code_before
stringlengths
16
1.81M
edits
stringlengths
4
328k
next_edit
stringlengths
0
76.5k
code_after
stringlengths
3
49.9M
label_window
sequencelengths
4
1.81k
instruction
stringlengths
20
51.9k
html_url
stringlengths
74
116
file_name
stringlengths
3
311
return nil, false, nil } if len(line) != 0 { patterns = append(patterns, filepath.Join(dirName, line)) } } return patterns, true, s.Err() }
</s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename) </s> remove patterns, cont, err = checkFile(c, src[i]) </s> add patterns, cont, err = checkFile(fsys, fw, src[i]) </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove subsrc, err = handlePatterns(srcSet, patterns...) </s> add subsrc, err = handlePatterns(fsys, srcSet, patterns...) </s> remove }).Walk("/etc/*release*") </s> add }).Walk(RootDirFS(), etcReleasePattern)
patterns = append(patterns, path.Join(".", line))
return nil, false, nil } if len(line) != 0 { patterns = append(patterns, path.Join(".", line)) } } return patterns, true, s.Err() }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
const nl = "\n" testCases := []struct { name string testFS testFSGen initPattern string want bool }{{ name: "simple", testFS: testFSGen{
</s> remove want bool </s> add name string </s> remove testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove const nl = "\n" </s> add </s> remove for _, pair := range []struct { </s> add for _, pair := range [...]struct { </s> remove filename: "/etc/dhcpcd.conf", </s> add filename: "etc/dhcpcd.conf",
testFS fstest.MapFS want assert.BoolAssertionFunc
const nl = "\n" testCases := []struct { testFS fstest.MapFS want assert.BoolAssertionFunc testFS fstest.MapFS want assert.BoolAssertionFunc initPattern string want bool }{{ name: "simple", testFS: testFSGen{
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
testCases := []struct { name string testFS testFSGen initPattern string want bool }{{ name: "simple", testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), },
</s> remove name string testFS testFSGen </s> add testFS fstest.MapFS want assert.BoolAssertionFunc </s> remove testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
name string
testCases := []struct { name string testFS testFSGen initPattern string name string }{{ name: "simple", testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), },
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
initPattern string want bool }{{ name: "simple", testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), }, initPattern: "simple_0001.txt", want: true, }, { name: "chain",
</s> remove want bool </s> add name string </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove name string testFS testFSGen </s> add testFS fstest.MapFS want assert.BoolAssertionFunc </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
initPattern string want bool }{{ name: "simple", testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, }, initPattern: "simple_0001.txt", want: true, }, { name: "chain",
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), }, initPattern: "simple_0001.txt", want: true, }, { name: "chain", testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl),
</s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl),
want: assert.True,
testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), }, initPattern: "simple_0001.txt", want: assert.True, }, { name: "chain", testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl),
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
initPattern: "simple_0001.txt", want: true, }, { name: "chain", testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), }, initPattern: "chain_0001.txt", want: true, }, { name: "several",
</s> remove want: true, </s> add want: assert.True, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl),
testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
initPattern: "simple_0001.txt", want: true, }, { name: "chain", testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, }, initPattern: "chain_0001.txt", want: true, }, { name: "several",
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
"chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), }, initPattern: "chain_0001.txt", want: true, }, { name: "several", testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl),
</s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove want: true, </s> add want: assert.True, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl),
want: assert.True,
"chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), }, initPattern: "chain_0001.txt", want: assert.True, }, { name: "several", testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl),
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
initPattern: "chain_0001.txt", want: true, }, { name: "several", testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), }, initPattern: "several_0001.txt", want: true, }, { name: "no",
</s> remove want: true, </s> add want: assert.True, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl),
testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
initPattern: "chain_0001.txt", want: true, }, { name: "several", testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, }, initPattern: "several_0001.txt", want: true, }, { name: "no",
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
"several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), }, initPattern: "several_0001.txt", want: true, }, { name: "no", testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl),
</s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), </s> add testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, </s> remove want: false, </s> add want: assert.False, </s> remove want: true, </s> add want: assert.True, </s> remove want: true, </s> add want: assert.True,
want: assert.True,
"several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), }, initPattern: "several_0001.txt", want: assert.True, }, { name: "no", testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl),
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
initPattern: "several_0001.txt", want: true, }, { name: "no", testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), }, initPattern: "no_*", want: false, }, { name: "subdirectory",
</s> remove want: false, </s> add want: assert.False, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove want: true, </s> add want: assert.True,
testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)},
initPattern: "several_0001.txt", want: true, }, { name: "no", testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, }, initPattern: "no_*", want: false, }, { name: "subdirectory",
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
"no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), }, initPattern: "no_*", want: false, }, { name: "subdirectory", testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl),
</s> remove testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), </s> add testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), </s> remove want: true, </s> add want: assert.True, </s> remove "subdir_0001.txt": []byte(`dir/*`), </s> add "subdir_0001.txt": &fstest.MapFile{Data: []byte(`dir/*`)}, </s> remove want: true, </s> add want: assert.True,
want: assert.False,
"no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), }, initPattern: "no_*", want: assert.False, }, { name: "subdirectory", testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl),
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
initPattern: "no_*", want: false, }, { name: "subdirectory", testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), }, "subdir_0001.txt": []byte(`dir/*`), }, initPattern: "subdir_0001.txt", want: true,
</s> remove "subdir_0001.txt": []byte(`dir/*`), </s> add "subdir_0001.txt": &fstest.MapFile{Data: []byte(`dir/*`)}, </s> remove want: false, </s> add want: assert.False, </s> remove testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), </s> add testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl),
initPattern: "no_*", want: false, }, { name: "subdirectory", testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), }, "subdir_0001.txt": []byte(`dir/*`), }, initPattern: "subdir_0001.txt", want: true,
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), }, "subdir_0001.txt": []byte(`dir/*`), }, initPattern: "subdir_0001.txt", want: true, }}
</s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), </s> remove want: false, </s> add want: assert.False, </s> remove want: true, </s> add want: assert.True, </s> remove want: true, </s> add want: assert.True, </s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)},
"subdir_0001.txt": &fstest.MapFile{Data: []byte(`dir/*`)},
testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), }, "subdir_0001.txt": &fstest.MapFile{Data: []byte(`dir/*`)}, }, initPattern: "subdir_0001.txt", want: true, }}
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
}, "subdir_0001.txt": []byte(`dir/*`), }, initPattern: "subdir_0001.txt", want: true, }} for _, tc := range testCases { testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir)
</s> remove testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) </s> add fw := makeFileWalker("") </s> remove "subdir_0001.txt": []byte(`dir/*`), </s> add "subdir_0001.txt": &fstest.MapFile{Data: []byte(`dir/*`)}, </s> remove testFS: testFSGen{ "dir": testFSDir{ "subdir_0002.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ path.Join("dir", "subdir_0002.txt"): &fstest.MapFile{ Data: []byte(attribute + nl), </s> remove ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) </s> add ok, err := fw.Walk(tc.testFS, tc.initPattern) </s> remove testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), </s> add testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)},
want: assert.True,
}, "subdir_0001.txt": []byte(`dir/*`), }, initPattern: "subdir_0001.txt", want: assert.True, }} for _, tc := range testCases { testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir)
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
want: true, }} for _, tc := range testCases { testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) t.Run(tc.name, func(t *testing.T) { ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) require.NoError(t, err)
</s> remove want: true, </s> add want: assert.True, </s> remove ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) </s> add ok, err := fw.Walk(tc.testFS, tc.initPattern) </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol")
fw := makeFileWalker("")
want: true, }} for _, tc := range testCases { fw := makeFileWalker("") fw := makeFileWalker("") t.Run(tc.name, func(t *testing.T) { ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) require.NoError(t, err)
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) t.Run(tc.name, func(t *testing.T) { ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) require.NoError(t, err) assert.Equal(t, tc.want, ok) }) }
</s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) </s> add fw := makeFileWalker("") </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol") </s> remove want: true, </s> add want: assert.True, </s> remove // TODO(e.burkov): Use assert.ErrorsIs within the error from // less platform-dependent package instead of syscall.EINVAL. // // See https://github.com/golang/go/issues/46849 and // https://github.com/golang/go/issues/30322. pathErr := &os.PathError{} require.ErrorAs(t, err, &pathErr) assert.Equal(t, "open", pathErr.Op) assert.Equal(t, badPath, pathErr.Path) </s> add }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok)
ok, err := fw.Walk(tc.testFS, tc.initPattern)
testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) t.Run(tc.name, func(t *testing.T) { ok, err := fw.Walk(tc.testFS, tc.initPattern) require.NoError(t, err) assert.Equal(t, tc.want, ok) }) }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
t.Run(tc.name, func(t *testing.T) { ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) require.NoError(t, err) assert.Equal(t, tc.want, ok) }) } t.Run("pattern_malformed", func(t *testing.T) { ok, err := makeFileWalker("").Walk("[]")
</s> remove ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) </s> add ok, err := fw.Walk(tc.testFS, tc.initPattern) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]") </s> remove testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) </s> add fw := makeFileWalker("") </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol") </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern)
tc.want(t, ok)
t.Run(tc.name, func(t *testing.T) { ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) require.NoError(t, err) tc.want(t, ok) }) } t.Run("pattern_malformed", func(t *testing.T) { ok, err := makeFileWalker("").Walk("[]")
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
}) } t.Run("pattern_malformed", func(t *testing.T) { ok, err := makeFileWalker("").Walk("[]") require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, filepath.ErrBadPattern) })
</s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename)
f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]")
}) } t.Run("pattern_malformed", func(t *testing.T) { f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]") require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, filepath.ErrBadPattern) })
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
ok, err := makeFileWalker("").Walk("[]") require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, filepath.ErrBadPattern) }) t.Run("bad_filename", func(t *testing.T) { dir := testFSGen{ "bad_filename.txt": []byte("[]"),
</s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]") </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove dir := testFSGen{ "bad_filename.txt": []byte("[]"), }.gen(t) fw := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> add const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename)
assert.ErrorIs(t, err, path.ErrBadPattern)
ok, err := makeFileWalker("").Walk("[]") require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, path.ErrBadPattern) }) t.Run("bad_filename", func(t *testing.T) { dir := testFSGen{ "bad_filename.txt": []byte("[]"),
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
assert.ErrorIs(t, err, filepath.ErrBadPattern) }) t.Run("bad_filename", func(t *testing.T) { dir := testFSGen{ "bad_filename.txt": []byte("[]"), }.gen(t) fw := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { s := bufio.NewScanner(r) for s.Scan() { patterns = append(patterns, s.Text()) }
</s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove makeFileWalker := func(dirName string) (fw FileWalker) { </s> add makeFileWalker := func(_ string) (fw FileWalker) { </s> remove }).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) </s> add }).Walk(f, "*") require.ErrorIs(t, err, rerr) </s> remove dir := testFSGen{ "mockfile.txt": []byte(`mockdata`), }.gen(t) </s> add f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } </s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename)
const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) {
assert.ErrorIs(t, err, filepath.ErrBadPattern) }) t.Run("bad_filename", func(t *testing.T) { const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { s := bufio.NewScanner(r) for s.Scan() { patterns = append(patterns, s.Text()) }
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
patterns = append(patterns, s.Text()) } return patterns, true, s.Err() }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, filepath.ErrBadPattern) })
</s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]") </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove patterns = append(patterns, filepath.Join(dirName, line)) </s> add patterns = append(patterns, path.Join(".", line))
}).Walk(f, filename)
patterns = append(patterns, s.Text()) } return patterns, true, s.Err() }).Walk(f, filename) }).Walk(f, filename) }).Walk(f, filename) require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, filepath.ErrBadPattern) })
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, filepath.ErrBadPattern) }) t.Run("itself_error", func(t *testing.T) { const rerr errors.Error = "returned error"
</s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename) </s> remove dir := testFSGen{ "mockfile.txt": []byte(`mockdata`), }.gen(t) </s> add f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]") </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok)
assert.ErrorIs(t, err, path.ErrBadPattern)
ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) require.Error(t, err) assert.False(t, ok) assert.ErrorIs(t, err, path.ErrBadPattern) }) t.Run("itself_error", func(t *testing.T) { const rerr errors.Error = "returned error"
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
t.Run("itself_error", func(t *testing.T) { const rerr errors.Error = "returned error" dir := testFSGen{ "mockfile.txt": []byte(`mockdata`), }.gen(t) ok, err := FileWalker(func(r io.Reader) (patterns []string, ok bool, err error) { return nil, true, rerr }).Walk(filepath.Join(dir, "*")) require.Error(t, err)
</s> remove }).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) </s> add }).Walk(f, "*") require.ErrorIs(t, err, rerr) </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove dir := testFSGen{ "bad_filename.txt": []byte("[]"), }.gen(t) fw := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> add const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern)
f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, }
t.Run("itself_error", func(t *testing.T) { const rerr errors.Error = "returned error" f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, ok bool, err error) { return nil, true, rerr }).Walk(filepath.Join(dir, "*")) require.Error(t, err)
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
}.gen(t) ok, err := FileWalker(func(r io.Reader) (patterns []string, ok bool, err error) { return nil, true, rerr }).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) assert.ErrorIs(t, err, rerr) }) }
</s> remove dir := testFSGen{ "mockfile.txt": []byte(`mockdata`), }.gen(t) </s> add f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove dir := testFSGen{ "bad_filename.txt": []byte("[]"), }.gen(t) fw := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> add const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename)
}).Walk(f, "*") require.ErrorIs(t, err, rerr)
}.gen(t) ok, err := FileWalker(func(r io.Reader) (patterns []string, ok bool, err error) { return nil, true, rerr }).Walk(f, "*") require.ErrorIs(t, err, rerr) }).Walk(f, "*") require.ErrorIs(t, err, rerr) }).Walk(f, "*") require.ErrorIs(t, err, rerr) assert.ErrorIs(t, err, rerr) }) }
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
}).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) assert.ErrorIs(t, err, rerr) }) } func TestWalkerFunc_CheckFile(t *testing.T) { t.Run("non-existing", func(t *testing.T) {
</s> remove }).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) </s> add }).Walk(f, "*") require.ErrorIs(t, err, rerr) </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol") </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]")
assert.False(t, ok)
}).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) assert.False(t, ok) }) } func TestWalkerFunc_CheckFile(t *testing.T) { t.Run("non-existing", func(t *testing.T) {
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
} func TestWalkerFunc_CheckFile(t *testing.T) { emptyFS := fstest.MapFS{} t.Run("non-existing", func(t *testing.T) { _, ok, err := checkFile(emptyFS, nil, "lol") require.NoError(t, err)
</s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol") </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]")
type errFS struct { fs.GlobFS } const errErrFSOpen errors.Error = "this error is always returned" func (efs *errFS) Open(name string) (fs.File, error) { return nil, errErrFSOpen }
} type errFS struct { fs.GlobFS } const errErrFSOpen errors.Error = "this error is always returned" func (efs *errFS) Open(name string) (fs.File, error) { return nil, errErrFSOpen } func TestWalkerFunc_CheckFile(t *testing.T) { emptyFS := fstest.MapFS{} t.Run("non-existing", func(t *testing.T) { _, ok, err := checkFile(emptyFS, nil, "lol") require.NoError(t, err)
[ "keep", "add", "keep", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
return nil, errErrFSOpen } func TestWalkerFunc_CheckFile(t *testing.T) { t.Run("non-existing", func(t *testing.T) { _, ok, err := checkFile(emptyFS, nil, "lol") require.NoError(t, err) assert.True(t, ok)
</s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol") </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove const badPath = "\x00" _, ok, err := checkFile(nil, badPath) require.Error(t, err) </s> add _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen)
emptyFS := fstest.MapFS{}
return nil, errErrFSOpen } func TestWalkerFunc_CheckFile(t *testing.T) { emptyFS := fstest.MapFS{} t.Run("non-existing", func(t *testing.T) { _, ok, err := checkFile(emptyFS, nil, "lol") require.NoError(t, err) assert.True(t, ok)
[ "keep", "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
} func TestWalkerFunc_CheckFile(t *testing.T) { t.Run("non-existing", func(t *testing.T) { _, ok, err := checkFile(nil, "lol") require.NoError(t, err) assert.True(t, ok) })
</s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove const badPath = "\x00" _, ok, err := checkFile(nil, badPath) require.Error(t, err) </s> add _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen)
_, ok, err := checkFile(emptyFS, nil, "lol")
} func TestWalkerFunc_CheckFile(t *testing.T) { t.Run("non-existing", func(t *testing.T) { _, ok, err := checkFile(emptyFS, nil, "lol") require.NoError(t, err) assert.True(t, ok) })
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
assert.True(t, ok) }) t.Run("invalid_argument", func(t *testing.T) { const badPath = "\x00" _, ok, err := checkFile(nil, badPath) require.Error(t, err) assert.False(t, ok) // TODO(e.burkov): Use assert.ErrorsIs within the error from // less platform-dependent package instead of syscall.EINVAL. //
</s> remove // TODO(e.burkov): Use assert.ErrorsIs within the error from // less platform-dependent package instead of syscall.EINVAL. // // See https://github.com/golang/go/issues/46849 and // https://github.com/golang/go/issues/30322. pathErr := &os.PathError{} require.ErrorAs(t, err, &pathErr) assert.Equal(t, "open", pathErr.Op) assert.Equal(t, badPath, pathErr.Path) </s> add }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol") </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove assert.ErrorIs(t, err, rerr) </s> add assert.False(t, ok) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]")
_, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen)
assert.True(t, ok) }) t.Run("invalid_argument", func(t *testing.T) { _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen) _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen) _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen) _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen) assert.False(t, ok) // TODO(e.burkov): Use assert.ErrorsIs within the error from // less platform-dependent package instead of syscall.EINVAL. //
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
_, ok, err := checkFile(nil, badPath) require.Error(t, err) assert.False(t, ok) // TODO(e.burkov): Use assert.ErrorsIs within the error from // less platform-dependent package instead of syscall.EINVAL. // // See https://github.com/golang/go/issues/46849 and // https://github.com/golang/go/issues/30322. pathErr := &os.PathError{} require.ErrorAs(t, err, &pathErr) assert.Equal(t, "open", pathErr.Op) assert.Equal(t, badPath, pathErr.Path) }) }
</s> remove const badPath = "\x00" _, ok, err := checkFile(nil, badPath) require.Error(t, err) </s> add _, ok, err := checkFile(&errFS{}, nil, "") require.ErrorIs(t, err, errErrFSOpen) </s> remove ok, err := makeFileWalker("").Walk("[]") </s> add f := fstest.MapFS{} ok, err := makeFileWalker("").Walk(f, "[]") </s> remove }) ok, err := fw.Walk(filepath.Join(dir, "bad_filename.txt")) </s> add }).Walk(f, filename) </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern) </s> remove assert.ErrorIs(t, err, filepath.ErrBadPattern) </s> add assert.ErrorIs(t, err, path.ErrBadPattern)
}) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok)
_, ok, err := checkFile(nil, badPath) require.Error(t, err) assert.False(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) }) }
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/filewalker_test.go
"fmt" "io" "os/exec" "path" "runtime" "strconv" "strings"
</s> remove "os" "path/filepath" </s> add "path" </s> remove "os" "path/filepath" </s> add "io/fs" </s> remove "os" </s> add
"io/fs" "os"
"fmt" "io" "io/fs" "os" "os/exec" "path" "runtime" "strconv" "strings"
[ "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/os.go
} func isOpenWrt() (ok bool) { var err error ok, err = FileWalker(func(r io.Reader) (_ []string, cont bool, err error) { const osNameData = "openwrt" // This use of ReadAll is now safe, because FileWalker's Walk()
</s> remove dir := testFSGen{ "bad_filename.txt": []byte("[]"), }.gen(t) fw := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> add const filename = "bad_filename.txt" f := fstest.MapFS{ filename: &fstest.MapFile{Data: []byte("[]")}, } ok, err := FileWalker(func(r io.Reader) (patterns []string, cont bool, err error) { </s> remove return aghos.FileWalker(interfaceName(ifaceName).rcConfStaticConfig).Walk(filename) </s> add walker := aghos.FileWalker(interfaceName(ifaceName).rcConfStaticConfig) return walker.Walk(aghos.RootDirFS(), rcConfFilename) </s> remove return aghos.FileWalker(hostnameIfStaticConfig).Walk(filename) </s> add return aghos.FileWalker(hostnameIfStaticConfig).Walk(aghos.RootDirFS(), filename) </s> remove dir := testFSGen{ "mockfile.txt": []byte(`mockdata`), }.gen(t) </s> add f := fstest.MapFS{ "mockfile.txt": &fstest.MapFile{Data: []byte(`mockdata`)}, } </s> remove }).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) </s> add }).Walk(f, "*") require.ErrorIs(t, err, rerr)
const etcReleasePattern = "etc/*release*"
} func isOpenWrt() (ok bool) { const etcReleasePattern = "etc/*release*" var err error ok, err = FileWalker(func(r io.Reader) (_ []string, cont bool, err error) { const osNameData = "openwrt" // This use of ReadAll is now safe, because FileWalker's Walk()
[ "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/os_linux.go
return nil, false, err } return nil, !stringutil.ContainsFold(string(data), osNameData), nil }).Walk("/etc/*release*") return err == nil && ok }
</s> remove patterns = append(patterns, filepath.Join(dirName, line)) </s> add patterns = append(patterns, path.Join(".", line)) </s> remove if errors.Is(err, os.ErrNotExist) { // Ignore non-existing files since this may only happen // when the file was removed after filepath.Glob matched // it. </s> add if errors.Is(err, fs.ErrNotExist) { // Ignore non-existing files since this may only happen when the // file was removed after filepath.Glob matched it. </s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things. </s> remove }).Walk(filepath.Join(dir, "*")) require.Error(t, err) require.False(t, ok) </s> add }).Walk(f, "*") require.ErrorIs(t, err, rerr) </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil {
}).Walk(RootDirFS(), etcReleasePattern)
return nil, false, err } return nil, !stringutil.ContainsFold(string(data), osNameData), nil }).Walk(RootDirFS(), etcReleasePattern) return err == nil && ok }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/aghos/os_linux.go
"encoding/pem" "fmt" "math/big" "net" "os" "sync" "testing" "time" "github.com/AdguardTeam/AdGuardHome/internal/aghnet"
</s> remove "os" "path/filepath" </s> add "io/fs"
"encoding/pem" "fmt" "math/big" "net" "sync" "testing" "time" "github.com/AdguardTeam/AdGuardHome/internal/aghnet"
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
"fmt" "math/big" "net" "sync" "testing" "testing/fstest" "time"
</s> remove "os" </s> add
"sync/atomic"
"fmt" "math/big" "net" "sync" "sync/atomic" "testing" "testing/fstest" "time"
[ "keep", "keep", "keep", "add", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
"net" "sync" "sync/atomic" "testing" "time" "github.com/AdguardTeam/AdGuardHome/internal/aghnet" "github.com/AdguardTeam/AdGuardHome/internal/aghtest" "github.com/AdguardTeam/AdGuardHome/internal/dhcpd"
</s> remove "os" </s> add </s> remove "os" "path/filepath" </s> add "path"
"testing/fstest"
"net" "sync" "sync/atomic" "testing" "testing/fstest" "time" "github.com/AdguardTeam/AdGuardHome/internal/aghnet" "github.com/AdguardTeam/AdGuardHome/internal/aghtest" "github.com/AdguardTeam/AdGuardHome/internal/dhcpd"
[ "keep", "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
assert.Equal(t, "myhost.", ptr.Ptr) } func TestPTRResponseFromHosts(t *testing.T) { c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, } // Prepare test hosts file. hf, err := os.CreateTemp("", "") require.NoError(t, err)
</s> remove // Prepare test hosts file. hf, err := os.CreateTemp("", "") </s> add const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename) </s> remove assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) </s> add assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) </s> remove c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) </s> add c := filtering.Config{ EtcHosts: hc, } </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) </s> add ok, err := fw.Walk(tc.testFS, tc.initPattern)
// Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)},
assert.Equal(t, "myhost.", ptr.Ptr) } func TestPTRResponseFromHosts(t *testing.T) { // Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)}, // Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)}, } // Prepare test hosts file. hf, err := os.CreateTemp("", "") require.NoError(t, err)
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, } // Prepare test hosts file. hf, err := os.CreateTemp("", "") require.NoError(t, err) t.Cleanup(func() { assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) })
</s> remove assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) </s> add assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) </s> remove c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, </s> add // Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)}, </s> remove _, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") </s> add require.ErrorIs(t, hc.Close(), closeCalled) }) </s> remove c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) </s> add c := filtering.Config{ EtcHosts: hc, } </s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok)
const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename)
c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, } const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename) const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename) require.NoError(t, err) t.Cleanup(func() { assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) })
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
// Prepare test hosts file. hf, err := os.CreateTemp("", "") require.NoError(t, err) t.Cleanup(func() { assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) _, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") c.EtcHosts.Init(hf.Name())
</s> remove _, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") </s> add require.ErrorIs(t, hc.Close(), closeCalled) }) </s> remove c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) </s> add c := filtering.Config{ EtcHosts: hc, } </s> remove c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, </s> add // Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)}, </s> remove // Prepare test hosts file. hf, err := os.CreateTemp("", "") </s> add const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename) </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol")
assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter))
// Prepare test hosts file. hf, err := os.CreateTemp("", "") require.NoError(t, err) t.Cleanup(func() { assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) _, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") c.EtcHosts.Init(hf.Name())
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) _, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) var snd *aghnet.SubnetDetector
</s> remove assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) </s> add assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) </s> remove c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) </s> add c := filtering.Config{ EtcHosts: hc, } </s> remove c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, </s> add // Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)}, </s> remove // Prepare test hosts file. hf, err := os.CreateTemp("", "") </s> add const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename)
require.ErrorIs(t, hc.Close(), closeCalled) })
assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) require.ErrorIs(t, hc.Close(), closeCalled) }) require.ErrorIs(t, hc.Close(), closeCalled) }) c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) var snd *aghnet.SubnetDetector
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
_, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") c.EtcHosts.Init(hf.Name()) t.Cleanup(c.EtcHosts.Close) var snd *aghnet.SubnetDetector snd, err = aghnet.NewSubnetDetector() require.NoError(t, err) require.NotNil(t, snd)
</s> remove _, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") </s> add require.ErrorIs(t, hc.Close(), closeCalled) }) </s> remove assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) </s> add assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) </s> remove c := filtering.Config{ EtcHosts: &aghnet.EtcHostsContainer{}, </s> add // Prepare test hosts file. const hostsFilename = "hosts" testFS := fstest.MapFS{ hostsFilename: &fstest.MapFile{Data: []byte(` 127.0.0.1 host # comment ::1 localhost#comment `)}, </s> remove _, ok, err := checkFile(nil, "lol") </s> add _, ok, err := checkFile(emptyFS, nil, "lol")
c := filtering.Config{ EtcHosts: hc, }
_, _ = hf.WriteString(" 127.0.0.1 host # comment \n") _, _ = hf.WriteString(" ::1 localhost#comment \n") c := filtering.Config{ EtcHosts: hc, } c := filtering.Config{ EtcHosts: hc, } var snd *aghnet.SubnetDetector snd, err = aghnet.NewSubnetDetector() require.NoError(t, err) require.NotNil(t, snd)
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
resp, err := dns.Exchange(req, addr.String()) require.NoError(t, err) require.Len(t, resp.Answer, 1) assert.Equal(t, dns.TypePTR, resp.Answer[0].Header().Rrtype) assert.Equal(t, "1.0.0.127.in-addr.arpa.", resp.Answer[0].Header().Name) ptr, ok := resp.Answer[0].(*dns.PTR)
</s> remove assert.Equal(t, tc.want, ok) </s> add tc.want(t, ok) </s> remove ok, err := fw.Walk(filepath.Join(testDir, tc.initPattern)) </s> add ok, err := fw.Walk(tc.testFS, tc.initPattern) </s> remove // TODO(e.burkov): Use assert.ErrorsIs within the error from // less platform-dependent package instead of syscall.EINVAL. // // See https://github.com/golang/go/issues/46849 and // https://github.com/golang/go/issues/30322. pathErr := &os.PathError{} require.ErrorAs(t, err, &pathErr) assert.Equal(t, "open", pathErr.Op) assert.Equal(t, badPath, pathErr.Path) </s> add }) t.Run("ignore_dirs", func(t *testing.T) { const dirName = "dir" testFS := fstest.MapFS{ path.Join(dirName, "file"): &fstest.MapFile{Data: []byte{}}, } patterns, ok, err := checkFile(testFS, nil, dirName) require.NoError(t, err) assert.Empty(t, patterns) assert.True(t, ok) </s> remove assert.NoError(t, hf.Close()) assert.NoError(t, os.Remove(hf.Name())) }) </s> add assert.Equal(t, uint32(1), atomic.LoadUint32(&eventsCalledCounter)) </s> remove // Prepare test hosts file. hf, err := os.CreateTemp("", "") </s> add const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename)
require.Lenf(t, resp.Answer, 1, "%#v", resp)
resp, err := dns.Exchange(req, addr.String()) require.NoError(t, err) require.Lenf(t, resp.Answer, 1, "%#v", resp) assert.Equal(t, dns.TypePTR, resp.Answer[0].Header().Rrtype) assert.Equal(t, "1.0.0.127.in-addr.arpa.", resp.Answer[0].Header().Name) ptr, ok := resp.Answer[0].(*dns.PTR)
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/dnsforward/dnsforward_test.go
// DNSRewriteResultResponse is the collection of DNS response records // the server returns. type DNSRewriteResultResponse map[rules.RRType][]rules.RRValue // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. func (d *DNSFilter) processDNSRewrites(dnsr []*rules.NetworkRule) (res Result) { if len(dnsr) == 0 { return Result{} }
</s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things. </s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil {
// processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// DNSRewriteResultResponse is the collection of DNS response records // the server returns. type DNSRewriteResultResponse map[rules.RRType][]rules.RRValue // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set. // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set. // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set. func (d *DNSFilter) processDNSRewrites(dnsr []*rules.NetworkRule) (res Result) { if len(dnsr) == 0 { return Result{} }
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/dnsrewrite.go
BlockedServices []string `yaml:"blocked_services"` // EtcHosts is a container of IP-hostname pairs taken from the operating // system configuration files (e.g. /etc/hosts). EtcHosts *aghnet.EtcHostsContainer `yaml:"-"` // Called when the configuration is changed by HTTP request ConfigModified func() `yaml:"-"` // Register an HTTP handler
</s> remove clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module etcHosts *aghnet.EtcHostsContainer // IP-hostname pairs taken from system configuration (e.g. /etc/hosts) files updater *updater.Updater </s> add clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater </s> remove etcHosts *aghnet.EtcHostsContainer // get entries from system hosts-files </s> add // etcHosts contains list of rewrite rules taken from the operating system's // hosts databse. etcHosts *aghnet.HostsContainer </s> remove // AddHost adds a new IP-hostname pairing. The priorities of the sources is </s> add // AddHost adds a new IP-hostname pairing. The priorities of the sources are </s> remove // Rewritten is returned when there was a rewrite by a legacy DNS // rewrite rule. </s> add // Rewritten is returned when there was a rewrite by a legacy DNS rewrite // rule. </s> remove // should be valid for filepath.Glob. If cont is false, the walking terminates. // Each opened file is also limited for reading to MaxWalkedFileSize. </s> add // should be valid for fs.Glob. If cont is false, the walking terminates. Each // opened file is also limited for reading to MaxWalkedFileSize.
EtcHosts *aghnet.HostsContainer `yaml:"-"`
BlockedServices []string `yaml:"blocked_services"` // EtcHosts is a container of IP-hostname pairs taken from the operating // system configuration files (e.g. /etc/hosts). EtcHosts *aghnet.HostsContainer `yaml:"-"` // Called when the configuration is changed by HTTP request ConfigModified func() `yaml:"-"` // Register an HTTP handler
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
FilteredSafeSearch // FilteredBlockedService - the host is blocked by "blocked services" settings FilteredBlockedService // Rewritten is returned when there was a rewrite by a legacy DNS // rewrite rule. Rewritten // RewrittenAutoHosts is returned when there was a rewrite by autohosts // rules (/etc/hosts and so on). RewrittenAutoHosts
</s> remove // TODO(a.garipov): Remove Rewritten and RewrittenAutoHosts by merging // their functionality into RewrittenRule. </s> add // TODO(a.garipov): Remove Rewritten and RewrittenAutoHosts by merging their // functionality into RewrittenRule. </s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things. </s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove EtcHosts *aghnet.EtcHostsContainer `yaml:"-"` </s> add EtcHosts *aghnet.HostsContainer `yaml:"-"`
// Rewritten is returned when there was a rewrite by a legacy DNS rewrite // rule.
FilteredSafeSearch // FilteredBlockedService - the host is blocked by "blocked services" settings FilteredBlockedService // Rewritten is returned when there was a rewrite by a legacy DNS rewrite // rule. // Rewritten is returned when there was a rewrite by a legacy DNS rewrite // rule. Rewritten // RewrittenAutoHosts is returned when there was a rewrite by autohosts // rules (/etc/hosts and so on). RewrittenAutoHosts
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
RewrittenAutoHosts // RewrittenRule is returned when a $dnsrewrite filter rule was applied. // // TODO(a.garipov): Remove Rewritten and RewrittenAutoHosts by merging // their functionality into RewrittenRule. // // See https://github.com/AdguardTeam/AdGuardHome/issues/2499. RewrittenRule )
</s> remove // Rewritten is returned when there was a rewrite by a legacy DNS // rewrite rule. </s> add // Rewritten is returned when there was a rewrite by a legacy DNS rewrite // rule. </s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things.
// TODO(a.garipov): Remove Rewritten and RewrittenAutoHosts by merging their // functionality into RewrittenRule.
RewrittenAutoHosts // RewrittenRule is returned when a $dnsrewrite filter rule was applied. // // TODO(a.garipov): Remove Rewritten and RewrittenAutoHosts by merging their // functionality into RewrittenRule. // TODO(a.garipov): Remove Rewritten and RewrittenAutoHosts by merging their // functionality into RewrittenRule. // // See https://github.com/AdguardTeam/AdGuardHome/issues/2499. RewrittenRule )
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// Reason is the reason for blocking or unblocking the request. Reason Reason `json:",omitempty"` // Rules are applied rules. If Rules are not empty, each rule // is not nil. Rules []*ResultRule `json:",omitempty"` // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. ReverseHosts []string `json:",omitempty"`
</s> remove // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. </s> add // ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts. </s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// Rules are applied rules. If Rules are not empty, each rule is not nil.
// Reason is the reason for blocking or unblocking the request. Reason Reason `json:",omitempty"` // Rules are applied rules. If Rules are not empty, each rule is not nil. // Rules are applied rules. If Rules are not empty, each rule is not nil. Rules []*ResultRule `json:",omitempty"` // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. ReverseHosts []string `json:",omitempty"`
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// Rules are applied rules. If Rules are not empty, each rule // is not nil. Rules []*ResultRule `json:",omitempty"` // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. ReverseHosts []string `json:",omitempty"` // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. IPList []net.IP `json:",omitempty"`
</s> remove // Rules are applied rules. If Rules are not empty, each rule // is not nil. </s> add // Rules are applied rules. If Rules are not empty, each rule is not nil. </s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts.
// Rules are applied rules. If Rules are not empty, each rule // is not nil. Rules []*ResultRule `json:",omitempty"` // ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts. // ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts. ReverseHosts []string `json:",omitempty"` // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. IPList []net.IP `json:",omitempty"`
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. ReverseHosts []string `json:",omitempty"` // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. IPList []net.IP `json:",omitempty"` // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. CanonName string `json:",omitempty"`
</s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. </s> add // ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts. </s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // Rules are applied rules. If Rules are not empty, each rule // is not nil. </s> add // Rules are applied rules. If Rules are not empty, each rule is not nil. </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten.
// ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. ReverseHosts []string `json:",omitempty"` // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. IPList []net.IP `json:",omitempty"` // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. CanonName string `json:",omitempty"`
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. IPList []net.IP `json:",omitempty"` // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. CanonName string `json:",omitempty"` // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. ServiceName string `json:",omitempty"`
</s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. </s> add // ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts. </s> remove // Rules are applied rules. If Rules are not empty, each rule // is not nil. </s> add // Rules are applied rules. If Rules are not empty, each rule is not nil. </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule.
// IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. IPList []net.IP `json:",omitempty"` // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. CanonName string `json:",omitempty"` // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. ServiceName string `json:",omitempty"`
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. CanonName string `json:",omitempty"` // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. ServiceName string `json:",omitempty"` // DNSRewriteResult is the $dnsrewrite filter rule result. DNSRewriteResult *DNSRewriteResult `json:",omitempty"` }
</s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // IPList is the lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts or Rewritten. </s> add // IPList is the lookup rewrite result. It is empty unless Reason is set to // RewrittenAutoHosts or Rewritten. </s> remove // ReverseHosts is the reverse lookup rewrite result. It is // empty unless Reason is set to RewrittenAutoHosts. </s> add // ReverseHosts is the reverse lookup rewrite result. It is empty unless // Reason is set to RewrittenAutoHosts. </s> remove // Rules are applied rules. If Rules are not empty, each rule // is not nil. </s> add // Rules are applied rules. If Rules are not empty, each rule is not nil. </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService.
// CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. CanonName string `json:",omitempty"` // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. ServiceName string `json:",omitempty"` // DNSRewriteResult is the $dnsrewrite filter rule result. DNSRewriteResult *DNSRewriteResult `json:",omitempty"` }
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
return Result{}, nil } // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { return Result{}, nil } ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil {
</s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things. </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove return res, nil </s> add switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) } </s> remove revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{ Reason: RewrittenAutoHosts, } </s> add var ips []net.IP var revHosts []string
// matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil {
return Result{}, nil } // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { return Result{}, nil } ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil {
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
if d.Config.EtcHosts == nil { return Result{}, nil } ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } return res, nil } revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype)
</s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{ Reason: RewrittenAutoHosts, } </s> add var ips []net.IP var revHosts []string </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove return res, nil </s> add switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) }
dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, })
if d.Config.EtcHosts == nil { return Result{}, nil } dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) return res, nil } revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype)
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
Reason: RewrittenAutoHosts, IPList: ips, } return res, nil } revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{
</s> remove revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{ Reason: RewrittenAutoHosts, } </s> add var ips []net.IP var revHosts []string </s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove return Result{}, nil </s> add return Result{ Reason: RewrittenAutoHosts, IPList: ips, ReverseHosts: revHosts, }, nil </s> remove return res, nil </s> add switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) }
dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil
Reason: RewrittenAutoHosts, IPList: ips, } dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil } revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
return res, nil } revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{ Reason: RewrittenAutoHosts, } // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "."
</s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove return res, nil </s> add switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) } </s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove return Result{}, nil </s> add return Result{ Reason: RewrittenAutoHosts, IPList: ips, ReverseHosts: revHosts, }, nil
var ips []net.IP var revHosts []string
return res, nil } var ips []net.IP var revHosts []string var ips []net.IP var revHosts []string var ips []net.IP var revHosts []string var ips []net.IP var revHosts []string var ips []net.IP var revHosts []string // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "."
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
res = Result{ Reason: RewrittenAutoHosts, } // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." } return res, nil }
</s> remove revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{ Reason: RewrittenAutoHosts, } </s> add var ips []net.IP var revHosts []string </s> remove return res, nil </s> add switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) } </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove return Result{}, nil </s> add return Result{ Reason: RewrittenAutoHosts, IPList: ips, ReverseHosts: revHosts, }, nil
for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue
res = Result{ Reason: RewrittenAutoHosts, } for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue } return res, nil }
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." } return res, nil } return Result{}, nil }
</s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove revHosts := d.Config.EtcHosts.ProcessReverse(host, qtype) if len(revHosts) != 0 { res = Result{ Reason: RewrittenAutoHosts, } </s> add var ips []net.IP var revHosts []string </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove return Result{}, nil </s> add return Result{ Reason: RewrittenAutoHosts, IPList: ips, ReverseHosts: revHosts, }, nil
switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) }
for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." } switch val := nr.DNSRewrite.Value.(type) { case net.IP: ips = append(ips, val) case string: revHosts = append(revHosts, val) } } return Result{}, nil }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
return res, nil } return Result{}, nil } // Process rewrites table // . Find CNAME for a domain name (exact match or by wildcard) // . if found and CNAME equals to domain name - this is an exception; exit
</s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things. </s> remove // ServiceName is the name of the blocked service. It is empty // unless Reason is set to FilteredBlockedService. </s> add // ServiceName is the name of the blocked service. It is empty unless // Reason is set to FilteredBlockedService. </s> remove // CanonName is the CNAME value from the lookup rewrite result. // It is empty unless Reason is set to Rewritten or RewrittenRule. </s> add // CanonName is the CNAME value from the lookup rewrite result. It is empty // unless Reason is set to Rewritten or RewrittenRule. </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue
return Result{ Reason: RewrittenAutoHosts, IPList: ips, ReverseHosts: revHosts, }, nil
return res, nil } return Result{ Reason: RewrittenAutoHosts, IPList: ips, ReverseHosts: revHosts, }, nil } // Process rewrites table // . Find CNAME for a domain name (exact match or by wildcard) // . if found and CNAME equals to domain name - this is an exception; exit
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
if err != nil { return err } d.engineLock.Lock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow d.engineLock.Unlock() // Make sure that the OS reclaims memory as soon as possible debug.FreeOSMemory() log.Debug("initialized filtering engine")
</s> remove // Make sure that the OS reclaims memory as soon as possible </s> add // Make sure that the OS reclaims memory as soon as possible. </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } }
func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }()
if err != nil { return err } func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() // Make sure that the OS reclaims memory as soon as possible debug.FreeOSMemory() log.Debug("initialized filtering engine")
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow d.engineLock.Unlock() // Make sure that the OS reclaims memory as soon as possible debug.FreeOSMemory() log.Debug("initialized filtering engine") return nil }
</s> remove d.engineLock.Lock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow d.engineLock.Unlock() </s> add func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }() </s> remove d.engineLock.RLock() // Keep in mind that this lock must be held no just when calling Match() // but also while using the rules returned by it. defer d.engineLock.RUnlock() </s> add </s> remove // Ignore the error since LimitReader function returns error only if // passed limit value is less than zero, but the constant used. </s> add // Ignore the error since LimitReader function returns error only if passed // limit value is less than zero, but the constant used.
// Make sure that the OS reclaims memory as soon as possible.
d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow d.engineLock.Unlock() // Make sure that the OS reclaims memory as soon as possible. debug.FreeOSMemory() log.Debug("initialized filtering engine") return nil }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
return res } if dnsres.HostRulesV4 != nil || dnsres.HostRulesV6 != nil { // Question type doesn't match the host rules. Return the first // matched host rule, but without an IP address. var matchedRules []rules.Rule if dnsres.HostRulesV4 != nil { matchedRules = []rules.Rule{dnsres.HostRulesV4[0]} } else if dnsres.HostRulesV6 != nil { matchedRules = []rules.Rule{dnsres.HostRulesV6[0]}
</s> remove // A rewrite of a host to itself. Go on and try // matching other things. </s> add // A rewrite of a host to itself. Go on and try matching other // things. </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil
// Question type doesn't match the host rules. Return the first matched // host rule, but without an IP address.
return res } if dnsres.HostRulesV4 != nil || dnsres.HostRulesV6 != nil { // Question type doesn't match the host rules. Return the first matched // host rule, but without an IP address. // Question type doesn't match the host rules. Return the first matched // host rule, but without an IP address. var matchedRules []rules.Rule if dnsres.HostRulesV4 != nil { matchedRules = []rules.Rule{dnsres.HostRulesV4[0]} } else if dnsres.HostRulesV6 != nil { matchedRules = []rules.Rule{dnsres.HostRulesV6[0]}
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
if !setts.FilteringEnabled { return Result{}, nil } d.engineLock.RLock() // Keep in mind that this lock must be held no just when calling Match() // but also while using the rules returned by it. defer d.engineLock.RUnlock() ureq := urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(),
</s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove // handlePatterns parses the patterns and ignores duplicates using srcSet. // srcSet must be non-nil. func handlePatterns(srcSet *stringutil.Set, patterns ...string) (sub []string, err error) { </s> add // handlePatterns parses the patterns in fsys and ignores duplicates using // srcSet. srcSet must be non-nil. func handlePatterns( fsys fs.FS, srcSet *stringutil.Set, patterns ...string, ) (sub []string, err error) { </s> remove // should be valid for filepath.Glob. If cont is false, the walking terminates. // Each opened file is also limited for reading to MaxWalkedFileSize. </s> add // should be valid for fs.Glob. If cont is false, the walking terminates. Each // opened file is also limited for reading to MaxWalkedFileSize. </s> remove // TODO(e.burkov): Consider moving to the separate package like pathutil. </s> add // TODO(e.burkov, a.garipov): Move into another package like aghfs.
if !setts.FilteringEnabled { return Result{}, nil } ureq := urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(),
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
} if d.filteringEngineAllow != nil { dnsres, ok := d.filteringEngineAllow.MatchRequest(ureq) if ok { return d.matchHostProcessAllowList(host, dnsres) } }
</s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, }) </s> remove }).Walk("/etc/*release*") </s> add }).Walk(RootDirFS(), etcReleasePattern) </s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } </s> remove if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { </s> add if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil {
d.engineLock.RLock() // Keep in mind that this lock must be held no just when calling Match() but // also while using the rules returned by it. // // TODO(e.burkov): Inspect if the above is true. defer d.engineLock.RUnlock()
} d.engineLock.RLock() // Keep in mind that this lock must be held no just when calling Match() but // also while using the rules returned by it. // // TODO(e.burkov): Inspect if the above is true. defer d.engineLock.RUnlock() if d.filteringEngineAllow != nil { dnsres, ok := d.filteringEngineAllow.MatchRequest(ureq) if ok { return d.matchHostProcessAllowList(host, dnsres) } }
[ "keep", "add", "keep", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// Check DNS rewrites first, because the API there is a bit awkward. if dnsr := dnsres.DNSRewrites(); len(dnsr) > 0 { res = d.processDNSRewrites(dnsr) if res.Reason == RewrittenRule && res.CanonName == host { // A rewrite of a host to itself. Go on and try // matching other things. } else { return res, nil } } else if !ok { return Result{}, nil
</s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove // Question type doesn't match the host rules. Return the first // matched host rule, but without an IP address. </s> add // Question type doesn't match the host rules. Return the first matched // host rule, but without an IP address. </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set.
// A rewrite of a host to itself. Go on and try matching other // things.
// Check DNS rewrites first, because the API there is a bit awkward. if dnsr := dnsres.DNSRewrites(); len(dnsr) > 0 { res = d.processDNSRewrites(dnsr) if res.Reason == RewrittenRule && res.CanonName == host { // A rewrite of a host to itself. Go on and try matching other // things. // A rewrite of a host to itself. Go on and try matching other // things. } else { return res, nil } } else if !ok { return Result{}, nil
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
resolver: resolver, } d.hostCheckers = []hostChecker{{ check: d.checkEtcHosts, name: "etchosts", }, { check: d.matchHost, name: "filtering", }, { check: matchBlockedServicesRules,
</s> remove testFS: testFSGen{ "no_0001.txt": []byte(nl), "no_0002.txt": []byte(nl), "no_0003.txt": []byte(nl), </s> add testFS: fstest.MapFS{ "no_0001.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0002.txt": &fstest.MapFile{Data: []byte(nl)}, "no_0003.txt": &fstest.MapFile{Data: []byte(nl)}, </s> remove testFS: testFSGen{ "simple_0001.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "simple_0001.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "chain_0001.txt": []byte(`chain_0002.txt` + nl), "chain_0002.txt": []byte(`chain_0003.txt` + nl), "chain_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "chain_0001.txt": &fstest.MapFile{Data: []byte(`chain_0002.txt` + nl)}, "chain_0002.txt": &fstest.MapFile{Data: []byte(`chain_0003.txt` + nl)}, "chain_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove testFS: testFSGen{ "several_0001.txt": []byte(`several_*` + nl), "several_0002.txt": []byte(`several_0001.txt` + nl), "several_0003.txt": []byte(attribute + nl), </s> add testFS: fstest.MapFS{ "several_0001.txt": &fstest.MapFile{Data: []byte(`several_*` + nl)}, "several_0002.txt": &fstest.MapFile{Data: []byte(`several_0001.txt` + nl)}, "several_0003.txt": &fstest.MapFile{Data: []byte(attribute + nl)}, </s> remove want: false, </s> add want: assert.False,
check: d.matchSysHosts, name: "hosts container",
resolver: resolver, } d.hostCheckers = []hostChecker{{ check: d.matchSysHosts, name: "hosts container", check: d.matchSysHosts, name: "hosts container", }, { check: d.matchHost, name: "filtering", }, { check: matchBlockedServicesRules,
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/filtering/filtering.go
// dnsServer is used for checking clients IP status access list status dnsServer *dnsforward.Server etcHosts *aghnet.EtcHostsContainer // get entries from system hosts-files testing bool // if TRUE, this object is used for internal tests } // Init initializes clients container
</s> remove clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module etcHosts *aghnet.EtcHostsContainer // IP-hostname pairs taken from system configuration (e.g. /etc/hosts) files updater *updater.Updater </s> add clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater </s> remove EtcHosts *aghnet.EtcHostsContainer `yaml:"-"` </s> add EtcHosts *aghnet.HostsContainer `yaml:"-"` </s> remove // testFSDir maps entries' names to entries which should either be a testFSDir // or byte slice. type testFSDir map[string]interface{} // testFSGen is used to generate a temporary filesystem consisting of // directories and plain text files from itself. type testFSGen testFSDir // gen returns the name of top directory of the generated filesystem. func (g testFSGen) gen(t *testing.T) (dirName string) { t.Helper() dirName = t.TempDir() g.rangeThrough(t, dirName) return dirName } func (g testFSGen) rangeThrough(t *testing.T, dirName string) { const perm fs.FileMode = 0o777 for k, e := range g { switch e := e.(type) { case []byte: require.NoError(t, os.WriteFile(filepath.Join(dirName, k), e, perm)) case testFSDir: newDir := filepath.Join(dirName, k) require.NoError(t, os.Mkdir(newDir, perm)) testFSGen(e).rangeThrough(t, newDir) default: t.Fatalf("unexpected entry type %T", e) } } } </s> add </s> remove etcHosts *aghnet.EtcHostsContainer, </s> add etcHosts *aghnet.HostsContainer, </s> remove func (clients *clientsContainer) onHostsChanged() { clients.addFromHostsFile() } </s> add
// etcHosts contains list of rewrite rules taken from the operating system's // hosts databse. etcHosts *aghnet.HostsContainer
// dnsServer is used for checking clients IP status access list status dnsServer *dnsforward.Server // etcHosts contains list of rewrite rules taken from the operating system's // hosts databse. etcHosts *aghnet.HostsContainer testing bool // if TRUE, this object is used for internal tests } // Init initializes clients container
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/clients.go
// Note: this function must be called only once func (clients *clientsContainer) Init( objects []clientObject, dhcpServer *dhcpd.Server, etcHosts *aghnet.EtcHostsContainer, ) { if clients.list != nil { log.Fatal("clients.list != nil") } clients.list = make(map[string]*Client)
</s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove func (clients *clientsContainer) onHostsChanged() { clients.addFromHostsFile() } </s> add </s> remove func (clients *clientsContainer) addFromHostsFile() { if clients.etcHosts == nil { return } hosts := clients.etcHosts.List() </s> add func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { </s> remove // handlePatterns parses the patterns and ignores duplicates using srcSet. // srcSet must be non-nil. func handlePatterns(srcSet *stringutil.Set, patterns ...string) (sub []string, err error) { </s> add // handlePatterns parses the patterns in fsys and ignores duplicates using // srcSet. srcSet must be non-nil. func handlePatterns( fsys fs.FS, srcSet *stringutil.Set, patterns ...string, ) (sub []string, err error) {
etcHosts *aghnet.HostsContainer,
// Note: this function must be called only once func (clients *clientsContainer) Init( objects []clientObject, dhcpServer *dhcpd.Server, etcHosts *aghnet.HostsContainer, ) { if clients.list != nil { log.Fatal("clients.list != nil") } clients.list = make(map[string]*Client)
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/clients.go
clients.dhcpServer = dhcpServer clients.etcHosts = etcHosts clients.addFromConfig(objects) if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) } } } // Start - start the module
</s> remove etcHosts *aghnet.EtcHostsContainer, </s> add etcHosts *aghnet.HostsContainer, </s> remove func (clients *clientsContainer) addFromHostsFile() { if clients.etcHosts == nil { return } hosts := clients.etcHosts.List() </s> add func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { </s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } </s> remove if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { </s> add if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil { </s> remove Context.etcHosts = &aghnet.EtcHostsContainer{} Context.etcHosts.Init("") </s> add var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) }
if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd)
clients.dhcpServer = dhcpServer clients.etcHosts = etcHosts clients.addFromConfig(objects) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) } } } // Start - start the module
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/clients.go
clients.updateFromDHCP(false) } } func (clients *clientsContainer) onHostsChanged() { clients.addFromHostsFile() } // Exists checks if client with this IP address already exists. func (clients *clientsContainer) Exists(ip net.IP, source clientSource) (ok bool) { clients.lock.Lock() defer clients.lock.Unlock()
</s> remove func (clients *clientsContainer) addFromHostsFile() { if clients.etcHosts == nil { return } hosts := clients.etcHosts.List() </s> add func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { </s> remove // AddHost adds a new IP-hostname pairing. The priorities of the sources is </s> add // AddHost adds a new IP-hostname pairing. The priorities of the sources are </s> remove etcHosts *aghnet.EtcHostsContainer, </s> add etcHosts *aghnet.HostsContainer, </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove filename := fmt.Sprintf("/etc/hostname.%s", ifaceName) </s> add filename := fmt.Sprintf("etc/hostname.%s", ifaceName)
clients.updateFromDHCP(false) } } // Exists checks if client with this IP address already exists. func (clients *clientsContainer) Exists(ip net.IP, source clientSource) (ok bool) { clients.lock.Lock() defer clients.lock.Unlock()
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/clients.go
log.Debug("clients: set whois info for runtime client with ip %s: %+v", ip, wi) } // AddHost adds a new IP-hostname pairing. The priorities of the sources is // taken into account. ok is true if the pairing was added. func (clients *clientsContainer) AddHost(ip net.IP, host string, src clientSource) (ok bool, err error) { clients.lock.Lock() defer clients.lock.Unlock()
</s> remove func (clients *clientsContainer) onHostsChanged() { clients.addFromHostsFile() } </s> add </s> remove func (clients *clientsContainer) addFromHostsFile() { if clients.etcHosts == nil { return } hosts := clients.etcHosts.List() </s> add func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { </s> remove // Walk starts walking the files defined by initPattern. It only returns true // if c signed to stop walking. func (c FileWalker) Walk(initPattern string) (ok bool, err error) { // The slice of sources keeps the order in which the files are walked // since srcSet.Values() returns strings in undefined order. </s> add // Walk starts walking the files in fsys defined by patterns from initial. // It only returns true if fw signed to stop walking. func (fw FileWalker) Walk(fsys fs.FS, initial ...string) (ok bool, err error) { // The slice of sources keeps the order in which the files are walked since // srcSet.Values() returns strings in undefined order. </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { </s> remove return aghos.FileWalker(hostnameIfStaticConfig).Walk(filename) </s> add return aghos.FileWalker(hostnameIfStaticConfig).Walk(aghos.RootDirFS(), filename)
// AddHost adds a new IP-hostname pairing. The priorities of the sources are
log.Debug("clients: set whois info for runtime client with ip %s: %+v", ip, wi) } // AddHost adds a new IP-hostname pairing. The priorities of the sources are // taken into account. ok is true if the pairing was added. func (clients *clientsContainer) AddHost(ip net.IP, host string, src clientSource) (ok bool, err error) { clients.lock.Lock() defer clients.lock.Unlock()
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/clients.go
} // addFromHostsFile fills the client-hostname pairing index from the system's // hosts files. func (clients *clientsContainer) addFromHostsFile() { if clients.etcHosts == nil { return } hosts := clients.etcHosts.List() clients.lock.Lock() defer clients.lock.Unlock() clients.rmHostsBySrc(ClientSourceHostsFile)
</s> remove func (clients *clientsContainer) onHostsChanged() { clients.addFromHostsFile() } </s> add </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove // AddHost adds a new IP-hostname pairing. The priorities of the sources is </s> add // AddHost adds a new IP-hostname pairing. The priorities of the sources are </s> remove // checkEtcHosts compares the host against our /etc/hosts table. The err is // always nil, it is only there to make this a valid hostChecker function. func (d *DNSFilter) checkEtcHosts( host string, qtype uint16, _ *Settings, ) (res Result, err error) { if d.Config.EtcHosts == nil { </s> add // matchSysHosts tries to match the host against the operating system's hosts // database. func (d *DNSFilter) matchSysHosts(host string, qtype uint16, setts *Settings) (res Result, err error) { if d.EtcHosts == nil { </s> remove Context.etcHosts = &aghnet.EtcHostsContainer{} Context.etcHosts.Init("") </s> add var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) }
func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) {
} // addFromHostsFile fills the client-hostname pairing index from the system's // hosts files. func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { clients.lock.Lock() defer clients.lock.Unlock() clients.rmHostsBySrc(ClientSourceHostsFile)
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/clients.go
enableFiltersLocked(async) } func enableFiltersLocked(async bool) { var whiteFilters []filtering.Filter filters := []filtering.Filter{{ Data: []byte(strings.Join(config.UserRules, "\n")), }} for _, filter := range config.Filters {
</s> remove testDir := tc.testFS.gen(t) fw := makeFileWalker(testDir) </s> add fw := makeFileWalker("") </s> remove want: true, </s> add want: assert.True, </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue
enableFiltersLocked(async) } func enableFiltersLocked(async bool) { filters := []filtering.Filter{{ Data: []byte(strings.Join(config.UserRules, "\n")), }} for _, filter := range config.Filters {
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/filter.go
FilePath: filter.Path(), }) } for _, filter := range config.WhitelistFilters { if !filter.Enabled { continue }
</s> remove whiteFilters = append(whiteFilters, filtering.Filter{ </s> add allowFilters = append(allowFilters, filtering.Filter{ </s> remove if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { </s> add if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil { </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove var whiteFilters []filtering.Filter </s> add </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd)
var allowFilters []filtering.Filter
FilePath: filter.Path(), }) } var allowFilters []filtering.Filter for _, filter := range config.WhitelistFilters { if !filter.Enabled { continue }
[ "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/filter.go
if !filter.Enabled { continue } whiteFilters = append(whiteFilters, filtering.Filter{ ID: filter.ID, FilePath: filter.Path(), }) }
</s> remove if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { </s> add if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil { </s> remove var whiteFilters []filtering.Filter </s> add </s> remove // TODO(a.garipov): Optimize this with a buffer. res.ReverseHosts = make([]string, len(revHosts)) for i := range revHosts { res.ReverseHosts[i] = revHosts[i] + "." </s> add for _, nr := range dnsr { dr := nr.DNSRewrite if dr == nil { continue </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd)
allowFilters = append(allowFilters, filtering.Filter{
if !filter.Enabled { continue } allowFilters = append(allowFilters, filtering.Filter{ ID: filter.ID, FilePath: filter.Path(), }) }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/filter.go
FilePath: filter.Path(), }) } if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { log.Debug("enabling filters: %s", err) } Context.dnsFilter.SetEnabled(config.DNS.FilteringEnabled) }
</s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } </s> remove whiteFilters = append(whiteFilters, filtering.Filter{ </s> add allowFilters = append(allowFilters, filtering.Filter{ </s> remove Context.etcHosts = &aghnet.EtcHostsContainer{} Context.etcHosts.Init("") </s> add var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) } </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd)
if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil {
FilePath: filter.Path(), }) } if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil { log.Debug("enabling filters: %s", err) } Context.dnsFilter.SetEnabled(config.DNS.FilteringEnabled) }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/filter.go
type homeContext struct { // Modules // -- clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module etcHosts *aghnet.EtcHostsContainer // IP-hostname pairs taken from system configuration (e.g. /etc/hosts) files updater *updater.Updater subnetDetector *aghnet.SubnetDetector // mux is our custom http.ServeMux. mux *http.ServeMux
</s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove EtcHosts *aghnet.EtcHostsContainer `yaml:"-"` </s> add EtcHosts *aghnet.HostsContainer `yaml:"-"` </s> remove etcHosts *aghnet.EtcHostsContainer // get entries from system hosts-files </s> add // etcHosts contains list of rewrite rules taken from the operating system's // hosts databse. etcHosts *aghnet.HostsContainer </s> remove // processDNSRewrites processes DNS rewrite rules in dnsr. It returns // an empty result if dnsr is empty. Otherwise, the result will have // either CanonName or DNSRewriteResult set. </s> add // processDNSRewrites processes DNS rewrite rules in dnsr. It returns an empty // result if dnsr is empty. Otherwise, the result will have either CanonName or // DNSRewriteResult set. </s> remove // Rewritten is returned when there was a rewrite by a legacy DNS // rewrite rule. </s> add // Rewritten is returned when there was a rewrite by a legacy DNS rewrite // rule.
clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater
type homeContext struct { // Modules // -- clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater clients clientsContainer // per-client-settings module stats stats.Stats // statistics module queryLog querylog.QueryLog // query log module dnsServer *dnsforward.Server // DNS module rdns *RDNS // rDNS module whois *WHOIS // WHOIS module dnsFilter *filtering.DNSFilter // DNS filtering module dhcpServer *dhcpd.Server // DHCP module auth *Auth // HTTP authentication module filters Filtering // DNS filtering module web *Web // Web (HTTP, HTTPS) module tls *TLSMod // TLS module // etcHosts is an IP-hostname pairs set taken from system configuration // (e.g. /etc/hosts) files. etcHosts *aghnet.HostsContainer updater *updater.Updater subnetDetector *aghnet.SubnetDetector // mux is our custom http.ServeMux. mux *http.ServeMux
[ "keep", "keep", "keep", "keep", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/home.go
ConfName: config.getConfigFilename(), }) if !args.noEtcHosts { Context.etcHosts = &aghnet.EtcHostsContainer{} Context.etcHosts.Init("") } Context.clients.Init(config.Clients, Context.dhcpServer, Context.etcHosts) config.Clients = nil // override bind host/port from the console
</s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } </s> remove func (clients *clientsContainer) addFromHostsFile() { if clients.etcHosts == nil { return } hosts := clients.etcHosts.List() </s> add func (clients *clientsContainer) addFromHostsFile(hosts *netutil.IPMap) { </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { </s> add if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil { </s> remove ips := d.Config.EtcHosts.Process(host, qtype) if ips != nil { res = Result{ Reason: RewrittenAutoHosts, IPList: ips, } </s> add dnsres, _ := d.EtcHosts.MatchRequest(urlfilter.DNSRequest{ Hostname: host, SortedClientTags: setts.ClientTags, // TODO(e.burkov): Wait for urlfilter update to pass net.IP. ClientIP: setts.ClientIP.String(), ClientName: setts.ClientName, DNSType: qtype, })
var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) }
ConfName: config.getConfigFilename(), }) if !args.noEtcHosts { var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) } var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) } } Context.clients.Init(config.Clients, Context.dhcpServer, Context.etcHosts) config.Clients = nil // override bind host/port from the console
[ "keep", "keep", "keep", "keep", "replace", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/home.go
err = initDNSServer() fatalOnError(err) Context.tls.Start() Context.etcHosts.Start() go func() { serr := startDNSServer() if serr != nil { closeDNSServer()
</s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove Context.etcHosts.Close() </s> add if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } </s> remove // Prepare test hosts file. hf, err := os.CreateTemp("", "") </s> add const closeCalled errors.Error = "close method called" var eventsCalledCounter uint32 hc, err := aghnet.NewHostsContainer(testFS, &aghtest.FSWatcher{ OnEvents: func() (e <-chan struct{}) { assert.Equal(t, uint32(1), atomic.AddUint32(&eventsCalledCounter, 1)) return nil }, OnAdd: func(name string) (err error) { assert.Equal(t, hostsFilename, name) return nil }, OnClose: func() (err error) { return closeCalled }, }, hostsFilename) </s> remove d.engineLock.Lock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow d.engineLock.Unlock() </s> add func() { d.engineLock.Lock() defer d.engineLock.Unlock() d.reset() d.rulesStorage = rulesStorage d.filteringEngine = filteringEngine d.rulesStorageAllow = rulesStorageAllow d.filteringEngineAllow = filteringEngineAllow }()
err = initDNSServer() fatalOnError(err) Context.tls.Start() go func() { serr := startDNSServer() if serr != nil { closeDNSServer()
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/home.go
log.Error("stopping dhcp server: %s", err) } } Context.etcHosts.Close() if Context.tls != nil { Context.tls.Close() Context.tls = nil }
</s> remove if err := Context.dnsFilter.SetFilters(filters, whiteFilters, async); err != nil { </s> add if err := Context.dnsFilter.SetFilters(filters, allowFilters, async); err != nil { </s> remove if !clients.testing { clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } if clients.etcHosts != nil { clients.etcHosts.SetOnChanged(clients.onHostsChanged) </s> add if clients.testing { return } clients.updateFromDHCP(true) if clients.dhcpServer != nil { clients.dhcpServer.SetOnLeaseChanged(clients.onDHCPLeaseChanged) } go clients.handleHostsUpdates() } func (clients *clientsContainer) handleHostsUpdates() { if clients.etcHosts != nil { for upd := range clients.etcHosts.Upd() { clients.addFromHostsFile(upd) </s> remove Context.etcHosts = &aghnet.EtcHostsContainer{} Context.etcHosts.Init("") </s> add var osWritesWatcher aghos.FSWatcher osWritesWatcher, err = aghos.NewOSWritesWatcher() if err != nil { return fmt.Errorf("initing os watcher: %w", err) } Context.etcHosts, err = aghnet.NewHostsContainer( aghos.RootDirFS(), osWritesWatcher, aghnet.DefaultHostsPaths()..., ) if err != nil { return fmt.Errorf("initing hosts container: %w", err) } </s> remove patterns = append(patterns, filepath.Join(dirName, line)) </s> add patterns = append(patterns, path.Join(".", line)) </s> remove return res, nil </s> add dnsr := dnsres.DNSRewrites() if len(dnsr) == 0 { return Result{}, nil
if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } }
log.Error("stopping dhcp server: %s", err) } } if Context.etcHosts != nil { if err = Context.etcHosts.Close(); err != nil { log.Error("stopping hosts container: %s", err) } } if Context.tls != nil { Context.tls.Close() Context.tls = nil }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: 2499 merge rewrites vol.1 Merge in DNS/adguard-home from 2499-merge-rewrites-vol.1 to master Updates #2499. Squashed commit of the following: commit 6b308bc2b360cee8c22e506f31d62bacb4bf8fb3 Merge: f49e9186 2b635bf6 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 19:23:07 2021 +0300 Merge branch 'master' into 2499-merge-rewrites-vol.1 commit f49e9186ffc8b7074d03c6721ee56cdb09243684 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 18:50:49 2021 +0300 aghos: fix fs events filtering commit 567dd646556606212af5dab60e3ecbb8fff22c25 Author: Eugene Burkov <[email protected]> Date: Thu Oct 14 16:50:37 2021 +0300 all: imp code, docs, fix windows commit 140c8bf519345eb54d0e7500a996fcf465353d71 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:41:53 2021 +0300 aghnet: use const commit bebf3f76bd394a498ccad812c57d4507c69529ba Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 19:32:37 2021 +0300 all: imp tests, docs commit 9bfdbb6eb454833135d616e208e82699f98e2562 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 18:42:20 2021 +0300 all: imp path more, imp docs commit ee9ea4c132a6b17787d150bf2bee703abaa57be3 Author: Eugene Burkov <[email protected]> Date: Wed Oct 13 16:09:46 2021 +0300 all: fix windows, imp paths commit 6fac8338a81e9ecfebfc23a1adcb964e89f6aee6 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 19:53:35 2021 +0300 all: imp code, docs commit da1ce1a2a3dd2be3fdff2412a6dbd596859dc249 Author: Eugene Burkov <[email protected]> Date: Mon Oct 11 18:22:50 2021 +0300 aghnet: fix windows tests commit d29de359ed68118d71efb226a8433fac15ff5c66 Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 21:02:14 2021 +0300 all: repl & imp commit 1356c08944cdbb85ce5532d90fe5b077219ce5ff Author: Eugene Burkov <[email protected]> Date: Fri Oct 8 01:41:19 2021 +0300 all: add tests, mv logic, added tmpfs commit f4b11adf8998bc8d9d955c5ac9f386f671bd5213 Author: Eugene Burkov <[email protected]> Date: Thu Oct 7 14:26:30 2021 +0300 all: imp filewalker, refactor hosts container
https://github.com/AdguardTeam/AdGuardHome/commit/2796e65468a87c7e556087fdec1c8663eedfe90e
internal/home/home.go
require.NotNil(t, errPtr) err := *errPtr require.NotNil(t, err) assert.Equal(t, wantMsg, err.Error()) }) t.Run("defer", func(t *testing.T) {
</s> remove require.NotNil(t, err) </s> add require.Error(t, err) </s> remove require.Nil(t, err) </s> add require.NoError(t, err) </s> remove require.Nil(t, err) </s> add require.NoError(t, err) </s> remove require.Nil(t, err) </s> add require.NoError(t, err) </s> remove require.Nil(t, err) </s> add require.NoError(t, err)
require.Error(t, err)
require.NotNil(t, errPtr) err := *errPtr require.Error(t, err) assert.Equal(t, wantMsg, err.Error()) }) t.Run("defer", func(t *testing.T) {
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/agherr/agherr_test.go
return errTest } err := f() require.NotNil(t, err) assert.Equal(t, wantMsg, err.Error()) }) }
</s> remove require.NotNil(t, err) </s> add require.Error(t, err) </s> remove assert.Nil(t, err, "after %s", time.Since(start)) </s> add assert.NoError(t, err, "after %s", time.Since(start)) </s> remove require.Nil(t, err) </s> add require.NoError(t, err) </s> remove require.Nil(t, err) </s> add require.NoError(t, err) </s> remove require.Nil(t, err) </s> add require.NoError(t, err)
require.Error(t, err)
return errTest } err := f() require.Error(t, err) assert.Equal(t, wantMsg, err.Error()) }) }
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/agherr/agherr_test.go
func TestLimitReadCloser(t *testing.T) { testCases := []struct { name string n int64 }{{ want: nil,
</s> remove want error </s> add </s> remove limit int64 </s> add </s> remove err error </s> add
want error
func TestLimitReadCloser(t *testing.T) { testCases := []struct { want error name string n int64 }{{ want: nil,
[ "keep", "add", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
func TestLimitReadCloser(t *testing.T) { testCases := []struct { name string n int64 want error }{{ name: "positive", n: 1, want: nil, }, {
</s> remove want: nil, </s> add </s> remove limit int64 </s> add
func TestLimitReadCloser(t *testing.T) { testCases := []struct { name string n int64 }{{ name: "positive", n: 1, want: nil, }, {
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
name string n int64 }{{ name: "positive", n: 1, }, { want: nil, name: "zero",
</s> remove want error </s> add </s> remove want: nil, </s> add </s> remove want: nil, </s> add
want: nil,
name string n int64 }{{ want: nil, name: "positive", n: 1, }, { want: nil, name: "zero",
[ "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
want error }{{ name: "positive", n: 1, want: nil, }, { name: "zero", n: 0, want: nil, }, {
</s> remove want error </s> add </s> remove want: nil, </s> add
want error }{{ name: "positive", n: 1, }, { name: "zero", n: 0, want: nil, }, {
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
n: 1, }, { name: "zero", n: 0, }, { want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), name: "negative", n: -1,
</s> remove want: nil, </s> add </s> remove want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), </s> add </s> remove want: nil, </s> add
want: nil,
n: 1, }, { want: nil, name: "zero", n: 0, }, { want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), name: "negative", n: -1,
[ "keep", "add", "keep", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
want: nil, }, { name: "zero", n: 0, want: nil, }, { name: "negative", n: -1, want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), }}
</s> remove want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), </s> add </s> remove want: nil, </s> add
want: nil, }, { name: "zero", n: 0, }, { name: "negative", n: -1, want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), }}
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
name: "zero", n: 0, }, { name: "negative", n: -1, }} for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) {
</s> remove want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), </s> add </s> remove want: nil, </s> add </s> remove err: nil, </s> add
want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"),
name: "zero", n: 0, }, { want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), name: "negative", n: -1, }} for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) {
[ "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
want: nil, }, { name: "negative", n: -1, want: fmt.Errorf("aghio: invalid n in LimitReadCloser: -1"), }} for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { _, err := LimitReadCloser(nil, tc.n)
</s> remove want: nil, </s> add </s> remove err: nil, </s> add
want: nil, }, { name: "negative", n: -1, }} for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { _, err := LimitReadCloser(nil, tc.n)
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
} func TestLimitedReadCloser_Read(t *testing.T) { testCases := []struct { name string rStr string limit int64 want int }{{
</s> remove limit int64 </s> add </s> remove err error </s> add </s> remove want error </s> add
err error
} func TestLimitedReadCloser_Read(t *testing.T) { testCases := []struct { err error name string rStr string limit int64 want int }{{
[ "keep", "keep", "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
func TestLimitedReadCloser_Read(t *testing.T) { testCases := []struct { name string limit int64 rStr string want int err error }{{ name: "perfectly_match",
</s> remove err error </s> add </s> remove want error </s> add
func TestLimitedReadCloser_Read(t *testing.T) { testCases := []struct { name string rStr string want int err error }{{ name: "perfectly_match",
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
name string rStr string want int }{{ err: nil, name: "perfectly_match", rStr: "abc",
</s> remove err error </s> add </s> remove limit int64 </s> add </s> remove limit: 3, </s> add
limit int64
name string rStr string limit int64 want int }{{ err: nil, name: "perfectly_match", rStr: "abc",
[ "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
name string limit int64 rStr string want int err error }{{ name: "perfectly_match", limit: 3, rStr: "abc", want: 3,
</s> remove limit int64 </s> add </s> remove limit: 3, </s> add
name string limit int64 rStr string want int }{{ name: "perfectly_match", limit: 3, rStr: "abc", want: 3,
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
rStr string limit int64 want int }{{ name: "perfectly_match", rStr: "abc", limit: 3, want: 3,
</s> remove err error </s> add </s> remove limit int64 </s> add </s> remove limit: 3, </s> add
err: nil,
rStr string limit int64 want int }{{ err: nil, name: "perfectly_match", rStr: "abc", limit: 3, want: 3,
[ "keep", "keep", "keep", "add", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
want int err error }{{ name: "perfectly_match", limit: 3, rStr: "abc", want: 3, err: nil, }, { name: "eof",
</s> remove err error </s> add </s> remove err: nil, </s> add
want int err error }{{ name: "perfectly_match", rStr: "abc", want: 3, err: nil, }, { name: "eof",
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
name: "perfectly_match", rStr: "abc", want: 3, }, { err: io.EOF, name: "eof", rStr: "",
</s> remove err: nil, </s> add </s> remove err: io.EOF, </s> add </s> remove limit: 3, </s> add
limit: 3,
name: "perfectly_match", rStr: "abc", limit: 3, want: 3, }, { err: io.EOF, name: "eof", rStr: "",
[ "keep", "add", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
name: "perfectly_match", limit: 3, rStr: "abc", want: 3, err: nil, }, { name: "eof", limit: 3, rStr: "", want: 0,
</s> remove limit: 3, </s> add </s> remove limit: 3, </s> add </s> remove err: io.EOF, </s> add
name: "perfectly_match", limit: 3, rStr: "abc", want: 3, }, { name: "eof", limit: 3, rStr: "", want: 0,
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
rStr: "abc", limit: 3, want: 3, }, { name: "eof", rStr: "", limit: 3, want: 0,
</s> remove err: nil, </s> add </s> remove limit: 3, </s> add </s> remove err: io.EOF, </s> add
err: io.EOF,
rStr: "abc", limit: 3, want: 3, }, { err: io.EOF, name: "eof", rStr: "", limit: 3, want: 0,
[ "keep", "keep", "keep", "add", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
want: 3, err: nil, }, { name: "eof", limit: 3, rStr: "", want: 0, err: io.EOF, }, { name: "limit_reached",
</s> remove err: io.EOF, </s> add </s> remove err: nil, </s> add
want: 3, err: nil, }, { name: "eof", rStr: "", want: 0, err: io.EOF, }, { name: "limit_reached",
[ "keep", "keep", "keep", "keep", "replace", "keep", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go
err: io.EOF, name: "eof", rStr: "", want: 0, }, { err: &LimitReachedError{ Limit: 0,
</s> remove name: "limit_reached", limit: 0, rStr: "abc", want: 0, </s> add </s> remove err: io.EOF, </s> add </s> remove limit: 3, </s> add
limit: 3,
err: io.EOF, name: "eof", rStr: "", limit: 3, want: 0, }, { err: &LimitReachedError{ Limit: 0,
[ "keep", "keep", "add", "keep", "keep", "keep", "keep" ]
Pull request: all: imp some tests Merge in DNS/adguard-home from imp-tests to master Squashed commit of the following: commit 6171420068d66808f069f280a81e0c60e61e5ce3 Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:43:36 2021 +0300 aghnet: imp test msgs commit ed2880ff03ab0e41a77f07aad2caf13bf5f4bd9f Author: Ainar Garipov <[email protected]> Date: Thu Mar 25 17:39:44 2021 +0300 all: imp some tests
https://github.com/AdguardTeam/AdGuardHome/commit/27f4f0527331ad5fa85bcec843cd13cc97c696a8
internal/aghio/limitedreadcloser_test.go