code_before
stringlengths 16
1.81M
| edits
stringlengths 4
328k
| next_edit
stringlengths 0
76.5k
| code_after
stringlengths 3
49.9M
| label_window
sequencelengths 4
1.81k
| instruction
stringlengths 20
51.9k
| html_url
stringlengths 74
116
| file_name
stringlengths 3
311
|
|---|---|---|---|---|---|---|---|
<h6>Interactions</h6>
{this.renderSwitch("Editing", "enableCellEditing")}
{this.renderSwitch("Selection", "enableCellSelection")}
{this.renderSwitch("Truncation", "enableCellTruncation", "enableCellEditing", false)}
<div className="sidebar-indented-group">{truncatedPopoverModeMenu}</div>
{this.renderSwitch("Fixed Truncation", "enableCellTruncationFixed", "enableCellTruncation", true)}
<div className="sidebar-indented-group">{truncatedLengthMenu}</div>
{this.renderSwitch("Wrap Text", "enableCellWrap")}
| </s> remove truncateLength={80}
</s> add truncateLength={this.state.cellTruncationLength} </s> remove detectTruncation={true}
</s> add detectTruncation={!this.state.enableCellTruncationFixed} | <h6>Text Layout</h6> | <h6>Interactions</h6>
{this.renderSwitch("Editing", "enableCellEditing")}
{this.renderSwitch("Selection", "enableCellSelection")}
<h6>Text Layout</h6>
{this.renderSwitch("Truncation", "enableCellTruncation", "enableCellEditing", false)}
<div className="sidebar-indented-group">{truncatedPopoverModeMenu}</div>
{this.renderSwitch("Fixed Truncation", "enableCellTruncationFixed", "enableCellTruncation", true)}
<div className="sidebar-indented-group">{truncatedLengthMenu}</div>
{this.renderSwitch("Wrap Text", "enableCellWrap")}
| [
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [Table] Add more switches for text layout to dev preview (#1641)
* add switches for truncating to string length
* lint | https://github.com/palantir/blueprint/commit/ae5974d733eda58ecd47a483fb7b77dcbbea13a7 | packages/table/preview/mutableTable.tsx |
{this.renderSwitch("Selection", "enableCellSelection")}
<h6>Text Layout</h6>
{this.renderSwitch("Truncation", "enableCellTruncation", "enableCellEditing", false)}
<div className="sidebar-indented-group">{truncatedPopoverModeMenu}</div>
{this.renderSwitch("Wrap Text", "enableCellWrap")}
<h4>Page</h4>
<h6>Display</h6>
{this.renderFocusStyleSelectMenu()}
| </s> remove truncateLength={80}
</s> add truncateLength={this.state.cellTruncationLength} </s> remove detectTruncation={true}
</s> add detectTruncation={!this.state.enableCellTruncationFixed} | {this.renderSwitch("Fixed Truncation", "enableCellTruncationFixed", "enableCellTruncation", true)}
<div className="sidebar-indented-group">{truncatedLengthMenu}</div> | {this.renderSwitch("Selection", "enableCellSelection")}
<h6>Text Layout</h6>
{this.renderSwitch("Truncation", "enableCellTruncation", "enableCellEditing", false)}
<div className="sidebar-indented-group">{truncatedPopoverModeMenu}</div>
{this.renderSwitch("Fixed Truncation", "enableCellTruncationFixed", "enableCellTruncation", true)}
<div className="sidebar-indented-group">{truncatedLengthMenu}</div>
{this.renderSwitch("Wrap Text", "enableCellWrap")}
<h4>Page</h4>
<h6>Display</h6>
{this.renderFocusStyleSelectMenu()} | [
"keep",
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [Table] Add more switches for text layout to dev preview (#1641)
* add switches for truncating to string length
* lint | https://github.com/palantir/blueprint/commit/ae5974d733eda58ecd47a483fb7b77dcbbea13a7 | packages/table/preview/mutableTable.tsx |
/**
* Generic interface defining constructor types, such as classes. This is used to type the class
* itself in meta-programming situations such as decorators.
*
* @deprecated will be removed in Blueprint v4.0
*/
export type IConstructor<T> = new (...args: any[]) => T;
| </s> remove // this can be removed once Popover2 is merged into core in v4.0
</s> add // this can be removed once Popover2 is merged into core in v5.0 </s> remove // these tests can be removed once Popover2 is merged into core in v4.0
</s> add // these tests can be removed once Popover2 is merged into core in v5.0 </s> remove * @deprecated will be removed in Blueprint v4.0, where components will use `ref` prop instead
</s> add * @deprecated will be removed in Blueprint v5.0, where components will use `ref` prop instead | * @deprecated will be removed in Blueprint v5.0 | /**
* Generic interface defining constructor types, such as classes. This is used to type the class
* itself in meta-programming situations such as decorators.
*
* @deprecated will be removed in Blueprint v5.0
*/
export type IConstructor<T> = new (...args: any[]) => T; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep"
] | docs: Update v4 deprecation notices to v5 (#5018)
Co-authored-by: Henry Warhurst <[email protected]> | https://github.com/palantir/blueprint/commit/afcf7ac1bc3861b6b6606e801161874761a37341 | packages/core/src/common/constructor.ts |
}
export type ControlledProps2 = IControlledProps2;
/**
* @deprecated will be removed in Blueprint v4.0, where components will use `ref` prop instead
*/
export interface IElementRefProps<E extends HTMLElement> {
/** A ref handler or a ref object that receives the native HTML element rendered by this component. */
elementRef?: IRef<E>;
}
| </s> remove // this can be removed once Popover2 is merged into core in v4.0
</s> add // this can be removed once Popover2 is merged into core in v5.0 </s> remove * @deprecated will be removed in Blueprint v4.0
</s> add * @deprecated will be removed in Blueprint v5.0 </s> remove // these tests can be removed once Popover2 is merged into core in v4.0
</s> add // these tests can be removed once Popover2 is merged into core in v5.0 | * @deprecated will be removed in Blueprint v5.0, where components will use `ref` prop instead | }
export type ControlledProps2 = IControlledProps2;
/**
* @deprecated will be removed in Blueprint v5.0, where components will use `ref` prop instead
*/
export interface IElementRefProps<E extends HTMLElement> {
/** A ref handler or a ref object that receives the native HTML element rendered by this component. */
elementRef?: IRef<E>;
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | docs: Update v4 deprecation notices to v5 (#5018)
Co-authored-by: Henry Warhurst <[email protected]> | https://github.com/palantir/blueprint/commit/afcf7ac1bc3861b6b6606e801161874761a37341 | packages/core/src/common/props.ts |
`.${Classes.POPOVER2_DISMISS}, .${Classes.POPOVER2_DISMISS_OVERRIDE}`,
);
// dismiss selectors from the "V1" version of Popover in the core pacakge
// we expect these to be rendered by MenuItem, which at this point has no knowledge of Popover2
// this can be removed once Popover2 is merged into core in v4.0
const dismissElementV1 = eventTarget.closest(
`.${CoreClasses.POPOVER_DISMISS}, .${CoreClasses.POPOVER_DISMISS_OVERRIDE}`,
);
const shouldDismiss =
| </s> remove * @deprecated will be removed in Blueprint v4.0
</s> add * @deprecated will be removed in Blueprint v5.0 </s> remove // these tests can be removed once Popover2 is merged into core in v4.0
</s> add // these tests can be removed once Popover2 is merged into core in v5.0 </s> remove * @deprecated will be removed in Blueprint v4.0, where components will use `ref` prop instead
</s> add * @deprecated will be removed in Blueprint v5.0, where components will use `ref` prop instead | // this can be removed once Popover2 is merged into core in v5.0 | `.${Classes.POPOVER2_DISMISS}, .${Classes.POPOVER2_DISMISS_OVERRIDE}`,
);
// dismiss selectors from the "V1" version of Popover in the core pacakge
// we expect these to be rendered by MenuItem, which at this point has no knowledge of Popover2
// this can be removed once Popover2 is merged into core in v5.0
const dismissElementV1 = eventTarget.closest(
`.${CoreClasses.POPOVER_DISMISS}, .${CoreClasses.POPOVER_DISMISS_OVERRIDE}`,
);
const shouldDismiss = | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | docs: Update v4 deprecation notices to v5 (#5018)
Co-authored-by: Henry Warhurst <[email protected]> | https://github.com/palantir/blueprint/commit/afcf7ac1bc3861b6b6606e801161874761a37341 | packages/popover2/src/popover2.tsx |
}, done);
});
});
// these tests can be removed once Popover2 is merged into core in v4.0
describe("compatibility", () => {
it("MenuItem from core package is able to dismiss open Popover2", () => {
wrapper = renderPopover(
{ defaultIsOpen: true, usePortal: false },
<Menu>
| </s> remove // this can be removed once Popover2 is merged into core in v4.0
</s> add // this can be removed once Popover2 is merged into core in v5.0 </s> remove * @deprecated will be removed in Blueprint v4.0
</s> add * @deprecated will be removed in Blueprint v5.0 </s> remove * @deprecated will be removed in Blueprint v4.0, where components will use `ref` prop instead
</s> add * @deprecated will be removed in Blueprint v5.0, where components will use `ref` prop instead | // these tests can be removed once Popover2 is merged into core in v5.0 | }, done);
});
});
// these tests can be removed once Popover2 is merged into core in v5.0
describe("compatibility", () => {
it("MenuItem from core package is able to dismiss open Popover2", () => {
wrapper = renderPopover(
{ defaultIsOpen: true, usePortal: false },
<Menu> | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | docs: Update v4 deprecation notices to v5 (#5018)
Co-authored-by: Henry Warhurst <[email protected]> | https://github.com/palantir/blueprint/commit/afcf7ac1bc3861b6b6606e801161874761a37341 | packages/popover2/test/popover2Tests.tsx |
import * as React from "react";
import { polyfill } from "react-lifecycles-compat";
import { DISPLAYNAME_PREFIX } from "../../common/props";
export interface IAsyncControllableInputProps
extends React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> {
inputRef?: React.LegacyRef<HTMLInputElement>;
}
| </s> remove export class AsyncControllableInput extends React.PureComponent<
</s> add export class AsyncControllableInput extends AbstractPureComponent2< </s> remove await Promise.resolve();
</s> add // Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
</s> remove this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
</s> add this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); </s> remove this.setState({ isComposing: false });
</s> add // In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
); | import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common"; |
import * as React from "react";
import { polyfill } from "react-lifecycles-compat";
import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common";
export interface IAsyncControllableInputProps
extends React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> {
inputRef?: React.LegacyRef<HTMLInputElement>;
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/src/components/forms/asyncControllableInput.tsx |
*
* Note: this component does not apply any Blueprint-specific styling.
*/
@polyfill
export class AsyncControllableInput extends React.PureComponent<
IAsyncControllableInputProps,
IAsyncControllableInputState
> {
public static displayName = `${DISPLAYNAME_PREFIX}.AsyncControllableInput`;
| </s> remove import { DISPLAYNAME_PREFIX } from "../../common/props";
</s> add import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common"; </s> remove this.setState({ isComposing: false });
</s> add // In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
); </s> remove this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
</s> add this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); | export class AsyncControllableInput extends AbstractPureComponent2< | *
* Note: this component does not apply any Blueprint-specific styling.
*/
@polyfill
export class AsyncControllableInput extends AbstractPureComponent2<
IAsyncControllableInputProps,
IAsyncControllableInputState
> {
public static displayName = `${DISPLAYNAME_PREFIX}.AsyncControllableInput`;
| [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/src/components/forms/asyncControllableInput.tsx |
IAsyncControllableInputState
> {
public static displayName = `${DISPLAYNAME_PREFIX}.AsyncControllableInput`;
public state: IAsyncControllableInputState = {
hasPendingUpdate: false,
isComposing: false,
nextValue: this.props.value,
value: this.props.value,
| </s> remove export class AsyncControllableInput extends React.PureComponent<
</s> add export class AsyncControllableInput extends AbstractPureComponent2< </s> remove this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
</s> add this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); </s> remove this.setState({ isComposing: false });
</s> add // In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
); </s> remove await Promise.resolve();
</s> add // Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
| /**
* The amount of time (in milliseconds) which the input will wait after a compositionEnd event before
* unlocking its state value for external updates via props. See `handleCompositionEnd` for more details.
*/
public static COMPOSITION_END_DELAY = 10;
| IAsyncControllableInputState
> {
public static displayName = `${DISPLAYNAME_PREFIX}.AsyncControllableInput`;
/**
* The amount of time (in milliseconds) which the input will wait after a compositionEnd event before
* unlocking its state value for external updates via props. See `handleCompositionEnd` for more details.
*/
public static COMPOSITION_END_DELAY = 10;
public state: IAsyncControllableInputState = {
hasPendingUpdate: false,
isComposing: false,
nextValue: this.props.value,
value: this.props.value, | [
"keep",
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/src/components/forms/asyncControllableInput.tsx |
value: this.props.value,
};
public static getDerivedStateFromProps(
nextProps: IAsyncControllableInputProps,
nextState: IAsyncControllableInputState,
): Partial<IAsyncControllableInputState> | null {
if (nextState.isComposing || nextProps.value === undefined) {
// don't derive anything from props if:
| </s> remove import { DISPLAYNAME_PREFIX } from "../../common/props";
</s> add import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common"; </s> remove export class AsyncControllableInput extends React.PureComponent<
</s> add export class AsyncControllableInput extends AbstractPureComponent2< </s> remove await Promise.resolve();
</s> add // Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
</s> remove this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
</s> add this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); | private cancelPendingCompositionEnd: (() => void) | null = null;
| value: this.props.value,
};
private cancelPendingCompositionEnd: (() => void) | null = null;
public static getDerivedStateFromProps(
nextProps: IAsyncControllableInputProps,
nextState: IAsyncControllableInputState,
): Partial<IAsyncControllableInputState> | null {
if (nextState.isComposing || nextProps.value === undefined) {
// don't derive anything from props if: | [
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/src/components/forms/asyncControllableInput.tsx |
);
}
private handleCompositionStart = (e: React.CompositionEvent<HTMLInputElement>) => {
this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
this.props.onCompositionStart?.(e);
};
private handleCompositionEnd = (e: React.CompositionEvent<HTMLInputElement>) => {
this.setState({ isComposing: false });
| </s> remove this.setState({ isComposing: false });
</s> add // In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
); </s> remove await Promise.resolve();
</s> add // Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
</s> remove import { DISPLAYNAME_PREFIX } from "../../common/props";
</s> add import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common"; | this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); | );
}
private handleCompositionStart = (e: React.CompositionEvent<HTMLInputElement>) => {
this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true });
this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true });
this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true });
this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true });
this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true });
this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true });
this.props.onCompositionStart?.(e);
};
private handleCompositionEnd = (e: React.CompositionEvent<HTMLInputElement>) => {
this.setState({ isComposing: false }); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"replace",
"replace",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/src/components/forms/asyncControllableInput.tsx |
this.props.onCompositionStart?.(e);
};
private handleCompositionEnd = (e: React.CompositionEvent<HTMLInputElement>) => {
this.setState({ isComposing: false });
this.props.onCompositionEnd?.(e);
};
private handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
const { value } = e.target;
| </s> remove this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
</s> add this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); </s> remove await Promise.resolve();
</s> add // Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
</s> remove import { DISPLAYNAME_PREFIX } from "../../common/props";
</s> add import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common"; | // In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
); | this.props.onCompositionStart?.(e);
};
private handleCompositionEnd = (e: React.CompositionEvent<HTMLInputElement>) => {
// In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
);
this.props.onCompositionEnd?.(e);
};
private handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
const { value } = e.target; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/src/components/forms/asyncControllableInput.tsx |
input.simulate("compositionupdate", { data: " " });
input.simulate("change", { target: { value: "hi " } });
input.simulate("compositionend", { data: " " });
await Promise.resolve();
// we are "rejecting" the composition here by supplying a different controlled value
wrapper.setProps({ value: "bye" }).update();
assert.strictEqual(wrapper.find("input").prop("value"), "bye");
});
| </s> remove this.setState({ isComposing: false });
</s> add // In some non-latin languages, a keystroke can end a composition event and immediately afterwards start another.
// This can lead to unexpected characters showing up in the text input. In order to circumvent this problem, we
// use a timeout which creates a delay which merges the two composition events, creating a more natural and predictable UX.
// `this.state.nextValue` will become "locked" (it cannot be overwritten by the `value` prop) until a delay (10ms) has
// passed without a new composition event starting.
this.cancelPendingCompositionEnd = this.setTimeout(
() => this.setState({ isComposing: false }),
AsyncControllableInput.COMPOSITION_END_DELAY,
); </s> remove this.setState({
isComposing: true,
// Make sure that localValue matches externalValue, in case externalValue
// has changed since the last onChange event.
nextValue: this.state.value,
});
</s> add this.cancelPendingCompositionEnd?.();
this.setState({ isComposing: true }); </s> remove import { DISPLAYNAME_PREFIX } from "../../common/props";
</s> add import { AbstractPureComponent2, DISPLAYNAME_PREFIX } from "../../common"; | // Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
| input.simulate("compositionupdate", { data: " " });
input.simulate("change", { target: { value: "hi " } });
input.simulate("compositionend", { data: " " });
// Wait for the composition ending delay to pass
await new Promise(resolve =>
setTimeout(() => resolve(null), AsyncControllableInput.COMPOSITION_END_DELAY + 5),
);
// we are "rejecting" the composition here by supplying a different controlled value
wrapper.setProps({ value: "bye" }).update();
assert.strictEqual(wrapper.find("input").prop("value"), "bye");
}); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | [core] fix(AsyncControllableInput): handle compound composition events (#5165)
Co-authored-by: Henry Stoke <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]> | https://github.com/palantir/blueprint/commit/b0a614374b500939de103bf5f8b08146f8c63902 | packages/core/test/forms/asyncControllableInputTests.tsx |
{
"lerna": "4.0.0",
"npmClient": "yarn",
"useWorkspaces": true,
"version": "independent"
}
| </s> remove "lerna": "^5.1.8",
</s> add "lerna": "^5.5.4", </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add | "lerna": "5.5.4", | {
"lerna": "5.5.4",
"npmClient": "yarn",
"useWorkspaces": true,
"version": "independent"
} | [
"keep",
"replace",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | lerna.json |
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-prettier": "^4.2.1",
"gh-pages": "^4.0.0",
"http-server": "^14.1.1",
"lerna": "^5.1.8",
"npm-run-all": "^4.1.5",
"prettier": "~2.7.1",
"sinon": "^9.2.1",
"stylelint-config-palantir": "^6.0.1",
"stylelint-scss": "^4.2.0",
| </s> remove "lerna": "4.0.0",
</s> add "lerna": "5.5.4", </s> remove const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect2.ofType<Film>(); </s> remove function renderTag(film: IFilm) {
</s> add function renderTag(film: Film) { </s> remove function multiselect(props: Partial<MultiSelect2Props<IFilm>> = {}, query?: string) {
</s> add function multiselect(props: Partial<MultiSelect2Props<Film>> = {}, query?: string) { </s> remove selectPopoverTestSuite<MultiSelect2Props<IFilm>, MultiSelect2State>(props =>
</s> add selectPopoverTestSuite<MultiSelect2Props<Film>, MultiSelect2State>(props => | "lerna": "^5.5.4", | "eslint-config-prettier": "^8.5.0",
"eslint-plugin-prettier": "^4.2.1",
"gh-pages": "^4.0.0",
"http-server": "^14.1.1",
"lerna": "^5.5.4",
"npm-run-all": "^4.1.5",
"prettier": "~2.7.1",
"sinon": "^9.2.1",
"stylelint-config-palantir": "^6.0.1",
"stylelint-scss": "^4.2.0", | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | package.json |
Popover2InteractionKind,
Popover2SharedProps,
StrictModifierNames,
} from "@blueprintjs/popover2";
import FilmSelect from "../../common/filmSelect";
const POPPER_DOCS_URL = "https://popper.js.org/docs/v2/";
const INTERACTION_KINDS = [
{ label: "Click", value: "click" },
| </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add const FilmSuggest = Suggest2.ofType<Film>(); </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove
import { IFilm, TOP_100_FILMS } from "../../common/films";
import FilmSelect from "../../common/filmSelect";
</s> add import { Film, FilmSelect, TOP_100_FILMS } from "@blueprintjs/select/examples"; | import { FilmSelect } from "@blueprintjs/select/examples"; | Popover2InteractionKind,
Popover2SharedProps,
StrictModifierNames,
} from "@blueprintjs/popover2";
import { FilmSelect } from "@blueprintjs/select/examples";
import { FilmSelect } from "@blueprintjs/select/examples";
const POPPER_DOCS_URL = "https://popper.js.org/docs/v2/";
const INTERACTION_KINDS = [
{ label: "Click", value: "click" }, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/popover2-examples/popover2Example.tsx |
arrayContainsFilm,
createFilms,
filterFilm,
getFilmItemProps,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmsMenuItem,
TOP_100_FILMS,
| </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add </s> remove } from "../../common/films";
</s> add } from "@blueprintjs/select/examples";
| Film, | arrayContainsFilm,
createFilms,
Film,
filterFilm,
getFilmItemProps,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmsMenuItem,
TOP_100_FILMS, | [
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
arrayContainsFilm,
createFilms,
filterFilm,
getFilmItemProps,
IFilm,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmsMenuItem,
TOP_100_FILMS,
} from "../../common/films";
| </s> remove } from "../../common/films";
</s> add } from "@blueprintjs/select/examples";
</s> remove IFilm,
</s> add </s> remove IFilm,
</s> add | arrayContainsFilm,
createFilms,
filterFilm,
getFilmItemProps,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmsMenuItem,
TOP_100_FILMS,
} from "../../common/films"; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
|
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmsMenuItem,
TOP_100_FILMS,
} from "../../common/films";
import { PropCodeTooltip } from "../../common/propCodeTooltip";
const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
const INTENTS = [Intent.NONE, Intent.PRIMARY, Intent.SUCCESS, Intent.DANGER, Intent.WARNING];
| </s> remove const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect2.ofType<Film>(); </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove IFilm,
</s> add </s> remove const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect2.ofType<Film>(); | } from "@blueprintjs/select/examples";
| maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmsMenuItem,
TOP_100_FILMS,
} from "@blueprintjs/select/examples";
import { PropCodeTooltip } from "../../common/propCodeTooltip";
const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
const INTENTS = [Intent.NONE, Intent.PRIMARY, Intent.SUCCESS, Intent.DANGER, Intent.WARNING]; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
TOP_100_FILMS,
} from "../../common/films";
import { PropCodeTooltip } from "../../common/propCodeTooltip";
const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
const INTENTS = [Intent.NONE, Intent.PRIMARY, Intent.SUCCESS, Intent.DANGER, Intent.WARNING];
export interface IMultiSelectExampleState {
allowCreate: boolean;
| </s> remove } from "../../common/films";
</s> add } from "@blueprintjs/select/examples";
</s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove const FilmOmnibar = Omnibar.ofType<IFilm>();
</s> add const FilmOmnibar = Omnibar.ofType<Film>(); </s> remove } from "./../../common/films";
</s> add } from "@blueprintjs/select/examples"; </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { | const FilmMultiSelect = MultiSelect2.ofType<Film>(); | TOP_100_FILMS,
} from "../../common/films";
import { PropCodeTooltip } from "../../common/propCodeTooltip";
const FilmMultiSelect = MultiSelect2.ofType<Film>();
const INTENTS = [Intent.NONE, Intent.PRIMARY, Intent.SUCCESS, Intent.DANGER, Intent.WARNING];
export interface IMultiSelectExampleState {
allowCreate: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
const INTENTS = [Intent.NONE, Intent.PRIMARY, Intent.SUCCESS, Intent.DANGER, Intent.WARNING];
export interface IMultiSelectExampleState {
allowCreate: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
films: IFilm[];
hasInitialContent: boolean;
intent: boolean;
| </s> remove films: IFilm[];
</s> add films: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect2.ofType<Film>(); </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { | createdItems: Film[]; | const INTENTS = [Intent.NONE, Intent.PRIMARY, Intent.SUCCESS, Intent.DANGER, Intent.WARNING];
export interface IMultiSelectExampleState {
allowCreate: boolean;
createdItems: Film[];
disabled: boolean;
fill: boolean;
films: IFilm[];
hasInitialContent: boolean;
intent: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
allowCreate: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
films: IFilm[];
hasInitialContent: boolean;
intent: boolean;
items: IFilm[];
matchTargetWidth: boolean;
openOnKeyDown: boolean;
| </s> remove items: IFilm[];
</s> add items: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove film: IFilm;
items: IFilm[];
</s> add film: Film;
items: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | films: Film[]; | allowCreate: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
films: Film[];
hasInitialContent: boolean;
intent: boolean;
items: IFilm[];
matchTargetWidth: boolean;
openOnKeyDown: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
fill: boolean;
films: IFilm[];
hasInitialContent: boolean;
intent: boolean;
items: IFilm[];
matchTargetWidth: boolean;
openOnKeyDown: boolean;
popoverMinimal: boolean;
resetOnSelect: boolean;
showClearButton: boolean;
| </s> remove films: IFilm[];
</s> add films: Film[]; </s> remove film: IFilm;
items: IFilm[];
</s> add film: Film;
items: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | items: Film[]; | fill: boolean;
films: IFilm[];
hasInitialContent: boolean;
intent: boolean;
items: Film[];
matchTargetWidth: boolean;
openOnKeyDown: boolean;
popoverMinimal: boolean;
resetOnSelect: boolean;
showClearButton: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
</>
);
}
private renderTag = (film: IFilm) => film.title;
private renderFilm: ItemRenderer<IFilm> = (film, props) => {
if (!props.modifiers.matchesPredicate) {
return null;
}
| </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private handleItemSelect = (film: IFilm) => {
</s> add private handleItemSelect = (film: Film) => { | private renderTag = (film: Film) => film.title; | </>
);
}
private renderTag = (film: Film) => film.title;
private renderFilm: ItemRenderer<IFilm> = (film, props) => {
if (!props.modifiers.matchesPredicate) {
return null;
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
}
private renderTag = (film: IFilm) => film.title;
private renderFilm: ItemRenderer<IFilm> = (film, props) => {
if (!props.modifiers.matchesPredicate) {
return null;
}
return (
| </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private handleItemSelect = (film: IFilm) => {
</s> add private handleItemSelect = (film: Film) => { | private renderFilm: ItemRenderer<Film> = (film, props) => { | }
private renderTag = (film: IFilm) => film.title;
private renderFilm: ItemRenderer<Film> = (film, props) => {
if (!props.modifiers.matchesPredicate) {
return null;
}
return ( | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
private handleTagRemove = (_tag: React.ReactNode, index: number) => {
this.deselectFilm(index);
};
private getSelectedFilmIndex(film: IFilm) {
return this.state.films.indexOf(film);
}
private isFilmSelected(film: IFilm) {
return this.getSelectedFilmIndex(film) !== -1;
| </s> remove private isFilmSelected(film: IFilm) {
</s> add private isFilmSelected(film: Film) { </s> remove private selectFilm(film: IFilm) {
</s> add private selectFilm(film: Film) { </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { | private getSelectedFilmIndex(film: Film) { | private handleTagRemove = (_tag: React.ReactNode, index: number) => {
this.deselectFilm(index);
};
private getSelectedFilmIndex(film: Film) {
return this.state.films.indexOf(film);
}
private isFilmSelected(film: IFilm) {
return this.getSelectedFilmIndex(film) !== -1; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
private getSelectedFilmIndex(film: IFilm) {
return this.state.films.indexOf(film);
}
private isFilmSelected(film: IFilm) {
return this.getSelectedFilmIndex(film) !== -1;
}
private selectFilm(film: IFilm) {
this.selectFilms([film]);
| </s> remove private getSelectedFilmIndex(film: IFilm) {
</s> add private getSelectedFilmIndex(film: Film) { </s> remove private selectFilm(film: IFilm) {
</s> add private selectFilm(film: Film) { </s> remove private selectFilms(filmsToSelect: IFilm[]) {
</s> add private selectFilms(filmsToSelect: Film[]) { </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; | private isFilmSelected(film: Film) { | private getSelectedFilmIndex(film: IFilm) {
return this.state.films.indexOf(film);
}
private isFilmSelected(film: Film) {
return this.getSelectedFilmIndex(film) !== -1;
}
private selectFilm(film: IFilm) {
this.selectFilms([film]); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
private isFilmSelected(film: IFilm) {
return this.getSelectedFilmIndex(film) !== -1;
}
private selectFilm(film: IFilm) {
this.selectFilms([film]);
}
private selectFilms(filmsToSelect: IFilm[]) {
this.setState(({ createdItems, films, items }) => {
| </s> remove private selectFilms(filmsToSelect: IFilm[]) {
</s> add private selectFilms(filmsToSelect: Film[]) { </s> remove private isFilmSelected(film: IFilm) {
</s> add private isFilmSelected(film: Film) { </s> remove private getSelectedFilmIndex(film: IFilm) {
</s> add private getSelectedFilmIndex(film: Film) { </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; | private selectFilm(film: Film) { | private isFilmSelected(film: IFilm) {
return this.getSelectedFilmIndex(film) !== -1;
}
private selectFilm(film: Film) {
this.selectFilms([film]);
}
private selectFilms(filmsToSelect: IFilm[]) {
this.setState(({ createdItems, films, items }) => { | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
private selectFilm(film: IFilm) {
this.selectFilms([film]);
}
private selectFilms(filmsToSelect: IFilm[]) {
this.setState(({ createdItems, films, items }) => {
let nextCreatedItems = createdItems.slice();
let nextFilms = films.slice();
let nextItems = items.slice();
| </s> remove private selectFilm(film: IFilm) {
</s> add private selectFilm(film: Film) { </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private isFilmSelected(film: IFilm) {
</s> add private isFilmSelected(film: Film) { </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { | private selectFilms(filmsToSelect: Film[]) { | private selectFilm(film: IFilm) {
this.selectFilms([film]);
}
private selectFilms(filmsToSelect: Film[]) {
this.setState(({ createdItems, films, items }) => {
let nextCreatedItems = createdItems.slice();
let nextFilms = films.slice();
let nextItems = items.slice();
| [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
items: nextItems,
});
}
private handleFilmSelect = (film: IFilm) => {
if (!this.isFilmSelected(film)) {
this.selectFilm(film);
} else {
this.deselectFilm(this.getSelectedFilmIndex(film));
}
| </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove private handleItemSelect = (film: IFilm) => {
</s> add private handleItemSelect = (film: Film) => { | private handleFilmSelect = (film: Film) => { | items: nextItems,
});
}
private handleFilmSelect = (film: Film) => {
if (!this.isFilmSelected(film)) {
this.selectFilm(film);
} else {
this.deselectFilm(this.getSelectedFilmIndex(film));
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
this.deselectFilm(this.getSelectedFilmIndex(film));
}
};
private handleFilmsPaste = (films: IFilm[]) => {
// On paste, don't bother with deselecting already selected values, just
// add the new ones.
this.selectFilms(films);
};
| </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private selectFilms(filmsToSelect: IFilm[]) {
</s> add private selectFilms(filmsToSelect: Film[]) { </s> remove private getSelectedFilmIndex(film: IFilm) {
</s> add private getSelectedFilmIndex(film: Film) { | private handleFilmsPaste = (films: Film[]) => { | this.deselectFilm(this.getSelectedFilmIndex(film));
}
};
private handleFilmsPaste = (films: Film[]) => {
// On paste, don't bother with deselecting already selected values, just
// add the new ones.
this.selectFilms(films);
};
| [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/multiSelectExample.tsx |
areFilmsEqual,
createFilm,
filterFilm,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
| </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add | Film, | areFilmsEqual,
createFilm,
Film,
filterFilm,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS, | [
"keep",
"add",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/omnibarExample.tsx |
import {
areFilmsEqual,
createFilm,
filterFilm,
IFilm,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
} from "./../../common/films";
| </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add | import {
areFilmsEqual,
createFilm,
filterFilm,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
} from "./../../common/films";
| [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/omnibarExample.tsx |
|
IFilm,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
} from "./../../common/films";
const FilmOmnibar = Omnibar.ofType<IFilm>();
export interface IOmnibarExampleState {
allowCreate: boolean;
| </s> remove const FilmOmnibar = Omnibar.ofType<IFilm>();
</s> add const FilmOmnibar = Omnibar.ofType<Film>(); </s> remove } from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add } from "@blueprintjs/select/examples"; </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { </s> remove IFilm,
</s> add </s> remove const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect2.ofType<Film>(); | } from "@blueprintjs/select/examples"; | IFilm,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
} from "@blueprintjs/select/examples";
const FilmOmnibar = Omnibar.ofType<IFilm>();
export interface IOmnibarExampleState {
allowCreate: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/omnibarExample.tsx |
renderFilm,
TOP_100_FILMS,
} from "./../../common/films";
const FilmOmnibar = Omnibar.ofType<IFilm>();
export interface IOmnibarExampleState {
allowCreate: boolean;
isOpen: boolean;
resetOnSelect: boolean;
| </s> remove } from "./../../common/films";
</s> add } from "@blueprintjs/select/examples"; </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { </s> remove } from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add } from "@blueprintjs/select/examples"; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | const FilmOmnibar = Omnibar.ofType<Film>(); | renderFilm,
TOP_100_FILMS,
} from "./../../common/films";
const FilmOmnibar = Omnibar.ofType<Film>();
export interface IOmnibarExampleState {
allowCreate: boolean;
isOpen: boolean;
resetOnSelect: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/omnibarExample.tsx |
private handleClick = (_event: React.MouseEvent<HTMLElement>) => {
this.setState({ isOpen: true });
};
private handleItemSelect = (film: IFilm) => {
this.setState({ isOpen: false });
this.toaster.show({
message: (
<span>
| </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private handleSwitchChange(prop: keyof ISuggestExampleState) {
</s> add private handleSwitchChange(prop: keyof SuggestExampleState) { </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { | private handleItemSelect = (film: Film) => { | private handleClick = (_event: React.MouseEvent<HTMLElement>) => {
this.setState({ isOpen: true });
};
private handleItemSelect = (film: Film) => {
this.setState({ isOpen: false });
this.toaster.show({
message: (
<span> | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/omnibarExample.tsx |
import * as React from "react";
import { H5, MenuItem, Switch } from "@blueprintjs/core";
import { Example, ExampleProps } from "@blueprintjs/docs-theme";
import { IFilm, TOP_100_FILMS } from "../../common/films";
import FilmSelect from "../../common/filmSelect";
export interface ISelectExampleState {
allowCreate: boolean;
createFirst: boolean;
createdItems: IFilm[];
| </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { | import { Film, FilmSelect, TOP_100_FILMS } from "@blueprintjs/select/examples"; | import * as React from "react";
import { H5, MenuItem, Switch } from "@blueprintjs/core";
import { Example, ExampleProps } from "@blueprintjs/docs-theme";
import { Film, FilmSelect, TOP_100_FILMS } from "@blueprintjs/select/examples";
import { Film, FilmSelect, TOP_100_FILMS } from "@blueprintjs/select/examples";
import { Film, FilmSelect, TOP_100_FILMS } from "@blueprintjs/select/examples";
export interface ISelectExampleState {
allowCreate: boolean;
createFirst: boolean;
createdItems: IFilm[]; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/selectExample.tsx |
export interface ISelectExampleState {
allowCreate: boolean;
createFirst: boolean;
createdItems: IFilm[];
disableItems: boolean;
disabled: boolean;
fill: boolean;
filterable: boolean;
hasInitialContent: boolean;
| </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove films: IFilm[];
</s> add films: Film[]; </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { </s> remove film: IFilm;
items: IFilm[];
</s> add film: Film;
items: Film[]; | createdItems: Film[]; |
export interface ISelectExampleState {
allowCreate: boolean;
createFirst: boolean;
createdItems: Film[];
disableItems: boolean;
disabled: boolean;
fill: boolean;
filterable: boolean;
hasInitialContent: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/selectExample.tsx |
this.setState(state => ({ ...state, [prop]: checked }));
};
}
private isItemDisabled = (film: IFilm) => this.state.disableItems && film.year < 2000;
}
| </s> remove private handleSwitchChange(prop: keyof ISuggestExampleState) {
</s> add private handleSwitchChange(prop: keyof SuggestExampleState) { </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; | private isItemDisabled = (film: Film) => this.state.disableItems && film.year < 2000; | this.setState(state => ({ ...state, [prop]: checked }));
};
}
private isItemDisabled = (film: Film) => this.state.disableItems && film.year < 2000;
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/selectExample.tsx |
import {
areFilmsEqual,
createFilm,
filterFilm,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmMenuItem,
renderFilm,
| </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add | Film, | import {
areFilmsEqual,
createFilm,
Film,
filterFilm,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmMenuItem,
renderFilm, | [
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
import {
areFilmsEqual,
createFilm,
filterFilm,
IFilm,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
| </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add </s> remove IFilm,
</s> add | import {
areFilmsEqual,
createFilm,
filterFilm,
maybeAddCreatedFilmToArrays,
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
|
maybeDeleteCreatedFilmFromArrays,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
} from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
export interface ISuggestExampleState {
allowCreate: boolean;
closeOnSelect: boolean;
createdItems: IFilm[];
| </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove } from "./../../common/films";
</s> add } from "@blueprintjs/select/examples"; </s> remove const FilmOmnibar = Omnibar.ofType<IFilm>();
</s> add const FilmOmnibar = Omnibar.ofType<Film>(); </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | } from "@blueprintjs/select/examples"; | maybeDeleteCreatedFilmFromArrays,
renderCreateFilmMenuItem,
renderFilm,
TOP_100_FILMS,
} from "@blueprintjs/select/examples";
} from "@blueprintjs/select/examples";
} from "@blueprintjs/select/examples";
export interface ISuggestExampleState {
allowCreate: boolean;
closeOnSelect: boolean;
createdItems: IFilm[]; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
} from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
export interface ISuggestExampleState {
allowCreate: boolean;
closeOnSelect: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
| </s> remove } from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add } from "@blueprintjs/select/examples"; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove films: IFilm[];
</s> add films: Film[]; | export interface SuggestExampleState { | } from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
export interface SuggestExampleState {
allowCreate: boolean;
closeOnSelect: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
export interface ISuggestExampleState {
allowCreate: boolean;
closeOnSelect: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
film: IFilm;
items: IFilm[];
matchTargetWidth: boolean;
| </s> remove film: IFilm;
items: IFilm[];
</s> add film: Film;
items: Film[]; </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { </s> remove films: IFilm[];
</s> add films: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | createdItems: Film[]; |
export interface ISuggestExampleState {
allowCreate: boolean;
closeOnSelect: boolean;
createdItems: Film[];
disabled: boolean;
fill: boolean;
film: IFilm;
items: IFilm[];
matchTargetWidth: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
closeOnSelect: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
film: IFilm;
items: IFilm[];
matchTargetWidth: boolean;
minimal: boolean;
openOnKeyDown: boolean;
resetOnClose: boolean;
resetOnQuery: boolean;
| </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove films: IFilm[];
</s> add films: Film[]; </s> remove items: IFilm[];
</s> add items: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | film: Film;
items: Film[]; | closeOnSelect: boolean;
createdItems: IFilm[];
disabled: boolean;
fill: boolean;
film: Film;
items: Film[];
film: Film;
items: Film[];
matchTargetWidth: boolean;
minimal: boolean;
openOnKeyDown: boolean;
resetOnClose: boolean;
resetOnQuery: boolean; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
resetOnQuery: boolean;
resetOnSelect: boolean;
}
export class SuggestExample extends React.PureComponent<ExampleProps, ISuggestExampleState> {
public state: ISuggestExampleState = {
allowCreate: false,
closeOnSelect: true,
createdItems: [],
disabled: false,
fill: false,
| </s> remove export interface ISuggestExampleState {
</s> add export interface SuggestExampleState { </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; </s> remove } from "./../../common/films";
const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add } from "@blueprintjs/select/examples"; </s> remove createdItems: IFilm[];
</s> add createdItems: Film[]; | export class SuggestExample extends React.PureComponent<ExampleProps, SuggestExampleState> {
public state: SuggestExampleState = { | resetOnQuery: boolean;
resetOnSelect: boolean;
}
export class SuggestExample extends React.PureComponent<ExampleProps, SuggestExampleState> {
public state: SuggestExampleState = {
export class SuggestExample extends React.PureComponent<ExampleProps, SuggestExampleState> {
public state: SuggestExampleState = {
allowCreate: false,
closeOnSelect: true,
createdItems: [],
disabled: false,
fill: false, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
const maybeCreateNewItemRenderer = allowCreate ? renderCreateFilmMenuItem : null;
return (
<Example options={this.renderOptions()} {...this.props}>
<FilmSuggest
{...flags}
createNewItemFromQuery={maybeCreateNewItemFromQuery}
createNewItemRenderer={maybeCreateNewItemRenderer}
inputValueRenderer={this.renderInputValue}
items={this.state.items}
| </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
</s> add function mountForPasteTest(overrideProps: Partial<QueryListProps<Film>> = {}) { </s> remove const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
</s> add const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => { </s> remove const itemListRenderer: ItemListRenderer<IFilm> = props => (
</s> add const itemListRenderer: ItemListRenderer<Film> = props => ( </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; | <Suggest2<Film> | const maybeCreateNewItemRenderer = allowCreate ? renderCreateFilmMenuItem : null;
return (
<Example options={this.renderOptions()} {...this.props}>
<Suggest2<Film>
{...flags}
createNewItemFromQuery={maybeCreateNewItemFromQuery}
createNewItemRenderer={maybeCreateNewItemRenderer}
inputValueRenderer={this.renderInputValue}
items={this.state.items} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
</>
);
}
private renderInputValue = (film: IFilm) => film.title;
private handleValueChange = (film: IFilm) => {
// delete the old film from the list if it was newly created
const { createdItems, items } = maybeDeleteCreatedFilmFromArrays(
this.state.items,
| </s> remove private handleValueChange = (film: IFilm) => {
</s> add private handleValueChange = (film: Film) => { </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private handleItemSelect = (film: IFilm) => {
</s> add private handleItemSelect = (film: Film) => { | private renderInputValue = (film: Film) => film.title; | </>
);
}
private renderInputValue = (film: Film) => film.title;
private handleValueChange = (film: IFilm) => {
// delete the old film from the list if it was newly created
const { createdItems, items } = maybeDeleteCreatedFilmFromArrays(
this.state.items, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
}
private renderInputValue = (film: IFilm) => film.title;
private handleValueChange = (film: IFilm) => {
// delete the old film from the list if it was newly created
const { createdItems, items } = maybeDeleteCreatedFilmFromArrays(
this.state.items,
this.state.createdItems,
this.state.film,
| </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private renderFilm: ItemRenderer<IFilm> = (film, props) => {
</s> add private renderFilm: ItemRenderer<Film> = (film, props) => { </s> remove private handleFilmSelect = (film: IFilm) => {
</s> add private handleFilmSelect = (film: Film) => { </s> remove private handleItemSelect = (film: IFilm) => {
</s> add private handleItemSelect = (film: Film) => { | private handleValueChange = (film: Film) => { | }
private renderInputValue = (film: IFilm) => film.title;
private handleValueChange = (film: Film) => {
// delete the old film from the list if it was newly created
const { createdItems, items } = maybeDeleteCreatedFilmFromArrays(
this.state.items,
this.state.createdItems,
this.state.film, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
);
this.setState({ createdItems: nextCreatedItems, film, items: nextItems });
};
private handleSwitchChange(prop: keyof ISuggestExampleState) {
return (event: React.FormEvent<HTMLInputElement>) => {
const checked = event.currentTarget.checked;
this.setState(state => ({ ...state, [prop]: checked }));
};
}
| </s> remove private isItemDisabled = (film: IFilm) => this.state.disableItems && film.year < 2000;
</s> add private isItemDisabled = (film: Film) => this.state.disableItems && film.year < 2000; </s> remove private handleItemSelect = (film: IFilm) => {
</s> add private handleItemSelect = (film: Film) => { </s> remove private getSelectedFilmIndex(film: IFilm) {
</s> add private getSelectedFilmIndex(film: Film) { </s> remove private renderTag = (film: IFilm) => film.title;
</s> add private renderTag = (film: Film) => film.title; </s> remove private selectFilms(filmsToSelect: IFilm[]) {
</s> add private selectFilms(filmsToSelect: Film[]) { | private handleSwitchChange(prop: keyof SuggestExampleState) { | );
this.setState({ createdItems: nextCreatedItems, film, items: nextItems });
};
private handleSwitchChange(prop: keyof SuggestExampleState) {
return (event: React.FormEvent<HTMLInputElement>) => {
const checked = event.currentTarget.checked;
this.setState(state => ({ ...state, [prop]: checked }));
};
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/docs-app/src/examples/select-examples/suggestExample.tsx |
...eslintPluginRules,
},
overrides: [
{
files: ["*.js"],
env: {
node: true,
es6: true,
},
},
| </s> remove
import FilmSelect from "../../common/filmSelect";
</s> add import { FilmSelect } from "@blueprintjs/select/examples"; </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add | files: ["*.js", "*.mjs"], | ...eslintPluginRules,
},
overrides: [
{
files: ["*.js", "*.mjs"],
env: {
node: true,
es6: true,
},
}, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/eslint-config/index.js |
env: {
node: true,
es6: true,
},
},
{
files: ["**/*.{ts,tsx}"],
env: {
browser: true,
| </s> remove files: ["*.js"],
</s> add files: ["*.js", "*.mjs"], </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add const FilmSuggest = Suggest2.ofType<Film>(); | parserOptions: {
ecmaVersion: 2022,
sourceType: "module",
}, | env: {
node: true,
es6: true,
},
parserOptions: {
ecmaVersion: 2022,
sourceType: "module",
},
},
{
files: ["**/*.{ts,tsx}"],
env: {
browser: true, | [
"keep",
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/eslint-config/index.js |
"core-js",
"date-fns",
"react-dom",
"@blueprintjs/table/src",
"@blueprintjs/test-commons/bootstrap",
"tsutils"
]
},
| </s> remove files: ["*.js"],
</s> add files: ["*.js", "*.mjs"], </s> remove "parserOptions": {
"ecmaVersion": 2022,
"sourceType": "module"
},
</s> add </s> remove
import FilmSelect from "../../common/filmSelect";
</s> add import { FilmSelect } from "@blueprintjs/select/examples"; </s> remove </FilmSelect>,
</s> add </Select>, | "@blueprintjs/select/examples", | "core-js",
"date-fns",
"react-dom",
"@blueprintjs/select/examples",
"@blueprintjs/table/src",
"@blueprintjs/test-commons/bootstrap",
"tsutils"
]
}, | [
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/eslint-config/tslint.json |
{
"parserOptions": {
"ecmaVersion": 2022,
"sourceType": "module"
},
"rules": {
"no-console": "off"
}
}
| </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add const FilmSuggest = Suggest2.ofType<Film>(); | {
"rules": {
"no-console": "off"
}
} | [
"keep",
"replace",
"replace",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/node-build-scripts/.eslintrc.json |
|
const baseConfig = createKarmaConfig({
dirname: __dirname,
});
config.set(baseConfig);
};
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | coverageExcludes: ["src/__examples__/*"], | const baseConfig = createKarmaConfig({
dirname: __dirname,
coverageExcludes: ["src/__examples__/*"],
});
config.set(baseConfig);
}; | [
"keep",
"add",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/karma.conf.js |
import { Classes as CoreClasses, Keys, Tag } from "@blueprintjs/core";
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
// this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
import { ItemRendererProps, MultiSelect2, MultiSelect2Props, MultiSelect2State } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<MultiSelect2>", () => {
| </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
</s> add type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>; </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add |
import { Classes as CoreClasses, Keys, Tag } from "@blueprintjs/core";
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
import { ItemRendererProps, MultiSelect2, MultiSelect2Props, MultiSelect2State } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<MultiSelect2>", () => { | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
|
import { Classes as CoreClasses, Keys, Tag } from "@blueprintjs/core";
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
import { ItemRendererProps, MultiSelect2, MultiSelect2Props, MultiSelect2State } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<MultiSelect2>", () => {
| </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add | import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__"; | import { Classes as CoreClasses, Keys, Tag } from "@blueprintjs/core";
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
import { ItemRendererProps, MultiSelect2, MultiSelect2Props, MultiSelect2State } from "../src";
import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<MultiSelect2>", () => { | [
"keep",
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<MultiSelect2>", () => {
const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as IFilm[],
| </s> remove const FilmMultiSelect = MultiSelect.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect.ofType<Film>(); </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add const FilmSuggest = Suggest2.ofType<Film>(); </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest.ofType<IFilm>();
</s> add const FilmSuggest = Suggest.ofType<Film>(); | const FilmMultiSelect = MultiSelect2.ofType<Film>(); | import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<MultiSelect2>", () => {
const FilmMultiSelect = MultiSelect2.ofType<Film>();
const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as IFilm[], | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as IFilm[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
| </s> remove selectedItems: [] as IFilm[],
</s> add selectedItems: [] as Film[], </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; | selectedItems: [] as Film[], | const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as Film[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
selectedItems: [] as IFilm[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
onItemSelect: sinon.SinonSpy;
};
let testsContainerElement: HTMLElement | undefined;
beforeEach(() => {
| </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove inputValueRenderer: sinon.SinonSpy<[IFilm], string>;
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add inputValueRenderer: sinon.SinonSpy<[Film], string>;
itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove selectedItems: [] as IFilm[],
</s> add selectedItems: [] as Film[], | itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; | selectedItems: [] as IFilm[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>;
itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>;
onItemSelect: sinon.SinonSpy;
};
let testsContainerElement: HTMLElement | undefined;
beforeEach(() => { | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
afterEach(() => {
testsContainerElement?.remove();
});
selectComponentSuite<MultiSelect2Props<IFilm>, MultiSelect2State>(props =>
mount(
<MultiSelect2
selectedItems={[]}
{...props}
popoverProps={{ isOpen: true, usePortal: false }}
| </s> remove selectComponentSuite<Suggest2Props<IFilm>, Suggest2State<IFilm>>(props =>
</s> add selectComponentSuite<Suggest2Props<Film>, Suggest2State<Film>>(props => </s> remove selectComponentSuite<ISelectProps<IFilm>, ISelectState>(props =>
</s> add selectComponentSuite<ISelectProps<Film>, ISelectState>(props => </s> remove selectComponentSuite<Select2Props<IFilm>, Select2State>(props =>
</s> add selectComponentSuite<Select2Props<Film>, Select2State>(props => </s> remove selectComponentSuite<ISuggestProps<IFilm>, ISuggestState<IFilm>>(props =>
</s> add selectComponentSuite<ISuggestProps<Film>, ISuggestState<Film>>(props => </s> remove selectPopoverTestSuite<MultiSelect2Props<IFilm>, MultiSelect2State>(props =>
</s> add selectPopoverTestSuite<MultiSelect2Props<Film>, MultiSelect2State>(props => | selectComponentSuite<MultiSelect2Props<Film>, MultiSelect2State>(props => | afterEach(() => {
testsContainerElement?.remove();
});
selectComponentSuite<MultiSelect2Props<Film>, MultiSelect2State>(props =>
mount(
<MultiSelect2
selectedItems={[]}
{...props}
popoverProps={{ isOpen: true, usePortal: false }} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
/>,
),
);
selectPopoverTestSuite<MultiSelect2Props<IFilm>, MultiSelect2State>(props =>
mount(<MultiSelect2 {...props} selectedItems={[]} tagRenderer={renderTag} />, {
attachTo: testsContainerElement,
}),
);
| </s> remove selectPopoverTestSuite<Suggest2Props<IFilm>, Suggest2State<IFilm>>(props =>
</s> add selectPopoverTestSuite<Suggest2Props<Film>, Suggest2State<Film>>(props => </s> remove selectComponentSuite<Select2Props<IFilm>, Select2State>(props =>
</s> add selectComponentSuite<Select2Props<Film>, Select2State>(props => </s> remove selectPopoverTestSuite<Select2Props<IFilm>, Select2State>(props =>
</s> add selectPopoverTestSuite<Select2Props<Film>, Select2State>(props => </s> remove selectComponentSuite<MultiSelect2Props<IFilm>, MultiSelect2State>(props =>
</s> add selectComponentSuite<MultiSelect2Props<Film>, MultiSelect2State>(props => </s> remove selectComponentSuite<IMultiSelectProps<IFilm>, IMultiSelectState>(props =>
</s> add selectComponentSuite<IMultiSelectProps<Film>, IMultiSelectState>(props => | selectPopoverTestSuite<MultiSelect2Props<Film>, MultiSelect2State>(props => | />,
),
);
selectPopoverTestSuite<MultiSelect2Props<Film>, MultiSelect2State>(props =>
mount(<MultiSelect2 {...props} selectedItems={[]} tagRenderer={renderTag} />, {
attachTo: testsContainerElement,
}),
);
| [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
wrapper.find(`.${CoreClasses.TAG_REMOVE}`).at(1).simulate("click");
assert.isTrue(handleRemove.calledOnceWithExactly(TOP_100_FILMS[3], 1));
});
function multiselect(props: Partial<MultiSelect2Props<IFilm>> = {}, query?: string) {
const wrapper = mount(
<FilmMultiSelect {...defaultProps} {...handlers} {...props}>
<article />
</FilmMultiSelect>,
);
| </s> remove function multiselect(props: Partial<IMultiSelectProps<IFilm>> = {}, query?: string) {
</s> add function multiselect(props: Partial<IMultiSelectProps<Film>> = {}, query?: string) { </s> remove function select(props: Partial<Select2Props<IFilm>> = {}, query?: string) {
</s> add function select(props: Partial<Select2Props<Film>> = {}, query?: string) { </s> remove <FilmSelect {...defaultProps} {...handlers} {...props}>
</s> add <Select2<Film> {...defaultProps} {...handlers} {...props}> </s> remove <FilmSelect {...defaultProps} {...handlers} {...props}>
</s> add <Select<Film> {...defaultProps} {...handlers} {...props}> </s> remove function select(props: Partial<ISelectProps<IFilm>> = {}, query?: string) {
</s> add function select(props: Partial<ISelectProps<Film>> = {}, query?: string) { | function multiselect(props: Partial<MultiSelect2Props<Film>> = {}, query?: string) { | wrapper.find(`.${CoreClasses.TAG_REMOVE}`).at(1).simulate("click");
assert.isTrue(handleRemove.calledOnceWithExactly(TOP_100_FILMS[3], 1));
});
function multiselect(props: Partial<MultiSelect2Props<Film>> = {}, query?: string) {
const wrapper = mount(
<FilmMultiSelect {...defaultProps} {...handlers} {...props}>
<article />
</FilmMultiSelect>,
); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
return wrapper;
}
});
function renderTag(film: IFilm) {
return film.title;
}
function filterByYear(query: string, film: IFilm) {
return query === "" || film.year.toString() === query;
| </s> remove function renderTag(film: IFilm) {
</s> add function renderTag(film: Film) { </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { | function renderTag(film: Film) { | return wrapper;
}
});
function renderTag(film: Film) {
return film.title;
}
function filterByYear(query: string, film: IFilm) {
return query === "" || film.year.toString() === query; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
function renderTag(film: IFilm) {
return film.title;
}
function filterByYear(query: string, film: IFilm) {
return query === "" || film.year.toString() === query;
}
| </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { </s> remove function renderTag(film: IFilm) {
</s> add function renderTag(film: Film) { </s> remove function renderTag(film: IFilm) {
</s> add function renderTag(film: Film) { </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { </s> remove function filterByYear(query: string, film: IFilm) {
</s> add function filterByYear(query: string, film: Film) { | function filterByYear(query: string, film: Film) { | function renderTag(film: IFilm) {
return film.title;
}
function filterByYear(query: string, film: Film) {
return query === "" || film.year.toString() === query;
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelect2Tests.tsx |
import { Classes as CoreClasses, Keys, Tag } from "@blueprintjs/core";
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
// this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
import { IMultiSelectProps, IMultiSelectState, ItemRendererProps, MultiSelect } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
describe("<MultiSelect>", () => {
const FilmMultiSelect = MultiSelect.ofType<IFilm>();
| </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
</s> add type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>; </s> remove const FilmMultiSelect = MultiSelect.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect.ofType<Film>(); |
import { Classes as CoreClasses, Keys, Tag } from "@blueprintjs/core";
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
import { IMultiSelectProps, IMultiSelectState, ItemRendererProps, MultiSelect } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
describe("<MultiSelect>", () => {
const FilmMultiSelect = MultiSelect.ofType<IFilm>(); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
|
import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
import { IMultiSelectProps, IMultiSelectState, ItemRendererProps, MultiSelect } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
describe("<MultiSelect>", () => {
const FilmMultiSelect = MultiSelect.ofType<Film>();
const defaultProps = {
items: TOP_100_FILMS,
| </s> remove const FilmMultiSelect = MultiSelect.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect.ofType<Film>(); </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add | import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__"; | import { dispatchTestKeyboardEventWithCode } from "@blueprintjs/test-commons";
import { IMultiSelectProps, IMultiSelectState, ItemRendererProps, MultiSelect } from "../src";
import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__";
import { selectComponentSuite } from "./selectComponentSuite";
describe("<MultiSelect>", () => {
const FilmMultiSelect = MultiSelect.ofType<Film>();
const defaultProps = {
items: TOP_100_FILMS, | [
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
import { IMultiSelectProps, IMultiSelectState, ItemRendererProps, MultiSelect } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
describe("<MultiSelect>", () => {
const FilmMultiSelect = MultiSelect.ofType<IFilm>();
const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as IFilm[],
| </s> remove const FilmMultiSelect = MultiSelect2.ofType<IFilm>();
</s> add const FilmMultiSelect = MultiSelect2.ofType<Film>(); </s> remove const FilmSelect = Select.ofType<IFilm>();
</s> add </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add const FilmSuggest = Suggest2.ofType<Film>(); | const FilmMultiSelect = MultiSelect.ofType<Film>(); | import { IMultiSelectProps, IMultiSelectState, ItemRendererProps, MultiSelect } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
describe("<MultiSelect>", () => {
const FilmMultiSelect = MultiSelect.ofType<Film>();
const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as IFilm[], | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as IFilm[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
| </s> | selectedItems: [] as Film[], | const defaultProps = {
items: TOP_100_FILMS,
popoverProps: { isOpen: true, usePortal: false },
query: "",
selectedItems: [] as Film[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
selectedItems: [] as IFilm[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
onItemSelect: sinon.SinonSpy;
};
beforeEach(() => {
handlers = {
| </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove selectedItems: [] as IFilm[],
</s> add selectedItems: [] as Film[], </s> remove selectedItems: [] as IFilm[],
</s> add selectedItems: [] as Film[], </s> remove inputValueRenderer: sinon.SinonSpy<[IFilm], string>;
itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add inputValueRenderer: sinon.SinonSpy<[Film], string>;
itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; </s> remove itemPredicate: sinon.SinonSpy<[string, IFilm], boolean>;
itemRenderer: sinon.SinonSpy<[IFilm, ItemRendererProps], JSX.Element | null>;
</s> add itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; | itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>; | selectedItems: [] as IFilm[],
tagRenderer: renderTag,
};
let handlers: {
itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>;
itemPredicate: sinon.SinonSpy<[string, Film], boolean>;
itemRenderer: sinon.SinonSpy<[Film, ItemRendererProps], JSX.Element | null>;
onItemSelect: sinon.SinonSpy;
};
beforeEach(() => {
handlers = { | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
onItemSelect: sinon.spy(),
};
});
selectComponentSuite<IMultiSelectProps<IFilm>, IMultiSelectState>(props =>
mount(<MultiSelect {...props} popoverProps={{ isOpen: true, usePortal: false }} tagRenderer={renderTag} />),
);
it("placeholder can be controlled with placeholder prop", () => {
const placeholder = "look here";
| </s> remove selectComponentSuite<ISuggestProps<IFilm>, ISuggestState<IFilm>>(props =>
</s> add selectComponentSuite<ISuggestProps<Film>, ISuggestState<Film>>(props => </s> remove selectComponentSuite<Select2Props<IFilm>, Select2State>(props =>
</s> add selectComponentSuite<Select2Props<Film>, Select2State>(props => </s> remove selectComponentSuite<ISelectProps<IFilm>, ISelectState>(props =>
</s> add selectComponentSuite<ISelectProps<Film>, ISelectState>(props => </s> remove selectPopoverTestSuite<Select2Props<IFilm>, Select2State>(props =>
</s> add selectPopoverTestSuite<Select2Props<Film>, Select2State>(props => </s> remove selectComponentSuite<Suggest2Props<IFilm>, Suggest2State<IFilm>>(props =>
</s> add selectComponentSuite<Suggest2Props<Film>, Suggest2State<Film>>(props => | selectComponentSuite<IMultiSelectProps<Film>, IMultiSelectState>(props => | onItemSelect: sinon.spy(),
};
});
selectComponentSuite<IMultiSelectProps<Film>, IMultiSelectState>(props =>
mount(<MultiSelect {...props} popoverProps={{ isOpen: true, usePortal: false }} tagRenderer={renderTag} />),
);
it("placeholder can be controlled with placeholder prop", () => {
const placeholder = "look here"; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
wrapper.find(`.${CoreClasses.TAG_REMOVE}`).at(1).simulate("click");
assert.isTrue(handleRemove.calledOnceWithExactly(TOP_100_FILMS[3], 1));
});
function multiselect(props: Partial<IMultiSelectProps<IFilm>> = {}, query?: string) {
const wrapper = mount(
<FilmMultiSelect {...defaultProps} {...handlers} {...props}>
<article />
</FilmMultiSelect>,
);
| </s> remove function multiselect(props: Partial<MultiSelect2Props<IFilm>> = {}, query?: string) {
</s> add function multiselect(props: Partial<MultiSelect2Props<Film>> = {}, query?: string) { </s> remove function select(props: Partial<Select2Props<IFilm>> = {}, query?: string) {
</s> add function select(props: Partial<Select2Props<Film>> = {}, query?: string) { </s> remove <FilmSelect {...defaultProps} {...handlers} {...props}>
</s> add <Select2<Film> {...defaultProps} {...handlers} {...props}> </s> remove <FilmSelect {...defaultProps} {...handlers} {...props}>
</s> add <Select<Film> {...defaultProps} {...handlers} {...props}> </s> remove function select(props: Partial<ISelectProps<IFilm>> = {}, query?: string) {
</s> add function select(props: Partial<ISelectProps<Film>> = {}, query?: string) { | function multiselect(props: Partial<IMultiSelectProps<Film>> = {}, query?: string) { | wrapper.find(`.${CoreClasses.TAG_REMOVE}`).at(1).simulate("click");
assert.isTrue(handleRemove.calledOnceWithExactly(TOP_100_FILMS[3], 1));
});
function multiselect(props: Partial<IMultiSelectProps<Film>> = {}, query?: string) {
const wrapper = mount(
<FilmMultiSelect {...defaultProps} {...handlers} {...props}>
<article />
</FilmMultiSelect>,
); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
return wrapper;
}
});
function renderTag(film: IFilm) {
return film.title;
}
function filterByYear(query: string, film: IFilm) {
return query === "" || film.year.toString() === query;
| </s> | function renderTag(film: Film) { | return wrapper;
}
});
function renderTag(film: Film) {
return film.title;
}
function filterByYear(query: string, film: IFilm) {
return query === "" || film.year.toString() === query; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
function renderTag(film: IFilm) {
return film.title;
}
function filterByYear(query: string, film: IFilm) {
return query === "" || film.year.toString() === query;
}
| </s> | function filterByYear(query: string, film: Film) { | function renderTag(film: IFilm) {
return film.title;
}
function filterByYear(query: string, film: Film) {
return query === "" || film.year.toString() === query;
} | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/multiSelectTests.tsx |
import * as sinon from "sinon";
import { Menu } from "@blueprintjs/core";
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
import {
IQueryListState,
ItemListPredicate,
ItemListRenderer,
ItemPredicate,
| </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { areFilmsEqual, filterFilm, IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add | import * as sinon from "sinon";
import { Menu } from "@blueprintjs/core";
import {
IQueryListState,
ItemListPredicate,
ItemListRenderer,
ItemPredicate, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
|
QueryListProps,
QueryListRendererProps,
} from "../src";
type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>;
describe("<QueryList>", () => {
| </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
</s> add type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>; </s> remove const FilmQueryList = QueryList.ofType<IFilm>();
</s> add const FilmQueryList = QueryList.ofType<Film>(); | import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__"; | QueryListProps,
QueryListRendererProps,
} from "../src";
import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__";
type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>;
describe("<QueryList>", () => { | [
"keep",
"keep",
"add",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
QueryListProps,
QueryListRendererProps,
} from "../src";
// this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
describe("<QueryList>", () => {
const FilmQueryList = QueryList.ofType<IFilm>();
const testProps = {
itemRenderer: sinon.spy(renderFilm),
| </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove const FilmQueryList = QueryList.ofType<IFilm>();
</s> add const FilmQueryList = QueryList.ofType<Film>(); </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>; | QueryListProps,
QueryListRendererProps,
} from "../src";
type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>;
type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>;
type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>;
describe("<QueryList>", () => {
const FilmQueryList = QueryList.ofType<IFilm>();
const testProps = {
itemRenderer: sinon.spy(renderFilm), | [
"keep",
"keep",
"keep",
"keep",
"replace",
"replace",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
describe("<QueryList>", () => {
const FilmQueryList = QueryList.ofType<IFilm>();
const testProps = {
itemRenderer: sinon.spy(renderFilm),
items: TOP_100_FILMS.slice(0, 20),
onActiveItemChange: sinon.spy(),
onItemSelect: sinon.spy(),
| </s> remove // this is an awkward import across the monorepo, but we'd rather not introduce a cyclical dependency or create another package
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
</s> add type FilmQueryListWrapper = ReactWrapper<QueryListProps<Film>, IQueryListState<Film>>; </s> remove renderer: sinon.spy((props: QueryListRendererProps<IFilm>) => <div>{props.itemList}</div>),
</s> add renderer: sinon.spy((props: QueryListRendererProps<Film>) => <div>{props.itemList}</div>), </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove selectComponentSuite<IMultiSelectProps<IFilm>, IMultiSelectState>(props =>
</s> add selectComponentSuite<IMultiSelectProps<Film>, IMultiSelectState>(props => | const FilmQueryList = QueryList.ofType<Film>(); |
type FilmQueryListWrapper = ReactWrapper<QueryListProps<IFilm>, IQueryListState<IFilm>>;
describe("<QueryList>", () => {
const FilmQueryList = QueryList.ofType<Film>();
const testProps = {
itemRenderer: sinon.spy(renderFilm),
items: TOP_100_FILMS.slice(0, 20),
onActiveItemChange: sinon.spy(),
onItemSelect: sinon.spy(), | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
itemRenderer: sinon.spy(renderFilm),
items: TOP_100_FILMS.slice(0, 20),
onActiveItemChange: sinon.spy(),
onItemSelect: sinon.spy(),
renderer: sinon.spy((props: QueryListRendererProps<IFilm>) => <div>{props.itemList}</div>),
};
beforeEach(() => {
testProps.itemRenderer.resetHistory();
testProps.onActiveItemChange.resetHistory();
| </s> remove const FilmQueryList = QueryList.ofType<IFilm>();
</s> add const FilmQueryList = QueryList.ofType<Film>(); </s> remove selectComponentSuite<ISuggestProps<IFilm>, ISuggestState<IFilm>>(props =>
</s> add selectComponentSuite<ISuggestProps<Film>, ISuggestState<Film>>(props => </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove renderer: sinon.spy((listItemsProps: QueryListRendererProps<IFilm>) => {
</s> add renderer: sinon.spy((listItemsProps: QueryListRendererProps<Film>) => { </s> remove selectComponentSuite<IMultiSelectProps<IFilm>, IMultiSelectState>(props =>
</s> add selectComponentSuite<IMultiSelectProps<Film>, IMultiSelectState>(props => | renderer: sinon.spy((props: QueryListRendererProps<Film>) => <div>{props.itemList}</div>), | itemRenderer: sinon.spy(renderFilm),
items: TOP_100_FILMS.slice(0, 20),
onActiveItemChange: sinon.spy(),
onItemSelect: sinon.spy(),
renderer: sinon.spy((props: QueryListRendererProps<Film>) => <div>{props.itemList}</div>),
};
beforeEach(() => {
testProps.itemRenderer.resetHistory();
testProps.onActiveItemChange.resetHistory(); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
});
});
describe("itemListRenderer", () => {
const itemListRenderer: ItemListRenderer<IFilm> = props => (
<ul className="foo">{props.items.map(props.renderItem)}</ul>
);
it("renderItem calls itemRenderer", () => {
const wrapper = shallow(<FilmQueryList {...testProps} itemListRenderer={itemListRenderer} />);
| </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
</s> add const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query)); | const itemListRenderer: ItemListRenderer<Film> = props => ( | });
});
describe("itemListRenderer", () => {
const itemListRenderer: ItemListRenderer<Film> = props => (
<ul className="foo">{props.items.map(props.renderItem)}</ul>
);
it("renderItem calls itemRenderer", () => {
const wrapper = shallow(<FilmQueryList {...testProps} itemListRenderer={itemListRenderer} />); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
});
describe("filtering", () => {
it("itemPredicate filters each item by query", () => {
const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
shallow(<FilmQueryList {...testProps} itemPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, testProps.items.length, "called once per item");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
| </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
</s> add const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query)); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const itemListRenderer: ItemListRenderer<IFilm> = props => (
</s> add const itemListRenderer: ItemListRenderer<Film> = props => ( | const predicate = sinon.spy((query: string, film: Film) => film.year === +query); | });
describe("filtering", () => {
it("itemPredicate filters each item by query", () => {
const predicate = sinon.spy((query: string, film: Film) => film.year === +query);
shallow(<FilmQueryList {...testProps} itemPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, testProps.items.length, "called once per item");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994"); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
shallow(<FilmQueryList {...testProps} itemPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, testProps.items.length, "called once per item");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
});
it("itemListPredicate filters entire list by query", () => {
const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
| </s> remove const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
</s> add const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query)); </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
</s> add const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => { | const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; | const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
shallow(<FilmQueryList {...testProps} itemPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, testProps.items.length, "called once per item");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
});
it("itemListPredicate filters entire list by query", () => {
const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query)); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
});
it("itemListPredicate filters entire list by query", () => {
const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
shallow(<FilmQueryList {...testProps} itemListPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, 1, "called once for entire list");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
| </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const itemListRenderer: ItemListRenderer<IFilm> = props => (
</s> add const itemListRenderer: ItemListRenderer<Film> = props => ( | const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query)); | assert.lengthOf(filteredItems, 3, "returns only films from 1994");
});
it("itemListPredicate filters entire list by query", () => {
const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query));
shallow(<FilmQueryList {...testProps} itemListPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, 1, "called once for entire list");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994"); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
shallow(<FilmQueryList {...testProps} itemListPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, 1, "called once for entire list");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
});
it("prefers itemListPredicate if both are defined", () => {
const predicate = sinon.spy(() => true);
| </s> remove const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
</s> add const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query)); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const itemListRenderer: ItemListRenderer<IFilm> = props => (
</s> add const itemListRenderer: ItemListRenderer<Film> = props => ( | const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; | const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
shallow(<FilmQueryList {...testProps} itemListPredicate={predicate} query="1994" />);
assert.equal(predicate.callCount, 1, "called once for entire list");
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>;
assert.lengthOf(filteredItems, 3, "returns only films from 1994");
});
it("prefers itemListPredicate if both are defined", () => {
const predicate = sinon.spy(() => true); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
});
it("omitting both predicate props is supported", () => {
shallow(<FilmQueryList {...testProps} query="1980" />);
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
assert.lengthOf(filteredItems, testProps.items.length, "returns all films");
});
it("ensure onActiveItemChange is not called with undefined and empty list", () => {
const myItem = { title: "Toy Story 3", year: 2010, rank: 1 };
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const predicate = sinon.spy((query: string, films: IFilm[]) => films.filter(f => f.year === +query));
</s> add const predicate = sinon.spy((query: string, films: Film[]) => films.filter(f => f.year === +query)); | const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; | });
it("omitting both predicate props is supported", () => {
shallow(<FilmQueryList {...testProps} query="1980" />);
const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>;
assert.lengthOf(filteredItems, testProps.items.length, "returns all films");
});
it("ensure onActiveItemChange is not called with undefined and empty list", () => {
const myItem = { title: "Toy Story 3", year: 2010, rank: 1 }; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
});
it("ensure onActiveItemChange is not called updating props and query doesn't change", () => {
const myItem = { title: "Toy Story 3", year: 2010, rank: 1 };
const props: QueryListProps<IFilm> = {
...testProps,
activeItem: myItem,
items: [myItem],
query: "",
};
| </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | });
it("ensure onActiveItemChange is not called updating props and query doesn't change", () => {
const myItem = { title: "Toy Story 3", year: 2010, rank: 1 };
const props: QueryListProps<Film> = {
...testProps,
activeItem: myItem,
items: [myItem],
query: "",
}; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
assert.equal(testProps.onActiveItemChange.callCount, 0);
});
it("ensure activeItem changes on query change", () => {
const props: QueryListProps<IFilm> = {
...testProps,
items: [TOP_100_FILMS[0]],
query: "abc",
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />);
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | assert.equal(testProps.onActiveItemChange.callCount, 0);
});
it("ensure activeItem changes on query change", () => {
const props: QueryListProps<Film> = {
...testProps,
items: [TOP_100_FILMS[0]],
query: "abc",
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
assert.deepEqual(filmQueryList.state().activeItem, TOP_100_FILMS[1]);
});
it("ensure activeItem changes on when no longer in new items", () => {
const props: QueryListProps<IFilm> = {
...testProps,
items: [TOP_100_FILMS[0]],
query: "abc",
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />);
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | assert.deepEqual(filmQueryList.state().activeItem, TOP_100_FILMS[1]);
});
it("ensure activeItem changes on when no longer in new items", () => {
const props: QueryListProps<Film> = {
...testProps,
items: [TOP_100_FILMS[0]],
query: "abc",
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
});
describe("activeItem state initialization", () => {
it("initializes to first filtered item when uncontrolled", () => {
const props: QueryListProps<IFilm> = {
...testProps,
// Filter down to only item at index 11, so item at index 11 should be
// chosen as default activeItem
itemPredicate: (_query, item) => item === TOP_100_FILMS[11],
query: "123",
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const queryList = (wrapper.instance() as Suggest<IFilm> as any).queryList; // private ref
</s> add const queryList = (wrapper.instance() as Suggest<Film> as any).queryList; // private ref | const props: QueryListProps<Film> = { | });
describe("activeItem state initialization", () => {
it("initializes to first filtered item when uncontrolled", () => {
const props: QueryListProps<Film> = {
...testProps,
// Filter down to only item at index 11, so item at index 11 should be
// chosen as default activeItem
itemPredicate: (_query, item) => item === TOP_100_FILMS[11],
query: "123", | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
assert(filmQueryList.state().activeItem === TOP_100_FILMS[11]);
});
it("initializes to controlled activeItem prop (non-null)", () => {
const props: QueryListProps<IFilm> = {
...testProps,
// List is not filtered, and item at index 11 is explicitly chosen as activeItem
activeItem: TOP_100_FILMS[11],
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />);
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | assert(filmQueryList.state().activeItem === TOP_100_FILMS[11]);
});
it("initializes to controlled activeItem prop (non-null)", () => {
const props: QueryListProps<Film> = {
...testProps,
// List is not filtered, and item at index 11 is explicitly chosen as activeItem
activeItem: TOP_100_FILMS[11],
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
assert(filmQueryList.state().activeItem === TOP_100_FILMS[11]);
});
it("initializes to controlled activeItem prop (null)", () => {
const props: QueryListProps<IFilm> = {
...testProps,
activeItem: null,
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />);
assert(filmQueryList.state().activeItem === null);
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | assert(filmQueryList.state().activeItem === TOP_100_FILMS[11]);
});
it("initializes to controlled activeItem prop (null)", () => {
const props: QueryListProps<Film> = {
...testProps,
activeItem: null,
};
const filmQueryList: FilmQueryListWrapper = mount(<FilmQueryList {...props} />);
assert(filmQueryList.state().activeItem === null); | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
assert(filmQueryList.state().activeItem === null);
});
it("createNewItemPosition affects position of create new item", () => {
const props: QueryListProps<IFilm> = {
...testProps,
createNewItemFromQuery: sinon.spy(),
createNewItemRenderer: () => <article />,
items: TOP_100_FILMS.slice(0, 4),
query: "the",
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | assert(filmQueryList.state().activeItem === null);
});
it("createNewItemPosition affects position of create new item", () => {
const props: QueryListProps<Film> = {
...testProps,
createNewItemFromQuery: sinon.spy(),
createNewItemRenderer: () => <article />,
items: TOP_100_FILMS.slice(0, 4),
query: "the", | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
describe("pasting", () => {
const onItemsPaste = sinon.spy();
const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
return exactMatch === true ? query.toLowerCase() === film.title.toLowerCase() : true;
};
function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
// Placeholder. This will be overwritten by the mounted component.
| </s> remove function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
</s> add function mountForPasteTest(overrideProps: Partial<QueryListProps<Film>> = {}) { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const predicate = sinon.spy((query: string, film: IFilm) => film.year === +query);
</s> add const predicate = sinon.spy((query: string, film: Film) => film.year === +query); </s> remove const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<IFilm>;
</s> add const { filteredItems } = testProps.renderer.args[0][0] as QueryListRendererProps<Film>; </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => { |
describe("pasting", () => {
const onItemsPaste = sinon.spy();
const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => {
return exactMatch === true ? query.toLowerCase() === film.title.toLowerCase() : true;
};
function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
// Placeholder. This will be overwritten by the mounted component. | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
return exactMatch === true ? query.toLowerCase() === film.title.toLowerCase() : true;
};
function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
// Placeholder. This will be overwritten by the mounted component.
let handlePaste: (queries: string[]) => void;
const props: QueryListProps<IFilm> = {
...testProps,
| </s> remove const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
</s> add const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | function mountForPasteTest(overrideProps: Partial<QueryListProps<Film>> = {}) { | const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
return exactMatch === true ? query.toLowerCase() === film.title.toLowerCase() : true;
};
function mountForPasteTest(overrideProps: Partial<QueryListProps<Film>> = {}) {
// Placeholder. This will be overwritten by the mounted component.
let handlePaste: (queries: string[]) => void;
const props: QueryListProps<IFilm> = {
...testProps, | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
// Placeholder. This will be overwritten by the mounted component.
let handlePaste: (queries: string[]) => void;
const props: QueryListProps<IFilm> = {
...testProps,
itemPredicate,
onItemsPaste,
renderer: sinon.spy((listItemsProps: QueryListRendererProps<IFilm>) => {
handlePaste = listItemsProps.handlePaste;
| </s> remove function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
</s> add function mountForPasteTest(overrideProps: Partial<QueryListProps<Film>> = {}) { </s> remove renderer: sinon.spy((listItemsProps: QueryListRendererProps<IFilm>) => {
</s> add renderer: sinon.spy((listItemsProps: QueryListRendererProps<Film>) => { </s> remove const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
</s> add const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | const props: QueryListProps<Film> = { | function mountForPasteTest(overrideProps: Partial<QueryListProps<IFilm>> = {}) {
// Placeholder. This will be overwritten by the mounted component.
let handlePaste: (queries: string[]) => void;
const props: QueryListProps<Film> = {
...testProps,
itemPredicate,
onItemsPaste,
renderer: sinon.spy((listItemsProps: QueryListRendererProps<IFilm>) => {
handlePaste = listItemsProps.handlePaste; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
const props: QueryListProps<IFilm> = {
...testProps,
itemPredicate,
onItemsPaste,
renderer: sinon.spy((listItemsProps: QueryListRendererProps<IFilm>) => {
handlePaste = listItemsProps.handlePaste;
return testProps.renderer(listItemsProps);
}),
...overrideProps,
};
| </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { | renderer: sinon.spy((listItemsProps: QueryListRendererProps<Film>) => { | const props: QueryListProps<IFilm> = {
...testProps,
itemPredicate,
onItemsPaste,
renderer: sinon.spy((listItemsProps: QueryListRendererProps<Film>) => {
handlePaste = listItemsProps.handlePaste;
return testProps.renderer(listItemsProps);
}),
...overrideProps,
}; | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
let triggerInputQueryChange: ((e: any) => void) | undefined;
const createNewItemFromQuerySpy = sinon.spy();
const createNewItemRendererSpy = sinon.spy();
// we must supply our own renderer so that we can hook into QueryListRendererProps#handleQueryChange
const renderer = sinon.spy((props: QueryListRendererProps<IFilm>) => {
triggerInputQueryChange = props.handleQueryChange;
return <div>{props.itemList}</div>;
});
shallow(
<FilmQueryList
| </s> remove const itemPredicate: ItemPredicate<IFilm> = (query: string, film: IFilm, _i?: number, exactMatch?: boolean) => {
</s> add const itemPredicate: ItemPredicate<Film> = (query: string, film: Film, _i?: number, exactMatch?: boolean) => { </s> remove const props: QueryListProps<IFilm> = {
</s> add const props: QueryListProps<Film> = { </s> remove renderer: sinon.spy((listItemsProps: QueryListRendererProps<IFilm>) => {
</s> add renderer: sinon.spy((listItemsProps: QueryListRendererProps<Film>) => { </s> remove const queryList = (wrapper.instance() as Suggest2<IFilm> as any).queryList; // private ref
</s> add const queryList = (wrapper.instance() as Suggest2<Film> as any).queryList; // private ref </s> remove const queryList = (wrapper.instance() as Suggest<IFilm> as any).queryList; // private ref
</s> add const queryList = (wrapper.instance() as Suggest<Film> as any).queryList; // private ref | const renderer = sinon.spy((props: QueryListRendererProps<Film>) => { | let triggerInputQueryChange: ((e: any) => void) | undefined;
const createNewItemFromQuerySpy = sinon.spy();
const createNewItemRendererSpy = sinon.spy();
// we must supply our own renderer so that we can hook into QueryListRendererProps#handleQueryChange
const renderer = sinon.spy((props: QueryListRendererProps<Film>) => {
triggerInputQueryChange = props.handleQueryChange;
return <div>{props.itemList}</div>;
});
shallow(
<FilmQueryList | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
);
// Change the query to something non-empty so we can ensure it wasn't cleared.
// Ignore this change in the spy.
(queryList.instance() as QueryList<IFilm>).setQuery("some query");
onQueryChangeSpy.resetHistory();
assert.isDefined(triggerItemCreate, "query list should pass click handler to createNewItemRenderer");
triggerItemCreate!({});
| </s> remove export function selectPopoverTestSuite<P extends ListItemsProps<IFilm>, S>(
render: (props: ListItemsProps<IFilm> & SelectPopoverProps) => ReactWrapper<P, S>,
</s> add export function selectPopoverTestSuite<P extends ListItemsProps<Film>, S>(
render: (props: ListItemsProps<Film> & SelectPopoverProps) => ReactWrapper<P, S>, </s> remove private renderInputValue = (film: IFilm) => film.title;
</s> add private renderInputValue = (film: Film) => film.title; </s> remove const queryList = (wrapper.instance() as Suggest<IFilm> as any).queryList as QueryList<IFilm>; // private ref
</s> add const queryList = (wrapper.instance() as Suggest<Film> as any).queryList as QueryList<Film>; // private ref </s> remove const queryList = (wrapper.instance() as Suggest2<IFilm> as any).queryList as QueryList<IFilm>; // private ref
</s> add const queryList = (wrapper.instance() as Suggest2<Film> as any).queryList as QueryList<Film>; // private ref | (queryList.instance() as QueryList<Film>).setQuery("some query"); | );
// Change the query to something non-empty so we can ensure it wasn't cleared.
// Ignore this change in the spy.
(queryList.instance() as QueryList<Film>).setQuery("some query");
onQueryChangeSpy.resetHistory();
assert.isDefined(triggerItemCreate, "query list should pass click handler to createNewItemRenderer");
triggerItemCreate!({});
| [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/queryListTests.tsx |
import { InputGroup, Keys, MenuItem } from "@blueprintjs/core";
import { Popover2 } from "@blueprintjs/popover2";
import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
import { ItemRendererProps, Select2, Select2Props, Select2State } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<Select2>", () => {
| </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add |
import { InputGroup, Keys, MenuItem } from "@blueprintjs/core";
import { Popover2 } from "@blueprintjs/popover2";
import { ItemRendererProps, Select2, Select2Props, Select2State } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<Select2>", () => { | [
"keep",
"keep",
"keep",
"keep",
"replace",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/select2Tests.tsx |
|
import { ItemRendererProps, Select2, Select2Props, Select2State } from "../src";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<Select2>", () => {
const defaultProps = {
items: TOP_100_FILMS,
| </s> remove import { IFilm, renderFilm, TOP_100_FILMS } from "../../docs-app/src/common/films";
</s> add </s> remove const FilmSelect = Select2.ofType<IFilm>();
</s> add </s> remove const FilmSuggest = Suggest2.ofType<IFilm>();
</s> add const FilmSuggest = Suggest2.ofType<Film>(); | import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__"; |
import { ItemRendererProps, Select2, Select2Props, Select2State } from "../src";
import { Film, renderFilm, TOP_100_FILMS } from "../src/__examples__";
import { selectComponentSuite } from "./selectComponentSuite";
import { selectPopoverTestSuite } from "./selectPopoverTestSuite";
describe("<Select2>", () => {
const defaultProps = {
items: TOP_100_FILMS, | [
"keep",
"add",
"keep",
"keep",
"keep",
"keep",
"keep",
"keep"
] | chore: refactor FilmSelect into new private dev package (#5632) | https://github.com/palantir/blueprint/commit/b0d500511217db6590e86ccb9627385b4fd153a5 | packages/select/test/select2Tests.tsx |
Subsets and Splits