What makes someone a good photographer? 

1. Skill with the camera?
2. Artistic eye?
3. Theoretical knowledge?
4. A lot of practice?

The reason I am asking is that my photographs don't look nearly as good as I wish it to be. When I see photos on deviantArt and then when I look at my photos - there is just no comparison.

I am frustrated because I can't achieve the photo results I want and I am not sure what's wrong - is it just me, or my lack of skill with the camera, or perhaps both.