Datasets:

---

feedback-to-code

/

mozzarella

like 1

Follow

Feedback-2-Code 7

[ "keyword_pr_to_issue" ]

[ "Just checked and the validation error is triggered for all triggers so apparently editing any type of trigger shows this error." ]

[]

[ "bug", "frontend" ]

[ "ui/src/components/inputs/LowCodeEditor.vue" ]

[ "ui/src/components/inputs/LowCodeEditor.vue" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/functions/ReadFileFunction.java" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/functions/ReadFileFunction.java" ]

[ "core/src/test/java/io/kestra/core/runners/pebble/functions/ReadFileFunctionTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "cli/src/main/java/io/kestra/cli/commands/sys/SysCommand.java" ]

[ "cli/src/main/java/io/kestra/cli/commands/sys/SysCommand.java", "cli/src/main/java/io/kestra/cli/commands/sys/database/DatabaseCommand.java", "cli/src/main/java/io/kestra/cli/commands/sys/database/DatabaseMigrateCommand.java" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/components/flows/FlowRoot.vue" ]

[ "ui/src/components/flows/FlowRoot.vue" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/functions/ReadFileFunction.java" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/functions/ReadFileFunction.java" ]

[ "core/src/test/java/io/kestra/core/runners/pebble/functions/ReadFileFunctionTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "```suggestion\r\n private List<String> include;\r\n```\r\ngiven that it's a list, it seems better to use include as in \"Include all those listed paths\"", "```suggestion\r\n private List<String> exclude;\r\n```\r\nsame, given that it's a list, it seems better to use exclude as in \"Exclude all those listed paths\"", "Wouldn't it be easier to use the `NamespaceFiles` object here and have a way to inject everything from it?\r\nLike a `all` boolean or just document that to inject everything one should configure `include: **/*`?\r\n\r\nI wonder if those multi-types that we often use are easy to use for not too technical people.", "Wouldn't it be easier to use the `NamespaceFiles` object here and have a way to inject everything from it?\r\nLike a `all` boolean or just document that to inject everything one should configure `include: **/*`?\r\n\r\nI wonder if those multi-types that we often use are easy to use for not too technical people.", "Cache was designed to be fail-tolerant, if you didn't succeed in caching an error is displayed but the task is still runs. You change the behaviour here and I'm not sure it's a good idea as the task can still run even if it fails to use its cache.", "I don't thin it's a good idea, in Kestra, parallelism is at the worker thread level not at the task level.\r\nMoreover, parallel stream uses the default forkJoinPool so it may be less performant than a standard stream if multiple tasks are executed in parallel.", "```suggestion\r\n public List<URI> list(RunContext runContext, String tenantId, String namespace, Path basePath, Object namespaceFiles) throws Exception {\r\n```\r\n\r\nIt didn't really inject the files but list the files to be injected by the task that uses it so the name is kind of misleading.", "We discussed it initially via Slack and the initial proposal was to have 2 properties: one boolean `namespaceFiles` whether to fetch all namespace files and then if true, optional `namespaceFilesFilter` property with include/exclude. Given that there is some risk of confusion of using the filter without setting the boolean to true (it must be set to false by default), we went for that option with 1 property\r\n\r\ngood point though and well spotted", "for now, a good tradeoff might be if we add maybe 2-3 examples in the task docs to show the usage", "Better to add them in the namespace file documentation as we will use this in multiple tasks and we will not add those 2-3 examples in all tasks (the script tasks already have a lot of examples).\r\nWe may add a link to the documentation for that.", "Cache should never failed, I don't see a reason to let failed a cache failed silently and even more that the error will be on the worker and not on the user side (ui) ", "this method copy the files on the directory and return the list of copied files, inject is better than list", "```suggestion\r\n title = \"Whether to enable namespace files to be loaded into the working directory\"\r\n```", "```suggestion\r\n title = \"A list of filters to include only matching glob patterns\"\r\n```\r\ncould be more explicit this way", "could be also: \"Filters to include only matching glob patterns\" if you don't want to include the info that it's a list 👍 ", "```suggestion\r\n title = \"A list of filters to exclude matching glob patterns\"\r\n```", "```suggestion\r\n description = \"Inject namespace files to this task. When enabled, it will, by default, load all namespace files into the working directory. However, you can use the `include` or `exclude` properties to limit which namespace files will be injected.\"\r\n```" ]

[]

[ "core/src/main/java/io/kestra/core/runners/Worker.java", "core/src/main/java/io/kestra/core/tasks/flows/WorkingDirectory.java" ]

[ "core/src/main/java/io/kestra/core/models/tasks/NamespaceFiles.java", "core/src/main/java/io/kestra/core/models/tasks/NamespaceFilesInterface.java", "core/src/main/java/io/kestra/core/runners/NamespaceFilesService.java", "core/src/main/java/io/kestra/core/runners/Worker.java", "core/src/main/java/io/kestra/core/tasks/flows/WorkingDirectory.java" ]

[ "core/src/test/java/io/kestra/core/runners/NamespaceFilesServiceTest.java", "core/src/test/java/io/kestra/core/tasks/flows/WorkingDirectoryTest.java", "core/src/test/java/io/kestra/core/tasks/test/Read.java", "core/src/test/resources/flows/valids/working-directory-namespace-files.yaml" ]

[ "keyword_pr_to_issue" ]

[]

[ "I'm not sure it's worth creating a new type of toast.\r\nMaybe an alternative would be that you use the options from the saved method to give an \"genericQualifier\" key which defines whether or not we should display the saved thing in italic (false = italic, which will be the default not to break anything).\r\n\r\nYou can then update the saved() method to check for this param (don't forget to be null-safe on the options param :+1: ). Conditionally on that you can create a new translation that **doesn't includes** the `<em>` (see [here](https://github.com/kestra-io/kestra/blob/develop/ui/src/translations.json#L27)) if this param is true.\r\n\r\nThis way we now have a customizable toast which allow to display saved things whether they are id or not (and so the display will be adapted to it).\r\n\r\nAn example of usage for settings saving would then be\r\n`this.$toast().saved(this.$t('setting'), undefined, {genericQualifier: true})`\r\n\r\nTo recap:\r\n\r\n- in saved method check for options?.genericQualifier\r\n- if true -> use $t('generic saved done') else -> use $t('saved done')\r\n- create a translation for `generic saved done` key [below that](https://github.com/kestra-io/kestra/blob/develop/ui/src/translations.json#L27C39-L27C51) and [that](https://github.com/kestra-io/kestra/blob/develop/ui/src/translations.json#L546) (it's the same but without the `<em>` tags\r\n- use `this.$toast().saved(this.$t('setting'), undefined, {genericQualifier: true})` everywhere a setting is saved\r\n- remove your introduced \"toast().settingsSaved()\"", "Ok.I will update it.", "```suggestion\r\n \"multiple saved done\": \"{name} have been saved\",\r\n```", "```suggestion\r\n ? self.$t(\"multiple saved done\", {name})\r\n```", "```suggestion\r\n this.$toast().saved(this.$t('settings'),undefined,{multiple: true});\r\n```\r\nSorry I changed my mind but \"multiple\" will be easier to understand I think", "```suggestion\r\n const message = options?.multiple\r\n```", "Thank you.I update it." ]

[]

[ "ui/src/components/settings/BasicSettings.vue", "ui/src/translations.json", "ui/src/utils/toast.js" ]

[ "ui/src/components/settings/BasicSettings.vue", "ui/src/translations.json", "ui/src/utils/toast.js" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/storages/StorageInterface.java" ]

[ "core/src/main/java/io/kestra/core/storages/StorageInterface.java" ]

[ "core/src/test/java/io/kestra/core/storage/StorageInterfaceTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/package-lock.json", "ui/package.json", "ui/src/components/executions/Topology.vue" ]

[ "ui/package-lock.json", "ui/package.json", "ui/src/components/executions/Topology.vue" ]

[]

[ "keyword_pr_to_issue" ]

[ "@brian-mulier-p just a comment that if we don't make this one in 0.13.0 it's fine, just an edge case \r\n" ]

[]

[ "enhancement" ]

[ "ui/src/components/namespace/Editor.vue" ]

[ "ui/src/components/namespace/Editor.vue" ]

[]

[ "keyword_pr_to_issue" ]

[ "A bit opiniated for the team (https://kestra-io.slack.com/archives/C04HTFM3VL6/p1699614141351939?thread_ts=1699613554.492519&cid=C04HTFM3VL6). Maybe we should not do it ?", "After discussion, the choice is to change the command so that it takes a \"from\" (local folder path) and \"to\" (remote namespace files folder) folders so there is no more confusions. It allows multi-teams upload to a same namespace with `from=\"my_scripts\" to=\"/team_a_scripts\"` while keeping the ability to override the whole namespace with `from=\"all_my_scripts\" to=\"/\"`" ]

[ "```suggestion\r\n void runWithToSpecified() {\r\n```\r\n\r\nI have nothing against `_` in test method name but as other methods have With in there name for consistency it's better to use it there." ]

[ "bug" ]

[ "cli/src/main/java/io/kestra/cli/commands/namespaces/files/NamespaceFilesUpdateCommand.java" ]

[ "cli/src/main/java/io/kestra/cli/commands/namespaces/files/NamespaceFilesUpdateCommand.java" ]

[ "cli/src/test/java/io/kestra/cli/commands/namespaces/files/NamespaceFilesUpdateCommandTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutableUtils.java" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutableUtils.java" ]

[ "core/src/test/java/io/kestra/core/tasks/flows/ForEachItemCaseTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/storages/StorageInterface.java" ]

[ "core/src/main/java/io/kestra/core/storages/StorageInterface.java" ]

[ "core/src/test/java/io/kestra/core/storage/StorageInterfaceTest.java", "core/src/test/java/io/kestra/core/tasks/flows/VariablesTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/NamespaceFileControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[ "Will double check as I fixed this for JDBC last week.", "I can reproduce the issue, pause count as running ... but cancel state is not correctly handled with pause task.\r\nI'll have a look." ]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutorService.java" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutorService.java" ]

[ "core/src/test/java/io/kestra/core/runners/FlowConcurrencyCaseTest.java", "core/src/test/resources/flows/valids/flow-concurrency-cancel-pause.yml", "jdbc/src/test/java/io/kestra/jdbc/runner/JdbcRunnerTest.java" ]

[ "keyword_pr_to_issue" ]

[ "There is no easy fix for this, logs from executable tasks are not sent so even if I add one it would not be sent anywhere so not be visible (I think the same applies to logs from flowable tasks).\r\n\r\nAs a side note, when an exception occurs that is not caught in a task, it goes into the executor exception handling, which will fail the task and the execution. It will add an error logs to the flow execution that is not visible in the Logs tab of an execution as this one only contains tasks logs. You will be able to see it when looking at the Logs page.", "I created https://github.com/kestra-io/kestra/issues/2521 as a followup to the more broad issue of logs related to a flow execution not linked to any tasks." ]

[ "```suggestion\r\n if (!renderedUri.startsWith(\"kestra://\")) {\r\n```" ]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/tasks/flows/ForEachItem.java" ]

[ "core/src/main/java/io/kestra/core/tasks/flows/ForEachItem.java" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/utils/axios.js" ]

[ "ui/src/utils/axios.js" ]

[]

[ "keyword_pr_to_issue" ]

[ "Hello, if issue #2476is currently unassigned or available, please consider assigning it to me.", "Hello @prajwalgh, thank's for contributing, I assigned you :)", "Hello @prajwalgh do you manage to do it or do you need any help ?" ]

[]

[ "bug", "frontend", "good first issue" ]

[ "ui/src/components/namespace/Editor.vue", "ui/src/utils/constants.js" ]

[ "ui/src/components/namespace/Editor.vue", "ui/src/utils/constants.js" ]

[]

[ "keyword_pr_to_issue" ]

[]

[ "Put it in a file for more readability ", "I moved them to a variable" ]

[]

[ "ui/public/init.js" ]

[ "ui/public/init.js" ]

[]

[ "keyword_pr_to_issue" ]

[]

[ "Put it in a file for more readability ", "I moved them to a variable" ]

[]

[ "ui/public/init.js" ]

[ "ui/public/init.js" ]

[]

[ "keyword_pr_to_issue" ]

[]

[ "Put it in a file for more readability ", "I moved them to a variable" ]

[]

[ "ui/public/init.js" ]

[ "ui/public/init.js" ]

[]

[ "keyword_pr_to_issue" ]

[ "can you explain more? how did it look like before?\r\n\r\nit seems you can edit tasks + add new ones directly from the UI forms\r\n\r\n\r\n\r\n\r\n", "When you're in full topology view, the \"Actions\" button I highlighted above isn't show, so you can edit your flow metadata for example" ]

[]

[ "bug" ]

[ "ui/src/components/inputs/Editor.vue", "ui/src/components/inputs/EditorView.vue" ]

[ "ui/src/components/inputs/Editor.vue", "ui/src/components/inputs/EditorButtons.vue", "ui/src/components/inputs/EditorView.vue" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/styles/layout/element-plus-overload.scss" ]

[ "ui/src/styles/layout/element-plus-overload.scss" ]

[]

[ "keyword_pr_to_issue" ]

[ "Seems like the `replace` method doesn't handle string/datetime very well\r\n\r\n\r\n", "Reopened because the fix has been reverted in https://github.com/kestra-io/kestra/pull/2754", "closing as with the render function (non-recursive behavior), both manual and scheduled executions generate identical results:\r\n\r\n```yaml\r\nid: copine_voyage_troubleshoot\r\nnamespace: dev\r\n\r\nvariables:\r\n period: \"{{ schedule.date ?? execution.startDate | dateAdd(-1, 'DAYS') | date('yyyy-MM') }}\"\r\n\r\ntasks:\r\n - id: debug\r\n type: io.kestra.core.tasks.log.Log\r\n message: |\r\n Period: {{ render(vars.period) }}\r\n {{ render(vars.period) | replace({'-': ''}) }}\r\n {{ render(vars.period | replace({'-': ''})) }}\r\n {{ render(vars.period) | replace({'2023': 'toto'}) }}\r\n {{ render(vars.period | replace({'2023': 'toto'})) }}\r\n\r\ntriggers:\r\n - id: schedule\r\n type: io.kestra.core.models.triggers.types.Schedule\r\n cron: \"*/1 * * * *\"\r\n```\r\n\r\n@Ben8t please open a new issue if you see any usage patterns not being feasible with the new behavior in 0.14.0" ]

[ "`true` is the default so you can revert this change", "```suggestion\r\n public String render(String inline, boolean preprocessVariables) throws IllegalVariableEvaluationException {\r\n```\r\n\r\nI think it's better to call it preprocessed as it's what you do and variable are rendered anyway as we are recursive.", "Revert as it's the default behaviour", "I think all changes inside the RunContext can be reverted as the new functions are not used anywhere.\r\nJust keep it simple for now", "```suggestion\r\n public String recursiveRender(String inline, Map<String, Object> variables, Boolean preprocessVariables) throws IllegalVariableEvaluationException {\r\n```", "Please add an infinite loop test and assert that you get the result that preceeds the infinite loop turn\r\n(var1: {{var2}}, var2: {{var3}}, var3: {{var1}})\r\n=> render({{var1 | replace({'3': '4'})}}) => {{var4}} ", "you can change the test as it's purely logic and not easily understandable but you get it" ]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/RunContext.java", "core/src/main/java/io/kestra/core/runners/VariableRenderer.java" ]

[ "core/src/main/java/io/kestra/core/runners/RunContext.java", "core/src/main/java/io/kestra/core/runners/VariableRenderer.java" ]

[ "core/src/test/java/io/kestra/core/models/hierarchies/FlowGraphTest.java", "core/src/test/java/io/kestra/core/runners/RunContextTest.java", "core/src/test/java/io/kestra/core/runners/pebble/PebbleVariableRendererTest.java", "core/src/test/resources/flows/templates/with-template.yaml", "core/src/test/resources/flows/valids/return.yaml" ]

[ "keyword_pr_to_issue" ]

[ "Matrix of state (from this [spreadsheet](https://docs.google.com/spreadsheets/d/1yKCFT0yoc3kVTrtXpgSAG2Y3TKBtfLxgRtr81HlFddw/edit?usp=sharing))\n\n| CURRENT_STATE | WANTED_STATE | WHY ? |\n|---------------|--------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|\n| CREATED | RUNNING | |\n| | PAUSED | No way to force it. Only done through Pause task. Related to https://github.com/kestra-io/kestra/issues/1449 which wants to be able to tell execution to pause itself at a specific task id at execution creation |\n| | RESTARTED | UI (gray button cause not running / not failed) + Backend (only failed or paused taskruns can be restarted) |\n| | KILLING | |\n| | SUCCESS | UI (No taskrun displayed in Gantt / Logs tab which prevent us from accessing change status popup) + Backend (Won't let a task change for non-terminated / non-paused tasks, service guard) |\n| | WARNING | UI (No taskrun displayed in Gantt / Logs tab which prevent us from accessing change status popup) + Backend (Won't let a task change for non-terminated / non-paused tasks, service guard) |\n| | FAILED | UI (No taskrun displayed in Gantt / Logs tab which prevent us from accessing change status popup) + Backend (Won't let a task change for non-terminated / non-paused tasks, service guard) |\n| | KILLED | No force-kill |\n| | | |\n| RUNNING | PAUSED | No way to force it. Only done through Pause task. Related to https://github.com/kestra-io/kestra/issues/1449 which wants to be able to tell execution to pause itself at a specific task id at execution creation |\n| | RESTARTED | Useless ? |\n| | KILLING | |\n| | SUCCESS | UI (Gray button) + Backend (Won't let a task change for non-terminated / non-paused tasks, service guard) |\n| | WARNING | UI (Gray button) + Backend (Won't let a task change for non-terminated / non-paused tasks, service guard) |\n| | FAILED | UI (Gray button) + Backend (Won't let a task change for non-terminated / non-paused tasks, service guard) |\n| | KILLED | Only automatically by backend once we receive a KILLED confirmation from underlying taskruns. Currently no way to force it |\n| | | |\n| PAUSED | RUNNING | Resume button |\n| | RESTARTED | UI (gray button). Backend OK but strange behaviour cause it pushes the paused task as RESTARTED which then goes to running, bypassing the paused state without going through resume call |\n| | KILLING | When killing a PAUSED execution, it goes to running then back to paused. It executes tasks that are after the PAUSE task but then stays in PAUSE (only in KAFKA) |\n| | SUCCESS | UI (no change-state in Gantt chart cause no log) + Mark-as service throws if execution is paused. Need to resume which will success the paused task. However there is no way to force the whole execution to being in a success state without executing after-paused tasks |\n| | WARNING | '' |\n| | FAILED | '' |\n| | KILLED | Only automatically by backend once we receive a KILLED confirmation from underlying taskruns. Currently no way to force it |\n| | | |\n| RESTARTED | RUNNING | Automatically by backend, but it's a standard behaviour |\n| | PAUSED | No way to force it. Only done through Pause task. Related to https://github.com/kestra-io/kestra/issues/1449 which wants to be able to tell execution to pause itself at a specific task id at execution creation |\n| | KILLING | |\n| | SUCCESS | UI is OK but backend requires a terminated state to change state (and restarted isn't one) |\n| | WARNING | '' |\n| | FAILED | '' |\n| | KILLED | |\n| | | |\n| KILLING | RUNNING | No UI button to do so + Taskruns are put as killed as soon as an execution is marked as KILLING |\n| | PAUSED | No interaction possible |\n| | RESTARTED | '' |\n| | SUCCESS | '' |\n| | WARNING | '' |\n| | FAILED | '' |\n| | KILLED | Only automatically by backend once we receive a KILLED confirmation from underlying taskruns. Currently no way to force it |\n| | | |\n| SUCCESS | RUNNING | No UI button -> Must go through a replay which creates a new execution -> No restart possible (both UI & Backend makes it impossible: backend searches for failed or paused taskruns to restart from) |\n| | PAUSED | No way to force it. Only done through Pause task. Related to https://github.com/kestra-io/kestra/issues/1449 which wants to be able to tell execution to pause itself at a specific task id at execution creation |\n| | RESTARTED | UI (gray button cause not running / not failed) + Backend (only failed or paused taskruns can be restarted) |\n| | KILLING | No UI button + backend will not accept a terminated execution |\n| | WARNING | |\n| | FAILED | |\n| | KILLED | |\n| | | |\n| | | |\n| WARNING | RUNNING | No UI button -> Must go through a replay which creates a new execution -> No restart possible (both UI & Backend makes it impossible: backend searches for failed or paused taskruns to restart from) |\n| | PAUSED | |\n| | RESTARTED | UI (gray button cause not running / not failed) + Backend (only failed or paused taskruns can be restarted) |\n| | KILLING | No UI button + backend will not accept a terminated execution |\n| | SUCCESS | |\n| | FAILED | |\n| | KILLED | |\n| | | |\n| FAILED | RUNNING | Indirect state because you need to restart the execution in overview menu which changes the execution to RESTARTED then RUNNING by the executor |\n| | PAUSED | |\n| | RESTARTED | Restart from overview menu |\n| | KILLING | No UI button + Backend checks and refuses terminated states |\n| | SUCCESS | |\n| | WARNING | |\n| | KILLED | |\n| | | |\n| KILLED | RUNNING | You cannot restart a killed execution (UI button is not present + backend will search for a failed or paused taskrun to start from). Change status doesn't display running as an available switch-to state. Meaning you are forced to either replay in another execution or skip the killed task |\n| | PAUSED | |\n| | RESTARTED | You cannot restart a killed execution (UI button is not present + backend will search for a failed or paused taskrun to start from). |\n| | KILLING | No usage |\n| | SUCCESS | Change status button |\n| | WARNING | |\n| | FAILED | |", "We just had a case creating a lot of execution (several thousand) in \"RESTARTED\" state. This was a mistake.\r\nDue to Kestra check, we have not been able to stop all these executions until they change to \"RUNNING\" state.\r\nThis could be usefull to be able to stop executions before they are running.", "@aurelienWls killing `CREATED` execution is already possible on Kestra 0.10, but we will check if we need to handle more use case.", "UI currently prevents changing the Execution state when some state transition is not allowed. However, often this is required to unblock some applications. More input is needed here to decide about next steps\r\n", "It seems that the only state changes we should allow that are not currently allowed are\r\nCREATED & RESTARTED -> terminated state (SUCCESS, WARNING, FAIL).\r\nIt opens to potential concurrency issues but even if it starts after the status change it should still work :thinking: ", "Decission is to allow transitionning from CREATED & RESTARTED to a terminal state (SUCCESS, WARNING, FAILED).", "Allow transitionning from RESTARTED to a terminal state (SUCCESS, WARNING, FAILED) was already implemented so only CREATED needs to be allowed." ]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/services/ExecutionService.java", "ui/src/components/executions/ChangeStatus.vue" ]

[ "core/src/main/java/io/kestra/core/services/ExecutionService.java", "ui/src/components/executions/ChangeStatus.vue" ]

[]

[ "keyword_pr_to_issue" ]

[ "After discussing with @tchiotludo it was chosen not to include search by flow source for now as it requires some rework around matches retrieval (we need more info on matches' index in flow for VSCode to highlight / show proper preview). Moreover, as we're limited by storages which prevent us from having search by content over Namespace Files (not flows) which in the end leads to incomplete and confusing feature (why my search by content is scoped to flows ?).\r\n\r\nI'll only introduce search by file (& flows) name for now." ]

[ "The second line is misleading, does it retruns path or path relative to the preifx?\r\nI think it should return full URI", "So the test shows that it returns relative path which is strange.\r\nLooking at the interface of the LocalStorage I think it should returns a List<URI> instead, containing the full internal storage URI.\r\nThis if you need a list of string without the prefix it is something related to NamespaceFiles so it must be adapted inside the NamespaceFile service.\r\nOtherwise, this method will not be reusable for something else.", "I don't understand in what this is different from the existing method that list all files for a namespace?", "It's recursive. Its goal is to be able to get every file under the given prefix (note the word file, we don't want directories in here) with their path. It walks along the whole hierarchy which is behind the prefix. So for eg. we use it there by giving the NamespaceFiles storage prefix which will allow me to get URIs of every namespace files.\r\n\r\nIt's required for file search by name in VSCode editor. Ideally we would've liked that the implementation do the search part but it's not feasible as storages don't allow wildcards searching so we would be scoped to \"startsWith\" alike searches\r\n\r\nFollowing what you said above, I can definitely return the entire URI if that's preferable and do the change in NamespaceFile service", "replied in the other comment", "> Following what you said above, I can definitely return the entire URI if that's preferable and do the change in NamespaceFile service\r\n\r\nYes, full URIs please, internal storage always use full URIs", "You need to name the file differently to check that it is not inside the response from the null tenant", "Please add a test for when there is no response (should return an empty list)", "Why do you concat with staticFiles and what is this statifFiles?", "Nice spot", "For easier maintainability and flexibility I added a static file concept for VSCode editor. Those files are served from static resources of the webserver and the goal is to be able as a software to provide some read-only files to the user. This can be used to guide him (for eg. we currently have a getting-started file which appear on VSCode editor but isn't editable, it is served statically and acts like a README for editor usage)", "Well, I'm not sure I see the point of including them in the search but anyway, OK", "If I don't include them the feature will look unfinished or broken IMO :thinking: " ]

[ "backend", "enhancement", "frontend" ]

[ "core/src/main/java/io/kestra/core/storages/StorageInterface.java", "storage-local/src/main/java/io/kestra/storage/local/LocalStorage.java", "ui/public/init.js", "webserver/src/main/java/io/kestra/webserver/controllers/NamespaceFileController.java" ]

[ "core/src/main/java/io/kestra/core/storages/StorageInterface.java", "storage-local/src/main/java/io/kestra/storage/local/LocalStorage.java", "ui/public/init.js", "webserver/src/main/java/io/kestra/webserver/controllers/NamespaceFileController.java" ]

[ "core/src/test/java/io/kestra/core/storage/StorageTestSuite.java", "webserver/src/test/java/io/kestra/webserver/controllers/NamespaceFileControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/override/components/LeftMenu.vue" ]

[ "ui/src/override/components/LeftMenu.vue" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug", "backport-needed" ]

[ "ui/src/components/executions/Executions.vue" ]

[ "ui/src/components/executions/Executions.vue" ]

[]

[ "keyword_pr_to_issue" ]

[ "TBD whether we can support uploading an entire folder: https://stackoverflow.com/questions/49655967/browser-folder-uploading\r\n\r\nOtherwise, both Import and Export will be based on a zip file" ]

[]

[ "backend", "enhancement", "frontend" ]

[ "core/src/main/java/io/kestra/core/repositories/FlowRepositoryInterface.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcFlowRepository.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryFlowRepository.java", "ui/src/components/namespace/Editor.vue", "ui/src/stores/namespaces.js", "ui/src/translations.json", "ui/src/utils/utils.js", "webserver/src/main/java/io/kestra/webserver/controllers/FlowController.java", "webserver/src/main/java/io/kestra/webserver/controllers/NamespaceFileController.java" ]

[ "core/src/main/java/io/kestra/core/repositories/FlowRepositoryInterface.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcFlowRepository.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryFlowRepository.java", "ui/src/components/namespace/Editor.vue", "ui/src/stores/namespaces.js", "ui/src/translations.json", "ui/src/utils/utils.js", "webserver/src/main/java/io/kestra/webserver/controllers/FlowController.java", "webserver/src/main/java/io/kestra/webserver/controllers/NamespaceFileController.java" ]

[ "core/src/test/java/io/kestra/core/repositories/AbstractFlowRepositoryTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/NamespaceFileControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[ "It is already deprecated and displayed as it inside the Kestra UI, see https://preview-oss.kestra.io/ui/plugins/io.kestra.core.models.conditions.types.FlowCondition\n\n\n\n\n\n\n\nBut for an unknown reason, on the website the deprecated icon is not shown, see https://kestra.io/plugins/core/conditions/io.kestra.core.models.conditions.types.flowcondition\n\n\n\n\n\n\n", "Ey! So far in my findings I see that the website FE is taking the title `.md` tag value so in this example it'll only show \"FlowCondition\" instead of \"FlowCondition- 🔒 Deprecated\".\r\n\r\n```\r\n---\r\ntitle: FlowCondition\r\neditLink: false\r\n\r\ndescription: \"Condition for a specific flow. Note that this condition is deprecated, use `ExecutionFlowCondition` instead.\"\r\n\r\nicon: PHN2Zy...\r\n---\r\n\r\n\r\n<h1>\r\n <img width=\"25\" src=\"...\" alt=\"FlowCondition\" /> FlowCondition- 🔒 Deprecated\r\n</h1>\r\n```\r\n\r\nSo title should have the same content as the h1.", "Thanks, it explains the behavior, on our side, we didn't add the 'deprecated' flag on the MD title.\r\nI'll have a look." ]

[]

[ "backend", "enhancement" ]

[ "core/src/main/resources/docs/task.hbs" ]

[ "core/src/main/resources/docs/task.hbs" ]

[]

[ "keyword_pr_to_issue" ]

[]

[ "Following Slack discussion, I'm ok with that but it should be consistent across all conditions so please do the change accordingly or stay with now()", "```suggestion\r\n @PluginProperty(dynamic = true)\r\n```", "```suggestion\r\n @PluginProperty(dynamic = true)\r\n```", "```suggestion\r\n HolidayManager holidayManager = country != null ? HolidayManager.getInstance(ManagerParameters.create(conditionContext.getRunContext().render(country))) : HolidayManager.getInstance();\r\n```", "```suggestion\r\n return subDivision == null ? holidayManager.isHoliday(currentDate) : holidayManager.isHoliday(currentDate, conditionContext.getRunContext().render(subDivision));\r\n```", "Please also provide an example to revert the condition", "It has been decided to align all date based conditions to the trigger date", "I'm not sure it really have use cases but if you want ...\r\nDone." ]

[ "enhancement" ]

[ "core/build.gradle", "core/src/main/java/io/kestra/core/models/conditions/types/DateTimeBetweenCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/DayWeekCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/DayWeekInMonthCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/TimeBetweenCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/WeekendCondition.java" ]

[ "core/build.gradle", "core/src/main/java/io/kestra/core/models/conditions/types/DateTimeBetweenCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/DayWeekCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/DayWeekInMonthCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/PublicHolidayCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/TimeBetweenCondition.java", "core/src/main/java/io/kestra/core/models/conditions/types/WeekendCondition.java" ]

[ "core/src/test/java/io/kestra/core/models/conditions/types/PublicHolidayConditionTest.java" ]

[ "keyword_pr_to_issue" ]

[ "0fa696465b3506cbecd5fd72d8119aad9c6112ca and be383eb6d97161788b51a783f76794873a400b6d prevent the crash, now we need to add a proper validation on flow save" ]

[]

[ "bug", "backend" ]

[ "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/validations/TimezoneId.java", "core/src/main/java/io/kestra/core/validations/validator/TimezoneIdValidator.java" ]

[ "core/src/test/java/io/kestra/core/validations/TimezoneIdTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug", "quick-win" ]

[ "ui/public/init.js", "ui/src/components/flows/TriggerFlow.vue", "ui/src/components/namespace/Editor.vue" ]

[ "ui/public/init.js", "ui/src/components/flows/TriggerFlow.vue", "ui/src/components/namespace/Editor.vue" ]

[ "core/src/test/java/io/kestra/core/tasks/flows/ForEachItemCaseTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "All other task types are suffixed by _able_, maybe call it ExecutionUpdatableTask ?", "```suggestion\r\n title = \"Allow to add labels to the current execution at runtime.\",\r\n```", "I don't think this description brings much value", "Please use text block for such long string.\r\nDon't modify it but think for the next time.", "```suggestion\r\n title = \"Labels to add to the current execution.\",\r\n```", "It seems overly complicated to allow multiple ways to define the label.\r\nThe original issue propose Map which is what we usually advise so I'll only propose to set labels as map", "Please define the mapper as a constant as we usually do", "I didn't understand this test, it doesn't NPE?", "The algorithm is a bit complex, if it's a string or a list you create a map, then if it's a map (which will always be the case at this point) you create a map with the existing, add the new, then create a list.\r\n\r\nYou may be able to simplify it.\r\nAnd we usually check that if it's none of what we expected we throw an exception.", "```suggestion\r\n title = \"Allow to add or overwrite labels for the current execution at runtime.\",\r\n```", "```suggestion\r\n title = \"Labels to add or overwrite for the current execution.\",\r\n```", "I'll remove String but List is something @anna-geller want to be able to use afaik", "That's already a constant behind it, I'm using a static method :+1: ", "I renamed it but basically it asserts that there is no NPE if you don't provide any label before (as it was a bug I detected and wanted to unit test it)", "I removed the String part but for the rest I'm pretty confident in the algorithm. The map part is done to easily handle overrides (as grouping them onto a single map with new values behind added afterwards will delete previous values)." ]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutorService.java", "core/src/main/java/io/kestra/core/tasks/flows/EachParallel.java" ]

[ "core/src/main/java/io/kestra/core/models/tasks/ExecutionUpdatableTask.java", "core/src/main/java/io/kestra/core/runners/ExecutorService.java", "core/src/main/java/io/kestra/core/tasks/executions/Labels.java", "core/src/main/java/io/kestra/core/tasks/flows/EachParallel.java" ]

[ "core/src/test/java/io/kestra/core/tasks/flows/RuntimeLabelsTest.java", "core/src/test/resources/flows/valids/labels-update-task.yml", "core/src/test/resources/flows/valids/npe-labels-update-task.yml", "jdbc/src/test/java/io/kestra/jdbc/repository/AbstractJdbcFlowRepositoryTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "This is the same as using indexOf(':') and taking what' s before as key and what's after as value right?", "By doing that we miss some protection that we have before with miss-crafted query string", "```suggestion\r\n public static final String ENCODED_URL_LABEL_VALUE = URLEncoder.encode(URL_LABEL_VALUE, StandardCharsets.UTF_8));\r\n```\r\n\r\nThe all string must be encoded", "That's what I did before, I forgot a comment but I saw that this is the behaviour of our UI library (for eg. \":\" aren't encoded from UI) so I prefer to replicate this encoding to ensure we don't miss any side-effect (\":\" parsing in this example)", "I don't think we should handle the syntax at this level. The goal of this method should only be to extract before & after first \":\" imo.\r\nFor the indexOf yes I can also do that :+1: ", "So in this case indexOf is straightforward", "We should URL encode everything from the UI, this is a bug and a security risk I think" ]

[ "bug" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java", "webserver/src/main/java/io/kestra/webserver/utils/RequestUtils.java" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java", "webserver/src/main/java/io/kestra/webserver/utils/RequestUtils.java" ]

[ "webserver/src/test/java/io/kestra/webserver/controllers/ExecutionControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug", "frontend", "quick-win" ]

[ "ui/src/utils/yamlUtils.js" ]

[ "ui/src/utils/yamlUtils.js" ]

[]

[ "keyword_pr_to_issue" ]

[ "thanks so much for the issue! I can reproduce", "temporary workaround: adding leading `/` in the `include` solves the issue\r\n\r\n```yaml\r\nid: test\r\nnamespace: dev\r\n\r\ntasks:\r\n - id: test\r\n type: io.kestra.plugin.scripts.python.Commands\r\n namespaceFiles:\r\n enabled: true\r\n include:\r\n - \"/test/**\"\r\n commands:\r\n - ls test/ .\r\n```\r\n\r\n" ]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/NamespaceFilesService.java" ]

[ "core/src/main/java/io/kestra/core/runners/NamespaceFilesService.java" ]

[ "core/src/test/java/io/kestra/core/runners/NamespaceFilesServiceTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug", "quick-win" ]

[ "jdbc/src/main/java/io/kestra/jdbc/runner/AbstractJdbcSubflowExecutionStorage.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcExecutor.java" ]

[ "jdbc/src/main/java/io/kestra/jdbc/runner/AbstractJdbcSubflowExecutionStorage.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcExecutor.java" ]

[ "core/src/test/java/io/kestra/core/runners/DeserializationIssuesCaseTest.java", "jdbc-postgres/src/test/java/io/kestra/runner/postgres/PostgresSubflowExecutionStorageTest.java", "jdbc/src/test/java/io/kestra/jdbc/runner/AbstractSubflowExecutionTest.java" ]

[ "keyword_pr_to_issue" ]

[ "Notion automation got a bit crazy, sorry Ludo for this back and forth on changing Milestone, haha - this wasn't me, this was a flow that got mad", "We won't tackle the recursive vs non-recursive approach for 0.14.0. Will be tackled for 0.15.0" ]

[ "I had no choice but to put them as static since I need to access them in the new static `renderOnce` & `renderRecursively` methods which are also called from RenderFunction (and in such Pebble functions you don't have access to Micronaut context or the whole PebbleEngine)", "No, your function can themself be CDI beans, this is what we do already for some of them.\r\nLook inside `io.kestra.core.runners.pebble.Extension`", "Not great to override a parameter", "This is strange that it takes an integer argument, I think this should be an implementation detail.", "I thought we want to discourage recursiveness, in this case shouldn't it be false by default?", "By default, we don't render recursively. If you use the render function you opt-in to render (recursively if needed) explicitly. \r\n\r\nrecursive=False is an edge case to render only once as for trigger payload\r\n\r\nI'll add a draft PR to docs to show based on examples 👍 \r\n\r\n(so this is intentional)", "That's true my bad", "https://github.com/kestra-io/docs/pull/776", "I had to move the VariableRenderer bean injection to a runtime one as it's a circular dependency otherwise (VariableRenderer spawns the Pebble extension which spawns this function which needs VariableRenderer) so fetching it a runtime will work", "```suggestion\r\n rivate String renderRecursively(int renderingCount, String inline, Map<String, Object> variables) throws IllegalVariableEvaluationException {\r\n```", "Why is it nullable?", "I think you can do it at postConstruct time instead of doing it each time", "Is it really needed? This looks like a bad idea (same for the other getter)", "Because the function isn't created only if the recursive settings is set to true", "Oh god!\r\nMaybe it would be better to create it and throw, with this we would be able to display a better error message.\r\nAnyway, OK.", "No because PostConstruct is still within the Lifecycle of the bean (if it can't execute, the bean isn't in the context) so if I try to get the variableRenderer in PostConstruct it will circle as the variableRenderer will need that bean :'( ", "I forgot to remove it", "Ludo advised not to inject the function and let Pebble say that this function doesn't exist, it will be documented that render function cannot be used with recursive setting" ]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/VariableRenderer.java", "core/src/main/java/io/kestra/core/runners/handlebars/helpers/EvalHelper.java", "core/src/main/java/io/kestra/core/runners/handlebars/helpers/FirstDefinedEvalHelper.java", "core/src/main/java/io/kestra/core/runners/pebble/Extension.java" ]

[ "core/src/main/java/io/kestra/core/runners/VariableRenderer.java", "core/src/main/java/io/kestra/core/runners/handlebars/helpers/EvalHelper.java", "core/src/main/java/io/kestra/core/runners/handlebars/helpers/FirstDefinedEvalHelper.java", "core/src/main/java/io/kestra/core/runners/pebble/Extension.java", "core/src/main/java/io/kestra/core/runners/pebble/functions/RenderFunction.java" ]

[ "core/src/test/java/io/kestra/core/runners/handlebars/helpers/HandlebarsVariableRendererTest.java", "core/src/test/java/io/kestra/core/runners/handlebars/helpers/JqHelperTest.java", "core/src/test/java/io/kestra/core/runners/pebble/PebbleVariableRendererTest.java", "core/src/test/java/io/kestra/core/runners/pebble/RecursivePebbleVariableRendererTest.java", "core/src/test/java/io/kestra/core/runners/pebble/filters/JqFilterTest.java", "core/src/test/java/io/kestra/core/runners/pebble/functions/ReadFileFunctionTest.java", "core/src/test/resources/flows/valids/variables.yaml" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/Worker.java" ]

[ "core/src/main/java/io/kestra/core/runners/Worker.java" ]

[ "core/src/test/java/io/kestra/core/runners/RetryTest.java", "core/src/test/resources/flows/valids/retry-invalid.yml" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/components/namespace/NamespaceSelect.vue", "ui/src/styles/layout/element-plus-overload.scss" ]

[ "ui/src/components/namespace/NamespaceSelect.vue", "ui/src/styles/layout/element-plus-overload.scss" ]

[]

[ "keyword_pr_to_issue" ]

[ "Done thanks to:\r\n- Automatic encryption and decryption of task output: https://github.com/kestra-io/kestra/pull/3005\r\n- Encryption of GCP Auht Token: https://github.com/kestra-io/plugin-gcp/pull/324\r\n- Encrypton of ECR token: https://github.com/kestra-io/plugin-aws/pull/373 (will be merged soon)" ]

[ "## Encryption algorithms should be used with secure mode and padding scheme\n\n<!--SONAR_ISSUE_KEY:AY0hk3_ygJ56SSpZTR-1-->Use another cipher mode or disable padding. <p>See more on <a href=\"https://sonarcloud.io/project/issues?id=kestra-io_kestra&issues=AY0hk3_ygJ56SSpZTR-1&open=AY0hk3_ygJ56SSpZTR-1&pullRequest=2892\">SonarCloud</a></p>\n\n[Show more details](https://github.com/kestra-io/kestra/security/code-scanning/35)", "## Counter Mode initialization vectors should not be reused\n\n<!--SONAR_ISSUE_KEY:AY0hk3_ygJ56SSpZTR-2-->Use a dynamically-generated initialization vector (IV) to avoid IV-key pair reuse. <p>See more on <a href=\"https://sonarcloud.io/project/issues?id=kestra-io_kestra&issues=AY0hk3_ygJ56SSpZTR-2&open=AY0hk3_ygJ56SSpZTR-2&pullRequest=2892\">SonarCloud</a></p>\n\n[Show more details](https://github.com/kestra-io/kestra/security/code-scanning/36)", "## Encryption algorithms should be used with secure mode and padding scheme\n\n<!--SONAR_ISSUE_KEY:AY0hk3_ygJ56SSpZTR-3-->Use another cipher mode or disable padding. <p>See more on <a href=\"https://sonarcloud.io/project/issues?id=kestra-io_kestra&issues=AY0hk3_ygJ56SSpZTR-3&open=AY0hk3_ygJ56SSpZTR-3&pullRequest=2892\">SonarCloud</a></p>\n\n[Show more details](https://github.com/kestra-io/kestra/security/code-scanning/37)", "It's fixed, I have no idea why the Sonar action didn't close this comment as 'Fixed'.", "For `AES/GCM/NoPadding` IV length must be `12`. Others lengths will require more computation and can be less secure. The remaning 4 bytes are used internally for the counter. Furthermore, as the general recommendation is to have an IV of 12 bytes in length, this will make our encryption compatible with most libraries.", "Done" ]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/Extension.java" ]

[ "core/src/main/java/io/kestra/core/crypto/CryptoService.java", "core/src/main/java/io/kestra/core/runners/pebble/Extension.java", "core/src/main/java/io/kestra/core/runners/pebble/functions/DecryptFunction.java", "core/src/main/java/io/kestra/core/runners/pebble/functions/EncryptFunction.java" ]

[ "core/src/test/java/io/kestra/core/runners/pebble/functions/EncryptDecryptFunctionTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/MiscController.java", "webserver/src/main/java/io/kestra/webserver/filter/AuthenticationFilter.java" ]

[ "core/src/main/java/io/kestra/core/utils/AuthUtils.java", "webserver/src/main/java/io/kestra/webserver/controllers/MiscController.java", "webserver/src/main/java/io/kestra/webserver/filter/AuthenticationFilter.java", "webserver/src/main/java/io/kestra/webserver/listeners/OssAuthListener.java", "webserver/src/main/java/io/kestra/webserver/models/events/Event.java", "webserver/src/main/java/io/kestra/webserver/models/events/OssAuthEvent.java", "webserver/src/main/java/io/kestra/webserver/services/BasicAuthService.java" ]

[ "webserver/src/test/java/io/kestra/webserver/controllers/MiscControllerSecuredTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/MiscControllerTest.java", "webserver/src/test/java/io/kestra/webserver/filter/AuthenticationFilterTest.java", "webserver/src/test/java/io/kestra/webserver/services/BasicAuthServiceTest.java", "webserver/src/test/resources/application-test.yml" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/MiscController.java", "webserver/src/main/java/io/kestra/webserver/filter/AuthenticationFilter.java" ]

[ "core/src/main/java/io/kestra/core/utils/AuthUtils.java", "webserver/src/main/java/io/kestra/webserver/controllers/MiscController.java", "webserver/src/main/java/io/kestra/webserver/filter/AuthenticationFilter.java", "webserver/src/main/java/io/kestra/webserver/listeners/OssAuthListener.java", "webserver/src/main/java/io/kestra/webserver/models/events/Event.java", "webserver/src/main/java/io/kestra/webserver/models/events/OssAuthEvent.java", "webserver/src/main/java/io/kestra/webserver/services/BasicAuthService.java" ]

[ "webserver/src/test/java/io/kestra/webserver/controllers/MiscControllerSecuredTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/MiscControllerTest.java", "webserver/src/test/java/io/kestra/webserver/filter/AuthenticationFilterTest.java", "webserver/src/test/java/io/kestra/webserver/services/BasicAuthServiceTest.java", "webserver/src/test/resources/application-test.yml" ]

[ "keyword_pr_to_issue" ]

[ "This issue is only related to `inputs`: if the user has sensitive input information, adding a `SECRET`-type input might be a great solution, as proposed here.\r\n\r\nWhen it comes to obfuscating Secret values from:\r\n- the logs\r\n- inputs passed to subflows/tasks \r\n- outputs\r\n\r\ncheck this issue: https://github.com/kestra-io/kestra/issues/2046 \r\n\r\n\r\n" ]

[]

[ "backend" ]

[ "core/src/main/java/io/kestra/core/models/flows/Input.java", "core/src/main/java/io/kestra/core/runners/RunContext.java", "core/src/main/java/io/kestra/core/runners/RunnerUtils.java", "ui/src/components/executions/Overview.vue", "ui/src/components/flows/FlowRun.vue" ]

[ "core/src/main/java/io/kestra/core/models/flows/Input.java", "core/src/main/java/io/kestra/core/models/flows/input/SecretInput.java", "core/src/main/java/io/kestra/core/runners/RunContext.java", "core/src/main/java/io/kestra/core/runners/RunnerUtils.java", "ui/src/components/executions/Overview.vue", "ui/src/components/flows/FlowRun.vue" ]

[ "core/src/test/java/io/kestra/core/runners/InputsTest.java", "core/src/test/java/io/kestra/core/serializers/YamlFlowParserTest.java", "core/src/test/resources/flows/valids/inputs.yaml", "webserver/src/test/java/io/kestra/webserver/controllers/ExecutionControllerTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/PluginControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug", "customer-request" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[]

[ "keyword_pr_to_issue" ]

[ "Can you give us more information about the issue.\n\n- How do you set this env variable that includes a new line? Newline on itself is cumbersome in the shell.\n- What is the error in Kestra? Do you have any logs?" ]

[]

[ "bug", "quick-win" ]

[ "build.gradle", "core/src/main/java/io/kestra/core/secret/SecretService.java" ]

[ "build.gradle", "core/src/main/java/io/kestra/core/secret/SecretService.java" ]

[ "core/src/test/java/io/kestra/core/secret/SecretFunctionTest.java", "core/src/test/resources/flows/valids/secrets.yaml" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/NamespaceFilesService.java" ]

[ "core/src/main/java/io/kestra/core/runners/NamespaceFilesService.java" ]

[ "core/src/test/java/io/kestra/core/runners/NamespaceFilesServiceTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug", "quick-win" ]

[ "ui/src/components/executions/Logs.vue", "ui/src/components/executions/TaskRunLine.vue" ]

[ "ui/src/components/executions/Logs.vue", "ui/src/components/executions/TaskRunLine.vue" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutorState.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcExecutor.java" ]

[ "core/src/main/java/io/kestra/core/runners/ExecutorState.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcExecutor.java" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/models/executions/LogEntry.java", "core/src/main/java/io/kestra/core/queues/QueueService.java", "core/src/main/java/io/kestra/core/repositories/LogRepositoryInterface.java", "core/src/main/java/io/kestra/core/runners/RunContextLogger.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcLogRepository.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryLogRepository.java", "webserver/src/main/java/io/kestra/webserver/controllers/LogController.java" ]

[ "core/src/main/java/io/kestra/core/models/executions/LogEntry.java", "core/src/main/java/io/kestra/core/queues/QueueService.java", "core/src/main/java/io/kestra/core/repositories/LogRepositoryInterface.java", "core/src/main/java/io/kestra/core/runners/RunContextLogger.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcLogRepository.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryLogRepository.java", "webserver/src/main/java/io/kestra/webserver/controllers/LogController.java" ]

[ "core/src/test/java/io/kestra/core/repositories/AbstractLogRepositoryTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/LogControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[ "@anna-geller there is no audit logs generated when a trigger is automatically disabled due to a stopAfter condition.\r\nAudit logs are for actions made by a user, stopAfter will disable the trigger out of any user context so we cannot create an audit log with our current implementation." ]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/models/triggers/AbstractTrigger.java", "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/models/triggers/TriggerContext.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/schedulers/DefaultScheduler.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcTriggerRepository.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcScheduler.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcSchedulerTriggerState.java", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/AbstractTrigger.java", "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/models/triggers/TriggerContext.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/schedulers/DefaultScheduler.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcTriggerRepository.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcScheduler.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcSchedulerTriggerState.java", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "core/src/test/java/io/kestra/core/docs/JsonSchemaGeneratorTest.java", "core/src/test/java/io/kestra/core/schedulers/AbstractSchedulerTest.java", "core/src/test/java/io/kestra/core/schedulers/SchedulerPollingTriggerTest.java", "core/src/test/java/io/kestra/core/schedulers/SchedulerScheduleTest.java" ]

[ "keyword_pr_to_issue" ]

[ "There is a high risk that users already used `system` for their system flows.\r\n\r\nWhat we can do however, is to use as _system_ namespace a namespace name that users cannot use as it's not valid (this may require some work on our side) like `*system*`. If those flows will not be editable from users the name of the namespace will not be that important so we may also generate it and register the generated name somewhere.", "There is no risk, we won't delete any flows or namespaces for the user. The idea is that if they have a system namespace in 0.15.0, they will see a warning asking to change the name because this namespace will be reserved for system flows. Even if they have some of them, they will not be gone, they will just be hidden behind system flow so they will need to then move if they don't want to always click on the dropdown to find those flows and executions\r\n\r\nI think this issue will clarify https://github.com/kestra-io/kestra/issues/3003 \r\n\r\nFor now, we only need a warning, that's all", "There is no way to 'move' a flow so they will need to delete the flow and re-create it.", "yes you're right, that's a tradeoff we have to make", "The idea of hiding an _internal functionality_ performed by _utility flows_ is interesting. Could the name be configurable like the [env-vars-prefix](https://kestra.io/docs/administrator-guide/configuration/others#kestravariablesenv-vars-prefix) is?", "> The idea of hiding an _internal functionality_ performed by _utility flows_ is interesting. Could the name be configurable like the [env-vars-prefix](https://kestra.io/docs/administrator-guide/configuration/others#kestravariablesenv-vars-prefix) is?\r\n\r\n@yuri1969 we would like to call the feature system flows so the preference would be to put it in the system namespace for maximum clarity. Do you have some specific use cases that would require putting system flows in another namespace (i.e. making it a configuration)?", "@anna-geller No particular use case here beyond flexibility.", "ok, let's do it:\r\n\r\n```yaml\r\nkestra:\r\n system-flows:\r\n namespace: system\r\n```" ]

[ "I supposed that the syntax `:system` is used to set a default, but I think for user it would be great to put it in the application.yml, so its more explicit", "Yes, it provides a default, we use this syntax already in a few places and it avoids adding it to the various configuration files we have.\r\n\r\n> for user it would be great to put it in the application.yml, so its more explicit\r\n\r\nWhat we really need is an example config file with all configuration point and comments. I already thought about it. But this is for a different PR ;) " ]

[ "enhancement" ]

[ "cli/src/main/resources/application.yml", "core/src/main/java/io/kestra/core/models/validations/ValidateConstraintViolation.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "ui/src/components/flows/ValidationError.vue", "ui/src/components/inputs/EditorView.vue", "webserver/src/main/java/io/kestra/webserver/controllers/FlowController.java" ]

[ "cli/src/main/resources/application.yml", "core/src/main/java/io/kestra/core/models/validations/ValidateConstraintViolation.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "ui/src/components/flows/ValidationError.vue", "ui/src/components/inputs/EditorView.vue", "webserver/src/main/java/io/kestra/webserver/controllers/FlowController.java" ]

[ "core/src/test/java/io/kestra/core/services/FlowServiceTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/FlowControllerTest.java", "webserver/src/test/resources/application-test.yml", "webserver/src/test/resources/flows/validateMultipleValidFlows.yaml" ]

[ "keyword_pr_to_issue" ]

[ "indeed, quite an urgent bug https://share.descript.com/view/cxaYIAZcOAd " ]

[]

[ "bug", "quick-win" ]

[ "ui/src/components/flows/FlowCreate.vue", "ui/src/components/inputs/EditorView.vue" ]

[ "ui/src/components/flows/FlowCreate.vue", "ui/src/components/inputs/EditorView.vue" ]

[]

[ "keyword_pr_to_issue" ]

[ "definitely worth showing a warning in the UI when creating a flow with such invalid condition and disable those WARN logs.\r\n\r\nI was able to reproduce that this log message appears every couple of milliseconds:\r\n\r\n```Java\r\n2024-01-07 20:07:46,922 WARN pool-7-thread-1 f.h.naive-schedule-condition [namespace: company.team] [flow: hello-world-var-condition] [condition: VariableCondition(super=io.kestra.core.models.conditions.types.VariableCondition@596bcd, expression={{ trigger.date | date() < now() }})] Evaluate Condition Failed with error 'io.pebbletemplates.pebble.error.PebbleException: Could not perform greater modulus ({{ trigger.date | date() < now() }}:1)'\r\nio.kestra.core.exceptions.IllegalVariableEvaluationException: io.pebbletemplates.pebble.error.PebbleException: Could not perform greater modulus ({{ trigger.date | date() < now() }}:1)\r\n\tat io.kestra.core.runners.VariableRenderer.properPebbleException(VariableRenderer.java:166)\r\n\tat io.kestra.core.runners.VariableRenderer.recursiveRender(VariableRenderer.java:127)\r\n\tat io.kestra.core.runners.VariableRenderer.render(VariableRenderer.java:170)\r\n\tat io.kestra.core.runners.RunContext.render(RunContext.java:442)\r\n\tat io.kestra.core.models.conditions.types.VariableCondition.test(VariableCondition.java:50)\r\n\tat io.kestra.core.services.ConditionService.lambda$isValid$0(ConditionService.java:69)\r\n\tat java.base/java.util.stream.MatchOps$1MatchSink.accept(Unknown Source)\r\n\tat java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline.forEachWithCancel(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)\r\n\tat java.base/java.util.stream.MatchOps$MatchOp.evaluateSequential(Unknown Source)\r\n\tat java.base/java.util.stream.MatchOps$MatchOp.evaluateSequential(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline.allMatch(Unknown Source)\r\n\tat io.kestra.core.services.ConditionService.isValid(ConditionService.java:67)\r\n\tat io.kestra.core.models.triggers.types.Schedule.validateScheduleCondition(Schedule.java:433)\r\n\tat io.kestra.core.models.triggers.types.Schedule.truePreviousNextDateWithCondition(Schedule.java:393)\r\n\tat io.kestra.core.models.triggers.types.Schedule.nextEvaluationDate(Schedule.java:186)\r\n\tat io.kestra.core.schedulers.AbstractScheduler.lambda$handle$15(AbstractScheduler.java:259)\r\n\tat java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)\r\n\tat java.base/java.util.AbstractList$RandomAccessSpliterator.forEachRemaining(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)\r\n\tat java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline.toArray(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline.toArray(Unknown Source)\r\n\tat java.base/java.util.stream.ReferencePipeline.toList(Unknown Source)\r\n\tat io.kestra.core.schedulers.AbstractScheduler.handle(AbstractScheduler.java:268)\r\n\tat java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)\r\n\tat java.base/java.util.concurrent.FutureTask.runAndReset(Unknown Source)\r\n\tat java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)\r\n\tat java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)\r\n\tat java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)\r\n\tat java.base/java.lang.Thread.run(Unknown Source)\r\nCaused by: io.pebbletemplates.pebble.error.PebbleException: Could not perform greater modulus ({{ trigger.date | date() < now() }}:1)\r\n\tat io.pebbletemplates.pebble.node.expression.LessThanExpression.evaluate(LessThanExpression.java:25)\r\n\tat io.pebbletemplates.pebble.node.expression.LessThanExpression.evaluate(LessThanExpression.java:16)\r\n\tat io.pebbletemplates.pebble.node.PrintNode.render(PrintNode.java:37)\r\n\tat io.pebbletemplates.pebble.node.BodyNode.render(BodyNode.java:44)\r\n\tat io.pebbletemplates.pebble.node.RootNode.render(RootNode.java:31)\r\n\tat io.pebbletemplates.pebble.template.PebbleTemplateImpl.evaluate(PebbleTemplateImpl.java:157)\r\n\tat io.pebbletemplates.pebble.template.PebbleTemplateImpl.evaluate(PebbleTemplateImpl.java:96)\r\n\tat io.kestra.core.runners.VariableRenderer.recursiveRender(VariableRenderer.java:122)\r\n\t... 40 common frames omitted\r\nCaused by: java.lang.RuntimeException: invalid operands for mathematical comparison [LESS_THAN]\r\n\tat io.pebbletemplates.pebble.utils.OperatorUtils.wideningConversionBinaryComparison(OperatorUtils.java:189)\r\n\tat io.pebbletemplates.pebble.utils.OperatorUtils.lt(OperatorUtils.java:94)\r\n\tat io.pebbletemplates.pebble.node.expression.LessThanExpression.evaluate(LessThanExpression.java:21)\r\n\t... 47 common frames omitted\r\n```", "- change the WARN level to TRACE or DEBUG\r\n- add a short and informative error message that Pebble in the condition is invalid" ]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/services/ConditionService.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/services/ConditionService.java" ]

[ "core/src/test/java/io/kestra/core/schedulers/SchedulerPollingTriggerTest.java", "core/src/test/java/io/kestra/core/schedulers/SchedulerScheduleTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "I think it's better to calculate the next date out of this method so any exception can be handled easily.\r\nThose methods inside the Trigger object are designed to be builders/mappers." ]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "webserver/src/test/java/io/kestra/webserver/controllers/TriggerControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "I think it's better to calculate the next date out of this method so any exception can be handled easily.\r\nThose methods inside the Trigger object are designed to be builders/mappers." ]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/services/FlowService.java", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "webserver/src/test/java/io/kestra/webserver/controllers/TriggerControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[ "The UX workflow:\r\n\r\n1. Select one or more executions\r\n2. Click on `Set labels` bulk action\r\n3. Fill in the label key value pairs to add or modify/overwrite from the same \"Executions labels\" box as in Advanced configuration when you click on the Execute button\r\n\r\n\r\n", "Important question: should we limit this functionality to terminated execution?\r\n\r\nif not, this may be hard to implement as there will be races with the executor.", "yup definitely 👍 \r\n\r\nduring execution, labels can already be overwritten by the Labels task so good point about the race condition. " ]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/repositories/ExecutionRepositoryInterface.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcExecutionRepository.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryExecutionRepository.java", "ui/src/components/executions/Executions.vue", "ui/src/components/executions/Overview.vue", "ui/src/stores/executions.js", "ui/src/translations.json", "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[ "core/src/main/java/io/kestra/core/repositories/ExecutionRepositoryInterface.java", "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcExecutionRepository.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryExecutionRepository.java", "ui/src/components/executions/Executions.vue", "ui/src/components/executions/Overview.vue", "ui/src/components/executions/SetLabels.vue", "ui/src/stores/executions.js", "ui/src/translations.json", "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[ "core/src/test/java/io/kestra/core/repositories/AbstractExecutionRepositoryTest.java", "webserver/src/test/java/io/kestra/webserver/controllers/ExecutionControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/services/ConditionService.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/Trigger.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/services/ConditionService.java" ]

[ "core/src/test/java/io/kestra/core/schedulers/SchedulerPollingTriggerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/stores/flow.js" ]

[ "ui/src/stores/flow.js" ]

[]

[ "keyword_pr_to_issue" ]

[ "Shouldn't we use the new kestra.plugins.configuration property to override default values of the Schedule `recoverMissedSchedules` property?", "sure, might be more intuitive that way\r\n\r\nI believe someone initially suggested `server` by assuming this is meant as Scheduler property \r\n\r\njust to confirm, would this be then like so?\r\n\r\n```yaml\r\nkestra:\r\n plugins:\r\n configurations:\r\n - type: io.kestra.core.models.triggers.types.Schedule\r\n values:\r\n recoverMissedSchedules: LAST | NONE | ALL # ⚡️ new!\r\n```\r\n", "> just to confirm, would this be then like so?\r\n\r\nYes it will." ]

[ "@loicmathieu shouldn't this be `recoverMissedSchedules: ALL`? (without hyphens)" ]

[ "enhancement", "medium-sized-issue", "customer-request" ]

[ "cli/src/main/resources/application.yml", "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/runners/RunContext.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/schedulers/DefaultScheduler.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcScheduler.java", "ui/src/translations.json" ]

[ "cli/src/main/resources/application.yml", "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/runners/RunContext.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/schedulers/DefaultScheduler.java", "jdbc/src/main/java/io/kestra/jdbc/runner/JdbcScheduler.java", "ui/src/translations.json" ]

[ "core/src/test/java/io/kestra/core/models/triggers/types/ScheduleTest.java", "core/src/test/java/io/kestra/core/plugins/PluginConfigurationTest.java", "core/src/test/java/io/kestra/core/schedulers/SchedulerScheduleTest.java", "core/src/test/resources/application-test.yml" ]

[ "keyword_pr_to_issue" ]

[ "\r\ninstead of:\r\n```yaml\r\nid: beverage_order\r\nnamespace: dev\r\n\r\ninputs:\r\n - name: beverage\r\n type: STRING\r\n defaults: coffee\r\n\r\ntasks:\r\n - id: order_beverage\r\n type: io.kestra.plugin.fs.http.Request\r\n uri: https://reqres.in/api/products\r\n method: POST\r\n contentType: application/json\r\n formData:\r\n beverage: \"{{inputs.beverage}}\"\r\n\r\n - id: set_labels\r\n type: io.kestra.core.tasks.executions.Labels\r\n labels:\r\n date: \"{{trigger.date ?? execution.startDate | date('yyyy-MM-dd')}}\"\r\n beverage: \"{{inputs.beverage}}\"\r\n\r\ntriggers:\r\n - id: workday\r\n type: io.kestra.core.models.triggers.types.Schedule\r\n cron: \"0 9 * * *\"\r\n scheduleConditions:\r\n - type: io.kestra.core.models.conditions.types.NotCondition\r\n conditions:\r\n - type: io.kestra.core.models.conditions.types.WeekendCondition\r\n\r\n - id: weekend\r\n type: io.kestra.core.models.triggers.types.Schedule\r\n cron: \"0 9 * * *\" # every day at 9am\r\n scheduleConditions:\r\n - type: io.kestra.core.models.conditions.types.WeekendCondition\r\n inputs:\r\n beverage: beer\r\n```\r\n\r\nchange to this:\r\n\r\n```yaml\r\nid: beverage_order\r\nnamespace: dev\r\n\r\ninputs:\r\n - name: beverage\r\n type: STRING\r\n defaults: coffee\r\n\r\ntasks:\r\n - id: order_beverage\r\n type: io.kestra.plugin.fs.http.Request\r\n uri: https://reqres.in/api/products\r\n method: POST\r\n contentType: application/json\r\n formData:\r\n beverage: \"{{inputs.beverage}}\"\r\n\r\n - id: set_labels\r\n type: io.kestra.core.tasks.executions.Labels\r\n labels:\r\n date: \"{{trigger.date ?? execution.startDate | date('yyyy-MM-dd')}}\"\r\n beverage: \"{{inputs.beverage}}\"\r\n\r\ntriggers:\r\n - id: workday\r\n type: io.kestra.core.models.triggers.types.Schedule\r\n cron: \"0 9 * * *\"\r\n conditions:\r\n - type: io.kestra.core.models.conditions.types.NotCondition\r\n conditions:\r\n - type: io.kestra.core.models.conditions.types.WeekendCondition\r\n\r\n - id: weekend\r\n type: io.kestra.core.models.triggers.types.Schedule\r\n cron: \"0 9 * * *\" # every day at 9am\r\n conditions:\r\n - type: io.kestra.core.models.conditions.types.WeekendCondition\r\n inputs:\r\n beverage: beer\r\n```\r\n\r\n " ]

[ "Why do you remove the validation", "```suggestion\r\n if (this.getConditions() != null) {\r\n```\r\n\r\nYou should use getConditions() everywhere to have the merge of conditions and scheduleConditions", "```suggestion\r\n```\r\n\r\nI think you just did what this FIXME means ;)", "Why do you want to evaluate disabled triggers?", "This change should be revert, if we cannot get the nextDate with conditions, we get the next date without evaluating the condition. This is important to avoid evaluating the condition on each second.", "I don't understand why you do that here now", "Why did you removed this test?", "It test the previous backfill", "If it shouldnt be evaluated, meaning the executionDate isn't validated by the condition, then we currently do nothing, then the trigger is re-evaluated the next second\r\nSo if the currentDate isn't good, we do calculate the next time it should be evaluated again", "You did the filtering of disabled triggers earlier :\r\n\r\n", "I'm lost with all those evaluations.\r\nI'll trust you on this one, as long as the existing tests pass.", "If it's still there the test should stay and be removed when it disapear." ]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/models/conditions/types/TimeBetweenCondition.java", "core/src/main/java/io/kestra/core/models/triggers/AbstractTrigger.java", "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java", "core/src/main/java/io/kestra/core/validations/Schedule.java", "core/src/main/java/io/kestra/core/validations/validator/ScheduleValidator.java" ]

[ "core/src/main/java/io/kestra/core/models/conditions/types/TimeBetweenCondition.java", "core/src/main/java/io/kestra/core/models/triggers/AbstractTrigger.java", "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java", "core/src/main/java/io/kestra/core/schedulers/AbstractScheduler.java" ]

[ "core/src/test/java/io/kestra/core/models/conditions/types/TimeBetweenConditionTest.java", "core/src/test/java/io/kestra/core/models/triggers/types/ScheduleTest.java", "core/src/test/java/io/kestra/core/schedulers/SchedulerConditionTest.java", "core/src/test/java/io/kestra/core/schedulers/SchedulerScheduleTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "Errors should not be deprecated as it's part of the Flowable interface", "Will Pause still be a flowable later ? I don't see any reason, and errors is used for tasks in the flowable, no tasks, no errors ?", "Yes, pause will still be a flowable as it's executed by the executor." ]

[ "enhancement", "quick-win" ]

[ "core/src/main/java/io/kestra/core/tasks/flows/Pause.java", "core/src/main/java/io/kestra/core/tasks/flows/Sequential.java", "ui/src/App.vue" ]

[ "core/src/main/java/io/kestra/core/tasks/flows/Pause.java", "core/src/main/java/io/kestra/core/tasks/flows/Sequential.java", "ui/src/App.vue" ]

[ "core/src/test/java/io/kestra/core/tasks/flows/PauseTest.java", "core/src/test/resources/flows/valids/pause_no_tasks.yaml" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/docs/AbstractClassDocumentation.java" ]

[ "core/src/main/java/io/kestra/core/docs/AbstractClassDocumentation.java" ]

[ "cli/src/test/java/io/kestra/cli/commands/plugins/PluginDocCommandTest.java" ]

[ "keyword_pr_to_issue" ]

[ "The toggle is independent of what is configured in the code. If you disable the trigger explicitly in your flow code, there is no other way to reenable it unless you change the source code again.\r\n\r\nIf `disabled: true` in the source code, you should not be able to toggle it on. It works on the Flow's Trigger page. However, you are right, this is indeed a bug on the Administration page: https://share.descript.com/view/ZUaJMVu2JJt\r\n", "Repro: try any disabled trigger:\r\n\r\n```yaml\r\nid: hello-world\r\nnamespace: company.team\r\ntasks:\r\n - id: hello\r\n type: io.kestra.core.tasks.log.Log\r\n message: Kestra team wishes you a great day! 👋\r\n\r\ntriggers:\r\n - id: schedule\r\n type: io.kestra.core.models.triggers.types.Schedule\r\n disabled: true\r\n cron: \"* * * * *\"\r\n```\r\n\r\nThen go to the Admin Trigger page and you will be able to toggle it, even though you shouldn't as it has no effect (explicitly disabled in code takes priority). \r\n\r\n\r\n" ]

[]

[ "bug" ]

[ "ui/src/components/admin/Triggers.vue", "ui/src/translations.json", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "ui/src/components/admin/Triggers.vue", "ui/src/translations.json", "webserver/src/main/java/io/kestra/webserver/controllers/TriggerController.java" ]

[ "webserver/src/test/java/io/kestra/webserver/controllers/TriggerControllerTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "ui/src/components/inputs/SwitchView.vue" ]

[ "ui/src/components/inputs/SwitchView.vue" ]

[]

[ "keyword_pr_to_issue" ]

[ "Can you copy/paste the flow YAML that trigger this exception?", "```yaml\r\nid: pause_resume\r\nnamespace: dev\r\n\r\ntasks:\r\n - id: pause\r\n type: io.kestra.core.tasks.flows.Pause\r\n\r\n - id: after_pause\r\n type: io.kestra.core.tasks.log.Log\r\n message: Execution has been resumed!\r\n```" ]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/models/tasks/FlowableTask.java", "core/src/main/java/io/kestra/core/tasks/flows/Pause.java", "core/src/main/java/io/kestra/core/tasks/flows/Sequential.java" ]

[ "core/src/main/java/io/kestra/core/models/tasks/FlowableTask.java", "core/src/main/java/io/kestra/core/tasks/flows/Pause.java", "core/src/main/java/io/kestra/core/tasks/flows/Sequential.java" ]

[]

[ "keyword_pr_to_issue" ]

[ "This would enhance the use of templated subflows, allowing to create subflows that use inputs to define it's behaviour.", "TBD consider making it just one task as the implementation would be much easier/faster", "Here's an example that could kind of work out of the box, dependent on the deserialization of YAML and type verification.\r\n\r\n```yaml\r\nid: nested-parameters-from-inputs\r\nnamespace: test\r\n\r\ninputs:\r\n - name: imagePullSecrets\r\n type: STRING\r\n # defaults: \"\"\r\n description: \"Kubernetes GitLab Container Registry API access token\"\r\n required: true\r\n\r\n # the following represents the object resources with nested structure as supported by Kestra\r\n - name: resources.limits.cpu\r\n type: STRING\r\n defaults: \"1\"\r\n required: true\r\n\r\n - name: resources.limits.memory\r\n type: STRING\r\n defaults: \"1000Mi\"\r\n required: true\r\n\r\n - name: resources.requests.cpu\r\n type: STRING\r\n required: false # note that this is optional and when not filled, it should be skipped in the definition (could be with a filter before passing the argument)\r\n\r\n - name: resources.requests.memory\r\n type: STRING\r\n required: false # note that this is optional and when not filled, it should be skipped in the definition (could be with a filter before passing the argument)\r\n\r\n# using variables here to support other data types not supported by inputs, specifically lists\r\nvariables:\r\n env: # interpreted as an array of objects\r\n - name: VARIABLE_1\r\n value: \"VALUE_1\"\r\n - name: VARIABLE_2\r\n value: \"VALUE_2\"\r\n\r\n command: # interpreted as an array of strings\r\n - 'bash' \r\n - '-c'\r\n - 'for i in {1..10}; do echo $i; sleep 0.1; done'\r\n\r\ntasks:\r\n - id: pod\r\n type: \"io.kestra.plugin.kubernetes.PodCreate\"\r\n namespace: kestra\r\n spec:\r\n containers:\r\n - name: unittest\r\n image: debian:stable-slim\r\n\r\n # k8s command by definition is a list of strings\r\n # here we should be able to expand variables.command, which is also a list of strings\r\n command: {{ vars.command }}\r\n\r\n # k8s env by definition is a list of objects (name, value as keys)\r\n # here we should be able to expand variables.env, which is also a list of objects\r\n env: {{ vars.env }} \r\n\r\n # k8s resources is a complex nested object\r\n # since in the input variable \"resources\" we have also defined a nested input parameter\r\n # that follows the structure, we should be able to deserialize it just like YAML definition\r\n resources: {{ inputs.resources }}\r\n # here we should perhaps filter out any attributes with null values, when they are not defined in the inputs.\r\n\r\n # example of the original idea in this issue\r\n # optional, string based deserialization, maybe not the best way to handle this\r\n # this would require deserialization of a string to a nested YAML format\r\n imagePullSecrets: | \r\n - name: \"{{ inputs.imagePullSecrets }}\"\r\n\r\n```\r\n\r\nAll except for the last example should actually be similar to Kestra's best practice, however currently, this way it does not really work.\r\n\r\nEven though the nested input and variables are correctly loaded as JSON objects/arrays, then the type verification and deserialization process happens in an order that prohibits this type of use.\r\n\r\nThe last option which is an example from Anna's post is one workaround to implement the end goal, but I'd actually prefer a more straight forward approach - not having to hard-code all the properties of the task definition, but pass them along as (almost) correctly typed objects.\r\n\r\nThis would allow manipulation of the objects between inputs, passing them to subflows and dynamically altering where necessary.", "Perhaps a more concrete example could be the following, closely resembling our use-case.\r\n\r\n### Templated subflow - a common flow to be called from specific implementations\r\n\r\n```yaml\r\nid: templated-podcreate\r\nnamespace: test\r\n\r\ninputs:\r\n - name: env\r\n type: JSON\r\n default: \"[]\"\r\n required: false\r\n description: \"Optionally pass additional environment variables to PodCreate\"\r\n\r\n - name: command\r\n type: JSON\r\n default: \"[]\"\r\n required: true\r\n description: \"Pass specific commands to PodCreate\"\r\n\r\n - name: imagePullSecrets\r\n type: STRING\r\n # defaults: \"\"\r\n required: true\r\n\r\n # the following represents the object resources with nested structure as supported by Kestra\r\n - name: resources.limits.cpu\r\n type: STRING\r\n defaults: \"1\"\r\n required: true\r\n\r\n - name: resources.limits.memory\r\n type: STRING\r\n defaults: \"1000Mi\"\r\n required: true\r\n\r\n - name: resources.requests.cpu\r\n type: STRING\r\n required: false # note that this is optional and when not filled, it should be skipped in the definition (could be with a filter before passing the argument)\r\n\r\n - name: resources.requests.memory\r\n type: STRING\r\n required: false # note that this is optional and when not filled, it should be skipped in the definition (could be with a filter before passing the argument)\r\n\r\nvariables:\r\n common_env: # here we define common environment variables that are added to the input env's\r\n - name: COMMON_1\r\n value: VALUE\r\n\r\n\r\ntasks:\r\n - id: pod\r\n type: \"io.kestra.plugin.kubernetes.PodCreate\"\r\n namespace: kestra\r\n spec:\r\n containers:\r\n - name: unittest\r\n image: debian:stable-slim\r\n\r\n # k8s command by definition is a list of strings\r\n # here we should be able to expand variables.command, which is also a list of strings\r\n command: {{ inputs.command }}\r\n\r\n # k8s env by definition is a list of objects (name, value as keys)\r\n # here we should be able to expand variables.common_env and add inputs.env, which is also a list of objects\r\n env: {{ vars.common_env | merge(inputs.env) }}\r\n\r\n # k8s resources is a complex nested object\r\n # since in the input variable \"resources\" we have also defined a nested input parameter\r\n # that follows the structure, we should be able to deserialize it just like YAML definition\r\n resources: {{ inputs.resources }}\r\n # here we should perhaps filter out any attributes with null values, when they are not defined in the inputs.\r\n\r\n # example of the original idea in this issue\r\n # optional, string based deserialization, maybe not the best way to handle this\r\n # this would require deserialization of a string to a nested YAML format\r\n # this could be done similarily as with env's example above\r\n imagePullSecrets: |\r\n - name: \"common-secret\" # predefined common pullsecret\r\n - name: \"{{ inputs.imagePullSecrets }}\" # string here\r\n\r\n```\r\n\r\n### Specific flow that itself calls the templated subflow\r\n\r\n```yaml\r\nid: run-podcreate\r\nnamespace: test\r\n\r\nvariables:\r\n env: # interpreted as an array of objects\r\n - name: VARIABLE_1\r\n value: \"VALUE_1\"\r\n - name: VARIABLE_2\r\n value: \"VALUE_2\"\r\n\r\n command: # interpreted as an array of strings\r\n - 'bash'\r\n - '-c'\r\n - 'for i in {1..10}; do echo $i; sleep 0.1; done'\r\n\r\ntasks:\r\n - id: \"load-table-kubernetes\"\r\n type: \"io.kestra.core.tasks.flows.Subflow\"\r\n flowId: templated-podcreate\r\n namespace: test\r\n inputs: \r\n env: {{ vars.env }} # passing additional envs to subflow that will be merged with common\r\n command: {{ vars.command }} # our specific command\r\n imagePullSecrets: \"mypullsecret\" # our specific pullsecret\r\n\r\n # resources.limits.cpu: \"1\" # not passing, using default defined in subflow\r\n resources.limits.memory: \"128\" # overwriting default defined in subflow\r\n resources.requests.cpu: \"0.5\" # assigning a value to subflow optional input\r\n # resources.requests.memory: \"\" # not passing, not defined in subflow either, thus should not be passed to k8s\r\n```\r\n\r\n### Variable deserialization\r\nNow as for variable interpolation or parsing goes, no preferences here, instead of:\r\n```\r\n resources: {{ inputs.resources }}\r\n```\r\nit would be fine to use a filter\r\n```\r\n resources: {{ inputs.resources | objectify }}\r\n```\r\nor a function, such as:\r\n```\r\n resources: {{ json(inputs.resources) }}\r\n```\r\nor something like:\r\n```\r\n resources: {{ deserialize(inputs.resources) }}\r\n```\r\n\r\nThus type safety should remain, but it would be possible to pass complex parameters as values to task attributes like it is now possible with strings.", "hi @kriko, thanks for all the suggestions. We plan to add the `DynamicTask` as it will allow maximum flexibility for more advanced use cases like this one. You could use it short term until we introduce a proper KUBERNETES runner that will allow a much nicer way to specify resource definition for a pod - WDYT? \r\n\r\nThe KUBERNETES runner will not suffer from these issues, everything will be typed properly. " ]

[ "```suggestion\r\n title = \"This task's `spec` property allows you to fully template all task properties using Kestra's Pebble templating. This way, all task properties and their values can be dynamically rendered based on your custom inputs, variables, and outputs from other tasks!\"\r\n```" ]

[ "enhancement", "customer-request" ]

[]

[ "core/src/main/java/io/kestra/core/tasks/templating/TemplatedTask.java", "core/src/main/resources/icons/io.kestra.core.tasks.templating.svg" ]

[ "core/src/test/java/io/kestra/core/tasks/templating/TemplatedTaskTest.java" ]

[ "keyword_pr_to_issue" ]

[ "This looks like a dependency issue as we no longer use reactivex.\r\n\r\n> io/reactivex/functions/BiConsumer", "Yes, the goal of these issue is to kept the scheduler running even if a plugin could not be loaded, in that case, we just should log an error and don't load the flow behind. " ]

[]

[ "bug" ]

[ "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcFlowRepository.java" ]

[ "jdbc/src/main/java/io/kestra/jdbc/repository/AbstractJdbcFlowRepository.java" ]

[]

[ "keyword_pr_to_issue" ]

[ "We can have default time range to 1H instead of 30 days 👍 ", "Let's wait for some analysis ;) \r\n\r\nBut we use 7 days for some pages, we might decide to align this page also.", "Locally, it correctly uses the `logs_namespace_flow` index.\n\nAs we switch from 30 days to 7 days in other places I advise to do the same here.\n\nFor the record the SQL query is:\n\n```sql\nselect \"value\" from logs where (\"tenant_id\" is null and \"deleted\" = false and (level in ('ERROR'::log_level, 'WARN'::log_level)) and \"timestamp\" >= cast('2023-09-24 15:30:39.253+02:00' as timestamp with time zone) and \"timestamp\" <= cast('2023-10-24 15:30:39.253+02:00' as timestamp with time zone)) order by \"timestamp\" desc fetch next 10 rows only\n```\n", "> As we switch from 30 days to 7 days in other places I advise to do the same here.\n\nI was wrong, apparently we use 30 days by default in all dashboards (homepage, flows, executions, namespaces, ...)" ]

[]

[ "bug", "quick-win" ]

[]

[ "jdbc-h2/src/main/resources/migrations/h2/V1_16__log_timestamp_index.sql", "jdbc-mysql/src/main/resources/migrations/mysql/V1_16__log_timestamp_index.sql", "jdbc-postgres/src/main/resources/migrations/postgres/V1_16__log_timestamp_index.sql" ]

[]

[ "keyword_pr_to_issue" ]

[ "I believe failing will not help here. The secret function will need to return null if the secret is not found " ]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/RunContextLogger.java", "core/src/main/java/io/kestra/core/secret/SecretService.java" ]

[ "core/src/main/java/io/kestra/core/runners/RunContextLogger.java", "core/src/main/java/io/kestra/core/secret/SecretService.java" ]

[ "core/src/test/java/io/kestra/core/runners/RunContextLoggerTest.java", "core/src/test/java/io/kestra/core/secret/SecretFunctionTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "enhancement" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/functions/ReadFileFunction.java" ]

[ "core/src/main/java/io/kestra/core/runners/pebble/functions/ReadFileFunction.java" ]

[ "core/src/test/java/io/kestra/core/runners/pebble/functions/ReadFileFunctionTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[ "Not a fan of the name of the method.\r\nYou can either update findByExecution to return an optional (and impact all usage) or use the findById() in the only place that needs this method. But adding a method in the interface each time you need something slightly different is a code smell.", "Is it realy needed?\r\nIf so, EE should be updated accordingly." ]

[ "bug" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[ "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "backend" ]

[ "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java" ]

[ "core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java" ]

[]

[ "keyword_pr_to_issue" ]

[ "I'm afraid there is no one-size-fits-all here as we sometime may want to escape some special char to be displayed in the documentation and sometimes not.\r\n\r\nIn these cases, the best is to add a `defaultValue` in the schema, this will override in the documentation the default value computed from the task default attribute value.\r\n\r\nI'll do it for the task referenced here." ]

[]

[ "bug", "quick-win" ]

[ "core/src/main/java/io/kestra/core/storages/StorageSplitInterface.java" ]

[ "core/src/main/java/io/kestra/core/storages/StorageSplitInterface.java" ]

[]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/models/hierarchies/AbstractGraphTrigger.java", "core/src/main/java/io/kestra/core/models/hierarchies/GraphTrigger.java", "core/src/main/java/io/kestra/core/services/GraphService.java", "core/src/main/java/io/kestra/core/utils/GraphUtils.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryTriggerRepository.java", "ui/package-lock.json", "ui/package.json", "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[ "core/src/main/java/io/kestra/core/models/hierarchies/AbstractGraphTrigger.java", "core/src/main/java/io/kestra/core/models/hierarchies/GraphTrigger.java", "core/src/main/java/io/kestra/core/services/GraphService.java", "core/src/main/java/io/kestra/core/utils/GraphUtils.java", "repository-memory/src/main/java/io/kestra/repository/memory/MemoryTriggerRepository.java", "ui/package-lock.json", "ui/package.json", "webserver/src/main/java/io/kestra/webserver/controllers/ExecutionController.java" ]

[ "core/src/test/java/io/kestra/core/models/hierarchies/FlowGraphTest.java", "core/src/test/java/io/kestra/core/repositories/AbstractTriggerRepositoryTest.java" ]

[ "keyword_pr_to_issue" ]

[]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/services/StorageService.java" ]

[ "core/src/main/java/io/kestra/core/services/StorageService.java" ]

[]

[ "keyword_pr_to_issue" ]

[ "ForEachItem is considered as a dependency, it just need the children from to exists\r\n\r\n\r\n", "Could you try inverting the creation, before the ForEach flow after the subflow please ?\r\nAs I remember, I've done by this way as I remember " ]

[]

[ "bug" ]

[ "core/src/main/java/io/kestra/core/tasks/flows/ForEachItem.java", "core/src/main/java/io/kestra/core/tasks/flows/Subflow.java" ]

[ "core/src/main/java/io/kestra/core/tasks/flows/ChildFlowInterface.java", "core/src/main/java/io/kestra/core/tasks/flows/ForEachItem.java", "core/src/main/java/io/kestra/core/tasks/flows/Subflow.java" ]

[]