@@ -56,6 +56,12 @@ func (r *Reporter) Failed(cr *cmapi.CertificateRequest, err error, reason, messa
 	r.recorder.Event(cr, corev1.EventTypeWarning, reason, message)
 	apiutil.SetCertificateRequestCondition(cr, cmapi.CertificateRequestConditionReady,
 		cmmeta.ConditionFalse, cmapi.CertificateRequestReasonFailed, message)
+
+}
+
+func (r *Reporter) InvalidRequest(cr *cmapi.CertificateRequest) {
+	apiutil.SetCertificateRequestCondition(cr, cmapi.CertificateRequestConditionInvalidRequest,
+		cmmeta.ConditionTrue, "", "")
 }
 
 func (r *Reporter) Pending(cr *cmapi.CertificateRequest, err error, reason, message string) {
/*
Copyright 2019 The Jetstack cert-manager contributors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package util

import (
	"fmt"

	corev1 "k8s.io/api/core/v1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/client-go/tools/record"
	"k8s.io/utils/clock"

	apiutil "github.com/jetstack/cert-manager/pkg/api/util"
	cmapi "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1alpha2"
	cmmeta "github.com/jetstack/cert-manager/pkg/apis/meta/v1"
)

const (
	readyMessage = "Certificate fetched from issuer successfully"
)

type Reporter struct {
	clock    clock.Clock
	recorder record.EventRecorder
}

func NewReporter(clock clock.Clock, recorder record.EventRecorder) *Reporter {
	return &Reporter{
		clock:    clock,
		recorder: recorder,
	}
}

func (r *Reporter) Failed(cr *cmapi.CertificateRequest, err error, reason, message string) {
	// Set the FailureTime to c.clock.Now(), only if it has not been already set.
	if cr.Status.FailureTime == nil {
		nowTime := metav1.NewTime(r.clock.Now())
		cr.Status.FailureTime = &nowTime
	}

	message = fmt.Sprintf("%s: %v", message, err)
	r.recorder.Event(cr, corev1.EventTypeWarning, reason, message)
	apiutil.SetCertificateRequestCondition(cr, cmapi.CertificateRequestConditionReady,
		cmmeta.ConditionFalse, cmapi.CertificateRequestReasonFailed, message)
}

func (r *Reporter) Pending(cr *cmapi.CertificateRequest, err error, reason, message string) {
	if err != nil {
		message = fmt.Sprintf("%s: %v", message, err)
	}

	// If pending condition not already set then fire a Pending Event. This is to
	// reduce strain on the API server and avoid rate limiting ourselves for
	// Event creation.
	if apiutil.CertificateRequestReadyReason(cr) != cmapi.CertificateRequestReasonPending {
		r.recorder.Event(cr, corev1.EventTypeNormal, reason, message)
	}

	apiutil.SetCertificateRequestCondition(cr, cmapi.CertificateRequestConditionReady,
		cmmeta.ConditionFalse, cmapi.CertificateRequestReasonPending, message)
}

func (r *Reporter) Ready(cr *cmapi.CertificateRequest) {
	r.recorder.Event(cr, corev1.EventTypeNormal, "CertificateIssued", readyMessage)
	apiutil.SetCertificateRequestCondition(cr, cmapi.CertificateRequestConditionReady,
		cmmeta.ConditionTrue, cmapi.CertificateRequestReasonIssued, readyMessage)
}

We need to also report information as to *why* the request failed (i.e. the 'reason' field) - if this method isn't used yet, it may be best to remove for now. Otherwise can you update the signature to ensure it's useful in future?  