@@ -44,7 +44,7 @@ public class AttributeNode extends AbstractNodeInfo {
     @Override
     public Value atomize() throws XPathException {
         if (value == null) {
-            Object v = attribute.getValue();
+            final Object v = attribute.getValue();
             value = SaxonXPathRuleQuery.getAtomicRepresentation(v);
         }
         return value;
/**
 * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
 */

package net.sourceforge.pmd.lang.ast.xpath.saxon;

import net.sourceforge.pmd.lang.ast.xpath.Attribute;
import net.sourceforge.pmd.lang.rule.xpath.SaxonXPathRuleQuery;

import net.sf.saxon.om.NodeInfo;
import net.sf.saxon.om.SequenceIterator;
import net.sf.saxon.trans.XPathException;
import net.sf.saxon.type.Type;
import net.sf.saxon.value.Value;

/**
 * A Saxon OM Attribute node for an AST Node Attribute.
 */
public class AttributeNode extends AbstractNodeInfo {
    protected final Attribute attribute;
    protected final int id;
    protected Value value;

    public AttributeNode(Attribute attribute, int id) {
        this.attribute = attribute;
        this.id = id;
    }

    @Override
    public int getNodeKind() {
        return Type.ATTRIBUTE;
    }

    @Override
    public String getLocalPart() {
        return attribute.getName();
    }

    @Override
    public String getURI() {
        return "";
    }

    @Override
    public Value atomize() throws XPathException {
        if (value == null) {
            Object v = attribute.getValue();
            value = SaxonXPathRuleQuery.getAtomicRepresentation(v);
        }
        return value;
    }

    @Override
    public CharSequence getStringValueCS() {
        return attribute.getStringValue();
    }

    @Override
    public SequenceIterator getTypedValue() throws XPathException {
        return atomize().iterate();
    }

    @Override
    public int compareOrder(NodeInfo other) {
        return Integer.signum(this.id - ((AttributeNode) other).id);
    }
}

Maybe inline that variable