@@ -133,8 +133,11 @@ void UpdateVertexExecutor::setupResponse(cpp2::ExecutionResponse &resp) {
 }
 
 
-void UpdateVertexExecutor::finishExecution(storage::cpp2::UpdateResponse &&rpcResp) {
-    resp_ = std::make_unique<cpp2::ExecutionResponse>();
+void UpdateVertexExecutor::finishExecution(storage::cpp2::UpdateResponse &&rpcResp,
+    int32_t vertex) {
+    if (resp_ == nullptr) {
+        resp_ = std::make_unique<cpp2::ExecutionResponse>();
+    }
     std::vector<std::string> columnNames;
     columnNames.reserve(yields_.size());
     for (auto *col : yields_) {
/* Copyright (c) 2019 vesoft inc. All rights reserved.
 *
 * This source code is licensed under Apache 2.0 License,
 * attached with Common Clause Condition 1.0, found in the LICENSES directory.
 */

#include "base/Base.h"
#include "filter/Expressions.h"
#include "graph/UpdateVertexExecutor.h"
#include "storage/client/StorageClient.h"
#include "dataman/RowWriter.h"
#include "dataman/RowReader.h"

namespace nebula {
namespace graph {

// UPDATE/UPSERT VERTEX <vertex_id>
// SET <update_decl> [WHEN <conditions>] [YIELD <field_list>]
UpdateVertexExecutor::UpdateVertexExecutor(Sentence *sentence,
                                           ExecutionContext *ectx)
    : Executor(ectx, "update_vertex") {
    sentence_ = static_cast<UpdateVertexSentence*>(sentence);
}

Status UpdateVertexExecutor::prepare() {
    return Status::OK();
}

Status UpdateVertexExecutor::prepareData() {
    DCHECK(sentence_ != nullptr);

    spaceId_ = ectx()->rctx()->session()->space();
    expCtx_ = std::make_unique<ExpressionContext>();
    expCtx_->setSpace(spaceId_);
    expCtx_->setStorageClient(ectx()->getStorageClient());

    Status status = Status::OK();
    do {
        status = checkIfGraphSpaceChosen();
        if (!status.ok()) {
            break;
        }
        insertable_ = sentence_->getInsertable();
        auto id = sentence_->getVid();
        id->setContext(expCtx_.get());
        status = id->prepare();
        if (!status.ok()) {
            break;
        }
        Getters getters;
        auto vid = id->eval(getters);
        if (!vid.ok() || !Expression::isInt(vid.value())) {
            status = Status::Error("Get Vertex ID failure!");
            break;
        }
        vertex_ = Expression::asInt(vid.value());
        status = prepareSet();
        if (!status.ok()) {
            break;
        }
        status = prepareWhen();
        if (!status.ok()) {
            break;
        }
        status = prepareYield();
        if (!status.ok()) {
            break;
        }
    } while (false);

    if (status.ok()) {
        stats::Stats::addStatsValue(stats_.get(), false, duration().elapsedInUSec());
    }
    return status;
}


Status UpdateVertexExecutor::prepareSet() {
    auto status = Status::OK();
    auto items = sentence_->updateList()->items();
    for (auto& item : items) {
        // item: name_label ASSIGN expression, name_label is alias_ref_expression
        storage::cpp2::UpdateItem updateItem;
        auto expRet = Expression::decode(*item->field());
        if (!expRet.ok()) {
            return Status::SyntaxError("Invalid vertex update item field: " + *item->field());
        }
        auto expr = std::move(expRet).value();
        // alias_ref_expression(LABLE DOT LABLE): TagName.PropName
        auto* eexpr = static_cast<const AliasPropertyExpression*>(expr.get());
        updateItem.name = *eexpr->alias();
        updateItem.prop = *eexpr->prop();
        updateItem.value = Expression::encode(item->value());
        updateItems_.emplace_back(std::move(updateItem));
    }
    return status;
}


Status UpdateVertexExecutor::prepareWhen() {
    auto *clause = sentence_->whenClause();
    if (clause != nullptr) {
        filter_ = clause->filter();
    }
    return Status::OK();
}


Status UpdateVertexExecutor::prepareYield() {
    auto *clause = sentence_->yieldClause();
    if (clause != nullptr) {
        yields_ = clause->columns();
    }
    return Status::OK();
}


std::vector<std::string> UpdateVertexExecutor::getReturnColumns() {
    std::vector<std::string> returnColumns;
    for (auto *col : yields_) {
        auto column = Expression::encode(col->expr());
        returnColumns.emplace_back(std::move(column));
    }
    return returnColumns;
}


void UpdateVertexExecutor::setupResponse(cpp2::ExecutionResponse &resp) {
    if (resp_ == nullptr) {
        resp_ = std::make_unique<cpp2::ExecutionResponse>();
    }
    resp = std::move(*resp_);
}


void UpdateVertexExecutor::finishExecution(storage::cpp2::UpdateResponse &&rpcResp) {
    resp_ = std::make_unique<cpp2::ExecutionResponse>();
    std::vector<std::string> columnNames;
    columnNames.reserve(yields_.size());
    for (auto *col : yields_) {
        if (col->alias() == nullptr) {
            columnNames.emplace_back(col->expr()->toString());
        } else {
            columnNames.emplace_back(*col->alias());
        }
    }
    resp_->set_column_names(std::move(columnNames));

    std::vector<cpp2::RowValue> rows;
    if (rpcResp.__isset.schema && rpcResp.__isset.data) {
        auto schema = std::make_shared<ResultSchemaProvider>(rpcResp.schema);
        auto reader = RowReader::getRowReader(rpcResp.data, schema);
        std::vector<cpp2::ColumnValue> row(yields_.size());
        for (auto index = 0UL; index < yields_.size(); index++) {
            auto res = RowReader::getPropByIndex(reader.get(), index);
            if (ok(res)) {
                auto column = value(std::move(res));
                switch (column.which()) {
                    case VAR_INT64:
                        row[index].set_integer(boost::get<int64_t>(column));
                        break;
                    case VAR_DOUBLE:
                        row[index].set_double_precision(boost::get<double>(column));
                        break;
                    case VAR_BOOL:
                        row[index].set_bool_val(boost::get<bool>(column));
                        break;
                    case VAR_STR:
                        row[index].set_str(boost::get<std::string>(column));
                        break;
                    default:
                        LOG(ERROR) << "Unknown VariantType: " << column.which();
                        doError(Status::Error("Unknown VariantType: %d", column.which()));
                        return;
                }
            } else {
                doError(Status::Error("get property failed"));
                return;
            }
        }
        rows.emplace_back();
        rows.back().set_columns(std::move(row));
    }
    resp_->set_rows(std::move(rows));
    doFinish(Executor::ProcessControl::kNext);
}


void UpdateVertexExecutor::execute() {
    FLOG_INFO("Executing UpdateVertex: %s", sentence_->toString().c_str());

    auto status = prepareData();
    if (!status.ok()) {
        doError(std::move(status));
        return;
    }

    std::string filterStr = filter_ ? Expression::encode(filter_) : "";
    auto returns = getReturnColumns();
    auto future = ectx()->getStorageClient()->updateVertex(spaceId_,
                                                           vertex_,
                                                           filterStr,
                                                           std::move(updateItems_),
                                                           std::move(returns),
                                                           insertable_);
    auto *runner = ectx()->rctx()->runner();
    auto cb = [this] (auto &&resp) {
        if (!resp.ok()) {
            doError(Status::Error("Insert vertex `%ld' failed.", vertex_));
            return;
        }
        auto rpcResp = std::move(resp).value();
        for (auto& code : rpcResp.get_result().get_failed_codes()) {
            switch (code.get_code()) {
                case nebula::storage::cpp2::ErrorCode::E_INVALID_FILTER:
                    doError(Status::Error("Maybe invalid tag or property in WHEN clause!"));
                    return;
                case nebula::storage::cpp2::ErrorCode::E_INVALID_UPDATER:
                    doError(Status::Error("Maybe invalid tag or property in SET/YIELD clasue!"));
                    return;
                case nebula::storage::cpp2::ErrorCode::E_FILTER_OUT:
                    // Treat as Ok so do nothing
                    // https://github.com/vesoft-inc/nebula/issues/1888
                    // TODO(shylock) maybe we need alert user execute ok but no data affect
                    break;
                default:
                    std::string errMsg =
                        folly::stringPrintf("Maybe vertex does not exist or filter failed, "
                                            "part: %d, error code: %d!",
                                            code.get_part_id(),
                                            static_cast<int32_t>(code.get_code()));
                    LOG(ERROR) << errMsg;
                    doError(Status::Error(errMsg));
                    return;
            }
        }
        this->finishExecution(std::move(rpcResp));
    };
    auto error = [this] (auto &&e) {
        auto msg = folly::stringPrintf("Insert vertex `%ld' exception: %s",
                vertex_, e.what().c_str());
        LOG(ERROR) << msg;
        doError(Status::Error(std::move(msg)));
    };
    std::move(future).via(runner).thenValue(cb).thenError(error);
}

}   // namespace graph
}   // namespace nebula

why add this check?