@@ -41,11 +41,11 @@ func TestEnabledControllers(t *testing.T) {
 		},
 		"if all controllers enabled, return all controllers": {
 			controllers: []string{"*"},
-			expEnabled:  sets.NewString(allControllers...),
+			expEnabled:  sets.NewString(defaultEnabledControllers...),
 		},
 		"if all controllers enabled, some diabled, return all controllers with disabled": {
 			controllers: []string{"*", "-clusrerissuers", "-issuer"},
-			expEnabled:  sets.NewString(allControllers...).Delete("-clusterissuers", "-issuers"),
+			expEnabled:  sets.NewString(defaultEnabledControllers...).Delete("-clusterissuers", "-issuers"),
 		},
 	}
 
/*
Copyright 2021 The cert-manager Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package options

import (
	"testing"

	"k8s.io/apimachinery/pkg/util/sets"
)

func TestEnabledControllers(t *testing.T) {
	tests := map[string]struct {
		controllers []string
		expEnabled  sets.String
	}{
		"if no controllers enabled, return empty": {
			controllers: []string{},
			expEnabled:  sets.NewString(),
		},
		"if some controllers enabled, return list": {
			controllers: []string{"foo", "bar"},
			expEnabled:  sets.NewString("foo", "bar"),
		},
		"if some controllers enabled, one then disabled, return list without disabled": {
			controllers: []string{"foo", "bar", "-foo"},
			expEnabled:  sets.NewString("bar"),
		},
		"if all controllers enabled, return all controllers": {
			controllers: []string{"*"},
			expEnabled:  sets.NewString(allControllers...),
		},
		"if all controllers enabled, some diabled, return all controllers with disabled": {
			controllers: []string{"*", "-clusrerissuers", "-issuer"},
			expEnabled:  sets.NewString(allControllers...).Delete("-clusterissuers", "-issuers"),
		},
	}

	for name, test := range tests {
		t.Run(name, func(t *testing.T) {
			o := ControllerOptions{
				controllers: test.controllers,
			}

			got := o.EnabledControllers()
			if !got.Equal(test.expEnabled) {
				t.Errorf("got unexpected enabled, exp=%s got=%s",
					test.expEnabled, got)
			}
		})
	}
}

suggestion: the handling of which controllers are enabled might change based on what was discussed in standup on 27/05, but as-is this test name probably needs updating; this PR is (currently) changing the meaning of `*` from "enable all controllers" to "enable default controllers"