@@ -101,7 +101,7 @@ module EnlistmentFilters
 
   def get_code_location_id
     response = CodeLocationApi.new(url: @code_location.url, branch: @code_location.branch).fetch
-    JSON.parse(response).first['id'] unless response.nil?
+    JSON.parse(response)['id'] unless response.nil?
   end
 
   def get_enlistment
# frozen_string_literal: true

module EnlistmentFilters
  extend ActiveSupport::Concern

  included do
    before_action :session_required, :redirect_unverified_account, only: %i[create new destroy edit update]
    before_action :set_project_or_fail
    before_action :set_project_editor_account_to_current_user
    before_action :check_project_authorization, except: %i[index show]
    before_action :find_enlistment, only: %i[show edit update destroy]
    before_action :project_context, only: %i[index new edit create update]
    before_action :validate_project, only: %i[edit update destroy]
    before_action :sidekiq_job_exists, only: :create
    before_action :handle_github_user_flow, only: :create
    before_action :build_code_location, only: :create
    before_action :project_has_code_location?, only: :create
  end

  private

  def enlistment_params
    params.require(:enlistment).permit(:ignore)
  end

  def parse_sort_term
    Enlistment.respond_to?("by_#{params[:sort]}") ? "by_#{params[:sort]}" : 'by_url'
  end

  def find_enlistment
    @enlistment = Enlistment.find_by(id: params[:id])
    raise ParamRecordNotFound unless @enlistment

    @enlistment.editor_account = current_user
  end

  def sidekiq_job_exists
    key = Setting.get_project_enlistment_key(@project.id)
    job = Setting.get_value(key)
    return unless job.present? && job.key?(code_location_params[:url])

    redirect_to project_enlistments_path(@project), flash: { error: t('.job_exists') }
  end

  def handle_github_user_flow
    return unless code_location_params[:scm_type] == 'GithubUser'

    github_user = GithubUser.new(url: code_location_params[:url])
    @code_location = CodeLocation.new(url: code_location_params[:url])
    return create_worker if github_user.valid?

    @code_location.errors = github_user.errors
    render :new, status: :unprocessable_entity
  end

  def create_worker
    worker = EnlistmentWorker.perform_async(@code_location.url, current_user.id, @project.id)
    Setting.update_worker(@project.id, worker, @code_location.url)
    flash[:notice] = t('.github_repos_added', username: @code_location.url)
    redirect_to project_enlistments_path(@project)
  end

  def validate_project
    return if @project.valid?

    error_msg = @project.errors.include?(:description) ? add_custom_error_msg : @project.errors.full_messages
    flash[:error] = error_msg.join(', ')
    redirect_to project_enlistments_path
  end

  def add_custom_error_msg
    project_errors = @project.errors
    project_errors.delete(:description)
    project_errors.full_messages.unshift(custom_description_error)
  end

  def build_code_location
    @code_location = CodeLocation.new(code_location_params.merge(client_relation_id: @project.id))
  end

  def project_has_code_location?
    return unless CodeLocationSubscription.code_location_exists?(@project.id, @code_location.url,
                                                                 @code_location.branch, code_location_params[:scm_type])

    manage_deleted_enlistment
    redirect_to project_enlistments_path(@project)
  end

  def manage_deleted_enlistment
    if enlistment_deleted?
      restore_deleted_enlistment
    else
      flash[:notice] = t('.notice', url: @code_location.url, module_branch_name: @code_location.branch)
    end
  end

  def enlistment_deleted?
    enlistment = get_enlistment
    enlistment.try(:deleted?) ? true : false
  end

  def get_code_location_id
    response = CodeLocationApi.new(url: @code_location.url, branch: @code_location.branch).fetch
    JSON.parse(response).first['id'] unless response.nil?
  end

  def get_enlistment
    Enlistment.where(project_id: @project.id, code_location_id: get_code_location_id).first
  end

  def restore_deleted_enlistment
    CreateEdit.find_by(target: get_enlistment).redo!(current_user)
    flash[:success] = 'Deleted CodeLocation has been successfully restored.'
  end
end

This looks pretty important; like the eFISbot Code Location API changed its return type from an array to a single instance. Is that correct? If so, when did we change the Code Location API and is it having an impact on the KB Discovery code? If there is a chance that this end point will return an array, then we should convert all responses to an array so they are treated the same: `Array(response)` has no effect if `response` is already an array and so is safe when `CodeLocationApi` returns an array.