@@ -205,7 +205,6 @@ public class EthSchedulerTest {
     result.cancel(false);
     assertThat(task.isDone()).isTrue();
     assertThat(task.isFailed()).isTrue();
-    assertThat(task.isSucceeded()).isFalse();
     assertThat(task.isCancelled()).isTrue();
   }
 }
/*
 * Copyright ConsenSys AG.
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
 * the License. You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
 * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
 * specific language governing permissions and limitations under the License.
 *
 * SPDX-License-Identifier: Apache-2.0
 */
package org.hyperledger.besu.ethereum.eth.manager;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.anyBoolean;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;

import org.hyperledger.besu.testutil.MockExecutorService;

import java.time.Duration;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Future;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicBoolean;

import org.junit.Before;
import org.junit.Test;

public class EthSchedulerTest {

  private DeterministicEthScheduler ethScheduler;
  private MockExecutorService syncWorkerExecutor;
  private MockScheduledExecutor scheduledExecutor;
  private AtomicBoolean shouldTimeout;

  @Before
  public void setup() {
    shouldTimeout = new AtomicBoolean(false);
    ethScheduler = new DeterministicEthScheduler(shouldTimeout::get);
    syncWorkerExecutor = ethScheduler.mockSyncWorkerExecutor();
    scheduledExecutor = ethScheduler.mockScheduledExecutor();
  }

  @Test
  public void scheduleWorkerTask_completesWhenScheduledTaskCompletes() {
    final CompletableFuture<Object> future = new CompletableFuture<>();
    final CompletableFuture<Object> result = ethScheduler.scheduleSyncWorkerTask(() -> future);

    assertThat(result.isDone()).isFalse();
    future.complete("bla");
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isFalse();
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void scheduleWorkerTask_completesWhenScheduledTaskFails() {
    final CompletableFuture<Object> future = new CompletableFuture<>();
    final CompletableFuture<Object> result = ethScheduler.scheduleSyncWorkerTask(() -> future);

    assertThat(result.isDone()).isFalse();
    future.completeExceptionally(new RuntimeException("whoops"));
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isTrue();
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void scheduleWorkerTask_completesWhenScheduledTaskIsCancelled() {
    final CompletableFuture<Object> future = new CompletableFuture<>();
    final CompletableFuture<Object> result = ethScheduler.scheduleSyncWorkerTask(() -> future);

    assertThat(result.isDone()).isFalse();
    future.cancel(false);
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isTrue();
    assertThat(result.isCancelled()).isTrue();
  }

  @Test
  public void scheduleWorkerTask_cancelsScheduledFutureWhenResultIsCancelled() {
    final CompletableFuture<Object> result =
        ethScheduler.scheduleSyncWorkerTask(() -> new CompletableFuture<>());

    assertThat(syncWorkerExecutor.getFutures().size()).isEqualTo(1);
    final Future<?> future = syncWorkerExecutor.getFutures().get(0);

    verify(future, times(0)).cancel(anyBoolean());
    result.cancel(true);
    verify(future, times(1)).cancel(eq(false));
  }

  @Test
  public void scheduleFutureTask_completesWhenScheduledTaskCompletes() {
    final CompletableFuture<Object> future = new CompletableFuture<>();
    final CompletableFuture<Object> result =
        ethScheduler.scheduleFutureTask(() -> future, Duration.ofMillis(100));

    assertThat(result.isDone()).isFalse();
    future.complete("bla");
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isFalse();
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void scheduleFutureTask_completesWhenScheduledTaskFails() {
    final CompletableFuture<Object> future = new CompletableFuture<>();
    final CompletableFuture<Object> result =
        ethScheduler.scheduleFutureTask(() -> future, Duration.ofMillis(100));

    assertThat(result.isDone()).isFalse();
    future.completeExceptionally(new RuntimeException("whoops"));
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isTrue();
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void scheduleFutureTask_completesWhenScheduledTaskIsCancelled() {
    final CompletableFuture<Object> future = new CompletableFuture<>();
    final CompletableFuture<Object> result =
        ethScheduler.scheduleFutureTask(() -> future, Duration.ofMillis(100));

    assertThat(result.isDone()).isFalse();
    future.cancel(false);
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isTrue();
    assertThat(result.isCancelled()).isTrue();
  }

  @Test
  public void scheduleFutureTask_cancelsScheduledFutureWhenResultIsCancelled() {
    final CompletableFuture<Object> result =
        ethScheduler.scheduleFutureTask(() -> new CompletableFuture<>(), Duration.ofMillis(100));

    assertThat(scheduledExecutor.getFutures().size()).isEqualTo(1);
    final Future<?> future = scheduledExecutor.getFutures().get(0);

    verify(future, times(0)).cancel(anyBoolean());
    result.cancel(true);
    verify(future, times(1)).cancel(eq(false));
  }

  @Test
  public void timeout_resultCompletesWhenScheduledTaskCompletes() {
    final MockEthTask task = new MockEthTask();
    final CompletableFuture<Object> result = ethScheduler.timeout(task, Duration.ofSeconds(2));

    assertThat(task.hasBeenStarted()).isTrue();
    assertThat(task.isDone()).isFalse();
    assertThat(result.isDone()).isFalse();

    task.complete();
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isFalse();
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void timeout_resultCompletesWhenScheduledTaskFails() {
    final MockEthTask task = new MockEthTask();
    final CompletableFuture<Object> result = ethScheduler.timeout(task, Duration.ofSeconds(2));

    assertThat(task.hasBeenStarted()).isTrue();
    assertThat(task.isDone()).isFalse();
    assertThat(result.isDone()).isFalse();

    task.fail();
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isTrue();
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void timeout_resultCompletesOnTimeout() {
    shouldTimeout.set(true);
    final MockEthTask task = new MockEthTask();
    final CompletableFuture<Object> result = ethScheduler.timeout(task, Duration.ofSeconds(2));

    // Timeout fires immediately, so everything should be done
    assertThat(task.hasBeenStarted()).isTrue();
    assertThat(task.isDone()).isTrue();
    assertThat(result.isDone()).isTrue();
    assertThat(result.isCompletedExceptionally()).isTrue();
    assertThatThrownBy(result::get).hasCauseInstanceOf(TimeoutException.class);
    assertThat(result.isCancelled()).isFalse();
  }

  @Test
  public void timeout_cancelsTaskWhenResultIsCancelled() {
    final MockEthTask task = new MockEthTask();
    final CompletableFuture<Object> result = ethScheduler.timeout(task, Duration.ofSeconds(2));

    assertThat(task.hasBeenStarted()).isTrue();
    assertThat(task.isDone()).isFalse();
    assertThat(result.isDone()).isFalse();

    result.cancel(false);
    assertThat(task.isDone()).isTrue();
    assertThat(task.isFailed()).isTrue();
    assertThat(task.isSucceeded()).isFalse();
    assertThat(task.isCancelled()).isTrue();
  }
}

I'm not sure why we should remove isSucceeded but we should keep isFailed. maybe I missed something