issue_id
int64 2.03k
426k
| title
stringlengths 9
251
| body
stringlengths 1
32.8k
⌀ | status
stringclasses 6
values | after_fix_sha
stringlengths 7
7
| updated_files
stringlengths 29
34.1k
| project_name
stringclasses 6
values | repo_url
stringclasses 6
values | repo_name
stringclasses 6
values | language
stringclasses 1
value | issue_url
null | before_fix_sha
null | pull_url
null | commit_datetime
unknown | report_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
48,267 | Bug 48267 Patch to fix generics in javax packages | null | resolved fixed | 632e68c | ["java/javax/annotation/Resource.java", "java/javax/ejb/EJB.java", "java/javax/el/BeanELResolver.java", "java/javax/el/ELContext.java", "java/javax/el/ListELResolver.java", "java/javax/el/MapELResolver.java", "java/javax/el/ResourceBundleELResolver.java", "java/javax/xml/ws/WebServiceRef.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-27T17:14:16Z" | "2009-11-23T18:13:20Z" |
48,266 | Bug 48266 Patch to fix generics in catalina | null | resolved fixed | 21cd308 | ["java/org/apache/catalina/ant/jmx/JMXAccessorTask.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/core/StandardPart.java", "java/org/apache/catalina/ha/backend/CollectedInfo.java", "java/org/apache/catalina/ha/session/BackupManager.java", "java/org/apache/catalina/ha/tcp/ReplicationValve.java", "java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java", "java/org/apache/catalina/tribes/transport/bio/MultipointBioSender.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-25T01:00:07Z" | "2009-11-23T18:13:20Z" |
47,836 | Bug 47836 TldConfig keeps an internal list of ApplicationListeners | null | resolved fixed | 92e53f3 | ["java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/startup/TldConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-24T01:27:40Z" | "2009-09-14T12:06:40Z" |
48,239 | Bug 48239 HexUtils exposes public array | null | resolved fixed | 55e5052 | ["java/org/apache/coyote/ajp/AjpAprProcessor.java", "java/org/apache/coyote/ajp/AjpProcessor.java", "java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java", "java/org/apache/coyote/http11/Http11Processor.java", "java/org/apache/coyote/http11/filters/ChunkedInputFilter.java", "java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java", "java/org/apache/tomcat/util/buf/HexUtils.java", "java/org/apache/tomcat/util/buf/MessageBytes.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-23T00:36:10Z" | "2009-11-19T11:26:40Z" |
48,248 | Bug 48248 tribes.group.interceptors.MessageDispatchInterceptor.run should be volatile | org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run should be volatile, as it is used to communicate between running threads. | resolved fixed | a524187 | ["java/org/apache/catalina/tribes/group/GroupChannel.java", "java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java", "java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java", "java/org/apache/catalina/tribes/membership/McastServiceImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-23T00:31:43Z" | "2009-11-20T09:40:00Z" |
48,249 | Bug 48249 org.apache.tomcat.util.net.NioBlockingSelector.BlockPoller.run <= volatile | org.apache.tomcat.util.net.NioBlockingSelector.BlockPoller.run should be volatile, as it is used to communicate between running threads. | resolved fixed | c7d7ba2 | ["java/org/apache/tomcat/util/net/NioBlockingSelector.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-23T00:28:03Z" | "2009-11-20T09:40:00Z" |
48,049 | Bug 48049 org.apache.naming.NamingContext's destroySubcontext() method doesn't invoke itself recursively, but invoke unbind() method | Below is the original implementation of destroySubcontext(Name name) method: public void destroySubcontext(Name name) throws NamingException { checkWritable(); while ((!name.isEmpty()) && (name.get(0).length() == 0)) name = name.getSuffix(1); if (name.isEmpty()) throw new NamingException (sm.getString("namingContext.invalidName")); NamingEntry entry = (NamingEntry) bindings.get(name.get(0)); if (entry == null) { throw new NameNotFoundException (sm.getString("namingContext.nameNotBound", name.get(0))); } if (name.size() > 1) { if (entry.type == NamingEntry.CONTEXT) { ((Context) entry.value).unbind(name.getSuffix(1)); } else { throw new NamingException (sm.getString("namingContext.contextExpected")); } } else { if (entry.type == NamingEntry.CONTEXT) { ((Context) entry.value).close(); bindings.remove(name.get(0)); } else { throw new NotContextException (sm.getString("namingContext.contextExpected")); } } } However, the method invokes 'unbind' method rather than invokes itself recursively. if (name.size() > 1) { if (entry.type == NamingEntry.CONTEXT) { ((Context) entry.value).unbind(name.getSuffix(1)); } else { throw new NamingException (sm.getString("namingContext.contextExpected")); } should be: if (name.size() > 1) { if (entry.type == NamingEntry.CONTEXT) { ((Context) entry.value).destroySubcontext(name.getSuffix(1)); } else { throw new NamingException (sm.getString("namingContext.contextExpected")); } | resolved fixed | af8a612 | ["java/org/apache/naming/NamingContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-22T22:56:53Z" | "2009-10-25T11:26:40Z" |
47,799 | Bug 47799 Domain does not work in Membership and DomainFilterInterceptor. | null | resolved fixed | 94c643b | ["java/org/apache/catalina/tribes/group/interceptors/DomainFilterInterceptor.java", "java/org/apache/catalina/tribes/membership/McastService.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-22T22:37:43Z" | "2009-09-08T06:06:40Z" |
47,462 | Bug 47462 The annotation doesn't become effective.(metadata-complete="false" is not effective.) | null | resolved fixed | 04b0838 | ["java/org/apache/catalina/startup/WebRuleSet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-22T20:49:04Z" | "2009-07-01T06:33:20Z" |
47,997 | Bug 47997 NamingContextListener fails to add itself as a PropertyChangeListener to all namingResources | null | resolved fixed | 58162ed | ["java/org/apache/catalina/core/NamingContextListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-22T19:59:51Z" | "2009-10-14T22:40:00Z" |
47,718 | Bug 47718 ManagerBase leaks fd to /dev/urandom when context stopped | On operating systems where /dev/urandom exists, org.apache.catalina.session.ManagerBase will use it as a source of data for getRandomBytes(). If you stop a context or undeploy a host, the number of file descriptors that have /dev/urandom open tomcat remains constant. For example, if you use the manager application to stop or undeploy a context, the number of file descriptors to /dev/urandom is the same as before the stop. File descriptor use is determined by using lsof or examining the /proc/<pid>/fd directory on Linux. The same issue is seen if you undeploy a virtual host. If you undeploy/deploy a context, or remove/add a virtual host, the # of file descriptors to /dev/urandom will increase each time. This is because ManagerBase does not close the DataInputStream it holds to /dev/urandom. The patch shown below resolves this issue. Stopping a context, or undeploying a virtual host will close the session manager's reference to /dev/urandom. --- apache-tomcat-5.5.28-src/container/catalina/src/share/org/apache/catalina/session/ManagerBase.java 2009-07-24 13:35:00.000000000 -0600 +++ apache-tomcat-5.5.28-gls/container/catalina/src/share/org/apache/catalina/session/ManagerBase.java 2009-08-20 13:38:03.000000000 -0600 @@ -688,10 +688,17 @@ } public void destroy() { if( oname != null ) Registry.getRegistry(null, null).unregisterComponent(oname); + if (randomIS!=null) { + try { + randomIS.close(); + } catch (IOException ioe) { + } + randomIS=null; + } initialized=false; oname = null; // Don't clear log since it is required in case attributes are changed // (eg via JMX) whilst the manager is stopped. } | resolved fixed | ae5c640 | ["java/org/apache/catalina/session/ManagerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-22T19:39:33Z" | "2009-08-20T17:40:00Z" |
48,252 | Bug 48252 StackOverflowError in NioEndpoint.setProperty when setting jkHome | - Noticed only when running in debugger with breakpoint set for StackOverflowError. - The error is translated by Java's reflection mechanism to an InvocationTargetException, which is caught and silently ignored by IntrospectionUtils. - Connector.initialize() sets jkHome property on Http11NioProtocol. - Http11NioProtocol sets jkHome property on NioEndpoint. - NioEndpoint recursively invokes its own setProperty method via IntrospectionUtils.setProperty, causing the stack overflow. - Using embedded Tomcat. - Using Nio connector. Does not happen for standard connector. - Happens in 6.0.18 and 6.0.20; haven't tested with earlier versions. | resolved fixed | c0cb61b | ["java/org/apache/tomcat/util/IntrospectionUtils.java", "java/org/apache/tomcat/util/net/AbstractEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-20T16:57:31Z" | "2009-11-20T12:26:40Z" |
48,234 | Bug 48234 org.apache.catalina.core.ContainerBase.getLogger() not thread-safe? | org.apache.catalina.core.ContainerBase.getLogger() is not synchronised, yet all the other methods which access org.apache.catalina.core.ContainerBase.logger are synch. This seems wrong. org.apache.catalina.core.ContainerBase.logger should probably be private to prevent unsynch. access by subclasses. Similar considerations apply to logName and logName() The Javadoc for getLogger() states that it can return null - that does not appear to be possible. [Not sure if the method ever returns the parent logger either.] | resolved fixed | c53173b | ["java/org/apache/catalina/core/ContainerBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-19T02:01:57Z" | "2009-11-18T21:33:20Z" |
48,172 | Bug 48172 JspRuntimeContext synch. problems. | JspRuntimeContext.jspReloadCount is synchronised when updated, but not when read by getJspReloadCount(). If the instance is accessed from multiple threads, then the returned value may not be the current value, it could be arbitrarily stale. If this is acceptable, then the Javadoc should say so; otherwise the getter needs to be synch. (or the field needs to be volatile) Or just use AtomicInteger. == Various other fields are neither final nor synchronized, e.g. classpath codeSource etc. As far as I can tell, these could easily be made final as they are only written by the constructor. | resolved fixed | 242b6a3 | ["java/org/apache/jasper/compiler/JspRuntimeContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-18T23:33:57Z" | "2009-11-11T09:00:00Z" |
48,197 | Bug 48197 XByteBuffer: privatize public fields; fix Javadoc | null | resolved fixed | a1cb0c3 | ["java/org/apache/catalina/tribes/io/XByteBuffer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-18T23:22:13Z" | "2009-11-14T12:00:00Z" |
48,230 | Bug 48230 Unused imports | null | resolved fixed | 84d49a0 | ["java/org/apache/catalina/Authenticator.java", "java/org/apache/catalina/authenticator/FormAuthenticator.java", "java/org/apache/tomcat/util/net/NioEndpoint.java", "modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestSuspectTimeout.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-18T23:10:53Z" | "2009-11-18T18:46:40Z" |
48,217 | Bug 48217 Loggers should be final | null | resolved fixed | 0d7263a | ["java/org/apache/coyote/http11/AbstractHttp11Protocol.java", "java/org/apache/coyote/http11/Http11NioProtocol.java", "java/org/apache/coyote/http11/Http11Protocol.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-18T12:10:12Z" | "2009-11-17T20:33:20Z" |
48,196 | Bug 48196 Public arrays that should be private | null | resolved fixed | 38f52b5 | ["java/org/apache/catalina/startup/Tomcat.java", "java/org/apache/catalina/tribes/group/interceptors/TwoPhaseCommitInterceptor.java", "java/org/apache/catalina/util/HexUtils.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T23:03:43Z" | "2009-11-14T12:00:00Z" |
48,176 | Bug 48176 Fields that should be final | null | resolved fixed | 16c4534 | ["java/org/apache/catalina/tribes/io/BufferPool.java", "java/org/apache/jasper/compiler/ServletWriter.java", "modules/tomcat-lite/java/org/apache/tomcat/util/http/MimeMap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T23:00:31Z" | "2009-11-11T11:46:40Z" |
48,175 | Bug 48175 Loggers should be final | null | resolved fixed | 799b934 | ["java/org/apache/catalina/core/ApplicationFilterConfig.java", "java/org/apache/catalina/core/ContainerBase.java", "java/org/apache/catalina/core/StandardHost.java", "java/org/apache/catalina/core/StandardWrapper.java", "java/org/apache/catalina/ha/ClusterListener.java", "java/org/apache/catalina/ha/context/ReplicatedContext.java", "java/org/apache/catalina/ha/deploy/FarmWarDeployer.java", "java/org/apache/catalina/ha/deploy/FileMessageFactory.java", "java/org/apache/catalina/ha/deploy/WarWatcher.java", "java/org/apache/catalina/ha/session/BackupManager.java", "java/org/apache/catalina/ha/session/DeltaManager.java", "java/org/apache/catalina/ha/session/DeltaRequest.java", "java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/ha/session/JvmRouteBinderValve.java", "java/org/apache/catalina/ha/session/SerializablePrincipal.java", "java/org/apache/catalina/ha/session/SimpleTcpReplicationManager.java", "java/org/apache/catalina/ha/tcp/ReplicationValve.java", "java/org/apache/catalina/loader/WebappClassLoader.java", "java/org/apache/catalina/loader/WebappLoader.java", "java/org/apache/catalina/mbeans/MBeanFactory.java", "java/org/apache/catalina/security/SecurityConfig.java", "java/org/apache/catalina/security/SecurityUtil.java", "java/org/apache/catalina/startup/Catalina.java", "java/org/apache/catalina/startup/CatalinaProperties.java", "java/org/apache/catalina/startup/ContextConfig.java", "java/org/apache/catalina/startup/DefaultJarScanner.java", "java/org/apache/catalina/startup/DigesterFactory.java", "java/org/apache/catalina/startup/EngineConfig.java", "java/org/apache/catalina/startup/HostConfig.java", "java/org/apache/catalina/startup/TldConfig.java", "java/org/apache/catalina/startup/UserConfig.java", "java/org/apache/catalina/startup/WebXml.java", "java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java", "java/org/apache/catalina/tribes/group/GroupChannel.java", "java/org/apache/catalina/tribes/group/RpcChannel.java", "java/org/apache/catalina/tribes/group/interceptors/FragmentationInterceptor.java", "java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java", "java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java", "java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java", "java/org/apache/catalina/tribes/group/interceptors/ThroughputInterceptor.java", "java/org/apache/catalina/tribes/group/interceptors/TwoPhaseCommitInterceptor.java", "java/org/apache/catalina/tribes/io/ObjectReader.java", "java/org/apache/catalina/tribes/io/XByteBuffer.java", "java/org/apache/catalina/tribes/membership/McastService.java", "java/org/apache/catalina/tribes/membership/McastServiceImpl.java", "java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java", "java/org/apache/catalina/tribes/tipis/ReplicatedMap.java", "java/org/apache/catalina/tribes/transport/bio/BioReceiver.java", "java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java", "java/org/apache/catalina/tribes/transport/bio/BioSender.java", "java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java", "java/org/apache/catalina/tribes/transport/nio/NioReceiver.java", "java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java", "java/org/apache/catalina/tribes/transport/nio/NioSender.java", "java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java", "java/org/apache/catalina/tribes/util/Logs.java", "java/org/apache/catalina/util/ExtensionValidator.java", "java/org/apache/coyote/ajp/AjpAprProcessor.java", "java/org/apache/coyote/ajp/AjpAprProtocol.java", "java/org/apache/coyote/ajp/AjpMessage.java", "java/org/apache/coyote/ajp/AjpProcessor.java", "java/org/apache/coyote/ajp/AjpProtocol.java", "java/org/apache/coyote/http11/AbstractHttp11Processor.java", "java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11AprProtocol.java", "java/org/apache/coyote/http11/Http11NioProtocol.java", "java/org/apache/coyote/http11/Http11Protocol.java", "java/org/apache/jasper/JspCompilationContext.java", "java/org/apache/jasper/compiler/SmapUtil.java", "java/org/apache/jasper/security/SecurityClassLoad.java", "java/org/apache/jasper/xmlparser/UCSReader.java", "java/org/apache/jasper/xmlparser/UTF8Reader.java", "java/org/apache/naming/NamingContext.java", "java/org/apache/naming/SelectorContext.java", "java/org/apache/naming/resources/FileDirContext.java", "java/org/apache/naming/resources/WARDirContext.java", "java/org/apache/tomcat/util/DomUtil.java", "java/org/apache/tomcat/util/IntrospectionUtils.java", "java/org/apache/tomcat/util/buf/B2CConverter.java", "java/org/apache/tomcat/util/buf/C2BConverter.java", "java/org/apache/tomcat/util/buf/StringCache.java", "java/org/apache/tomcat/util/buf/UEncoder.java", "java/org/apache/tomcat/util/http/Cookies.java", "java/org/apache/tomcat/util/http/Parameters.java", "java/org/apache/tomcat/util/http/mapper/Mapper.java", "java/org/apache/tomcat/util/net/SSLImplementation.java", "java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java", "java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java", "java/org/apache/tomcat/util/net/jsse/JSSESupport.java", "modules/tomcat-lite/java/org/apache/tomcat/util/http/mapper/BaseMapper.java", "test/org/apache/catalina/tribes/demos/IntrospectionUtils.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:59:34Z" | "2009-11-11T11:46:40Z" |
48,174 | Bug 48174 org.apache.tomcat.jni.Address.APR_ANYADDR should be final | org.apache.tomcat.jni.Address.APR_ANYADDR should be final | resolved fixed | 57571a7 | ["java/org/apache/tomcat/jni/Address.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:47:39Z" | "2009-11-11T11:46:40Z" |
48,173 | Bug 48173 org.apache.catalina.tribes.io.ChannelData.EMPTY_DATA_ARRAY should be final | org.apache.catalina.tribes.io.ChannelData.EMPTY_DATA_ARRAY should be final | resolved fixed | e5ae1bc | ["java/org/apache/catalina/tribes/io/ChannelData.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:46:41Z" | "2009-11-11T11:46:40Z" |
48,151 | Bug 48151 Java files that don't have AL headers | null | resolved fixed | 5447621 | ["java/org/apache/catalina/startup/DefaultJarScanner.java", "java/org/apache/tomcat/JarScannerCallback.java", "modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java", "modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestException.java", "modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/driver/ResultSet.java", "modules/tomcat-lite/examples/spring/TomcatSpring.java", "modules/tomcat-lite/java/org/apache/tomcat/addons/Filesystem.java", "modules/tomcat-lite/java/org/apache/tomcat/addons/UserAuthentication.java", "modules/tomcat-lite/java/org/apache/tomcat/addons/UserSessionManager.java", "modules/tomcat-lite/java/org/apache/tomcat/addons/UserTemplateClassMapper.java", "modules/tomcat-lite/java/org/apache/tomcat/integration/ObjectManager.java", "modules/tomcat-lite/java/org/apache/tomcat/integration/jmx/JmxObjectManagerSpi.java", "modules/tomcat-lite/java/org/apache/tomcat/integration/simple/LocalFilesystem.java", "modules/tomcat-lite/java/org/apache/tomcat/integration/simple/Main.java", "modules/tomcat-lite/java/org/apache/tomcat/integration/simple/ServletHelper.java", "modules/tomcat-lite/java/org/apache/tomcat/integration/simple/SimpleObjectManager.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/BodyWriter.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/Connector.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/ContextPreinitListener.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/WebappContextMapper.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/coyote/CoyoteConnector.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/webxml/ServletContextConfig.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/webxml/TomcatLiteWebXmlConfig.java", "modules/tomcat-lite/java/org/apache/tomcat/lite/webxml/WebXml.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/file/CopyUtils.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/file/FileCopyUtils.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/jsp/PreCompileFilter.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/jsp/SingleThreadedProxyServlet.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/sec/UserDB.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/session/RandomGenerator.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/util/Range.java", "modules/tomcat-lite/java/org/apache/tomcat/servlets/util/UrlUtils.java", "modules/tomcat-lite/java/org/apache/tomcat/util/http/HttpRequest.java", "modules/tomcat-lite/java/org/apache/tomcat/util/http/HttpResponse.java", "modules/tomcat-lite/test/org/apache/tomcat/lite/LiteTestHelper.java", "modules/tomcat-lite/test/org/apache/tomcat/lite/PropertiesSpiTest.java", "modules/tomcat-lite/test/org/apache/tomcat/lite/SimpleServlet.java", "modules/tomcat-lite/test/org/apache/tomcat/test/watchdog/WatchdogTest.java", "modules/tomcat-lite/test/org/apache/tomcat/util/buf/UEncoderTest.java", "test/org/apache/TestAll.java", "test/org/apache/catalina/startup/SimpleHttpClient.java", "test/org/apache/catalina/startup/TestWebXml.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:44:58Z" | "2009-11-06T06:46:40Z" |
48,150 | Bug 48150 some misspellings I found in the "javax.servlet" package | null | resolved fixed | 7849435 | ["java/javax/servlet/GenericServlet.java", "java/javax/servlet/http/HttpServlet.java", "java/javax/servlet/jsp/JspWriter.java", "java/javax/servlet/jsp/PageContext.java", "java/javax/servlet/jsp/SkipPageException.java", "java/javax/servlet/jsp/tagext/JspFragment.java", "java/javax/servlet/jsp/tagext/PageData.java", "java/javax/servlet/jsp/tagext/SimpleTagSupport.java", "java/javax/servlet/jsp/tagext/TagLibraryInfo.java", "java/javax/servlet/jsp/tagext/TagLibraryValidator.java", "java/javax/servlet/jsp/tagext/TagSupport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:35:41Z" | "2009-11-06T06:46:40Z" |
48,149 | Bug 48149 some misspellings I found in the "org.apache.coyote" package and "org.apache.el" package | null | resolved fixed | 39a78f4 | ["java/org/apache/coyote/ActionCode.java", "java/org/apache/coyote/ProtocolHandler.java", "java/org/apache/coyote/Request.java", "java/org/apache/coyote/RequestGroupInfo.java", "java/org/apache/coyote/RequestInfo.java", "java/org/apache/coyote/Response.java", "java/org/apache/coyote/ajp/AjpAprProcessor.java", "java/org/apache/coyote/ajp/AjpAprProtocol.java", "java/org/apache/coyote/ajp/AjpProcessor.java", "java/org/apache/coyote/ajp/AjpProtocol.java", "java/org/apache/coyote/http11/AbstractHttp11Processor.java", "java/org/apache/coyote/http11/AbstractInputBuffer.java", "java/org/apache/coyote/http11/AbstractOutputBuffer.java", "java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java", "java/org/apache/coyote/http11/Http11Processor.java", "java/org/apache/coyote/http11/InternalAprInputBuffer.java", "java/org/apache/coyote/http11/InternalAprOutputBuffer.java", "java/org/apache/coyote/http11/InternalInputBuffer.java", "java/org/apache/coyote/http11/InternalNioInputBuffer.java", "java/org/apache/coyote/http11/InternalNioOutputBuffer.java", "java/org/apache/coyote/http11/InternalOutputBuffer.java", "java/org/apache/coyote/http11/filters/VoidInputFilter.java", "java/org/apache/el/parser/AstValue.java", "java/org/apache/el/parser/ParseException.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:33:58Z" | "2009-11-06T06:46:40Z" |
48,148 | Bug 48148 some misspellings I found in the "org.apache.jasper" package and "org.apache.juli" package | null | resolved fixed | 6ce7032 | ["java/org/apache/jasper/Constants.java", "java/org/apache/jasper/EmbeddedServletOptions.java", "java/org/apache/jasper/JasperException.java", "java/org/apache/jasper/JspC.java", "java/org/apache/jasper/JspCompilationContext.java", "java/org/apache/jasper/Options.java", "java/org/apache/jasper/compiler/Collector.java", "java/org/apache/jasper/compiler/Compiler.java", "java/org/apache/jasper/compiler/ELFunctionMapper.java", "java/org/apache/jasper/compiler/Generator.java", "java/org/apache/jasper/compiler/JarScannerFactory.java", "java/org/apache/jasper/compiler/JspConfig.java", "java/org/apache/jasper/compiler/JspDocumentParser.java", "java/org/apache/jasper/compiler/JspReader.java", "java/org/apache/jasper/compiler/JspRuntimeContext.java", "java/org/apache/jasper/compiler/JspUtil.java", "java/org/apache/jasper/compiler/Node.java", "java/org/apache/jasper/compiler/TagFileProcessor.java", "java/org/apache/jasper/compiler/TagLibraryInfoImpl.java", "java/org/apache/jasper/compiler/TextOptimizer.java", "java/org/apache/jasper/compiler/TldLocationsCache.java", "java/org/apache/jasper/compiler/Validator.java", "java/org/apache/jasper/compiler/tagplugin/TagPluginContext.java", "java/org/apache/jasper/runtime/BodyContentImpl.java", "java/org/apache/jasper/runtime/JspContextWrapper.java", "java/org/apache/jasper/servlet/JspServlet.java", "java/org/apache/jasper/servlet/JspServletWrapper.java", "java/org/apache/jasper/tagplugins/jstl/core/Import.java", "java/org/apache/jasper/util/Enumerator.java", "java/org/apache/jasper/xmlparser/UTF8Reader.java", "java/org/apache/jasper/xmlparser/XMLEncodingDetector.java", "java/org/apache/juli/ClassLoaderLogManager.java", "java/org/apache/juli/OneLineFormatter.java", "java/org/apache/juli/logging/DirectJDKLog.java", "java/org/apache/juli/logging/Log.java", "java/org/apache/juli/logging/LogFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:31:47Z" | "2009-11-06T06:46:40Z" |
48,147 | Bug 48147 some misspellings I can find in the "org.apache.naming" package | null | resolved fixed | 21e86e6 | ["java/org/apache/naming/NamingEntry.java", "java/org/apache/naming/NamingService.java", "java/org/apache/naming/NamingServiceMBean.java", "java/org/apache/naming/ResourceRef.java", "java/org/apache/naming/factory/EjbFactory.java", "java/org/apache/naming/factory/OpenEjbFactory.java", "java/org/apache/naming/factory/ResourceEnvFactory.java", "java/org/apache/naming/factory/TransactionFactory.java", "java/org/apache/naming/resources/BaseDirContext.java", "java/org/apache/naming/resources/DirContextURLConnection.java", "java/org/apache/naming/resources/FileDirContext.java", "java/org/apache/naming/resources/ProxyDirContext.java", "java/org/apache/naming/resources/Resource.java", "java/org/apache/naming/resources/ResourceCache.java", "java/org/apache/naming/resources/WARDirContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:27:58Z" | "2009-11-06T04:00:00Z" |
48,146 | Bug 48146 some misspellings I can find in the "org.apache.tomcat" package | null | resolved fixed | ed97da7 | ["java/org/apache/tomcat/jni/BIOCallback.java", "java/org/apache/tomcat/jni/Directory.java", "java/org/apache/tomcat/jni/File.java", "java/org/apache/tomcat/jni/Local.java", "java/org/apache/tomcat/jni/OS.java", "java/org/apache/tomcat/jni/Poll.java", "java/org/apache/tomcat/jni/Pool.java", "java/org/apache/tomcat/jni/Proc.java", "java/org/apache/tomcat/jni/SSL.java", "java/org/apache/tomcat/jni/SSLContext.java", "java/org/apache/tomcat/jni/Shm.java", "java/org/apache/tomcat/jni/Socket.java", "java/org/apache/tomcat/jni/Time.java", "java/org/apache/tomcat/jni/User.java", "java/org/apache/tomcat/util/DomUtil.java", "java/org/apache/tomcat/util/IntrospectionUtils.java", "java/org/apache/tomcat/util/buf/B2CConverter.java", "java/org/apache/tomcat/util/buf/ByteChunk.java", "java/org/apache/tomcat/util/buf/C2BConverter.java", "java/org/apache/tomcat/util/buf/CharChunk.java", "java/org/apache/tomcat/util/buf/MessageBytes.java", "java/org/apache/tomcat/util/buf/StringCache.java", "java/org/apache/tomcat/util/buf/UDecoder.java", "java/org/apache/tomcat/util/buf/UEncoder.java", "java/org/apache/tomcat/util/collections/MultiMap.java", "java/org/apache/tomcat/util/collections/MultiMapNamesEnumeration.java", "java/org/apache/tomcat/util/digester/AbstractRulesImpl.java", "java/org/apache/tomcat/util/digester/CallMethodRule.java", "java/org/apache/tomcat/util/digester/Digester.java", "java/org/apache/tomcat/util/digester/FactoryCreateRule.java", "java/org/apache/tomcat/util/digester/GenericParser.java", "java/org/apache/tomcat/util/digester/NodeCreateRule.java", "java/org/apache/tomcat/util/digester/RuleSet.java", "java/org/apache/tomcat/util/digester/RulesBase.java", "java/org/apache/tomcat/util/digester/SetNextRule.java", "java/org/apache/tomcat/util/digester/SetPropertiesRule.java", "java/org/apache/tomcat/util/digester/SetPropertyRule.java", "java/org/apache/tomcat/util/digester/SetRootRule.java", "java/org/apache/tomcat/util/digester/SetTopRule.java", "java/org/apache/tomcat/util/digester/WithDefaultsRulesWrapper.java", "java/org/apache/tomcat/util/http/ContentType.java", "java/org/apache/tomcat/util/http/Cookies.java", "java/org/apache/tomcat/util/http/MimeHeaders.java", "java/org/apache/tomcat/util/http/fileupload/FileItem.java", "java/org/apache/tomcat/util/http/fileupload/MultipartStream.java", "java/org/apache/tomcat/util/http/mapper/Mapper.java", "java/org/apache/tomcat/util/modeler/AttributeInfo.java", "java/org/apache/tomcat/util/modeler/BaseModelMBean.java", "java/org/apache/tomcat/util/modeler/Registry.java", "java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java", "java/org/apache/tomcat/util/net/AprEndpoint.java", "java/org/apache/tomcat/util/net/DefaultServerSocketFactory.java", "java/org/apache/tomcat/util/net/NioEndpoint.java", "java/org/apache/tomcat/util/net/ServerSocketFactory.java", "java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:24:42Z" | "2009-11-06T04:00:00Z" |
48,143 | Bug 48143 Javadoc fixes | null | resolved fixed | c52b1ba | ["java/javax/servlet/SessionCookieConfig.java", "java/org/apache/catalina/ant/jmx/JMXAccessorCreateTask.java", "java/org/apache/catalina/core/ApplicationFilterChain.java", "java/org/apache/catalina/core/StandardContextValve.java", "java/org/apache/catalina/core/StandardEngineValve.java", "java/org/apache/catalina/core/StandardHostValve.java", "java/org/apache/catalina/core/StandardWrapperValve.java", "java/org/apache/catalina/ha/ClusterManager.java", "java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java", "java/org/apache/catalina/manager/StatusTransformer.java", "java/org/apache/catalina/realm/CombinedRealm.java", "java/org/apache/catalina/realm/LockOutRealm.java", "java/org/apache/catalina/startup/Embedded.java", "java/org/apache/catalina/startup/WebRuleSet.java", "java/org/apache/catalina/tribes/group/ChannelCoordinator.java", "java/org/apache/catalina/tribes/io/ChannelData.java", "java/org/apache/catalina/tribes/io/ObjectReader.java", "java/org/apache/catalina/tribes/io/ReplicationStream.java", "java/org/apache/catalina/tribes/io/XByteBuffer.java", "java/org/apache/catalina/tribes/membership/McastServiceImpl.java", "java/org/apache/catalina/tribes/membership/MemberImpl.java", "java/org/apache/catalina/tribes/membership/Membership.java", "java/org/apache/catalina/tribes/transport/bio/util/LinkObject.java", "java/org/apache/catalina/tribes/transport/nio/NioReceiver.java", "java/org/apache/catalina/users/MemoryUserDatabase.java", "java/org/apache/catalina/valves/RemoteIpValve.java", "java/org/apache/coyote/http11/Http11Processor.java", "java/org/apache/jasper/compiler/ParserController.java", "java/org/apache/jasper/compiler/TagFileProcessor.java", "java/org/apache/jasper/compiler/TldLocationsCache.java", "java/org/apache/naming/HandlerRef.java", "java/org/apache/naming/ServiceRef.java", "java/org/apache/naming/resources/BaseDirContext.java", "java/org/apache/tomcat/buildutil/Txt2Html.java", "java/org/apache/tomcat/util/digester/SetPropertiesRule.java", "java/org/apache/tomcat/util/digester/SetPropertyRule.java", "java/org/apache/tomcat/util/modeler/BaseModelMBean.java", "java/org/apache/tomcat/util/net/NioBlockingSelector.java", "java/org/apache/tomcat/util/net/SSLSessionManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-17T22:13:30Z" | "2009-11-05T16:53:20Z" |
48,139 | Bug 48139 Tomcat Javadoc and unthrown exception fixes | null | resolved fixed | ab3620c | ["java/org/apache/catalina/startup/Tomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T19:12:14Z" | "2009-11-05T14:06:40Z" |
48,137 | Bug 48137 some misspellings I can find in the "org.apache.catalina" package | null | resolved fixed | 18c0edc | ["java/org/apache/catalina/Cluster.java", "java/org/apache/catalina/CometEvent.java", "java/org/apache/catalina/CometProcessor.java", "java/org/apache/catalina/Context.java", "java/org/apache/catalina/Host.java", "java/org/apache/catalina/Pipeline.java", "java/org/apache/catalina/ant/BaseRedirectorHelperTask.java", "java/org/apache/catalina/ant/JKStatusUpdateTask.java", "java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java", "java/org/apache/catalina/ant/jmx/JMXAccessorSetTask.java", "java/org/apache/catalina/ant/jmx/JMXAccessorTask.java", "java/org/apache/catalina/authenticator/AuthenticatorBase.java", "java/org/apache/catalina/authenticator/FormAuthenticator.java", "java/org/apache/catalina/authenticator/SingleSignOn.java", "java/org/apache/catalina/connector/Connector.java", "java/org/apache/catalina/connector/CoyoteAdapter.java", "java/org/apache/catalina/connector/CoyoteInputStream.java", "java/org/apache/catalina/connector/CoyoteReader.java", "java/org/apache/catalina/connector/OutputBuffer.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/connector/RequestFacade.java", "java/org/apache/catalina/connector/Response.java", "java/org/apache/catalina/deploy/ContextService.java", "java/org/apache/catalina/filters/WebdavFixFilter.java", "java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java", "java/org/apache/catalina/ha/backend/CollectedInfo.java", "java/org/apache/catalina/ha/backend/HeartbeatListener.java", "java/org/apache/catalina/ha/deploy/FarmWarDeployer.java", "java/org/apache/catalina/ha/deploy/FileMessageFactory.java", "java/org/apache/catalina/ha/deploy/WarWatcher.java", "java/org/apache/catalina/ha/session/DeltaManager.java", "java/org/apache/catalina/ha/session/DeltaRequest.java", "java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/ha/session/JvmRouteBinderValve.java", "java/org/apache/catalina/ha/session/SessionMessageImpl.java", "java/org/apache/catalina/ha/tcp/ReplicationValve.java", "java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java", "java/org/apache/catalina/loader/WebappClassLoader.java", "java/org/apache/catalina/manager/HTMLManagerServlet.java", "java/org/apache/catalina/manager/JMXProxyServlet.java", "java/org/apache/catalina/manager/ManagerServlet.java", "java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java", "java/org/apache/catalina/manager/util/SessionUtils.java", "java/org/apache/catalina/mbeans/ContextEnvironmentMBean.java", "java/org/apache/catalina/mbeans/ContextResourceLinkMBean.java", "java/org/apache/catalina/mbeans/ContextResourceMBean.java", "java/org/apache/catalina/mbeans/MBeanFactory.java", "java/org/apache/catalina/mbeans/ServerLifecycleListener.java", "java/org/apache/catalina/realm/DataSourceRealm.java", "java/org/apache/catalina/realm/JAASCallbackHandler.java", "java/org/apache/catalina/realm/JAASMemoryLoginModule.java", "java/org/apache/catalina/realm/JAASRealm.java", "java/org/apache/catalina/realm/JDBCRealm.java", "java/org/apache/catalina/realm/JNDIRealm.java", "java/org/apache/catalina/realm/LockOutRealm.java", "java/org/apache/catalina/realm/RealmBase.java", "java/org/apache/catalina/security/SecurityUtil.java", "java/org/apache/catalina/servlets/CGIServlet.java", "java/org/apache/catalina/servlets/DefaultServlet.java", "java/org/apache/catalina/servlets/WebdavServlet.java", "java/org/apache/catalina/session/JDBCStore.java", "java/org/apache/catalina/session/PersistentManagerBase.java", "java/org/apache/catalina/session/StandardManager.java", "java/org/apache/catalina/ssi/ExpressionParseTree.java", "java/org/apache/catalina/ssi/SSIFsize.java", "java/org/apache/catalina/ssi/SSIServletExternalResolver.java", "java/org/apache/catalina/ssi/SSIStopProcessingException.java", "java/org/apache/catalina/tribes/Channel.java", "java/org/apache/catalina/tribes/ChannelListener.java", "java/org/apache/catalina/tribes/Heartbeat.java", "java/org/apache/catalina/tribes/Member.java", "java/org/apache/catalina/tribes/UniqueId.java", "java/org/apache/catalina/tribes/group/GroupChannel.java", "java/org/apache/catalina/tribes/group/interceptors/MessageDispatch15Interceptor.java", "java/org/apache/catalina/tribes/io/ObjectReader.java", "java/org/apache/catalina/tribes/membership/McastServiceImpl.java", "java/org/apache/catalina/tribes/transport/PooledSender.java", "java/org/apache/catalina/tribes/transport/bio/BioReplicationTask.java", "java/org/apache/catalina/tribes/transport/bio/BioSender.java", "java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java", "java/org/apache/catalina/tribes/transport/nio/NioSender.java", "java/org/apache/catalina/tribes/transport/nio/ParallelNioSender.java", "java/org/apache/catalina/users/MemoryUserDatabase.java", "java/org/apache/catalina/util/Base64.java", "java/org/apache/catalina/util/DateTool.java", "java/org/apache/catalina/util/ExtensionValidator.java", "java/org/apache/catalina/util/IOTools.java", "java/org/apache/catalina/util/ManifestResource.java", "java/org/apache/catalina/util/ParameterMap.java", "java/org/apache/catalina/util/RequestUtil.java", "java/org/apache/catalina/util/SchemaResolver.java", "java/org/apache/catalina/util/Strftime.java", "java/org/apache/catalina/valves/AccessLogValve.java", "java/org/apache/catalina/valves/CometConnectionManagerValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T19:08:42Z" | "2009-11-05T11:20:00Z" |
48,135 | Bug 48135 ServiceRefFactory: impossible null check of serviceInterfaceClass | The ServiceRefFactory class performs an impossible null check of serviceInterfaceClass at line 238: 237: Class[] serviceInterfaces = serviceInterfaceClass.getInterfaces(); 238: if (serviceInterfaceClass != null) { If it were null, line 237 would generate an NPE. | resolved fixed | 97ccffd | ["java/org/apache/naming/factory/webservices/ServiceProxy.java", "java/org/apache/naming/factory/webservices/ServiceRefFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T18:41:30Z" | "2009-11-05T08:33:20Z" |
48,133 | Bug 48133 misspellings in the javadoc and comment of the various classes in the package of "org.apache.core" | null | resolved fixed | 9204e4d | ["java/org/apache/catalina/core/ApplicationDispatcher.java", "java/org/apache/catalina/core/ApplicationFilterFactory.java", "java/org/apache/catalina/core/ApplicationHttpRequest.java", "java/org/apache/catalina/core/ContainerBase.java", "java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/core/StandardEngine.java", "java/org/apache/catalina/core/StandardHost.java", "java/org/apache/catalina/core/StandardPipeline.java", "java/org/apache/catalina/core/StandardService.java", "java/org/apache/catalina/core/StandardWrapperFacade.java", "java/org/apache/catalina/core/StandardWrapperValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T18:18:53Z" | "2009-11-05T00:13:20Z" |
48,131 | Bug 48131 Add @deprecated annotations to deprecated elements | null | resolved fixed | a3fa5d3 | ["java/javax/servlet/ServletContext.java", "java/javax/servlet/ServletRequest.java", "java/javax/servlet/ServletRequestWrapper.java", "java/javax/servlet/SingleThreadModel.java", "java/javax/servlet/UnavailableException.java", "java/javax/servlet/http/HttpServletRequest.java", "java/javax/servlet/http/HttpServletRequestWrapper.java", "java/javax/servlet/http/HttpServletResponse.java", "java/javax/servlet/http/HttpServletResponseWrapper.java", "java/javax/servlet/http/HttpSession.java", "java/javax/servlet/http/HttpSessionContext.java", "java/javax/servlet/http/HttpUtils.java", "java/javax/servlet/jsp/JspException.java", "java/javax/servlet/jsp/el/ELException.java", "java/javax/servlet/jsp/el/ELParseException.java", "java/javax/servlet/jsp/el/Expression.java", "java/javax/servlet/jsp/el/ExpressionEvaluator.java", "java/javax/servlet/jsp/el/FunctionMapper.java", "java/javax/servlet/jsp/el/VariableResolver.java", "java/javax/servlet/jsp/tagext/BodyTag.java", "java/org/apache/catalina/Cluster.java", "java/org/apache/catalina/Manager.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/connector/Response.java", "java/org/apache/catalina/core/ApplicationContext.java", "java/org/apache/catalina/core/ApplicationContextFacade.java", "java/org/apache/catalina/core/ApplicationHttpResponse.java", "java/org/apache/catalina/core/DummyRequest.java", "java/org/apache/catalina/core/DummyResponse.java", "java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java", "java/org/apache/catalina/realm/JAASRealm.java", "java/org/apache/catalina/session/ManagerBase.java", "java/org/apache/catalina/session/StandardSession.java", "java/org/apache/catalina/session/StandardSessionFacade.java", "java/org/apache/catalina/startup/Catalina.java", "java/org/apache/catalina/tribes/io/XByteBuffer.java", "java/org/apache/catalina/tribes/membership/McastService.java", "java/org/apache/catalina/tribes/transport/ReceiverBase.java", "java/org/apache/el/parser/SimpleCharStream.java", "java/org/apache/jasper/servlet/JspCServletContext.java", "java/org/apache/naming/resources/ResourceAttributes.java", "java/org/apache/tomcat/util/digester/Rule.java", "java/org/apache/tomcat/util/digester/SetNextRule.java", "java/org/apache/tomcat/util/digester/SetPropertiesRule.java", "java/org/apache/tomcat/util/digester/SetPropertyRule.java", "java/org/apache/tomcat/util/digester/SetRootRule.java", "java/org/apache/tomcat/util/digester/SetTopRule.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T00:46:07Z" | "2009-11-04T18:40:00Z" |
48,123 | Bug 48123 4 misspellings in the javadoc of class "org.apache.catalina.startup.WebRuleSet" | No.1 Line: 99 /** * Construct an instance of this <code>RuleSet</code> with the default * matching pattern prefix and default fargment setting. */ public WebRuleSet() { 'fragment' was misspelled as 'fargment' No.2 Line: 614 /** * Rule to check that the <code>login-config</code> is occuring * only 1 time within the web.xml */ final class SetLoginConfig extends Rule { 'occurring' was misspelled as 'occuring' No.3 Line 635 /** * Rule to check that the <code>jsp-config</code> is occuring * only 1 time within the web.xml */ final class SetJspConfig extends Rule { 'occurring' was misspelled as 'occuring' No.4 Line 656 /** * Rule to check that the <code>session-config</code> is occuring * only 1 time within the web.xml */ final class SetSessionConfig extends Rule { 'occurring' was misspelled as 'occuring' | resolved fixed | 363b79a | ["java/org/apache/catalina/startup/WebRuleSet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T00:34:33Z" | "2009-11-04T07:33:20Z" |
48,121 | Bug 48121 2 misspellings in the javadoc of class "org.apache.catalina.startup.TldConfig" | No.1 Line 194: /** * Attribute value used to turn on/off TLD namespace awarenes. */ private boolean tldNamespaceAware = false; 'awareness' was misspelled as 'awarenes' No.2 Line 261 /** * Get the server.xml <host> attribute's xmlNamespaceAware. * @return true if namespace awarenes is enabled. * */ public boolean getTldNamespaceAware(){ return this.tldNamespaceAware; } 'awareness' was misspelled as 'awarenes' | resolved fixed | 5d9f68b | ["java/org/apache/catalina/startup/TldConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T00:30:25Z" | "2009-11-04T07:33:20Z" |
48,120 | Bug 48120 one misspelling in the javadoc of class "org.apache.catalina.startup.SetNextNamingRule" | Line 50: /** * Construct a "set next" rule with the specified method name. * * @param methodName Method name of the parent method to call * @param paramType Java class of the parent method's argument * (if you wish to use a primitive type, specify the corresonding * Java wrapper class instead, such as <code>java.lang.Boolean</code> * for a <code>boolean</code> parameter) */ public SetNextNamingRule(String methodName, String paramType) { 'corresponding' was misspelled as 'corresonding' | resolved fixed | 7508847 | ["java/org/apache/catalina/startup/SetNextNamingRule.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T00:28:09Z" | "2009-11-04T07:33:20Z" |
48,117 | Bug 48117 two misspellings in the javadoc of class "org.apache.catalina.startup.ContextConfig" | in protected synchronized void stop(): (Line: 1059) // Removing sercurity role 'security' is misspelled to 'sercurity' in protected InputSource getWebXmlSource(String filename, String path): (Line: 1354) /** * * @param filename Name of the file (possibly with one or more leading path * segemnts) to read * @param path Location that filename is relative to * @return */ 'segments' is misspelled to 'segemnts'. | resolved fixed | b6df018 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-05T00:26:28Z" | "2009-11-04T07:33:20Z" |
48,119 | Bug 48119 5 misspellings in the javadoc of class "org.apache.catalina.startup.HostConfig' | No.1 Line 146: /** * Attribute value used to turn on/off XML namespace awarenes. */ protected boolean xmlNamespaceAware = false; 'awareness' was misspelled as 'awarenes' No.2 Line 268: /** * Get the server.xml <host> attribute's xmlNamespaceAware. * @return true if namespace awarenes is enabled. * */ public boolean getXmlNamespaceAware(){ return xmlNamespaceAware; } 'awareness' was misspelled as 'awarenes' No.3 Line 366: /** * Has the specified application been deployed? Note applications defined * in server.xml will not have been deployed. * @return <code>true</code> if the application has been deployed and * <code>false</code> if the applciation has not been deployed or does not * exist */ public boolean isDeployed(String name) { 'application' was misspelled as 'applciation' No.4 Line 1328: /** * Add a new Context to be managed by us. * Entry point for the admin webapp, and other JMX Context controlers. */ public void manageApp(Context context) { 'controllers' was misspelled as 'controlers' Line 1382: /** * Remove a webapp from our control. * Entry point for the admin webapp, and other JMX Context controlers. */ public void unmanageApp(String contextPath) { 'controllers' was misspelled as 'controlers' | resolved fixed | 07e5982 | ["java/org/apache/catalina/startup/HostConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-04T13:26:33Z" | "2009-11-04T07:33:20Z" |
48,118 | Bug 48118 two misspellings in the javadoc of class "org.apache.catalina.startup.Embeded" | Line: 230 /** * Return true if redirction of standard streams is enabled. */ public boolean isRedirectStreams() { return (this.redirectStreams); } 'redirection' was misspelled to 'redirction' Line: 875 /** Initialize naming - this should only enable java:env and root naming. * If tomcat is embeded in an application that already defines those - * it shouldn't do it. * * XXX The 2 should be separated, you may want to enable java: but not * the initial context and the reverse * XXX Can we "guess" - i.e. lookup java: and if something is returned assume * false ? * XXX We have a major problem with the current setting for java: url */ protected void initNaming() { 'embedded' was mispelled to 'embeded' | resolved fixed | ae16eb2 | ["java/org/apache/catalina/startup/Embedded.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-04T13:13:41Z" | "2009-11-04T07:33:20Z" |
46,947 | Bug 46947 Code cleanup patch that removes some obsolete null checks | null | resolved fixed | 6908b18 | ["java/org/apache/catalina/ant/jmx/JMXAccessorTask.java", "java/org/apache/catalina/tribes/transport/bio/BioReceiver.java", "java/org/apache/catalina/valves/JDBCAccessLogValve.java", "java/org/apache/tomcat/util/net/NioBlockingSelector.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-04T00:54:02Z" | "2009-03-31T17:20:00Z" |
48,102 | Bug 48102 'Bootstrap' is misspelled as 'Boostrap' in the javadoc of the class of 'org.apache.catalina.startup.Bootstrap' | Below is the javadoc of the class of 'org.apache.catalina.startup.Bootstrap': /** * Boostrap loader for Catalina. This application constructs a class loader * for use in loading the Catalina internal classes (by accumulating all of the * JAR files found in the "server" directory under "catalina.home"), and * starts the regular execution of the container. The purpose of this * roundabout approach is to keep the Catalina internal classes (and any * other classes they depend on, such as an XML parser) out of the system * class path and therefore not visible to application level classes. * * @author Craig R. McClanahan * @author Remy Maucherat * @version $Revision: 831860 $ $Date: 2009-11-02 19:00:01 +0800 (Mon, 02 Nov 2009) $ */ the first word ommits a 't' letter. It sould be 'Bootstrap', not 'Boostrap'. | resolved fixed | c060034 | ["java/org/apache/catalina/startup/Bootstrap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-03T00:16:42Z" | "2009-11-02T08:20:00Z" |
48,104 | Bug 48104 the javadoc of class 'org.apache.catalina.startup.Catalina' is not complete, as in the usage() method | Below is the javadoc of class 'org.apache.catalina.startup.Catalina': /** * Startup/Shutdown shell program for Catalina. The following command line * options are recognized: * <ul> * <li><b>-config {pathname}</b> - Set the pathname of the configuration file * to be processed. If a relative path is specified, it will be * interpreted as relative to the directory pathname specified by the * "catalina.base" system property. [conf/server.xml] * <li><b>-help</b> - Display usage information. * <li><b>-stop</b> - Stop the currently running instance of Catalina. * </u> * * Should do the same thing as Embedded, but using a server.xml file. * * @author Craig R. McClanahan * @author Remy Maucherat * @version $Revision: 752323 $ $Date: 2009-03-11 08:46:54 +0800 (Wed, 11 Mar 2009) $ */ However, it doesn't allude the '-nonmaing' option, and 'start' option. Below is the usage() method of the same class: /** * Print usage information for this application. */ protected void usage() { System.out.println ("usage: java org.apache.catalina.startup.Catalina" + " [ -config {pathname} ]" + " [ -nonaming ] { start | stop }"); } It is not complete either. It lacks the '-help' option. | resolved fixed | 481cfe9 | ["java/org/apache/catalina/startup/Catalina.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-03T00:14:11Z" | "2009-11-02T08:20:00Z" |
47,881 | Bug 47881 org.apache.catalina.startup.Bootstrap's main method handles 'startd' or 'stopd' wrongly | String command = "start"; if (args.length > 0) { command = args[args.length - 1]; } if (command.equals("startd")) { args[0] = "start"; daemon.load(args); daemon.start(); } else if (command.equals("stopd")) { args[0] = "stop"; daemon.stop(); } ... ... should be: String command = "start"; if (args.length > 0) { command = args[args.length - 1]; } if (command.equals("startd")) { args[args.length - 1] = "start"; daemon.load(args); daemon.start(); } else if (command.equals("stopd")) { args[args.length - 1] = "stop"; daemon.stop(); } ... ... Please refer to the following usage method of org.apache.catalina.startup.Catalina: protected void usage() { System.out.println ("usage: java org.apache.catalina.startup.Catalina" + " [ -config {pathname} ]" + " [ -nonaming ] { start | stop }"); } | resolved fixed | 3ef0f21 | ["java/org/apache/catalina/startup/Bootstrap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-02T11:00:01Z" | "2009-09-20T23:40:00Z" |
47,331 | Bug 47331 No translation error messag when using #{...} in template text | null | resolved fixed | f3b04b4 | ["java/org/apache/jasper/compiler/Validator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-02T00:30:55Z" | "2009-06-08T05:46:40Z" |
47,451 | Bug 47451 NPE if response contains null content-encoding header | null | resolved fixed | 14084ac | ["java/org/apache/catalina/connector/Response.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-01T22:53:29Z" | "2009-06-29T18:26:40Z" |
47,364 | Bug 47364 HttpServletRequest.getAttributeNames() does not return the names of all attributes | In an email exchange that involved Ranier (see attachment), he suggested I log this in Bugzilla, so I am. I was using Tomcat 6.0.20 on Windows XP SP3 with the latest Java 6 JVM. In the doGet method of a servlet, I was trying to see all request attributes to see if the "sendfile supported" attribute was set (specifically the request attribute org.apache.tomcat.sendfile.support). On my first pass at this I just used HttpServletRequest.getAttributeNames() to dump all the names of the attributes expecting to see this one listed, but I got no attributes listed at all. Then I actually got the attribute via getAttribute("org.apache.tomcat.sendfile.support") which worked. So getAttributeNames is not returning the names of all attributes. So either: 1. getAttributeNames needs to be fixed to return the names of all attributes (i.e., a code change); or 2. The Tomcat doc needs to be updated in some way as to say thatgetAttributeNames only returns certain attributes and blah blah (i.e., a doc change). Again my original email and Ranier's reply is attached. Thanks! | resolved fixed | 7fc56b4 | ["java/org/apache/catalina/connector/Request.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-11-01T18:35:02Z" | "2009-06-12T18:06:40Z" |
48,009 | Bug 48009 Editing context.xml may cause unwanted undeploy of a webapp | Tomcat polls context.xml files for changes. If a previously-existing context.xml is missing at the instant Tomcat polls, then the application is undeployed. Some text editors (notably vi and its derivatives) create backup files by: 1) Renaming the original file, then 2) creating a new file and writing the edited contents to that file. Therefore there is a race condition. There is a small but non-zero probability that a user editing and saving context.xml using such an editor will see their webapp undeployed. Messages on tomcat-users indicate that such a situation has occurred on a production server at least once. It's undoubtedly rare. Suggested fixes: - Examine the directory for the presence of backup files for context.xml, and do not undeploy if one is found even if context.xml is missing. This is horribly ugly and makes the semantics of "a backup file" very peculiar, but is actually the only way to *prevent* the race - anything else only makes it less likely, as on a heavily loaded system (or one where context.xml is being edited via a network file share) the interval between the old context.xml being renamed and the new one being created may be arbitrarily long. - Only undeploy if the file is missing for a period of time. The discussion is then around that period. On tomcat-users, Mark Thomas suggested polling again after 500ms; I suggested remembering the state between polls and only undeploying if the file was missing for two successive polls. This is a cleaner fix to explain, but is not a complete solution as it does not remove the possibility of such a race. --- As an aside, there may well be a similar issue where Tomcat polls for context.xml as it is being written, finds it has changed, and reads a part-written version. In mitigation, the files involved are typically small and may well be written in one or very few operations; however, Tomcat should probably not assume that any file change is atomic. | resolved fixed | d55f1d9 | ["java/org/apache/catalina/startup/HostConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-10-21T20:53:47Z" | "2009-10-16T05:13:20Z" |
48,019 | Bug 48019 StackOverflowError on "include" | JSP file name: /common/headers.jsp It's cotent: <% // example: <%@ include file="/common/headers.jsp" % > %> <meta http-equiv="Content-Type" content="text/html;charset=utf-8" /> <meta http-equiv="Cache-Control" content="no-store" /> <meta http-equiv="Pragma" content="no-cache" /> <meta http-equiv="Expires" content="0" /> <link href="../css/css.css" rel="stylesheet" type="text/css"> Console output: java.lang.StackOverflowError at java.text.DateFormat.format(DateFormat.java:275) at java.text.Format.format(Format.java:140) at java.text.MessageFormat.subformat(MessageFormat.java:1288) at java.text.MessageFormat.format(MessageFormat.java:795) at java.util.logging.SimpleFormatter.format(SimpleFormatter.java:50) at java.util.logging.StreamHandler.publish(StreamHandler.java:179) at java.util.logging.ConsoleHandler.publish(ConsoleHandler.java:88) at java.util.logging.Logger.log(Logger.java:458) at java.util.logging.Logger.doLog(Logger.java:480) at java.util.logging.Logger.logp(Logger.java:680) at org.apache.juli.logging.DirectJDKLog.log(DirectJDKLog.java:167) at org.apache.juli.logging.DirectJDKLog.error(DirectJDKLog.java:135) at org.apache.jasper.compiler.JspReader.pushFile(JspReader.java:606) at org.apache.jasper.compiler.JspReader.<init>(JspReader.java:141) at org.apache.jasper.compiler.JspReader.<init>(JspReader.java:119) at org.apache.jasper.compiler.ParserController.determineSyntaxAndEncoding(ParserController.java:399) at org.apache.jasper.compiler.ParserController.doParse(ParserController.java:207) at org.apache.jasper.compiler.ParserController.parse(ParserController.java:137) at org.apache.jasper.compiler.Parser.processIncludeDirective(Parser.java:339) at org.apache.jasper.compiler.Parser.parseIncludeDirective(Parser.java:376) at org.apache.jasper.compiler.Parser.parseDirective(Parser.java:484) at org.apache.jasper.compiler.Parser.parseTagFileDirectives(Parser.java:1784) at org.apache.jasper.compiler.Parser.parse(Parser.java:127) This not exist in "6.0.18". | resolved fixed | deac657 | ["java/org/apache/jasper/compiler/Parser.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-10-21T20:43:21Z" | "2009-10-17T11:46:40Z" |
40,001 | Bug 40001 HTML pages should not use GET to restart web-apps. | null | resolved fixed | 99f01fd | ["java/org/apache/catalina/manager/Constants.java", "java/org/apache/catalina/manager/HTMLManagerServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-10-10T21:54:54Z" | "2006-07-10T19:33:20Z" |
47,320 | Bug 47320 Decoding jsessionid bug on z/os | If you receive a rewritten URL on z/os with uss (unix on a mainframe), Tomcat does not properly decode the jsessionid portion of the URL. The problem is in org.apache.catalina.connector.CoyoteAdapter in the parseSessionId method. The two instantiations of a String object do not specify the encdoding to use. e.g. String sid = new String(uriBC.getBuffer(), start + sessionIdStart, semicolon2 - sessionIdStart); ...as well as the second String instantiation in this method. Consequently z/os uses its default encoding which (I think) is EBCDIC. If I recompile with a hardcoded "UTF-8" for the encoding then the jsessionid decodes properly. Not that I am suggesting this literally for the official fix. e.g. String sid = new String(uriBC.getBuffer(), start + sessionIdStart, semicolon2 - sessionIdStart, "UTF-8"); | resolved fixed | 0f99904 | ["java/org/apache/catalina/connector/CoyoteAdapter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-27T16:48:23Z" | "2009-06-05T13:53:20Z" |
47,499 | Bug 47499 provide better insight on BindException: Cannot assign requested address | 1) cite the address you attempt to listen (not just the port) 2) proper exception chaining the following info is currently lost: <<java.net.BindException: Cannot assign requested address at java.net.PlainSocketImpl.socketBind(Native Method) at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:359) at java.net.ServerSocket.bind(ServerSocket.java:319) at java.net.ServerSocket.<init>(ServerSocket.java:185) at javax.net.ssl.SSLServerSocket.<init>(SSLServerSocket.java:106) at com.privasphere.net.ssl.SSLServerSocketImpl.<init>(SSLServerSocketImpl.java:106) at com.privasphere.net.ssl.SSLServerSocketFactoryImpl.createServerSocket(SSLServerSocketFactoryImpl.java:71) at org.apache.tomcat.util.net.jsse.JSSESocketFactory.createSocket(JSSESocketFactory.java:100) at org.apache.tomcat.util.net.PoolTcpEndpoint.initEndpoint(PoolTcpEndpoint.java:295) at org.apache.coyote.http11.Http11BaseProtocol.init(Http11BaseProtocol.java:139) at org.apache.catalina.connector.Connector.initialize(Connector.java:1017) at org.apache.catalina.core.StandardService.initialize(StandardService.java:578)>> | resolved fixed | 73bb9e4 | ["java/org/apache/tomcat/util/net/JIoEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-22T21:16:54Z" | "2009-07-09T03:26:40Z" |
47,866 | Bug 47866 NullPointerException in embedded tomcat | It seems that the WebappClassLoader was stopped? {noformat} Caused by: java.lang.NullPointerException at org.apache.catalina.loader.WebappClassLoader.findResources(WebappClassLoader.java:994) at java.lang.ClassLoader.getResources(ClassLoader.java:1016) {noformat} All I did was launch a server add a context and then ask it to load a resource from its classpath. It's a bit more complicated than that, so I'll try and narrow it down if needed. | resolved wontfix | 189181a | ["test/org/apache/catalina/startup/TestTomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-21T10:54:36Z" | "2009-09-18T05:00:00Z" |
47,225 | Bug 47225 Wrong argument in redirectPath.setChars in Mapper.internalMapWrapper() | null | resolved fixed | a31d52f | ["java/org/apache/tomcat/util/http/mapper/Mapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-16T21:17:11Z" | "2009-05-20T00:40:00Z" |
47,161 | Bug 47161 Manager ignores executors on status pages | When displaying the thread pools, the StatusManagerServlet ignores executors and uses the 'standard' ThreadPool information for each connector. This causes incorrect information to be displayed when a connector is configured to use an executor. On a related topic, it appears that the connector<->executor link is not exposed via JMX (which it will need to be to fix this). | resolved fixed | aaf7b5d | ["java/org/apache/tomcat/util/net/AbstractEndpoint.java", "java/org/apache/tomcat/util/threads/ResizableExecutor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-15T21:06:14Z" | "2009-05-06T11:40:00Z" |
46,950 | Bug 46950 SSL renegotiation does not occur when resource with CLIENT-CERT auth is requested | When a part of a webapp requires an SSL connection with a client certificate there should be an SSL renegotiation to request a client certificate from the browser. This is the configuration I added to an webapp that already uses an SSL connector: <login-config id="LoginConfig_1"> <auth-method>CLIENT-CERT</auth-method> <realm-name>WPS</realm-name> </login-config> <security-constraint id="SecurityConstraint_1"> <web-resource-collection id="WebResourceCollection_1"> <web-resource-name/> <url-pattern>/LoginWithCert.do</url-pattern> <http-method>DELETE</http-method> <http-method>GET</http-method> <http-method>POST</http-method> <http-method>PUT</http-method> <http-method>HEAD</http-method> </web-resource-collection> <user-data-constraint id="UserDataConstraint_4"> <transport-guarantee>CONFIDENTIAL</transport-guarantee> </user-data-constraint> </security-constraint> Requests to /LoginWithCert.do require an SSL connection, if there isn't one, but no client certificate is requested. | resolved fixed | e9248d7 | ["java/org/apache/catalina/core/AprLifecycleListener.java", "java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/tomcat/jni/SSLSocket.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-15T17:50:54Z" | "2009-04-01T10:00:00Z" |
47,828 | Bug 47828 Change Tomcat.setSilent() to setSilent(boolean) | Change Tomcat.setSilent() to setSilent(boolean). It's nicer for clients to have a JavaBean type setter, and it doesn't seem to make sense that you can set something but not unset it. | resolved fixed | 59e88f1 | ["java/org/apache/catalina/startup/Tomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-15T10:38:23Z" | "2009-09-12T04:33:20Z" |
47,820 | Bug 47820 Static utility methods in Tomcat should be instance methods | Why are the static addServlet() methods in Tomcat static? I can see they don't use any state from the instance, but isn't it cleaner to use an instance method, so that the API is uniform (everything I want to do to a tomcat instance goes through the instance)? It would be more consistent to follow the pattern of addServlet(String,String,String), and search for the context by name instead of requiring the instance to be passed in to a static method. | resolved fixed | 6cce550 | ["java/org/apache/catalina/startup/Tomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-15T10:26:32Z" | "2009-09-11T06:20:00Z" |
47,826 | Bug 47826 a logging statement error in org.apache.catalina.startup.Bootstrap.java | // Local repository boolean replace = false; String before = repository; while ((i=repository.indexOf(CATALINA_HOME_TOKEN))>=0) { replace=true; if (i>0) { repository = repository.substring(0,i) + getCatalinaHome() + repository.substring(i+CATALINA_HOME_TOKEN.length()); } else { repository = getCatalinaHome() + repository.substring(CATALINA_HOME_TOKEN.length()); } } while ((i=repository.indexOf(CATALINA_BASE_TOKEN))>=0) { replace=true; if (i>0) { repository = repository.substring(0,i) + getCatalinaBase() + repository.substring(i+CATALINA_BASE_TOKEN.length()); } else { repository = getCatalinaBase() + repository.substring(CATALINA_BASE_TOKEN.length()); } } if (replace && log.isDebugEnabled()) log.debug("Expanded " + before + " to " + replace); The last line should be: "log.debug("Expanded " + before + " to " + repository);" | resolved fixed | 720de5e | ["java/org/apache/catalina/startup/Bootstrap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-09-12T16:13:14Z" | "2009-09-11T23:00:00Z" |
47,705 | Bug 47705 ArithmeticException: / by zero when expiring sessions via manager | Received ArithmeticException: / by zero when expiring sessions via Tomcat manager webapp. This exception was thrown only if session-timeout is set as -1 on webapp web.xml. Moreover, the exception was also thrown regardless of the idle parameter value (/expire?path=/xxx&idle=mm) as long as session-timeout = -1. Result: Exception stacktrace: ERROR: 19/08/2009 00:18:22 [http-80-exec-33] (org.apache.catalina.core.ApplicationContext:669) HTMLManager: ManagerServlet.sessions[/contextpath] java.lang.ArithmeticException: / by zero at org.apache.catalina.manager.ManagerServlet.sessions(ManagerServlet.java:1133) at org.apache.catalina.manager.HTMLManagerServlet.sessions(HTMLManagerServlet.java:573) at org.apache.catalina.manager.HTMLManagerServlet.expireSessions(HTMLManagerServlet.java:660) at org.apache.catalina.manager.HTMLManagerServlet.doGet(HTMLManagerServlet.java:118) at org.apache.catalina.manager.HTMLManagerServlet.doPost(HTMLManagerServlet.java:157) at javax.servlet.http.HttpServlet.service(HttpServlet.java:637) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:525) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286) at org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:880) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:719) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2081) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:619) | resolved fixed | 6ab874a | ["java/org/apache/catalina/manager/ManagerServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-08-31T14:17:37Z" | "2009-08-19T05:33:20Z" |
47,378 | Bug 47378 welcome-file ignores servlet mapping | Web applications that use a servlet mapping for their welcome-file are ignored and the server returns either a directory listing or a 404 if the listing is disabled. I have JSF servlet defined and a servlet-mapping for *.jsf to go to the FacesServlet. I have "index.jsf" listed as by welcome-file and I get a 404 with directory listing disabled. I also have a custom servlet defined with its mapping and set the welcome-file to its mapping and get a 404 as well. | resolved fixed | fe53ca9 | ["java/org/apache/tomcat/util/http/mapper/Mapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-08-31T13:59:00Z" | "2009-06-16T16:33:20Z" |
47,612 | Bug 47612 [PATCH] fix unsafe public string array in AbstractCreateStatementInterceptor | null | resolved fixed | 4f5a5e4 | ["modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/AbstractCreateStatementInterceptor.java", "modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/AbstractQueryReport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-08-05T16:19:34Z" | "2009-07-30T21:40:00Z" |
47,583 | Bug 47583 Fix occasional test failure in TestConcurrency | null | resolved fixed | 278dedc | ["modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestConcurrency.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-30T19:40:54Z" | "2009-07-26T12:06:40Z" |
47,576 | Bug 47576 Javadoc errors - Exception name misspelt | The files FairBlockingQueue.java MultiLockFairBlockingQueue.java use * @throws UnsupportedOperation This should be * @throws UnsupportedOperationException | resolved fixed | abbb922 | ["modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/FairBlockingQueue.java", "modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/MultiLockFairBlockingQueue.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-30T18:13:36Z" | "2009-07-24T21:13:20Z" |
47,569 | Bug 47569 Test cases do not clear up afterwards | Some of the test cases (e.g. TestTomcat) start a Tomcat server, This creates the directory tree tomcat.8080/work... which is not deleted when the test finishes. | resolved fixed | a9e00d5 | ["test/org/apache/catalina/connector/TestRequest.java", "test/org/apache/catalina/startup/TestTomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-30T18:10:35Z" | "2009-07-23T17:26:40Z" |
47,568 | Bug 47568 TestTomcat fails to delete work directory | TestTomcat.setUp() creates a work directory, but does not delete it in tearDown() | resolved fixed | cfb18a0 | ["test/org/apache/catalina/startup/TestTomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-30T07:01:13Z" | "2009-07-23T17:26:40Z" |
41,824 | Bug 41824 Unable to use nested type in TLD | null | resolved fixed | 768af9f | ["java/org/apache/jasper/compiler/JspUtil.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-24T19:06:54Z" | "2007-03-12T14:33:20Z" |
46,907 | Bug 46907 Jasper with log4j in web-app classpath and debug level enabled prevents reading HTTP POST stream from JSP | This is on Tomcat 5.5.x (don't remember the last rev. number, not my current machine). When log4j is in the classpath of the web-app and is configured to log at debug level, Jasper dumps the whole HTTP POST request body as debug traces. This consumes the HttpServletRequest input stream which then arrives unusable for the user at the beginning of the JSP code (using HttpServletRequest.getInputStream(), the stream is already at its end). A workaround is to disable debug traces for Japser class in log4j.properties, but Jasper should not consume the HttpServletRequest input stream whatever mode it runs into. | resolved fixed | 50d0e6e | ["java/org/apache/jasper/servlet/JspServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-23T17:48:56Z" | "2009-03-24T18:40:00Z" |
47,518 | Bug 47518 Valve Interface Javadocs for invoke method references non-existent method | It appears that the Valve interface javadoc hasn't been updated since around TC 5.5. Here is a snip of what it currently available from TC's website (6.0.20 I would guess): " # If the corresponding Response was not generated (and control was not returned, call the next Valve in the pipeline (if there is one) by executing context.invokeNext(). . . . # Modify the HTTP headers included with the Response after the invokeNext() method has returned. # Perform any actions on the output stream associated with the specified Response after the invokeNext() method has returned. " The invokeNext method has not existed in the Valve interface in many versions. I believe the replacement is: this.getNext().invoke(request, response) I'm happy to provide a doc patch if getNext().invoke(request, response) is the expected replacement for invokeNext(request, response). Note that the docs for 5.5 also have the same problem. Please let me know if I should log that separately. | resolved fixed | 9dc93f5 | ["java/org/apache/catalina/Valve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-21T06:24:58Z" | "2009-07-13T10:13:20Z" |
41,059 | Bug 41059 WebAppClassLoader clearReferences code break running threads | When the WebAppClassLoader stops it manually sets all static and final variables to null in the clearReferences method. This results in NPEs for any thread that was not stopped and not expecting its final or static variables to be null. This is particularly a problem with hot deploys since the unload fails and terminating the deploy. | resolved fixed | a9f0239 | ["java/org/apache/catalina/loader/WebappClassLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-17T17:19:59Z" | "2006-11-28T16:06:40Z" |
40,551 | Bug 40551 Sticky sessions using PersistentManager enter indeterminate state on node failover | If a cluster of nodes is being load balanced with sticky sessions, and a particular node becomes unavailable, any sessions bound to that node must be redistributed. Particularly in the case of mod_jk these sessions will not be bound to whichever node the failover occurred on because the jessionid will still contain the JVM route of the original failed node, thus placing the session in an indeterminate state and losing sticky properties. I am attaching a patch that will trigger a session to rebind itself to a new node if the jvmroutes don't match and replace the jessionid in the browser's cookie. | resolved fixed | f0d447d | ["java/org/apache/catalina/ha/session/JvmRouteBinderValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-16T20:07:19Z" | "2006-09-20T05:26:40Z" |
47,515 | Bug 47515 Tomcat can't replicate session when it is started. | null | resolved fixed | 83e98da | ["java/org/apache/catalina/ha/session/DeltaManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-16T14:12:16Z" | "2009-07-13T01:53:20Z" |
40,380 | Bug 40380 Potential syncro problem in StandardSession.expire(boolean) | public void expire(boolean notify) { // Mark this session as "being expired" if needed if (expiring) return; // No man's land here synchronized (this) { if (manager == null) return; expiring = true; | resolved fixed | 6f3e56e | ["java/org/apache/catalina/session/StandardSession.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-14T17:22:47Z" | "2006-09-01T00:20:00Z" |
47,524 | Bug 47524 McastServiceImpl executor is not dispatching events. | null | resolved fixed | aa8a2d3 | ["java/org/apache/catalina/tribes/membership/McastServiceImpl.java", "java/org/apache/catalina/tribes/transport/ReceiverBase.java", "java/org/apache/catalina/tribes/util/ExecutorFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-14T14:46:34Z" | "2009-07-14T11:13:20Z" |
39,231 | Bug 39231 The JAAS contract for LoginModule is broken | The issue is that the custom JAAS's LoginModule.logout() method is never called. I guess this has been never implemented correctly (at least since Tomcat 5.5.9). The thing is that according to the JAAS spec, the LoginContext.logout() is supposed to invoke the logout method for each LoginModule configured for this LoginContext. So, somebody should be sure to call LoginContext.logout() method. The caller for this method could be either a server or a client. So, either Tomcat should provide some means to access the LoginContext to the clients, or Tomcat should take the responsibility to call this method by itself. I guess the solution could be for Tomcat to associate the instance of LoginContext with the user's session, and then Tomcat could invoke LoginContext.logout() when the session is being invalidated (both when the session times out or invalidated explicitely). I hope that I am correctly interpreting the JAAS spec. | resolved fixed | 80f8ec6 | ["java/org/apache/catalina/realm/GenericPrincipal.java", "java/org/apache/catalina/realm/JAASRealm.java", "java/org/apache/catalina/session/StandardSession.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-07T16:33:02Z" | "2006-04-07T00:33:20Z" |
47,478 | Bug 47478 DeltaSession ignores notifyListenersOnReplication when BackupManager is used. | null | resolved fixed | c1099f7 | ["java/org/apache/catalina/ha/session/DeltaSession.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-06T15:45:32Z" | "2009-07-06T06:00:00Z" |
37,933 | Bug 37933 Bugs in Tomcat | null | resolved fixed | 202a33e | ["java/org/apache/jasper/compiler/Generator.java", "java/org/apache/jasper/compiler/PageInfo.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-05T11:30:22Z" | "2005-12-16T10:46:40Z" |
37,984 | Bug 37984 JNDIRealm.java not able to handle MD5 password | I'm using JNDIRealm to authenticate to OpenLDAP 2.2.28. Within OpenLDAP I've configured the userPassword attribute for each user to contain the MD5 digest, and each is prefixed with the string "{MD5}". I am not an LDAP expert by any means but I believe this prefix is a standard convention. Anyway assuming this is a convention then JNDIRealm needs to strip off the "{MD5}" portion much like it does with "{SHA1}". See attached patch which accomplishes this and I verified it works in my environment. | resolved fixed | c6818a0 | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-07-01T22:13:33Z" | "2005-12-21T10:13:20Z" |
47,440 | Bug 47440 Remove DB-specific SQL statements from test cases (SELECT 1) | Some of the test cases assume that the JDBC provider supports "SELECT 1" as a valid SQL statement; however this is not always the case, e.g. Derby requires a table name to select from. The solution provided in the patches is to use the validation query defined in the properties set up for the test, rather than always using "SELECT 1". | resolved fixed | d92da6e | ["modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/CheckOutThreadTest.java", "modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/DefaultProperties.java", "modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/TestSlowQueryReport.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-29T14:36:57Z" | "2009-06-27T08:06:40Z" |
47,439 | Bug 47439 PooledConnection.connect() fails to check for null connection | PooledConnection.connect() fails to check for null return from java.sql.Driver.connect() method. This can result in an NPE when the connection is used later. | resolved fixed | ef96fa2 | ["modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-28T15:58:13Z" | "2009-06-27T08:06:40Z" |
38,352 | Bug 38352 Additional Entries for Default catalina.policy file. | This patch adds additional entries to the catalina.policy file. Specifically: The catalina.base/shared directory is added and given equal permissions to catalina.home/common java.io.tmpdir is now readable. javax.servlet.context.tempdir is now readable. I think to be compliant with the spec, this must be allowed. Directory specified by java.io.tmpdir (which is what tomcat points javax.servlet.context.tempdir to) is now read, write, delete. Again, I think the spec requires this. | resolved fixed | 76a4eb3 | ["java/org/apache/jasper/compiler/JspRuntimeContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-19T13:03:42Z" | "2006-01-23T01:33:20Z" |
47,308 | Bug 47308 Cannot join in the cluster membership. | null | resolved fixed | 51fd68b | ["java/org/apache/catalina/tribes/membership/McastService.java", "java/org/apache/catalina/tribes/membership/McastServiceImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-18T17:08:38Z" | "2009-06-03T06:20:00Z" |
47,389 | Bug 47389 DeltaManager doesn't do the session replication. (notifySessionListenersOnReplication=false) | null | resolved fixed | c768090 | ["java/org/apache/catalina/ha/session/DeltaManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-18T15:27:55Z" | "2009-06-18T07:26:40Z" |
47,369 | Bug 47369 DeltaRequest is never reset. (use BackupManager) | null | resolved fixed | b3e2be4 | ["java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-15T17:35:07Z" | "2009-06-15T07:13:20Z" |
47,343 | Bug 47343 Fails re-deploying, when we update context.xml. | null | resolved fixed | cc1f0dd | ["java/org/apache/catalina/startup/HostConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-11T13:48:42Z" | "2009-06-10T07:46:40Z" |
47,299 | Bug 47299 Cannot override StandardContext in embedding case because of StandardSession.fireContainerEvent | StandardSession.fireContainerEvent checks for the String class name! Why not just use an instanceof check here? | resolved fixed | 468f370 | ["java/org/apache/catalina/session/StandardSession.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-05T21:38:44Z" | "2009-06-02T10:53:20Z" |
47,158 | Bug 47158 I think AccessLogValve has race condition problem | null | resolved fixed | f00029e | ["java/org/apache/catalina/valves/AccessLogValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-06-04T15:36:07Z" | "2009-05-05T19:00:00Z" |
47,216 | Bug 47216 Possible NPE in Http11Processor.action() | The code at around line 1075: } else if (actionCode == ActionCode.ACTION_REQ_LOCAL_ADDR_ATTRIBUTE) { if (localAddr == null) localAddr = socket.getLocalAddress().getHostAddress(); fails to check if "socket != null". Since this is checked everywhere else in the method this is probably a bug. The method Http11Processor.parseHost() also references "socket" without checking for null. Within the class, it is only called by process(Socket), which guarantees that it won't be null. However once process() returns normally, socket will be set to null. The parseHost() method is public, so it may be called when socket == null. Perhaps the parseHost() method should be private? | resolved wontfix | 36feee0 | ["java/org/apache/coyote/http11/Http11Processor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-05-25T11:00:23Z" | "2009-05-18T20:53:20Z" |
47,234 | Bug 47234 serviceStartTime is different in MemberImpl from McastServiceImpl | Hi, I'm using the tribes cluster module in my own application (which has nothing to do with tomcat) and I'm using the member alive time value to sort all the cluster members. This bug produces the following: I have 2 nodes that were started almost at the same time and both nodes claim that the other node was started before them NODE1: Remote members: (-52.63.57.110:4001 ready=true suspect=false failing=false aliveTime=1526) Local member: (-52.63.57.109:4000 ready=true suspect=false failing=false aliveTime=1236) NODE2: Remote members: (-52.63.57.109:4000 ready=true suspect=false failing=false aliveTime=2021) Local member: (-52.63.57.110:4001 ready=true suspect=false failing=false aliveTime=1069) My code do the following: Member[] members = groupChannel.getMembers(); printRemote(members); Member localMember = groupChannel.getLocalMember(true); printLocal(localMember); In that code (due to timing issues) it should possible the other way around (that every node claim to be started before the other) but not that case. The issue occurs because when the McastService is started, it assigns a start time to the local member. public class McastService .... { public void start(int level) { .... localMember.setServiceStartTime(System.currentTimeMillis()); .... impl = new McastServiceImpl(localMember, ....); impl.start(level); } } But, then it creates and starts a McastServiceImpl which also stores a new serviceStartTime :-( public class McastServiceImpl { protected long serviceStartTime; public void start(int level) { .... serviceStartTime = System.currentTimeMillis(); .... } } So, we have 2 different start times. Unfortunately both times are used: To get the local member, the impl.getServiceStartTime() is used: public class McastService .... { public Member getLocalMember(boolean alive) { if ( alive && localMember != null && impl != null) localMember.setMemberAliveTime(System.currentTimeMillis()-impl.getServiceStartTime()); return localMember; } } But, when the member is transmited throw the network, the MemberImpl.getServiceStartTime() is used. public class MemberImpl .... { public byte[] getData(boolean getalive, boolean reset) { if ( reset ) dataPkg = null; //look in cache first if ( dataPkg!=null ) { if ( getalive ) { //you'd be surprised, but System.currentTimeMillis //shows up on the profiler long alive=System.currentTimeMillis()-getServiceStartTime(); XByteBuffer.toBytes( (long) alive, dataPkg, TRIBES_MBR_BEGIN.length+4); } return dataPkg; } ...... } That produces that weird behaviour. IMHO, the fix should be setting the same "serviceStartTime" to both components. This issue is affecting seriously my code. I would appreciate if you could fix it asap. I've verified that the same code is present in trunk repository. Regards, Ariel | resolved fixed | 9fa7640 | ["java/org/apache/catalina/tribes/membership/McastServiceImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-05-21T18:35:40Z" | "2009-05-21T12:46:40Z" |
47,111 | Bug 47111 do caching the resources like the docu say it (StringManager) | null | resolved wontfix | 96167ed | ["java/org/apache/tomcat/util/res/StringManager.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-05-02T23:36:24Z" | "2009-04-28T12:00:00Z" |
47,050 | Bug 47050 StandardHostValve.status unnecessarily HTML-escapes the error message | null | resolved fixed | 1ad0501 | ["java/org/apache/catalina/core/StandardHostValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-05-01T15:34:43Z" | "2009-04-19T05:46:40Z" |
47,046 | Bug 47046 Shutdown does not unregister all MBeans | null | resolved fixed | 54b9da9 | ["java/org/apache/catalina/connector/MapperListener.java", "java/org/apache/catalina/mbeans/MBeanUtils.java", "java/org/apache/catalina/mbeans/ServerLifecycleListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-29T22:47:53Z" | "2009-04-17T12:06:40Z" |
46,925 | Bug 46925 Nested groups in JNDI realm with non-recursive implementation | null | resolved fixed | d04dd88 | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-27T18:54:55Z" | "2009-03-27T07:46:40Z" |
37,929 | Bug 37929 invalidated session causes pageContext methods to fail | javax.servlet.http.HttpSession methods such as getAttribute(), getValue(), getAttributeNames(), getValueNames(), etc, throw an IllegalStateException if called on a session that has been invalidated. So, with the following code in a JSP page: <% session.invalidate(); Object obj = pageContext.findAttribute("foo"); %> An IllegalStateException is thrown because pageContext.findAttribute() eventually calls session.getAttribute() on a session that has been invalidated. The session that has been invalidated should simply be ignored when a method needs to process the various scopes (page, request, session, application). This impacts the following methods in PageContextImpl: public int getAttributesScope(final String name) which calls -> private int doGetAttributeScope(String name); public Object findAttribute(final String name) which calls -> private Object doFindAttribute(String name); public void removeAttribute(final String name) which calls -> private void doRemoveAttribute(String name); The fix is to catch IllegalStateException and ignore it when processing the attribute in session scope. The code then simply follows through to process application scope. No need to worry about setAttribute() because it is always invoked on a specific scope, and the spec already states that java.lang.IllegalStateException must be thrown when called on an invalidated session. pageContext.setAttribute("foo", "value of foo", PageContext.SESSION_SCOPE); java.lang.IllegalStateException - if the scope is PageContext.SESSION_SCOPE but the page that was requested does not participate in a session or the session has been invalidated. --------------------------------------------------------------------------- At the same time, a fix should be done to method "doRemoveAttribute(String name)" where a try/catch block for Exception appears unnecessary. private void doRemoveAttribute(String name){ try { removeAttribute(name, PAGE_SCOPE); removeAttribute(name, REQUEST_SCOPE); if( session != null ) { try { removeAttribute(name, SESSION_SCOPE); } catch (IllegalStateException ex) { // Session has been invalidated. // Ignore and fall through to application scope. } } removeAttribute(name, APPLICATION_SCOPE); } catch (Exception ex) { // we remove as much as we can, and // simply ignore possible exceptions } } Here is a full analysis: Starting with 'removeAttribute(final String name)' - we check for null and throw NPE if necessary - we call doRemoveAttribute(name) doRemoveAttribute(name) - we call removeAttribute(name, scope) for each scope removeAttribute(final String name, final int scope) - this calls doRemoveAttribute(name, scope) doRemoveAttribute(name, scope) - page scope: attributes.remove -> won't throw an Exception - request scope: request.removeAttribute -> no documented Exception thrown - session scope: throws IllegalStateException if session is null - app scope: context.removeAttribute -> no documented Exception thrown A null value for name is already checked in removeAttribute(final String name) and we throw NPE. So this situation (removing an attr from page or request scope throwing an NPE) won't happen. In doRemoveAttribute(name), we already check on session != null before calling removeAttribute(name, SESSION_SCOPE). So there normally is no IllegalStateException thrown (except for the invalidated case). When removing an attribute from application (i.e., ServletContext) scope, any registered listeners will be notified, but the code that does that (see appserv-webtier/src/java/org/apache/catalina/core/ApplicationContext. removeAttribute()) already catches any Throwable that a listener may throw. The try/catch block is therefore unnecessary. Moreover, if any of the removal actions from the different scopes could have thrown an exception, each of them would have needed to be wrapped inside their own try/catch, so as to ensure that an exception in one scope does not cause any of the subsequent removals to be bypassed. doRemoveAttribute(String name) has therefore been modified as follows: private void doRemoveAttribute(String name){ removeAttribute(name, PAGE_SCOPE); removeAttribute(name, REQUEST_SCOPE); if( session != null ) { try { removeAttribute(name, SESSION_SCOPE); } catch (IllegalStateException ex) { // Session has been invalidated. // Ignore and fall through to application scope. } } removeAttribute(name, APPLICATION_SCOPE); } -------------------------- Changes done on glassfish. ymmv on jasper for the diffs. --- PageContextImpl.java 9 Dec 2005 18:54:30 -0000 1.7 +++ PageContextImpl.java 16 Dec 2005 00:11:21 -0000 1.8 @@ -452,8 +452,13 @@ return REQUEST_SCOPE; if (session != null) { + try { if (session.getAttribute(name) != null) return SESSION_SCOPE; + } catch (IllegalStateException ex) { + // Session has been invalidated. + // Ignore and fall through to application scope. + } } if (context.getAttribute(name) != null) @@ -495,9 +500,14 @@ return o; if (session != null) { + try { o = session.getAttribute(name); - if (o != null) - return o; + } catch (IllegalStateException ex) { + // Session has been invalidated. + // Ignore and fall through to application scope. + } + + if (o != null) return o; } return context.getAttribute(name); @@ -559,19 +569,18 @@ } } - private void doRemoveAttribute(String name){ - try { removeAttribute(name, PAGE_SCOPE); removeAttribute(name, REQUEST_SCOPE); if( session != null ) { + try { removeAttribute(name, SESSION_SCOPE); + } catch (IllegalStateException ex) { + // Session has been invalidated. + // Ignore and fall through to application scope. } - removeAttribute(name, APPLICATION_SCOPE); - } catch (Exception ex) { - // we remove as much as we can, and - // simply ignore possible exceptions } + removeAttribute(name, APPLICATION_SCOPE); } public JspWriter getOut() { | resolved fixed | 04cacaf | ["java/org/apache/jasper/runtime/PageContextImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-16T15:16:43Z" | "2005-12-16T08:00:00Z" |
47,013 | Bug 47013 JSP not compiled at startup when used as a servlet | null | resolved fixed | c8cbc28 | ["java/org/apache/catalina/core/Constants.java", "java/org/apache/catalina/core/StandardWrapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-14T22:16:53Z" | "2009-04-10T13:26:40Z" |
42,579 | Bug 42579 [Patch] JNDIRealm fails to parse absolute names | Active Directory can respond to a query with SearchResult's that are not relative. We discovered this happening with a directory hosted across many servers when the userBase was not sufficient to identify a single server. In getUserBySearch, JNDIRealm assumes that the SearchResult is relative and goes about creating a DN for the user by appending together the various bits of names it gets back. This is definitely wrong for absolute names which are URL's of the form: ldap://server/encoded_user_dn I discovered this issue in Tomcat 5.5 and a cursory look at the SVN repo for Tomcat 6.0 reveals that this bug is also present there. I have a patch for this issue which I will attach. | resolved fixed | 90e8d0d | ["java/org/apache/catalina/realm/JNDIRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-09T15:45:30Z" | "2007-06-04T18:00:00Z" |
46,354 | Bug 46354 LIMIT_BUFFER setting causes arraycopy errors | null | resolved fixed | 78a994a | ["java/org/apache/jasper/runtime/BodyContentImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-09T15:11:46Z" | "2008-12-05T15:13:20Z" |
46,984 | Bug 46984 Server incorrectly reports a 501 error on bad method name. Should report 400 error. | null | resolved fixed | 42a093b | ["java/org/apache/coyote/http11/Http11AprProcessor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java", "java/org/apache/coyote/http11/Http11Processor.java", "java/org/apache/coyote/http11/InternalAprInputBuffer.java", "java/org/apache/coyote/http11/InternalInputBuffer.java", "java/org/apache/coyote/http11/InternalNioInputBuffer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-09T13:54:05Z" | "2009-04-07T10:26:40Z" |
46,961 | Bug 46961 org.apache.catalina.loader.WebappClassLoader throws exception related to Java 6 Bug 6434149 | null | resolved fixed | f109fb9 | ["java/org/apache/catalina/loader/WebappClassLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-09T12:54:09Z" | "2009-04-03T12:00:00Z" |
46,909 | Bug 46909 <jsp:plugin> error | <jsp:plugin type="applet"> generates type="application/x-java-applet;" instead of type = "application/x-java-applet". Firefox with Java-plugin cannot display Java applets because ";" is added. | resolved fixed | 80b90ee | ["java/org/apache/jasper/compiler/Generator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2009-04-09T11:46:13Z" | "2009-03-25T05:46:40Z" |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.