# Import python libs
import logging

# Import salt libs
import salt.utils

log = logging.getLogger(__name__)


def held(name):
    '''
    Set package in 'hold' state, meaning it will not be upgraded.

    name
        The name of the package, e.g., 'tmux'
    '''
    ret = {'name': name}
    state = __salt__['pkg.get_selections'](
        pattern=name,
    )
    if not state:
        ret.update({'changes': {},
                    'result': False,
                    'comment': 'Package {0} does not have a state'.format(
                        name
                    )})
        return ret
    if not salt.utils.is_true(state.get('hold', False)):
        if not __opts__['test']:
            result = __salt__['pkg.set_selections'](
                selection={'hold': [name]}
            )
            ret.update({'changes': result[name],
                        'result': True,
                        'comment': 'Package {0} is now being held'.format(
                            name
                        )})
        else:
            ret.update({'changes': {},
                        'result': None,
                        'comment': 'Package {0} is set to be held'.format(
                            name
                        )})
    else:
        ret.update({'changes': {},
                    'result': True,
                    'comment': 'Package {0} is already held'.format(name)})

    return ret

# Import python libs
import logging

# Import salt libs
import salt.utils

log = logging.getLogger(__name__)


def held(name):
    '''
    Set package in 'hold' state, meaning it will not be upgraded.

    name
        The name of the package, e.g., 'tmux'
    '''
    ret = {'name': name, 'changes': {}, 'result': False, 'comment': ''}
    state = __salt__['pkg.get_selections'](
        pattern=name,
    )
    if not state:
        ret.update(comment='Package {0} does not have a state'.format(name))
        return ret
    if not salt.utils.is_true(state.get('hold', False)):
        if not __opts__['test']:
            result = __salt__['pkg.set_selections'](
                selection={'hold': [name]}
            )
            ret.update(changes=result[name],
                       result=True,
                       comment='Package {0} is now being held'.format(name))
        else:
            ret.update(result=None,
                       comment='Package {0} is set to be held'.format(name))
    else:
        ret.update(result= True,
                   comment='Package {0} is already held'.format(name))

    return ret

Make dict updates more dense
Make dict updates more dense
