# PL1 - Byzantine Generals
------

## Rubrics

|                                     | Sprint 4   |           |                |                       |                |            |
|-------------------------------------|------------|-----------|----------------|-----------------------|----------------|------------|
|                                     | User Story |           |                | Learning From History |                |            |
| Group                               | Definition | Splitting | Responsibility | Estimation            | Prioritisation | Reflection |
| PL1 (Byzantine Generals)            | 9          | 10        | 8              | 8                     | 9              | 8          |

|                                     | Code Evolution Quality 4 |         |                     |                  |         |          |                        |         |         |                        |             |
|-------------------------------------|--------------------------|---------|---------------------|------------------|---------|----------|------------------------|---------|---------|------------------------|-------------|
|                                     | Architecture             |         |                     | Code Readability |         |          | Continuous Integration |         |         | Pull-based Development |             |
| Group                               | Changes                  | Arch-DD | Code Change Quality | Change           | Quality | Comments | Building               | Testing | Tooling | Branching              | Code Review |
| PL1 (Byzantine Generals)            | 2                        | 5       | 9                   | 9                | 10      | 9        | 9                      | 10      | 5       | 10                     | 8           |


## Notes
sprint:
-Definition: split devise and implementation
-Responsibility: Not everybody has important tasks (While Ali spends 24 hours on an A)

Reflection:
-Prioritisation: Test coverage/refactoring has an A?
-Reflection: Good analysis, should have more problems

EAD:
-no new version
-should implement previous feedback

EAD-changes:
-great amount of refactoring/restructuring, none of which documented in the EAD

Readability:
-Comments should sometimes be more specific, see Subject interface and such

CI:
-The Travis button is a png?

Tooling:
-Findbugs, PMD, CPD and Checkstyle issues
Add feedback for sprint 4
Add feedback for sprint 4
