===============
Uploading Diffs
===============

A review request's diff can be updated by clicking :guilabel:`Upload Diff`
or :guilabel:`Update Diff` on the action bar. It will present a dialog much
like the New Review Request page.

.. image:: upload-diff-dialog.png

See :ref:`review-requests-for-diffs` for more information on the fields.


.. note:: It's usually best to use :ref:`post-review` or another tool
          to update a diff, instead of uploading using this dialog.
          This will help guarantee a valid diff, and works around problems
          in some diff formats.


.. comment: vim: ft=rst et ts=3

===============
Uploading Diffs
===============

A review request's diff can be updated by clicking :guilabel:`Upload Diff`
or :guilabel:`Update Diff` on the action bar. It will present a dialog much
like the New Review Request page.

.. image:: upload-diff-dialog.png

See :ref:`review-requests-for-diffs` for more information on the fields.

.. note:: When updating the diff on a review request, you need to upload a
          full diff between the upstream code (what's present in the
	  repository) and your change. You can't just upload a diff of the
	  changes since the previous diff.

.. note:: It's usually best to use :ref:`post-review` or another tool
          to update a diff, instead of uploading using this dialog.
          This will help guarantee a valid diff, and works around problems
          in some diff formats.


.. comment: vim: ft=rst et ts=3

Clarify in the docs that you need to upload full diffs.
Clarify in the docs that you need to upload full diffs.

When updating an existing review request, some people try to upload just the
incremental diff from their previous change, which doesn't work. Clarify in the
docs how to do this.

Testing done: Built HTML docs.
Reviewed at https://reviews.reviewboard.org/r/4831/
Fixes bug 2899.
