#!/usr/bin/env bash

#Copyright 2018 The CDI Authors.
#
#Licensed under the Apache License, Version 2.0 (the "License");
#you may not use this file except in compliance with the License.
#You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
#Unless required by applicable law or agreed to in writing, software
#distributed under the License is distributed on an "AS IS" BASIS,
#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#See the License for the specific language governing permissions and
#limitations under the License.

# NOTE: Not using pipefail because gofmt returns 0 when it finds
# suggestions and 1 when files are clean

source hack/build/config.sh
source hack/build/common.sh

LINTABLE=(pkg cmd tests tools)
ec=0
out="$(gofmt -l -s ${SOURCE_DIRS} | grep ".*\.go")"
if [[ ${out} ]]; then
    echo "FAIL: Format errors found in the following files:"
    echo "${out}"
    ec=1
fi
for p in "${LINTABLE[@]}"; do
  echo "running golint on directory: ${p}"
  out="$(golint ${p}/...)"
  if [[ ${out} ]]; then
    echo "FAIL: following golint errors found:"
    echo "${out}"
    ec=1
  fi
done

#echo "running golint on the pkg directory (golint pkg/...)"
#out="$(golint pkg/...)"
#if [[ ${out} ]]; then
#    echo "FAIL: following golint errors found:"
#    echo "${out}"
#    ec=1
#fi

exit ${ec}

#!/usr/bin/env bash

#Copyright 2018 The CDI Authors.
#
#Licensed under the Apache License, Version 2.0 (the "License");
#you may not use this file except in compliance with the License.
#You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
#Unless required by applicable law or agreed to in writing, software
#distributed under the License is distributed on an "AS IS" BASIS,
#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#See the License for the specific language governing permissions and
#limitations under the License.

# NOTE: Not using pipefail because gofmt returns 0 when it finds
# suggestions and 1 when files are clean

source hack/build/config.sh
source hack/build/common.sh

LINTABLE=(pkg cmd tests tools)
ec=0
out="$(gofmt -l -s ${SOURCE_DIRS} | grep ".*\.go")"
if [[ ${out} ]]; then
    echo "FAIL: Format errors found in the following files:"
    echo "${out}"
    ec=1
fi
for p in "${LINTABLE[@]}"; do
  echo "running golint on directory: ${p}"
  out="$(golint ${p}/...)"
  if [[ ${out} ]]; then
    echo "FAIL: following golint errors found:"
    echo "${out}"
    ec=1
  fi
done

exit ${ec}

Remove old commented out lintcheck code
Remove old commented out lintcheck code

Remove the commented out code in run-lint-checks.sh, this was leftover
from when we were only linting the pkg directory, we've now extended
that out to the other .go folders in the project and this was commented
out but should've been removed.
