# frozen_string_literal: true

module Gitlab
  module Database
    module Subquery
      class << self
        def self_join(relation)
          t = relation.arel_table
          # Work around a bug in Rails 5, where LIMIT causes trouble
          # See https://gitlab.com/gitlab-org/gitlab-ce/issues/51729
          r = relation.limit(nil).arel
          r.take(relation.limit_value) if relation.limit_value
          t2 = r.as('t2')

          relation.unscoped.joins(t.join(t2).on(t[:id].eq(t2[:id])).join_sources.first)
        end
      end
    end
  end
end

# frozen_string_literal: true

module Gitlab
  module Database
    module Subquery
      class << self
        def self_join(relation)
          t = relation.arel_table
          t2 = relation.arel.as('t2')

          relation.unscoped.joins(t.join(t2).on(t[:id].eq(t2[:id])).join_sources.first)
        end
      end
    end
  end
end

Revert "Workaround for Rails 5, where LIMIT..."
Revert "Workaround for Rails 5, where LIMIT..."

This reverts commit 6823e7defb45dfd86d5258b40d6f82482d1ef451.

Originally implemented in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21839, but an
error was reported in
https://gitlab.com/gitlab-org/gitlab-ce/issues/51729 resulting in a
workaround introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21879.

Now Rails 5.2 is used, this workaround no longer seems needed, so this
reverts it.
