# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for string conversion in string interpolation,
      # which is redundant.
      #
      # @example
      #
      #   # bad
      #
      #   "result is #{something.to_s}"
      #
      # @example
      #
      #   # good
      #
      #   "result is #{something}"
      class StringConversionInInterpolation < Cop
        MSG_DEFAULT = 'Redundant use of `Object#to_s` in interpolation.'.freeze
        MSG_SELF = 'Use `self` instead of `Object#to_s` in ' \
                   'interpolation.'.freeze

        def on_dstr(node)
          node.each_child_node(:begin) do |begin_node|
            final_node = begin_node.children.last

            next unless final_node && final_node.send_type? &&
                        final_node.method?(:to_s) && !final_node.arguments?

            add_offense(final_node, location: :selector)
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            receiver, _method_name, *_args = *node
            corrector.replace(
              node.source_range,
              if receiver
                receiver.source
              else
                'self'
              end
            )
          end
        end

        private

        def message(node)
          node.receiver ? MSG_DEFAULT : MSG_SELF
        end
      end
    end
  end
end

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for string conversion in string interpolation,
      # which is redundant.
      #
      # @example
      #
      #   # bad
      #
      #   "result is #{something.to_s}"
      #
      # @example
      #
      #   # good
      #
      #   "result is #{something}"
      class StringConversionInInterpolation < Cop
        MSG_DEFAULT = 'Redundant use of `Object#to_s` in interpolation.'.freeze
        MSG_SELF = 'Use `self` instead of `Object#to_s` in ' \
                   'interpolation.'.freeze

        def_node_matcher :to_s_without_args?, '(send _ :to_s)'

        def on_dstr(node)
          node.each_child_node(:begin) do |begin_node|
            final_node = begin_node.children.last

            next unless to_s_without_args?(final_node)

            add_offense(final_node, location: :selector)
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            receiver = node.receiver
            corrector.replace(
              node.source_range,
              if receiver
                receiver.source
              else
                'self'
              end
            )
          end
        end

        private

        def message(node)
          node.receiver ? MSG_DEFAULT : MSG_SELF
        end
      end
    end
  end
end

Use node_matcher for better readability
Use node_matcher for better readability
