
require 'color'
require 'set/color_set'

class RainbowSet < ColorSet

  def initialize(length = DEFAULT_LENGTH, type = DEFAULT_TYPE)
    super(length, type)
    @frequency = Math::PI / @length
  end

  def next_frame
    @frame_count += 1
  end

  def frame
    next_frame
    set = []

    @length.times do |i|
      set << pixel(i)
    end

    set += set.reverse if type == :double

    set
  end

  def pixel(number, frame = @frame_count)
    number = @length - number if number >= @length
    Color.new(
        (Math.sin(@frequency*(number+frame) + 0)**2 * 127),
        (Math.sin(@frequency*(number+frame) + 2.0*Math::PI/3.0)**2 * 127),
        (Math.sin(@frequency*(number+frame) + 4.0*Math::PI/3.0)**2 * 127)
    )
  end

end

require 'color'
require 'set/color_set'

class RainbowSet < ColorSet

  def initialize(length = DEFAULT_LENGTH, type = DEFAULT_TYPE)
    super(length, type)
    @frequency = Math::PI / @length
  end

  def next_frame
    @frame_count += 1
  end

  def frame
    next_frame
    set = []

    @length.times do |i|
      set << pixel(i)
    end

    set += set.reverse if type == :double

    set
  end

  def pixel(number)
    number = @length - number if number >= @length
    x = @frequency*(number+@frame_count)
    Color.new(
        (Math.sin(x)**2 * 127),
        (Math.sin(x + 2.0*Math::PI/3.0)**2 * 127),
        (Math.sin(x + 4.0*Math::PI/3.0)**2 * 127)
    )
  end

end
Remove obsolete frame parameter, calculate x only once
[REFACTORING] Remove obsolete frame parameter, calculate x only once
