# -*- coding: utf-8 -*-
# Copyright 2014 TIS Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
require 'sinatra/activerecord'

class ApplicationHistory < ActiveRecord::Base
  before_save :allocate_version
  before_save :serf_request, if: -> { new_record? }

  belongs_to :application

  validates :application, presence: true
  validates :uri, presence: true, format: { with: URI.regexp }

  validates_each :parameters do |record, attr, value|
    begin
      JSON.parse(value) unless value.nil?
    rescue JSON::ParserError
      record.errors.add(attr, 'is malformed or invalid json string')
    end
  end

  def allocate_version
    self.version = application.histories.count + 1
  end

  def serf_request
    payload = {}
    payload[:url] = uri
    payload[:revision] = revision
    payload[:parameters] = JSON.parse(parameters)

    application.system.serf.call('event', 'deploy', payload)
  end
end

# -*- coding: utf-8 -*-
# Copyright 2014 TIS Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
require 'sinatra/activerecord'

class ApplicationHistory < ActiveRecord::Base
  before_create :allocate_version
  before_create :serf_request

  belongs_to :application

  validates :application, presence: true
  validates :uri, presence: true, format: { with: URI.regexp }

  validates_each :parameters do |record, attr, value|
    begin
      JSON.parse(value) unless value.nil?
    rescue JSON::ParserError
      record.errors.add(attr, 'is malformed or invalid json string')
    end
  end

  def allocate_version
    self.version = application.histories.count + 1
  end

  def serf_request
    payload = {}
    payload[:url] = uri
    payload[:revision] = revision
    payload[:parameters] = JSON.parse(parameters)

    application.system.serf.call('event', 'deploy', payload)
  end
end

Change timing to call callback from before_save to before_create
Change timing to call callback from before_save to before_create
