<p dir="auto">I am testing the latest VS Code insiders build (Version 0.10.10-insider (0.10.10-insider)). With the introduction of the new Salsa JS language service, "Goto symbol" no longer works for JS files with old module pattern (anonymous closure) or with AMD modules. I understand that, as documented, Salsa can't resolve AMD references, but it should recognise the symbols inside the file.</p>
<p dir="auto">Here's an example how it works in the latest stable build:</p>
<p dir="auto"><a target="_blank" rel="noopener noreferrer nofollow" href="https://cloud.githubusercontent.com/assets/10324676/13567580/b645f394-e464-11e5-9499-801bb63e52ec.png"><img src="https://cloud.githubusercontent.com/assets/10324676/13567580/b645f394-e464-11e5-9499-801bb63e52ec.png" alt="screen shot 2016-03-07 at 12 57 55" style="max-width: 100%;"></a></p>
<p dir="auto">and here's with Salsa:</p>
<p dir="auto"><a target="_blank" rel="noopener noreferrer nofollow" href="https://cloud.githubusercontent.com/assets/10324676/13567577/b413af4e-e464-11e5-8607-a3e1f3225c5c.png"><img src="https://cloud.githubusercontent.com/assets/10324676/13567577/b413af4e-e464-11e5-8607-a3e1f3225c5c.png" alt="screen shot 2016-03-07 at 12 57 37" style="max-width: 100%;"></a></p>
<p dir="auto"><em>From <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/warpdesign/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/warpdesign">@warpdesign</a> on February 17, 2016 11:21</em></p>
<p dir="auto">I have activated salsa and when activated, some symbols cannot be found anymore in ES5 files.</p>
<p dir="auto">For example, if I have a a file with only:</p>
<div class="snippet-clipboard-content notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="function toto() {
}"><pre class="notranslate"><code class="notranslate">function toto() {
}
</code></pre></div>
<p dir="auto">Typing <code class="notranslate">@toto</code>will work and highlight the toto function.</p>
<p dir="auto">But if I wrap the code into a closure, it doesn't work anymore:</p>
<p dir="auto"><a target="_blank" rel="noopener noreferrer nofollow" href="https://cloud.githubusercontent.com/assets/199648/13107988/b5b09720-d570-11e5-8e1a-9a00e8c5984b.jpg"><img src="https://cloud.githubusercontent.com/assets/199648/13107988/b5b09720-d570-11e5-8e1a-9a00e8c5984b.jpg" alt="salsa" style="max-width: 100%;"></a></p>
<p dir="auto">Without salsa, it works as expected, highlighting the toto function even if it is wrapped into a closure.</p>
<p dir="auto">Code 0.10.8<br>
Windows 10</p>
<p dir="auto"><em>Copied from original issue: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="134253446" data-permission-text="Title is private" data-url="https://github.com/microsoft/vscode/issues/3079" data-hovercard-type="issue" data-hovercard-url="/microsoft/vscode/issues/3079/hovercard" href="https://github.com/microsoft/vscode/issues/3079">microsoft/vscode#3079</a></em></p>