instruction
stringclasses 1
value | output
stringlengths 64
69.4k
| input
stringlengths 205
32.4k
|
|---|---|---|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private void readCursorFile() throws IOException {
BufferedReader fileCursorReader = null;
try {
fileCursorReader = new BufferedReader(new FileReader(getFileName(fileCursor)));
String line;
//read the last number
while ((line = fileCursorReader.readLine()) != null) {
cursor = new AtomicInteger(NumberUtils.toInt(line));
}
} finally {
if (fileCursorReader != null) {
IOUtils.closeQuietly(fileCursorReader);
}
}
}
|
#vulnerable code
private void readCursorFile() throws IOException {
BufferedReader fileCursorReader = null;
try {
new BufferedReader(new FileReader(getFileName(fileCursor)));
String line;
//read the last number
while ((line = fileCursorReader.readLine()) != null) {
cursor = new AtomicInteger(NumberUtils.toInt(line));
}
} finally {
if (fileCursorReader != null) {
IOUtils.closeQuietly(fileCursorReader);
}
}
}
#location 7
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private void readCursorFile() throws IOException {
BufferedReader fileCursorReader = null;
try {
fileCursorReader = new BufferedReader(new FileReader(getFileName(fileCursor)));
String line;
//read the last number
while ((line = fileCursorReader.readLine()) != null) {
cursor = new AtomicInteger(NumberUtils.toInt(line));
}
} finally {
if (fileCursorReader != null) {
IOUtils.closeQuietly(fileCursorReader);
}
}
}
|
#vulnerable code
private void readCursorFile() throws IOException {
BufferedReader fileCursorReader = null;
try {
new BufferedReader(new FileReader(getFileName(fileCursor)));
String line;
//read the last number
while ((line = fileCursorReader.readLine()) != null) {
cursor = new AtomicInteger(NumberUtils.toInt(line));
}
} finally {
if (fileCursorReader != null) {
IOUtils.closeQuietly(fileCursorReader);
}
}
}
#location 4
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void testGetHtmlCharset() throws Exception {
HttpServer server = httpserver(12306);
server.get(by(uri("/header"))).response(header("Content-Type", "text/html; charset=gbk"));
server.get(by(uri("/meta4"))).response(with(text("<html>\n" +
" <head>\n" +
" <meta charset='gbk'/>\n" +
" </head>\n" +
" <body></body>\n" +
"</html>")),header("Content-Type",""));
server.get(by(uri("/meta5"))).response(with(text("<html>\n" +
" <head>\n" +
" <meta http-equiv=\"Content-Type\" content=\"text/html; charset=gbk\" />\n" +
" </head>\n" +
" <body></body>\n" +
"</html>")),header("Content-Type",""));
Runner.running(server, new Runnable() {
@Override
public void run() {
String charset = getCharsetByUrl("http://127.0.0.1:12306/header");
assertEquals(charset, "gbk");
charset = getCharsetByUrl("http://127.0.0.1:12306/meta4");
assertEquals(charset, "gbk");
charset = getCharsetByUrl("http://127.0.0.1:12306/meta5");
assertEquals(charset, "gbk");
}
private String getCharsetByUrl(String url) {
HttpClientDownloader downloader = new HttpClientDownloader();
Site site = Site.me();
CloseableHttpClient httpClient = new HttpClientGenerator().getClient(site);
// encoding in http header Content-Type
Request requestGBK = new Request(url);
CloseableHttpResponse httpResponse = null;
try {
httpResponse = httpClient.execute(downloader.getHttpUriRequest(requestGBK, site, null));
} catch (IOException e) {
e.printStackTrace();
}
String charset = null;
try {
byte[] contentBytes = IOUtils.toByteArray(httpResponse.getEntity().getContent());
charset = downloader.getHtmlCharset(httpResponse,contentBytes);
} catch (IOException e) {
e.printStackTrace();
}
return charset;
}
});
}
|
#vulnerable code
@Test
public void testGetHtmlCharset() throws IOException {
HttpClientDownloader downloader = new HttpClientDownloader();
Site site = Site.me();
CloseableHttpClient httpClient = new HttpClientGenerator().getClient(site);
// encoding in http header Content-Type
Request requestGBK = new Request("http://sports.163.com/14/0514/13/9S7986F300051CA1.html#p=9RGQDGGH0AI90005");
CloseableHttpResponse httpResponse = httpClient.execute(downloader.getHttpUriRequest(requestGBK, site, null));
String charset = downloader.getHtmlCharset(httpResponse);
assertEquals(charset, "GBK");
// encoding in meta
Request requestUTF_8 = new Request("http://preshing.com/");
httpResponse = httpClient.execute(downloader.getHttpUriRequest(requestUTF_8, site, null));
charset = downloader.getHtmlCharset(httpResponse);
assertEquals(charset, "utf-8");
}
#location 5
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
protected void checkComponent() {
if (downloader == null) {
this.downloader = new HttpClientDownloader();
}
if (pipelines.isEmpty()) {
pipelines.add(new ConsolePipeline());
}
downloader.setThread(threadNum);
}
|
#vulnerable code
protected void checkComponent() {
if (downloader == null) {
this.downloader = new HttpClientDownloader();
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void run() {
if (!stat.compareAndSet(STAT_INIT, STAT_RUNNING)
&& !stat.compareAndSet(STAT_STOPPED, STAT_RUNNING)) {
throw new IllegalStateException("Spider is already running!");
}
checkComponent();
if (startUrls != null) {
for (String startUrl : startUrls) {
scheduler.push(new Request(startUrl), this);
}
startUrls.clear();
}
Request request = scheduler.poll(this);
//single thread
if (threadNum <= 1) {
while (request != null && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
processRequest(request);
request = scheduler.poll(this);
}
} else {
synchronized (this) {
this.executorService = ThreadUtils.newFixedThreadPool(threadNum);
}
//multi thread
final AtomicInteger threadAlive = new AtomicInteger(0);
while (true && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
if (request == null) {
//when no request found but some thread is alive, sleep a while.
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
processRequest(requestFinal);
threadAlive.decrementAndGet();
}
});
}
request = scheduler.poll(this);
if (threadAlive.get() == 0) {
request = scheduler.poll(this);
if (request == null) {
break;
}
}
}
executorService.shutdown();
}
stat.compareAndSet(STAT_RUNNING, STAT_STOPPED);
//release some resources
destroy();
}
|
#vulnerable code
@Override
public void run() {
if (!stat.compareAndSet(STAT_INIT, STAT_RUNNING)
&& !stat.compareAndSet(STAT_STOPPED, STAT_RUNNING)) {
throw new IllegalStateException("Spider is already running!");
}
checkComponent();
if (startUrls != null) {
for (String startUrl : startUrls) {
scheduler.push(new Request(startUrl), this);
}
startUrls.clear();
}
Request request = scheduler.poll(this);
//single thread
if (executorService == null) {
while (request != null && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
processRequest(request);
request = scheduler.poll(this);
}
} else {
//multi thread
final AtomicInteger threadAlive = new AtomicInteger(0);
while (true && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
if (request == null) {
//when no request found but some thread is alive, sleep a while.
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
processRequest(requestFinal);
threadAlive.decrementAndGet();
}
});
}
request = scheduler.poll(this);
if (threadAlive.get() == 0) {
request = scheduler.poll(this);
if (request == null) {
break;
}
}
}
executorService.shutdown();
}
stat.compareAndSet(STAT_RUNNING, STAT_STOPPED);
//release some resources
destroy();
}
#location 50
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void testRemovePadding() throws Exception {
String name = new Json(text).removePadding("callback").jsonPath("$.name").get();
assertThat(name).isEqualTo("json");
}
|
#vulnerable code
@Test
public void testRemovePadding() throws Exception {
String name = new Json(text).removePadding("callback").jsonPath("$.name").get();
assertThat(name).isEqualTo("json");
Page page = null;
page.getJson().jsonPath("$.name").get();
page.getJson().removePadding("callback").jsonPath("$.name").get();
}
#location 7
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void setThread(int thread) {
poolSize = thread;
}
|
#vulnerable code
@Override
public void setThread(int thread) {
poolSize = thread;
httpClientPool = new HttpClientPool(thread);
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
protected void pushWhenNoDuplicate(Request request, Task task) {
/* if (!inited.get()) {
init(task);
}*/
queue.add(request);
fileUrlWriter.println(request.getUrl());
}
|
#vulnerable code
@Override
protected void pushWhenNoDuplicate(Request request, Task task) {
if (!inited.get()) {
init(task);
}
queue.add(request);
fileUrlWriter.println(request.getUrl());
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = new HashSet<Integer>();
acceptStatCode.add(200);
}
logger.info("downloading page " + request.getUrl());
HttpGet httpGet = new HttpGet(request.getUrl());
if (headers != null) {
for (Map.Entry<String, String> headerEntry : headers.entrySet()) {
httpGet.addHeader(headerEntry.getKey(), headerEntry.getValue());
}
}
CloseableHttpResponse httpResponse = null;
try {
httpResponse = getHttpClient(site).execute(httpGet);
int statusCode = httpResponse.getStatusLine().getStatusCode();
if (acceptStatCode.contains(statusCode)) {
//charset
if (charset == null) {
String value = httpResponse.getEntity().getContentType().getValue();
charset = UrlUtils.getCharset(value);
}
return handleResponse(request, charset, httpResponse, task);
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
return null;
} finally {
try {
if (httpResponse != null) {
httpResponse.close();
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
|
#vulnerable code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
int retryTimes = 0;
Set<Integer> acceptStatCode;
String charset = null;
Map<String,String> headers = null;
if (site != null) {
retryTimes = site.getRetryTimes();
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = new HashSet<Integer>();
acceptStatCode.add(200);
}
logger.info("downloading page " + request.getUrl());
HttpClient httpClient = getHttpClientPool().getClient(site);
try {
HttpGet httpGet = new HttpGet(request.getUrl());
if (headers!=null){
for (Map.Entry<String, String> headerEntry : headers.entrySet()) {
httpGet.addHeader(headerEntry.getKey(),headerEntry.getValue());
}
}
if (!httpGet.containsHeader("Accept-Encoding")) {
httpGet.addHeader("Accept-Encoding", "gzip");
}
HttpResponse httpResponse = null;
int tried = 0;
boolean retry;
do {
try {
httpResponse = httpClient.execute(httpGet);
retry = false;
} catch (IOException e) {
tried++;
if (tried > retryTimes) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
Page page = new Page();
Object cycleTriedTimesObject = request.getExtra(Request.CYCLE_TRIED_TIMES);
if (cycleTriedTimesObject == null) {
page.addTargetRequest(request.setPriority(0).putExtra(Request.CYCLE_TRIED_TIMES, 1));
} else {
int cycleTriedTimes = (Integer) cycleTriedTimesObject;
cycleTriedTimes++;
if (cycleTriedTimes >= site.getCycleRetryTimes()) {
return null;
}
page.addTargetRequest(request.setPriority(0).putExtra(Request.CYCLE_TRIED_TIMES, 1));
}
return page;
}
return null;
}
logger.info("download page " + request.getUrl() + " error, retry the " + tried + " time!");
retry = true;
}
} while (retry);
int statusCode = httpResponse.getStatusLine().getStatusCode();
if (acceptStatCode.contains(statusCode)) {
handleGzip(httpResponse);
//charset
if (charset == null) {
String value = httpResponse.getEntity().getContentType().getValue();
charset = UrlUtils.getCharset(value);
}
return handleResponse(request, charset, httpResponse, task);
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
}
} catch (Exception e) {
logger.warn("download page " + request.getUrl() + " error", e);
}
return null;
}
#location 21
#vulnerability type INTERFACE_NOT_THREAD_SAFE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page {}", request.getUrl());
CloseableHttpResponse httpResponse = null;
int statusCode=0;
try {
HttpUriRequest httpUriRequest = getHttpUriRequest(request, site, headers);
httpResponse = getHttpClient(site).execute(httpUriRequest);
statusCode = httpResponse.getStatusLine().getStatusCode();
request.putExtra(Request.STATUS_CODE, statusCode);
if (statusAccept(acceptStatCode, statusCode)) {
Page page = handleResponse(request, charset, httpResponse, task);
onSuccess(request);
return page;
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
onError(request);
return null;
} finally {
request.putExtra(Request.STATUS_CODE, statusCode);
try {
if (httpResponse != null) {
//ensure the connection is released back to pool
EntityUtils.consume(httpResponse.getEntity());
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
|
#vulnerable code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page {}", request.getUrl());
CloseableHttpResponse httpResponse = null;
int statusCode=0;
try {
HttpUriRequest httpUriRequest = getHttpUriRequest(request, site, headers);
httpResponse = getHttpClient(site).execute(httpUriRequest);
statusCode = httpResponse.getStatusLine().getStatusCode();
request.putExtra(Request.STATUS_CODE, statusCode);
if (statusAccept(acceptStatCode, statusCode)) {
Page page = handleResponse(request, charset, httpResponse, task);
onSuccess(request);
return page;
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
onError(request);
return null;
} finally {
request.putExtra(Request.STATUS_CODE, statusCode);
try {
if (httpResponse != null) {
//ensure the connection is released back to pool
EntityUtils.consume(httpResponse.getEntity());
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
if (site.getHttpProxyPool().isEnable()) {
site.returnHttpProxyToPool((HttpHost) request.getExtra(Request.PROXY), (Integer) request
.getExtra(Request.STATUS_CODE));
}
}
}
#location 51
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void run() {
checkRunningStat();
initComponent();
logger.info("Spider " + getUUID() + " started!");
final AtomicInteger threadAlive = new AtomicInteger(0);
while (!Thread.currentThread().isInterrupted() && stat.get() == STAT_RUNNING) {
Request request = scheduler.poll(this);
if (request == null) {
if (threadAlive.get() == 0 && exitWhenComplete) {
break;
}
// wait until new url added
waitNewUrl();
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
try {
processRequest(requestFinal);
} catch (Exception e) {
logger.error("download " + requestFinal + " error", e);
} finally {
threadAlive.decrementAndGet();
signalNewUrl();
}
}
});
}
}
executorService.shutdown();
stat.set(STAT_STOPPED);
// release some resources
destroy();
}
|
#vulnerable code
@Override
public void run() {
checkRunningStat();
initComponent();
logger.info("Spider " + getUUID() + " started!");
final AtomicInteger threadAlive = new AtomicInteger(0);
while (!Thread.currentThread().isInterrupted() && stat.get() == STAT_RUNNING) {
Request request = scheduler.poll(this);
if (request == null) {
if (threadAlive.get() == 0 && exitWhenComplete) {
break;
}
// wait until new url added
try {
newUrlLock.lock();
try {
newUrlCondition.await();
} catch (InterruptedException e) {
}
} finally {
newUrlLock.unlock();
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
try {
processRequest(requestFinal);
} catch (Exception e) {
logger.error("download " + requestFinal + " error", e);
} finally {
threadAlive.decrementAndGet();
signalNewUrl();
}
}
});
}
}
executorService.shutdown();
stat.set(STAT_STOPPED);
// release some resources
destroy();
}
#location 10
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void run() {
if (!stat.compareAndSet(STAT_INIT, STAT_RUNNING)
&& !stat.compareAndSet(STAT_STOPPED, STAT_RUNNING)) {
throw new IllegalStateException("Spider is already running!");
}
checkComponent();
if (startUrls != null) {
for (String startUrl : startUrls) {
scheduler.push(new Request(startUrl), this);
}
startUrls.clear();
}
Request request = scheduler.poll(this);
//single thread
if (threadNum <= 1) {
while (request != null && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
processRequest(request);
request = scheduler.poll(this);
}
} else {
synchronized (this) {
this.executorService = ThreadUtils.newFixedThreadPool(threadNum);
}
//multi thread
final AtomicInteger threadAlive = new AtomicInteger(0);
while (true && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
if (request == null) {
//when no request found but some thread is alive, sleep a while.
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
processRequest(requestFinal);
threadAlive.decrementAndGet();
}
});
}
request = scheduler.poll(this);
if (threadAlive.get() == 0) {
request = scheduler.poll(this);
if (request == null) {
break;
}
}
}
executorService.shutdown();
}
stat.compareAndSet(STAT_RUNNING, STAT_STOPPED);
//release some resources
destroy();
}
|
#vulnerable code
@Override
public void run() {
if (!stat.compareAndSet(STAT_INIT, STAT_RUNNING)
&& !stat.compareAndSet(STAT_STOPPED, STAT_RUNNING)) {
throw new IllegalStateException("Spider is already running!");
}
checkComponent();
if (startUrls != null) {
for (String startUrl : startUrls) {
scheduler.push(new Request(startUrl), this);
}
startUrls.clear();
}
Request request = scheduler.poll(this);
//single thread
if (executorService == null) {
while (request != null && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
processRequest(request);
request = scheduler.poll(this);
}
} else {
//multi thread
final AtomicInteger threadAlive = new AtomicInteger(0);
while (true && stat.compareAndSet(STAT_RUNNING, STAT_RUNNING)) {
if (request == null) {
//when no request found but some thread is alive, sleep a while.
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
processRequest(requestFinal);
threadAlive.decrementAndGet();
}
});
}
request = scheduler.poll(this);
if (threadAlive.get() == 0) {
request = scheduler.poll(this);
if (request == null) {
break;
}
}
}
executorService.shutdown();
}
stat.compareAndSet(STAT_RUNNING, STAT_STOPPED);
//release some resources
destroy();
}
#location 7
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private void readCursorFile() throws IOException {
BufferedReader fileCursorReader = null;
try {
new BufferedReader(new FileReader(getFileName(fileCursor)));
String line;
//read the last number
while ((line = fileCursorReader.readLine()) != null) {
cursor = new AtomicInteger(NumberUtils.toInt(line));
}
} finally {
if (fileCursorReader != null) {
IOUtils.closeQuietly(fileCursorReader);
}
}
}
|
#vulnerable code
private void readCursorFile() throws IOException {
BufferedReader fileCursorReader = new BufferedReader(new FileReader(getFileName(fileCursor)));
String line;
//read the last number
while ((line = fileCursorReader.readLine()) != null) {
cursor = new AtomicInteger(NumberUtils.toInt(line));
}
}
#location 7
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void run() {
if (!stat.compareAndSet(STAT_INIT, STAT_RUNNING)) {
throw new IllegalStateException("Spider is already running!");
}
checkComponent();
if (startUrls != null) {
for (String startUrl : startUrls) {
scheduler.push(new Request(startUrl), this);
}
}
Request request = scheduler.poll(this);
//singel thread
if (executorService == null) {
while (request != null) {
processRequest(request);
request = scheduler.poll(this);
}
} else {
//multi thread
final AtomicInteger threadAlive = new AtomicInteger(0);
while (true) {
if (request == null) {
//when no request found but some thread is alive, sleep a while.
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
processRequest(requestFinal);
threadAlive.decrementAndGet();
}
});
}
request = scheduler.poll(this);
if (threadAlive.get() == 0) {
request = scheduler.poll(this);
if (request == null) {
break;
}
}
}
executorService.shutdown();
}
stat.compareAndSet(STAT_RUNNING, STAT_STOPPED);
//release some resources
destroy();
}
|
#vulnerable code
@Override
public void run() {
if (!stat.compareAndSet(STAT_INIT, STAT_RUNNING)) {
throw new IllegalStateException("Spider is already running!");
}
checkComponent();
if (startUrls != null) {
for (String startUrl : startUrls) {
scheduler.push(new Request(startUrl), this);
}
}
Request request = scheduler.poll(this);
if (pipelines.isEmpty()) {
pipelines.add(new ConsolePipeline());
}
//singel thread
if (executorService == null) {
while (request != null) {
processRequest(request);
request = scheduler.poll(this);
}
} else {
//multi thread
final AtomicInteger threadAlive = new AtomicInteger(0);
while (true) {
if (request == null) {
//when no request found but some thread is alive, sleep a while.
try {
Thread.sleep(100);
} catch (InterruptedException e) {
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
processRequest(requestFinal);
threadAlive.decrementAndGet();
}
});
}
request = scheduler.poll(this);
if (threadAlive.get() == 0) {
request = scheduler.poll(this);
if (request == null) {
break;
}
}
}
executorService.shutdown();
}
stat.compareAndSet(STAT_RUNNING, STAT_STOPPED);
//release some resources
destroy();
}
#location 19
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void run() {
checkRunningStat();
initComponent();
logger.info("Spider " + getUUID() + " started!");
final AtomicInteger threadAlive = new AtomicInteger(0);
while (!Thread.currentThread().isInterrupted() && stat.get() == STAT_RUNNING) {
Request request = scheduler.poll(this);
if (request == null) {
if (threadAlive.get() == 0 && exitWhenComplete) {
break;
}
// wait until new url added
waitNewUrl();
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
try {
processRequest(requestFinal);
} catch (Exception e) {
logger.error("download " + requestFinal + " error", e);
} finally {
threadAlive.decrementAndGet();
signalNewUrl();
}
}
});
}
}
executorService.shutdown();
stat.set(STAT_STOPPED);
// release some resources
destroy();
}
|
#vulnerable code
@Override
public void run() {
checkRunningStat();
initComponent();
logger.info("Spider " + getUUID() + " started!");
final AtomicInteger threadAlive = new AtomicInteger(0);
while (!Thread.currentThread().isInterrupted() && stat.get() == STAT_RUNNING) {
Request request = scheduler.poll(this);
if (request == null) {
if (threadAlive.get() == 0 && exitWhenComplete) {
break;
}
// wait until new url added
try {
newUrlLock.lock();
try {
newUrlCondition.await();
} catch (InterruptedException e) {
}
} finally {
newUrlLock.unlock();
}
} else {
final Request requestFinal = request;
threadAlive.incrementAndGet();
executorService.execute(new Runnable() {
@Override
public void run() {
try {
processRequest(requestFinal);
} catch (Exception e) {
logger.error("download " + requestFinal + " error", e);
} finally {
threadAlive.decrementAndGet();
signalNewUrl();
}
}
});
}
}
executorService.shutdown();
stat.set(STAT_STOPPED);
// release some resources
destroy();
}
#location 5
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = WMCollections.newHashSet(200);
}
logger.info("downloading page {}", request.getUrl());
CloseableHttpResponse httpResponse = null;
int statusCode=0;
try {
HttpHost proxyHost = null;
Proxy proxy = null; //TODO
if (site.getHttpProxyPool() != null && site.getHttpProxyPool().isEnable()) {
proxy = site.getHttpProxyFromPool();
proxyHost = proxy.getHttpHost();
} else if(site.getHttpProxy()!= null){
proxyHost = site.getHttpProxy();
}
HttpUriRequest httpUriRequest = getHttpUriRequest(request, site, headers, proxyHost);//���������˴���
httpResponse = getHttpClient(site, proxy).execute(httpUriRequest);//getHttpClient�������˴�����֤
statusCode = httpResponse.getStatusLine().getStatusCode();
request.putExtra(Request.STATUS_CODE, statusCode);
if (statusAccept(acceptStatCode, statusCode)) {
Page page = handleResponse(request, charset, httpResponse, task);
onSuccess(request);
return page;
} else {
logger.warn("get page {} error, status code {} ",request.getUrl(),statusCode);
return null;
}
} catch (IOException e) {
logger.warn("download page {} error", request.getUrl(), e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
onError(request);
return null;
} finally {
request.putExtra(Request.STATUS_CODE, statusCode);
if (site.getHttpProxyPool()!=null && site.getHttpProxyPool().isEnable()) {
site.returnHttpProxyToPool((HttpHost) request.getExtra(Request.PROXY), (Integer) request
.getExtra(Request.STATUS_CODE));
}
try {
if (httpResponse != null) {
//ensure the connection is released back to pool
EntityUtils.consume(httpResponse.getEntity());
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
|
#vulnerable code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page {}", request.getUrl());
CloseableHttpResponse httpResponse = null;
int statusCode=0;
try {
HttpHost proxyHost = null;
Proxy proxy = null; //TODO
if (site.getHttpProxyPool() != null && site.getHttpProxyPool().isEnable()) {
proxy = site.getHttpProxyFromPool();
proxyHost = proxy.getHttpHost();
} else if(site.getHttpProxy()!= null){
proxyHost = site.getHttpProxy();
}
HttpUriRequest httpUriRequest = getHttpUriRequest(request, site, headers, proxyHost);//���������˴���
httpResponse = getHttpClient(site, proxy).execute(httpUriRequest);//getHttpClient�������˴�����֤
statusCode = httpResponse.getStatusLine().getStatusCode();
request.putExtra(Request.STATUS_CODE, statusCode);
if (statusAccept(acceptStatCode, statusCode)) {
Page page = handleResponse(request, charset, httpResponse, task);
onSuccess(request);
return page;
} else {
logger.warn("get page {} error, status code {} ",request.getUrl(),statusCode);
return null;
}
} catch (IOException e) {
logger.warn("download page {} error", request.getUrl(), e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
onError(request);
return null;
} finally {
request.putExtra(Request.STATUS_CODE, statusCode);
if (site.getHttpProxyPool()!=null && site.getHttpProxyPool().isEnable()) {
site.returnHttpProxyToPool((HttpHost) request.getExtra(Request.PROXY), (Integer) request
.getExtra(Request.STATUS_CODE));
}
try {
if (httpResponse != null) {
//ensure the connection is released back to pool
EntityUtils.consume(httpResponse.getEntity());
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
#location 23
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page {}" , request.getUrl());
CloseableHttpResponse httpResponse = null;
try {
HttpUriRequest httpUriRequest = getHttpUriRequest(request, site, headers);
httpResponse = getHttpClient(site).execute(httpUriRequest);
int statusCode = httpResponse.getStatusLine().getStatusCode();
if (statusAccept(acceptStatCode, statusCode)) {
//charset
if (charset == null) {
String value = httpResponse.getEntity().getContentType().getValue();
charset = UrlUtils.getCharset(value);
}
return handleResponse(request, charset, httpResponse, task);
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
return null;
} finally {
try {
if (httpResponse != null) {
//ensure the connection is released back to pool
EntityUtils.consume(httpResponse.getEntity());
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
|
#vulnerable code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page {}" , request.getUrl());
RequestBuilder requestBuilder = RequestBuilder.get().setUri(request.getUrl());
if (headers != null) {
for (Map.Entry<String, String> headerEntry : headers.entrySet()) {
requestBuilder.addHeader(headerEntry.getKey(), headerEntry.getValue());
}
}
RequestConfig.Builder requestConfigBuilder = RequestConfig.custom()
.setConnectionRequestTimeout(site.getTimeOut())
.setSocketTimeout(site.getTimeOut())
.setConnectTimeout(site.getTimeOut())
.setCookieSpec(CookieSpecs.BEST_MATCH);
if (site != null && site.getHttpProxy() != null) {
requestConfigBuilder.setProxy(site.getHttpProxy());
}
requestBuilder.setConfig(requestConfigBuilder.build());
CloseableHttpResponse httpResponse = null;
try {
httpResponse = getHttpClient(site).execute(requestBuilder.build());
int statusCode = httpResponse.getStatusLine().getStatusCode();
if (acceptStatCode.contains(statusCode)) {
//charset
if (charset == null) {
String value = httpResponse.getEntity().getContentType().getValue();
charset = UrlUtils.getCharset(value);
}
return handleResponse(request, charset, httpResponse, task);
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
return null;
} finally {
try {
if (httpResponse != null) {
//ensure the connection is released back to pool
EntityUtils.consume(httpResponse.getEntity());
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
#location 25
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Ignore
@Test
public void testCookie() {
Site site = Site.me().setDomain("www.diandian.com").addCookie("t", "yct7q7e6v319wpg4cpxqduu5m77lcgix");
HttpClientDownloader httpClientDownloader = new HttpClientDownloader();
Page download = httpClientDownloader.download(new Request("http://www.diandian.com"), site.toTask());
Assert.assertTrue(download.getHtml().toString().contains("flashsword30"));
}
|
#vulnerable code
@Ignore
@Test
public void testCookie() {
Site site = Site.me().setDomain("www.diandian.com").addCookie("t", "yct7q7e6v319wpg4cpxqduu5m77lcgix");
HttpClientDownloader httpClientDownloader = new HttpClientDownloader();
Page download = httpClientDownloader.download(new Request("http://www.diandian.com"), site);
Assert.assertTrue(download.getHtml().toString().contains("flashsword30"));
}
#location 7
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page " + request.getUrl());
RequestBuilder requestBuilder = RequestBuilder.get().setUri(request.getUrl());
if (headers != null) {
for (Map.Entry<String, String> headerEntry : headers.entrySet()) {
requestBuilder.addHeader(headerEntry.getKey(), headerEntry.getValue());
}
}
RequestConfig.Builder requestConfigBuilder = RequestConfig.custom()
.setConnectionRequestTimeout(site.getTimeOut())
.setConnectTimeout(site.getTimeOut())
.setCookieSpec(CookieSpecs.BEST_MATCH);
if (site != null && site.getHttpProxy() != null) {
requestConfigBuilder.setProxy(site.getHttpProxy());
}
requestBuilder.setConfig(requestConfigBuilder.build());
CloseableHttpResponse httpResponse = null;
try {
httpResponse = getHttpClient(site).execute(requestBuilder.build());
int statusCode = httpResponse.getStatusLine().getStatusCode();
if (acceptStatCode.contains(statusCode)) {
//charset
if (charset == null) {
String value = httpResponse.getEntity().getContentType().getValue();
charset = UrlUtils.getCharset(value);
}
return handleResponse(request, charset, httpResponse, task);
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
return null;
} finally {
try {
if (httpResponse != null) {
httpResponse.close();
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
|
#vulnerable code
@Override
public Page download(Request request, Task task) {
Site site = null;
if (task != null) {
site = task.getSite();
}
Set<Integer> acceptStatCode;
String charset = null;
Map<String, String> headers = null;
if (site != null) {
acceptStatCode = site.getAcceptStatCode();
charset = site.getCharset();
headers = site.getHeaders();
} else {
acceptStatCode = Sets.newHashSet(200);
}
logger.info("downloading page " + request.getUrl());
RequestBuilder requestBuilder = RequestBuilder.get().setUri(request.getUrl());
if (headers != null) {
for (Map.Entry<String, String> headerEntry : headers.entrySet()) {
requestBuilder.addHeader(headerEntry.getKey(), headerEntry.getValue());
}
}
RequestConfig.Builder requestConfigBuilder = RequestConfig.custom()
.setConnectionRequestTimeout(site.getTimeOut())
.setConnectTimeout(site.getTimeOut())
.setCookieSpec(CookieSpecs.BEST_MATCH);
if (site.getHttpProxy() != null) {
requestConfigBuilder.setProxy(site.getHttpProxy());
}
requestBuilder.setConfig(requestConfigBuilder.build());
CloseableHttpResponse httpResponse = null;
try {
httpResponse = getHttpClient(site).execute(requestBuilder.build());
int statusCode = httpResponse.getStatusLine().getStatusCode();
if (acceptStatCode.contains(statusCode)) {
//charset
if (charset == null) {
String value = httpResponse.getEntity().getContentType().getValue();
charset = UrlUtils.getCharset(value);
}
return handleResponse(request, charset, httpResponse, task);
} else {
logger.warn("code error " + statusCode + "\t" + request.getUrl());
return null;
}
} catch (IOException e) {
logger.warn("download page " + request.getUrl() + " error", e);
if (site.getCycleRetryTimes() > 0) {
return addToCycleRetry(request, site);
}
return null;
} finally {
try {
if (httpResponse != null) {
httpResponse.close();
}
} catch (IOException e) {
logger.warn("close response fail", e);
}
}
}
#location 34
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
protected void processRequest(Request request) {
Page page = downloader.download(request, this);
if (page == null) {
sleep(site.getSleepTime());
onError(request);
return;
}
// for cycle retry
if (page.isNeedCycleRetry()) {
extractAndAddRequests(page, true);
sleep(site.getSleepTime());
return;
}
pageProcessor.process(page);
extractAndAddRequests(page, spawnUrl);
if (!page.getResultItems().isSkip()) {
for (Pipeline pipeline : pipelines) {
pipeline.process(page.getResultItems(), this);
}
}
sleep(site.getSleepTime());
}
|
#vulnerable code
protected void processRequest(Request request) {
Page page = downloader.download(request, this);
if (page == null) {
sleep(site.getSleepTime());
onError(request);
}
// for cycle retry
if (page.isNeedCycleRetry()) {
extractAndAddRequests(page, true);
sleep(site.getSleepTime());
return;
}
pageProcessor.process(page);
extractAndAddRequests(page, spawnUrl);
if (!page.getResultItems().isSkip()) {
for (Pipeline pipeline : pipelines) {
pipeline.process(page.getResultItems(), this);
}
}
sleep(site.getSleepTime());
}
#location 8
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public boolean tryAdvance(Consumer<? super E> action) {
Objects.requireNonNull(action);
if (!exhausted) {
E e = null;
ReentrantLock lock = queueLock;
lock.lock();
try {
Object p;
if ((p = current) != null || (p = getQueueFirst(queue)) != null)
do {
e = getNodeItem(p);
p = succ(p);
} while (e == null && p != null);
exhausted = ((current = p) == null);
} finally {
// checkInvariants();
lock.unlock();
}
if (e != null) {
action.accept(e);
return true;
}
}
return false;
}
|
#vulnerable code
@Override
public boolean tryAdvance(Consumer<? super E> action) {
Objects.requireNonNull(action);
if (!exhausted) {
ReentrantLock lock = queueLock;
Object p = current;
E e = null;
lock.lock();
try {
if (p != null || (p = getQueueFirst(queue)) != null)
do {
e = getNodeItem(p);
p = succ(p);
} while (e == null && p != null);
} finally {
// checkInvariants();
lock.unlock();
}
exhausted = ((current = p) == null);
if (e != null) {
action.accept(e);
return true;
}
}
return false;
}
#location 19
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
@SuppressWarnings("unchecked")
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
int hi = getFence();
Object[] a = array;
int i;
for (i = index, index = hi; i < hi; i++) {
action.accept((E) a[i]);
}
if (getModCount(list) != expectedModCount) {
throw new ConcurrentModificationException();
}
}
|
#vulnerable code
@Override
@SuppressWarnings("unchecked")
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
int i, hi; // hoist accesses and checks from loop
Vector<E> lst = list;
Object[] a;
if ((hi = fence) < 0) {
synchronized (lst) {
expectedModCount = getModCount(lst);
a = array = getData(lst);
hi = fence = getSize(lst);
}
} else {
a = array;
}
if (a != null && (i = index) >= 0 && (index = hi) <= a.length) {
while (i < hi) {
action.accept((E) a[i++]);
}
if (expectedModCount == getModCount(lst)) {
return;
}
}
throw new ConcurrentModificationException();
}
#location 17
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public boolean tryAdvance(Consumer<? super E> action) {
Objects.requireNonNull(action);
if (exhausted)
return false;
LinkedBlockingDeque<E> q = queue;
ReentrantLock lock = queueLock;
Object p = current;
E e = null;
lock.lock();
try {
if ((p != null && p != getNextNode(p)) || (p = getQueueFirst(q)) != null) {
e = getNodeItem(p);
p = getNextNode(p);
}
} finally {
lock.unlock();
}
exhausted = ((current = p) == null);
if (e == null)
return false;
action.accept(e);
return true;
}
|
#vulnerable code
@Override
public boolean tryAdvance(Consumer<? super E> action) {
Objects.requireNonNull(action);
LinkedBlockingDeque<E> q = queue;
ReentrantLock lock = queueLock;
if (!exhausted) {
E e = null;
lock.lock();
try {
if (current == null) {
current = getQueueFirst(q);
}
while (current != null) {
e = getNodeItem(current);
current = getNextNode(current);
if (e != null) {
break;
}
}
} finally {
lock.unlock();
}
if (current == null) {
exhausted = true;
}
if (e != null) {
action.accept(e);
return true;
}
}
return false;
}
#location 15
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
@SuppressWarnings("unchecked")
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
int hi = getFence();
Object[] a = array;
int i;
for (i = index, index = hi; i < hi; i++) {
action.accept((E) a[i]);
}
if (getModCount(list) != expectedModCount) {
throw new ConcurrentModificationException();
}
}
|
#vulnerable code
@Override
@SuppressWarnings("unchecked")
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
int i, hi; // hoist accesses and checks from loop
Vector<E> lst = list;
Object[] a;
if ((hi = fence) < 0) {
synchronized (lst) {
expectedModCount = getModCount(lst);
a = array = getData(lst);
hi = fence = getSize(lst);
}
} else {
a = array;
}
if (a != null && (i = index) >= 0 && (index = hi) <= a.length) {
while (i < hi) {
action.accept((E) a[i++]);
}
if (expectedModCount == getModCount(lst)) {
return;
}
}
throw new ConcurrentModificationException();
}
#location 15
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
if (!exhausted) {
exhausted = true;
Object p = current;
current = null;
forEachFrom(action, p);
}
}
|
#vulnerable code
@Override
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
if (!exhausted) {
exhausted = true;
ReentrantLock lock = queueLock;
Object p = current;
current = null;
do {
E e = null;
lock.lock();
try {
if (p != null || (p = getQueueFirst(queue)) != null)
do {
e = getNodeItem(p);
p = succ(p);
} while (e == null && p != null);
} finally {
// checkInvariants();
lock.unlock();
}
if (e != null)
action.accept(e);
} while (p != null);
}
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
@SuppressWarnings("unchecked")
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
int hi = getFence();
Object[] a = array;
int i;
for (i = index, index = hi; i < hi; i++) {
action.accept((E) a[i]);
}
if (getModCount(list) != expectedModCount) {
throw new ConcurrentModificationException();
}
}
|
#vulnerable code
@Override
@SuppressWarnings("unchecked")
public void forEachRemaining(Consumer<? super E> action) {
Objects.requireNonNull(action);
int i, hi; // hoist accesses and checks from loop
Vector<E> lst = list;
Object[] a;
if ((hi = fence) < 0) {
synchronized (lst) {
expectedModCount = getModCount(lst);
a = array = getData(lst);
hi = fence = getSize(lst);
}
} else {
a = array;
}
if (a != null && (i = index) >= 0 && (index = hi) <= a.length) {
while (i < hi) {
action.accept((E) a[i++]);
}
if (expectedModCount == getModCount(lst)) {
return;
}
}
throw new ConcurrentModificationException();
}
#location 21
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private static List<String> listNames(File dir) {
List<String> names = new ArrayList<String>();
if (!dir.exists()) {
return names;
}
File[] files = dir.listFiles();
if (files == null) {
return names;
}
for (File file : files) {
String name = file.getName();
if (name.startsWith(".") || file.isFile()) {
continue;
}
names.add(name);
}
return names;
}
|
#vulnerable code
private static List<String> listNames(File dir) {
List<String> names = new ArrayList<String>();
for (File file : dir.listFiles()) {
String name = file.getName();
if (name.startsWith(".") || file.isFile()) {
continue;
}
names.add(name);
}
return names;
}
#location 3
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void removeExecutable(Distribution distribution, File executable) {
FileWithCounter fileWithCounter;
synchronized (_lock) {
fileWithCounter = _distributionFiles.get(distribution);
}
if (fileWithCounter!=null) {
fileWithCounter.free(executable);
} else {
_logger.warning("Allready removed "+executable+" for "+distribution+", emergency shutdown?");
}
}
|
#vulnerable code
@Override
public void removeExecutable(Distribution distribution, File executable) {
FileWithCounter fileWithCounter;
synchronized (_lock) {
fileWithCounter = _distributionFiles.get(distribution);
}
fileWithCounter.free(executable);
//_delegate.removeExecutable(executable);
}
#location 7
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public ExtractedFileSet extractFileSet(Distribution distribution)
throws IOException {
Directory withDistribution = withDistribution(extraction.getDirectory(), distribution);
ArtifactStore baseStore = store(withDistribution, extraction.getExecutableNaming());
boolean foundExecutable=false;
File destinationDir = withDistribution.asFile();
Builder fileSetBuilder = ExtractedFileSet.builder(destinationDir)
.baseDirIsGenerated(withDistribution.isGenerated());
FilesToExtract filesToExtract = baseStore.filesToExtract(distribution);
for (FileSet.Entry file : filesToExtract.files()) {
if (file.type()==FileType.Executable) {
String executableName = FilesToExtract.executableName(extraction.getExecutableNaming(), file);
File executableFile = new File(executableName);
File resolvedExecutableFile = new File(destinationDir, executableName);
if (resolvedExecutableFile.isFile()) {
foundExecutable=true;
}
fileSetBuilder.executable(executableFile);
} else {
fileSetBuilder.addLibraryFiles(new File(FilesToExtract.fileName(file)));
}
}
ExtractedFileSet extractedFileSet;
if (!foundExecutable) {
// we found no executable, so we trigger extraction and hope for the best
try {
extractedFileSet = baseStore.extractFileSet(distribution);
} catch (FileAlreadyExistsException fx) {
throw new RuntimeException("extraction to "+destinationDir+" has failed", fx);
}
} else {
extractedFileSet = fileSetBuilder.build();
}
return ExtractedFileSets.copy(extractedFileSet, temp.getDirectory(), temp.getExecutableNaming());
}
|
#vulnerable code
@Override
public ExtractedFileSet extractFileSet(Distribution distribution)
throws IOException {
Directory withDistribution = withDistribution(extraction.getDirectory(), distribution);
ArtifactStore baseStore = store(withDistribution, extraction.getExecutableNaming());
boolean foundExecutable=false;
File destinationDir = withDistribution.asFile();
Builder fileSetBuilder = ExtractedFileSet.builder(destinationDir)
.baseDirIsGenerated(withDistribution.isGenerated());
FilesToExtract filesToExtract = baseStore.filesToExtract(distribution);
for (FileSet.Entry file : filesToExtract.files()) {
if (file.type()==FileType.Executable) {
String executableName = FilesToExtract.executableName(extraction.getExecutableNaming(), file);
File executableFile = new File(executableName);
File resolvedExecutableFile = new File(destinationDir, executableName);
if (resolvedExecutableFile.isFile()) {
foundExecutable=true;
}
fileSetBuilder.executable(executableFile);
} else {
fileSetBuilder.addLibraryFiles(new File(FilesToExtract.fileName(file)));
}
}
if (!foundExecutable) {
// we found no executable, so we trigger extraction and hope for the best
try {
baseStore.extractFileSet(distribution);
} catch (FileAlreadyExistsException fx) {
throw new RuntimeException("extraction to "+destinationDir+" has failed", fx);
}
}
ExtractedFileSet extractedFileSet = fileSetBuilder.build();
return ExtractedFileSets.copy(extractedFileSet, temp.getDirectory(), temp.getExecutableNaming());
}
#location 39
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void constructorOpensConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection(mockUrl, (HttpMethod) any, (Proxy) any);
}
};
}
|
#vulnerable code
@Test
public void constructorOpensConnection(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection(mockUrl, (HttpMethod) any);
}
};
}
#location 15
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void getRequestIdOnTopicWithVersionBeforeRidGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String status = Deencapsulation.invoke(testParser, "getRequestId", 3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
|
#vulnerable code
@Test
public void getRequestIdOnTopicWithVersionBeforeRidGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String status = testParser.getRequestId(3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
#location 13
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void parsePayloadReturnsBytesForSpecifiedTopic(@Mocked final Mqtt mockMqtt) throws IOException
{
//arrange
MqttDeviceTwin testTwin = new MqttDeviceTwin();
String insertTopic = "$iothub/twin/"+ anyString;
final byte[] insertMessage = {0x61, 0x62, 0x63};
ConcurrentSkipListMap<String, byte[]> testMap = new ConcurrentSkipListMap<String, byte[]>();
testMap.put(insertTopic, insertMessage);
Deencapsulation.setField(mockMqtt, "allReceivedMessages", testMap);
//act
byte[] parsedPayload = Deencapsulation.invoke(testTwin, "parsePayload", insertTopic);
//assert
assertNotNull(parsedPayload);
assertEquals(insertMessage.length, parsedPayload.length);
for (int i = 0 ; i < parsedPayload.length; i++)
{
assertEquals(parsedPayload[i], insertMessage[i]);
}
}
|
#vulnerable code
@Test
public void parsePayloadReturnsBytesForSpecifiedTopic(@Mocked final Mqtt mockMqtt) throws IOException
{
//arrange
MqttDeviceTwin testTwin = new MqttDeviceTwin();
String insertTopic = "$iothub/twin/"+ anyString;
final byte[] insertMessage = {0x61, 0x62, 0x63};
ConcurrentSkipListMap<String, byte[]> testMap = new ConcurrentSkipListMap<String, byte[]>();
testMap.put(insertTopic, insertMessage);
Deencapsulation.setField(mockMqtt, "allReceivedMessages", testMap);
//act
byte[] parsedPayload = testTwin.parsePayload(insertTopic);
//assert
assertNotNull(parsedPayload);
assertEquals(insertMessage.length, parsedPayload.length);
for (int i = 0 ; i < parsedPayload.length; i++)
{
assertEquals(parsedPayload[i], insertMessage[i]);
}
}
#location 18
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void onConnectionBound(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_030: [The event handler shall get the Transport (Proton) object from the event.]
Transport transport = event.getConnection().getTransport();
if(transport != null){
if (this.useWebSockets)
{
WebSocketImpl webSocket = new WebSocketImpl();
webSocket.configure(this.hostName, WEB_SOCKET_PATH, 0, WEB_SOCKET_SUB_PROTOCOL, null, null);
((TransportInternal)transport).addTransportLayer(webSocket);
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_031: [The event handler shall set the SASL_PLAIN authentication on the transport using the given user name and sas token.]
Sasl sasl = transport.sasl();
sasl.plain(this.userName, this.sasToken);
SslDomain domain = makeDomain();
transport.ssl(domain);
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
|
#vulnerable code
@Override
public void onConnectionBound(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_030: [The event handler shall get the Transport (Proton) object from the event.]
Transport transport = event.getConnection().getTransport();
if(transport != null){
if (this.useWebSockets)
{
WebSocketImpl webSocket = new WebSocketImpl();
webSocket.configure(this.hostName, WEB_SOCKET_PATH, 0, WEB_SOCKET_SUB_PROTOCOL, null, null);
((TransportInternal)transport).addTransportLayer(webSocket);
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_031: [The event handler shall set the SASL_PLAIN authentication on the transport using the given user name and sas token.]
Sasl sasl = transport.sasl();
sasl.plain(this.userName, this.sasToken);
SslDomain domain = makeDomain();
transport.ssl(domain);
}
synchronized (openLock)
{
openLock.notifyLock();
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 18
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
}
|
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 34
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public HttpsResponse send() throws TransportException
{
return send(true);
}
|
#vulnerable code
public HttpsResponse send() throws TransportException
{
if (this.url == null)
{
throw new IllegalArgumentException("url cannot be null");
}
HttpsConnection connection = new HttpsConnection(url, method, this.proxySettings);
for (String headerKey : headers.keySet())
{
for (String headerValue : this.headers.get(headerKey))
{
connection.setRequestHeader(headerKey, headerValue);
}
}
connection.writeOutput(this.body);
if (this.sslContext != null)
{
connection.setSSLContext(this.sslContext);
}
if (this.readTimeout != 0)
{
connection.setReadTimeout(this.readTimeout);
}
if (this.connectTimeout != 0)
{
connection.setConnectTimeout(this.connectTimeout);
}
int responseStatus = -1;
byte[] responseBody = new byte[0];
byte[] errorReason = new byte[0];
Map<String, List<String>> headerFields;
// Codes_SRS_HTTPSREQUEST_11_008: [The function shall send an HTTPS request as formatted in the constructor.]
connection.connect();
responseStatus = connection.getResponseStatus();
headerFields = connection.getResponseHeaders();
if (responseStatus == 200)
{
responseBody = connection.readInput();
}
// Codes_SRS_HTTPSREQUEST_11_009: [The function shall return the HTTPS response received, including the status code, body (if 200 status code), header fields, and error reason (if any).]
return new HttpsResponse(responseStatus, responseBody, headerFields, errorReason);
}
#location 46
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void getRequestIdOnTopicWithVersionGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7&$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String status = Deencapsulation.invoke(testParser, "getRequestId", 3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
|
#vulnerable code
@Test
public void getRequestIdOnTopicWithVersionGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$version=7&$rid=5";
TopicParser testParser = new TopicParser(validString);
//act
String status = testParser.getRequestId(3);
//assert
assertNotNull(status);
assertTrue(status.equals(String.valueOf(5)));
}
#location 13
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test (expected = IllegalArgumentException.class)
public void request_nullHttpMethod_failed() throws Exception
{
//arrange
//act
HttpResponse response = DeviceOperations.request(
IOT_HUB_CONNECTION_STRING,
new URL(STANDARD_URL),
null,
STANDARD_PAYLOAD,
STANDARD_REQUEST_ID,
0);
//assert
}
|
#vulnerable code
@Test (expected = IllegalArgumentException.class)
public void request_nullHttpMethod_failed() throws Exception
{
//arrange
//act
HttpResponse response = DeviceOperations.request(
IOT_HUB_CONNECTION_STRING,
new URL(STANDARD_URL),
null,
STANDARD_PAYLOAD,
STANDARD_REQUEST_ID);
//assert
}
#location 7
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void onReactorFinal(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_011: [The function shall call notify lock on close lock.]
synchronized (closeLock)
{
closeLock.notifyLock();
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_012: [The function shall set the reactor member variable to null.]
this.reactor = null;
if (reconnectCall)
{
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_013: [The function shall call openAsync and disable reconnection if it is a reconnection attempt.]
reconnectCall = false;
for (ServerListener listener : listeners)
{
listener.reconnect();
}
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
|
#vulnerable code
@Override
public void onReactorFinal(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_011: [The function shall call notify lock on close lock.]
synchronized (closeLock)
{
closeLock.notifyLock();
}
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_012: [The function shall set the reactor member variable to null.]
this.reactor = null;
if (reconnectCall)
{
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_013: [The function shall call openAsync and disable reconnection if it is a reconnection attempt.]
reconnectCall = false;
try
{
openAsync();
}
catch (IOException e)
{
// Codes_SRS_AMQPSIOTHUBCONNECTION_12_014: [The function shall log the error if openAsync failed.]
logger.LogDebug("onReactorFinal has thrown exception: %s", e.getMessage());
}
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 21
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public HttpsResponse send() throws TransportException
{
return send(true);
}
|
#vulnerable code
public HttpsResponse send() throws TransportException
{
if (this.url == null)
{
throw new IllegalArgumentException("url cannot be null");
}
HttpsConnection connection = new HttpsConnection(url, method, this.proxySettings);
for (String headerKey : headers.keySet())
{
for (String headerValue : this.headers.get(headerKey))
{
connection.setRequestHeader(headerKey, headerValue);
}
}
connection.writeOutput(this.body);
if (this.sslContext != null)
{
connection.setSSLContext(this.sslContext);
}
if (this.readTimeout != 0)
{
connection.setReadTimeout(this.readTimeout);
}
if (this.connectTimeout != 0)
{
connection.setConnectTimeout(this.connectTimeout);
}
int responseStatus = -1;
byte[] responseBody = new byte[0];
byte[] errorReason = new byte[0];
Map<String, List<String>> headerFields;
// Codes_SRS_HTTPSREQUEST_11_008: [The function shall send an HTTPS request as formatted in the constructor.]
connection.connect();
responseStatus = connection.getResponseStatus();
headerFields = connection.getResponseHeaders();
if (responseStatus == 200)
{
responseBody = connection.readInput();
}
// Codes_SRS_HTTPSREQUEST_11_009: [The function shall return the HTTPS response received, including the status code, body (if 200 status code), header fields, and error reason (if any).]
return new HttpsResponse(responseStatus, responseBody, headerFields, errorReason);
}
#location 48
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void getVersionOnTopicWithRIDGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String version = Deencapsulation.invoke(testParser, "getVersion", 3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
}
|
#vulnerable code
@Test
public void getVersionOnTopicWithRIDGets() throws IOException
{
//arrange
String validString = "$iothub/twin/res/?$rid=5&$version=7";
TopicParser testParser = new TopicParser(validString);
//act
String version = testParser.getVersion(3);
//assert
assertNotNull(version);
assertTrue(version.equals(String.valueOf(7)));
}
#location 13
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
@StandardTierHubOnlyTest
public void invokeMethodSucceed() throws Exception
{
testInstance.transportClient.open();
for (int i = 0; i < testInstance.clientArrayList.size(); i++)
{
DeviceMethodStatusCallBack subscribedCallback = new DeviceMethodStatusCallBack();
((DeviceClient)testInstance.clientArrayList.get(i)).subscribeToDeviceMethod(new SampleDeviceMethodCallback(), null, subscribedCallback, null);
long startTime = System.currentTimeMillis();
while (!subscribedCallback.isSubscribed)
{
Thread.sleep(200);
if (System.currentTimeMillis() - startTime > METHOD_SUBSCRIBE_TIMEOUT_MILLISECONDS)
{
fail(buildExceptionMessage("Timed out waiting for device to subscribe to methods", testInstance.clientArrayList.get(i)));
}
}
CountDownLatch countDownLatch = new CountDownLatch(1);
RunnableInvoke runnableInvoke = new RunnableInvoke(methodServiceClient, testInstance.devicesList[i].getDeviceId(), METHOD_NAME, METHOD_PAYLOAD, countDownLatch);
new Thread(runnableInvoke).start();
countDownLatch.await(3, TimeUnit.MINUTES);
MethodResult result = runnableInvoke.getResult();
Assert.assertNotNull(buildExceptionMessage(runnableInvoke.getException() == null ? "Runnable returns null without exception information" : runnableInvoke.getException().getMessage(), testInstance.clientArrayList.get(i)), result);
Assert.assertEquals(buildExceptionMessage("result was not success, but was: " + result.getStatus(), testInstance.clientArrayList.get(i)), (long)METHOD_SUCCESS,(long)result.getStatus());
Assert.assertEquals(buildExceptionMessage("Received unexpected payload", testInstance.clientArrayList.get(i)), runnableInvoke.getExpectedPayload(), METHOD_NAME + ":" + result.getPayload().toString());
}
testInstance.transportClient.closeNow();
}
|
#vulnerable code
@Test
@StandardTierHubOnlyTest
public void invokeMethodSucceed() throws Exception
{
testInstance.transportClient.open();
for (int i = 0; i < testInstance.clientArrayList.size(); i++)
{
((DeviceClient)testInstance.clientArrayList.get(i)).subscribeToDeviceMethod(new SampleDeviceMethodCallback(), null, new DeviceMethodStatusCallBack(), null);
CountDownLatch countDownLatch = new CountDownLatch(1);
RunnableInvoke runnableInvoke = new RunnableInvoke(methodServiceClient, testInstance.devicesList[i].getDeviceId(), METHOD_NAME, METHOD_PAYLOAD, countDownLatch);
new Thread(runnableInvoke).start();
countDownLatch.await(3, TimeUnit.MINUTES);
MethodResult result = runnableInvoke.getResult();
Assert.assertNotNull(buildExceptionMessage(runnableInvoke.getException() == null ? "Runnable returns null without exception information" : runnableInvoke.getException().getMessage(), testInstance.clientArrayList.get(i)), result);
Assert.assertEquals(buildExceptionMessage("result was not success, but was: " + result.getStatus(), testInstance.clientArrayList.get(i)), (long)METHOD_SUCCESS,(long)result.getStatus());
Assert.assertEquals(buildExceptionMessage("Received unexpected payload", testInstance.clientArrayList.get(i)), runnableInvoke.getExpectedPayload(), METHOD_NAME + ":" + result.getPayload().toString());
}
testInstance.transportClient.closeNow();
}
#location 18
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
DeviceClientManager(DeviceClient deviceClient, boolean autoReconnectOnDisconnected) {
this.connectionStatus = ConnectionStatus.DISCONNECTED;
this.client = deviceClient;
this.client.registerConnectionStatusChangeCallback(this, this);
this.autoReconnectOnDisconnected = autoReconnectOnDisconnected;
}
|
#vulnerable code
void doConnect() {
// Device client does not have retry on the initial open() call. Will need to be re-opened by the calling application
while (connectionStatus == ConnectionStatus.CONNECTING) {
synchronized (lock) {
if(connectionStatus == ConnectionStatus.CONNECTING) {
try {
log.debug("[connect] - Opening the device client instance...");
client.open();
connectionStatus = ConnectionStatus.CONNECTED;
break;
}
catch (Exception ex) {
log.error("[connect] - Exception thrown while opening DeviceClient instance: ", ex);
}
}
}
try {
log.debug("[connect] - Sleeping for 10 secs before attempting another open()");
Thread.sleep(SLEEP_TIME_BEFORE_RECONNECTING_IN_SECONDS * 1000);
}
catch (InterruptedException ex) {
log.error("[connect] - Exception in thread sleep: ", ex);
}
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void onLinkRemoteClose(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
this.state = State.CLOSED;
String linkName = event.getLink().getName();
if (this.amqpsSessionManager.isLinkFound(linkName))
{
logger.LogInfo("Starting to reconnect to IotHub, method name is %s ", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_048: [The event handler shall attempt to startReconnect to IoTHub.]
startReconnect();
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
|
#vulnerable code
@Override
public void onLinkRemoteClose(Event event)
{
logger.LogDebug("Entered in method %s", logger.getMethodName());
this.state = State.CLOSED;
String linkName = event.getLink().getName();
if (this.amqpsSessionManager.isLinkFound(linkName))
{
logger.LogInfo("Starting to reconnect to IotHub, method name is %s ", logger.getMethodName());
// Codes_SRS_AMQPSIOTHUBCONNECTION_15_048: [The event handler shall attempt to startReconnect to IoTHub.]
startReconnect();
}
logger.LogDebug("Exited from method %s", logger.getMethodName());
}
#location 12
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
// Notify send thread to finish up so it doesn't survive this close
synchronized (this.sendThreadLock)
{
this.sendThreadLock.notifyAll();
}
// Notify receive thread to finish up so it doesn't survive this close
synchronized (this.receiveThreadLock)
{
this.receiveThreadLock.notifyAll();
}
log.info("Client connection closed successfully");
}
|
#vulnerable code
public void close(IotHubConnectionStatusChangeReason reason, Throwable cause) throws DeviceClientException
{
if (reason == null)
{
//Codes_SRS_IOTHUBTRANSPORT_34_026: [If the supplied reason is null, this function shall throw an
// IllegalArgumentException.]
throw new IllegalArgumentException("reason cannot be null");
}
this.cancelPendingPackets();
//Codes_SRS_IOTHUBTRANSPORT_34_023: [This function shall invoke all callbacks.]
this.invokeCallbacks();
if (this.taskScheduler != null)
{
this.taskScheduler.shutdown();
}
if (this.scheduledExecutorService != null)
{
this.scheduledExecutorService.shutdownNow();
this.scheduledExecutorService = null;
}
//Codes_SRS_IOTHUBTRANSPORT_34_024: [This function shall close the connection.]
if (this.iotHubTransportConnection != null)
{
this.iotHubTransportConnection.close();
}
//Codes_SRS_IOTHUBTRANSPORT_34_025: [This function shall invoke updateStatus with status DISCONNECTED and the
// supplied reason and cause.]
this.updateStatus(IotHubConnectionStatus.DISCONNECTED, reason, cause);
log.info("Client connection closed successfully");
}
#location 22
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void tokenExpiredAfterOpenButBeforeSendHttp() throws Exception
{
final long SECONDS_FOR_SAS_TOKEN_TO_LIVE = 3;
final long MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE = 5000;
if (testInstance.protocol != HTTPS || testInstance.authenticationType != SAS)
{
//This scenario only applies to HTTP since MQTT and AMQP allow expired sas tokens for 30 minutes after open
// as long as token did not expire before open. X509 doesn't apply either
return;
}
this.testInstance.setup();
String soonToBeExpiredSASToken = generateSasTokenForIotDevice(hostName, testInstance.identity.getDeviceId(), testInstance.identity.getPrimaryKey(), SECONDS_FOR_SAS_TOKEN_TO_LIVE);
DeviceClient client = new DeviceClient(soonToBeExpiredSASToken, testInstance.protocol);
IotHubServicesCommon.openClientWithRetry(client);
//Force the SAS token to expire before sending messages
Thread.sleep(MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE);
IotHubServicesCommon.sendMessagesExpectingSASTokenExpiration(client, testInstance.protocol.toString(), 1, RETRY_MILLISECONDS, SEND_TIMEOUT_MILLISECONDS, testInstance.authenticationType);
client.closeNow();
}
|
#vulnerable code
@Test
public void tokenExpiredAfterOpenButBeforeSendHttp() throws InvalidKeyException, IOException, InterruptedException, URISyntaxException
{
final long SECONDS_FOR_SAS_TOKEN_TO_LIVE = 3;
final long MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE = 5000;
if (testInstance.protocol != HTTPS || testInstance.authenticationType != SAS)
{
//This scenario only applies to HTTP since MQTT and AMQP allow expired sas tokens for 30 minutes after open
// as long as token did not expire before open. X509 doesn't apply either
return;
}
String soonToBeExpiredSASToken = generateSasTokenForIotDevice(hostName, testInstance.identity.getDeviceId(), testInstance.identity.getPrimaryKey(), SECONDS_FOR_SAS_TOKEN_TO_LIVE);
DeviceClient client = new DeviceClient(soonToBeExpiredSASToken, testInstance.protocol);
IotHubServicesCommon.openClientWithRetry(client);
//Force the SAS token to expire before sending messages
Thread.sleep(MILLISECONDS_TO_WAIT_FOR_TOKEN_TO_EXPIRE);
IotHubServicesCommon.sendMessagesExpectingSASTokenExpiration(client, testInstance.protocol.toString(), 1, RETRY_MILLISECONDS, SEND_TIMEOUT_MILLISECONDS, testInstance.authenticationType);
client.closeNow();
}
#location 14
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
protected void disconnect() throws IOException
{
try
{
/*
**Codes_SRS_Mqtt_25_010: [**If the MQTT connection is closed, the function shall do nothing.**]**
*/
if (Mqtt.info.mqttAsyncClient.isConnected())
{
/*
** Codes_SRS_Mqtt_25_009: [**The function shall close the MQTT connection.**]**
*/
IMqttToken disconnectToken = Mqtt.info.mqttAsyncClient.disconnect();
disconnectToken.waitForCompletion();
}
Mqtt.info.mqttAsyncClient = null;
}
catch (MqttException e)
{
/*
** SRS_Mqtt_25_011: [**If an MQTT connection is unable to be closed for any reason, the function shall throw an IOException.**]**
*/
throw new IOException("Unable to disconnect" + "because " + e.getMessage() );
}
}
|
#vulnerable code
protected void disconnect() throws IOException
{
synchronized (Mqtt.MQTT_LOCK)
{
try
{
/*
**Codes_SRS_Mqtt_25_010: [**If the MQTT connection is closed, the function shall do nothing.**]**
*/
if (Mqtt.info.mqttAsyncClient.isConnected())
{
/*
** Codes_SRS_Mqtt_25_009: [**The function shall close the MQTT connection.**]**
*/
IMqttToken disconnectToken = Mqtt.info.mqttAsyncClient.disconnect();
disconnectToken.waitForCompletion();
}
Mqtt.info.mqttAsyncClient = null;
}
catch (MqttException e)
{
/*
** SRS_Mqtt_25_011: [**If an MQTT connection is unable to be closed for any reason, the function shall throw an IOException.**]**
*/
throw new IOException("Unable to disconnect" + "because " + e.getMessage() );
}
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
void openLinks(Session session)
{
// Codes_SRS_AMQPSESSIONDEVICEOPERATION_12_042: [The function shall do nothing if the session parameter is null.]
if (session != null)
{
if (this.amqpsAuthenticatorState == AmqpsDeviceAuthenticationState.AUTHENTICATED)
{
synchronized (this.openLock)
{
for (AmqpsDeviceOperations amqpDeviceOperation : this.amqpsDeviceOperationsMap.values())
{
amqpDeviceOperation.openLinks(session);
}
}
}
}
}
|
#vulnerable code
boolean onLinkRemoteOpen(String linkName)
{
// Codes_SRS_AMQPSESSIONDEVICEOPERATION_12_024: [The function shall return true if any of the operation's link name is a match and return false otherwise.]
if (this.amqpsAuthenticatorState == AmqpsDeviceAuthenticationState.AUTHENTICATED)
{
for (Map.Entry<MessageType, AmqpsDeviceOperations> entry : amqpsDeviceOperationsMap.entrySet())
{
if (entry.getValue().onLinkRemoteOpen(linkName))
{
// If the link that is being opened is a sender link and the operation is a DeviceTwin operation, we will send a subscribe message on the opened link
if (entry.getKey() == MessageType.DEVICE_TWIN && linkName.equals(entry.getValue().getSenderLinkTag()))
{
// since we have already checked the message type, we can safely cast it
AmqpsDeviceTwin deviceTwinOperations = (AmqpsDeviceTwin)entry.getValue();
sendMessage(deviceTwinOperations.buildSubscribeToDesiredPropertiesProtonMessage(), entry.getKey(), deviceClientConfig.getDeviceId());
}
return true;
}
}
}
return false;
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
DeviceClientManager(DeviceClient deviceClient, boolean autoReconnectOnDisconnected) {
this.connectionStatus = ConnectionStatus.DISCONNECTED;
this.client = deviceClient;
this.client.registerConnectionStatusChangeCallback(this, this);
this.autoReconnectOnDisconnected = autoReconnectOnDisconnected;
}
|
#vulnerable code
void disconnect() {
try {
log.debug("[disconnect] - Closing the device client instance...");
client.closeNow();
}
catch (IOException e) {
log.error("[disconnect] - Exception thrown while closing DeviceClient instance: ", e);
}
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void handleMessageReturnsNoReceivedMessage() throws IOException
{
new NonStrictExpectations()
{
{
new AmqpsIotHubConnection(mockConfig, 1);
result = mockConnection;
mockConfig.getDeviceTelemetryMessageCallback();
result = mockMessageCallback;
mockConfig.getDeviceId();
result = "deviceId";
}
};
AmqpsTransport transport = new AmqpsTransport(mockConfig);
transport.open();
transport.handleMessage();
Queue<AmqpsMessage> receivedMessages = Deencapsulation.getField(transport, "receivedMessages");
Assert.assertEquals(0, receivedMessages.size());
new Verifications()
{
{
mockMessageCallback.execute((Message) any, any);
times = 0;
}
};
}
|
#vulnerable code
@Test
public void handleMessageReturnsNoReceivedMessage() throws IOException
{
new NonStrictExpectations()
{
{
new AmqpsIotHubConnection(mockConfig);
result = mockConnection;
mockConfig.getDeviceTelemetryMessageCallback();
result = mockMessageCallback;
mockConfig.getDeviceId();
result = "deviceId";
}
};
AmqpsTransport transport = new AmqpsTransport(mockConfig);
transport.open();
transport.handleMessage();
Queue<AmqpsMessage> receivedMessages = Deencapsulation.getField(transport, "receivedMessages");
Assert.assertEquals(0, receivedMessages.size());
new Verifications()
{
{
mockMessageCallback.execute((Message) any, any);
times = 0;
}
};
}
#location 15
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
@ConditionalIgnoreRule.ConditionalIgnore(condition = StandardTierOnlyRule.class)
public void testQueryTwin() throws IOException, InterruptedException, IotHubException, GeneralSecurityException, URISyntaxException, ModuleClientException
{
addMultipleDevices(MAX_DEVICES);
// Add same desired on multiple devices
final String queryProperty = PROPERTY_KEY_QUERY + UUID.randomUUID().toString();
final String queryPropertyValue = PROPERTY_VALUE_QUERY + UUID.randomUUID().toString();
setDesiredProperties(queryProperty, queryPropertyValue, MAX_DEVICES);
// Query multiple devices having same property
final String where = "is_defined(properties.desired." + queryProperty + ")";
SqlQuery sqlQuery = SqlQuery.createSqlQuery("*", SqlQuery.FromType.DEVICES, where, null);
Thread.sleep(MAXIMUM_TIME_FOR_IOTHUB_PROPAGATION_BETWEEN_DEVICE_SERVICE_CLIENTS);
Query twinQuery = sCDeviceTwin.queryTwin(sqlQuery.getQuery(), PAGE_SIZE);
for (int i = 0; i < MAX_DEVICES; i++)
{
if (sCDeviceTwin.hasNextDeviceTwin(twinQuery))
{
DeviceTwinDevice d = sCDeviceTwin.getNextDeviceTwin(twinQuery);
assertNotNull(d.getVersion());
assertEquals(TwinConnectionState.DISCONNECTED.toString(), d.getConnectionState());
for (Pair dp : d.getDesiredProperties())
{
assertEquals(buildExceptionMessage("Unexpected desired property key, expected " + queryProperty + " but was " + dp.getKey(), internalClient), queryProperty, dp.getKey());
assertEquals(buildExceptionMessage("Unexpected desired property value, expected " + queryPropertyValue + " but was " + dp.getValue(), internalClient), queryPropertyValue, dp.getValue());
}
}
}
assertFalse(sCDeviceTwin.hasNextDeviceTwin(twinQuery));
removeMultipleDevices(MAX_DEVICES);
}
|
#vulnerable code
@Test
@ConditionalIgnoreRule.ConditionalIgnore(condition = StandardTierOnlyRule.class)
public void testQueryTwin() throws IOException, InterruptedException, IotHubException, NoSuchAlgorithmException, URISyntaxException, ModuleClientException
{
addMultipleDevices(MAX_DEVICES);
// Add same desired on multiple devices
final String queryProperty = PROPERTY_KEY_QUERY + UUID.randomUUID().toString();
final String queryPropertyValue = PROPERTY_VALUE_QUERY + UUID.randomUUID().toString();
setDesiredProperties(queryProperty, queryPropertyValue, MAX_DEVICES);
// Query multiple devices having same property
final String where = "is_defined(properties.desired." + queryProperty + ")";
SqlQuery sqlQuery = SqlQuery.createSqlQuery("*", SqlQuery.FromType.DEVICES, where, null);
Thread.sleep(MAXIMUM_TIME_FOR_IOTHUB_PROPAGATION_BETWEEN_DEVICE_SERVICE_CLIENTS);
Query twinQuery = sCDeviceTwin.queryTwin(sqlQuery.getQuery(), PAGE_SIZE);
for (int i = 0; i < MAX_DEVICES; i++)
{
if (sCDeviceTwin.hasNextDeviceTwin(twinQuery))
{
DeviceTwinDevice d = sCDeviceTwin.getNextDeviceTwin(twinQuery);
assertNotNull(d.getVersion());
assertEquals(TwinConnectionState.DISCONNECTED.toString(), d.getConnectionState());
for (Pair dp : d.getDesiredProperties())
{
assertEquals(buildExceptionMessage("Unexpected desired property key, expected " + queryProperty + " but was " + dp.getKey(), internalClient), queryProperty, dp.getKey());
assertEquals(buildExceptionMessage("Unexpected desired property value, expected " + queryPropertyValue + " but was " + dp.getValue(), internalClient), queryPropertyValue, dp.getValue());
}
}
}
assertFalse(sCDeviceTwin.hasNextDeviceTwin(twinQuery));
removeMultipleDevices(MAX_DEVICES);
}
#location 35
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void constructorSetsHttpsMethodCorrectly(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection((URL) any, httpsMethod, (Proxy) any);
}
};
}
|
#vulnerable code
@Test
public void constructorSetsHttpsMethodCorrectly(@Mocked final HttpConnection mockConn, final @Mocked URL mockUrl) throws IOException
{
// Arrange
final HttpMethod httpsMethod = HttpMethod.GET;
final byte[] body = new byte[0];
new NonStrictExpectations()
{
{
mockUrl.getProtocol();
result = "http";
}
};
// Act
new HttpRequest(mockUrl, httpsMethod, body);
// Assert
new Verifications()
{
{
new HttpConnection((URL) any, httpsMethod);
}
};
}
#location 15
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
protected boolean connect() throws IOException {
if (isConnected()) {
return false;
}
Closer.close(channel());
setChannel(createSocketChannel(readTimeoutMs, keepAlive));
InetSocketAddress inetSocketAddress = new InetSocketAddress(getHost(), getPort());
if (channel().connect(inetSocketAddress)) {
return true;
}
long connectTimeoutLeft = TimeUnit.MILLISECONDS.toNanos(connectTimeoutMs);
long waitTimeoutMs = 10;
long waitTimeoutNs = TimeUnit.MILLISECONDS.toNanos(waitTimeoutMs);
boolean connected;
try {
while (!(connected = channel().finishConnect())) {
Thread.sleep(waitTimeoutMs);
connectTimeoutLeft -= waitTimeoutNs;
if (connectTimeoutLeft <= 0) {
break;
}
}
if (!connected) {
throw new ConnectException("Connection timed out. Cannot connect to " + inetSocketAddress + " within "
+ TimeUnit.NANOSECONDS.toMillis(connectTimeoutLeft) + "ms");
}
return connected;
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new IOException("Connection interrupted", e);
}
}
|
#vulnerable code
protected boolean connect() throws IOException {
if (isConnected()) {
return false;
}
if (!channel().isOpen()) {
Closer.close(channel());
setChannel(createSocketChannel(readTimeoutMs, keepAlive));
}
InetSocketAddress inetSocketAddress = new InetSocketAddress(getHost(), getPort());
if (channel().connect(inetSocketAddress)) {
return true;
}
long connectTimeoutLeft = TimeUnit.MILLISECONDS.toNanos(connectTimeoutMs);
long waitTimeoutMs = 10;
long waitTimeoutNs = TimeUnit.MILLISECONDS.toNanos(waitTimeoutMs);
boolean connected;
try {
while (!(connected = channel().finishConnect())) {
Thread.sleep(waitTimeoutMs);
connectTimeoutLeft -= waitTimeoutNs;
if (connectTimeoutLeft <= 0) {
break;
}
}
if (!connected) {
throw new ConnectException("Connection timed out. Cannot connect to " + inetSocketAddress + " within "
+ TimeUnit.NANOSECONDS.toMillis(connectTimeoutLeft) + "ms");
}
return connected;
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new IOException("Connection interrupted", e);
}
}
#location 7
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public synchronized void put(String key, Entry entry) {
pruneIfNeeded(entry.data.length);
File file = getFileForKey(key);
try {
BufferedOutputStream fos = new BufferedOutputStream(new FileOutputStream(file));
CacheHeader e = new CacheHeader(key, entry);
boolean success = e.writeHeader(fos);
if (!success) {
fos.close();
VolleyLog.d("Failed to write header for %s", file.getAbsolutePath());
throw new IOException();
}
fos.write(entry.data);
fos.close();
putEntry(key, e);
return;
} catch (IOException e) {
}
boolean deleted = file.delete();
if (!deleted) {
VolleyLog.d("Could not clean up file %s", file.getAbsolutePath());
}
}
|
#vulnerable code
@Override
public synchronized void put(String key, Entry entry) {
pruneIfNeeded(entry.data.length);
File file = getFileForKey(key);
try {
FileOutputStream fos = new FileOutputStream(file);
CacheHeader e = new CacheHeader(key, entry);
boolean success = e.writeHeader(fos);
if (!success) {
fos.close();
VolleyLog.d("Failed to write header for %s", file.getAbsolutePath());
throw new IOException();
}
fos.write(entry.data);
fos.close();
putEntry(key, e);
return;
} catch (IOException e) {
}
boolean deleted = file.delete();
if (!deleted) {
VolleyLog.d("Could not clean up file %s", file.getAbsolutePath());
}
}
#location 18
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public synchronized Entry get(String key) {
CacheHeader entry = mEntries.get(key);
// if the entry does not exist, return.
if (entry == null) {
return null;
}
File file = getFileForKey(key);
CountingInputStream cis = null;
try {
cis = new CountingInputStream(new BufferedInputStream(new FileInputStream(file)));
CacheHeader.readHeader(cis); // eat header
byte[] data = streamToBytes(cis, (int) (file.length() - cis.bytesRead));
return entry.toCacheEntry(data);
} catch (IOException e) {
VolleyLog.d("%s: %s", file.getAbsolutePath(), e.toString());
remove(key);
return null;
} finally {
if (cis != null) {
try {
cis.close();
} catch (IOException ioe) {
return null;
}
}
}
}
|
#vulnerable code
@Override
public synchronized Entry get(String key) {
CacheHeader entry = mEntries.get(key);
// if the entry does not exist, return.
if (entry == null) {
return null;
}
File file = getFileForKey(key);
CountingInputStream cis = null;
try {
cis = new CountingInputStream(new FileInputStream(file));
CacheHeader.readHeader(cis); // eat header
byte[] data = streamToBytes(cis, (int) (file.length() - cis.bytesRead));
return entry.toCacheEntry(data);
} catch (IOException e) {
VolleyLog.d("%s: %s", file.getAbsolutePath(), e.toString());
remove(key);
return null;
} finally {
if (cis != null) {
try {
cis.close();
} catch (IOException ioe) {
return null;
}
}
}
}
#location 12
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public SourceEntry buildEntry(File sourceDir, String path) {
path = FilenameUtils.separatorsToUnix(path);
String[] arr = StringUtils.split(path, "/");
SourceEntry entry = null;
for(String s: arr){
sourceDir = new File(sourceDir, s);
entry = new SourceEntry(entry, sourceDir);
}
return entry;
}
|
#vulnerable code
@Override
public SourceEntry buildEntry(File sourceDir, String path) {
path = FilenameUtils.separatorsToUnix(path);
String[] arr = StringUtils.split(path, "/");
SourceEntry entry = null;
int i = 0;
for(String s: arr){
System.out.println("[" + (i++) + "]: " + s);
sourceDir = new File(sourceDir, s);
entry = new SourceEntry(entry, sourceDir);
}
System.out.println(entry.getPath());
System.out.println(entry.getName());
System.out.println(entry.getFile().getAbsolutePath());
System.out.println(entry.getParent().getFile().getAbsolutePath());
return entry;
}
#location 14
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse response = client.execute(request);
parseResponse(response);
} catch (LogCallback.DoneException e) {
// Signifies we're finished with the log stream.
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
|
#vulnerable code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse respone = client.execute(request);
parseResponse(respone);
} catch (LogCallback.DoneException e) {
finish();
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void testSystemProperty() throws Exception {
System.setProperty("docker.push.username","roland");
System.setProperty("docker.push.password", "secret");
System.setProperty("docker.push.email", "[email protected]");
try {
AuthConfig config = factory.createAuthConfig(true, null, settings, null, null);
verifyAuthConfig(config,"roland","secret","[email protected]");
} finally {
System.clearProperty("docker.push.username");
System.clearProperty("docker.push.password");
System.clearProperty("docker.push.email");
}
}
|
#vulnerable code
@Test
public void testSystemProperty() throws Exception {
System.setProperty("docker.username","roland");
System.setProperty("docker.password", "secret");
System.setProperty("docker.email", "[email protected]");
try {
AuthConfig config = factory.createAuthConfig(null,settings, null, null);
verifyAuthConfig(config,"roland","secret","[email protected]");
} finally {
System.clearProperty("docker.username");
System.clearProperty("docker.password");
System.clearProperty("docker.email");
}
}
#location 8
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public BuildService getBuildService() {
checkDockerAccessInitialization();
return buildService;
}
|
#vulnerable code
public BuildService getBuildService() {
checkInitialization();
return buildService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private String convert(HttpEntity entity) {
try {
if (entity.isStreaming()) {
return entity.toString();
}
InputStreamReader is = new InputStreamReader(entity.getContent(),"UTF-8");
StringBuilder sb = new StringBuilder();
try (BufferedReader br = new BufferedReader(is)) {
String read = br.readLine();
while (read != null) {
//System.out.println(read);
sb.append(read);
read = br.readLine();
}
return sb.toString();
}
} catch (IOException e) {
return "[error serializing inputstream for debugging]";
}
}
|
#vulnerable code
private String convert(HttpEntity entity) {
try {
if (entity.isStreaming()) {
return entity.toString();
}
InputStreamReader is = new InputStreamReader(entity.getContent());
StringBuilder sb = new StringBuilder();
BufferedReader br = new BufferedReader(is);
String read = br.readLine();
while (read != null) {
//System.out.println(read);
sb.append(read);
read = br.readLine();
}
return sb.toString();
} catch (IOException e) {
return "[error serializing inputstream for debugging]";
}
}
#location 17
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public ArchiveService getArchiveService() {
return archiveService;
}
|
#vulnerable code
public ArchiveService getArchiveService() {
checkBaseInitialization();
return archiveService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public File createDockerTarArchive(String imageName, MojoParameters params, BuildImageConfiguration buildConfig) throws MojoExecutionException {
BuildDirs buildDirs = createBuildDirs(imageName, params);
AssemblyConfiguration assemblyConfig = buildConfig.getAssemblyConfiguration();
AssemblyMode assemblyMode = (assemblyConfig == null) ? AssemblyMode.dir : assemblyConfig.getMode();
if (hasAssemblyConfiguration(assemblyConfig)) {
createAssemblyArchive(assemblyConfig, params, buildDirs);
}
try {
File extraDir = null;
String dockerFileDir = assemblyConfig != null ? assemblyConfig.getDockerFileDir() : null;
if (dockerFileDir != null) {
// Use specified docker directory which must include a Dockerfile.
extraDir = validateDockerDir(params, dockerFileDir);
} else {
// Create custom docker file in output dir
DockerFileBuilder builder = createDockerFileBuilder(buildConfig, assemblyConfig);
builder.write(buildDirs.getOutputDirectory());
}
return createTarball(buildDirs, extraDir, assemblyMode);
} catch (IOException e) {
throw new MojoExecutionException(String.format("Cannot create Dockerfile in %s", buildDirs.getOutputDirectory()), e);
}
}
|
#vulnerable code
public File createDockerTarArchive(String imageName, MojoParameters params, BuildImageConfiguration buildConfig) throws MojoExecutionException {
AssemblyConfiguration assemblyConfig = buildConfig.getAssemblyConfiguration();
BuildDirs buildDirs = createBuildDirs(imageName, params);
try {
if (assemblyConfig != null &&
(assemblyConfig.getInline() != null ||
assemblyConfig.getDescriptor() != null ||
assemblyConfig.getDescriptorRef() != null)) {
createAssemblyArchive(assemblyConfig, params, buildDirs);
}
File extraDir = null;
String dockerFileDir = assemblyConfig != null ? assemblyConfig.getDockerFileDir() : null;
if (dockerFileDir != null) {
// Use specified docker directory which must include a Dockerfile.
extraDir = validateDockerDir(params, dockerFileDir);
} else {
// Create custom docker file in output dir
DockerFileBuilder builder = createDockerFileBuilder(buildConfig, assemblyConfig);
builder.write(buildDirs.getOutputDirectory());
}
return createTarball(buildDirs, extraDir, assemblyConfig.getMode());
} catch (IOException e) {
throw new MojoExecutionException(String.format("Cannot create Dockerfile in %s", buildDirs.getOutputDirectory()), e);
}
}
#location 23
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
protected void executeInternal(ServiceHub hub) throws MojoExecutionException, DockerAccessException {
QueryService queryService = hub.getQueryService();
LogDispatcher logDispatcher = getLogDispatcher(hub);
for (ImageConfiguration image : getResolvedImages()) {
String imageName = image.getName();
if (logAll) {
for (Container container : queryService.getContainersForImage(imageName)) {
doLogging(logDispatcher, image, container.getId());
}
} else {
Container container = queryService.getLatestContainerForImage(imageName);
if (container != null) {
doLogging(logDispatcher, image, container.getId());
}
}
}
if (follow) {
// Block forever ....
waitForEver();
}
}
|
#vulnerable code
@Override
protected void executeInternal(ServiceHub hub) throws MojoExecutionException, DockerAccessException {
QueryService queryService = hub.getQueryService();
LogDispatcher logDispatcher = getLogDispatcher(hub);
for (ImageConfiguration image : getResolvedImages()) {
String imageName = image.getName();
if (logAll) {
for (Container container : queryService.getContainersForImage(imageName)) {
doLogging(logDispatcher, image, container.getId());
}
} else {
Container container = queryService.getLatestContainerForImage(imageName);
doLogging(logDispatcher, image, container.getId());
}
}
if (follow) {
// Block forever ....
waitForEver();
}
}
#location 10
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse response = client.execute(request);
parseResponse(response);
} catch (LogCallback.DoneException e) {
// Signifies we're finished with the log stream.
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
|
#vulnerable code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse respone = client.execute(request);
parseResponse(respone);
} catch (LogCallback.DoneException e) {
finish();
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
#location 5
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void testFromSettingsDefault() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(isPush, null, settings, "rhuss", "test.org");
assertNotNull(config);
verifyAuthConfig(config, "rhuss", "secret2", "[email protected]");
}
|
#vulnerable code
@Test
public void testFromSettingsDefault() throws MojoExecutionException {
setupServers();
AuthConfig config = factory.createAuthConfig(null,settings, "rhuss", "test.org");
assertNotNull(config);
verifyAuthConfig(config, "rhuss", "secret2", "[email protected]");
}
#location 6
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public RunService getRunService() {
checkDockerAccessInitialization();
return runService;
}
|
#vulnerable code
public RunService getRunService() {
checkInitialization();
return runService;
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void testFromPluginConfiguration() throws MojoExecutionException {
Map pluginConfig = new HashMap();
pluginConfig.put("username", "roland");
pluginConfig.put("password", "secret");
pluginConfig.put("email", "[email protected]");
AuthConfig config = factory.createAuthConfig(isPush, pluginConfig, settings, null, null);
verifyAuthConfig(config, "roland", "secret", "[email protected]");
}
|
#vulnerable code
@Test
public void testFromPluginConfiguration() throws MojoExecutionException {
Map pluginConfig = new HashMap();
pluginConfig.put("username", "roland");
pluginConfig.put("password", "secret");
pluginConfig.put("email", "[email protected]");
AuthConfig config = factory.createAuthConfig(pluginConfig,settings,null,null);
verifyAuthConfig(config, "roland", "secret", "[email protected]");
}
#location 9
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public synchronized void fetchContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
dockerAccess.getLogSync(containerId, createLogCallback(spec));
}
|
#vulnerable code
public synchronized void fetchContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
dockerAccess.getLogSync(containerId, new DefaultLogCallback(spec));
}
#location 2
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public MojoExecutionService getMojoExecutionService() {
return mojoExecutionService;
}
|
#vulnerable code
public MojoExecutionService getMojoExecutionService() {
checkBaseInitialization();
return mojoExecutionService;
}
#location 2
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public synchronized void trackContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
LogGetHandle handle = dockerAccess.getLogAsync(containerId, createLogCallback(spec));
logHandles.put(containerId, handle);
}
|
#vulnerable code
public synchronized void trackContainerLog(String containerId, LogOutputSpec spec) throws FileNotFoundException {
LogGetHandle handle = dockerAccess.getLogAsync(containerId, new DefaultLogCallback(spec));
logHandles.put(containerId, handle);
}
#location 2
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse response = client.execute(request);
parseResponse(response);
} catch (LogCallback.DoneException e) {
// Signifies we're finished with the log stream.
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
|
#vulnerable code
public void fetchLogs() {
try {
callback.open();
this.request = getLogRequest(false);
final HttpResponse respone = client.execute(request);
parseResponse(respone);
} catch (LogCallback.DoneException e) {
finish();
} catch (IOException exp) {
callback.error(exp.getMessage());
} finally {
callback.close();
}
}
#location 6
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void variableReplacement() throws MojoExecutionException {
PortMapping mapping = createPortMapping("jolokia.port:8080","18181:8181","127.0.0.1:9090:9090", "127.0.0.1:other.port:5678");
updateDynamicMapping(mapping, 8080, 49900);
updateDynamicMapping(mapping, 5678, 49901);
mapAndVerifyReplacement(mapping,
"http://localhost:49900/", "http://localhost:${jolokia.port}/",
"http://pirx:49900/", "http://pirx:${ jolokia.port}/");
mapAndVerifyReplacement(mapping,
"http://localhost:49901/", "http://localhost:${other.port}/",
"http://pirx:49901/", "http://pirx:${ other.port}/",
"http://49900/49901","http://${jolokia.port}/${other.port}");
assertEquals((int) mapping.getPortVariables().get("jolokia.port"), 49900);
assertEquals((int) mapping.getPortVariables().get("other.port"), 49901);
assertTrue(mapping.containsDynamicPorts());
assertEquals(4, mapping.getContainerPorts().size());
assertEquals(4, mapping.getPortsMap().size());
assertEquals(2, mapping.getBindToHostMap().size());
assertEquals(49900, (long) mapping.getPortVariables().get("jolokia.port"));
assertEquals(49901, (long) mapping.getPortVariables().get("other.port"));
Map<String,Integer> p = mapping.getPortsMap();
assertEquals(p.size(),4);
assertNull(p.get("8080/tcp"));
assertNull(p.get("5678/tcp"));
assertEquals(18181, (long) p.get("8181/tcp"));
assertEquals(9090, (long) p.get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("5678/tcp"));
}
|
#vulnerable code
@Test
public void variableReplacement() throws MojoExecutionException {
PortMapping mapping = createPortMapping("jolokia.port:8080","18181:8181","127.0.0.1:9090:9090", "127.0.0.1:other.port:5678");
updateDynamicMapping(mapping, 8080, 49900);
updateDynamicMapping(mapping, 5678, 49901);
mapAndVerifyReplacement(mapping,
"http://localhost:49900/", "http://localhost:${jolokia.port}/",
"http://pirx:49900/", "http://pirx:${ jolokia.port}/");
mapAndVerifyReplacement(mapping,
"http://localhost:49901/", "http://localhost:${other.port}/",
"http://pirx:49901/", "http://pirx:${ other.port}/");
assertEquals((int) mapping.getPortVariables().get("jolokia.port"), 49900);
assertEquals((int) mapping.getPortVariables().get("other.port"), 49901);
assertTrue(mapping.containsDynamicPorts());
assertEquals(4, mapping.getContainerPorts().size());
assertEquals(4, mapping.getPortsMap().size());
assertEquals(2, mapping.getBindToHostMap().size());
assertEquals(49900, (long) mapping.getPortVariables().get("jolokia.port"));
assertEquals(49901, (long) mapping.getPortVariables().get("other.port"));
Map<String,Integer> p = mapping.getPortsMap();
assertEquals(p.size(),4);
assertNull(p.get("8080/tcp"));
assertNull(p.get("5678/tcp"));
assertEquals(18181, (long) p.get("8181/tcp"));
assertEquals(9090, (long) p.get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("9090/tcp"));
assertEquals("127.0.0.1", mapping.getBindToHostMap().get("5678/tcp"));
}
#location 17
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public static String getVersion() {
try {
return CFLintMain.class.getPackage().getImplementationVersion();
} catch (Exception e) {
return "";
}
}
|
#vulnerable code
public static String getVersion() {
final InputStream is = Version.class
.getResourceAsStream("/META-INF/maven/com.github.cflint/CFLint/pom.properties");
try {
final BufferedReader reader = new BufferedReader(new InputStreamReader(is));
String line = reader.readLine();
while (line != null && !line.startsWith("version=")) {
line = reader.readLine();
}
if (line != null) {
return line.replaceAll("version=", "");
}
} catch (final Exception e) {
try {
if (is != null) {
is.close();
}
} catch (final IOException e1) {
e1.printStackTrace();
}
}
return "";
}
#location 13
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
static String load(final File file) {
FileInputStream fis = null;
try {
fis = new FileInputStream(file);
final byte[] b = new byte[fis.available()];
fis.read(b);
return new String(b);
} catch (final Exception e) {
return null;
} finally {
try {
if (fis != null)
fis.close();
} catch (IOException e) {
return null;
}
}
}
|
#vulnerable code
static String load(final File file) {
FileInputStream fis;
try {
fis = new FileInputStream(file);
final byte[] b = new byte[fis.available()];
fis.read(b);
return new String(b);
} catch (final Exception e) {
return null;
}
}
#location 6
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
protected void registerRuleOverrides(Context context, final Token functionToken) {
final String mlText = PrecedingCommentReader.getMultiLine(context, functionToken);
if(mlText != null && !mlText.isEmpty()){
final Pattern pattern = Pattern.compile(".*\\s*@CFLintIgnore\\s+([\\w,_]+)\\s*.*", Pattern.DOTALL);
final Matcher matcher = pattern.matcher(mlText);
if (matcher.matches()) {
String ignoreCodes = matcher.group(1);
context.ignore(Arrays.asList(ignoreCodes.split(",\\s*")));
}
}
}
|
#vulnerable code
protected void registerRuleOverrides(Context context, final Token functionToken) {
Iterable<Token> tokens = context.beforeTokens(functionToken);
for (Token currentTok : tokens) {
if (currentTok.getChannel() == Token.HIDDEN_CHANNEL && currentTok.getType() == CFSCRIPTLexer.ML_COMMENT) {
String mlText = currentTok.getText();
Pattern pattern = Pattern.compile(".*\\s*@CFLintIgnore\\s+([\\w,_]+)\\s*.*", Pattern.DOTALL);
Matcher matcher = pattern.matcher(mlText);
if (matcher.matches()) {
String ignoreCodes = matcher.group(1);
context.ignore(Arrays.asList(ignoreCodes.split(",\\s*")));
}
} else if (currentTok.getLine() < functionToken.getLine()) {
break;
}
}
}
#location 4
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private void execute() throws IOException, TransformerException, JAXBException, MarshallerException {
final CFLint cflint = new CFLint(buildConfigChain());
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setStrictIncludes(strictInclude);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if (extensions != null && extensions.trim().length() > 0) {
try {
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
} catch (final Exception e) {
System.err.println(
"Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
final CFLintFilter filter = createBaseFilter();
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
final StringBuilder source = new StringBuilder();
final Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
final String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
final Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out)
: createWriter(xmlOutFile, StandardCharsets.UTF_8);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if (verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter, showStats, cflint.getStats());
} else {
if (verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new DefaultCFlintResultMarshaller().output(cflint.getBugs(), xmlwriter, showStats);
}
}
if (textOutput) {
if (textOutFile != null && verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
final Writer textwriter = stdOut || textOutFile == null ? new OutputStreamWriter(System.out)
: new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter, showStats);
}
if (htmlOutput) {
try {
if (verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
final Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter, showStats, cflint.getStats());
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if (verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
final Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter, showStats);
}
if (verbose) {
display("Total files scanned: " + cflint.getStats().getFileCount());
display("Total size: " + cflint.getStats().getTotalSize());
}
}
|
#vulnerable code
private void execute() throws IOException, TransformerException, JAXBException, MarshallerException {
final CFLint cflint = new CFLint(buildConfigChain());
cflint.setVerbose(verbose);
cflint.setLogError(logerror);
cflint.setQuiet(quiet);
cflint.setStrictIncludes(strictInclude);
cflint.setShowProgress(showprogress);
cflint.setProgressUsesThread(progressUsesThread);
if (extensions != null && extensions.trim().length() > 0) {
try {
cflint.setAllowedExtensions(Arrays.asList(extensions.trim().split(",")));
} catch (final Exception e) {
System.err.println(
"Unable to use extensions (" + extensions + ") using default instead. " + e.getMessage());
}
}
final CFLintFilter filter = createBaseFilter();
cflint.getBugs().setFilter(filter);
for (final String scanfolder : folder) {
cflint.scan(scanfolder);
}
if (stdIn) {
final StringBuilder source = new StringBuilder();
final Scanner scanner = new Scanner(System.in);
while (scanner.hasNextLine()) {
final String nextLine = scanner.nextLine();
source.append(nextLine);
source.append(System.lineSeparator());
}
scanner.close();
cflint.process(source.toString(), stdInFile);
}
if (xmlOutput) {
final Writer xmlwriter = stdOut ? new OutputStreamWriter(System.out)
: createWriter(xmlOutFile, StandardCharsets.UTF_8);
if ("findbugs".equalsIgnoreCase(xmlstyle)) {
if (verbose) {
display("Writing XML findbugs style" + (stdOut ? "." : " to " + xmlOutFile));
}
new XMLOutput().outputFindBugs(cflint.getBugs(), xmlwriter, showStats);
} else {
if (verbose) {
display("Writing XML" + (stdOut ? "." : " to " + xmlOutFile));
}
new DefaultCFlintResultMarshaller().output(cflint.getBugs(), xmlwriter, showStats);
}
}
if (textOutput) {
if (textOutFile != null && verbose) {
display("Writing text" + (stdOut ? "." : " to " + textOutFile));
}
final Writer textwriter = stdOut || textOutFile == null ? new OutputStreamWriter(System.out)
: new FileWriter(textOutFile);
new TextOutput().output(cflint.getBugs(), textwriter, showStats);
}
if (htmlOutput) {
try {
if (verbose) {
display("Writing HTML" + (stdOut ? "." : " to " + htmlOutFile));
}
final Writer htmlwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(htmlOutFile);
new HTMLOutput(htmlStyle).output(cflint.getBugs(), htmlwriter, showStats);
} catch (final TransformerException e) {
throw new IOException(e);
}
}
if (jsonOutput) {
if (verbose) {
display("Writing JSON" + (stdOut ? "." : " to " + jsonOutFile));
}
final Writer jsonwriter = stdOut ? new OutputStreamWriter(System.out) : new FileWriter(jsonOutFile);
new JSONOutput().output(cflint.getBugs(), jsonwriter, showStats);
}
if (verbose) {
display("Total files scanned: " + cflint.getStats().getFileCount());
display("Total size: " + cflint.getStats().getTotalSize());
}
}
#location 18
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private void mergeConfigFileInFilter(CFLintFilter filter)
{
CFLintConfig cfg = loadConfig(configfile);
if(cfg != null){
for(PluginMessage message : cfg.getIncludes())
{
filter.includeCode(message.getCode());
}
for(PluginMessage message : cfg.getExcludes())
{
filter.excludeCode(message.getCode());
}
}
}
|
#vulnerable code
private void mergeConfigFileInFilter(CFLintFilter filter)
{
CFLintConfig cfg = loadConfig(configfile);
for(PluginMessage message : cfg.getIncludes())
{
filter.includeCode(message.getCode());
}
for(PluginMessage message : cfg.getExcludes())
{
filter.excludeCode(message.getCode());
}
}
#location 4
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void expression(final CFExpression expression, final Context context, final BugList bugs) {
String repeatThreshold = getParameter("maximum");
String maxWarnings = getParameter("maxWarnings");
String warningScope = getParameter("warningScope");
if (repeatThreshold != null) {
threshold = Integer.parseInt(repeatThreshold);
}
if (maxWarnings != null) {
warningThreshold = Integer.parseInt(maxWarnings);
}
if (expression instanceof CFLiteral) {
CFLiteral literal = (CFLiteral) expression;
String name = literal.Decompile(0).replace("'","");
if (isCommon(name)) {
return;
}
int lineNo = literal.getLine() + context.startLine() - 1;
if (warningScope == null || warningScope.equals("global")) {
literalCount(name, lineNo, globalLiterals, true, context, bugs);
}
else if (warningScope.equals("local")) {
literalCount(name, lineNo, functionListerals, false, context, bugs);
}
}
}
|
#vulnerable code
@Override
public void expression(final CFExpression expression, final Context context, final BugList bugs) {
String repeatThreshold = getParameter("maximum");
int threshold = REPEAT_THRESHOLD;
if (repeatThreshold != null) {
threshold = Integer.parseInt(repeatThreshold);
}
if (expression instanceof CFLiteral) {
CFLiteral literal = (CFLiteral) expression;
String name = literal.Decompile(0).replace("'","");
int count = 1;
if (isCommon(name)) {
return;
}
if (literals.get(name) == null) {
literals.put(name, count);
done.put(name, false);
}
else {
count = literals.get(name);
count++;
literals.put(name, count);
}
if (count > threshold && !done.get(name)) {
int lineNo = literal.getLine() + context.startLine() - 1;
magicValue(name, lineNo, context, bugs);
done.put(name, true);
}
}
}
#location 29
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public AsyncIOWriter write(AtmosphereResponse r, byte[] data, int offset, int length) throws IOException {
boolean transform = filters.size() > 0 && r.getStatus() < 400;
if (transform) {
data = transform(r, data, offset, length);
offset = 0;
length = data.length;
}
logger.trace("About to write to {}", r.resource() != null ? r.resource().uuid() : "null");
if (channel.isOpen()) {
final ChannelBuffer buffer = ChannelBuffers.dynamicBuffer();
pendingWrite.incrementAndGet();
if (writeHeader && !headerWritten) {
buffer.writeBytes(constructStatusAndHeaders(r).getBytes("UTF-8"));
headerWritten = true;
}
if (headerWritten) {
buffer.writeBytes(Integer.toHexString(length - offset).getBytes("UTF-8"));
buffer.writeBytes(CHUNK_DELIMITER);
}
buffer.writeBytes(data, offset, length);
if (headerWritten) {
buffer.writeBytes(CHUNK_DELIMITER);
}
channel.write(buffer).addListener(listener);
byteWritten = true;
lastWrite = System.currentTimeMillis();
} else {
logger.debug("Trying to write on a closed channel {}", channel);
throw new IOException("Channel closed");
}
headerWritten = true;
return this;
}
|
#vulnerable code
@Override
public AsyncIOWriter write(AtmosphereResponse r, byte[] data, int offset, int length) throws IOException {
boolean transform = filters.size() > 0 && r.getStatus() < 400;
if (transform) {
data = transform(r, data, offset, length);
offset = 0;
length = data.length;
}
logger.trace("About to write to {}", r.resource() != null ? r.resource().uuid() : "null");
if (channel.isOpen()) {
final ChannelBuffer buffer = ChannelBuffers.dynamicBuffer();
pendingWrite.incrementAndGet();
if (writeHeader && !headerWritten) {
buffer.writeBytes(constructStatusAndHeaders(r).getBytes("UTF-8"));
headerWritten = true;
}
ChannelBufferOutputStream c = new ChannelBufferOutputStream(buffer);
if (headerWritten) {
c.write(Integer.toHexString(length - offset).getBytes("UTF-8"));
c.write(CHUNK_DELIMITER);
}
c.write(data, offset, length);
if (headerWritten) {
c.write(CHUNK_DELIMITER);
}
channel.write(c.buffer()).addListener(listener);
byteWritten = true;
lastWrite = System.currentTimeMillis();
} else {
logger.debug("Trying to write on a closed channel {}", channel);
throw new IOException("Channel closed");
}
headerWritten = true;
return this;
}
#location 32
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
pipelineStop();
image = null;
}
|
#vulnerable code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
image = null;
LOG.debug("Unlink elements");
pipe.setState(State.NULL);
Element.unlinkMany(source, filter, sink);
pipe.removeMany(source, filter, sink);
}
#location 14
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void resume() {
if (!paused) {
return;
}
paused = false;
}
|
#vulnerable code
public void resume() {
if (!paused) {
return;
}
synchronized (repainter) {
repainter.notifyAll();
}
paused = false;
}
#location 5
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
}
|
#vulnerable code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegparse.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
}
#location 14
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
pipelineStop();
image = null;
}
|
#vulnerable code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
image = null;
LOG.debug("Unlink elements");
pipe.setState(State.NULL);
Element.unlinkMany(source, filter, sink);
pipe.removeMany(source, filter, sink);
}
#location 16
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegparse.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
}
|
#vulnerable code
@Override
public void dispose() {
if (!disposed.compareAndSet(false, true)) {
return;
}
LOG.debug("Disposing GStreamer device");
close();
source.dispose();
filter.dispose();
jpegpar.dispose();
jpegdec.dispose();
caps.dispose();
sink.dispose();
pipe.dispose();
}
#location 14
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
pipelineStop();
image = null;
}
|
#vulnerable code
@Override
public void close() {
if (!open.compareAndSet(true, false)) {
return;
}
LOG.debug("Closing GStreamer device");
image = null;
LOG.debug("Unlink elements");
pipe.setState(State.NULL);
Element.unlinkMany(source, filter, sink);
pipe.removeMany(source, filter, sink);
}
#location 15
#vulnerability type THREAD_SAFETY_VIOLATION
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private static String streamToString(InputStream inputStream) throws IOException {
InputStreamReader reader = new InputStreamReader(inputStream, StandardCharsets.UTF_8);
return CharStreams.toString(reader);
}
|
#vulnerable code
private static String streamToString(InputStream inputStream) throws IOException {
StringBuilder stringBuilder = new StringBuilder();
Reader reader = new InputStreamReader(inputStream, StandardCharsets.UTF_8);
char[] buffer = new char[256];
int length;
while ((length = reader.read(buffer)) != -1) {
stringBuilder.append(buffer, 0, length);
}
inputStream.close();
return stringBuilder.toString();
}
#location 10
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private List<ApiParamDoc> getQueryParamsFromSpringAnnotation(Method method, Class<?> controller) {
List<ApiParamDoc> apiParamDocs = new ArrayList<ApiParamDoc>();
if(controller.isAnnotationPresent(RequestMapping.class)) {
RequestMapping requestMapping = controller.getAnnotation(RequestMapping.class);
if(requestMapping.params().length > 0) {
for (String param : requestMapping.params()) {
String[] splitParam = param.split("=");
if(splitParam != null) {
apiParamDocs.add(new ApiParamDoc(splitParam[0], null, JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{splitParam[1]}, null, null));
} else {
apiParamDocs.add(new ApiParamDoc(param, null, JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{}, null, null));
}
}
}
}
if(method.isAnnotationPresent(RequestMapping.class)) {
RequestMapping requestMapping = method.getAnnotation(RequestMapping.class);
if(requestMapping.params().length > 0) {
apiParamDocs.clear();
for (String param : requestMapping.params()) {
String[] splitParam = param.split("=");
if(splitParam.length > 1) {
apiParamDocs.add(new ApiParamDoc(splitParam[0], "", JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{splitParam[1]}, null, null));
} else {
apiParamDocs.add(new ApiParamDoc(param, "", JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{}, null, null));
}
}
}
}
return apiParamDocs;
}
|
#vulnerable code
private List<ApiParamDoc> getQueryParamsFromSpringAnnotation(Method method, Class<?> controller) {
List<ApiParamDoc> apiParamDocs = new ArrayList<ApiParamDoc>();
if(controller.isAnnotationPresent(RequestMapping.class)) {
RequestMapping requestMapping = controller.getAnnotation(RequestMapping.class);
if(requestMapping.params().length > 0) {
for (String param : requestMapping.params()) {
String[] splitParam = param.split("=");
if(splitParam != null) {
apiParamDocs.add(new ApiParamDoc(splitParam[0], null, JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{splitParam[1]}, null, null));
} else {
apiParamDocs.add(new ApiParamDoc(param, null, JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{}, null, null));
}
}
}
}
if(controller.isAnnotationPresent(RequestMapping.class)) {
RequestMapping requestMapping = method.getAnnotation(RequestMapping.class);
if(requestMapping.params().length > 0) {
apiParamDocs.clear();
for (String param : requestMapping.params()) {
String[] splitParam = param.split("=");
if(splitParam.length > 1) {
apiParamDocs.add(new ApiParamDoc(splitParam[0], "", JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{splitParam[1]}, null, null));
} else {
apiParamDocs.add(new ApiParamDoc(param, "", JSONDocTypeBuilder.build(new JSONDocType(), String.class, null), "true", new String[]{}, null, null));
}
}
}
}
return apiParamDocs;
}
#location 24
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@SuppressWarnings("resource")
@Override
public CBORParser createParser(File f) throws IOException {
IOContext ctxt = _createContext(f, true);
return _createParser(_decorate(new FileInputStream(f), ctxt), ctxt);
}
|
#vulnerable code
@SuppressWarnings("resource")
@Override
public CBORParser createParser(File f) throws IOException {
return _createParser(new FileInputStream(f), _createContext(f, true));
}
#location 4
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private JsonToken _handleNestedKey(int tag) throws IOException
{
int wireType = (tag & 0x7);
int id = (tag >> 3);
ProtobufField f;
if ((_currentField == null) || (f = _currentField.nextOrThisIf(id)) == null) {
f = _currentMessage.field(id);
}
// Note: may be null; if so, value needs to be skipped
if (f == null) {
return _skipUnknownField(id, wireType);
}
_parsingContext.setCurrentName(f.name);
if (!f.isValidFor(wireType)) {
_reportIncompatibleType(f, wireType);
}
// array?
if (f.repeated) {
if (f.packed) {
_state = STATE_ARRAY_START_PACKED;
} else {
_state = STATE_ARRAY_START;
}
} else {
_state = STATE_NESTED_VALUE;
}
_currentField = f;
return (_currToken = JsonToken.FIELD_NAME);
}
|
#vulnerable code
private JsonToken _handleNestedKey(int tag) throws IOException
{
int wireType = (tag & 0x7);
int id = (tag >> 3);
ProtobufField f;
if ((_currentField == null) || (f = _currentField.nextOrThisIf(id)) == null) {
f = _currentMessage.field(id);
}
_parsingContext.setCurrentName(f.name);
if (!f.isValidFor(wireType)) {
_reportIncompatibleType(f, wireType);
}
// array?
if (f.repeated) {
if (f.packed) {
_state = STATE_ARRAY_START_PACKED;
} else {
_state = STATE_ARRAY_START;
}
} else {
_state = STATE_NESTED_VALUE;
}
_currentField = f;
return (_currToken = JsonToken.FIELD_NAME);
}
#location 10
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void testGarbageCollectorExports() {
assertEquals(
100L,
registry.getSampleValue(
"jvm_gc_collection_seconds_count",
new String[]{"gc"},
new String[]{"MyGC1"}),
.0000001);
assertEquals(
10d,
registry.getSampleValue(
"jvm_gc_collection_seconds_sum",
new String[]{"gc"},
new String[]{"MyGC1"}),
.0000001);
assertEquals(
200L,
registry.getSampleValue(
"jvm_gc_collection_seconds_count",
new String[]{"gc"},
new String[]{"MyGC2"}),
.0000001);
assertEquals(
20d,
registry.getSampleValue(
"jvm_gc_collection_seconds_sum",
new String[]{"gc"},
new String[]{"MyGC2"}),
.0000001);
}
|
#vulnerable code
@Test
public void testGarbageCollectorExports() {
assertEquals(
100L,
registry.getSampleValue(
GarbageCollectorExports.COLLECTIONS_COUNT_METRIC,
new String[]{"gc"},
new String[]{"MyGC1"}),
.0000001);
assertEquals(
10d,
registry.getSampleValue(
GarbageCollectorExports.COLLECTIONS_TIME_METRIC,
new String[]{"gc"},
new String[]{"MyGC1"}),
.0000001);
assertEquals(
200L,
registry.getSampleValue(
GarbageCollectorExports.COLLECTIONS_COUNT_METRIC,
new String[]{"gc"},
new String[]{"MyGC2"}),
.0000001);
assertEquals(
20d,
registry.getSampleValue(
GarbageCollectorExports.COLLECTIONS_TIME_METRIC,
new String[]{"gc"},
new String[]{"MyGC2"}),
.0000001);
}
#location 5
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void priceFormat() {
assertEquals("%7.2f ", FRACTIONS.get("FOO").getPriceFormat());
}
|
#vulnerable code
@Test
public void priceFormat() {
assertEquals("%7.2f ", INSTRUMENTS.get("FOO").getPriceFormat());
}
#location 3
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private static void listen(boolean taq, Config config) throws IOException {
Instruments instruments = Instruments.fromConfig(config, "instruments");
MarketDataListener listener = taq ? new TAQFormat(instruments) : new DisplayFormat(instruments);
Market market = new Market(listener);
for (Instrument instrument : instruments)
market.open(instrument.asLong());
MarketDataProcessor processor = new MarketDataProcessor(market, listener);
listen(config, new PMDParser(processor));
}
|
#vulnerable code
private static void listen(boolean taq, Config config) throws IOException {
List<String> instruments = config.getStringList("instruments");
MarketDataListener listener = taq ? new TAQFormat() : new DisplayFormat(instruments);
Market market = new Market(listener);
for (String instrument : instruments)
market.open(ASCII.packLong(instrument));
MarketDataProcessor processor = new MarketDataProcessor(market, listener);
listen(config, new PMDParser(processor));
}
#location 13
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Test
public void priceFactor() {
assertEquals(100.0, FRACTIONS.get("FOO").getPriceFactor(), 0.0);
}
|
#vulnerable code
@Test
public void priceFactor() {
assertEquals(100.0, INSTRUMENTS.get("FOO").getPriceFactor(), 0.0);
}
#location 3
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void add(long instrument, long orderId, Side side, long price, long size) {
if (orders.containsKey(orderId))
return;
OrderBook book = books.get(instrument);
if (book == null)
return;
Order order = new Order(book, side, price, size);
book.add(side, price, size);
orders.put(orderId, order);
if (order.isOnBestLevel())
book.bbo(listener);
}
|
#vulnerable code
public void add(long instrument, long orderId, Side side, long price, long size) {
if (orders.containsKey(orderId))
return;
OrderBook book = books.get(instrument);
if (book == null)
return;
Order order = book.add(side, price, size);
orders.put(orderId, order);
if (order.isOnBestLevel())
book.bbo(listener);
}
#location 12
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void run() throws IOException {
LineReader reader = LineReaderBuilder.builder()
.completer(new StringsCompleter(Commands.names().castToList()))
.build();
printf("Type 'help' for help.\n");
while (!closed) {
String line = reader.readLine("> ");
if (line == null)
break;
Scanner scanner = scan(line);
if (!scanner.hasNext())
continue;
Command command = Commands.find(scanner.next());
if (command == null) {
printf("error: Unknown command\n");
continue;
}
try {
command.execute(this, scanner);
} catch (CommandException e) {
printf("Usage: %s\n", command.getUsage());
} catch (ClosedChannelException e) {
printf("error: Connection closed\n");
}
}
close();
}
|
#vulnerable code
public void run() throws IOException {
ConsoleReader reader = new ConsoleReader();
reader.addCompleter(new StringsCompleter(Commands.names().castToList()));
printf("Type 'help' for help.\n");
while (!closed) {
String line = reader.readLine("> ");
if (line == null)
break;
Scanner scanner = scan(line);
if (!scanner.hasNext())
continue;
Command command = Commands.find(scanner.next());
if (command == null) {
printf("error: Unknown command\n");
continue;
}
try {
command.execute(this, scanner);
} catch (CommandException e) {
printf("Usage: %s\n", command.getUsage());
} catch (ClosedChannelException e) {
printf("error: Connection closed\n");
}
}
close();
}
#location 10
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
private static void main(Config config) throws IOException {
MarketDataServer marketData = marketData(config);
MarketReportServer marketReport = marketReport(config);
List<String> instruments = config.getStringList("instruments");
MatchingEngine engine = new MatchingEngine(instruments, marketData, marketReport);
int orderEntryPort = Configs.getPort(config, "order-entry.port");
OrderEntryServer orderEntry = OrderEntryServer.create(orderEntryPort, engine);
marketData.version();
new Events(marketData, marketReport, orderEntry).run();
}
|
#vulnerable code
private static void main(Config config) throws IOException {
MarketDataServer marketData = marketData(config);
String marketReportSession = config.getString("market-report.session");
InetAddress marketReportMulticastGroup = Configs.getInetAddress(config, "market-report.multicast-group");
int marketReportMulticastPort = Configs.getPort(config, "market-report.multicast-port");
int marketReportRequestPort = Configs.getPort(config, "market-report.request-port");
MarketReportServer marketReport = MarketReportServer.create(marketReportSession,
new InetSocketAddress(marketReportMulticastGroup, marketReportMulticastPort),
marketReportRequestPort);
List<String> instruments = config.getStringList("instruments");
MatchingEngine engine = new MatchingEngine(instruments, marketData, marketReport);
int orderEntryPort = Configs.getPort(config, "order-entry.port");
OrderEntryServer orderEntry = OrderEntryServer.create(orderEntryPort, engine);
marketData.version();
new Events(marketData, marketReport, orderEntry).run();
}
#location 23
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public void run(ApplicationArguments args) throws Exception {
try {
// 测试 Redis连接是否正常
redisService.exists("febs_test");
} catch (Exception e) {
log.error(" ____ __ _ _ ");
log.error("| |_ / /\\ | | | |");
log.error("|_| /_/--\\ |_| |_|__");
log.error(" ");
log.error("FEBS启动失败，{}", e.getMessage());
log.error("Redis连接异常，请检查Redis连接配置并确保Redis服务已启动");
// 关闭 FEBS
context.close();
}
if (context.isActive()) {
InetAddress address = InetAddress.getLocalHost();
String url = String.format("http://%s:%s", address.getHostAddress(), port);
String loginUrl = febsProperties.getShiro().getLoginUrl();
if (StringUtils.isNotBlank(contextPath))
url += contextPath;
if (StringUtils.isNotBlank(loginUrl))
url += loginUrl;
log.info(" __ ___ _ ___ _ ____ _____ ____ ");
log.info("/ /` / / \\ | |\\/| | |_) | | | |_ | | | |_ ");
log.info("\\_\\_, \\_\\_/ |_| | |_| |_|__ |_|__ |_| |_|__ ");
log.info(" ");
log.info("FEBS 权限系统启动完毕，地址：{}", url);
boolean auto = febsProperties.isAutoOpenBrowser();
String[] autoEnv = febsProperties.getAutoOpenBrowserEnv();
if (auto && ArrayUtils.contains(autoEnv, active)) {
String os = System.getProperty("os.name");
// 默认为 windows时才自动打开页面
if (StringUtils.containsIgnoreCase(os, "windows")) {
//使用默认浏览器打开系统登录页
Runtime.getRuntime().exec("cmd /c start " + url);
}
}
}
}
|
#vulnerable code
@Override
public void run(ApplicationArguments args) throws Exception {
try {
// 测试 Redis连接是否正常
redisService.exists("febs_test");
} catch (Exception e) {
log.error(" ____ __ _ _ ");
log.error("| |_ / /\\ | | | |");
log.error("|_| /_/--\\ |_| |_|__");
log.error(" ");
log.error("FEBS启动失败，{}", e.getMessage());
log.error("Redis连接异常，请检查Redis连接配置并确保Redis服务已启动");
// 关闭 FEBS
context.close();
}
if (context.isActive()) {
InetAddress address = InetAddress.getLocalHost();
String url = String.format("http://%s:%s", address.getHostAddress(), port);
String loginUrl = febsProperties.getShiro().getLoginUrl();
if (StringUtils.isNotBlank(contextPath))
url += contextPath;
if (StringUtils.isNotBlank(loginUrl))
url += loginUrl;
log.info(" __ ___ _ ___ _ ____ _____ ____ ");
log.info("/ /` / / \\ | |\\/| | |_) | | | |_ | | | |_ ");
log.info("\\_\\_, \\_\\_/ |_| | |_| |_|__ |_|__ |_| |_|__ ");
log.info(" ");
log.info("FEBS 权限系统启动完毕，地址：{}", url);
boolean auto = febsProperties.isAutoOpenBrowser();
String[] autoEnv = febsProperties.getAutoOpenBrowserEnv();
int i = Arrays.binarySearch(autoEnv, active);
if (auto && i > 0) {
String osName = System.getProperty("os.name").toLowerCase();
if (osName.contains("windows")) {// 默认为windows时才自动打开页面
//使用默认浏览器打开系统登录页
Runtime.getRuntime().exec("cmd /c start " + url);
}
}
}
}
#location 34
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void load(File file) throws FileNotFoundException, IOException, InvalidConfigurationException {
Validate.notNull(file, "File cannot be null");
final FileInputStream stream = new FileInputStream(file);
load(new InputStreamReader(stream, UTF8_OVERRIDE && !UTF_BIG ? Charsets.UTF_8 : Charset.defaultCharset()));
}
|
#vulnerable code
public void load(File file) throws FileNotFoundException, IOException, InvalidConfigurationException {
Validate.notNull(file, "File cannot be null");
load(new FileInputStream(file));
}
#location 4
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public Plugin loadPlugin(File file) throws InvalidPluginException, InvalidDescriptionException, UnknownDependencyException {
return loadPlugin(file, false);
}
|
#vulnerable code
public Plugin loadPlugin(File file) throws InvalidPluginException, InvalidDescriptionException, UnknownDependencyException {
JavaPlugin result = null;
PluginDescriptionFile description = null;
if (!file.exists()) {
throw new InvalidPluginException(new FileNotFoundException(String.format("%s does not exist", file.getPath())));
}
try {
JarFile jar = new JarFile(file);
JarEntry entry = jar.getJarEntry("plugin.yml");
if (entry == null) {
throw new InvalidPluginException(new FileNotFoundException("Jar does not contain plugin.yml"));
}
InputStream stream = jar.getInputStream(entry);
description = new PluginDescriptionFile(stream);
stream.close();
jar.close();
} catch (IOException ex) {
throw new InvalidPluginException(ex);
} catch (YAMLException ex) {
throw new InvalidPluginException(ex);
}
File dataFolder = new File(file.getParentFile(), description.getName());
File oldDataFolder = getDataFolder(file);
// Found old data folder
if (dataFolder.equals(oldDataFolder)) {
// They are equal -- nothing needs to be done!
} else if (dataFolder.isDirectory() && oldDataFolder.isDirectory()) {
server.getLogger().log( Level.INFO, String.format(
"While loading %s (%s) found old-data folder: %s next to the new one: %s",
description.getName(),
file,
oldDataFolder,
dataFolder
));
} else if (oldDataFolder.isDirectory() && !dataFolder.exists()) {
if (!oldDataFolder.renameTo(dataFolder)) {
throw new InvalidPluginException(new Exception("Unable to rename old data folder: '" + oldDataFolder + "' to: '" + dataFolder + "'"));
}
server.getLogger().log( Level.INFO, String.format(
"While loading %s (%s) renamed data folder: '%s' to '%s'",
description.getName(),
file,
oldDataFolder,
dataFolder
));
}
if (dataFolder.exists() && !dataFolder.isDirectory()) {
throw new InvalidPluginException(new Exception(String.format(
"Projected datafolder: '%s' for %s (%s) exists and is not a directory",
dataFolder,
description.getName(),
file
)));
}
ArrayList<String> depend;
try {
depend = (ArrayList)description.getDepend();
if(depend == null) {
depend = new ArrayList<String>();
}
} catch (ClassCastException ex) {
throw new InvalidPluginException(ex);
}
for(String pluginName : depend) {
if(loaders == null) {
throw new UnknownDependencyException(pluginName);
}
PluginClassLoader current = loaders.get(pluginName);
if(current == null) {
throw new UnknownDependencyException(pluginName);
}
}
PluginClassLoader loader = null;
try {
URL[] urls = new URL[1];
urls[0] = file.toURI().toURL();
loader = new PluginClassLoader(this, urls, getClass().getClassLoader());
Class<?> jarClass = Class.forName(description.getMain(), true, loader);
Class<? extends JavaPlugin> plugin = jarClass.asSubclass(JavaPlugin.class);
Constructor<? extends JavaPlugin> constructor = plugin.getConstructor();
result = constructor.newInstance();
result.initialize(this, server, description, dataFolder, file, loader);
} catch (Throwable ex) {
throw new InvalidPluginException(ex);
}
loaders.put(description.getName(), (PluginClassLoader)loader);
return (Plugin)result;
}
#location 13
#vulnerability type RESOURCE_LEAK
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
@Override
public boolean execute(CommandSender sender, String currentAlias, String[] args) {
if (!testPermission(sender)) return true;
if (args.length < 1 || args.length > 4) {
sender.sendMessage(ChatColor.RED + "Usage: " + usageMessage);
return false;
}
Player player;
if (args.length == 1 || args.length == 3) {
if (sender instanceof Player) {
player = (Player) sender;
} else {
sender.sendMessage("Please provide a player!");
return true;
}
} else {
player = Bukkit.getPlayerExact(args[0]);
}
if (player == null) {
sender.sendMessage("Player not found: " + args[0]);
return true;
}
if (args.length < 3) {
Player target = Bukkit.getPlayerExact(args[args.length - 1]);
if (target == null) {
sender.sendMessage("Can't find user " + args[args.length - 1] + ". No tp.");
return true;
}
player.teleport(target, TeleportCause.COMMAND);
Command.broadcastCommandMessage(sender, "Teleported " + player.getName() + " to " + target.getName());
} else if (player.getWorld() != null) {
int x = getInteger(sender, args[args.length - 3], -30000000, 30000000);
int y = getInteger(sender, args[args.length - 2], 0, 256);
int z = getInteger(sender, args[args.length - 1], -30000000, 30000000);
Location location = new Location(player.getWorld(), x, y, z);
player.teleport(location);
Command.broadcastCommandMessage(sender, "Teleported " + player.getName() + " to " + + x + "," + y + "," + z);
}
return true;
}
|
#vulnerable code
@Override
public boolean execute(CommandSender sender, String currentAlias, String[] args) {
if (!testPermission(sender)) return true;
if (args.length < 1 || args.length > 4) {
sender.sendMessage(ChatColor.RED + "Usage: " + usageMessage);
return false;
}
Player player;
if (args.length == 1 || args.length == 3) {
if (sender instanceof Player) {
player = (Player) sender;
} else {
sender.sendMessage("Please provide a player!");
return true;
}
} else {
player = Bukkit.getPlayerExact(args[0]);
}
if (player == null) {
sender.sendMessage("Player not found: " + args[0]);
}
if (args.length < 3) {
Player target = Bukkit.getPlayerExact(args[args.length - 1]);
if (target == null) {
sender.sendMessage("Can't find user " + args[args.length - 1] + ". No tp.");
}
player.teleport(target, TeleportCause.COMMAND);
sender.sendMessage("Teleported " + player.getName() + " to " + target.getName());
} else if (player.getWorld() != null) {
int x = getInteger(sender, args[args.length - 3], -30000000, 30000000);
int y = getInteger(sender, args[args.length - 2], 0, 256);
int z = getInteger(sender, args[args.length - 1], -30000000, 30000000);
Location location = new Location(player.getWorld(), x, y, z);
player.teleport(location);
sender.sendMessage("Teleported " + player.getName() + " to " + x + "," + y + "," + z);
}
return true;
}
#location 32
#vulnerability type NULL_DEREFERENCE
|
Below is the vulnerable code, please generate the patch based on the following information.
|
#fixed code
public void recalculatePermissions() {
clearPermissions();
Set<Permission> defaults = Bukkit.getServer().getPluginManager().getDefaultPermissions(isOp());
Bukkit.getServer().getPluginManager().subscribeToDefaultPerms(isOp(), parent);
for (Permission perm : defaults) {
String name = perm.getName().toLowerCase();
permissions.put(name, new PermissionAttachmentInfo(parent, name, null, true));
Bukkit.getServer().getPluginManager().subscribeToPermission(name, parent);
calculateChildPermissions(perm.getChildren(), false, null);
}
for (PermissionAttachment attachment : attachments) {
calculateChildPermissions(attachment.getPermissions(), false, attachment);
}
}
|
#vulnerable code
public void recalculatePermissions() {
dirtyPermissions = true;
}
#location 2
#vulnerability type THREAD_SAFETY_VIOLATION
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.