issue_id
int64
2.04k
425k
title
stringlengths
9
251
body
stringlengths
4
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
23
187
chunk_content
stringlengths
1
22k
8,757
Bug 8757 Type Hierarchy view - Error decoration not removed when error fixed
Eclipse 200201129-I Windows 2000 1) Focus on the hierarchy of class (one that has a few super classes). 2) Cause a compile error to happen in the class and save the change. 3) Select a different class in the hierarchy and then select the class with the error. Note that now the label at the top of the methods list in the TypeHierarchy view nows has a red x on it. I don't know why you have to flip between classes to make this red x appear - it should appear as soon as you save the change that caused a compile error. 4) Now fix the compile error and save the change. The red x does not disappear from the label above the methods list.
resolved fixed
2a59a99
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T18:52:29Z
2002-01-30T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
return; } updateHierarchyViewer(); } else { if (getCurrentViewer().isMethodFiltering()) { if (changedTypes.length == 1) { getCurrentViewer().refresh(changedTypes[0]); } else { updateHierarchyViewer(); } } else { getCurrentViewer().update(changedTypes, new String[] { IBasicPropertyConstants.P_TEXT, IBasicPropertyConstants.P_IMAGE } ); } } } } /** * Determines the input element to be used initially . */ private IJavaElement determineInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IJavaElement) { return (IJavaElement) input; } return null; }
8,757
Bug 8757 Type Hierarchy view - Error decoration not removed when error fixed
Eclipse 200201129-I Windows 2000 1) Focus on the hierarchy of class (one that has a few super classes). 2) Cause a compile error to happen in the class and save the change. 3) Select a different class in the hierarchy and then select the class with the error. Note that now the label at the top of the methods list in the TypeHierarchy view nows has a red x on it. I don't know why you have to flip between classes to make this red x appear - it should appear as soon as you save the change that caused a compile error. 4) Now fix the compile error and save the change. The red x does not disappear from the label above the methods list.
resolved fixed
2a59a99
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T18:52:29Z
2002-01-30T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
/* * @see IViewPart#init */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /* * @see ViewPart#saveState(IMemento) */ public void saveState(IMemento memento) { if (fPagebook == null) { if (fMemento != null) { memento.putMemento(fMemento); } return; } if (fInputElement != null) { memento.putString(TAG_INPUT, fInputElement.getHandleIdentifier()); } memento.putInteger(TAG_VIEW, getViewIndex()); memento.putInteger(TAG_ORIENTATION, fCurrentOrientation); int weigths[]= fTypeMethodsSplitter.getWeights(); int ratio= (weigths[0] * 1000) / (weigths[0] + weigths[1]); memento.putInteger(TAG_RATIO, ratio); ScrollBar bar= getCurrentViewer().getTree().getVerticalBar(); int position= bar != null ? bar.getSelection() : 0;
8,757
Bug 8757 Type Hierarchy view - Error decoration not removed when error fixed
Eclipse 200201129-I Windows 2000 1) Focus on the hierarchy of class (one that has a few super classes). 2) Cause a compile error to happen in the class and save the change. 3) Select a different class in the hierarchy and then select the class with the error. Note that now the label at the top of the methods list in the TypeHierarchy view nows has a red x on it. I don't know why you have to flip between classes to make this red x appear - it should appear as soon as you save the change that caused a compile error. 4) Now fix the compile error and save the change. The red x does not disappear from the label above the methods list.
resolved fixed
2a59a99
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T18:52:29Z
2002-01-30T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
memento.putInteger(TAG_VERTICAL_SCROLL, position); IJavaElement selection= (IJavaElement)((IStructuredSelection) getCurrentViewer().getSelection()).getFirstElement(); if (selection != null) { memento.putString(TAG_SELECTION, selection.getHandleIdentifier()); } fMethodsViewer.saveState(memento); } /** * Restores the type hierarchy settings from a memento. */ private void restoreState(IMemento memento, IJavaElement defaultInput) { IJavaElement input= defaultInput; String elementId= memento.getString(TAG_INPUT); if (elementId != null) { input= JavaCore.create(elementId); if (!input.exists()) { input= null; } } setInputElement(input); Integer viewerIndex= memento.getInteger(TAG_VIEW); if (viewerIndex != null) { setView(viewerIndex.intValue()); } Integer orientation= memento.getInteger(TAG_ORIENTATION); if (orientation != null) { setOrientation(orientation.intValue()); }
8,757
Bug 8757 Type Hierarchy view - Error decoration not removed when error fixed
Eclipse 200201129-I Windows 2000 1) Focus on the hierarchy of class (one that has a few super classes). 2) Cause a compile error to happen in the class and save the change. 3) Select a different class in the hierarchy and then select the class with the error. Note that now the label at the top of the methods list in the TypeHierarchy view nows has a red x on it. I don't know why you have to flip between classes to make this red x appear - it should appear as soon as you save the change that caused a compile error. 4) Now fix the compile error and save the change. The red x does not disappear from the label above the methods list.
resolved fixed
2a59a99
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T18:52:29Z
2002-01-30T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Integer ratio= memento.getInteger(TAG_RATIO); if (ratio != null) { fTypeMethodsSplitter.setWeights(new int[] { ratio.intValue(), 1000 - ratio.intValue() }); } ScrollBar bar= getCurrentViewer().getTree().getVerticalBar(); if (bar != null) { Integer vScroll= memento.getInteger(TAG_VERTICAL_SCROLL); if (vScroll != null) { bar.setSelection(vScroll.intValue()); } } String selectionId= memento.getString(TAG_SELECTION); if (selectionId != null) { IJavaElement elem= JavaCore.create(selectionId); if (getCurrentViewer().isElementShown(elem) && elem instanceof IMember) { internalSelectType((IMember)elem, false); } } fMethodsViewer.restoreState(memento); } /** * Link selection to active editor. */ private void editorActivated(IEditorPart editor) { if (!JavaBasePreferencePage.linkTypeHierarchySelectionToEditor()) { return; } if (fInputElement == null) {
8,757
Bug 8757 Type Hierarchy view - Error decoration not removed when error fixed
Eclipse 200201129-I Windows 2000 1) Focus on the hierarchy of class (one that has a few super classes). 2) Cause a compile error to happen in the class and save the change. 3) Select a different class in the hierarchy and then select the class with the error. Note that now the label at the top of the methods list in the TypeHierarchy view nows has a red x on it. I don't know why you have to flip between classes to make this red x appear - it should appear as soon as you save the change that caused a compile error. 4) Now fix the compile error and save the change. The red x does not disappear from the label above the methods list.
resolved fixed
2a59a99
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T18:52:29Z
2002-01-30T17:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
return; } IJavaElement elem= (IJavaElement)editor.getEditorInput().getAdapter(IJavaElement.class); try { TypeHierarchyViewer currentViewer= getCurrentViewer(); if (elem instanceof IClassFile) { IType type= ((IClassFile)elem).getType(); if (currentViewer.isElementShown(type)) { internalSelectType(type, true); updateMethodViewer(type); } } else if (elem instanceof ICompilationUnit) { IType[] allTypes= ((ICompilationUnit)elem).getAllTypes(); for (int i= 0; i < allTypes.length; i++) { if (currentViewer.isElementShown(allTypes[i])) { internalSelectType(allTypes[i], true); updateMethodViewer(allTypes[i]); return; } } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.BusyIndicator; import org.eclipse.swt.custom.CLabel; import org.eclipse.swt.custom.SashForm; import org.eclipse.swt.custom.ViewForm; import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DragSource; import org.eclipse.swt.dnd.Transfer; import org.eclipse.swt.events.KeyAdapter; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.KeyListener; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.ScrollBar; import org.eclipse.swt.widgets.ToolBar; import org.eclipse.jface.action.IMenuListener;
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.action.IStatusLineManager; import org.eclipse.jface.action.IToolBarManager; import org.eclipse.jface.action.MenuManager; import org.eclipse.jface.action.Separator; import org.eclipse.jface.action.ToolBarManager; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.IBasicPropertyConstants; import org.eclipse.jface.viewers.IInputSelectionProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.IActionBars; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IMemento; import org.eclipse.ui.IPartListener; import org.eclipse.ui.IViewSite; import org.eclipse.ui.IWorkbenchActionConstants; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.PartInitException; import org.eclipse.ui.actions.OpenWithMenu; import org.eclipse.ui.help.ViewContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.part.PageBook; import org.eclipse.ui.part.ViewPart;
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.ITypeHierarchyViewPart; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.AddMethodStubAction; import org.eclipse.jdt.internal.ui.actions.ContextMenuGroup; import org.eclipse.jdt.internal.ui.dnd.BasicSelectionTransferDragAdapter; import org.eclipse.jdt.internal.ui.dnd.LocalSelectionTransfer; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.packageview.BuildGroup; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringGroup; import org.eclipse.jdt.internal.ui.reorg.ReorgGroup; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.viewsupport.ErrorTickImageProvider; import org.eclipse.jdt.internal.ui.viewsupport.IProblemChangedListener; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementLabels; import org.eclipse.jdt.internal.ui.viewsupport.JavaUILabelProvider; import org.eclipse.jdt.internal.ui.viewsupport.StatusBarUpdater; /** * view showing the supertypes/subtypes of its input. */ public class TypeHierarchyViewPart extends ViewPart implements ITypeHierarchyViewPart {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
public static final int VIEW_ID_TYPE= 2; public static final int VIEW_ID_SUPER= 0; public static final int VIEW_ID_SUB= 1; public static final int VIEW_ORIENTATION_VERTICAL= 0; public static final int VIEW_ORIENTATION_HORIZONTAL= 1; public static final int VIEW_ORIENTATION_SINGLE= 2; private static final String DIALOGSTORE_HIERARCHYVIEW= "TypeHierarchyViewPart.hierarchyview"; private static final String DIALOGSTORE_VIEWORIENTATION= "TypeHierarchyViewPart.orientation"; private static final String TAG_INPUT= "input"; private static final String TAG_VIEW= "view"; private static final String TAG_ORIENTATION= "orientation"; private static final String TAG_RATIO= "ratio"; private static final String TAG_SELECTION= "selection"; private static final String TAG_VERTICAL_SCROLL= "vertical_scroll";
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
private IType fSelectedType; private IJavaElement fInputElement; private ArrayList fInputHistory; private IMemento fMemento; private IProblemChangedListener fHierarchyProblemListener; private TypeHierarchyLifeCycle fHierarchyLifeCycle; private ITypeHierarchyLifeCycleListener fTypeHierarchyLifeCycleListener; private MethodsViewer fMethodsViewer; private int fCurrentViewerIndex; private TypeHierarchyViewer[] fAllViewers; private SelectionProviderMediator fSelectionProviderMediator; private ISelectionChangedListener fSelectionChangedListener; private boolean fIsEnableMemberFilter; private SashForm fTypeMethodsSplitter; private PageBook fViewerbook; private PageBook fPagebook; private Label fNoHierarchyShownLabel;
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
private Label fEmptyTypesViewer; private ViewForm fTypeViewerViewForm; private ViewForm fMethodViewerViewForm; private CLabel fMethodViewerPaneLabel; private JavaUILabelProvider fPaneLabelProvider; private IDialogSettings fDialogSettings; private ToggleViewAction[] fViewActions; private HistoryDropDownAction fHistoryDropDownAction; private ToggleOrientationAction[] fToggleOrientationActions; private int fCurrentOrientation; private EnableMemberFilterAction fEnableMemberFilterAction; private AddMethodStubAction fAddStubAction; private FocusOnTypeAction fFocusOnTypeAction; private FocusOnSelectionAction fFocusOnSelectionAction; private IPartListener fPartListener; public TypeHierarchyViewPart() { fSelectedType= null; fInputElement= null; fHierarchyLifeCycle= new TypeHierarchyLifeCycle(); fTypeHierarchyLifeCycleListener= new ITypeHierarchyLifeCycleListener() {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
public void typeHierarchyChanged(TypeHierarchyLifeCycle typeHierarchy, IType[] changedTypes) { doTypeHierarchyChanged(typeHierarchy, changedTypes); } }; fHierarchyLifeCycle.addChangedListener(fTypeHierarchyLifeCycleListener); fHierarchyProblemListener= null; fIsEnableMemberFilter= false; fInputHistory= new ArrayList(); fAllViewers= null; fViewActions= new ToggleViewAction[] { new ToggleViewAction(this, VIEW_ID_TYPE), new ToggleViewAction(this, VIEW_ID_SUPER), new ToggleViewAction(this, VIEW_ID_SUB) }; fDialogSettings= JavaPlugin.getDefault().getDialogSettings(); fHistoryDropDownAction= new HistoryDropDownAction(this); fHistoryDropDownAction.setEnabled(false); fToggleOrientationActions= new ToggleOrientationAction[] { new ToggleOrientationAction(this, VIEW_ORIENTATION_VERTICAL), new ToggleOrientationAction(this, VIEW_ORIENTATION_HORIZONTAL), new ToggleOrientationAction(this, VIEW_ORIENTATION_SINGLE) };
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
fEnableMemberFilterAction= new EnableMemberFilterAction(this, false); fFocusOnTypeAction= new FocusOnTypeAction(this); fPaneLabelProvider= new JavaUILabelProvider(); fAddStubAction= new AddMethodStubAction(); fFocusOnSelectionAction= new FocusOnSelectionAction(this); fPartListener= new IPartListener() { public void partActivated(IWorkbenchPart part) { if (part instanceof IEditorPart) editorActivated((IEditorPart) part); } public void partBroughtToTop(IWorkbenchPart part) {} public void partClosed(IWorkbenchPart part) {} public void partDeactivated(IWorkbenchPart part) {} public void partOpened(IWorkbenchPart part) {} }; fSelectionChangedListener= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) { doSelectionChanged(event); } }; } /** * Adds the entry if new. Inserted at the beginning of the history entries list.
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
*/ private void addHistoryEntry(IJavaElement entry) { if (fInputHistory.contains(entry)) { fInputHistory.remove(entry); } fInputHistory.add(0, entry); fHistoryDropDownAction.setEnabled(true); } private void updateHistoryEntries() { for (int i= fInputHistory.size() - 1; i >= 0; i--) { IJavaElement type= (IJavaElement) fInputHistory.get(i); if (!type.exists()) { fInputHistory.remove(i); } } fHistoryDropDownAction.setEnabled(!fInputHistory.isEmpty()); } /** * Goes to the selected entry, without updating the order of history entries. */ public void gotoHistoryEntry(IJavaElement entry) { if (fInputHistory.contains(entry)) { updateInput(entry); } } /** * Gets all history entries.
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
*/ public IJavaElement[] getHistoryEntries() { if (fInputHistory.size() > 0) { updateHistoryEntries(); } return (IJavaElement[]) fInputHistory.toArray(new IJavaElement[fInputHistory.size()]); } /** * Sets the history entries */ public void setHistoryEntries(IJavaElement[] elems) { fInputHistory.clear(); for (int i= 0; i < elems.length; i++) { fInputHistory.add(elems[i]); } updateHistoryEntries(); } /** * Selects an member in the methods list */ public void selectMember(IMember member) { ICompilationUnit cu= member.getCompilationUnit(); if (cu != null && cu.isWorkingCopy()) { member= (IMember) cu.getOriginal(member); if (member == null) { return; } }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Control methodControl= fMethodsViewer.getControl(); if (methodControl != null && !methodControl.isDisposed()) { fMethodsViewer.getControl().setFocus(); } fMethodsViewer.setSelection(new StructuredSelection(member), true); } /** * @deprecated */ public IType getInput() { if (fInputElement instanceof IType) { return (IType) fInputElement; } return null; } /** * Sets the input to a new type * @deprecated */ public void setInput(IType type) { setInputElement(type); } /** * Returns the input element of the type hierarchy. * Can be of type <code>IType</code> or <code>IPackageFragment</code> */ public IJavaElement getInputElement() { return fInputElement;
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} /** * Sets the input to a new element. */ public void setInputElement(IJavaElement element) { if (element != null) { if (element instanceof IMember) { ICompilationUnit cu= ((IMember) element).getCompilationUnit(); if (cu != null && cu.isWorkingCopy()) { element= cu.getOriginal(element); if (!element.exists()) { MessageDialog.openError(getSite().getShell(), TypeHierarchyMessages.getString("TypeHierarchyViewPart.error.title"), TypeHierarchyMessages.getString("TypeHierarchyViewPart.error.message")); return; } } if (element.getElementType() == IJavaElement.METHOD || element.getElementType() == IJavaElement.FIELD || element.getElementType() == IJavaElement.INITIALIZER) { element= ((IMember) element).getDeclaringType(); } } } if (element != null && !element.equals(fInputElement)) { addHistoryEntry(element); } updateInput(element); } /** * Changes the input to a new type
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
*/ private void updateInput(IJavaElement inputElement) { IJavaElement prevInput= fInputElement; fInputElement= inputElement; if (fInputElement == null) { clearInput(); } else { try { fHierarchyLifeCycle.ensureRefreshedTypeHierarchy(fInputElement); } catch (JavaModelException e) { JavaPlugin.log(e); clearInput(); return; } fPagebook.showPage(fTypeMethodsSplitter); if (inputElement.getElementType() != IJavaElement.TYPE) { setView(VIEW_ID_TYPE); } setMemberFilter(null); fIsEnableMemberFilter= false; if (!fInputElement.equals(prevInput)) { updateHierarchyViewer(); } IType root= getSelectableType(fInputElement); internalSelectType(root, true); updateMethodViewer(root); updateToolbarButtons();
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
updateTitle(); enableMemberFilter(false); } } private void clearInput() { fInputElement= null; fHierarchyLifeCycle.freeHierarchy(); updateHierarchyViewer(); updateToolbarButtons(); } /* * @see IWorbenchPart#setFocus */ public void setFocus() { fPagebook.setFocus(); } /* * @see IWorkbenchPart#dispose */ public void dispose() { fHierarchyLifeCycle.freeHierarchy(); fHierarchyLifeCycle.removeChangedListener(fTypeHierarchyLifeCycleListener); fPaneLabelProvider.dispose(); getSite().getPage().removePartListener(fPartListener); if (fHierarchyProblemListener != null) { JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fHierarchyProblemListener); } if (fMethodsViewer != null) {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fMethodsViewer); } super.dispose(); } private Control createTypeViewerControl(Composite parent) { fViewerbook= new PageBook(parent, SWT.NULL); KeyListener keyListener= createKeyListener(); HierarchyLabelProvider lprovider= new HierarchyLabelProvider(this); TypeHierarchyViewer superTypesViewer= new SuperTypeHierarchyViewer(fViewerbook, fHierarchyLifeCycle, lprovider, this); initializeTypesViewer(superTypesViewer, keyListener, IContextMenuConstants.TARGET_ID_SUPERTYPES_VIEW); TypeHierarchyViewer subTypesViewer= new SubTypeHierarchyViewer(fViewerbook, fHierarchyLifeCycle, lprovider, this); initializeTypesViewer(subTypesViewer, keyListener, IContextMenuConstants.TARGET_ID_SUBTYPES_VIEW); TypeHierarchyViewer vajViewer= new TraditionalHierarchyViewer(fViewerbook, fHierarchyLifeCycle, lprovider, this); initializeTypesViewer(vajViewer, keyListener, IContextMenuConstants.TARGET_ID_HIERARCHY_VIEW); fAllViewers= new TypeHierarchyViewer[3]; fAllViewers[VIEW_ID_SUPER]= superTypesViewer; fAllViewers[VIEW_ID_SUB]= subTypesViewer; fAllViewers[VIEW_ID_TYPE]= vajViewer; int currViewerIndex; try { currViewerIndex= fDialogSettings.getInt(DIALOGSTORE_HIERARCHYVIEW); if (currViewerIndex < 0 || currViewerIndex > 2) {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
currViewerIndex= VIEW_ID_TYPE; } } catch (NumberFormatException e) { currViewerIndex= VIEW_ID_TYPE; } fEmptyTypesViewer= new Label(fViewerbook, SWT.LEFT); for (int i= 0; i < fAllViewers.length; i++) { fAllViewers[i].setInput(fAllViewers[i]); } fCurrentViewerIndex= -1; setView(currViewerIndex); return fViewerbook; } private KeyListener createKeyListener() { return new KeyAdapter() { public void keyPressed(KeyEvent event) { if (event.stateMask == 0) { if (event.keyCode == SWT.F4) { OpenTypeHierarchyUtil.open(getSite().getSelectionProvider().getSelection(), getSite().getWorkbenchWindow()); return; } else if (event.keyCode == SWT.F5) { updateHierarchyViewer(); return; }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} viewPartKeyShortcuts(event); } }; } private void initializeTypesViewer(final TypeHierarchyViewer typesViewer, KeyListener keyListener, String cotextHelpId) { typesViewer.getControl().setVisible(false); typesViewer.getControl().addKeyListener(keyListener); typesViewer.initContextMenu(new IMenuListener() { public void menuAboutToShow(IMenuManager menu) { fillTypesViewerContextMenu(typesViewer, menu); } }, cotextHelpId, getSite()); typesViewer.addSelectionChangedListener(fSelectionChangedListener); } private Control createMethodViewerControl(Composite parent) { fMethodsViewer= new MethodsViewer(parent, this); fMethodsViewer.initContextMenu(new IMenuListener() { public void menuAboutToShow(IMenuManager menu) { fillMethodsViewerContextMenu(menu); } }, IContextMenuConstants.TARGET_ID_MEMBERS_VIEW, getSite()); fMethodsViewer.addSelectionChangedListener(fSelectionChangedListener); Control control= fMethodsViewer.getTable(); control.addKeyListener(createKeyListener()); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fMethodsViewer);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
return control; } private void initDragAndDrop() { Transfer[] transfers= new Transfer[] { LocalSelectionTransfer.getInstance() }; int ops= DND.DROP_COPY; DragSource source= new DragSource(fMethodsViewer.getControl(), ops); source.setTransfer(transfers); source.addDragListener(new BasicSelectionTransferDragAdapter(fMethodsViewer)); for (int i= 0; i < fAllViewers.length; i++) { TypeHierarchyViewer curr= fAllViewers[i]; curr.addDropSupport(ops, transfers, new TypeHierarchyTransferDropAdapter(curr)); } } private void viewPartKeyShortcuts(KeyEvent event) { if (event.stateMask == SWT.CTRL) { if (event.character == '1') { setView(VIEW_ID_TYPE); } else if (event.character == '2') { setView(VIEW_ID_SUPER); } else if (event.character == '3') { setView(VIEW_ID_SUB); } } }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
/** * Returns the inner component in a workbench part. * @see IWorkbenchPart#createPartControl */ public void createPartControl(Composite container) { fPagebook= new PageBook(container, SWT.NONE); fTypeMethodsSplitter= new SashForm(fPagebook, SWT.VERTICAL); fTypeMethodsSplitter.setVisible(false); fTypeViewerViewForm= new ViewForm(fTypeMethodsSplitter, SWT.NONE); Control typeViewerControl= createTypeViewerControl(fTypeViewerViewForm); fTypeViewerViewForm.setContent(typeViewerControl); fMethodViewerViewForm= new ViewForm(fTypeMethodsSplitter, SWT.NONE); fTypeMethodsSplitter.setWeights(new int[] {35, 65}); Control methodViewerPart= createMethodViewerControl(fMethodViewerViewForm); fMethodViewerViewForm.setContent(methodViewerPart); fMethodViewerPaneLabel= new CLabel(fMethodViewerViewForm, SWT.NONE); fMethodViewerViewForm.setTopLeft(fMethodViewerPaneLabel); initDragAndDrop(); ToolBar methodViewerToolBar= new ToolBar(fMethodViewerViewForm, SWT.FLAT | SWT.WRAP); fMethodViewerViewForm.setTopCenter(methodViewerToolBar);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
fNoHierarchyShownLabel= new Label(fPagebook, SWT.TOP + SWT.LEFT + SWT.WRAP); fNoHierarchyShownLabel.setText(TypeHierarchyMessages.getString("TypeHierarchyViewPart.empty")); MenuManager menu= new MenuManager(); menu.add(fFocusOnTypeAction); fNoHierarchyShownLabel.setMenu(menu.createContextMenu(fNoHierarchyShownLabel)); fPagebook.showPage(fNoHierarchyShownLabel); int orientation; try { orientation= fDialogSettings.getInt(DIALOGSTORE_VIEWORIENTATION); if (orientation < 0 || orientation > 2) { orientation= VIEW_ORIENTATION_VERTICAL; } } catch (NumberFormatException e) { orientation= VIEW_ORIENTATION_VERTICAL; } fCurrentOrientation= -1; setOrientation(orientation); IActionBars actionBars= getViewSite().getActionBars(); IMenuManager viewMenu= actionBars.getMenuManager(); for (int i= 0; i < fToggleOrientationActions.length; i++) { viewMenu.add(fToggleOrientationActions[i]); } viewMenu.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS));
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
ToolBarManager lowertbmanager= new ToolBarManager(methodViewerToolBar); lowertbmanager.add(fEnableMemberFilterAction); lowertbmanager.add(new Separator()); fMethodsViewer.contributeToToolBar(lowertbmanager); lowertbmanager.update(true); int nHierarchyViewers= fAllViewers.length; Viewer[] trackedViewers= new Viewer[nHierarchyViewers + 1]; for (int i= 0; i < nHierarchyViewers; i++) { trackedViewers[i]= fAllViewers[i]; } trackedViewers[nHierarchyViewers]= fMethodsViewer; fSelectionProviderMediator= new SelectionProviderMediator(trackedViewers); IStatusLineManager slManager= getViewSite().getActionBars().getStatusLineManager(); fSelectionProviderMediator.addSelectionChangedListener(new StatusBarUpdater(slManager)); getSite().setSelectionProvider(fSelectionProviderMediator); getSite().getPage().addPartListener(fPartListener); IJavaElement input= determineInputElement(); if (fMemento != null) { restoreState(fMemento, input); } else if (input != null) { setInputElement(input); } else { setViewerVisibility(false); }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
ReorgGroup.addGlobalReorgActions(getViewSite().getActionBars(), getViewSite().getSelectionProvider()); WorkbenchHelp.setHelp(fPagebook, new ViewContextComputer(this, IJavaHelpContextIds.TYPE_HIERARCHY_VIEW)); } /** * called from ToggleOrientationAction. * @param orientation VIEW_ORIENTATION_SINGLE, VIEW_ORIENTATION_HORIZONTAL or VIEW_ORIENTATION_VERTICAL */ public void setOrientation(int orientation) { if (fCurrentOrientation != orientation) { boolean methodViewerNeedsUpdate= false; if (fMethodViewerViewForm != null && !fMethodViewerViewForm.isDisposed() && fTypeMethodsSplitter != null && !fTypeMethodsSplitter.isDisposed()) { if (orientation == VIEW_ORIENTATION_SINGLE) { fMethodViewerViewForm.setVisible(false); enableMemberFilter(false); updateMethodViewer(null); } else { if (fCurrentOrientation == VIEW_ORIENTATION_SINGLE) { fMethodViewerViewForm.setVisible(true); methodViewerNeedsUpdate= true; } boolean horizontal= orientation == VIEW_ORIENTATION_HORIZONTAL; fTypeMethodsSplitter.setOrientation(horizontal ? SWT.HORIZONTAL : SWT.VERTICAL); } updateMainToolbar(orientation); fTypeMethodsSplitter.layout(); }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
for (int i= 0; i < fToggleOrientationActions.length; i++) { fToggleOrientationActions[i].setChecked(orientation == fToggleOrientationActions[i].getOrientation()); } fCurrentOrientation= orientation; if (methodViewerNeedsUpdate) { updateMethodViewer(fSelectedType); } fDialogSettings.put(DIALOGSTORE_VIEWORIENTATION, orientation); } } private void updateMainToolbar(int orientation) { IActionBars actionBars= getViewSite().getActionBars(); IToolBarManager tbmanager= actionBars.getToolBarManager(); if (orientation == VIEW_ORIENTATION_HORIZONTAL) { clearMainToolBar(tbmanager); ToolBar typeViewerToolBar= new ToolBar(fTypeViewerViewForm, SWT.FLAT | SWT.WRAP); fillMainToolBar(new ToolBarManager(typeViewerToolBar)); fTypeViewerViewForm.setTopLeft(typeViewerToolBar); } else { fTypeViewerViewForm.setTopLeft(null); fillMainToolBar(tbmanager); } } private void fillMainToolBar(IToolBarManager tbmanager) { tbmanager.removeAll(); tbmanager.add(fHistoryDropDownAction);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
for (int i= 0; i < fViewActions.length; i++) { tbmanager.add(fViewActions[i]); } tbmanager.update(false); } private void clearMainToolBar(IToolBarManager tbmanager) { tbmanager.removeAll(); tbmanager.update(false); } /** * Creates the context menu for the hierarchy viewers */ private void fillTypesViewerContextMenu(TypeHierarchyViewer viewer, IMenuManager menu) { JavaPlugin.createStandardGroups(menu); viewer.contributeToContextMenu(menu); IStructuredSelection selection= (IStructuredSelection)viewer.getSelection(); if (JavaBasePreferencePage.openTypeHierarchyInPerspective()) { addOpenPerspectiveItem(menu, selection); } addOpenWithMenu(menu, selection); menu.appendToGroup(IContextMenuConstants.GROUP_SHOW, fFocusOnTypeAction); if (fFocusOnSelectionAction.canActionBeAdded()) menu.appendToGroup(IContextMenuConstants.GROUP_SHOW, fFocusOnSelectionAction); addRefactoring(menu, viewer); ContextMenuGroup.add(menu, new ContextMenuGroup[] { new BuildGroup(), new ReorgGroup() }, viewer);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} /** * Creates the context menu for the method viewer */ private void fillMethodsViewerContextMenu(IMenuManager menu) { JavaPlugin.createStandardGroups(menu); fMethodsViewer.contributeToContextMenu(menu); if (fSelectedType != null && fAddStubAction.init(fSelectedType, fMethodsViewer.getSelection())) { menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, fAddStubAction); } addOpenWithMenu(menu, (IStructuredSelection)fMethodsViewer.getSelection()); addRefactoring(menu, fMethodsViewer); ContextMenuGroup.add(menu, new ContextMenuGroup[] { new BuildGroup(), new ReorgGroup() }, fMethodsViewer); } private void addRefactoring(IMenuManager menu, IInputSelectionProvider viewer){ MenuManager refactoring= new MenuManager(TypeHierarchyMessages.getString("TypeHierarchyViewPart.menu.refactor")); ContextMenuGroup.add(refactoring, new ContextMenuGroup[] { new RefactoringGroup() }, viewer); if (!refactoring.isEmpty()) menu.appendToGroup(IContextMenuConstants.GROUP_REORGANIZE, refactoring); } private void addOpenWithMenu(IMenuManager menu, IStructuredSelection selection) { if (selection.size() != 1) return; Object element= selection.getFirstElement();
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
if (!(element instanceof IJavaElement)) return; IResource resource= null; try { resource= ((IJavaElement)element).getUnderlyingResource(); } catch(JavaModelException e) { } if (!(resource instanceof IFile)) return; MenuManager submenu= new MenuManager(TypeHierarchyMessages.getString("TypeHierarchyViewPart.menu.open")); submenu.add(new OpenWithMenu(getSite().getPage(), (IFile) resource)); menu.appendToGroup(IContextMenuConstants.GROUP_OPEN, submenu); } private void addOpenPerspectiveItem(IMenuManager menu, IStructuredSelection selection) { OpenTypeHierarchyUtil.addToMenu(getSite().getWorkbenchWindow(), menu, selection); } /** * Toggles between the empty viewer page and the hierarchy */ private void setViewerVisibility(boolean showHierarchy) { if (showHierarchy) { fViewerbook.showPage(getCurrentViewer().getControl()); } else { fViewerbook.showPage(fEmptyTypesViewer); } }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
/** * Sets the member filter. <code>null</code> disables member filtering. */ private void setMemberFilter(IMember[] memberFilter) { Assert.isNotNull(fAllViewers); for (int i= 0; i < fAllViewers.length; i++) { fAllViewers[i].setMemberFilter(memberFilter); } } private IType getSelectableType(IJavaElement elem) { ISelection sel= null; if (elem.getElementType() != IJavaElement.TYPE) { return (IType) getCurrentViewer().getTreeRootType(); } else { return (IType) elem; } } private void internalSelectType(IMember elem, boolean reveal) { TypeHierarchyViewer viewer= getCurrentViewer(); viewer.removeSelectionChangedListener(fSelectionChangedListener); viewer.setSelection(elem != null ? new StructuredSelection(elem) : StructuredSelection.EMPTY, reveal); viewer.addSelectionChangedListener(fSelectionChangedListener); } private void internalSelectMember(IMember member) { fMethodsViewer.removeSelectionChangedListener(fSelectionChangedListener); fMethodsViewer.setSelection(member != null ? new StructuredSelection(member) : StructuredSelection.EMPTY); fMethodsViewer.addSelectionChangedListener(fSelectionChangedListener);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} /** * When the input changed or the hierarchy pane becomes visible, * <code>updateHierarchyViewer<code> brings up the correct view and refreshes * the current tree */ private void updateHierarchyViewer() { if (fInputElement == null) { fPagebook.showPage(fNoHierarchyShownLabel); } else { if (getCurrentViewer().containsElements() != null) { Runnable runnable= new Runnable() { public void run() { getCurrentViewer().updateContent(); } }; BusyIndicator.showWhile(getDisplay(), runnable); if (!isChildVisible(fViewerbook, getCurrentViewer().getControl())) { setViewerVisibility(true); } } else { fEmptyTypesViewer.setText(TypeHierarchyMessages.getFormattedString("TypeHierarchyViewPart.nodecl", fInputElement.getElementName())); setViewerVisibility(false); } } } private void updateMethodViewer(IType input) { if (input != fMethodsViewer.getInput() && !fIsEnableMemberFilter && fCurrentOrientation != VIEW_ORIENTATION_SINGLE) {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
if (input != null) { fMethodViewerPaneLabel.setText(fPaneLabelProvider.getText(input)); fMethodViewerPaneLabel.setImage(fPaneLabelProvider.getImage(input)); } else { fMethodViewerPaneLabel.setText(""); fMethodViewerPaneLabel.setImage(null); } fMethodsViewer.setInput(input); } } private void doSelectionChanged(SelectionChangedEvent e) { if (e.getSelectionProvider() == fMethodsViewer) { methodSelectionChanged(e.getSelection()); } else { typeSelectionChanged(e.getSelection()); } } private void methodSelectionChanged(ISelection sel) { if (sel instanceof IStructuredSelection) { List selected= ((IStructuredSelection)sel).toList(); int nSelected= selected.size(); if (fIsEnableMemberFilter) { IMember[] memberFilter= null; if (nSelected > 0) { memberFilter= new IMember[nSelected]; selected.toArray(memberFilter);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} setMemberFilter(memberFilter); updateHierarchyViewer(); updateTitle(); internalSelectType(fSelectedType, true); } if (nSelected == 1) { revealElementInEditor(selected.get(0), fMethodsViewer); } } } private void typeSelectionChanged(ISelection sel) { if (sel instanceof IStructuredSelection) { List selected= ((IStructuredSelection)sel).toList(); int nSelected= selected.size(); if (nSelected != 0) { List types= new ArrayList(nSelected); for (int i= nSelected-1; i >= 0; i--) { Object elem= selected.get(i); if (elem instanceof IType && !types.contains(elem)) { types.add(elem); } } if (types.size() == 1) { fSelectedType= (IType) types.get(0); updateMethodViewer(fSelectedType); } else if (types.size() == 0) { }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
if (nSelected == 1) { revealElementInEditor(selected.get(0), getCurrentViewer()); } } else { fSelectedType= null; updateMethodViewer(null); } } } private void revealElementInEditor(Object elem, Viewer originViewer) { if (getSite().getPage().getActivePart() != this) { return; } if (fSelectionProviderMediator.getViewerInFocus() != originViewer) { return; } IEditorPart editorPart= EditorUtility.isOpenInEditor(elem); if (editorPart != null && (elem instanceof IJavaElement)) { try { getSite().getPage().removePartListener(fPartListener); EditorUtility.openInEditor(elem, false); EditorUtility.revealInEditor(editorPart, (IJavaElement) elem); getSite().getPage().addPartListener(fPartListener); } catch (CoreException e) { JavaPlugin.log(e);
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} } } private Display getDisplay() { if (fPagebook != null && !fPagebook.isDisposed()) { return fPagebook.getDisplay(); } return null; } private boolean isChildVisible(Composite pb, Control child) { Control[] children= pb.getChildren(); for (int i= 0; i < children.length; i++) { if (children[i] == child && children[i].isVisible()) return true; } return false; } private void updateTitle() { String viewerTitle= getCurrentViewer().getTitle(); String tooltip; String title; if (fInputElement != null) { String[] args= new String[] { viewerTitle, JavaElementLabels.getElementLabel(fInputElement, JavaElementLabels.ALL_DEFAULT) }; title= TypeHierarchyMessages.getFormattedString("TypeHierarchyViewPart.title", args); tooltip= TypeHierarchyMessages.getFormattedString("TypeHierarchyViewPart.tooltip", args); } else {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
title= viewerTitle; tooltip= viewerTitle; } setTitle(title); setTitleToolTip(tooltip); } private void updateToolbarButtons() { boolean isType= fInputElement instanceof IType; for (int i= 0; i < fViewActions.length; i++) { ToggleViewAction action= fViewActions[i]; if (action.getViewerIndex() == VIEW_ID_TYPE) { action.setEnabled(fInputElement != null); } else { action.setEnabled(isType); } } } /** * Sets the current view (see view id) * called from ToggleViewAction. Must be called after creation of the viewpart. */ public void setView(int viewerIndex) { Assert.isNotNull(fAllViewers); if (viewerIndex < fAllViewers.length && fCurrentViewerIndex != viewerIndex) { fCurrentViewerIndex= viewerIndex; updateHierarchyViewer(); if (fInputElement != null) {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
ISelection currSelection= getCurrentViewer().getSelection(); if (currSelection == null || currSelection.isEmpty()) { internalSelectType(getSelectableType(fInputElement), false); currSelection= getCurrentViewer().getSelection(); } if (!fIsEnableMemberFilter) { typeSelectionChanged(currSelection); } } updateTitle(); if (fHierarchyProblemListener != null) { JavaPlugin.getDefault().getProblemMarkerManager().removeListener(fHierarchyProblemListener); } fHierarchyProblemListener= getCurrentViewer(); JavaPlugin.getDefault().getProblemMarkerManager().addListener(fHierarchyProblemListener); fDialogSettings.put(DIALOGSTORE_HIERARCHYVIEW, viewerIndex); getCurrentViewer().getTree().setFocus(); } for (int i= 0; i < fViewActions.length; i++) { ToggleViewAction action= fViewActions[i]; action.setChecked(fCurrentViewerIndex == action.getViewerIndex()); } } /** * Gets the curret active view index. */ public int getViewIndex() {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
return fCurrentViewerIndex; } private TypeHierarchyViewer getCurrentViewer() { return fAllViewers[fCurrentViewerIndex]; } /** * called from EnableMemberFilterAction. * Must be called after creation of the viewpart. */ public void enableMemberFilter(boolean on) { if (on != fIsEnableMemberFilter) { fIsEnableMemberFilter= on; if (!on) { IType methodViewerInput= (IType) fMethodsViewer.getInput(); setMemberFilter(null); updateHierarchyViewer(); updateTitle(); if (methodViewerInput != null && getCurrentViewer().isElementShown(methodViewerInput)) { internalSelectType(methodViewerInput, true); } else if (fSelectedType != null) { internalSelectType(fSelectedType, true); updateMethodViewer(fSelectedType); } } else { methodSelectionChanged(fMethodsViewer.getSelection()); }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
} fEnableMemberFilterAction.setChecked(on); } /** * Called from ITypeHierarchyLifeCycleListener. * Can be called from any thread */ private void doTypeHierarchyChanged(final TypeHierarchyLifeCycle typeHierarchy, final IType[] changedTypes) { Display display= getDisplay(); if (display != null) { display.asyncExec(new Runnable() { public void run() { doTypeHierarchyChangedOnViewers(changedTypes); } }); } } private void doTypeHierarchyChangedOnViewers(IType[] changedTypes) { if (fHierarchyLifeCycle.getHierarchy() == null || !fHierarchyLifeCycle.getHierarchy().exists()) { clearInput(); } else { if (changedTypes == null) { try { fHierarchyLifeCycle.ensureRefreshedTypeHierarchy(fInputElement); } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); clearInput();
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
return; } updateHierarchyViewer(); } else { if (getCurrentViewer().isMethodFiltering()) { if (changedTypes.length == 1) { getCurrentViewer().refresh(changedTypes[0]); } else { updateHierarchyViewer(); } } else { getCurrentViewer().update(changedTypes, new String[] { IBasicPropertyConstants.P_TEXT, IBasicPropertyConstants.P_IMAGE } ); } } } } /** * Determines the input element to be used initially . */ private IJavaElement determineInputElement() { Object input= getSite().getPage().getInput(); if (input instanceof IJavaElement) { return (IJavaElement) input; } return null; }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
/* * @see IViewPart#init */ public void init(IViewSite site, IMemento memento) throws PartInitException { super.init(site, memento); fMemento= memento; } /* * @see ViewPart#saveState(IMemento) */ public void saveState(IMemento memento) { if (fPagebook == null) { if (fMemento != null) { memento.putMemento(fMemento); } return; } if (fInputElement != null) { memento.putString(TAG_INPUT, fInputElement.getHandleIdentifier()); } memento.putInteger(TAG_VIEW, getViewIndex()); memento.putInteger(TAG_ORIENTATION, fCurrentOrientation); int weigths[]= fTypeMethodsSplitter.getWeights(); int ratio= (weigths[0] * 1000) / (weigths[0] + weigths[1]); memento.putInteger(TAG_RATIO, ratio); ScrollBar bar= getCurrentViewer().getTree().getVerticalBar(); int position= bar != null ? bar.getSelection() : 0;
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
memento.putInteger(TAG_VERTICAL_SCROLL, position); IJavaElement selection= (IJavaElement)((IStructuredSelection) getCurrentViewer().getSelection()).getFirstElement(); if (selection != null) { memento.putString(TAG_SELECTION, selection.getHandleIdentifier()); } fMethodsViewer.saveState(memento); } /** * Restores the type hierarchy settings from a memento. */ private void restoreState(IMemento memento, IJavaElement defaultInput) { IJavaElement input= defaultInput; String elementId= memento.getString(TAG_INPUT); if (elementId != null) { input= JavaCore.create(elementId); if (!input.exists()) { input= null; } } setInputElement(input); Integer viewerIndex= memento.getInteger(TAG_VIEW); if (viewerIndex != null) { setView(viewerIndex.intValue()); } Integer orientation= memento.getInteger(TAG_ORIENTATION); if (orientation != null) { setOrientation(orientation.intValue()); }
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Integer ratio= memento.getInteger(TAG_RATIO); if (ratio != null) { fTypeMethodsSplitter.setWeights(new int[] { ratio.intValue(), 1000 - ratio.intValue() }); } ScrollBar bar= getCurrentViewer().getTree().getVerticalBar(); if (bar != null) { Integer vScroll= memento.getInteger(TAG_VERTICAL_SCROLL); if (vScroll != null) { bar.setSelection(vScroll.intValue()); } } String selectionId= memento.getString(TAG_SELECTION); if (selectionId != null) { IJavaElement elem= JavaCore.create(selectionId); if (getCurrentViewer().isElementShown(elem) && elem instanceof IMember) { internalSelectType((IMember)elem, false); } } fMethodsViewer.restoreState(memento); } /** * Link selection to active editor. */ private void editorActivated(IEditorPart editor) { if (!JavaBasePreferencePage.linkTypeHierarchySelectionToEditor()) { return; } if (fInputElement == null) {
8,815
Bug 8815 Open Hierarchy does not set focus correctly
If I open the type hierarchy then the Hierarchy view has the focus but the element inside its viewer is gray - it should be blue. This affects the Java Browsers: the selection is not propagated and the Members view remains empty.
verified fixed
3820185
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:11:21Z
2002-01-31T09:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
return; } IJavaElement elem= (IJavaElement)editor.getEditorInput().getAdapter(IJavaElement.class); try { TypeHierarchyViewer currentViewer= getCurrentViewer(); if (elem instanceof IClassFile) { IType type= ((IClassFile)elem).getType(); if (currentViewer.isElementShown(type)) { internalSelectType(type, true); updateMethodViewer(type); } } else if (elem instanceof ICompilationUnit) { IType[] allTypes= ((ICompilationUnit)elem).getAllTypes(); for (int i= 0; i < allTypes.length; i++) { if (currentViewer.isElementShown(allTypes[i])) { internalSelectType(allTypes[i], true); updateMethodViewer(allTypes[i]); return; } } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } }
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.typehierarchy; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.List;
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jdt.core.ElementChangedEvent; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IElementChangedListener; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaElementDelta; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.IRegion; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.ITypeHierarchyChangedListener; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; /** * Manages a type hierarchy, to keep it refreshed, and to allow it to be shared. */ public class TypeHierarchyLifeCycle implements ITypeHierarchyChangedListener, IElementChangedListener { private boolean fHierarchyRefreshNeeded; private ITypeHierarchy fHierarchy; private IJavaElement fInputElement; private boolean fIsSuperTypesOnly;
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
private List fChangeListeners; public TypeHierarchyLifeCycle() { this(false); } public TypeHierarchyLifeCycle(boolean isSuperTypesOnly) { fHierarchy= null; fInputElement= null; fIsSuperTypesOnly= isSuperTypesOnly; fChangeListeners= new ArrayList(2); } public ITypeHierarchy getHierarchy() { return fHierarchy; } public IJavaElement getInputElement() { return fInputElement; } public void freeHierarchy() { if (fHierarchy != null) { fHierarchy.removeTypeHierarchyChangedListener(this); JavaCore.removeElementChangedListener(this); fHierarchy= null; fInputElement= null; }
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
} public void removeChangedListener(ITypeHierarchyLifeCycleListener listener) { fChangeListeners.remove(listener); } public void addChangedListener(ITypeHierarchyLifeCycleListener listener) { if (!fChangeListeners.contains(listener)) { fChangeListeners.add(listener); } } private void fireChange(IType[] changedTypes) { for (int i= fChangeListeners.size()-1; i>=0; i--) { ITypeHierarchyLifeCycleListener curr= (ITypeHierarchyLifeCycleListener) fChangeListeners.get(i); curr.typeHierarchyChanged(this, changedTypes); } } public void ensureRefreshedTypeHierarchy(final IJavaElement element) throws JavaModelException { if (element == null) { freeHierarchy(); return; } boolean hierachyCreationNeeded= (fHierarchy == null || !element.equals(fInputElement)); if (hierachyCreationNeeded || fHierarchyRefreshNeeded) { IRunnableWithProgress op= new IRunnableWithProgress() { public void run(IProgressMonitor pm) throws InvocationTargetException { try {
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
doHierarchyRefresh(element, pm); } catch (JavaModelException e) { throw new InvocationTargetException(e); } } }; try { new BusyIndicatorRunnableContext().run(false, false, op); } catch (InvocationTargetException e) { Throwable th= e.getTargetException(); if (th instanceof JavaModelException) { throw (JavaModelException)th; } else { throw new JavaModelException(th, IStatus.ERROR); } } catch (InterruptedException e) { } fHierarchyRefreshNeeded= false; } } private void doHierarchyRefresh(IJavaElement element, IProgressMonitor pm) throws JavaModelException { boolean hierachyCreationNeeded= (fHierarchy == null || !element.equals(fInputElement)); if (fHierarchy != null) { fHierarchy.removeTypeHierarchyChangedListener(this);
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
JavaCore.removeElementChangedListener(this); } if (hierachyCreationNeeded) { fInputElement= element; if (element.getElementType() == IJavaElement.TYPE) { IType type= (IType) element; if (fIsSuperTypesOnly) { fHierarchy= type.newSupertypeHierarchy(pm); } else { fHierarchy= type.newTypeHierarchy(pm); } } else { IRegion region= JavaCore.newRegion(); if (element.getElementType() == IJavaElement.JAVA_PROJECT) { IPackageFragmentRoot[] roots= ((IJavaProject) element).getPackageFragmentRoots(); for (int i= 0; i < roots.length; i++) { if (roots[i].getKind() == IPackageFragmentRoot.K_SOURCE) { region.add(roots[i]); } } } else { region.add(element); } IJavaProject jproject= element.getJavaProject(); fHierarchy= jproject.newTypeHierarchy(region, pm); } } else { fHierarchy.refresh(pm); }
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
fHierarchy.addTypeHierarchyChangedListener(this); JavaCore.addElementChangedListener(this); } /* * @see ITypeHierarchyChangedListener#typeHierarchyChanged */ public void typeHierarchyChanged(ITypeHierarchy typeHierarchy) { fHierarchyRefreshNeeded= true; } /* * @see IElementChangedListener#elementChanged(ElementChangedEvent) */ public void elementChanged(ElementChangedEvent event) { if (fChangeListeners.isEmpty()) { return; } IJavaElement elem= event.getDelta().getElement(); if (elem instanceof IWorkingCopy && ((IWorkingCopy)elem).isWorkingCopy()) { return; } if (fHierarchyRefreshNeeded) { fireChange(null); } else { ArrayList changedTypes= new ArrayList(); processDelta(event.getDelta(), changedTypes); fireChange((IType[]) changedTypes.toArray(new IType[changedTypes.size()])); } }
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
/* * Assume that the hierarchy is intact (no refresh needed) */ private void processDelta(IJavaElementDelta delta, ArrayList changedTypes) { IJavaElement element= delta.getElement(); switch (element.getElementType()) { case IJavaElement.TYPE: processTypeDelta((IType) element, changedTypes); processChildrenDelta(delta, changedTypes); break; case IJavaElement.JAVA_MODEL: case IJavaElement.JAVA_PROJECT: case IJavaElement.PACKAGE_FRAGMENT_ROOT: case IJavaElement.PACKAGE_FRAGMENT: processChildrenDelta(delta, changedTypes); break; case IJavaElement.COMPILATION_UNIT: if (delta.getKind() == IJavaElementDelta.CHANGED && (delta.getFlags() & IJavaElementDelta.F_CONTENT) != 0) { try { IType[] types= ((ICompilationUnit) element).getAllTypes(); for (int i= 0; i < types.length; i++) { processTypeDelta(types[i], changedTypes); } } catch (JavaModelException e) { JavaPlugin.log(e); } } else { processChildrenDelta(delta, changedTypes); }
8,142
Bug 8142 no scoped type hierarchy on binary projects
When I hit F4 on a binary project selection (e.g. org.apache.ant), I get: 'No declaration of selected members in the chosen hierarchy of 'org.apache.ant'. I would expect to see the class hierarchies of the internal jars. BTW, what does the message mean? I don't understand it.
verified fixed
4b48a12
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:17:50Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java
break; case IJavaElement.CLASS_FILE: if (delta.getKind() == IJavaElementDelta.CHANGED && (delta.getFlags() & IJavaElementDelta.F_CONTENT) != 0) { try { IType type= ((IClassFile) element).getType(); processTypeDelta(type, changedTypes); } catch (JavaModelException e) { JavaPlugin.log(e); } } else { processChildrenDelta(delta, changedTypes); } break; } } private void processTypeDelta(IType type, ArrayList changedTypes) { if (getHierarchy().contains(type)) { changedTypes.add(type); } } private void processChildrenDelta(IJavaElementDelta delta, ArrayList changedTypes) { IJavaElementDelta[] children= delta.getAffectedChildren(); for (int i= 0; i < children.length; i++) { processDelta(children[i], changedTypes); } } }
8,205
Bug 8205 Missing mnemonic: Outline View->Open Super Implementation
Select a method in the outline view. "Open Super Implementation" on the popup menu is missing a mnemonic.
resolved fixed
f81a291
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:25:54Z
2002-01-23T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenExternalJavadocAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.actions; import java.io.IOException; import java.net.URL; import org.eclipse.core.runtime.CoreException; import org.eclipse.swt.SWT; import org.eclipse.swt.program.Program; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; import org.eclipse.jface.dialogs.ErrorDialog;
8,205
Bug 8205 Missing mnemonic: Outline View->Open Super Implementation
Select a method in the outline view. "Open Super Implementation" on the popup menu is missing a mnemonic.
resolved fixed
f81a291
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:25:54Z
2002-01-23T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenExternalJavadocAction.java
import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.ui.IObjectActionDelegate; import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.texteditor.IUpdate; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.internal.corext.javadoc.JavaDocLocations; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaUIMessages; /** * On a selected member; opens the Javadoc in an external browser (if existing) */ public class OpenExternalJavadocAction extends Action implements IUpdate, IObjectActionDelegate { private StructuredSelectionProvider fSelectionProvider; /** * Use only for IWorkbenchWindowActionDelegates! */ public OpenExternalJavadocAction() { this(null); } public OpenExternalJavadocAction(StructuredSelectionProvider provider) { super(); setText("Open External Javadoc@Shift+F2"); setDescription("Opens the Javadoc of the selected element in an external browser");
8,205
Bug 8205 Missing mnemonic: Outline View->Open Super Implementation
Select a method in the outline view. "Open Super Implementation" on the popup menu is missing a mnemonic.
resolved fixed
f81a291
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:25:54Z
2002-01-23T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenExternalJavadocAction.java
setToolTipText("Opens the Javadoc of the selected element in an external browser"); fSelectionProvider= provider; } public void update() { setEnabled(canOperateOn()); } private boolean canOperateOn() { if (fSelectionProvider != null) { IStructuredSelection selection= fSelectionProvider.getSelection(StructuredSelectionProvider.FLAGS_GET_EDITOR_INPUT); return selection.size() == 1; } return false; } private IJavaElement getDocumentedElement() { if (fSelectionProvider == null) { return null; } IStructuredSelection selection= fSelectionProvider.getSelection(StructuredSelectionProvider.FLAGS_DO_CODERESOLVE | StructuredSelectionProvider.FLAGS_GET_EDITOR_INPUT); if (selection.size() != 1) return null; Object obj= selection.getFirstElement(); if (obj instanceof IJavaElement) { IJavaElement elem= (IJavaElement) obj; int type= elem.getElementType(); if (type == IJavaElement.JAVA_MODEL || type == IJavaElement.JAVA_PROJECT) {
8,205
Bug 8205 Missing mnemonic: Outline View->Open Super Implementation
Select a method in the outline view. "Open Super Implementation" on the popup menu is missing a mnemonic.
resolved fixed
f81a291
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:25:54Z
2002-01-23T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenExternalJavadocAction.java
return null; } if (type == IJavaElement.IMPORT_DECLARATION) { return elem; } IPackageFragmentRoot root= JavaModelUtil.getPackageFragmentRoot(elem); if (JavaDocLocations.getJavadocLocation(root.getPath()) != null) { return elem; } } return null; } public void run() { IJavaElement element= getDocumentedElement(); if (element == null) { return; } try { URL url= JavaDocLocations.getJavaDocLocation(element); if (url != null) { openInBrowser(url, JavaPlugin.getActiveWorkbenchShell()); } } catch (CoreException e) { JavaPlugin.log(e); String title= "Open External Javadoc"; String message= "Opening Javadoc failed. See log for details."; ErrorDialog.openError(JavaPlugin.getActiveWorkbenchShell(), title, message, e.getStatus()); } }
8,205
Bug 8205 Missing mnemonic: Outline View->Open Super Implementation
Select a method in the outline view. "Open Super Implementation" on the popup menu is missing a mnemonic.
resolved fixed
f81a291
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:25:54Z
2002-01-23T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenExternalJavadocAction.java
/* * @see IActionDelegate#run(IAction) */ public void run(IAction action) { run(); } /* * @see IActionDelegate#selectionChanged(IAction, ISelection) */ public void selectionChanged(IAction action, ISelection selection) { } /* * @see IObjectActionDelegate#setActivePart(IAction, IWorkbenchPart) */ public void setActivePart(IAction action, IWorkbenchPart targetPart) { fSelectionProvider= StructuredSelectionProvider.createFrom(targetPart.getSite().getWorkbenchWindow().getSelectionService()); } private static boolean webBrowserOpened = false; /** * Copied from AboutPluginsDialog.openMoreInfo */ public static void openInBrowser(final URL url, final Shell shell) { if (SWT.getPlatform().equals("win32")) { Program.launch(url.toString());
8,205
Bug 8205 Missing mnemonic: Outline View->Open Super Implementation
Select a method in the outline view. "Open Super Implementation" on the popup menu is missing a mnemonic.
resolved fixed
f81a291
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:25:54Z
2002-01-23T18:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OpenExternalJavadocAction.java
} else { Thread launcher = new Thread("External Javadoc Launcher") { public void run() { try { if (webBrowserOpened) { Runtime.getRuntime().exec("netscape -remote openURL(" + url.toString() + ")"); } else { Process p = Runtime.getRuntime().exec("netscape " + url.toString()); webBrowserOpened = true; try { if (p != null) p.waitFor(); } catch (InterruptedException e) { MessageDialog.openError(shell, "Open External Javadoc", e.getMessage()); } finally { webBrowserOpened = false; } } } catch (IOException e) { MessageDialog.openError(shell, "Open External Javadoc", e.getMessage()); } } }; launcher.start(); } } }
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.preferences; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Hashtable; import org.eclipse.swt.SWT; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button;
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
import org.eclipse.swt.widgets.Combo; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.TabFolder; import org.eclipse.swt.widgets.TabItem; import org.eclipse.swt.widgets.Widget; import org.eclipse.core.resources.IncrementalProjectBuilder; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferencePage; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPreferencePage; import org.eclipse.ui.help.DialogPageContextComputer; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.TabFolderLayout; /* * The page for setting the compiler options. */ public class CompilerPreferencePage extends PreferencePage implements IWorkbenchPreferencePage {
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
private static final String PREF_LOCAL_VARIABLE_ATTR= "org.eclipse.jdt.core.compiler.debug.localVariable"; private static final String PREF_LINE_NUMBER_ATTR= "org.eclipse.jdt.core.compiler.debug.lineNumber"; private static final String PREF_SOURCE_FILE_ATTR= "org.eclipse.jdt.core.compiler.debug.sourceFile"; private static final String PREF_CODEGEN_UNUSED_LOCAL= "org.eclipse.jdt.core.compiler.codegen.unusedLocal"; private static final String PREF_CODEGEN_TARGET_PLATFORM= "org.eclipse.jdt.core.compiler.codegen.targetPlatform"; private static final String PREF_PB_UNREACHABLE_CODE= "org.eclipse.jdt.core.compiler.problem.unreachableCode"; private static final String PREF_PB_INVALID_IMPORT= "org.eclipse.jdt.core.compiler.problem.invalidImport"; private static final String PREF_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD= "org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod"; private static final String PREF_PB_METHOD_WITH_CONSTRUCTOR_NAME= "org.eclipse.jdt.core.compiler.problem.methodWithConstructorName"; private static final String PREF_PB_DEPRECATION= "org.eclipse.jdt.core.compiler.problem.deprecation"; private static final String PREF_PB_HIDDEN_CATCH_BLOCK= "org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock"; private static final String PREF_PB_UNUSED_LOCAL= "org.eclipse.jdt.core.compiler.problem.unusedLocal"; private static final String PREF_PB_UNUSED_PARAMETER= "org.eclipse.jdt.core.compiler.problem.unusedParameter"; private static final String PREF_PB_SYNTHETIC_ACCESS_EMULATION= "org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation"; private static final String PREF_PB_NON_EXTERNALIZED_STRINGS= "org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral"; private static final String PREF_PB_ASSERT_AS_IDENTIFIER= "org.eclipse.jdt.core.compiler.problem.assertIdentifier"; private static final String PREF_SOURCE_COMPATIBILITY= "org.eclipse.jdt.core.compiler.source"; private static final String GENERATE= "generate"; private static final String DO_NOT_GENERATE= "do not generate"; private static final String PRESERVE= "preserve"; private static final String OPTIMIZE_OUT= "optimize out"; private static final String VERSION_1_1= "1.1"; private static final String VERSION_1_2= "1.2"; private static final String VERSION_1_3= "1.3"; private static final String VERSION_1_4= "1.4";
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
private static final String ERROR= "error"; private static final String WARNING= "warning"; private static final String IGNORE= "ignore"; private static String[] getAllKeys() { return new String[] { PREF_LOCAL_VARIABLE_ATTR, PREF_LINE_NUMBER_ATTR, PREF_SOURCE_FILE_ATTR, PREF_CODEGEN_UNUSED_LOCAL, PREF_CODEGEN_TARGET_PLATFORM, PREF_PB_UNREACHABLE_CODE, PREF_PB_INVALID_IMPORT, PREF_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD, PREF_PB_METHOD_WITH_CONSTRUCTOR_NAME, PREF_PB_DEPRECATION, PREF_PB_HIDDEN_CATCH_BLOCK, PREF_PB_UNUSED_LOCAL, PREF_PB_UNUSED_PARAMETER, PREF_PB_SYNTHETIC_ACCESS_EMULATION, PREF_PB_NON_EXTERNALIZED_STRINGS, PREF_PB_ASSERT_AS_IDENTIFIER, PREF_SOURCE_COMPATIBILITY }; } /** * Initializes the current options (read from preference store) */ public static void initDefaults(IPreferenceStore store) { Hashtable hashtable= JavaCore.getDefaultOptions(); Hashtable currOptions= JavaCore.getOptions(); String[] allKeys= getAllKeys(); for (int i= 0; i < allKeys.length; i++) { String key= allKeys[i]; String defValue= (String) hashtable.get(key); if (defValue != null) { store.setDefault(key, defValue); } else { JavaPlugin.logErrorMessage("CompilerPreferencePage: value is null: " + key); } String val= store.getString(key);
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
if (val != null) { currOptions.put(key, val); } } JavaCore.setOptions(currOptions); } private static class ControlData { private String fKey; private String[] fValues; public ControlData(String key, String[] values) { fKey= key; fValues= values; } public String getKey() { return fKey; } public String getValue(boolean selection) { int index= selection ? 0 : 1; return fValues[index]; } public String getValue(int index) { return fValues[index]; } public int getSelection(String value) { for (int i= 0; i < fValues.length; i++) {
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
if (value.equals(fValues[i])) { return i; } } throw new IllegalArgumentException(); } } private Hashtable fWorkingValues; private ArrayList fCheckBoxes; private ArrayList fComboBoxes; private SelectionListener fSelectionListener; public CompilerPreferencePage() { setPreferenceStore(JavaPlugin.getDefault().getPreferenceStore()); setDescription(JavaUIMessages.getString("CompilerPreferencePage.description")); fWorkingValues= JavaCore.getOptions(); fCheckBoxes= new ArrayList(); fComboBoxes= new ArrayList(); fSelectionListener= new SelectionListener() { public void widgetDefaultSelected(SelectionEvent e) {} public void widgetSelected(SelectionEvent e) { controlChanged(e.widget); } }; } /**
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
* @see IWorkbenchPreferencePage#init() */ public void init(IWorkbench workbench) { } /** * @see PreferencePage#createControl(Composite) */ public void createControl(Composite parent) { super.createControl(parent); WorkbenchHelp.setHelp(getControl(), new DialogPageContextComputer(this, IJavaHelpContextIds.COMPILER_PREFERENCE_PAGE)); } /** * @see PreferencePage#createContents(Composite) */ protected Control createContents(Composite parent) { TabFolder folder= new TabFolder(parent, SWT.NONE); folder.setLayout(new TabFolderLayout()); folder.setLayoutData(new GridData(GridData.FILL_BOTH)); String[] errorWarningIgnore= new String[] { ERROR, WARNING, IGNORE }; String[] errorWarningIgnoreLabels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.error"), JavaUIMessages.getString("CompilerPreferencePage.warning"), JavaUIMessages.getString("CompilerPreferencePage.ignore") }; GridLayout layout= new GridLayout(); layout.numColumns= 2;
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
Composite warningsComposite= new Composite(folder, SWT.NULL); warningsComposite.setLayout(layout); String label= JavaUIMessages.getString("CompilerPreferencePage.pb_unreachable_code.label"); addComboBox(warningsComposite, label, PREF_PB_UNREACHABLE_CODE, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_invalid_import.label"); addComboBox(warningsComposite, label, PREF_PB_INVALID_IMPORT, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_overriding_pkg_dflt.label"); addComboBox(warningsComposite, label, PREF_PB_OVERRIDING_PACKAGE_DEFAULT_METHOD, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_method_naming.label"); addComboBox(warningsComposite, label, PREF_PB_METHOD_WITH_CONSTRUCTOR_NAME, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_deprecation.label"); addComboBox(warningsComposite, label, PREF_PB_DEPRECATION, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_hidden_catchblock.label"); addComboBox(warningsComposite, label, PREF_PB_HIDDEN_CATCH_BLOCK, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_unused_local.label"); addComboBox(warningsComposite, label, PREF_PB_UNUSED_LOCAL, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_unused_parameter.label"); addComboBox(warningsComposite, label, PREF_PB_UNUSED_PARAMETER, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_synth_access_emul.label"); addComboBox(warningsComposite, label, PREF_PB_SYNTHETIC_ACCESS_EMULATION, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_non_externalized_strings.label"); addComboBox(warningsComposite, label, PREF_PB_NON_EXTERNALIZED_STRINGS, errorWarningIgnore, errorWarningIgnoreLabels); label= JavaUIMessages.getString("CompilerPreferencePage.pb_assert_as_identifier.label"); addComboBox(warningsComposite, label, PREF_PB_ASSERT_AS_IDENTIFIER, errorWarningIgnore, errorWarningIgnoreLabels);
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
String[] generateValues= new String[] { GENERATE, DO_NOT_GENERATE }; layout= new GridLayout(); layout.numColumns= 2; Composite codeGenComposite= new Composite(folder, SWT.NULL); codeGenComposite.setLayout(layout); label= JavaUIMessages.getString("CompilerPreferencePage.variable_attr.label"); addCheckBox(codeGenComposite, label, PREF_LOCAL_VARIABLE_ATTR, generateValues); label= JavaUIMessages.getString("CompilerPreferencePage.line_number_attr.label"); addCheckBox(codeGenComposite, label, PREF_LINE_NUMBER_ATTR, generateValues); label= JavaUIMessages.getString("CompilerPreferencePage.source_file_attr.label"); addCheckBox(codeGenComposite, label, PREF_SOURCE_FILE_ATTR, generateValues); label= JavaUIMessages.getString("CompilerPreferencePage.codegen_unused_local.label"); addCheckBox(codeGenComposite, label, PREF_CODEGEN_UNUSED_LOCAL, new String[] { PRESERVE, OPTIMIZE_OUT }); String[] values= new String[] { VERSION_1_1, VERSION_1_2, VERSION_1_3, VERSION_1_4 }; String[] valuesLabels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.jvm11"), JavaUIMessages.getString("CompilerPreferencePage.jvm12"), JavaUIMessages.getString("CompilerPreferencePage.jvm13"), JavaUIMessages.getString("CompilerPreferencePage.jvm14") }; label= JavaUIMessages.getString("CompilerPreferencePage.codegen_targetplatform.label"); addComboBox(codeGenComposite, label, PREF_CODEGEN_TARGET_PLATFORM, values, valuesLabels); values= new String[] { VERSION_1_3, VERSION_1_4 }; valuesLabels= new String[] { JavaUIMessages.getString("CompilerPreferencePage.version13"), JavaUIMessages.getString("CompilerPreferencePage.version14") };
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
label= JavaUIMessages.getString("CompilerPreferencePage.source_compatibility.label"); addComboBox(codeGenComposite, label, PREF_SOURCE_COMPATIBILITY, values, valuesLabels); TabItem item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CompilerPreferencePage.warnings.tabtitle")); item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_REFACTORING_WARNING)); item.setControl(warningsComposite); item= new TabItem(folder, SWT.NONE); item.setText(JavaUIMessages.getString("CompilerPreferencePage.generation.tabtitle")); item.setImage(JavaPluginImages.get(JavaPluginImages.IMG_OBJS_CFILE)); item.setControl(codeGenComposite); return folder; } private void addCheckBox(Composite parent, String label, String key, String[] values) { ControlData data= new ControlData(key, values); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.horizontalSpan= 2; Button checkBox= new Button(parent, SWT.CHECK); checkBox.setText(label); checkBox.setData(data); checkBox.setLayoutData(gd); checkBox.addSelectionListener(fSelectionListener); String currValue= (String)fWorkingValues.get(key); checkBox.setSelection(data.getSelection(currValue) == 0);
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
fCheckBoxes.add(checkBox); } private void addComboBox(Composite parent, String label, String key, String[] values, String[] valueLabels) { ControlData data= new ControlData(key, values); Label labelControl= new Label(parent, SWT.NONE); labelControl.setText(label); labelControl.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); GridData gd= new GridData(); gd.horizontalAlignment= GridData.FILL; Combo comboBox= new Combo(parent, SWT.READ_ONLY); comboBox.setItems(valueLabels); comboBox.setData(data); comboBox.setLayoutData(gd); comboBox.addSelectionListener(fSelectionListener); String currValue= (String)fWorkingValues.get(key); comboBox.select(data.getSelection(currValue)); fComboBoxes.add(comboBox); } private void controlChanged(Widget widget) { ControlData data= (ControlData) widget.getData(); String newValue= null; if (widget instanceof Button) {
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
newValue= data.getValue(((Button)widget).getSelection()); } else if (widget instanceof Combo) { newValue= data.getValue(((Combo)widget).getSelectionIndex()); } else { return; } fWorkingValues.put(data.getKey(), newValue); } /* * @see IPreferencePage#performOk() */ public boolean performOk() { String[] allKeys= getAllKeys(); Hashtable actualOptions= JavaCore.getOptions(); IPreferenceStore store= getPreferenceStore(); boolean hasChanges= false; for (int i= 0; i < allKeys.length; i++) { String key= allKeys[i]; String val= (String) fWorkingValues.get(key); String oldVal= (String) actualOptions.get(key); hasChanges= hasChanges | !val.equals(oldVal); actualOptions.put(key, val); store.setValue(key, val); } JavaCore.setOptions(actualOptions);
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
if (hasChanges) { String title= JavaUIMessages.getString("CompilerPreferencePage.needsbuild.title"); String message= JavaUIMessages.getString("CompilerPreferencePage.needsbuild.message"); if (MessageDialog.openQuestion(getShell(), title, message)) { doFullBuild(); } } return super.performOk(); } private void doFullBuild() { ProgressMonitorDialog dialog= new ProgressMonitorDialog(getShell()); try { dialog.run(true, true, new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException { try { JavaPlugin.getWorkspace().build(IncrementalProjectBuilder.FULL_BUILD, monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }); } catch (InterruptedException e) { } catch (InvocationTargetException e) { String title= JavaUIMessages.getString("CompilerPreferencePage.builderror.title"); String message= JavaUIMessages.getString("CompilerPreferencePage.builderror.message"); ExceptionHandler.handle(e, getShell(), title, message); } }
8,443
Bug 8443 Wording in Compiler prefer page needs to be improved
Martin let's discuss how to improve the wording. From Greg: * With respect to the preference page its problematic on several fronts - it requires me to have to rebuild everything - it is separate from the task view & thus does not work as your typical view filter works * the page itself is unclear to a user. When a user first sees this preference page they are not sure what it actually means. This is probably fixed with some simple text that says something like "What severity level do you want to assign to the following problems."
resolved fixed
32b312f
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-07T19:26:43Z
2002-01-25T00:53:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CompilerPreferencePage.java
/* * @see PreferencePage#performDefaults() */ protected void performDefaults() { fWorkingValues= JavaCore.getDefaultOptions(); updateControls(); super.performDefaults(); } private void updateControls() { for (int i= fCheckBoxes.size() - 1; i >= 0; i--) { Button curr= (Button) fCheckBoxes.get(i); ControlData data= (ControlData) curr.getData(); String currValue= (String) fWorkingValues.get(data.getKey()); curr.setSelection(data.getSelection(currValue) == 0); } for (int i= fComboBoxes.size() - 1; i >= 0; i--) { Combo curr= (Combo) fComboBoxes.get(i); ControlData data= (ControlData) curr.getData(); String currValue= (String) fWorkingValues.get(data.getKey()); curr.select(data.getSelection(currValue)); } } }
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Comparator; import java.util.Iterator; import java.util.List; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.util.Assert; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.corext.util.AllTypesCache; import org.eclipse.jdt.internal.corext.util.TypeInfo; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.StringMatcher; import org.eclipse.jdt.internal.ui.util.TypeInfoLabelProvider; /** * A dialog to select a type from a list of types. */ public class TypeSelectionDialog extends TwoPaneElementSelector {
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
private static class TypeFilterMatcher implements FilteredList.FilterMatcher { private StringMatcher fMatcher; private StringMatcher fQualifierMatcher; /* * @see FilteredList.FilterMatcher#setFilter(String, boolean) */ public void setFilter(String pattern, boolean ignoreCase, boolean igoreWildCards) { int qualifierIndex= pattern.lastIndexOf("."); if (qualifierIndex == -1) { fQualifierMatcher= null; fMatcher= new StringMatcher(pattern + '*', ignoreCase, igoreWildCards); } else { fQualifierMatcher= new StringMatcher(pattern.substring(0, qualifierIndex), ignoreCase, igoreWildCards); fMatcher= new StringMatcher(pattern.substring(qualifierIndex + 1), ignoreCase, igoreWildCards); } } /*
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
* @see FilteredList.FilterMatcher#match(Object) */ public boolean match(Object element) { if (!(element instanceof TypeInfo)) return false; TypeInfo type= (TypeInfo) element; if (!fMatcher.match(type.getTypeName())) return false; if (fQualifierMatcher == null) return true; return fQualifierMatcher.match(type.getTypeContainerName()); } } /* * A string comparator which is aware of obfuscated code * (type names starting with lower case characters). */ private static class StringComparator implements Comparator { public int compare(Object left, Object right) { String leftString= (String) left; String rightString= (String) right; if (Character.isLowerCase(leftString.charAt(0)) && !Character.isLowerCase(rightString.charAt(0))) return +1; if (Character.isLowerCase(rightString.charAt(0)) && !Character.isLowerCase(leftString.charAt(0))) return -1;
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
return leftString.compareToIgnoreCase(rightString); } } private IRunnableContext fRunnableContext; private IJavaSearchScope fScope; private int fElementKinds; /** * Constructs a type selection dialog. * @param parent the parent shell. * @param context the runnable context. * @param elementKinds <code>IJavaSearchConstants.CLASS</code>, <code>IJavaSearchConstants.INTERFACE</code> * or <code>IJavaSearchConstants.TYPE</code> * @param scope the java search scope. */ public TypeSelectionDialog(Shell parent, IRunnableContext context, int elementKinds, IJavaSearchScope scope) { super(parent, new TypeInfoLabelProvider(TypeInfoLabelProvider.SHOW_TYPE_ONLY), new TypeInfoLabelProvider(TypeInfoLabelProvider.SHOW_TYPE_CONTAINER_ONLY + TypeInfoLabelProvider.SHOW_ROOT_POSTFIX)); Assert.isNotNull(context); Assert.isNotNull(scope); fRunnableContext= context; fScope= scope; fElementKinds= elementKinds; setUpperListLabel(JavaUIMessages.getString("TypeSelectionDialog.upperLabel")); setLowerListLabel(JavaUIMessages.getString("TypeSelectionDialog.lowerLabel")); } public void create() { if (getFilter() == null) setFilter("A");
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
super.create(); } /* * @see AbstractElementListSelectionDialog#createFilteredList(Composite) */ protected FilteredList createFilteredList(Composite parent) { FilteredList list= super.createFilteredList(parent); fFilteredList.setFilterMatcher(new TypeFilterMatcher()); fFilteredList.setComparator(new StringComparator()); return list; } /** * @see Window#open() */ public int open() { final ArrayList typeList= new ArrayList(); IRunnableWithProgress runnable= new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { try { AllTypesCache.getTypes(fScope, fElementKinds, monitor, typeList); } catch (JavaModelException e) { throw new InvocationTargetException(e); } if (monitor.isCanceled()) { throw new InterruptedException(); }
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
} }; try { fRunnableContext.run(true, true, runnable); } catch (InvocationTargetException e) { ExceptionHandler.handle(e, "Exception", "Unexpected exception. See log for details."); } catch (InterruptedException e) { return CANCEL; } List filteredList= new ArrayList(typeList.size()); for (Iterator iterator = typeList.iterator(); iterator.hasNext();) { TypeInfo info = (TypeInfo) iterator.next(); if (info.getTypeName().length() != 0) filteredList.add(info); } if (filteredList.isEmpty()) { String title= JavaUIMessages.getString("TypeSelectionDialog.notypes.title"); String message= JavaUIMessages.getString("TypeSelectionDialog.notypes.message"); MessageDialog.openInformation(getShell(), title, message); return CANCEL; } TypeInfo[] typeRefs= (TypeInfo[])filteredList.toArray(new TypeInfo[filteredList.size()]); setElements(typeRefs); return super.open(); }
6,835
Bug 6835 characters and doesn't work in Java editor on Swedish keyboard
On a Swedish keybord the charaters and doesnt work. If I type one of theese charaters 9 gibberlish character symbols occur on the screen. This happens on XFree 4.1.0 X server and Redhat 7.2
resolved fixed
51cab62
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T11:38:01Z
2001-12-12T04:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/TypeSelectionDialog.java
/** * @see SelectionStatusDialog#computeResult() */ protected void computeResult() { TypeInfo ref= (TypeInfo) getLowerSelectedElement(); if (ref == null) return; try { IType type= ref.resolveType(fScope); if (type == null) { String title= JavaUIMessages.getString("TypeSelectionDialog.errorTitle"); String message= JavaUIMessages.getString("TypeSelectionDialog.errorMessage"); MessageDialog.openError(getShell(), title, message); setResult(null); } else { List result= new ArrayList(1); result.add(type); setResult(result); } } catch (JavaModelException e) { String title= JavaUIMessages.getString("TypeSelectionDialog.errorTitle"); String message= JavaUIMessages.getString("TypeSelectionDialog.errorMessage"); MessageDialog.openError(getShell(), title, message); setResult(null); } } }
6,682
Bug 6682 Search in Hierarchy does not find Declarations in supers
20011206 - (happened to be on Windows2000) - Open an editor on a class that is in a deep hierarchy (I was in List in the SWT Widget hierarchy) - In the Outline view, select a method that has a declaration in several classes in the hierarchy (I selected createScrollBar(int) - this method is defined in Scrollable and redefined in List) - Context menu -> Declarations -> Hierarchy - It only found the method that was defined in List, and it missed the one that is defined in Scrollable (super of List) I notice that if you select the method (createScrollBar(int))in the superclass (Scrollable) and search for declarations in the hierarchy, it will find all of the methods. So I suspect that the search algorithm is only looking "down" for declarations, when it needs to look "up" as well.
resolved fixed
cda0387
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T13:43:51Z
2001-12-07T18:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindDeclarationsInHierarchyAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.jdt.core.IField; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.internal.ui.JavaPlugin; public class FindDeclarationsInHierarchyAction extends FindDeclarationsAction {
6,682
Bug 6682 Search in Hierarchy does not find Declarations in supers
20011206 - (happened to be on Windows2000) - Open an editor on a class that is in a deep hierarchy (I was in List in the SWT Widget hierarchy) - In the Outline view, select a method that has a declaration in several classes in the hierarchy (I selected createScrollBar(int) - this method is defined in Scrollable and redefined in List) - Context menu -> Declarations -> Hierarchy - It only found the method that was defined in List, and it missed the one that is defined in Scrollable (super of List) I notice that if you select the method (createScrollBar(int))in the superclass (Scrollable) and search for declarations in the hierarchy, it will find all of the methods. So I suspect that the search algorithm is only looking "down" for declarations, when it needs to look "up" as well.
resolved fixed
cda0387
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T13:43:51Z
2001-12-07T18:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindDeclarationsInHierarchyAction.java
public FindDeclarationsInHierarchyAction() { super(SearchMessages.getString("Search.FindHierarchyDeclarationsAction.label"), new Class[] {IField.class, IMethod.class} ); setToolTipText(SearchMessages.getString("Search.FindHierarchyDeclarationsAction.tooltip")); } protected JavaSearchOperation makeOperation(IJavaElement element) throws JavaModelException { IType type= getType(element); return new JavaSearchOperation(JavaPlugin.getWorkspace(), element, getLimitTo(), getScope(type), getScopeDescription(type), getCollector()); }; protected IJavaSearchScope getScope(IType type) throws JavaModelException { if (type != null) return SearchEngine.createHierarchyScope(type); else return super.getScope(type); } protected String getScopeDescription(IType type) { String typeName= ""; if (type != null) typeName= type.getElementName(); return SearchMessages.getFormattedString("HierarchyScope", new String[] {typeName}); } }
6,935
Bug 6935 CodeCompletion: Fill arguments feature bugs (Int1211)
null
resolved fixed
6261ef6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T16:57:38Z
2001-12-14T14:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ExperimentalResultCollector.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.jface.text.ITextViewer; /** * Bin to collect the proposal of the infrastructure on code assist in a java text. */ public class ExperimentalResultCollector extends ResultCollector { private ITextViewer fViewer; protected JavaCompletionProposal createMethodCompletion(char[] declaringTypeName, char[] name, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypeName, char[] completionName, int modifiers, int start, int end) { JavaCompletionProposal original= super.createMethodCompletion(declaringTypeName, name, parameterTypeNames, parameterNames, returnTypeName, completionName, modifiers, start, end); if (completionName.length == 0) return original;
6,935
Bug 6935 CodeCompletion: Fill arguments feature bugs (Int1211)
null
resolved fixed
6261ef6
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T16:57:38Z
2001-12-14T14:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ExperimentalResultCollector.java
int count= parameterNames.length; int[] offsets= new int[count]; int[] lengths= new int[count]; StringBuffer buffer= new StringBuffer(); buffer.append(name); buffer.append('('); for (int i= 0; i != count; i++) { if (i != 0) buffer.append(", "); offsets[i]= buffer.length(); buffer.append(parameterNames[i]); lengths[i]= buffer.length() - offsets[i]; } buffer.append(')'); if (new String(returnTypeName).equals("void")) buffer.append(';'); return new ExperimentalProposal(buffer.toString(), start, end - start, original.getImage(), original.getDisplayString(), offsets, lengths, fViewer); } /** * Sets the viewer. * @param viewer The viewer to set */ public void setViewer(ITextViewer viewer) { fViewer= viewer; } }
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
package org.eclipse.jdt.internal.ui.actions; import java.util.ArrayList; import java.util.HashSet; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.Viewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.corext.codemanipulation.IOverrideMethodQuery; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.dialogs.CheckedTreeSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.ISelectionValidator; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; public class OverrideMethodQuery implements IOverrideMethodQuery { private static class OverrideMethodContentProvider implements ITreeContentProvider {
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
private Object[] fTypes; private IMethod[] fMethods; private final Object[] fEmpty= new Object[0]; /** * Constructor for OverrideMethodContentProvider. */ public OverrideMethodContentProvider(IMethod[] methods, Object[] types) { fMethods= methods; fTypes= types; } /* * @see ITreeContentProvider#getChildren(Object) */ public Object[] getChildren(Object parentElement) { if (parentElement instanceof IType) { ArrayList result= new ArrayList(fMethods.length); for (int i= 0; i < fMethods.length; i++) { if (fMethods[i].getDeclaringType().equals(parentElement)) { result.add(fMethods[i]); } } return result.toArray(); } return fEmpty; } /* * @see ITreeContentProvider#getParent(Object) */ public Object getParent(Object element) {
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
if (element instanceof IMethod) { return ((IMethod)element).getDeclaringType(); } return null; } /* * @see ITreeContentProvider#hasChildren(Object) */ public boolean hasChildren(Object element) { return getChildren(element).length > 0; } /* * @see IStructuredContentProvider#getElements(Object) */ public Object[] getElements(Object inputElement) { return fTypes; } /* * @see IContentProvider#dispose() */ public void dispose() { } /* * @see IContentProvider#inputChanged(Viewer, Object, Object) */ public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } } private static class OverrideMethodSorter extends ViewerSorter {
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
private IType[] fAllTypes; public OverrideMethodSorter(ITypeHierarchy typeHierarchy) { IType curr= typeHierarchy.getType(); IType[] superTypes= typeHierarchy.getAllSupertypes(curr); fAllTypes= new IType[superTypes.length + 1]; fAllTypes[0]= curr; System.arraycopy(superTypes, 0, fAllTypes, 1, superTypes.length); } /* * @see ViewerSorter#compare(Viewer, Object, Object) */ public int compare(Viewer viewer, Object e1, Object e2) { if (e1 instanceof IType && e2 instanceof IType) { if (e1.equals(e2)) { return 0; } for (int i= 0; i < fAllTypes.length; i++) { IType curr= fAllTypes[i]; if (curr.equals(e1)) { return -1; } if (curr.equals(e2)) {
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
return 1; } } return 0; } else { return super.compare(viewer, e1, e2); } } } private class OverrideMethodValidator implements ISelectionValidator { /* * @see ISelectionValidator#validate(Object[]) */ public IStatus validate(Object[] selection) { int count= 0; for (int i= 0; i < selection.length; i++) { if (selection[i] instanceof IMethod) { count++; } } if (count == 0 && !fEmptySelectionAllowed) { return new StatusInfo(IStatus.ERROR, ""); } String message; if (count == 1) { message= JavaUIMessages.getFormattedString("OverrideMethodQuery.selectioninfo.one", String.valueOf(count)); } else { message= JavaUIMessages.getFormattedString("OverrideMethodQuery.selectioninfo.more", String.valueOf(count));
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
} return new StatusInfo(IStatus.INFO, message); } } private boolean fEmptySelectionAllowed; private Shell fShell; public OverrideMethodQuery(Shell shell, boolean emptySelectionAllowed) { fShell= shell; fEmptySelectionAllowed= emptySelectionAllowed; } /* * @see IOverrideMethodQuery#select(IMethod[], IMethod[], ITypeHierarchy) */ public IMethod[] select(IMethod[] methods, IMethod[] defaultSelected, ITypeHierarchy typeHierarchy) { HashSet types= new HashSet(methods.length); for (int i= 0; i < methods.length; i++) { types.add(methods[i].getDeclaringType()); } Object[] typesArrays= types.toArray(); ViewerSorter sorter= new OverrideMethodSorter(typeHierarchy); sorter.sort(null, typesArrays); HashSet expanded= new HashSet(defaultSelected.length); for (int i= 0; i < defaultSelected.length; i++) { expanded.add(defaultSelected[i].getDeclaringType()); } if (expanded.isEmpty() && typesArrays.length > 0) { expanded.add(typesArrays[0]);
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/actions/OverrideMethodQuery.java
} ILabelProvider lprovider= new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT); ITreeContentProvider cprovider= new OverrideMethodContentProvider(methods, typesArrays); CheckedTreeSelectionDialog dialog= new CheckedTreeSelectionDialog(fShell, lprovider, cprovider); dialog.setValidator(new OverrideMethodValidator()); dialog.setTitle(JavaUIMessages.getString("OverrideMethodQuery.dialog.title")); dialog.setMessage(JavaUIMessages.getString("OverrideMethodQuery.dialog.description")); dialog.setInitialSelections(defaultSelected); dialog.setExpandedElements(expanded.toArray()); dialog.setContainerMode(true); dialog.setSorter(sorter); dialog.setSize(60, 25); dialog.setInput(this); if (dialog.open() == dialog.OK) { Object[] checkedElements= dialog.getResult(); ArrayList result= new ArrayList(checkedElements.length); for (int i= 0; i < checkedElements.length; i++) { Object curr= checkedElements[i]; if (curr instanceof IMethod) { result.add(curr); } } return (IMethod[]) result.toArray(new IMethod[result.size()]); } return null; } }
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.util.ArrayList;
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
import java.util.Arrays; import java.util.List; import org.eclipse.core.runtime.IStatus; import org.eclipse.swt.SWT; import org.eclipse.swt.custom.BusyIndicator; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Tree; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.viewers.CheckStateChangedEvent; import org.eclipse.jface.viewers.CheckboxTreeViewer; import org.eclipse.jface.viewers.ICheckStateListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.viewsupport.ContainerCheckedTreeViewer; /** * A class to select elements out of a tree structure. */ public class CheckedTreeSelectionDialog extends SelectionStatusDialog {
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
private CheckboxTreeViewer fViewer; private ILabelProvider fLabelProvider; private ITreeContentProvider fContentProvider; private ISelectionValidator fValidator= null; private ViewerSorter fSorter; private String fEmptyListMessage= JavaUIMessages.getString("ElementTreeSelectionDialog.nothing_available"); private IStatus fCurrStatus= new StatusInfo(); private List fFilters; private Object fInput; private boolean fIsEmpty; private int fWidth= 40; private int fHeight= 18; private boolean fContainerMode; private Object[] fExpandedElements; /** * Constructs an instance of <code>ElementTreeSelectionDialog</code>. * @param labelProvider the label provider to render the entries * @param contentProvider the content provider to evaluate the tree structure */ public CheckedTreeSelectionDialog(Shell parent, ILabelProvider labelProvider, ITreeContentProvider contentProvider) { super(parent);
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
fLabelProvider= labelProvider; fContentProvider= contentProvider; setResult(new ArrayList(0)); setStatusLineAboveButtons(true); fContainerMode= false; fExpandedElements= null; } /** * If set, the checked /gray state of containers (inner nodes) is derived from the checked state of its * leaf nodes. * @param containerMode The containerMode to set */ public void setContainerMode(boolean containerMode) { fContainerMode= containerMode; } /** * Sets the initial selection. * Convenience method. * @param selection the initial selection. */ public void setInitialSelection(Object selection) { setInitialSelections(new Object[] {selection}); } /** * Sets the message to be displayed if the list is empty. * @param message the message to be displayed. */ public void setEmptyListMessage(String message) {
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
fEmptyListMessage= message; } /** * Sets the sorter used by the tree viewer. */ public void setSorter(ViewerSorter sorter) { fSorter= sorter; } /** * Adds a filter to the tree viewer. * @param filter a filter. */ public void addFilter(ViewerFilter filter) { if (fFilters == null) fFilters= new ArrayList(4); fFilters.add(filter); } /** * Sets an optional validator to check if the selection is valid. * The validator is invoked whenever the selection changes. * @param validator the validator to validate the selection. */ public void setValidator(ISelectionValidator validator) { fValidator= validator; }
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
/** * Sets the tree input. * @param input the tree input. */ public void setInput(Object input) { fInput= input; } /** * Expands the tree */ public void setExpandedElements(Object[] elements) { fExpandedElements= elements; } /** * Sets the size of the tree in unit of characters. * @param width the width of the tree. * @param height the height of the tree. */ public void setSize(int width, int height) { fWidth= width; fHeight= height; } protected void updateOKStatus() { if (!fIsEmpty) { if (fValidator != null) { fCurrStatus= fValidator.validate(fViewer.getCheckedElements()); updateStatus(fCurrStatus); } else if (!fCurrStatus.isOK()) { fCurrStatus= new StatusInfo();
8,150
Bug 8150 Override methods dialog is too long
The Override methods dialog takes up the entire depth of the screen in Windows Standard Extra large. This is acceptable but if it doesn't need to be this large it should be reduced in size. STEPS 1) Create a class that implements java.sql.Statement 2) Select Override Methods from the Outline View 3) Very long dialog opens
verified fixed
e762ef9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-08T17:25:33Z
2002-01-23T15:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/CheckedTreeSelectionDialog.java
} } else { fCurrStatus= new StatusInfo(IStatus.ERROR, fEmptyListMessage); } updateStatus(fCurrStatus); } /* * @see Window#open() */ public int open() { fIsEmpty= evaluateIfTreeEmpty(fInput); BusyIndicator.showWhile(null, new Runnable() { public void run() { access$superOpen(); } }); return getReturnCode(); } private void access$superOpen() { super.open(); } /** * Handles cancel button pressed event. */ protected void cancelPressed() { setResult(null); super.cancelPressed();