id
int64
1
6.5k
bug_id
int64
2.03k
426k
summary
stringlengths
9
251
description
stringlengths
1
32.8k
report_time
stringlengths
19
19
report_timestamp
int64
1B
1.39B
status
stringclasses
6 values
commit
stringlengths
7
9
commit_timestamp
int64
1B
1.39B
files
stringlengths
25
32.8k
project_name
stringclasses
6 values
110
55,125
Bug 55125 Tomcat does not shut down if LifecycleListener throws an exception
null
2013-06-21 11:23:54
1,371,830,000
resolved fixed
3a36a8f
1,372,020,000
java/org/apache/catalina/core/StandardService.java java/org/apache/catalina/startup/Catalina.java
Tomcat
111
55,127
Bug 55127 Encoders init and destroy methods are never called
null
2013-06-22 06:04:48
1,371,900,000
resolved fixed
93bcdde
1,371,910,000
java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java java/org/apache/tomcat/websocket/WsRemoteEndpointImplClient.java java/org/apache/tomcat/websocket/WsSession.java java/org/apache/tomcat/websocket/WsWebSocketContainer.java java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
Tomcat
112
55,126
Bug 55126 IAE is thrown during deployment of ServerEndPoint having multiple text decoders
null
2013-06-21 13:16:22
1,371,840,000
resolved fixed
366ddff
1,371,850,000
java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
Tomcat
113
55,101
Bug 55101 BasicAuthenticator parser and associated unit tests
null
2013-06-15 15:01:40
1,371,320,000
resolved fixed
c4a50f5
1,371,760,000
java/org/apache/catalina/authenticator/BasicAuthenticator.java test/org/apache/catalina/authenticator/TestBasicAuthParser.java test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java
Tomcat
114
54,745
Bug 54745 Tomcat JarScanning does not work when Tomcat started with Java Web Start
null
2013-03-22 23:07:06
1,364,010,000
resolved fixed
c7c30b6
1,371,740,000
java/org/apache/tomcat/util/scan/StandardJarScanner.java
Tomcat
115
53,987
Bug 53987 Log uncovered HTTP methods in combined security constraints
It is usually an error (and a security hole) if security constraints are defined for some but not all HTTP methods for a given URL. If such a situation is detected on web application start, log it.
2012-10-09 19:02:28
1,349,820,000
resolved fixed
f78c1a4
1,371,680,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
116
55,073
Bug 55073 wasted work in ValidateVisitor.isExpression()
null
2013-06-07 14:23:24
1,370,630,000
resolved fixed
3e2ceee
1,371,540,000
java/org/apache/jasper/compiler/Validator.java
Tomcat
117
55,108
Bug 55108 Wasted work in "AbstractReplicatedMap.excludeFromSet"
null
2013-06-17 18:12:00
1,371,510,000
resolved fixed
4979721
1,371,540,000
java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Tomcat
118
55,109
Bug 55109 Wasted work in "WebdavServlet.isLocked"
null
2013-06-17 18:24:46
1,371,510,000
resolved fixed
82bccd2
1,371,540,000
java/org/apache/catalina/servlets/WebdavServlet.java
Tomcat
119
55,110
Bug 55110 Wasted work in "TestNonLoginAndBasicAuthenticator.doTestBasic"
null
2013-06-17 18:37:18
1,371,510,000
resolved fixed
c48a2ed
1,371,540,000
test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java
Tomcat
120
55,052
Bug 55052 [JULI] Make ClassLoaderLogManager.getProperty() to try unprefixed property if prefixed one does not exist
null
2013-06-03 13:08:20
1,370,280,000
resolved fixed
99562d3
1,370,350,000
java/org/apache/juli/ClassLoaderLogManager.java
Tomcat
121
55,046
Bug 55046 CORS Filter
null
2013-06-02 00:48:49
1,370,150,000
resolved fixed
72edec7
1,370,340,000
java/org/apache/catalina/filters/CorsFilter.java test/org/apache/catalina/filters/TestCorsFilter.java test/org/apache/catalina/filters/TesterFilterChain.java test/org/apache/catalina/filters/TesterFilterConfigs.java test/org/apache/catalina/filters/TesterHttpServletRequest.java test/org/apache/catalina/filters/TesterHttpServletResponse.java test/org/apache/catalina/filters/TesterServletContext.java
Tomcat
122
55,035
Bug 55035 Deploy ROOT webapp with version through text manager using Ant
Currently Ant "deploy" task does not support separate parameter "version" and, thanks to URLEncoder, there is no workaround for that. But for apps with not empty context it's possible to define version using ##, like setting path to "/someContext#someVersion". For apps with empty context we receive error: Case #1: <deploy url="{tomcat.manager}/text" username="${username}", password="${password}" path="/ROOT##12345" war="${pathtowar}" /> Result: Failed to deploy application at context path /ROOT##12345 Case #1: <deploy url="{tomcat.manager}/text" username="${username}", password="${password}" path="/##12345" war="${pathtowar}" /> Result: Failed to deploy application at context path /##12345
2013-05-31 16:05:20
1,370,030,000
resolved fixed
712a351
1,370,290,000
java/org/apache/catalina/ant/DeployTask.java
Tomcat
123
54,999
Bug 54999 JSESSIONIDSSO not re-created upon re-authentication on the same request - logout() and login(username,password)
In testing I found that the JSESSIONIDSSO was not re-created upon re-authentication via logout() and login(username,password) in the same request. The problem stemmed from the REQ_SSOID_NOTE that was was not reset upon request.logout(), whereas the documentation indicates that a logout() from any web-app should logout() from all web-apps. When the REQ_SSOID_NOTE is not removed upon logout(), a subsequent login(username,password) on the same request will re-create a JSESSIONID for the current web-app but fails to re-create a JSESSIONIDSSO since the REQ_SSO_ID_NOTE still lingers on the request. AuthenticatorBase.java adjustment for logout(request) that removes the REQ_SSOID_NOTE so that a subsequent login(username,password) will work on the same request: @Override public void logout(Request request) throws ServletException { register(request, request.getResponse(), null, null, null, null); request.removeNote(Constants.REQ_SSOID_NOTE); } I'll upload a diff-patch against the trunk and for 7.0.40.
2013-05-21 19:50:48
1,369,180,000
resolved fixed
6d789fe
1,369,920,000
java/org/apache/catalina/authenticator/AuthenticatorBase.java
Tomcat
124
54,997
Bug 54997 SSL Handshake implementation in AsycnChannelWrapperSecure does not handle SSLEngineResult.Status.BUFFER_UNDERFLOW and SSLEngineResult.Status.BUFFER_OVERFLOW states
null
2013-05-21 07:22:32
1,369,140,000
resolved fixed
6c6b25c
1,369,820,000
java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java
Tomcat
125
54,971
Bug 54971 javax.servlet.http.Part.write(String fileName) is not properly implemented
1. fileName parameter / relative vs absolute filaName parameter specification in <1><JSR-000315 Java Servlet 3.0 Final Release javadocs> is different from the <2><javax API tomcat refers to>. <1> <JSR-000315 Java Servlet 3.0 Final Release javadocs> Parameters:fileName - the name of the file to which the stream will be written. The file is created relative to the location as specified in the MultipartConfig <2> javax. API tomcat refers to * @param fileName The location into which the uploaded part should be * stored. Relative locations are relative to {@link * javax.servlet.MultipartConfigElement#getLocation()} Tomcat is implemented as specified in <2> so that it can process "absolute path", but it should only accept "relative path" as specified in <1> <JSR-000315 Java Servlet 3.0 Final Release javadocs> 2. If MultiPartConfig.location is not set, write( String relative path ) throws FileNotFound Exception. A default location needs to be set in order to avoid such exception. example) os: windows8 part.write("/test"); java.io.IOException: java.io.FileNotFoundException: \test (Access is denied) at org.apache.catalina.core.ApplicationPart.write(ApplicationPart.java:123) at servlet.multipart.MultipleUploadServlet.doPost(MultipleUploadServlet.java:76) at javax.servlet.http.HttpServlet.service(HttpServlet.java:647) at javax.servlet.http.HttpServlet.service(HttpServlet.java:728) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:947) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1009) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918) at java.lang.Thread.run(Thread.java:662)
2013-05-15 02:16:03
1,368,600,000
resolved fixed
cccd0ac
1,369,750,000
java/org/apache/catalina/connector/Request.java java/org/apache/catalina/core/ApplicationPart.java
Tomcat
126
54,964
Bug 54964 Class loading issue of "TagPlugin" in TagPluginManager
null
2013-05-14 06:57:34
1,368,530,000
resolved fixed
65ab66e
1,369,740,000
java/org/apache/jasper/compiler/TagPluginManager.java
Tomcat
127
54,963
Bug 54963 Concurrent issue of Spdy/NetSupportSocket
null
2013-05-14 06:50:20
1,368,530,000
resolved fixed
6272fca
1,369,740,000
java/org/apache/tomcat/spdy/NetSupportSocket.java
Tomcat
128
54,961
Bug 54961 Make "compress" configurable in SpdyProxyProtocol
null
2013-05-14 02:56:42
1,368,510,000
resolved fixed
c25112b
1,369,740,000
java/org/apache/coyote/spdy/SpdyProxyProtocol.java
Tomcat
129
54,947
Bug 54947 Http11NioProtocol generates HTTP 505 responses on valid requests if request is split across multiple packets
If an HTTP request is broken up across multiple packets *and* the first packet contains a GET request up to "\r" AND the "\n" terminating the first line of the request is included in the next packet Tomcat incorrectly throws an HTTP "505 Version Not Supported" response. This is with the Http11NioProtocol connector only - the default HTTP/1.1 connector does not exhibit this problem. An example request: Packet 1: GET / HTTP/1.1\r Packet 2: \nHost: localhost\r\n Packet 3: Connection: Close\r\n\r\n Response: HTTP/1.1 505 HTTP Version Not Supported Server: Apache-Coyote/1.1 Date: Thu, 09 May 2013 20:23:58 GMT Connection: close The following Python program reproduces the problem for me in both Tomcat 6.0.37 and Tomcat 7.0.39: """ #!/usr/bin/python import socket import time s = socket.socket() s.connect(("localhost",8080)) s.sendall("GET / HTTP/1.1\r") time.sleep(1.5) # make sure the above goes out in its own packet s.sendall("\nHost: localhost\r\n") s.sendall("Connection: close\r\n\r\n") print s.makefile().read() """ Moving the "\n" to from the second sendall to the end of the first sendall causes Tomcat to respond correctly.
2013-05-09 20:27:01
1,368,150,000
resolved fixed
f763975
1,369,740,000
java/org/apache/coyote/http11/InternalNioInputBuffer.java test/org/apache/catalina/startup/SimpleHttpClient.java test/org/apache/coyote/http11/TestInternalInputBuffer.java
Tomcat
130
54,944
Bug 54944 Enhancements to TestFormAuthenticator
null
2013-05-09 14:33:23
1,368,120,000
resolved fixed
0de078e
1,369,740,000
test/org/apache/catalina/authenticator/TestFormAuthenticator.java
Tomcat
131
55,019
Bug 55019 <jsp:include page="blabla" flush="true"/> failed to compile under security manager
null
2013-05-27 12:55:28
1,369,670,000
resolved fixed
76a7098
1,369,670,000
java/org/apache/coyote/http11/AbstractOutputBuffer.java
Tomcat
132
54,984
Bug 54984 multipart/form-data is not always read with correct encoding
The bug occurs when form data is posted as multipart/form-data and using Servlet 3 API to get posted files. In a servlet, if we set the encoding: request.setCharacterEncoding("UTF-8"); Then invoke: request.getParts() And then invoke: String text = request.getParameter("sometextfield"); UTF-8 characters in the text have been garbled. Order of method calls are significant, if a getParameter is called before getParts, the correct encoding will be used. However, the order which you invoke the methods should not matter.
2013-05-16 11:15:20
1,368,720,000
resolved fixed
7558546
1,369,420,000
java/org/apache/catalina/connector/Request.java test/org/apache/catalina/connector/TestRequest.java
Tomcat
133
54,928
Bug 54928 IllegalStateException: Calling [asyncError()] is not valid for a request with Async state [COMPLETING]
In an async scenario (request.startAsync), when the client goes away, trying to write to the response raises an IOException. If I then call asyncContext.complete() in order to finalize and clean up the request, soon after the following exception occurs: java.lang.IllegalStateException: Calling [asyncError()] is not valid for a request with Async state [COMPLETING] at org.apache.coyote.AsyncStateMachine.asyncError(AsyncStateMachine.java:304) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:793) at org.apache.coyote.Request.action(Request.java:373) at org.apache.catalina.core.AsyncContextImpl.setErrorState(AsyncContextImpl.java:441) at org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:312) at org.apache.coyote.http11.AbstractHttp11Processor.asyncDispatch(AbstractHttp11Processor.java:1509) at org.apache.coyote.http11.Http11NioProcessor.asyncDispatch(Http11NioProcessor.java:221) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:619) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1581) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1540) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) It looks like an attempt to maybe to send an error event to AsyncListener's but asyncContext.complete has already been called. Is calling asyncContext.complete() a reasonable way to handle an IOException from the response in order to finalize the request and release any resorces associated with it?
2013-05-04 12:41:30
1,367,690,000
resolved fixed
3960b22
1,369,400,000
test/org/apache/catalina/connector/TestCoyoteAdapter.java
Tomcat
134
54,955
Bug 54955 Mapping to application context root returns 404 after reload
null
2013-05-13 03:50:12
1,368,430,000
resolved fixed
cdbf6b0
1,369,080,000
java/org/apache/catalina/mapper/Mapper.java
Tomcat
135
54,981
Bug 54981 ServletContext.getJspConfigDescriptor() should return null when there is no jsp configuration
According to Servlet 3.0 javadoc ServletContext.getJspConfigDescriptor() must return NULL when there is no jsp configuration: " Returns: the <jsp-config> related configuration that was aggregated from the web.xml and web-fragment.xml descriptor files of the web application represented by this ServletContext, or null if no such configuration exists "
2013-05-16 08:02:36
1,368,710,000
resolved fixed
aabef09
1,368,690,000
java/org/apache/catalina/core/ApplicationContext.java test/org/apache/catalina/core/TestApplicationContext.java
Tomcat
136
54,974
Bug 54974 SessionCookieConfig.setXXX methods must throw IllegalStateException when invoked after initialization phase
According to Servlet 3.0 javadoc javax.servlet.SessionCookieConfig setter methods must throw IllegalStateException when invoked after initialization phase setComment(String) setDomain(String) setHttpOnly(boolean) setMaxAge(int) setName(String) setPath(String) setSecure(boolean) " Throws: java.lang.IllegalStateException - if the ServletContext from which this SessionCookieConfig was acquired has already been initialized "
2013-05-15 08:23:39
1,368,620,000
resolved fixed
41462ca
1,368,610,000
java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/ApplicationSessionCookieConfig.java test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java
Tomcat
137
54,703
Bug 54703 Nullpointer exception in HttpParser.parseMediaType
input for parseMediaType() is ---------- multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="----=_Part_121_929034657.1363355797756" ---------- exception trace java.lang.NullPointerException at org.apache.tomcat.util.http.parser.HttpParser.parseMediaType(HttpParser.java:215) at org.apache.tomcat.util.http.parser.MediaTypeCache.parse(MediaTypeCache.java:54) at org.apache.catalina.connector.Response.setContentType(Response.java:806) at org.apache.catalina.connector.Response.checkSpecialHeader(Response.java:1119) at org.apache.catalina.connector.Response.setHeader(Response.java:1446) at org.apache.catalina.connector.ResponseFacade.setHeader(ResponseFacade.java:535)
2013-03-15 14:09:19
1,363,370,000
resolved fixed
7aeab0e
1,367,940,000
java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestMediaType.java
Tomcat
138
54,906
Bug 54906 WebappClassLoader.loadedByThisOrChild can throw ConcurrentModificationException
null
2013-04-29 19:25:04
1,367,280,000
resolved fixed
c06707c
1,367,700,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
139
54,926
Bug 54926 WsFilter performs handshake validation even if it doesn't have a mapped endpoint
WsFilter performs several validations on WebSocket requests before checking if there is a registered Endpoint. I think the check for registered Endponts (and delegation to the next Filter) should take place first and the filter should do no further processing if there is mapped Endpoint for that URL. For example a SockJS protocol test send a POST request with a connection and upgrade headers but no ws version header and expects back a 405 (invalid HTTP method) where WsFilter sends 426 even though it has no Endpoint mapped at that URL.
2013-05-04 01:23:20
1,367,650,000
resolved fixed
2df191f
1,367,660,000
java/org/apache/tomcat/websocket/server/WsFilter.java
Tomcat
140
54,888
Bug 54888 TagPlugin "ForEach" doesn't support CSV items
null
2013-04-24 16:49:45
1,366,840,000
resolved fixed
d440ae2
1,367,240,000
java/org/apache/jasper/tagplugins/jstl/core/ForEach.java test/org/apache/jasper/tagplugins/jstl/core/TestForEach.java
Tomcat
141
54,801
Bug 54801 EL-like expressions in jsp:scriptlet break compilation of JSP XML documents
null
2013-04-04 22:24:00
1,365,130,000
resolved fixed
1631be1
1,366,900,000
java/org/apache/jasper/compiler/JspDocumentParser.java test/org/apache/jasper/compiler/TestJspDocumentParser.java
Tomcat
142
54,178
Bug 54178 [CVE-2013-2071] runtime exception in onComplete of AsyncListener, will make org.apache.catalina.connector.Request not recycled (orginally reported MESSAGE POST to tomcat, but it called doGet)
one HTTP request use POST method, but in tomcat it calls doGet() what is really strage. as I only tested in 7.0.23, and 7.0.32. in 7.0.32, 7.0.32 is more reproduceable than 7.0.23. I know it must be a very strange issue, as tomcat has so many release. I can't believe it if I didn't see it with my own eyes. so I attache the image.
2012-11-21 08:22:00
1,353,500,000
resolved fixed
4171baf
1,366,800,000
java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java
Tomcat
143
54,708
Bug 54708 Use base file name ("ROOT") as the work directory for the default webapp instead of "_"
null
2013-03-15 22:22:13
1,363,400,000
resolved fixed
59a0676
1,366,750,000
java/org/apache/catalina/core/StandardContext.java
Tomcat
144
54,781
Bug 54781 NPE in WsServerContainer if there is no matching path
null
2013-04-01 19:32:18
1,364,860,000
resolved fixed
67ed3e7
1,366,750,000
java/org/apache/tomcat/websocket/server/WsFilter.java java/org/apache/tomcat/websocket/server/WsServerContainer.java
Tomcat
145
54,792
Bug 54792 IllegalStateException with chat sample
This looks related to 54659 and 54724 but possibly a new issue. To reproduce, open the chat sample page, send a message or two, and then close the browser tab. The following exception appears in the log and it doesn't seem to step from anything done in the application: java.lang.IllegalStateException: The WebSocket session has been closed and no method (apart from close()) may be called on a closed session at org.apache.tomcat.websocket.WsSession.checkState(WsSession.java:516) at org.apache.tomcat.websocket.WsSession.getMessageHandlers(WsSession.java:191) at org.apache.tomcat.websocket.pojo.PojoEndpointBase.onClose(PojoEndpointBase.java:113) at org.apache.tomcat.websocket.WsSession.fireEndpointOnClose(WsSession.java:392) at org.apache.tomcat.websocket.WsSession.onClose(WsSession.java:370) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.close(WsHttpUpgradeHandler.java:166) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.access$200(WsHttpUpgradeHandler.java:44) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler$WsReadListener.onDataAvailable(WsHttpUpgradeHandler.java:192) at org.apache.coyote.http11.upgrade.AbstractServletInputStream.onDataAvailable(AbstractServletInputStream.java:169) at org.apache.coyote.http11.upgrade.AbstractProcessor.upgradeDispatch(AbstractProcessor.java:94) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:618) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1581) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1537) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722)
2013-04-02 20:54:28
1,364,950,000
resolved fixed
e26d61d
1,366,730,000
webapps/examples/WEB-INF/classes/websocket/chat/ChatAnnotation.java
Tomcat
146
54,800
Bug 54800 Possible thread/memory leak with use of WebSocketContainer
Whenever WebSocketContainer is used to connect to a server endpoint, the following message appears when Tomcat shuts down: SEVERE: The web application [/websocket-test] appears to have started a thread named [Thread-4] but has failed to stop it. This is very likely to create a memory leak. The message is repeated for 6 different threads. I don't have proof this is caused by the use of WebSocketContainer but the messages don't appear when it isn't used. The Endpoint used to connect is very simple. It sends a message when the session is opened to the EchoEndpoint on the server side, and prints the response and closes when the message is echoed back.
2013-04-04 21:47:00
1,365,130,000
resolved fixed
d2630df
1,366,730,000
java/org/apache/tomcat/websocket/WsWebSocketContainer.java
Tomcat
147
54,807
Bug 54807 [jsr356] java.lang.ClassCastException: org.apache.tomcat.websocket.server.WsServerContainer$TemplatePathMatch
Caused by: java.lang.ClassCastException: org.apache.tomcat.websocket.server.WsServerContainer$TemplatePathMatch cannot be cast to java.lang.Comparable at java.util.TreeMap.compare(TreeMap.java:1188) at java.util.TreeMap.put(TreeMap.java:531) at java.util.TreeSet.add(TreeSet.java:255) at org.apache.tomcat.websocket.server.WsServerContainer.addEndpoint(WsServerContainer.java:144) at org.apache.tomcat.websocket.server.WsSci.onStartup(WsSci.java:118) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5195) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) ... 11 more Reproducible when a path is defined as {path}. For example: @Override public Set<ServerEndpointConfig> getEndpointConfigs(Set<Class<? extends Endpoint>> endpointClasses) { logger.debug("{} detected", JSR356ServerEndpointConfig.class.getName()); return new HashSet<ServerEndpointConfig>() {{ add(ServerEndpointConfig.Builder.create(JSR356Endpoint.class, "/{path}").configurator(c).build()); }}; }
2013-04-05 15:38:39
1,365,190,000
resolved fixed
0339fec
1,366,400,000
java/org/apache/tomcat/websocket/server/WsServerContainer.java test/org/apache/tomcat/websocket/server/TestWebSocketServerContainer.java
Tomcat
148
54,822
Bug 54822 URL with Query String can't work over SPDY
null
2013-04-10 07:13:22
1,365,590,000
resolved fixed
3da2133
1,366,380,000
java/org/apache/coyote/spdy/SpdyProcessor.java
Tomcat
149
54,851
Bug 54851 Folder without web-fragment.xml should not impact the status of distributable
null
2013-04-16 08:47:44
1,366,120,000
resolved fixed
e97e158
1,366,120,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
150
54,755
Bug 54755 Type-based Endpoint's cannot be deployed by instance
For type-based Endpoint's, WsServlet instantiates the Endpoint via reflection instead of using the Configurator as is done in PojoEndpointServer: sec.getConfigurator().getEndpointInstance(sec.getEndpointClass())
2013-03-26 14:52:29
1,364,320,000
resolved fixed
d025179
1,364,330,000
java/org/apache/tomcat/websocket/server/WsServlet.java
Tomcat
151
54,748
Bug 54748 IOException in echo WebSocket example
The IOException "New frame received after a close control frame" is raised after pressing Disconnect. The exception can be detected by adding an onError method to EchoEndpoint.
2013-03-25 09:23:09
1,364,220,000
resolved fixed
cf0c064
1,364,250,000
java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/server/WsFrameServer.java
Tomcat
152
54,732
Bug 54732 StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks
null
2013-03-20 16:09:31
1,363,810,000
resolved fixed
8cf47b4
1,363,960,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCounterInterceptor.java modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestStatementCache.java
Tomcat
153
54,599
Bug 54599 DataSource password is exposed to applications via toString method
On the server side, create a DataSource using "org.apache.tomcat.jdbc.pool.DataSourceFactory". Ex: <Resource auth="Container" description="" name="jdbc/testTomcatJdbc" factory="org.apache.tomcat.jdbc.pool.DataSourceFactory" type="javax.sql.DataSource" username="sa" password="super-secret" driverClassName="org.h2.Driver" url="jdbc:h2:mem:test" minIdle="1" initialSize="1" /> In a web application, create a JSP file, add the following: <%@ page import="javax.naming.*" session="false" %> <!DOCTYPE HTML> <html> <head> <title>Display Password!</title> </head> <body> <h1>toString for Tomcat JDBC</h1> <% dataSource = (javax.sql.DataSource) ctx.lookup("java:/comp/env/jdbc/testTomcatJdbc"); out.println("<p>" + dataSource.toString() + "</p>"); %> </body> </html> Access the JSP in your browser. The output from toString on the DataSource will display the password that was configured in the <Resource/> tag. Example Output: toString for Tomcat JDBC org.apache.tomcat.jdbc.pool.DataSource@75cae120{ConnectionPool[defaultAutoCommit=null; defaultReadOnly=null; defaultTransactionIsolation=-1; defaultCatalog=null; driverClassName=org.h2.Driver; maxActive=100; maxIdle=100; minIdle=1; initialSize=1; maxWait=30000; testOnBorrow=false; testOnReturn=false; timeBetweenEvictionRunsMillis=5000; numTestsPerEvictionRun=0; minEvictableIdleTimeMillis=60000; testWhileIdle=false; testOnConnect=false; password=super-secret; url=jdbc:h2:mem:test; username=sa; validationQuery=null; validatorClassName=null; validationInterval=30000; accessToUnderlyingConnectionAllowed=true; removeAbandoned=false; removeAbandonedTimeout=60; logAbandoned=false; connectionProperties=null; initSQL=null; jdbcInterceptors=null; jmxEnabled=true; fairQueue=true; useEquals=true; abandonWhenPercentageFull=0; maxAge=0; useLock=false; dataSource=null; dataSourceJNDI=null; suspectTimeout=0; alternateUsernameAllowed=false; commitOnReturn=false; rollbackOnReturn=false; useDisposableConnectionFacade=true; logValidationErrors=false; propagateInterruptState=false; }
2013-02-22 16:37:23
1,361,570,000
resolved fixed
8445d9a
1,363,940,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
Tomcat
154
54,724
Bug 54724 WsSession does not throw IllegalStateException if closed when methods on it are called
Spec JavaDoc says: "Once the session is closed, it is no longer valid for use by applications. Calling any of its methods once the session has been closed will result in an IllegalStateException being thrown. Developers should retrieve any information from the session during the Endpoint.onClose(Session, CloseReason) method." Of course, the rules of Closeable also apply here, and calling Session#close(...) more than once should have no effect subsequent times. There are actually three problems here: 1) None of the methods throw IllegalStateException if the session is closed. Instead, they return things (like the basic remote, for example), and some methods in the endpoint implementation will not notice concurrent exceptions from the socket and then block forever waiting four the Countdown to clear. 2) The Session#state is never actually changed to State.CLOSED unless Session#onClose is called. However, Session#onClose is never actually called that I can find (though I will look harder before I make changes). 3) Even in Session#onClose, the state is incorrectly changed to State.CLOSED BEFORE Endpoint#onClose is called, when it should be changed AFTER. I'm working on a patch for this.
2013-03-19 13:22:56
1,363,710,000
resolved fixed
12f89ff
1,363,720,000
java/org/apache/tomcat/websocket/WsSession.java test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java
Tomcat
155
54,721
Bug 54721 RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders
null
2013-03-18 22:01:43
1,363,660,000
resolved fixed
80ef59a
1,363,700,000
java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java
Tomcat
156
54,710
Bug 54710 Java WebSocket specification says @OnMessage methods can have InputStream/Reader parameters; @OnClose can have CloseReason parameters
null
2013-03-17 09:59:10
1,363,530,000
resolved fixed
06800eb
1,363,640,000
java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBinary.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialText.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBinary.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholePong.java java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeText.java java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
Tomcat
157
54,709
Bug 54709 Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https"
null
2013-03-17 08:54:31
1,363,520,000
resolved fixed
ad148dd
1,363,550,000
java/org/apache/tomcat/websocket/WsWebSocketContainer.java test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java
Tomcat
158
54,712
Bug 54712 Prefer Locale.ENGLISH over Locale.US for case conversion
null
2013-03-17 12:54:09
1,363,540,000
resolved fixed
dc16474
1,363,530,000
java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/buf/B2CConverter.java java/org/apache/tomcat/util/http/parser/HttpParser.java java/org/apache/tomcat/util/http/parser/MediaType.java modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java test/org/apache/catalina/startup/SimpleHttpClient.java
Tomcat
159
54,631
Bug 54631 @PathParam is not working with @OnMessage
I have defined server end-point as: @ServerEndpoint(value = "/ws/{mid}/{rid}/{uid}") When using @PathParam with @OnMessage, values are null. Other annotations like @OnOpen and @OnClose print values specified in URL. @OnMessage public void onTextMessage(@PathParam("mid") Long mid, @PathParam("rid") Integer rid, @PathParam("uid") Long uid, Session session, String message, boolean pair) { log.debug("[TEXT]" + " : " + mid + " : " + rid + " : " + uid + message + " : " + session.getRequestURI()); }
2013-03-04 05:03:35
1,362,390,000
resolved fixed
7fd7279
1,363,380,000
test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java
Tomcat
160
54,702
Bug 54702 File descriptor leak at web.xml loading
Hello I think I've found a file descriptor leak in file /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java (method getGlobalWebXmlSource). A stream is from file "web.xml" is not closed. private WebXml getDefaultWebXmlFragment() { ... 1284 InputSource globalWebXml = getGlobalWebXmlSource(); ... 1337 // Parse global web.xml if present 1338 if (globalWebXml == null) { 1339 // This is unusual enough to log 1340 log.info(sm.getString("contextConfig.defaultMissing")); 1341 } else { 1342 parseWebXml(globalWebXml, webXmlDefaultFragment, false); 1343 } Here is the full stack trace [java.io.FileInputStream.<init>(FileInputStream.java:109)] [org.apache.catalina.startup.ContextConfig.getWebXmlSource(ContextConfig.java:1837)] [org.apache.catalina.startup.ContextConfig.getGlobalWebXmlSource(ContextConfig.java:1744)] [org.apache.catalina.startup.ContextConfig.getDefaultWebXmlFragment(ContextConfig.java:1417)] [org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1253)] [org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:878)] [org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:369)] [org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)] [org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)] [org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5173)] [org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)] [org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)] [org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)] [org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)] [org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:977)] [org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:542)] [org.apache.catalina.startup.HostConfig.check(HostConfig.java:1462)] [sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)] [sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)] [sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)] [java.lang.reflect.Method.invoke(Method.java:597)] [org.apache.tomcat.util.modeler.BaseModelMBean.invoke(BaseModelMBean.java:301)] [com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:836)] [com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761)] [org.apache.catalina.manager.ManagerServlet.check(ManagerServlet.java:1445)] [org.apache.catalina.manager.HTMLManagerServlet.upload(HTMLManagerServlet.java:301)] [org.apache.catalina.manager.HTMLManagerServlet.doPost(HTMLManagerServlet.java:208)] [javax.servlet.http.HttpServlet.service(HttpServlet.java:647)] [javax.servlet.http.HttpServlet.service(HttpServlet.java:728)] [org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)] [org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)] [org.apache.catalina.filters.CsrfPreventionFilter.doFilter(CsrfPreventionFilter.java:213)] [org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)] [org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)] [org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)] [org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)] [org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)] [org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)] [org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)] [org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:581)] [org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)] [org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)] [org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:931)] [org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)] [org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)] [org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)] [org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)] [org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1822)] [java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)] [java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)] [java.lang.Thread.run(Thread.java:662)]
2013-03-15 08:53:36
1,363,350,000
resolved fixed
7c88af9
1,363,360,000
java/org/apache/catalina/startup/ContextConfig.java
Tomcat
161
54,658
Bug 54658 Implement Part#getSubmittedFileName from SERVLET_SPEC-57
null
2013-03-09 21:46:36
1,362,880,000
resolved fixed
ca205c1
1,363,290,000
java/javax/servlet/http/Part.java java/org/apache/catalina/connector/Request.java java/org/apache/catalina/core/ApplicationPart.java java/org/apache/catalina/manager/HTMLManagerServlet.java
Tomcat
162
54,660
Bug 54660 AccessLogValve fileDateFormat can not be changed through JMX
When an AccessLogValve is added to a catalina host with the JMX addVale() operation on the Host object name, the valve will start with the default fileDateFormat. Changing the attribute on the valve through it's JMX object name has no effect because the valve is already started. Executing a rotate() operation on the valve does also have no effect. Steps to Reproduce: - Start tomcat server - Add Host using JMX - Add valve to Host using JMX - Set valve attribute fileDateFormat to something else than yyyy-MM-dd, for example yy-MM Actual Results: The access log file format will include the default fileDateFormat of yyyy-MM-dd Expected Results: The access log file format with yy-MM, as from the example.
2013-03-10 07:09:11
1,362,910,000
resolved fixed
2a03ca6
1,363,280,000
java/org/apache/catalina/valves/AccessLogValve.java
Tomcat
163
54,690
Bug 54690 HTTPS BIO/NIO connector does not enable TLS 1.1 and TLS 1.2 by default
null
2013-03-13 17:07:20
1,363,210,000
closed fixed
fedf189
1,363,270,000
java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Tomcat
164
54,671
Bug 54671 Spec says ServerContainerProvider#getServerContainer() should be public, but implemented package-private in Tomcat 8.0
null
2013-03-11 22:31:14
1,363,060,000
resolved fixed
28c599f
1,363,040,000
java/javax/websocket/server/ServerContainerProvider.java
Tomcat
165
54,628
Bug 54628 there is something wrong when send binary data by websocket.
there is something wrong when send binary data by websocket. see org.apache.catalina.websocket.WsOutbound.doWriteBytes(ByteBuffer, boolean) I think // Write the content upgradeOutbound.write(buffer.array(), 0, buffer.limit()); upgradeOutbound.flush(); should change to : // Write the content upgradeOutbound.write(buffer.array(), buffer.arrayOffset(), buffer.limit()); upgradeOutbound.flush(); For example: byte[] bts = new byte[]{1,2,3,4,5} ByteBuffer bf = ByteBuffer.wrap(bts, 2, 2); out.writeBinaryMessage(bf); I mean write [3,4] to the client, but in fact [1,2,3,4] be sent;
2013-03-02 08:37:25
1,362,230,000
resolved fixed
e1d16fd
1,362,600,000
java/org/apache/catalina/websocket/WsOutbound.java
Tomcat
166
54,624
Bug 54624 Form authenticator hangs on re-authentication of POST request behind mod_proxy_ajp
Setup: Tomcat AJP connector behind mod_proxy_ajp, form-based authentication. When session expires and a POST request is submitted, Tomcat shows login form, user logs in, authenticator tries to restore the original POST request. Doing that, it tries to swallow the AJP message body before replacing the body of the request with the original POST request body. It tries to read the first 4 bytes of the AJP message (the message length) and blocks forever waiting for those 4 bytes.
2013-02-28 21:44:55
1,362,110,000
resolved fixed
c9e056c
1,362,600,000
java/org/apache/catalina/authenticator/FormAuthenticator.java
Tomcat
167
54,612
Bug 54612 Fatal Error when trying to send data to WebSocket with conection closed
null
2013-02-27 06:32:43
1,361,960,000
resolved fixed
1255d32
1,362,590,000
java/org/apache/catalina/websocket/WsOutbound.java
Tomcat
168
54,638
Bug 54638 /manager/status?XML=true
Hi all, in /manager/status?XML=true, informations about memory pools are incorrect. for every row all the values (initial,committed,maximum,used) are the same: Memory Pools Name:Eden Space Type:Heap memory Initial:143130624 Committed:143130624 Maximum:143130624 Used:143130624 Name:Survivor Space Type:Heap memory Initial:17891328 Committed:17891328 Maximum:17891328 Used:17891328 Name:Tenured Gen Type:Heap memory Initial:357957632 Committed:357957632 Maximum:357957632 Used:357957632 Name:Code Cache Type:Non-heap memory Initial:163840 Committed:8421376 Maximum:33554432 Used:163840 Name:Perm Gen Type:Non-heap memory Initial:12582912 Committed:23330816 Maximum:67108864 Used:12582912 Name:Perm Gen [shared-ro] Type:Non-heap memory Initial:10485760 Committed:10485760 Maximum:10485760 Used:10485760 Name:Perm Gen [shared-rw] Type:Non-heap memory Initial:12582912 Committed:12582912 Maximum:12582912 Used:12582912 Instead in the gui page values are correct.
2013-03-05 12:29:57
1,362,500,000
resolved fixed
78b3c10
1,362,530,000
java/org/apache/catalina/manager/StatusTransformer.java
Tomcat
169
54,585
Bug 54585 WebappLoader doesn't honor delegate attr while constructing jsp_classpath
If custom WebappClassLoader is created with delegate=true then parent-first classloading model is used. Everything works here as expected. However jsp_classpath is always constructed in the following manner: customWebappClassLoader.urls;parent.urls;parent...parent.urls Whereas it is expected to me that if delegate=true then parent's urls should come first.
2013-02-19 20:50:13
1,361,330,000
resolved fixed
9ad4904
1,362,010,000
java/org/apache/catalina/loader/WebappLoader.java
Tomcat
170
54,602
Bug 54602 B2CConverter character decode underflow leaves bytes in buffer
If a request contains a uri that ends in a multi byte character which is missing a byte the extra bytes are left in a buffer which is reused by a future request. The problem comes from two different things: 1) If B2CConverter tries to convert a ByteChunk which ends in a character underflow it does not convert that last character and it is left in a buffer in B2CConver. 2) The B2CConverter in org.apache.catalina.connector.Request is not recycled with the rest of the objects. It looks like this is done intentionally based on the comment above it's declaration. The issue with B2CConverter can be demonstrated with the code below, which is a simplification of what is done inside of CoyoteAdapter.convertURI(): <code> B2CConverter conv = new B2CConverter("UTF-8"); ByteChunk bc = new ByteChunk(); CharChunk cc = new CharChunk(); byte[] bytes = { 0x61, 0x62, 0x63, 0x64, -8, -69, -73, -77 }; bc.append(bytes, 0, bytes.length); cc.allocate(bc.getLength(), -1); conv.convert(bc, cc, cc.getBuffer().length - cc.getEnd()); System.out.println(cc); cc.recycle(); bc.recycle(); bc.append(bytes, 0, bytes.length); cc.allocate(bc.getLength(), -1); conv.convert(bc, cc, cc.getBuffer().length - cc.getEnd()); System.out.println(cc); </code> If the B2CConverter was recycled with everything else in Request this would prevent a previous request from corrupting the next request but it doesn't fix the issue that a character is dropped from the initial decode. I tried playing with B2CConverter and the only way I could get the convert to get everything was by ignoring the limit argument and reading to the end of the stream. It looks like tomcat8 is moving in this direction with the move to NIO, however I tried playing with the latest B2CConverter and was still seeing issues with the given byte sequence.
2013-02-22 20:06:36
1,361,580,000
resolved fixed
b2f0e7c
1,361,570,000
java/org/apache/catalina/connector/CoyoteAdapter.java
Tomcat
171
54,203
Bug 54203 Part class missing documentation
null
2012-11-25 09:02:17
1,353,850,000
resolved fixed
81eaf63
1,360,750,000
java/javax/servlet/http/Part.java
Tomcat
172
54,552
Bug 54552 Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener
null
2013-02-12 13:56:32
1,360,700,000
resolved fixed
c11952d
1,360,750,000
java/javax/servlet/http/HttpServletRequest.java java/javax/servlet/http/HttpServletRequestWrapper.java java/javax/servlet/http/HttpSessionIdListener.java java/org/apache/catalina/connector/Request.java java/org/apache/catalina/connector/RequestFacade.java java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/session/ManagerBase.java java/org/apache/catalina/websocket/WsHttpServletRequestWrapper.java
Tomcat
173
54,536
Bug 54536 ErrorReportValve doesn't respect HttpServletResponse.sendError(int sc, String msg)
null
2013-02-07 12:33:41
1,360,260,000
resolved fixed
ef9ed07
1,360,700,000
java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java
Tomcat
174
54,239
Bug 54239 Extensible EL Interpreter
null
2012-12-04 06:56:18
1,354,620,000
resolved fixed
f8ac6a0
1,360,680,000
java/org/apache/jasper/compiler/ELInterpreter.java java/org/apache/jasper/compiler/ELInterpreterFactory.java java/org/apache/jasper/compiler/Generator.java test/org/apache/jasper/compiler/TestELInterpreterFactory.java
Tomcat
175
54,456
Bug 54456 ChunkedInputFilter returning EOF when client closes connection without sending end chunk
null
2013-01-21 16:45:51
1,358,800,000
resolved fixed
cc2f8db
1,360,240,000
java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
Tomcat
176
54,521
Bug 54521 DigestAuthenticator: nonceCountValid() fails in case of simultaneous asynchronous requests of the same client
Concerned components: org.apache.catalina.authenticator.DigestAuthenticator org.apache.catalina.authenticator.DigestAuthenticator.NonceInfo Scenario: A multithreaded client sends two requests within one millisecond. The DigestAuthenticator creates for each request a nonce as well as a NonceInfo instance. The two nonces are equal, as they were created within the same millisecond. When writing data into the cache (method generateNonce()), the second NonceInfo instance overwrites the first one (same key!). Problem: The two client threads then send a second request with a digest authentication header. In both requests, nc (nonce count) is equal 1, as the nonce has been newly created. In the NonceInfo of the first request, array seen is set to true for index ((nonceCount + offset) % seen.length). In the second request the same NonceInfo instance is used, as the instance is retrieved from map nonces using nonce as a key, that is, in both requests the same key is used. Consequently, method nonceCountValid() returns false, as seen[(nonceCount + offset) % seen.length)] has already been set to true. Therefore the authentication fails, although the client has sent a valid digest authentication header. Conclusion: Working with multi-threaded clients with many requests, digest authentication does not function reliably.
2013-02-04 10:54:16
1,359,990,000
resolved fixed
b68bbb8
1,360,230,000
java/org/apache/catalina/authenticator/DigestAuthenticator.java test/org/apache/catalina/authenticator/TestDigestAuthenticator.java
Tomcat
177
54,534
Bug 54534 JMX connection may load servlet with invalid ClassLoader
null
2013-02-06 19:14:48
1,360,200,000
resolved fixed
a993d7c2
1,360,230,000
java/org/apache/catalina/core/StandardWrapper.java
Tomcat
178
54,513
Bug 54513 NullPointerException in AprEndpoint$Poller.run
Trunk at r1441188, running the test suite with APR connector, Native 1.1.26 Windows 32-bit with JDK 7u11. I encountered the following when running org.apache.catalina.loader.TestVirtualContext test On second re-run of the test the same issue happened, so it is as if there is something specific here. I have not encountered the issue with the rest of testsuite yet. [[[ Feb 01, 2013 2:07:26 AM org.apache.tomcat.util.net.AprEndpoint$Poller run WARNING: Unexpected poller error java.lang.NullPointerException at org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper.access$200(AprEndpoint.java:2198) at org.apache.tomcat.util.net.AprEndpoint$Poller.run(AprEndpoint.java:1632) at java.lang.Thread.run(Thread.java:722) ]]] The code at AprEndpoint$Poller.run(AprEndpoint.java:1632) is 1628 for (int n = 0; n < rv; n++) { 1629 timeouts.remove(desc[n*2+1]); 1630 AprSocketWrapper wrapper = connections.get( 1631 Long.valueOf(desc[n*2+1])); 1632 wrapper.pollerFlags = wrapper.pollerFlags & ~((int) desc[n*2]); I suspect that "wrapper" is null here. The above code is specific to Tomcat trunk and is not present in 7.0.x. When this happened, the test hung for 15 minutes (1000 secs) waiting on a socket read. When time out passed, it continued to run all the other tests. [[[ Testcase: testAdditionalWebInfClassesPaths took 1 006,735 sec Caused an ERROR Read timed out java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:150) at java.net.SocketInputStream.read(SocketInputStream.java:121) at java.io.BufferedInputStream.fill(BufferedInputStream.java:235) at java.io.BufferedInputStream.read1(BufferedInputStream.java:275) at java.io.BufferedInputStream.read(BufferedInputStream.java:334) at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:633) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:579) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1322) at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468) at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:247) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:219) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:213) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:202) at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVirtualContext.java:326) at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVirtualContext.java:320) at org.apache.catalina.loader.TestVirtualContext.testAdditionalWebInfClassesPaths(TestVirtualContext.java:311) ]]]
2013-01-31 23:15:59
1,359,690,000
resolved fixed
bbb13f6
1,359,840,000
java/org/apache/tomcat/util/net/AprEndpoint.java
Tomcat
179
54,497
Bug 54497 RuntimeException in WebappClassLoader.checkThreadLocalMapForLeaks() causes LifecycleException
Observed this when testing Tomcat trunk at r1438747, at WinXP 32-bit, JDK 7u11. (running TestWsWebSocketContainer with APR, Tomcat-Native 1.1.26 RC) There occurred an NPE in WebappClassLoader.checkThreadLocalMapForLeaks(). It was uncaught and caused LifecycleException and ultimately a failure to stop Tomcat. =============== In stderr: SEVERE: A child container failed during stop java.util.concurrent.ExecutionException: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[]] at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:252) at java.util.concurrent.FutureTask.get(FutureTask.java:111) at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:974) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1404) at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1393) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) ... 7 more Caused by: org.apache.catalina.LifecycleException: Failed to stop component [WebappLoader[]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardContext.stopInternal(StandardContext.java:5365) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) ... 7 more Caused by: java.lang.NullPointerException at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:54) at sun.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36) at java.lang.reflect.Field.get(Field.java:372) at org.apache.catalina.loader.WebappClassLoader.checkThreadLocalMapForLeaks(WebappClassLoader.java:2247) at org.apache.catalina.loader.WebappClassLoader.checkThreadLocalsForLeaks(WebappClassLoader.java:2188) at org.apache.catalina.loader.WebappClassLoader.clearReferences(WebappClassLoader.java:1731) at org.apache.catalina.loader.WebappClassLoader.stop(WebappClassLoader.java:1641) at org.apache.catalina.loader.WebappLoader.stopInternal(WebappLoader.java:491) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) ... 9 more =============== In testcase: Testcase: testSmallTextBufferClientTextMessage took 2,328 sec Caused an ERROR Failed to stop component [StandardServer[-1]] org.apache.catalina.LifecycleException: Failed to stop component [StandardServer[-1]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:336) at org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:163) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardService[Tomcat]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:766) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardService.stopInternal(StandardService.java:501) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Caused by: org.apache.catalina.LifecycleException: A child container failed during stop at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:981) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) =============== Thoughts: 1. We should catch throwables in those checkFor**Leaks methods. It should not cause a "failed to stop component" failure. 2. In that method there are many calls to "table[j]". The array member should be evaluated only once, so that it does not become null unexpectedly.
2013-01-25 23:16:17
1,359,170,000
resolved fixed
ea16bda
1,359,720,000
java/org/apache/catalina/loader/WebappClassLoader.java
Tomcat
180
54,496
Bug 54496 ..tribes.membership.MemberImpl.toString() might be better using .getClass().getName()
public String toString() { StringBuilder buf = new StringBuilder("org.apache.catalina.tribes.membership.MemberImpl["); Might be better to use .getClass().getName() to cover StaticMember and any other sub-classes that might arise.
2013-01-25 18:34:53
1,359,160,000
resolved fixed
e1e4e4e
1,359,390,000
java/org/apache/catalina/tribes/membership/MemberImpl.java
Tomcat
181
53,869
Bug 53869 Performance tuning solution to resolve too many cascaded JspContextWrapper issue
null
2012-09-13 13:56:24
1,347,560,000
resolved fixed
ce55f25
1,359,120,000
java/org/apache/jasper/runtime/JspContextWrapper.java
Tomcat
182
54,476
Bug 54476 incorrect param specification in javadoc ...tribes.group.GroupChannel send methods
* @param destination Member[] - destination.length > 1 I believe this should be: * @param destination Member[] - destination.length > 0
2013-01-23 20:05:14
1,358,990,000
resolved fixed
6647531
1,359,020,000
java/org/apache/catalina/tribes/group/GroupChannel.java
Tomcat
183
54,466
Bug 54466 No file name information in detail error when compiling the java file generated from a tag file
null
2013-01-22 09:07:46
1,358,860,000
resolved fixed
d7f744c
1,358,970,000
java/org/apache/jasper/compiler/DefaultErrorHandler.java
Tomcat
184
54,458
Bug 54458 DataSourceRealm should provide more info on SQLException
The getPassword() method of the DataSourceRealm does not log enough information when it encounters an SQL error. The catch block is: } catch(SQLException e) { containerLog.error( sm.getString("dataSourceRealm.getPassword.exception", username)); } finally { it would be really helpful to have some details of what the SQLException is. I am getting this intermittently, and have resorted to subclassing getPassword() in an attempt to figure out what is going wrong.
2013-01-21 21:56:02
1,358,820,000
resolved fixed
07a930d
1,358,960,000
java/org/apache/catalina/realm/DataSourceRealm.java
Tomcat
185
54,450
Bug 54450 Injection fails when part of the servlet properties uses @Resource and the other uses 'injection-target'
Hi, I have a servlet with: - annotated properties - and injection-target declarations in web.xml When I try to request this servlet I receive: javax.naming.NameNotFoundException: Name [envEntry1] is not bound in this Context. Unable to find [envEntry1]. at org.apache.naming.NamingContext.lookup(NamingContext.java:820) at org.apache.naming.NamingContext.lookup(NamingContext.java:154) at org.apache.naming.NamingContext.lookup(NamingContext.java:831) at org.apache.naming.NamingContext.lookup(NamingContext.java:168) at org.apache.catalina.core.DefaultInstanceManager.lookupMethodResource(DefaultInstanceManager.java:622) at org.apache.catalina.core.DefaultInstanceManager.processAnnotations(DefaultInstanceManager.java:466) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:157) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:138) at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1137) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:858) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:136) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) The problem is that when the application uses 'injection-target' declarations in org.apache.catalina.core.DefaultInstanceManager.populateAnnotationsCache(Class<?>, Map<String, String>) only the first setter method is evaluated and the rest are skipped. I would like to propose a patch and test case. I'm looking forward to your comments. Regards Violeta
2013-01-18 18:18:08
1,358,550,000
resolved fixed
ac78456
1,358,940,000
java/org/apache/catalina/core/DefaultInstanceManager.java test/org/apache/catalina/startup/TestContextConfig.java test/org/apache/catalina/startup/TesterServletWithAnnotations.java
Tomcat
186
54,448
Bug 54448 Field of primitive type, annotated with @Resource is not recognized as env entry
Hi, I have a servlet with one field of primitive type. The field is annotated with @Resource. public class MyServlet extends HttpServlet { @Resource(mappedName = "1") private int envEntry; protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { ... } } When I request this servlet I receive the following exception: SEVERE: Allocate exception for servlet MyServlet javax.naming.NamingException: Cannot create resource instance at org.apache.naming.factory.ResourceEnvFactory.getObjectInstance(ResourceEnvFactory.java:117) at javax.naming.spi.NamingManager.getObjectInstance(NamingManager.java:304) at org.apache.naming.NamingContext.lookup(NamingContext.java:843) at org.apache.naming.NamingContext.lookup(NamingContext.java:154) at org.apache.naming.NamingContext.lookup(NamingContext.java:831) at org.apache.naming.NamingContext.lookup(NamingContext.java:168) at org.apache.catalina.core.DefaultInstanceManager.lookupFieldResource(DefaultInstanceManager.java:581) at org.apache.catalina.core.DefaultInstanceManager.processAnnotations(DefaultInstanceManager.java:470) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:157) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:138) at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1137) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:858) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:136) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) That's because in the method below the primitive types are not 'converted' to their corresponding wrappers and this field is interpreted not as env entry but as resource env ref. org.apache.catalina.startup.WebAnnotationSet.addResource(Context, Resource, String, String) I'm attaching a patch that solves this issue and a test case. I'm looking forward to your comments. Regards Violeta
2013-01-17 21:48:35
1,358,480,000
resolved fixed
74f5b3a
1,358,940,000
java/org/apache/catalina/deploy/NamingResources.java java/org/apache/catalina/startup/WebAnnotationSet.java java/org/apache/catalina/util/Introspection.java test/org/apache/catalina/startup/TestContextConfig.java test/org/apache/catalina/startup/TesterServletWithAnnotations.java
Tomcat
187
54,324
Bug 54324 Support is required to disable TLS compression to prevent against CRIME attacks
null
2012-12-18 21:51:15
1,355,890,000
resolved fixed
ab44514
1,358,450,000
java/org/apache/coyote/http11/Http11AprProtocol.java java/org/apache/tomcat/jni/SSL.java java/org/apache/tomcat/util/net/AprEndpoint.java
Tomcat
188
54,438
Bug 54438 Bug fix 52953 introduces NullPointerException in RealmBase.java line 409 when user not found in JDBC
null
2013-01-16 21:14:31
1,358,390,000
resolved fixed
c8d5d88
1,358,430,000
java/org/apache/catalina/realm/RealmBase.java
Tomcat
189
54,440
Bug 54440 TagPluginManager.init() throws NPE when used in Ant <jasper> task
null
2013-01-17 03:29:19
1,358,410,000
resolved fixed
297b26a
1,358,430,000
java/org/apache/jasper/JspC.java java/org/apache/jasper/servlet/JspCServletContext.java
Tomcat
190
54,406
Bug 54406 NIO and BIO connectors handle unsupported SSL ciphers and sslEnabledProtocols differently
The NIO and BIO connectors share (most of) a JSSE based SSLImplementation, but differ in their handling of the ciphers and sslEnabledProtocols attributes. The NIO connector sets the configured values for both attributes directly on the SSLEngine, which will fail immediately if any of them are unsupported. This makes creating a portable/superset collection of ciphers impossible - i.e. IBM JDKs do not support many of the cipher suite names used by JSSE and vice versa (usually TLS_ vs SSL_ prefixes differ) and the supported options differ between Java 6/7 etc. The BIO connector attempts to filter the specified values down to those supported by the SSL implementation, but has issues as well: if none of the specified ciphers/protocols are supported it will silently use the defaults of the SSL implementation, which can lead to unexpectedly (and unwittingly) insecure configurations. I propose to: - modify the NIO connector to use the same logic as the BIO connector to filter requested ciphers/protocols to supported values (by placing these operations on the SSLUtil interface). - modify the ciphers/protocols filtering logic to treat an explicit list of unsupported options as setting no supported ciphers/protocols and warn when this is done (it will also fail visibly with errors if SSL connections are attempted).
2013-01-10 21:09:19
1,357,870,000
resolved fixed
9f657ac
1,358,110,000
java/org/apache/tomcat/util/net/NioEndpoint.java java/org/apache/tomcat/util/net/SSLUtil.java java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Tomcat
191
54,387
Bug 54387 Having servlets with same url should at least cause warning
I've found this interesting "mal functioning" in a application where I just copied the mapping portion of web.xml for a new created servlet, but forgot to change de URI. Tomcat deployed the application without any warning, but when running the application only the last referenced servlet was working (like if the mapping of the first has been overwritten by the last in the XML file). I made additional tests using annotations in servlets, and the behavior of having more than one servlet with same mapping causes random access to one or another (I cannot determine a predictable way). In order to prevent breaking existing applications, I would like to have just a "big warning" in the log at startup and/or deployment of the application that have more than one servlet mapped to same URL. Examples of the problem: Example 1: Web.xml ... <servlet> <servlet-name>PrintDacteServlet</servlet-name> <servlet-class>br.com.simfreteV1.web.PrintDacteServlet</servlet-class> </servlet> <servlet> <servlet-name>CotacaoReportServlet</servlet-name> <servlet-class>br.com.simfreteV1.web.CotacaoReportServlet</servlet-class> </servlet> <servlet-mapping> <servlet-name>PrintDacteServlet</servlet-name> <url-pattern>/secure/relatorios/Action</url-pattern> </servlet-mapping> <servlet-mapping> <servlet-name>CotacaoReportServlet</servlet-name> <url-pattern>/secure/relatorios/Action</url-pattern> </servlet-mapping> ... Example 2: annotations in java servlet files @WebServlet(name = "PdfReportPrint", urlPatterns = {"/secure/relatorios/doReport"}) public class PdfReportPrint extends AbstractBaseServlet { ... @WebServlet(name = "PrintBoletoServlet", urlPatterns = {"/secure/relatorios/doReport"}) public class PrintBoletoServlet extends HttpServlet { ...
2013-01-08 12:58:37
1,357,670,000
resolved fixed
334c466
1,357,820,000
java/org/apache/catalina/deploy/WebXml.java test/org/apache/catalina/deploy/TestWebXml.java
Tomcat
192
54,379
Bug 54379 Implement support for post-construct and pre-destroy elements in web.xml
null
2013-01-07 04:07:15
1,357,550,000
resolved fixed
71d075e
1,357,820,000
java/org/apache/catalina/Context.java java/org/apache/catalina/core/DefaultInstanceManager.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/deploy/WebXml.java java/org/apache/catalina/startup/FailedContext.java java/org/apache/catalina/startup/WebRuleSet.java java/org/apache/catalina/util/Introspection.java test/org/apache/catalina/core/TestStandardContext.java test/org/apache/catalina/core/TesterContext.java test/org/apache/catalina/deploy/TestWebXml.java test/org/apache/catalina/startup/TestContextConfig.java test/org/apache/catalina/startup/TestWebRuleSet.java test/org/apache/catalina/startup/TesterServletWithLifeCycleMethods.java
Tomcat
193
54,382
Bug 54382 Nullpointer Exception after activating SSI and loading of any html-file with a specific comment
1. Activate SSI on Tomcat and restart Tomcat 2. create an any html-file with a comment like this "<!--#-->" 3. put this html-file to the webapp folder of tomcat 4. when you now go to the html file via tomcat, you will get an Nullpointer Exception. The SSIServlet.class and other necessary SSI-classes cannot be found
2013-01-07 23:56:21
1,357,620,000
resolved fixed
d83a5e5
1,357,680,000
java/org/apache/catalina/ssi/SSIProcessor.java
Tomcat
194
54,381
Bug 54381 Websocket StreamInbound never reports receipt of a Pong
The tomcat websocket api now allows the send of a Ping frame by the server (as of 7.0.33), via WsOutbound, but never reports the receipt of a Pong. See StreamInbound in the onData() method... } else if (opCode == Constants.OPCODE_PONG) { // NO-OP } As the intended use of Pings is for heartbeat messages, allowing a Ping without informing the server extension of the returned Pong leaves out half the utility. I would suggest these changes to StreamInbound as a fix... 1) In the onData() method... } else if (opCode == Constants.OPCODE_PONG) { onPong(frame.getPayLoad()); } 2) Add a method onPong (ByteBuffer buffer)... protected void onPong(ByteBuffer buffer) { // NO-OP } ...which implementations may now override to handle Pong receipt and heartbeat logic. This is necessary as onData() is marked final, so there's no alternate workaround.
2013-01-07 19:44:37
1,357,610,000
resolved fixed
5f7af1b
1,357,680,000
java/org/apache/catalina/websocket/StreamHandler.java
Tomcat
195
54,377
Bug 54377 RemoteIpFilter does not correctly set request attributes for AccessLog
In RemoteIpFilter class, there is code that publishes the new request attributes to AccessLog (see below). 821 if (requestAttributesEnabled) { 822 request.setAttribute(AccessLog.REMOTE_ADDR_ATTRIBUTE, 823 request.getRemoteAddr()); 824 request.setAttribute(AccessLog.REMOTE_HOST_ATTRIBUTE, 825 request.getRemoteHost()); 826 request.setAttribute(AccessLog.PROTOCOL_ATTRIBUTE, 827 request.getProtocol()); 828 request.setAttribute(AccessLog.SERVER_PORT_ATTRIBUTE, 829 Integer.valueOf(request.getServerPort())); 830 } The problem is that the source values should come from xRequest, e.g. xRequest.getRemoteAddr() and xRequest.getRemoteHost(), etc. As it is written above, RemoteIpFilter simply republishes the current values, and AccessLog therefore does not display the correct values.
2013-01-05 23:52:37
1,357,450,000
resolved fixed
95e6056
1,357,680,000
java/org/apache/catalina/filters/RemoteIpFilter.java test/org/apache/catalina/filters/TestRemoteIpFilter.java test/org/apache/catalina/valves/TestRemoteIpValve.java
Tomcat
196
54,380
Bug 54380 In MapperListener.lifecycleEvent(..): check state of parent before calling registerWrapper()
null
2013-01-07 12:37:27
1,357,580,000
resolved fixed
3a9990b
1,357,630,000
java/org/apache/catalina/mapper/MapperListener.java
Tomcat
197
54,248
Bug 54248 Retrieving content that contains a BOM via request.getReader() issue
If a request contains Content that includes the BOM - in my case Content-Type: application/xml; charset-utf-16 - and the content has a BOM (FF FE), when fetched utilizing the BufferedReader from getReader() - the first request serviced on the AJP thread works correctly (encoded correctly, only characters fetched), however, any subsequent request on the thread which includes the BOM has the BOM being delivered to the application. It appears via review of the Tomcat code, that the recycle() method in B2CConverter simply ensures the socket's data has been completely flushed and the underlying InputStream doesn't get reset (don't really know if there is a way to do this without re-instantiating it) to ensure subsequent requests BOM is consumed. I proved this as a test by adding a call to reset() within the recycle() method which re-instantiates the underlying InputStreams and the problem resolved itself. I've temporarily resolved the issue in my application code by using request.getInputStream() and using request.getCharacterEncoding() and encoding the content inside my application.
2012-12-05 11:56:08
1,354,730,000
resolved fixed
f7fc27a
1,357,600,000
java/org/apache/tomcat/util/buf/B2CConverter.java test/org/apache/tomcat/util/buf/TestB2CConverter.java
Tomcat
198
54,284
Bug 54284 Util.objectNameValueNeedsQuote throws NPE for anonymous Filters
How to reproduce? From inside the contextInitialized-Method of an ServletContextListener instance, call context.addFilter(null, new ArbitraryFilter(pathPrefix)).addMappingForUrlPatterns(null, false, pathPrefix); What happens? Dec 12, 2012 3:59:03 PM org.apache.catalina.core.StandardContext filterStart SEVERE: Exception starting filter null java.lang.NullPointerException at org.apache.tomcat.util.modeler.Util.objectNameValueNeedsQuote(Util.java:26) at org.apache.catalina.core.ApplicationFilterConfig.registerJMX(ApplicationFilterConfig.java:421) at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:282) at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:108) at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4650) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5306) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633) at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:657) at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1637) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Dec 12, 2012 3:59:03 PM org.apache.catalina.core.StandardContext startInternal SEVERE: Error filterStart Dec 12, 2012 3:59:03 PM org.apache.catalina.core.StandardContext startInternal SEVERE: Context [] startup failed due to previous errors What should happen? Either - if null is not an allowed filter name, throw a IllegalArgumentException on context.addFilter(...) Or, if it is an allowed filter name, handle null-values gracefully
2012-12-12 15:51:40
1,355,350,000
resolved fixed
113c0bd
1,357,590,000
java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/deploy/FilterDef.java java/org/apache/catalina/deploy/ServletDef.java test/org/apache/catalina/core/TestApplicationContext.java test/org/apache/catalina/deploy/TestFilterDef.java test/org/apache/catalina/deploy/TestServletDef.java
Tomcat
199
54,262
Bug 54262 An empty <absolute-ordering /> should turn off all web-fragments
The use of an <absolute-ordering> element does disable ServletContainerInitializer classpath scanning as discussed also in issue 53619. However, it does seem to require having at least one web-fragment name to be listed. In other words I would this: <absolute-ordering /> To turn off all web-fragments since none are named. A workaround is to list a web-fragment even if it doesn't exist but that shouldn't be necessary.
2012-12-07 22:00:09
1,354,940,000
resolved fixed
5418e2b
1,357,580,000
java/org/apache/catalina/deploy/WebXml.java java/org/apache/catalina/startup/WebRuleSet.java test/org/apache/catalina/startup/TestContextConfig.java
Tomcat
200
54,370
Bug 54370 NPE mapping method in EL
null
2013-01-03 14:20:38
1,357,240,000
resolved fixed
5361e86
1,357,230,000
java/org/apache/el/util/ReflectionUtil.java test/org/apache/el/util/TestReflectionUtil.java test/org/apache/el/util/Tester.java
Tomcat
201
54,260
Bug 54260 JSP unloading - NullPointerException when using ".tag" files
null
2012-12-07 17:58:25
1,354,920,000
resolved fixed
94da507
1,357,220,000
java/org/apache/jasper/util/FastRemovalDequeue.java
Tomcat
202
54,256
Bug 54256 Enhance Exception reporting on JAR file error
(I posted this to the mailing list on Oct 28, 2011, but didn't end up creating a report on it until now. I have the same error with Tomcat 7.) PROBLEM DESCRIPTION: I have an exception (appended below), and I think it would be nice to have more information about what is going on. If I had more context, it would help me find the cause of my problem much more quickly. For example, if the exception indicated what the file/resource that was having the problem was, it would speed up troubleshooting immensely. HOW TO REPRODUCE: In a JAR file contained in WAR file's WEB-INF/lib folder: Change the MANIFEST.MF file in the JAR file. Put in a line with ONLY "Class-Path:". Note there is no space after the period, which is what causes the error. During load of the application, the exception which I have appended at the end of this message will show up. SUGGESTED IMPROVEMENT: My suggestion would be to modify ExtensionValidator.validateApplication(...), around line 195. This is the location that actually knows about what the resource is. It would be nice if the IOException was caught, and information about the Resource was added to the exception, probably by wrapping the exception. Because I have not gone through the overhead of getting a version of Tomcat running from source, these changes have not been compiled and tested, but I think the suggestion is relatively straight-forward. Here are the suggested code changes: First code change - move the definition of "resource" outside of the try/catch: // Locate the Manifests for all bundled JARs Resource resource = null; // ADDED NamingEnumeration<Binding> ne = null; Second code change - make the existing declaration of "resource" just an assignment: resource = (Resource) obj; // MODIFIED inputStream = resource.streamContent(); Manifest jmanifest = getManifest(inputStream); Third code change: add a catch clause and re-throw: } catch (NamingException nex) { // Jump out of the check for this application because it // has no resources } catch (IOException ioex) { // ADDED throw new IOException("validation problem in " + resource.toString(), ioex); // ADDED } finally { The problem is that the resource may not have a proper toString(). I would suggest changing FileDirContext:898 (inner class=FileResource) to have a toString method, something along the lines of: public String toString() { // ADDED return file == null ? "null" : file.toString(); // ADDED } // ADDED Note: about this, in the original email thread, Konstantin Kolinko said: "Not sure about FileResource.toString(), but adding a catch for IOException looks like doable." Finally, here's the exception: 28-Oct-2011 11:03:03 AM org.apache.catalina.core.StandardContext startInternal SEVERE: Error in dependencyCheck java.io.IOException: invalid header field at java.util.jar.Attributes.read(Attributes.java:410) at java.util.jar.Manifest.read(Manifest.java:199) at java.util.jar.JarInputStream.<init>(JarInputStream.java:83) at java.util.jar.JarInputStream.<init>(JarInputStream.java:60) at org.apache.catalina.util.ExtensionValidator.getManifest(ExtensionValidator.java:394) at org.apache.catalina.util.ExtensionValidator.validateApplication(ExtensionValidator.java:195) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5037) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1033) at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:774) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1033) at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:291) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.StandardService.startInternal(StandardService.java:443) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:727) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.startup.Catalina.start(Catalina.java:621) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:322) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:450) (And if only java.util.jar.Attributes.read reported WHICH attribute had the problem, we'd really be in business.)
2012-12-06 20:44:32
1,354,840,000
resolved fixed
0ae2f34
1,357,160,000
java/org/apache/catalina/util/ExtensionValidator.java
Tomcat
203
54,247
Bug 54247 Exception in JmxRemoteLifecycleListener.destroyServer
null
2012-12-05 10:00:36
1,354,720,000
resolved fixed
29c4a0e
1,357,160,000
java/org/apache/catalina/startup/Bootstrap.java
Tomcat
204
54,241
Bug 54241 NPE in BodyContentImpl
null
2012-12-04 07:53:25
1,354,630,000
resolved fixed
ffc4525
1,357,140,000
java/org/apache/jasper/runtime/JspWriterImpl.java test/org/apache/jasper/runtime/TestJspWriterImpl.java
Tomcat
205
54,194
Bug 54194 NPE in DataSource.registerJmx() although DataSource is created with setJmxEnabled(false)
null
2012-11-23 14:35:58
1,353,700,000
resolved fixed
1c61fb1
1,354,600,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java
Tomcat
206
54,150
Bug 54150 SlowQueryReportJmx mbean deregistration failure due to NPE - properties not set during pool close callback
Found while debugging version 7.0.29 I found that our SlowQueryReportJmx mbean was not being deregistered during webapp shutdown. I tracked this down to a NPE. The interceptor properties are not being set (as is done in setupConnection) prior to the pool close callback. ConnectionPool.close(boolean) poolClosed callback produces NPE in SlowQueryReportJmx. {code} PoolProperties.InterceptorDefinition[] proxies = getPoolProperties().getJdbcInterceptorsAsArray(); for (int i=0; i<proxies.length; i++) { try { proxies[i].getInterceptorClass().newInstance().poolClosed(this); }catch (Exception x) { log.debug("Unable to inform interceptor of pool closure.",x); } } ... {code} NPE in SlowQueryReportJmx - null.containsKey {code} public ObjectName getObjectName(Class<?> clazz, String poolName) throws MalformedObjectNameException { ... NPE if (getProperties().containsKey(objectNameAttribute)) { ... {code} Sounds reasonable to set properties any time you need to instantiate interceptors. As is done in ConnectionPool.init(PoolConfiguration) {code} JdbcInterceptor interceptor = proxies[i].getInterceptorClass().newInstance(); interceptor.setProperties(proxies[i].getProperties()); interceptor.poolStarted(this); {code}
2012-11-15 18:38:29
1,353,020,000
resolved fixed
b021a22
1,354,600,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Tomcat
207
54,220
Bug 54220 ErrorReportValve invoked on non-error responses too
null
2012-11-28 20:19:49
1,354,150,000
resolved fixed
a2d1441
1,354,540,000
java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java
Tomcat
208
54,217
Bug 54217 JDBC connection pool runs out of connections when Context reload=true is enabled in Tomcat
null
2012-11-28 10:35:43
1,354,120,000
resolved fixed
a81538d
1,354,540,000
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Tomcat
209
54,207
Bug 54207 javaURLContextFactory javadoc refers to defunct package names in initial context properties
Javadoc for org.apache.naming.java.javaURLContextFactory: /** * Context factory for the "java:" namespace. * <p> * <b>Important note</b> : This factory MUST be associated with the "java" URL * prefix, which can be done by either : * <ul> * <li>Adding a * java.naming.factory.url.pkgs=org.apache.catalina.util.naming property * to the JNDI properties file</li> * <li>Setting an environment variable named Context.URL_PKG_PREFIXES with * its value including the org.apache.catalina.util.naming package name. * More detail about this can be found in the JNDI documentation : * {@link javax.naming.spi.NamingManager#getURLContext(java.lang.String, java.util.Hashtable)}.</li> * </ul> * * @author Remy Maucherat * @version $Id$ */ org.apache.catalina.util.naming is a very old package name. The correct name for both TC6 and TC7 is org.apache.naming .
2012-11-26 02:10:22
1,353,910,000
resolved fixed
d6b4740
1,353,930,000
java/org/apache/naming/java/javaURLContextFactory.java
Tomcat