Fix code analysis issues.
@@ -3406,13 +3406,13 @@ int client_error_test()
ret = tls_api_one_sim_round(test_ctx, &simulated_time, next_time, &was_active);
}
- if (test_ctx->cnx_server->cnx_state != picoquic_state_disconnected) {
+ if (ret == 0 && test_ctx->cnx_server->cnx_state != picoquic_state_disconnected) {
ret = -1;
}
+ if (ret == 0) {
/* Delete the client connection from the client context,
* without sending notification to the server */
-
while (test_ctx->qclient->cnx_list != NULL) {
picoquic_delete_cnx(test_ctx->qclient->cnx_list);
}
@@ -3432,6 +3432,7 @@ int client_error_test()
else if (ret == 0) {
ret = picoquic_start_client_cnx(test_ctx->cnx_client);
}
+ }
/* Now, restart a connection in the same context */
if (ret == 0) {
@@ -3891,11 +3892,9 @@ int migration_test()
int cnxid_renewal_test()
{
- uint64_t loss_mask_data = 0;
uint64_t simulated_time = 0;
uint64_t next_time = 0;
uint64_t loss_mask = 0;
- uint64_t initial_challenge = 0;
picoquic_connection_id_t target_id = picoquic_null_connection_id;
picoquic_connection_id_t previous_local_id = picoquic_null_connection_id;
picoquic_test_tls_api_ctx_t* test_ctx = NULL;
