STM32 Ethernet: Using Timer Instead of Poll Thread
@@ -35,6 +35,9 @@ struct rt_stm32_eth
{
/* inherit from ethernet device */
struct eth_device parent;
+#ifndef PHY_USING_INTERRUPT_MODE
+ rt_timer_t poll_link_timer;
+#endif
/* interface address info, hw address */
rt_uint8_t dev_addr[MAX_ADDR_LEN];
@@ -515,12 +518,7 @@ static void phy_monitor_thread_entry(void *parameter)
rt_thread_mdelay(2000);
HAL_ETH_WritePHYRegister(&EthHandle, PHY_BASIC_CONTROL_REG, PHY_AUTO_NEGOTIATION_MASK);
- while (1)
- {
phy_linkchange();
-
- if (stm32_eth_device.parent.netif->flags & NETIF_FLAG_LINK_UP)
- {
#ifdef PHY_USING_INTERRUPT_MODE
/* configuration intterrupt pin */
rt_pin_mode(PHY_INT_PIN, PIN_MODE_INPUT_PULLUP);
@@ -532,18 +530,14 @@ static void phy_monitor_thread_entry(void *parameter)
#if defined(PHY_INTERRUPT_CTRL_REG)
HAL_ETH_WritePHYRegister(&EthHandle, PHY_INTERRUPT_CTRL_REG, PHY_INTERRUPT_EN);
#endif
- break;
-#endif
- } /* link up. */
- else
+#else /* PHY_USING_INTERRUPT_MODE */
+ stm32_eth_device.poll_link_timer = rt_timer_create("phylnk", (void (*)(void*))phy_linkchange,
+ NULL, RT_TICK_PER_SECOND, RT_TIMER_FLAG_PERIODIC);
+ if (!stm32_eth_device.poll_link_timer || rt_timer_start(stm32_eth_device.poll_link_timer) != RT_EOK)
{
- LOG_I("link down");
- /* send link down. */
- eth_device_linkchange(&stm32_eth_device.parent, RT_FALSE);
- }
-
- rt_thread_delay(RT_TICK_PER_SECOND);
+ LOG_E("Start link change detection timer failed");
}
+#endif /* PHY_USING_INTERRUPT_MODE */
}
/* Register the EMAC device */
