misc: vppctl fix heap-buffer-overflow & memleaks
1. Malloc may return not zero buffer, causing strncat buffer overflow
2. Malloc buffer not freed
Type: fix
Fixes: ("misc: vppctl - remove the dependency on vppinfra")
@@ -215,6 +215,13 @@ main (int argc, char *argv[])
{
cmd_len++; // account for \n in the end
cmd = malloc (cmd_len);
+ if (!cmd)
+ {
+ error = errno;
+ perror ("malloc failed");
+ goto done;
+ }
+ memset (cmd, 0, cmd_len);
while (argc--)
{
strncat (cmd, *argv++, cmd_len);
@@ -431,6 +438,7 @@ main (int argc, char *argv[])
close (sock_fd);
done:
+ free (cmd);
if (efd > -1)
close (efd);
