Resove GPDB_12_MERGE_FIXME in cdbhash.c
remove fixme in cdbhash.c: this is only used in internal to compute
the hash key value, they all use the same collation with default collation,
so it will get same result with the same value, it's ok here.
@@ -186,8 +186,7 @@ cdbhash(CdbHash *h, int attno, Datum datum, bool isnull)
uint32 hkey;
InitFunctionCallInfoData(*fcinfo, &h->hashfuncs[attno - 1], 1,
- /* GPDB_12_MERGE_FIXME: always use default collation. Is that OK? */
- DEFAULT_COLLATION_OID,
+ DEFAULT_COLLATION_OID, /* have to specify collation for attribute of text or bpchar */
NULL, NULL);
fcinfo->args[0].value = datum;
