ioam: fix coverity warning/NULL dereference
Add a NULL check and missing array index to avoid multiple NULL
derefences.
Runnning:
set ioam ip6 sr-tunnel-select disable
on a fresh VPP no longer crashes.
Type: fix
@@ -608,6 +608,8 @@ ioam_cache_ts_table_destroy (vlib_main_t * vm)
int i;
/* free pool and hash table */
+ if (cm->ioam_ts_pool)
+ {
for (i = 0; i < no_of_threads; i++)
{
pool_foreach (entry, cm->ioam_ts_pool[i])
@@ -615,10 +617,11 @@ ioam_cache_ts_table_destroy (vlib_main_t * vm)
ioam_cache_ts_entry_free (i, entry, cm->error_node_index);
}
pool_free (cm->ioam_ts_pool[i]);
- cm->ioam_ts_pool = 0;
+ cm->ioam_ts_pool[i] = 0;
tw_timer_wheel_free_16t_2w_512sl (&cm->timer_wheels[i]);
}
vec_free (cm->ioam_ts_pool);
+ }
return (0);
}
