Address review comments and improve the design doc
-Attestation QPL Enforcement Support
+Attestation SGX QPL Enforcement Support
====
-This proposal is to make a change to `oe_verify_evidence`, so that it can support policy based QPL (Quote Provider Library) enhancement, such as allowing the API user to pass data to QPL for more advanced quote verification.
+This proposal is to make a change to `oe_verify_evidence`, so that it can support policy-based SGX QPL (Quote Provider Library) specific enhancement, such as allowing the API user to pass data to the SGX QPL for more advanced quote verification.
Motivation
----
-Intel SGX rolls out PCK certificate and collateral information about every six month. There is a scenario that a quote is signed by the last version of PCK certificate cannot be verified with the latest version of collateral information. This causes unnecessary attestation failures when new versions of PCK certificate and collateral information are rolled out. To deal with this issue, the QPL need to be able to return any version collateral information based on additional query parameters (referred as baselines). With that, a new API called `sgx_ql_get_quote_verification_collateral_with_params` is introduced in QPL. Changes are also needed at OE SDK to call this new API.
+Intel SGX rolls out PCK certificate and collateral information about every six month. There is a scenario that a quote is signed by the last version of PCK certificate cannot be verified with the latest version of collateral information. This causes unnecessary attestation failures when new versions of PCK certificate and collateral information are rolled out. To deal with this issue, the SGX QPL need to return any version collateral information based on additional query parameters (referred as baselines). With that, a new API called `sgx_ql_get_quote_verification_collateral_with_params` is introduced in the SGX QPL. Changes are also needed at OE SDK to call this new API.
Goals:
- - Verifier can call `oe_verify_evidence` and pass QPL specific parameters to do more advanced quote verification.
+ - Verifier can call `oe_verify_evidence` and pass SGX QPL specific parameters to do more advanced quote verification.
User Experience
----
-A new policy type `OE_POLICY_SGX_COLLATERAL_BASELINE` is added to current policy types. Quote verifier can pass multiple policies with this type, while OE SDK would pass all the policies down to the QPL API without interpreting the data content.
+A new policy type `OE_POLICY_SGX_COLLATERAL_BASELINE` is added to current policy types. Quote verifier can pass multiple policies with this type, while OE SDK would pass all the policies down to the SGX QPL API without interpreting the data content.
Specification
----
@@ -24,7 +24,7 @@ Specification
- `OE_POLICY_SGX_COLLATERAL_BASELINE` in `oe_policy_type_t`
- `oe_sgx_collateral_query_param`, which is defined as below,
```C
-// defined by QPL
+// defined by SGX QPL
#define MAX_PARAM_STRING_SIZE (255)
typedef struct _oe_sgx_collateral_query_param
{
