message: [tests] Don't initialize PrecomputedTransactionData in txvalidationcache tests
  PrecomputedTransactionData is initialized inside CheckInputScripts(). No need
  to pre-initialize it before calling into CheckInputScripts().
diff: @@ -108,7 +108,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_block_doublespend, TestChain100Setup)
  // any script flag that is implemented as an upgraded NOP code.
  static void ValidateCheckInputsForAllFlags(const CTransaction &tx, uint32_t failing_flags, bool add_to_cache) EXCLUSIVE_LOCKS_REQUIRED(cs_main)
  {
  - PrecomputedTransactionData txdata(tx);
  + PrecomputedTransactionData txdata;
  // If we add many more flags, this loop can get too expensive, but we can
  // rewrite in the future to randomly pick a set of flags to evaluate.
  for (uint32_t test_flags=0; test_flags < (1U << 16); test_flags += 1) {
  @@ -200,7 +200,7 @@ BOOST_FIXTURE_TEST_CASE(checkinputs_test, TestChain100Setup)
  LOCK(cs_main);
  TxValidationState state;
  - PrecomputedTransactionData ptd_spend_tx(spend_tx);
  + PrecomputedTransactionData ptd_spend_tx;
  BOOST_CHECK(!CheckInputScripts(CTransaction(spend_tx), state, &::ChainstateActive().CoinsTip(), SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_DERSIG, true, true, ptd_spend_tx, nullptr));
  @@ -270,7 +270,7 @@ BOOST_FIXTURE_TEST_CASE(checkinputs_test, TestChain100Setup)
  // Make it valid, and check again
  invalid_with_cltv_tx.vin[0].scriptSig = CScript() << vchSig << 100;
  TxValidationState state;
  - PrecomputedTransactionData txdata(invalid_with_cltv_tx);
  + PrecomputedTransactionData txdata;
  BOOST_CHECK(CheckInputScripts(CTransaction(invalid_with_cltv_tx), state, ::ChainstateActive().CoinsTip(), SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY, true, true, txdata, nullptr));
  }
  @@ -298,7 +298,7 @@ BOOST_FIXTURE_TEST_CASE(checkinputs_test, TestChain100Setup)
  // Make it valid, and check again
  invalid_with_csv_tx.vin[0].scriptSig = CScript() << vchSig << 100;
  TxValidationState state;
  - PrecomputedTransactionData txdata(invalid_with_csv_tx);
  + PrecomputedTransactionData txdata;
  BOOST_CHECK(CheckInputScripts(CTransaction(invalid_with_csv_tx), state, &::ChainstateActive().CoinsTip(), SCRIPT_VERIFY_CHECKSEQUENCEVERIFY, true, true, txdata, nullptr));
  }
  @@ -359,7 +359,7 @@ BOOST_FIXTURE_TEST_CASE(checkinputs_test, TestChain100Setup)
  tx.vin[1].scriptWitness.SetNull();
  TxValidationState state;
  - PrecomputedTransactionData txdata(tx);
  + PrecomputedTransactionData txdata;
  // This transaction is now invalid under segwit, because of the second input.
  BOOST_CHECK(!CheckInputScripts(CTransaction(tx), state, &::ChainstateActive().CoinsTip(), SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, true, true, txdata, nullptr));
  