message: staticrelo: Remove line number check
  Summary:
  Now that we have the line number map, we can probably be more
  aggressive in relocating methods.
  The broader motivation is that I want to remove the m_line_start
  field in DexDebugInfo as part of a larger refactor.
diff: @@ -43,7 +43,6 @@ static float s_avg_relocation_load;
  static size_t s_max_relocation_load;
  static int s_single_ref_total_count;
  static int s_single_ref_moved_count;
  -static int s_line_conflict_but_sig_fine_count;
  /** map of dmethod or class (T) -> method/opcode referencing dmethod or class */
  template <typename T>
  @@ -272,22 +271,8 @@ bool does_method_collide(
  const DexMethod* method,
  const std::vector<DexMethod*> methods) {
  for (auto other_method : methods) {
  - auto first_dbg = method->get_code()->get_debug_item();
  - auto sec_dbg = other_method->get_code()->get_debug_item();
  - bool line_nums_equal = false;
  - // In a stack trace we can't disambiguate between
  - // two methods if they have the same name and line number
  - // since we don't get the full signature back.
  - if (first_dbg != nullptr && sec_dbg != nullptr) {
  - line_nums_equal = first_dbg->get_line_start() == sec_dbg->get_line_start();
  - }
  if (method->get_name() == other_method->get_name() &&
  - (method->get_proto() == other_method->get_proto() ||
  - line_nums_equal)) {
  - // under different constraints we could use the full signature to disambiguate
  - if (method->get_proto() != other_method->get_proto()) {
  - s_line_conflict_but_sig_fine_count++;
  - }
  + method->get_proto() == other_method->get_proto()) {
  return true;
  }
  }
  @@ -649,7 +634,6 @@ void StaticReloPass::run_pass(DexStoresVector& stores, ConfigFiles& cfg, PassMan
  s_max_relocation_load = 0; // FIXME: does not work with DexStores
  s_single_ref_total_count = 0;
  s_single_ref_moved_count = 0;
  - s_line_conflict_but_sig_fine_count = 0;
  //relocate statics on a per-dex store basis
  for (auto& store : stores) {
  @@ -709,7 +693,6 @@ void StaticReloPass::run_pass(DexStoresVector& stores, ConfigFiles& cfg, PassMan
  "RELO :| On average relocated %f methods onto all targets\n"
  "RELO :| Max %d methods relocated onto any one target\n"
  "RELO :( Could not move %d methods\n"
  - "RELO :( Could not move %d methods due to conservative "
  "aliasing criteria\n",
  mgr.get_metric(METRIC_NUM_DELETED_METHODS),
  mgr.get_metric(METRIC_NUM_MOVED_METHODS),
  @@ -718,8 +701,7 @@ void StaticReloPass::run_pass(DexStoresVector& stores, ConfigFiles& cfg, PassMan
  s_single_ref_total_count,
  s_avg_relocation_load,
  s_max_relocation_load,
  - s_meth_could_not_move_count,
  - s_line_conflict_but_sig_fine_count);
  + s_meth_could_not_move_count);
  }
  static StaticReloPass s_pass;
  