message: test: check parameter validity in rpc_signmessage.py
  checks parameter validity and error codes for the related RPCs:
  - signmessagewithprivkey
  - signmessage
  - verifymessage
diff: """Test RPC commands for signing and verifying messages."""
  from test_framework.test_framework import BitcoinTestFramework
  -from test_framework.util import assert_equal
  +from test_framework.util import (
  + assert_equal,
  + assert_raises_rpc_error,
  +)
  class SignMessagesTest(BitcoinTestFramework):
  def set_test_params(self):
  @@ -38,5 +41,22 @@ class SignMessagesTest(BitcoinTestFramework):
  assert not self.nodes[0].verifymessage(other_address, signature, message)
  assert not self.nodes[0].verifymessage(address, other_signature, message)
  + self.log.info('test parameter validity and error codes')
  + # signmessage(withprivkey) have two required parameters
  + for num_params in [0, 1, 3, 4, 5]:
  + param_list = ["dummy"]*num_params
  + assert_raises_rpc_error(-1, "signmessagewithprivkey", self.nodes[0].signmessagewithprivkey, *param_list)
  + assert_raises_rpc_error(-1, "signmessage", self.nodes[0].signmessage, *param_list)
  + # verifymessage has three required parameters
  + for num_params in [0, 1, 2, 4, 5]:
  + param_list = ["dummy"]*num_params
  + assert_raises_rpc_error(-1, "verifymessage", self.nodes[0].verifymessage, *param_list)
  + # invalid key or address provided
  + assert_raises_rpc_error(-5, "Invalid private key", self.nodes[0].signmessagewithprivkey, "invalid_key", message)
  + assert_raises_rpc_error(-5, "Invalid address", self.nodes[0].signmessage, "invalid_addr", message)
  + assert_raises_rpc_error(-5, "Invalid address", self.nodes[0].verifymessage, "invalid_addr", signature, message)
  + # malformed signature provided
  + assert_raises_rpc_error(-3, "Malformed base64 encoding", self.nodes[0].verifymessage, self.nodes[0].getnewaddress(), "invalid_sig", message)
  +
  if __name__ == '__main__':
  SignMessagesTest().main()
  