message: net: cleanup newly added PeerManagerImpl::ProcessNewBlock
  Addresses some post-merge comments.
diff: @@ -493,7 +493,8 @@ private:
  void ProcessGetData(CNode& pfrom, Peer& peer, const std::atomic<bool>& interruptMsgProc) EXCLUSIVE_LOCKS_REQUIRED(peer.m_getdata_requests_mutex) LOCKS_EXCLUDED(::cs_main);
  - void ProcessBlock(CNode& pfrom, const std::shared_ptr<const CBlock>& pblock, bool fForceProcessing);
  + /** Process a new block. Perform any post-processing housekeeping */
  + void ProcessBlock(CNode& node, const std::shared_ptr<const CBlock>& block, bool force_processing);
  /** Relay map (txid or wtxid -> CTransactionRef) */
  typedef std::map<uint256, CTransactionRef> MapRelay;
  @@ -2397,15 +2398,15 @@ void PeerManagerImpl::ProcessGetCFCheckPt(CNode& peer, CDataStream& vRecv)
  m_connman.PushMessage(&peer, std::move(msg));
  }
  -void PeerManagerImpl::ProcessBlock(CNode& pfrom, const std::shared_ptr<const CBlock>& pblock, bool fForceProcessing)
  +void PeerManagerImpl::ProcessBlock(CNode& node, const std::shared_ptr<const CBlock>& block, bool force_processing)
  {
  - bool fNewBlock = false;
  - m_chainman.ProcessNewBlock(m_chainparams, pblock, fForceProcessing, &fNewBlock);
  - if (fNewBlock) {
  - pfrom.nLastBlockTime = GetTime();
  + bool new_block{false};
  + m_chainman.ProcessNewBlock(m_chainparams, block, force_processing, &new_block);
  + if (new_block) {
  + node.nLastBlockTime = GetTime();
  } else {
  LOCK(cs_main);
  - mapBlockSource.erase(pblock->GetHash());
  + mapBlockSource.erase(block->GetHash());
  }
  }
  @@ -3495,7 +3496,7 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
  LOCK(cs_main);
  mapBlockSource.emplace(pblock->GetHash(), std::make_pair(pfrom.GetId(), false));
  }
  - // Setting fForceProcessing to true means that we bypass some of
  + // Setting force_processing to true means that we bypass some of
  // our anti-DoS protections in AcceptBlock, which filters
  // unrequested blocks that might be trying to waste our resources
  // (eg disk space). Because we only try to reconstruct blocks when
  @@ -3504,7 +3505,7 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
  // we have a chain with at least nMinimumChainWork), and we ignore
  // compact blocks with less work than our tip, it is safe to treat
  // reconstructed compact blocks as having been requested.
  - ProcessBlock(pfrom, pblock, /*fForceProcessing=*/true);
  + ProcessBlock(pfrom, pblock, /*force_processing=*/true);
  LOCK(cs_main); // hold cs_main for CBlockIndex::IsValid()
  if (pindex->IsValid(BLOCK_VALID_TRANSACTIONS)) {
  // Clear download state for this block, which is in
  @@ -3587,7 +3588,7 @@ void PeerManagerImpl::ProcessMessage(CNode& pfrom, const std::string& msg_type,
  // disk-space attacks), but this should be safe due to the
  // protections in the compact block handler -- see related comment
  // in compact block optimistic reconstruction handling.
  - ProcessBlock(pfrom, pblock, /*fForceProcessing=*/true);
  + ProcessBlock(pfrom, pblock, /*force_processing=*/true);
  }
  return;
  }
  