message: refactor: Remove Node::getReindex() call from GUI
diff: @@ -241,17 +241,6 @@ static void BannedListChanged(ClientModel *clientmodel)
  static void BlockTipChanged(ClientModel* clientmodel, SynchronizationState sync_state, int height, int64_t blockTime, double verificationProgress, bool fHeader)
  {
  - const bool initialSync = sync_state != SynchronizationState::POST_INIT;
  -
  - // lock free async UI updates in case we have a new block tip
  - // during initial sync, only update the UI if the last update
  - // was > 250ms (MODEL_UPDATE_DELAY) ago
  - int64_t now = 0;
  - if (initialSync)
  - now = GetTimeMillis();
  -
  - int64_t& nLastUpdateNotification = fHeader ? nLastHeaderTipUpdateNotification : nLastBlockTipUpdateNotification;
  -
  if (fHeader) {
  // cache best headers time and height to reduce future cs_main locks
  clientmodel->cachedBestHeaderHeight = height;
  @@ -260,9 +249,14 @@ static void BlockTipChanged(ClientModel* clientmodel, SynchronizationState sync_
  clientmodel->m_cached_num_blocks = height;
  }
  - // During initial sync, block notifications, and header notifications from reindexing are both throttled.
  - if (!initialSync || (fHeader && !clientmodel->node().getReindex()) || now - nLastUpdateNotification > MODEL_UPDATE_DELAY) {
  - //pass an async signal to the UI thread
  + // Throttle GUI notifications about (a) blocks during initial sync, and (b) both blocks and headers during reindex.
  + const bool throttle = (sync_state != SynchronizationState::POST_INIT && !fHeader) || sync_state == SynchronizationState::INIT_REINDEX;
  + const int64_t now = throttle ? GetTimeMillis() : 0;
  + int64_t& nLastUpdateNotification = fHeader ? nLastHeaderTipUpdateNotification : nLastBlockTipUpdateNotification;
  + if (throttle && now < nLastUpdateNotification + MODEL_UPDATE_DELAY) {
  + return;
  + }
  +
  bool invoked = QMetaObject::invokeMethod(clientmodel, "numBlocksChanged", Qt::QueuedConnection,
  Q_ARG(int, height),
  Q_ARG(QDateTime, QDateTime::fromTime_t(blockTime)),
  @@ -271,7 +265,6 @@ static void BlockTipChanged(ClientModel* clientmodel, SynchronizationState sync_
  assert(invoked);
  nLastUpdateNotification = now;
  }
  -}
  void ClientModel::subscribeToCoreSignals()
  {
  