message: [net processing] Move all const declarations to top of net_processing.cpp
diff: @@ -115,7 +115,20 @@ static const unsigned int MAX_BLOCKS_TO_ANNOUNCE = 8;
  static const int MAX_UNCONNECTING_HEADERS = 10;
  /** Minimum blocks required to signal NODE_NETWORK_LIMITED */
  static const unsigned int NODE_NETWORK_LIMITED_MIN_BLOCKS = 288;
  -
  +/** Average delay between local address broadcasts */
  +static constexpr std::chrono::hours AVG_LOCAL_ADDRESS_BROADCAST_INTERVAL{24};
  +/** Average delay between peer address broadcasts */
  +static constexpr std::chrono::seconds AVG_ADDRESS_BROADCAST_INTERVAL{30};
  +/** Average delay between trickled inventory transmissions in seconds.
  + * Blocks and whitelisted receivers bypass this, outbound peers get half this delay. */
  +static const unsigned int INVENTORY_BROADCAST_INTERVAL = 5;
  +/** Maximum number of inventory items to send per transmission.
  + * Limits the impact of low-fee transaction floods. */
  +static constexpr unsigned int INVENTORY_BROADCAST_MAX = 7 * INVENTORY_BROADCAST_INTERVAL;
  +/** Average delay between feefilter broadcasts in seconds. */
  +static constexpr unsigned int AVG_FEEFILTER_BROADCAST_INTERVAL = 10 * 60;
  +/** Maximum feefilter broadcast delay after significant change. */
  +static constexpr unsigned int MAX_FEEFILTER_CHANGE_DELAY = 5 * 60;
  struct COrphanTx {
  // When modifying, adapt the copy of this definition in tests/DoS_tests.
  @@ -132,21 +145,6 @@ void EraseOrphansFor(NodeId peer);
  /** Increase a node's misbehavior score. */
  void Misbehaving(NodeId nodeid, int howmuch, const std::string& message="") EXCLUSIVE_LOCKS_REQUIRED(cs_main);
  -/** Average delay between local address broadcasts */
  -static constexpr std::chrono::hours AVG_LOCAL_ADDRESS_BROADCAST_INTERVAL{24};
  -/** Average delay between peer address broadcasts */
  -static constexpr std::chrono::seconds AVG_ADDRESS_BROADCAST_INTERVAL{30};
  -/** Average delay between trickled inventory transmissions in seconds.
  - * Blocks and whitelisted receivers bypass this, outbound peers get half this delay. */
  -static const unsigned int INVENTORY_BROADCAST_INTERVAL = 5;
  -/** Maximum number of inventory items to send per transmission.
  - * Limits the impact of low-fee transaction floods. */
  -static constexpr unsigned int INVENTORY_BROADCAST_MAX = 7 * INVENTORY_BROADCAST_INTERVAL;
  -/** Average delay between feefilter broadcasts in seconds. */
  -static constexpr unsigned int AVG_FEEFILTER_BROADCAST_INTERVAL = 10 * 60;
  -/** Maximum feefilter broadcast delay after significant change. */
  -static constexpr unsigned int MAX_FEEFILTER_CHANGE_DELAY = 5 * 60;
  -
  // Internal stuff
  namespace {
  /** Number of nodes with fSyncStarted. */
  