message: net_processing: move AddToCompactExtraTransactions into PeerManagerImpl
  Allows making vExtraTxnForCompact and vExtraTxnForCompactIt member vars
  instead of globals.
diff: @@ -461,10 +461,8 @@ private:
  /** Storage for orphan information */
  TxOrphanage m_orphanage;
  -};
  -} // namespace
  -namespace {
  + void AddToCompactExtraTransactions(const CTransactionRef& tx) EXCLUSIVE_LOCKS_REQUIRED(g_cs_orphans);
  /** peercoin: blocks that are waiting to be processed, the key points to previous CBlockIndex entry */
  struct WaitElement {
  std::shared_ptr<CBlock> pblock;
  @@ -472,15 +470,19 @@ namespace {
  };
  std::map<CBlockIndex*, WaitElement> mapBlocksWait;
  - /** Number of preferable block download peers. */
  - int nPreferredDownload GUARDED_BY(cs_main) = 0;
  /** Orphan/conflicted/etc transactions that are kept for compact block reconstruction.
  * The last -blockreconstructionextratxn/DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN of
  * these are kept in a ring buffer */
  - static std::vector<std::pair<uint256, CTransactionRef>> vExtraTxnForCompact GUARDED_BY(g_cs_orphans);
  + std::vector<std::pair<uint256, CTransactionRef>> vExtraTxnForCompact GUARDED_BY(g_cs_orphans);
  /** Offset into vExtraTxnForCompact to insert the next tx */
  - static size_t vExtraTxnForCompactIt GUARDED_BY(g_cs_orphans) = 0;
  + size_t vExtraTxnForCompactIt GUARDED_BY(g_cs_orphans) = 0;
  +};
  +} // namespace
  +
  +namespace {
  + /** Number of preferable block download peers. */
  + int nPreferredDownload GUARDED_BY(cs_main) = 0;
  } // namespace
  namespace {
  @@ -1090,7 +1092,7 @@ bool PeerManagerImpl::GetNodeStateStats(NodeId nodeid, CNodeStateStats &stats)
  return true;
  }
  -static void AddToCompactExtraTransactions(const CTransactionRef& tx) EXCLUSIVE_LOCKS_REQUIRED(g_cs_orphans)
  +void PeerManagerImpl::AddToCompactExtraTransactions(const CTransactionRef& tx)
  {
  size_t max_extra_txn = gArgs.GetArg("-blockreconstructionextratxn", DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN);
  if (max_extra_txn <= 0)
  