message: qt, refactor: Use enum type as switch argument in BanTableModel
diff: @@ -23,15 +23,13 @@ bool BannedNodeLessThan::operator()(const CCombinedBan& left, const CCombinedBan
  if (order == Qt::DescendingOrder)
  std::swap(pLeft, pRight);
  - switch(column)
  - {
  + switch (static_cast<BanTableModel::ColumnIndex>(column)) {
  case BanTableModel::Address:
  return pLeft->subnet.ToString().compare(pRight->subnet.ToString()) < 0;
  case BanTableModel::Bantime:
  return pLeft->banEntry.nBanUntil < pRight->banEntry.nBanUntil;
  - }
  -
  - return false;
  + } // no default case, so the compiler can warn about missing cases
  + assert(false);
  }
  // private implementation
  @@ -119,16 +117,17 @@ QVariant BanTableModel::data(const QModelIndex &index, int role) const
  CCombinedBan *rec = static_cast<CCombinedBan*>(index.internalPointer());
  + const auto column = static_cast<ColumnIndex>(index.column());
  if (role == Qt::DisplayRole) {
  - switch(index.column())
  - {
  + switch (column) {
  case Address:
  return QString::fromStdString(rec->subnet.ToString());
  case Bantime:
  QDateTime date = QDateTime::fromMSecsSinceEpoch(0);
  date = date.addSecs(rec->banEntry.nBanUntil);
  return QLocale::system().toString(date, QLocale::LongFormat);
  - }
  + } // no default case, so the compiler can warn about missing cases
  + assert(false);
  }
  return QVariant();
  