message: review: try to make both clang and gcc happy.
diff: @@ -132,21 +132,29 @@ protected:
  Network::Test::getCanonicalLoopbackAddress(GetParam()), nullptr, true);
  listener_ =
  dispatcher_->createListener(socket_, listener_callbacks_, true, ENVOY_TCP_BACKLOG_SIZE);
  -#if 0
  - client_connection_ = std::make_unique<Network::TestClientConnectionImpl>(
  - *dispatcher_, socket_->localAddress(), source_address_,
  - Network::Test::createRawBufferSocket(), socket_options_);
  -#else
  - // NB: there is a bug in clang such that the above code reports:
  +#if defined(__clang__) && defined(__has_feature) && __has_feature(address_sanitizer)
  + // There is a bug in clang with AddressSanitizer on the CI such that the code below reports:
  + //
  // runtime error: constructor call on address 0x6190000b4a80 with insufficient space for
  // an object of type 'Envoy::Network::(anonymous namespace)::TestClientConnectionImpl'
  // 0x6190000b4a80: note: pointer points here
  - // 05 01 80 39 be be be be be be be be be be be be be be be be be be be be be be be be be
  - // be be be
  - auto x = malloc(sizeof(TestClientConnectionImpl) + 1000);
  + // 05 01 80 39 be be be be be be be be be be be be be be be be be be be be be be be be
  + // be be be be
  + //
  + // However, the workaround below trips gcc on the CI, which reports:
  + //
  + // size check failed 2304 1280 38
  + // CorrectSize(p, size, tcmalloc::DefaultAlignPolicy())
  + //
  + // so we only use it for clang with AddressSanitizer builds.
  + auto x = malloc(sizeof(TestClientConnectionImpl) + 1024);
  new (x) TestClientConnectionImpl(*dispatcher_, socket_->localAddress(), source_address_,
  Network::Test::createRawBufferSocket(), socket_options_);
  client_connection_.reset(reinterpret_cast<TestClientConnectionImpl*>(x));
  +#else
  + client_connection_ = std::make_unique<Network::TestClientConnectionImpl>(
  + *dispatcher_, socket_->localAddress(), source_address_,
  + Network::Test::createRawBufferSocket(), socket_options_);
  #endif
  client_connection_->addConnectionCallbacks(client_callbacks_);
  EXPECT_EQ(nullptr, client_connection_->ssl());
  