message: fuzz: Fill various small fuzzing gaps
diff: // Distributed under the MIT software license, see the accompanying
  // file COPYING or http://www.opensource.org/licenses/mit-license.php.
  +#include <merkleblock.h>
  +#include <policy/fees.h>
  #include <rpc/util.h>
  #include <test/fuzz/FuzzedDataProvider.h>
  #include <test/fuzz/fuzz.h>
  #include <util/error.h>
  #include <util/translation.h>
  +#include <array>
  #include <cstdint>
  #include <vector>
  +namespace {
  +constexpr TransactionError ALL_TRANSACTION_ERROR[] = {
  + TransactionError::OK,
  + TransactionError::MISSING_INPUTS,
  + TransactionError::ALREADY_IN_CHAIN,
  + TransactionError::P2P_DISABLED,
  + TransactionError::MEMPOOL_REJECTED,
  + TransactionError::MEMPOOL_ERROR,
  + TransactionError::INVALID_PSBT,
  + TransactionError::PSBT_MISMATCH,
  + TransactionError::SIGHASH_MISMATCH,
  + TransactionError::MAX_FEE_EXCEEDED,
  +};
  +
  +constexpr FeeEstimateHorizon ALL_FEE_EST_HORIZON[] = {
  + FeeEstimateHorizon::SHORT_HALFLIFE,
  + FeeEstimateHorizon::MED_HALFLIFE,
  + FeeEstimateHorizon::LONG_HALFLIFE,
  +};
  +
  +constexpr OutputType ALL_OUTPUT_TYPE[] = {
  + OutputType::LEGACY,
  + OutputType::P2SH_SEGWIT,
  + OutputType::BECH32,
  +};
  +}; // namespace
  +
  // The fuzzing kitchen sink: Fuzzing harness for functions that need to be
  // fuzzed but a.) don't belong in any existing fuzzing harness file, and
  // b.) are not important enough to warrant their own fuzzing harness file.
  @@ -19,8 +49,23 @@ FUZZ_TARGET(kitchen_sink)
  {
  FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
  - const TransactionError transaction_error = fuzzed_data_provider.PickValueInArray<TransactionError>({TransactionError::OK, TransactionError::MISSING_INPUTS, TransactionError::ALREADY_IN_CHAIN, TransactionError::P2P_DISABLED, TransactionError::MEMPOOL_REJECTED, TransactionError::MEMPOOL_ERROR, TransactionError::INVALID_PSBT, TransactionError::PSBT_MISMATCH, TransactionError::SIGHASH_MISMATCH, TransactionError::MAX_FEE_EXCEEDED});
  + const TransactionError transaction_error = fuzzed_data_provider.PickValueInArray(ALL_TRANSACTION_ERROR);
  (void)JSONRPCTransactionError(transaction_error);
  (void)RPCErrorFromTransactionError(transaction_error);
  (void)TransactionErrorString(transaction_error);
  +
  + (void)StringForFeeEstimateHorizon(fuzzed_data_provider.PickValueInArray(ALL_FEE_EST_HORIZON));
  +
  + const OutputType output_type = fuzzed_data_provider.PickValueInArray(ALL_OUTPUT_TYPE);
  + const std::string& output_type_string = FormatOutputType(output_type);
  + OutputType output_type_parsed;
  + const bool parsed = ParseOutputType(output_type_string, output_type_parsed);
  + assert(parsed);
  + assert(output_type == output_type_parsed);
  + (void)ParseOutputType(fuzzed_data_provider.ConsumeRandomLengthString(64), output_type_parsed);
  +
  + const std::vector<uint8_t> bytes = ConsumeRandomLengthByteVector(fuzzed_data_provider);
  + const std::vector<bool> bits = BytesToBits(bytes);
  + const std::vector<uint8_t> bytes_decoded = BitsToBytes(bits);
  + assert(bytes == bytes_decoded);
  }
  