message: Combo: Cleanup. Removed unrequired uses of the _ComboBox flag (the test in EndChild() is from commit no 1!). We could remove ImGuiWindowFlags_ComboBox soonish.
diff: @@ -2770,8 +2770,6 @@ static int ChildWindowComparer(const void* lhs, const void* rhs)
  return d;
  if (int d = (a->Flags & ImGuiWindowFlags_Tooltip) - (b->Flags & ImGuiWindowFlags_Tooltip))
  return d;
  - if (int d = (a->Flags & ImGuiWindowFlags_ComboBox) - (b->Flags & ImGuiWindowFlags_ComboBox))
  - return d;
  return (a->OrderWithinParent - b->OrderWithinParent);
  }
  @@ -3973,7 +3971,7 @@ void ImGui::EndChild()
  ImGuiWindow* window = GetCurrentWindow();
  IM_ASSERT(window->Flags & ImGuiWindowFlags_ChildWindow); // Mismatched BeginChild()/EndChild() callss
  - if ((window->Flags & ImGuiWindowFlags_ComboBox) || window->BeginCount > 1)
  + if (window->BeginCount > 1)
  {
  ImGui::End();
  }
  @@ -4482,7 +4480,7 @@ bool ImGui::Begin(const char* name, bool* p_open, ImGuiWindowFlags flags)
  window->WindowRounding = (flags & ImGuiWindowFlags_ChildWindow) ? style.ChildRounding : ((flags & ImGuiWindowFlags_Popup) && !(flags & ImGuiWindowFlags_Modal)) ? style.PopupRounding : style.WindowRounding;
  window->WindowBorderSize = (flags & ImGuiWindowFlags_ChildWindow) ? style.ChildBorderSize : ((flags & ImGuiWindowFlags_Popup) && !(flags & ImGuiWindowFlags_Modal)) ? style.PopupBorderSize : style.WindowBorderSize;
  window->WindowPadding = style.WindowPadding;
  - if ((flags & ImGuiWindowFlags_ChildWindow) && !(flags & (ImGuiWindowFlags_AlwaysUseWindowPadding | ImGuiWindowFlags_ComboBox | ImGuiWindowFlags_Popup)) && window->WindowBorderSize == 0.0f)
  + if ((flags & ImGuiWindowFlags_ChildWindow) && !(flags & (ImGuiWindowFlags_AlwaysUseWindowPadding | ImGuiWindowFlags_Popup)) && window->WindowBorderSize == 0.0f)
  window->WindowPadding = ImVec2(0.0f, (flags & ImGuiWindowFlags_MenuBar) ? style.WindowPadding.y : 0.0f);
  const float window_rounding = window->WindowRounding;
  const float window_border_size = window->WindowBorderSize;
  @@ -9093,21 +9091,17 @@ bool ImGui::BeginCombo(const char* label, const char* preview_value, ImGuiComboF
  if (!ItemAdd(total_bb, id))
  return false;
  - const float arrow_size = SmallSquareSize();
  -
  bool hovered, held;
  bool pressed = ButtonBehavior(frame_bb, id, &hovered, &held);
  -
  bool popup_open = IsPopupOpen(id);
  + const float arrow_size = SmallSquareSize();
  const ImRect value_bb(frame_bb.Min, frame_bb.Max - ImVec2(arrow_size, 0.0f));
  RenderFrame(frame_bb.Min, frame_bb.Max, GetColorU32(ImGuiCol_FrameBg), true, style.FrameRounding);
  RenderFrame(ImVec2(frame_bb.Max.x-arrow_size, frame_bb.Min.y), frame_bb.Max, GetColorU32(popup_open || hovered ? ImGuiCol_ButtonHovered : ImGuiCol_Button), true, style.FrameRounding); // FIXME-ROUNDING
  RenderTriangle(ImVec2(frame_bb.Max.x - arrow_size + style.FramePadding.y, frame_bb.Min.y + style.FramePadding.y), ImGuiDir_Down);
  -
  if (preview_value != NULL)
  RenderTextClipped(frame_bb.Min + style.FramePadding, value_bb.Max, preview_value, NULL, NULL, ImVec2(0.0f,0.0f));
  -
  if (label_size.x > 0)
  RenderText(ImVec2(frame_bb.Max.x + style.ItemInnerSpacing.x, frame_bb.Min.y + style.FramePadding.y), label);
  