message: [Executor] Remove create_storage_server
  This function does not do anything other than wrapping
  start_storage_service.
  Closes:
  Approved by: zamsden
diff: @@ -25,10 +25,6 @@ use storage_client::{StorageRead, StorageReadServiceClient, StorageWriteServiceC
  use storage_service::start_storage_service;
  use tokio::runtime::Runtime;
  -fn create_storage_server(config: &mut NodeConfig) -> Runtime {
  - start_storage_service(&config)
  -}
  -
  fn create_executor(config: &NodeConfig) -> (Executor<MockVM>, ExecutedTrees) {
  let mut rt = Runtime::new().unwrap();
  let read_client = Arc::new(StorageReadServiceClient::new(&config.storage.address));
  @@ -77,8 +73,8 @@ struct TestExecutor {
  impl TestExecutor {
  fn new() -> (TestExecutor, ExecutedTrees) {
  - let (mut config, _) = config_builder::test_config();
  - let storage_server = create_storage_server(&mut config);
  + let (config, _) = config_builder::test_config();
  + let storage_server = start_storage_service(&config);
  let (executor, committed_trees) = create_executor(&config);
  (
  @@ -287,8 +283,8 @@ fn create_transaction_chunks(
  // To obtain the batches of transactions, we first execute and save all these transactions in a
  // separate DB. Then we call get_transactions to retrieve them.
  - let (mut config, _) = config_builder::test_config();
  - let storage_server = create_storage_server(&mut config);
  + let (config, _) = config_builder::test_config();
  + let storage_server = start_storage_service(&config);
  let (executor, root_trees) = create_executor(&config);
  let mut txns = vec![];
  @@ -351,8 +347,8 @@ fn test_executor_execute_and_commit_chunk() {
  };
  // Now we execute these two chunks of transactions.
  - let (mut config, _) = config_builder::test_config();
  - let storage_server = create_storage_server(&mut config);
  + let (config, _) = config_builder::test_config();
  + let storage_server = start_storage_service(&config);
  let (executor, mut committed_trees) = create_executor(&config);
  let storage_client = StorageReadServiceClient::new(&config.storage.address);
  @@ -448,8 +444,8 @@ fn test_executor_execute_and_commit_chunk_restart() {
  ])
  };
  - let (mut config, _) = config_builder::test_config();
  - let storage_server = create_storage_server(&mut config);
  + let (config, _) = config_builder::test_config();
  + let storage_server = start_storage_service(&config);
  let mut synced_trees;
  // First we simulate syncing the first chunk of transactions.
  @@ -624,8 +620,8 @@ proptest! {
  let block_a = TestBlock::new(0..a_size, amount, *PRE_GENESIS_BLOCK_ID, gen_block_id(1));
  let block_b = TestBlock::new(0..b_size, amount, gen_block_id(1), gen_block_id(2));
  - let (mut config, _) = config_builder::test_config();
  - let storage_server = create_storage_server(&mut config);
  + let (config, _) = config_builder::test_config();
  + let storage_server = start_storage_service(&config);
  // First execute and commit one block, then destroy executor.
  {
  @@ -682,8 +678,8 @@ proptest! {
  overlap_start..overlap_end
  ]);
  - let (mut config, _) = config_builder::test_config();
  - let storage_server = create_storage_server(&mut config);
  + let (config, _) = config_builder::test_config();
  + let storage_server = start_storage_service(&config);
  let (executor, committed_trees) = create_executor(&config);
  let overlap_txn_list_with_proof = chunks.pop().unwrap();
  