put description for the new implementation as comments in the method
this is a summary of how to get done
@@ -60,6 +60,18 @@ impl RawSettings {
}
pub fn log_settings(&self) -> LogSettings {
+ // FIXME: remove this after refactoring is done
+ // changing the flow for creating the LogSettings inner Vec to this:
+ // * Read log settings from the config file path
+ // * If no log settings are found:
+ // + add LogSettingsEntry with default values
+ // * If the command line specifies log arguments:
+ // + Check that the arg is Some(output), else, skip
+ // + Read the log settings, and look if we already
+ // have this output configured
+ // + If the output is aleady configured:
+ // - overwrite entry.level if cli_entry.level is Some(level)
+ // - overwrite entry.format if cli_entry.format is Some(format)
let mut entries = Vec::new();
if let Some(log) = self.config.as_ref().and_then(|cfg| cfg.log.as_ref()) {
