Classify the remaining unfixed clippy lints as ones to fix versus ignore
No code changes here, this is just to confirm our consensus about what our
goals and expectations are.
@@ -190,27 +190,26 @@ unit-sup: build-launcher-for-supervisor-tests
.PHONY: build-launcher-for-supervisor-tests
# Lints we need to work through and decide as a team whether to allow or fix
-UNEXAMINED_LINTS = clippy::cyclomatic_complexity \
- clippy::large_enum_variant \
- clippy::len_without_is_empty \
- clippy::module_inception \
- clippy::needless_pass_by_value \
+UNEXAMINED_LINTS =
+
+# Lints we disagree with and choose to keep in our code with no warning
+ALLOWED_LINTS = clippy::module_inception \
clippy::needless_return \
clippy::new_ret_no_self \
clippy::new_without_default \
clippy::new_without_default_derive \
+ clippy::redundant_field_names
+
+# Known failing lints we want to receive warnings for, but not fail the build
+LINTS_TO_FIX = clippy::cyclomatic_complexity \
+ clippy::large_enum_variant \
+ clippy::len_without_is_empty \
+ clippy::needless_pass_by_value \
clippy::question_mark \
- clippy::redundant_field_names \
clippy::too_many_arguments \
clippy::trivially_copy_pass_by_ref \
clippy::wrong_self_convention
-# Lints we disagree with and choose to keep in our code with no warning
-ALLOWED_LINTS =
-
-# Known failing lints we want to receive warnings for, but not fail the build
-LINTS_TO_FIX =
-
# Lints we don't expect to have in our code at all and want to avoid adding
# even at the cost of failing the build
DENIED_LINTS = clippy::assign_op_pattern \
