virtcontainers: clh: Turn-off serial and virtio-console by default
We will need to have console output from the guest only for debugging
purposes. As a result, we can turn-off both the serial and
virtio-console devices by default for better boot time.
Fixes:
@@ -285,11 +285,12 @@ func (clh *cloudHypervisor) createSandbox(ctx context.Context, id string, networ
clh.vmconfig.Pmem = &[]chclient.PmemConfig{*pmem}
}
- // set the serial console to the cloud hypervisor
+ // Use serial port as the guest console only in debug mode,
+ // so that we can gather early OS booting log
if clh.config.Debug {
clh.vmconfig.Serial = chclient.NewConsoleConfig(cctTTY)
} else {
- clh.vmconfig.Serial = chclient.NewConsoleConfig(cctNULL)
+ clh.vmconfig.Serial = chclient.NewConsoleConfig(cctOFF)
}
clh.vmconfig.Console = chclient.NewConsoleConfig(cctOFF)
@@ -989,7 +990,6 @@ func (clh *cloudHypervisor) launchClh() (int, error) {
const (
cctOFF string = "Off"
- cctNULL string = "Null"
cctTTY string = "Tty"
)
