Fix clippy::wrong_self_convention
Actually just suppress it because the fix would be a pretty involved
refactoring of PackageArchive.
@@ -206,6 +206,14 @@ impl PackageArchive {
// a service. It determines that by checking for the presence of a run hook file or a
// pkg_svc_run value. Therefore, if we can detect the presence of a SVC_USER file, we can
// consider this archive a service.
+ //
+ // The allow below is necessary because `is_*` functions expect a `&self`, not `&mut self`.
+ // It would be good to refactor this struct to do the read_metadata in new and then
+ // eliminate the `&mut self`s on all the accessor functions, but that's a more involved
+ // change than we want to undertake now.
+ //
+ // See https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
+ #[allow(clippy::wrong_self_convention)]
pub fn is_a_service(&mut self) -> bool {
match self.svc_user() {
Ok(_) => true,
