CI: increase AMD snap resume latency limit
We are currently experiencing a degradation in AMD
latency which is causing our CI to stay blocked.
In order to unblock it, we are relaxing the value
temporarily.
@@ -20,6 +20,7 @@ from framework.utils import (
get_kernel_version,
is_io_uring_supported,
)
+from framework.utils_cpuid import get_instance_type
from framework.stats import core, consumer, producer, types, criteria, function
from integration_tests.performance.utils import handle_failure
@@ -64,8 +65,11 @@ CREATE_LATENCY_BASELINES = {
# this is tracked here:
# https://github.com/firecracker-microvm/firecracker/issues/2027
# TODO: Update the table after fix. Target is < 5ms.
+# TODO: we need to actually measure the numbers for m6i
+# since they might be lower.
LOAD_LATENCY_BASELINES = {
"x86_64": {
+ "m5d.metal": {
"4.14": {
"sync": {
"2vcpu_256mb.json": {"target": 9},
@@ -83,7 +87,45 @@ LOAD_LATENCY_BASELINES = {
},
},
},
+ "m6a.metal": {
+ "4.14": {
+ "sync": {
+ "2vcpu_256mb.json": {"target": 15},
+ "2vcpu_512mb.json": {"target": 15},
+ }
+ },
+ "5.10": {
+ "sync": {
+ "2vcpu_256mb.json": {"target": 60},
+ "2vcpu_512mb.json": {"target": 60},
+ },
+ "async": {
+ "2vcpu_256mb.json": {"target": 190},
+ "2vcpu_512mb.json": {"target": 190},
+ },
+ },
+ },
+ "m6i.metal": {
+ "4.14": {
+ "sync": {
+ "2vcpu_256mb.json": {"target": 9},
+ "2vcpu_512mb.json": {"target": 9},
+ }
+ },
+ "5.10": {
+ "sync": {
+ "2vcpu_256mb.json": {"target": 60},
+ "2vcpu_512mb.json": {"target": 60},
+ },
+ "async": {
+ "2vcpu_256mb.json": {"target": 190},
+ "2vcpu_512mb.json": {"target": 190},
+ },
+ },
+ },
+ },
"aarch64": {
+ "m6g.metal": {
"4.14": {
"sync": {
"2vcpu_256mb.json": {"target": 2},
@@ -100,6 +142,7 @@ LOAD_LATENCY_BASELINES = {
"2vcpu_512mb.json": {"target": 130},
},
},
+ }
},
}
@@ -124,7 +167,7 @@ def snapshot_create_measurements(vm_type, snapshot_type):
def snapshot_resume_measurements(vm_type, io_engine):
"""Define measurements for snapshot resume tests."""
- load_latency = LOAD_LATENCY_BASELINES[platform.machine()][
+ load_latency = LOAD_LATENCY_BASELINES[platform.machine()][get_instance_type()][
get_kernel_version(level=1)
][io_engine][vm_type]
@@ -331,7 +374,7 @@ def _test_snapshot_resume_latency(context):
rw_disk = context.disk.copy()
# Get ssh key from read-only artifact.
ssh_key = context.disk.ssh_key()
- # Create a fresh microvm from aftifacts.
+ # Create a fresh microvm from artifacts.
vm_instance = vm_builder.build(
kernel=context.kernel,
disks=[rw_disk],
