message: Remove last call to BasicCheck from now private function
  Now that the function is private, all calls to it are controlled, and
  can be pre-checked for valid parameter values.
  Remove BasicCheck helper function.
diff: #include <stdexcept>
  -namespace
  -{
  - void BasicCheck(PopulationTable::Role role);
  -}
  -
  -
  /**
  * Sets a pointer to a Population object.
  *
  @@ -50,7 +44,6 @@ bool PopulationPool::usePopulation(PopulationRequirements populationRequirements
  */
  bool PopulationPool::usePopulation(PopulationTable::Role role, int amount)
  {
  - BasicCheck(role);
  int scientistsAvailable = mPopulation->size(PopulationTable::Role::Scientist) - (mScientistsAsWorkers + mScientistsUsed);
  int workersAvailable = mPopulation->size(PopulationTable::Role::Worker) - mWorkersUsed;
  @@ -129,38 +122,3 @@ int PopulationPool::populationEmployed()
  {
  return scientistsEmployed() + scientistsAsWorkers() + workersEmployed();
  }
  -
  -
  -// ===============================================================================
  -
  -namespace
  -{
  - /**
  - * Does a basic check to ensure that we're only trying to pull population that can be employed.
  - *
  - * Generally speaking the only 'workable' population is for Workers and Scientists. Children, Students
  - * and Retirees won't be pulled for labor/research so attempting to pull this should be considered
  - * a mistake and should fail very loudly. In this case throws a std::runtime_error.
  - *
  - * In the future this may change but for now this is almost strictly a debugging aid. This failure
  - * would indicate a very significant problem with the calling code.
  - *
  - * \throws std::runtime_exception if Child/Student/Retired is asked for.
  - */
  - void BasicCheck(PopulationTable::Role role)
  - {
  - if (role == PopulationTable::Role::Child || role == PopulationTable::Role::Student || role == PopulationTable::Role::Retired)
  - {
  - std::string roleTypeName;
  - switch (role)
  - {
  - case PopulationTable::Role::Child: roleTypeName = "PopulationTable::Role::Child"; break;
  - case PopulationTable::Role::Student: roleTypeName = "PopulationTable::Role::Student"; break;
  - case PopulationTable::Role::Retired: roleTypeName = "PopulationTable::Role::Retired"; break;
  - default: break;
  - }
  -
  - throw std::runtime_error("PopulationPool::BasicCheck(): Invalid population role specified (" + roleTypeName + ").");
  - }
  - }
  -}
  