src_fm_fc_ms_ff
stringlengths 43
86.8k
| target
stringlengths 20
276k
|
|---|---|
AutomaticPermanentBlocksCleanup implements DailyScheduledTask { @Override @Scheduled(cron = "0 0 0 * * *") @SchedulerLock(name = "AutomaticPermanentBlocksCleanup") public void run() { final LocalDate eventRemoveDate = dateTimeProvider.getCurrentDate().minusMonths(3); LOGGER.debug("Removing block events before {}", eventRemoveDate); accessControlListDao.removeBlockEventsBefore(eventRemoveDate); final LocalDate blockRemoveDate = dateTimeProvider.getCurrentDate().minusYears(1); LOGGER.debug("Removing permanent bans before {}", blockRemoveDate); accessControlListDao.removePermanentBlocksBefore(blockRemoveDate); } @Autowired AutomaticPermanentBlocksCleanup(final DateTimeProvider dateTimeProvider, final AccessControlListDao accessControlListDao); @Override @Scheduled(cron = "0 0 0 * * *") @SchedulerLock(name = "AutomaticPermanentBlocksCleanup") void run(); } | @Test public void run() { final LocalDate now = LocalDate.now(); when(dateTimeProvider.getCurrentDate()).thenReturn(now); subject.run(); verify(accessControlListDao, times(1)).removePermanentBlocksBefore(argThat(new BaseMatcher<LocalDate>() { @Override public boolean matches(Object item) { return item.equals(now.minusYears(1)); } @Override public void describeTo(Description description) { description.appendText("Should only delete bans older than 1 year"); } })); verify(accessControlListDao, times(1)).removeBlockEventsBefore(argThat(new BaseMatcher<LocalDate>() { @Override public boolean matches(Object item) { return item.equals(now.minusMonths(3)); } @Override public void describeTo(Description description) { description.appendText("Should only delete events older than 3 months"); } })); } |
SsoTranslator { public RpslObject translateFromCacheAuthToUuid(final UpdateContext updateContext, final RpslObject rpslObject) { return translateAuthFromCache(updateContext, rpslObject); } @Autowired SsoTranslator(final CrowdClient crowdClient); void populateCacheAuthToUsername(final UpdateContext updateContext, final RpslObject rpslObject); void populateCacheAuthToUuid(final UpdateContext updateContext, final Update update); RpslObject translateFromCacheAuthToUuid(final UpdateContext updateContext, final RpslObject rpslObject); RpslObject translateFromCacheAuthToUsername(final UpdateContext updateContext, final RpslObject rpslObject); } | @Test public void translate_to_uuid_username_not_stored_in_context() { final RpslObject object = RpslObject.parse("mntner: TEST-MNT\nauth: SSO [email protected]"); when(updateContext.getSsoTranslationResult("[email protected]")).thenReturn("BBBB-1234-CCCC-DDDD"); final RpslObject result = subject.translateFromCacheAuthToUuid(updateContext, object); assertThat(result, is(RpslObject.parse("mntner: TEST-MNT\nauth: SSO BBBB-1234-CCCC-DDDD"))); verify(updateContext).getSsoTranslationResult("[email protected]"); }
@Test public void translate_to_username_uuid_stored_in_context_already() { final RpslObject object = RpslObject.parse("mntner: TEST-MNT\nauth: SSO aadd-2132-aaa-fff"); when(updateContext.getSsoTranslationResult("aadd-2132-aaa-fff")).thenReturn("[email protected]"); final RpslObject result = subject.translateFromCacheAuthToUuid(updateContext, object); assertThat(result, is(RpslObject.parse("mntner: TEST-MNT\nauth: SSO [email protected]"))); }
@Test public void translate_not_a_maintainer() { final RpslObject object = RpslObject.parse("person: test person\nnic-hdl: test-nic"); final RpslObject result = subject.translateFromCacheAuthToUuid(updateContext, object); verifyZeroInteractions(updateContext); assertThat(result, is(object)); } |
SsoTranslator { public void populateCacheAuthToUuid(final UpdateContext updateContext, final Update update) { final RpslObject submittedObject = update.getSubmittedObject(); SsoHelper.translateAuth(submittedObject, new AuthTranslator() { @Override @CheckForNull public RpslAttribute translate(final String authType, final String authToken, final RpslAttribute originalAttribute) { if (authType.equals("SSO")) { if (!updateContext.hasSsoTranslationResult(authToken)) { try { final String uuid = crowdClient.getUuid(authToken); updateContext.addSsoTranslationResult(authToken, uuid); } catch (CrowdClientException e) { updateContext.addMessage(update, originalAttribute, UpdateMessages.ripeAccessAccountUnavailable(authToken)); } } } return null; } }); } @Autowired SsoTranslator(final CrowdClient crowdClient); void populateCacheAuthToUsername(final UpdateContext updateContext, final RpslObject rpslObject); void populateCacheAuthToUuid(final UpdateContext updateContext, final Update update); RpslObject translateFromCacheAuthToUuid(final UpdateContext updateContext, final RpslObject rpslObject); RpslObject translateFromCacheAuthToUsername(final UpdateContext updateContext, final RpslObject rpslObject); } | @Test public void populate_not_maintainer_object() { final RpslObject object = RpslObject.parse("aut-num: AS1234"); when(update.getSubmittedObject()).thenReturn(object); subject.populateCacheAuthToUuid(updateContext, update); verifyZeroInteractions(updateContext); }
@Test public void populate_no_sso_auth() { final RpslObject object = RpslObject.parse("mntner: TEST-MNT\nauth: MD5-PW aaff1232431"); when(update.getSubmittedObject()).thenReturn(object); subject.populateCacheAuthToUuid(updateContext, update); verifyZeroInteractions(updateContext); }
@Test public void populate_sso_auth() { final RpslObject object = RpslObject.parse("mntner: TEST-MNT\nauth: SSO [email protected]"); when(update.getSubmittedObject()).thenReturn(object); when(updateContext.hasSsoTranslationResult("[email protected]")).thenReturn(true); subject.populateCacheAuthToUuid(updateContext, update); verify(updateContext, times(0)).addSsoTranslationResult(eq("[email protected]"), anyString()); } |
MntRoutesAttributeTransformer implements Transformer { public RpslObject transform(final RpslObject rpslObject, final Update update, final UpdateContext updateContext, final Action action) { if ((rpslObject.getType() != ObjectType.AUT_NUM) || !rpslObject.containsAttribute(AttributeType.MNT_ROUTES)) { return rpslObject; } updateContext.addMessage(update, UpdateMessages.mntRoutesAttributeRemoved()); return new RpslObjectBuilder(rpslObject).removeAttributeType(AttributeType.MNT_ROUTES).get(); } RpslObject transform(final RpslObject rpslObject,
final Update update,
final UpdateContext updateContext,
final Action action); } | @Test public void filter_mnt_routes_from_autnum() { final RpslObject autnum = RpslObject.parse( "aut-num: AS3333\n" + "as-name: TEST-AS\n" + "org: ORG-TEST1-TEST\n" + " # Transit:\n" + "import: from AS3333 action pref=700; accept ANY # preserve \n" + "export: to AS3333 announce AS3333:AS-TEST # formatting \n" + "admin-c: AA1-TEST\n" + "tech-c: AA1-TEST\n" + "status: ASSIGNED\n" + "mnt-by: RIPE-NCC-END-MNT\n" + "mnt-by: OWNER-MNT\n" + "mnt-routes: ANOTHER-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2018-7-25T09:01:00Z\n" + "source: TEST"); final RpslObject updatedAutnum = subject.transform(autnum, update, updateContext, Action.MODIFY); assertThat(updatedAutnum.containsAttribute(AttributeType.MNT_ROUTES), is(false)); assertThat(diff(autnum, updatedAutnum), is( "@@ -11,3 +11,2 @@\n" + " mnt-by: OWNER-MNT\n" + "-mnt-routes: ANOTHER-MNT\n" + " created: 1970-01-01T00:00:00Z\n")); verifyMessageAdded(); }
@Test public void no_mnt_routes_in_autnum() { final RpslObject autnum = RpslObject.parse( "aut-num: AS3333\n" + "as-name: TEST-AS\n" + "org: ORG-TEST1-TEST\n" + " # Transit:\n" + "import: from AS3333 action pref=700; accept ANY\n" + "export: to AS3333 announce AS3333:AS-TEST\n" + "admin-c: AA1-TEST\n" + "tech-c: AA1-TEST\n" + "status: ASSIGNED\n" + "mnt-by: RIPE-NCC-END-MNT\n" + "mnt-by: OWNER-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2018-7-25T09:01:00Z\n" + "source: TEST"); final RpslObject updatedAutnum = subject.transform(autnum, update, updateContext, Action.MODIFY); assertThat(updatedAutnum.containsAttribute(AttributeType.MNT_ROUTES), is(false)); assertThat(diff(autnum, updatedAutnum), isEmptyString()); verifyMessageNotAdded(); }
@Test public void dont_filter_mnt_routes_from_inetnum() { final RpslObject inetnum = RpslObject.parse( "inetnum: 192.0.0.0 - 192.255.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED UNSPECIFIED\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-lower: LIR-MNT\n" + "mnt-routes: LIR-MNT\n" + "source: TEST\n"); final RpslObject updatedInetnum = subject.transform(inetnum, update, updateContext, Action.MODIFY); assertThat(updatedInetnum.containsAttribute(AttributeType.MNT_ROUTES), is(true)); assertThat(diff(inetnum, updatedInetnum), isEmptyString()); verifyMessageNotAdded(); } |
ShortFormatTransformer implements Transformer { @Override public RpslObject transform(final RpslObject rpslObject, final Update update, final UpdateContext updateContext, final Action action) { final RpslObjectBuilder builder = new RpslObjectBuilder(rpslObject); boolean updated = false; final ListIterator<RpslAttribute> iterator = builder.getAttributes().listIterator(); while (iterator.hasNext()) { final RpslAttribute rpslAttribute = iterator.next(); if (rpslAttribute.getType() != null && !rpslAttribute.getType().getName().equals(rpslAttribute.getKey())) { iterator.set(new RpslAttribute(rpslAttribute.getType(), rpslAttribute.getValue())); updated = true; } } if (updated) { updateContext.addMessage(update, UpdateMessages.shortFormatAttributeReplaced()); return builder.get(); } return rpslObject; } @Override RpslObject transform(final RpslObject rpslObject, final Update update, final UpdateContext updateContext, final Action action); } | @Test public void dont_transform_no_short_format_attributes() { final RpslObject mntner = RpslObject.parse( "mntner: MINE-MNT\n" + "admin-c: AA1-TEST\n" + "auth: MD5-PW $1$/7f2XnzQ$p5ddbI7SXq4z4yNrObFS/0 # emptypassword\n" + "mnt-by: MINE-MNT\n" + "source: TEST\n"); final RpslObject updatedObject = subject.transform(mntner, update, updateContext, Action.MODIFY); assertThat(updatedObject, is(mntner)); verifyNoMoreInteractions(update); verifyNoMoreInteractions(updateContext); }
@Test public void transform_short_format_attributes() { final RpslObject mntner = RpslObject.parse( "mntner: MINE-MNT\n" + "admin-c: AA1-TEST\n" + "auth: MD5-PW $1$/7f2XnzQ$p5ddbI7SXq4z4yNrObFS/0 # emptypassword\n" + "mb: MINE-MNT # mb\n" + "*mb: MINE-MNT # star mb\n" + "mnt-by: MINE-MNT\n" + "source: TEST\n"); final RpslObject updatedObject = subject.transform(mntner, update, updateContext, Action.MODIFY); assertThat(updatedObject.toString(), is( "mntner: MINE-MNT\n" + "admin-c: AA1-TEST\n" + "auth: MD5-PW $1$/7f2XnzQ$p5ddbI7SXq4z4yNrObFS/0 # emptypassword\n" + "mnt-by: MINE-MNT # mb\n" + "mnt-by: MINE-MNT # star mb\n" + "mnt-by: MINE-MNT\n" + "source: TEST\n")); verify(updateContext).addMessage(update, UpdateMessages.shortFormatAttributeReplaced()); verifyNoMoreInteractions(update); verifyNoMoreInteractions(updateContext); } |
AttributeSanitizer { public RpslObject sanitize(final RpslObject object, final ObjectMessages objectMessages) { final Map<RpslAttribute, RpslAttribute> replacements = Maps.newHashMap(); for (final RpslAttribute attribute : object.getAttributes()) { final AttributeType type = attribute.getType(); String newValue = null; final Sanitizer sanitizer = SANITIZER_MAP.get(type); if (sanitizer == null) { continue; } try { newValue = sanitizer.sanitize(attribute); } catch (IllegalArgumentException ignored) { LOGGER.debug("{}: {}", ignored.getClass().getName(), ignored.getMessage()); } if (newValue == null) { continue; } final List<Message> attributeMessages = Lists.newArrayList(); if (!sanitizer.silent() && !attribute.getCleanValue().toString().equals(newValue)) { attributeMessages.add(ValidationMessages.attributeValueConverted(attribute.getCleanValue(), newValue)); } if (keyAttributes.contains(type) && attribute.getValue().indexOf('\n') != -1) { attributeMessages.add(ValidationMessages.continuationLinesRemoved()); } if (keyAttributes.contains(type) && attribute.getValue().indexOf('#') != -1) { attributeMessages.add(ValidationMessages.remarksReformatted()); } final String replacement = newValue + getCommentReplacement(attribute); final RpslAttribute transformed = new RpslAttribute(attribute.getKey(), replacement); replacements.put(attribute, transformed); for (final Message attributeMessage : attributeMessages) { objectMessages.addMessage(transformed, attributeMessage); } } return new RpslObjectBuilder(object).replaceAttributes(replacements).get(); } @Autowired AttributeSanitizer(DateTimeProvider dateTimeProvider); CIString sanitizeKey(final RpslObject originalObject); RpslObject sanitize(final RpslObject object, final ObjectMessages objectMessages); } | @Test public void transform_inetnum_prefix() { final RpslObject rpslObject = RpslObject.parse("inetnum: 193/8"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INETNUM).toString(), is("193.0.0.0 - 193.255.255.255")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("193/8", "193.0.0.0 - 193.255.255.255")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inetnum_prefix_with_comment() { final RpslObject rpslObject = RpslObject.parse("inetnum: 193/8 # Comment"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.toString(), is("inetnum: 193.0.0.0 - 193.255.255.255 # Comment\n")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("193/8", "193.0.0.0 - 193.255.255.255")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.remarksReformatted()); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inet6num_no_change() { final RpslObject rpslObject = RpslObject.parse("inet6num: 2001:67c:20c4::/48"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET6NUM).toString(), is("2001:67c:20c4::/48")); verifyZeroInteractions(objectMessages); }
@Test public void transform_inet6num_leading_zeroes() { final RpslObject rpslObject = RpslObject.parse("inet6num: 2001:067c:20c4::/48"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET6NUM).toString(), is("2001:67c:20c4::/48")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("2001:067c:20c4::/48", "2001:67c:20c4::/48")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inet6num_uppercase() { final RpslObject rpslObject = RpslObject.parse("inet6num: 2001:67C:20C4::/48"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET6NUM).toString(), is("2001:67c:20c4::/48")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("2001:67C:20C4::/48", "2001:67c:20c4::/48")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inet6num_trailing_zero() { final RpslObject rpslObject = RpslObject.parse("inet6num: 2001:67c:20c4::0/48"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET6NUM).toString(), is("2001:67c:20c4::/48")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("2001:67c:20c4::0/48", "2001:67c:20c4::/48")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inet6num_prefix_with_comment() { final RpslObject rpslObject = RpslObject.parse("inet6num: 2001:67c:20c4::0/48 # Comment"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.toString(), is("inet6num: 2001:67c:20c4::/48 # Comment\n")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("2001:67c:20c4::0/48", "2001:67c:20c4::/48")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.remarksReformatted()); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inet6num_change() { final RpslObject rpslObject = RpslObject.parse("inet6num: 2001::/8"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET6NUM).toString(), is("2000::/8")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("2001::/8", "2000::/8")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_nserver_no_not() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "nserver: hostname.nu\n"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.NSERVER).toString(), is("hostname.nu")); verifyZeroInteractions(objectMessages); }
@Test public void transform_nserver_with_dot() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "nserver: hostname.nu.\n"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.NSERVER).toString(), is("hostname.nu")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.NSERVER), ValidationMessages.attributeValueConverted("hostname.nu.", "hostname.nu")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_nserver_glue_ipv4() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "nserver: hostname.nu 10.0.0.0\n"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.NSERVER).toString(), is("hostname.nu 10.0.0.0")); verifyZeroInteractions(objectMessages); }
@Test public void transform_nserver_glue_ipv4_prefix() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "nserver: hostname.nu 10.0.0.0/32\n"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.NSERVER).toString(), is("hostname.nu 10.0.0.0")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.NSERVER), ValidationMessages.attributeValueConverted("hostname.nu 10.0.0.0/32", "hostname.nu 10.0.0.0")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_nserver_glue_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "nserver: hostname.nu FFAA::0\n"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.NSERVER).toString(), is("hostname.nu ffaa::")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.NSERVER), ValidationMessages.attributeValueConverted("hostname.nu FFAA::0", "hostname.nu ffaa::")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_route_no_change() { final RpslObject rpslObject = RpslObject.parse("" + "route: 212.166.64.0/19\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE).toString(), is("212.166.64.0/19")); verifyZeroInteractions(objectMessages); }
@Test public void transform_route_leading_zeroes() { final RpslObject rpslObject = RpslObject.parse("" + "route: 212.166.064.000/19\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE).toString(), is("212.166.64.0/19")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("212.166.064.000/19", "212.166.64.0/19")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_route_short_prefix() { final RpslObject rpslObject = RpslObject.parse("" + "route: 15/8\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE).toString(), is("15.0.0.0/8")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("15/8", "15.0.0.0/8")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_route6_no_change() { final RpslObject rpslObject = RpslObject.parse("" + "route6: 2001:1578:200::/40\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE6).toString(), is("2001:1578:200::/40")); verifyZeroInteractions(objectMessages); }
@Test public void transform_route6_leading_zeroes() { final RpslObject rpslObject = RpslObject.parse("" + "route6: 2001:1578:0200::/40\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE6).toString(), is("2001:1578:200::/40")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.ROUTE6), ValidationMessages.attributeValueConverted("2001:1578:0200::/40", "2001:1578:200::/40")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_route6_trailing_zero() { final RpslObject rpslObject = RpslObject.parse("" + "route6: 2001:1578:200::0/40\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE6).toString(), is("2001:1578:200::/40")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.ROUTE6), ValidationMessages.attributeValueConverted("2001:1578:200::0/40", "2001:1578:200::/40")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_route6_uppercase() { final RpslObject rpslObject = RpslObject.parse("" + "route6: 2001:6F8::/32\n" + "origin: AS12321"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ROUTE6).toString(), is("2001:6f8::/32")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.ROUTE6), ValidationMessages.attributeValueConverted("2001:6F8::/32", "2001:6f8::/32")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_alias_no_dot() { final RpslObject rpslObject = RpslObject.parse("" + "inet-rtr: test.ripe.net\n" + "alias: alias.ripe.net"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ALIAS).toString(), is("alias.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_alias_with_trailing_dot() { final RpslObject rpslObject = RpslObject.parse("" + "inet-rtr: test.ripe.net\n" + "alias: alias.ripe.net."); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.ALIAS).toString(), is("alias.ripe.net")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.ALIAS), ValidationMessages.attributeValueConverted("alias.ripe.net.", "alias.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inetrtr_no_dot() { final RpslObject rpslObject = RpslObject.parse("" + "inet-rtr: test.ripe.net\n" + "alias: alias.ripe.net"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET_RTR).toString(), is("test.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inetrtr_with_trailing_dot() { final RpslObject rpslObject = RpslObject.parse("" + "inet-rtr: test.ripe.net.\n" + "alias: alias.ripe.net"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INET_RTR).toString(), is("test.ripe.net")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.INET_RTR), ValidationMessages.attributeValueConverted("test.ripe.net.", "test.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_invalid() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum: test.ripe.net"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INETNUM).toString(), is("test.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_changed() { when(dateTimeProvider.getCurrentDate()).thenReturn(LocalDate.of(2013, 02, 25)); final RpslObject rpslObject = RpslObject.parse("inet6num: 2001::/16\n" + "changed: [email protected] 20120601\n" + "changed: [email protected]\n" + "remarks: changed"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); final List<RpslAttribute> changed = result.findAttributes(AttributeType.CHANGED); assertThat(changed.get(0).getCleanValue().toString(), is("[email protected] 20120601")); assertThat(changed.get(1).getCleanValue().toString(), is("[email protected] 20130225")); verifyZeroInteractions(objectMessages); }
@Test public void transform_type_and_key() { final RpslObject rpslObject = RpslObject.parse("" + "person: some # with\n" + "+ person\n" + "+ # remark\n" + "nic-hdl: TEST-PN\n" + "+ # another\n" + "+ #\n" + "+ # remark\n"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.findAttribute(AttributeType.PERSON).getValue(), is("some person # with remark")); assertThat(result.findAttribute(AttributeType.NIC_HDL).getValue(), is("TEST-PN # another remark")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.continuationLinesRemoved()); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.remarksReformatted()); verify(objectMessages).addMessage(result.findAttribute(AttributeType.NIC_HDL), ValidationMessages.continuationLinesRemoved()); verify(objectMessages).addMessage(result.findAttribute(AttributeType.NIC_HDL), ValidationMessages.remarksReformatted()); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_source_to_upper() { final RpslObject rpslObject = RpslObject.parse("person: Person A\nnic-hdl: tst-test\nsource: Test"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.findAttribute(AttributeType.SOURCE).getValue(), is("TEST")); }
@Test public void transform_domain_no_dot() { final RpslObject rpslObject = RpslObject.parse("domain: 17.45.212.in-addr.arpa"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getKey().toString(), is("17.45.212.in-addr.arpa")); assertThat(result.getValueForAttribute(AttributeType.DOMAIN).toString(), is("17.45.212.in-addr.arpa")); verifyZeroInteractions(objectMessages); }
@Test public void transform_domain_with_trailing_dot() { final RpslObject rpslObject = RpslObject.parse("domain: 17.45.212.in-addr.arpa."); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getKey().toString(), is("17.45.212.in-addr.arpa")); assertThat(result.getValueForAttribute(AttributeType.DOMAIN).toString(), is("17.45.212.in-addr.arpa")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("17.45.212.in-addr.arpa.", "17.45.212.in-addr.arpa")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_ds_rdata_no_change() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "ds-rdata: 52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.DS_RDATA).toString(), is("52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verifyZeroInteractions(objectMessages); }
@Test public void transform_ds_rdata_remove_spaces() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "ds-rdata: 52314 5 1 93B5837D4E5C063 A3728FAA72BA64 068F89B39DF"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.DS_RDATA).toString(), is("52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.DS_RDATA), ValidationMessages.attributeValueConverted("52314 5 1 93B5837D4E5C063 A3728FAA72BA64 068F89B39DF", "52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_ds_rdata_remove_parentheses() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "ds-rdata: 52314 5 1 ( 93B5837D4E5C063A3728FAA72BA64068F89B39DF )"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.DS_RDATA).toString(), is("52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.DS_RDATA), ValidationMessages.attributeValueConverted("52314 5 1 ( 93B5837D4E5C063A3728FAA72BA64068F89B39DF )", "52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_ds_rdata_remove_spaces_and_parentheses() { final RpslObject rpslObject = RpslObject.parse("" + "domain: 17.45.212.in-addr.arpa\n" + "ds-rdata: 52314 5 1 ( 93B5837D4E5C063 A3728FAA72BA64 068F89B39DF )"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.DS_RDATA).toString(), is("52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verify(objectMessages).addMessage(result.findAttribute(AttributeType.DS_RDATA), ValidationMessages.attributeValueConverted("52314 5 1 ( 93B5837D4E5C063 A3728FAA72BA64 068F89B39DF )", "52314 5 1 93B5837D4E5C063A3728FAA72BA64068F89B39DF")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_person() { final RpslObject rpslObject = RpslObject.parse("" + "person: Test Person\n" + "nic-hdl: TP1-RIPE"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result, is(rpslObject)); verifyZeroInteractions(objectMessages); }
@Test public void transform_inetnum_no_change() { final RpslObject rpslObject = RpslObject.parse("inetnum: 193.0.0.0 - 193.255.255.255"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result, is(rpslObject)); verifyZeroInteractions(objectMessages); }
@Test public void transform_inetnum_leading_zeroes() { final RpslObject rpslObject = RpslObject.parse("inetnum: 010.0.0.01 - 193.255.255.098"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INETNUM).toString(), is("10.0.0.1 - 193.255.255.98")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("010.0.0.01 - 193.255.255.098", "10.0.0.1 - 193.255.255.98")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_inetnum_change() { final RpslObject rpslObject = RpslObject.parse("inetnum: 192.0.0.0/4"); final RpslObject result = attributeSanitizer.sanitize(rpslObject, objectMessages); assertThat(result.getValueForAttribute(AttributeType.INETNUM).toString(), is("192.0.0.0 - 207.255.255.255")); verify(objectMessages).addMessage(result.getTypeAttribute(), ValidationMessages.attributeValueConverted("192.0.0.0/4", "192.0.0.0 - 207.255.255.255")); verifyNoMoreInteractions(objectMessages); } |
ResponseFactory { public String createExceptionResponse(final UpdateContext updateContext, final Origin origin) { final VelocityContext velocityContext = new VelocityContext(); return createResponse(TEMPLATE_EXCEPTION, updateContext, velocityContext, origin); } @Autowired ResponseFactory(
final DateTimeProvider dateTimeProvider,
final ApplicationVersion applicationVersion,
@Value("${whois.source}") final String source); String createExceptionResponse(final UpdateContext updateContext, final Origin origin); String createAckResponse(final UpdateContext updateContext, final Origin origin, final Ack ack); String createHelpResponse(final UpdateContext updateContext, final Origin origin); ResponseMessage createNotification(final UpdateContext updateContext, final Origin origin, final Notification notification); } | @Test public void getException() { final String response = subject.createExceptionResponse(updateContext, origin); assertThat(response, containsString("" + "> From: Andre Kampert <[email protected]>\n" + "> Subject: delete route 194.39.132.0/24\n" + "> Date: Thu, 14 Jun 2012 10:04:42 +0200\n" + "> Reply-To: [email protected]\n" + "> Message-ID: <[email protected]>\n" + "\n" + "Internal software error\n" + "\n" + "\n" + "The RIPE Database is subject to Terms and Conditions:\n" + "http: "\n" + "For assistance or clarification please contact:\n" + "RIPE Database Administration <[email protected]>\n")); assertVersion(response); } |
ResponseFactory { public String createAckResponse(final UpdateContext updateContext, final Origin origin, final Ack ack) { final VelocityContext velocityContext = new VelocityContext(); velocityContext.put("ack", ack); velocityContext.put("updateContext", updateContext); return createResponse(TEMPLATE_ACK, updateContext, velocityContext, origin); } @Autowired ResponseFactory(
final DateTimeProvider dateTimeProvider,
final ApplicationVersion applicationVersion,
@Value("${whois.source}") final String source); String createExceptionResponse(final UpdateContext updateContext, final Origin origin); String createAckResponse(final UpdateContext updateContext, final Origin origin, final Ack ack); String createHelpResponse(final UpdateContext updateContext, final Origin origin); ResponseMessage createNotification(final UpdateContext updateContext, final Origin origin, final Notification notification); } | @Test public void getAck_no_errors() { final RpslObject rpslObject = RpslObject.parse("mntner: DEV-ROOT-MNT"); updateResults.add(new UpdateResult(rpslObject, rpslObject, Action.DELETE, UpdateStatus.SUCCESS, new ObjectMessages(), 0, false)); final Ack ack = new Ack(updateResults, ignoredParagraphs); final String response = subject.createAckResponse(updateContext, origin, ack); assertThat(response, containsString("Number of objects found: 1")); assertThat(response, containsString("Number of objects processed successfully: 1")); assertThat(response, containsString("Delete: 1")); assertThat(response, containsString("Number of objects processed with errors: 0")); assertThat(response, containsString("Delete: 0")); assertThat(response, not(containsString(WARNING))); assertThat(response, not(containsString(ERROR))); assertThat(response, not(containsString(SKIPPED_PARAGRAPH))); assertThat(response, containsString("" + "> From: Andre Kampert <[email protected]>\n" + "> Subject: delete route 194.39.132.0/24\n" + "> Date: Thu, 14 Jun 2012 10:04:42 +0200\n" + "> Reply-To: [email protected]\n" + "> Message-ID: <[email protected]>\n" + "\n" + "SUMMARY OF UPDATE:\n" + "\n" + "Number of objects found: 1\n" + "Number of objects processed successfully: 1\n" + " Create: 0\n" + " Modify: 0\n" + " Delete: 1\n" + " No Operation: 0\n" + "Number of objects processed with errors: 0\n" + " Create: 0\n" + " Modify: 0\n" + " Delete: 0\n" + "\n" + "DETAILED EXPLANATION:\n" + "\n" + "\n" + "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" + "The following object(s) were processed SUCCESSFULLY:\n" + "\n" + "---\n" + "Delete SUCCEEDED: [mntner] DEV-ROOT-MNT\n" + "\n" + "\n" + "\n" + "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" + "\n" + "The RIPE Database is subject to Terms and Conditions:\n" + "http: "\n" + "For assistance or clarification please contact:\n" + "RIPE Database Administration <[email protected]>\n\n")); assertVersion(response); }
@Test public void getAck_skipped_paragraphs() { final Paragraph paragraph1 = new Paragraph("paragraph 1"); final Paragraph paragraph2 = new Paragraph("paragraph 2"); ignoredParagraphs.add(paragraph1); ignoredParagraphs.add(paragraph2); final Ack ack = new Ack(updateResults, ignoredParagraphs); final String response = subject.createAckResponse(updateContext, origin, ack); assertThat(response, containsString(SKIPPED_PARAGRAPH)); assertThat(response, containsString(paragraph1.getContent())); assertThat(response, containsString(paragraph2.getContent())); assertThat(response, containsString("" + "> From: Andre Kampert <[email protected]>\n" + "> Subject: delete route 194.39.132.0/24\n" + "> Date: Thu, 14 Jun 2012 10:04:42 +0200\n" + "> Reply-To: [email protected]\n" + "> Message-ID: <[email protected]>\n" + "\n" + "SUMMARY OF UPDATE:\n" + "\n" + "Number of objects found: 0\n" + "Number of objects processed successfully: 0\n" + " Create: 0\n" + " Modify: 0\n" + " Delete: 0\n" + " No Operation: 0\n" + "Number of objects processed with errors: 0\n" + " Create: 0\n" + " Modify: 0\n" + " Delete: 0\n" + "\n" + "DETAILED EXPLANATION:\n" + "\n" + "\n" + "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" + "The following paragraph(s) do not look like objects\n" + "and were NOT PROCESSED:\n" + "\n" + "paragraph 1\n" + "\n" + "paragraph 2\n" + "\n" + "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" + "\n" + "The RIPE Database is subject to Terms and Conditions:\n" + "http: "\n" + "For assistance or clarification please contact:\n" + "RIPE Database Administration <[email protected]>\n")); assertVersion(response); }
@Test public void getAck_errors() { final String rpslObjectString = "" + "route: 194.39.132.0/24\n" + "descr: Description\n" + "origin: AS1\n" + "notify: [email protected]\n" + "mnt-by: TEST-MNT\n" + "source: RIPE\n" + "delete: no longer required\n"; final RpslObject rpslObject = RpslObject.parse(rpslObjectString); final ObjectMessages objectMessages = new ObjectMessages(); objectMessages.addMessage(rpslObject.findAttribute(AttributeType.SOURCE), UpdateMessages.unrecognizedSource("RIPE")); updateResults.add(new UpdateResult(rpslObject, rpslObject, Action.DELETE, UpdateStatus.FAILED, objectMessages, 0, false)); final Ack ack = new Ack(updateResults, ignoredParagraphs); final String response = subject.createAckResponse(updateContext, origin, ack); assertThat(response, not(containsString(SKIPPED_PARAGRAPH))); assertThat(response, containsString(ERROR)); assertThat(response, containsString("" + "> From: Andre Kampert <[email protected]>\n" + "> Subject: delete route 194.39.132.0/24\n" + "> Date: Thu, 14 Jun 2012 10:04:42 +0200\n" + "> Reply-To: [email protected]\n" + "> Message-ID: <[email protected]>\n" + "\n" + "SUMMARY OF UPDATE:\n" + "\n" + "Number of objects found: 1\n" + "Number of objects processed successfully: 0\n" + " Create: 0\n" + " Modify: 0\n" + " Delete: 0\n" + " No Operation: 0\n" + "Number of objects processed with errors: 1\n" + " Create: 0\n" + " Modify: 0\n" + " Delete: 1\n" + "\n" + "DETAILED EXPLANATION:\n" + "\n" + "\n" + "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" + "The following object(s) were found to have ERRORS:\n" + "\n" + "---\n" + "Delete FAILED: [route] 194.39.132.0/24AS1\n" + "\n" + "route: 194.39.132.0/24\n" + "descr: Description\n" + "origin: AS1\n" + "notify: [email protected]\n" + "mnt-by: TEST-MNT\n" + "source: RIPE\n" + "***Error: Unrecognized source: RIPE\n" + "delete: no longer required\n" + "\n" + "\n" + "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n" + "\n" + "The RIPE Database is subject to Terms and Conditions:\n" + "http: "\n" + "For assistance or clarification please contact:\n" + "RIPE Database Administration <[email protected]>\n")); assertVersion(response); } |
ResponseFactory { public String createHelpResponse(final UpdateContext updateContext, final Origin origin) { final VelocityContext velocityContext = new VelocityContext(); return createResponse(TEMPLATE_HELP, updateContext, velocityContext, origin); } @Autowired ResponseFactory(
final DateTimeProvider dateTimeProvider,
final ApplicationVersion applicationVersion,
@Value("${whois.source}") final String source); String createExceptionResponse(final UpdateContext updateContext, final Origin origin); String createAckResponse(final UpdateContext updateContext, final Origin origin, final Ack ack); String createHelpResponse(final UpdateContext updateContext, final Origin origin); ResponseMessage createNotification(final UpdateContext updateContext, final Origin origin, final Notification notification); } | @Test public void createHelpResponse() { final String response = subject.createHelpResponse(updateContext, origin); assertThat(response, containsString("" + "> From: Andre Kampert <[email protected]>\n" + "> Subject: delete route 194.39.132.0/24\n" + "> Date: Thu, 14 Jun 2012 10:04:42 +0200\n" + "> Reply-To: [email protected]\n" + "> Message-ID: <[email protected]>\n" + "\n" + "You have requested Help information from the RIPE NCC Database,\n" + "therefore the body of your message has been ignored.\n" + "\n" + "RIPE Database documentation is available at\n" + "\n" + "http: "\n" + "RIPE Database FAQ is available at\n" + "\n" + "http: "\n" + "RPSL RFCs are available at\n" + "\n" + "ftp: "ftp: "ftp: "\n" + "The RIPE Database is subject to Terms and Conditions:\n" + "http: "\n" + "For assistance or clarification please contact:\n" + "RIPE Database Administration <[email protected]>\n")); assertVersion(response); } |
ResponseFactory { public ResponseMessage createNotification(final UpdateContext updateContext, final Origin origin, final Notification notification) { final String ssoUserEmail = updateContext.getUserSession() != null ? updateContext.getUserSession().getUsername() : ""; final VelocityContext velocityContext = new VelocityContext(); velocityContext.put("failedAuthentication", notification.getUpdates(Notification.Type.FAILED_AUTHENTICATION)); velocityContext.put("success", notification.getUpdates(Notification.Type.SUCCESS)); velocityContext.put("successReference", notification.getUpdates(Notification.Type.SUCCESS_REFERENCE)); velocityContext.put("ssoUser", ssoUserEmail); final String subject; if (notification.has(Notification.Type.FAILED_AUTHENTICATION)) { subject = "RIPE Database updates, auth error notification"; } else { subject = "Notification of RIPE Database changes"; } return new ResponseMessage(subject, createResponse(TEMPLATE_NOTIFICATION, updateContext, velocityContext, origin), ssoUserEmail); } @Autowired ResponseFactory(
final DateTimeProvider dateTimeProvider,
final ApplicationVersion applicationVersion,
@Value("${whois.source}") final String source); String createExceptionResponse(final UpdateContext updateContext, final Origin origin); String createAckResponse(final UpdateContext updateContext, final Origin origin, final Ack ack); String createHelpResponse(final UpdateContext updateContext, final Origin origin); ResponseMessage createNotification(final UpdateContext updateContext, final Origin origin, final Notification notification); } | @Test public void notification_success() { final RpslObject object1 = RpslObject.parse("mntner: DEV-ROOT1-MNT"); final Update update1 = new Update(new Paragraph(object1.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object1); final PreparedUpdate create1 = new PreparedUpdate(update1, null, object1, Action.CREATE); final RpslObject object2 = RpslObject.parse("mntner: DEV-ROOT2-MNT"); final Update update2 = new Update(new Paragraph(object2.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object2); final PreparedUpdate create2 = new PreparedUpdate(update2, null, object2, Action.CREATE); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.SUCCESS, create1, updateContext); notification.add(Notification.Type.SUCCESS, create2, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getSubject(), is("Notification of RIPE Database changes")); assertThat(responseMessage.getMessage(), containsString("" + "Some object(s) in RIPE Database that you either\n" + "maintain or you are listed in as to-be-notified have\n" + "been added, deleted or changed.\n")); assertThat(responseMessage.getMessage(), containsString("" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-ROOT1-MNT\n" + "\n" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-ROOT2-MNT\n")); }
@Test public void notification_success_with_user_in_the_session() { when(updateContext.getUserSession()).thenReturn(new UserSession("[email protected]", "Test User", true,"2033-01-30T16:38:27.369+11:00")); final RpslObject object1 = RpslObject.parse("mntner: DEV-ROOT1-MNT"); final Update update1 = new Update(new Paragraph(object1.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object1); final PreparedUpdate create1 = new PreparedUpdate(update1, null, object1, Action.CREATE); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.SUCCESS, create1, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getMessage(), containsString("You can reply to this message to contact the person who made this change.\n")); }
@Test public void notification_success_with_effective_sso_credentials() { when(updateContext.getUserSession()).thenReturn(new UserSession("[email protected]", "Test User", true,"2033-01-30T16:38:27.369+11:00")); final RpslObject object1 = RpslObject.parse("mntner: DEV-ROOT1-MNT"); final Update update1 = new Update(new Paragraph(object1.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object1); final PreparedUpdate create1 = new PreparedUpdate(update1, null, object1, Action.CREATE); update1.setEffectiveCredential("[email protected]", Update.EffectiveCredentialType.SSO); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.SUCCESS, create1, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getMessage(), containsString("" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-ROOT1-MNT\n" + "\n" + "Changed by SSO account: [email protected]\n"+ "\n" )); }
@Test public void notification_success_with_effective_pgp_credentials() { final RpslObject object1 = RpslObject.parse("mntner: DEV-ROOT1-MNT"); final Update update1 = new Update(new Paragraph(object1.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object1); final PreparedUpdate create1 = new PreparedUpdate(update1, null, object1, Action.CREATE); update1.setEffectiveCredential("PGP-KEY-123", Update.EffectiveCredentialType.PGP); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.SUCCESS, create1, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getMessage(), containsString("" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-ROOT1-MNT\n" + "\n" + "Changed by PGP-KEY-123. You can find contact details for this key here:\n" + "https: "\n" )); }
@Test public void notification_success_filter_auth() { final RpslObject object = RpslObject.parse("" + "mntner: DEV-MNT\n" + "auth: MD5-PW $1$YmPozTxJ$s3eGZRVrKVGdSDTeEZJu "source: RIPE" ); final Update update = new Update(new Paragraph(object.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object); final PreparedUpdate create = new PreparedUpdate(update, null, object, Action.CREATE); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.SUCCESS, create, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getSubject(), is("Notification of RIPE Database changes")); assertThat(responseMessage.getMessage(), containsString("" + "Some object(s) in RIPE Database that you either\n" + "maintain or you are listed in as to-be-notified have\n" + "been added, deleted or changed.\n")); assertThat(responseMessage.getMessage(), containsString("" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-MNT\n" + "auth: MD5-PW # Filtered\n" + "source: RIPE # Filtered\n" + "")); }
@Test public void notification_success_reference() { final RpslObject object1 = RpslObject.parse("mntner: DEV-ROOT1-MNT"); final Update update1 = new Update(new Paragraph(object1.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object1); final PreparedUpdate create1 = new PreparedUpdate(update1, null, object1, Action.CREATE); final RpslObject object2 = RpslObject.parse("mntner: DEV-ROOT2-MNT"); final Update update2 = new Update(new Paragraph(object2.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object2); final PreparedUpdate create2 = new PreparedUpdate(update2, null, object2, Action.CREATE); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.SUCCESS_REFERENCE, create1, updateContext); notification.add(Notification.Type.SUCCESS_REFERENCE, create2, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getSubject(), is("Notification of RIPE Database changes")); assertThat(responseMessage.getMessage(), containsString("" + "Some object(s) in RIPE Database added references to\n" + "objects you are listed in as to-be-notified.")); assertThat(responseMessage.getMessage(), containsString("" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-ROOT1-MNT\n" + "\n" + "---\n" + "OBJECT BELOW CREATED:\n" + "\n" + "mntner: DEV-ROOT2-MNT")); }
@Test public void notification_auth_failed() { final RpslObject object1 = RpslObject.parse("mntner: DEV-ROOT1-MNT"); final Update update1 = new Update(new Paragraph(object1.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object1); final PreparedUpdate create1 = new PreparedUpdate(update1, null, object1, Action.CREATE); final RpslObject object2 = RpslObject.parse("mntner: DEV-ROOT2-MNT"); final Update update2 = new Update(new Paragraph(object2.toString()), Operation.UNSPECIFIED, Lists.<String>newArrayList(), object2); final PreparedUpdate create2 = new PreparedUpdate(update2, null, object2, Action.CREATE); final Notification notification = new Notification("[email protected]"); notification.add(Notification.Type.FAILED_AUTHENTICATION, create1, updateContext); notification.add(Notification.Type.FAILED_AUTHENTICATION, create2, updateContext); final ResponseMessage responseMessage = subject.createNotification(updateContext, origin, notification); assertNotification(responseMessage); assertThat(responseMessage.getSubject(), is("RIPE Database updates, auth error notification")); assertThat(responseMessage.getMessage(), containsString("" + "Some objects in which you are referenced as a\n" + "maintainer were requested to be changed, but *failed*\n" + "the proper authorisation for any of the referenced\n" + "maintainers.")); assertThat(responseMessage.getMessage(), containsString("" + "---\n" + "CREATE REQUESTED FOR:\n" + "\n" + "mntner: DEV-ROOT1-MNT\n" + "\n" + "---\n" + "CREATE REQUESTED FOR:\n" + "\n" + "mntner: DEV-ROOT2-MNT")); } |
SetNotReferencedValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired SetNotReferencedValidator(final RpslObjectDao objectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.DELETE)); } |
SetNotReferencedValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired SetNotReferencedValidator(final RpslObjectDao objectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.AS_SET, ObjectType.ROUTE_SET, ObjectType.RTR_SET)); } |
SetNotReferencedValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); final List<RpslObjectInfo> incomingReferences = objectDao.findMemberOfByObjectTypeWithoutMbrsByRef(updatedObject.getType(), updatedObject.getKey().toString()); if (!incomingReferences.isEmpty()) { updateContext.addMessage(update, UpdateMessages.objectInUse(updatedObject)); } } @Autowired SetNotReferencedValidator(final RpslObjectDao objectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void set_that_has_incoming_references() { final RpslObject routeSet = RpslObject.parse("route-set: rs-AH"); when(update.getUpdatedObject()).thenReturn(routeSet); when(objectDao.findMemberOfByObjectTypeWithoutMbrsByRef(ObjectType.ROUTE_SET, "rs-AH")).thenReturn(Lists.newArrayList(new RpslObjectInfo(1, ObjectType.ROUTE, "192.168.0.1/32"))); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.objectInUse(routeSet)); }
@Test public void set_that_has_no_incoming_references() { final RpslObject asSet = RpslObject.parse("as-set: AS1325:AS-lopp"); when(update.getUpdatedObject()).thenReturn(asSet); when(objectDao.findMemberOfByObjectTypeWithoutMbrsByRef(ObjectType.AS_SET, "rs-AH")).thenReturn(Lists.<RpslObjectInfo>newArrayList()); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.objectInUse(asSet)); } |
PeeringSetAttributeMustBePresent implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } PeeringSetAttributeMustBePresent(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
PeeringSetAttributeMustBePresent implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } PeeringSetAttributeMustBePresent(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetTypes() { assertThat(subject.getTypes(), Matchers.contains(ObjectType.PEERING_SET, ObjectType.FILTER_SET)); } |
PeeringSetAttributeMustBePresent implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); final ObjectType objectType = update.getType(); final List<AttributeType> attributeTypes = attributeMap.get(objectType); final AttributeType simpleAttribute = attributeTypes.get(0); final List<RpslAttribute> simpleAttributes = updatedObject.findAttributes(simpleAttribute); final AttributeType complexAttribute = attributeTypes.get(1); final List<RpslAttribute> extendedAttributes = updatedObject.findAttributes(complexAttribute); if (simpleAttributes.isEmpty() && extendedAttributes.isEmpty()) { updateContext.addMessage(update, UpdateMessages.neitherSimpleOrComplex(objectType, simpleAttribute.getName(), complexAttribute.getName())); } if (!simpleAttributes.isEmpty() && !extendedAttributes.isEmpty()) { updateContext.addMessage(update, UpdateMessages.eitherSimpleOrComplex(objectType, simpleAttribute.getName(), complexAttribute.getName())); } } PeeringSetAttributeMustBePresent(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void mpPeering_and_peering_present() { when(update.getType()).thenReturn(ObjectType.PEERING_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("peering-set: prng-ripe\ndescr: description\npeering: AS6845 at 194.102.255.254\nmp-peering: AS702:PRNG-AT-CUSTOMER")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.eitherSimpleOrComplex(ObjectType.PEERING_SET, "peering", "mp-peering")); }
@Test public void mpPeering_nor_peering_present() { when(update.getType()).thenReturn(ObjectType.PEERING_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("peering-set: prng-ripe\ndescr: description")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.neitherSimpleOrComplex(ObjectType.PEERING_SET, "peering", "mp-peering")); }
@Test public void only_mpPeering_present() { when(update.getType()).thenReturn(ObjectType.PEERING_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("peering-set: prng-ripe\ndescr: description\nmp-peering: AS702:PRNG-AT-CUSTOMER")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.eitherSimpleOrComplex(ObjectType.PEERING_SET, "peering", "mp-peering")); verify(updateContext, never()).addMessage(update, UpdateMessages.neitherSimpleOrComplex(ObjectType.PEERING_SET, "peering", "mp-peering")); }
@Test public void only_peering_present() { when(update.getType()).thenReturn(ObjectType.PEERING_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("peering-set: prng-ripe\ndescr: description\npeering: AS6845 at 194.102.255.254")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.eitherSimpleOrComplex(ObjectType.PEERING_SET, "peering", "mp-peering")); verify(updateContext, never()).addMessage(update, UpdateMessages.neitherSimpleOrComplex(ObjectType.PEERING_SET, "peering", "mp-peering")); }
@Test public void filter_and_mpFilter_present() { when(update.getType()).thenReturn(ObjectType.FILTER_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("filter-set: prng-ripe\ndescr: description\nfilter: AS6845 at 194.102.255.254\nmp-filter: AS702:PRNG-AT-CUSTOMER")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.eitherSimpleOrComplex(ObjectType.FILTER_SET, "filter", "mp-filter")); }
@Test public void mpFilter_nor_filter_present() { when(update.getType()).thenReturn(ObjectType.FILTER_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("filter-set: prng-ripe\ndescr: description")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.neitherSimpleOrComplex(ObjectType.FILTER_SET, "filter", "mp-filter")); }
@Test public void only_mpFilter_present() { when(update.getType()).thenReturn(ObjectType.FILTER_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("filter-set: prng-ripe\ndescr: description\nmp-filter: AS702:PRNG-AT-CUSTOMER")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.eitherSimpleOrComplex(ObjectType.FILTER_SET, "filter", "mp-filter")); verify(updateContext, never()).addMessage(update, UpdateMessages.neitherSimpleOrComplex(ObjectType.FILTER_SET, "filter", "mp-filter")); }
@Test public void only_filter_present() { when(update.getType()).thenReturn(ObjectType.FILTER_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("filter-set: prng-ripe\ndescr: description\nfilter: AS6845 at 194.102.255.254")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.eitherSimpleOrComplex(ObjectType.FILTER_SET, "filter", "mp-filter")); verify(updateContext, never()).addMessage(update, UpdateMessages.neitherSimpleOrComplex(ObjectType.FILTER_SET, "filter", "mp-filter")); } |
SetnameMustExistValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired SetnameMustExistValidator(final RpslObjectDao objectDao,
final AuthenticationModule authenticationModule); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE)); } |
SetnameMustExistValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired SetnameMustExistValidator(final RpslObjectDao objectDao,
final AuthenticationModule authenticationModule); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.AS_SET, ObjectType.FILTER_SET, ObjectType.PEERING_SET, ObjectType.ROUTE_SET, ObjectType.RTR_SET)); } |
SetnameMustExistValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (updateContext.getSubject(update).hasPrincipal(Principal.OVERRIDE_MAINTAINER)) { return; } final String key = update.getUpdatedObject().getTypeAttribute().getCleanValue().toString(); final int lastColon = key.lastIndexOf(':'); if (lastColon < 0) { return; } final CIString parentKey = ciString(key.substring(0, lastColon)); final RpslObject parent = CollectionHelper.uniqueResult( objectDao.getByKeys(findObjectType(update.getType(), parentKey), Collections.singleton(parentKey))); if (parent == null) { updateContext.addMessage(update, UpdateMessages.parentObjectNotFound(parentKey)); return; } final List<RpslObject> referencedMaintainers = findMaintainers(parent); final List<RpslObject> authenticatedMaintainers = authenticationModule.authenticate(update, updateContext, referencedMaintainers); if (authenticatedMaintainers.isEmpty()) { updateContext.addMessage(update, UpdateMessages.parentAuthenticationFailed(parent, findAttributeType(parent), referencedMaintainers)); } } @Autowired SetnameMustExistValidator(final RpslObjectDao objectDao,
final AuthenticationModule authenticationModule); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_missing_parent() { when(update.getType()).thenReturn(ObjectType.FILTER_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("filter-set: FLTR-RIPE:FLTR-ALLOCBNDR:FLTR-IPV6:fltr-something")); when(objectDao.getByKeys(eq(ObjectType.FILTER_SET), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.parentObjectNotFound("FLTR-RIPE:FLTR-ALLOCBNDR:FLTR-IPV6")); }
@Test public void validate_no_hiearchy() { when(update.getType()).thenReturn(ObjectType.FILTER_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("filter-set: FLTR-ND")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void validate_autnum_lookup_does_not_exist() { when(update.getType()).thenReturn(ObjectType.AS_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-set: AS101:AS-TEST")); when(objectDao.getByKeys(eq(ObjectType.AUT_NUM), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.parentObjectNotFound("AS101")); }
@Test public void validate_autnum_lookup_does_not_exist_with_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.AS_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-set: AS101:AS-TEST")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void validate_autnum_lookup_exists_but_is_not_authenticated() { when(update.getType()).thenReturn(ObjectType.AS_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-set: AS101:AS-TEST")); when(objectDao.getByKeys(eq(ObjectType.AUT_NUM), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("aut-num: AS101"))); when(authenticationModule.authenticate(eq(update), eq(updateContext), anyList())).thenReturn(Lists.<RpslObject>newArrayList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.parentAuthenticationFailed(RpslObject.parse("aut-num: AS101"), AttributeType.MNT_BY, Lists.<RpslObject>newArrayList())); }
@Test public void validate_autnum_lookup_exists_and_is_authenticated() { when(update.getType()).thenReturn(ObjectType.AS_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-set: AS101:AS-TEST")); when(objectDao.getByKeys(eq(ObjectType.AUT_NUM), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("aut-num: AS101\nmnt-by: TEST-MNT"))); when(authenticationModule.authenticate(eq(update), eq(updateContext), anyList())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("mntner: TEST-MNT"))); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void validate_routeset_against_autnum() { when(update.getType()).thenReturn(ObjectType.ROUTE_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route-set: As101:RS-ROUTESET")); when(objectDao.getByKeys(eq(ObjectType.AUT_NUM), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("aut-num: AS101\nmnt-by: TEST-MNT"))); when(authenticationModule.authenticate(eq(update), eq(updateContext), anyList())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("mntner: TEST-MNT"))); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void validate_routeset_against_parent() { when(update.getType()).thenReturn(ObjectType.ROUTE_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route-set: RS-PARENT:RS-CHILD")); when(objectDao.getByKeys(eq(ObjectType.ROUTE_SET), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("route-set: RS-PARENT\nmnt-lower: TEST-MNT"))); when(authenticationModule.authenticate(eq(update), eq(updateContext), anyList())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("mntner: TEST-MNT"))); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void validate_routeset_against_parent_not_authenticated() { when(update.getType()).thenReturn(ObjectType.ROUTE_SET); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route-set: RS-PARENT:RS-CHILD")); when(objectDao.getByKeys(eq(ObjectType.ROUTE_SET), anyCollection())).thenReturn(Lists.<RpslObject>newArrayList(RpslObject.parse("route-set: RS-PARENT\nmnt-by: TEST-MNT"))); when(authenticationModule.authenticate(eq(update), eq(updateContext), anyList())).thenReturn(Lists.<RpslObject>newArrayList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.parentAuthenticationFailed(RpslObject.parse("route-set: RS-PARENT"), AttributeType.MNT_BY, Lists.<RpslObject>newArrayList())); } |
OrganisationTypeValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions().size(), is(2)); assertThat(subject.getActions().contains(Action.MODIFY), is(true)); assertThat(subject.getActions().contains(Action.CREATE), is(true)); } |
OrganisationTypeValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes().size(), is(1)); assertThat(subject.getTypes().get(0), is(ObjectType.ORGANISATION)); } |
OrganisationTypeValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)) { return; } final RpslAttribute orgTypeAttribute = update.getUpdatedObject().findAttribute(AttributeType.ORG_TYPE); final CIString orgType = orgTypeAttribute.getCleanValue(); if ((OrgType.OTHER != OrgType.getFor(orgType)) && orgTypeHasChanged(update) && !subject.hasPrincipal(Principal.ALLOC_MAINTAINER)) { updateContext.addMessage(update, orgTypeAttribute, UpdateMessages.invalidMaintainerForOrganisationType(orgType)); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void update_is_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(update); verifyNoMoreInteractions(updateContext); }
@Test public void status_other() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: other")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); }
@Test public void orgtype_has_not_changed() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: RIR")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); when(update.getReferenceObject()).thenReturn(RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: RIR")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); }
@Test public void not_auth_by_powermntner() { final RpslObject rpslObject = RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: RIR"); when(update.getUpdatedObject()).thenReturn(rpslObject); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); when(update.getReferenceObject()).thenReturn(RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: LIR")); when(update.getAction()).thenReturn(Action.MODIFY); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, rpslObject.findAttribute(AttributeType.ORG_TYPE), UpdateMessages.invalidMaintainerForOrganisationType("RIR")); }
@Test public void orgtype_has_changed_auth_by_powermntner() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: RIR")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); when(update.getReferenceObject()).thenReturn(RpslObject.parse("organisation: ORG-TST-RIPE\norg-type: LIR")); when(update.getAction()).thenReturn(Action.MODIFY); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); } |
OrgNameNotChangedValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired OrgNameNotChangedValidator(final RpslObjectUpdateDao objectUpdateDao, final RpslObjectDao objectDao, final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(Action.MODIFY)); } |
OrgNameNotChangedValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired OrgNameNotChangedValidator(final RpslObjectUpdateDao objectUpdateDao, final RpslObjectDao objectDao, final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), contains(ObjectType.ORGANISATION)); } |
OrgNameNotChangedValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject originalObject = update.getReferenceObject(); final RpslObject updatedObject = update.getUpdatedObject(); if (isLir(originalObject)) { return; } if (orgNameDidntChange(originalObject, updatedObject)) { return; } final Subject subject = updateContext.getSubject(update); if (alreadyHasAllPossibleAuthorisations(subject)) { return; } if (isReferencedByRsMaintainedResource(originalObject)) { final RpslAttribute orgNameAttribute = updatedObject.findAttribute(AttributeType.ORG_NAME); updateContext.addMessage(update, orgNameAttribute, UpdateMessages.cantChangeOrgName()); } } @Autowired OrgNameNotChangedValidator(final RpslObjectUpdateDao objectUpdateDao, final RpslObjectDao objectDao, final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void orgname_not_changed() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_SAME_NAME); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_not_referenced_at_all() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); when(updateDao.getReferences(ORIGINAL_ORG)).thenReturn(Collections.EMPTY_SET); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_for_lir() { presetOverrideAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_LIR); when(update.getUpdatedObject()).thenReturn(UPDATED_LIR); presetReferrers(REFERRER_MNT_BY_RS, REFERRER_MNT_BY_LEGACY); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_not_referenced_by_resource() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); when(updateDao.getReferences(ORIGINAL_ORG)).thenReturn(Sets.newHashSet(new RpslObjectInfo(5, ObjectType.PERSON, "TEST-NIC"))); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_without_RSmntner__no_RSmntner_auth() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_USER); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_RSmntner__no_RSmntner_auth() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); when(maintainers.isRsMaintainer(Sets.newHashSet(CIString.ciString("RIPE-NCC-HM-MNT")))).thenReturn(true); presetReferrers(REFERRER_MNT_BY_RS); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, UPDATED_ORG_NEW_NAME.findAttribute(AttributeType.ORG_NAME), UpdateMessages.cantChangeOrgName()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_LEGACY_mntner__no_LEGACY_mntner_auth() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); when(maintainers.isRsMaintainer(Sets.newHashSet(CIString.ciString("RIPE-NCC-LEGACY-MNT")))).thenReturn(true); presetReferrers(REFERRER_MNT_BY_LEGACY); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, UPDATED_ORG_NEW_NAME.findAttribute(AttributeType.ORG_NAME), UpdateMessages.cantChangeOrgName()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-LEGACY-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_RS_and_LEGACY_mntner__no_LEGACY_mntner_auth() { presetOverrideAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_RS, REFERRER_MNT_BY_LEGACY); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(update, UPDATED_ORG_NEW_NAME.findAttribute(AttributeType.ORG_NAME), UpdateMessages.cantChangeOrgName()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_RSmntner__RSmaintainer_auth() { presetOverrideAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_RS); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_LEGACY_mntner__LEGACY_maintainer_auth() { presetRsAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_LEGACY); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_RSmntner__auth_by_override() { presetOverrideAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_RS); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_LEGACY_mntner__auth_by_override() { presetOverrideAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_LEGACY); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_RS_and_LEGACY_mntner__auth_by_override() { presetOverrideAuthentication(); when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_NEW_NAME); presetReferrers(REFERRER_MNT_BY_RS, REFERRER_MNT_BY_LEGACY); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void orgname_changed_referenced_by_resource_with_RSmntner_change_is_case_sensitive() { when(update.getReferenceObject()).thenReturn(ORIGINAL_ORG); when(update.getUpdatedObject()).thenReturn(UPDATED_ORG_CASE_CHANGE); when(maintainers.isRsMaintainer(Sets.newHashSet(CIString.ciString("RIPE-NCC-HM-MNT")))).thenReturn(true); presetReferrers(REFERRER_MNT_BY_RS); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, ORIGINAL_ORG.findAttribute(AttributeType.ORG_NAME), UpdateMessages.cantChangeOrgName()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); } |
AbuseValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); if (updatedObject == null) { return; } validateAbuseC(updatedObject, update, updateContext); validateAbuseCRemoved(updatedObject, update, updateContext); } @Autowired AbuseValidator(final RpslObjectDao objectDao, final RpslObjectUpdateDao updateDao, final Maintainers maintainers); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); } | @Test public void has_no_abusec() { when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITHOUT_ABUSE_C); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void references_role_without_abuse_mailbox() { when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(objectDao.getByKey(eq(ObjectType.ROLE), eq(CIString.ciString("AB-NIC")))).thenReturn(ROLE_WITHOUT_ABUSE_MAILBOX); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.abuseMailboxRequired("AB-NIC", update.getUpdatedObject().getType())); verifyZeroInteractions(maintainers); }
@Test public void references_role_with_abuse_mailbox() { when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(objectDao.getByKey(eq(ObjectType.ROLE), eq(CIString.ciString("AB-NIC")))).thenReturn(ROLE_WITH_ABUSE_MAILBOX); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); verifyZeroInteractions(maintainers); }
@Test public void references_person_instead_of_role() { when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(objectDao.getByKey(eq(ObjectType.ROLE), eq(CIString.ciString("AB-NIC")))).thenThrow(new EmptyResultDataAccessException(1)); when(objectDao.getByKey(eq(ObjectType.PERSON), eq(CIString.ciString("AB-NIC")))).thenReturn(PERSON_WITHOUT_ABUSE_MAILBOX); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.abuseCPersonReference()); verify(updateContext, never()).addMessage(update, UpdateMessages.abuseMailboxRequired("nic-hdl: AB-NIC", update.getUpdatedObject().getType())); verifyZeroInteractions(maintainers); }
@Test public void reference_not_found() { when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(objectDao.getByKey(eq(ObjectType.ROLE), eq(CIString.ciString("AB-NIC")))).thenThrow(new EmptyResultDataAccessException(1)); when(objectDao.getByKey(eq(ObjectType.PERSON), eq(CIString.ciString("AB-NIC")))).thenThrow(new EmptyResultDataAccessException(1)); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); verifyZeroInteractions(maintainers); }
@Test public void remove_abuse_contact_LIR_org() { when(update.getReferenceObject()).thenReturn(LIR_ORG_WITH_ABUSE_C); when(update.getUpdatedObject()).thenReturn(LIR_ORG_WITHOUT_ABUSE_C); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.abuseContactNotRemovable()); verifyZeroInteractions(maintainers); }
@Test public void allow_remove_abuse_contact_when_non_LIR_no_referencing_objects() { when(update.getReferenceObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITHOUT_ABUSE_C); when(updateDao.getReferences(update.getUpdatedObject())).thenReturn(Collections.EMPTY_SET); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); verifyZeroInteractions(maintainers); }
@Test public void allow_remove_abusec_when_referencing_object_is_not_resource() { final RpslObject referencingPerson = RpslObject.parse( "person: A Person\n" + "address: Address 1\n" + "phone: +31 20 535 4444\n" + "nic-hdl: DUMY-RIPE\n" + "org: ORG-1\n" + "mnt-by: A_NON_RS_MAINTAINER\n" + "source: RIPE"); final RpslObjectInfo info = new RpslObjectInfo(1, ObjectType.PERSON, "AS6"); when(update.getReferenceObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITHOUT_ABUSE_C); when(updateDao.getReferences(update.getUpdatedObject())).thenReturn(Sets.newHashSet(info)); when(objectDao.getById(1)).thenReturn(referencingPerson); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); verifyZeroInteractions(maintainers); }
@Test public void allow_remove_abuse_contact_when_referencing_resources_is_not_rs_maintained() { final RpslObjectInfo info = new RpslObjectInfo(1, ObjectType.AUT_NUM, "AS6"); when(update.getReferenceObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITHOUT_ABUSE_C); when(updateDao.getReferences(update.getUpdatedObject())).thenReturn(Sets.newHashSet(info)); when(objectDao.getById(info.getObjectId())).thenReturn(RESOURCE_NOT_RS_MAINTAINED); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); verify(maintainers).isRsMaintainer(ciSet("A_NON_RS_MAINTAINER")); verifyNoMoreInteractions(maintainers); }
@Test public void do_not_allow_remove_abuse_contact_when_a_referencing_resource_is_rs_maintained() { final RpslObjectInfo info = new RpslObjectInfo(1, ObjectType.AUT_NUM, "AS6"); when(update.getReferenceObject()).thenReturn(OTHER_ORG_WITH_ABUSE_C); when(update.getUpdatedObject()).thenReturn(OTHER_ORG_WITHOUT_ABUSE_C); when(updateDao.getReferences(update.getUpdatedObject())).thenReturn(Sets.newHashSet(info)); when(objectDao.getById(info.getObjectId())).thenReturn(RESOURCE_RS_MAINTAINED); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.abuseContactNotRemovable()); verify(maintainers).isRsMaintainer(ciSet("AN_RS_MAINTAINER")); verifyNoMoreInteractions(maintainers); } |
LirUserMaintainedAttributesValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions().size(), is(1)); assertTrue(subject.getActions().contains(Action.MODIFY)); } |
LirUserMaintainedAttributesValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes().size(), is(1)); assertTrue(subject.getTypes().contains(ObjectType.ORGANISATION)); } |
LirUserMaintainedAttributesValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER) || subject.hasPrincipal(Principal.ALLOC_MAINTAINER)) { return; } final RpslObject originalObject = update.getReferenceObject(); if (! isLir(originalObject)) { return; } final RpslObject updatedObject = update.getUpdatedObject(); USER_MANAGED_IN_PORTAL_ATTRIBUTES.forEach(attributeType -> { if (haveAttributesChanged(originalObject, updatedObject, attributeType)) { updateContext.addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(attributeType)); } }); } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void update_of_non_lir() { when(update.getReferenceObject()).thenReturn(NON_LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(NON_LIR_ORG_CHANGED); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_address() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ADDRESS); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(AttributeType.ADDRESS)); verifyNoMoreInteractions(update); }
@Test public void update_of_phone() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_PHONE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(AttributeType.PHONE)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_fax() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_FAX); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(AttributeType.FAX_NO)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_email() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_EMAIL); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(AttributeType.E_MAIL)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_name() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_NAME); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(AttributeType.ORG_NAME)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_name_case_sensitive() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_NAME_CASE_SENSITIVE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedinLirPortal(AttributeType.ORG_NAME)); verifyNoMoreInteractions(updateContext); } |
AbuseCNoLimitWarningValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
AbuseCNoLimitWarningValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.ROLE)); } |
AbuseCNoLimitWarningValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (update.getUpdatedObject().containsAttribute(AttributeType.ABUSE_MAILBOX) && (!update.hasOriginalObject() || !update.getReferenceObject().containsAttribute(AttributeType.ABUSE_MAILBOX))) { updateContext.addMessage(update, UpdateMessages.abuseCNoLimitWarning()); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void role_has_added_abuse_mailbox_create() { final RpslObject role = RpslObject.parse("role: Some Role\nnic-hdl: TEST-NIC\nabuse-mailbox: [email protected]"); when(update.hasOriginalObject()).thenReturn(false); when(update.getReferenceObject()).thenReturn(role); when(update.getUpdatedObject()).thenReturn(role); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.abuseCNoLimitWarning()); }
@Test public void role_has_added_abuse_mailbox_modify() { when(update.hasOriginalObject()).thenReturn(true); when(update.getReferenceObject()).thenReturn(RpslObject.parse("role: Some Role\nnic-hdl: TEST-NIC")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("role: Some Role\nnic-hdl: TEST-NIC\nabuse-mailbox: [email protected]")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.abuseCNoLimitWarning()); }
@Test public void role_has_not_added_abuse_mailbox() { when(update.hasOriginalObject()).thenReturn(true); when(update.getReferenceObject()).thenReturn(RpslObject.parse("role: Some Role\nnic-hdl: TEST-NIC\nabuse-mailbox: [email protected]")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("role: Some Role\nnic-hdl: TEST-NIC\nabuse-mailbox: [email protected]")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.abuseCNoLimitWarning()); } |
LirMntByAttributeCountValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired LirMntByAttributeCountValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions().size(), is(2)); assertTrue(subject.getActions().contains(Action.CREATE)); assertTrue(subject.getActions().contains(Action.MODIFY)); } |
LirMntByAttributeCountValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired LirMntByAttributeCountValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes().size(), is(1)); assertTrue(subject.getTypes().contains(ObjectType.ORGANISATION)); } |
LirMntByAttributeCountValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject originalObject = update.getReferenceObject(); if (!isLir(originalObject)) { return; } final RpslObject updatedObject = update.getUpdatedObject(); final Collection<CIString> userMntner = filterUserMntner(updatedObject); if (userMntner.size() > 1) { updateContext.addMessage(update, UpdateMessages.multipleUserMntBy(userMntner)); } } @Autowired LirMntByAttributeCountValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void update_of_not_lir_with_single_mntner() { when(update.getReferenceObject()).thenReturn(NON_LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(NON_LIR_ORG_SINGLE_USER_MNTNER); subject.validate(update, updateContext); verify(update).getReferenceObject(); verifyNoMoreInteractions(update); verifyZeroInteractions(maintainers, updateContext); }
@Test public void update_of_not_lir_with_multiple_mntner() { when(update.getReferenceObject()).thenReturn(NON_LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(NON_LIR_ORG_MULTIPLE_USER_MNTNER); subject.validate(update, updateContext); verify(update).getReferenceObject(); verifyNoMoreInteractions(update); verifyZeroInteractions(maintainers, updateContext); }
@Test public void update_of_lir_with_single_mntner() { when(maintainers.isRsMaintainer(ciString("MNT1-LIR"))).thenReturn(false); when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_SINGLE_USER_MNTNER); subject.validate(update, updateContext); verify(maintainers).isRsMaintainer(ciString("MNT1-LIR")); verifyNoMoreInteractions(maintainers); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verifyNoMoreInteractions(update); verifyZeroInteractions(updateContext); }
@Test public void update_of_lir_with_multiple_mntner() { when(maintainers.isRsMaintainer(ciString("MNT1-LIR"))).thenReturn(false); when(maintainers.isRsMaintainer(ciString("MNT2-LIR"))).thenReturn(false); when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_MULTIPLE_USER_MNTNER); subject.validate(update, updateContext); verify(maintainers).isRsMaintainer(ciString("MNT1-LIR")); verify(maintainers).isRsMaintainer(ciString("MNT2-LIR")); verifyNoMoreInteractions(maintainers); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.multipleUserMntBy(ImmutableList.of(ciString("MNT1-LIR"), ciString("MNT2-LIR")))); verifyNoMoreInteractions(update); verifyNoMoreInteractions(updateContext); } |
ExportFileWriterFactory { public boolean isExportDir(final File dir) { final File[] files = dir.listFiles(); if (files == null) { return false; } for (final File file : files) { if (file.isFile()) { return false; } final String fileName = file.getName(); if (! (fileName.equals(externalExportDir) || fileName.equals(internalExportDir) || fileName.equals(legacyExternalExportDir))) { return false; } } return true; } @Autowired ExportFileWriterFactory(final DummifierNrtm dummifierNrtm, final DummifierCurrent dummifierCurrent,
@Value("${dir.rpsl.export.internal}") final String internalExportDir,
@Value("${dir.rpsl.export.external}") final String externalExportDir,
@Value("${dir.rpsl.export.external.legacy}") final String legacyExternalExportDir,
@Value("${whois.source}") final String source,
@Value("${whois.nonauth.source}") final String nonAuthSource); List<ExportFileWriter> createExportFileWriters(final File baseDir, final int lastSerial); boolean isExportDir(final File dir); } | @Test public void isExportDir_empty() { assertThat(subject.isExportDir(folder.getRoot()), Matchers.is(true)); }
@Test public void isExportDir_home() { final File homeDir = new File(System.getProperty("user.home")); assertThat(homeDir.exists(), Matchers.is(true)); assertThat(homeDir.isDirectory(), Matchers.is(true)); assertThat(homeDir.canWrite(), Matchers.is(true)); assertThat(subject.isExportDir(homeDir), Matchers.is(false)); } |
LirRipeMaintainedAttributesValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions().size(), is(1)); assertTrue(subject.getActions().contains(Action.MODIFY)); } |
LirRipeMaintainedAttributesValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes().size(), is(1)); assertTrue(subject.getTypes().contains(ObjectType.ORGANISATION)); } |
LirRipeMaintainedAttributesValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER) || subject.hasPrincipal(Principal.ALLOC_MAINTAINER)) { return; } final RpslObject originalObject = update.getReferenceObject(); if (!isLir(originalObject)) { return; } final RpslObject updatedObject = update.getUpdatedObject(); RIPE_NCC_MANAGED_ATTRIBUTES.forEach(attributeType -> { if (haveAttributesChanged(originalObject, updatedObject, attributeType)) { updateContext.addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(attributeType)); } }); } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void update_of_non_lir() { when(update.getReferenceObject()).thenReturn(NON_LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(NON_LIR_ORG_CHANGED); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_mntby() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_MNT_BY); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.MNT_BY)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.ORG)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_type() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_TYPE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verify(update).getReferenceObject(); verify(update).getUpdatedObject(); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.ORG_TYPE)); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_address_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ADDRESS); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_phone_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_PHONE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_fax_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_FAX); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_email_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_EMAIL); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_name_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_NAME); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_mntby_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_MNT_BY); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_type_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_TYPE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_abuse_mailbox_with_override() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ABUSE_MAILBOX); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_address_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ADDRESS); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_phone_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_PHONE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_fax_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_FAX); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_email_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_EMAIL); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_name_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_NAME); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_mntby_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_MNT_BY); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_org_type_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ORG_TYPE); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); }
@Test public void update_of_abuse_mailbox_with_powermntner() { when(update.getReferenceObject()).thenReturn(LIR_ORG); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(LIR_ORG_ABUSE_MAILBOX); subject.validate(update, updateContext); verify(updateContext).getSubject(update); verifyNoMoreInteractions(updateContext); } |
AggregatedByLirStatusValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired AggregatedByLirStatusValidator(final Ipv6Tree ipv6Tree, final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(Action.CREATE, Action.MODIFY)); } |
AggregatedByLirStatusValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired AggregatedByLirStatusValidator(final Ipv6Tree ipv6Tree, final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), contains(ObjectType.INET6NUM)); } |
AggregatedByLirStatusValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (update.getAction()== CREATE) { validateCreate(update, updateContext); } else { validateModify(update, updateContext); } } @Autowired AggregatedByLirStatusValidator(final Ipv6Tree ipv6Tree, final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_no_aggregated_by_lir() { final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: ASSIGNED"); when(update.getUpdatedObject()).thenReturn(object); when(update.getAction()).thenReturn(Action.CREATE); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_no_aggregated_by_lir_with_assignment_size() { final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: ASSIGNED\n" + "assignment-size: 64"); when(update.getUpdatedObject()).thenReturn(object); when(update.getAction()).thenReturn(Action.CREATE); subject.validate(update, updateContext); verify(updateContext).addMessage(update, object.findAttribute(AttributeType.ASSIGNMENT_SIZE), UpdateMessages.attributeAssignmentSizeNotAllowed()); }
@Test public void validate_no_aggregated_by_lir_update_with_assignment_size() { final RpslObject referenceObject = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: ASSIGNED"); final RpslObject updatedObject = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: ASSIGNED\n" + "assignment-size: 64\n"+ "assignment-size: 32"); when(update.getAction()).thenReturn(Action.MODIFY); when(update.getReferenceObject()).thenReturn(referenceObject); when(update.getUpdatedObject()).thenReturn(updatedObject); subject.validate(update, updateContext); final List<RpslAttribute> assignmentSizeAttributes = updatedObject.findAttributes(AttributeType.ASSIGNMENT_SIZE); verify(updateContext).addMessage(update, assignmentSizeAttributes.get(0), UpdateMessages.attributeAssignmentSizeNotAllowed()); verify(updateContext).addMessage(update, assignmentSizeAttributes.get(1), UpdateMessages.attributeAssignmentSizeNotAllowed()); }
@Test public void validate_parent_assignment_size() { final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 64"); final Ipv6Resource key = Ipv6Resource.parse("2001:0658:021A::/48"); final RpslObject parent = RpslObject.parse("" + "inet6num: 2001:0658:021A::/32\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 40"); final Ipv6Entry ipv6Entry = new Ipv6Entry(Ipv6Resource.parse(parent.getKey()), 1); when(update.getAction()).thenReturn(Action.CREATE); when(ipv6Tree.findFirstLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6Entry)); when(rpslObjectDao.getById(1)).thenReturn(parent); when(update.getUpdatedObject()).thenReturn(object); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.invalidPrefixLength(Ipv6Resource.parse(object.getKey()), 40)); verifyNoMoreInteractions(updateContext); }
@Test public void validate_aggregatedByLir_in_parent_and_grandparent() { final Ipv6Resource key = Ipv6Resource.parse("2001:0658:021A::/48"); final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 64"); final RpslObject parent = RpslObject.parse("" + "inet6num: 2001:0658:021A::/32\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 48"); final RpslObject grandParent = RpslObject.parse("" + "inet6num: 2001:0658:021A::/16\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 32"); final Ipv6Entry ipv6EntryParent = new Ipv6Entry(Ipv6Resource.parse(parent.getKey()), 1); final Ipv6Entry ipv6EntryGrandParent = new Ipv6Entry(Ipv6Resource.parse(grandParent.getKey()), 2); when(update.getAction()).thenReturn(Action.CREATE); when(ipv6Tree.findFirstLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findAllLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent, ipv6EntryGrandParent)); when(rpslObjectDao.getById(1)).thenReturn(parent); when(rpslObjectDao.getById(2)).thenReturn(grandParent); when(update.getUpdatedObject()).thenReturn(object); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.tooManyAggregatedByLirInHierarchy()); verifyNoMoreInteractions(updateContext); }
@Test public void validate_aggregatedByLir_in_parent_and_child() { final Ipv6Resource key = Ipv6Resource.parse("2001:0658:021A::/48"); final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 64"); final RpslObject parent = RpslObject.parse("" + "inet6num: 2001:0658:021A::/32\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 48"); final RpslObject child = RpslObject.parse("" + "inet6num: 2001:0658:021A::/64\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 128"); final Ipv6Entry ipv6EntryParent = new Ipv6Entry(Ipv6Resource.parse(parent.getKey()), 1); final Ipv6Entry ipv6EntryChild = new Ipv6Entry(Ipv6Resource.parse(child.getKey()), 2); when(update.getAction()).thenReturn(Action.CREATE); when(ipv6Tree.findFirstLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findAllLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findFirstMoreSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryChild)); when(rpslObjectDao.getById(1)).thenReturn(parent); when(rpslObjectDao.getById(2)).thenReturn(child); when(update.getUpdatedObject()).thenReturn(object); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.tooManyAggregatedByLirInHierarchy()); verifyNoMoreInteractions(updateContext); }
@Test public void validate_aggregatedByLir_in_child_and_grandchild() { final Ipv6Resource key = Ipv6Resource.parse("2001:0658:021A::/48"); final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 64"); final RpslObject parent = RpslObject.parse("" + "inet6num: 2001:0658:021A::/32\n" + "status: ALLOCATED-BY-RIR"); final RpslObject child = RpslObject.parse("" + "inet6num: 2001:0658:021A::/64\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 68"); final RpslObject grandChild = RpslObject.parse("" + "inet6num: 2001:0658:021A::/68\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 128"); final Ipv6Entry ipv6EntryParent = new Ipv6Entry(Ipv6Resource.parse(parent.getKey()), 1); final Ipv6Entry ipv6EntryChild = new Ipv6Entry(Ipv6Resource.parse(child.getKey()), 2); final Ipv6Entry ipv6EntryGrandChild = new Ipv6Entry(Ipv6Resource.parse(grandChild.getKey()), 3); when(ipv6Tree.findFirstLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findAllLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findFirstMoreSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryChild)); when(ipv6Tree.findFirstMoreSpecific(ipv6EntryChild.getKey())).thenReturn(Lists.newArrayList(ipv6EntryGrandChild)); when(rpslObjectDao.getById(1)).thenReturn(parent); when(rpslObjectDao.getById(2)).thenReturn(child); when(rpslObjectDao.getById(3)).thenReturn(grandChild); when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(object); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.tooManyAggregatedByLirInHierarchy()); verifyNoMoreInteractions(updateContext); }
@Test public void validate_child_prefix_length() { final Ipv6Resource key = Ipv6Resource.parse("2001:0658:021A::/48"); final RpslObject object = RpslObject.parse("" + "inet6num: 2001:0658:021A::/48\n" + "status: AGGREGATED-BY-LIR\n" + "assignment-size: 64"); final RpslObject parent = RpslObject.parse("" + "inet6num: 2001:0658:021A::/32\n" + "status: ALLOCATED-BY-RIR"); final RpslObject child = RpslObject.parse("" + "inet6num: 2001:0658:021A::/128\n" + "status: ASSIGNED"); final Ipv6Entry ipv6EntryParent = new Ipv6Entry(Ipv6Resource.parse(parent.getKey()), 1); final Ipv6Entry ipv6EntryChild = new Ipv6Entry(Ipv6Resource.parse(child.getKey()), 2); when(rpslObjectDao.getById(1)).thenReturn(parent); when(rpslObjectDao.getById(2)).thenReturn(child); when(ipv6Tree.findFirstLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findAllLessSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryParent)); when(ipv6Tree.findFirstMoreSpecific(key)).thenReturn(Lists.newArrayList(ipv6EntryChild)); when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(object); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.invalidChildPrefixLength()); verifyNoMoreInteractions(updateContext); }
@Test public void modify_assignmentSize_has_not_changed() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffee::/48\nassignment-size: 48\nstatus:AGGREGATED-BY-LIR")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffee::/48\nassignment-size: 48\nstatus:AGGREGATED-BY-LIR")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void modify_assignmentSize_has_changed() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffee::/48\nstatus:AGGREGATED-BY-LIR")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffee::/48\nassignment-size: 48\nstatus:AGGREGATED-BY-LIR")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.cantChangeAssignmentSize()); }
@Test public void create_has_assSize_when_it_should_not() { when(update.getAction()).thenReturn(Action.CREATE); final RpslObject rpslObject = RpslObject.parse("inet6num: ffee::/48\nassignment-size: 48\nstatus:ALLOCATED-BY-LIR"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, rpslObject.findAttribute(AttributeType.ASSIGNMENT_SIZE), UpdateMessages.attributeAssignmentSizeNotAllowed()); }
@Test public void create_has_no_assSize_when_it_should_not() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffee::/48\nstatus:ALLOCATED-BY-LIR")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void create_succeeds() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffee::/48\nstatus:ASSIGNED")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); } |
SponsoringOrgValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired SponsoringOrgValidator(final RpslObjectDao objectDao, final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(CREATE, MODIFY)); } |
SponsoringOrgValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired SponsoringOrgValidator(final RpslObjectDao objectDao, final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(INETNUM, INET6NUM, AUT_NUM)); } |
StatusValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (update.getAction() == DELETE) { if (update.getType().equals(INETNUM)) { validateDelete(update, updateContext, ipv4Tree); } else { validateDelete(update, updateContext, ipv6Tree); } } else { validateModify(update, updateContext); } } @Autowired StatusValidator(
final RpslObjectDao objectDao,
final Ipv4Tree ipv4Tree,
final Ipv6Tree ipv6Tree,
final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void delete_inetnum_w_legacy_not_allowed_under_unspecified_w_non_rs_maintainer() { when(update.getAction()).thenReturn(Action.DELETE); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("" + "inetnum: 0.0.0.0 - 255.255.255.255\n" + "status: ALLOCATED UNSPECIFIED")); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: LEGACY\n" + "mnt-by: TEST-MNT\n" + "password: update")); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, UpdateMessages.inetnumStatusLegacy()); }
@Test public void modify_status_change() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getReferenceObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: ASSIGNED PI")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: ASSIGNED PA")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.statusChange()); } |
MntRouteRangeValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); final IpInterval<?> ipInterval = IpInterval.parse(updatedObject.getKey()); for (final RpslAttribute attribute : updatedObject.findAttributes(AttributeType.MNT_ROUTES)) { final MntRoutes mntRoutes = MntRoutes.parse(attribute.getCleanValue()); if (mntRoutes.isAnyRange()) { return; } for (final AddressPrefixRange addressPrefixRange : mntRoutes.getAddressPrefixRanges()) { final AddressPrefixRange.BoundaryCheckResult boundaryCheckResult = addressPrefixRange.checkWithinBounds(ipInterval); switch (boundaryCheckResult) { case IPV4_EXPECTED: updateContext.addMessage(update, attribute, UpdateMessages.invalidIpv6Address(addressPrefixRange.getIpInterval().toString())); break; case IPV6_EXPECTED: updateContext.addMessage(update, attribute, UpdateMessages.invalidIpv4Address(addressPrefixRange.getIpInterval().toString())); break; case NOT_IN_BOUNDS: updateContext.addMessage(update, attribute, UpdateMessages.invalidRouteRange(addressPrefixRange.toString())); break; default: break; } } } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void is_inside_range() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:192.0.0.0 - 192.0.255.255\n" + "mnt-routes: DEV-MNT {192.0.0.0/24}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void is_inside_range_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:2a00:c00::/32\n" + "mnt-routes: QSC-NOC {2a00:c00::/48}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void is_inside_range_multiple() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:192.0.0.0 - 192.0.255.255\n" + "mnt-routes: DEV-MNT1 {192.0.0.0/24}\n" + "mnt-routes: DEV-MNT2 {192.0.0.0/32}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void is_inside_range_multiple_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:2a00:c00::/32\n" + "mnt-routes: QSC-NOC {2a00:c00::/48}\n" + "mnt-routes: QSC-NOC {2a00:c00::/64}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void any_range() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:192.0.0.0 - 192.0.255.255\n" + "mnt-routes: DEV-MNT ANY"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void any_range_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:2a00:c00::/32\n" + "mnt-routes: DEV-MNT ANY"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void ipv6_range_with_ipv4() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:192.0.0.0 - 192.0.255.255\n" + "mnt-routes: DEV-MNT {::0/128^+}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidIpv4Address("::/128"))); }
@Test public void ipv4_range_with_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:2a00:c00::/32\n" + "mnt-routes: DEV-MNT {192.0.0.0/24}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidIpv6Address("192.0.0.0/24"))); }
@Test public void is_outside_range() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:192.0.0.0 - 192.0.0.255\n" + "mnt-routes: DEV-MNT {192.0.0.0/16}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidRouteRange("192.0.0.0/16"))); }
@Test public void is_outside_range_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:2a00:c00::/32\n" + "mnt-routes: DEV-MNT {2a00:c00::/16}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidRouteRange("2a00:c00::/16"))); }
@Test public void is_outside_range_multiple() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:192.0.0.0 - 192.0.0.255\n" + "mnt-routes: DEV-MNT {192.0.0.0/16,192.0.0.0/8}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidRouteRange("192.0.0.0/16"))); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidRouteRange("192.0.0.0/8"))); }
@Test public void is_outside_range_multiple_ipv6() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum:2a00:c00::/32\n" + "mnt-routes: DEV-MNT {2a00:c00::/24,2a00:c00::/16}"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidRouteRange("2a00:c00::/24"))); verify(updateContext).addMessage(any(PreparedUpdate.class), eq(rpslObject.findAttribute(AttributeType.MNT_ROUTES)), eq(UpdateMessages.invalidRouteRange("2a00:c00::/16"))); } |
MntRouteRangeValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void supports() { final List<ObjectType> supportedTypes = subject.getTypes(); assertThat(supportedTypes, containsInAnyOrder(ObjectType.INETNUM, ObjectType.INET6NUM)); } |
MntRouteRangeValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void supports_actions_create_modify() { final List<Action> actions = subject.getActions(); assertThat(actions.size(), is(2)); assertThat(actions.contains(Action.CREATE), is(true)); assertThat(actions.contains(Action.MODIFY), is(true)); } |
LirMntByValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired LirMntByValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(Action.MODIFY)); } |
LirMntByValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired LirMntByValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.INETNUM, ObjectType.INET6NUM)); } |
LirMntByValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); final RpslObject originalObject = update.getReferenceObject(); final RpslObject updatedObject = update.getUpdatedObject(); final boolean rsMaintained = maintainers.isRsMaintainer(originalObject.getValuesForAttribute(AttributeType.MNT_BY)); if (mntByChanged(originalObject, updatedObject) && rsMaintained && isAllocation(originalObject)) { if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER) || subject.hasPrincipal(Principal.RS_MAINTAINER)) { return; } else { updateContext.addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.MNT_BY)); } } } @Autowired LirMntByValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void modify_mntby_on_inetnum_with_lir() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST2-MNT"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.MNT_BY)); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_on_inetnum_with_rs() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST2-MNT"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_on_inetnum_with_override() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST2-MNT"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void mntby_unchanged() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_remove_rs_mntner_on_inetnum_with_lir() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: TEST-MNT"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.MNT_BY)); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_remove_own_mntner_on_inetnum_with_lir() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.MNT_BY)); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_multiple_on_inetnum_with_lir() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "mnt-by: TEST2-MNT"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST4-MNT"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.canOnlyBeChangedByRipeNCC(AttributeType.MNT_BY)); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT", "TEST2-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_add_lir_mntner_on_inetnum_with_rs() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_add_lir_mntner_on_inetnum_with_override() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_delete_lir_mntner_on_inetnum_with_rs() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(false); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_mntby_delete_lir_mntner_on_inetnum_with_override() { final RpslObject rpslOriginalObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n"); final RpslObject rpslUpdatedlObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n"); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getReferenceObject()).thenReturn(rpslOriginalObject); when(update.getUpdatedObject()).thenReturn(rpslUpdatedlObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); } |
ReferenceCheck implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (updateContext.getSubject(update).hasPrincipal(Principal.OVERRIDE_MAINTAINER)) { return; } final InetStatus inetStatus = getStatus(update); final List<RpslAttribute> updatedOrgAttributes = update.getUpdatedObject().findAttributes(AttributeType.ORG); if (inetStatus.needsOrgReference() && updatedOrgAttributes.isEmpty()) { updateContext.addMessage(update, UpdateMessages.orgAttributeMissing()); return; } if (updatedOrgAttributes.isEmpty()) { return; } final RpslAttribute org = updatedOrgAttributes.get(0); final RpslObject referencedOrganisation = findOrgReference(org); if (referencedOrganisation == null) { updateContext.addMessage(update, UpdateMessages.referenceNotFound(org.getCleanValue())); return; } final CIString cleanOrgTypeValue = referencedOrganisation.findAttribute(AttributeType.ORG_TYPE).getCleanValue(); final OrgType orgType = OrgType.getFor(cleanOrgTypeValue); if (orgType == null || !inetStatus.isValidOrgType(orgType)) { updateContext.addMessage(update, UpdateMessages.wrongOrgType(inetStatus.getAllowedOrgTypes())); } } @Autowired ReferenceCheck(final RpslObjectUpdateDao rpslObjectUpdateDao, final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void modify_org_reference_missing() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.orgAttributeMissing()); }
@Test public void modify_org_reference_missing_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getAction()).thenReturn(Action.MODIFY); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_org_reference_not_found_in_db() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(null); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.referenceNotFound("ORG1")); }
@Test public void modify_org_reference_not_found_in_db_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getAction()).thenReturn(Action.MODIFY); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(null); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_wrong_orgtype_on_found_org() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: OTHER")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.wrongOrgType(InetnumStatus.ALLOCATED_PA.getAllowedOrgTypes())); }
@Test public void modify_wrong_orgtype_on_found_org_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getAction()).thenReturn(Action.MODIFY); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: OTHER")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_right_orgtype_on_found_org() { when(update.getAction()).thenReturn(Action.MODIFY); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: LIR")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void create_org_reference_missing() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.orgAttributeMissing()); }
@Test public void create_org_reference_missing_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void create_org_reference_not_found_in_db() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(null); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.referenceNotFound("ORG1")); }
@Test public void create_org_reference_not_found_in_db_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(null); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void create_wrong_orgtype_on_found_org() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: OTHER")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.wrongOrgType(InetnumStatus.ALLOCATED_PA.getAllowedOrgTypes())); }
@Test public void create_wrong_orgtype_on_found_org_direct_assignment() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: DIRECT_ASSIGNMENT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.wrongOrgType(InetnumStatus.ALLOCATED_PA.getAllowedOrgTypes())); }
@Test public void create_wrong_orgtype_on_found_org_override() { when(updateSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: OTHER")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void create_right_orgtype_on_found_org() { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA\norg: ORG1")); when(rpslObjectUpdateDao.getAttributeReference(AttributeType.ORG, ciString("ORG1"))).thenReturn(rpslObjectInfo); when(rpslObjectInfo.getKey()).thenReturn("ORG1"); when(rpslObjectDao.getByKey(ObjectType.ORGANISATION, "ORG1")).thenReturn(RpslObject.parse("organisation: ORG1\norg-type: LIR")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); } |
IntersectionValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired IntersectionValidator(final Ipv4Tree ipv4Tree, final Ipv6Tree ipv6Tree); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(Action.CREATE)); } |
IntersectionValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired IntersectionValidator(final Ipv4Tree ipv4Tree, final Ipv6Tree ipv6Tree); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.INETNUM, ObjectType.INET6NUM)); } |
IntersectionValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final IpInterval ipInterval = IpInterval.parse(update.getReferenceObject().getKey()); if (ipInterval instanceof Ipv4Resource) { validateIntersections(update, updateContext, ipInterval, ipv4Tree); } else { validateIntersections(update, updateContext, ipInterval, ipv6Tree); } } @Autowired IntersectionValidator(final Ipv4Tree ipv4Tree, final Ipv6Tree ipv6Tree); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_no_children_ipv4() { final RpslObject object = RpslObject.parse("inetnum: 193.0.0.0"); when(ipv4Tree.findFirstMoreSpecific(parentIpv4Key)).thenReturn(Lists.<Ipv4Entry>newArrayList()); when(update.getReferenceObject()).thenReturn(object); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_no_children_ipv6() { final RpslObject object = RpslObject.parse("inet6num: 2001:0658:021A::/48"); when(ipv6Tree.findFirstMoreSpecific(parentIpv6Key)).thenReturn(Lists.<Ipv6Entry>newArrayList()); when(update.getReferenceObject()).thenReturn(object); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_no_intersections_ipv4() { final RpslObject object = RpslObject.parse("inetnum: 193.0.0.0 - 193.0.0.10"); when(ipv4Tree.findFirstMoreSpecific(parentIpv4Key)).thenReturn(Lists.newArrayList( new Ipv4Entry(Ipv4Resource.parse("192/8"), 1), new Ipv4Entry(Ipv4Resource.parse("193.0.0.1"), 2), new Ipv4Entry(Ipv4Resource.parse("193.0.1/24"), 3), new Ipv4Entry(Ipv4Resource.parse("193.0.0.1 - 193.0.0.2"), 4) )); when(update.getReferenceObject()).thenReturn(object); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_intersections_ipv4() { final RpslObject object = RpslObject.parse("inetnum: 193.0.0.0 - 193.0.0.10"); when(ipv4Tree.findFirstMoreSpecific(parentIpv4Key)).thenReturn(Lists.newArrayList( new Ipv4Entry(Ipv4Resource.parse("193.0.0.10 - 193.0.0.12"), 1), new Ipv4Entry(Ipv4Resource.parse("193.0.1/24"), 2) )); when(update.getReferenceObject()).thenReturn(object); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.intersectingRange(Ipv4Resource.parse("193.0.0.10 - 193.0.0.12"))); verifyNoMoreInteractions(updateContext); }
@Test public void validate_invalid_parent_interval() throws Exception { when(ipv6Tree.findFirstLessSpecific(any(Ipv6Resource.class))).thenReturn(Collections.<Ipv6Entry>emptyList()); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: fe80::/32")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.invalidParentEntryForInterval(Ipv6Resource.parse("fe80::/32"))); verifyNoMoreInteractions(updateContext); } |
EndUserMaintainerChecks implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)) { return; } if (subject.hasPrincipal(Principal.ENDUSER_MAINTAINER)) { final boolean hasEnduserMaintainers = maintainers.isEnduserMaintainer( update.getUpdatedObject().getValuesForAttribute(AttributeType.MNT_BY)); if (!hasEnduserMaintainers) { updateContext.addMessage(update, UpdateMessages.adminMaintainerRemoved()); } } } @Autowired EndUserMaintainerChecks(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void modify_has_no_endusermntner() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-by: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(principalSubject); when(principalSubject.hasPrincipal(Principal.ENDUSER_MAINTAINER)).thenReturn(true); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.adminMaintainerRemoved()); verify(maintainers).isEnduserMaintainer(ciSet("TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void modify_has_no_endusermntner_override() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-by: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(principalSubject); when(principalSubject.hasPrincipal(any(Principal.class))).thenReturn(true); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verifyZeroInteractions(maintainers); }
@Test public void modify_succeeds() { when(principalSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-by: END-MNT")); when(updateContext.getSubject(update)).thenReturn(principalSubject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verifyZeroInteractions(maintainers); } |
OrgAttributeNotChangedValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired OrgAttributeNotChangedValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(Action.MODIFY)); } |
OrgAttributeNotChangedValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired OrgAttributeNotChangedValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.INETNUM, ObjectType.INET6NUM, ObjectType.AUT_NUM)); } |
OrgAttributeNotChangedValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject originalObject = update.getReferenceObject(); final CIString originalOrg = originalObject.getValueOrNullForAttribute(AttributeType.ORG); final CIString updatedOrg = update.getUpdatedObject().getValueOrNullForAttribute(AttributeType.ORG); if (Objects.equals(originalOrg, updatedOrg)) { return; } boolean rsMaintained = maintainers.isRsMaintainer(originalObject.getValuesForAttribute(AttributeType.MNT_BY)); final Subject subject = updateContext.getSubject(update); if (rsMaintained && !(subject.hasPrincipal(Principal.RS_MAINTAINER) || subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER))) { final List<RpslAttribute> org = update.getUpdatedObject().findAttributes(AttributeType.ORG); if (org.isEmpty()) { updateContext.addMessage(update, UpdateMessages.cantRemoveOrgAttribute()); } else { updateContext.addMessage(update, org.get(0), UpdateMessages.cantChangeOrgAttribute()); } } } @Autowired OrgAttributeNotChangedValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_org_attribute_not_changed_for_aut_num() { final RpslObject rpslObject = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-RT-TEST\n" + "mnt-by: TEST-MNT"); when(update.getReferenceObject()).thenReturn(rpslObject); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void validate_org_attribute_not_changed_for_inetnum() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(rpslObject); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void validate_org_attribute_not_changed_for_inet6num() { final RpslObject rpslObject = RpslObject.parse("" + "inet6num: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(rpslObject); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void validate_has_no_org_attribute_for_aut_num() { final RpslObject rpslObject = RpslObject.parse("" + "aut-num: AS123\n" + "mnt-by: TEST-MNT"); when(update.getReferenceObject()).thenReturn(rpslObject); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void validate_has_no_org_attribute_for_inetnum() { final RpslObject rpslObject = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(rpslObject); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void validate_has_no_org_attribute_for_inet6num() { final RpslObject rpslObject = RpslObject.parse("" + "inet6num: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(rpslObject); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verifyZeroInteractions(maintainers); }
@Test public void validate_resource_not_maintained_by_ripe_for_aut_num() { final RpslObject original = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-RT-TEST\n" + "mnt-by: TEST-MNT"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-PQ-TEST\n" + "mnt-by: OTHER-MNT"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_not_maintained_by_ripe_for_inetnum() { final RpslObject original = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: TEST-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: OTHER-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_not_maintained_by_ripe_for_inet6num() { final RpslObject original = RpslObject.parse("" + "inet6num: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: OTHER-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inet6num: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: OTHER-MNT\n" + "mnt-lower: LIR-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("OTHER-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_modify_resource_maintained_by_ripe_auth_by_other_mnt_for_aut_num() { final RpslObject original = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-RT-TEST\n" + "mnt-by: RIPE-NCC-HM-MNT"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-PQ-TEST\n" + "mnt-by: RIPE-NCC-HM-MNT"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, updated.findAttribute(AttributeType.ORG), UpdateMessages.cantChangeOrgAttribute()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_modify_resource_maintained_by_ripe_auth_by_other_mnt_for_inetnum() { final RpslObject original = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, updated.findAttribute(AttributeType.ORG), UpdateMessages.cantChangeOrgAttribute()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_modify_resource_maintained_by_ripe_auth_by_other_mnt_for_inet6num() { final RpslObject original = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext).addMessage(update, updated.findAttribute(AttributeType.ORG), UpdateMessages.cantChangeOrgAttribute()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_delete_resource_maintained_by_ripe_auth_by_other_mnt_for_aut_num() { final RpslObject original = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-RT-TEST\n" + "mnt-by: RIPE-NCC-HM-MNT"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "aut-num: AS123\n" + "mnt-by: RIPE-NCC-HM-MNT"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.cantRemoveOrgAttribute()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_delete_resource_maintained_by_ripe_auth_by_other_mnt_for_inetnum() { final RpslObject original = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.cantRemoveOrgAttribute()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_delete_resource_maintained_by_ripe_auth_by_other_mnt_for_inet6num() { final RpslObject original = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.cantRemoveOrgAttribute()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_maintained_by_ripe_for_aut_num() { when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.TRUE); when(updateContext.getSubject(update)).thenReturn(subjectObject); final RpslObject original = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-RT-TEST\n" + "mnt-by: RIPE-NCC-HM-MNT"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-WG-TEST\n" + "mnt-by: RIPE-NCC-HM-MNT"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_maintained_by_ripe_for_inetnum() { when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.TRUE); when(updateContext.getSubject(update)).thenReturn(subjectObject); final RpslObject original = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_maintained_by_ripe_for_inet6num() { when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(Boolean.TRUE); when(updateContext.getSubject(update)).thenReturn(subjectObject); final RpslObject original = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); when(update.isOverride()).thenReturn(Boolean.FALSE); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT", "TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_not_maintained_by_ripe_override_for_aut_num() { when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(subjectObject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(updateContext.getSubject(update)).thenReturn(subjectObject); final RpslObject original = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-RT-TEST\n" + "mnt-by: RIPE-NCC-END-MNT"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "aut-num: AS123\n" + "org: ORG-WG-TEST\n" + "mnt-by: RIPE-NCC-END-MNT"); when(update.getUpdatedObject()).thenReturn(updated); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-END-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_not_maintained_by_ripe_override_for_inetnum() { when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(subjectObject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(updateContext.getSubject(update)).thenReturn(subjectObject); final RpslObject original = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 192.168.0.0 - 192.169.255.255\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("TEST-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_resource_not_maintained_by_ripe_override_for_inet6num() { when(subjectObject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(subjectObject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(updateContext.getSubject(update)).thenReturn(subjectObject); final RpslObject original = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR1-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getReferenceObject()).thenReturn(original); final RpslObject updated = RpslObject.parse("" + "inetnum: 2001:600:1:1:1:1:1:1/64\n" + "netname: TEST-NET-NAME\n" + "descr: TEST network\n" + "country: NL\n" + "org: ORG-LIR2-TEST\n" + "admin-c: TP1-TEST\n" + "tech-c: TP1-TEST\n" + "status: ALLOCATED PA\n" + "mnt-by: TEST-MNT\n" + "source: TEST"); when(update.getUpdatedObject()).thenReturn(updated); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<Message>anyObject()); verify(updateContext, never()).addMessage(Matchers.<Update>anyObject(), Matchers.<RpslAttribute>anyObject(), Matchers.<Message>anyObject()); verify(maintainers).isRsMaintainer(ciSet("TEST-MNT")); verifyNoMoreInteractions(maintainers); } |
ExportFileWriterFactory { public List<ExportFileWriter> createExportFileWriters(final File baseDir, final int lastSerial) { final File fullDir = new File(baseDir, legacyExternalExportDir); final File fullDirNew = new File(baseDir, externalExportDir); final File splitDir = new File(baseDir, legacyExternalExportDir + File.separator + SPLITFILE_FOLDERNAME); final File splitDirNew = new File(baseDir, externalExportDir + File.separator + SPLITFILE_FOLDERNAME); final File internalDir = new File(baseDir, internalExportDir + File.separator + SPLITFILE_FOLDERNAME); initDirs(fullDirNew, fullDir, splitDirNew, splitDir, internalDir); try { FileCopyUtils.copy(String.valueOf(lastSerial).getBytes(StandardCharsets.ISO_8859_1), new File(fullDirNew, CURRENTSERIAL_FILENAME)); FileCopyUtils.copy(String.valueOf(lastSerial).getBytes(StandardCharsets.ISO_8859_1), new File(fullDir, CURRENTSERIAL_FILENAME)); FileCopyUtils.copy(String.valueOf(lastSerial).getBytes(StandardCharsets.ISO_8859_1), new File(fullDirNew, CURRENTSERIAL_NONAUTH_FILENAME)); FileCopyUtils.copy(String.valueOf(lastSerial).getBytes(StandardCharsets.ISO_8859_1), new File(fullDir, CURRENTSERIAL_NONAUTH_FILENAME)); } catch (IOException e) { throw new RuntimeException("Writing current serial", e); } final FilenameStrategy singleFile = new FilenameStrategy.SingleFile(); final FilenameStrategy splitFile = new FilenameStrategy.SplitFile(); final FilenameStrategy nonAuthSingleFile = new FilenameStrategy.NonAuthSingleFile(); final FilenameStrategy nonAuthSplitFile = new FilenameStrategy.NonAuthSplitFile(); final ExportFilter sourceFilter = new ExportFilter.SourceExportFilter(source, ImmutableSet.copyOf(ObjectType.values())); final ExportFilter nonAuthSourceFilter = new ExportFilter.SourceExportFilter(nonAuthSource, Sets.immutableEnumSet(AUT_NUM, ROUTE, ROUTE6), false); return Lists.newArrayList( new ExportFileWriter(fullDir, singleFile, new DecorationStrategy.DummifyLegacy(dummifierNrtm), sourceFilter), new ExportFileWriter(splitDir, splitFile, new DecorationStrategy.DummifyLegacy(dummifierNrtm), sourceFilter), new ExportFileWriter(fullDirNew, singleFile, new DecorationStrategy.DummifyCurrent(dummifierCurrent), sourceFilter), new ExportFileWriter(splitDirNew, splitFile, new DecorationStrategy.DummifyCurrent(dummifierCurrent), sourceFilter), new ExportFileWriter(internalDir, splitFile, new DecorationStrategy.None(), sourceFilter), new ExportFileWriter(fullDir, nonAuthSingleFile, new DecorationStrategy.DummifyLegacy(dummifierNrtm), nonAuthSourceFilter), new ExportFileWriter(splitDir, nonAuthSplitFile, new DecorationStrategy.DummifyLegacy(dummifierNrtm), nonAuthSourceFilter), new ExportFileWriter(fullDirNew, nonAuthSingleFile, new DecorationStrategy.DummifyCurrent(dummifierCurrent), nonAuthSourceFilter), new ExportFileWriter(splitDirNew, nonAuthSplitFile, new DecorationStrategy.DummifyCurrent(dummifierCurrent), nonAuthSourceFilter), new ExportFileWriter(internalDir, nonAuthSplitFile, new DecorationStrategy.None(), nonAuthSourceFilter) ); } @Autowired ExportFileWriterFactory(final DummifierNrtm dummifierNrtm, final DummifierCurrent dummifierCurrent,
@Value("${dir.rpsl.export.internal}") final String internalExportDir,
@Value("${dir.rpsl.export.external}") final String externalExportDir,
@Value("${dir.rpsl.export.external.legacy}") final String legacyExternalExportDir,
@Value("${whois.source}") final String source,
@Value("${whois.nonauth.source}") final String nonAuthSource); List<ExportFileWriter> createExportFileWriters(final File baseDir, final int lastSerial); boolean isExportDir(final File dir); } | @Test public void isLastSerialFile_created() throws IOException { subject.createExportFileWriters(folder.getRoot(), LAST_SERIAL); final File currentSerialFile = new File(folder.getRoot(), "dbase/RIPE.CURRENTSERIAL"); assertThat(currentSerialFile.exists(), Matchers.is(true)); final String savedSerial = new String(FileCopyUtils.copyToByteArray(currentSerialFile), StandardCharsets.ISO_8859_1); assertThat(savedSerial, Matchers.is(String.valueOf(LAST_SERIAL))); final File newSerialFile = new File(folder.getRoot(), "dbase_new/RIPE.CURRENTSERIAL"); assertThat(newSerialFile.exists(), Matchers.is(true)); final String newSavedSerial = new String(FileCopyUtils.copyToByteArray(currentSerialFile), StandardCharsets.ISO_8859_1); assertThat(newSavedSerial, Matchers.is(String.valueOf(LAST_SERIAL))); }
@Test(expected = IllegalStateException.class) public void createExportFileWriters_existing_dir() throws IOException { folder.newFolder("dbase"); subject.createExportFileWriters(folder.getRoot(), LAST_SERIAL); }
@Test public void createExportFileWriters() { final List<ExportFileWriter> exportFileWriters = subject.createExportFileWriters(folder.getRoot(), LAST_SERIAL); assertThat(exportFileWriters.isEmpty(), Matchers.is(false)); final File[] files = folder.getRoot().listFiles(); assertNotNull(files); assertThat(files.length, Matchers.is(3)); for (final File file : files) { if (! (file.getAbsolutePath().endsWith("internal") || file.getAbsolutePath().endsWith("dbase") || file.getAbsolutePath().endsWith("dbase_new"))) { Assert.fail("Unexpected folder: " + file.getAbsolutePath()); } } } |
StrictStatusValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { validateCreate(update, updateContext); } @Autowired StrictStatusValidator(
final RpslObjectDao objectDao,
final Ipv4Tree ipv4Tree,
final Ipv6Tree ipv6Tree,
final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void invalid_child_status_fails_ipv4() { when(update.getType()).thenReturn(INETNUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); final Ipv4Resource ipv4Resource = Ipv4Resource.parse("192.0/32"); final Ipv4Entry child = new Ipv4Entry(ipv4Resource, 1); when(ipv4Tree.findFirstMoreSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(child)); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); when(objectDao.getById(1)).thenReturn(RpslObject.parse("inetnum: 192.0/32\nstatus: ASSIGNED PI")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.incorrectChildStatus(ERROR, "ALLOCATED PA", "ASSIGNED PI", "192.0/32")); verify(maintainers).isRsMaintainer(ciSet()); verifyNoMoreInteractions(maintainers); }
@Test public void not_authorized_by_rsmntner_ipv4() { when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("inetnum: 0.0.0.0 - 255.255.255\nstatus: ALLOCATED UNSPECIFIED")); when(update.getType()).thenReturn(INETNUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST")); when(ipv4Tree.findFirstMoreSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.statusRequiresAuthorization("ASSIGNED ANYCAST")); verify(maintainers, times(2)).isRsMaintainer(ciSet()); verifyNoMoreInteractions(maintainers); }
@Test public void not_authorized_by_rsmntner_ipv4_override() { when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("inetnum: 0.0.0.0 - 255.255.255\nstatus: ALLOCATED UNSPECIFIED")); when(update.getType()).thenReturn(INETNUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST")); when(ipv4Tree.findFirstMoreSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList()); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); }
@Test public void parent_has_assigned_pa_status_and_grandparent_is_allocated_pa_and_has_rs_maintainer() { when(update.getType()).thenReturn(INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.168.1.0/24\nstatus: ASSIGNED PA")); Ipv4Entry parentEntry = new Ipv4Entry(Ipv4Resource.parse("192.168/16"), 1); when(objectDao.getById(1)).thenReturn(RpslObject.parse("inetnum: 192.168/16\nstatus: ASSIGNED PA")); Ipv4Entry grandParentEntry = new Ipv4Entry(Ipv4Resource.parse("192/8"), 2); when(objectDao.getById(2)).thenReturn(RpslObject.parse("inetnum: 192/8\nstatus: ALLOCATED PA\nmnt-by: RIPE-NCC-HM-MNT")); when(ipv4Tree.findAllLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry, grandParentEntry)); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry)); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.incorrectParentStatus(ERROR, INETNUM, "ASSIGNED PA")); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verify(maintainers, times(2)).isRsMaintainer(ciSet()); verifyNoMoreInteractions(maintainers); }
@Test public void parent_has_assigned_pa_status_and_grandparent_is_allocated_pa_but_does_not_have_rs_maintainer() { when(update.getType()).thenReturn(INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.168.1.0/24\nstatus: ASSIGNED PA")); Ipv4Entry parentEntry = new Ipv4Entry(Ipv4Resource.parse("192.168/16"), 1); when(objectDao.getById(1)).thenReturn(RpslObject.parse("inetnum: 192.168/16\nstatus: ASSIGNED PA")); Ipv4Entry grandParentEntry = new Ipv4Entry(Ipv4Resource.parse("192/8"), 2); when(objectDao.getById(2)).thenReturn(RpslObject.parse("inetnum: 192/8\nstatus: ALLOCATED PA")); when(ipv4Tree.findAllLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry, grandParentEntry)); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry)); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.incorrectParentStatus(ERROR, INETNUM, "ASSIGNED PA")); verify(maintainers, times(3)).isRsMaintainer(ciSet()); verifyNoMoreInteractions(maintainers); }
@Test public void incorrect_parent_status_ipv4() { when(update.getType()).thenReturn(INETNUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED PI")); when(ipv4Tree.findFirstMoreSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList()); Ipv4Entry parentEntry = new Ipv4Entry(Ipv4Resource.parse("192.0/16"), 1); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry)); final RpslObject parent = RpslObject.parse("inetnum: 192.0/16\nstatus: SUB-ALLOCATED PA"); when(objectDao.getById(1)).thenReturn(parent); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.incorrectParentStatus(ERROR, INETNUM, "SUB-ALLOCATED PA")); verify(maintainers).isRsMaintainer(ciSet()); verifyNoMoreInteractions(maintainers); }
@Test public void incorrect_parent_status_ipv4_override() { when(update.getType()).thenReturn(INETNUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED PI")); when(ipv4Tree.findFirstMoreSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList()); Ipv4Entry parentEntry = new Ipv4Entry(Ipv4Resource.parse("192.0/16"), 1); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry)); final RpslObject parent = RpslObject.parse("inetnum: 192.0/16\nstatus: SUB-ALLOCATED PA"); when(objectDao.getById(1)).thenReturn(parent); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.incorrectParentStatus(ERROR, INETNUM, "SUB-ALLOCATED PA")); }
@Test public void correct_parent_status_ipv4() { when(update.getType()).thenReturn(INETNUM); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED PI\nmnt-by: RIPE-NCC-HM-MNT")); when(ipv4Tree.findFirstMoreSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList()); Ipv4Entry parentEntry = new Ipv4Entry(Ipv4Resource.parse("192.0/16"), 1); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.<Ipv4Entry>newArrayList(parentEntry)); final RpslObject parent = RpslObject.parse("inetnum: 192.0/16\nstatus: ALLOCATED UNSPECIFIED"); when(objectDao.getById(1)).thenReturn(parent); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verify(maintainers).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void not_authorized_by_rsmntner_ipv6() { when(ipv6Tree.findFirstLessSpecific(any(Ipv6Resource.class))).thenReturn(Lists.newArrayList(new Ipv6Entry(Ipv6Resource.parse("::0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("inet6num: ::0/0\nstatus: ALLOCATED-BY-RIR")); when(update.getType()).thenReturn(ObjectType.INET6NUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: 2001::/48\nstatus: ASSIGNED ANYCAST")); when(ipv6Tree.findFirstMoreSpecific(any(Ipv6Resource.class))).thenReturn(Lists.<Ipv6Entry>newArrayList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.statusRequiresAuthorization("ASSIGNED ANYCAST")); verify(maintainers, times(2)).isRsMaintainer(ciSet()); verifyNoMoreInteractions(maintainers); }
@Test public void incorrect_parent_status_ipv6() { when(update.getType()).thenReturn(ObjectType.INET6NUM); when(authenticationSubject.hasPrincipal(Principal.ALLOC_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: 2001::/48\nstatus: ASSIGNED PI\nmnt-by: RIPE-NCC-HM-MNT\n")); when(ipv6Tree.findFirstMoreSpecific(any(Ipv6Resource.class))).thenReturn(Lists.<Ipv6Entry>newArrayList()); Ipv6Entry parentEntry = new Ipv6Entry(Ipv6Resource.parse("2001::/24"), 1); when(ipv6Tree.findFirstLessSpecific(any(Ipv6Resource.class))).thenReturn(Lists.<Ipv6Entry>newArrayList(parentEntry)); final RpslObject parent = RpslObject.parse("inet6num: 2001::/24\nstatus: ALLOCATED-BY-LIR"); when(objectDao.getById(1)).thenReturn(parent); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.incorrectParentStatus(ERROR, ObjectType.INET6NUM, "ALLOCATED-BY-LIR")); verify(maintainers, times(2)).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void correct_parent_status_ipv6() { when(update.getType()).thenReturn(ObjectType.INET6NUM); when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: 2001::/48\nstatus: ASSIGNED PI\nmnt-by: RIPE-NCC-HM-MNT\n")); when(ipv6Tree.findFirstMoreSpecific(any(Ipv6Resource.class))).thenReturn(Lists.<Ipv6Entry>newArrayList()); Ipv6Entry parentEntry = new Ipv6Entry(Ipv6Resource.parse("2001::/24"), 1); when(ipv6Tree.findFirstLessSpecific(any(Ipv6Resource.class))).thenReturn(Lists.<Ipv6Entry>newArrayList(parentEntry)); final RpslObject parent = RpslObject.parse("inet6num: 2001::/24\nstatus: ALLOCATED-BY-RIR"); when(objectDao.getById(1)).thenReturn(parent); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verify(maintainers, times(2)).isRsMaintainer(ciSet("RIPE-NCC-HM-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void create_inetnum_w_legacy_allowed_under_legacy_w_non_rs_maintainer() { when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("" + "inetnum: 0.0.0.0 - 255.255.255.255\n" + "status: LEGACY")); when(update.getType()).thenReturn(INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: LEGACY\n" + "mnt-by: TEST-MNT\n" + "password: update")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.inetnumStatusLegacy()); }
@Test public void create_inetnum_w_legacy_not_allowed_under_unspecified_w_non_rs_maintainer() { when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("" + "inetnum: 0.0.0.0 - 255.255.255.255\n" + "status: ALLOCATED UNSPECIFIED")); when(update.getType()).thenReturn(INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: LEGACY\n" + "mnt-by: TEST-MNT\n" + "password: update")); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, UpdateMessages.inetnumStatusLegacy()); }
@Test public void create_inetnum_w_legacy_allowed_under_unspecified_w_rs_maintainer() { when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("" + "inetnum: 0.0.0.0 - 255.255.255.255\n" + "status: ALLOCATED UNSPECIFIED")); when(update.getType()).thenReturn(INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: LEGACY\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "password: update")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.inetnumStatusLegacy()); }
@Test public void create_inetnum_w_legacy_not_allowed_under_wrong_status_w_rs_maintainer() { when(authenticationSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Lists.newArrayList(new Ipv4Entry(Ipv4Resource.parse("0/0"), 1))); when(objectDao.getById(1)).thenReturn(RpslObject.parse("" + "inetnum: 0.0.0.0 - 255.255.255.255\n" + "status: LIR-PARTITIONED PA")); when(update.getType()).thenReturn(INETNUM); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: LEGACY\n" + "mnt-by: RIPE-NCC-HM-MNT\n" + "password: update")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.inetnumStatusLegacy()); verify(updateContext, times(1)).addMessage(update, UpdateMessages.incorrectParentStatus(ERROR, INETNUM, "LIR-PARTITIONED PA")); }
@Test public void validate_invalid_parent_interval() throws Exception { when(update.getAction()).thenReturn(Action.CREATE); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "inetnum: 192.0/24\n" + "status: ASSIGNED PA")); when(ipv4Tree.findFirstLessSpecific(any(Ipv4Resource.class))).thenReturn(Collections.<Ipv4Entry>emptyList()); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.invalidParentEntryForInterval(Ipv4Resource.parse("192.0/24"))); verifyNoMoreInteractions(updateContext); } |
MntLowerAddedRemoved implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)) { return; } if (ObjectType.INETNUM.equals(update.getType()) && !VALIDATED_INETNUM_STATUSES.contains(getStatus(update))) { return; } if (ObjectType.INET6NUM.equals(update.getType()) && !VALIDATED_INET6NUM_STATUSES.contains(getStatus(update))) { return; } final Set<CIString> differences = update.getDifferences(AttributeType.MNT_LOWER); if (!differences.isEmpty() && !subject.hasPrincipal(Principal.RS_MAINTAINER)) { updateContext.addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void status_does_not_require_endMntnerAuthorisation_inetnum() { when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ALLOCATED PA")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void status_does_not_require_endMntnerAuthorisation_inet6num() { when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/24\nstatus: ALLOCATED-BY-LIR")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/24\nstatus: ALLOCATED-BY-LIR")); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_mntLower_added_inetnum() { when(authenticationSubject.hasPrincipal(Principal.ENDUSER_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("TEST-MNT")); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_mntLower_added_inetnum_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED PI")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED PI\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_mntLower_added_inet6num() { when(authenticationSubject.hasPrincipal(Principal.ENDUSER_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED PI")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED PI\nmnt-lower: TEST-MNT")); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_mntLower_added_inet6num_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED PI")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED PI\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_mntLower_removed_inetnum() { when(authenticationSubject.hasPrincipal(Principal.ENDUSER_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST")); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_mntLower_removed_inetnum_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_mntLower_removed_inet6num() { when(authenticationSubject.hasPrincipal(Principal.ENDUSER_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED ANYCAST")); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_mntLower_removed_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/48\nstatus: ASSIGNED ANYCAST")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_mntLowers_same_inetnum() { when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_mntLowers_same_inetnum_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_mntLowers_same_inet6num() { when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_mntLowers_same_inet6num_override() { when(authenticationSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff::/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext).getSubject(any(UpdateContainer.class)); verifyNoMoreInteractions(updateContext); }
@Test public void modify_authorisation_succeeds_inetnum() { when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: OTHER-MNT")); when(authenticationSubject.hasPrincipal(any(Principal.class))).thenReturn(true); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_authorisation_succeeds_inet6num() { when(update.getType()).thenReturn(ObjectType.INET6NUM); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inet6num: ffff/32\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inet6num: ffff::/32\nstatus: ASSIGNED ANYCAST\nmnt-lower: OTHER-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); }
@Test public void modify_fails_assigned_anycast_inetnum() { when(authenticationSubject.hasPrincipal(Principal.ENDUSER_MAINTAINER)).thenReturn(true); when(update.getType()).thenReturn(ObjectType.INETNUM); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("OTHER-MNT")); when(update.getReferenceObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: TEST-MNT")); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.0/24\nstatus: ASSIGNED ANYCAST\nmnt-lower: OTHER-MNT")); when(updateContext.getSubject(update)).thenReturn(authenticationSubject); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, UpdateMessages.authorisationRequiredForAttrChange(AttributeType.MNT_LOWER)); } |
AttributeSanitizer { public CIString sanitizeKey(final RpslObject originalObject) { final List<RpslAttribute> keyRelatedAttributes = getKeyRelatedAttributes(originalObject); return new RpslObject(sanitizeKeyAttributes(keyRelatedAttributes)).getKey(); } @Autowired AttributeSanitizer(DateTimeProvider dateTimeProvider); CIString sanitizeKey(final RpslObject originalObject); RpslObject sanitize(final RpslObject object, final ObjectMessages objectMessages); } | @Test public void transform_key_inetrtr_no_dot() { final RpslObject rpslObject = RpslObject.parse("" + "inet-rtr: test.ripe.net\n" + "alias: alias.ripe.net"); final CIString result = attributeSanitizer.sanitizeKey(rpslObject); assertThat(result.toString(), is("test.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_key_inetrtr_with_trailing_dot() { final RpslObject rpslObject = RpslObject.parse("" + "inet-rtr: test.ripe.net.\n" + "alias: alias.ripe.net"); final CIString result = attributeSanitizer.sanitizeKey(rpslObject); assertThat(result.toString(), is("test.ripe.net")); verifyNoMoreInteractions(objectMessages); }
@Test public void transform_key_domain_no_dot() { final RpslObject rpslObject = RpslObject.parse("domain: 17.45.212.in-addr.arpa"); final CIString result = attributeSanitizer.sanitizeKey(rpslObject); assertThat(result.toString(), is("17.45.212.in-addr.arpa")); }
@Test public void transform_keys_domain_with_trailing_dot() { final RpslObject rpslObject = RpslObject.parse("domain: 17.45.212.in-addr.arpa."); final CIString result = attributeSanitizer.sanitizeKey(rpslObject); assertThat(result.toString(), is("17.45.212.in-addr.arpa")); } |
AsblockByRsMaintainersOnlyValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
AsblockByRsMaintainersOnlyValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.AS_BLOCK)); } |
AsblockByRsMaintainersOnlyValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final boolean authenticatedByOverride = updateContext.getSubject(update).hasPrincipal(Principal.OVERRIDE_MAINTAINER); final boolean authenticatedByDbmMaintainer = updateContext.getSubject(update).hasPrincipal(Principal.DBM_MAINTAINER); if (!(authenticatedByOverride || authenticatedByDbmMaintainer)) { updateContext.addMessage(update, UpdateMessages.asblockIsMaintainedByRipe()); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_override_succeeds() { when(update.isOverride()).thenReturn(true); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.asblockIsMaintainedByRipe()); }
@Test public void validate_authenticatedByDbmMaintainer_succeeds() { when(update.isOverride()).thenReturn(false); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.DBM_MAINTAINER)).thenReturn(true); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.asblockIsMaintainedByRipe()); }
@Test public void validate_not_authenticatedByDbmMaintainer_or_override_fails() { when(update.isOverride()).thenReturn(false); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(subjectObject.hasPrincipal(Principal.DBM_MAINTAINER)).thenReturn(false); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.asblockIsMaintainedByRipe()); } |
AsblockHierarchyValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired AsblockHierarchyValidator(final RpslObjectDao rpslObjectDao); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); } | @Test public void testGetActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE)); } |
AsblockHierarchyValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired AsblockHierarchyValidator(final RpslObjectDao rpslObjectDao); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); } | @Test public void testGetTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.AS_BLOCK)); } |
AsblockHierarchyValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { AsBlockRange asBlockNew = AsBlockRange.parse(update.getUpdatedObject().getKey().toString()); final List<RpslObject> intersections = rpslObjectDao.findAsBlockIntersections(asBlockNew.getBegin(), asBlockNew.getEnd()); for (final RpslObject intersection : intersections) { final AsBlockRange asBlockExisting = AsBlockRange.parse(intersection.getKey().toString()); if (asBlockExisting.equals(asBlockNew)) { updateContext.addMessage(update, UpdateMessages.asblockAlreadyExists()); } else if (asBlockExisting.contains(asBlockNew)) { updateContext.addMessage(update, UpdateMessages.asblockParentAlreadyExists()); } else if (asBlockNew.contains(asBlockExisting)) { updateContext.addMessage(update, UpdateMessages.asblockChildAlreadyExists()); } else { updateContext.addMessage(update, UpdateMessages.intersectingAsblockAlreadyExists()); } } } @Autowired AsblockHierarchyValidator(final RpslObjectDao rpslObjectDao); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); } | @Test public void validate_asBlock_Parent_exists() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-block: AS10 - AS20")); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(rpslObjectDao.findAsBlockIntersections(10L, 20L)).thenReturn(Lists.newArrayList(RpslObject.parse("as-block: AS1 - AS30"))); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, UpdateMessages.asblockParentAlreadyExists()); }
@Test public void validate_asBlock_intersects() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-block: AS10 - AS20")); when(updateContext.getSubject(update)).thenReturn(subjectObject); when(rpslObjectDao.findAsBlockIntersections(10L, 20L)).thenReturn(Lists.newArrayList(RpslObject.parse("as-block: AS15 - AS30"))); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, UpdateMessages.intersectingAsblockAlreadyExists()); }
@Test public void validate_asBlock_child_exists() { when(updateContext.getSubject(update)).thenReturn(subjectObject); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-block: AS10 - AS15")); when(rpslObjectDao.findAsBlock(1L, 20L)).thenReturn(RpslObject.parse("as-block: AS10 - AS15")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.asblockChildAlreadyExists()); }
@Test public void validate_asBlock_intersects_on_boundaries() { when(updateContext.getSubject(update)).thenReturn(subjectObject); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-block: AS10 - AS15")); when(rpslObjectDao.findAsBlock(10L, 20L)).thenReturn(RpslObject.parse("as-block: AS10 - AS15")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.intersectingAsblockAlreadyExists()); }
@Test public void validate_already_exists() { when(updateContext.getSubject(update)).thenReturn(subjectObject); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("as-block: AS10 - AS15")); when(rpslObjectDao.findAsBlock(10L, 15L)).thenReturn(RpslObject.parse("as-block: AS10 - AS15")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(update, UpdateMessages.asblockAlreadyExists()); } |
PoemHasOnlyPublicMaintainerValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
PoemHasOnlyPublicMaintainerValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.POEM)); } |
PoemHasOnlyPublicMaintainerValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslAttribute mntByAttribute = update.getUpdatedObject().findAttribute(AttributeType.MNT_BY); if (!mntByAttribute.getCleanValue().equals(POEM_MAINTAINER)) { updateContext.addMessage(update, mntByAttribute, UpdateMessages.poemRequiresPublicMaintainer()); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_LIM_MNT() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "poem: POEM-FORM-LIMERICK\n" + "mnt-by: LIM-MNT\n")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_other_maintainer() { final RpslObject poem = RpslObject.parse("" + "poem: POEM-FORM-LIMERICK\n" + "mnt-by: DEV-MNT\n"); when(update.getUpdatedObject()).thenReturn(poem); subject.validate(update, updateContext); verify(updateContext).addMessage(update, poem.findAttribute(AttributeType.MNT_BY), UpdateMessages.poemRequiresPublicMaintainer()); } |
BogonValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); if (updatedObject == null) { return; } getPrefix(updatedObject).ifPresent(prefix -> { if (isBogon(prefix.toString())) { updateContext.addMessage(update, UpdateMessages.bogonPrefixNotAllowed(prefix.toString())); } }); } @Autowired BogonValidator(@Value("${ipranges.bogons:}") final String ... bogons); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void ipv6_exact_match_bogon() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route6: 2001:2::/48\norigin: AS3333\nsource: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.bogonPrefixNotAllowed("2001:2::/48")); verifyNoMoreInteractions(updateContext); }
@Test public void ipv4_exact_match_bogon() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route: 192.0.2.0/24\norigin: AS3333\nsource: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.bogonPrefixNotAllowed("192.0.2.0/24")); verifyNoMoreInteractions(updateContext); }
@Test public void ipv6_more_specific_bogon() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route6: 2001:2:0:1::/64\norigin: AS3333\nsource: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.bogonPrefixNotAllowed("2001:2:0:1::/64")); verifyNoMoreInteractions(updateContext); }
@Test public void ipv4_more_specific_bogon() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route: 192.0.2.1/32\norigin: AS3333\nsource: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.bogonPrefixNotAllowed("192.0.2.1/32")); verifyNoMoreInteractions(updateContext); }
@Test public void ipv6_not_bogon() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route6: 2002:1:2:3::/64\norigin: AS3333\nsource: TEST")); subject.validate(update, updateContext); verifyNoMoreInteractions(updateContext); }
@Test public void ipv4_not_bogon() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("route: 193.201.1.0/24\norigin: AS3333\nsource: TEST")); subject.validate(update, updateContext); verifyNoMoreInteractions(updateContext); } |
ValueWithinPrefixValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetActions() throws Exception { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
ValueWithinPrefixValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void testGetTypes() throws Exception { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.ROUTE, ObjectType.ROUTE6)); } |
ValueWithinPrefixValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedRouteObject = update.getUpdatedObject(); final AttributeType attributeType = findAttributeType(updatedRouteObject); final CIString prefix = updatedRouteObject.findAttribute(attributeType).getCleanValue(); for (final RpslAttribute holeAttribute : updatedRouteObject.findAttributes(AttributeType.HOLES)) { for (final CIString hole : holeAttribute.getCleanValues()) { validatePrefixForHolesAttribute(update, updateContext, AddressPrefixRange.parse(hole), prefix, holeAttribute); } } for (final RpslAttribute pingableAttribute : updatedRouteObject.findAttributes(AttributeType.PINGABLE)) { for (final CIString pingable : pingableAttribute.getCleanValues()) { validatePrefixForPingableAttribute(update, updateContext, pingable, prefix, pingableAttribute); } } final IpInterval ipInterval = IpInterval.parse(prefix); if ((ipInterval.getPrefixLength() < 8 && attributeType == AttributeType.ROUTE) || (ipInterval.getPrefixLength() < 12 && attributeType == AttributeType.ROUTE6)) { updateContext.addMessage(update, UpdateMessages.invalidRoutePrefix(attributeType.getName())); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void route_with_one_holes_attribute_outside_prefixrange() { final RpslObject route = RpslObject.parse("route:195.190.20.0/24\norigin:AS43746\nholes:94.73.128.0/24"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, route.findAttribute(AttributeType.HOLES), UpdateMessages.invalidRouteRange("94.73.128.0/24")); }
@Test public void route_with_many_holes_attributes_outside_prefixrange() { final RpslObject route = RpslObject.parse("route:195.190.20.0/24\norigin:AS43746\nholes:94.73.128.0/24\nholes:94.73.134.0/24"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); List<RpslAttribute> rpslAttributes = route.findAttributes(AttributeType.HOLES); verify(updateContext, times(1)).addMessage(update, rpslAttributes.get(0), UpdateMessages.invalidRouteRange("94.73.128.0/24")); verify(updateContext, times(1)).addMessage(update, rpslAttributes.get(1), UpdateMessages.invalidRouteRange("94.73.134.0/24")); }
@Test public void route_with_holes_attribute_list_outside_prefixrange() { final RpslObject route = RpslObject.parse("route:195.190.20.0/24\norigin:AS43746\nholes:94.73.128.0/24,94.73.134.0/24"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, route.findAttribute(AttributeType.HOLES), UpdateMessages.invalidRouteRange("94.73.128.0/24")); verify(updateContext, times(1)).addMessage(update, route.findAttribute(AttributeType.HOLES), UpdateMessages.invalidRouteRange("94.73.134.0/24")); }
@Test public void route_with_holes_attribute_list_inside_prefixrange() { final RpslObject route = RpslObject.parse("route:94.73.128.0/18\norigin:AS43746\nholes:94.73.129.0/24, 94.73.131.0/24\nholes:94.73.137.0/24"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void route6_with_one_holes_attribute_outside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a02:2a98::/32\norigin:AS43746\nholes:2a01:568:4000::/36"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, route6.findAttribute(AttributeType.HOLES), UpdateMessages.invalidRouteRange("2a01:568:4000::/36")); }
@Test public void route6_with_many_holes_attributes_outside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a02:2a98::/32\norigin:AS43746\nholes:2a01:758:4000::/48\nholes:2a01:758:5000::/48"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); List<RpslAttribute> rpslAttributes = route6.findAttributes(AttributeType.HOLES); verify(updateContext, times(1)).addMessage(update, rpslAttributes.get(0), UpdateMessages.invalidRouteRange("2a01:758:4000::/48")); verify(updateContext, times(1)).addMessage(update, rpslAttributes.get(1), UpdateMessages.invalidRouteRange("2a01:758:5000::/48")); }
@Test public void route6_with_holes_attribute_list_outside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a02:2a98::/32\norigin:AS43746\nholes:2a01:758:4000::/48,2a01:758:5000::/48"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, route6.findAttribute(AttributeType.HOLES), UpdateMessages.invalidRouteRange("2a01:758:4000::/48")); verify(updateContext, times(1)).addMessage(update, route6.findAttribute(AttributeType.HOLES), UpdateMessages.invalidRouteRange("2a01:758:5000::/48")); }
@Test public void route6_with_holes_attribute_list_inside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a02:2020::/32\norigin:AS43746\nholes:2A02:2020:0000:0000::/48,2A02:2020:0001:0000::/48\nholes:2A02:2020:0002:0000::/48"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void route6_with_one_pingable_attribute_outside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a02:2a98::/32\norigin:AS43746\npingable:2a00:9e80::1"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, route6.findAttribute(AttributeType.PINGABLE), UpdateMessages.invalidRouteRange("2a00:9e80::1")); }
@Test public void route6_with_many_pingable_attributes_outside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a02:2a98::/32\norigin:AS43746\npingable:2a00:1e88:e::4\npingable:2a00:1e88:e::5"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); List<RpslAttribute> pingableAttribute = route6.findAttributes(AttributeType.PINGABLE); verify(updateContext, times(1)).addMessage(update, pingableAttribute.get(0), UpdateMessages.invalidRouteRange("2a00:1e88:e::4")); verify(updateContext, times(1)).addMessage(update, pingableAttribute.get(1), UpdateMessages.invalidRouteRange("2a00:1e88:e::5")); }
@Test public void route6_with_pingable_attribute_list_inside_prefixrange() { final RpslObject route6 = RpslObject.parse("route6:2a00:1e88::/32\norigin:AS43746\npingable:2a00:1e88:e::4\npingable:2a00:1e88:e::5"); when(update.getUpdatedObject()).thenReturn(route6); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void route_with_one_pingable_attribute_outside_prefixrange() { final RpslObject route = RpslObject.parse("route: 84.40.47.0/24\norigin:AS43746\npingable:93.191.209.1"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verify(updateContext, times(1)).addMessage(update, route.findAttribute(AttributeType.PINGABLE), UpdateMessages.invalidRouteRange("93.191.209.1")); }
@Test public void route_with_many_pingable_attributes_outside_prefixrange() { final RpslObject route = RpslObject.parse("route:84.40.47.0/24\norigin:AS43746\npingable:95.180.201.1\npingable:93.191.209.1"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); List<RpslAttribute> pingableAttribute = route.findAttributes(AttributeType.PINGABLE); verify(updateContext, times(1)).addMessage(update, pingableAttribute.get(0), UpdateMessages.invalidRouteRange("95.180.201.1")); verify(updateContext, times(1)).addMessage(update, pingableAttribute.get(1), UpdateMessages.invalidRouteRange("93.191.209.1")); }
@Test public void route_with_pingable_attribute_list_inside_prefixrange() { final RpslObject route = RpslObject.parse("route:93.191.209.0/24\norigin:AS43746\npingable:93.191.209.1\npingable:93.191.209.2"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void route_with_pingable_and_holes_attribute_list_inside_prefixrange() { final RpslObject route = RpslObject.parse("route:93.191.209.0/24\norigin:AS43746\npingable:93.191.209.1\npingable:93.191.209.2\nholes:93.191.209.0/31"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void route_too_large() { final RpslObject route = RpslObject.parse("route:92.0.0.0/7\norigin:AS43746"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.invalidRoutePrefix("route")); }
@Test public void route_not_too_large() { final RpslObject route = RpslObject.parse("route:92.0.0.0/8\norigin:AS43746"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void route6_too_large() { final RpslObject route = RpslObject.parse("route6:2a02:2a98::/11\norigin:AS43746"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.invalidRoutePrefix("route6")); }
@Test public void route6_not_too_large() { final RpslObject route = RpslObject.parse("route6:2a02:2a98::/12\norigin:AS43746"); when(update.getUpdatedObject()).thenReturn(route); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); } |
MaintainerNameValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
AddOrRemoveRipeNccMaintainerValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired AddOrRemoveRipeNccMaintainerValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
AddOrRemoveRipeNccMaintainerValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired AddOrRemoveRipeNccMaintainerValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.values())); } |
AddOrRemoveRipeNccMaintainerValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (updateContext.getSubject(update).hasPrincipal(Principal.OVERRIDE_MAINTAINER)) { return; } validateForSpecialMaintainer(Principal.RS_MAINTAINER, maintainers.getRsMaintainers(), update, updateContext); validateForSpecialMaintainer(Principal.DBM_MAINTAINER, maintainers.getDbmMaintainers(), update, updateContext); } @Autowired AddOrRemoveRipeNccMaintainerValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_no_rs_auth_no_rs_maintainer_added() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DEV-MNT\n")); when(update.getDifferences(AttributeType.MNT_BY)).thenReturn(ciSet("DEV-MNT")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); }
@Test public void validate_no_rs_auth_rs_maintainer_added() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: RS-MNT\n")); when(update.getDifferences(AttributeType.MNT_BY)).thenReturn(ciSet("RS-MNT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_no_rs_auth_rs_maintainer_added_mnt_domains() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-domains: RS-MNT\n")); when(update.getDifferences(AttributeType.MNT_DOMAINS)).thenReturn(ciSet("RS-MNT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_no_rs_auth_rs_maintainer_added_mnt_lower() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-lower: RS-MNT\n")); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("RS-MNT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_no_rs_auth_rs_maintainer_added_mnt_routes() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-routes: RS-MNT ANY\n")); when(update.getDifferences(AttributeType.MNT_ROUTES)).thenReturn(ciSet("RS-MNT ANY")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_rs_auth_rs_maintainer_added() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: RS-MNT\n")); when(update.getDifferences(AttributeType.MNT_BY)).thenReturn(ciSet("RS-MNT")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); }
@Test public void validate_dbm_auth_dbm_maintainer_added() { when(authSubject.hasPrincipal(Principal.DBM_MAINTAINER)).thenReturn(true); when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DBM-MNT\n" + "mnt-lower: HM-MNT\n")); when(update.getDifferences(AttributeType.MNT_BY)).thenReturn(ciSet("DBM-MNT")); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("HM-MNT")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); }
@Test public void validate_dbm_auth_dbm_maintainer_added_by_rs_maintainer() { when(authSubject.hasPrincipal(Principal.DBM_MAINTAINER)).thenReturn(false); when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DBM-MNT\n" + "mnt-lower: HM-MNT\n")); when(update.getDifferences(AttributeType.MNT_BY)).thenReturn(ciSet("DBM-MNT")); when(update.getDifferences(AttributeType.MNT_LOWER)).thenReturn(ciSet("HM-MNT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_no_rs_auth_rs_maintainer_added_mnt_ref() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-ref: RS-MNT\n")); when(update.getDifferences(AttributeType.MNT_REF)).thenReturn(ciSet("RS-MNT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_no_dbm_auth_dbm_maintainer_added_mnt_ref() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-ref: RS-MNT\n")); when(update.getDifferences(AttributeType.MNT_REF)).thenReturn(ciSet("DBM-MNT")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForChangingRipeMaintainer()); }
@Test public void validate_added_override() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-routes: RS-MNT ANY\n")); when(update.getDifferences(AttributeType.MNT_ROUTES)).thenReturn(ciSet("RS-MNT")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); } |
ExportFileWriter { public void write(final RpslObject object, final List<Tag> tags) throws IOException { if (exportFilter.shouldExport(object)) { final String filename = filenameStrategy.getFilename(object.getType()); if (filename != null) { final Writer writer = getWriter(filename); final RpslObject decoratedObject = decorationStrategy.decorate(object); if (decoratedObject != null) { writer.write('\n'); decoratedObject.writeTo(writer); if (!tags.isEmpty()) { writer.write('\n'); writer.write(new TagResponseObject(decoratedObject.getKey(), tags).toString()); } } } } } ExportFileWriter(final File baseDir,
final FilenameStrategy filenameStrategy,
final DecorationStrategy decorationStrategy,
final ExportFilter exportFilter); void write(final RpslObject object, final List<Tag> tags); void close(); } | @SuppressWarnings("unchecked") @Test public void write() throws IOException { subject.write(RpslObject.parse("mntner: DEV-MNT1"), Collections.EMPTY_LIST); subject.write(RpslObject.parse("mntner: DEV-MNT2"), Collections.EMPTY_LIST); subject.write(RpslObject.parse("mntner: DEV-MNT3"), Collections.EMPTY_LIST); subject.write(RpslObject.parse("mntner: DEV-MNT4"), Collections.EMPTY_LIST); subject.write(RpslObject.parse("inetnum: 193.0.0.0 - 193.0.0.10"), Collections.EMPTY_LIST); subject.write(RpslObject.parse("route: 193.0.0.0 - 193.0.0.10\norigin: AS12"), Lists.newArrayList(new Tag(CIString.ciString("foo"), 3, "bar"))); subject.close(); final File[] files = folder.getRoot().listFiles(); Assert.assertNotNull(files); Assert.assertThat(files.length, Matchers.is(21)); for (final File file : files) { final String fileName = file.getName(); if (fileName.endsWith("mntner.gz")) { checkFile(file, "" + "mntner: DEV-MNT1\n" + "\n" + "mntner: DEV-MNT2\n" + "\n" + "mntner: DEV-MNT3\n" + "\n" + "mntner: DEV-MNT4\n"); } else if (fileName.endsWith("inetnum.gz")) { checkFile(file, "" + "inetnum: 193.0.0.0 - 193.0.0.10\n"); } else if (fileName.endsWith("route.gz")) { checkFile(file, "" + "route: 193.0.0.0 - 193.0.0.10\n" + "origin: AS12\n\n" + QueryMessages.tagInfoStart("193.0.0.0 - 193.0.0.10AS12") + QueryMessages.tagInfo("foo", "bar")); } } } |
AbuseCDuplicateValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final CIString abuseC = update.getUpdatedObject().getValueOrNullForAttribute(AttributeType.ABUSE_C); if (abuseC == null) { return; } final RpslObject orgAbuseCObject = findOrgAbuseC(update.getUpdatedObject()); if (orgAbuseCObject == null) { return; } if (orgAbuseCObject.getValueForAttribute(AttributeType.ABUSE_C).equals(abuseC)) { updateContext.addMessage(update, UpdateMessages.duplicateAbuseC(abuseC, orgAbuseCObject.getKey())); } } @Autowired AbuseCDuplicateValidator(final Ipv4Tree ipv4Tree, final Ipv6Tree ipv6Tree, final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void no_abuse_c() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.168.0.0 - 192.168.255.255\nsource: TEST")); subject.validate(update, updateContext); verifyNoMoreInteractions(updateContext); }
@Test public void has_abuse_c_but_no_org() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.168.0.0 - 192.168.255.255\nabuse-c: AA1-TEST\nsource: TEST")); subject.validate(update, updateContext); verifyNoMoreInteractions(updateContext); }
@Test public void org_abuse_c_matches_inetnum_abuse_c() { when(update.getUpdatedObject()).thenReturn( RpslObject.parse( "inetnum: 192.168.0.0 - 192.168.255.255\n" + "org: ORG-AA1-TEST\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); when(rpslObjectDao.getByKeyOrNull(ObjectType.ORGANISATION, CIString.ciString("ORG-AA1-TEST"))).thenReturn( RpslObject.parse( "organisation: ORG-AA1-TEST\n" + "org-name: Any Any\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.duplicateAbuseC(CIString.ciString("AA1-TEST"), CIString.ciString("ORG-AA1-TEST"))); verifyNoMoreInteractions(updateContext); }
@Test public void org_abuse_c_does_not_match_inetnum_abuse_c() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("inetnum: 192.168.0.0 - 192.168.255.255\norg: ORG-AA1-TEST\nabuse-c: AA1-TEST\nsource: TEST")); when(rpslObjectDao.getByKeyOrNull(ObjectType.ORGANISATION, CIString.ciString("ORG-AA1-TEST"))).thenReturn( RpslObject.parse( "organisation: ORG-AA1-TEST\n" + "org-name: Any Any\n" + "abuse-c: BB1-TEST\n" + "source: TEST")); subject.validate(update, updateContext); verifyNoMoreInteractions(updateContext); }
@Test public void org_abuse_c_matches_inet6num_abuse_c() { when(update.getUpdatedObject()).thenReturn( RpslObject.parse( "inet6num: 2001:67c:2e8::/48\n" + "org: ORG-AA1-TEST\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); when(rpslObjectDao.getByKeyOrNull(ObjectType.ORGANISATION, CIString.ciString("ORG-AA1-TEST"))).thenReturn( RpslObject.parse( "organisation: ORG-AA1-TEST\n" + "org-name: Any Any\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.duplicateAbuseC(CIString.ciString("AA1-TEST"), CIString.ciString("ORG-AA1-TEST"))); verifyNoMoreInteractions(updateContext); }
@Test public void org_abuse_c_matches_autnum_abuse_c() { when(update.getUpdatedObject()).thenReturn( RpslObject.parse( "aut-num: AS3333\n" + "org: ORG-AA1-TEST\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); when(rpslObjectDao.getByKeyOrNull(ObjectType.ORGANISATION, CIString.ciString("ORG-AA1-TEST"))).thenReturn( RpslObject.parse( "organisation: ORG-AA1-TEST\n" + "org-name: Any Any\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.duplicateAbuseC(CIString.ciString("AA1-TEST"), CIString.ciString("ORG-AA1-TEST"))); verifyNoMoreInteractions(updateContext); }
@Test public void org_abuse_c_matches_parent_inetnum_abuse_c() { when(update.getUpdatedObject()).thenReturn( RpslObject.parse( "inetnum: 192.168.0.0 - 192.168.255.255\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); when(ipv4Tree.findFirstLessSpecific(Ipv4Resource.parse("192.168.0.0/16"))).thenReturn( Collections.singletonList( new Ipv4Entry(Ipv4Resource.parse("192.168.0.0/16"), 101))); when(rpslObjectDao.getById(101)).thenReturn( RpslObject.parse( "inetnum: 192.0.0.0 - 192.255.255.255\n" + "org: ORG-AA1-TEST\n" + "source: TEST")); when(rpslObjectDao.getByKeyOrNull(ObjectType.ORGANISATION, CIString.ciString("ORG-AA1-TEST"))).thenReturn( RpslObject.parse( "organisation: ORG-AA1-TEST\n" + "org-name: Any Any\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.duplicateAbuseC(CIString.ciString("AA1-TEST"), CIString.ciString("ORG-AA1-TEST"))); verifyNoMoreInteractions(updateContext); }
@Test public void org_abuse_c_matches_parent_inet6num_abuse_c() { when(update.getUpdatedObject()).thenReturn( RpslObject.parse( "inet6num: 2001:67c:2e8::/48\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); when(ipv6Tree.findFirstLessSpecific(Ipv6Resource.parse("2001:67c:2e8::/48"))).thenReturn( Collections.singletonList( new Ipv6Entry(Ipv6Resource.parse("2001:67c::/32"), 102))); when(rpslObjectDao.getById(102)).thenReturn( RpslObject.parse( "inet6num: 2001:67c::/32\n" + "org: ORG-AA1-TEST\n" + "source: TEST")); when(rpslObjectDao.getByKeyOrNull(ObjectType.ORGANISATION, CIString.ciString("ORG-AA1-TEST"))).thenReturn( RpslObject.parse( "organisation: ORG-AA1-TEST\n" + "org-name: Any Any\n" + "abuse-c: AA1-TEST\n" + "source: TEST")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.duplicateAbuseC(CIString.ciString("AA1-TEST"), CIString.ciString("ORG-AA1-TEST"))); verifyNoMoreInteractions(updateContext); } |
DummifierRC extends DummifierCurrent { @Override public RpslObject dummify(final int version, final RpslObject rpslObject) { final List<RpslAttribute> attributes = Lists.newArrayList(rpslObject.getAttributes()); for (int i = 0; i < attributes.size(); i++) { RpslAttribute replacement = attributes.get(i); replacement = dummifyOrgName(rpslObject, replacement); replacement = dummifyDescr(replacement); replacement = dummifyRemarks(replacement); replacement = dummifyAsName(replacement); replacement = dummifyOwner(replacement); attributes.set(i, replacement); } return super.dummify(version, new RpslObject(rpslObject, attributes)); } @Override RpslObject dummify(final int version, final RpslObject rpslObject); } | @Test public void dummify_organisation() { final RpslObject before = RpslObject.parse( "organisation: ORG-RIEN1-TEST\n" + "org-name: Reseaux IP Europeens Network Coordination Centre (RIPE NCC)\n" + "org-type: LIR\n" + "descr: RIPE NCC Operations\n" + "address: Singel 256\n" + "address: Amsterdam\n" + "address: Netherlands\n" + "phone: +31205552222\n" + "fax-no: +31205552266\n" + "admin-c: AC1-TEST\n" + "admin-c: AC2-TEST\n" + "abuse-c: AR1-TEST\n" + "mnt-ref: TEST-MNT\n" + "mnt-by: TEST-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2020-09-22T09:00:00Z\n" + "source: TEST"); final RpslObject after = subject.dummify(3, before); assertThat(after.toString(), is( "organisation: ORG-RIEN1-TEST\n" + "org-name: Dummy org-name for ORG-RIEN1-TEST\n" + "org-type: LIR\n" + "descr: ***\n" + "address: ***\n" + "address: ***\n" + "address: Netherlands\n" + "phone: +31205......\n" + "fax-no: +31205......\n" + "admin-c: AC1-TEST\n" + "admin-c: AC2-TEST\n" + "abuse-c: AR1-TEST\n" + "mnt-ref: TEST-MNT\n" + "mnt-by: TEST-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2020-09-22T09:00:00Z\n" + "source: TEST\n")); }
@Test public void dummify_role() { final RpslObject before = RpslObject.parse( "role: Abuse Contact\n" + "descr: RIPE NCC Operations\n" + "address: Singel 256\n" + "address: Amsterdam\n" + "address: Netherlands\n" + "e-mail: [email protected]\n" + "nic-hdl: AC1-TEST\n" + "remarks: Abuse\n" + "+Contact\n" + "\tRole\n" + "abuse-mailbox: [email protected]\n" + "mnt-by: TEST-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2020-09-22T09:00:00Z\n" + "source: TEST"); final RpslObject after = subject.dummify(3, before); assertThat(after.toString(), is( "role: Abuse Contact\n" + "descr: ***\n" + "address: Singel 256\n" + "address: Amsterdam\n" + "address: Netherlands\n" + "e-mail: ***@ripe.net\n" + "nic-hdl: AC1-TEST\n" + "remarks: ***\n" + "abuse-mailbox: [email protected]\n" + "mnt-by: TEST-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2020-09-22T09:00:00Z\n" + "source: TEST\n")); }
@Test public void dummify_aut_num() { final RpslObject before = RpslObject.parse( "aut-num: AS3333\n" + "descr: RIPE NCC Operations\n" + "as-name: RIPE_NCC_AS_NAME\n" + "admin-c: AC1-TEST\n" + "tech-c: TC1-TEST\n" + "mnt-by: TEST-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2020-09-22T09:00:00Z\n" + "source: TEST"); final RpslObject after = subject.dummify(3, before); assertThat(after.toString(), is( "aut-num: AS3333\n" + "descr: ***\n" + "as-name: ***\n" + "admin-c: AC1-TEST\n" + "tech-c: TC1-TEST\n" + "mnt-by: TEST-MNT\n" + "created: 1970-01-01T00:00:00Z\n" + "last-modified: 2020-09-22T09:00:00Z\n" + "source: TEST\n")); }
@Test public void dummify_keycert() { final RpslObject before = RpslObject.parse( "key-cert: PGPKEY-57639544\n" + "method: PGP\n" + "owner: Test Person <[email protected]>\n" + "fingerpr: 2A4F DFBE F26C 1951 449E B450 73BB 96F8 5763 9544\n" + "certif: -----BEGIN PGP PUBLIC KEY BLOCK-----\n" + "certif: -----END PGP PUBLIC KEY BLOCK-----\n" + "notify: [email protected]\n" + "mnt-by: TEST-MNT\n" + "source: TEST\n"); final RpslObject after = subject.dummify(3, before); assertThat(after.toString(), is( "key-cert: PGPKEY-57639544\n" + "method: PGP\n" + "owner: ***\n" + "fingerpr: 2A4F DFBE F26C 1951 449E B450 73BB 96F8 5763 9544\n" + "certif: -----BEGIN PGP PUBLIC KEY BLOCK-----\n" + "certif: -----END PGP PUBLIC KEY BLOCK-----\n" + "notify: ***@ripe.net\n" + "mnt-by: TEST-MNT\n" + "source: TEST\n")); } |
DeleteRsMaintainedObjectValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired DeleteRsMaintainedObjectValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.DELETE)); } |
DeleteRsMaintainedObjectValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Autowired DeleteRsMaintainedObjectValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.values())); } |
DeleteRsMaintainedObjectValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Subject subject = updateContext.getSubject(update); if (subject.hasPrincipal(Principal.OVERRIDE_MAINTAINER) || subject.hasPrincipal(Principal.RS_MAINTAINER)) { return; } final Set<CIString> mntBys = update.getUpdatedObject().getValuesForAttribute(AttributeType.MNT_BY); if (maintainers.isRsMaintainer(mntBys)) { updateContext.addMessage(update, UpdateMessages.authorisationRequiredForDeleteRsMaintainedObject()); } } @Autowired DeleteRsMaintainedObjectValidator(final Maintainers maintainers); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_no_rs_auth_no_rs_maintainer() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DEV-MNT\n")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verify(maintainers).isRsMaintainer(ciSet("DEV-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_no_rs_auth_rs_maintainer() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DEV-MNT\n" + "mnt-by: RS-MNT\n")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.authorisationRequiredForDeleteRsMaintainedObject()); verify(maintainers).isRsMaintainer(ciSet("DEV-MNT", "RS-MNT")); verifyNoMoreInteractions(maintainers); }
@Test public void validate_no_rs_auth_rs_maintainer_override() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(false); when(authSubject.hasPrincipal(Principal.OVERRIDE_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DEV-MNT\n" + "mnt-by: RS-MNT\n")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verifyZeroInteractions(maintainers); }
@Test public void validate_rs_auth_rs_maintainer() { when(authSubject.hasPrincipal(Principal.RS_MAINTAINER)).thenReturn(true); when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "mntner: DEV-MNT\n" + "mnt-by: DEV-MNT\n" + "mnt-by: RS-MNT\n")); subject.validate(update, updateContext); verify(updateContext, never()).addMessage(eq(update), any(Message.class)); verifyZeroInteractions(maintainers); } |
ReservedWordValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE)); } |
ReservedWordValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); if (updatedObject == null) { return; } final CIString primaryKey = updatedObject.getKey(); if (RESERVED_WORDS.contains(primaryKey)) { updateContext.addMessage(update, UpdateMessages.reservedNameUsed(primaryKey.toLowerCase())); return; } for (Map.Entry<CIString, ObjectType> entry : RESERVED_PREFIXES.entrySet()) { if (primaryKey.startsWith(entry.getKey()) && (!updatedObject.getType().equals(entry.getValue()))) { updateContext.addMessage(update, UpdateMessages.reservedPrefixUsed(entry.getKey(), entry.getValue())); return; } } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void not_reserved_word() { mockUpdate("mntner: OWNER-MNT\nsource: TEST"); subject.validate(update, updateContext); verifyOk(); }
@Test public void reserved_word_as_any_not_ok() { mockUpdate("as-set: AS-ANy\nsource: TEST"); subject.validate(update, updateContext); verifyReservedName("as-any"); }
@Test public void reserved_prefix_as_not_ok() { mockUpdate("mntner: AS-TEST\nsource: TEST"); subject.validate(update, updateContext); verifyReservedPrefixUsed("as-", ObjectType.AS_SET); }
@Test public void reserved_prefix_org_not_ok() { mockUpdate("mntner: ORG-TEST\nsource: TEST"); subject.validate(update, updateContext); verifyReservedPrefixUsed("org-", ObjectType.ORGANISATION); }
@Test public void reserved_prefix_as_ok() { mockUpdate("as-set: AS-TEST\nsource: TEST"); subject.validate(update, updateContext); verifyOk(); } |
MaintainedReferencedMaintainerPersonRolesValidator extends AbstractObjectIsMaintainedValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired MaintainedReferencedMaintainerPersonRolesValidator(final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
MntRoutesValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), contains(Action.CREATE, Action.MODIFY)); } |
MntRoutesValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), contains(ObjectType.INET6NUM, ObjectType.INETNUM, ObjectType.ROUTE, ObjectType.ROUTE6)); } |
MntRoutesValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final Map<MntRoutes, RpslAttribute> mntRoutesMap = Maps.newHashMap(); for (final RpslAttribute attribute : update.getUpdatedObject().findAttributes(AttributeType.MNT_ROUTES)) { for (final CIString mntRoutesValue : attribute.getCleanValues()) { try { final MntRoutes mntRoutes = MntRoutes.parse(mntRoutesValue); for (final Map.Entry<MntRoutes, RpslAttribute> mntRoutesEntry : mntRoutesMap.entrySet()) { final MntRoutes otherMntRoutes = mntRoutesEntry.getKey(); if (mntRoutes.getMaintainer().equals(otherMntRoutes.getMaintainer()) && mntRoutes.isAnyRange() != otherMntRoutes.isAnyRange()) { final RpslAttribute otherAttribute = mntRoutesEntry.getValue(); syntaxError(update, updateContext, otherAttribute); syntaxError(update, updateContext, attribute); } } mntRoutesMap.put(mntRoutes, attribute); } catch (AttributeParseException e) { syntaxError(update, updateContext, attribute); } } } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_single_valid_any() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT any\n" + "source: TEST\n")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_single_valid_range() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT {20.13.0.0/16^+}\n" + "source: TEST\n")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_single_invalid() { final RpslObject rpslObject = RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT {any, 20.13.0.0/16^+}\n" + "source: TEST\n"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verify(updateContext).addMessage(update, rpslObject.findAttribute(AttributeType.MNT_ROUTES), new Message(Messages.Type.ERROR, "Syntax error in EXACT-MR-MNT {any, 20.13.0.0/16^+} (ANY can only occur as a single value)")); }
@Test public void validate_multiple_valid_any() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT any\n" + "mnt-routes: EXACT-MR-MNT any\n" + "source: TEST\n")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_lots_valid_any() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT any\n" + "mnt-routes: EXACT-MR-MNT any\n" + "mnt-routes: EXACT-MR-MNT any\n" + "mnt-routes: EXACT-MR-MNT any\n" + "source: TEST\n")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_multiple_valid_range() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT {20.13.0.0/16^+}\n" + "mnt-routes: EXACT-MR-MNT {20.13.0.0/16}\n" + "source: TEST\n")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); }
@Test public void validate_multiple_invalid_range() { final RpslObject rpslObject = RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT {20.13.0.0/16^+}\n" + "mnt-routes: EXACT-MR-MNT any\n" + "source: TEST\n"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); final List<RpslAttribute> attributes = rpslObject.findAttributes(AttributeType.MNT_ROUTES); verify(updateContext).addMessage(update, attributes.get(0), new Message(Messages.Type.ERROR, "Syntax error in EXACT-MR-MNT {20.13.0.0/16^+} (ANY can only occur as a single value)")); verify(updateContext).addMessage(update, attributes.get(1), new Message(Messages.Type.ERROR, "Syntax error in EXACT-MR-MNT any (ANY can only occur as a single value)")); }
@Test public void validate_multiple_different_maintainers() { final RpslObject rpslObject = RpslObject.parse("" + "route: 20.13.0.0/16\n" + "origin: AS3000\n" + "mnt-routes: EXACT-MR-MNT1 {20.13.0.0/16^+}\n" + "mnt-routes: EXACT-MR-MNT2 any\n" + "source: TEST\n"); when(update.getUpdatedObject()).thenReturn(rpslObject); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); } |
NewKeywordValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE)); } |
NewKeywordValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { if (update.hasOriginalObject()) { updateContext.addMessage(update, UpdateMessages.newKeywordAndObjectExists()); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_create_with_existing() { when(preparedUpdate.getAction()).thenReturn(Action.CREATE); when(preparedUpdate.hasOriginalObject()).thenReturn(true); subject.validate(preparedUpdate, updateContext); verify(updateContext).addMessage(preparedUpdate, UpdateMessages.newKeywordAndObjectExists()); }
@Test public void validate_create_without() { when(preparedUpdate.getAction()).thenReturn(Action.CREATE); when(preparedUpdate.hasOriginalObject()).thenReturn(false); subject.validate(preparedUpdate, updateContext); verifyZeroInteractions(updateContext); } |
MaintainedReferencedPersonRolesValidator extends AbstractObjectIsMaintainedValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired MaintainedReferencedPersonRolesValidator(final RpslObjectDao rpslObjectDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
SourceCommentValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
SourceCommentValidator implements BusinessRuleValidator { @Override public ImmutableList<ObjectType> getTypes() { return TYPES; } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getTypes() { assertThat(subject.getTypes(), containsInAnyOrder(ObjectType.values())); } |
SourceCommentValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final String source = update.getUpdatedObject().findAttribute(SOURCE).getValue(); if (REMARK_PATTERN.matcher(source).matches()) { updateContext.addMessage(update, UpdateMessages.commentInSourceNotAllowed()); } } @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void source_attribute_has_comment() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("mntner: TEST-MNT\nsource: TEST # comment")); subject.validate(update, updateContext); verify(updateContext).addMessage(update, UpdateMessages.commentInSourceNotAllowed()); }
@Test public void source_attribute_has_no_comment() { when(update.getUpdatedObject()).thenReturn(RpslObject.parse("mntner: TEST-MNT\nsource: TEST")); subject.validate(update, updateContext); verifyZeroInteractions(updateContext); } |
ReferencedObjectsExistValidator implements BusinessRuleValidator { @Override public ImmutableList<Action> getActions() { return ACTIONS; } @Autowired ReferencedObjectsExistValidator(final RpslObjectUpdateDao rpslObjectUpdateDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void getActions() { assertThat(subject.getActions(), containsInAnyOrder(Action.CREATE, Action.MODIFY)); } |
ReferencedObjectsExistValidator implements BusinessRuleValidator { @Override public void validate(final PreparedUpdate update, final UpdateContext updateContext) { final RpslObject updatedObject = update.getUpdatedObject(); final Map<RpslAttribute, Set<CIString>> invalidReferences = rpslObjectUpdateDao.getInvalidReferences(updatedObject); final ObjectMessages objectMessages = updateContext.getMessages(update); for (final Map.Entry<RpslAttribute, Set<CIString>> invalidReferenceEntry : invalidReferences.entrySet()) { final RpslAttribute attribute = invalidReferenceEntry.getKey(); if (objectMessages.getMessages(attribute).getErrors().isEmpty()) { updateContext.addMessage(update, attribute, UpdateMessages.unknownObjectReferenced(StringUtils.join(invalidReferenceEntry.getValue(), ','))); } } } @Autowired ReferencedObjectsExistValidator(final RpslObjectUpdateDao rpslObjectUpdateDao); @Override void validate(final PreparedUpdate update, final UpdateContext updateContext); @Override ImmutableList<Action> getActions(); @Override ImmutableList<ObjectType> getTypes(); } | @Test public void validate_no_invalid_references() { when(rpslObjectUpdateDao.getInvalidReferences(object)).thenReturn(Collections.<RpslAttribute, Set<CIString>>emptyMap()); subject.validate(update, updateContext); verify(updateContext).getMessages(update); verifyNoMoreInteractions(updateContext); }
@Test public void validate_invalid_references() { final RpslAttribute invalidAttribute = object.getAttributes().get(1); final Map<RpslAttribute, Set<CIString>> invalidReferences = Maps.newHashMap(); invalidReferences.put(invalidAttribute, invalidAttribute.getCleanValues()); when(updateContext.getMessages(update)).thenReturn(new ObjectMessages()); when(rpslObjectUpdateDao.getInvalidReferences(object)).thenReturn(invalidReferences); subject.validate(update, updateContext); verify(updateContext).addMessage(update, invalidAttribute, UpdateMessages.unknownObjectReferenced("ADMIN_NC")); } |
Subsets and Splits