Add fixme to adapter.
MODIFY
dd-java-agent/instrumentation/jetty-8/src/main/java/datadog/trace/instrumentation/jetty8/HttpServletRequestExtractAdapter.java
dd-java-agent/instrumentation/jetty-8/src/main/java/datadog/trace/instrumentation/jetty8/HttpServletRequestExtractAdapter.java
@@ -16,6 +16,7 @@ import javax.servlet.http.HttpServletRequest;
*
* @author Pavol Loffay
*/
+// FIXME: This code is duplicated in several places. Extract to a common dependency.
public class HttpServletRequestExtractAdapter implements TextMap {
private final Map<String, List<String>> headers;
@@ -61,7 +62,7 @@ public class HttpServletRequestExtractAdapter implements TextMap {
private Iterator<V> listIterator;
public MultivaluedMapFlatIterator(final Set<Map.Entry<K, List<V>>> multiValuesEntrySet) {
- this.mapIterator = multiValuesEntrySet.iterator();
+ mapIterator = multiValuesEntrySet.iterator();
}
@Override

MODIFY
dd-java-agent/instrumentation/servlet-2/src/main/java/datadog/trace/instrumentation/servlet2/HttpServletRequestExtractAdapter.java
dd-java-agent/instrumentation/servlet-2/src/main/java/datadog/trace/instrumentation/servlet2/HttpServletRequestExtractAdapter.java
@@ -16,6 +16,7 @@ import javax.servlet.http.HttpServletRequest;
*
* @author Pavol Loffay
*/
+// FIXME: This code is duplicated in several places. Extract to a common dependency.
public class HttpServletRequestExtractAdapter implements TextMap {
private final Map<String, List<String>> headers;
@@ -61,7 +62,7 @@ public class HttpServletRequestExtractAdapter implements TextMap {
private Iterator<V> listIterator;
public MultivaluedMapFlatIterator(final Set<Map.Entry<K, List<V>>> multiValuesEntrySet) {
- this.mapIterator = multiValuesEntrySet.iterator();
+ mapIterator = multiValuesEntrySet.iterator();
}
@Override

MODIFY
dd-java-agent/instrumentation/servlet-3/src/main/java/datadog/trace/instrumentation/servlet3/HttpServletRequestExtractAdapter.java
dd-java-agent/instrumentation/servlet-3/src/main/java/datadog/trace/instrumentation/servlet3/HttpServletRequestExtractAdapter.java
@@ -16,6 +16,7 @@ import javax.servlet.http.HttpServletRequest;
*
* @author Pavol Loffay
*/
+// FIXME: This code is duplicated in several places. Extract to a common dependency.
public class HttpServletRequestExtractAdapter implements TextMap {
private final Map<String, List<String>> headers;
@@ -61,7 +62,7 @@ public class HttpServletRequestExtractAdapter implements TextMap {
private Iterator<V> listIterator;
public MultivaluedMapFlatIterator(final Set<Map.Entry<K, List<V>>> multiValuesEntrySet) {
- this.mapIterator = multiValuesEntrySet.iterator();
+ mapIterator = multiValuesEntrySet.iterator();
}
@Override

MODIFY
dd-java-agent/testing/src/main/java/datadog/trace/agent/test/server/http/HttpServletRequestExtractAdapter.java
dd-java-agent/testing/src/main/java/datadog/trace/agent/test/server/http/HttpServletRequestExtractAdapter.java
@@ -16,6 +16,7 @@ import javax.servlet.http.HttpServletRequest;
*
* @author Pavol Loffay
*/
+// FIXME: This code is duplicated in several places. Extract to a common dependency.
public class HttpServletRequestExtractAdapter implements TextMap {
private final Map<String, List<String>> headers;

Add fixme to adapter.