fix: remove commitlint
it is confusing for contributors and I can edit the commit message when I squash anyways
MODIFY
.circleci/config.yml
.circleci/config.yml
@@ -110,7 +110,7 @@ jobs:
keys:
- v3-{{checksum ".circleci/config.yml"}}-{{checksum "yarn.lock"}}
- run: yarn global add greenkeeper-lockfile@1
- - run: yarn add -D mocha-junit-reporter@1 @commitlint/cli@6 @commitlint/config-conventional@6
+ - run: yarn add -D mocha-junit-reporter@1
- run: yarn exec nps test.command
- save_cache:
key: v3-{{checksum ".circleci/config.yml"}}-{{checksum "yarn.lock"}}

MODIFY
src/generators/app.ts
src/generators/app.ts
@@ -365,10 +365,6 @@ class App extends Generator {
this.fs.copyTpl(this.templatePath('eslintrc'), this.destinationPath('.eslintrc'), this)
const eslintignore = this._eslintignore()
if (eslintignore.trim()) this.fs.write(this.destinationPath('.eslintignore'), this._eslintignore())
- // this.fs.copyTpl(this.templatePath('package-scripts.js.ejs'), this.destinationPath('package-scripts.js'), this)
- // if (this.semantic_release) {
- // this.fs.copyTpl(this.templatePath('.commitlintrc.js'), this.destinationPath('.commitlintrc.js'), this)
- // }
switch (this.type) {
case 'single':

MODIFY
templates/circle.yml.ejs
templates/circle.yml.ejs
-<%_
-let deps = [
- 'nyc@11',
- '@oclif/nyc-config@1',
- 'mocha-junit-reporter@1',
-]
-if (semantic_release) deps.push('@commitlint/cli@6', '@commitlint/config-conventional@6')
-deps = deps.join(' ')
-_%>
---
version: 2
jobs:
@@ -26,7 +17,7 @@ jobs:
- v1-yarn-{{checksum ".circleci/config.yml"}}-{{ checksum "yarn.lock"}}
- v1-yarn-{{checksum ".circleci/config.yml"}}
- run: .circleci/greenkeeper
- - run: yarn add -D <%- deps %>
+ - run: yarn add -D nyc@11 @oclif/nyc-config@1 mocha-junit-reporter@1
<%_ if (['single', 'multi'].includes(type)) { _%>
- run: ./bin/run --version
<%_ } _%>
@@ -42,9 +33,6 @@ jobs:
<%_ } else { _%>
- run: yarn test
<%_ } _%>
- <%_ if (semantic_release) { _%>
- - run: yarn exec commitlint -- -x @commitlint/config-conventional --from origin/master
- <%_ } _%>
- store_test_results: &store_test_results
path: ~/cli/reports
node-8:

MODIFY
yarn.lock
yarn.lock
@@ -1526,10 +1526,6 @@ has-values@^1.0.0:
is-number "^3.0.0"
kind-of "^4.0.0"
-has-yarn@^1.0.0:
- version "1.0.0"
- resolved "https://registry.yarnpkg.com/has-yarn/-/has-yarn-1.0.0.tgz#89e25db604b725c8f5976fff0addc921b828a5a7"
-
he@1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/he/-/he-1.1.1.tgz#93410fd21b009735151f8868c2f271f3427e23fd"

fix: remove commitlint (#83)

it is confusing for contributors and I can edit the commit message when I squash anyways