Read the right username field when performing account deactivation
`Login` has 2 username fields, and we were always checking the
deprecated one. Instead, check both.
MODIFY
clientapi/routing/deactivate.go
clientapi/routing/deactivate.go
@@ -33,7 +33,7 @@ func Deactivate(
return *errRes
}
- localpart, _, err := gomatrixserverlib.SplitID('@', login.User)
+ localpart, _, err := gomatrixserverlib.SplitID('@', login.Username())
if err != nil {
util.GetLogger(req.Context()).WithError(err).Error("gomatrixserverlib.SplitID failed")
return jsonerror.InternalServerError()

Read the right username field when performing account deactivation (#1954)

`Login` has 2 username fields, and we were always checking the
deprecated one. Instead, check both.