De-race `CompleteSync`
The `err` was coming from outside of the goroutine and being written to by concurrent goroutines.
MODIFY
syncapi/streams/stream_pdu.go
syncapi/streams/stream_pdu.go
@@ -109,12 +109,11 @@ func (p *PDUStreamProvider) CompleteSync(
p.queue(func() {
defer reqWaitGroup.Done()
- var jr *types.JoinResponse
- jr, err = p.getJoinResponseForCompleteSync(
+ jr, jerr := p.getJoinResponseForCompleteSync(
ctx, roomID, r, &stateFilter, &eventFilter, req.WantFullState, req.Device,
)
- if err != nil {
- req.Log.WithError(err).Error("p.getJoinResponseForCompleteSync failed")
+ if jerr != nil {
+ req.Log.WithError(jerr).Error("p.getJoinResponseForCompleteSync failed")
return
}

De-race `CompleteSync` (#2601)

The `err` was coming from outside of the goroutine and being written to by concurrent goroutines.