Remove magnitude and normalization tests, as they should be internal.
MODIFY
WalletWasabi.Tests/UnitTests/Crypto/GroupElementComparisionTests.cs
WalletWasabi.Tests/UnitTests/Crypto/GroupElementComparisionTests.cs
@@ -56,40 +56,6 @@ namespace WalletWasabi.Tests.UnitTests.Crypto
Assert.True(Secp256k1Helpers.Equals(a, b));
}
- [Fact]
- public void MagnitudeDoesntMatter()
- {
- // ToDo: is this ok?
- var one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: false);
- var one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 1, normalized: false);
- var a = new GE(one, one);
- var b = new GE(one2, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
-
- one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: false);
- one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 2, normalized: false);
- a = new GE(one, one);
- b = new GE(one2, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
-
- one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 1, normalized: false);
- one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 2, normalized: false);
- a = new GE(one, one);
- b = new GE(one2, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
- }
-
- [Fact]
- public void NormalizationDoesntMatter()
- {
- // ToDo: is this ok?
- var one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: false);
- var one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: true);
- var a = new GE(one, one);
- var b = new GE(one2, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
- }
-
[Fact]
public void OneOneOneEqualsOneOneOneJacobian()
{
@@ -138,39 +104,5 @@ namespace WalletWasabi.Tests.UnitTests.Crypto
var b = new GEJ(two, one, one, infinity: true);
Assert.True(Secp256k1Helpers.Equals(a, b));
}
-
- [Fact]
- public void MagnitudeDoesntMatterJacobian()
- {
- // ToDo: is this ok?
- var one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: false);
- var one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 1, normalized: false);
- var a = new GEJ(one, one, one);
- var b = new GEJ(one2, one, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
-
- one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: false);
- one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 2, normalized: false);
- a = new GEJ(one, one, one);
- b = new GEJ(one2, one, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
-
- one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 1, normalized: false);
- one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 2, normalized: false);
- a = new GEJ(one, one, one);
- b = new GEJ(one2, one, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
- }
-
- [Fact]
- public void NormalizationDoesntMatterJacobian()
- {
- // ToDo: is this ok?
- var one = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: false);
- var one2 = new FE(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, magnitude: 0, normalized: true);
- var a = new GEJ(one, one, one);
- var b = new GEJ(one2, one, one);
- Assert.True(Secp256k1Helpers.Equals(a, b));
- }
}
}

Remove magnitude and normalization tests, as they should be internal.