Remove unnecessary getVersion overrides
MODIFY
instrumentation-core/servlet/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java
instrumentation-core/servlet/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java
@@ -30,11 +30,6 @@ import javax.servlet.http.HttpServletRequest;
public abstract class ServletHttpServerTracer<RESPONSE>
extends HttpServerTracer<HttpServletRequest, RESPONSE, HttpServletRequest, HttpServletRequest> {
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
// TODO this violates convention
protected URI url(HttpServletRequest httpServletRequest) throws URISyntaxException {

MODIFY
instrumentation-core/spring/spring-webmvc-3.1/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/SpringWebMvcServerTracer.java
instrumentation-core/spring/spring-webmvc-3.1/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/SpringWebMvcServerTracer.java
@@ -89,9 +89,4 @@ class SpringWebMvcServerTracer
protected String getInstrumentationName() {
return null;
}
-
- @Override
- protected String getVersion() {
- return null;
- }
}

MODIFY
instrumentation/akka-http-10.0/src/main/java/io/opentelemetry/instrumentation/auto/akkahttp/AkkaHttpServerTracer.java
instrumentation/akka-http-10.0/src/main/java/io/opentelemetry/instrumentation/auto/akkahttp/AkkaHttpServerTracer.java
@@ -77,11 +77,6 @@ public class AkkaHttpServerTracer
return "io.opentelemetry.auto.akka-http-10.0";
}
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
protected Integer peerPort(HttpRequest httpRequest) {
return null;

MODIFY
instrumentation/armeria-1.0/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java
instrumentation/armeria-1.0/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java
@@ -46,11 +46,6 @@ public class ArmeriaServerTracer
return "io.opentelemetry.armeria-1.0";
}
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
protected Integer peerPort(ServiceRequestContext ctx) {
SocketAddress socketAddress = ctx.remoteAddress();

MODIFY
instrumentation/grizzly-2.0/src/main/java/io/opentelemetry/instrumentation/auto/grizzly/GrizzlyHttpServerTracer.java
instrumentation/grizzly-2.0/src/main/java/io/opentelemetry/instrumentation/auto/grizzly/GrizzlyHttpServerTracer.java
@@ -88,11 +88,6 @@ public class GrizzlyHttpServerTracer
return "io.opentelemetry.auto.grizzly-2.0";
}
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
protected Integer peerPort(HttpRequestPacket httpRequest) {
return httpRequest.getRemotePort();

MODIFY
instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/instrumentation/auto/netty/v3_8/server/NettyHttpServerTracer.java
instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/instrumentation/auto/netty/v3_8/server/NettyHttpServerTracer.java
@@ -93,11 +93,6 @@ public class NettyHttpServerTracer
return "io.opentelemetry.auto.netty-3.8";
}
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
protected Integer peerPort(Channel channel) {
SocketAddress socketAddress = channel.getRemoteAddress();

MODIFY
instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_0/server/NettyHttpServerTracer.java
instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_0/server/NettyHttpServerTracer.java
@@ -64,11 +64,6 @@ public class NettyHttpServerTracer
return "io.opentelemetry.auto.netty-4.0";
}
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
protected Getter<HttpRequest> getGetter() {
return NettyRequestExtractAdapter.GETTER;

MODIFY
instrumentation/netty/netty-4.1/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_1/server/NettyHttpServerTracer.java
instrumentation/netty/netty-4.1/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_1/server/NettyHttpServerTracer.java
@@ -64,11 +64,6 @@ public class NettyHttpServerTracer
return "io.opentelemetry.auto.netty-4.1";
}
- @Override
- protected String getVersion() {
- return null;
- }
-
@Override
protected Getter<HttpRequest> getGetter() {
return NettyRequestExtractAdapter.GETTER;

Remove unnecessary getVersion overrides (#1004)