suggestions renaming
MODIFY
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/CoinVerifierTests.cs
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/CoinVerifierTests.cs
@@ -231,7 +231,7 @@ public class CoinVerifierTests
{
foreach (Coin coin in coins)
{
- coinVerifier.ScheduleVerification(coin, CancellationToken.None, delay, confirmations: _wabisabiTestConfig.CoinVerifierRequiredConfirmation);
+ coinVerifier.ScheduleVerification(coin, CancellationToken.None, delay, confirmations: _wabisabiTestConfig.CoinVerifierRequiredConfirmations);
}
}
}

MODIFY
WalletWasabi/WabiSabi/Backend/Banning/CoinVerifier.cs
WalletWasabi/WabiSabi/Backend/Banning/CoinVerifier.cs
@@ -189,7 +189,7 @@ public class CoinVerifier
if (coin.Amount >= WabiSabiConfig.CoinVerifierRequiredConfirmationAmount)
{
- if (confirmations is null || confirmations < WabiSabiConfig.CoinVerifierRequiredConfirmation)
+ if (confirmations is null || confirmations < WabiSabiConfig.CoinVerifierRequiredConfirmations)
{
taskCompletionSource.SetResult(new CoinVerifyResult(coin, ShouldBan: false, ShouldRemove: true));
return;

MODIFY
WalletWasabi/WabiSabi/Backend/WabiSabiConfig.cs
WalletWasabi/WabiSabi/Backend/WabiSabiConfig.cs
@@ -133,8 +133,8 @@ public class WabiSabiConfig : ConfigBase
public TimeSpan CoinVerifierStartBefore { get; set; } = TimeSpan.FromMinutes(2);
[DefaultValue(3)]
- [JsonProperty(PropertyName = "CoinVerifierRequiredConfirmation", DefaultValueHandling = DefaultValueHandling.Populate)]
- public int CoinVerifierRequiredConfirmation { get; set; } = 3;
+ [JsonProperty(PropertyName = "CoinVerifierRequiredConfirmations", DefaultValueHandling = DefaultValueHandling.Populate)]
+ public int CoinVerifierRequiredConfirmations { get; set; } = 3;
[DefaultValueMoneyBtc("1")]
[JsonProperty(PropertyName = "CoinVerifierRequiredConfirmationAmount", DefaultValueHandling = DefaultValueHandling.Populate)]

suggestions renaming