Apply review resquest
MODIFY
WalletWasabi/Extensions/RPCClientExtensions.cs
WalletWasabi/Extensions/RPCClientExtensions.cs
@@ -18,7 +18,7 @@ namespace NBitcoin.RPC
/// <summary>
/// Waits for a specific new block and returns useful info about it.
/// </summary>
- /// <param name="timeout">Time in milliseconds to wait for a response. (int, optional, default=0). 0 indicates no timeout.</param>
+ /// <param name="timeout">Time in milliseconds to wait for a response. 0 indicates no timeout.</param>
/// <returns>Returns the current block on timeout or exit</returns>
public static async Task<(Height height, uint256 hash)> WaitForNewBlockAsync(this RPCClient rpc, long timeout = 0)
{
@@ -30,7 +30,7 @@ namespace NBitcoin.RPC
/// Waits for a specific new block and returns useful info about it.
/// </summary>
/// <param name="blockHash">Block hash to wait for</param>
- /// <param name="timeout">Time in milliseconds to wait for a response. (int, optional, default=0). 0 indicates no timeout.</param>
+ /// <param name="timeout">Time in milliseconds to wait for a response. 0 indicates no timeout.</param>
/// <returns>Returns the current block on timeout or exit</returns>
public static async Task<(Height height, uint256 hash)> WaitForBlockAsync(this RPCClient rpc, uint256 blockHash, long timeout = 0)
{
@@ -213,7 +213,6 @@ namespace NBitcoin.RPC
return newEstimations;
}
- /// <returns>Return (Allowed, reject-reason)</returns>
public static async Task<(bool accept, string rejectReason)> TestMempoolAcceptAsync(this RPCClient rpc, IEnumerable<Coin> coins)
{
// Check if mempool would accept a fake transaction created with the registered inputs.

MODIFY
WalletWasabi/Gma/QrCodeNet/Encoding/DataEncodation/InputRecognition/ModeEncodeCheck.cs
WalletWasabi/Gma/QrCodeNet/Encoding/DataEncodation/InputRecognition/ModeEncodeCheck.cs
@@ -27,9 +27,8 @@ namespace Gma.QrCodeNet.Encoding.DataEncodation.InputRecognition
/// </summary>
/// <param name="content">Input string</param>
/// <param name="encodingName">Encoding name. Check ECI table</param>
- /// <param name="startPos">Starting position</param>
- /// <returns>Return -1 if from starting position to end encoding success. Else return fail position</returns>
- internal static int TryEncodeEightBitByte(string content, string encodingName, int startPos, int contentLength)
+ /// <returns>Returns -1 if from starting position to end encoding success. Else returns fail position</returns>
+ internal static int TryEncodeEightBitByte(string content, string encodingName, int startingPosition, int contentLength)
{
if (string.IsNullOrEmpty(content))
{
@@ -43,13 +42,13 @@ namespace Gma.QrCodeNet.Encoding.DataEncodation.InputRecognition
}
catch (ArgumentException)
{
- return startPos;
+ return startingPosition;
}
char[] currentChar = new char[1];
byte[] bytes;
- for (int index = startPos; index < contentLength; index++)
+ for (int index = startingPosition; index < contentLength; index++)
{
currentChar[0] = content[index];
bytes = encoding.GetBytes(currentChar);
@@ -64,7 +63,7 @@ namespace Gma.QrCodeNet.Encoding.DataEncodation.InputRecognition
}
}
- for (int index = 0; index < startPos; index++)
+ for (int index = 0; index < startingPosition; index++)
{
currentChar[0] = content[index];
bytes = encoding.GetBytes(currentChar);

MODIFY
WalletWasabi/Gma/QrCodeNet/Encoding/EncodingRegion/VersionInformation.cs
WalletWasabi/Gma/QrCodeNet/Encoding/EncodingRegion/VersionInformation.cs
@@ -15,8 +15,6 @@ namespace Gma.QrCodeNet.Encoding.EncodingRegion
/// Embed version information to Matrix
/// Only for version greater than or equal to 7
/// </summary>
- /// <param name="tsMatrix">Matrix</param>
- /// <param name="version">Version number</param>
internal static void EmbedVersionInformation(this TriStateMatrix tsMatrix, int version)
{
if (version < 7)

MODIFY
WalletWasabi/Gma/QrCodeNet/Encoding/ReedSolomon/Polynomial.cs
WalletWasabi/Gma/QrCodeNet/Encoding/ReedSolomon/Polynomial.cs
@@ -155,7 +155,7 @@ namespace Gma.QrCodeNet.Encoding.ReedSolomon
/// <summary>
/// Multiplay scalar to current polynomial
/// </summary>
- /// <returns>result of polynomial after multiply scalar</returns>
+ /// <returns>Result of polynomial after multiply scalar</returns>
internal Polynomial MultiplyScalar(int scalar)
{
if (scalar == 0)

MODIFY
WalletWasabi/Helpers/ByteArrayBuilder.cs
WalletWasabi/Helpers/ByteArrayBuilder.cs
@@ -49,7 +49,7 @@ namespace System
}
/// <summary>
- /// Utf8 encoding
+ /// UTF8 encoding
/// </summary>
public override string ToString()
{

Apply review resquest