Remove error tolerancy
MODIFY
WalletWasabi.Tests/UnitTests/WabiSabi/Integration/WabiSabiHttpApiIntegrationTests.cs
WalletWasabi.Tests/UnitTests/WabiSabi/Integration/WabiSabiHttpApiIntegrationTests.cs
@@ -50,7 +50,7 @@ namespace WalletWasabi.Tests.UnitTests.WabiSabi.Integration
[Theory]
[InlineData(new long[] { 20_000_000, 40_000_000, 60_000_000, 80_000_000 })]
[InlineData(new long[] { 10_000_000, 20_000_000, 30_000_000, 40_000_000, 100_000_000 })]
- [InlineData(new long[] { 10_000_000, 20_000_000, 30_000_000, 40_000_000, 100_000_000 }, new long[] { 100_000_000, 100_000_000 })] //failing test
+ [InlineData(new long[] { 10_000_000, 20_000_000, 30_000_000, 40_000_000, 100_000_000 }, new long[] { 100_000_000, 100_000_000 })]
[InlineData(new long[] { 120_000_000 }, new long[] { 20_000_000, 40_000_000, 60_000_000 })]
[InlineData(new long[] { 100_000_000, 10_000_000, 10_000 })] // failing test
public async Task SoloCoinJoinTestAsync(long[] amounts, long[]? outputs = null)

MODIFY
WalletWasabi/WabiSabi/Client/AliceClient.cs
WalletWasabi/WabiSabi/Client/AliceClient.cs
@@ -114,6 +114,10 @@ namespace WalletWasabi.WabiSabi.Client
Logger.LogInfo($"Round ({RoundId}), Alice ({AliceId}): Posted a signature.");
}
+ public async Task SignalReadyAsync()
+ {
+ }
+
private static uint256 CalculateHash(Coin coin, BitcoinSecret bitcoinSecret, uint256 roundId)
{
var ownershipProof = OwnershipProof.GenerateCoinJoinInputProof(

MODIFY
WalletWasabi/WabiSabi/Client/CoinJoinClient.cs
WalletWasabi/WabiSabi/Client/CoinJoinClient.cs
@@ -66,7 +66,7 @@ namespace WalletWasabi.WabiSabi.Client
DependencyGraphResolver dgr = new(dependencyGraph, ZeroAmountCredentialPool, ZeroVsizeCredentialPool);
// Register coins.
- aliceClients = await RegisterCoinsAsync(aliceClients, cancellationToken).ConfigureAwait(false);
+ await RegisterCoinsAsync(aliceClients, cancellationToken).ConfigureAwait(false);
// Confirm coins.
await dgr.StartConfirmConnectionsAsync(aliceClients, dependencyGraph, roundState.ConnectionConfirmationTimeout, cancellationToken).ConfigureAwait(false);
@@ -111,26 +111,15 @@ namespace WalletWasabi.WabiSabi.Client
return aliceClients;
}
- private async Task<List<AliceClient>> RegisterCoinsAsync(IEnumerable<AliceClient> aliceClients, CancellationToken cancellationToken)
+ private async Task RegisterCoinsAsync(IEnumerable<AliceClient> aliceClients, CancellationToken cancellationToken)
{
- async Task<AliceClient?> RegisterInputTask(AliceClient aliceClient)
- {
- try
+ async Task RegisterInputTask(AliceClient aliceClient)
{
await aliceClient.RegisterInputAsync(cancellationToken).ConfigureAwait(false);
- return aliceClient;
- }
- catch (Exception e)
- {
- Logger.LogWarning($"Round ({aliceClient.RoundId}), Alice ({aliceClient.AliceId}): {nameof(AliceClient.RegisterInputAsync)} failed, reason:'{e}'.");
- return default;
- }
}
var registerRequests = aliceClients.Select(RegisterInputTask);
- var completedRequests = await Task.WhenAll(registerRequests).ConfigureAwait(false);
-
- return completedRequests.Where(x => x is not null).Cast<AliceClient>().ToList();
+ await Task.WhenAll(registerRequests).ConfigureAwait(false);
}
private async Task<List<AliceClient>> ConfirmConnectionsAsync(IEnumerable<AliceClient> aliceClients, long maxVsizeAllocationPerAlice, TimeSpan connectionConfirmationTimeout, CancellationToken cancellationToken)

Remove error tolerancy