Add test for improved messages
MODIFY
dd-java-agent/agent-profiling/profiling-controller/src/test/java/com/datadog/profiling/controller/ControllerFactoryTest.java
dd-java-agent/agent-profiling/profiling-controller/src/test/java/com/datadog/profiling/controller/ControllerFactoryTest.java
package com.datadog.profiling.controller;
+import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.condition.JRE.JAVA_8;
@@ -19,10 +20,18 @@ public class ControllerFactoryTest {
@Test
@EnabledOnJre({JAVA_8})
public void testCreateControllerJava8() {
- assertThrows(
+ System.out.println("Java Version: " + System.getProperty("java.version") + " " + System.getProperty("java.vendor"));
+ UnsupportedEnvironmentException unsupportedEnvironmentException = assertThrows(
UnsupportedEnvironmentException.class,
() -> {
ControllerFactory.createController(config);
});
+ System.out.println(unsupportedEnvironmentException.getMessage());
+ System.out.println(System.getProperty("java.vendor"));
+ String expected = "The JFR controller could not find a supported JFR API, use OpenJDK 11+ or Azul zulu version 1.8.0_212+";
+ if ("Azul Systems, Inc.".equals(System.getProperty("java.vendor"))) {
+ expected = "The JFR controller could not find a supported JFR API, use Azul zulu version 1.8.0_212+";
+ }
+ assertEquals(expected, unsupportedEnvironmentException.getMessage());
}
}

Add test for improved messages