lapack,mat: rename SVDInPlace constant to SVDStore
MODIFY
lapack/lapack.go
lapack/lapack.go
@@ -108,10 +108,10 @@ const (
type SVDJob byte
const (
- SVDAll SVDJob = 'A' // Compute all singular vectors
- SVDInPlace SVDJob = 'S' // Compute the first singular vectors and store them in provided storage.
- SVDOverwrite SVDJob = 'O' // Compute the singular vectors and store them in input matrix
- SVDNone SVDJob = 'N' // Do not compute singular vectors
+ SVDAll SVDJob = 'A' // Compute all columns of the matrix U or V.
+ SVDStore SVDJob = 'S' // Compute the singular vectors and store them in the matrix U or V.
+ SVDOverwrite SVDJob = 'O' // Compute the singular vectors and overwrite them on the input matrix A.
+ SVDNone SVDJob = 'N' // Do not compute singular vectors.
)
// GSVDJob specifies the singular vector computation type for Generalized SVD.

MODIFY
lapack/testlapack/dgesvd.go
lapack/testlapack/dgesvd.go
@@ -111,16 +111,16 @@ func DgesvdTest(t *testing.T, impl Dgesvder) {
svdCheck(t, false, errStr, m, n, s, a, u, ldu, vt, ldvt, aCopy, lda)
svdCheckPartial(t, impl, lapack.SVDAll, errStr, uAllOrig, vtAllOrig, aCopy, m, n, a, lda, s, u, ldu, vt, ldvt, work, false)
- // Test InPlace
- jobU = lapack.SVDInPlace
- jobVT = lapack.SVDInPlace
+ // Test SVDStore
+ jobU = lapack.SVDStore
+ jobVT = lapack.SVDStore
copy(a, aCopy)
copy(u, uAllOrig)
copy(vt, vtAllOrig)
impl.Dgesvd(jobU, jobVT, m, n, a, lda, s, u, ldu, vt, ldvt, work, len(work))
svdCheck(t, true, errStr, m, n, s, a, u, ldu, vt, ldvt, aCopy, lda)
- svdCheckPartial(t, impl, lapack.SVDInPlace, errStr, uAllOrig, vtAllOrig, aCopy, m, n, a, lda, s, u, ldu, vt, ldvt, work, false)
+ svdCheckPartial(t, impl, lapack.SVDStore, errStr, uAllOrig, vtAllOrig, aCopy, m, n, a, lda, s, u, ldu, vt, ldvt, work, false)
}
}

lapack,mat: rename SVDInPlace constant to SVDStore