Format and renaming issues
MODIFY
dd-trace/src/main/java/com/datadoghq/trace/resolver/DDTracerFactory.java
dd-trace/src/main/java/com/datadoghq/trace/resolver/DDTracerFactory.java
@@ -10,11 +10,10 @@ import com.datadoghq.trace.writer.DDAgentWriter;
import com.datadoghq.trace.writer.DDApi;
import com.datadoghq.trace.writer.LoggingWriter;
import com.datadoghq.trace.writer.Writer;
-import lombok.extern.slf4j.Slf4j;
-
import java.util.List;
import java.util.Map;
import java.util.regex.Pattern;
+import lombok.extern.slf4j.Slf4j;
/** Create a tracer from a configuration file */
@Slf4j

MODIFY
dd-trace/src/main/java/com/datadoghq/trace/resolver/DDTracerResolver.java
dd-trace/src/main/java/com/datadoghq/trace/resolver/DDTracerResolver.java
@@ -21,7 +21,6 @@ public class DDTracerResolver extends TracerResolver {
//Create tracer from resource files
tracer = DDTracerFactory.createFromConfigurationFile();
-
return tracer;
}

MODIFY
dd-trace/src/test/groovy/com/datadoghq/trace/SpanFactory.groovy
dd-trace/src/test/groovy/com/datadoghq/trace/SpanFactory.groovy
@@ -18,7 +18,7 @@ class SpanFactory {
return new DDSpan(timestampMicro, context)
}
- static newSpanTracer(DDTracer tracer) {
+ static newSpanOf(DDTracer tracer) {
def context = new DDSpanContext(
1L,
1L,
@@ -32,6 +32,6 @@ class SpanFactory {
Collections.emptyMap(),
null,
tracer)
- return new DDSpan(0, context)
+ return new DDSpan(1, context)
}
}

MODIFY
dd-trace/src/test/groovy/com/datadoghq/trace/integration/SpanDecoratorTest.groovy
dd-trace/src/test/groovy/com/datadoghq/trace/integration/SpanDecoratorTest.groovy
@@ -25,12 +25,11 @@ class SpanDecoratorTest extends Specification {
decorator.setSetValue("newBar")
tracer.addDecorator(decorator)
- def span = SpanFactory.newSpanTracer(tracer)
+ def span = SpanFactory.newSpanOf(tracer)
new StringTag("foo").set(span, "bar")
expect:
span.getTags().containsKey("newFoo")
- ((String) span.getTags().get("newFoo")) == "newBar"
-
+ span.getTags().get("newFoo") == "newBar"
}
}

Format and renaming issues