A few typos & code style
MODIFY
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/PhaseStepping/StepOutputRegistrationTests.cs
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/PhaseStepping/StepOutputRegistrationTests.cs
@@ -14,7 +14,6 @@ using WalletWasabi.WabiSabi.Client.RoundStateAwaiters;
using WalletWasabi.WabiSabi.Models;
using WalletWasabi.WabiSabi.Models.MultipartyTransaction;
using Xunit;
-using Xunit.Abstractions;
namespace WalletWasabi.Tests.UnitTests.WabiSabi.Backend.PhaseStepping;
@@ -223,6 +222,7 @@ public class StepOutputRegistrationTests
{
await arena.TriggerAndWaitRoundAsync(token);
}
+
await Task.WhenAll(task1, task2);
var aliceClient1 = await task1;
var aliceClient2 = await task2;
@@ -348,13 +348,13 @@ public class StepOutputRegistrationTests
{
try
{
- // Trying to registed the same script again and again.
+ // Trying to register the same script again and again.
await bobClient2.RegisterOutputAsync(
out1a.PubKey.GetScriptPubKey(ScriptPubKeyType.Segwit),
amountCredentials2a.Take(ProtocolConstants.CredentialNumber),
vsizeCredentials2a.Take(ProtocolConstants.CredentialNumber),
combinedCts.Token);
- throw new InvalidOperationException("This output shoud never be able to register.");
+ throw new InvalidOperationException("This output should never be able to register.");
}
catch (WabiSabiProtocolException)
{

MODIFY
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/PostRequests/SignTransactionTests.cs
WalletWasabi.Tests/UnitTests/WabiSabi/Backend/PostRequests/SignTransactionTests.cs
@@ -86,6 +86,7 @@ public class SignTransactionTests
Assert.Equal(WabiSabiProtocolErrorCode.WrongPhase, ex.ErrorCode);
}
}
+
await arena.StopAsync(CancellationToken.None);
}
}

MODIFY
WalletWasabi.Tests/UnitTests/WabiSabi/Models/MultipartyTransactionTests.cs
WalletWasabi.Tests/UnitTests/WabiSabi/Models/MultipartyTransactionTests.cs
using NBitcoin;
using System.Collections.Immutable;
-using WalletWasabi.Crypto;
using System.Linq;
+using WalletWasabi.Crypto;
+using WalletWasabi.Extensions;
+using WalletWasabi.Helpers;
+using WalletWasabi.Tests.Helpers;
using WalletWasabi.WabiSabi.Backend.Models;
+using WalletWasabi.WabiSabi.Backend.Rounds;
using WalletWasabi.WabiSabi.Models;
using WalletWasabi.WabiSabi.Models.MultipartyTransaction;
-using WalletWasabi.Tests.Helpers;
using Xunit;
-using WalletWasabi.Helpers;
-using WalletWasabi.WabiSabi.Backend.Rounds;
-using WalletWasabi.Extensions;
namespace WalletWasabi.Tests.UnitTests.WabiSabi.Models;
@@ -23,7 +23,9 @@ public class MultipartyTransactionTests
MaxRegistrableAmount = DefaultAllowedAmounts.Max,
MaxSuggestedAmountBase = Money.Coins(Constants.MaximumNumberOfBitcoins)
}) with
- { MiningFeeRate = new FeeRate(0m) };
+ {
+ MiningFeeRate = new FeeRate(0m)
+ };
private static readonly CoinJoinInputCommitmentData CommitmentData = WabiSabiFactory.CreateCommitmentData();

MODIFY
WalletWasabi/WabiSabi/Backend/Rounds/Arena.Partial.cs
WalletWasabi/WabiSabi/Backend/Rounds/Arena.Partial.cs
@@ -380,10 +380,12 @@ public partial class Arena : IWabiSabiApiRequestHandler
{
throw new WabiSabiProtocolException(WabiSabiProtocolErrorCode.InputSpent);
}
+
if (txOutResponse.Confirmations == 0)
{
throw new WabiSabiProtocolException(WabiSabiProtocolErrorCode.InputUnconfirmed);
}
+
if (txOutResponse.IsCoinBase && txOutResponse.Confirmations <= 100)
{
throw new WabiSabiProtocolException(WabiSabiProtocolErrorCode.InputImmature);

MODIFY
WalletWasabi/WabiSabi/Client/CoinJoinManager.cs
WalletWasabi/WabiSabi/Client/CoinJoinManager.cs
@@ -75,7 +75,7 @@ public class CoinJoinManager : BackgroundService
// Detects and notifies about wallets that can participate in a coinjoin.
var walletsMonitoringTask = Task.Run(() => MonitorWalletsAsync(stoppingToken), stoppingToken);
- // Coinjoin handling Start / Stop and finallization.
+ // Coinjoin handling Start / Stop and finalization.
var monitorAndHandleCoinjoinsTask = MonitorAndHandleCoinJoinsAsync(stoppingToken);
await Task.WhenAny(walletsMonitoringTask, monitorAndHandleCoinjoinsTask).ConfigureAwait(false);

MODIFY
WalletWasabi/WabiSabi/Models/MultipartyTransaction/ConstructionState.cs
WalletWasabi/WabiSabi/Models/MultipartyTransaction/ConstructionState.cs
@@ -97,6 +97,7 @@ public record ConstructionState : MultipartyTransactionState
return this with { Events = Events.Add(new OutputAdded(output)) };
}
+
public SigningState Finalize()
{
if (EstimatedVsize > Parameters.MaxTransactionSize)

A few typos & code style