Added checks for JSON body in accounts_data endpoint
MODIFY
clientapi/routing/account_data.go
clientapi/routing/account_data.go
package routing
import (
+ "encoding/json"
"io/ioutil"
"net/http"
@@ -80,12 +81,26 @@ func SaveAccountData(
defer req.Body.Close() // nolint: errcheck
+ if req.Body == http.NoBody {
+ return util.JSONResponse{
+ Code: http.StatusBadRequest,
+ JSON: jsonerror.NotJSON("Content not JSON"),
+ }
+ }
+
body, err := ioutil.ReadAll(req.Body)
if err != nil {
util.GetLogger(req.Context()).WithError(err).Error("ioutil.ReadAll failed")
return jsonerror.InternalServerError()
}
+ if !json.Valid(body) {
+ return util.JSONResponse{
+ Code: http.StatusBadRequest,
+ JSON: jsonerror.BadJSON("Bad JSON content"),
+ }
+ }
+
if err := accountDB.SaveAccountData(
req.Context(), localpart, roomID, dataType, string(body),
); err != nil {

Added checks for JSON body in accounts_data endpoint (#863)

Signed-off-by: Prateek Sachan <psachan@cs.iitr.ac.in>