Small cleanup of ripesprocessor.h
MODIFY
src/processorhandler.h
src/processorhandler.h
@@ -47,7 +47,7 @@ public:
/**
* @brief selectProcessor
* Constructs the processor identified by @param id, and performs all necessary initialization through the
- * RipesVSRTLProcessor interface.
+ * RipesProcessor interface.
*/
static void selectProcessor(const ProcessorID& id, const QStringList& extensions = {},
RegisterInitialization setup = RegisterInitialization()) {

MODIFY
src/processors/ripesprocessor.h
src/processors/ripesprocessor.h
@@ -183,43 +183,6 @@ public:
*/
virtual void clockProcessor() = 0;
- /**
- * @brief clocked, reversed & reset signals
- * These signals must be emitted whenever the processor has finished the given operation.
- * Signals should only be emitted if m_emitsSignals is set.
- */
- Gallant::Signal0<> processorWasClocked;
- Gallant::Signal0<> processorWasReversed;
- Gallant::Signal0<> processorWasReset;
-
- /** FEATURE: Reversible=============================================*/
- /**
- * @brief reverse
- * Reverses the processor, undoing the latest clock cycle
- */
- virtual void reverse(){};
- /**
- * @brief setMaxReverseCycles
- * @p cycles denotes the maximum number of cycles that the processor is expected to be able to reverse.
- */
- virtual void setMaxReverseCycles(unsigned cycles) { Q_UNUSED(cycles); };
-
- /** ================================================================*/
-
- /**
- * @brief isExecutableAddress
- * Callback that the processor can use to query the Ripes environment. Returns whether the @p
- * address is an address which is valid to be executed.
- */
- std::function<bool(uint32_t)> isExecutableAddress;
-
- /**
- * @brief handleSysCall
- * Signal that the processor can use to pass control to the outside environment whenever a system call must be
- * handled (RISC-V ecall instruction).
- */
- Gallant::Signal0<> handleSysCall;
-
/**
* @brief finalize
* Called from Ripes to indicate that the processor should start or stop its finishing sequence.
@@ -249,6 +212,46 @@ public:
*/
virtual long long getCycleCount() const = 0;
+ /** ======================= Signals and callbacks ======================= */
+ /**
+ * @brief clocked, reversed & reset signals
+ * These signals must be emitted whenever the processor has finished the given operation.
+ * Signals should only be emitted if m_emitsSignals is set.
+ */
+ Gallant::Signal0<> processorWasClocked;
+ Gallant::Signal0<> processorWasReversed;
+ Gallant::Signal0<> processorWasReset;
+
+ /**
+ * @brief isExecutableAddress
+ * Callback that the processor can use to query the Ripes environment. Returns whether the @p
+ * address is an address which is valid to be executed.
+ */
+ std::function<bool(uint32_t)> isExecutableAddress;
+
+ /**
+ * @brief handleSysCall
+ * Signal that the processor can use to pass control to the outside environment whenever a system call must be
+ * handled (RISC-V ecall instruction).
+ */
+ Gallant::Signal0<> handleSysCall;
+
+ /** ======================== FEATURE: Reversible ======================== */
+ // Enabled by setting m_features.isReversible = true
+
+ /**
+ * @brief reverse
+ * Reverses the processor, undoing the latest clock cycle
+ */
+ virtual void reverse(){};
+ /**
+ * @brief setMaxReverseCycles
+ * @p cycles denotes the maximum number of cycles that the processor is expected to be able to reverse.
+ */
+ virtual void setMaxReverseCycles(unsigned cycles) { Q_UNUSED(cycles); };
+
+ /** ======================================================================*/
+
protected:
// m_features should be adjusted accordingly during processor construction
Features m_features;

Small cleanup of ripesprocessor.h