Add staticcheck lint
MODIFY
linter.json
linter.json
"unparam",
"errcheck",
"vet",
- "unused",
- "gosimple"
+ "megacheck"
]
}

MODIFY
src/github.com/matrix-org/dendrite/cmd/dendrite-room-server/main.go
src/github.com/matrix-org/dendrite/cmd/dendrite-room-server/main.go
@@ -80,7 +80,9 @@ func main() {
aliasAPI.SetupHTTP(http.DefaultServeMux)
- http.DefaultServeMux.Handle("/metrics", prometheus.Handler())
+ // This is deprecated, but prometheus are still arguing on what to replace
+ // it with. Alternatively we could set it up manually.
+ http.DefaultServeMux.Handle("/metrics", prometheus.Handler()) // nolint: staticcheck, megacheck
log.Info("Started room server on ", cfg.Listen.RoomServer)

MODIFY
src/github.com/matrix-org/dendrite/cmd/mediaapi-integration-tests/main.go
src/github.com/matrix-org/dendrite/cmd/mediaapi-integration-tests/main.go
@@ -190,7 +190,7 @@ func getMediaURI(host, endpoint, query string, components []string) string {
func testUpload(host, filePath string) {
fmt.Printf("==TESTING== upload %v to %v\n", filePath, host)
file, err := os.Open(filePath)
- defer file.Close() // nolint: errcheck
+ defer file.Close() // nolint: errcheck, staticcheck, megacheck
if err != nil {
panic(err)
}

MODIFY
src/github.com/matrix-org/dendrite/cmd/syncserver-integration-tests/testdata.go
src/github.com/matrix-org/dendrite/cmd/syncserver-integration-tests/testdata.go
package main
-// nolint: varcheck, deadcode, unused
+// nolint: varcheck, deadcode, unused, megacheck
const (
i0StateRoomCreate = iota
i1StateAliceJoin

MODIFY
src/github.com/matrix-org/dendrite/common/httpapi.go
src/github.com/matrix-org/dendrite/common/httpapi.go
@@ -52,6 +52,7 @@ func MakeFedAPI(
// SetupHTTPAPI registers an HTTP API mux under /api and sets up a metrics
// listener.
func SetupHTTPAPI(servMux *http.ServeMux, apiMux *mux.Router) {
- servMux.Handle("/metrics", prometheus.Handler())
+ // This is deprecated.
+ servMux.Handle("/metrics", prometheus.Handler()) // nolint: megacheck, staticcheck
servMux.Handle("/api/", http.StripPrefix("/api", apiMux))
}

MODIFY
src/github.com/matrix-org/dendrite/mediaapi/writers/download.go
src/github.com/matrix-org/dendrite/mediaapi/writers/download.go
@@ -236,7 +236,7 @@ func (r *downloadRequest) respondFromLocalFile(
return nil, errors.Wrap(err, "failed to get file path from metadata")
}
file, err := os.Open(filePath)
- defer file.Close() // nolint: errcheck
+ defer file.Close() // nolint: errcheck, staticcheck, megacheck
if err != nil {
return nil, errors.Wrap(err, "failed to open file")
}

Add staticcheck lint (#245)