Make appName Constant
I need the Appname to be a Constant because the feature depends on it.
If the appname changes in the Packager,
but not in the StartupHelper, the feature just won't work at all.
MODIFY
WalletWasabi.Fluent/Helpers/StartupHelper.cs
WalletWasabi.Fluent/Helpers/StartupHelper.cs
@@ -13,7 +13,7 @@ namespace WalletWasabi.Fluent.Helpers
private const string KeyPath = "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run";
// Arguments to add Wasabi to macOS startup settings.
- private static readonly string AddCmd = $"osascript -e \' tell application \"System Events\" to make new login item at end with properties {{name:\"WasabiWallet\", path:\"/Applications/WasabiWallet.app\",hidden:false}} \'";
+ private static readonly string AddCmd = $"osascript -e \' tell application \"System Events\" to make new login item at end with properties {{name:\"WasabiWallet\", path:\"/Applications/{Constants.AppName}\",hidden:false}} \'";
// Arguments to delete Wasabi from macOS startup settings.
private static readonly string DeleteCmd = "osascript -e \' tell application \"System Events\" to delete login item \"WasabiWallet\" \'";

MODIFY
WalletWasabi.Packager/MacSignTools.cs
WalletWasabi.Packager/MacSignTools.cs
@@ -6,6 +6,7 @@ using System.IO.Compression;
using System.Linq;
using System.Runtime.InteropServices;
using System.Threading;
+using WalletWasabi.Helpers;
namespace WalletWasabi.Packager
{
@@ -33,7 +34,7 @@ namespace WalletWasabi.Packager
var workingDir = Path.Combine(desktopPath, "wasabiTemp");
var dmgPath = Path.Combine(workingDir, "dmg");
var unzippedPath = Path.Combine(workingDir, "unzipped");
- var appName = "Wasabi Wallet.app";
+ var appName = Constants.AppName;
var appPath = Path.Combine(dmgPath, appName);
var appContentsPath = Path.Combine(appPath, "Contents");
var appMacOsPath = Path.Combine(appContentsPath, "MacOS");

MODIFY
WalletWasabi/Helpers/Constants.cs
WalletWasabi/Helpers/Constants.cs
@@ -50,6 +50,7 @@ namespace WalletWasabi.Helpers
public const string CapitalAlphaNumericCharacters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
public const string ExecutableName = "wassabee";
+ public const string AppName = "Wasabi Wallet.app";
public const string BuiltinBitcoinNodeName = "Bitcoin Knots";
public static readonly Version ClientVersion = new(1, 1, 12, 9);

Make appName Constant

I need the Appname to be a Constant because the feature depends on it.
If the appname changes in the Packager,
but not in the StartupHelper, the feature just won't work at all.