lapack: remove None const
MODIFY
lapack/gonum/dgeev.go
lapack/gonum/dgeev.go
@@ -128,7 +128,7 @@ func (impl Implementation) Dgeev(jobvl lapack.LeftEVJob, jobvr lapack.RightEVJob
maxwrk = max(maxwrk, n+int(work[0]))
maxwrk = max(maxwrk, 4*n)
} else {
- impl.Dhseqr(lapack.EigenvaluesOnly, lapack.None, n, 0, n-1,
+ impl.Dhseqr(lapack.EigenvaluesOnly, lapack.SchurNone, n, 0, n-1,
nil, 1, nil, nil, nil, 1, work, -1)
maxwrk = max(maxwrk, max(n+1, n+int(work[0])))
}
@@ -197,7 +197,7 @@ func (impl Implementation) Dgeev(jobvl lapack.LeftEVJob, jobvr lapack.RightEVJob
} else {
// Compute eigenvalues only.
iwrk = n
- first = impl.Dhseqr(lapack.EigenvaluesOnly, lapack.None, n, ilo, ihi,
+ first = impl.Dhseqr(lapack.EigenvaluesOnly, lapack.SchurNone, n, ilo, ihi,
a, lda, wr, wi, nil, 1, work[iwrk:], lwork-iwrk)
}

MODIFY
lapack/gonum/dgesvd.go
lapack/gonum/dgesvd.go
@@ -86,13 +86,13 @@ func (impl Implementation) Dgesvd(jobU, jobVT lapack.SVDJob, m, n int, a []float
wantus := jobU == lapack.SVDInPlace
wantuas := wantua || wantus
wantuo := jobU == lapack.SVDOverwrite
- wantun := jobU == lapack.None
+ wantun := jobU == lapack.SVDNone
wantva := jobVT == lapack.SVDAll
wantvs := jobVT == lapack.SVDInPlace
wantvas := wantva || wantvs
wantvo := jobVT == lapack.SVDOverwrite
- wantvn := jobVT == lapack.None
+ wantvn := jobVT == lapack.SVDNone
bi := blas64.Implementation()
var mnthr int

MODIFY
lapack/lapack.go
lapack/lapack.go
@@ -6,8 +6,6 @@ package lapack
import "gonum.org/v1/gonum/blas"
-const None = 'N'
-
// Complex128 defines the public complex128 LAPACK API supported by gonum/lapack.
type Complex128 interface{}

MODIFY
lapack/testlapack/dsteqr.go
lapack/testlapack/dsteqr.go
@@ -137,7 +137,7 @@ func DsteqrTest(t *testing.T, impl Dsteqrer) {
for i := range work {
work[i] = rnd.Float64()
}
- impl.Dsteqr(lapack.None, n, dDecomp, eDecomp, aDecomp, lda, work)
+ impl.Dsteqr(lapack.EVCompNone, n, dDecomp, eDecomp, aDecomp, lda, work)
if !floats.EqualApprox(d, dAns, 1e-8) {
t.Errorf("Eigenvalue mismatch when eigenvectors not computed")
}

MODIFY
lapack/testlapack/dsyev.go
lapack/testlapack/dsyev.go
@@ -106,7 +106,7 @@ func DsyevTest(t *testing.T, impl Dsyever) {
for i := range work {
work[i] = rnd.Float64()
}
- impl.Dsyev(lapack.None, uplo, n, a, lda, w, work, len(work))
+ impl.Dsyev(lapack.EVNone, uplo, n, a, lda, w, work, len(work))
if !floats.EqualApprox(w, wAns, 1e-8) {
t.Errorf("Eigenvalue mismatch when vectors not computed")
}

lapack: remove None const