Fixed segfault because wrong order in args
MODIFY
include/afl-fuzz.h
include/afl-fuzz.h
@@ -642,6 +642,7 @@ typedef struct afl_state {
char * statsd_tags_flavor;
char * statsd_tags_format;
char * statsd_metric_format;
+ int statsd_metric_format_type;
double stats_avg_exec;

MODIFY
src/afl-fuzz-statsd.c
src/afl-fuzz-statsd.c
#define SIGNALFX_TAGS_FORMAT "[banner=%s,afl_version=%s]"
// For DogstatsD
-#define STATSD_TAGS_AFTER_METRICS \
+#define STATSD_TAGS_TYPE_SUFFIX 1
+#define STATSD_TAGS_SUFFIX_METRICS \
METRIC_PREFIX \
".cycle_done:%llu|g%s\n" METRIC_PREFIX \
".cycles_wo_finds:%llu|g%s\n" METRIC_PREFIX \
".paths_total:%u|g%s\n" METRIC_PREFIX \
".paths_favored:%u|g%s\n" METRIC_PREFIX \
".paths_found:%u|g%s\n" METRIC_PREFIX \
- ".paths_imported:%u|g%s\n" METRIC_PREFIX \
- ".max_depth:%u|g%s\n" METRIC_PREFIX ".cur_path:%u|g%s\n" METRIC_PREFIX \
- ".pending_favs:%u|g%s\n" METRIC_PREFIX \
+ ".paths_imported:%u|g%s\n" METRIC_PREFIX ".max_depth:%u|g%s\n" METRIC_PREFIX \
+ ".cur_path:%u|g%s\n" METRIC_PREFIX ".pending_favs:%u|g%s\n" METRIC_PREFIX \
".pending_total:%u|g%s\n" METRIC_PREFIX \
".variable_paths:%u|g%s\n" METRIC_PREFIX \
".unique_crashes:%llu|g%s\n" METRIC_PREFIX \
".var_byte_count:%u|g%s\n" METRIC_PREFIX ".havoc_expansion:%u|g%s\n"
// For Librato, InfluxDB, SignalFX
+#define STATSD_TAGS_TYPE_MID 2
#define STATSD_TAGS_MID_METRICS \
METRIC_PREFIX \
".cycle_done%s:%llu|g\n" METRIC_PREFIX \
".paths_total%s:%u|g\n" METRIC_PREFIX \
".paths_favored%s:%u|g\n" METRIC_PREFIX \
".paths_found%s:%u|g\n" METRIC_PREFIX \
- ".paths_imported%s:%u|g\n" METRIC_PREFIX \
- ".max_depth%s:%u|g\n" METRIC_PREFIX ".cur_path%s:%u|g\n" METRIC_PREFIX \
- ".pending_favs%s:%u|g\n" METRIC_PREFIX \
+ ".paths_imported%s:%u|g\n" METRIC_PREFIX ".max_depth%s:%u|g\n" METRIC_PREFIX \
+ ".cur_path%s:%u|g\n" METRIC_PREFIX ".pending_favs%s:%u|g\n" METRIC_PREFIX \
".pending_total%s:%u|g\n" METRIC_PREFIX \
".variable_paths%s:%u|g\n" METRIC_PREFIX \
".unique_crashes%s:%llu|g\n" METRIC_PREFIX \
@@ -84,22 +84,26 @@ void statsd_setup_format(afl_state_t *afl) {
if (strcmp(afl->afl_env.afl_statsd_tags_flavor, "dogstatsd") == 0) {
afl->statsd_tags_format = DOGSTATSD_TAGS_FORMAT;
- afl->statsd_metric_format = STATSD_TAGS_AFTER_METRICS;
+ afl->statsd_metric_format = STATSD_TAGS_SUFFIX_METRICS;
+ afl->statsd_metric_format_type = STATSD_TAGS_TYPE_SUFFIX;
} else if (strcmp(afl->afl_env.afl_statsd_tags_flavor, "librato") == 0) {
afl->statsd_tags_format = LIBRATO_TAGS_FORMAT;
afl->statsd_metric_format = STATSD_TAGS_MID_METRICS;
+ afl->statsd_metric_format_type = STATSD_TAGS_TYPE_MID;
} else if (strcmp(afl->afl_env.afl_statsd_tags_flavor, "influxdb") == 0) {
afl->statsd_tags_format = INFLUXDB_TAGS_FORMAT;
afl->statsd_metric_format = STATSD_TAGS_MID_METRICS;
+ afl->statsd_metric_format_type = STATSD_TAGS_TYPE_MID;
} else if (strcmp(afl->afl_env.afl_statsd_tags_flavor, "signalfx") == 0) {
afl->statsd_tags_format = SIGNALFX_TAGS_FORMAT;
afl->statsd_metric_format = STATSD_TAGS_MID_METRICS;
+ afl->statsd_metric_format_type = STATSD_TAGS_TYPE_MID;
} else {
@@ -108,6 +112,7 @@ void statsd_setup_format(afl_state_t *afl) {
// Still need to pick a format. Doesn't change anything since if will be
// replaced by the empty string anyway.
afl->statsd_metric_format = STATSD_TAGS_MID_METRICS;
+ afl->statsd_metric_format_type = STATSD_TAGS_TYPE_MID;
}
@@ -188,7 +193,7 @@ int statsd_send_metric(afl_state_t *afl) {
(struct sockaddr *)&afl->statsd_server,
sizeof(afl->statsd_server)) == -1) {
- if (!close(afl->statsd_sock)) { FATAL("Cannot close socket"); }
+ if (!close(afl->statsd_sock)) { PFATAL("Cannot close socket"); }
afl->statsd_sock = 0;
WARNF("Cannot sendto");
return -1;
@@ -208,6 +213,8 @@ int statsd_format_metric(afl_state_t *afl, char *buff, size_t bufflen) {
/* Sends multiple metrics with one UDP Packet.
bufflen will limit to the max safe size.
*/
+ if (afl->statsd_metric_format_type == STATSD_TAGS_TYPE_SUFFIX) {
+
snprintf(buff, bufflen, afl->statsd_metric_format,
afl->queue_cycle ? (afl->queue_cycle - 1) : 0, tags,
afl->cycles_wo_finds, tags, afl->fsrv.total_execs, tags,
@@ -215,13 +222,33 @@ int statsd_format_metric(afl_state_t *afl, char *buff, size_t bufflen) {
((double)(get_cur_time() - afl->start_time) / 1000),
tags, afl->queued_paths, tags, afl->queued_favored, tags,
afl->queued_discovered, tags, afl->queued_imported, tags,
- afl->max_depth, tags, afl->current_entry, tags, afl->pending_favored,
- tags, afl->pending_not_fuzzed, tags, afl->queued_variable, tags,
- afl->unique_crashes, tags, afl->unique_hangs, tags,
- afl->total_crashes, tags, afl->slowest_exec_ms, tags,
+ afl->max_depth, tags, afl->current_entry, tags,
+ afl->pending_favored, tags, afl->pending_not_fuzzed, tags,
+ afl->queued_variable, tags, afl->unique_crashes, tags,
+ afl->unique_hangs, tags, afl->total_crashes, tags,
+ afl->slowest_exec_ms, tags,
count_non_255_bytes(afl, afl->virgin_bits), tags,
afl->var_byte_count, tags, afl->expand_havoc, tags);
+ } else if (afl->statsd_metric_format_type == STATSD_TAGS_TYPE_MID) {
+
+ snprintf(buff, bufflen, afl->statsd_metric_format, tags,
+ afl->queue_cycle ? (afl->queue_cycle - 1) : 0, tags,
+ afl->cycles_wo_finds, tags, afl->fsrv.total_execs, tags,
+ afl->fsrv.total_execs /
+ ((double)(get_cur_time() - afl->start_time) / 1000),
+ tags, afl->queued_paths, tags, afl->queued_favored, tags,
+ afl->queued_discovered, tags, afl->queued_imported, tags,
+ afl->max_depth, tags, afl->current_entry, tags,
+ afl->pending_favored, tags, afl->pending_not_fuzzed, tags,
+ afl->queued_variable, tags, afl->unique_crashes, tags,
+ afl->unique_hangs, tags, afl->total_crashes, tags,
+ afl->slowest_exec_ms, tags,
+ count_non_255_bytes(afl, afl->virgin_bits), tags,
+ afl->var_byte_count, tags, afl->expand_havoc);
+
+ }
+
return 0;
}

Fixed segfault because wrong order in args