improve test coverage for IP address parsing code
MODIFY
src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java
src/test/java/org/apache/commons/io/FilenameUtilsTestCase.java
@@ -249,12 +249,30 @@ public void testNormalize() throws Exception {
assertEquals(SEP + SEP + "127.0.0.1" + SEP + "a" + SEP + "b" + SEP + "c.txt", FilenameUtils.normalize("\\\\127.0.0.1\\a\\b\\c.txt"));
assertEquals(SEP + SEP + "::1" + SEP + "a" + SEP + "b" + SEP + "c.txt", FilenameUtils.normalize("\\\\::1\\a\\b\\c.txt"));
+ assertEquals(SEP + SEP + "1::" + SEP + "a" + SEP + "b" + SEP + "c.txt", FilenameUtils.normalize("\\\\1::\\a\\b\\c.txt"));
assertEquals(SEP + SEP + "server.example.org" + SEP + "a" + SEP + "b" + SEP + "c.txt", FilenameUtils.normalize("\\\\server.example.org\\a\\b\\c.txt"));
+ assertEquals(SEP + SEP + "server.sub.example.org" + SEP + "a" + SEP + "b" + SEP + "c.txt", FilenameUtils.normalize("\\\\server.sub.example.org\\a\\b\\c.txt"));
assertEquals(SEP + SEP + "server." + SEP + "a" + SEP + "b" + SEP + "c.txt", FilenameUtils.normalize("\\\\server.\\a\\b\\c.txt"));
+ assertEquals(SEP + SEP + "1::127.0.0.1" + SEP + "a" + SEP + "b" + SEP + "c.txt",
+ FilenameUtils.normalize("\\\\1::127.0.0.1\\a\\b\\c.txt"));
+
+ // not valid IPv4 addresses but technically a valid "reg-name"s according to RFC1034
+ assertEquals(SEP + SEP + "127.0.0.256" + SEP + "a" + SEP + "b" + SEP + "c.txt",
+ FilenameUtils.normalize("\\\\127.0.0.256\\a\\b\\c.txt"));
+ assertEquals(SEP + SEP + "127.0.0.01" + SEP + "a" + SEP + "b" + SEP + "c.txt",
+ FilenameUtils.normalize("\\\\127.0.0.01\\a\\b\\c.txt"));
assertEquals(null, FilenameUtils.normalize("\\\\-server\\a\\b\\c.txt"));
assertEquals(null, FilenameUtils.normalize("\\\\.\\a\\b\\c.txt"));
assertEquals(null, FilenameUtils.normalize("\\\\..\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\127.0..1\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\::1::2\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\:1\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\1:\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\1:2:3:4:5:6:7:8:9\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\g:2:3:4:5:6:7:8\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\1ffff:2:3:4:5:6:7:8\\a\\b\\c.txt"));
+ assertEquals(null, FilenameUtils.normalize("\\\\1:2\\a\\b\\c.txt"));
}
@Test

improve test coverage for IP address parsing code