Fix small things from review
MODIFY
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/ChannelFutureListenerInstrumentation.java
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/ChannelFutureListenerInstrumentation.java
@@ -4,6 +4,7 @@ import static datadog.trace.agent.tooling.ClassLoaderMatcher.hasClassesNamed;
import static datadog.trace.agent.tooling.bytebuddy.matcher.DDElementMatchers.implementsInterface;
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activateSpan;
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.startSpan;
+import static datadog.trace.instrumentation.netty38.server.NettyHttpServerDecorator.DECORATE;
import static java.util.Collections.singletonMap;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
import static net.bytebuddy.matcher.ElementMatchers.named;
@@ -17,7 +18,6 @@ import datadog.trace.bootstrap.instrumentation.api.AgentScope;
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
import datadog.trace.bootstrap.instrumentation.api.Tags;
import datadog.trace.context.TraceScope;
-import datadog.trace.instrumentation.netty38.server.NettyHttpServerDecorator;
import java.util.Collections;
import java.util.Map;
import net.bytebuddy.asm.Advice;
@@ -103,8 +103,8 @@ public class ChannelFutureListenerInstrumentation extends Instrumenter.Default {
final AgentSpan errorSpan = startSpan("netty.connect").setTag(Tags.COMPONENT, "netty");
try (final AgentScope scope = activateSpan(errorSpan, false)) {
- NettyHttpServerDecorator.DECORATE.onError(errorSpan, cause);
- NettyHttpServerDecorator.DECORATE.beforeFinish(errorSpan);
+ DECORATE.onError(errorSpan, cause);
+ DECORATE.beforeFinish(errorSpan);
errorSpan.finish();
}

RENAME
dd-java-agent/instrumentation/netty-3.8/src/test/groovy/Netty39ClientTest.groovy
dd-java-agent/instrumentation/netty-3.8/src/test/groovy/Netty38ClientTest.groovy
@@ -15,7 +15,7 @@ import static datadog.trace.agent.test.utils.PortUtils.UNUSABLE_PORT
import static datadog.trace.agent.test.utils.TraceUtils.basicSpan
import static datadog.trace.agent.test.utils.TraceUtils.runUnderTrace
-class Netty39ClientTest extends HttpClientTest {
+class Netty38ClientTest extends HttpClientTest {
@Shared
def clientConfig = new AsyncHttpClientConfig.Builder().setRequestTimeoutInMs(TimeUnit.SECONDS.toMillis(10).toInteger()).build()

RENAME
dd-java-agent/instrumentation/netty-3.8/src/test/groovy/Netty39ServerTest.groovy
dd-java-agent/instrumentation/netty-3.8/src/test/groovy/Netty38ServerTest.groovy
@@ -14,7 +14,7 @@ import static datadog.trace.agent.test.base.HttpServerTest.ServerEndpoint.*
import static org.jboss.netty.handler.codec.http.HttpHeaders.Names.*
import static org.jboss.netty.handler.codec.http.HttpVersion.HTTP_1_1
-class Netty39ServerTest extends HttpServerTest<Channel> {
+class Netty38ServerTest extends HttpServerTest<Channel> {
ChannelPipeline channelPipeline() {
ChannelPipeline channelPipeline = new DefaultChannelPipeline()

Fix small things from review