Fix some style CodeFactor issues
MODIFY
WalletWasabi.Gui/Helpers/ShellUtils.cs
WalletWasabi.Gui/Helpers/ShellUtils.cs
@@ -112,8 +112,6 @@ namespace WalletWasabi.Gui.Helpers
/// <summary>
/// Attempts to locate the full path to a script
/// </summary>
- /// <param name="fileName"></param>
- /// <returns></returns>
public static string ResolveFullExecutablePath(string fileName, bool returnNullOnFailure = true, params string[] extraPaths)
{
if (File.Exists(fileName))

MODIFY
WalletWasabi.Packager/NSubsys/PeUtility.cs
WalletWasabi.Packager/NSubsys/PeUtility.cs
@@ -67,9 +67,6 @@ namespace NSubsys
/// Reads in a block from a file and converts it to the struct
/// type specified by the template parameter
/// </summary>
- /// <typeparam name="T"></typeparam>
- /// <param name="reader"></param>
- /// <returns></returns>
public static T FromBinaryReader<T>(BinaryReader reader)
{
// Read in a byte array

MODIFY
WalletWasabi.Packager/Tools.cs
WalletWasabi.Packager/Tools.cs
@@ -44,18 +44,18 @@ namespace WalletWasabi.Packager
}
}
- //public static void RemoveSosDocsUnix(string pathToSearch)
- //{
- // // ToDo ?: Must remove from the ui.deps.json, too otherwise binary will fail.
- // // Leave it to not do anything for now.
- // string[] files = Directory.GetFiles(pathToSearch, "sosdocsunix.txt", SearchOption.AllDirectories);
- // if (files is null) return;
+ ////public static void RemoveSosDocsUnix(string pathToSearch)
+ ////{
+ //// // ToDo ?: Must remove from the ui.deps.json, too otherwise binary will fail.
+ //// // Leave it to not do anything for now.
+ //// string[] files = Directory.GetFiles(pathToSearch, "sosdocsunix.txt", SearchOption.AllDirectories);
+ //// if (files is null) return;
- // foreach (var sosDocsUnixFilePath in files)
- // {
- // File.Delete(sosDocsUnixFilePath);
- // }
- //}
+ //// foreach (var sosDocsUnixFilePath in files)
+ //// {
+ //// File.Delete(sosDocsUnixFilePath);
+ //// }
+ ////}
public static string LinuxPathCombine(params string[] paths)
{

MODIFY
WalletWasabi/Helpers/EnvironmentHelpers.cs
WalletWasabi/Helpers/EnvironmentHelpers.cs
@@ -165,7 +165,6 @@ namespace WalletWasabi.Helpers
/// Executes a command with bash.
/// https://stackoverflow.com/a/47918132/2061103
/// </summary>
- /// <param name="cmd"></param>
public static async Task ShellExecAsync(string cmd, bool waitForExit = true)
{
var escapedArgs = cmd.Replace("\"", "\\\"");

MODIFY
WalletWasabi/Models/Height.cs
WalletWasabi/Models/Height.cs
@@ -15,13 +15,11 @@ namespace WalletWasabi.Models
/// <summary>
/// Gets a new Height instance for mempool
/// </summary>
- /// <returns></returns>
public static Height Mempool { get; } = new Height(HeightType.Mempool);
/// <summary>
/// Gets a new Height instance for unknown (no chain, no mempool)
/// </summary>
- /// <returns></returns>
public static Height Unknown { get; } = new Height(HeightType.Unknown);
public Height(uint height) : this((int)height)

Fix some style CodeFactor issues