Clarify muzzle specific checks
MODIFY
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/ChannelFutureListenerInstrumentation.java
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/ChannelFutureListenerInstrumentation.java
@@ -41,6 +41,7 @@ public class ChannelFutureListenerInstrumentation extends Instrumenter.Default {
// Optimization for expensive typeMatcher.
return hasClassesNamed(
"org.jboss.netty.channel.ChannelFutureListener",
+ // 3.10: NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader
"org.jboss.netty.channel.StaticChannelPipeline" // Not in 3.10
);
}

MODIFY
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/NettyChannelInstrumentation.java
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/NettyChannelInstrumentation.java
@@ -34,7 +34,9 @@ public class NettyChannelInstrumentation extends Instrumenter.Default {
// Optimization for expensive typeMatcher.
return hasClassesNamed(
"org.jboss.netty.channel.Channel",
+ // 3.7: cannot find symbol method headers() for type HttpRequest
"org.jboss.netty.handler.codec.http.DefaultHttpHeaders", // Not in 3.7
+ // 3.10: NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader
"org.jboss.netty.channel.StaticChannelPipeline" // Not in 3.10
);
}

MODIFY
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/NettyChannelPipelineInstrumentation.java
dd-java-agent/instrumentation/netty-3.8/src/main/java/datadog/trace/instrumentation/netty38/NettyChannelPipelineInstrumentation.java
@@ -50,6 +50,7 @@ public class NettyChannelPipelineInstrumentation extends Instrumenter.Default {
// Optimization for expensive typeMatcher.
return hasClassesNamed(
"org.jboss.netty.channel.ChannelPipeline",
+ // 3.10: NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader
"org.jboss.netty.channel.StaticChannelPipeline" // Not in 3.10
);
}

Clarify muzzle specific checks