bots: Do not remove self from list of recipients in group PMs.
The origin of this line seems like an arbitary decision when writing the
wikipedia bot in Removing self
doesn't have any other significance, and not making any changes to the
recipient list helps with
Fixes
MODIFY
zulip_bots/zulip_bots/lib.py
zulip_bots/zulip_bots/lib.py
@@ -165,7 +165,7 @@ class ExternalBotHandler:
if message['type'] == 'private':
return self.send_message(dict(
type='private',
- to=[x['email'] for x in message['display_recipient'] if self.email != x['email']],
+ to=[x['email'] for x in message['display_recipient']],
content=response,
widget_content=widget_content,
))

MODIFY
zulip_bots/zulip_bots/tests/test_lib.py
zulip_bots/zulip_bots/tests/test_lib.py
@@ -120,7 +120,7 @@ class LibTest(TestCase):
expected = [({'type': 'private', 'display_recipient': [to]},
{'type': 'private', 'to': [to['email']]}, None),
({'type': 'private', 'display_recipient': [to, profile]},
- {'type': 'private', 'to': [to['email']]}, 'widget_content'),
+ {'type': 'private', 'to': [to['email'], profile['email']]}, 'widget_content'),
({'type': 'stream', 'display_recipient': 'Stream name', 'subject': 'Topic'},
{'type': 'stream', 'to': 'Stream name', 'subject': 'Topic'}, 'test widget')]
response_text = "Response"

bots: Do not remove self from list of recipients in group PMs.

The origin of this line seems like an arbitary decision when writing the
wikipedia bot in ad25f278534bc21310c1e3bd8a8021154bc19126. Removing self
doesn't have any other significance, and not making any changes to the
recipient list helps with https://github.com/zulip/zulip/issues/14228.

Fixes #552.