mediaapi/fileutils: Fix and comment os.IsNotExist bug
MODIFY
src/github.com/matrix-org/dendrite/mediaapi/fileutils/fileutils.go
src/github.com/matrix-org/dendrite/mediaapi/fileutils/fileutils.go
@@ -76,7 +76,9 @@ func MoveFileWithHashCheck(tmpDir types.Path, mediaMetadata *types.MediaMetadata
}
var stat os.FileInfo
- if stat, err = os.Stat(finalPath); os.IsExist(err) {
+ // Note: The double-negative is intentional as os.IsExist(err) != !os.IsNotExist(err).
+ // The functions are error checkers to be used in different cases.
+ if stat, err = os.Stat(finalPath); !os.IsNotExist(err) {
duplicate = true
if stat.Size() == int64(mediaMetadata.FileSizeBytes) {
return types.Path(finalPath), duplicate, nil

mediaapi/fileutils: Fix and comment os.IsNotExist bug