fixing some issue after the merge
MODIFY
src/main/java/com/datadoghq/trace/impl/DDSpan.java
src/main/java/com/datadoghq/trace/impl/DDSpan.java
package com.datadoghq.trace.impl;
-import java.util.LinkedHashSet;
-import java.util.Map;
-import java.util.Optional;
+import java.time.Clock;
+import java.util.*;
import com.fasterxml.jackson.annotation.JsonGetter;
-import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonIgnore;
import io.opentracing.Span;
import io.opentracing.SpanContext;
@@ -16,30 +15,29 @@ public class DDSpan implements io.opentracing.Span {
protected final Tracer tracer;
protected String operationName;
protected Map<String, Object> tags;
- protected long startTime;
- protected long startTimeNano; // Only used to measure nano time durations
+ protected long startTimeNano;
protected long durationNano;
protected final DDSpanContext context;
- protected final LinkedHashSet<Span> traces;
+ protected final ArrayList<Span> trace;
DDSpan(
Tracer tracer,
String operationName,
- LinkedHashSet<Span> traces,
+ ArrayList<Span> trace,
Map<String, Object> tags,
- Long timestamp,
+ Long timestampMilliseconds,
DDSpanContext context) {
this.tracer = tracer;
this.operationName = operationName;
- this.traces = Optional.ofNullable(traces).orElse(new LinkedHashSet<>());
+ this.trace = Optional.ofNullable(trace).orElse(new ArrayList<>());
this.tags = tags;
- this.startTime = System.currentTimeMillis() * 1000000;
- this.startTimeNano = System.nanoTime();
+ this.startTimeNano = Optional.ofNullable(timestampMilliseconds).orElse(Clock.systemUTC().millis()) * 1000000L;
this.context = context;
// track each span of the trace
- this.traces.add(this);
+ this.trace.add(this);
+
}
public SpanContext context() {
@@ -47,20 +45,19 @@ public class DDSpan implements io.opentracing.Span {
}
public void finish() {
- this.durationNano = System.nanoTime() - startTimeNano;
- afterFinish();
- }
-
- public void finish(long stopTimeMicro) {
- this.durationNano = stopTimeMicro * 1000L - startTime;
- afterFinish();
+ finish(Clock.systemUTC().millis());
}
- protected void afterFinish(){
+ public void finish(long stopTimeMillis) {
+ this.durationNano = (stopTimeMillis * 1000000L - startTimeNano) ;
if (this.isRootSpan()) {
- this.traces.stream()
- .filter(s -> ((DDSpanContext) s.context()).getSpanId() != ((DDSpanContext) this.context()).getSpanId())
- .forEach(s -> s.finish());
+ this.trace.stream()
+ .filter(s -> {
+ boolean isSelf = ((DDSpanContext) s.context()).getSpanId() == ((DDSpanContext) this.context()).getSpanId();
+ boolean isFinished = ((DDSpan) s).getDurationNano() != 0L;
+ return !isSelf && !isFinished;
+ })
+ .forEach(Span::finish);
}
}
@@ -146,7 +143,7 @@ public class DDSpan implements io.opentracing.Span {
@JsonGetter(value = "start")
public long getStartTime() {
- return startTime;
+ return startTimeNano;
}
@JsonGetter(value = "duration")
@@ -187,7 +184,7 @@ public class DDSpan implements io.opentracing.Span {
}
@JsonIgnore
- public LinkedHashSet<Span> getTraces() {
- return traces;
+ public ArrayList<Span> getTrace() {
+ return trace;
}
}

fixing some issue after the merge