Switch UT and remove obsoleted comment
MODIFY
WalletWasabi.Tests/UnitTests/WabiSabi/Models/ConstructionStateTests.cs
WalletWasabi.Tests/UnitTests/WabiSabi/Models/ConstructionStateTests.cs
@@ -28,12 +28,12 @@ public class ConstructionStateTests
var state = round.Assert<ConstructionState>();
var (coin, ownershipProof) = WabiSabiFactory.CreateCoinWithOwnershipProof(
- amount: roundParameters.AllowedInputAmounts.Min + miningFeeRate.GetFee(Constants.P2wpkhInputVirtualSize),
+ amount: roundParameters.AllowedInputAmounts.Min + miningFeeRate.GetFee(Constants.P2wpkhInputVirtualSize + Constants.P2wpkhOutputVirtualSize),
roundId: round.Id);
state = state.AddInput(coin, ownershipProof, WabiSabiFactory.CreateCommitmentData(round.Id));
state = state.AddOutput(new TxOut(roundParameters.AllowedInputAmounts.Min, new Script("0 bf3593d140d512eb607b3ddb5c5ee085f1e3a210") ));
- var ex = Assert.Throws<WabiSabiProtocolException>(() => state.Finalize());
- Assert.Equal(WabiSabiProtocolErrorCode.InsufficientFees, ex.ErrorCode);
+ var signingState = state.Finalize();
+ Assert.Equal(miningFeeRate, signingState.EffectiveFeeRate);
}
}

MODIFY
WalletWasabi/WabiSabi/Models/MultipartyTransaction/MultipartyTransactionState.cs
WalletWasabi/WabiSabi/Models/MultipartyTransaction/MultipartyTransactionState.cs
@@ -48,10 +48,6 @@ public abstract record MultipartyTransactionState
[JsonIgnore] protected int UnpaidSharedOverhead { get; init; } = MultipartyTransactionParameters.SharedOverhead;
- // With no coordinator fees we can't ensure that the shared overhead
- // of the transaction also pays at the nominal feerate so this will have
- // to do for now, but in the future EstimatedVsize should be used
- // including the shared overhead
[JsonIgnore]
public FeeRate EffectiveFeeRate => new(Balance, EstimatedVsize - UnpaidSharedOverhead);

Switch UT and remove obsoleted comment