url
stringlengths
63
63
repository_url
stringclasses
1 value
labels_url
stringlengths
77
77
comments_url
stringlengths
72
72
events_url
stringlengths
70
70
html_url
stringlengths
51
53
id
int64
1.57B
2.35B
node_id
stringlengths
18
19
number
int64
59.5k
69.6k
title
stringlengths
1
554
user
dict
labels
listlengths
0
8
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
8
milestone
null
comments
sequencelengths
0
30
created_at
timestamp[s]
updated_at
timestamp[s]
closed_at
timestamp[s]
author_association
stringclasses
4 values
active_lock_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
body
stringlengths
1
65.4k
reactions
dict
timeline_url
stringlengths
72
72
performed_via_github_app
null
state_reason
stringclasses
3 values
is_pull_request
bool
2 classes
https://api.github.com/repos/tensorflow/tensorflow/issues/59712
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59712/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59712/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59712/events
https://github.com/tensorflow/tensorflow/issues/59712
1,587,856,197
I_kwDOArmXAs5epMNF
59,712
tensor.ndim not working in tensorflow.function decorator
{ "login": "MegaCreater", "id": 45305845, "node_id": "MDQ6VXNlcjQ1MzA1ODQ1", "avatar_url": "https://avatars.githubusercontent.com/u/45305845?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MegaCreater", "html_url": "https://github.com/MegaCreater", "followers_url": "https://api.github.com/users/MegaCreater/followers", "following_url": "https://api.github.com/users/MegaCreater/following{/other_user}", "gists_url": "https://api.github.com/users/MegaCreater/gists{/gist_id}", "starred_url": "https://api.github.com/users/MegaCreater/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MegaCreater/subscriptions", "organizations_url": "https://api.github.com/users/MegaCreater/orgs", "repos_url": "https://api.github.com/users/MegaCreater/repos", "events_url": "https://api.github.com/users/MegaCreater/events{/privacy}", "received_events_url": "https://api.github.com/users/MegaCreater/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59712\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59712\">No</a>\n" ]
2023-02-16T15:11:02
2023-02-16T15:30:19
2023-02-16T15:30:16
NONE
null
null
null
Tensorflow Version -> v2.11.0-rc2-17-gd5b57ca93e5, 2.11.0 Custom Code -> Yes OS Platform and Distribution -> Google colab ### Standalone code to reproduce the issue ```python3 import tensorflow as tf tensor=tf.random.normal((32,128,128,3)) # some images print('Work here->',tensor.ndim) @tf.function def some_function(images): #assert images.ndim==4 # not working here also # some complex code print('NOT working here->',images.ndim) some_function(tensor) ``` ### Relevant log output ```shell --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) [<ipython-input-247-f1adf673db7a>](https://localhost:8080/#) in <module> 10 print('NOT working here->',images.ndim) 11 ---> 12 some_function(tensor) 1 frames [/usr/local/lib/python3.8/dist-packages/tensorflow/python/util/traceback_utils.py](https://localhost:8080/#) in error_handler(*args, **kwargs) 151 except Exception as e: 152 filtered_tb = _process_traceback_frames(e.__traceback__) --> 153 raise e.with_traceback(filtered_tb) from None 154 finally: 155 del filtered_tb [/tmp/__autograph_generated_filesflyrml3.py](https://localhost:8080/#) in tf__some_function(images) 6 def tf__some_function(images): 7 with ag__.FunctionScope('some_function', 'fscope', ag__.ConversionOptions(recursive=True, user_requested=True, optional_features=(), internal_convert_user_code=True)) as fscope: ----> 8 ag__.ld(print)('NOT working here->', ag__.ld(images).ndim) 9 return tf__some_function 10 return inner_factory AttributeError: in user code: File "<ipython-input-246-0cf28125d885>", line 10, in some_function * print('NOT working here->',images.ndim) AttributeError: 'Tensor' object has no attribute 'ndim' ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59712/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59712/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59711
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59711/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59711/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59711/events
https://github.com/tensorflow/tensorflow/issues/59711
1,587,574,514
I_kwDOArmXAs5eoHby
59,711
Cannot convert explicit Q/DQ nodes using TF-TRT
{ "login": "codejaeger", "id": 32168969, "node_id": "MDQ6VXNlcjMyMTY4OTY5", "avatar_url": "https://avatars.githubusercontent.com/u/32168969?v=4", "gravatar_id": "", "url": "https://api.github.com/users/codejaeger", "html_url": "https://github.com/codejaeger", "followers_url": "https://api.github.com/users/codejaeger/followers", "following_url": "https://api.github.com/users/codejaeger/following{/other_user}", "gists_url": "https://api.github.com/users/codejaeger/gists{/gist_id}", "starred_url": "https://api.github.com/users/codejaeger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/codejaeger/subscriptions", "organizations_url": "https://api.github.com/users/codejaeger/orgs", "repos_url": "https://api.github.com/users/codejaeger/repos", "events_url": "https://api.github.com/users/codejaeger/events{/privacy}", "received_events_url": "https://api.github.com/users/codejaeger/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1754777628, "node_id": "MDU6TGFiZWwxNzU0Nzc3NjI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu:tensorrt", "name": "comp:gpu:tensorrt", "color": "ea98ba", "default": false, "description": "Issues specific to TensorRT" }, { "id": 4511033337, "node_id": "LA_kwDOArmXAs8AAAABDODn-Q", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.10", "name": "TF 2.10", "color": "C15088", "default": false, "description": "" } ]
open
false
{ "login": "poulsbo", "id": 1046529, "node_id": "MDQ6VXNlcjEwNDY1Mjk=", "avatar_url": "https://avatars.githubusercontent.com/u/1046529?v=4", "gravatar_id": "", "url": "https://api.github.com/users/poulsbo", "html_url": "https://github.com/poulsbo", "followers_url": "https://api.github.com/users/poulsbo/followers", "following_url": "https://api.github.com/users/poulsbo/following{/other_user}", "gists_url": "https://api.github.com/users/poulsbo/gists{/gist_id}", "starred_url": "https://api.github.com/users/poulsbo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poulsbo/subscriptions", "organizations_url": "https://api.github.com/users/poulsbo/orgs", "repos_url": "https://api.github.com/users/poulsbo/repos", "events_url": "https://api.github.com/users/poulsbo/events{/privacy}", "received_events_url": "https://api.github.com/users/poulsbo/received_events", "type": "User", "site_admin": false }
[ { "login": "poulsbo", "id": 1046529, "node_id": "MDQ6VXNlcjEwNDY1Mjk=", "avatar_url": "https://avatars.githubusercontent.com/u/1046529?v=4", "gravatar_id": "", "url": "https://api.github.com/users/poulsbo", "html_url": "https://github.com/poulsbo", "followers_url": "https://api.github.com/users/poulsbo/followers", "following_url": "https://api.github.com/users/poulsbo/following{/other_user}", "gists_url": "https://api.github.com/users/poulsbo/gists{/gist_id}", "starred_url": "https://api.github.com/users/poulsbo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/poulsbo/subscriptions", "organizations_url": "https://api.github.com/users/poulsbo/orgs", "repos_url": "https://api.github.com/users/poulsbo/repos", "events_url": "https://api.github.com/users/poulsbo/events{/privacy}", "received_events_url": "https://api.github.com/users/poulsbo/received_events", "type": "User", "site_admin": false }, { "login": "DEKHTIARJonathan", "id": 10923599, "node_id": "MDQ6VXNlcjEwOTIzNTk5", "avatar_url": "https://avatars.githubusercontent.com/u/10923599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DEKHTIARJonathan", "html_url": "https://github.com/DEKHTIARJonathan", "followers_url": "https://api.github.com/users/DEKHTIARJonathan/followers", "following_url": "https://api.github.com/users/DEKHTIARJonathan/following{/other_user}", "gists_url": "https://api.github.com/users/DEKHTIARJonathan/gists{/gist_id}", "starred_url": "https://api.github.com/users/DEKHTIARJonathan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DEKHTIARJonathan/subscriptions", "organizations_url": "https://api.github.com/users/DEKHTIARJonathan/orgs", "repos_url": "https://api.github.com/users/DEKHTIARJonathan/repos", "events_url": "https://api.github.com/users/DEKHTIARJonathan/events{/privacy}", "received_events_url": "https://api.github.com/users/DEKHTIARJonathan/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@codejaeger can you re-execute with this defined first:\r\n```\r\nexport TF_TRT_SHOW_DETAILED_REPORT=1\r\n```\r\n\r\nPlease copy the log output here. Thanks", "Hi,\r\n\r\nThanks for the quick response. I have used the flag you mentioned and collected the logs below.\r\n\r\nWhile using `quantize_and_dequantize` at the `trt_func = converter.convert()` step\r\n```shell\r\n2023-02-17 04:15:02.325189: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.334523: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.335893: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.337785: I tensorflow/core/platform/cpu_feature_guard.cc:194] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: SSE3 SSE4.1 SSE4.2 AVX\r\nTo enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-02-17 04:15:02.338256: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.339644: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.341033: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.463483: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.464255: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.464901: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.465529: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1637] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 20554 MB memory: -> device: 0, name: NVIDIA A10, pci bus id: 0000:04:00.0, compute capability: 8.6\r\n2023-02-17 04:15:02.913897: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.914577: I tensorflow/core/grappler/devices.cc:66] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 1\r\n2023-02-17 04:15:02.914799: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session\r\n2023-02-17 04:15:02.915229: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.915866: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.916488: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.917169: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.917785: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:02.918368: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1637] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 20554 MB memory: -> device: 0, name: NVIDIA A10, pci bus id: 0000:04:00.0, compute capability: 8.6\r\nINFO:tensorflow:Clearing prior device assignments in loaded saved model\r\nINFO:tensorflow:Automatic mixed precision will be used on the whole TensorFlow Graph. This behavior can be deactivated using the environment variable: TF_TRT_EXPERIMENTAL_FEATURES=deactivate_mixed_precision.\r\nMore information can be found on: https://www.tensorflow.org/guide/mixed_precision.\r\n2023-02-17 04:15:03.126010: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:03.126716: I tensorflow/core/grappler/devices.cc:66] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 1\r\n2023-02-17 04:15:03.126943: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session\r\n2023-02-17 04:15:03.127281: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:03.127933: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:03.128545: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:03.129232: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:03.129848: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero\r\n2023-02-17 04:15:03.130423: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1637] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 20554 MB memory: -> device: 0, name: NVIDIA A10, pci bus id: 0000:04:00.0, compute capability: 8.6\r\n2023-02-17 04:15:03.143752: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:2359] Running auto_mixed_precision graph optimizer\r\n2023-02-17 04:15:03.152657: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1195] Automatic Mixed Precision Grappler Pass Summary:\r\n\r\nTotal processable nodes: 46\r\nRecognized nodes available for conversion: 11\r\nTotal nodes converted: 6\r\nTotal FP16 Cast ops used (excluding Const and Variable casts): 10\r\nAllowlisted nodes converted: 5\r\nDenylisted nodes blocking conversion: 0\r\nNodes blocked from conversion by denylisted nodes: 0\r\n\r\nFor more information regarding mixed precision training, including how to make automatic mixed precision aware of a custom op type, please see the documentation available here:\r\nhttps://docs.nvidia.com/deeplearning/frameworks/tensorflow-user-guide/index.html#tfamp\r\n\r\n\r\n2023-02-17 04:15:03.158267: I tensorflow/compiler/tf2tensorrt/convert/trt_optimization_pass.cc:206] [TF-TRT] Using explicit QDQ mode\r\n2023-02-17 04:15:03.159885: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_1/custom_conv2d_1q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160112: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_2/custom_conv2d_2q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160292: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_3/custom_conv2d_3q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160497: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_4/custom_conv2d_4q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160682: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_5/custom_conv2d_5q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160711: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_1/custom_conv2d_1_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160782: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_2/custom_conv2d_2_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160815: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_3/custom_conv2d_3_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160846: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_4/custom_conv2d_4_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160876: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_5/custom_conv2d_5_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.\r\n2023-02-17 04:15:03.160929: W tensorflow/compiler/tf2tensorrt/segment/segment.cc:952] \r\n\r\n################################################################################\r\nTensorRT unsupported/non-converted OP Report:\r\n - Conv2D -> 5x\r\n - [Count: 5x] Conv2D expects kernel of dimension 4\r\n\r\n - NoOp -> 2x\r\n - [Count: 2x] Op type NoOp is not supported.\r\n\r\n - Identity -> 1x\r\n - [Count: 1x] excluded by segmenter option. Most likely an input or output node.\r\n\r\n - Placeholder -> 1x\r\n - [Count: 1x] excluded by segmenter option. Most likely an input or output node.\r\n\r\n--------------------------------------------------------------------------------\r\n - Total nonconverted OPs: 9\r\n - Total nonconverted OP Types: 4\r\nFor more information see https://docs.nvidia.com/deeplearning/frameworks/tf-trt-user-guide/index.html#supported-ops.\r\n################################################################################\r\n\r\n2023-02-17 04:15:03.161089: W tensorflow/compiler/tf2tensorrt/segment/segment.cc:1280] The environment variable TF_TRT_MAX_ALLOWED_ENGINES=20 has no effect since there are only 5 TRT Engines with at least minimum_segment_size=3 nodes.\r\n2023-02-17 04:15:03.161110: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:799] Number of TensorRT candidate segments: 5\r\n2023-02-17 04:15:03.162706: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 0 consisting of 3 nodes by TRTEngineOp_000_000.\r\n2023-02-17 04:15:03.162745: W tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:919] TF-TRT Warning: Cannot replace segment 1 consisting of 16 nodes by TRTEngineOp_000_001 reason: Segment has no inputs (possible constfold failure) (keeping original segment).\r\n2023-02-17 04:15:03.162816: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 2 consisting of 3 nodes by TRTEngineOp_000_002.\r\n2023-02-17 04:15:03.162881: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 3 consisting of 3 nodes by TRTEngineOp_000_003.\r\n2023-02-17 04:15:03.162950: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 4 consisting of 3 nodes by TRTEngineOp_000_004.\r\n2023-02-17 04:15:03.165975: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do\r\n2023-02-17 04:15:03.167998: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do\r\n2023-02-17 04:15:03.169708: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do\r\n2023-02-17 04:15:03.171302: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do\r\n```\r\n\r\nThe `converter.build(input_fn=input_fn)` step with this flag being set seemed to suppress all the warnings I was getting without it.\r\n\r\nI noticed something else, while checking the converted model summary i.e. the converter shows the input and output dtypes to be in `float16` while upon checking the original model before TF-TRT conversion I can see the layer `dtypes` are inferred to be `float32`. \r\n\r\n```shell\r\n>>> converter.summary()\r\nTRTEngineOP Name Device # Nodes # Inputs # Outputs Input DTypes Output Dtypes Input Shapes Output Shapes \r\n================================================================================================================================================================\r\n\r\n----------------------------------------\r\n\r\nTRTEngineOp_000_000 device:GPU:0 5 1 1 ['float16'] ['float16'] [[-1, 112, 112 ... [[-1, 112, 112 ...\r\n\r\n - Cast: 2x\r\n - Const: 2x\r\n - QuantizeAndDequantizeV2: 1x\r\n\r\n----------------------------------------\r\n\r\nTRTEngineOp_000_002 device:GPU:0 5 1 1 ['float16'] ['float16'] [[-1, 56, 56, 64]] [[-1, 56, 56, 64]]\r\n\r\n - Cast: 2x\r\n - Const: 2x\r\n - QuantizeAndDequantizeV2: 1x\r\n\r\n----------------------------------------\r\n\r\nTRTEngineOp_000_003 device:GPU:0 5 1 1 ['float16'] ['float16'] [[-1, 28, 28, 64]] [[-1, 28, 28, 64]]\r\n\r\n - Cast: 2x\r\n - Const: 2x\r\n - QuantizeAndDequantizeV2: 1x\r\n\r\n----------------------------------------\r\n\r\nTRTEngineOp_000_004 device:GPU:0 5 1 1 ['float16'] ['float16'] [[-1, 14, 14, 64]] [[-1, 14, 14, 64]]\r\n\r\n - Cast: 2x\r\n - Const: 2x\r\n - QuantizeAndDequantizeV2: 1x\r\n\r\n================================================================================================================================================================\r\n[*] Total number of TensorRT engines: 4\r\n[*] % of OPs Converted: 41.67% [20/48]\r\n```\r\nIs this some automatic behavior of TF-TRT that can be suppressed?", "Any updates regarding this issue? @DEKHTIARJonathan are the logs above helpful to solve the issue or is anything more required?", "Just a quick note that TF-TRT with explicit quantize & dequantize is actually still experimental and not really supported. I just finished working through some of the issues you mentioned above, including Conv2D not being supported (for me it was because it had a tensor input). \r\n\r\n@DEKHTIARJonathan is there any active effort on this right now? Would be happy to join forces and add the fixes I've found", "I've opened another issue here: https://github.com/tensorflow/tensorflow/issues/60168\r\nI think that the fixes I've already implemented are real bugs and can be used to help here as well @codejaeger. \r\n" ]
2023-02-16T12:17:01
2023-03-29T23:42:00
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version TF 2.10 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 20.04.5 LTS ### Mobile device _No response_ ### Python version 3.8.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version CUDA 11.8 ### GPU model and memory _No response_ ### Current Behaviour? I am trying to convert a quantized TF model with TF-TRT, however, the following issues prevent me from doing so. I have attempted a temporary workaround to fix issue#1 but am stuck with no possible solution to the next problem. According to PR #52248, explicit Q/DQ models should be supported with Tensorflow when using Tensor-RT 8. *Problem 1* The non-deprecated way to add quantize-dequantize nodes in Tensorflow models is through `tf.quantization.quantize_and_dequantize_v2`. However, this adds https://github.com/tensorflow/tensorflow/blob/b6517cce24a06e07535c4b047a5991a290ef9368/tensorflow/python/ops/array_ops.py#L6323-L6326 nodes with tag `QuantizeAndDequantizeV4` https://github.com/tensorflow/tensorflow/blob/6285a27e1bc55c3adb10be723b16d43c444dbdcb/tensorflow/core/ops/array_ops.cc#L2916 which is clearly not supported in the list of ops for explicit precision mode. https://github.com/tensorflow/tensorflow/blob/7103c2ca32786fc7a2809a84e4c923196b208416/tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.h#L35-L39 A possible workaround is to use the deprecated API `tf.quantization.quantize_and_dequantize` which will add a `QuantizeAndDequantizeV2` node which is still supported. *Problem 2* After performing the hack above, I encounter a second error (possibly because of incorrect usage). To convert the explicitly quantized TF saved using TensorRT I am following the examples provided in the [Nvidia TF-TRT](https://docs.nvidia.com/deeplearning/frameworks/tf-trt-user-guide/index.html#quickstart-guide) documentation. However, I get failed tensorRT engine conversion issues and some warnings which I have attached in the log outputs. **Expected Behavior** The explicitly quantized Tensorflow saved models should be convertible with TF-TRT. ### Standalone code to reproduce the issue ```shell **Custom quantized keras layer to build an example model** import tensorflow as tf from tensorflow import keras class CustomConv2D(keras.layers.Layer): def __init__(self, filters, kernel_size, name="CustomConv2d"): super(CustomConv2D, self).__init__() self.w = self.add_weight( shape=(kernel_size, kernel_size, filters, filters), initializer="random_normal", dtype="float32", name=self.name+"_weights", trainable=True ) def call(self, inputs): # Using the deprecated quantize_and_dequantize here since quantize_and_dequantize_v2 is listed as unsupported-ops by TF-TRT q_i = tf.quantization.quantize_and_dequantize(inputs, 0, 1, name=self.name+"_q_i", narrow_range=True) q_w = tf.quantization.quantize_and_dequantize(self.w, -1, 1, name=self.name+"q_w",narrow_range=True) return tf.nn.conv2d(q_i, q_w, 2, "SAME") l = CustomConv2D(64, 3) t = tf.random.normal((1, 224, 224, 64), dtype="float32") model = tf.keras.Sequential() model.add(tf.keras.layers.InputLayer(input_shape=(224, 224, 64))) for i in range(5): model.add(CustomConv2D(64, 3, name=f'custom_conv2d_{i}')) model.save('./saved_model_qat/') **Code used for converting saved quantized TF model using TF-TRT** ```python from tensorflow.python.compiler.tensorrt import trt_convert as trt converter = trt.TrtGraphConverterV2( input_saved_model_dir='saved_model_qat', precision_mode=trt.TrtPrecisionMode.INT8, use_calibration=False ) trt_func = converter.convert() converter.summary() x_test = tf.ones((2, 224, 224, 64)) MAX_BATCH_SIZE=2 def input_fn(): batch_size = MAX_BATCH_SIZE x = x_test[0:batch_size, :] yield [x] converter.build(input_fn=input_fn) ``` ``` ### Relevant log output ```shell Logs generated 1. when using `quantize_and_dequantize_v2` instead of `quantize_and_dequantize` at the `trt_func = converter.convert()` step INFO:tensorflow:Clearing prior device assignments in loaded saved model INFO:tensorflow:Automatic mixed precision will be used on the whole TensorFlow Graph. This behavior can be deactivated using the environment variable: TF_TRT_EXPERIMENTAL_FEATURES=deactivate_mixed_precision. More information can be found on: https://www.tensorflow.org/guide/mixed_precision. 2023-02-16 12:12:02.652333: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:12:02.653263: I tensorflow/core/grappler/devices.cc:66] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 1 2023-02-16 12:12:02.653394: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session 2023-02-16 12:12:02.653696: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:12:02.654338: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:12:02.655044: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:12:02.655721: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:12:02.656447: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:12:02.657032: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1637] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 20554 MB memory: -> device: 0, name: NVIDIA A10, pci bus id: 0000:04:00.0, compute capability: 8.6 2023-02-16 12:12:02.668533: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:2359] Running auto_mixed_precision graph optimizer 2023-02-16 12:12:02.675439: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1195] Automatic Mixed Precision Grappler Pass Summary: Total processable nodes: 46 Recognized nodes available for conversion: 11 Total nodes converted: 6 Total FP16 Cast ops used (excluding Const and Variable casts): 10 Allowlisted nodes converted: 5 Denylisted nodes blocking conversion: 0 Nodes blocked from conversion by denylisted nodes: 0 For more information regarding mixed precision training, including how to make automatic mixed precision aware of a custom op type, please see the documentation available here: https://docs.nvidia.com/deeplearning/frameworks/tensorflow-user-guide/index.html#tfamp 2023-02-16 12:12:02.682088: W tensorflow/compiler/tf2tensorrt/segment/segment.cc:952] ################################################################################ TensorRT unsupported/non-converted OP Report: - QuantizeAndDequantizeV4 -> 10x - Conv2D -> 5x - NoOp -> 2x - Identity -> 1x - Placeholder -> 1x -------------------------------------------------------------------------------- - Total nonconverted OPs: 19 - Total nonconverted OP Types: 5 For more information see https://docs.nvidia.com/deeplearning/frameworks/tf-trt-user-guide/index.html#supported-ops. ################################################################################ 2023-02-16 12:12:02.682177: W tensorflow/compiler/tf2tensorrt/segment/segment.cc:1280] The environment variable TF_TRT_MAX_ALLOWED_ENGINES=20 has no effect since there are only 0 TRT Engines with at least minimum_segment_size=3 nodes. 2023-02-16 12:12:02.682195: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:799] Number of TensorRT candidate segments: 0 2. when using `quantize_and_dequantize` at the `trt_func = converter.convert()` step ```shell INFO:tensorflow:Clearing prior device assignments in loaded saved model INFO:tensorflow:Automatic mixed precision will be used on the whole TensorFlow Graph. This behavior can be deactivated using the environment variable: TF_TRT_EXPERIMENTAL_FEATURES=deactivate_mixed_precision. More information can be found on: https://www.tensorflow.org/guide/mixed_precision. 2023-02-16 12:14:27.966166: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:14:27.966825: I tensorflow/core/grappler/devices.cc:66] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 1 2023-02-16 12:14:27.966960: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session 2023-02-16 12:14:27.967241: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:14:27.967877: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:14:27.968493: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:14:27.969167: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:14:27.969781: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:996] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero 2023-02-16 12:14:27.970355: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1637] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 20554 MB memory: -> device: 0, name: NVIDIA A10, pci bus id: 0000:04:00.0, compute capability: 8.6 2023-02-16 12:14:27.981918: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:2359] Running auto_mixed_precision graph optimizer 2023-02-16 12:14:27.988304: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1195] Automatic Mixed Precision Grappler Pass Summary: Total processable nodes: 46 Recognized nodes available for conversion: 11 Total nodes converted: 6 Total FP16 Cast ops used (excluding Const and Variable casts): 10 Allowlisted nodes converted: 5 Denylisted nodes blocking conversion: 0 Nodes blocked from conversion by denylisted nodes: 0 For more information regarding mixed precision training, including how to make automatic mixed precision aware of a custom op type, please see the documentation available here: https://docs.nvidia.com/deeplearning/frameworks/tensorflow-user-guide/index.html#tfamp 2023-02-16 12:14:27.993404: I tensorflow/compiler/tf2tensorrt/convert/trt_optimization_pass.cc:206] [TF-TRT] Using explicit QDQ mode 2023-02-16 12:14:27.994965: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_1/custom_conv2d_1q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995142: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_2/custom_conv2d_2q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995296: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_3/custom_conv2d_3q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995449: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_4/custom_conv2d_4q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995603: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_5/custom_conv2d_5q1_w has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995626: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_1/custom_conv2d_1_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995681: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_2/custom_conv2d_2_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995710: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_3/custom_conv2d_3_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995737: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_4/custom_conv2d_4_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995764: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_5/custom_conv2d_5_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:14:27.995803: W tensorflow/compiler/tf2tensorrt/segment/segment.cc:952] ################################################################################ TensorRT unsupported/non-converted OP Report: - Conv2D -> 5x - NoOp -> 2x - Identity -> 1x - Placeholder -> 1x -------------------------------------------------------------------------------- - Total nonconverted OPs: 9 - Total nonconverted OP Types: 4 For more information see https://docs.nvidia.com/deeplearning/frameworks/tf-trt-user-guide/index.html#supported-ops. ################################################################################ 2023-02-16 12:14:27.995933: W tensorflow/compiler/tf2tensorrt/segment/segment.cc:1280] The environment variable TF_TRT_MAX_ALLOWED_ENGINES=20 has no effect since there are only 5 TRT Engines with at least minimum_segment_size=3 nodes. 2023-02-16 12:14:27.995954: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:799] Number of TensorRT candidate segments: 5 2023-02-16 12:14:27.997440: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 0 consisting of 3 nodes by TRTEngineOp_000_000. 2023-02-16 12:14:27.997478: W tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:919] TF-TRT Warning: Cannot replace segment 1 consisting of 16 nodes by TRTEngineOp_000_001 reason: Segment has no inputs (possible constfold failure) (keeping original segment). 2023-02-16 12:14:27.997532: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 2 consisting of 3 nodes by TRTEngineOp_000_002. 2023-02-16 12:14:27.997588: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 3 consisting of 3 nodes by TRTEngineOp_000_003. 2023-02-16 12:14:27.997641: I tensorflow/compiler/tf2tensorrt/convert/convert_graph.cc:916] Replaced segment 4 consisting of 3 nodes by TRTEngineOp_000_004. 2023-02-16 12:14:28.000505: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do 2023-02-16 12:14:28.002105: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do 2023-02-16 12:14:28.003662: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do 2023-02-16 12:14:28.005172: I tensorflow/core/grappler/optimizers/auto_mixed_precision.cc:1533] No allowlist ops found, nothing to do ``` As can be seen, the `Conv2D` nodes are strangely left unconverted by TF-TRT. 3. The next step `converter.build(input_fn=input_fn)` throws more errors ```shell 2023-02-16 12:16:44.399623: I tensorflow/stream_executor/cuda/cuda_dnn.cc:424] Loaded cuDNN version 8700 2023-02-16 12:16:44.493304: I tensorflow/compiler/tf2tensorrt/common/utils.cc:104] Linked TensorRT version: 8.5.1 2023-02-16 12:16:44.493380: I tensorflow/compiler/tf2tensorrt/common/utils.cc:106] Loaded TensorRT version: 8.5.1 2023-02-16 12:16:46.885047: W tensorflow/compiler/tf2tensorrt/utils/trt_logger.cc:83] TF-TRT Warning: DefaultLogger The NetworkDefinitionCreationFlag::kEXPLICIT_PRECISION flag has been deprecated and has no effect. Please do not use this flag when creating the network. 2023-02-16 12:16:46.886238: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_2/custom_conv2d_2_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:16:46.985131: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:1103] TF-TRT Warning: Engine creation for TRTEngineOp_000_000 failed. The native segment will be used instead. Reason: INTERNAL: tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:217 TRT_ENSURE_OK failure: INTERNAL: ./tensorflow/compiler/tf2tensorrt/convert/ops/layer_utils.h:610 TRT_ENSURE failure 2023-02-16 12:16:46.985391: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:936] TF-TRT Warning: Engine retrieval for input shapes: [[2,112,112,64]] failed. Running native segment for TRTEngineOp_000_000 2023-02-16 12:16:49.308912: W tensorflow/compiler/tf2tensorrt/utils/trt_logger.cc:83] TF-TRT Warning: DefaultLogger The NetworkDefinitionCreationFlag::kEXPLICIT_PRECISION flag has been deprecated and has no effect. Please do not use this flag when creating the network. 2023-02-16 12:16:49.310048: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_3/custom_conv2d_3_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:16:49.406425: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:1103] TF-TRT Warning: Engine creation for TRTEngineOp_000_002 failed. The native segment will be used instead. Reason: INTERNAL: tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:217 TRT_ENSURE_OK failure: INTERNAL: ./tensorflow/compiler/tf2tensorrt/convert/ops/layer_utils.h:610 TRT_ENSURE failure 2023-02-16 12:16:49.406586: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:936] TF-TRT Warning: Engine retrieval for input shapes: [[2,56,56,64]] failed. Running native segment for TRTEngineOp_000_002 2023-02-16 12:16:51.735398: W tensorflow/compiler/tf2tensorrt/utils/trt_logger.cc:83] TF-TRT Warning: DefaultLogger The NetworkDefinitionCreationFlag::kEXPLICIT_PRECISION flag has been deprecated and has no effect. Please do not use this flag when creating the network. 2023-02-16 12:16:51.736541: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_4/custom_conv2d_4_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:16:51.835118: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:1103] TF-TRT Warning: Engine creation for TRTEngineOp_000_003 failed. The native segment will be used instead. Reason: INTERNAL: tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:217 TRT_ENSURE_OK failure: INTERNAL: ./tensorflow/compiler/tf2tensorrt/convert/ops/layer_utils.h:610 TRT_ENSURE failure 2023-02-16 12:16:51.835262: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:936] TF-TRT Warning: Engine retrieval for input shapes: [[2,28,28,64]] failed. Running native segment for TRTEngineOp_000_003 2023-02-16 12:16:54.067165: W tensorflow/compiler/tf2tensorrt/utils/trt_logger.cc:83] TF-TRT Warning: DefaultLogger The NetworkDefinitionCreationFlag::kEXPLICIT_PRECISION flag has been deprecated and has no effect. Please do not use this flag when creating the network. 2023-02-16 12:16:54.068481: W tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:146] QuantizeAndDequantizeV2: StatefulPartitionedCall/sequential/custom_conv2d_5/custom_conv2d_5_q1_i has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended. 2023-02-16 12:16:54.175458: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:1103] TF-TRT Warning: Engine creation for TRTEngineOp_000_004 failed. The native segment will be used instead. Reason: INTERNAL: tensorflow/compiler/tf2tensorrt/convert/ops/quantization_ops.cc:217 TRT_ENSURE_OK failure: INTERNAL: ./tensorflow/compiler/tf2tensorrt/convert/ops/layer_utils.h:610 TRT_ENSURE failure 2023-02-16 12:16:54.175760: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:936] TF-TRT Warning: Engine retrieval for input shapes: [[2,14,14,64]] failed. Running native segment for TRTEngineOp_000_004 2023-02-16 12:16:54.201923: W tensorflow/compiler/tf2tensorrt/kernels/trt_engine_op.cc:936] TF-TRT Warning: Engine retrieval for input shapes: [[2,112,112,64]] failed. Running native segment for TRTEngineOp_000_000 ``` ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59711/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59711/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59710
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59710/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59710/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59710/events
https://github.com/tensorflow/tensorflow/issues/59710
1,586,978,241
I_kwDOArmXAs5el13B
59,710
TF Distributed looks for libcublasLt.so.10, when installed CUDA version is 11.6
{ "login": "SuperSecureHuman", "id": 88489071, "node_id": "MDQ6VXNlcjg4NDg5MDcx", "avatar_url": "https://avatars.githubusercontent.com/u/88489071?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SuperSecureHuman", "html_url": "https://github.com/SuperSecureHuman", "followers_url": "https://api.github.com/users/SuperSecureHuman/followers", "following_url": "https://api.github.com/users/SuperSecureHuman/following{/other_user}", "gists_url": "https://api.github.com/users/SuperSecureHuman/gists{/gist_id}", "starred_url": "https://api.github.com/users/SuperSecureHuman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SuperSecureHuman/subscriptions", "organizations_url": "https://api.github.com/users/SuperSecureHuman/orgs", "repos_url": "https://api.github.com/users/SuperSecureHuman/repos", "events_url": "https://api.github.com/users/SuperSecureHuman/events{/privacy}", "received_events_url": "https://api.github.com/users/SuperSecureHuman/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 996845227, "node_id": "MDU6TGFiZWw5OTY4NDUyMjc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:dist-strat", "name": "comp:dist-strat", "color": "0052cc", "default": false, "description": "Distribution Strategy related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @SuperSecureHuman \r\n\r\nAplogize for the delay and It seems like there is some problem with `cudatoolkit` and the `cudnn` version could be incompatible with your tensorflow version. If possible could you please help me with the output of these two commands `nvcc --version` and `nvidia-smi` and as per our [official documentation](https://www.tensorflow.org/install/source#gpu) with Tested build configurations for `tensorflow-2.11.0`,`CUDA==11.2` and `cuDNN==8.1` should work. Thank you!", "Hey!\r\n\r\nHere you go\r\n\r\nNvidia-smi\r\n\r\n![image](https://user-images.githubusercontent.com/88489071/219923465-f80a2f77-fcac-4fe1-9c02-e2e0c5189672.png)\r\n\r\n\r\nnvcc --version\r\n\r\n```\r\nnvcc --version\r\nnvcc: NVIDIA (R) Cuda compiler driver\r\nCopyright (c) 2005-2022 NVIDIA Corporation\r\nBuilt on Tue_Mar__8_18:18:20_PST_2022\r\nCuda compilation tools, release 11.6, V11.6.124\r\nBuild cuda_11.6.r11.6/compiler.31057947_0\r\n```\r\n\r\n\r\nCuda 11.2 still has the library version at 11, while TF looks for libcublas10.\r\n\r\n![image](https://user-images.githubusercontent.com/88489071/219923593-fbd7bc1f-9a7c-46b5-a290-090c4498a070.png)\r\n\r\n\r\nAnyway, loading 11.2/8.1 and running the same training script on two nodes.\r\n\r\n", "I have no idea what happened, but the training went fine. Even with cuda 11.6\r\n\r\nBecause of the queue in the HPC, I am unable to have an interactive session for longer time, through which I can look into this once again.\r\n\r\nI'll update once again here, after I try it again", "I am unable to reproduce the bug now. You may close the issue if needed. I'll reopen if I get it again.", "Hi, @SuperSecureHuman \r\n\r\nThank you for the confirmation and it seems like the issue got resolved if you're able to reproduce the bug again, so I would request you to please post new issue and we will look into that issue. Could you please confirm if this issue is resolved for you now ? Please feel free to close the issue if it is resolved ? Thank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "I was not able to reproduce the issue again, I'll create a new issue if I get it again.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59710\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59710\">No</a>\n" ]
2023-02-16T04:14:15
2023-03-04T04:15:02
2023-03-04T04:15:00
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.8, 2.11 ### Custom Code Yes ### OS Platform and Distribution RHEL 7.9 ### Mobile device _No response_ ### Python version 3.8 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.6/8.4 ### GPU model and memory _No response_ ### Current Behaviour? ```shell When using tf multi worker, the chief node looks for libcublasLt from CUDA 10.2, while the loaded CUDA version is 11.6. The expected behaviour is that TensorFlow should be using libcublasLt from the currently available CUDA version rather than 10.2 The worker node exits with a communication error - Connection reset by peer ``` ### Standalone code to reproduce the issue ```shell https://www.tensorflow.org/tutorials/distribute/multi_worker_with_keras#train_the_model ``` ### Relevant log output ```shell 2023-02-16 09:26:37.626920: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-02-16 09:26:38.332105: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1525] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 11641 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:3b:00.0, compute capability: 7.0 2023-02-16 09:26:38.334955: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1525] Created device /job:worker/replica:0/task:0/device:GPU:0 with 11641 MB memory: -> device: 0, name: Tesla V100-PCIE-16GB, pci bus id: 0000:3b:00.0, compute capability: 7.0 2023-02-16 09:26:38.341938: I tensorflow/core/distributed_runtime/rpc/grpc_channel.cc:272] Initialize GrpcChannelCache for job worker -> {0 -> 10.149.255.254:12345, 1 -> 10.149.0.4:23456} 2023-02-16 09:26:38.342153: I tensorflow/core/distributed_runtime/rpc/grpc_server_lib.cc:437] Started server with target: grpc://10.149.255.254:12345 2023-02-16 09:26:44.265969: W tensorflow/core/grappler/optimizers/data/auto_shard.cc:776] AUTO sharding policy will apply DATA sharding policy as it failed to apply FILE sharding policy because of the following reason: Found an unshardable source dataset: name: "TensorSliceDataset/_2" op: "TensorSliceDataset" input: "Placeholder/_0" input: "Placeholder/_1" attr { key: "Toutput_types" value { list { type: DT_FLOAT type: DT_INT64 } } } attr { key: "_cardinality" value { i: 60000 } } attr { key: "is_files" value { b: false } } attr { key: "metadata" value { s: "\n\024TensorSliceDataset:0" } } attr { key: "output_shapes" value { list { shape { dim { size: 28 } dim { size: 28 } } shape { } } } } experimental_type { type_id: TFT_PRODUCT args { type_id: TFT_DATASET args { type_id: TFT_PRODUCT args { type_id: TFT_TENSOR args { type_id: TFT_FLOAT } } args { type_id: TFT_TENSOR args { type_id: TFT_INT64 } } } } args { type_id: TFT_DATASET args { type_id: TFT_PRODUCT args { type_id: TFT_TENSOR args { type_id: TFT_FLOAT } } args { type_id: TFT_TENSOR args { type_id: TFT_INT64 } } } } } Epoch 1/3 Could not load library libcublasLt.so.10. Error: libcublasLt.so.10: cannot open shared object file: No such file or directory ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59710/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59710/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59709
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59709/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59709/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59709/events
https://github.com/tensorflow/tensorflow/issues/59709
1,586,970,354
I_kwDOArmXAs5elz7y
59,709
Node: 'sequential/embedding/embedding_lookup' indices[0,57] = 1544453 is not in [0, 1498136) [[{{node sequential/embedding/embedding_lookup}}]] [Op:__inference_train_function_8141]
{ "login": "priyansh4320", "id": 69320370, "node_id": "MDQ6VXNlcjY5MzIwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/69320370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/priyansh4320", "html_url": "https://github.com/priyansh4320", "followers_url": "https://api.github.com/users/priyansh4320/followers", "following_url": "https://api.github.com/users/priyansh4320/following{/other_user}", "gists_url": "https://api.github.com/users/priyansh4320/gists{/gist_id}", "starred_url": "https://api.github.com/users/priyansh4320/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/priyansh4320/subscriptions", "organizations_url": "https://api.github.com/users/priyansh4320/orgs", "repos_url": "https://api.github.com/users/priyansh4320/repos", "events_url": "https://api.github.com/users/priyansh4320/events{/privacy}", "received_events_url": "https://api.github.com/users/priyansh4320/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@priyansh4320 \r\n I tried to reproduce the issue on colab using TF v2.11 but facing different error could you please provide all dependencies and find the gist [here](https://colab.research.google.com/gist/tiruk007/b861319a02bcbea01a7a2a80154f906b/untitled134.ipynb) for reference.\r\n\r\nThank you !", "@tiruk007 i assume that you have also uploaded the dataset via the link https://drive.google.com/file/d/1pKAJ-PF42nRB2kw0ZdMAkg1i2fUSvF-y/view?usp=sharing to your google drive.\r\n\r\n1. my file path to the dataset is this : /content/drive/MyDrive/ATS- gigadata/model_gigadata_new.csv \r\n2. here I have create another folder \"ATS-gigadata\" where my file is located\r\n3. you can use this path for yourself: /content/drive/MyDrive/model_gigadata_new.csv\r\n4. since uploading a file to google drive will appear in \"MyDrive\" by default\r\n5. regarding dependencies , all dependencies are provided in file itself ", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "@priyansh4320 \r\nSorry for the late reply, Could you please provide an accessible dataset to replicate the issue reported here ?\r\n\r\nThank you!\r\n", "@tiruk007 \r\ndataset link : https://drive.google.com/file/d/1pKAJ-PF42nRB2kw0ZdMAkg1i2fUSvF-y/view?usp=sharing", "@SuryanarayanaY \r\nI was able to reproduce the issue on Colab using 2.11. please find the gist [here](https://colab.research.google.com/gist/tiruk007/98ddf5d0ede5ad6f6ad06168ed1e09f5/untitled148.ipynb) for reference.\r\n\r\nThank you !", "@tiruk007 ok, now can you please provide me solution to resolve this error . i am not able to move forward in my project.\r\n", "Hi, Apologies for the delayed response, I tried to check the issue. Model definition looks fine, the only thing you want to try is data preprocessing part like take a relook into the tokenizer part.\r\nAlso, I did not get the use of below logic.\r\n```\r\n#increasing length of word index to change the shape\r\ni=1\r\nwhile i<=10:\r\n word_index['person organization gpe ',i] = 1000+i\r\n i+=1\r\n```\r\n\r\n", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59709\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59709\">No</a>\n" ]
2023-02-16T04:05:22
2023-04-06T01:53:41
2023-04-06T01:53:39
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tensorflow.compat.v2.version ### Custom Code Yes ### OS Platform and Distribution google colab ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell InvalidArgumentError: Graph execution error: Detected at node 'sequential/embedding/embedding_lookup' defined at (most recent call last): File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/usr/local/lib/python3.8/dist-packages/ipykernel_launcher.py", line 16, in <module> app.launch_new_instance() File "/usr/local/lib/python3.8/dist-packages/traitlets/config/application.py", line 992, in launch_instance app.start() File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelapp.py", line 612, in start self.io_loop.start() File "/usr/local/lib/python3.8/dist-packages/tornado/platform/asyncio.py", line 149, in start self.asyncio_loop.run_forever() File "/usr/lib/python3.8/asyncio/base_events.py", line 570, in run_forever self._run_once() File "/usr/lib/python3.8/asyncio/base_events.py", line 1859, in _run_once handle._run() File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run self._context.run(self._callback, *self._args) File "/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py", line 690, in <lambda> lambda f: self._run_callback(functools.partial(callback, future)) File "/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py", line 743, in _run_callback ret = callback() File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 787, in inner self.run() File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 748, in run yielded = self.gen.send(value) File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 365, in process_one yield gen.maybe_future(dispatch(*args)) File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper yielded = next(result) File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 268, in dispatch_shell yield gen.maybe_future(handler(stream, idents, msg)) File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper yielded = next(result) File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 543, in execute_request self.do_execute( File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper yielded = next(result) File "/usr/local/lib/python3.8/dist-packages/ipykernel/ipkernel.py", line 306, in do_execute res = shell.run_cell(code, store_history=store_history, silent=silent) File "/usr/local/lib/python3.8/dist-packages/ipykernel/zmqshell.py", line 536, in run_cell return super(ZMQInteractiveShell, self).run_cell(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 2854, in run_cell result = self._run_cell( File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 2881, in _run_cell return runner(coro) File "/usr/local/lib/python3.8/dist-packages/IPython/core/async_helpers.py", line 68, in _pseudo_sync_runner coro.send(None) File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3057, in run_cell_async has_raised = await self.run_ast_nodes(code_ast.body, cell_name, File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3249, in run_ast_nodes if (await self.run_code(code, result, async_=asy)): File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3326, in run_code exec(code_obj, self.user_global_ns, self.user_ns) File "<ipython-input-32-2dfe1a9e3af4>", line 1, in <module> model.fit(padded_sequences_x, padded_sequences_y, batch_size=64, epochs=15) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1650, in fit tmp_logs = self.train_function(iterator) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1249, in train_function return step_function(self, iterator) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1233, in step_function outputs = model.distribute_strategy.run(run_step, args=(data,)) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1222, in run_step outputs = model.train_step(data) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1023, in train_step y_pred = self(x, training=True) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 561, in __call__ return super().__call__(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/engine/base_layer.py", line 1132, in __call__ outputs = call_fn(inputs, *args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 96, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/engine/sequential.py", line 413, in call return super().call(inputs, training=training, mask=mask) File "/usr/local/lib/python3.8/dist-packages/keras/engine/functional.py", line 511, in call return self._run_internal_graph(inputs, training=training, mask=mask) File "/usr/local/lib/python3.8/dist-packages/keras/engine/functional.py", line 668, in _run_internal_graph outputs = node.layer(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/engine/base_layer.py", line 1132, in __call__ outputs = call_fn(inputs, *args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 96, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/layers/core/embedding.py", line 208, in call out = tf.nn.embedding_lookup(self.embeddings, inputs) Node: 'sequential/embedding/embedding_lookup' indices[0,57] = 1544453 is not in [0, 1498136) [[{{node sequential/embedding/embedding_lookup}}]] [Op:__inference_train_function_8141] ``` ### Standalone code to reproduce the issue ```shell link to code and dataset: colab file: https://colab.research.google.com/drive/13JZX5HQQGJrf6t9CcCA0kM3JHegBtnTz?usp=sharing dataset: https://drive.google.com/file/d/1pKAJ-PF42nRB2kw0ZdMAkg1i2fUSvF-y/view?usp=sharing i expect the code to fit in the model: model: # Define model model = Sequential() model.add(Embedding(len(word_index)+1 , embedding_weights.shape[1], weights=[embedding_weights], input_length=padded_sequences_x.shape[1], trainable=False)) model.add(Bidirectional(LSTM(32, return_sequences=True))) model.add(attention(return_sequences=False)) # receive 3D and output 3D model.add(RepeatVector(len(padded_sequences_y[1]))) # repeat vector model.add(LSTM(32, return_sequences=True)) #decoder layer model.add(Dropout(0.2)) model.add(TimeDistributed(Dense(1, activation='softmax'))) #model.add(Dense(1, activation='softmax')) summery: Model: "sequential" _________________________________________________________________ Layer (type) Output Shape Param # ================================================================= embedding (Embedding) (None, 79, 100) 149813600 bidirectional (Bidirectiona (None, 79, 64) 34048 l) attention (attention) (None, 64) 143 repeat_vector (RepeatVector (None, 38, 64) 0 ) lstm_1 (LSTM) (None, 38, 32) 12416 dropout (Dropout) (None, 38, 32) 0 time_distributed (TimeDistr (None, 38, 1) 33 ibuted) ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59709/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59709/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59708
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59708/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59708/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59708/events
https://github.com/tensorflow/tensorflow/pull/59708
1,586,793,207
PR_kwDOArmXAs5KFWPH
59,708
Add checking on the quantized limits for tosa.clamp
{ "login": "Jerry-Ge", "id": 24451859, "node_id": "MDQ6VXNlcjI0NDUxODU5", "avatar_url": "https://avatars.githubusercontent.com/u/24451859?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Jerry-Ge", "html_url": "https://github.com/Jerry-Ge", "followers_url": "https://api.github.com/users/Jerry-Ge/followers", "following_url": "https://api.github.com/users/Jerry-Ge/following{/other_user}", "gists_url": "https://api.github.com/users/Jerry-Ge/gists{/gist_id}", "starred_url": "https://api.github.com/users/Jerry-Ge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Jerry-Ge/subscriptions", "organizations_url": "https://api.github.com/users/Jerry-Ge/orgs", "repos_url": "https://api.github.com/users/Jerry-Ge/repos", "events_url": "https://api.github.com/users/Jerry-Ge/events{/privacy}", "received_events_url": "https://api.github.com/users/Jerry-Ge/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "cc @eric-k256 @rsuderman ", "There is actually no implementation of the `dtype.isUnsigned()` [Reference](https://mlir.llvm.org/doxygen/classmlir_1_1quant_1_1QuantizedType.html) . Simply using getStorageTypeMin/Max for much cleaner implementation.\r\n\r\nJerry " ]
2023-02-16T00:18:06
2023-02-24T23:24:47
2023-02-24T23:24:47
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59708", "html_url": "https://github.com/tensorflow/tensorflow/pull/59708", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59708.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59708.patch", "merged_at": "2023-02-24T23:24:47" }
The original request: https://github.com/tensorflow/tensorflow/pull/58288#discussion_r1013360726 This is the 1st patch for review. I will cleanup everything else after the 1st round of review. Jerry
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59708/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59708/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59707
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59707/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59707/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59707/events
https://github.com/tensorflow/tensorflow/issues/59707
1,586,681,794
I_kwDOArmXAs5ektfC
59,707
tflite_runtime wheel file import error in beaglebone black wireless
{ "login": "ZIFENG278", "id": 93161044, "node_id": "U_kgDOBY2GVA", "avatar_url": "https://avatars.githubusercontent.com/u/93161044?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ZIFENG278", "html_url": "https://github.com/ZIFENG278", "followers_url": "https://api.github.com/users/ZIFENG278/followers", "following_url": "https://api.github.com/users/ZIFENG278/following{/other_user}", "gists_url": "https://api.github.com/users/ZIFENG278/gists{/gist_id}", "starred_url": "https://api.github.com/users/ZIFENG278/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZIFENG278/subscriptions", "organizations_url": "https://api.github.com/users/ZIFENG278/orgs", "repos_url": "https://api.github.com/users/ZIFENG278/repos", "events_url": "https://api.github.com/users/ZIFENG278/events{/privacy}", "received_events_url": "https://api.github.com/users/ZIFENG278/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1205615612, "node_id": "MDU6TGFiZWwxMjA1NjE1NjEy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:%20ubuntu/linux", "name": "subtype: ubuntu/linux", "color": "b619ea", "default": false, "description": "Ubuntu/Linux Build/Installation Issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "terryheo", "id": 2908505, "node_id": "MDQ6VXNlcjI5MDg1MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/2908505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terryheo", "html_url": "https://github.com/terryheo", "followers_url": "https://api.github.com/users/terryheo/followers", "following_url": "https://api.github.com/users/terryheo/following{/other_user}", "gists_url": "https://api.github.com/users/terryheo/gists{/gist_id}", "starred_url": "https://api.github.com/users/terryheo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terryheo/subscriptions", "organizations_url": "https://api.github.com/users/terryheo/orgs", "repos_url": "https://api.github.com/users/terryheo/repos", "events_url": "https://api.github.com/users/terryheo/events{/privacy}", "received_events_url": "https://api.github.com/users/terryheo/received_events", "type": "User", "site_admin": false }
[ { "login": "terryheo", "id": 2908505, "node_id": "MDQ6VXNlcjI5MDg1MDU=", "avatar_url": "https://avatars.githubusercontent.com/u/2908505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/terryheo", "html_url": "https://github.com/terryheo", "followers_url": "https://api.github.com/users/terryheo/followers", "following_url": "https://api.github.com/users/terryheo/following{/other_user}", "gists_url": "https://api.github.com/users/terryheo/gists{/gist_id}", "starred_url": "https://api.github.com/users/terryheo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/terryheo/subscriptions", "organizations_url": "https://api.github.com/users/terryheo/orgs", "repos_url": "https://api.github.com/users/terryheo/repos", "events_url": "https://api.github.com/users/terryheo/events{/privacy}", "received_events_url": "https://api.github.com/users/terryheo/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@ZIFENG278 try this below \r\nIt looks like there might be an issue with the TensorFlow Lite build for your BeagleBone Black Wireless. The error message you're getting suggests that there is an unresolved symbol when loading the shared library.\r\n\r\nHere are some suggestions to resolve this issue:\r\n\r\nEnsure that you have built the TensorFlow Lite wheel file correctly for your platform by following the instructions in the [guide](https://www.tensorflow.org/lite/guide/build_cmake_pip).\r\n\r\nDouble-check the compilation flags you used when building the wheel file, as you mentioned that you changed the -mfpu=neon-vpfv4 flag to -mfpu=neon. Ensure that this change is compatible with your platform's architecture and requirements.\r\n\r\nTry rebuilding the wheel file and reinstalling it on your BeagleBone Black Wireless. Make sure to remove any previous installations of tflite_runtime before reinstalling. \r\n\r\nIf the issue persists, consider posting a detailed description of your build process, the flags you used, and the platform information on the [TensorFlow GitHub issues](https://github.com/tensorflow/tensorflow/issues) page. The TensorFlow team or the community members might be able to help you with your specific issue.\r\n\r\nGood luck, and I hope you manage to resolve the issue!", "@Adesoji1 Thanks for your answer,\r\n\r\nThe problem I found was that I built the wheel in a conda=py3.7 environment, which could have been problematic, the guide mentions it uses docker to build it so I ignored that\r\n\r\nThis time I built the wheel in my bash environment after a git pull and it installed successfully in my beaglebone black wireless.\r\n\r\nThanks for help.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59707\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59707\">No</a>\n" ]
2023-02-15T22:40:35
2023-04-02T17:16:20
2023-04-02T17:16:17
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version tf ### Custom Code No ### OS Platform and Distribution Debian GNU/Linux 10 (buster) ### Mobile device _No response_ ### Python version 3.7.3 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell i want to install tflite_runtime on beaglebone black wireless, and i build the wheel file follow the https://www.tensorflow.org/lite/guide/build_cmake_pip and i change the -mfpu=neon-vpfv4 to -mfpu=neon becauuse the beaglebone black wireless is not support the vpfv4, after build the wheel file and install in beaglebone black, in python3 code: "from tflite_runtime.interpreter import Interpreter", it output Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/debian/.local/lib/python3.7/site-packages/tflite_runtime/interpreter.py", line 33, in <module> from tflite_runtime import _pywrap_tensorflow_interpreter_wrapper as _interpreter_wrapper ImportError: /home/debian/.local/lib/python3.7/site-packages/tflite_runtime/_pywrap_tensorflow_interpreter_wrapper.so: undefined symbol: _ZN6tflite9telemetry20TelemetryReportEventEP13TfLiteContextPKc12TfLiteStatus >>> ``` ### Standalone code to reproduce the issue ```shell from tflite_runtime.interpreter import Interpreter ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59707/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59707/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59706
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59706/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59706/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59706/events
https://github.com/tensorflow/tensorflow/pull/59706
1,586,668,185
PR_kwDOArmXAs5KE7a8
59,706
[TF-TRT] reviewers test PR
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-15T22:28:51
2023-02-15T22:53:57
2023-02-15T22:29:00
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59706", "html_url": "https://github.com/tensorflow/tensorflow/pull/59706", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59706.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59706.patch", "merged_at": null }
[TF-TRT] reviewers test base on title. DO NOT MERGE(Test change only)
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59706/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59706/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59705
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59705/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59705/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59705/events
https://github.com/tensorflow/tensorflow/issues/59705
1,586,586,575
I_kwDOArmXAs5ekWPP
59,705
tf.experimental.numpy.power behaves differently when inputs are large numbers
{ "login": "trickiwoo", "id": 121965696, "node_id": "U_kgDOB0UMgA", "avatar_url": "https://avatars.githubusercontent.com/u/121965696?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trickiwoo", "html_url": "https://github.com/trickiwoo", "followers_url": "https://api.github.com/users/trickiwoo/followers", "following_url": "https://api.github.com/users/trickiwoo/following{/other_user}", "gists_url": "https://api.github.com/users/trickiwoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/trickiwoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trickiwoo/subscriptions", "organizations_url": "https://api.github.com/users/trickiwoo/orgs", "repos_url": "https://api.github.com/users/trickiwoo/repos", "events_url": "https://api.github.com/users/trickiwoo/events{/privacy}", "received_events_url": "https://api.github.com/users/trickiwoo/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "The CPU behavior matches NumPy. The result overflows the underlying data type in NumPy.\r\n```\r\n>>> import numpy as np\r\n>>> np.power(2, 62)\r\n4611686018427387904\r\n>>> np.power(2, 63)\r\n-9223372036854775808\r\n>>> np.power(2, 64)\r\n0\r\n>>> np.power(2, 128)\r\n0\r\n```\r\n\r\nOn GPU, the result is wrapping for some reason:\r\n```\r\nwith tf.device(\"gpu\"):\r\n print(tf.experimental.numpy.power(2, 63))\r\n print(tf.experimental.numpy.power(2, 64))\r\n print(tf.experimental.numpy.power(2, 65))\r\n print(tf.experimental.numpy.power(2, 66))\r\n print(tf.experimental.numpy.power(2, 67))\r\n...\r\n\r\ntf.Tensor(-9223372036854775808, shape=(), dtype=int64)\r\ntf.Tensor(1, shape=(), dtype=int64)\r\ntf.Tensor(2, shape=(), dtype=int64)\r\ntf.Tensor(4, shape=(), dtype=int64)\r\ntf.Tensor(8, shape=(), dtype=int64)\r\n```\r\n\r\nI haven't gotten too deep into the implementation (I'm new), but CPU and GPU seem to follow the same path all the way through `gen_math_ops.py._pow()`'s call to `pywrap_tfe.TFE_Py_FastPathExecute()`. I don't have the time to figure out what happens in `TFE_Py_FastPathExecute_C()` and maybe `GetOp()` are doing based on the device.", "@trickiwoo Thanks for reporting this issue.\r\n\r\nI was able to reproduce this behaviour on TF 2.11 and TF Nightly 2.13.0-dev20230215. \r\n\r\nHowever, `tf.math.pow` has not shown any such behaviour on GPU. Please find the [gist](https://colab.research.google.com/gist/pjpratik/cc9e46c992bcc4631133f57064f9e7db/59705.ipynb) here.\r\n\r\n@tilakrayal Could you please look into this. Thanks!", "Right, `tf.experimental.numpy.pow()` converts its scalar arguments to `tf.Tensor` before passing to `gen_math_ops._pow()`.\r\n\r\n`tf.math.pow()` passes them as scalars. That seems to make a difference in the GPU case, but apparently not in the CPU case.", "Tried with Apple M1 GPU and it is giving the expected result.\r\nSeems to be issue only when NVIDIA GPU is used. It needs more investigation.\r\n```\r\nwith tf.device(\"gpu\"):\r\n x_t = tf.experimental.numpy.power(2, 64)\r\n print(x_t)\r\n```\r\n`tf.Tensor(0, shape=(), dtype=int64)`", "This results is a signed int overflow, which is undefined behavior. Different compilers can choose to do different things, so your program output is unpredictable, which is what you're seeing here.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59705\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59705\">No</a>\n" ]
2023-02-15T21:24:56
2023-05-04T23:08:24
2023-05-04T23:08:21
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.13.0.dev20230204 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 20.04.4 LTS ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell tf.experimental.numpy.power behaves differently when inputs are large numbers ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("cpu"): x_t = tf.experimental.numpy.power(2, 64) print(x_t) with tf.device("gpu"): x_t = tf.experimental.numpy.power(2, 64) print(x_t) ``` ### Relevant log output ```shell tf.Tensor(0, shape=(), dtype=int64) tf.Tensor(1, shape=(), dtype=int64) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59705/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59705/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59704
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59704/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59704/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59704/events
https://github.com/tensorflow/tensorflow/issues/59704
1,586,581,936
I_kwDOArmXAs5ekVGw
59,704
tf.image.convert_image_dtype behaves differently between CPU and GPU when inputs are negative numbers
{ "login": "trickiwoo", "id": 121965696, "node_id": "U_kgDOB0UMgA", "avatar_url": "https://avatars.githubusercontent.com/u/121965696?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trickiwoo", "html_url": "https://github.com/trickiwoo", "followers_url": "https://api.github.com/users/trickiwoo/followers", "following_url": "https://api.github.com/users/trickiwoo/following{/other_user}", "gists_url": "https://api.github.com/users/trickiwoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/trickiwoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trickiwoo/subscriptions", "organizations_url": "https://api.github.com/users/trickiwoo/orgs", "repos_url": "https://api.github.com/users/trickiwoo/repos", "events_url": "https://api.github.com/users/trickiwoo/events{/privacy}", "received_events_url": "https://api.github.com/users/trickiwoo/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @trickiwoo \r\n\r\nAplogize for the delay and I was able to replicate the issue and it's returning different values for the same code on `CPU` and `GPU`, for your reference I have added [gist-file-tf2.11](https://colab.research.google.com/gist/gaikwadrahul8/097cea61a28081a64601a762e40903bb/-59704.ipynb), [gist-file-tf2.12.0rc0 ](https://colab.research.google.com/gist/gaikwadrahul8/d1a846e1a60c10eb1b4f806014427aa4/-59704-tensorflow-2-12-0rc0.ipynb) and [gist-file-tf-nightly-2.13.0.dev20230216](https://colab.research.google.com/gist/gaikwadrahul8/453761c41c9b0dd0bf84a207e3ed2035/-59704.ipynb) so we will have to dig more into this issue and we'll update you soon here, Thank you for noticing this issue. Thank you!", "Would this be undefined by the specification anyway? The [tf.image.convert_image_dtype](https://www.tensorflow.org/api_docs/python/tf/image/convert_image_dtype) documentation says floating-point values are expected to be in the range `[0, 1)`. If so, then I'd expect inconsistent behavior and perhaps a warning message for out-of-range values.", "Thanks for getting back to me! @gaikwadrahul8 @nrwahl2 \r\nYes, the input values are expected to be in the range [0, 1), but it seems that the CPU converts negative numbers to 180, and it doesn't make sense. It would be great if it throws exceptions or outputs 0 as the GPU does. ", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Hi, @trickiwoo \r\n\r\nApologize for the delay and I tried to execute the same code on CPU by passing `saturate=True` argument to `tf.image.convert_image_dtype()` and it's giving the same result as GPU and for your reference I have added gist file [here](https://colab.research.google.com/gist/SuryanarayanaY/5e193ed69f1cad5de8b0561dc05046d7/untitled55.ipynb) and by default value is `saturate=False` and you can refer [official documentation ](https://www.tensorflow.org/api_docs/python/tf/image/convert_image_dtype)\r\n\r\nCould you please try from your end by passing `saturate=True` argument to `tf.image.convert_image_dtype()` and check whether is it giving the same result as GPU ? Thank you!", "Thanks for the detailed explanation. Yes, passing the `saturate=True` argument would be the proper usage.", "@trickiwoo \r\n\r\nThank you for the confirmation and If you need any further assistance please let us know ? or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59704\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59704\">No</a>\n" ]
2023-02-15T21:20:51
2023-03-06T21:34:24
2023-03-06T21:34:22
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.13.0.dev20230204 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 20.04.4 LTS ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell tf.image.convert_image_dtype behaves differently between CPU and GPU when inputs are negative numbers. CPU produces weird outputs but doesn't raise warnings or exceptions. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf with tf.device("gpu"): x = tf.ones((10,10), dtype=tf.float32)*(-0.3) y = tf.image.convert_image_dtype(x, dtype=tf.uint8) print(y) with tf.device("cpu"): x = tf.ones((10,10), dtype=tf.float32)*(-0.3) y = tf.image.convert_image_dtype(x, dtype=tf.uint8) print(y) ``` ### Relevant log output ```shell tf.Tensor( [[0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0]], shape=(10, 10), dtype=uint8) tf.Tensor( [[180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180] [180 180 180 180 180 180 180 180 180 180]], shape=(10, 10), dtype=uint8) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59704/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59704/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59703
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59703/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59703/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59703/events
https://github.com/tensorflow/tensorflow/pull/59703
1,586,566,150
PR_kwDOArmXAs5KEl98
59,703
Fix GRUCellBlockOp message for invalid rank of x
{ "login": "nrwahl2", "id": 30487349, "node_id": "MDQ6VXNlcjMwNDg3MzQ5", "avatar_url": "https://avatars.githubusercontent.com/u/30487349?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nrwahl2", "html_url": "https://github.com/nrwahl2", "followers_url": "https://api.github.com/users/nrwahl2/followers", "following_url": "https://api.github.com/users/nrwahl2/following{/other_user}", "gists_url": "https://api.github.com/users/nrwahl2/gists{/gist_id}", "starred_url": "https://api.github.com/users/nrwahl2/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nrwahl2/subscriptions", "organizations_url": "https://api.github.com/users/nrwahl2/orgs", "repos_url": "https://api.github.com/users/nrwahl2/repos", "events_url": "https://api.github.com/users/nrwahl2/events{/privacy}", "received_events_url": "https://api.github.com/users/nrwahl2/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" }, { "id": 1178505529, "node_id": "MDU6TGFiZWwxMTc4NTA1NTI5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/prtype:bugfix", "name": "prtype:bugfix", "color": "159b2e", "default": false, "description": "PR to fix a bug" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "> LGTM, just reordering the imports back as this would break Copybara otherwise\r\n\r\nNo problem. Why's that?", "Internally the imports get rewritten based on where the code is situated in the Google monorepo and the type of the code (OSS -> third_party). Plus, code linters want the imports sorted." ]
2023-02-15T21:08:35
2023-03-06T22:03:48
2023-02-16T19:25:16
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59703", "html_url": "https://github.com/tensorflow/tensorflow/pull/59703", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59703.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59703.patch", "merged_at": "2023-02-16T19:25:16" }
The validation checks that `x` is a matrix, so rank must be 2. ff45913 fixed the crash in https://github.com/tensorflow/tensorflow/issues/58261 but left this typo in an exception message. Fixes https://github.com/tensorflow/tensorflow/issues/58261 @mihaimaruseac
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59703/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59703/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59702
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59702/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59702/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59702/events
https://github.com/tensorflow/tensorflow/issues/59702
1,586,552,791
I_kwDOArmXAs5ekN_X
59,702
tf.cast behaves differently in CPU and GPU when casting negative values
{ "login": "trickiwoo", "id": 121965696, "node_id": "U_kgDOB0UMgA", "avatar_url": "https://avatars.githubusercontent.com/u/121965696?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trickiwoo", "html_url": "https://github.com/trickiwoo", "followers_url": "https://api.github.com/users/trickiwoo/followers", "following_url": "https://api.github.com/users/trickiwoo/following{/other_user}", "gists_url": "https://api.github.com/users/trickiwoo/gists{/gist_id}", "starred_url": "https://api.github.com/users/trickiwoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trickiwoo/subscriptions", "organizations_url": "https://api.github.com/users/trickiwoo/orgs", "repos_url": "https://api.github.com/users/trickiwoo/repos", "events_url": "https://api.github.com/users/trickiwoo/events{/privacy}", "received_events_url": "https://api.github.com/users/trickiwoo/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
open
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "The result of casting a negative float to an int is undefined according to the C++ standard:\r\n> A prvalue of a floating-point type can be converted to a prvalue of an\r\ninteger type. The conversion truncates; that is, the fractional part is\r\ndiscarded.\r\n> The behavior is undefined if the truncated value cannot be represented\r\nin the destination type.\r\n\r\nhttps://github.com/cplusplus/draft/blob/5ef31f3fc1531d9e6e923cb57bf6e5ecec59ed4e/source/expressions.tex#L949-L958\r\n\r\nIt's mentioned in more readable language here (unofficial):\r\n* https://cplusplus.com/doc/tutorial/typecasting/\r\n* https://embeddeduse.com/2013/08/25/casting-a-negative-float-to-an-unsigned-int/\r\n\r\nPerhaps TF could either print a warning message or work around it by either:\r\n* taking absolute value of the floating-point value first, or\r\n* casting to a signed int type first", "@tilakrayal \r\n \r\nI was able to reproduce the issue on Colab using TF v2.11 and tf-nightly. Please find the gist of [2.11](https://colab.research.google.com/gist/tiruk007/fb8c930fed1e0f533966180067793815/2_11.ipynb) and [tf-nightly](https://colab.research.google.com/gist/tiruk007/538982863653d5f46152ee2f853ef874/untitled134.ipynb) for reference.\r\n\r\nThank you !", "Hi, @trickiwoo \r\n\r\nApologize for the delay and @nrwahl2, Thank you for the detailed explanation and suggested workaround, I really appreciate your efforts and time, I was able to replicate the same issue with `tensorflow 2.12.0rc0` and I have added [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/6f28a09e97fd4597c26ad01d4a7cc54a/-59702.ipynb) for your reference. \r\n\r\nIt is undefined behaviour in `C99` if the floating point number is` less than or equal to -1.0`. If it's in the range `(-1.0, 0.0),` the resulting value will be 0.\r\n\r\n**From C99, §6.3.1.4, paragraph 1**\r\n\r\n`When a finite value of real floating type is converted to an integer type other than _Bool, the fractional part is discarded (i.e., the value is truncated toward zero). If the value of the integral part cannot be represented by the integer type, the behavior is undefined`\r\n\r\nWe'll have to dig more into this issue and we'll update you soon. Thank you! ", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Hi, @sachinprasadhs \r\n\r\nCould you please look into this issue ? Thank you!" ]
2023-02-15T20:59:06
2023-03-22T22:35:04
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.13.0.dev20230204 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 20.04.4 LTS ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell tf.cast behaves differently in CPU and GPU when casting negative values ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf import numpy as np with tf.device('cpu'): data = np.array([[-1.0]]).astype(np.float64) x = tf.dtypes.cast(data, tf.uint8) print(x) with tf.device('gpu'): data = np.array([[-1.0]]).astype(np.float64) x = tf.dtypes.cast(data, tf.uint8) print(x) ``` ### Relevant log output ```shell tf.Tensor([[255]], shape=(1, 1), dtype=uint8) tf.Tensor([[0]], shape=(1, 1), dtype=uint8) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59702/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59702/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59701
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59701/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59701/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59701/events
https://github.com/tensorflow/tensorflow/issues/59701
1,586,499,665
I_kwDOArmXAs5ekBBR
59,701
Video CNN Tutorial
{ "login": "chewman19", "id": 44807421, "node_id": "MDQ6VXNlcjQ0ODA3NDIx", "avatar_url": "https://avatars.githubusercontent.com/u/44807421?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chewman19", "html_url": "https://github.com/chewman19", "followers_url": "https://api.github.com/users/chewman19/followers", "following_url": "https://api.github.com/users/chewman19/following{/other_user}", "gists_url": "https://api.github.com/users/chewman19/gists{/gist_id}", "starred_url": "https://api.github.com/users/chewman19/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chewman19/subscriptions", "organizations_url": "https://api.github.com/users/chewman19/orgs", "repos_url": "https://api.github.com/users/chewman19/repos", "events_url": "https://api.github.com/users/chewman19/events{/privacy}", "received_events_url": "https://api.github.com/users/chewman19/received_events", "type": "User", "site_admin": false }
[ { "id": 284443156, "node_id": "MDU6TGFiZWwyODQ0NDMxNTY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:docs-bug", "name": "type:docs-bug", "color": "159b2e", "default": false, "description": "Document issues" }, { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "@chewman19 I was able to execute the code from [Load video data](https://www.tensorflow.org/tutorials/load_data/video) tutorial succesfully using TF v 2.11. Kindly refer to the gist [here](https://colab.sandbox.google.com/gist/synandi/a9e43199c8c958f5f3178ce7d4e0ff14/59701.ipynb). For better assistance please share the colab gist in which you are executing the code from Load video data tutorial. Thank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "\r\nClosing as stale. Please reopen if you'd like to work on this further.\r\n\r\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59701\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59701\">No</a>\n" ]
2023-02-15T20:21:11
2023-03-23T16:44:05
2023-03-23T16:44:02
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf 2.11.0 ### Custom Code No ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version 3.9 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell I do not know if this belongs here. I was trying to work through your "Video classification with a 3D convolutional neural network" tutorial. Going through the "Load Video Data" portion. I keep coming across an error that I cannot resolve. " line 102, in convert_to_eager_tensor return ops.EagerTensor(value, ctx.device_name, dtype) ValueError: Attempt to convert a value (None) with an unsupported type (<class 'NoneType'>) to a Tensor. " this is the code step: ucf_sample_video = frames_from_video_file(next(subset_paths['train'].glob('*/*.avi')), 50) The isolated video_path argument in the tutorial works, it just seems to be this assignment and I am not sure how to fix it. I have tried to work through with little success and end up getting the same error farther down in the tutorial with: for frames, labels in train_ds.take(10): print(labels) I apologize if this is not where I should be posting stuff about the tutorial. ``` ### Standalone code to reproduce the issue ```shell https://www.tensorflow.org/tutorials/load_data/video I have copied and pasted everything that you see in your tutorial. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59701/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59701/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59700
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59700/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59700/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59700/events
https://github.com/tensorflow/tensorflow/pull/59700
1,586,446,267
PR_kwDOArmXAs5KELod
59,700
[TF:TRT] Sample change
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-15T19:44:12
2023-02-15T19:45:05
2023-02-15T19:44:52
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59700", "html_url": "https://github.com/tensorflow/tensorflow/pull/59700", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59700.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59700.patch", "merged_at": null }
[TF:TRT] Test changes for the title issue assignment from google-ml-buttler bot.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59700/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59700/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59699
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59699/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59699/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59699/events
https://github.com/tensorflow/tensorflow/issues/59699
1,586,437,956
I_kwDOArmXAs5ejx9E
59,699
Test Issue
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "sample comment", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59699\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59699\">No</a>\n" ]
2023-02-15T19:37:56
2023-02-15T19:38:45
2023-02-15T19:38:43
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell A bug happened! ``` ### Standalone code to reproduce the issue ```shell Sample issue ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59699/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59699/timeline
null
not_planned
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59698
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59698/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59698/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59698/events
https://github.com/tensorflow/tensorflow/issues/59698
1,586,221,272
I_kwDOArmXAs5ei9DY
59,698
LSTM prediction() - too slow
{ "login": "danielstankw", "id": 72759092, "node_id": "MDQ6VXNlcjcyNzU5MDky", "avatar_url": "https://avatars.githubusercontent.com/u/72759092?v=4", "gravatar_id": "", "url": "https://api.github.com/users/danielstankw", "html_url": "https://github.com/danielstankw", "followers_url": "https://api.github.com/users/danielstankw/followers", "following_url": "https://api.github.com/users/danielstankw/following{/other_user}", "gists_url": "https://api.github.com/users/danielstankw/gists{/gist_id}", "starred_url": "https://api.github.com/users/danielstankw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/danielstankw/subscriptions", "organizations_url": "https://api.github.com/users/danielstankw/orgs", "repos_url": "https://api.github.com/users/danielstankw/repos", "events_url": "https://api.github.com/users/danielstankw/events{/privacy}", "received_events_url": "https://api.github.com/users/danielstankw/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1205615612, "node_id": "MDU6TGFiZWwxMjA1NjE1NjEy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:%20ubuntu/linux", "name": "subtype: ubuntu/linux", "color": "b619ea", "default": false, "description": "Ubuntu/Linux Build/Installation Issues" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "[Lstm3.zip](https://github.com/tensorflow/tensorflow/files/10745602/Lstm3.zip)\r\n\r\n\r\nTrained model:\r\n`model = keras.models.load_model('Lstm3')`", "Hi @danielstankw,\r\n\r\nThe prediction time in TensorFlow depends on several factors, some of them are:\r\n\r\n1. Model complexity: Models with a large number of layers or parameters require more computation and memory, which can increase the prediction time.\r\n2. Input data size: Larger input data requires more computation and memory to process, which can increase the prediction time.\r\n3. Hardware specifications: The speed and memory of the CPU, GPU, or TPU being used to run the model can significantly affect the prediction time.\r\n4. Optimization techniques: TensorFlow provides various optimization techniques to speed up model prediction, such as quantization, pruning, and model compression.\r\n\r\nPlease refer to [Pruning in Keras](https://www.tensorflow.org/model_optimization/guide/pruning/pruning_with_keras), [Quantization aware training](https://www.tensorflow.org/model_optimization/guide/quantization/training_comprehensive_guide) and [model compression](https://www.tensorflow.org/tutorials/optimization/compression). Thank you!\r\n\r\n", "@synandi \r\nThank you for your reply, \r\n1. I have tried a single LSTM layer with 4 units instead of the network given above, and the time of prediction was of the same order of magnitude. This leads me to believe that the issue is related to the slow performance of LSTM layer implementation in Tensorflow. \r\nThis seems to be the case, considering the fact that I have seen other Github Issue posts being made about LSTM performance issues.\r\n\r\n2 & 3. My PC specs are pretty good. A friend of mine implemented complex LSTM using Pytorch instead and was able to achieve great performance with no issue in prediction time delay. As mentioned before, it seems like the issue is related to LSTM not being optimized in TF rather then complexity of model/ data. \r\n\r\n4. I will have a look into the links provided - thanks. If that does not help I guess will have to move on to Pytorch which is a bummer as I like the ease of implementation in TF much more ;/", "@danielstankw, as per the keras documentation please try adding an extra argument to the LSTM as `unroll=True`.\r\n> unroll: Boolean (default False). If True, the network will be unrolled, else a symbolic loop will be used. Unrolling can speed-up a RNN, although it tends to be more memory-intensive. Unrolling is only suitable for short sequences.\r\n \r\nLet us know if it is still an issue and if the links provided were helpful? Thank you! ", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59698\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59698\">No</a>\n" ]
2023-02-15T17:03:40
2023-03-24T04:32:42
2023-03-24T04:32:40
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Performance ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### Specs Memory: 32GB Ubuntu 22.04 LTS Processor: 12th Gen Intel-Core i9-12900KSx24 OS-type; 64-bit ### Current Behaviour? ``` I have trained an LSTM Autoencoder (see code for the structure). With the trained model I attempt to make predictions. For that, I have re-formated the input data to fit the input shape needed for LSTM. The issue is, that the speed of prediction is too slow. I am using the model to predict anomalies in sensor data in real time. My system runs in 125HZ -> 0.008 sec, so predictions of 0.03 slow down my system, which results in inability to execute the tasks properly. I have previously seen a similar issue discussed: https://github.com/tensorflow/tensorflow/issues/40261, I was unable to draw conclusions that can help in my case. Does anyone have any clue how can I speed up the prediction time? - any help would be much appreciated Using `model.predict(test_seq)`: avg: 0.03 sec Using `model(test_seq)`: abg: 0.03 sec ``` ### Standalone code to reproduce the issue ```shell def to_sequence(data, timesteps=1): n_features=data.shape[2] seq = [] for i in range(len(data)-timesteps): # takes a window of data of specified timesteps temp = data[i:(i+timesteps)] temp = temp.reshape(timesteps, n_features) seq.append(temp) return np.array(seq) def LSTM_autoencoder(data): n_timesteps = data.shape[1] n_features = data.shape[2] keras.backend.clear_session() model = keras.Sequential() model.add(keras.layers.Input(shape=(n_timesteps, n_features))) model.add(keras.layers.Conv1D(filters=32, kernel_size=15, padding='same', data_format='channels_last',dilation_rate=1, activation="linear")) model.add(keras.layers.LSTM(units=50, activation='relu', name='LSTM_1', return_sequences=False)) model.add(keras.layers.Dropout(0.2)) # to connect encoder with decoder RepeatVector repeats the provided 2D input multiple times to create 3D output model.add(keras.layers.RepeatVector(n=n_timesteps)) # decoder expects the 3D input model.add(keras.layers.LSTM(units=50, activation='relu', name='LSTM_2', return_sequences=True)) model.add(keras.layers.Conv1D(filters=32, kernel_size=15, padding='same', data_format='channels_last',dilation_rate=1, activation="linear")) model.add(keras.layers.Dropout(0.2)) # allows the same output layer to be reused for each element in sequence model.add(keras.layers.TimeDistributed(keras.layers.Dense(units=n_features))) model.compile(optimizer=keras.optimizers.Adam(learning_rate=0.001), loss="mse") return model model = keras.models.load_model('Lstm3') test=np.ones(255).reshape(51,5) # (51,5) test_expanded = np.expand_dims(test,axis=1) # (51,1,5) test_seq = to_sequence(test_expanded , 50) # (1,50,5) t=0 while t<100: t_start = time.time() model.predict(test_seq) print(time.time()-t_start) t+=1 ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59698/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59698/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59697
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59697/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59697/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59697/events
https://github.com/tensorflow/tensorflow/pull/59697
1,586,185,565
PR_kwDOArmXAs5KDS_2
59,697
[NVIDIA TF] Optimize Bilinear image resize using SSE instructions on x86 CPUs
{ "login": "nluehr", "id": 1873655, "node_id": "MDQ6VXNlcjE4NzM2NTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1873655?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nluehr", "html_url": "https://github.com/nluehr", "followers_url": "https://api.github.com/users/nluehr/followers", "following_url": "https://api.github.com/users/nluehr/following{/other_user}", "gists_url": "https://api.github.com/users/nluehr/gists{/gist_id}", "starred_url": "https://api.github.com/users/nluehr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nluehr/subscriptions", "organizations_url": "https://api.github.com/users/nluehr/orgs", "repos_url": "https://api.github.com/users/nluehr/repos", "events_url": "https://api.github.com/users/nluehr/events{/privacy}", "received_events_url": "https://api.github.com/users/nluehr/received_events", "type": "User", "site_admin": false }
[ { "id": 1173072136, "node_id": "MDU6TGFiZWwxMTczMDcyMTM2", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XL", "name": "size:XL", "color": "adafea", "default": false, "description": "CL Change Size:Extra Large" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @nluehr Can you please check @cantonios's comments and keep us posted ? Thank you!" ]
2023-02-15T16:39:34
2023-03-15T20:28:45
2023-03-15T20:28:38
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59697", "html_url": "https://github.com/tensorflow/tensorflow/pull/59697", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59697.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59697.patch", "merged_at": null }
With these changes I see an 18% improvement in single threaded bi-linear resize performance on x86 CPUs (based on resizing full-sized imagenet inputs to 224x224 pixels). Including disk IO and jpeg decode, the improvement dilutes to ~5%. But on multi-GPU systems where image pre-processing can represent a significant bottleneck, this 5% can translate directly to an overall 5% wall-time speedup.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59697/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59697/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59696
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59696/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59696/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59696/events
https://github.com/tensorflow/tensorflow/issues/59696
1,585,935,453
I_kwDOArmXAs5eh3Rd
59,696
Model performs differently on identical training and validation sets
{ "login": "taylora-mitre", "id": 103946969, "node_id": "U_kgDOBjIa2Q", "avatar_url": "https://avatars.githubusercontent.com/u/103946969?v=4", "gravatar_id": "", "url": "https://api.github.com/users/taylora-mitre", "html_url": "https://github.com/taylora-mitre", "followers_url": "https://api.github.com/users/taylora-mitre/followers", "following_url": "https://api.github.com/users/taylora-mitre/following{/other_user}", "gists_url": "https://api.github.com/users/taylora-mitre/gists{/gist_id}", "starred_url": "https://api.github.com/users/taylora-mitre/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/taylora-mitre/subscriptions", "organizations_url": "https://api.github.com/users/taylora-mitre/orgs", "repos_url": "https://api.github.com/users/taylora-mitre/repos", "events_url": "https://api.github.com/users/taylora-mitre/events{/privacy}", "received_events_url": "https://api.github.com/users/taylora-mitre/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @gaikwadrahul8 -- have you been able to reproduce this issue? Just want to make sure it doesn't get lost", "Hi, @taylora-mitre \r\n\r\nApologize for the delay and I was able to replicate the issue on Google colab with `Tensorflow==2.11` so I have added gist file for your reference [here](https://colab.research.google.com/gist/gaikwadrahul8/2360833ea46b4519353b601dc2da64dd/-59696.ipynb) and if training loss is converges to zero and still the validation loss is high this may indicate that the model is underfitting. It seems like mine and yours training loss and validation loss are different because you're generating random dataset in your code and you're using the same dataset as validation_data.\r\n\r\nJust to confirm, you're expecting both training loss and validation loss should be same because you're using same identical training and validation dataset Am I Right ? or Am I misunderstanding something here so please correct me ? Thank you!\r\n\r\n", "@gaikwadrahul8 \r\n\r\nYes, that's correct. I am expecting the train and validation loss to be the same, since I'm using identical datasets. Or, if not perfectly identical, at least very close -- I am not expecting them to differ by several orders of magnitude as in your gist and mine", "@gaikwadrahul8 what are the next steps for this issue?", "Hi, @taylora-mitre \r\n\r\nApologize for the delay and if you're following ResNet-18 model architecture with your customized functions and as you mentioned earlier training loss converging towards zero but still the validation loss high for random dataset with identical training and validation datasets it means that model is in underfitting but ideally we shouldn't use same training dataset for model validation.\r\n\r\nIf you want to build a reliable and robust model, you need to split your dataset into the training, validation, and test sets and If you don't, your results will be biased, and you'll end up with a false impression of better model accuracy.\r\n\r\nThe purpose of Validation set is our model training process is not a one-time process. We have to train multiple models by trying different combinations of hyperparameters. Then, we evaluate the performance of each model on the validation set. Therefore, the validation test is useful for hyperparameter tuning or selecting the best model out of different models\r\n\r\nYou're training your model only for 10 epochs so I don't think so you've built reliable, robust and generalise model so it will give you best result on validation dataset even though it's identical with training dataset in 10 epochs so could you please try for more number of epochs on GPU because the original ResNet-18 model architecture is complex and it has trained for some days with GPU, you can refer this [link](https://stackoverflow.com/questions/48051670/training-resnet-deep-neural-network-from-scratch), I hope it will help you to resolve your issue.\r\n\r\nIf I'm missing something here please let me know ? Thank you!", "@gaikwadrahul8 \r\n\r\nIt seems to me that you're missing the point of this issue entirely. I am not trying to build a robust, generalizable model; this is a toy example meant to demonstrate a specific technical issue.\r\n\r\nDo you truly think that the model is underfitting here? If anything, the model should be drastically *over-fitting* since we only use one `(X, y)` pair. In fact, this is by design! I am demonstrating that the expected behavior (extreme overfitting, leading to zero training and validation loss) does not happen here. This is the core of the issue.\r\n\r\nAgain, let me say that I am NOT trying to build a robust, production-ready, generalizable model in this simple toy example. I am trying a prove a point, which I believe you may have missed. For that reason, splitting the dataset into unique train/validation/test sets is not applicable here; similarly, training for longer times is not applicable here.", "Hi, @taylora-mitre \r\n\r\nApologize for the delayed response and I'm really sorry if I misunderstood your issue here so as you are using identical training and validation sets so you're expecting training and validation loss should be very close to zero or at least there shouldn't be difference by several orders of magnitude so (extreme overfitting, leading to zero training and validation loss) does not happening here, We'll have to dig more into this issue and we'll update you soon, Thank you for noticing this issue. Thank you!", "Yes, this is my issue. Thanks for the response. Let me know if you come up with anything for this!", "Hi, @taylora-mitre \r\n\r\nApologize for the delayed response and I found [stack-overflow-answer-1](https://stackoverflow.com/questions/49165351/why-val-loss-is-different-from-training-loss-when-use-the-same-training-data-as) and [stack-overflow-answer-2](https://stackoverflow.com/questions/55444737/validation-loss-much-higher-than-training-loss) which may help you to understand why training and validation loss shouldn't be very close to zero or at least there shouldn't be difference by several orders of magnitude on identical training and validation datasets and in your case it's leading to `Data Leakage` where the Machine Learning Model is already aware of some part of test data after training.This causes the problem of overfitting. I hope it will help you to solve your issue. Thank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "For anyone who comes across this in the future, the issue is the `BatchNormalization` layers in the model creation. Replacing these with another kinds of normalization (such as e.g. `GroupNormalization`), or just removing them entirely, leads to the expected behavior in this toy example.\r\n\r\nFor real-life applications of ML, it is recommended to use an alternative kind of normalization rather than dropping it entirely.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59696\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59696\">No</a>\n" ]
2023-02-15T14:14:32
2023-03-31T13:49:35
2023-03-31T13:49:32
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? Training a `tf.keras.models.Model` on a single, constant `(X, y)` does not behave as expected. The training loss converges to 0 as the model appears to learn the single training data element, but the validation loss remains high, despite the training and validation data being identical. I am using a ResNet-18 model architecture (see https://arxiv.org/pdf/1711.09577.pdf or the attached gist) which uses several stacked convolutional layers to form a deep and robust model. ### Standalone code to reproduce the issue ```python import numpy as np import tensorflow as tf # Build model model = build_my_model() # see attached gist below for specific model build # Generate training/validation data input_data = np.random.random((batch_size,*imshape)) dummy_target = np.random.random((batch_size,3)) # Convert to tf.data.Dataset ds1 = tf.data.Dataset.from_tensors(input_data) ds2 = tf.data.Dataset.from_tensors(dummy_target) dataset = tf.data.Dataset.zip((ds1,ds2)).repeat() for img,target in dataset.take(1): print(img.shape, target) # Fit model -- note training loss goes to 0, while validation loss does not model.fit( dataset, epochs=10, steps_per_epoch=30, validation_data = dataset, validation_steps=3, ) # Predict on the input data to show that the loss is still much larger than it should be ypred = model.predict(input_data, verbose=0) print(dummy_target, ypred, model.loss(ypred, dummy_target)) ``` Reproducible gist in Google Colab ```shell https://colab.research.google.com/gist/taylora-mitre/9ccdc0275f8d2119e33e311092c5334e/train-and-validation.ipynb ``` ### Relevant log output ``` Epoch 1/10 30/30 [==============================] - 7s 224ms/step - loss: 5.9760e-05 - val_loss: 5.9585 Epoch 2/10 30/30 [==============================] - 7s 225ms/step - loss: 3.0297e-06 - val_loss: 2.6298 Epoch 3/10 30/30 [==============================] - 7s 228ms/step - loss: 1.2876e-07 - val_loss: 1.4914 Epoch 4/10 30/30 [==============================] - 7s 223ms/step - loss: 5.6785e-09 - val_loss: 1.0507 Epoch 5/10 30/30 [==============================] - 7s 229ms/step - loss: 2.6075e-10 - val_loss: 0.8550 Epoch 6/10 30/30 [==============================] - 7s 220ms/step - loss: 7.5849e-12 - val_loss: 0.7406 Epoch 7/10 30/30 [==============================] - 7s 218ms/step - loss: 5.1980e-13 - val_loss: 0.6433 Epoch 8/10 30/30 [==============================] - 7s 222ms/step - loss: 1.7708e-13 - val_loss: 0.5429 Epoch 9/10 30/30 [==============================] - 7s 221ms/step - loss: 3.3924e-13 - val_loss: 0.4408 Epoch 10/10 30/30 [==============================] - 7s 221ms/step - loss: 3.0570e-13 - val_loss: 0.3440 <keras.callbacks.History at 0x7f6960343eb0> ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59696/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59696/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59695
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59695/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59695/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59695/events
https://github.com/tensorflow/tensorflow/pull/59695
1,585,927,190
PR_kwDOArmXAs5KCa6T
59,695
Update curl to 7.88.0
{ "login": "yongtang", "id": 6932348, "node_id": "MDQ6VXNlcjY5MzIzNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/6932348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yongtang", "html_url": "https://github.com/yongtang", "followers_url": "https://api.github.com/users/yongtang/followers", "following_url": "https://api.github.com/users/yongtang/following{/other_user}", "gists_url": "https://api.github.com/users/yongtang/gists{/gist_id}", "starred_url": "https://api.github.com/users/yongtang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yongtang/subscriptions", "organizations_url": "https://api.github.com/users/yongtang/orgs", "repos_url": "https://api.github.com/users/yongtang/repos", "events_url": "https://api.github.com/users/yongtang/events{/privacy}", "received_events_url": "https://api.github.com/users/yongtang/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-15T14:09:36
2023-02-16T02:00:18
2023-02-16T00:18:08
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59695", "html_url": "https://github.com/tensorflow/tensorflow/pull/59695", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59695.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59695.patch", "merged_at": "2023-02-16T00:18:08" }
This PR update curl to 7.88.0 for fixing the following vuls in previous 7.87.0: CVE-2023-23916: HTTP multi-header compression denial of service 2023-02-15 7.57.0-7.87.0 CVE-2023-23915: HSTS amnesia with --parallel 2023-02-15 7.77.0-7.87.0 CVE-2023-23914: HSTS ignored on multiple requests 2023-02-15 7.77.0-7.87.0 Reference: https://curl.se/docs/security.html
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59695/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59695/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59694
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59694/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59694/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59694/events
https://github.com/tensorflow/tensorflow/issues/59694
1,585,777,815
I_kwDOArmXAs5ehQyX
59,694
WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 6). These functions will not be directly callable after loading.
{ "login": "clime", "id": 2030528, "node_id": "MDQ6VXNlcjIwMzA1Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2030528?v=4", "gravatar_id": "", "url": "https://api.github.com/users/clime", "html_url": "https://github.com/clime", "followers_url": "https://api.github.com/users/clime/followers", "following_url": "https://api.github.com/users/clime/following{/other_user}", "gists_url": "https://api.github.com/users/clime/gists{/gist_id}", "starred_url": "https://api.github.com/users/clime/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/clime/subscriptions", "organizations_url": "https://api.github.com/users/clime/orgs", "repos_url": "https://api.github.com/users/clime/repos", "events_url": "https://api.github.com/users/clime/events{/privacy}", "received_events_url": "https://api.github.com/users/clime/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @clime \r\n\r\nApologize for the delay and as far I know, I think this warning can be safely ignored as you can find the same warning even in [Tensorflow-Tutorial](https://www.tensorflow.org/text/tutorials/text_generation#export_the_generator) and that warnings are that function could not be traced. It should be safe to ignore.\r\n\r\n`model.save() `will not only try to save the weights/variables, but also trace functions of the model and save their graph representations. This is what is failing for that function, and the warnings tell you about that.\r\n\r\nIf you want to continue training a model, you probably want to recreate the model from Python code anyway, and load/save just the weights. The `tf.keras.callbacks.BackupAndRestore `does this automatically at the end of each epoch. So if you interrupt the training script, next time you start it, it should automatically pick up from the beginning of the interrupted epoch.\r\n\r\nAs far as know these functions are needed while training the model I think those warnings are coming while training the model.\r\n\r\nYou can refer this [Stack overflow answer](https://stackoverflow.com/questions/65697623/tensorflow-warning-found-untraced-functions-such-as-lstm-cell-6-layer-call-and) also which supports ignoring those warnings.\r\n\r\nIf you're looking to disable `absl INFO and WARNING log `messages please use below code snippet:\r\n\r\n```\r\nimport absl.logging\r\nabsl.logging.set_verbosity(absl.logging.ERROR)\r\n```\r\nI hope I answered your questions and if I miss something here, Please let us know ? Thank you!", "Thanks, but I don't want to suppress the warning and I would also prefer not to ignore it. There should be a clean way to get rid of them. \r\n\r\nMy questions are:\r\n\r\n1) Why traces of these particular functions cannot be saved?\r\n2) If I decide to save the model without traces, will I be able to later load the model without recompiling and use it for evaluation?\r\n3) If I compile the model (`load_model(compile=True)`), will these jit functions be regenerated?\r\n4) Why would the get_config() method be only needed for all custom layers/models (I don't actually have any custom layers or models) when I disable saving the traces? Why is this `get_config()` method relevant at all?\r\n", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "ping :)", "Hi, @clime \r\n\r\nApologize for the delay and I found similar issue [#47554](https://github.com/tensorflow/tensorflow/issues/47554), If you save your model in `SavedModel` format which is the more comprehensive save format that saves the model architecture, weights, and the traced Tensorflow subgraphs of the call functions. This enables Keras to restore both built-in layers as well as custom objects and if saved model reloads without any change in model architecture, layers or Parameters then there shouldn't be any problem.\r\n\r\nIf you're saving your model in` .h5` format then you won't get any such warnings \r\n\r\nConfiguration of a Sequential model or Functional API model, These types of models are explicit graphs of layers their configuration is always available in a structured form and `get_config()` and `from_config()` API's calling will return a Python dict containing the configuration of the model. The same model can then be reconstructed via `Sequential.from_config(config)` (for a Sequential model) or `Model.from_config(config) `(for a Functional API model).\r\n\r\nIf you save the model in `SavedModel` format without traces, you can load the model without recompilation by doing `load_model(compile=False)` and if you compile the model `load_model(compile=True)` as far I know these jit functions warnings may come, you can refer our official documentation for [Save and load Keras models ](https://www.tensorflow.org/guide/keras/save_and_serialize#savedmodel_format) and also please refer this [answer](https://stackoverflow.com/questions/65697623/tensorflow-warning-found-untraced-functions-such-as-lstm-cell-6-layer-call-and#:~:text=If%20you%20ignore,environment%20after%20training.) on stackoverflow, I hope I'm able to answer your questions. \r\n\r\nIf you still need any further help please let us know ? Thank you!\r\n\r\n\r\n\r\n\r\n\r\n", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59694\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59694\">No</a>\n" ]
2023-02-15T12:30:58
2023-03-31T01:56:46
2023-03-31T01:56:43
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Support ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.11 ### Custom Code Yes ### OS Platform and Distribution Ubuntu 22.04.1 LTS ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell The warning appears: WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 6). These functions will not be directly callable after loading. ``` Can you please, explain, what is meant by this warning and how to fix it? I have the following accompanying questions to it: * Function traces are basically graph representations of functions or something else? * If these jit traces are not found in a loaded model, will they be generated again? Is model compilation needed for regeneration? * Are these functions needed only for training or also for prediction/evaluation? I have found in Keras docs (https://keras.io/api/models/model_saving_apis/) that I can disable saving the traces with the following note: "Disabling this will decrease serialization time and reduce file size, but it requires that all custom layers/models implement a get_config() method." * Why would the `get_config()` method be only needed when I disable saving the traces? Thanks in advance for any explanations given! ```shell ### Reproducer It's not my code but the warnings appear e.g. here: https://jovian.com/blog/tutorials/%20parameter-logging-wandb-ai ``` ``` ### Relevant log output WARNING:absl:Found untraced functions such as _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op, _jit_compiled_convolution_op while saving (showing 5 of 6). These functions will not be directly callable after loading. ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59694/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59694/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59693
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59693/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59693/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59693/events
https://github.com/tensorflow/tensorflow/issues/59693
1,585,767,303
I_kwDOArmXAs5ehOOH
59,693
Update curl to 7.88.0
{ "login": "RamanSggs", "id": 43900804, "node_id": "MDQ6VXNlcjQzOTAwODA0", "avatar_url": "https://avatars.githubusercontent.com/u/43900804?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RamanSggs", "html_url": "https://github.com/RamanSggs", "followers_url": "https://api.github.com/users/RamanSggs/followers", "following_url": "https://api.github.com/users/RamanSggs/following{/other_user}", "gists_url": "https://api.github.com/users/RamanSggs/gists{/gist_id}", "starred_url": "https://api.github.com/users/RamanSggs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RamanSggs/subscriptions", "organizations_url": "https://api.github.com/users/RamanSggs/orgs", "repos_url": "https://api.github.com/users/RamanSggs/repos", "events_url": "https://api.github.com/users/RamanSggs/events{/privacy}", "received_events_url": "https://api.github.com/users/RamanSggs/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "https://lore.kernel.org/distributions/[email protected]/T/#u\r\n\r\ntl;dr it might be worth holding off.", "Hi @RamanSggs, In order to expedite the trouble shooting process, please fill the issue [template](https://github.com/tensorflow/tensorflow/issues/new/choose) and share complete reproducible code. Thank you!", "This should be handled by #59695 ", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59693\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59693\">No</a>\n" ]
2023-02-15T12:23:21
2023-02-16T19:31:55
2023-02-16T19:31:53
NONE
null
null
null
Vulnerabilities are reported in curl 7.87. Can someone please update curl to 7.88 ?
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59693/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59693/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59692
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59692/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59692/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59692/events
https://github.com/tensorflow/tensorflow/issues/59692
1,585,588,674
I_kwDOArmXAs5eginC
59,692
TFLite undefined symbol when cross-compiling for android on linux
{ "login": "turgut-baba", "id": 56086820, "node_id": "MDQ6VXNlcjU2MDg2ODIw", "avatar_url": "https://avatars.githubusercontent.com/u/56086820?v=4", "gravatar_id": "", "url": "https://api.github.com/users/turgut-baba", "html_url": "https://github.com/turgut-baba", "followers_url": "https://api.github.com/users/turgut-baba/followers", "following_url": "https://api.github.com/users/turgut-baba/following{/other_user}", "gists_url": "https://api.github.com/users/turgut-baba/gists{/gist_id}", "starred_url": "https://api.github.com/users/turgut-baba/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/turgut-baba/subscriptions", "organizations_url": "https://api.github.com/users/turgut-baba/orgs", "repos_url": "https://api.github.com/users/turgut-baba/repos", "events_url": "https://api.github.com/users/turgut-baba/events{/privacy}", "received_events_url": "https://api.github.com/users/turgut-baba/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@turgut-baba Thanks for reporting the issue.\r\n\r\nI've tried running the commands \r\n\r\n`bazel build -c opt --config=elinux_aarch64 //tensorflow/lite:libtensorflowlite.so --fat_apk_cpu=arm64-v8a`\r\nand\r\n`bazel build -c opt --config=elinux_aarch64 //tensorflow/lite:libtensorflowlite.so` on Linux/Ubuntu 20.04, with Bazel 5.3.0 and was able to build successfully. Please find the [gist](https://colab.research.google.com/gist/pjpratik/eda786aa4b7b0471a09465a4b19561c7/-59692.ipynb#scrollTo=D2pgHogEk3O0) here. \r\n\r\nHave you tried with Android NDK 19c which is [recommended](https://www.tensorflow.org/lite/android/lite_build#set_up_build_environment_without_docker). Thanks!\r\n\r\n", "Hello, I will try it with bazel 5.3.0 and update you, however due to my projects needs, I can't use NDK versions below 25.", "Running `bazel build -c opt --config=elinux_aarch64 //tensorflow/lite:libtensorflowlite.so --fat_apk_cpu=arm64-v8a` with bazel 5.3.0 causes this error on the `v2.12.0-rc0` and `r2.12` and `master` branch :\r\n```\r\nStarting local Bazel server and connecting to it...\r\nINFO: Options provided by the client:\r\n Inherited 'common' options: --isatty=1 --terminal_columns=80\r\nINFO: Reading rc options for 'build' from /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc:\r\n Inherited 'common' options: --experimental_repo_remote_exec\r\nINFO: Reading rc options for 'build' from /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc:\r\n 'build' options: --define framework_shared_object=true --define tsl_protobuf_header_only=true --define=use_fast_cpp_protos=true --define=allow_oversize_protos=true --spawn_strategy=standalone -c opt --announce_rc --define=grpc_no_ares=true --noincompatible_remove_legacy_whole_archive --enable_platform_specific_config --define=with_xla_support=true --config=short_logs --config=v2 --define=no_aws_support=true --define=no_hdfs_support=true --experimental_cc_shared_library --experimental_link_static_libraries_once=false --incompatible_enforce_config_setting_visibility\r\nINFO: Reading rc options for 'build' from /home/tb/Desktop/tensorflow/tensorflow_src/.tf_configure.bazelrc:\r\n 'build' options: --action_env PYTHON_BIN_PATH=/usr/bin/python3 --action_env PYTHON_LIB_PATH=/usr/lib/python3/dist-packages --python_path=/usr/bin/python3\r\nINFO: Reading rc options for 'build' from /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc:\r\n 'build' options: --deleted_packages=tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/eager,tensorflow/core/tfrt/eager/backends/cpu,tensorflow/core/tfrt/eager/backends/gpu,tensorflow/core/tfrt/eager/core_runtime,tensorflow/core/tfrt/eager/cpp_tests/core_runtime,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils\r\nINFO: Found applicable config definition build:short_logs in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --output_filter=DONT_MATCH_ANYTHING\r\nINFO: Found applicable config definition build:v2 in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1\r\nINFO: Found applicable config definition build:elinux_aarch64 in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --config=elinux --cpu=aarch64 --distinct_host_configuration=true\r\nINFO: Found applicable config definition build:elinux in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --crosstool_top=@local_config_embedded_arm//:toolchain --host_crosstool_top=@bazel_tools//tools/cpp:toolchain\r\nINFO: Found applicable config definition build:linux in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --host_copt=-w --copt=-Wno-all --copt=-Wno-extra --copt=-Wno-deprecated --copt=-Wno-deprecated-declarations --copt=-Wno-ignored-attributes --copt=-Wno-array-bounds --copt=-Wunused-result --copt=-Werror=unused-result --copt=-Wswitch --copt=-Werror=switch --copt=-Wno-error=unused-but-set-variable --define=PREFIX=/usr --define=LIBDIR=$(PREFIX)/lib --define=INCLUDEDIR=$(PREFIX)/include --define=PROTOBUF_INCLUDE_PATH=$(PREFIX)/include --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --config=dynamic_kernels --distinct_host_configuration=false --experimental_guard_against_concurrent_changes\r\nINFO: Found applicable config definition build:dynamic_kernels in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --define=dynamic_loaded_kernels=true --copt=-DAUTOLOAD_DYNAMIC_KERNELS\r\nINFO: Analyzed target //tensorflow/lite:libtensorflowlite.so (89 packages loaded, 10700 targets configured).\r\nINFO: Found 1 target...\r\nERROR: /home/tb/Desktop/tensorflow/tensorflow_src/tensorflow/lite/kernels/internal/BUILD:864:11: Compiling tensorflow/lite/kernels/internal/mfcc.cc failed: (Exit 1): aarch64-none-linux-gnu-gcc failed: error executing command /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/bin/aarch64-none-linux-gnu-gcc -fstack-protector -g0 -O2 -DNDEBUG -ffunction-sections -fdata-sections ... (remaining 52 arguments skipped)\r\nIn file included from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/bits/specfun.h:46,\r\n from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/cmath:1935,\r\n from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/math.h:36,\r\n from tensorflow/lite/kernels/internal/mfcc.cc:16:\r\n/home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/limits:1673:7: internal compiler error: Illegal instruction\r\n 1673 | min() _GLIBCXX_USE_NOEXCEPT { return __FLT_MIN__; }\r\n | ^~~\r\n0x7f1c93401d5f ???\r\n\t./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0\r\nPlease submit a full bug report,\r\nwith preprocessed source if appropriate.\r\nPlease include the complete backtrace with any bug report.\r\nSee <https://bugs.linaro.org/> for instructions.\r\nERROR: /home/tb/Desktop/tensorflow/tensorflow_src/tensorflow/lite/kernels/internal/BUILD:864:11: Compiling tensorflow/lite/kernels/internal/mfcc_dct.cc failed: (Exit 1): aarch64-none-linux-gnu-gcc failed: error executing command /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/bin/aarch64-none-linux-gnu-gcc -fstack-protector -g0 -O2 -DNDEBUG -ffunction-sections -fdata-sections ... (remaining 52 arguments skipped)\r\nIn file included from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/bits/specfun.h:46,\r\n from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/cmath:1935,\r\n from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/math.h:36,\r\n from tensorflow/lite/kernels/internal/mfcc_dct.cc:18:\r\n/home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/limits:1673:7: internal compiler error: Illegal instruction\r\n 1673 | min() _GLIBCXX_USE_NOEXCEPT { return __FLT_MIN__; }\r\n | ^~~\r\n0x7ff7ee25dd5f ???\r\n\t./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0\r\nPlease submit a full bug report,\r\nwith preprocessed source if appropriate.\r\nPlease include the complete backtrace with any bug report.\r\nSee <https://bugs.linaro.org/> for instructions.\r\nERROR: /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/ruy/ruy/BUILD:189:11: Compiling ruy/tune.cc failed: (Exit 1): aarch64-none-linux-gnu-gcc failed: error executing command /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/bin/aarch64-none-linux-gnu-gcc -fstack-protector -g0 -O2 -DNDEBUG -ffunction-sections -fdata-sections ... (remaining 62 arguments skipped)\r\nIn file included from /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/chrono:41,\r\n from external/ruy/ruy/time.h:19,\r\n from external/ruy/ruy/tune.h:48,\r\n from external/ruy/ruy/tune.cc:16:\r\n/home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/aarch64-none-linux-gnu/include/c++/11.3.1/limits:1673:7: internal compiler error: Illegal instruction\r\n 1673 | min() _GLIBCXX_USE_NOEXCEPT { return __FLT_MIN__; }\r\n | ^~~\r\n0x7f82f4e2dd5f ???\r\n\t./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0\r\nPlease submit a full bug report,\r\nwith preprocessed source if appropriate.\r\nPlease include the complete backtrace with any bug report.\r\nSee <https://bugs.linaro.org/> for instructions.\r\nERROR: /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/XNNPACK/BUILD.bazel:5371:19: Compiling src/subgraph/static-constant-pad.c failed: (Exit 1): aarch64-none-linux-gnu-gcc failed: error executing command /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/bin/aarch64-none-linux-gnu-gcc -fstack-protector -g0 -O2 -DNDEBUG -ffunction-sections -fdata-sections ... (remaining 93 arguments skipped)\r\nIn file included from external/XNNPACK/src/xnnpack/compute.h:14,\r\n from external/XNNPACK/src/xnnpack/operator.h:18,\r\n from external/XNNPACK/src/subgraph/static-constant-pad.c:6:\r\nexternal/XNNPACK/src/xnnpack/math.h: In function 'min':\r\nexternal/XNNPACK/src/xnnpack/math.h:35:3: internal compiler error: Illegal instruction\r\n 35 | return XNN_UNPREDICTABLE(b < a) ? b : a;\r\n | ^~~~~~\r\n0x7f0820113d5f ???\r\n\t./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0\r\n0x7f08200fed09 __libc_start_main\r\n\t../csu/libc-start.c:308\r\nPlease submit a full bug report,\r\nwith preprocessed source if appropriate.\r\nPlease include the complete backtrace with any bug report.\r\nSee <https://bugs.linaro.org/> for instructions.\r\nERROR: /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/XNNPACK/BUILD.bazel:5371:19: Compiling src/subgraph/global-average-pooling.c failed: (Exit 1): aarch64-none-linux-gnu-gcc failed: error executing command /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/aarch64_linux_toolchain/bin/aarch64-none-linux-gnu-gcc -fstack-protector -g0 -O2 -DNDEBUG -ffunction-sections -fdata-sections ... (remaining 93 arguments skipped)\r\nIn file included from external/XNNPACK/src/xnnpack/compute.h:14,\r\n from external/XNNPACK/src/xnnpack/operator.h:18,\r\n from external/XNNPACK/src/subgraph/global-average-pooling.c:13:\r\nexternal/XNNPACK/src/xnnpack/math.h: In function 'min':\r\nexternal/XNNPACK/src/xnnpack/math.h:35:3: internal compiler error: Illegal instruction\r\n 35 | return XNN_UNPREDICTABLE(b < a) ? b : a;\r\n | ^~~~~~\r\n0x7ffb93661d5f ???\r\n\t./signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0\r\n0x7ffb9364cd09 __libc_start_main\r\n\t../csu/libc-start.c:308\r\nPlease submit a full bug report,\r\nwith preprocessed source if appropriate.\r\nPlease include the complete backtrace with any bug report.\r\nSee <https://bugs.linaro.org/> for instructions.\r\nTarget //tensorflow/lite:libtensorflowlite.so failed to build\r\nUse --verbose_failures to see the command lines of failed build steps.\r\nINFO: Elapsed time: 88.774s, Critical Path: 26.47s\r\nINFO: 210 processes: 177 internal, 33 local.\r\nFAILED: Build did NOT complete successfully\r\n\r\n```", "@turgut-baba Thanks for the update.\r\n\r\n@sachinprasadhs Could you please look into this. Thank you.", "@pjpratik On a side note, I've found some pre-compiled versions of the library on the internet from 2021, it runs just fine on it's own but when I use it inside my project, which uses threading on android, it gives out an error. (I've set `setnumThreads` to 2.). I assume this issue is addressed in the newer releases but since I can't compile it on my own I'm stuck. Also: If I compile the .so files with NDK 19, can I use that in my NDK 25 > project?", "> C/C++: ld: error: undefined symbol: tflite::impl::Interpreter::Invoke()\r\n\r\nThat symbol is supposed to be defined in the file tensorflow/lite/core/interpreter.cc.\r\n\r\nThere have been a few changes related to this recently, with the implementation of this method recently moving\r\n(a) from the \"tflite\" namespace to the \"tflite::impl\" namespace and\r\n(b) from tensorflow/lite/interpreter.cc to tensorflow/lite/core/interpreter.cc\r\n\r\nI suspect the problem may be related to one of those, probably (b).\r\n", "@fergushenderson Do you have any suggestions I can try in the meantime? Which branch do you suggest I use?", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Hi, Could you please try to build against the latest stable branch `2.11` and let us know if it is working for you.\r\n`2.12` is not yet released, till `2.12` is available you could build it against the last stable branch which is `2.11`. Thanks!", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59692\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59692\">No</a>\n", "@sachinprasadhs the issue was not fixed since then it seems\r\nthis commit https://github.com/tensorflow/tensorflow/commit/734de9e767fdd81d67bd47a14a1281b9736c8544#diff-7456c1d9f62f2c8c05621072dba61fc0db513a09331f60f9601d2e610c114dda updated the ARM toolchain to 11.3 Rel1 - however, according to \r\nhttps://bugs.linaro.org/show_bug.cgi?id=5825#c34\r\n```\r\nThe issues was only fixed in the baremetal builds with 11.3 Rel1. Unfortunately the aarch64-none-linux-gnu and arm-none-linux-gnueabihf targets are still affected by the same underlying issue in that release.\r\n```\r\nso I'm assuming it is still broken on latest master - but it is definitely broken in 2.12rc0, which is what I'm trying to build.\r\n\r\nI'm trying swapping the toolchain to arm-gnu-toolchain-12.3.rel1-aarch64-arm-none-linux-gnueabihf, the build seems to be progressing as of now.\r\n\r\nIf it builds and runs, would you like me to make a PR? Do you have a CI test for this in place?", "You can go ahead and make the changes." ]
2023-02-15T10:17:10
2024-04-09T18:17:53
2023-03-28T01:57:56
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12 ### Custom Code Yes ### OS Platform and Distribution Debian 11 ### Mobile device Android NDK 25 ### Python version 3.9.2 ### Bazel version Tried on 7.0.0 and 6.0.0 ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? I'm trying to cross compile TFLite on my linux machine to be compatible with android machines so I can use it on my c++ code that runs on android devices. I've tried 3 different bazel builds with 3 different issues. Also tried the 'build with cmake for arm' section with errors. More details can be found here: https://stackoverflow.com/questions/75457043/build-tflite-c-lib-for-android-with-ndk-25-with-bazel https://stackoverflow.com/questions/75435665/errno-8-exec-format-error-on-tflite-cmake-build-for-arm64-v8a How can I fix this or are there any pre-compiled so files? ### Standalone code to reproduce the issue First I ran `./configure` and skipped over the `configure ./WORKSPACE` part since I'm using ndk version 25 and can't give the path. First command tried: `bazel build -c opt --config=elinux_aarch64 //tensorflow/lite:libtensorflowlite.so --fat_apk_cpu=arm64-v8a` Second command: `bazel build -c opt --config=android_arm64 //tensorflow/lite:libtensorflowlite.so` Third command (not right but I've tried it anyways): `bazel build -c opt --config=elinux_aarch64 //tensorflow/lite:libtensorflowlite.so` I've also tried running the `cross compilation with cmake for arm` by doing: - Clone to tensorflow_src - Create tensorflow_build in the same place as src - Run `curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz` - Run `mkdir -p ${HOME}/toolchains` - Run `tar xvf gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz -C ${HOME}/toolchains` - go to tensorflow_build dir - Run `ARMCC_PREFIX=${HOME}/toolchains/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/bin/aarch64-linux-gnu-` && `ARMCC_FLAGS="-funsafe-math-optimizations"` - And finally `cmake -DCMAKE_C_COMPILER=${ARMCC_PREFIX}gcc -DCMAKE_CXX_COMPILER=${ARMCC_PREFIX}g++ -DCMAKE_C_FLAGS="${ARMCC_FLAGS}" -DCMAKE_CXX_FLAGS="${ARMCC_FLAGS}" -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=aarch64 ../tensorflow_src/tensorflow/lite/` My cmake looks like this: ```cmake set(TENSORFLOW_SOURCE_DIR "" CACHE PATH "~/Desktop/tensorflow/tensorflow_build" ) if(NOT TENSORFLOW_SOURCE_DIR) get_filename_component(TENSORFLOW_SOURCE_DIR "~/Desktop/tensorflow/tensorflow_src" ABSOLUTE) endif() add_subdirectory( "${TENSORFLOW_SOURCE_DIR}/tensorflow/lite" "${CMAKE_CURRENT_BINARY_DIR}/tensorflow-lite" EXCLUDE_FROM_ALL) ... target_link_directories( ... tensorflow-lite ) ``` ### Relevant log output Output of the first command: I get the .so, get the relevant header files from r1.11 branch `C/C++: ld: error: undefined symbol: tflite::impl::Interpreter::Invoke()` Second one I get: When I try to compile with bazel I get this: ```shell ... INFO: Found applicable config definition build:android_arm64 in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --config=android --cpu=arm64-v8a --fat_apk_cpu=arm64-v8a INFO: Found applicable config definition build:android in file /home/tb/Desktop/tensorflow/tensorflow_src/.bazelrc: --crosstool_top=//external:android/crosstool --host_crosstool_top=@bazel_tools//tools/cpp:toolchain --noenable_platform_specific_config --copt=-w --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --define=with_xla_support=false INFO: Build options --copt, --cpu, --crosstool_top, and 2 more have changed, discarding analysis cache. ERROR: /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/local_config_cc/BUILD:47:19: in cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'arm64-v8a' ERROR: /home/tb/.cache/bazel/_bazel_tb/f8bd8a53c316ccb93548129bbd0ade7a/external/local_config_cc/BUILD:47:19: Analysis of target '@local_config_cc//:toolchain' failed ERROR: Analysis of target '//tensorflow/lite:libtensorflowlite.so' failed; build aborted: INFO: Elapsed time: 0.238s INFO: 0 processes. ERROR: Build did NOT complete successfully ``` Third one, as expected: `C/C++: ld: error: /home/tb/Desktop/proj/cmake/android/../../third-party/libs/tflite/arm64-v8a/libtensorflowlite.so is incompatible with aarch64linux` The result I got when I run with the cmake attempt: When compiling: ``` In file included from /home/tb/Desktop/tensorflow/tensorflow_src/tensorflow/lite/python/interpreter_wrapper/python_utils.cc:16: /home/tb/Desktop/tensorflow/tensorflow_src/tensorflow/lite/python/interpreter_wrapper/python_utils.h:19:10: fatal error: 'Python.h' file not found ``` When I give the path for python manually cmake it gives a bunch of more errors related to python, it's a rabbit hole. Note: My project REQUIRES ndk versions above 25 so I have to find a way to build it like that and it's the reason why I can't say yes to `configure ./WORKSPACE` when running `./configure `
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59692/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59692/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59691
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59691/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59691/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59691/events
https://github.com/tensorflow/tensorflow/pull/59691
1,585,448,613
PR_kwDOArmXAs5KAzU7
59,691
features/add-example
{ "login": "Layconnn", "id": 124673376, "node_id": "U_kgDOB25dYA", "avatar_url": "https://avatars.githubusercontent.com/u/124673376?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Layconnn", "html_url": "https://github.com/Layconnn", "followers_url": "https://api.github.com/users/Layconnn/followers", "following_url": "https://api.github.com/users/Layconnn/following{/other_user}", "gists_url": "https://api.github.com/users/Layconnn/gists{/gist_id}", "starred_url": "https://api.github.com/users/Layconnn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Layconnn/subscriptions", "organizations_url": "https://api.github.com/users/Layconnn/orgs", "repos_url": "https://api.github.com/users/Layconnn/repos", "events_url": "https://api.github.com/users/Layconnn/events{/privacy}", "received_events_url": "https://api.github.com/users/Layconnn/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59691/checks?check_run_id=11352869680) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "@Layconnn Can you please sign CLA. Thank you!", "Hi @Layconnn I can see no changes in file. Hence closing the PR. Thanks you!", "Yeah, this seems spam" ]
2023-02-15T08:45:56
2023-02-16T15:18:32
2023-02-16T04:47:29
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59691", "html_url": "https://github.com/tensorflow/tensorflow/pull/59691", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59691.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59691.patch", "merged_at": null }
@tensorflow @meshmmanuel
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59691/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59691/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59690
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59690/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59690/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59690/events
https://github.com/tensorflow/tensorflow/pull/59690
1,584,994,834
PR_kwDOArmXAs5J_SVg
59,690
Fix broken relnotes.
{ "login": "mihaimaruseac", "id": 323199, "node_id": "MDQ6VXNlcjMyMzE5OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/323199?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mihaimaruseac", "html_url": "https://github.com/mihaimaruseac", "followers_url": "https://api.github.com/users/mihaimaruseac/followers", "following_url": "https://api.github.com/users/mihaimaruseac/following{/other_user}", "gists_url": "https://api.github.com/users/mihaimaruseac/gists{/gist_id}", "starred_url": "https://api.github.com/users/mihaimaruseac/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mihaimaruseac/subscriptions", "organizations_url": "https://api.github.com/users/mihaimaruseac/orgs", "repos_url": "https://api.github.com/users/mihaimaruseac/repos", "events_url": "https://api.github.com/users/mihaimaruseac/events{/privacy}", "received_events_url": "https://api.github.com/users/mihaimaruseac/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-02-14T23:49:12
2023-02-15T15:52:50
2023-02-15T15:52:45
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59690", "html_url": "https://github.com/tensorflow/tensorflow/pull/59690", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59690.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59690.patch", "merged_at": "2023-02-15T15:52:45" }
There should be only one level 1 heading (`#` / `<h1>`) in each release section and the rest should be L2 (`##`/`<h2>`) but when the stub got created at the last release time it got created badly and review was nonexistent so we see the breakage ~3 months after
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59690/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59690/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59689
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59689/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59689/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59689/events
https://github.com/tensorflow/tensorflow/pull/59689
1,584,923,329
PR_kwDOArmXAs5J_Cty
59,689
Povtesting
{ "login": "parson-harness", "id": 108954591, "node_id": "U_kgDOBn6D3w", "avatar_url": "https://avatars.githubusercontent.com/u/108954591?v=4", "gravatar_id": "", "url": "https://api.github.com/users/parson-harness", "html_url": "https://github.com/parson-harness", "followers_url": "https://api.github.com/users/parson-harness/followers", "following_url": "https://api.github.com/users/parson-harness/following{/other_user}", "gists_url": "https://api.github.com/users/parson-harness/gists{/gist_id}", "starred_url": "https://api.github.com/users/parson-harness/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/parson-harness/subscriptions", "organizations_url": "https://api.github.com/users/parson-harness/orgs", "repos_url": "https://api.github.com/users/parson-harness/repos", "events_url": "https://api.github.com/users/parson-harness/events{/privacy}", "received_events_url": "https://api.github.com/users/parson-harness/received_events", "type": "User", "site_admin": false }
[ { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59689/checks?check_run_id=11343709078) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request." ]
2023-02-14T22:30:59
2023-02-14T22:31:29
2023-02-14T22:31:29
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59689", "html_url": "https://github.com/tensorflow/tensorflow/pull/59689", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59689.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59689.patch", "merged_at": null }
null
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59689/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59689/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59688
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59688/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59688/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59688/events
https://github.com/tensorflow/tensorflow/pull/59688
1,584,844,945
PR_kwDOArmXAs5J-xkG
59,688
Feature/add examples
{ "login": "Horlaboi", "id": 114763097, "node_id": "U_kgDOBtclWQ", "avatar_url": "https://avatars.githubusercontent.com/u/114763097?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Horlaboi", "html_url": "https://github.com/Horlaboi", "followers_url": "https://api.github.com/users/Horlaboi/followers", "following_url": "https://api.github.com/users/Horlaboi/following{/other_user}", "gists_url": "https://api.github.com/users/Horlaboi/gists{/gist_id}", "starred_url": "https://api.github.com/users/Horlaboi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Horlaboi/subscriptions", "organizations_url": "https://api.github.com/users/Horlaboi/orgs", "repos_url": "https://api.github.com/users/Horlaboi/repos", "events_url": "https://api.github.com/users/Horlaboi/events{/privacy}", "received_events_url": "https://api.github.com/users/Horlaboi/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59688/checks?check_run_id=11342188340) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "Hi @Horlaboi Can you please sign CLA. Thank you!" ]
2023-02-14T21:17:24
2023-02-16T05:21:48
2023-02-16T05:21:45
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59688", "html_url": "https://github.com/tensorflow/tensorflow/pull/59688", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59688.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59688.patch", "merged_at": null }
For me to get to the stage i read about the article and try to understand about clone a forked repository before i make changes from the example, now commit and push it on my github account. kudos to you on this learning @opencv @meshmmanuel
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59688/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59688/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59687
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59687/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59687/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59687/events
https://github.com/tensorflow/tensorflow/pull/59687
1,584,736,926
PR_kwDOArmXAs5J-aJp
59,687
[tf-trt] Test PR
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-14T19:52:06
2023-02-14T21:03:38
2023-02-14T19:52:14
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59687", "html_url": "https://github.com/tensorflow/tensorflow/pull/59687", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59687.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59687.patch", "merged_at": null }
This is TEST PR to check the PR reviewers based on the [TF-TRT] [TFTRT] [TF:TRT] tags in the title, all case insensitive.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59687/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59687/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59686
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59686/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59686/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59686/events
https://github.com/tensorflow/tensorflow/pull/59686
1,584,538,705
PR_kwDOArmXAs5J9vO1
59,686
Update Release.MD file
{ "login": "vinila21", "id": 106367904, "node_id": "U_kgDOBlcLoA", "avatar_url": "https://avatars.githubusercontent.com/u/106367904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinila21", "html_url": "https://github.com/vinila21", "followers_url": "https://api.github.com/users/vinila21/followers", "following_url": "https://api.github.com/users/vinila21/following{/other_user}", "gists_url": "https://api.github.com/users/vinila21/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinila21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinila21/subscriptions", "organizations_url": "https://api.github.com/users/vinila21/orgs", "repos_url": "https://api.github.com/users/vinila21/repos", "events_url": "https://api.github.com/users/vinila21/events{/privacy}", "received_events_url": "https://api.github.com/users/vinila21/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-02-14T17:13:49
2023-02-15T15:50:33
2023-02-15T15:50:25
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59686", "html_url": "https://github.com/tensorflow/tensorflow/pull/59686", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59686.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59686.patch", "merged_at": "2023-02-15T15:50:25" }
Moving `tf.SavedModel` to Major Features and Improvements.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59686/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59686/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59685
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59685/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59685/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59685/events
https://github.com/tensorflow/tensorflow/issues/59685
1,584,519,200
I_kwDOArmXAs5ecdgg
59,685
experimental_convert_saved_model_to_mlir strips public functions with expected names from exported MLIR
{ "login": "dellis23", "id": 1346302, "node_id": "MDQ6VXNlcjEzNDYzMDI=", "avatar_url": "https://avatars.githubusercontent.com/u/1346302?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dellis23", "html_url": "https://github.com/dellis23", "followers_url": "https://api.github.com/users/dellis23/followers", "following_url": "https://api.github.com/users/dellis23/following{/other_user}", "gists_url": "https://api.github.com/users/dellis23/gists{/gist_id}", "starred_url": "https://api.github.com/users/dellis23/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dellis23/subscriptions", "organizations_url": "https://api.github.com/users/dellis23/orgs", "repos_url": "https://api.github.com/users/dellis23/repos", "events_url": "https://api.github.com/users/dellis23/events{/privacy}", "received_events_url": "https://api.github.com/users/dellis23/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 2691123225, "node_id": "MDU6TGFiZWwyNjkxMTIzMjI1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:tf.function", "name": "comp:tf.function", "color": "0052cc", "default": false, "description": "tf.function related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "matthiaskramm", "id": 306087, "node_id": "MDQ6VXNlcjMwNjA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/306087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/matthiaskramm", "html_url": "https://github.com/matthiaskramm", "followers_url": "https://api.github.com/users/matthiaskramm/followers", "following_url": "https://api.github.com/users/matthiaskramm/following{/other_user}", "gists_url": "https://api.github.com/users/matthiaskramm/gists{/gist_id}", "starred_url": "https://api.github.com/users/matthiaskramm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/matthiaskramm/subscriptions", "organizations_url": "https://api.github.com/users/matthiaskramm/orgs", "repos_url": "https://api.github.com/users/matthiaskramm/repos", "events_url": "https://api.github.com/users/matthiaskramm/events{/privacy}", "received_events_url": "https://api.github.com/users/matthiaskramm/received_events", "type": "User", "site_admin": false }
[ { "login": "matthiaskramm", "id": 306087, "node_id": "MDQ6VXNlcjMwNjA4Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/306087?v=4", "gravatar_id": "", "url": "https://api.github.com/users/matthiaskramm", "html_url": "https://github.com/matthiaskramm", "followers_url": "https://api.github.com/users/matthiaskramm/followers", "following_url": "https://api.github.com/users/matthiaskramm/following{/other_user}", "gists_url": "https://api.github.com/users/matthiaskramm/gists{/gist_id}", "starred_url": "https://api.github.com/users/matthiaskramm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/matthiaskramm/subscriptions", "organizations_url": "https://api.github.com/users/matthiaskramm/orgs", "repos_url": "https://api.github.com/users/matthiaskramm/repos", "events_url": "https://api.github.com/users/matthiaskramm/events{/privacy}", "received_events_url": "https://api.github.com/users/matthiaskramm/received_events", "type": "User", "site_admin": false }, { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "@matthiaskramm for visibility (can't seem to assign you)", "Thanks for the detailed bug report! I'll take a look. (Give me a few days, I'm in the middle of another thing.)", "I can't find a pass that would already do this (take the exported_names and create a wrapper function for each). The one that comes closest is `tensorflow/compiler/mlir/tfrt/transforms/lower_saved_model.cc`, but it duplicates the function(s) in question which I don't think we should.\r\n\r\nWill write a new pass and hook up to `tf-lower-to-mlprogram-and-hlo`.", "This should be fixed now. (In tf-nightly)", "Hi, @dellis23 \r\n\r\nApologize for the delayed response and I was able to replicate the same issue with `tf-nightly` and I have added [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/d4697e78fc93c5b2440e6898cfb00a03/-59685.ipynb) for your reference and May I know have we taken care of your issue in `tf-nightly` please ? Thank you!\r\n\r\nI have added details about `simple-model.mlir` below:\r\n\r\n```\r\nmodule {\r\n func.func @train(%arg0: tensor<f32>) -> tensor<f32> {\r\n %0 = call @__inference_train_3160_internal(%arg0) : (tensor<f32>) -> tensor<f32>\r\n return %0 : tensor<f32>\r\n }\r\n ml_program.global public mutable @vars.__sm_node1__w(dense<1.200000e+01> : tensor<f32>) : tensor<f32>\r\n ml_program.global public mutable @vars.__sm_node2__b(dense<7.000000e+00> : tensor<f32>) : tensor<f32>\r\n func.func private @__inference_train_3160_internal(%arg0: tensor<f32>) -> tensor<f32> {\r\n %0 = ml_program.global_load @vars.__sm_node1__w : tensor<f32>\r\n %1 = stablehlo.add %0, %arg0 : tensor<f32>\r\n ml_program.global_store @vars.__sm_node1__w = %1 : tensor<f32>\r\n %2 = ml_program.global_load @vars.__sm_node1__w : tensor<f32>\r\n %3 = ml_program.global_load @vars.__sm_node2__b : tensor<f32>\r\n %4 = stablehlo.add %3, %arg0 : tensor<f32>\r\n ml_program.global_store @vars.__sm_node2__b = %4 : tensor<f32>\r\n return %2 : tensor<f32>\r\n }\r\n}\r\n```", "@gaikwadrahul8 No worries! Yes, this seems to be fixed in the latest nightly. Thanks.", "Hi, @dellis23 \r\n\r\nThank you for the confirmation and Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59685\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59685\">No</a>\n" ]
2023-02-14T17:01:14
2023-03-30T13:14:39
2023-03-30T13:14:37
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version v1.12.1-89390-gf1ef1162316 2.13.0-dev20230214 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? Using `experimental_convert_saved_model_to_mlir` to generate MLIR for a model strips nice names (e.g. "train") and leaves behind funky ones (e.g. "__inference_train_250"). See https://github.com/iree-org/iree/issues/10849#issuecomment-1430031039 for more background. ### Standalone code to reproduce the issue ```python import tensorflow as tf from tensorflow.python import pywrap_mlir from pathlib import Path class MyModel(tf.Module): def __init__(self, **kwargs): super().__init__(**kwargs) self.w = tf.Variable(5.0, name='weight') self.b = tf.Variable(0.0, name='bias') @tf.function def train(self, x): self.w.assign_add(x) self.b.assign_add(x) return self.w m = MyModel() m.train(tf.constant(3.0)) m.train(tf.constant(4.0)) tf.saved_model.save(m, '/tmp/simple-model') def convert_to_hlo(model_path: str): result = pywrap_mlir.experimental_convert_saved_model_to_mlir( model_path, "", show_debug_info=False) pipeline = ["tf-lower-to-mlprogram-and-hlo"] result = pywrap_mlir.experimental_run_pass_pipeline( result, ",".join(pipeline), show_debug_info=False) return result Path("/tmp/simple-model.mlir").write_text( convert_to_hlo("/tmp/simple-model")) ``` This generates the following MLIR: ```mlir module { ml_program.global public mutable @vars.__sm_node1__w(dense<1.200000e+01> : tensor<f32>) : tensor<f32> ml_program.global public mutable @vars.__sm_node2__b(dense<7.000000e+00> : tensor<f32>) : tensor<f32> func.func @__inference_train_250(%arg0: tensor<f32>) -> tensor<f32> { %0 = ml_program.global_load @vars.__sm_node1__w : tensor<f32> %1 = stablehlo.add %0, %arg0 : tensor<f32> ml_program.global_store @vars.__sm_node1__w = %1 : tensor<f32> %2 = ml_program.global_load @vars.__sm_node1__w : tensor<f32> %3 = ml_program.global_load @vars.__sm_node2__b : tensor<f32> %4 = stablehlo.add %3, %arg0 : tensor<f32> ml_program.global_store @vars.__sm_node2__b = %4 : tensor<f32> return %2 : tensor<f32> } } ``` Note the name `__inference_train_250` rather than the expected `train`. ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59685/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59685/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59684
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59684/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59684/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59684/events
https://github.com/tensorflow/tensorflow/issues/59684
1,584,293,891
I_kwDOArmXAs5ebmgD
59,684
tflite model has bad accuracy
{ "login": "codingzebra333", "id": 112169713, "node_id": "U_kgDOBq-S8Q", "avatar_url": "https://avatars.githubusercontent.com/u/112169713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/codingzebra333", "html_url": "https://github.com/codingzebra333", "followers_url": "https://api.github.com/users/codingzebra333/followers", "following_url": "https://api.github.com/users/codingzebra333/following{/other_user}", "gists_url": "https://api.github.com/users/codingzebra333/gists{/gist_id}", "starred_url": "https://api.github.com/users/codingzebra333/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/codingzebra333/subscriptions", "organizations_url": "https://api.github.com/users/codingzebra333/orgs", "repos_url": "https://api.github.com/users/codingzebra333/repos", "events_url": "https://api.github.com/users/codingzebra333/events{/privacy}", "received_events_url": "https://api.github.com/users/codingzebra333/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1463677878, "node_id": "MDU6TGFiZWwxNDYzNjc3ODc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:performance", "name": "type:performance", "color": "159b2e", "default": false, "description": "Performance Issue" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "haozha111", "id": 6316921, "node_id": "MDQ6VXNlcjYzMTY5MjE=", "avatar_url": "https://avatars.githubusercontent.com/u/6316921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/haozha111", "html_url": "https://github.com/haozha111", "followers_url": "https://api.github.com/users/haozha111/followers", "following_url": "https://api.github.com/users/haozha111/following{/other_user}", "gists_url": "https://api.github.com/users/haozha111/gists{/gist_id}", "starred_url": "https://api.github.com/users/haozha111/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/haozha111/subscriptions", "organizations_url": "https://api.github.com/users/haozha111/orgs", "repos_url": "https://api.github.com/users/haozha111/repos", "events_url": "https://api.github.com/users/haozha111/events{/privacy}", "received_events_url": "https://api.github.com/users/haozha111/received_events", "type": "User", "site_admin": false }
[ { "login": "haozha111", "id": 6316921, "node_id": "MDQ6VXNlcjYzMTY5MjE=", "avatar_url": "https://avatars.githubusercontent.com/u/6316921?v=4", "gravatar_id": "", "url": "https://api.github.com/users/haozha111", "html_url": "https://github.com/haozha111", "followers_url": "https://api.github.com/users/haozha111/followers", "following_url": "https://api.github.com/users/haozha111/following{/other_user}", "gists_url": "https://api.github.com/users/haozha111/gists{/gist_id}", "starred_url": "https://api.github.com/users/haozha111/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/haozha111/subscriptions", "organizations_url": "https://api.github.com/users/haozha111/orgs", "repos_url": "https://api.github.com/users/haozha111/repos", "events_url": "https://api.github.com/users/haozha111/events{/privacy}", "received_events_url": "https://api.github.com/users/haozha111/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }, { "login": "pkgoogle", "id": 132095473, "node_id": "U_kgDOB9-d8Q", "avatar_url": "https://avatars.githubusercontent.com/u/132095473?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pkgoogle", "html_url": "https://github.com/pkgoogle", "followers_url": "https://api.github.com/users/pkgoogle/followers", "following_url": "https://api.github.com/users/pkgoogle/following{/other_user}", "gists_url": "https://api.github.com/users/pkgoogle/gists{/gist_id}", "starred_url": "https://api.github.com/users/pkgoogle/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pkgoogle/subscriptions", "organizations_url": "https://api.github.com/users/pkgoogle/orgs", "repos_url": "https://api.github.com/users/pkgoogle/repos", "events_url": "https://api.github.com/users/pkgoogle/events{/privacy}", "received_events_url": "https://api.github.com/users/pkgoogle/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @codingzebra333 !\r\n I tried to replicate the issue on Colab using TF v2.11 but facing a different error. Could you please provide dependencies to reproduce the issue and find the gist [here](https://colab.research.google.com/gist/tiruk007/b23c955476d80be16eed766de5ba2c8f/untitled122.ipynb) for reference.\r\n\r\nThank you!\r\n", "Hey, \r\nThank you for fast response! [ Here ](https://colab.research.google.com/drive/14zMCm0XaszVrUoWd9bMvBjSXSdPvSWuw?userstoinvite=tirumaleshk%40google.com&actionButton=1#scrollTo=t-P2l2a-9AOm) is a colab file.\r\nI also tested .h5 file and .tflite on a different dataset (400 images) and compared the results:\r\n- .tflite vs .h5 (images that are in a good quality)\r\nMAD: 1.8\r\nRMSE: 1.9\r\n- tflite vs .h5 (same images but in a bad quality)\r\nMAD: 0.3\r\nRMSE: 0.4\r\nTflite model evaluates good images and bad images pretty much in the same way. \r\n", "@pjpratik \r\n \r\nI was able to reproduce the issue on Colab using TFv2.11. please find the gist [here](https://colab.research.google.com/gist/tiruk007/bcd8c781bbe3a2ab376fdb90cd342d8d/untitled132.ipynb) for reference.\r\n\r\nThank you!", "@codingzebra333 Sorry for the delayed response. \r\n\r\nI did try to reproduce the .csv file but facing some error while creating the model. Please find the [gist](https://colab.research.google.com/gist/pjpratik/1db27191830e15d4540b2984484b0983/59684.ipynb). \r\n\r\nThe conversion seems to be fine in both the cases. Also, the error difference from what is [reported](https://github.com/tensorflow/tensorflow/issues/59684#issuecomment-1431121144), specifically for good quality images seems to be on bit higher side.\r\n\r\nThe quantization aware training is supposed to give better model accuracy than post training quantization. Please refer to [document](https://www.tensorflow.org/model_optimization/guide/quantization/training) for QAT and let us know if it helps.\r\n\r\nThanks.\r\n\r\n", "Hi, thank you for your response! \r\nIf the conversion is fine in both cases, how come the model is unusable because of the terrible accuracy? Post training quantization is supposed to reduce the model accuracy by a little - not make it unusable. Is it because of the model architecture or is there any other possible explanation to this?\r\nAlso, what other solutions would you suggest without having to re-train all models? \r\nRegarding the errors, you just need to change from \"from backbone.resnet50 import ResNet50\" to \"from triq.src.backbone.resnet50 import ResNet50\" - it can't find a model because the path is incorrect.\r\nThank you in advance!", "Hi @codingzebra333 \r\n\r\nI have tested the both tflite model and .h5 model on the sample data provided. The results are\r\n```\r\nFor 2.9 MOS\r\ntflite = 2.8592536100477446\r\n.h5= 2.906168824993074\r\n\r\nFor 2.865 MOS\r\ntflite=2.880292271496728\r\n.h5= 2.742017399519682\r\n```\r\nWhat I see is that tflite results are not bad compared to the MOS infact tflite results are closer than .h5 in second case.\r\nPlease find the gist [here](https://colab.research.google.com/gist/pjpratik/934d2e4f087fd8ac484d3faac3c72b1f/59684.ipynb). I feel it is acceptable but depends on the use case.\r\n\r\nCan you please let us know your observation regarding the same?\r\n\r\n", "Hey, as I mentioned before, I tested it out on a different dataset with 400 images - good and bad quality. I provided the MAD and RMSE scores before. Tflite model evaluates good images and bad images pretty much in the same way. \r\n[Here](https://drive.google.com/drive/folders/1YcCSJgG6R4wRJ5qeU3gUoUd2296GghoL?usp=sharing) is a dataset available for comparison. First MOS score in image name is .h5 result and second one is .tflite result. \r\n\r\n", "Hey, are there any updates regarding this? ", "Hey, is there anything new regarding this?", "Hi, is there anyone who can help me with this? ", "Hi @codingzebra333, can you please share an up to date colab which reproduces the results, including the dataset (or where I can get the dataset) mentioned here, please also include the unconverted and converted model:\r\n\r\n>I also tested .h5 file and .tflite on a different dataset (400 images) and compared the results:\r\n\r\n>.tflite vs .h5 (images that are in a good quality)\r\n>MAD: 1.8\r\n>RMSE: 1.9\r\n>tflite vs .h5 (same images but in a bad quality)\r\n>MAD: 0.3\r\n>RMSE: 0.4\r\n>Tflite model evaluates good images and bad images pretty much in the same way.\r\n\r\nThanks for helping us refresh this issue.", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59684\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59684\">No</a>\n" ]
2023-02-14T14:46:36
2023-11-03T01:48:12
2023-11-03T01:48:10
NONE
null
null
null
Hey, I used tflite converter to convert .h5 file, the model is much smaller than the original, but the accuracy dropped drastically.[ Here ](https://colab.research.google.com/drive/14zMCm0XaszVrUoWd9bMvBjSXSdPvSWuw?userstoinvite=tirumaleshk%40google.com&actionButton=1#scrollTo=JWvOm1R5WyPs )is the code. Could you please check if everything is correct? Thank you in advance!
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59684/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59684/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59683
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59683/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59683/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59683/events
https://github.com/tensorflow/tensorflow/pull/59683
1,584,221,911
PR_kwDOArmXAs5J8qd_
59,683
Refactor BitcastOp_Create and BitcastOp_Compute
{ "login": "krittapat-canik", "id": 106488173, "node_id": "U_kgDOBljhbQ", "avatar_url": "https://avatars.githubusercontent.com/u/106488173?v=4", "gravatar_id": "", "url": "https://api.github.com/users/krittapat-canik", "html_url": "https://github.com/krittapat-canik", "followers_url": "https://api.github.com/users/krittapat-canik/followers", "following_url": "https://api.github.com/users/krittapat-canik/following{/other_user}", "gists_url": "https://api.github.com/users/krittapat-canik/gists{/gist_id}", "starred_url": "https://api.github.com/users/krittapat-canik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/krittapat-canik/subscriptions", "organizations_url": "https://api.github.com/users/krittapat-canik/orgs", "repos_url": "https://api.github.com/users/krittapat-canik/repos", "events_url": "https://api.github.com/users/krittapat-canik/events{/privacy}", "received_events_url": "https://api.github.com/users/krittapat-canik/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @krittapat-canik Can you please check @cantonios's comments and keep us posted ? Thank you!", "Hi @krittapat-canik Can you please check @cantonios's comments and keep us posted ? Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "Hi @krittapat-canik Any update on this PR? Please. Thank you!", "No response from author, and I doubt this will actually save anything significant in practice." ]
2023-02-14T14:02:23
2023-06-23T15:46:17
2023-06-23T15:46:13
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59683", "html_url": "https://github.com/tensorflow/tensorflow/pull/59683", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59683.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59683.patch", "merged_at": null }
refactorings BitcastOp_Create and BitcastOp_Compute for improved memory usage and performance. For BitcastOp_Create, I've made a few changes that will help reduce memory usage. Specifically, I've used a single TF_Status object for error checking and memory allocation, which should help reduce the overall memory footprint of this function. I've also optimized the calculation of check_size, which will eliminate unnecessary computation and help reduce memory usage even further. In BitcastOp_Compute, I've reordered variable initialization to reduce the overall memory footprint. I've also replaced the std::ostringstream object used for building error messages with a char buffer. This change will make error handling more efficient and help reduce memory usage for each function call. I've tested these changes to ensure that they preserve the previous behavior and have no functional impact. Overall, I believe that these refactorings will help improve the performance and memory usage of these functions, leading to a better user experience. Thanks for taking the time to review my pull request, and I'm looking forward to your feedback!
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59683/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59683/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59682
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59682/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59682/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59682/events
https://github.com/tensorflow/tensorflow/pull/59682
1,584,013,435
PR_kwDOArmXAs5J78__
59,682
Make official Docker images smaller
{ "login": "mikolajpabiszczak", "id": 29068382, "node_id": "MDQ6VXNlcjI5MDY4Mzgy", "avatar_url": "https://avatars.githubusercontent.com/u/29068382?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mikolajpabiszczak", "html_url": "https://github.com/mikolajpabiszczak", "followers_url": "https://api.github.com/users/mikolajpabiszczak/followers", "following_url": "https://api.github.com/users/mikolajpabiszczak/following{/other_user}", "gists_url": "https://api.github.com/users/mikolajpabiszczak/gists{/gist_id}", "starred_url": "https://api.github.com/users/mikolajpabiszczak/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mikolajpabiszczak/subscriptions", "organizations_url": "https://api.github.com/users/mikolajpabiszczak/orgs", "repos_url": "https://api.github.com/users/mikolajpabiszczak/repos", "events_url": "https://api.github.com/users/mikolajpabiszczak/events{/privacy}", "received_events_url": "https://api.github.com/users/mikolajpabiszczak/received_events", "type": "User", "site_admin": false }
[ { "id": 1173072136, "node_id": "MDU6TGFiZWwxMTczMDcyMTM2", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XL", "name": "size:XL", "color": "adafea", "default": false, "description": "CL Change Size:Extra Large" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @mikolajpabiszczak Can you please resolve conflicts? Thank you!", "From what I see the Dockerfiles used to build official images were move to [tensorflow/build](https://github.com/tensorflow/build) rendering this PR as out-of-place. Closing." ]
2023-02-14T11:42:32
2023-03-22T08:57:08
2023-03-22T08:57:01
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59682", "html_url": "https://github.com/tensorflow/tensorflow/pull/59682", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59682.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59682.patch", "merged_at": null }
This PR is added as a follow-up of Issue #59293 - it updates the Dockerfiles so that they consistently use `apt-get -y clean all && rm -rf /var/lib/apt/lists/*`, `apt-get install -y --no-install-recommends`. Thus making official Docker images smaller. With this update the change in size of the Docker image is the following: - `cpu.Dockerfile`: 2.07GB -> 1.76GB - `gpu.Dockerfile`: 6.63GB -> 6.52GB (I skipped the comparison for other Dockerfiles).
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59682/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59682/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59681
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59681/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59681/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59681/events
https://github.com/tensorflow/tensorflow/pull/59681
1,583,828,018
PR_kwDOArmXAs5J7VKO
59,681
[Linaro:Neon] For Neon nr must be 4
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" }, { "id": 1178505529, "node_id": "MDU6TGFiZWwxMTc4NTA1NTI5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/prtype:bugfix", "name": "prtype:bugfix", "color": "159b2e", "default": false, "description": "PR to fix a bug" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@penpornk @cantonios " ]
2023-02-14T09:43:15
2023-03-06T09:29:11
2023-02-20T18:46:11
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59681", "html_url": "https://github.com/tensorflow/tensorflow/pull/59681", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59681.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59681.patch", "merged_at": "2023-02-20T18:46:11" }
Ensure the expected value of nr is set for Neon optimised code Fixes #59680
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59681/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59681/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59680
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59680/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59680/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59680/events
https://github.com/tensorflow/tensorflow/issues/59680
1,583,820,283
I_kwDOArmXAs5eZy37
59,680
Unit test //tensorflow/tsl/framework/convolution:spatial_convolutions_test fails to build
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "@angerson", "Introduced by https://github.com/tensorflow/tensorflow/commit/397570c85afa4dacd0a10869a1463bac8872bfd7", "Hi, @elfringham \r\n\r\nThank you for noticing the issue and I see you've submitted PR [#59681](https://github.com/tensorflow/tensorflow/pull/59681) for this issue so this issue will be taken care once PR got merged after following the PR process. I really appreciate your efforts and time. Thank you!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59680\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59680\">No</a>\n" ]
2023-02-14T09:38:18
2023-02-24T05:29:36
2023-02-20T18:46:12
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version git HEAD ### Custom Code No ### OS Platform and Distribution RHEL 8.7 ### Mobile device n/a ### Python version 3.9.13 ### Bazel version 5.3.0 ### GCC/Compiler version 10.3.0 ### CUDA/cuDNN version n/a ### GPU model and memory n/a ### Current Behaviour? ```shell When building for AARCH64 the unit test //tensorflow/tsl/framework/convolution:spatial_convolutions_test fails to build with ./tensorflow/tsl/framework/convolution/eigen_spatial_convolutions-inl.h:1490:27: error: static assertion failed: YOU_MADE_A_PROGRAMMING_MISTAKE ``` ### Standalone code to reproduce the issue ```shell bazel test --test_timeout=300,500,-1,-1 --flaky_test_attempts=3 --test_output=all --cache_test_results=no --noremote_accept_cached --config=mkl_aarch64_threadpool --copt="-mtune=generic" --copt="-march=armv8-a" --copt="-O3" --build_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-no_aarch64,-requires-gpu --test_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-no_aarch64,-requires-gpu --verbose_failures --build_tests_only -- //tensorflow/tsl/framework/convolution:spatial_convolutions_test ``` ### Relevant log output ```shell ERROR: /home/andrew/src/tensorflow/tensorflow/tsl/framework/convolution/BUILD:99:12: Compiling tensorflow/tsl/framework/convolution/eigen_spatial_convolutions_test.cc failed: (Exit 1): gcc failed: error executing command (cd /home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow && \ exec env - \ LD_LIBRARY_PATH=/opt/rh/gcc-toolset-10/root/usr/lib64:/opt/rh/gcc-toolset-10/root/usr/lib:/opt/rh/gcc-toolset-10/root/usr/lib64/dyninst:/opt/rh/gcc-toolset-10/root/usr/lib/dyninst:/opt/rh/gcc-toolset-10/root/usr/lib64:/opt/rh/gcc-toolset-10/root/usr/lib \ PATH=/home/andrew/.cache/bazelisk/downloads/bazelbuild/bazel-5.3.0-linux-arm64/bin:/home/andrew/.local/bin:/home/andrew/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin \ PWD=/proc/self/cwd \ PYTHON_BIN_PATH=/home/andrew/src/venv38/bin/python3 \ PYTHON_LIB_PATH=/home/andrew/src/venv38/lib/python3.8/site-packages \ TF2_BEHAVIOR=1 \ /opt/rh/gcc-toolset-10/root/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-std=c++0x' -MD -MF bazel-out/aarch64-opt/bin/tensorflow/tsl/framework/convolution/_objs/spatial_convolutions_test/eigen_spatial_convolutions_test.d '-frandom-seed=bazel-out/aarch64-opt/bin/tensorflow/tsl/framework/convolution/_objs/spatial_convolutions_test/eigen_spatial_convolutions_test.o' -DEIGEN_MPL2_ONLY '-DEIGEN_MAX_ALIGN_BYTES=64' -DTENSORFLOW_USE_CUSTOM_CONTRACTION_KERNEL -DGEMM_KERNEL_H '-DEIGEN_ALTIVEC_USE_CUSTOM_PACK=0' '-DEIGEN_NEON_GEBP_NR=4' -iquote . -iquote bazel-out/aarch64-opt/bin -iquote external/com_google_absl -iquote bazel-out/aarch64-opt/bin/external/com_google_absl -iquote external/eigen_archive -iquote bazel-out/aarch64-opt/bin/external/eigen_archive -iquote external/nsync -iquote bazel-out/aarch64-opt/bin/external/nsync -iquote external/double_conversion -iquote bazel-out/aarch64-opt/bin/external/double_conversion -iquote external/com_google_googletest -iquote bazel-out/aarch64-opt/bin/external/com_google_googletest -iquote external/com_google_benchmark -iquote bazel-out/aarch64-opt/bin/external/com_google_benchmark -iquote external/com_google_protobuf -iquote bazel-out/aarch64-opt/bin/external/com_google_protobuf -iquote external/zlib -iquote bazel-out/aarch64-opt/bin/external/zlib -iquote external/bazel_tools -iquote bazel-out/aarch64-opt/bin/external/bazel_tools -Ibazel-out/aarch64-opt/bin/external/com_google_benchmark/_virtual_includes/benchmark -isystem third_party/eigen3/mkl_include -isystem bazel-out/aarch64-opt/bin/third_party/eigen3/mkl_include -isystem external/eigen_archive -isystem bazel-out/aarch64-opt/bin/external/eigen_archive -isystem external/nsync/public -isystem bazel-out/aarch64-opt/bin/external/nsync/public -isystem external/com_google_googletest/googlemock -isystem bazel-out/aarch64-opt/bin/external/com_google_googletest/googlemock -isystem external/com_google_googletest/googlemock/include -isystem bazel-out/aarch64-opt/bin/external/com_google_googletest/googlemock/include -isystem external/com_google_googletest/googletest -isystem bazel-out/aarch64-opt/bin/external/com_google_googletest/googletest -isystem external/com_google_googletest/googletest/include -isystem bazel-out/aarch64-opt/bin/external/com_google_googletest/googletest/include -isystem external/com_google_protobuf/src -isystem bazel-out/aarch64-opt/bin/external/com_google_protobuf/src -isystem external/zlib -isystem bazel-out/aarch64-opt/bin/external/zlib -Wno-all -Wno-extra -Wno-deprecated -Wno-deprecated-declarations -Wno-ignored-attributes -Wno-array-bounds -Wunused-result '-Werror=unused-result' -Wswitch '-Werror=switch' '-Wno-error=unused-but-set-variable' -DAUTOLOAD_DYNAMIC_KERNELS '-mtune=generic' '-march=armv8-a' -O3 '-std=c++17' -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c tensorflow/tsl/framework/convolution/eigen_spatial_convolutions_test.cc -o bazel-out/aarch64-opt/bin/tensorflow/tsl/framework/convolution/_objs/spatial_convolutions_test/eigen_spatial_convolutions_test.o) # Configuration: 67e3477bbfd3aa6df692c90e4aaaf7a6ee0f55b121a5556fe852592ce2c633e2 # Execution platform: @local_execution_config_platform//:platform In file included from external/eigen_archive/unsupported/Eigen/CXX11/../../../Eigen/Core:162, from external/eigen_archive/unsupported/Eigen/CXX11/Tensor:14, from ./third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1, from ./tensorflow/tsl/framework/convolution/eigen_spatial_convolutions.h:19, from tensorflow/tsl/framework/convolution/eigen_spatial_convolutions_test.cc:16: ./tensorflow/tsl/framework/convolution/eigen_spatial_convolutions-inl.h: In instantiation of 'struct Eigen::internal::gemm_pack_rhs<Eigen::QInt8, long int, Eigen::internal::TensorContractionSubMapper<Eigen::QInt8, long int, 0, Eigen::TensorEvaluator<const Eigen::TensorReshapingOp<Eigen::DSizes<long int, 2>, const Eigen::TensorImagePatchOp<-1, -1, Eigen::TensorMap<Eigen::Tensor<Eigen::QInt8, 4, 0, long int>, 16, Eigen::MakePointer> > >, Eigen::DefaultDevice>, std::array<long int, 1>, std::array<long int, 1>, 1, true, false, 0, Eigen::MakePointer>, 1, 0, false, false>': tensorflow/tsl/framework/convolution/eigen_spatial_convolutions_test.cc:924:15: required from 'void Eigen::PackRhsHelper(benchmark::State&, int, int, int, int, int, int, int, Eigen::PaddingType, int, int, int, int, Eigen::Index, Eigen::Index) [with T = Eigen::QInt8; Eigen::Index = long int]' tensorflow/tsl/framework/convolution/eigen_spatial_convolutions_test.cc:1375:1: required from here ./tensorflow/tsl/framework/convolution/eigen_spatial_convolutions-inl.h:1490:27: error: static assertion failed: YOU_MADE_A_PROGRAMMING_MISTAKE 1490 | EIGEN_STATIC_ASSERT((nr == 4), YOU_MADE_A_PROGRAMMING_MISTAKE) | ~~~~^~~~~ Target //tensorflow/tsl/framework/convolution:spatial_convolutions_test failed to build INFO: Elapsed time: 9.629s, Critical Path: 9.11s INFO: 3 processes: 2 internal, 1 local. FAILED: Build did NOT complete successfully //tensorflow/tsl/framework/convolution:spatial_convolutions_test FAILED TO BUILD FAILED: Build did NOT complete successfully ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59680/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59680/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59679
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59679/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59679/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59679/events
https://github.com/tensorflow/tensorflow/issues/59679
1,583,725,301
I_kwDOArmXAs5eZbr1
59,679
pruned pretrained mobilenet_v1_1.0_224, mode.fit() error
{ "login": "PPParticle", "id": 61463025, "node_id": "MDQ6VXNlcjYxNDYzMDI1", "avatar_url": "https://avatars.githubusercontent.com/u/61463025?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PPParticle", "html_url": "https://github.com/PPParticle", "followers_url": "https://api.github.com/users/PPParticle/followers", "following_url": "https://api.github.com/users/PPParticle/following{/other_user}", "gists_url": "https://api.github.com/users/PPParticle/gists{/gist_id}", "starred_url": "https://api.github.com/users/PPParticle/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PPParticle/subscriptions", "organizations_url": "https://api.github.com/users/PPParticle/orgs", "repos_url": "https://api.github.com/users/PPParticle/repos", "events_url": "https://api.github.com/users/PPParticle/events{/privacy}", "received_events_url": "https://api.github.com/users/PPParticle/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 2671351731, "node_id": "MDU6TGFiZWwyNjcxMzUxNzMx", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ModelOptimizationToolkit", "name": "ModelOptimizationToolkit", "color": "BFD629", "default": false, "description": "TF Model Optimization Toolkit" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "@PPParticle Thanks for reporting the issue.\r\n\r\nSorry for the delayed response.\r\n\r\nAs per the documentation, [prune_low_magnitude](https://www.tensorflow.org/model_optimization/api_docs/python/tfmot/sparsity/keras/prune_low_magnitude) expects pruning schedule, but a dictionary of pruning schedule is given which can be resolved by either directly passing pruing schedule or getting pruning schedule from dictionary. Also, the callbacks are not called during pruned `model.fit`. \r\n\r\nPlease find the working [gist](https://colab.research.google.com/gist/pjpratik/3b25bca188e4b09526addf1418c197b0/59679.ipynb) and let us know if it helps.\r\n\r\nThe weights are not loaded as they are not provided.\r\n\r\nThanks!", "> \r\nThanks so much for your reply which has solved my problems !! However, I haven't figure out the reason why there are still so many non-trainable parameters after `model.fit()` with `model_for_pruning.summary()`. Maybe I should look up TF guidebook! All in all, thank you so much again !!", "@PPParticle Please feel free to close the issue if it is resolved. Thanks!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59679\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59679\">No</a>\n" ]
2023-02-14T08:33:31
2023-02-17T01:34:54
2023-02-17T01:34:52
NONE
null
null
null
### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version v2.11.0 ### Custom Code No ### OS Platform and Distribution WSL2 Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version python 3.8.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell A bug happened! I wanted to prun pretrained mobilenet_v1 with model_weight mobilenet_1_0_224. After I pruned the pretrained model and start to retrain pruned_model, something was wrong. ``` ### Standalone code to reproduce the issue ```shell This is code from matplotlib import pyplot as plt import tensorflow_model_optimization as tfmot import numpy as np import os import tensorflow as tf from tensorflow import keras import tensorflow_datasets as tfds import tensorflow_model_optimization as tfmot import tempfile _URL = 'https://storage.googleapis.com/mledu-datasets/cats_and_dogs_filtered.zip' path_to_zip = tf.keras.utils.get_file('cats_and_dogs.zip', origin=_URL, extract=True) PATH = os.path.join(os.path.dirname(path_to_zip), 'cats_and_dogs_filtered') train_path = os.path.join(PATH, 'train') validation_path = os.path.join(PATH, 'validation') IMG_SIZE = (224, 224) train_dataset = tf.keras.utils.image_dataset_from_directory(train_path, shuffle=True, image_size=IMG_SIZE) validation_dataset = tf.keras.utils.image_dataset_from_directory(validation_path, shuffle=True, image_size=IMG_SIZE) val_batches = tf.data.experimental.cardinality(validation_dataset) # check data number of one batch test_dataset = validation_dataset.take(val_batches // 5) val_dataset = validation_dataset.skip(val_batches // 5) num_images = tf.data.experimental.cardinality(test_dataset) end_step = np.ceil(num_images / 32).astype(np.int32) * 2 # load base model and freeze the base model model = tf.keras.applications.MobileNet() model.load_weights(r'/home/user/.keras/models/mobilenet_1_0_224_tf.h5') model.compile(optimizer='adam', loss=tf.keras.losses.SparseCategoricalCrossentropy(from_logits=True), metrics=['accuracy']) model.fit(test_dataset, epochs=2, validation_data=val_dataset) _, keras_file = tempfile.mkstemp('.h5') tf.keras.models.save_model(model, keras_file, include_optimizer=False) print('Saved baseline model to:', keras_file) model.save("mobilenet_no_pruning.h5") # loss, accuracy = model.evaluate(validation_dataset) # # model_for_pruning.summary() # trainable parameters + non-trainable mask parameters # print("initial loss: {:.2f}".format(loss)) # print("initial accuracy: {:.2f}".format(accuracy)) # model applied pruning pruning_schedule = { 'pruning_schedule': tfmot.sparsity.keras.PolynomialDecay(0.5,0.9,begin_step=0, end_step=end_step) } model_for_pruning = tfmot.sparsity.keras.prune_low_magnitude(model, pruning_schedule=pruning_schedule) # create a new model model_for_pruning.compile(optimizer='adam', loss=tf.keras.losses.SparseCategoricalCrossentropy(from_logits=True), metrics=['accuracy']) logdir = tempfile.mkdtemp() callbacks = [ tfmot.sparsity.keras.UpdatePruningStep(), # pruning parameters tfmot.sparsity.keras.PruningSummaries(log_dir=logdir), ] print("begin fit") # model_for_pruning.fit(test_dataset, batch_size=32, epochs=2, validation_data=val_dataset, callbacks=callbacks) model_for_pruning.fit(test_dataset, batch_size=32, epochs=2, validation_data=val_dataset) loss, accuracy = model_for_pruning.evaluate(validation_dataset) # # model_for_pruning.summary() # trainable parameters + non-trainable mask parameters print("initial loss: {:.2f}".format(loss)) print("initial accuracy: {:.2f}".format(accuracy)) ``` ``` ### Relevant log output The pretrained mode traing is as usual. The errors happens retrained pruned model. The errors are ```shell Found 2000 files belonging to 2 classes. Found 1000 files belonging to 2 classes. Epoch 1/2 /usr/local/lib/python3.8/dist-packages/keras/backend.py:5585: UserWarning: "`sparse_categorical_crossentropy` received `from_logits=True`, but the `output` argument was produced by a Softmax activation and thus does not represent logits. Was this intended? output, from_logits = _get_logits( 6/6 [==============================] - 26s 4s/step - loss: 4.2002 - accuracy: 0.5365 - val_loss: 28.3055 - val_accuracy: 0.0000e+00 Epoch 2/2 6/6 [==============================] - 19s 3s/step - loss: 0.3738 - accuracy: 0.9479 - val_loss: 21.0645 - val_accuracy: 0.0223 Saved baseline model to: /tmp/tmp68woeyxc.h5 WARNING:tensorflow:From /home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow/python/autograph/pyct/static_analysis/liveness.py:83: Analyzer.lamba_check (from tensorflow.python.autograph.pyct.static_analysis.liveness) is deprecated and will be removed after 2023-09-23. Instructions for updating: Lambda fuctions will be no more assumed to be used in the statement where they are used, or at least in the same block. https://github.com/tensorflow/tensorflow/issues/56089 begin fit Epoch 1/2 Traceback (most recent call last): File "fine-tune_mobilenet_v1_with_pruning.py", line 85, in <module> model_for_pruning.fit(test_dataset, batch_size=32, epochs=2, validation_data=val_dataset) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 70, in error_handler raise e.with_traceback(filtered_tb) from None File "/tmp/__autograph_generated_filefab8qmeh.py", line 15, in tf__train_function retval_ = ag__.converted_call(ag__.ld(step_function), (ag__.ld(self), ag__.ld(iterator)), None, fscope) File "/tmp/__autograph_generated_filerwugbiee.py", line 71, in tf__call update_mask = ag__.converted_call(ag__.ld(utils).smart_cond, (ag__.ld(training), ag__.ld(add_update), ag__.ld(no_op)), None, fscope) File "/tmp/__autograph_generated_filepmfh1utc.py", line 37, in tf__smart_cond ag__.if_stmt(ag__.converted_call(ag__.ld(isinstance), (ag__.ld(pred), ag__.ld(variables).Variable), None, fscope), if_body, else_body, get_state, set_state, ('do_return', 'retval_'), 2) File "/tmp/__autograph_generated_filepmfh1utc.py", line 33, in else_body retval_ = ag__.converted_call(ag__.ld(smart_module).smart_cond, (ag__.ld(pred),), dict(true_fn=ag__.ld(true_fn), false_fn=ag__.ld(false_fn), name=ag__.ld(name)), fscope) File "/tmp/__autograph_generated_filerwugbiee.py", line 48, in add_update with ag__.ld(tf).control_dependencies([ag__.ld(self).pruning_obj.conditional_mask_update()]): File "/home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow_model_optimization/python/core/sparsity/keras/pruning_impl.py", line 310, in conditional_mask_update return tf.distribute.get_replica_context().merge_call( File "/tmp/__autograph_generated_filepd0d14ah.py", line 63, in tf__mask_update_distributed retval_ = ag__.converted_call(ag__.ld(tf).cond, (ag__.converted_call(ag__.ld(maybe_update_masks), (), None, fscope), ag__.ld(update_distributed), ag__.ld(no_update)), None, fscope) File "/tmp/__autograph_generated_file1681ktv2.py", line 37, in tf__maybe_update_masks ag__.if_stmt(ag__.ld(self)._sparsity_m_by_n, if_body, else_body, get_state, set_state, ('do_return', 'retval_'), 2) File "/tmp/__autograph_generated_file1681ktv2.py", line 33, in else_body retval_ = ag__.converted_call(ag__.ld(self)._pruning_schedule, (ag__.converted_call(ag__.ld(self)._step_fn, (), None, fscope),), None, fscope)[0] TypeError: in user code: File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1249, in train_function * return step_function(self, iterator) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1233, in step_function ** outputs = model.distribute_strategy.run(run_step, args=(data,)) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1222, in run_step ** outputs = model.train_step(data) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1023, in train_step y_pred = self(x, training=True) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 70, in error_handler raise e.with_traceback(filtered_tb) from None File "/tmp/__autograph_generated_filerwugbiee.py", line 71, in tf__call update_mask = ag__.converted_call(ag__.ld(utils).smart_cond, (ag__.ld(training), ag__.ld(add_update), ag__.ld(no_op)), None, fscope) File "/tmp/__autograph_generated_filepmfh1utc.py", line 37, in tf__smart_cond ag__.if_stmt(ag__.converted_call(ag__.ld(isinstance), (ag__.ld(pred), ag__.ld(variables).Variable), None, fscope), if_body, else_body, get_state, set_state, ('do_return', 'retval_'), 2) File "/tmp/__autograph_generated_filepmfh1utc.py", line 33, in else_body retval_ = ag__.converted_call(ag__.ld(smart_module).smart_cond, (ag__.ld(pred),), dict(true_fn=ag__.ld(true_fn), false_fn=ag__.ld(false_fn), name=ag__.ld(name)), fscope) File "/tmp/__autograph_generated_filerwugbiee.py", line 48, in add_update with ag__.ld(tf).control_dependencies([ag__.ld(self).pruning_obj.conditional_mask_update()]): File "/home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow_model_optimization/python/core/sparsity/keras/pruning_impl.py", line 310, in conditional_mask_update return tf.distribute.get_replica_context().merge_call( File "/tmp/__autograph_generated_filepd0d14ah.py", line 63, in tf__mask_update_distributed retval_ = ag__.converted_call(ag__.ld(tf).cond, (ag__.converted_call(ag__.ld(maybe_update_masks), (), None, fscope), ag__.ld(update_distributed), ag__.ld(no_update)), None, fscope) File "/tmp/__autograph_generated_file1681ktv2.py", line 37, in tf__maybe_update_masks ag__.if_stmt(ag__.ld(self)._sparsity_m_by_n, if_body, else_body, get_state, set_state, ('do_return', 'retval_'), 2) File "/tmp/__autograph_generated_file1681ktv2.py", line 33, in else_body retval_ = ag__.converted_call(ag__.ld(self)._pruning_schedule, (ag__.converted_call(ag__.ld(self)._step_fn, (), None, fscope),), None, fscope)[0] TypeError: Exception encountered when calling layer 'prune_low_magnitude_conv1' (type PruneLowMagnitude). in user code: File "/home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow_model_optimization/python/core/sparsity/keras/pruning_wrapper.py", line 268, in add_update * with tf.control_dependencies( File "/home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow_model_optimization/python/core/keras/utils.py", line 54, in smart_cond * pred, true_fn=true_fn, false_fn=false_fn, name=name) File "/home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow_model_optimization/python/core/sparsity/keras/pruning_impl.py", line 307, in mask_update_distributed * return tf.cond(maybe_update_masks(), update_distributed, no_update) File "/home/qiao_sh_pudong/.local/lib/python3.8/site-packages/tensorflow_model_optimization/python/core/sparsity/keras/pruning_impl.py", line 264, in maybe_update_masks * return self._pruning_schedule(self._step_fn())[0] TypeError: '_DictWrapper' object is not callable Call arguments received by layer 'prune_low_magnitude_conv1' (type PruneLowMagnitude): • inputs=tf.Tensor(shape=(None, 224, 224, 3), dtype=float32) • training=True • kwargs=<class 'inspect._empty'> ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59679/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59679/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59678
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59678/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59678/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59678/events
https://github.com/tensorflow/tensorflow/issues/59678
1,583,638,578
I_kwDOArmXAs5eZGgy
59,678
Stateless dropout broken on mixed_float16 with XLA
{ "login": "AndreasMadsen", "id": 505333, "node_id": "MDQ6VXNlcjUwNTMzMw==", "avatar_url": "https://avatars.githubusercontent.com/u/505333?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AndreasMadsen", "html_url": "https://github.com/AndreasMadsen", "followers_url": "https://api.github.com/users/AndreasMadsen/followers", "following_url": "https://api.github.com/users/AndreasMadsen/following{/other_user}", "gists_url": "https://api.github.com/users/AndreasMadsen/gists{/gist_id}", "starred_url": "https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AndreasMadsen/subscriptions", "organizations_url": "https://api.github.com/users/AndreasMadsen/orgs", "repos_url": "https://api.github.com/users/AndreasMadsen/repos", "events_url": "https://api.github.com/users/AndreasMadsen/events{/privacy}", "received_events_url": "https://api.github.com/users/AndreasMadsen/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Note, the experimental API is not required to reproduce the bug. Just use `force_generator=True` instead.\r\n\r\n```py\r\nimport tensorflow as tf\r\n\r\ntf.keras.mixed_precision.set_global_policy('mixed_float16')\r\n\r\ndropout = tf.keras.layers.Dropout(rate=0.5, force_generator=True)\r\n\r\[email protected](jit_compile=True)\r\ndef run(x):\r\n return dropout(x, training=True)\r\n\r\nprint(run(tf.constant([0.1, 0.2], dtype=tf.dtypes.float32)))\r\n```", "Hi, @AndreasMadsen \r\n\r\nApologize for the delay and I was able to replicate the same issue with `tf-nightly-2.13.0-dev20230216` and `Tensorflow==2.11`, for your reference I have added [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/039b9344253d44c324ee07ccceffb2cf/-59678-tf-nightly.ipynb) but when I tried the same code with Pre Release `tensorflow 2.12.0rc0` and it seems like working fine as expected, for your reference I have added [gist-file-tensorflow-2.12.0rc0\r\n](https://colab.research.google.com/gist/gaikwadrahul8/2448d5ff89748bbbf87f8911ca8ce38f/-59678-tensorflow-2-12-0rc0.ipynb) so Could you please try with `tensorflow 2.12.0rc0` from your end and please let us know whether is it working fine or not ?\r\n\r\nIf issue still persists please let us know ? or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!", "@gaikwadrahul8 Hi, I can confirm that `2.12.0rc0` works using the docker image on a V100 GPU. Actually running `2.12.0rc0` on our typical system will require some more work as the CUDA and CuDNN have now changed. I have issued an update request to fully check this.\r\n\r\n\r\nAlso, before closing this issue, I would like clarification as to how this works on `2.12.0.rc0` but not the nightly version. The changelog does not appear to mention that float16 support was added to XLA StatelessUniform. \r\n\r\nFinally, I suggest checking that there is no issue `mixed_bfloat16` too.", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "@google-ml-butler The stalling is not my responsibility and I don't see a reason why this issue should be closed. Maybe you can remove the `stat:awaiting response` label to avoid confusion.", "Hi, @AndreasMadsen \r\n\r\nI'm really sorry, The **google-ml-butler** bot is not working as expected and our team is working on it, I'll remove **stalled** and **stat:awaiting response** labels manually now. Thank you!", "Hi, @AndreasMadsen \r\n\r\nI was able to replicate the same issue with `tf-nightly` and `tensorflow==2.12.0rc0` and It seems like, it's working as expected and in new release of `TF2.12 `this issue will be resolved, for your reference I have added [gist-file ](https://colab.research.google.com/gist/gaikwadrahul8/696769f161928a97c4272729e86e84fa/-59678-test.ipynb). Thank you!", "@gaikwadrahul8 Sorry, you were able to replicate the issue `tf-nightly` and `tensorflow==2.12.0rc0`? How is that \"working as expected\"?\r\n\r\nThe desired result is that you can **not** replicate the issue on `tf-nightly` and `2.12rcX`. Maybe that is what you meant.\r\n\r\nGreat to hear that it will be fixed on 2.12. I'm just confused about the first comment.", "Hi, @AndreasMadsen \r\n\r\nApologize for the delay and I have tested the same code with `tf-nightly `and `tensorflow==2.12.0rc0` and It seems like it's working as expected(without any erros) for your reference here is [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/696769f161928a97c4272729e86e84fa/-59678-test.ipynb) so you can use either `tf-nightly` or `tensorflow==2.12.0rc0` at the moment and we don't support all the `ops` with XLA at the moment, our developer team is working on it and it's in progress so your issue will be fixed in upcoming stable version `TF2.12 `. \r\n\r\nIf issue still persists with `tf-nightly` or `tensorflow==2.12.0rc0` please let us know or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!", "Thanks for the help, I truly appreciate it.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59678\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59678\">No</a>\n" ]
2023-02-14T07:23:09
2023-03-07T16:34:59
2023-03-07T16:34:37
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.13.0.dev20230213 ### Custom Code Yes ### OS Platform and Distribution Colab ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? Stateless/stateful (not legacy) dropout fails with `mixed_float16` and XLA, because the stateless-uniform-random operation does not exist for half types. Note that without Stateless/stateful (not legacy) dropout, a warning is generated saying that seeds are not respected. The error reproduces consistently on Colab, with TF 2.11 and the latest nightly. ### Standalone code to reproduce the issue ```py import tensorflow as tf tf.keras.mixed_precision.set_global_policy('mixed_float16') tf.keras.backend.experimental.enable_tf_random_generator() dropout = tf.keras.layers.Dropout(rate=0.5) @tf.function(jit_compile=True) def run(x): return dropout(x, training=True) print(run(tf.constant([0.1, 0.2], dtype=tf.dtypes.float32))) ``` https://colab.research.google.com/drive/1F9V0ayyNIpbIQcjjtk7IN6w3EQai5Fk9?usp=sharing ### Relevant log output ```shell nvalidArgumentError: Detected unsupported operations when trying to compile graph __inference_run_448[_XlaMustCompile=true,config_proto=3175580994766145631,executor_type=11160318154034397263] on XLA_CPU_JIT: StatelessRandomUniformV2 (No registered 'StatelessRandomUniformV2' OpKernel for XLA_CPU_JIT devices compatible with node {{node dropout_3/stateless_dropout/stateless_random_uniform/StatelessRandomUniformV2}} (OpKernel was found, but attributes didn't match) Requested Attributes: Tshape=DT_INT32, dtype=DT_HALF){{node dropout_3/stateless_dropout/stateless_random_uniform/StatelessRandomUniformV2}} The op is created at: File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/usr/local/lib/python3.8/dist-packages/ipykernel_launcher.py", line 16, in <module> app.launch_new_instance() File "/usr/local/lib/python3.8/dist-packages/traitlets/config/application.py", line 992, in launch_instance app.start() File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelapp.py", line 612, in start self.io_loop.start() File "/usr/local/lib/python3.8/dist-packages/tornado/platform/asyncio.py", line 149, in start self.asyncio_loop.run_forever() File "/usr/lib/python3.8/asyncio/base_events.py", line 570, in run_forever self._run_once() File "/usr/lib/python3.8/asyncio/base_events.py", line 1859, in _run_once handle._run() File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run self._context.run(self._callback, *self._args) File "/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py", line 690, in <lambda> lambda f: self._run_callback(functools.partial(callback, future)) File "/usr/local/lib/python3.8/dist-packages/tornado/ioloop.py", line 743, in _run_callback ret = callback() File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 787, in inner self.run() File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 748, in run yielded = self.gen.send(value) File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 365, in process_one yield gen.maybe_future(dispatch(*args)) File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper yielded = next(result) File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 268, in dispatch_shell yield gen.maybe_future(handler(stream, idents, msg)) File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper yielded = next(result) File "/usr/local/lib/python3.8/dist-packages/ipykernel/kernelbase.py", line 543, in execute_request self.do_execute( File "/usr/local/lib/python3.8/dist-packages/tornado/gen.py", line 209, in wrapper yielded = next(result) File "/usr/local/lib/python3.8/dist-packages/ipykernel/ipkernel.py", line 306, in do_execute res = shell.run_cell(code, store_history=store_history, silent=silent) File "/usr/local/lib/python3.8/dist-packages/ipykernel/zmqshell.py", line 536, in run_cell return super(ZMQInteractiveShell, self).run_cell(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 2854, in run_cell result = self._run_cell( File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 2881, in _run_cell return runner(coro) File "/usr/local/lib/python3.8/dist-packages/IPython/core/async_helpers.py", line 68, in _pseudo_sync_runner coro.send(None) File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3057, in run_cell_async has_raised = await self.run_ast_nodes(code_ast.body, cell_name, File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3249, in run_ast_nodes if (await self.run_code(code, result, async_=asy)): File "/usr/local/lib/python3.8/dist-packages/IPython/core/interactiveshell.py", line 3326, in run_code exec(code_obj, self.user_global_ns, self.user_ns) File "<ipython-input-14-7ae9614dfdd0>", line 11, in <module> print(run(tf.constant([0.1, 0.2], dtype=tf.dtypes.float32))) File "<ipython-input-11-7ae9614dfdd0>", line 9, in run return dropout(x, training=True) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/engine/base_layer.py", line 1132, in __call__ _name_scope_unnester(self._name_scope_on_declaration) File "/usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py", line 96, in error_handler return fn(*args, **kwargs) File "/usr/local/lib/python3.8/dist-packages/keras/layers/regularization/dropout.py", line 120, in call output = control_flow_util.smart_cond( File "/usr/local/lib/python3.8/dist-packages/keras/utils/control_flow_util.py", line 108, in smart_cond return tf.__internal__.smart_cond.smart_cond( File "/usr/local/lib/python3.8/dist-packages/keras/layers/regularization/dropout.py", line 116, in dropped_inputs return self._random_generator.dropout( File "/usr/local/lib/python3.8/dist-packages/keras/backend.py", line 2156, in dropout if self._rng_type == self.RNG_STATEFUL: [Op:__inference_run_448] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59678/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59678/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59677
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59677/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59677/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59677/events
https://github.com/tensorflow/tensorflow/issues/59677
1,583,538,689
I_kwDOArmXAs5eYuIB
59,677
Super Slow Performance (tf.function fails) of GradientTape with LSTM and Manual Training Loop
{ "login": "kasrash", "id": 75144521, "node_id": "MDQ6VXNlcjc1MTQ0NTIx", "avatar_url": "https://avatars.githubusercontent.com/u/75144521?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kasrash", "html_url": "https://github.com/kasrash", "followers_url": "https://api.github.com/users/kasrash/followers", "following_url": "https://api.github.com/users/kasrash/following{/other_user}", "gists_url": "https://api.github.com/users/kasrash/gists{/gist_id}", "starred_url": "https://api.github.com/users/kasrash/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kasrash/subscriptions", "organizations_url": "https://api.github.com/users/kasrash/orgs", "repos_url": "https://api.github.com/users/kasrash/repos", "events_url": "https://api.github.com/users/kasrash/events{/privacy}", "received_events_url": "https://api.github.com/users/kasrash/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 2691123225, "node_id": "MDU6TGFiZWwyNjkxMTIzMjI1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:tf.function", "name": "comp:tf.function", "color": "0052cc", "default": false, "description": "tf.function related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "@kasrash \r\nI tried to replicate the issue on Colab using TF v2.11 but facing a different problem. Please find the gist [here](https://colab.research.google.com/gist/tiruk007/b415002491a70d80b4181d00aeef3369/untitled123.ipynb) for reference.\r\nCould you please provide all dependencies to replicate the issue reported here ?\r\n\r\nThank you!", "> @kasrash I tried to replicate the issue on Colab using TF v2.11 but facing a different problem. Please find the gist [here](https://colab.research.google.com/gist/tiruk007/b415002491a70d80b4181d00aeef3369/untitled123.ipynb) for reference. Could you please provide all dependencies to replicate the issue reported here ?\r\n> \r\n> Thank you!\r\n\r\nHi Tiruk007,\r\n\r\nThank you for checking this. I created a gist at [here](https://colab.research.google.com/gist/kasrash/5ad0b2e8df48b288c82d98be7b59803b/tferrorreplicate.ipynb), and you can download the required data [here](https://drive.google.com/drive/folders/1IG5q0U1xCqVjpC_35F4j0uER5rackoNK?usp=share_link). However, I had to reduce the model size so that it won't run out of Ram. As you can see the issue is not created in the Colab. I am not sure if some of the outputs are suppressed there or there is an issue with my TF installation. I would be grateful to know your thoughts.\r\n", "@kasrash \r\nSorry for the late reply. I tried to execute the given code on a Linux machine using 2.11 where I got 6.47 seconds for each step. Please find the [screenshot](https://user-images.githubusercontent.com/111861663/219692401-c6e1b83e-b0c4-4a9c-a845-7af47412d5f0.png) for reference.Could you please make sure to check the tested build configuration as mentioned [here](https://www.tensorflow.org/install/source#tested_build_configurations) and use the latest TF version.\r\n\r\nThank you !\r\n\r\n", "> @kasrash Sorry for the late reply. I tried to execute the given code on a Linux machine using 2.11 where I got 6.47 seconds for each step. Please find the [screenshot](https://user-images.githubusercontent.com/111861663/219692401-c6e1b83e-b0c4-4a9c-a845-7af47412d5f0.png) for reference.Could you please make sure to check the tested build configuration as mentioned [here](https://www.tensorflow.org/install/source#tested_build_configurations) and use the latest TF version.\r\n> \r\n> Thank you !\r\n\r\n@tiruk007 hi\r\n\r\nThank you so much for testing this. I see that your not getting the same error as I am getting. I will check my installation, but I installed TF 2.11 using pip and the installation guide on the website. Nevertheless, don't you thin that 6.47 s for this toy example is too high? Since this is almost the same logic as model.fit() and that takes around ms to complete each step. Is there any way to speed up this process?", "Hello,\r\nJust an update on this, I tried the code and a MNIST toy model on several machines (Windows and Ubuntu) with different versions of TF (2.9 and 2.11) all give the same error.\r\n\r\nChanging the activation from tanh to sigmoid or relu solves the issue, and the performance is blazing fast. Of course CuDNN will not be utilized.\r\n\r\nHope it helps in solving this issue and I would be grateful to know your inputs.", "Also, [here](https://colab.research.google.com/gist/kasrash/ba04bd4f82e3de6423d67f828083f03b/untitled2.ipynb) is a gist of toy MNIST model. If you go to Runtime->Runtime log you can see the error.", "Hi, @kasrash \r\n\r\nI have tried to execute the same code from gist-file of toy MNIST model with `tanh` activation function and it's working as expected here is [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/09be3a67beeb4957871cefb232efb964/-59677-test.ipynb) and even I checked the runtime error log in that all I'm getting warning messages as far I know we can ignore those warnings messages unless and until the code is running as expected and giving the correct result. You can refer [stack overflow answers ](https://stackoverflow.com/questions/35911252/disable-tensorflow-debugging-information)which also supports \r\n\r\nIf you're looking to disable `absl INFO and WARNING log messages `please use below code snippet:\r\n\r\n```\r\nimport absl.logging\r\nabsl.logging.set_verbosity(absl.logging.ERROR)\r\n\r\n```\r\nHere is screenshot of Google Colab runtime error log :\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/220887073-3eb045e8-c95e-4fb8-a0c0-9517c9ab3abb.png)\r\n\r\n\r\nIf I've missed something here please let me know ? Just to confirm, May I know your initial issue slow performance with tf.fuction got resolved or not or do you still need help with that issue please ? Thank you!\r\n", "Hi @gaikwadrahul8,\r\n\r\nThat is true that it is a warning, but when I searched for this message on Google, I found several bug reports here dating back to 2019 and 2020, which TF team confirmed that it was actually a bug. Also, with \"tanh\" activation on my main code, the TF GradiantTape Jacobian (decorated with tf.function) calculation takes ~13 s, but when changing it to relu or sigmoid activations, it only takes ~0.9 s when decorated with tf.function and ~15 s without tf.function. So, I am guessing definitely something (maybe odd )is happening when tanh activation is used as it should be faster since it use CuDNN kernel.\r\n\r\nI would be grateful to know your thoughts on this, and many thanks for your time.", "Hi, @kasrash \r\n\r\nThank you for your detailed observations and if possible could you please help us with issues number which we considered warnings as bug back to 2019 and 2020 ?\r\n\r\nIf you're using `tf.function`,the behavior of `tf.function `when `AutoGraph `is used by default `AutoGraph==True `and `@tf.function` decorated function behaves as we expect if we use a `tf.Tensor `as input type (please use `tf.Tensor `everywhere!) and if the input is a Python native type creates a new graph. You can refer this [stack overflow answer](https://stackoverflow.com/questions/55711115/tensorflow-2-0-model-using-tf-function-very-slow-and-is-recompiling-every-time-t) and also refer these useful article links [Ref-1](https://pgaleone.eu/tensorflow/tf.function/2019/04/03/dissecting-tf-function-part-2/#using-a-python-native-type), [Ref-2](https://pgaleone.eu/tensorflow/tf.function/2019/05/10/dissecting-tf-function-part-3/), I hope it will help you to resolve your issue. Thank you!\r\n\r\n", "> Hi, @kasrash\r\n> \r\n> Thank you for your detailed observations and if possible could you please help us with issues number which we considered warnings as bug back to 2019 and 2020 ?\r\n> \r\n> If you're using `tf.function`,the behavior of `tf.function `when `AutoGraph `is used by default `AutoGraph==True `and `@tf.function` decorated function behaves as we expect if we use a `tf.Tensor `as input type (please use `tf.Tensor `everywhere!) and if the input is a Python native type creates a new graph. You can refer this [stack overflow answer](https://stackoverflow.com/questions/55711115/tensorflow-2-0-model-using-tf-function-very-slow-and-is-recompiling-every-time-t) and also refer these useful article links [Ref-1](https://pgaleone.eu/tensorflow/tf.function/2019/04/03/dissecting-tf-function-part-2/#using-a-python-native-type), [Ref-2](https://pgaleone.eu/tensorflow/tf.function/2019/05/10/dissecting-tf-function-part-3/), I hope it will help you to resolve your issue. Thank you!\r\n\r\nHi @gaikwadrahul8 \r\n\r\nPlease see issues [#35928](https://github.com/tensorflow/tensorflow/issues/35928), [#41129](https://github.com/tensorflow/tensorflow/issues/41129), and [#41949](https://github.com/tensorflow/tensorflow/issues/41949). There was also a PR ([here](https://github.com/tensorflow/tensorflow/commit/3a03164a24ea7dbfe221e84ca62e2a39b745c379), which not sure if it is relevant.\r\n\r\nThank you for the suggestion. But, the input to the function decorated with @tf.function is a Tensor. Also, it seems odd to me that this is happening only when using tanh activation (hence, CuDNNLSTM), but not with other activations (i.e., not CuDNNLSTMs).", "Hi, @kasrash\r\n\r\nThank you for sharing those similar issues, if possible could you please help me with your complete code snippet in Google Colab notebook or as gist-file with all imports so I'll test it from my end because I tested above toy `MNIST` model it's working fine with `tanh` activation functions ? also please help me with Tensorlflow, Python versions ? I hope you're using `cudatoolkit=11.2` and `cudnn=8.1.0 `which is tested configurations as per our [official documentation ](https://www.tensorflow.org/install/source#gpu). \r\n\r\nYou can also refer our official documentation for [Speeding-up your training step with tf.function](https://www.tensorflow.org/guide/keras/writing_a_training_loop_from_scratch#speeding-up_your_training_step_with_tffunction) and You can also try [tf.function(jit_compile=True)](https://www.tensorflow.org/api_docs/python/tf/function) for a more significant performance boost, especially if your code is heavy on TensorFlow control flow and uses many small tensors. Learn more in the _Explicit compilation with [tf.function(jitcompile=True)](https://www.tensorflow.org/api_docs/python/tf/function) section of the [XLA overview](https://www.tensorflow.org/xla). Thank you!\r\n\r\n", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59677\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59677\">No</a>\n" ]
2023-02-14T05:53:38
2023-03-31T01:56:49
2023-03-31T01:56:46
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version TF 2.11.0 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.9.16 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 12.0 (V12.0.140) ### GPU model and memory 2* Nvidia RTX A6000 48 GB ### Current Behaviour? ```shell Hello all, For a specific problem, I need a manual training loop that includes a intermediate function. This function gets the model jacobian (output w.r.t to model's weights) along with other variables to generate the gradients and the loss function. I tried to calculate the model's Jacobian with GradientTape inside a function wrapped by tf.function. However, I get the error that tf.function fails. I saw similar issues dating back to 2020, but they were solved back then. I would be grateful to know your thoughts as the performance of the current code is super slow (~13 seconds for each step). P.S. I cannot wrap the whole train_step function below with tf.function as the intermediate functions use Python dicts and Numpy arrays (the algorithm is a recursive algorithm if it matters). Many thanks in advance! ``` ### Standalone code to reproduce the issue ```shell #fn to calculate the model jacobian @tf.function def jacobian_calc(model, inputs): with tf.GradientTape() as tape: tape.watch(model.trainable_weights) predictions = model(inputs, training=True) model_jacobian = tape.jacobian(predictions,model.trainable_weights) return model_jacobian, predictions def train_step(model, inputs, targets, acc): st = time.time() model_jacobian, predictions = jacobian_calc(model,inputs) et = time.time() print(f"Elapsed time is {et-st}") dLoss = [] for jacobian in model_jacobian: p_loss, p_dLoss = loss_grads(targets, predictions, acc, jacobian) p_dLoss = tf.convert_to_tensor(p_dLoss, dtype=tf.float32) print(type(p_dLoss)) print(type(model.trainable_weights[0])) dLoss.append(p_dLoss/K.eval(inputs).size) Loss = p_loss/K.eval(inputs).size opt.apply_gradients(zip(dLoss, model.trainable_weights)) logs = {} print(f" Loosssss is = {Loss}") logs["loss"] = Loss return logs # load the samples with open(seq_path+'/real_1000_300.pkl','rb') as dumper: samples_real = pickle.load(dumper) with open(seq_path+'/model_1000_300.pkl','rb') as dumper: samples_model = pickle.load(dumper) with open(seq_path+'/acc_1000_300.pkl','rb') as dumper: samples_acc = pickle.load(dumper) # create training and testing sets train_x = samples_model[:val_index_opt, :, 0] #Umodel train_y = samples_real[:val_index_opt, :, 0] #Ureal train_acc = samples_acc[:val_index_opt, :, 0] #acc val_x = samples_model[val_index_opt:, :, 0] #Umodel val_y = samples_real[val_index_opt:, :, 0] #Ureal val_acc = samples_acc[val_index_opt:, :, 0] #acc # no data scaling as I need to figure this out later. A dirty fix for now! Sorry:) train_scaled_x = train_x.reshape(train_x.shape[0],train_x.shape[1],-1) train_scaled_y = train_y.reshape(train_y.shape[0],train_y.shape[1],-1) train_scaled_acc = train_acc.reshape(train_acc.shape[0],train_acc.shape[1],-1) val_scaled_x = val_x.reshape(val_x.shape[0],val_x.shape[1],-1) val_scaled_y = val_y.reshape(val_y.shape[0],val_y.shape[1],-1) val_scaled_acc = val_acc.reshape(val_acc.shape[0],val_acc.shape[1],-1) ## Creating the RNN model = Sequential() model.add(LSTM(32, input_shape=(None, train_scaled_x.shape[2]), mreturn_sequences=True)) model.add(Dense(32, input_shape=(None, train_scaled_x.shape[2]))) model.add(Dense(dense_1, activation='relu')) model.add(Dense(1, activation='linear')) # optimizer opt = tf.keras.optimizers.Adam(learning_rate=0.001) #Train model (only presented the training and not the validation here training_set = tf.data.Dataset.from_tensor_slices((train_scaled_x,train_scaled_acc,train_scaled_y)) training_set = training_set.batch(batch) history = {"loss": []} for ee in range(1,epoch+1): for inputs_batch, acc_batch, targets_batch in training_set: logs = train_step(model, inputs_batch,targets_batch,acc_batch) print(f"Results at the end of epoch {epoch}") for key, value in logs.items(): #have some other metrics that I omitted here print(f"...{key}: {value:.4f}") history["loss"].append(logs["loss"]) ``` ### Relevant log output ```shell 2023-02-13 21:51:20.518488: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-02-13 21:51:21.105332: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /opt/spack/v0.17.0/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/slurm-21-08-1-1-ctwolps4xy7mz7h3hooji4t72xs5vsyz/lib:/home/kshamsaei/miniconda3/envs/tf/lib/ 2023-02-13 21:51:21.105406: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /opt/spack/v0.17.0/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/slurm-21-08-1-1-ctwolps4xy7mz7h3hooji4t72xs5vsyz/lib:/home/kshamsaei/miniconda3/envs/tf/lib/ 2023-02-13 21:51:21.105417: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly. HELLO /home/kshamsaei/sdof/sdof-300-1000 2023-02-13 21:51:21.662319: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-02-13 21:51:22.347877: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 46671 MB memory: -> device: 0, name: NVIDIA RTX A6000, pci bus id: 0000:21:00.0, compute capability: 8.6 2023-02-13 21:51:22.348397: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:1 with 46685 MB memory: -> device: 1, name: NVIDIA RTX A6000, pci bus id: 0000:81:00.0, compute capability: 8.6 WARNING:tensorflow:From /home/kshamsaei/miniconda3/envs/tf/lib/python3.9/site-packages/tensorflow/python/autograph/pyct/static_analysis/liveness.py:83: Analyzer.lamba_check (from tensorflow.python.autograph.pyct.static_analysis.liveness) is deprecated and will be removed after 2023-09-23. Instructions for updating: Lambda fuctions will be no more assumed to be used in the statement where they are used, or at least in the same block. https://github.com/tensorflow/tensorflow/issues/56089 2023-02-13 21:51:25.417706: E tensorflow/core/grappler/optimizers/meta_optimizer.cc:954] function_optimizer failed: INVALID_ARGUMENT: Input 0 of node loop_body/PartitionedCall/pfor/PartitionedCall/gradients/while_grad/while_grad/pfor/PartitionedCall/while/enter/_746 was passed int32 from sequential/lstm/PartitionedCall:20 incompatible with expected variant. 2023-02-13 21:51:25.926875: E tensorflow/core/grappler/optimizers/meta_optimizer.cc:954] function_optimizer failed: INVALID_ARGUMENT: Input 0 of node loop_body/PartitionedCall/pfor/PartitionedCall/gradients/while_grad/while_grad/pfor/PartitionedCall/while/enter/_746 was passed int32 from sequential/lstm/PartitionedCall:20 incompatible with expected variant. 2023-02-13 21:51:26.001961: W tensorflow/core/common_runtime/process_function_library_runtime.cc:915] Ignoring multi-device function optimization failure: INVALID_ARGUMENT: Input 0 of node loop_body/PartitionedCall/pfor/PartitionedCall/gradients/while_grad/while_grad/pfor/PartitionedCall/while/enter/_728 was passed float from sequential/lstm/PartitionedCall:11 incompatible with expected int32. 2023-02-13 21:51:31.457799: I tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:630] TensorFloat-32 will be used for the matrix multiplication. This will only be logged once. ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59677/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59677/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59676
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59676/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59676/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59676/events
https://github.com/tensorflow/tensorflow/issues/59676
1,583,514,921
I_kwDOArmXAs5eYoUp
59,676
tensorflow js 4.2.0 version with Vue3 about version dependency problem
{ "login": "myplc", "id": 73979261, "node_id": "MDQ6VXNlcjczOTc5MjYx", "avatar_url": "https://avatars.githubusercontent.com/u/73979261?v=4", "gravatar_id": "", "url": "https://api.github.com/users/myplc", "html_url": "https://github.com/myplc", "followers_url": "https://api.github.com/users/myplc/followers", "following_url": "https://api.github.com/users/myplc/following{/other_user}", "gists_url": "https://api.github.com/users/myplc/gists{/gist_id}", "starred_url": "https://api.github.com/users/myplc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/myplc/subscriptions", "organizations_url": "https://api.github.com/users/myplc/orgs", "repos_url": "https://api.github.com/users/myplc/repos", "events_url": "https://api.github.com/users/myplc/events{/privacy}", "received_events_url": "https://api.github.com/users/myplc/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "@myplc,\r\nCould you please post this issue in [tensorflow/tfjs](https://github.com/tensorflow/tfjs/issues) repo to get the right help there?\r\nThanks!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59676\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59676\">No</a>\n" ]
2023-02-14T05:22:19
2023-02-28T15:07:05
2023-02-28T15:07:02
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 4.2.0 ### Custom Code Yes ### OS Platform and Distribution windows10 ### Mobile device _No response_ ### Python version 2.7 and 3.9 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory 4G ### Current Behaviour? ```shell Uncaught (in promise) TypeError: (0 , _environment__WEBPACK_IMPORTED_MODULE_6__.env)(...).platform.isTypedArray is not a function at isTypedArray (util.js:194:71) at inferShape (tensor_util_env.js:38:58) at Module.tensor (tensor.js:193:85) at tfex (tfjs.js:27:66) at Proxy.get (index.js??clonedRuleSet-40.use[0]!./node_modules/vue-loader/dist/index.js??ruleSet[0].use[0]!./src/components/tf1.vue?vue&type=script&lang=js:33:60) at onClick._cache.<computed>._cache.<computed> (index.js??clonedRuleSet-40.use[0]!./node_modules/vue-loader/dist/templateLoader.js??ruleSet[1].rules[3]!./node_modules/vue-loader/dist/index.js??ruleSet[0].use[0]!./src/components/tf1.vue?vue&type=template&id=4498369f:21:59) at callWithErrorHandling (runtime-core.esm-bundler.js:290:18) at callWithAsyncErrorHandling (runtime-core.esm-bundler.js:298:17) at HTMLButtonElement.invoker (runtime-dom.esm-bundler.js:473:82) ``` ### Standalone code to reproduce the issue ```shell In version 4.2.0 it doesn't run when importing to vue3. after suffering I found that downgrading the version fixed the problem. 4.1.0 and below no problem. ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59676/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59676/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59675
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59675/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59675/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59675/events
https://github.com/tensorflow/tensorflow/pull/59675
1,583,458,240
PR_kwDOArmXAs5J6GVL
59,675
[NVIDIA TF] Update cudnn frontend to v0.8
{ "login": "kaixih", "id": 4001424, "node_id": "MDQ6VXNlcjQwMDE0MjQ=", "avatar_url": "https://avatars.githubusercontent.com/u/4001424?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kaixih", "html_url": "https://github.com/kaixih", "followers_url": "https://api.github.com/users/kaixih/followers", "following_url": "https://api.github.com/users/kaixih/following{/other_user}", "gists_url": "https://api.github.com/users/kaixih/gists{/gist_id}", "starred_url": "https://api.github.com/users/kaixih/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kaixih/subscriptions", "organizations_url": "https://api.github.com/users/kaixih/orgs", "repos_url": "https://api.github.com/users/kaixih/repos", "events_url": "https://api.github.com/users/kaixih/events{/privacy}", "received_events_url": "https://api.github.com/users/kaixih/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "v0.8 is not available at https://github.com/NVIDIA/cudnn-frontend at the main branch. I cannot proceed until it has been updated.", "> v0.8 is not available at https://github.com/NVIDIA/cudnn-frontend at the main branch. I cannot proceed until it has been updated.\r\n\r\nThanks for the comment. Yes, we are working on releasing it soon. And this PR will be updated accordingly. Will ping you after that.", "There was an update ~1.5 days ago. Is that the final update to v0.8? Or are more changes expected?", "@pgpetrak Thanks for the checkup. I have pushed a new commit to use the official v0.8 release and updated the PR description to reflect this. PTAL.", "Basically, there are two changes of this PR: (1) update the download url and (2) update the patch file.\r\n\r\nThen, I checked the above automatically created PR https://github.com/openxla/xla/pull/1589, and saw one test \"XLA Linux GPU\" fails.\r\n\r\nIt seems that the above PR only fetches the change (2) and I don't know how to make it to apply the change (1) as well (I guess it uses a different way to download the zip rather than `workspace2.bzl`.).\r\n\r\n@reedwm Can you help or redirect?", "> Basically, there are two changes of this PR: (1) update the download url and (2) update the patch file.\r\n> \r\n> Then, I checked the above automatically created PR [openxla/xla#1589](https://github.com/openxla/xla/pull/1589), and saw one test \"XLA Linux GPU\" fails.\r\n> \r\n> It seems that the above PR only fetches the change (2) and I don't know how to make it to apply the change (1) as well (I guess it uses a different way to download the zip rather than `workspace2.bzl`.).\r\n> \r\n> @reedwm Can you help or redirect?\r\n\r\n@jakeharmon8 do you know how to fix this? I think this PR also needs to update the [`workspace2.bzl` in the openxla/xla repo](https://github.com/openxla/xla/blob/main/workspace2.bzl), in addition to the `workspace2.bzl` that it already updates in the TF repo. But a PR can only update one repo at once. When merging internally, should we update both `workspace2.bzl`s in the same CL?\r\n", "Is there an ETA on the merge for this PR. https://github.com/tensorflow/tensorflow/pull/60002 build is dependent on this PR being merged.", "@pgpetrak I guess you're still the reviewer for this? I'm going to remove myself as reviewer if you can take care of this.", "@reedwm Yes, you're correct. Tensorflow isn't using the OpenXLA version of XLA (yet! we should have that working soon). Because of that, we have to change both workspace files at the same time, which can only be done with an internal CL." ]
2023-02-14T04:11:23
2023-03-17T08:06:54
2023-03-17T08:06:53
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59675", "html_url": "https://github.com/tensorflow/tensorflow/pull/59675", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59675.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59675.patch", "merged_at": "2023-03-17T08:06:53" }
This PR is to update the cudnn frontend version to v0.8. The release note is [here](https://github.com/NVIDIA/cudnn-frontend/releases/tag/v0.8). cc. @pjannaty @nluehr
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59675/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59675/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59674
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59674/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59674/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59674/events
https://github.com/tensorflow/tensorflow/pull/59674
1,583,401,410
PR_kwDOArmXAs5J56b-
59,674
Fix debug build failure in math_approximation.cc due to 'isnan' was not declared
{ "login": "DamonFool", "id": 19923746, "node_id": "MDQ6VXNlcjE5OTIzNzQ2", "avatar_url": "https://avatars.githubusercontent.com/u/19923746?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DamonFool", "html_url": "https://github.com/DamonFool", "followers_url": "https://api.github.com/users/DamonFool/followers", "following_url": "https://api.github.com/users/DamonFool/following{/other_user}", "gists_url": "https://api.github.com/users/DamonFool/gists{/gist_id}", "starred_url": "https://api.github.com/users/DamonFool/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DamonFool/subscriptions", "organizations_url": "https://api.github.com/users/DamonFool/orgs", "repos_url": "https://api.github.com/users/DamonFool/repos", "events_url": "https://api.github.com/users/DamonFool/events{/privacy}", "received_events_url": "https://api.github.com/users/DamonFool/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks @tpopp for your review." ]
2023-02-14T02:56:56
2023-02-15T11:14:13
2023-02-15T11:14:13
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59674", "html_url": "https://github.com/tensorflow/tensorflow/pull/59674", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59674.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59674.patch", "merged_at": "2023-02-15T11:14:13" }
Hi all, The debug build failed. ``` tensorflow/compiler/xla/mlir/math/transforms/math_approximation.cc: In function 'mlir::Value xla::{anonymous}::ClampWithNormals(mlir::ImplicitLocOpBuilder&, const llvm::SmallVector<long int, 2>&, mlir::Value, float, float)': tensorflow/compiler/xla/mlir/math/transforms/math_approximation.cc:131:11: error: 'isnan' was not declared in this scope; did you mean 'std::isnan'? 131 | assert(!isnan(lower_bound)); | ^~~~~ In file included from external/llvm-project/llvm/include/llvm/Support/MathExtras.h:20, from external/llvm-project/llvm/include/llvm/Support/Alignment.h:24, from external/llvm-project/llvm/include/llvm/Support/Allocator.h:21, from external/llvm-project/mlir/include/mlir/Support/TypeID.h:21, from external/llvm-project/mlir/include/mlir/IR/MLIRContext.h:13, from external/llvm-project/mlir/include/mlir/IR/DialectRegistry.h:16, from external/llvm-project/mlir/include/mlir/IR/Dialect.h:16, from external/llvm-project/mlir/include/mlir/Dialect/Arith/IR/Arith.h:12, from tensorflow/compiler/xla/mlir/math/transforms/math_approximation.cc:20: /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/cmath:632:5: note: 'std::isnan' declared here 632 | isnan(_Tp __x) | ^~~~~ Target //tensorflow/tools/pip_package:build_pip_package failed to build ``` Let's fix it. Thanks. Best regards, Jie
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59674/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59674/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59673
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59673/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59673/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59673/events
https://github.com/tensorflow/tensorflow/pull/59673
1,583,118,884
PR_kwDOArmXAs5J4-H3
59,673
[NVIDIA TF] Enable GPU BF16 Relu unconditionally
{ "login": "trevor-m", "id": 12981474, "node_id": "MDQ6VXNlcjEyOTgxNDc0", "avatar_url": "https://avatars.githubusercontent.com/u/12981474?v=4", "gravatar_id": "", "url": "https://api.github.com/users/trevor-m", "html_url": "https://github.com/trevor-m", "followers_url": "https://api.github.com/users/trevor-m/followers", "following_url": "https://api.github.com/users/trevor-m/following{/other_user}", "gists_url": "https://api.github.com/users/trevor-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/trevor-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/trevor-m/subscriptions", "organizations_url": "https://api.github.com/users/trevor-m/orgs", "repos_url": "https://api.github.com/users/trevor-m/repos", "events_url": "https://api.github.com/users/trevor-m/events{/privacy}", "received_events_url": "https://api.github.com/users/trevor-m/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "rohan100jain", "id": 144114, "node_id": "MDQ6VXNlcjE0NDExNA==", "avatar_url": "https://avatars.githubusercontent.com/u/144114?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rohan100jain", "html_url": "https://github.com/rohan100jain", "followers_url": "https://api.github.com/users/rohan100jain/followers", "following_url": "https://api.github.com/users/rohan100jain/following{/other_user}", "gists_url": "https://api.github.com/users/rohan100jain/gists{/gist_id}", "starred_url": "https://api.github.com/users/rohan100jain/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rohan100jain/subscriptions", "organizations_url": "https://api.github.com/users/rohan100jain/orgs", "repos_url": "https://api.github.com/users/rohan100jain/repos", "events_url": "https://api.github.com/users/rohan100jain/events{/privacy}", "received_events_url": "https://api.github.com/users/rohan100jain/received_events", "type": "User", "site_admin": false }
[ { "login": "rohan100jain", "id": 144114, "node_id": "MDQ6VXNlcjE0NDExNA==", "avatar_url": "https://avatars.githubusercontent.com/u/144114?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rohan100jain", "html_url": "https://github.com/rohan100jain", "followers_url": "https://api.github.com/users/rohan100jain/followers", "following_url": "https://api.github.com/users/rohan100jain/following{/other_user}", "gists_url": "https://api.github.com/users/rohan100jain/gists{/gist_id}", "starred_url": "https://api.github.com/users/rohan100jain/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rohan100jain/subscriptions", "organizations_url": "https://api.github.com/users/rohan100jain/orgs", "repos_url": "https://api.github.com/users/rohan100jain/repos", "events_url": "https://api.github.com/users/rohan100jain/events{/privacy}", "received_events_url": "https://api.github.com/users/rohan100jain/received_events", "type": "User", "site_admin": false }, { "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }, { "login": "reedwm", "id": 6510203, "node_id": "MDQ6VXNlcjY1MTAyMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/6510203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reedwm", "html_url": "https://github.com/reedwm", "followers_url": "https://api.github.com/users/reedwm/followers", "following_url": "https://api.github.com/users/reedwm/following{/other_user}", "gists_url": "https://api.github.com/users/reedwm/gists{/gist_id}", "starred_url": "https://api.github.com/users/reedwm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reedwm/subscriptions", "organizations_url": "https://api.github.com/users/reedwm/orgs", "repos_url": "https://api.github.com/users/reedwm/repos", "events_url": "https://api.github.com/users/reedwm/events{/privacy}", "received_events_url": "https://api.github.com/users/reedwm/received_events", "type": "User", "site_admin": false }, { "login": "bfontain", "id": 6878204, "node_id": "MDQ6VXNlcjY4NzgyMDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6878204?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bfontain", "html_url": "https://github.com/bfontain", "followers_url": "https://api.github.com/users/bfontain/followers", "following_url": "https://api.github.com/users/bfontain/following{/other_user}", "gists_url": "https://api.github.com/users/bfontain/gists{/gist_id}", "starred_url": "https://api.github.com/users/bfontain/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bfontain/subscriptions", "organizations_url": "https://api.github.com/users/bfontain/orgs", "repos_url": "https://api.github.com/users/bfontain/repos", "events_url": "https://api.github.com/users/bfontain/events{/privacy}", "received_events_url": "https://api.github.com/users/bfontain/received_events", "type": "User", "site_admin": false }, { "login": "chsigg", "id": 7523982, "node_id": "MDQ6VXNlcjc1MjM5ODI=", "avatar_url": "https://avatars.githubusercontent.com/u/7523982?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chsigg", "html_url": "https://github.com/chsigg", "followers_url": "https://api.github.com/users/chsigg/followers", "following_url": "https://api.github.com/users/chsigg/following{/other_user}", "gists_url": "https://api.github.com/users/chsigg/gists{/gist_id}", "starred_url": "https://api.github.com/users/chsigg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chsigg/subscriptions", "organizations_url": "https://api.github.com/users/chsigg/orgs", "repos_url": "https://api.github.com/users/chsigg/repos", "events_url": "https://api.github.com/users/chsigg/events{/privacy}", "received_events_url": "https://api.github.com/users/chsigg/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }, { "login": "gcforster", "id": 108087815, "node_id": "U_kgDOBnFKBw", "avatar_url": "https://avatars.githubusercontent.com/u/108087815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gcforster", "html_url": "https://github.com/gcforster", "followers_url": "https://api.github.com/users/gcforster/followers", "following_url": "https://api.github.com/users/gcforster/following{/other_user}", "gists_url": "https://api.github.com/users/gcforster/gists{/gist_id}", "starred_url": "https://api.github.com/users/gcforster/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gcforster/subscriptions", "organizations_url": "https://api.github.com/users/gcforster/orgs", "repos_url": "https://api.github.com/users/gcforster/repos", "events_url": "https://api.github.com/users/gcforster/events{/privacy}", "received_events_url": "https://api.github.com/users/gcforster/received_events", "type": "User", "site_admin": false }, { "login": "xla-rotation", "id": 116104012, "node_id": "U_kgDOBuubTA", "avatar_url": "https://avatars.githubusercontent.com/u/116104012?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xla-rotation", "html_url": "https://github.com/xla-rotation", "followers_url": "https://api.github.com/users/xla-rotation/followers", "following_url": "https://api.github.com/users/xla-rotation/following{/other_user}", "gists_url": "https://api.github.com/users/xla-rotation/gists{/gist_id}", "starred_url": "https://api.github.com/users/xla-rotation/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xla-rotation/subscriptions", "organizations_url": "https://api.github.com/users/xla-rotation/orgs", "repos_url": "https://api.github.com/users/xla-rotation/repos", "events_url": "https://api.github.com/users/xla-rotation/events{/privacy}", "received_events_url": "https://api.github.com/users/xla-rotation/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-13T21:49:29
2023-02-14T16:06:35
2023-02-14T16:06:34
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59673", "html_url": "https://github.com/tensorflow/tensorflow/pull/59673", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59673.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59673.patch", "merged_at": "2023-02-14T16:06:34" }
Registers bf16 relu gpu kernels even when mlir generated kernels are enabled. cc @reedwm We can revert this when MLIR generated bf16 is available in the future. FYI @kushanam
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59673/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59673/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59672
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59672/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59672/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59672/events
https://github.com/tensorflow/tensorflow/pull/59672
1,583,028,926
PR_kwDOArmXAs5J4qmP
59,672
[tosa] improved legalization for leaky_relu
{ "login": "Tai78641", "id": 6504206, "node_id": "MDQ6VXNlcjY1MDQyMDY=", "avatar_url": "https://avatars.githubusercontent.com/u/6504206?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Tai78641", "html_url": "https://github.com/Tai78641", "followers_url": "https://api.github.com/users/Tai78641/followers", "following_url": "https://api.github.com/users/Tai78641/following{/other_user}", "gists_url": "https://api.github.com/users/Tai78641/gists{/gist_id}", "starred_url": "https://api.github.com/users/Tai78641/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Tai78641/subscriptions", "organizations_url": "https://api.github.com/users/Tai78641/orgs", "repos_url": "https://api.github.com/users/Tai78641/repos", "events_url": "https://api.github.com/users/Tai78641/events{/privacy}", "received_events_url": "https://api.github.com/users/Tai78641/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "This change (from compare+select operations, to a min/max operation) can improve implementation speed and size on some hardware platforms." ]
2023-02-13T20:38:30
2023-03-07T19:30:07
2023-03-07T19:30:06
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59672", "html_url": "https://github.com/tensorflow/tensorflow/pull/59672", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59672.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59672.patch", "merged_at": "2023-03-07T19:30:06" }
Using max/min instead of select. This change (from compare+select operations, to a min/max operation) can improve implementation speed and size on some hardware platforms. Signed-off-by: Tai Ly <[email protected]> Change-Id: I6e3929873ea2b1f12fe635b4e953c14ed5bdf526
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59672/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59672/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59671
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59671/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59671/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59671/events
https://github.com/tensorflow/tensorflow/issues/59671
1,583,021,775
I_kwDOArmXAs5eWv7P
59,671
CUDA_ERROR_ILLEGAL_ADDRESS
{ "login": "AndreasMadsen", "id": 505333, "node_id": "MDQ6VXNlcjUwNTMzMw==", "avatar_url": "https://avatars.githubusercontent.com/u/505333?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AndreasMadsen", "html_url": "https://github.com/AndreasMadsen", "followers_url": "https://api.github.com/users/AndreasMadsen/followers", "following_url": "https://api.github.com/users/AndreasMadsen/following{/other_user}", "gists_url": "https://api.github.com/users/AndreasMadsen/gists{/gist_id}", "starred_url": "https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AndreasMadsen/subscriptions", "organizations_url": "https://api.github.com/users/AndreasMadsen/orgs", "repos_url": "https://api.github.com/users/AndreasMadsen/repos", "events_url": "https://api.github.com/users/AndreasMadsen/events{/privacy}", "received_events_url": "https://api.github.com/users/AndreasMadsen/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547538, "node_id": "MDU6TGFiZWwxMDk3NTQ3NTM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu", "name": "comp:gpu", "color": "0052cc", "default": false, "description": "GPU related issues" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "reedwm", "id": 6510203, "node_id": "MDQ6VXNlcjY1MTAyMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/6510203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reedwm", "html_url": "https://github.com/reedwm", "followers_url": "https://api.github.com/users/reedwm/followers", "following_url": "https://api.github.com/users/reedwm/following{/other_user}", "gists_url": "https://api.github.com/users/reedwm/gists{/gist_id}", "starred_url": "https://api.github.com/users/reedwm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reedwm/subscriptions", "organizations_url": "https://api.github.com/users/reedwm/orgs", "repos_url": "https://api.github.com/users/reedwm/repos", "events_url": "https://api.github.com/users/reedwm/events{/privacy}", "received_events_url": "https://api.github.com/users/reedwm/received_events", "type": "User", "site_admin": false }
[ { "login": "reedwm", "id": 6510203, "node_id": "MDQ6VXNlcjY1MTAyMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/6510203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reedwm", "html_url": "https://github.com/reedwm", "followers_url": "https://api.github.com/users/reedwm/followers", "following_url": "https://api.github.com/users/reedwm/following{/other_user}", "gists_url": "https://api.github.com/users/reedwm/gists{/gist_id}", "starred_url": "https://api.github.com/users/reedwm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reedwm/subscriptions", "organizations_url": "https://api.github.com/users/reedwm/orgs", "repos_url": "https://api.github.com/users/reedwm/repos", "events_url": "https://api.github.com/users/reedwm/events{/privacy}", "received_events_url": "https://api.github.com/users/reedwm/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "In this gist, I have removed the dependency on `transformers` and a large amount of irrelevant code:\r\nV1: https://gist.github.com/AndreasMadsen/dc5785b5a55bf740c555b2fb5cdab1db (~600 LOC)\r\nV2: https://gist.github.com/AndreasMadsen/5fdaa8431929e25cf3a990f234f88a8c (update, more code removed. ~450 LOC)\r\nV3: https://gist.github.com/AndreasMadsen/2590423c055bc47a932a449a5161bac7 (update, more code removed. 209 LOC)\r\n\r\nI have tried to reduce the code further, but this causes the bug to disappear.", "@pjpratik I think you should add the `comp:xla` label too. As this bug only occurs when XLA is enabled.", "There is no failure with the reproduction script on `2.12.0rc0`. However, given how difficult this bug is to reproduce (e.g. changing just the seed of the shuffle function will make it disappear). I can't tell if this solves the issue consistently.", "The error appears to be specific to V100, as it does not reproduce on T4, A100, and P100 GPUs. I have however reproduced it on two different systems running V100. It is possible this is related to the specific memory size of the GPU.", "Hi, @AndreasMadsen \r\n\r\nApologize for the delay and Thank you for your detailed observations and efforts to find out the root cause for this issue and We'll try it from our end and will check whether this issue is specific to V100 GPU or not and we'll update you soon here. Thank you for noticing this issue. Thank you!", "@gaikwadrahul8 Thanks for looking into this. It did take me several days to make this error reproducible. So I hope it will help you. I suspect it's a rather complex integration bug, as removing pretty much any line in the latest (V3) script cause the bug to disappear. ", "Hi, @AndreasMadsen \r\n\r\nApologize for the delay and I was able to replicate the issue on `Tesla V100 GPU` and I was getting the exact same error message which you mentioned in your error log output above with `tensorflow/tensorflow:latest-gpu` docker image which is using `Tensorflow==2.11`, I have added screenshot for your reference below and even tested the same code on Google Colab and it's working fine as expected here is [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/caf4e40e4ef5c295f9c0b1defcacc63a/-59671.ipynb), I did not run for complete epoch because it was taking more time but code was running as expected but as you confirmed it's working fine on all other GPU's so this issue seems like specific to `Tesla V100 GPU` at the moment. Thank you!\r\n\r\nWhen I tried the same code with `tensorflow/tensorflow:2.12.0rc0-gpu` and `tensorflow/tensorflow:nightly-gpu` on `Tesla V100 GPU` it's working as expected, I have added screenshot below\r\n\r\nHere is screenshot for code execution with `tensorflow/tensorflow:latest-gpu` docker image\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/220920902-6a6004fb-297f-4bbb-8683-2a6e14d1b83a.png)\r\n\r\nHere is screenshot for code execution on Google-Colab :\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/220929005-86bab24b-ef55-4e61-90fe-8cf95fb8a5cf.png)\r\n\r\nHere is screenshot for code execution with `tensorflow/tensorflow:2.12.0rc0-gpu` docker image:\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/220937369-56b79ed5-d6db-4f28-9082-19d52762c4ad.png)\r\n\r\nHere is screenshot for code execution with `tensorflow/tensorflow:nightly-gpu` docker image:\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/220945432-a6f48ee1-afa3-426b-b793-d1f0db823e37.png)\r\n\r\n\r\n", "Hi @gaikwadrahul8, you didn't ask a question, so I'm not sure what you want me to respond to.\r\n\r\nI agree with your findings. Given how sensitive the bug is in terms of reproduction, I would not trust that it is something specific to V100 TF 2.11. I hope you will be able to debug this further and get to the resolve bug.", "Note, that this kind of bug has been reported quite a few times before, but I think most issues were not able to provide a reproduction script. So I hope you will find this script quite useful.\r\n\r\nISSUE: https://github.com/tensorflow/tensorflow/issues/50735\r\n\r\nI remember there were more closed issues, when I was researching solutions.\r\n\r\n", "Hi. @AndreasMadsen \r\n\r\nThank you for mentioning the similar issue, It seems like we have to dig more into this issue to find out the root cause and we'll update you soon and I was able to replicate the exact same issue with error log with `tensorflow/tensorflow:latest-gpu ` docker image that's the reason I did not ask any questions to you if we need any input or further details from your end certainly we will ask you. Thank you for noticing this issue, I really appreciate your efforts and time. Thank you!", "@gaikwadrahul8 Thanks for letting me know. I'm was just confused about the `stat:awaiting response` label.", "Hi, @sachinprasadhs \r\n\r\nCould you please look into this issue ? Thank you!", "Hi @sachinprasadhs, did you manage to investigate this? ", "Hi @AndreasMadsen , Apologies for the delayed response, based on the issue thread so far, it is difficult to point to an area why this is happening.\r\nBut you could try below steps and see if that works.\r\n1. Try reinstalling the CUDA and cuDNN dependency, in some cases it could be due to improper installation of these dependencies.\r\n2. Try setting the environmental variable `TF_FORCE_GPU_ALLOW_GROWTH `to `true`\r\n\r\nIf the above steps did not work could you please run the model with the env var `CUDA_LAUNCH_BLOCKING` set to `1` and attach the full logs?", "@sachinprasadhs Thanks for your response. Please note that I spent several days reducing this to a script that reproduces the issue. I think you can benifit tremendously from using that. Furthermore, @gaikwadrahul8 confirms that the issue could be reproduced with a V100 GPU.\r\n\r\n1. Try reinstalling the CUDA and cuDNN dependency, in some cases it could be due to improper installation of these dependencies.\r\n\r\nLet's not go down that route, since @gaikwadrahul8 was able to reproduce the issue on Google's infrastructure.\r\n\r\n2. Try setting the environmental variable `TF_FORCE_GPU_ALLOW_GROWTH` to `true`.\r\n\r\nSame issue. Expand the `<details>` to see the log.\r\n\r\n<details>\r\n<summary><code>TF_FORCE_GPU_ALLOW_GROWTH=true python main.py</code></summary>\r\n\r\n```\r\n2023-03-15 11:55:41.321502: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA\r\nTo enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-03-15 11:55:41.504643: I tensorflow/core/util/port.cc:104] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.\r\n2023-03-15 11:55:42.479709: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory\r\n2023-03-15 11:55:42.480077: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory\r\n2023-03-15 11:55:42.480113: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.\r\n2023-03-15 11:55:43.729040: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA\r\nTo enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-03-15 11:55:44.593353: W tensorflow/core/common_runtime/gpu/gpu_bfc_allocator.cc:42] Overriding orig_value setting because the TF_FORCE_GPU_ALLOW_GROWTH environment variable is set. Original config value was 0.\r\n2023-03-15 11:55:44.593541: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 30971 MB memory: -> device: 0, name: Tesla V100-SXM2-32GB, pci bus id: 0000:18:00.0, compute capability: 7.0\r\n2023-03-15 11:56:14.842711: I tensorflow/compiler/xla/service/service.cc:173] XLA service 0x20192630 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices:\r\n2023-03-15 11:56:14.842838: I tensorflow/compiler/xla/service/service.cc:181] StreamExecutor device (0): Tesla V100-SXM2-32GB, Compute Capability 7.0\r\n2023-03-15 11:56:15.808448: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:268] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable.\r\n2023-03-15 11:56:15.816882: W tensorflow/compiler/tf2xla/kernels/random_ops.cc:57] Warning: Using tf.random.uniform with XLA compilation will ignore seeds; consider using tf.random.stateless_uniform instead if reproducible behavior is desired. tf_roberta_for_sequence_classification/layer_._0/self/dropout/dropout/random_uniform/RandomUniform\r\n2023-03-15 11:57:26.919108: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:325] ptxas warning : Registers are spilled to local memory in function 'sort_9'\r\nptxas warning : Registers are spilled to local memory in function 'fusion_1107'\r\n\r\n2023-03-15 11:57:27.290497: I tensorflow/compiler/jit/xla_compilation_cache.cc:477] Compiled cluster using XLA! This line is logged at most once for the lifetime of the process.\r\n2023-03-15 11:57:27.774582: E tensorflow/compiler/xla/stream_executor/cuda/cuda_driver.cc:1159] failed to enqueue async memcpy from device to host: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered; host dst: 0x2b4b7e184eeb; GPU src: 0x2b4e0836e500; size: 1=0x1\r\n2023-03-15 11:57:27.774751: I tensorflow/compiler/xla/stream_executor/stream.cc:2485] INTERNAL: Unknown error\r\n2023-03-15 11:57:27.774869: I tensorflow/compiler/xla/stream_executor/stream.cc:2489] [stream=0x1c1751e0,impl=0x5e7c020] INTERNAL: stream did not block host until done; was already in an error state\r\nTraceback (most recent call last):\r\n File \"/scratch/anmadc/workspace/economical-roar/main.py\", line 209, in <module>\r\n model.fit(dataset_train_batched, verbose=1, epochs=1)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/utils/traceback_utils.py\", line 70, in error_handler\r\n raise e.with_traceback(filtered_tb) from None\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/tensorflow/python/eager/execute.py\", line 52, in quick_execute\r\n tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,\r\ntensorflow.python.framework.errors_impl.InternalError: Graph execution error:\r\n\r\nDetected at node 'StatefulPartitionedCall' defined at (most recent call last):\r\n File \"/scratch/anmadc/workspace/economical-roar/main.py\", line 209, in <module>\r\n model.fit(dataset_train_batched, verbose=1, epochs=1)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/utils/traceback_utils.py\", line 65, in error_handler\r\n return fn(*args, **kwargs)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/engine/training.py\", line 1650, in fit\r\n tmp_logs = self.train_function(iterator)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/engine/training.py\", line 1249, in train_function\r\n return step_function(self, iterator)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/engine/training.py\", line 1233, in step_function\r\n outputs = model.distribute_strategy.run(run_step, args=(data,))\r\nNode: 'StatefulPartitionedCall'\r\nFailed to retrieve branch_index value on stream 0x1c1751e0: stream did not block host until done; was already in an error state.\r\n\t [[{{node StatefulPartitionedCall}}]] [Op:__inference_train_function_37296]\r\n```\r\n</details>\r\n\r\n\r\n<details>\r\n<summary><code>CUDA_LAUNCH_BLOCKING=1 TF_FORCE_GPU_ALLOW_GROWTH=true python main.py</code></summary>\r\n\r\n```\r\n2023-03-15 11:57:59.121539: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA\r\nTo enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-03-15 11:57:59.307027: I tensorflow/core/util/port.cc:104] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.\r\n2023-03-15 11:58:00.281216: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory\r\n2023-03-15 11:58:00.281601: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory\r\n2023-03-15 11:58:00.281646: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.\r\n2023-03-15 11:58:01.543891: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA\r\nTo enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\n2023-03-15 11:58:02.412447: W tensorflow/core/common_runtime/gpu/gpu_bfc_allocator.cc:42] Overriding orig_value setting because the TF_FORCE_GPU_ALLOW_GROWTH environment variable is set. Original config value was 0.\r\n2023-03-15 11:58:02.412647: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 30971 MB memory: -> device: 0, name: Tesla V100-SXM2-32GB, pci bus id: 0000:18:00.0, compute capability: 7.0\r\n2023-03-15 11:58:32.523032: I tensorflow/compiler/xla/service/service.cc:173] XLA service 0x1fb485b0 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices:\r\n2023-03-15 11:58:32.523516: I tensorflow/compiler/xla/service/service.cc:181] StreamExecutor device (0): Tesla V100-SXM2-32GB, Compute Capability 7.0\r\n2023-03-15 11:58:33.492464: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:268] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable.\r\n2023-03-15 11:58:33.500937: W tensorflow/compiler/tf2xla/kernels/random_ops.cc:57] Warning: Using tf.random.uniform with XLA compilation will ignore seeds; consider using tf.random.stateless_uniform instead if reproducible behavior is desired. tf_roberta_for_sequence_classification/layer_._0/self/dropout/dropout/random_uniform/RandomUniform\r\n2023-03-15 11:59:44.579959: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:325] ptxas warning : Registers are spilled to local memory in function 'sort_9'\r\nptxas warning : Registers are spilled to local memory in function 'fusion_1107'\r\n\r\n2023-03-15 11:59:44.945238: I tensorflow/compiler/jit/xla_compilation_cache.cc:477] Compiled cluster using XLA! This line is logged at most once for the lifetime of the process.\r\nTraceback (most recent call last):\r\n File \"/scratch/anmadc/workspace/economical-roar/main.py\", line 209, in <module>\r\n model.fit(dataset_train_batched, verbose=1, epochs=1)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/utils/traceback_utils.py\", line 70, in error_handler\r\n raise e.with_traceback(filtered_tb) from None\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/tensorflow/python/eager/execute.py\", line 52, in quick_execute\r\n tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,\r\ntensorflow.python.framework.errors_impl.InternalError: Graph execution error:\r\n\r\nDetected at node 'StatefulPartitionedCall' defined at (most recent call last):\r\n File \"/scratch/anmadc/workspace/economical-roar/main.py\", line 209, in <module>\r\n model.fit(dataset_train_batched, verbose=1, epochs=1)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/utils/traceback_utils.py\", line 65, in error_handler\r\n return fn(*args, **kwargs)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/engine/training.py\", line 1650, in fit\r\n tmp_logs = self.train_function(iterator)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/engine/training.py\", line 1249, in train_function\r\n return step_function(self, iterator)\r\n File \"/localscratch/anmadc.62577500.0/env/lib/python3.10/site-packages/keras/engine/training.py\", line 1233, in step_function\r\n outputs = model.distribute_strategy.run(run_step, args=(data,))\r\nNode: 'StatefulPartitionedCall'\r\nFailed to launch CUDA kernel: fusion_1428 with block dimensions: 128x1x1 and grid dimensions: 1280x1x1: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered\r\n\t [[{{node StatefulPartitionedCall}}]] [Op:__inference_train_function_37296]\r\n```\r\n</details>", "Thank you @AndreasMadsen for the short script to reproduce and for removing the `transformers` dependency to keep the example simpler.\r\n\r\nI can reproduce the issue outside docker with CUDA 11.2.0 using the pre-built TF 2.11 pip package. However, the issue disappears when I use CUDA 11.8.0 using the same pip package (the pip package is built with CUDA 11.2 but applications built for one version of CUDA also work for future minor versions of CUDA). So I'm guessing this was a bug with CUDA 11.2 that was fixed somewhere between CUDA 11.2.1 and 11.8.0. Since the TF nightly pip packages are now built with CUDA 11.8, I think this issue is fixed so I'm closing this issue.\r\n\r\nIt's possible this is a race condition in TF instead of a bug in CUDA, and that updating the CUDA version changes some timings which causes the bug not to occur. But I think this is unlikely, so unless we later see CUDA_ERROR_ILLEGAL_ADDRESS errors in other models, we should consider this issue fixed.\r\n\r\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59671\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59671\">No</a>\n" ]
2023-02-13T20:32:19
2023-03-16T02:07:05
2023-03-16T02:07:02
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.11 ### Custom Code No ### OS Platform and Distribution Official docker image via apptainer ### Mobile device _No response_ ### Python version 3.8 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.2/8.1 ### GPU model and memory Tesla V100-SXM2-32GB ### Current Behaviour? Using the Official docker image, the provided code results in a CUDA_ERROR_ILLEGAL_ADDRESS. Note, that while the error is fully consistent (happens every time at the first epoch) it is highly sensitive. If a different seed or model-size is used, the error will not reproduce. I have tried enabling memory growth as suggested elsewhere. However, this only delays the issue to epoch 18. The error does not reproduce on Google Colab or when using the nightly docker image. However, due to the sensitivity of the issue, it is unclear what exactly this means. The Google Colab issue could be due to different GPU. On my own environment it's a Tesla V100-SXM2-32GB, not a T4. ### Standalone code to reproduce the issue This uses `transformers == 4.26.0`, and a synthetic dataset file (based on QQP) that is automatically downloaded. Code is available here: https://gist.github.com/AndreasMadsen/2bf669a3cd4c4a8ba964561b9e72279e Note, I did make an attempt at reproducing it using Colab: https://colab.research.google.com/drive/1zVbNNfz1lZ6xgyoZ7dKWnKzj6poM5XWC?usp=sharing However, the error does not reproduce on Colab. ### Relevant log output ```shell 2023-02-06 14:07:37.519351: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-02-06 14:07:37.759155: I tensorflow/core/util/port.cc:104] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. 2023-02-06 14:07:38.624178: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory 2023-02-06 14:07:38.624677: W tensorflow/compiler/xla/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory 2023-02-06 14:07:38.624725: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly. Configuration: persistent_dir = /scratch/anmadc/tf_memory_issue seed = 0 batch_size = 16 model = roberta-base jit_compile = True precision = mixed_float16 2023-02-06 14:07:40.255950: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 AVX512F AVX512_VNNI FMA To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags. 2023-02-06 14:07:41.029530: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1613] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 30971 MB memory: -> device: 0, name: Tesla V100-SXM2-32GB, pci bus id: 0000:af:00.0, compute capability: 7.0 All model checkpoint layers were used when initializing TFRobertaForSequenceClassification. Some layers of TFRobertaForSequenceClassification were not initialized from the model checkpoint at roberta-base and are newly initialized: ['classifier'] You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference. WARNING:tensorflow:From /localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/tensorflow/python/autograph/pyct/static_analysis/liveness.py:83: Analyzer.lamba_check (from tensorflow.python.autograph.pyct.static_analysis.liveness) is deprecated and will be removed after 2023-09-23. Instructions for updating: Lambda fuctions will be no more assumed to be used in the statement where they are used, or at least in the same block. https://github.com/tensorflow/tensorflow/issues/56089 2023-02-06 14:08:24.250220: I tensorflow/compiler/xla/service/service.cc:173] XLA service 0x2db1cb30 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices: 2023-02-06 14:08:24.264540: I tensorflow/compiler/xla/service/service.cc:181] StreamExecutor device (0): Tesla V100-SXM2-32GB, Compute Capability 7.0 2023-02-06 14:08:25.275879: W tensorflow/compiler/tf2xla/kernels/assert_op.cc:38] Ignoring Assert operator tf_roberta_for_sequence_classification/roberta/embeddings/assert_less/Assert/Assert 2023-02-06 14:08:25.309985: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:268] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable. 2023-02-06 14:08:25.321306: W tensorflow/compiler/tf2xla/kernels/random_ops.cc:57] Warning: Using tf.random.uniform with XLA compilation will ignore seeds; consider using tf.random.stateless_uniform instead if reproducible behavior is desired. tf_roberta_for_sequence_classification/roberta/embeddings/dropout_36/dropout/random_uniform/RandomUniform 2023-02-06 14:09:41.534987: I tensorflow/compiler/xla/stream_executor/gpu/asm_compiler.cc:325] ptxas warning : Registers are spilled to local memory in function 'sort_19' ptxas warning : Registers are spilled to local memory in function 'sort_17' 2023-02-06 14:09:41.931415: I tensorflow/compiler/jit/xla_compilation_cache.cc:477] Compiled cluster using XLA! This line is logged at most once for the lifetime of the process. 2023-02-06 14:09:42.331286: E tensorflow/compiler/xla/stream_executor/cuda/cuda_driver.cc:1159] failed to enqueue async memcpy from device to host: CUDA_ERROR_ILLEGAL_ADDRESS: an illegal memory access was encountered; host dst: 0x2b36f334aeeb; GPU src: 0x2b385f628600; size: 1=0x1 2023-02-06 14:09:42.331472: I tensorflow/compiler/xla/stream_executor/stream.cc:2485] INTERNAL: Unknown error 2023-02-06 14:09:42.331557: I tensorflow/compiler/xla/stream_executor/stream.cc:2489] [stream=0x1b700120,impl=0x52a9880] INTERNAL: stream did not block host until done; was already in an error state Traceback (most recent call last): File "/scratch/anmadc/workspace/economical-roar/reproduce.py", line 150, in <module> model.fit(dataset_train_batched, verbose=1, epochs=1) File "/localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/keras/utils/traceback_utils.py", line 70, in error_handler raise e.with_traceback(filtered_tb) from None File "/localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/tensorflow/python/eager/execute.py", line 52, in quick_execute tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name, tensorflow.python.framework.errors_impl.InternalError: Graph execution error: Detected at node 'StatefulPartitionedCall' defined at (most recent call last): File "/scratch/anmadc/workspace/economical-roar/reproduce.py", line 150, in <module> model.fit(dataset_train_batched, verbose=1, epochs=1) File "/localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/keras/utils/traceback_utils.py", line 65, in error_handler return fn(*args, **kwargs) File "/localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/keras/engine/training.py", line 1650, in fit tmp_logs = self.train_function(iterator) File "/localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/keras/engine/training.py", line 1249, in train_function return step_function(self, iterator) File "/localscratch/anmadc.58777029.0/env/lib/python3.10/site-packages/keras/engine/training.py", line 1233, in step_function outputs = model.distribute_strategy.run(run_step, args=(data,)) Node: 'StatefulPartitionedCall' Failed to retrieve branch_index value on stream 0x1b700120: stream did not block host until done; was already in an error state. [[{{node StatefulPartitionedCall}}]] [Op:__inference_train_function_42578] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59671/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59671/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59670
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59670/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59670/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59670/events
https://github.com/tensorflow/tensorflow/pull/59670
1,582,617,235
PR_kwDOArmXAs5J3S4F
59,670
Bump NCCL version to v2.16.5, which is the latest release.
{ "login": "hawkinsp", "id": 348932, "node_id": "MDQ6VXNlcjM0ODkzMg==", "avatar_url": "https://avatars.githubusercontent.com/u/348932?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hawkinsp", "html_url": "https://github.com/hawkinsp", "followers_url": "https://api.github.com/users/hawkinsp/followers", "following_url": "https://api.github.com/users/hawkinsp/following{/other_user}", "gists_url": "https://api.github.com/users/hawkinsp/gists{/gist_id}", "starred_url": "https://api.github.com/users/hawkinsp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hawkinsp/subscriptions", "organizations_url": "https://api.github.com/users/hawkinsp/orgs", "repos_url": "https://api.github.com/users/hawkinsp/repos", "events_url": "https://api.github.com/users/hawkinsp/events{/privacy}", "received_events_url": "https://api.github.com/users/hawkinsp/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-13T15:57:46
2023-02-14T16:57:20
2023-02-14T16:57:20
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59670", "html_url": "https://github.com/tensorflow/tensorflow/pull/59670", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59670.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59670.patch", "merged_at": "2023-02-14T16:57:19" }
null
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59670/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59670/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59669
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59669/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59669/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59669/events
https://github.com/tensorflow/tensorflow/issues/59669
1,582,564,053
I_kwDOArmXAs5eVALV
59,669
ERROR: no such package '@rules_pkg//': java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_pkg/releases/download/0.2.5/rules_pkg-0.2.5.tar.gz, https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.2.5/rules_pkg-0.2.5.tar.gz] to /private/var/tmp/_bazel_ysong2/b326506f60d8e1a7b80e7181271420e8/external/rules_pkg/temp3975631198066234777/rules_pkg-0.2.5.tar.gz: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
{ "login": "ysong2123", "id": 38981512, "node_id": "MDQ6VXNlcjM4OTgxNTEy", "avatar_url": "https://avatars.githubusercontent.com/u/38981512?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ysong2123", "html_url": "https://github.com/ysong2123", "followers_url": "https://api.github.com/users/ysong2123/followers", "following_url": "https://api.github.com/users/ysong2123/following{/other_user}", "gists_url": "https://api.github.com/users/ysong2123/gists{/gist_id}", "starred_url": "https://api.github.com/users/ysong2123/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ysong2123/subscriptions", "organizations_url": "https://api.github.com/users/ysong2123/orgs", "repos_url": "https://api.github.com/users/ysong2123/repos", "events_url": "https://api.github.com/users/ysong2123/events{/privacy}", "received_events_url": "https://api.github.com/users/ysong2123/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 1205765054, "node_id": "MDU6TGFiZWwxMjA1NzY1MDU0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:macOS", "name": "subtype:macOS", "color": "b619ea", "default": false, "description": "macOS Build/Installation issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "any one could help on this?\r\n", "Hi, @ysong2123 \r\n\r\nApologize for the delay and it seems like the problem is due to SSL certificate on your machine and at the moment I'm providing some useful links which will help you to solve your SSL certificate problem [Ref-1](https://docs.mend.io/en-US/bundle/wsk/page/how_to_resolve_error_message__pkix_path_building_failed__sun_security_provider_certpath_suncertpathbuilderexception__unable_to_find_valid_certification_path_to_requested_target_.html), [Ref-2](https://stackoverflow.com/questions/21076179/pkix-path-building-failed-and-unable-to-find-valid-certification-path-to-requ#:~:text=28-,Mac,-The%20accepted%20answer), [Ref-3](https://stackoverflow.com/questions/6908948/java-sun-security-provider-certpath-suncertpathbuilderexception-unable-to-find#:~:text=And%20if%20you%20are%20here%20in%202022%20and%20are%20on%20mac%20follow%20this) so please try to follow workaround from those references and please let me know is it resolving your issue?\r\n\r\nJust to confirm are you looking to install `Tensorflow 2.11` build from source or you just want to install Bazel on Macos ? I hope you're following this [official documentation](https://www.tensorflow.org/install/source#macos) to install Tensorflow build from source\r\n\r\nI'll also try to install `Tensorflow 2.11` build from source on `MacOS` once you confirm that you're looking to install `Tensorflow 2.11 `build from source so please confirm it ? Thank you!", "Hi Gaikwadrahul8,\r\nYes, i strictly followed the steps in the official doc, after git clone tensorflow, then cd to root directory, then try:\r\n'bazel build //tensorflow/tools/pip_package:build_pip_package' (all prerequisites have been installed in advance), finally i got the certificate issue above.\r\nBTW, the Ref-1,2,3 you shared above are talking about java home, may i know where's the java home for bazel build? i already tried to export certificate and added into my local macOS java home keystore, but i still got the same ssl exception.", "Hi, @ysong2123 \r\n\r\nThank you for the details and usually users get this error `PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target` due to the system firewall. The system firewall restricts the application to connect to external systems. The firewall requires a valid certificate to allow access to the external systems.\r\n\r\nCould you please confirm, whether you're installing [Bazel](https://bazel.build/install) normally or via `Bazelisk` because [Bazelisk](https://github.com/bazelbuild/bazelisk) is an easy way to install Bazel and automatically downloads the correct Bazel version for TensorFlow and if you're using Bazelisk then please download manually and please follow below steps :\r\n\r\n1. `wget https://github.com/bazelbuild/bazelisk/releases/download/v1.16.0/bazelisk-darwin-arm64` (If you get any error with respect to certificate then you can use this command `wget --no-check-certificate https://github.com/bazelbuild/bazelisk/releases/download/v1.16.0/bazelisk-darwin-arm64`\r\n\r\n2. `chmod +x bazelisk-darwin-arm64`\r\n\r\n3. `sudo mv bazelisk-darwin-arm64 /usr/local/bin/bazel`\r\n\r\nIf you have already done above steps and installed Bazel correctly then please execute below steps to see the Bazel or Bazelisk location and if possible please help me with those details \r\n\r\n```\r\n1. whereis bazel\r\n2. whereis bazelisk\r\n```\r\n\r\nI'll try to install Tensorflow on my MacOS from my end till then by following our official documentation and I'll update the same here. Thank you!", "ysong@LM-SHB-40523659 tensorflow % whereis bazel\r\nbazel: /opt/homebrew/bin/bazel\r\nysong@LM-SHB-40523659 tensorflow % whereis bazelisk\r\nbazelisk: /opt/homebrew/bin/bazelisk\r\nysong@LM-423659 tensorflow % \r\nysong@LM-423659 tensorflow % bazel version\r\nBazelisk version: development\r\nAnother command (pid=24928) is running. Waiting for it to complete on the server (server_pid=24932)...\r\nBuild label: 5.3.0\r\nBuild target: bazel-out/darwin_arm64-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar\r\nBuild time: Tue Aug 23 01:07:52 2022 (1661216872)\r\nBuild timestamp: 1661216872\r\nBuild timestamp as int: 1661216872\r\n\r\nMy new finding:\r\nafter run cmd in tensorflow root directory: \r\n'bazel build //tensorflow/tools/pip_package:build_pip_package', \r\nThen i found there's a jdk env auto-generated under path:\r\n/private/var/tmp/_bazel_ysong2/install/3c4a7a3c33b4c067b191587b066e5f1b/embedded_tools/jdk/\r\n\r\nthis JDK is isolated with my local JDK env. so i wrote a simple java demo tried to make a java ssl call to get tensorflow dependencies. If i use my local JDK(openjdk8 or openjdk11) i can get those dependencies with no any exception. \r\nBut when i pointed to /private/var/tmp/_bazel_ysong2/install/3c4a7a3c33b4c067b191587b066e5f1b/embedded_tools/jdk/, \r\ni got the same ssl issue. \r\n\r\nBesides, i tried to copy my local jdk to /private/var/tmp/_bazel_ysong2/install/3c4a7a3c33b4c067b191587b066e5f1b/embedded_tools/jdk/, then i got Fatal error:\r\nFATAL: corrupt installation: file '/var/tmp/_bazel_ysong2/install/3c4a7a3c33b4c067b191587b066e5f1b/embedded_tools/jdk/ASSEMBLY_EXCEPTION' is missing or modified. Please remove '/var/tmp/_bazel_ysong2/install/3c4a7a3c33b4c067b191587b066e5f1b' and try again.\r\n\r\nIs there any way to adopt my local jdk for bazel build?", "i solved this problem using :\r\nhttps://bazel.build/install/compile-source#bootstrap-unix. \r\nI commented out 'for' statement and rebuild a binary version of bazel:\r\nhttps://github.com/bazelbuild/bazel/blob/master/src/main/cpp/blaze.cc#L1015\r\nThen using this to build tensorflow, no any exception now\r\n", "Hi, @ysong2123 \r\n\r\nGood to hear that you're able to resolve your issue and even I was able to install `Tensorflow` build from source with `Bazelisk` approach and it seems like in your case there was some conflict between local JDK and Bazel embedded JDK and it got resolve by this command `env EXTRA_BAZEL_ARGS=\"--tool_java_runtime_version=local_jdk\" bash ./compile.sh`\r\n\r\nI have added screenshot below for your reference with `Bazelisk` Approach:\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/219292576-852d0a0f-ab4d-4e45-9d2b-c6be84e3f187.png)\r\n\r\nCould you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? if you need any further assistance please let us know? Thank you!\r\n\r\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59669\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59669\">No</a>\n" ]
2023-02-13T15:26:12
2023-02-16T07:21:25
2023-02-16T07:21:23
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tag: v2.11.0 ### Custom Code No ### OS Platform and Distribution MacOS Montery 12.6.1 ### Mobile device _No response_ ### Python version 3.9 ### Bazel version 5.6 ### GCC/Compiler version clang 14.0 ### CUDA/cuDNN version none ### GPU model and memory none ### Current Behaviour? ```shell ERROR: no such package '@rules_pkg//': java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_pkg/releases/download/0.2.5/rules_pkg-0.2.5.tar.gz, https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.2.5/rules_pkg-0.2.5.tar.gz] to /private/var/tmp/_bazel_ysong2/b326506f60d8e1a7b80e7181271420e8/external/rules_pkg/temp3975631198066234777/rules_pkg-0.2.5.tar.gz: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target tried add certificates into keystore but doesn't work. ``` ### Standalone code to reproduce the issue ```shell ERROR: no such package '@rules_pkg//': java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_pkg/releases/download/0.2.5/rules_pkg-0.2.5.tar.gz, https://mirror.bazel.build/github.com/bazelbuild/rules_pkg/releases/download/0.2.5/rules_pkg-0.2.5.tar.gz] to /private/var/tmp/_bazel_ysong2/b326506f60d8e1a7b80e7181271420e8/external/rules_pkg/temp3975631198066234777/rules_pkg-0.2.5.tar.gz: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59669/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59669/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59668
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59668/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59668/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59668/events
https://github.com/tensorflow/tensorflow/pull/59668
1,582,523,065
PR_kwDOArmXAs5J2-xy
59,668
[Linaro:ARM_CI] Use IS_NIGHTLY to determine which tensorboard to install
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }, { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-13T15:06:50
2023-03-06T09:29:11
2023-02-13T20:47:39
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59668", "html_url": "https://github.com/tensorflow/tensorflow/pull/59668", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59668.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59668.patch", "merged_at": "2023-02-13T20:47:39" }
Only install tb-nightly on nightly builds otherwise tensorboard, this keeps the build and the test consistent using the same package
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59668/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59668/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59667
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59667/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59667/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59667/events
https://github.com/tensorflow/tensorflow/issues/59667
1,582,413,177
I_kwDOArmXAs5eUbV5
59,667
ValueError: Did not get operators or tensors in subgraph 1
{ "login": "codingzebra333", "id": 112169713, "node_id": "U_kgDOBq-S8Q", "avatar_url": "https://avatars.githubusercontent.com/u/112169713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/codingzebra333", "html_url": "https://github.com/codingzebra333", "followers_url": "https://api.github.com/users/codingzebra333/followers", "following_url": "https://api.github.com/users/codingzebra333/following{/other_user}", "gists_url": "https://api.github.com/users/codingzebra333/gists{/gist_id}", "starred_url": "https://api.github.com/users/codingzebra333/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/codingzebra333/subscriptions", "organizations_url": "https://api.github.com/users/codingzebra333/orgs", "repos_url": "https://api.github.com/users/codingzebra333/repos", "events_url": "https://api.github.com/users/codingzebra333/events{/privacy}", "received_events_url": "https://api.github.com/users/codingzebra333/received_events", "type": "User", "site_admin": false }
[ { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" } ]
closed
false
{ "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false }
[ { "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-13T14:05:23
2023-02-14T14:38:12
2023-02-14T14:38:12
NONE
null
null
null
Hey, I am trying to evaluate a tflite model, but all my attempts have been unsuccessful. I have provided a full code [here](https://colab.research.google.com/drive/14zMCm0XaszVrUoWd9bMvBjSXSdPvSWuw#scrollTo=huwb9Wiufr9e). Thank you very much!
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59667/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59667/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59666
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59666/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59666/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59666/events
https://github.com/tensorflow/tensorflow/issues/59666
1,582,279,624
I_kwDOArmXAs5eT6vI
59,666
flatc Errno 8 Exec format error when building for android
{ "login": "turgut-baba", "id": 56086820, "node_id": "MDQ6VXNlcjU2MDg2ODIw", "avatar_url": "https://avatars.githubusercontent.com/u/56086820?v=4", "gravatar_id": "", "url": "https://api.github.com/users/turgut-baba", "html_url": "https://github.com/turgut-baba", "followers_url": "https://api.github.com/users/turgut-baba/followers", "following_url": "https://api.github.com/users/turgut-baba/following{/other_user}", "gists_url": "https://api.github.com/users/turgut-baba/gists{/gist_id}", "starred_url": "https://api.github.com/users/turgut-baba/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/turgut-baba/subscriptions", "organizations_url": "https://api.github.com/users/turgut-baba/orgs", "repos_url": "https://api.github.com/users/turgut-baba/repos", "events_url": "https://api.github.com/users/turgut-baba/events{/privacy}", "received_events_url": "https://api.github.com/users/turgut-baba/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "I've tried building with `bazel build -c opt //tensorflow/lite:libtensorflowlite.so --fat_apk_cpu=arm64-v8a` but now it says `<path to .so> is not compatible with aarch64linux` . I couldn't build with `bazel build -c opt //tensorflow/lite:libtensorflowlite.so --cpu=arm64-v8a` because I got `cc_toolchain_suite rule @local_config_cc//:toolchain: cc_toolchain_suite '@local_config_cc//:toolchain' does not contain a toolchain for cpu 'arm64-v8a'` error.", "Hi @turgut-baba, Please find the latest official pre release of TF v2.12 [here](https://github.com/tensorflow/tensorflow/tree/v2.12.0-rc0) and confirm if you are trying with the same source. Thank you! ", "I've deleted all the files, git clone again, checkout to the branch you linked, did everything the same, same result.", "Thank you for the update @turgut-baba. It seems like we have to dig more into this issue, we will update soon here. Thanks! ", "Also, I've opened another issue tackling more stuff I've tried: https://github.com/tensorflow/tensorflow/issues/59692", "Hi, @pjpratik \r\n\r\nCould you please look into this issue ?", "Hi @turgut-baba, sorry for delayed response.\r\n\r\nAs suggested [here](https://github.com/tensorflow/tensorflow/issues/59692#issuecomment-1451090438), can you please build on latest stable branch 2.11 and let us know if the issue still persists.\r\n\r\nThanks.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59666\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59666\">No</a>\n" ]
2023-02-13T12:40:32
2023-03-31T01:56:52
2023-03-31T01:56:48
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Build/Install ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version 2.12 ### Custom Code Yes ### OS Platform and Distribution Debian 11 ### Mobile device Android ### Python version 3.9.2 ### Bazel version 6.0.0 ### GCC/Compiler version 10.2.1 ### CUDA/cuDNN version _No response_ ### GPU model and memory nvidia ### Current Behaviour? ```shell I have a c++ code base that can be used on different applications with different UI's. Currently I've run the Build with CMake example on the documentation and it worked on my linux debian machine. However I want to build tflite for android devices too so I tried the "Specifics of Android cross-compilation" part with NDK 25.0.8775105 as my path provided. It eventually did finish the cmake run. ``` ### Standalone code to reproduce the issue ```shell After that I've tried running `cmake --build .` which caused me to get an error regarding `OSError: [Errno 8] Exec format error:` I can see that it's trying to find something like `#!/bin/sh` but I cannot add it since flatc is produced and deleted during the cmake run. ``` ### Relevant log output ```shell [ 21%] Built target flathash [ 21%] Linking CXX executable flatc Running scripts/generate_code.py... Traceback (most recent call last): File "/home/tb/Desktop/tensorflow/tflite_android_build/flatbuffers/scripts/generate_code.py", line 148, in <module> flatc( File "/home/tb/Desktop/tensorflow/tflite_android_build/flatbuffers/scripts/generate_code.py", line 82, in flatc result = subprocess.run(cmd, cwd=str(cwd), check=True) File "/usr/lib/python3.9/subprocess.py", line 505, in run with Popen(*popenargs, **kwargs) as process: File "/usr/lib/python3.9/subprocess.py", line 951, in __init__ self._execute_child(args, executable, preexec_fn, close_fds, File "/usr/lib/python3.9/subprocess.py", line 1823, in _execute_child raise child_exception_type(errno_num, err_msg, err_filename) OSError: [Errno 8] Exec format error: '/home/tb/Desktop/tensorflow/tflite_android_build/_deps/flatbuffers-build/flatc' gmake[2]: *** [_deps/flatbuffers-build/CMakeFiles/flatc.dir/build.make:540: _deps/flatbuffers-build/flatc] Error 1 gmake[2]: *** Deleting file '_deps/flatbuffers-build/flatc' gmake[1]: *** [CMakeFiles/Makefile2:4987: _deps/flatbuffers-build/CMakeFiles/flatc.dir/all] Error 2 gmake: *** [Makefile:149: all] Error 2 ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59666/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59666/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59665
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59665/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59665/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59665/events
https://github.com/tensorflow/tensorflow/issues/59665
1,582,072,266
I_kwDOArmXAs5eTIHK
59,665
Cannot import tensorflow after latest tensorboard release: TypeError: Descriptors cannot not be created directly
{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1946362326, "node_id": "MDU6TGFiZWwxOTQ2MzYyMzI2", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.3", "name": "TF 2.3", "color": "1d76db", "default": false, "description": "Issues related to TF 2.3" } ]
closed
false
{ "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false }
[ { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@albertvillanova Thanks for reporting the issue.\r\n\r\nI have tried installing `tensorflow==2.3.0` and `tensorboard==2.12` and was able to import tensorflow without any error.\r\n\r\nPlease find the gist [here](https://colab.research.google.com/gist/pjpratik/9d7f805f3e64536f1531cd732c4b3980/59665.ipynb). Could you please verify and confirm the same. Thanks!", "Hi @pjpratik, thanks for your answer and for having tried to reproduce the bug.\r\n\r\nPlease note that I get the error when trying to install tensorflow-2.3.0 in a completely empty Python environment.\r\n\r\nYou are not able to reproduce the bug because in the Colab Python environment, you have `protobuf-3.19.6` already installed from the beginning, which fulfills:\r\n- protobuf>=3.9.2 from tensorflow\r\n- protobuf>=3.19.6 from tensorboard\r\n\r\nand hence it is not updated.\r\n\r\nHowever, if you start with a completely empty Python environment, the requirements above resolve to installing `protobuf-4.21.12` and then you get the bug.\r\n\r\nAlso note that there is no problem with `protobuf-3.20.3`.", "These are the dependency packages installed in an empty Python environment, when installing `tensorflow-2.3.0`:\r\n```\r\nSuccessfully installed MarkupSafe-2.1.2 absl-py-1.4.0 astunparse-1.6.3 cachetools-5.3.0 charset-normalizer-3.0.1 gast-0.3.3 google-auth-2.16.0 google-auth-oauthlib-0.4.6 google-pasta-0.2.0 grpcio-1.51.1 h5py-2.10.0 idna-3.4 importlib-metadata-6.0.0 keras-preprocessing-1.1.2 markdown-3.4.1 numpy-1.18.5 oauthlib-3.2.2 opt-einsum-3.3.0 protobuf-4.21.12 pyasn1-0.4.8 pyasn1-modules-0.2.8 requests-2.28.2 requests-oauthlib-1.3.1 rsa-4.9 scipy-1.4.1 six-1.16.0 tensorboard-2.12.0 tensorboard-data-server-0.7.0 tensorboard-plugin-wit-1.8.1 tensorflow-2.3.0 tensorflow-estimator-2.3.0 termcolor-2.2.0 urllib3-1.26.14 werkzeug-2.2.2 wrapt-1.14.1 zipp-3.13.0\r\n```", "@albertvillanova Thanks for the clarification.\r\n\r\nI was able to reproduce this issue after installing protobuf-4.21.12. Please find the gist [here](https://colab.research.google.com/gist/pjpratik/32e420ffd7e93c16b29cd0c4f6069d66/59665.ipynb).\r\n\r\n@SuryanarayanaY Could you please look into this issue. Thanks!", "Also note that there was no issue before the `tensorboard-2.12.0` release, because in that case pip resolved to `protobuf-3.20.3`:\r\n```\r\npip install \"tensorflow==2.3.0\" \"tensorboard<2.12.0\"\r\n```\r\n```\r\nSuccessfully installed MarkupSafe-2.1.2 absl-py-1.4.0 astunparse-1.6.3 cachetools-5.3.0 charset-normalizer-3.0.1 gast-0.3.3 google-auth-2.16.0 google-auth-oauthlib-0.4.6 google-pasta-0.2.0 grpcio-1.51.1 h5py-2.10.0 idna-3.4 importlib-metadata-6.0.0 keras-preprocessing-1.1.2 markdown-3.4.1 numpy-1.18.5 oauthlib-3.2.2 opt-einsum-3.3.0 protobuf-3.20.3 pyasn1-0.4.8 pyasn1-modules-0.2.8 requests-2.28.2 requests-oauthlib-1.3.1 rsa-4.9 scipy-1.4.1 six-1.16.0 tensorboard-2.11.2 tensorboard-data-server-0.6.1 tensorboard-plugin-wit-1.8.1 tensorflow-2.3.0 tensorflow-estimator-2.3.0 termcolor-2.2.0 urllib3-1.26.14 werkzeug-2.2.2 wrapt-1.14.1 zipp-3.13.0\r\n```", "Hi, Thanks for opening the issue. \r\nWe have upgraded the protobuf dependency to 3.21.9 (4.21.9) for python from Tensorflow version 2.12, which was long awaited ask.\r\nFor Tensorflow and Tensorboard 2.12 version, the protobuf minimum version requirement is `'protobuf>=3.20.3,<5.0.0dev,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5'`.\r\nFor any older Tensorflow version and new Tensorboard version the only version which acts as bridge between both is 3.20.3, which is working fine in your case.\r\nOnce the Tensorflow 2.12 is released, you can use Tensorboard 2.12 without any package conflict. ", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Thanks @sachinprasadhs.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59665\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59665\">No</a>\n" ]
2023-02-13T10:27:09
2023-03-17T21:12:52
2023-03-17T21:12:50
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.3.0 ### Custom Code No ### OS Platform and Distribution Linux Ubuntu 20.04.5 LTS ### Mobile device _No response_ ### Python version 3.8.16 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Since tensorboard-2.12.0 release, we cannot install and then import tensorflow-2.3.0. ``` ### Standalone code to reproduce the issue ```shell pip install tensorflow==2.3.0 python -c "import tensorflow" ``` ### Relevant log output ```shell Traceback (most recent call last): File "<string>", line 1, in <module> File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/__init__.py", line 41, in <module> from tensorflow.python.tools import module_util as _module_util File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/python/__init__.py", line 40, in <module> from tensorflow.python.eager import context File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/python/eager/context.py", line 32, in <module> from tensorflow.core.framework import function_pb2 File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/core/framework/function_pb2.py", line 16, in <module> from tensorflow.core.framework import attr_value_pb2 as tensorflow_dot_core_dot_framework_dot_attr__value__pb2 File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/core/framework/attr_value_pb2.py", line 16, in <module> from tensorflow.core.framework import tensor_pb2 as tensorflow_dot_core_dot_framework_dot_tensor__pb2 File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/core/framework/tensor_pb2.py", line 16, in <module> from tensorflow.core.framework import resource_handle_pb2 as tensorflow_dot_core_dot_framework_dot_resource__handle__pb2 File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/core/framework/resource_handle_pb2.py", line 16, in <module> from tensorflow.core.framework import tensor_shape_pb2 as tensorflow_dot_core_dot_framework_dot_tensor__shape__pb2 File ".../venv-py38-tf/lib/python3.8/site-packages/tensorflow/core/framework/tensor_shape_pb2.py", line 36, in <module> _descriptor.FieldDescriptor( File ".../venv-py38-tf/lib/python3.8/site-packages/google/protobuf/descriptor.py", line 560, in __new__ _message.Message._CheckCalledFromGeneratedFile() TypeError: Descriptors cannot not be created directly. If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0. If you cannot immediately regenerate your protos, some other possible workarounds are: 1. Downgrade the protobuf package to 3.20.x or lower. 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower). More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59665/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59665/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59664
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59664/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59664/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59664/events
https://github.com/tensorflow/tensorflow/pull/59664
1,582,000,738
PR_kwDOArmXAs5J1ND9
59,664
[Linaro:ARM_CI] Add tag filters to exclude tests tagged no_oss_py3x
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }, { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-13T09:49:07
2023-03-06T09:29:11
2023-02-13T20:50:36
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59664", "html_url": "https://github.com/tensorflow/tensorflow/pull/59664", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59664.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59664.patch", "merged_at": "2023-02-13T20:50:36" }
Currently there is only 1 relevant test which is tagged no_oss_py38 but it segfaults with Python 3.8 so should be excluded Fixes #59643
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59664/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59664/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59663
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59663/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59663/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59663/events
https://github.com/tensorflow/tensorflow/issues/59663
1,581,654,256
I_kwDOArmXAs5eRiDw
59,663
zsh: illegal hardware instruction Run on MAC M2
{ "login": "aim2002", "id": 125238403, "node_id": "U_kgDOB3b8gw", "avatar_url": "https://avatars.githubusercontent.com/u/125238403?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aim2002", "html_url": "https://github.com/aim2002", "followers_url": "https://api.github.com/users/aim2002/followers", "following_url": "https://api.github.com/users/aim2002/following{/other_user}", "gists_url": "https://api.github.com/users/aim2002/gists{/gist_id}", "starred_url": "https://api.github.com/users/aim2002/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aim2002/subscriptions", "organizations_url": "https://api.github.com/users/aim2002/orgs", "repos_url": "https://api.github.com/users/aim2002/repos", "events_url": "https://api.github.com/users/aim2002/events{/privacy}", "received_events_url": "https://api.github.com/users/aim2002/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1205765054, "node_id": "MDU6TGFiZWwxMjA1NzY1MDU0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:macOS", "name": "subtype:macOS", "color": "b619ea", "default": false, "description": "macOS Build/Installation issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @aim2002 \r\n\r\nI'm not sure which instructions are you following but I'm able to install Tensorflow on `Apple M1 Pro` and it should work on `Mac M2` also so you can install Tensorlflow by using one of the `Conda`, `Miniconda` or `Miniforge` approach so I followed [Get started with tensorflow-metal](https://developer.apple.com/metal/tensorflow-plugin/) with `Miniconda3` instructions so could you please try with `arm64 : Apple silicon`\r\n\r\nWhile following the instructions and after clicking on [Download Conda environment ](https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-arm64.sh) `Miniconda3-latest-MacOSX-arm64.sh` file will be downloaded and replace that `.sh` file with `miniconda.sh` in command `bash ~/miniconda.sh -b -p $HOME/miniconda `as shown below in first step 1. Set up and please follow all steps from `2. Install base TensorFlow` as it is :\r\n\r\n```\r\nbash ~/Miniconda3-latest-MacOSX-arm64.sh -b -p $HOME/miniconda\r\nsource ~/miniconda/bin/activate\r\nconda install -c apple tensorflow-deps\r\n```\r\nYou'll have to use this command `source ~/miniconda/bin/activate` whenever you want to use/activate `Miniconda` environment \r\n\r\nIf you're looking to go with `Miniforge` approach then please refer this [Article](https://caffeinedev.medium.com/how-to-install-tensorflow-on-m1-mac-8e9b91d93706) and for [Miniconda-Article](https://medium.com/mlearning-ai/install-tensorflow-on-mac-m1-m2-with-gpu-support-c404c6cfb580) and also please refer [Releases-Table](https://developer.apple.com/metal/tensorflow-plugin/#:~:text=Releases-,tensorflow%2Dmacos,Distributed%20training,-Troubleshooting)\r\n\r\nI have added screenshot for your reference below, \r\n\r\n![image](https://user-images.githubusercontent.com/115997457/218498891-4990a9fb-c2a0-4a8d-a46c-3f2bdf84cbd5.png)\r\n\r\nIf issue still persists, please let us know? or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!\r\n", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59663\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59663\">No</a>\n", "Mac mini M2. Used pip install tensorflow. \r\nAs soon as I import tensorflow in my python script I am getting:\r\n`zsh: illegal hardware instruction`\r\n" ]
2023-02-13T04:54:55
2024-03-31T20:38:07
2023-02-27T17:07:05
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### OS Platform and Distribution 13.1 (22C65) ### Mobile device _No response_ ### Python version Python 3.9.12 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell A bug happened! Help me pleaseee tensorboard 2.11.2 tensorboard-data-server 0.6.1 tensorboard-plugin-wit 1.8.1 tensorflow 2.11.0 tensorflow-estimator 2.11.0 tensorflow-io-gcs-filesystem 0.29.0 ``` ### Standalone code to reproduce the issue ```shell zsh: illegal hardware instruction ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59663/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59663/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59662
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59662/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59662/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59662/events
https://github.com/tensorflow/tensorflow/issues/59662
1,581,536,298
I_kwDOArmXAs5eRFQq
59,662
The structure of the model generated is incorrect, the input tensors of the concatenate operator have changed from 4 different tensors to 3 different tensors plus one duplicated tensor
{ "login": "Sun2018421", "id": 38587877, "node_id": "MDQ6VXNlcjM4NTg3ODc3", "avatar_url": "https://avatars.githubusercontent.com/u/38587877?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sun2018421", "html_url": "https://github.com/Sun2018421", "followers_url": "https://api.github.com/users/Sun2018421/followers", "following_url": "https://api.github.com/users/Sun2018421/following{/other_user}", "gists_url": "https://api.github.com/users/Sun2018421/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sun2018421/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sun2018421/subscriptions", "organizations_url": "https://api.github.com/users/Sun2018421/orgs", "repos_url": "https://api.github.com/users/Sun2018421/repos", "events_url": "https://api.github.com/users/Sun2018421/events{/privacy}", "received_events_url": "https://api.github.com/users/Sun2018421/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "arfaian", "id": 1106365, "node_id": "MDQ6VXNlcjExMDYzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1106365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arfaian", "html_url": "https://github.com/arfaian", "followers_url": "https://api.github.com/users/arfaian/followers", "following_url": "https://api.github.com/users/arfaian/following{/other_user}", "gists_url": "https://api.github.com/users/arfaian/gists{/gist_id}", "starred_url": "https://api.github.com/users/arfaian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arfaian/subscriptions", "organizations_url": "https://api.github.com/users/arfaian/orgs", "repos_url": "https://api.github.com/users/arfaian/repos", "events_url": "https://api.github.com/users/arfaian/events{/privacy}", "received_events_url": "https://api.github.com/users/arfaian/received_events", "type": "User", "site_admin": false }
[ { "login": "arfaian", "id": 1106365, "node_id": "MDQ6VXNlcjExMDYzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1106365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arfaian", "html_url": "https://github.com/arfaian", "followers_url": "https://api.github.com/users/arfaian/followers", "following_url": "https://api.github.com/users/arfaian/following{/other_user}", "gists_url": "https://api.github.com/users/arfaian/gists{/gist_id}", "starred_url": "https://api.github.com/users/arfaian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arfaian/subscriptions", "organizations_url": "https://api.github.com/users/arfaian/orgs", "repos_url": "https://api.github.com/users/arfaian/repos", "events_url": "https://api.github.com/users/arfaian/events{/privacy}", "received_events_url": "https://api.github.com/users/arfaian/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "All the details are in the colab file, and I would like to know if this situation is a bug or an internal optimization of the converter. If it is an optimization, can I turn it off because I only want the model structure for later use and not for inference speed. Thank you for your help.", "@Sun2018421 \r\nI was able to reproduce the issue on colab using TF v2.11. Please find the gist [here](https://colab.research.google.com/gist/tiruk007/92b83900215f08fef3ea53a1dc9e5dfe/tflite.ipynb) for reference. It seems like we have to dig more into this issue, we will update soon here.\r\n\r\nThank you!", "Okay, Thank you", "@Sun2018421 Sorry for the delayed response.\r\n\r\nThe tflite converter may flatten/prune the graph during conversion process for better optimization. If the model structure needs to be retained, the converter can be used with just using select ops. Please refer the [gist](https://colab.research.google.com/gist/pjpratik/c0d1aaddce410eca58a3b5cdd35cd926/59662.ipynb).\r\n\r\nAlso, we can use [TFLite Model Anylzer](https://www.tensorflow.org/lite/guide/model_analyzer) to analyze tflite model structure and [Quantization Debugger](https://www.tensorflow.org/lite/performance/quantization_debugger) to assist the quantization debugging process. \r\n\r\nThanks!", "Thank you very much, I will go read and understand it.", "As you mentioned, \"the converter can be used with just using select ops\". Do you have any related information about the converter? Thank you. The docs that I know are https://www.tensorflow.org/lite/convert?hl=zh-cn.", "@Sun2018421 As per the select ops [documentation](https://www.tensorflow.org/lite/guide/ops_select), the select ops can be used for the ops which are not present in TFLite builtins. But using select ops might increase Tensorflow Lite binary size. \r\n\r\nI have observed that when just select ops is used, the concat operator is indeed taking four different inputs but not in the case when tflite builtins are added when observed in the [gist](https://colab.research.google.com/gist/pjpratik/c0d1aaddce410eca58a3b5cdd35cd926/59662.ipynb).\r\n\r\n![image](https://user-images.githubusercontent.com/118897289/219879317-7f53548e-e9c7-4155-ab01-2f33d3379c3d.png)\r\n\r\n\r\nMay I know the use case of requiring model structure but not for inference speed? Thanks.", "Thank you very much for your help. I will go and take a look, as my current work focuses on operator scheduling and intermediate tensor memory, as mentioned in the [paper](https://arxiv.org/abs/2003.02369) Therefore, I would prefer to have a clear network structure for analysis. I am not an experienced researcher, so my naive questions may have caused you some trouble. Thanks again for your help.", "Sorry for the feedback for so long, when i check the network structure in [gist](https://colab.research.google.com/gist/pjpratik/c0d1aaddce410eca58a3b5cdd35cd926/59662.ipynb#scrollTo=DsRBbVLeL_9x), I find it still has 1 repeated input, Op#68 FlexConcatV2(T#216, T#217, T#218, T#217, T#2[1]) -> [T#219]. I am trying select ops or tflite builtins , but i am working on some errors when converting. Thanks very much.", "Hi @Sun2018421, Thanks for the information.\r\n\r\n@sachinprasadhs Could you please look into this issue. Thanks!", "Hi, The code which you have provided is quite large to debug. \r\nCould you please provide simple reproducible example and attach the Gist. Thanks!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59662\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59662\">No</a>\n" ]
2023-02-13T02:30:04
2023-06-09T02:07:40
2023-06-09T02:07:38
NONE
null
null
null
### 1. System information - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): windos10 - TensorFlow installation (pip package or built from source): pip - TensorFlow library (version, if pip package or github SHA, if built from source): version 2.9.1 ### 2. Code Provide code to help us reproduce your issues using one of the following options: #### Option B: Paste your code here or provide a link to a custom end-to-end colab This is the file weblink https://colab.research.google.com/gist/Sun2018421/73059bdd906fd84313f3dd7714cbcc7e/tflite.ipynb ### 3. Failure after conversion If the conversion is successful, but the generated model is wrong, then state what is wrong: It seems like there is an error in the structure of the model generated. The original structure of the concatenate operator with 4 different inputs has become 3 different inputs and 1 repeated input. ### 4. (optional) RNN conversion support If converting TF RNN to TFLite fused RNN ops, please prefix [RNN] in the title. Not a RNN ### 5. (optional) Any other info / logs Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59662/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59662/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59661
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59661/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59661/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59661/events
https://github.com/tensorflow/tensorflow/pull/59661
1,581,514,130
PR_kwDOArmXAs5Jzj2v
59,661
Fix record_input bug when file_parallelism is less than 0
{ "login": "yongtang", "id": 6932348, "node_id": "MDQ6VXNlcjY5MzIzNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/6932348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yongtang", "html_url": "https://github.com/yongtang", "followers_url": "https://api.github.com/users/yongtang/followers", "following_url": "https://api.github.com/users/yongtang/following{/other_user}", "gists_url": "https://api.github.com/users/yongtang/gists{/gist_id}", "starred_url": "https://api.github.com/users/yongtang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yongtang/subscriptions", "organizations_url": "https://api.github.com/users/yongtang/orgs", "repos_url": "https://api.github.com/users/yongtang/repos", "events_url": "https://api.github.com/users/yongtang/events{/privacy}", "received_events_url": "https://api.github.com/users/yongtang/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" }, { "id": 1178505529, "node_id": "MDU6TGFiZWwxMTc4NTA1NTI5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/prtype:bugfix", "name": "prtype:bugfix", "color": "159b2e", "default": false, "description": "PR to fix a bug" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Please squash the commits", "Thanks @mihaimaruseac PR has been updated with commits squashed. Please take a look." ]
2023-02-13T01:59:17
2023-03-06T22:04:04
2023-02-14T04:24:10
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59661", "html_url": "https://github.com/tensorflow/tensorflow/pull/59661", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59661.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59661.patch", "merged_at": "2023-02-14T04:24:10" }
This PR tries to fix #59123 where file_parallelism <0 will cause a crash in record_input. Signed-off-by: Yong Tang <[email protected]>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59661/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59661/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59660
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59660/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59660/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59660/events
https://github.com/tensorflow/tensorflow/pull/59660
1,581,493,951
PR_kwDOArmXAs5JzfoM
59,660
Fix crash when invalid input was provided to ragged_tensor_to_variant
{ "login": "yongtang", "id": 6932348, "node_id": "MDQ6VXNlcjY5MzIzNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/6932348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yongtang", "html_url": "https://github.com/yongtang", "followers_url": "https://api.github.com/users/yongtang/followers", "following_url": "https://api.github.com/users/yongtang/following{/other_user}", "gists_url": "https://api.github.com/users/yongtang/gists{/gist_id}", "starred_url": "https://api.github.com/users/yongtang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yongtang/subscriptions", "organizations_url": "https://api.github.com/users/yongtang/orgs", "repos_url": "https://api.github.com/users/yongtang/repos", "events_url": "https://api.github.com/users/yongtang/events{/privacy}", "received_events_url": "https://api.github.com/users/yongtang/received_events", "type": "User", "site_admin": false }
[ { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" }, { "id": 1178505529, "node_id": "MDU6TGFiZWwxMTc4NTA1NTI5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/prtype:bugfix", "name": "prtype:bugfix", "color": "159b2e", "default": false, "description": "PR to fix a bug" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks @cantonios . The PR has been updated. \r\n\r\nIn the past I did notice that internal tests may have different error codes. Not sure the change will cover all scenarios in internal tests. Please let me know if there are additional failures in internal tests.", "\r\nHere are the internal errors, @yongtang can you please verify ? Thank you!\r\n\r\nDuring handling of the above exception, another exception occurred:\r\nTraceback (most recent call last):\r\n File \"/tensorflow/python/framework/test_util.py\", line 1526, in decorated\r\n run_eagerly(self, **kwargs)\r\n File \"/tensorflow/python/framework/test_util.py\", line 1510, in run_eagerly\r\n f(self, *args, **kwargs)\r\n File \"/tensorflow/python/ops/ragged/ragged_tensor_test.py\", line 2019, in testToVariantInvalidInputs\r\n self.assertRaisesRegex(\r\nAssertionError: \"must be less than 0, got 0|Shape must be at least rank 1 but is rank 0\" does not match \"{{function_node __wrapped__RaggedTensorToVariant_RAGGED_RANK_1_device_/job:localhost/replica:0/task:0/device:CPU:0}} Requires the first element of nested_row_splits[0] to be 0 but is 150 [Op:RaggedTensorToVariant]\"\r\n", "There might be some skew in Graph mode (shape inference error) vs eager mode (kernel check) error messages. Maybe look at the shape inference for this particular op?", "Hi @yongtang Any update on this PR? Please. Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "This PR was closed because it has been inactive for 14 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-02-13T01:26:42
2023-04-19T01:55:57
2023-04-19T01:55:52
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59660", "html_url": "https://github.com/tensorflow/tensorflow/pull/59660", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59660.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59660.patch", "merged_at": null }
This PR fixes #59084 by return error in case invalid shape set_dim is called. Signed-off-by: Yong Tang <[email protected]>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59660/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59660/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59659
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59659/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59659/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59659/events
https://github.com/tensorflow/tensorflow/pull/59659
1,581,429,253
PR_kwDOArmXAs5JzS7F
59,659
Updated Install libffi7 package step
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!" ]
2023-02-12T22:15:12
2023-07-25T11:42:06
2023-07-25T11:42:05
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59659", "html_url": "https://github.com/tensorflow/tensorflow/pull/59659", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59659.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59659.patch", "merged_at": "2023-07-25T11:42:05" }
While following the [TensorFlow Lite C++ minimal example](https://github.com/tensorflow/tensorflow/edit/master/tensorflow/lite/examples/minimal/README.md) instructions I encountered issue with `libffi7` package ([libffi.so.7: cannot open shared object file: No such file or directory](https://askubuntu.com/questions/1286772/libffi-so-7-cannot-open-shared-object-file-no-such-file-or-directory)) because since `Ubuntu 20.10` comes with `libff8` instead of `libffi7` and in TensorFlow Lite C++ minimal example it's still using `libffi7` package so we have to install `libffi7` by manually downloading the deb package from ubuntu focal (20.04) By following below steps so It's better to add below steps for Ubuntu users who are using `Ubuntu 20.10 or later `version to handle `libffi.so.7: cannot open shared object file: No such file or directory` error in our official documentation of [TensorFlow Lite C++ minimal example](https://github.com/tensorflow/tensorflow/edit/master/tensorflow/lite/examples/minimal/README.md) so please do the needful. Thank you! ``` 1. wget http://es.archive.ubuntu.com/ubuntu/pool/main/libf/libffi/libffi7_3.3-4_amd64.deb 2. sudo dpkg -i libffi7_3.3-4_amd64.deb ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59659/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59659/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59658
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59658/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59658/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59658/events
https://github.com/tensorflow/tensorflow/pull/59658
1,581,355,504
PR_kwDOArmXAs5JzE0y
59,658
Fix crash in ragged_cross where the ragged tensor input is invalid
{ "login": "yongtang", "id": 6932348, "node_id": "MDQ6VXNlcjY5MzIzNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/6932348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yongtang", "html_url": "https://github.com/yongtang", "followers_url": "https://api.github.com/users/yongtang/followers", "following_url": "https://api.github.com/users/yongtang/following{/other_user}", "gists_url": "https://api.github.com/users/yongtang/gists{/gist_id}", "starred_url": "https://api.github.com/users/yongtang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yongtang/subscriptions", "organizations_url": "https://api.github.com/users/yongtang/orgs", "repos_url": "https://api.github.com/users/yongtang/repos", "events_url": "https://api.github.com/users/yongtang/events{/privacy}", "received_events_url": "https://api.github.com/users/yongtang/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" }, { "id": 1178505529, "node_id": "MDU6TGFiZWwxMTc4NTA1NTI5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/prtype:bugfix", "name": "prtype:bugfix", "color": "159b2e", "default": false, "description": "PR to fix a bug" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@mihaimaruseac @cantonios PR has been updated with commits merged. Please take a look." ]
2023-02-12T18:09:25
2023-02-14T12:01:01
2023-02-14T05:38:56
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59658", "html_url": "https://github.com/tensorflow/tensorflow/pull/59658", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59658.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59658.patch", "merged_at": "2023-02-14T05:38:56" }
This PR tries to address the issue raised in #59114 where ragged_cross will crash when input is invalid. This PR fixes #59114. Signed-off-by: Yong Tang <[email protected]>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59658/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59658/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59657
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59657/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59657/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59657/events
https://github.com/tensorflow/tensorflow/pull/59657
1,581,323,857
PR_kwDOArmXAs5Jy-ok
59,657
Softmax fix in Mixed Precision
{ "login": "dsr-lab", "id": 43779403, "node_id": "MDQ6VXNlcjQzNzc5NDAz", "avatar_url": "https://avatars.githubusercontent.com/u/43779403?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dsr-lab", "html_url": "https://github.com/dsr-lab", "followers_url": "https://api.github.com/users/dsr-lab/followers", "following_url": "https://api.github.com/users/dsr-lab/following{/other_user}", "gists_url": "https://api.github.com/users/dsr-lab/gists{/gist_id}", "starred_url": "https://api.github.com/users/dsr-lab/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dsr-lab/subscriptions", "organizations_url": "https://api.github.com/users/dsr-lab/orgs", "repos_url": "https://api.github.com/users/dsr-lab/repos", "events_url": "https://api.github.com/users/dsr-lab/events{/privacy}", "received_events_url": "https://api.github.com/users/dsr-lab/received_events", "type": "User", "site_admin": false }
[ { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59657/checks?check_run_id=11283700124) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "Hi @dsr-lab It looks like your PR relates to the Keras component. Please submit it to the github.com/keras-team/keras repository instead. Thankyou.\r\n@fchollet, @qlzh727" ]
2023-02-12T16:37:04
2023-02-15T06:35:41
2023-02-15T06:35:38
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59657", "html_url": "https://github.com/tensorflow/tensorflow/pull/59657", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59657.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59657.patch", "merged_at": null }
## Contributors: * Gaetano Signorelli (https://github.com/gaetano-signorelli) * Daniele Sirocchi (https://github.com/dsr-lab) ## Description We found a possible bug in the implementation of the *Softmax* activation. In particular, we noticed learning issues when we trained a model with Mixed Precision (https://www.tensorflow.org/guide/mixed_precision) coupled with MultiHeadAttention (https://www.tensorflow.org/api_docs/python/tf/keras/layers/MultiHeadAttention). The potential problem is located in the following lines of code (see line 338 in module *advanced_activations.py*): ``` adder = (1.0 - math_ops.cast(mask, inputs.dtype)) * ( _large_compatible_negative(inputs.dtype)) ... inputs += adder ``` Specifically, the method **_large_compatible_negative** returns a value that is **too negatively large** when the data type is float16 (i.e., the mixed precision is enabled), and it causes **overflows** when the *adder* variable is combined with the *inputs*. Therefore, our model was unable to learn during the training procedure. Our fix consisted in moving this value away from the overflow edge, scaling it, but without changing the role of the **_large_compatible_negative** method, namely to return a big negative value to mask some parts of the inputs. After this fix, our model trained smoothly, and it was eventually able to learn how to solve our task.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59657/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59657/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59656
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59656/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59656/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59656/events
https://github.com/tensorflow/tensorflow/pull/59656
1,581,322,601
PR_kwDOArmXAs5Jy-aT
59,656
Fix MapPeek crash when key is not a scaler
{ "login": "yongtang", "id": 6932348, "node_id": "MDQ6VXNlcjY5MzIzNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/6932348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yongtang", "html_url": "https://github.com/yongtang", "followers_url": "https://api.github.com/users/yongtang/followers", "following_url": "https://api.github.com/users/yongtang/following{/other_user}", "gists_url": "https://api.github.com/users/yongtang/gists{/gist_id}", "starred_url": "https://api.github.com/users/yongtang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yongtang/subscriptions", "organizations_url": "https://api.github.com/users/yongtang/orgs", "repos_url": "https://api.github.com/users/yongtang/repos", "events_url": "https://api.github.com/users/yongtang/events{/privacy}", "received_events_url": "https://api.github.com/users/yongtang/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 703812914, "node_id": "MDU6TGFiZWw3MDM4MTI5MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/kokoro:force-run", "name": "kokoro:force-run", "color": "1d76db", "default": false, "description": "Tests on submitted change" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364458, "node_id": "MDU6TGFiZWwxMTY5MzY0NDU4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:S", "name": "size:S", "color": "adafea", "default": false, "description": "CL Change Size: Small" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Also, please squash all commits, we don't need 3 commits for a check and a test.", "Thanks @cantonios. The PR has been updated with `with self.session():` removed. Let me know if this works (I see most of the other tests seems to have this)", "Thanks @mihaimaruseac The PR has been updated with commits merged. Please take a look.\r\n", "@mihaimaruseac (In github there is an option in settings which allows the \"squash merge\" that can do the squash merge automatically when merge. This allows adjustments of try/revert tests in different sections while also keep the final commit history linear/clean.\r\n\r\nUnderstand tensorflow has an internal merge system, though maybe something similar to \"squash merge\" can be considered as well?\r\n\r\n_Below is a screenshot of the config in some other repos:_\r\n\r\n-------\r\n\r\n<img width=\"814\" alt=\"screenshot\" src=\"https://user-images.githubusercontent.com/6932348/218561562-4d8f417e-ae25-4f17-8f8b-37379863c978.png\">\r\n\r\n", "That would be ideal, but unfortunately it requires significant changes in Copybara, so instead we're suggesting squashes on PRs if we can. This is useful for vuln fixes as it is easier to cherrypick a squashed commit than 3 commits on a fix." ]
2023-02-12T16:33:00
2023-02-17T22:08:19
2023-02-17T17:49:46
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59656", "html_url": "https://github.com/tensorflow/tensorflow/pull/59656", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59656.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59656.patch", "merged_at": "2023-02-17T17:49:46" }
This PR tries to address the issue raised in #58271 where MapPeek will crash when key is not a scaler. This PR fixes #58271. Signed-off-by: Yong Tang <[email protected]>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59656/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59656/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59655
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59655/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59655/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59655/events
https://github.com/tensorflow/tensorflow/issues/59655
1,581,318,084
I_kwDOArmXAs5eQP_E
59,655
Tensorboard shows huge idle time and no blank spaces on GPU
{ "login": "alex19999", "id": 25909133, "node_id": "MDQ6VXNlcjI1OTA5MTMz", "avatar_url": "https://avatars.githubusercontent.com/u/25909133?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alex19999", "html_url": "https://github.com/alex19999", "followers_url": "https://api.github.com/users/alex19999/followers", "following_url": "https://api.github.com/users/alex19999/following{/other_user}", "gists_url": "https://api.github.com/users/alex19999/gists{/gist_id}", "starred_url": "https://api.github.com/users/alex19999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alex19999/subscriptions", "organizations_url": "https://api.github.com/users/alex19999/orgs", "repos_url": "https://api.github.com/users/alex19999/repos", "events_url": "https://api.github.com/users/alex19999/events{/privacy}", "received_events_url": "https://api.github.com/users/alex19999/received_events", "type": "User", "site_admin": false }
[ { "id": 284285184, "node_id": "MDU6TGFiZWwyODQyODUxODQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:tensorboard", "name": "comp:tensorboard", "color": "0052cc", "default": false, "description": "Tensorboard related issues" }, { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547538, "node_id": "MDU6TGFiZWwxMDk3NTQ3NTM4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu", "name": "comp:gpu", "color": "0052cc", "default": false, "description": "GPU related issues" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @alex19999, \r\nIn order to expedite the trouble-shooting process, kindly share complete reproducible code to replicate the issue reported here. Thank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59655\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59655\">No</a>\n" ]
2023-02-12T16:19:29
2023-03-01T18:07:06
2023-03-01T18:07:03
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version tf. 2.9 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu 20.04 ### Mobile device Linux Ubuntu 20.04 ### Python version 3.9 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.3 ### GPU model and memory Nvidia GeForce RTX 3090 ### Current Behaviour? ```shell I'm new to TF profiler and tensorboard. Could you please tell me how GPU idle time is calculated? I see contradictory data in profiling information on tensorboard and no information about it in docs: - I have no blank spaces in events trace (GPU compute stream) presented on `trace_viewer` page. - Wherein device (GPU) idle time shown on `tensorflow_stats` page is about 50%??? It's what I see when I use small batch size. After increasing batch size, same situation is on `trace_viewer` page, but GPU idle time decreased up to 7%. So, how is idle time calculated? By the way, another two questions: 1. What is `steps` on `trace_viewer` page? 2. Why does `trace_viewer` page contain only a part of profiling time? I profiled about 100 seconds of execution, but I see only 10 seconds on `trace_viewer` page. Thanks a lot in advance! ``` ### Standalone code to reproduce the issue ```shell I've used next setup: tf.profiler.experimental.start <training> tf.profiler.experimental.end ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59655/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59655/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59654
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59654/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59654/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59654/events
https://github.com/tensorflow/tensorflow/issues/59654
1,581,097,022
I_kwDOArmXAs5ePaA-
59,654
Tf 2.11 Optimizers. Does anyone have any custom optimizer for the new version?
{ "login": "thewizardnet", "id": 119863716, "node_id": "U_kgDOByT5pA", "avatar_url": "https://avatars.githubusercontent.com/u/119863716?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thewizardnet", "html_url": "https://github.com/thewizardnet", "followers_url": "https://api.github.com/users/thewizardnet/followers", "following_url": "https://api.github.com/users/thewizardnet/following{/other_user}", "gists_url": "https://api.github.com/users/thewizardnet/gists{/gist_id}", "starred_url": "https://api.github.com/users/thewizardnet/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thewizardnet/subscriptions", "organizations_url": "https://api.github.com/users/thewizardnet/orgs", "repos_url": "https://api.github.com/users/thewizardnet/repos", "events_url": "https://api.github.com/users/thewizardnet/events{/privacy}", "received_events_url": "https://api.github.com/users/thewizardnet/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "class Gravity(tf.keras.optimizers.Optimizer):\r\n def __init__(self,\r\n learning_rate=0.1,\r\n alpha=0.01,\r\n beta=0.9,\r\n name=\"Gravity\",\r\n **kwargs):\r\n super(Gravity, self).__init__(name, **kwargs)\r\n self._set_hyper('learning_rate', kwargs.get('lr', learning_rate))\r\n self._set_hyper('alpha', alpha)\r\n self._set_hyper('beta', beta)\r\n self.epsilon = 1e-7\r\n\r\n def _create_slots(self, var_list):\r\n alpha = self._get_hyper(\"alpha\")\r\n stddev = alpha / self._hyper['learning_rate']\r\n initializer = tf.keras.initializers.RandomNormal(mean=0.0,\r\n stddev=stddev,\r\n seed=None)\r\n for var in var_list:\r\n self.add_slot(var, \"velocity\", initializer=initializer)\r\n\r\n @tf.function\r\n def _resource_apply_dense(self, grad, var):\r\n # Get Data\r\n var_dtype = var.dtype.base_dtype\r\n lr_t = self._get_hyper('learning_rate', var_dtype)\r\n beta = self._get_hyper(\"beta\", var_dtype)\r\n t = tf.cast(self.iterations, float)\r\n beta_hat = (beta * t + 1) / (t + 2)\r\n velocity = self.get_slot(var, \"velocity\")\r\n\r\n # Calculations\r\n max_step_grad = 1 / tf.math.reduce_max(tf.math.abs(grad))\r\n gradient_term = grad / (1 + (grad / max_step_grad)**2)\r\n\r\n # update variables\r\n updated_velocity = velocity.assign(beta_hat * velocity +\r\n (1 - beta_hat) * gradient_term)\r\n updated_var = var.assign(var - lr_t * updated_velocity)\r\n\r\n def get_config(self):\r\n config = super(Gravity, self).get_config()\r\n config.update({\r\n 'learning_rate': self._get_hyper('learning_rate'),\r\n 'alpha': self._get_hyper('alpha'),\r\n 'beta': self._get_hyper('beta'),\r\n 'epsilon': self.epsilon,\r\n })\r\n return config\r\n", "Thank you, sir, but still not working.", "Let me know if this one works:\r\n\r\n```\r\nfrom tensorflow.keras import optimizers\r\n\r\nclass Gravity(optimizers.Optimizer):\r\n def __init__(self, learning_rate=0.1, alpha=0.01, beta=0.9, name=\"Gravity\", **kwargs):\r\n super(Gravity, self).__init__(name, **kwargs)\r\n self._set_hyper(\"learning_rate\", kwargs.get(\"lr\", learning_rate))\r\n self._set_hyper(\"decay\", self._initial_decay)\r\n self._set_hyper(\"alpha\", alpha)\r\n self._set_hyper(\"beta\", beta)\r\n self.epsilon = 1e-7\r\n\r\n def _create_slots(self, var_list):\r\n alpha = self._get_hyper(\"alpha\")\r\n stddev = alpha / self._get_hyper(\"learning_rate\")\r\n initializer = tf.keras.initializers.RandomNormal(mean=0.0, stddev=stddev, seed=None)\r\n for var in var_list:\r\n self.add_slot(var, \"velocity\", initializer=initializer)\r\n\r\n @tf.function\r\n def _resource_apply_dense(self, grad, var):\r\n var_dtype = var.dtype.base_dtype\r\n lr_t = self._decayed_lr(var_dtype)\r\n beta = self._get_hyper(\"beta\", var_dtype)\r\n t = tf.cast(self.iterations, var_dtype)\r\n beta_hat = (beta * t + 1) / (t + 2)\r\n velocity = self.get_slot(var, \"velocity\")\r\n\r\n max_step_grad = 1 / tf.math.reduce_max(tf.math.abs(grad))\r\n gradient_term = grad / (1 + (grad / max_step_grad)**2)\r\n\r\n updated_velocity = velocity.assign(beta_hat * velocity + (1 - beta_hat) * gradient_term)\r\n updated_var = var.assign_sub(lr_t * updated_velocity)\r\n\r\n return tf.group(updated_var.op, updated_velocity.op)\r\n\r\n def _resource_apply_sparse(self, grad, var):\r\n raise NotImplementedError\r\n\r\n def get_config(self):\r\n config = super(Gravity, self).get_config()\r\n config.update({\r\n \"learning_rate\": self._serialize_hyperparameter(\"learning_rate\"),\r\n \"decay\": self._serialize_hyperparameter(\"decay\"),\r\n \"alpha\": self._serialize_hyperparameter(\"alpha\"),\r\n \"beta\": self._serialize_hyperparameter(\"beta\"),\r\n \"epsilon\": self.epsilon,\r\n })\r\n return config\r\n\r\n```", "Still don't work \"'Gravity' object has no attribute '_set_hyper'\"", "@thewizardnet,\r\nI tried to execute the given code on tensorflow v2.13.0-dev20230215 and was able to execute without any issue/error.\r\nKindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/73916eea18f60811e7126614a21548bf/untitled965.ipynb).\r\n\r\nThe Optimizer issue comes from the fact that we call a **private _decayed_lr** method on the optimizer, which is not supported on the LossScaleOptimizer:\r\n\r\nPlease take a look at this https://github.com/tensorflow/models/issues/9262#issuecomment-696420425 and follow the steps as provided in the comment. Thank you!", "Hey, @tilakrayal thank you so much. I did not have a chance to look too much into the docs and know the issues, but I am glad that I got the solution.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59654\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59654\">No</a>\n", "> @thewizardnet, I tried to execute the given code on tensorflow v2.13.0-dev20230215 and was able to execute without any issue/error. Kindly find the gist of it [here](https://colab.research.google.com/gist/tilakrayal/73916eea18f60811e7126614a21548bf/untitled965.ipynb).\r\n> \r\n> The Optimizer issue comes from the fact that we call a **private _decayed_lr** method on the optimizer, which is not supported on the LossScaleOptimizer:\r\n> \r\n> Please take a look at this [tensorflow/models#9262 (comment)](https://github.com/tensorflow/models/issues/9262#issuecomment-696420425) and follow the steps as provided in the comment. Thank you!\r\n\r\nHi @tilakrayal @thewizardnet, I have run the snippet, replaced the version with `!pip install tf-nightly==2.14.0.dev20230701`, and instantiated the defined classed as\r\n\r\n```console\r\ng = Gravity()\r\n---------------------------------------------------------------------------\r\nAttributeError Traceback (most recent call last)\r\n[<ipython-input-4-7aa23255a1d6>](https://localhost:8080/#) in <cell line: 1>()\r\n----> 1 g = Gravity()\r\n\r\n[<ipython-input-3-65b6fe06e5d4>](https://localhost:8080/#) in __init__(self, learning_rate, alpha, beta, name, **kwargs)\r\n 12 **kwargs):\r\n 13 super(Gravity, self).__init__(name, **kwargs)\r\n---> 14 self._set_hyper('learning_rate', kwargs.get('lr', learning_rate))\r\n 15 self._set_hyper('decay', self._initial_decay)\r\n 16 self._set_hyper('alpha', alpha)\r\n\r\nAttributeError: 'Gravity' object has no attribute '_set_hyper'\r\n```\r\n\r\nMeanwhile, I think the main question here is whether we have an internal `_set_hyper` in the new `tf.keras.optimizers.Optimizer` to offer similar functionality as in `tf.keras.optimizers.legacy.Optimizer`. Can you shed some light on that?" ]
2023-02-12T02:56:29
2023-07-01T21:29:12
2023-02-17T11:41:48
NONE
null
null
null
I know that we can use tf.keras.optimizers.legacy.Optimizer for making the older custom optimizers to work,but I'm wonder how I can update my code.This the original code that I want to make it function for tf 2.11 `class Gravity(tf.keras.optimizers.Optimizer): def __init__(self, learning_rate=0.1, alpha=0.01, beta=0.9, name="Gravity", **kwargs): super(Gravity, self).__init__(name, **kwargs) self._set_hyper('learning_rate', kwargs.get('lr', learning_rate)) self._set_hyper('decay', self._initial_decay) self._set_hyper('alpha', alpha) self._set_hyper('beta', beta) self.epsilon = 1e-7 def _create_slots(self, var_list): alpha = self._get_hyper("alpha") stddev = alpha / self.learning_rate initializer = tf.keras.initializers.RandomNormal(mean=0.0, stddev=stddev, seed=None) for var in var_list: self.add_slot(var, "velocity", initializer=initializer) @tf.function def _resource_apply_dense(self, grad, var): # Get Data var_dtype = var.dtype.base_dtype lr_t = self._decayed_lr(var_dtype) beta = self._get_hyper("beta", var_dtype) t = tf.cast(self.iterations, float) beta_hat = (beta * t + 1) / (t + 2) velocity = self.get_slot(var, "velocity") # Calculations max_step_grad = 1 / tf.math.reduce_max(tf.math.abs(grad)) gradient_term = grad / (1 + (grad / max_step_grad)**2) # update variables updated_velocity = velocity.assign(beta_hat * velocity + (1 - beta_hat) * gradient_term) updated_var = var.assign(var - lr_t * updated_velocity) # updates = [updated_var, updated_velocity] # return tf.group(*updates) def _resource_apply_sparse(self, grad, var): raise NotImplementedError def get_config(self): config = super(Gravity, self).get_config() config.update({ 'learning_rate': self._serialize_hyperparameter('learning_rate'), 'decay': self._serialize_hyperparameter('decay'), 'alpha': self._serialize_hyperparameter('alpha'), 'beta': self._serialize_hyperparameter('beta'), 'epsilon': self.epsilon, }) return config`
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59654/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59654/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59653
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59653/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59653/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59653/events
https://github.com/tensorflow/tensorflow/pull/59653
1,581,073,992
PR_kwDOArmXAs5JyOP1
59,653
Update libpng to 1.6.39
{ "login": "yongtang", "id": 6932348, "node_id": "MDQ6VXNlcjY5MzIzNDg=", "avatar_url": "https://avatars.githubusercontent.com/u/6932348?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yongtang", "html_url": "https://github.com/yongtang", "followers_url": "https://api.github.com/users/yongtang/followers", "following_url": "https://api.github.com/users/yongtang/following{/other_user}", "gists_url": "https://api.github.com/users/yongtang/gists{/gist_id}", "starred_url": "https://api.github.com/users/yongtang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yongtang/subscriptions", "organizations_url": "https://api.github.com/users/yongtang/orgs", "repos_url": "https://api.github.com/users/yongtang/repos", "events_url": "https://api.github.com/users/yongtang/events{/privacy}", "received_events_url": "https://api.github.com/users/yongtang/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-12T01:04:04
2023-02-13T20:17:00
2023-02-13T20:15:54
MEMBER
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59653", "html_url": "https://github.com/tensorflow/tensorflow/pull/59653", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59653.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59653.patch", "merged_at": "2023-02-13T20:15:54" }
This PR updates libpng to latest 1.6.39 from previous 1.6.38. See below for some issues fixed in 1.6.39: https://github.com/glennrp/libpng/blob/libpng16/CHANGES#L6112-L6122 Signed-off-by: Yong Tang <[email protected]>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59653/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59653/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59652
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59652/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59652/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59652/events
https://github.com/tensorflow/tensorflow/issues/59652
1,580,936,276
I_kwDOArmXAs5eOyxU
59,652
tape.gradient computes none after model in model training
{ "login": "VictorvanWeelden", "id": 32543479, "node_id": "MDQ6VXNlcjMyNTQzNDc5", "avatar_url": "https://avatars.githubusercontent.com/u/32543479?v=4", "gravatar_id": "", "url": "https://api.github.com/users/VictorvanWeelden", "html_url": "https://github.com/VictorvanWeelden", "followers_url": "https://api.github.com/users/VictorvanWeelden/followers", "following_url": "https://api.github.com/users/VictorvanWeelden/following{/other_user}", "gists_url": "https://api.github.com/users/VictorvanWeelden/gists{/gist_id}", "starred_url": "https://api.github.com/users/VictorvanWeelden/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/VictorvanWeelden/subscriptions", "organizations_url": "https://api.github.com/users/VictorvanWeelden/orgs", "repos_url": "https://api.github.com/users/VictorvanWeelden/repos", "events_url": "https://api.github.com/users/VictorvanWeelden/events{/privacy}", "received_events_url": "https://api.github.com/users/VictorvanWeelden/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "can you put your code in detail to solve this issue?\r\n", "Hi, @VictorvanWeelden \r\n\r\nApologize for the delay and I was able to replicate the issue on Google colab with `TF2.11 `and also tried with pre release `tensorflow 2.12.0rc0`, I have added both gist files here [tf-2.11](https://colab.research.google.com/gist/gaikwadrahul8/d697ffdf060179449f5cade41e11ffa8/-59652-tf2-11.ipynb) and [tensorflow 2.12.0rc0](https://colab.research.google.com/gist/gaikwadrahul8/88d44213c3239c8dd0f102e2cb653e44/-59652.ipynb) but I'm also getting the same error but with pre release `tensorflow 2.12.0rc0` I noticed different error `RuntimeError: A non-persistent GradientTape can only be used to compute one set of gradients (or jacobians)` but it got resolved by passing `persistent=True` to `with tf.GradientTape()` so We will have to dig more into this issue and we will update soon here and thank you for noticing this issue. Thank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Hi, @VictorvanWeelden \r\n\r\nApologize for the delayed response and It seems like there is some issue while calculating the gradient and it's returning none so for your reference I have added one [gist file](https://colab.research.google.com/gist/gaikwadrahul8/a9665800afb2c2f103925c753c196f6c/-59652.ipynb) which may be one of the reason for tape.gradient computes none after model in model training so could you please have a look into that gist-file and check whether is it resolving your issue ?, if not please let us know for investigation to find out root cause for your issue. Thank you!", "This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.", "This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59652\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59652\">No</a>\n" ]
2023-02-11T17:14:58
2023-04-14T01:52:31
2023-04-14T01:52:28
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version 3.8 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell grads = tape.gradient(class_channel, last_conv_layer_output) does produce NONE after performing first a regression on a "inner" model (trained and tested with MNIST and CIFAR10), before freezing the "inner" model network and then training a "outer" model over the "inner" model. After even unfreezing the "inner" model tape.gradient does not produce a result when asking for the final layer of the "inner" model as used in Grad-CAM. ``` ### Standalone code to reproduce the issue ```shell The minimal code is in the link. Everything can be run, till the final cell where the bug is. https://colab.research.google.com/drive/1HhFORTW3kQnsr0HMrk6Kl9brAguPvf_t?usp=sharing ``` ### Relevant log output ```shell AttributeError Traceback (most recent call last) <ipython-input-12-17e9c91a6483> in <module> 4 print(class_channel.shape) 5 grads = tape.gradient(class_channel, last_conv_layer_output) ----> 6 print(grads.shape) AttributeError: 'NoneType' object has no attribute 'shape' ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59652/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59652/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59651
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59651/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59651/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59651/events
https://github.com/tensorflow/tensorflow/issues/59651
1,580,733,951
I_kwDOArmXAs5eOBX_
59,651
Feature Request: More descriptive get_weights() method
{ "login": "AAnirudh07", "id": 86918353, "node_id": "MDQ6VXNlcjg2OTE4MzUz", "avatar_url": "https://avatars.githubusercontent.com/u/86918353?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AAnirudh07", "html_url": "https://github.com/AAnirudh07", "followers_url": "https://api.github.com/users/AAnirudh07/followers", "following_url": "https://api.github.com/users/AAnirudh07/following{/other_user}", "gists_url": "https://api.github.com/users/AAnirudh07/gists{/gist_id}", "starred_url": "https://api.github.com/users/AAnirudh07/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AAnirudh07/subscriptions", "organizations_url": "https://api.github.com/users/AAnirudh07/orgs", "repos_url": "https://api.github.com/users/AAnirudh07/repos", "events_url": "https://api.github.com/users/AAnirudh07/events{/privacy}", "received_events_url": "https://api.github.com/users/AAnirudh07/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473173272, "node_id": "MDU6TGFiZWw0NzMxNzMyNzI=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:feature", "name": "type:feature", "color": "159b2e", "default": false, "description": "Feature requests" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false }
[ { "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false } ]
null
[ "@AAnirudh07 \r\nThis issue seems to be a keras related issue. Please post this issue on [keras-team/keras repo.](https://github.com/keras-team/keras/issues)\r\nTo know more see;\r\nhttps://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999.\r\n\r\nThank you!", "Oh cool, I'll do that. Thanks!" ]
2023-02-11T08:30:30
2023-02-14T02:13:25
2023-02-14T02:13:25
NONE
null
null
null
### Issue Type Feature Request ### Tensorflow Version tf 2.11.0 ### OS Platform and Distribution Windows 11 ### Python version 3.10.9 Hello! Currently, I can get the weights of each layer of a Keras model by calling TensorFlow's `get_weights()` method. Additionally, this method returns the bias of the layer if the `use_bias` term is true. There is no mention of the order in which weights and biases are returned in TensorFlow or Keras documentation. When the method returns two or more NumPy arrays, how can we determine what these layers represent? It would be awesome if the `get_weights()` method could also indicate whether a particular NumPy array is a weights array, bias array, etc. ### Standalone code to reproduce the issue ```shell import tensorflow as tf def get_model(): mnist_model = tf.keras.Sequential([ tf.keras.layers.Flatten(input_shape=(28, 28)), tf.keras.layers.Dense(256, activation='relu'), tf.keras.layers.Dropout(0.45), tf.keras.layers.Dense(256, activation='relu'), tf.keras.layers.Dropout(0.45), tf.keras.layers.Dense(10)]) return mnist_model def get_model_state_dict(model): for index, layer in enumerate(model.layers): print(model.layers[index].get_weights()) state_dict = (get_model_state_dict(get_model())) ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59651/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59651/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59650
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59650/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59650/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59650/events
https://github.com/tensorflow/tensorflow/pull/59650
1,580,450,293
PR_kwDOArmXAs5JwNXT
59,650
Update tensorboard tb-nightly dependency, as a follow-up to the 2.12.…
{ "login": "vinila21", "id": 106367904, "node_id": "U_kgDOBlcLoA", "avatar_url": "https://avatars.githubusercontent.com/u/106367904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinila21", "html_url": "https://github.com/vinila21", "followers_url": "https://api.github.com/users/vinila21/followers", "following_url": "https://api.github.com/users/vinila21/following{/other_user}", "gists_url": "https://api.github.com/users/vinila21/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinila21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinila21/subscriptions", "organizations_url": "https://api.github.com/users/vinila21/orgs", "repos_url": "https://api.github.com/users/vinila21/repos", "events_url": "https://api.github.com/users/vinila21/events{/privacy}", "received_events_url": "https://api.github.com/users/vinila21/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-02-10T23:03:25
2023-02-10T23:09:22
2023-02-10T23:09:19
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59650", "html_url": "https://github.com/tensorflow/tensorflow/pull/59650", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59650.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59650.patch", "merged_at": null }
…0 release. The tb-nightly 2.13.0.a* pypi package is now available
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59650/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59650/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59649
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59649/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59649/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59649/events
https://github.com/tensorflow/tensorflow/pull/59649
1,580,301,613
PR_kwDOArmXAs5Jvs7t
59,649
[NVIDIA TF] Pass '-m*' options through nvcc to host compiler
{ "login": "nluehr", "id": 1873655, "node_id": "MDQ6VXNlcjE4NzM2NTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1873655?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nluehr", "html_url": "https://github.com/nluehr", "followers_url": "https://api.github.com/users/nluehr/followers", "following_url": "https://api.github.com/users/nluehr/following{/other_user}", "gists_url": "https://api.github.com/users/nluehr/gists{/gist_id}", "starred_url": "https://api.github.com/users/nluehr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nluehr/subscriptions", "organizations_url": "https://api.github.com/users/nluehr/orgs", "repos_url": "https://api.github.com/users/nluehr/repos", "events_url": "https://api.github.com/users/nluehr/events{/privacy}", "received_events_url": "https://api.github.com/users/nluehr/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-10T20:46:05
2023-03-08T21:52:31
2023-03-01T16:05:38
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59649", "html_url": "https://github.com/tensorflow/tensorflow/pull/59649", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59649.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59649.patch", "merged_at": "2023-03-01T16:05:38" }
Flags -m32 and -m64 are still intercepted and passed to nvcc. Other -m options are appended to the list of flags that nvcc passes through to the host compiler. This is useful for allowing machine-dependent options (such as -march or -mtune) to be applied in compilation units handled by nvcc.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59649/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59649/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59648
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59648/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59648/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59648/events
https://github.com/tensorflow/tensorflow/pull/59648
1,580,242,098
PR_kwDOArmXAs5JvgCp
59,648
r2.12 cherry-pick: 455b00cba42 "#tf-data Fix memory_cleanup_test"
{ "login": "tensorflow-jenkins", "id": 16359713, "node_id": "MDQ6VXNlcjE2MzU5NzEz", "avatar_url": "https://avatars.githubusercontent.com/u/16359713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tensorflow-jenkins", "html_url": "https://github.com/tensorflow-jenkins", "followers_url": "https://api.github.com/users/tensorflow-jenkins/followers", "following_url": "https://api.github.com/users/tensorflow-jenkins/following{/other_user}", "gists_url": "https://api.github.com/users/tensorflow-jenkins/gists{/gist_id}", "starred_url": "https://api.github.com/users/tensorflow-jenkins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tensorflow-jenkins/subscriptions", "organizations_url": "https://api.github.com/users/tensorflow-jenkins/orgs", "repos_url": "https://api.github.com/users/tensorflow-jenkins/repos", "events_url": "https://api.github.com/users/tensorflow-jenkins/events{/privacy}", "received_events_url": "https://api.github.com/users/tensorflow-jenkins/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-02-10T19:55:17
2023-02-10T20:36:41
2023-02-10T20:36:31
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59648", "html_url": "https://github.com/tensorflow/tensorflow/pull/59648", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59648.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59648.patch", "merged_at": "2023-02-10T20:36:31" }
Refer to the original commit: https://github.com/tensorflow/tensorflow/commit/455b00c
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59648/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59648/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59647
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59647/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59647/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59647/events
https://github.com/tensorflow/tensorflow/issues/59647
1,580,019,297
I_kwDOArmXAs5eLS5h
59,647
The gradient of tf.math.digamma is NaN on GPU and 0.0 on CPU when the input is inf
{ "login": "mazeltovlee", "id": 91937711, "node_id": "U_kgDOBXrbrw", "avatar_url": "https://avatars.githubusercontent.com/u/91937711?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mazeltovlee", "html_url": "https://github.com/mazeltovlee", "followers_url": "https://api.github.com/users/mazeltovlee/followers", "following_url": "https://api.github.com/users/mazeltovlee/following{/other_user}", "gists_url": "https://api.github.com/users/mazeltovlee/gists{/gist_id}", "starred_url": "https://api.github.com/users/mazeltovlee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mazeltovlee/subscriptions", "organizations_url": "https://api.github.com/users/mazeltovlee/orgs", "repos_url": "https://api.github.com/users/mazeltovlee/repos", "events_url": "https://api.github.com/users/mazeltovlee/events{/privacy}", "received_events_url": "https://api.github.com/users/mazeltovlee/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "@mazeltovlee \r\nI was able to replicate the issue on Google Colab with TF v2.11 on both CPU(output is 0.0) and GPU(output is nan). Please find the gist for the same [here-CPU](https://colab.sandbox.google.com/gist/synandi/ae802b0f544e5369425e75c1f5f9b451/59647_cpu.ipynb) and [here-GPU](https://colab.sandbox.google.com/gist/synandi/29c159a1b541e83f5717cb1f0d4db61f/59647_gpu.ipynb). It seems like we have to dig more into this issue, we will update soon here. Thank you!", "Hi @mazeltovlee, Apologies for the delay. On a GPU, floating point operations are performed using a special hardware that is optimized for parallel computation. This hardware may use different algorithms or have different rounding behavior compared to a CPU, which can lead to different results for the same calculation.\r\n\r\nIn your case of `tf.math.digamma(x)` where x is equal to inf, the output is undefined mathematically. \r\nWhen x is set to inf, the result of the function is undefined, and the gradient of the function is also undefined. However, due to rounding errors and implementation differences, it may be evaluated as NaN on a GPU and as 0 on a CPU. \r\nThank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59647\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59647\">No</a>\n" ]
2023-02-10T16:47:24
2023-03-24T04:32:29
2023-03-24T04:32:26
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version 3.8 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell The gradient of tf.math.digamma is NaN when receiving inf as input. This issue only happens on GPU mode, when I run the program on CPU, the gradient is 0. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf import numpy as np x = tf.Variable(np.inf, dtype="float32") with tf.GradientTape() as g0: g0.watch(x) res = tf.math.digamma(x) tf_grad = g0.gradient(res, x) print("The gradient of digamma is: ", tf_grad) # The gradient of digamma is: tf.Tensor(nan, shape=(), dtype=float32) ``` ### Relevant log output ```shell The gradient of digamma is: tf.Tensor(nan, shape=(), dtype=float32) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59647/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59647/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59646
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59646/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59646/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59646/events
https://github.com/tensorflow/tensorflow/pull/59646
1,580,018,150
PR_kwDOArmXAs5JuwfF
59,646
From Rahul: Async cp with separate send and recv done prototype.
{ "login": "zhangqiaorjc", "id": 328992, "node_id": "MDQ6VXNlcjMyODk5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/328992?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zhangqiaorjc", "html_url": "https://github.com/zhangqiaorjc", "followers_url": "https://api.github.com/users/zhangqiaorjc/followers", "following_url": "https://api.github.com/users/zhangqiaorjc/following{/other_user}", "gists_url": "https://api.github.com/users/zhangqiaorjc/gists{/gist_id}", "starred_url": "https://api.github.com/users/zhangqiaorjc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhangqiaorjc/subscriptions", "organizations_url": "https://api.github.com/users/zhangqiaorjc/orgs", "repos_url": "https://api.github.com/users/zhangqiaorjc/repos", "events_url": "https://api.github.com/users/zhangqiaorjc/events{/privacy}", "received_events_url": "https://api.github.com/users/zhangqiaorjc/received_events", "type": "User", "site_admin": false }
[ { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169365682, "node_id": "MDU6TGFiZWwxMTY5MzY1Njgy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:L", "name": "size:L", "color": "adafea", "default": false, "description": "CL Change Size: Large" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@jurahul FYI", "Thanks @zhangqiaorjc. Note that this is a prototype and does not work with the new XLA runtime. I have tested with these flags: `--xla_gpu_enable_async_collective_permute=true --xla_gpu_enable_xla_runtime_executable=false --xla_gpu_enable_latency_hiding_scheduler=true --xla_gpu_enable_cp_separate_send_recv=true`\r\n\r\nThe `xla_gpu_enable_cp_separate_send_recv` flag will enable the new async collective-permute mode.\r\n", "This was not intended for merging, so closing it." ]
2023-02-10T16:46:26
2023-03-21T21:20:19
2023-03-21T21:20:18
MEMBER
null
true
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59646", "html_url": "https://github.com/tensorflow/tensorflow/pull/59646", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59646.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59646.patch", "merged_at": null }
Do not merge. This is from jurahul@ and zhangqiaorjc@ to show a fix for NVIDIA partners. We will close this when the actual CL gets merged internally.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59646/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59646/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59645
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59645/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59645/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59645/events
https://github.com/tensorflow/tensorflow/pull/59645
1,579,900,007
PR_kwDOArmXAs5JuWn_
59,645
[Linaro:ARM_CI] Fix use of updated protobuf
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }
[ { "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }, { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-10T15:34:16
2023-02-13T09:31:37
2023-02-10T19:22:14
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59645", "html_url": "https://github.com/tensorflow/tensorflow/pull/59645", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59645.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59645.patch", "merged_at": "2023-02-10T19:22:14" }
Remove the code to force protobuf < 4 now that protobuf 4 is supported
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59645/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59645/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59644
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59644/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59644/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59644/events
https://github.com/tensorflow/tensorflow/pull/59644
1,579,666,868
PR_kwDOArmXAs5JtjfG
59,644
[Linaro:ARM_CI] Prevent use of protobuf 4 on python 3.8
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }
[ { "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }, { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi Andrew,\r\n\r\nThanks for bringing this up! We have seen similar failure with that test on x86 as well. Since it is passing in other Python versions and because the immediately affected feature (DTensor) is experimental, we have [disabled](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/dtensor/python/tests/BUILD#L351) the test for the time being on Python 3.8. Can you do the same?", "@nitins17 https://github.com/tensorflow/tensorflow/pull/59664", "#59664 has removed the need for this PR." ]
2023-02-10T13:13:55
2023-02-14T09:16:06
2023-02-14T09:15:56
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59644", "html_url": "https://github.com/tensorflow/tensorflow/pull/59644", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59644.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59644.patch", "merged_at": null }
protobuf 4 can lead to segmentation faults on Python 3.8 so prevent that from happening by using protobuf 3 but only for Python 3.8 Fixes #59643
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59644/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59644/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59643
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59643/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59643/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59643/events
https://github.com/tensorflow/tensorflow/issues/59643
1,579,665,543
I_kwDOArmXAs5eJ8iH
59,643
protobuf 4 causes segmentation fault on Python 3.8 in unit test
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59643\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59643\">No</a>\n" ]
2023-02-10T13:12:56
2023-02-13T20:50:40
2023-02-13T20:50:37
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version git HEAD ### Custom Code No ### OS Platform and Distribution CentOS 7 ### Mobile device n/a ### Python version 3.8.13 ### Bazel version 5.3.0 ### GCC/Compiler version 10.3.0 ### CUDA/cuDNN version n/a ### GPU model and memory n/a ### Current Behaviour? ```shell Unit test //tensorflow/dtensor/python/tests:spmd_test_cpu fails when run with Python 3.8 and protobuf 4 is installed. Installing protobuf 3.20.3 resolves the issue. ``` ### Standalone code to reproduce the issue ```shell bazel test --config=mkl_aarch64_threadpool --test_env=TF_ENABLE_ONEDNN_OPTS=1 --cache_test_results=no --test_timeout=500,900,-1,-1 --copt="-mtune=generic" --copt="-march=armv8-a" --copt="-O3" --build_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-no_aarch64,-requires-gpu --test_tag_filters=-no_oss,-oss_serial,-gpu,-tpu,-benchmark-test,-v1only,-no_aarch64,-requires-gpu --build_tests_only --jobs=100 -- //tensorflow/dtensor/python/tests:spmd_test_cpu ``` ### Relevant log output ```shell Fatal Python error: Segmentation fault Current thread 0x0000ffffb7906370 (most recent call first): File "/home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow/bazel-out/aarch64-opt/bin/tensorflow/dtensor/python/tests/spmd_test_cpu.runfiles/org_tensorflow/tensorflow/python/eager/context.py", line 1108 in config File "/home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow/bazel-out/aarch64-opt/bin/tensorflow/dtensor/python/tests/spmd_test_cpu.runfiles/org_tensorflow/tensorflow/python/eager/context.py", line 568 in ensure_initialized File "/home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow/bazel-out/aarch64-opt/bin/tensorflow/dtensor/python/tests/spmd_test_cpu.runfiles/org_tensorflow/tensorflow/python/eager/context.py", line 1401 in remove_function File "/home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow/bazel-out/aarch64-opt/bin/tensorflow/dtensor/python/tests/spmd_test_cpu.runfiles/org_tensorflow/tensorflow/python/eager/context.py", line 2739 in remove_function File "/home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow/bazel-out/aarch64-opt/bin/tensorflow/dtensor/python/tests/spmd_test_cpu.runfiles/org_tensorflow/tensorflow/python/eager/polymorphic_function/monomorphic_function.py", line 172 in __del__ *** Received signal 11 *** *** BEGIN MANGLED STACK TRACE *** /home/andrew/.cache/bazel/_bazel_andrew/c61c5f84d239689cb19a72cfde16be9f/execroot/org_tensorflow/bazel-out/aarch64-opt/bin/tensorflow/dtensor/python/tests/spmd_test_cpu.runfiles/org_tensorflow/tensorflow/python/platform/../../../_solib_aarch64/_U_S_Stensorflow_Clibtensorflow_Uframework_Uimport_Ulib___Utensorflow/libtensorflow_framework.so.2(+0x15ae14c)[0xffff145de14c] linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffffb78b07a0] /lib64/libpthread.so.0(raise+0xac)[0xffffb71b2af4] linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffffb78b07a0] /lib64/libpython3.8.so.1.0(PyModule_GetState+0x4)[0xffffb72f9a3c] /home/andrew/src/venv38/lib64/python3.8/site-packages/google/_upb/_message.abi3.so(+0xa390)[0xffff1527a390] /home/andrew/src/venv38/lib64/python3.8/site-packages/google/_upb/_message.abi3.so(+0x13c9c)[0xffff15283c9c] /lib64/libpython3.8.so.1.0(_PyObject_MakeTpCall+0x1a8)[0xffffb72ed9c0] /lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0x53f4)[0xffffb73c1114] /lib64/libpython3.8.so.1.0(_PyEval_EvalCodeWithName+0xc8c)[0xffffb7371fe4] /lib64/libpython3.8.so.1.0(_PyFunction_Vectorcall+0x474)[0xffffb73734b4] /lib64/libpython3.8.so.1.0(+0x12662c)[0xffffb734662c] /lib64/libpython3.8.so.1.0(PyObject_GetAttr+0x27c)[0xffffb7361e4c] /lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0xa08)[0xffffb73bc728] /lib64/libpython3.8.so.1.0(_PyFunction_Vectorcall+0x1d0)[0xffffb7373210] /lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0x884)[0xffffb73bc5a4] /lib64/libpython3.8.so.1.0(_PyFunction_Vectorcall+0x1d0)[0xffffb7373210] /lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0x884)[0xffffb73bc5a4] /lib64/libpython3.8.so.1.0(_PyFunction_Vectorcall+0x1d0)[0xffffb7373210] /lib64/libpython3.8.so.1.0(_PyEval_EvalFrameDefault+0x4de8)[0xffffb73c0b08] /lib64/libpython3.8.so.1.0(_PyFunction_Vectorcall+0x1d0)[0xffffb7373210] /lib64/libpython3.8.so.1.0(+0x133640)[0xffffb7353640] /lib64/libpython3.8.so.1.0(+0x1f7248)[0xffffb7417248] /lib64/libpython3.8.so.1.0(+0xcc72c)[0xffffb72ec72c] /lib64/libpython3.8.so.1.0(_PyGC_CollectNoFail+0x38)[0xffffb745f060] /lib64/libpython3.8.so.1.0(PyImport_Cleanup+0x394)[0xffffb745f40c] /lib64/libpython3.8.so.1.0(Py_FinalizeEx+0x6c)[0xffffb7462c34] /lib64/libpython3.8.so.1.0(Py_Exit+0x14)[0xffffb72cb01c] /lib64/libpython3.8.so.1.0(+0xab060)[0xffffb72cb060] /lib64/libpython3.8.so.1.0(+0xab0b8)[0xffffb72cb0b8] /lib64/libpython3.8.so.1.0(PyRun_SimpleFileExFlags+0x3c4)[0xffffb72cbac0] /lib64/libpython3.8.so.1.0(Py_RunMain+0x2b8)[0xffffb74645d0] /lib64/libpython3.8.so.1.0(Py_BytesMain+0x3c)[0xffffb7464d1c] /lib64/libc.so.6(__libc_start_main+0xdc)[0xffffb6f14384] /home/andrew/src/venv38/bin/python3(+0x928)[0xaaaab41c0928] *** END MANGLED STACK TRACE *** *** Begin stack trace *** tsl::CurrentStackTrace[abi:cxx11]() __kernel_rt_sigreturn raise __kernel_rt_sigreturn PyModule_GetState _PyObject_MakeTpCall _PyEval_EvalFrameDefault _PyEval_EvalCodeWithName _PyFunction_Vectorcall PyObject_GetAttr _PyEval_EvalFrameDefault _PyFunction_Vectorcall _PyEval_EvalFrameDefault _PyFunction_Vectorcall _PyEval_EvalFrameDefault _PyFunction_Vectorcall _PyEval_EvalFrameDefault _PyFunction_Vectorcall _PyGC_CollectNoFail PyImport_Cleanup Py_FinalizeEx Py_Exit PyRun_SimpleFileExFlags Py_RunMain Py_BytesMain __libc_start_main *** End stack trace *** ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59643/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59643/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59642
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59642/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59642/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59642/events
https://github.com/tensorflow/tensorflow/issues/59642
1,579,575,288
I_kwDOArmXAs5eJmf4
59,642
LookupError: gradient registry has no entry for: ClipByValue
{ "login": "shkarupa-alex", "id": 1289725, "node_id": "MDQ6VXNlcjEyODk3MjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1289725?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shkarupa-alex", "html_url": "https://github.com/shkarupa-alex", "followers_url": "https://api.github.com/users/shkarupa-alex/followers", "following_url": "https://api.github.com/users/shkarupa-alex/following{/other_user}", "gists_url": "https://api.github.com/users/shkarupa-alex/gists{/gist_id}", "starred_url": "https://api.github.com/users/shkarupa-alex/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shkarupa-alex/subscriptions", "organizations_url": "https://api.github.com/users/shkarupa-alex/orgs", "repos_url": "https://api.github.com/users/shkarupa-alex/repos", "events_url": "https://api.github.com/users/shkarupa-alex/events{/privacy}", "received_events_url": "https://api.github.com/users/shkarupa-alex/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "qlzh727", "id": 5118881, "node_id": "MDQ6VXNlcjUxMTg4ODE=", "avatar_url": "https://avatars.githubusercontent.com/u/5118881?v=4", "gravatar_id": "", "url": "https://api.github.com/users/qlzh727", "html_url": "https://github.com/qlzh727", "followers_url": "https://api.github.com/users/qlzh727/followers", "following_url": "https://api.github.com/users/qlzh727/following{/other_user}", "gists_url": "https://api.github.com/users/qlzh727/gists{/gist_id}", "starred_url": "https://api.github.com/users/qlzh727/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qlzh727/subscriptions", "organizations_url": "https://api.github.com/users/qlzh727/orgs", "repos_url": "https://api.github.com/users/qlzh727/repos", "events_url": "https://api.github.com/users/qlzh727/events{/privacy}", "received_events_url": "https://api.github.com/users/qlzh727/received_events", "type": "User", "site_admin": false }
[ { "login": "qlzh727", "id": 5118881, "node_id": "MDQ6VXNlcjUxMTg4ODE=", "avatar_url": "https://avatars.githubusercontent.com/u/5118881?v=4", "gravatar_id": "", "url": "https://api.github.com/users/qlzh727", "html_url": "https://github.com/qlzh727", "followers_url": "https://api.github.com/users/qlzh727/followers", "following_url": "https://api.github.com/users/qlzh727/following{/other_user}", "gists_url": "https://api.github.com/users/qlzh727/gists{/gist_id}", "starred_url": "https://api.github.com/users/qlzh727/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qlzh727/subscriptions", "organizations_url": "https://api.github.com/users/qlzh727/orgs", "repos_url": "https://api.github.com/users/qlzh727/repos", "events_url": "https://api.github.com/users/qlzh727/events{/privacy}", "received_events_url": "https://api.github.com/users/qlzh727/received_events", "type": "User", "site_admin": false }, { "login": "reedwm", "id": 6510203, "node_id": "MDQ6VXNlcjY1MTAyMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/6510203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reedwm", "html_url": "https://github.com/reedwm", "followers_url": "https://api.github.com/users/reedwm/followers", "following_url": "https://api.github.com/users/reedwm/following{/other_user}", "gists_url": "https://api.github.com/users/reedwm/gists{/gist_id}", "starred_url": "https://api.github.com/users/reedwm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reedwm/subscriptions", "organizations_url": "https://api.github.com/users/reedwm/orgs", "repos_url": "https://api.github.com/users/reedwm/repos", "events_url": "https://api.github.com/users/reedwm/events{/privacy}", "received_events_url": "https://api.github.com/users/reedwm/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @shkarupa-alex \r\n\r\nAplogize for the delay and I was able to replicate the same issue with `tf-nightly `on Google Colab and also on `Ubuntu 20.04 `, for your reference I have added [gist-file-tf-nightly ](https://colab.research.google.com/gist/gaikwadrahul8/8621f06354de07d8e85b7c192f666e80/-59642-test.ipynb)and screenshot below and it's giving me same error as you mentioned above in the error log output `LookupError: gradient registry has no entry for: ClipByValue`\r\n\r\nHere is screenshot for code execution on `Ubuntu 20.04` with `tf-nightly`:\r\n\r\n![image](https://user-images.githubusercontent.com/115997457/219008278-630079bb-42a6-4f98-9be7-defa3bb678eb.png)\r\n\r\n\r\nI tried the same code on latest stable version of `Tensorflow==2.11 `and it's working fine as expected for your reference I have added [gist-file-tf-2.11](https://colab.research.google.com/gist/gaikwadrahul8/4e16d616590f8a3b8d206cd62196aa5b/-59642-test.ipynb). Thank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59642\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59642\">No</a>\n", "Hi, @shkarupa-alex \r\n\r\nI apologize for this issue got closed after stale from Bot so I re-opened this issue and I have tested the same code with `Tf-nightly `and our tensorflow pre-release `tensorflow==2.12.0rc0`, I'm getting the same error, for your reference I have added [gist-file](https://colab.research.google.com/gist/gaikwadrahul8/e208d73957480f560d4ed23dddbad356/-59642-test.ipynb) and we'll have to dig more into this issue and we'll update you soon. Thank you!", "Hi, @sachinprasadhs \r\n\r\nCould you please look into this issue ? Thank you!", "@qlzh727, the ClipByValue gradient is commented out and there is a TODO assigned to you from 2018: https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/python/ops/clip_ops.py;l=126;drc=ec69e86e01436b58d53f49b12782a0452bd26c8c. Do you remember why it's commented out?", "> @qlzh727, the ClipByValue gradient is commented out and there is a TODO assigned to you from 2018: https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/python/ops/clip_ops.py;l=126;drc=ec69e86e01436b58d53f49b12782a0452bd26c8c. Do you remember why it's commented out?\r\n\r\nI think I did this when I was on sync rotation for TF, and it was failing for the presubmit when I try to merge the change. I don't remember for the context of what's the failure now. Maybe we can try to re-enable it again?", "@qlzh727 can you do this? If you don't have time I can try.", "> @qlzh727 can you do this? If you don't have time I can try.\r\n\r\nI am actually quite booked for other tasks at the moment. Thanks for the help.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59642\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59642\">No</a>\n" ]
2023-02-10T12:04:59
2023-03-30T15:26:51
2023-03-30T15:26:47
CONTRIBUTOR
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.13.0-dev20230210 ### Custom Code Yes ### OS Platform and Distribution Google Colab ### Mobile device _No response_ ### Python version _No response_ ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Error occurred when mixed precision policy and `tf.saturate_cast` used together. No error without mixed precision policy. ``` ### Standalone code to reproduce the issue ```shell https://colab.research.google.com/drive/1hWTWBG7S8h6q4DK1qBNl2id0aK7h-3n4?usp=sharing ``` ### Relevant log output ```shell --------------------------------------------------------------------------- StagingError Traceback (most recent call last) <ipython-input-6-1edf848c14d2> in <module> 12 model = models.Model(inputs=inputs, outputs=outputs) 13 model.compile(optimizer='adam', loss='mse', run_eagerly=False, jit_compile=True) ---> 14 model.fit(images, labels, epochs=1, batch_size=2) 1 frames /usr/local/lib/python3.8/dist-packages/keras/utils/traceback_utils.py in error_handler(*args, **kwargs) 68 # To get the full stack trace, call: 69 # `tf.debugging.disable_traceback_filtering()` ---> 70 raise e.with_traceback(filtered_tb) from None 71 finally: 72 del filtered_tb /usr/local/lib/python3.8/dist-packages/tensorflow/python/framework/func_graph.py in autograph_handler(*args, **kwargs) 1169 except Exception as e: # pylint:disable=broad-except 1170 if hasattr(e, "ag_error_metadata"): -> 1171 raise e.ag_error_metadata.to_exception(e) 1172 else: 1173 raise StagingError: in user code: File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1284, in train_function * return step_function(self, iterator) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1249, in run_step * outputs = model.train_step(data) File "/usr/local/lib/python3.8/dist-packages/keras/engine/training.py", line 1054, in train_step ** self.optimizer.minimize(loss, self.trainable_variables, tape=tape) File "/usr/local/lib/python3.8/dist-packages/keras/optimizers/optimizer.py", line 542, in minimize grads_and_vars = self.compute_gradients(loss, var_list, tape) File "/usr/local/lib/python3.8/dist-packages/keras/mixed_precision/loss_scale_optimizer.py", line 1249, in compute_gradients grads_and_vars = self._optimizer.compute_gradients( File "/usr/local/lib/python3.8/dist-packages/keras/optimizers/optimizer.py", line 275, in compute_gradients grads = tape.gradient(loss, var_list) LookupError: gradient registry has no entry for: ClipByValue ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59642/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59642/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59641
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59641/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59641/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59641/events
https://github.com/tensorflow/tensorflow/issues/59641
1,579,496,747
I_kwDOArmXAs5eJTUr
59,641
tf.data.Dataset.map() of tf.data.Dataset feat. tf.RaggedTensor causes broken for-loop
{ "login": "Tens0rFlaw", "id": 125027769, "node_id": "U_kgDOB3PFuQ", "avatar_url": "https://avatars.githubusercontent.com/u/125027769?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Tens0rFlaw", "html_url": "https://github.com/Tens0rFlaw", "followers_url": "https://api.github.com/users/Tens0rFlaw/followers", "following_url": "https://api.github.com/users/Tens0rFlaw/following{/other_user}", "gists_url": "https://api.github.com/users/Tens0rFlaw/gists{/gist_id}", "starred_url": "https://api.github.com/users/Tens0rFlaw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Tens0rFlaw/subscriptions", "organizations_url": "https://api.github.com/users/Tens0rFlaw/orgs", "repos_url": "https://api.github.com/users/Tens0rFlaw/repos", "events_url": "https://api.github.com/users/Tens0rFlaw/events{/privacy}", "received_events_url": "https://api.github.com/users/Tens0rFlaw/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1114343535, "node_id": "MDU6TGFiZWwxMTE0MzQzNTM1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:data", "name": "comp:data", "color": "0052cc", "default": false, "description": "tf.data related issues" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "@sushreebarsa \r\n\r\nI was able to reproduce the issue on Colab using TF v2.11 . Please find the gist [here](https://colab.research.google.com/gist/tiruk007/01cd0b1c8b49584bf08617e8fe098086/untitled121.ipynb) for reference.\r\n\r\nThank you!", "Hi, @Tens0rFlaw \r\n\r\nApologize for the delay and I was able to replicate the issue on Google Colab with `Tensorflow==2.11` and it's working as expected, for your reference I have added [gist-file ](https://colab.research.google.com/gist/gaikwadrahul8/db0420fcfef1d506079d0d33dfbc0481/-59641.ipynb) and it seems like you're using python `map()` instead of `tf.map_fn()` and for your reference I have added [official documentation](https://www.tensorflow.org/api_docs/python/tf/map_fn) for `tf.map_fn()` which may help you. If issue still persists please let us know or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!", "Hi @gaikwadrahul8 \r\nthat indeed resolves the issue. \r\nThank you for you answer!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59641\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59641\">No</a>\n" ]
2023-02-10T11:15:27
2023-02-21T15:17:43
2023-02-21T15:17:40
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.9.2 ### Custom Code Yes ### OS Platform and Distribution Windows 10, WSL2 Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.8.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version 11.2 ### GPU model and memory _No response_ ### Current Behaviour? ```shell When using a tf.data.Dataset for tf.RaggedTensors, the .map() functionality seems to break the ability to iterate over the datapoints via for-loop, causing an internal TypeError on the for-loop itself. The expected behaviour would be for the program not to throw a TypeError as the same function works if used via a simple for-loop over the data instead of the .map() functionality. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf ragged_data=tf.ragged.constant([[[[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]]], [[[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]], [[1,2],[3,4],[5,6]]]]) ds=tf.data.Dataset.from_tensor_slices(ragged_data) def test_fn(ragged_data): for x in ragged_data: continue return ragged_data ds.map(test_fn) ``` ### Relevant log output ```shell TypeError: Input 'y' of 'Less' Op has type int64 that does not match type int32 of argument 'x'. ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59641/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59641/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59640
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59640/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59640/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59640/events
https://github.com/tensorflow/tensorflow/pull/59640
1,579,482,232
PR_kwDOArmXAs5Js7Jo
59,640
[OpenCL][Testing] Fix shell dir definition
{ "login": "echuraev", "id": 5525113, "node_id": "MDQ6VXNlcjU1MjUxMTM=", "avatar_url": "https://avatars.githubusercontent.com/u/5525113?v=4", "gravatar_id": "", "url": "https://api.github.com/users/echuraev", "html_url": "https://github.com/echuraev", "followers_url": "https://api.github.com/users/echuraev/followers", "following_url": "https://api.github.com/users/echuraev/following{/other_user}", "gists_url": "https://api.github.com/users/echuraev/gists{/gist_id}", "starred_url": "https://api.github.com/users/echuraev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/echuraev/subscriptions", "organizations_url": "https://api.github.com/users/echuraev/orgs", "repos_url": "https://api.github.com/users/echuraev/repos", "events_url": "https://api.github.com/users/echuraev/events{/privacy}", "received_events_url": "https://api.github.com/users/echuraev/received_events", "type": "User", "site_admin": false }
[ { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59640/checks?check_run_id=11250291842) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @alankelly Can you please review this PR ? Thank you!", "Hi @impjdi Can you please review this PR ? Thank you!", "This will cause everyone to run `sed` unconditionally. I would suggest to remove the `.` when you invoke it. If we let this through, maybe next time someone creates a PR that accommodates `../../../../tensorflow/lite/delegates/gpu/cl/testing/run_performance_profiling.sh`...", "Hi @echuraev Can you please check @impjdi's [comments](https://github.com/tensorflow/tensorflow/pull/59640#issuecomment-1785571292) and keep us posted? Thank you!", "> Hi @echuraev Can you please check @impjdi's [comments](https://github.com/tensorflow/tensorflow/pull/59640#issuecomment-1785571292) and keep us posted? Thank you!\r\n\r\nHi, @gbaned. I saw this comment, and it looks like we can close this PR. Probably to fix this problem, scripts should work with absolute path instead of relative.\r\n", "> > Hi @echuraev Can you please check @impjdi's [comments](https://github.com/tensorflow/tensorflow/pull/59640#issuecomment-1785571292) and keep us posted? Thank you!\r\n> \r\n> Hi, @gbaned. I saw this comment, and it looks like we can close this PR. Probably to fix this problem, scripts should work with absolute path instead of relative.\r\n\r\nHi @echuraev Thank you for the update. " ]
2023-02-10T11:05:12
2023-12-29T05:39:04
2023-12-29T05:39:03
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59640", "html_url": "https://github.com/tensorflow/tensorflow/pull/59640", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59640.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59640.patch", "merged_at": null }
It was a problem when `run_performance_profiling.sh` was running with `./` in the beginning of the command, e.g.: ``` ./tensorflow/lite/delegates/gpu/cl/testing/run_performance_profiling.sh -m ... ``` I got the following error: ``` ERROR: Skipping '//./tensorflow/lite/delegates/gpu/cl/testing:performance_profiling': invalid target format '//./tensorflow/lite/delegates/gpu/cl/testing:performance_profiling': invalid package name './tensorflow/lite/delegates/gpu/cl/testing': package name component contains only '.' characters ``` The same situation was mentioned here: https://github.com/tensorflow/tensorflow/issues/56463#issuecomment-1185389950 This PR fixes this issue.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59640/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59640/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59639
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59639/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59639/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59639/events
https://github.com/tensorflow/tensorflow/pull/59639
1,579,477,292
PR_kwDOArmXAs5Js6Dg
59,639
[Linaro:ARM_CI] Revert adding install of tensorflow-io
{ "login": "elfringham", "id": 10442001, "node_id": "MDQ6VXNlcjEwNDQyMDAx", "avatar_url": "https://avatars.githubusercontent.com/u/10442001?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elfringham", "html_url": "https://github.com/elfringham", "followers_url": "https://api.github.com/users/elfringham/followers", "following_url": "https://api.github.com/users/elfringham/following{/other_user}", "gists_url": "https://api.github.com/users/elfringham/gists{/gist_id}", "starred_url": "https://api.github.com/users/elfringham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elfringham/subscriptions", "organizations_url": "https://api.github.com/users/elfringham/orgs", "repos_url": "https://api.github.com/users/elfringham/repos", "events_url": "https://api.github.com/users/elfringham/events{/privacy}", "received_events_url": "https://api.github.com/users/elfringham/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "nitins17", "id": 29348997, "node_id": "MDQ6VXNlcjI5MzQ4OTk3", "avatar_url": "https://avatars.githubusercontent.com/u/29348997?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nitins17", "html_url": "https://github.com/nitins17", "followers_url": "https://api.github.com/users/nitins17/followers", "following_url": "https://api.github.com/users/nitins17/following{/other_user}", "gists_url": "https://api.github.com/users/nitins17/gists{/gist_id}", "starred_url": "https://api.github.com/users/nitins17/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nitins17/subscriptions", "organizations_url": "https://api.github.com/users/nitins17/orgs", "repos_url": "https://api.github.com/users/nitins17/repos", "events_url": "https://api.github.com/users/nitins17/events{/privacy}", "received_events_url": "https://api.github.com/users/nitins17/received_events", "type": "User", "site_admin": false }, { "login": "penpornk", "id": 38085909, "node_id": "MDQ6VXNlcjM4MDg1OTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38085909?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penpornk", "html_url": "https://github.com/penpornk", "followers_url": "https://api.github.com/users/penpornk/followers", "following_url": "https://api.github.com/users/penpornk/following{/other_user}", "gists_url": "https://api.github.com/users/penpornk/gists{/gist_id}", "starred_url": "https://api.github.com/users/penpornk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penpornk/subscriptions", "organizations_url": "https://api.github.com/users/penpornk/orgs", "repos_url": "https://api.github.com/users/penpornk/repos", "events_url": "https://api.github.com/users/penpornk/events{/privacy}", "received_events_url": "https://api.github.com/users/penpornk/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Probably best to wait for a new release of tensorflow-io before merging this PR", "No reason to wait for new release of tensorflow-io. Failures seen in ARM_CI run were not related." ]
2023-02-10T11:02:11
2023-02-22T12:48:43
2023-02-13T21:03:58
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59639", "html_url": "https://github.com/tensorflow/tensorflow/pull/59639", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59639.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59639.patch", "merged_at": "2023-02-13T21:03:58" }
Do not install tensorflow-io as an extra package, it is not needed and can cause additional problems and failed to achieve the original intent as it attempted to fix a problem that was actually in the building of the tensorflow-io-gcs-filesystem package for AARCH64
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59639/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59638
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59638/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59638/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59638/events
https://github.com/tensorflow/tensorflow/pull/59638
1,579,209,359
PR_kwDOArmXAs5Jr_yr
59,638
Use `tf` libaries instead of `array_ops` to provide compatibility with the Tensorflow API
{ "login": "Eben-Success", "id": 71809927, "node_id": "MDQ6VXNlcjcxODA5OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/71809927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Eben-Success", "html_url": "https://github.com/Eben-Success", "followers_url": "https://api.github.com/users/Eben-Success/followers", "following_url": "https://api.github.com/users/Eben-Success/following{/other_user}", "gists_url": "https://api.github.com/users/Eben-Success/gists{/gist_id}", "starred_url": "https://api.github.com/users/Eben-Success/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Eben-Success/subscriptions", "organizations_url": "https://api.github.com/users/Eben-Success/orgs", "repos_url": "https://api.github.com/users/Eben-Success/repos", "events_url": "https://api.github.com/users/Eben-Success/events{/privacy}", "received_events_url": "https://api.github.com/users/Eben-Success/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" } ]
open
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @rainwoodman Can you please review this PR ? Thank you!", "Hi @rainwoodman Can you please review this PR ? Thank you!", "Hi @rainwoodman Can you please review this PR ? Thank you!", "Hi @jsmeredith Can you please review this PR ? Thank you!", "Hi @jsmeredith Can you please review this PR ? Thank you!", "Hi @jsmeredith Can you please review this PR ? Thank you!", "Hi @jsmeredith Can you please review this PR ? Thank you!", "Hi @jsmeredith Can you please review this PR ? Thank you!", "Hi @jsmeredith Can you please review this PR ? Thank you!" ]
2023-02-10T08:11:12
2024-06-07T16:04:13
null
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59638", "html_url": "https://github.com/tensorflow/tensorflow/pull/59638", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59638.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59638.patch", "merged_at": null }
…ity with Tensorflow API
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59638/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59638/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59637
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59637/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59637/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59637/events
https://github.com/tensorflow/tensorflow/issues/59637
1,579,198,494
I_kwDOArmXAs5eIKge
59,637
How to use exported automl tensorflow model for tabular data in Python
{ "login": "kaywolter", "id": 18718568, "node_id": "MDQ6VXNlcjE4NzE4NTY4", "avatar_url": "https://avatars.githubusercontent.com/u/18718568?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kaywolter", "html_url": "https://github.com/kaywolter", "followers_url": "https://api.github.com/users/kaywolter/followers", "following_url": "https://api.github.com/users/kaywolter/following{/other_user}", "gists_url": "https://api.github.com/users/kaywolter/gists{/gist_id}", "starred_url": "https://api.github.com/users/kaywolter/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kaywolter/subscriptions", "organizations_url": "https://api.github.com/users/kaywolter/orgs", "repos_url": "https://api.github.com/users/kaywolter/repos", "events_url": "https://api.github.com/users/kaywolter/events{/privacy}", "received_events_url": "https://api.github.com/users/kaywolter/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 4032183365, "node_id": "LA_kwDOArmXAs7wVjxF", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.9", "name": "TF 2.9", "color": "1CF842", "default": false, "description": "Issues found in the TF 2.9 release (or RCs)" } ]
closed
false
{ "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false }
[ { "login": "tilakrayal", "id": 81610181, "node_id": "MDQ6VXNlcjgxNjEwMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/81610181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tilakrayal", "html_url": "https://github.com/tilakrayal", "followers_url": "https://api.github.com/users/tilakrayal/followers", "following_url": "https://api.github.com/users/tilakrayal/following{/other_user}", "gists_url": "https://api.github.com/users/tilakrayal/gists{/gist_id}", "starred_url": "https://api.github.com/users/tilakrayal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tilakrayal/subscriptions", "organizations_url": "https://api.github.com/users/tilakrayal/orgs", "repos_url": "https://api.github.com/users/tilakrayal/repos", "events_url": "https://api.github.com/users/tilakrayal/events{/privacy}", "received_events_url": "https://api.github.com/users/tilakrayal/received_events", "type": "User", "site_admin": false } ]
null
[ "@kaywolter,\r\nExporting AutoML tabular models has the following limitations:\r\n\r\n- You can export AutoML tabular classification and regression models only. Exporting AutoML tabular forecasting models is not supported.\r\n\r\n- Vertex Explainable AI is not available using exported tabular models. If you need to use Vertex Explainable AI, you must serve predictions from a model hosted by Vertex AI.\r\n\r\n- The exported tabular model can run only on x86 architecture CPUs that support Advanced Vector Extensions (AVX) instruction sets.\r\n\r\nAnd tabular data to string tensors, we can follow the below process.\r\n\r\n```\r\nimport numpy as np\r\ndef my_func(arg):\r\n arg = tf.convert_to_tensor(arg, dtype=tf.float32)\r\n return arg\r\n# The following calls are equivalent.\r\n\r\nvalue_1 = my_func(tf.constant([[1.0, 2.0], [3.0, 4.0]]))\r\nprint(value_1)\r\n\r\n\r\n\r\nvalue_2 = my_func([[1.0, 2.0], [3.0, 4.0]])\r\nprint(value_2)\r\n\r\n\r\n\r\nvalue_3 = my_func(np.array([[1.0, 2.0], [3.0, 4.0]], dtype=np.float32))\r\nprint(value_3)\r\n```\r\n\r\n\r\nAlso please take a look at this official doc [link](https://cloud.google.com/vertex-ai/docs/tabular-data/bp-tabular) for the reference. Thank you!", "Hi tilakrayal,\r\n\r\nThanks for the response. Not sure if understood your code correctly. When I pass the value returned from my_func I get error `input #0(zero-based) was expected to be a string tensor but is a float tensor`.\r\n\r\nHow can I pass the array to the model's signature?\r\n\r\nKay", "@kaywolter,\r\nThe code provided above was the sample toy code reference for converting tabular data to string tensors and also\r\ncan export AutoML tabular classification and regression models only. Exporting AutoML tabular forecasting models is not supported. Vertex Explainable AI is not available using exported tabular models. If you need to use Vertex Explainable AI, you must serve predictions from a model hosted by Vertex AI. Thank you!", "Closing this as stale. Please reopen if this is still a valid request. Thank you!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59637\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59637\">No</a>\n" ]
2023-02-10T08:04:57
2023-03-23T02:33:43
2023-03-23T02:33:40
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Support ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.9 ### Custom Code Yes ### OS Platform and Distribution Linux Ubuntu ### Mobile device _No response_ ### Python version 3.7 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Hello, I followed the instructions from Google Cloud to export and load a trainen AutoML model (training was done with data from BigQuery): https://cloud.google.com/vertex-ai/docs/export/export-model-tabular As we want to integrate this model in our Spark flow I need to load it and make predictions on it in Python directly. I tested the model with the tensorflow serving docker image as described in the documentation. This works perfectly fine. However, when I try to use the model directly I get an erro "Error: DATA_LOSS: Failed skipping unrequested field". Input must be a string tensor. I tried several formats (JSON, CSV) but none of them seemed to be correct. Can anybody give me a hint on how to convert the tabular data into a string tensor in a way that the model accepts the data and returns a prediction? Thanks in advance!! Kay ``` ### Standalone code to reproduce the issue ```shell import struct2tensor import tensorflow as tf import json import requests MODEL_PATH = '/home/kay/tmp/models/ml_cr_2022_12' predict_sample = {'Animals': '0.0', 'Apparel': '0.0165423884627339', 'Arts': '0.000893240417492657', 'Baby': '0.0', 'Business': '0.0', 'Cameras': '0.000158694043359865', 'Electronics': '0.0', 'Food': '6.4749054130615e-05', 'Furniture': '0.0', 'Hardware': '0.000247099237409669', 'Health': '0.00928790329794604', 'Home': '0.0442892335578687', 'Luggage': '3.65980448833796e-05', 'Mature': '0.0', 'Media': '0.70324946112978', 'Office': '0.000297127488105344', 'Religious': '0.0', 'Software': '0.0', 'Sporting': '0.0', 'Toys': '0.0', 'Vehicles': '7.25524348202571e-06', 'aov_bench': '59.8599307847218', 'aov_rep': '0', 'avgprice': '12.704623853211', 'bouncerate': '81.06', 'brand_search_volume': '0', 'brand_search_volume_share': '0.0', 'category': 'adult', 'competition': '0.0', 'cpc': '0.0', 'cr_bench': '0.00972125074728272', 'date': '2022-08-01', 'directShare': '40.79', 'displayShare': '0.0', 'domain_cat_1': '0', 'domain_cat_2': '0', 'domain_search_volum_share': '0.0', 'domain_search_volume': '0', 'ekps_aov': '26.859908543707', 'ekps_cr': '0.0194748958674429', 'iib_bench': '1.04867824234893', 'int64_field_0': '1', 'lineid': '1', 'mailShare': '0.0', 'mainCountry': 'Germany', 'mainCountryShare': '84.25', 'no_cat': '0.224926250022808', 'organicShare': '57.66', 'pageviews': '1.74154466250536', 'paidsearchShare': '0.0'} # Request to tensorflow_serving docker container, works perfectly response = requests.post( 'http://localhost:8080/predict', json={'instances': [predict_sample]} ) # prints {"predictions": 0.0056517720222473145} print(response.text) model = tf.saved_model.load(MODEL_PATH) infer = model.signatures["serving_default"] # No matter what I tried as input here, I always get error "Error consuming . Error: DATA_LOSS: Failed skipping unrequested field" print(infer(tf.constant('How to feed model with one string tensor??'))) ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59637/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59637/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59636
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59636/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59636/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59636/events
https://github.com/tensorflow/tensorflow/pull/59636
1,579,164,992
PR_kwDOArmXAs5Jr2BJ
59,636
[DO NOT REVIEW] Introduce multiple streams execution in TensorFlow.
{ "login": "buptzyb", "id": 38978109, "node_id": "MDQ6VXNlcjM4OTc4MTA5", "avatar_url": "https://avatars.githubusercontent.com/u/38978109?v=4", "gravatar_id": "", "url": "https://api.github.com/users/buptzyb", "html_url": "https://github.com/buptzyb", "followers_url": "https://api.github.com/users/buptzyb/followers", "following_url": "https://api.github.com/users/buptzyb/following{/other_user}", "gists_url": "https://api.github.com/users/buptzyb/gists{/gist_id}", "starred_url": "https://api.github.com/users/buptzyb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/buptzyb/subscriptions", "organizations_url": "https://api.github.com/users/buptzyb/orgs", "repos_url": "https://api.github.com/users/buptzyb/repos", "events_url": "https://api.github.com/users/buptzyb/events{/privacy}", "received_events_url": "https://api.github.com/users/buptzyb/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59636/checks?check_run_id=11246241128) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "We cannot accept PRs on versions that are out of life." ]
2023-02-10T07:40:24
2023-02-15T18:00:06
2023-02-13T23:50:22
CONTRIBUTOR
null
true
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59636", "html_url": "https://github.com/tensorflow/tensorflow/pull/59636", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59636.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59636.patch", "merged_at": null }
Multiple Stream TensorFlow is developed based on the official [TensorFlow 2.2](https://github.com/tensorflow/tensorflow/tree/r2.2). It leverages the features of modern GPUs to accelerate deep learning training and inference. This Multi-Stream implementation has successfully helped several customers migrate their TF models to the GPU and go online. For more details please visit [README_MultiStream.md](https://github.com/buptzyb/tensorflow/blob/r2.2_multistream/README_MultiStream.md).
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59636/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59636/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59635
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59635/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59635/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59635/events
https://github.com/tensorflow/tensorflow/issues/59635
1,579,150,396
I_kwDOArmXAs5eH-w8
59,635
Non deterministic random numbers generated in Eager and Graph mode
{ "login": "mergian", "id": 23471913, "node_id": "MDQ6VXNlcjIzNDcxOTEz", "avatar_url": "https://avatars.githubusercontent.com/u/23471913?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mergian", "html_url": "https://github.com/mergian", "followers_url": "https://api.github.com/users/mergian/followers", "following_url": "https://api.github.com/users/mergian/following{/other_user}", "gists_url": "https://api.github.com/users/mergian/gists{/gist_id}", "starred_url": "https://api.github.com/users/mergian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mergian/subscriptions", "organizations_url": "https://api.github.com/users/mergian/orgs", "repos_url": "https://api.github.com/users/mergian/repos", "events_url": "https://api.github.com/users/mergian/events{/privacy}", "received_events_url": "https://api.github.com/users/mergian/received_events", "type": "User", "site_admin": false }
[ { "id": 404586594, "node_id": "MDU6TGFiZWw0MDQ1ODY1OTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20tensorflower", "name": "stat:awaiting tensorflower", "color": "f4b400", "default": false, "description": "Status - Awaiting response from tensorflower" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 736653459, "node_id": "MDU6TGFiZWw3MzY2NTM0NTk=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:eager", "name": "comp:eager", "color": "0052cc", "default": false, "description": "Eager related issues" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
open
false
{ "login": "qlzh727", "id": 5118881, "node_id": "MDQ6VXNlcjUxMTg4ODE=", "avatar_url": "https://avatars.githubusercontent.com/u/5118881?v=4", "gravatar_id": "", "url": "https://api.github.com/users/qlzh727", "html_url": "https://github.com/qlzh727", "followers_url": "https://api.github.com/users/qlzh727/followers", "following_url": "https://api.github.com/users/qlzh727/following{/other_user}", "gists_url": "https://api.github.com/users/qlzh727/gists{/gist_id}", "starred_url": "https://api.github.com/users/qlzh727/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qlzh727/subscriptions", "organizations_url": "https://api.github.com/users/qlzh727/orgs", "repos_url": "https://api.github.com/users/qlzh727/repos", "events_url": "https://api.github.com/users/qlzh727/events{/privacy}", "received_events_url": "https://api.github.com/users/qlzh727/received_events", "type": "User", "site_admin": false }
[ { "login": "qlzh727", "id": 5118881, "node_id": "MDQ6VXNlcjUxMTg4ODE=", "avatar_url": "https://avatars.githubusercontent.com/u/5118881?v=4", "gravatar_id": "", "url": "https://api.github.com/users/qlzh727", "html_url": "https://github.com/qlzh727", "followers_url": "https://api.github.com/users/qlzh727/followers", "following_url": "https://api.github.com/users/qlzh727/following{/other_user}", "gists_url": "https://api.github.com/users/qlzh727/gists{/gist_id}", "starred_url": "https://api.github.com/users/qlzh727/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qlzh727/subscriptions", "organizations_url": "https://api.github.com/users/qlzh727/orgs", "repos_url": "https://api.github.com/users/qlzh727/repos", "events_url": "https://api.github.com/users/qlzh727/events{/privacy}", "received_events_url": "https://api.github.com/users/qlzh727/received_events", "type": "User", "site_admin": false }, { "login": "wangpengmit", "id": 7817365, "node_id": "MDQ6VXNlcjc4MTczNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/7817365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wangpengmit", "html_url": "https://github.com/wangpengmit", "followers_url": "https://api.github.com/users/wangpengmit/followers", "following_url": "https://api.github.com/users/wangpengmit/following{/other_user}", "gists_url": "https://api.github.com/users/wangpengmit/gists{/gist_id}", "starred_url": "https://api.github.com/users/wangpengmit/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wangpengmit/subscriptions", "organizations_url": "https://api.github.com/users/wangpengmit/orgs", "repos_url": "https://api.github.com/users/wangpengmit/repos", "events_url": "https://api.github.com/users/wangpengmit/events{/privacy}", "received_events_url": "https://api.github.com/users/wangpengmit/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "@mergian Thanks for reporting this issue.\r\n\r\nI was able to reproduce this issue in TF 2.11 and TF Nightly 2.13.0-dev20230209 . Please find the gist [here](https://colab.research.google.com/gist/pjpratik/ebeaa08d55c8797134f250ffa20606b4/59635.ipynb).\r\n\r\n@SuryanarayanaY Could you please look into this. Thanks.", "Hi @mergian ,\r\nDid you have any plan to fix this ? Please feel free to create a PR for this. Thanks!", "Hey @SuryanarayanaY\r\n\r\nI unfortunately don't have a good idea. To my understanding the problem is as follows:\r\n\r\nIn eager mode, TF checks if a random operation is \"unique\" using the local seed. So TF allocates the local seed object `PhiloxRandom` once for `123` in my example, and uses the same object for both calls.\r\n\r\nIncontrast, in graph mode TF creates local seed objects for each occurance of `tf.random.uniform(...)` within the graph, irrespectful of the seed argument.\r\n\r\n\r\nThis said: Syntactically I think eager mode is actually correct, as the user specified the identical local seed, and therefore TF should use the same local seed object for both calls. The problem however might come then when applying distribution strategies, where the first and second call to `tf.random.uniform(..., seed=123)` might not be executed on the same device, so sharing the same local seed object would not be possible or at least, difficult to implement.\r\n\r\nThe other way around, I think it's not possible for eager mode to identify that the two calls are not the same.\r\n\r\n\r\nA \"quick fix\" would be to document this behavior and make users aware that they should use different local seeds in their random calls to have correct behavior.\r\n\r\n\r\nOther solutions would likely require API changes. E.g., I've looked into how PyTorch is doing their random numbers ( https://pytorch.org/docs/stable/generated/torch.rand.html ). The user can either provide a `torch.Generator` object, which is a local seed object, or otherwise it will fall back to use the global seed object. I think this approach was not incorporated into TF to enable local random states for distributed computations.", "For distribution strategies, it is already documented as stated below.\r\n\r\n> Do not use [tf.compat.v1.Session](https://www.tensorflow.org/api_docs/python/tf/compat/v1/Session) and [tf.distribute.experimental.ParameterServerStrategy](https://www.tensorflow.org/api_docs/python/tf/distribute/experimental/ParameterServerStrategy), which can introduce nondeterminism. Besides ops (including [tf.data](https://www.tensorflow.org/api_docs/python/tf/data) ops), these are the only known potential sources of nondeterminism within TensorFlow, (if you find more, please file an issue). Note that [tf.compat.v1.Session](https://www.tensorflow.org/api_docs/python/tf/compat/v1/Session) is required to use the TF1 API, so determinism cannot be guaranteed when using the TF1 API.\r\n\r\nAdditional details are mentioned here https://www.tensorflow.org/api_docs/python/tf/config/experimental/enable_op_determinism", "cc @qlzh727 ", "Please see [the RNG guide](https://www.tensorflow.org/guide/random_numbers).", "Thanks for posting the two guides. I agree that using the newer variants with Generator or Stateless should not produce this problem. Still: as long as `tf.random.uniform` is not deprecated, I think the bug should be mentioned in the corresponding documentation: https://www.tensorflow.org/api_docs/python/tf/random/uniform\r\n\r\nAlso in the `tf.random.uniform` page it is not mentioned that it is strongly discouraged to use these." ]
2023-02-10T07:31:14
2023-03-27T05:56:57
null
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source binary ### Tensorflow Version 2.11.0 ### Custom Code No ### OS Platform and Distribution Linux CentOS ### Mobile device _No response_ ### Python version 3.7 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Executing the identical Keras model in eager and graph mode produce different results when the identical seed is passed to `tf.random.uniform`. I created a small example that just generates 2 random outputs. In one case, I use different values for seed, in the other I use identical seeds. As you can see in the output, in the case where the seeds differ, I get the same result using `model(data)` and `model.predict(data)`. However, when my seeds are identical, then I get other results in eager mode. I tried to pinpoint the source for this, and I think I found it. I modified the PhiloxRandom class to do some output whenever a function is called. It shows the pointer of `this`, which function gets called and also the `key[0:2]` and `columns[0:4]` values. `key` gets initialized through the global seed `tf.random.set_seed(...)` and `columns[2:4]` through the `seed` value passed to `tf.random.uniform`. What we see is, that in the case where the seed differs, TensorFlow creates two instances of `PhiloxRandom(...)`, one with 0x7C (==124) and one with 0x7B (==123) as seed. The same happens in graph mode. I think this is the expected behavior. In the case where the seeds are identical, we see that in eager mode only one instance of PhiloxRandom is created, and it gets called twice. So it uses an accumulated seed in the second `tf.random.uniform(...)`, which is wrong. My assumption is that TensorFlow in eager mode caches the operator instance and just reuses it when the "identical" layer gets called. However, in this particular case this causes undeterministic results, which differ from the graph mode. ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf import numpy as np # see: https://www.tensorflow.org/api_docs/python/tf/config/experimental/enable_op_determinism tf.keras.utils.set_random_seed(1) tf.config.experimental.enable_op_determinism() def create(seed_a, seed_b): inp = tf.keras.Input(shape=(5,)) x = inp / inp # == 1.0 a = tf.random.uniform(tf.shape(x), dtype=x.dtype, minval=-5, maxval=5, seed=seed_a) * x b = tf.random.uniform(tf.shape(x), dtype=x.dtype, minval=-5, maxval=5, seed=seed_b) * x return tf.keras.Model(inputs=[inp], outputs=[a, b]) def compare(seed_a, seed_b): print(f"## RUNNING {seed_a} {seed_b} ##") data = np.ones((1, 5), np.float32) model = create(seed_a, seed_b) eager = model(data) graph = model.predict(data) for i, (a, b) in enumerate(zip(eager, graph)): print(f'#{i}, A: {a.numpy()}, B: {b}') tf.random.set_seed(314159) compare(123, 124) tf.random.set_seed(314159) compare(123, 123) ``` ### Relevant log output ```shell # EXECUTION RESULTS --------------------------------------------------------- # ## RUNNING 123 124 ## #0, A: [[ 0.64956665 4.783145 -4.816675 4.7801285 1.6770649 ]], B: [[ 0.64956665 4.783145 -4.816675 4.7801285 1.6770649 ]] #1, A: [[ 1.321938 4.436612 2.8036633 -2.5721383 -3.595649 ]], B: [[ 1.321938 4.436612 2.8036633 -2.5721383 -3.595649 ]] ## RUNNING 123 123 ## #0, A: [[ 2.2466993 2.8111506 1.4583216 -0.34343958 2.204914 ]], B: [[ 0.64956665 4.783145 -4.816675 4.7801285 1.6770649 ]] #1, A: [[ 0.64956665 4.783145 -4.816675 4.7801285 1.6770649 ]], B: [[ 0.64956665 4.783145 -4.816675 4.7801285 1.6770649 ]] # /EXECUTION RESULTS -------------------------------------------------------- # # DEBUG --------------------------------------------------------------------- # ## RUNNING 123 124 ## ### EAGER 0x7fffb27e8170 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007C 00000000 0x4101a50 Skip(1280) 0x7fffb27e86f0 Skip(0) 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007C 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / 5150EBBA 4EF8C9E4 4D63E30B 919F139E 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007C 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / BC11F9C7 A411A7B1 99682563 B50F8A71 0x7fffb27e8170 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x412a130 Skip(1280) 0x7fffb27e86f0 Skip(0) 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / 5EC85080 05FD3969 A08258B8 61FD2F86 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007B 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / 4DD57768 F92C9439 A139802D 55996F6F ### GRAPH 0x7fffb27e9890 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007C 00000000 0x7fffb27e9890 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x441f8b0 Skip(1280) 0x7f8e1fffda30 Skip(0) 0x7f8e1fffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x7f8e1fffda30 OperatorEND(): 8FF812B0 96A522AD / 5EC85080 05FD3969 A08258B8 61FD2F86 0x7f8e1fffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007B 00000000 0x7f8e1fffda30 OperatorEND(): 8FF812B0 96A522AD / 4DD57768 F92C9439 A139802D 55996F6F 0x4454e30 Skip(1280) 0x7f8dfbffda30 Skip(0) 0x7f8dfbffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007C 00000000 0x7f8dfbffda30 OperatorEND(): 8FF812B0 96A522AD / 5150EBBA 4EF8C9E4 4D63E30B 919F139E 0x7f8dfbffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007C 00000000 0x7f8dfbffda30 OperatorEND(): 8FF812B0 96A522AD / BC11F9C7 A411A7B1 99682563 B50F8A71 ## RUNNING 123 123 ## ### EAGER 0x7fffb27e8170 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x4167510 Skip(1280) 0x7fffb27e86f0 Skip(0) 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / 5EC85080 05FD3969 A08258B8 61FD2F86 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007B 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / 4DD57768 F92C9439 A139802D 55996F6F 0x4167510 Skip(1280) 0x7fffb27e86f0 Skip(0) 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000500 00000000 0000007B 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / C7DCC1FC 4C63FB94 2352AAA1 D83B9A9E 0x7fffb27e86f0 OperatorBEGIN(): 0004CB2F 00000000 / 00000501 00000000 0000007B 00000000 0x7fffb27e86f0 OperatorEND(): 8FF812B0 96A522AD / 8DDC3910 CEB432E2 6CF2E131 6770FC94 ### GRAPH 0x7fffb27e9890 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x7fffb27e9890 PhiloxRandom(uint64_t, uint64_t): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x440ed40 Skip(1280) 0x7f8e1fffda30 Skip(0) 0x7f8e1fffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x7f8e1fffda30 OperatorEND(): 8FF812B0 96A522AD / 5EC85080 05FD3969 A08258B8 61FD2F86 0x7f8e1fffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007B 00000000 0x7f8e1fffda30 OperatorEND(): 8FF812B0 96A522AD / 4DD57768 F92C9439 A139802D 55996F6F 0x4500200 Skip(1280) 0x7f8dfbffda30 Skip(0) 0x7f8dfbffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000000 00000000 0000007B 00000000 0x7f8dfbffda30 OperatorEND(): 8FF812B0 96A522AD / 5EC85080 05FD3969 A08258B8 61FD2F86 0x7f8dfbffda30 OperatorBEGIN(): 0004CB2F 00000000 / 00000001 00000000 0000007B 00000000 0x7f8dfbffda30 OperatorEND(): 8FF812B0 96A522AD / 4DD57768 F92C9439 A139802D 55996F6F # /DEBUG -------------------------------------------------------------------- # ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59635/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59635/timeline
null
null
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59634
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59634/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59634/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59634/events
https://github.com/tensorflow/tensorflow/pull/59634
1,578,923,299
PR_kwDOArmXAs5JrCyD
59,634
[XLA] Add parser and codegen for more CPU architectures
{ "login": "kiszk", "id": 1315079, "node_id": "MDQ6VXNlcjEzMTUwNzk=", "avatar_url": "https://avatars.githubusercontent.com/u/1315079?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kiszk", "html_url": "https://github.com/kiszk", "followers_url": "https://api.github.com/users/kiszk/followers", "following_url": "https://api.github.com/users/kiszk/following{/other_user}", "gists_url": "https://api.github.com/users/kiszk/gists{/gist_id}", "starred_url": "https://api.github.com/users/kiszk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kiszk/subscriptions", "organizations_url": "https://api.github.com/users/kiszk/orgs", "repos_url": "https://api.github.com/users/kiszk/repos", "events_url": "https://api.github.com/users/kiszk/events{/privacy}", "received_events_url": "https://api.github.com/users/kiszk/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "I modified the patch slightly to make inclusion of targets conditional on the bazil configuration. Please reopen if this does not fix your issue.", "Thank you for letting me know. I will reopen it if it does not work." ]
2023-02-10T03:23:23
2023-02-16T15:47:30
2023-02-15T11:28:53
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59634", "html_url": "https://github.com/tensorflow/tensorflow/pull/59634", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59634.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59634.patch", "merged_at": "2023-02-15T11:28:53" }
This PR adds parser and codegen for PowerPC and SystemZ to execution engine in XLA runtime. I saw the following error w/o this PR when I ran Jax on s390x ``` $ python tests/core_test.py Traceback (most recent call last): File "/home/ishizaki/Jax/jax/tests/core_test.py", line 26, in <module> import jax File "/home/ishizaki/Jax/jax/jax/__init__.py", line 35, in <module> from jax import config as _config_module File "/home/ishizaki/Jax/jax/jax/config.py", line 17, in <module> from jax._src.config import config # noqa: F401 File "/home/ishizaki/Jax/jax/jax/_src/config.py", line 28, in <module> from jax._src import lib File "/home/ishizaki/Jax/jax/jax/_src/lib/__init__.py", line 87, in <module> import jaxlib.xla_client as xla_client File "/home/ishizaki/Jax/.venv/lib/python3.10/site-packages/jaxlib/xla_client.py", line 26, in <module> from . import xla_extension as _xla ImportError: /home/ishizaki/Jax/.venv/lib/python3.10/site-packages/jaxlib/xla_extension.so: undefined symbol: LLVMInitializeSystemZAsmParser ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59634/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59634/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59633
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59633/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59633/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59633/events
https://github.com/tensorflow/tensorflow/pull/59633
1,578,491,937
PR_kwDOArmXAs5Jpmcn
59,633
[oneDNN]Fix to close the file before exiting load_weights()
{ "login": "mraunak", "id": 83710963, "node_id": "MDQ6VXNlcjgzNzEwOTYz", "avatar_url": "https://avatars.githubusercontent.com/u/83710963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mraunak", "html_url": "https://github.com/mraunak", "followers_url": "https://api.github.com/users/mraunak/followers", "following_url": "https://api.github.com/users/mraunak/following{/other_user}", "gists_url": "https://api.github.com/users/mraunak/gists{/gist_id}", "starred_url": "https://api.github.com/users/mraunak/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mraunak/subscriptions", "organizations_url": "https://api.github.com/users/mraunak/orgs", "repos_url": "https://api.github.com/users/mraunak/repos", "events_url": "https://api.github.com/users/mraunak/events{/privacy}", "received_events_url": "https://api.github.com/users/mraunak/received_events", "type": "User", "site_admin": false }
[ { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @mraunak It looks like your PR relates to the Keras component. Please submit it to the github.com/keras-team/keras repository instead. Thankyou.\r\n@fchollet, @qlzh727", "Hi @gbaned, this file ( tensorflow/python/keras/engine/training.py) is getting called when the user is executing his code in the issue mentioned which resides inside the TensorFlow. I am not sure how fixing in Keras repo would fix this issue.", "Hi @gbaned, yeah sure I will submit PR to the github.com/keras-team/keras repository." ]
2023-02-09T19:49:44
2023-02-27T22:56:15
2023-02-10T08:08:10
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59633", "html_url": "https://github.com/tensorflow/tensorflow/pull/59633", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59633.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59633.patch", "merged_at": null }
The method 'load_weights()' which loads all layer weights, either from a TensorFlow or an HDF5 weight file, kept the file open due to which the next action of saving the checkpoints was failing on windows server 2019. The code change will now make sure that the weight files are closed before exiting the 'load_weights()' method. The solution fixes https://github.com/tensorflow/tensorflow/issues/58740
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59633/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59632
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59632/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59632/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59632/events
https://github.com/tensorflow/tensorflow/pull/59632
1,578,216,974
PR_kwDOArmXAs5Jorby
59,632
Adding support for dynamic shapes to the Unpack converter.
{ "login": "drivanov", "id": 32910461, "node_id": "MDQ6VXNlcjMyOTEwNDYx", "avatar_url": "https://avatars.githubusercontent.com/u/32910461?v=4", "gravatar_id": "", "url": "https://api.github.com/users/drivanov", "html_url": "https://github.com/drivanov", "followers_url": "https://api.github.com/users/drivanov/followers", "following_url": "https://api.github.com/users/drivanov/following{/other_user}", "gists_url": "https://api.github.com/users/drivanov/gists{/gist_id}", "starred_url": "https://api.github.com/users/drivanov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/drivanov/subscriptions", "organizations_url": "https://api.github.com/users/drivanov/orgs", "repos_url": "https://api.github.com/users/drivanov/repos", "events_url": "https://api.github.com/users/drivanov/events{/privacy}", "received_events_url": "https://api.github.com/users/drivanov/received_events", "type": "User", "site_admin": false }
[ { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" }, { "id": 1754777628, "node_id": "MDU6TGFiZWwxNzU0Nzc3NjI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:gpu:tensorrt", "name": "comp:gpu:tensorrt", "color": "ea98ba", "default": false, "description": "Issues specific to TensorRT" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Some repetitive code used by 4 converters (**ConvertStridedSlice, ConvertSlice, ConvertSplit, ConvertUnpack**) has been moved to the newly implemented **ConvertStridedSliceHelper** function.", "Hi @drivanov Can you please resolve conflicts? Thank you!", "Hi @pjannaty Can you please review this PR ? Thank you!", "Hi @pjannaty Can you please review this PR ? Thank you!", "Hi @drivanov, @pjannaty I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! Thank you!" ]
2023-02-09T16:30:06
2023-10-30T06:57:14
2023-10-30T06:57:11
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59632", "html_url": "https://github.com/tensorflow/tensorflow/pull/59632", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59632.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59632.patch", "merged_at": null }
null
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59632/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59631
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59631/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59631/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59631/events
https://github.com/tensorflow/tensorflow/issues/59631
1,578,131,325
I_kwDOArmXAs5eEF99
59,631
`tflite-runtime-nightly` on ARM64 has minimum GLIBC requirement 2.33, which prevents installation in official `python` container images
{ "login": "johnthagen", "id": 10340167, "node_id": "MDQ6VXNlcjEwMzQwMTY3", "avatar_url": "https://avatars.githubusercontent.com/u/10340167?v=4", "gravatar_id": "", "url": "https://api.github.com/users/johnthagen", "html_url": "https://github.com/johnthagen", "followers_url": "https://api.github.com/users/johnthagen/followers", "following_url": "https://api.github.com/users/johnthagen/following{/other_user}", "gists_url": "https://api.github.com/users/johnthagen/gists{/gist_id}", "starred_url": "https://api.github.com/users/johnthagen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/johnthagen/subscriptions", "organizations_url": "https://api.github.com/users/johnthagen/orgs", "repos_url": "https://api.github.com/users/johnthagen/repos", "events_url": "https://api.github.com/users/johnthagen/events{/privacy}", "received_events_url": "https://api.github.com/users/johnthagen/received_events", "type": "User", "site_admin": false }
[ { "id": 473173351, "node_id": "MDU6TGFiZWw0NzMxNzMzNTE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:build/install", "name": "type:build/install", "color": "159b2e", "default": false, "description": "Build and install issues" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1205615612, "node_id": "MDU6TGFiZWwxMjA1NjE1NjEy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/subtype:%20ubuntu/linux", "name": "subtype: ubuntu/linux", "color": "b619ea", "default": false, "description": "Ubuntu/Linux Build/Installation Issues" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Interesting that we'd get 2.33 when Ubuntu 20.04 build images should be 2.31", "ldd -v output from the arm64 build:\r\n\r\n```\r\n> ldd -v _pywrap_tensorflow_interpreter_wrapper.so\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /usr/lib/aarch64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.13' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\nlibm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000005501c4a000)\r\nlibstdc++.so.6 => /usr/lib/aarch64-linux-gnu/libstdc++.so.6 (0x0000005501cf5000)\r\nlibgcc_s.so.1 => /lib/aarch64-linux-gnu/libgcc_s.so.1 (0x0000005501ecd000)\r\nlibc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000005501ef1000)\r\n/lib/ld-linux-aarch64.so.1 (0x0000005500000000)\r\n```\r\n\r\nThis does not happen in the x86_64 build:\r\n\r\n```\r\n> ldd -v _pywrap_tensorflow_interpreter_wrapper.so\r\nlinux-vdso.so.1 (0x00007ffc9cb4a000)\r\nlibpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f31e875c000)\r\nlibm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f31e8618000)\r\nlibdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f31e8612000)\r\nlibstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f31e8445000)\r\nlibgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f31e842b000)\r\nlibc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f31e8254000)\r\n/lib64/ld-linux-x86-64.so.2 (0x00007f31e8c6b000)", "objdump -T output of failing symbols on arm64\r\n\r\n```\r\n...\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.33 fstat\r\n...\r\n0000000000000000 DO *UND*\t0000000000000000 GLIBC_2.32 __libc_single_threaded\r\n...\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.34 dlopen\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.34 pthread_create\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.34 pthread_join\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.34 pthread_once\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.34 dlsym\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBC_2.34 dlerror\r\n...\r\n0000000000000000 DF *UND*\t0000000000000000 GLIBCXX_3.4.29 _ZSt28__throw_bad_array_new_lengthv\r\n...\r\n0000000000000000 DF *UND*\t0000000000000000 CXXABI_1.3.13 _ZNSt15__exception_ptr13exception_ptr9_M_addrefEv\r\n0000000000000000 DF *UND*\t0000000000000000 CXXABI_1.3.13 _ZNSt15__exception_ptr13exception_ptr10_M_releaseEv\r\n...\r\n```\r\n\r\nOn x86_64:\r\n1. `dlopen`, `pthread_create`, `pthread_join`, `pthread_once`, `dlsym`, `dlerror` are using `GLIBC_2.2.5`\r\n2. `_ZSt28__throw_bad_array_new_lengthv`, `__libc_single_threaded`, `fstat` were not on the table\r\n3. All `_exception_ptr` are using `CXXABI_1.3.3`", "Similar issue on armv7 builds: \r\n\r\n```\r\nldd -v _pywrap_tensorflow_interpreter_wrapper.so\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /usr/lib/arm-linux-gnueabihf/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /usr/lib/arm-linux-gnueabihf/libstdc++.so.6: version `CXXABI_1.3.13' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /lib/arm-linux-gnueabihf/libc.so.6: version `GLIBC_2.33' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /lib/arm-linux-gnueabihf/libc.so.6: version `GLIBC_2.32' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\n./_pywrap_tensorflow_interpreter_wrapper.so: /lib/arm-linux-gnueabihf/libc.so.6: version `GLIBC_2.34' not found (required by ./_pywrap_tensorflow_interpreter_wrapper.so)\r\nlibm.so.6 => /lib/arm-linux-gnueabihf/libm.so.6 (0x3f4a9000)\r\nlibstdc++.so.6 => /usr/lib/arm-linux-gnueabihf/libstdc++.so.6 (0x3f36e000)\r\nlibgcc_s.so.1 => /lib/arm-linux-gnueabihf/libgcc_s.so.1 (0x3f345000)\r\nlibc.so.6 => /lib/arm-linux-gnueabihf/libc.so.6 (0x3f246000)\r\n/lib/ld-linux-armhf.so.3 (0x40000000)\r\n```\r\n\r\nExact same symbols on arm64 build are the ones failing on armv7", "Could you confirm if this only happens in `tflite-runtime-nightly`? Does `tflite-runtime` still work?", "Doesn't seem to happen on upstream `tflite-runtime`.\r\n\r\n```\r\n> ldd -v _pywrap_tensorflow_interpreter_wrapper.so\r\nlibdl.so.2 => /lib/aarch64-linux-gnu/libdl.so.2 (0x0000005501db1000)\r\nlibpthread.so.0 => /lib/aarch64-linux-gnu/libpthread.so.0 (0x0000005501dc7000)\r\nlibstdc++.so.6 => /usr/lib/aarch64-linux-gnu/libstdc++.so.6 (0x0000005501df6000)\r\nlibm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000005501f81000)\r\nlibgcc_s.so.1 => /lib/aarch64-linux-gnu/libgcc_s.so.1 (0x000000550203e000)\r\nlibc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000005502062000)\r\n/lib/ld-linux-aarch64.so.1 (0x0000005500000000)\r\n```\r\n\r\nI just checked python 3.9 version of tflite-runtime-nightly and it happens on arm64/armv7 builds as well.\r\n\r\nIt started happening on `2.12.0.dev20230202`. #59423 was merged after this nighly build, so I assume the issue comes from a tad bit before? Unless I'm misunderstanding how nightlies are stamped/built.\r\n\r\nJudging from the time frame, it was after `2.12.0.dev20230131` and before `2.12.0.dev20230202`. So maybe something in these [commits](https://github.com/tensorflow/tensorflow/commits/master/tensorflow/lite/tools/pip_package): 62b4e834276a414c0179f6640aea3ce27e11ba0b - 875df1672f492a0685f82d2c2dc5ea26d014fd87 that switched the build to bazel?\r\n\r\n", "Right, recently ARM toolchain was updated. https://github.com/tensorflow/tensorflow/pull/57585\r\nI think we'd better not to use it for Python wheel build. Let me handle it.", "@terryheo Ah I see. I thought we'd be using the toolchains from https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/tools/cmake/download_toolchains.sh, but I guess that's only for the cmake build?\r\n\r\ndownload_toolchains.sh **could** be updated to 9.2.1 if we want to bump it a little to keep glibc versions happy (e.g.):\r\n1. From `gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf` (8.3.0) to `gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf` (9.2.1)\r\n2. From `gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu` to `gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu`\r\n\r\nAlthough not sure if `9.2.1` would resolve the issues in #57364, I wonder if `10.3-2021.07` would still resolve the issue yet still be compatible. Ubuntu 20.04 was default was gcc-9, Ubuntu 22.04 default is gcc-11, so I'd assume we'd want to stick with the 9.x tools since we're building with 20.04 now. Stricly debian, bullseye defaults to gcc-10, where as buster defaults to gcc-8.\r\n\r\nFull file below for posterity in case that also needs to happen...\r\n\r\n<details>\r\n <summary>toolchains.diff</summary>\r\n\r\n```diff\r\n #!/bin/bash\r\n # Copyright 2021 The TensorFlow Authors. All Rights Reserved.\r\n #\r\n # Licensed under the Apache License, Version 2.0 (the \"License\");\r\n # you may not use this file except in compliance with the License.\r\n # You may obtain a copy of the License at\r\n #\r\n # http://www.apache.org/licenses/LICENSE-2.0\r\n #\r\n # Unless required by applicable law or agreed to in writing, software\r\n # distributed under the License is distributed on an \"AS IS\" BASIS,\r\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r\n # See the License for the specific language governing permissions and\r\n # limitations under the License.\r\n # ==============================================================================\r\n \r\n set -e\r\n \r\n SCRIPT_DIR=\"$(cd \"$(dirname \"${BASH_SOURCE[0]}\")\" && pwd)\"\r\n cd \"$SCRIPT_DIR/../../../..\"\r\n \r\n TOOLCHAINS_DIR=$(realpath tensorflow/lite/tools/cmake/toolchains)\r\n mkdir -p ${TOOLCHAINS_DIR}\r\n \r\n case $1 in\r\n \tarmhf)\r\n- if [[ ! -d \"${TOOLCHAINS_DIR}/gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf\" ]]; then\r\n- curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf.tar.xz >&2\r\n- tar xvf gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf.tar.xz -C ${TOOLCHAINS_DIR} >&2\r\n+ if [[ ! -d \"${TOOLCHAINS_DIR}/gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf\" ]]; then\r\n+ curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf.tar.xz >&2\r\n+ tar xvf gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf.tar.xz -C ${TOOLCHAINS_DIR} >&2\r\n fi\r\n- ARMCC_ROOT=${TOOLCHAINS_DIR}/gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf\r\n+ ARMCC_ROOT=${TOOLCHAINS_DIR}/gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf\r\n echo \"ARMCC_FLAGS=\\\"-march=armv7-a -mfpu=neon-vfpv4 -funsafe-math-optimizations \\\r\n- -isystem ${ARMCC_ROOT}/lib/gcc/arm-linux-gnueabihf/8.3.0/include \\\r\n- -isystem ${ARMCC_ROOT}/lib/gcc/arm-linux-gnueabihf/8.3.0/include-fixed \\\r\n- -isystem ${ARMCC_ROOT}/arm-linux-gnueabihf/include/c++/8.3.0 \\\r\n- -isystem ${ARMCC_ROOT}/arm-linux-gnueabihf/libc/usr/include \\\r\n+ -isystem ${ARMCC_ROOT}/lib/gcc/arm-none-linux-gnueabihf/9.2.1/include \\\r\n+ -isystem ${ARMCC_ROOT}/lib/gcc/arm-none-linux-gnueabihf/9.2.1/include-fixed \\\r\n+ -isystem ${ARMCC_ROOT}/arm-none-linux-gnueabihf/include/c++/9.2.1 \\\r\n+ -isystem ${ARMCC_ROOT}/arm-none-linux-gnueabihf/libc/usr/include \\\r\n -isystem \\\"\\${CROSSTOOL_PYTHON_INCLUDE_PATH}\\\" \\\r\n -isystem /usr/include\\\"\"\r\n- echo \"ARMCC_PREFIX=${ARMCC_ROOT}/bin/arm-linux-gnueabihf-\"\r\n+ echo \"ARMCC_PREFIX=${ARMCC_ROOT}/bin/arm-none-linux-gnueabihf-\"\r\n \t\t;;\r\n \taarch64)\r\n- if [[ ! -d \"${TOOLCHAINS_DIR}/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu\" ]]; then\r\n- curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz >&2\r\n- tar xvf gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz -C ${TOOLCHAINS_DIR} >&2\r\n+ if [[ ! -d \"${TOOLCHAINS_DIR}/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu\" ]]; then\r\n+ curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu.tar.xz >&2\r\n+ tar xvf gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu.tar.xz -C ${TOOLCHAINS_DIR} >&2\r\n fi\r\n- ARMCC_ROOT=${TOOLCHAINS_DIR}/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu\r\n+ ARMCC_ROOT=${TOOLCHAINS_DIR}/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu\r\n echo \"ARMCC_FLAGS=\\\"-funsafe-math-optimizations \\\r\n- -isystem ${ARMCC_ROOT}/lib/gcc/aarch64-linux-gnu/8.3.0/include \\\r\n- -isystem ${ARMCC_ROOT}/lib/gcc/aaarch64-linux-gnu/8.3.0/include-fixed \\\r\n- -isystem ${ARMCC_ROOT}/aarch64-linux-gnu/include/c++/8.3.0 \\\r\n- -isystem ${ARMCC_ROOT}/aarch64-linux-gnu/libc/usr/include \\\r\n+ -isystem ${ARMCC_ROOT}/lib/gcc/aarch64-none-linux-gnu/9.2.1/include \\\r\n+ -isystem ${ARMCC_ROOT}/lib/gcc/aarch64-none-linux-gnu/9.2.1/include-fixed \\\r\n+ -isystem ${ARMCC_ROOT}/aarch64-none-linux-gnu/include/c++/9.2.1 \\\r\n+ -isystem ${ARMCC_ROOT}/aarch64-none-linux-gnu/libc/usr/include \\\r\n -isystem \\\"\\${CROSSTOOL_PYTHON_INCLUDE_PATH}\\\" \\\r\n -isystem /usr/include\\\"\"\r\n- echo \"ARMCC_PREFIX=${ARMCC_ROOT}/bin/aarch64-linux-gnu-\"\r\n+ echo \"ARMCC_PREFIX=${ARMCC_ROOT}/bin/aarch64-none-linux-gnu-\"\r\n \t\t;;\r\n \trpi0)\r\n- if [[ ! -d \"${TOOLCHAINS_DIR}/gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf\" ]]; then\r\n- curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf.tar.xz >&2\r\n- tar xvf gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf.tar.xz -C ${TOOLCHAINS_DIR} >&2\r\n+ if [[ ! -d \"${TOOLCHAINS_DIR}/gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf\" ]]; then\r\n+ curl -LO https://storage.googleapis.com/mirror.tensorflow.org/developer.arm.com/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf.tar.xz >&2\r\n+ tar xvf gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf.tar.xz -C ${TOOLCHAINS_DIR} >&2\r\n fi\r\n- ARMCC_ROOT=${TOOLCHAINS_DIR}/gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf\r\n+ ARMCC_ROOT=${TOOLCHAINS_DIR}/gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf\r\n echo \"ARMCC_FLAGS=\\\"-march=armv6 -mfpu=vfp -mfloat-abi=hard -funsafe-math-optimizations \\\r\n- -isystem ${ARMCC_ROOT}/lib/gcc/arm-linux-gnueabihf/8.3.0/include \\\r\n- -isystem ${ARMCC_ROOT}/lib/gcc/arm-linux-gnueabihf/8.3.0/include-fixed \\\r\n- -isystem ${ARMCC_ROOT}/arm-linux-gnueabihf/include/c++/8.3.0 \\\r\n- -isystem ${ARMCC_ROOT}/arm-linux-gnueabihf/libc/usr/include \\\r\n+ -isystem ${ARMCC_ROOT}/lib/gcc/arm-none-linux-gnueabihf/9.2.1/include \\\r\n+ -isystem ${ARMCC_ROOT}/lib/gcc/arm-none-linux-gnueabihf/9.2.1/include-fixed \\\r\n+ -isystem ${ARMCC_ROOT}/arm-none-linux-gnueabihf/include/c++/9.2.1 \\\r\n+ -isystem ${ARMCC_ROOT}/arm-none-linux-gnueabihf/libc/usr/include \\\r\n -isystem \\\"\\${CROSSTOOL_PYTHON_INCLUDE_PATH}\\\" \\\r\n -isystem /usr/include\\\"\"\r\n- echo \"ARMCC_PREFIX=${ARMCC_ROOT}/bin/arm-linux-gnueabihf-\"\r\n+ echo \"ARMCC_PREFIX=${ARMCC_ROOT}/bin/arm-none-linux-gnueabihf-\"\r\n ;;\r\n \t*)\r\n \t\techo \"Usage: download_toolchains.sh [armhf|aarch64|rpi0]\" >&2\r\n exit\r\n \t\t;;\r\n esac\r\n \r\n echo \"download_toolchains.sh completed successfully.\" >&2\r\n```\r\n\r\n</details>", "I've updated internal build script to use CMake to build Python wheels.\r\nSo the nightly should be fine now. Please let me know if the issue still exists.\r\n\r\n\r\nRegarding the `toolchain.sh` update, I'd better keep it as it is since we need more compatibility. For those who need more up-to-date toolchain, they can use their own toolchain without relying on the script.", "> So the nightly should be fine now. Please let me know if the issue still exists.\r\n\r\nWill test the new `-nightly` when the next is published. Looks like the latest is still from 2 days ago:\r\n\r\n- https://pypi.org/project/tflite-runtime-nightly/#history", "@terryheo \r\n\r\nIt now seems that the _x86_ wheels are broken. To reproduce, use the following `Dockerfile` on an x86 platform:\r\n\r\n\r\n```Dockerfile\r\nFROM python:3.10-slim-bullseye\r\n\r\nENV PYTHONDONTWRITEBYTECODE 1\r\nENV PYTHONUNBUFFERED 1\r\nENV PIP_NO_CACHE_DIR 1\r\n\r\nRUN pip install \"tflite-runtime-nightly==2.13.0.dev20230214\"\r\nRUN python -c \"import tflite_runtime.interpreter as tflite\"\r\n```\r\n\r\nTrying to build this container image:\r\n\r\n```\r\n => ERROR [3/3] RUN python -c \"import tflite_runtime.interpreter as tflite\" 0.6s\r\n------ \r\n > [3/3] RUN python -c \"import tflite_runtime.interpreter as tflite\": \r\n#0 0.544 Traceback (most recent call last): \r\n#0 0.544 File \"<string>\", line 1, in <module> \r\n#0 0.544 File \"/usr/local/lib/python3.10/site-packages/tflite_runtime/interpreter.py\", line 33, in <module> \r\n#0 0.544 from tflite_runtime import _pywrap_tensorflow_interpreter_wrapper as _interpreter_wrapper\r\n#0 0.544 ImportError: /usr/local/lib/python3.10/site-packages/tflite_runtime/_pywrap_tensorflow_interpreter_wrapper.so: undefined symbol: _ZN6tflite9telemetry20TelemetryReportEventEP13TfLiteContextPKc12TfLiteStatus\r\n------\r\n```\r\n\r\nWe haven't tested ARM yet.", "Seems to happen on ARM builds as well", "Oops. Let me take a look.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59631\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59631\">No</a>\n", "@samypr100 @terryheo Wanted to report that [`tflite-runtime-nightly 2.13.0.dev20230219`](https://pypi.org/project/tflite-runtime-nightly/2.13.0.dev20230219/) passed our testing on both x86 and ARM. 🚀 Thanks!", "Somewhat related to this issue: Are there any plans of releasing `tensorflow/tensorflow` Docker images for ARM64?\r\n\r\nRelated to https://github.com/ARM-software/Tool-Solutions/issues/169#issuecomment-1460931621", "> Are there any plans of releasing tensorflow/tensorflow images for ARM64?\r\n\r\nThey already exist.\r\n\r\n### Linux\r\n\r\n- https://pypi.org/project/tensorflow/2.11.0/#files\r\n- `tensorflow-2.11.0-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl`\r\n\r\n### MacOS\r\n\r\n- https://pypi.org/project/tensorflow-macos/2.11.0/#files\r\n- `tensorflow_macos-2.11.0-cp310-cp310-macosx_12_0_arm64.whl`", "Whops sorry, I meant `tensorflow/tensorflow` *Docker* images. I wasn't specific enough " ]
2023-02-09T15:37:31
2023-03-13T17:31:34
2023-02-16T07:11:15
NONE
null
null
null
### System information - **Have I written custom code (as opposed to using a stock example script provided in TensorFlow)**: No - **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: `python:3.10-slim-bullseye` container image on **ARM64** - **Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on a mobile device**: N/A - **TensorFlow installed from (source or binary)**: Binary - **TensorFlow version (use command below)**: `tflite-runtime-nightly` `2.13.0.dev20230207` - **Python version**: 3.10.10 - **Bazel version (if compiling from source)**: N/A - **GCC/Compiler version (if compiling from source)**: N/A - **CUDA/cuDNN version**: N/A - **GPU model and memory**: N/A - **Exact command to reproduce**: ### Describe the problem 1. Create a new `python:3.10-slim-bullseye` container 2. Install [`tflite-runtime-nightly` `2.13.0.dev20230207`](https://pypi.org/project/tflite-runtime-nightly/2.13.0.dev20230207/) 3. Build and run the container on **ARM64** (such as from an ARM Macbook using Docker Desktop) 4. Run ``` >>> import tflite_runtime.interpreter as tflite Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/opt/venv/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 33, in <module> from tflite_runtime import _pywrap_tensorflow_interpreter_wrapper as _interpreter_wrapper ImportError: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /opt/venv/lib/python3.10/site-packages/tflite_runtime/_pywrap_tensorflow_interpreter_wrapper.so) ``` There are not yet any Debian bookworm-based [`python` official images](https://hub.docker.com/_/python) yet, so it's not possible to bump up to a newer Debian version with a newer GLIBC. ### Other background This worked fine in a `python:3.10-slim-bullseye` **x86** container, so perhaps the GLIBC version requirements are different due to how the ARM64 wheels were built? Here are the GLIBC versions of various Linux platforms: ``` Debian Buster: 2.28 Bullseye: 2.31 Bookworm: 2.36 Ubuntu 20.04: 2.31 22.04: 2.35 RHEL 8: 2.28 9: 2.34 ``` Related to: - #59423 CC @samypr100 @terryheo
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59631/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59631/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59630
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59630/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59630/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59630/events
https://github.com/tensorflow/tensorflow/issues/59630
1,577,471,086
I_kwDOArmXAs5eBkxu
59,630
Control Flow Ops with external delegate NPU
{ "login": "DiXcipuli", "id": 33719470, "node_id": "MDQ6VXNlcjMzNzE5NDcw", "avatar_url": "https://avatars.githubusercontent.com/u/33719470?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DiXcipuli", "html_url": "https://github.com/DiXcipuli", "followers_url": "https://api.github.com/users/DiXcipuli/followers", "following_url": "https://api.github.com/users/DiXcipuli/following{/other_user}", "gists_url": "https://api.github.com/users/DiXcipuli/gists{/gist_id}", "starred_url": "https://api.github.com/users/DiXcipuli/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DiXcipuli/subscriptions", "organizations_url": "https://api.github.com/users/DiXcipuli/orgs", "repos_url": "https://api.github.com/users/DiXcipuli/repos", "events_url": "https://api.github.com/users/DiXcipuli/events{/privacy}", "received_events_url": "https://api.github.com/users/DiXcipuli/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473184161, "node_id": "MDU6TGFiZWw0NzMxODQxNjE=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:support", "name": "type:support", "color": "159b2e", "default": false, "description": "Support issues" }, { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" }, { "id": 3797168204, "node_id": "LA_kwDOArmXAs7iVDBM", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.8", "name": "TF 2.8", "color": "5DC9D0", "default": false, "description": "" } ]
closed
false
{ "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false }
[ { "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false } ]
null
[ "@DiXcipuli \r\nCould you please try to add the following dependency in your gradle file to model:\r\n> org.tensorflow:tensorflow-lite-select-tf-ops:2.8\r\n\r\nPlease refer to this [doc](https://www.tensorflow.org/lite/guide/ops_select#run_inference) and let us know if it helps.\r\n\r\nThank you!", "This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.\n", "Closing as stale. Please reopen if you'd like to work on this further.\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59630\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59630\">No</a>\n" ]
2023-02-09T08:41:26
2023-02-27T20:07:07
2023-02-27T20:07:05
NONE
null
null
null
### 1. System information - OS Platform and Distribution : Ubuntu20.04 - TensorFlow installation : conda - TensorFlow library : 2.8.1 I am converting a pytorch model to Int8 quantize tensorflowlite model, to run it on a NXP board, on which I use delegates to make it run on the NPU. My original model contains an Unsqueeze block, which is somehow transformed into a While Ops (I can see that with netron, between the onnx and tflite model). Running this model on the board with the delegate (**libvx_delegate.so**) gives me the error: `ERROR: Attempting to use a delegate that only supports static-sized tensors with a graph that has dynamic-sized tensors.` From this post: https://stackoverflow.com/questions/66682315/finding-dynamic-tensors-in-a-tflite-model I understand that the Control Flow Ops are treated as dynamic. My question is how can I run such a model with the delegate?
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59630/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59630/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59629
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59629/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59629/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59629/events
https://github.com/tensorflow/tensorflow/pull/59629
1,577,463,199
PR_kwDOArmXAs5JmI0s
59,629
support disable jit_scope op's gradients compile when disable scope op compile
{ "login": "YangWorker", "id": 34177800, "node_id": "MDQ6VXNlcjM0MTc3ODAw", "avatar_url": "https://avatars.githubusercontent.com/u/34177800?v=4", "gravatar_id": "", "url": "https://api.github.com/users/YangWorker", "html_url": "https://github.com/YangWorker", "followers_url": "https://api.github.com/users/YangWorker/followers", "following_url": "https://api.github.com/users/YangWorker/following{/other_user}", "gists_url": "https://api.github.com/users/YangWorker/gists{/gist_id}", "starred_url": "https://api.github.com/users/YangWorker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/YangWorker/subscriptions", "organizations_url": "https://api.github.com/users/YangWorker/orgs", "repos_url": "https://api.github.com/users/YangWorker/repos", "events_url": "https://api.github.com/users/YangWorker/events{/privacy}", "received_events_url": "https://api.github.com/users/YangWorker/received_events", "type": "User", "site_admin": false }
[ { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi @cheshire Can you please review this PR ? Thank you!", "@jlebar Could you take a look ? I think you were doing something similar with using jit_scope to control what exactly autoclustering is compiling.", "Sorry, @cheshire. I don't remember touching those files or have any useful expertise to lend here.", "Hi @YangWorker Can you please check @cheshire's comments and resolve conflicts ? Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "Hi @YangWorker Any update on this PR? Please. Thank you!", "Hi @YangWorker Any update on this PR? Please. Thank you!", "Hi @YangWorker Any update on this PR? Please. Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "This PR was closed because it has been inactive for 14 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-02-09T08:34:51
2023-09-24T01:48:27
2023-09-24T01:48:22
NONE
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59629", "html_url": "https://github.com/tensorflow/tensorflow/pull/59629", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59629.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59629.patch", "merged_at": null }
Add compile_gradients param for xla.experimental.jit_scope to support disable compile op's gradients ops. In some scenarios, if op is dynamic shaped, the gradients op of it is dynamic shaped too.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59629/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59629/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59628
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59628/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59628/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59628/events
https://github.com/tensorflow/tensorflow/pull/59628
1,577,240,983
PR_kwDOArmXAs5JlZWj
59,628
Fix debug build failure in SnapshotStreamWriter::SnapshotStreamWriter
{ "login": "DamonFool", "id": 19923746, "node_id": "MDQ6VXNlcjE5OTIzNzQ2", "avatar_url": "https://avatars.githubusercontent.com/u/19923746?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DamonFool", "html_url": "https://github.com/DamonFool", "followers_url": "https://api.github.com/users/DamonFool/followers", "following_url": "https://api.github.com/users/DamonFool/following{/other_user}", "gists_url": "https://api.github.com/users/DamonFool/gists{/gist_id}", "starred_url": "https://api.github.com/users/DamonFool/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DamonFool/subscriptions", "organizations_url": "https://api.github.com/users/DamonFool/orgs", "repos_url": "https://api.github.com/users/DamonFool/repos", "events_url": "https://api.github.com/users/DamonFool/events{/privacy}", "received_events_url": "https://api.github.com/users/DamonFool/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "> Thanks for the fix!\r\n\r\nThanks @sagunb for your review." ]
2023-02-09T04:59:31
2023-02-13T19:31:29
2023-02-13T19:31:28
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59628", "html_url": "https://github.com/tensorflow/tensorflow/pull/59628", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59628.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59628.patch", "merged_at": "2023-02-13T19:31:28" }
Hi all, The debug build is broken with the following error msg. ``` # Execution platform: @local_execution_config_platform//:platform In file included from ./tensorflow/tsl/platform/logging.h:26, from ./tensorflow/tsl/platform/errors.h:26, from ./tensorflow/tsl/platform/statusor.h:72, from ./tensorflow/core/data/service/snapshot/path_utils.h:22, from ./tensorflow/core/data/service/snapshot/snapshot_stream_writer.h:25, from tensorflow/core/data/service/snapshot/snapshot_stream_writer.cc:15: ./tensorflow/tsl/platform/default/logging.h: In instantiation of 'void tsl::internal::MakeCheckOpValueString(std::ostream*, const T&) [with T = std::unique_ptr<tensorflow::data::TaskIterator>; std::ostream = std::basic_ostream<char>]': ./tensorflow/tsl/platform/default/logging.h:372:25: required from 'std::string* tsl::internal::MakeCheckOpString(const T1&, const T2&, const char*) [with T1 = std::unique_ptr<tensorflow::data::TaskIterator>; T2 = std::nullptr_t; std::string = std::basic_string<char>]' ./tensorflow/tsl/platform/default/logging.h:416:1: required from 'std::string* tsl::internal::Check_NEImpl(const T1&, const T2&, const char*) [with T1 = std::unique_ptr<tensorflow::data::TaskIterator>; T2 = std::nullptr_t; std::string = std::basic_string<char>]' tensorflow/core/data/service/snapshot/snapshot_stream_writer.cc:67:3: required from here ./tensorflow/tsl/platform/default/logging.h:313:9: error: no match for 'operator<<' (operand types are 'std::ostream' {aka 'std::basic_ostream<char>'} and 'const std::unique_ptr<tensorflow::data::TaskIterator>') 313 | (*os) << v; | ~~~~~~^~~~ ./tensorflow/tsl/platform/default/logging.h:313:9: note: candidate: 'operator<<(int, int)' (built-in) ./tensorflow/tsl/platform/default/logging.h:313:9: note: no known conversion for argument 2 from 'const std::unique_ptr<tensorflow::data::TaskIterator>' to 'int' ``` Let's fix it. Thanks. Best regards, Jie
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59628/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59628/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59627
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59627/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59627/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59627/events
https://github.com/tensorflow/tensorflow/issues/59627
1,577,170,415
I_kwDOArmXAs5eAbXv
59,627
tf.math.digamma outputs NaN when receiving 0
{ "login": "mazeltovlee", "id": 91937711, "node_id": "U_kgDOBXrbrw", "avatar_url": "https://avatars.githubusercontent.com/u/91937711?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mazeltovlee", "html_url": "https://github.com/mazeltovlee", "followers_url": "https://api.github.com/users/mazeltovlee/followers", "following_url": "https://api.github.com/users/mazeltovlee/following{/other_user}", "gists_url": "https://api.github.com/users/mazeltovlee/gists{/gist_id}", "starred_url": "https://api.github.com/users/mazeltovlee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mazeltovlee/subscriptions", "organizations_url": "https://api.github.com/users/mazeltovlee/orgs", "repos_url": "https://api.github.com/users/mazeltovlee/repos", "events_url": "https://api.github.com/users/mazeltovlee/events{/privacy}", "received_events_url": "https://api.github.com/users/mazeltovlee/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "I was able to replicate the issue on Google Colab with latest stable version of Tensorflow 2.11 and also tried with tf-nightly-2.13.0-dev20230209 it's returning nan. Kindly refer to the gist [here](https://colab.sandbox.google.com/gist/synandi/4b432401f0c6c46b7c87c2c6be95faef/59627.ipynb). It seems like we have to dig more into this issue, we will update soon here. Thank you!", "@mazeltovlee, \r\n\r\nApologies for the delay. The reason for the discrepancy in the output of the digamma function between TensorFlow and other libraries such as SciPy, MATLAB, and PyTorch is a matter of convention. TensorFlow follows the C99 standard for special functions, that defines the digamma function to be NaN (Not a Number) at x = 0, while the other libraries follow a convention that defines the digamma function to be -inf (negative infinity) at x = 0.\r\n\r\nThis difference in behavior is due to the underlying mathematical definition of the digamma function and the conventions used by different libraries. Thank you!", "Hi, @synandi \r\n\r\nThanks for your detailed explanation. I will close this issue as it is the expected behavior of TensorFlow.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59627\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59627\">No</a>\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59627\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59627\">No</a>\n" ]
2023-02-09T03:29:01
2023-02-15T07:32:01
2023-02-15T07:31:58
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version 3.8 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell tf.math.digamma outputs nan when receiving zero. In contrast, spicy, Matlab, and pytorch output -inf. Following the blue curve in this graph (https://ww2.mathworks.cn/help/matlab/ref/psi.html#mw_8a9c6576-f489-4530-bd3f-f6c8d596c644), I guess digamma outputs -inf for zero is more accurate. ``` ### Standalone code to reproduce the issue ```shell tf.math.digamma(0.) # outputs <tf.Tensor: shape=(), dtype=float32, numpy=nan> scipy.special.digamma(0.) # outputs -inf torch.digamma(0.) # outputs -inf ``` ### Relevant log output _No response_</details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59627/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59627/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59626
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59626/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59626/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59626/events
https://github.com/tensorflow/tensorflow/issues/59626
1,577,155,808
I_kwDOArmXAs5eAXzg
59,626
[RNN] TFLite fails to convert LSTM to 16x8 quantization
{ "login": "blaine-fs", "id": 110433039, "node_id": "U_kgDOBpUTDw", "avatar_url": "https://avatars.githubusercontent.com/u/110433039?v=4", "gravatar_id": "", "url": "https://api.github.com/users/blaine-fs", "html_url": "https://github.com/blaine-fs", "followers_url": "https://api.github.com/users/blaine-fs/followers", "following_url": "https://api.github.com/users/blaine-fs/following{/other_user}", "gists_url": "https://api.github.com/users/blaine-fs/gists{/gist_id}", "starred_url": "https://api.github.com/users/blaine-fs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blaine-fs/subscriptions", "organizations_url": "https://api.github.com/users/blaine-fs/orgs", "repos_url": "https://api.github.com/users/blaine-fs/repos", "events_url": "https://api.github.com/users/blaine-fs/events{/privacy}", "received_events_url": "https://api.github.com/users/blaine-fs/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 750616506, "node_id": "MDU6TGFiZWw3NTA2MTY1MDY=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:lite", "name": "comp:lite", "color": "0052cc", "default": false, "description": "TF Lite related issues" }, { "id": 1661751498, "node_id": "MDU6TGFiZWwxNjYxNzUxNDk4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TFLiteConverter", "name": "TFLiteConverter", "color": "bfdadc", "default": false, "description": "For issues related to TFLite converter" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "arfaian", "id": 1106365, "node_id": "MDQ6VXNlcjExMDYzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1106365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arfaian", "html_url": "https://github.com/arfaian", "followers_url": "https://api.github.com/users/arfaian/followers", "following_url": "https://api.github.com/users/arfaian/following{/other_user}", "gists_url": "https://api.github.com/users/arfaian/gists{/gist_id}", "starred_url": "https://api.github.com/users/arfaian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arfaian/subscriptions", "organizations_url": "https://api.github.com/users/arfaian/orgs", "repos_url": "https://api.github.com/users/arfaian/repos", "events_url": "https://api.github.com/users/arfaian/events{/privacy}", "received_events_url": "https://api.github.com/users/arfaian/received_events", "type": "User", "site_admin": false }
[ { "login": "arfaian", "id": 1106365, "node_id": "MDQ6VXNlcjExMDYzNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/1106365?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arfaian", "html_url": "https://github.com/arfaian", "followers_url": "https://api.github.com/users/arfaian/followers", "following_url": "https://api.github.com/users/arfaian/following{/other_user}", "gists_url": "https://api.github.com/users/arfaian/gists{/gist_id}", "starred_url": "https://api.github.com/users/arfaian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arfaian/subscriptions", "organizations_url": "https://api.github.com/users/arfaian/orgs", "repos_url": "https://api.github.com/users/arfaian/repos", "events_url": "https://api.github.com/users/arfaian/events{/privacy}", "received_events_url": "https://api.github.com/users/arfaian/received_events", "type": "User", "site_admin": false }, { "login": "sachinprasadhs", "id": 73069040, "node_id": "MDQ6VXNlcjczMDY5MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/73069040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sachinprasadhs", "html_url": "https://github.com/sachinprasadhs", "followers_url": "https://api.github.com/users/sachinprasadhs/followers", "following_url": "https://api.github.com/users/sachinprasadhs/following{/other_user}", "gists_url": "https://api.github.com/users/sachinprasadhs/gists{/gist_id}", "starred_url": "https://api.github.com/users/sachinprasadhs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sachinprasadhs/subscriptions", "organizations_url": "https://api.github.com/users/sachinprasadhs/orgs", "repos_url": "https://api.github.com/users/sachinprasadhs/repos", "events_url": "https://api.github.com/users/sachinprasadhs/events{/privacy}", "received_events_url": "https://api.github.com/users/sachinprasadhs/received_events", "type": "User", "site_admin": false } ]
null
[ "This feature would for sure be greatly appreciated", "@blaine-fs Thanks for reporting the issue.\r\n\r\nI was able to reproduce this issue in TF 2.11 and TF Nightly 2.13.0-dev20230208 as well. Please find the gist [here](https://colab.research.google.com/gist/pjpratik/e5adb100f2d167e3eacd07aacf743512/59626.ipynb#scrollTo=L7bc0aqcGZCX). \r\n\r\nA similar issue can be found in [#55267](https://github.com/tensorflow/tensorflow/issues/55267).\r\n\r\n@sachinprasadhs Can you please look into this. Thank you.", "Hi folks, this is an important issue for one the MLPerf working groups. If y'all could please resolve it would be very much appreciated. Feel free to ping me at petermattson@ if you need more background. Many thanks! :-)", "We ran into this as well. Intuitively, it looks like audio generation in general will run into perceptual issues at 8 bits.", "@sachinprasadhs @pjpratik do you have any updates on this? Is it on the roadmap for TFLite?", "Just wanted to gently nudge @arfaian as well. I just noticed this ticket was reassigned.", "Just wanted to update everyone on this. I was able to compile the example after merging this [PR](https://github.com/tucan9389/tensorflow/pull/1) from @tucan9389. This is a huge help to both the MLPerf tiny committee as well as a number of HW startups' internal efforts. Is there anything we can do to help get this merged into master, even if it's just an experimental flag?", "Hi all, I wanted to share a further update on the usefulness of 16x8 mode. \r\n\r\nHere are some results experimenting with an LSTM-based keyword spotting model in both 8x8 and 16x8 precision, compared to the Keras floating point baseline. As you can see, 8x8 mode suffers considerable accuracy degradation, while 16x8 yields results very close to the baseline. 16x8 quantization was achieved using the above PR.\r\n\r\n![image](https://user-images.githubusercontent.com/110433039/230952662-798049ca-a162-4f4f-9a48-2355160bcbfa.png)\r\n\r\n\r\nTerminology: F1 is the usual classification accuracy metric. FPR = \"false positive rate\", FNR = \"false negative rate\", FA/hr = \"false acceptance / hour\", a metric used for keyword spotting.\r\n\r\nIn my mind, this is strong evidence that 16x8 mode is necessary to recover full accuracy for some models.", "Hello. I have also built tensorflow using the lite/16x8-mlir-quantizer-base branch. However, I am still getting an issue about the unsupported inference_output_type as seen in the picture\r\n![tflite_lstm](https://user-images.githubusercontent.com/23378874/234510063-4d3720a1-f65b-4981-b63d-10a5b06cb2e0.PNG)\r\n\r\nOn the other side. If I change the input and output types to tf.int8, I get the error that \r\nValueError: The inference_input_type and inference_output_type must be in ['tf.float32', 'tf.int16'].\r\n\r\nThe lite.py and convert.py files in the tensorflow/lite/python path, are identical with the PR\r\n\r\nAny help would be appreciated!\r\n", "@anasvaf have you tried using `tf.int16` for both the input and output dtype?", "@pjpratik I am pleased to report that this issue seems to be fixed in TF 2.13! At least, I was able to get it to work so long as the RNNs use `unroll=True`. ", "@blaine-fs , Good to know that your issue is resolved, could you please spare some time to close this issue as well. Thank you!", "Closing due to feature added in TF 2.13", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59626\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59626\">No</a>\n" ]
2023-02-09T03:09:31
2023-09-12T10:17:03
2023-09-12T10:17:00
NONE
null
null
null
Hi, the [MLPerf Tiny](https://mlcommons.org/en/news/mlperf-tiny-v05/) working group would like to implement a streaming LSTM benchmark for audio speech enhancement, based on this [paper](https://arxiv.org/abs/2005.11138). Since audio playback typically uses 16 bits per sample, it seems like any ML model synthesizing audio will need to use 16-bit activations. However, TFLite does not seem to support 16x8 quantization for LSTMs. Please see the colab below which shows a streaming LSTM model successfully converting to TFLite in 8x8 mode, but not in 16x8 mode. Is there any way to work around this problem and get 16-bit activations out of an LSTM? This would be hugely impactful for the embedded audio community. ### 1. System information - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 22.04 - TensorFlow installation (pip package or built from source): `pip install tensorflow-cpu` - TensorFlow library (version, if pip package or github SHA, if built from source): 2.11.0 ### 2. Code https://colab.research.google.com/drive/1mQq7yqqwH6HjgOTSxTU0I_SMA1XIZ2XM?usp=sharing ### 3. Failure after conversion > RuntimeError: Max and min for dynamic tensors should be recorded during calibration: Failed for tensor arg1 > Empty min/max for tensor arg1
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59626/reactions", "total_count": 6, "+1": 6, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59626/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59625
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59625/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59625/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59625/events
https://github.com/tensorflow/tensorflow/pull/59625
1,577,150,811
PR_kwDOArmXAs5JlGHU
59,625
Clean up in tpu kernels
{ "login": "joesho112358", "id": 8650931, "node_id": "MDQ6VXNlcjg2NTA5MzE=", "avatar_url": "https://avatars.githubusercontent.com/u/8650931?v=4", "gravatar_id": "", "url": "https://api.github.com/users/joesho112358", "html_url": "https://github.com/joesho112358", "followers_url": "https://api.github.com/users/joesho112358/followers", "following_url": "https://api.github.com/users/joesho112358/following{/other_user}", "gists_url": "https://api.github.com/users/joesho112358/gists{/gist_id}", "starred_url": "https://api.github.com/users/joesho112358/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joesho112358/subscriptions", "organizations_url": "https://api.github.com/users/joesho112358/orgs", "repos_url": "https://api.github.com/users/joesho112358/repos", "events_url": "https://api.github.com/users/joesho112358/events{/privacy}", "received_events_url": "https://api.github.com/users/joesho112358/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" }, { "id": 1478826728, "node_id": "MDU6TGFiZWwxNDc4ODI2NzI4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:core", "name": "comp:core", "color": "024391", "default": false, "description": "issues related to core part of tensorflow" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[]
2023-02-09T03:03:47
2023-02-13T20:26:05
2023-02-13T20:26:05
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59625", "html_url": "https://github.com/tensorflow/tensorflow/pull/59625", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59625.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59625.patch", "merged_at": "2023-02-13T20:26:05" }
One lined some control statements and tried to reduce some logic and brackets/indentation to help readability
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59625/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59625/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59624
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59624/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59624/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59624/events
https://github.com/tensorflow/tensorflow/issues/59624
1,577,092,832
I_kwDOArmXAs5eAIbg
59,624
tf.math.digamma fails when receiving a bfloat16 input
{ "login": "mazeltovlee", "id": 91937711, "node_id": "U_kgDOBXrbrw", "avatar_url": "https://avatars.githubusercontent.com/u/91937711?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mazeltovlee", "html_url": "https://github.com/mazeltovlee", "followers_url": "https://api.github.com/users/mazeltovlee/followers", "following_url": "https://api.github.com/users/mazeltovlee/following{/other_user}", "gists_url": "https://api.github.com/users/mazeltovlee/gists{/gist_id}", "starred_url": "https://api.github.com/users/mazeltovlee/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mazeltovlee/subscriptions", "organizations_url": "https://api.github.com/users/mazeltovlee/orgs", "repos_url": "https://api.github.com/users/mazeltovlee/repos", "events_url": "https://api.github.com/users/mazeltovlee/events{/privacy}", "received_events_url": "https://api.github.com/users/mazeltovlee/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097545817, "node_id": "MDU6TGFiZWwxMDk3NTQ1ODE3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:apis", "name": "comp:apis", "color": "0052cc", "default": false, "description": "Highlevel API related issues" }, { "id": 1097547147, "node_id": "MDU6TGFiZWwxMDk3NTQ3MTQ3", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:ops", "name": "comp:ops", "color": "0052cc", "default": false, "description": "OPs related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false }
[ { "login": "gaikwadrahul8", "id": 115997457, "node_id": "U_kgDOBun7EQ", "avatar_url": "https://avatars.githubusercontent.com/u/115997457?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaikwadrahul8", "html_url": "https://github.com/gaikwadrahul8", "followers_url": "https://api.github.com/users/gaikwadrahul8/followers", "following_url": "https://api.github.com/users/gaikwadrahul8/following{/other_user}", "gists_url": "https://api.github.com/users/gaikwadrahul8/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaikwadrahul8/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaikwadrahul8/subscriptions", "organizations_url": "https://api.github.com/users/gaikwadrahul8/orgs", "repos_url": "https://api.github.com/users/gaikwadrahul8/repos", "events_url": "https://api.github.com/users/gaikwadrahul8/events{/privacy}", "received_events_url": "https://api.github.com/users/gaikwadrahul8/received_events", "type": "User", "site_admin": false } ]
null
[ "Hi, @mazeltovlee \r\n\r\nI was able to replicate the issue with latest stable `Tensorflow version 2.11` and also with `tf-nightly-2.13.0-dev20230208` and I'm also getting same error which you mentioned in above error log output and for your reference I have added [gist file-tf-2.11 ](https://colab.research.google.com/gist/gaikwadrahul8/39c2058136176a226b5330ff5b04dcd4/-59624-tf-2-11.ipynb)and [gist-file-tf-nightly](https://colab.research.google.com/gist/gaikwadrahul8/aae6b8b60cc0d209ed3daaadc40d74b2/-59624-tf-nightly.ipynb)\r\n\r\nAs per the `tf.math.digamma()` documentation below it should accept `bfloat16` so it seems like we have to dig more into this issue and we'll update soon here and thank you for noticing the issue with `bfloat16` datatype. Thank you!\r\n\r\n```\r\nComputes Psi, the derivative of Lgamma (the log of the absolute value of\r\n\r\nGamma(x)), element-wise.\r\n\r\nArgs:\r\n x: A Tensor. Must be one of the following types: bfloat16, half, float32, float64.\r\n name: A name for the operation (optional).\r\n\r\nReturns:\r\n A Tensor. Has the same type as x.\r\n```", "Thanks for your investigation, please let me know if there is something I can do.", "Hi, @mazeltovlee \r\n\r\nI have executed the same code on `TPU` with `bfloat16` datatype and it seems like it's working as expected and you'll have to use `bfloat16` datatype with `TPU` and it should work so for your reference I have added [gist file ](https://colab.research.google.com/gist/gaikwadrahul8/3df17e2e894684995cd6c57532c38689/-59624.ipynb) and you can try on Google Colab with TPU runtime type.\r\n\r\nIf issue still persists please let us know or Could you please confirm if this issue is resolved for you ? Please feel free to close the issue if it is resolved ? Thank you!", "Hi, @gaikwadrahul8 \r\nThanks for your reply. Since `bfloat16` works fine for the TPU computation and `bfloat16` is not expected to run on other platforms. I will close this issue.", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59624\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59624\">No</a>\n", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59624\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59624\">No</a>\n" ]
2023-02-09T02:03:24
2023-02-15T07:31:10
2023-02-15T07:31:07
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source source ### Tensorflow Version 2.11.0 ### Custom Code Yes ### OS Platform and Distribution _No response_ ### Mobile device _No response_ ### Python version 3.8 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell This issue is similar to my previous one: https://github.com/tensorflow/tensorflow/issues/59611. Following the documentation: https://www.tensorflow.org/api_docs/python/tf/math/digamma, tf.math.digamma should accept the bfloat16 input but it fails. BTW the sentence in the documentation online "Computes Psi, the derivative of Lgamma (the log of the absolute value of" seems incomplete ``` ### Standalone code to reproduce the issue ```shell import tensorflow as tf tf.math.digamma(tf.Variable(0., dtype="bfloat16")) ``` ### Relevant log output ```shell tensorflow.python.framework.errors_impl.NotFoundError: Could not find device for node: {{node Digamma}} = Digamma[T=DT_BFLOAT16] All kernels registered for op Digamma: device='XLA_CPU_JIT'; T in [DT_FLOAT, DT_DOUBLE, DT_BFLOAT16, DT_HALF] device='XLA_GPU_JIT'; T in [DT_FLOAT, DT_DOUBLE, DT_BFLOAT16, DT_HALF] device='GPU'; T in [DT_DOUBLE] device='GPU'; T in [DT_FLOAT] device='GPU'; T in [DT_HALF] device='CPU'; T in [DT_DOUBLE] device='CPU'; T in [DT_HALF] device='CPU'; T in [DT_FLOAT] [Op:Digamma] ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59624/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59624/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59623
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59623/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59623/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59623/events
https://github.com/tensorflow/tensorflow/issues/59623
1,577,082,245
I_kwDOArmXAs5eAF2F
59,623
[tensorflow_datasets 4.8.2]: Connection refused when trying to load huggingface datasets
{ "login": "YuliyaPylypiv", "id": 22336454, "node_id": "MDQ6VXNlcjIyMzM2NDU0", "avatar_url": "https://avatars.githubusercontent.com/u/22336454?v=4", "gravatar_id": "", "url": "https://api.github.com/users/YuliyaPylypiv", "html_url": "https://github.com/YuliyaPylypiv", "followers_url": "https://api.github.com/users/YuliyaPylypiv/followers", "following_url": "https://api.github.com/users/YuliyaPylypiv/following{/other_user}", "gists_url": "https://api.github.com/users/YuliyaPylypiv/gists{/gist_id}", "starred_url": "https://api.github.com/users/YuliyaPylypiv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/YuliyaPylypiv/subscriptions", "organizations_url": "https://api.github.com/users/YuliyaPylypiv/orgs", "repos_url": "https://api.github.com/users/YuliyaPylypiv/repos", "events_url": "https://api.github.com/users/YuliyaPylypiv/events{/privacy}", "received_events_url": "https://api.github.com/users/YuliyaPylypiv/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1114343535, "node_id": "MDU6TGFiZWwxMTE0MzQzNTM1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:data", "name": "comp:data", "color": "0052cc", "default": false, "description": "tf.data related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false }
[ { "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false } ]
null
[ "After a while it loaded. Should it take so long?\r\n\r\nW tensorflow/core/platform/cloud/google_auth_provider.cc:184] All attempts to get a Google authentication bearer token failed, returning an empty token. Retrieving token from files failed with \"NOT_FOUND: Could not locate the credentials file.\". Retrieving token from GCE failed with \"ABORTED: All 10 retry attempts failed. The last failure: Error executing an HTTP request: libcurl code 42 meaning 'Operation was aborted by an application callback', error details: Callback aborted\".\r\nDownloading and preparing dataset 1.43 MiB (download: 1.43 MiB, generated: Unknown size, total: 1.43 MiB) to /Users/x/tensorflow_datasets/glue/mrpc/1.0.0...\r\nDownloading and preparing dataset glue/mrpc to /Users/x/.cache/huggingface/datasets/glue/mrpc/1.0.0/dacbe3125aa31d7f70367a07a8a9e72a5a0bfeb5fc42e75c9db75b96da6053ad...\r\nDownloading data: 6.22kB [00:00, 3.34MB/s] | 0/3 [00:00<?, ?it/s]\r\nDownloading data: 1.05MB [00:00, 8.07MB/s]████████████████████████████████ | 1/3 [00:00<00:01, 1.73it/s]\r\nDownloading data: 441kB [00:00, 4.40MB/s]██████████████████████████████████████████████████████████████████████████████ | 2/3 [00:01<00:00, 1.83it/s]\r\nDownloading data files: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:01<00:00, 1.84it/s]\r\nDataset glue downloaded and prepared to /Users/x/.cache/huggingface/datasets/glue/mrpc/1.0.0/dacbe3125aa31d7f70367a07a8a9e72a5a0bfeb5fc42e75c9db75b96da6053ad. Subsequent calls will reuse this data.\r\n100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 322.06it/s]\r\nDataset glue downloaded and prepared to /Users/x/tensorflow_datasets/glue/mrpc/1.0.0. Subsequent calls will reuse this data. \r\n2023-02-08 17:50:58.416766: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations: AVX2 FMA\r\nTo enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.\r\nMetal device set to: AMD Radeon Pro 5500M\r\n\r\nsystemMemory: 32.00 GB\r\nmaxCacheSize: 3.99 GB\r\n\r\n2023-02-08 17:50:58.417866: I tensorflow/core/common_runtime/pluggable_device/pluggable_device_factory.cc:306] Could not identify NUMA node of platform GPU ID 0, defaulting to 0. Your kernel may not have been built with NUMA support.\r\n2023-02-08 17:50:58.417928: I tensorflow/core/common_runtime/pluggable_device/pluggable_device_factory.cc:272] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 0 MB memory) -> physical PluggableDevice (device: 0, name: METAL, pci bus id: <undefined>)", "@YuliyaPylypiv \r\nI was able to load the `glue/mrpc` dataset without any error on Colab using TF v2.11. Could you please find the gist [here](https://colab.research.google.com/gist/tiruk007/07488087d9893ce6193a796829f2295d/59623.ipynb) for reference.\r\n\r\nThank you!", "Thank you @tiruk007 for your response! Looks like it's working again for me! ", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59623\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59623\">No</a>\n" ]
2023-02-09T01:50:08
2023-02-10T00:12:48
2023-02-10T00:12:44
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.11.0 ### Custom Code No ### OS Platform and Distribution macOS ### Mobile device _No response_ ### Python version 3.8, 3.9, 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell Cannot load huggingface datasets Used to work fine on 02/01/2023 ``` ### Standalone code to reproduce the issue ```shell import tensorflow_datasets data = tensorflow_datasets.load('glue/mrpc') ``` ### Relevant log output ```shell 2023-02-08 17:46:43.871073: E tensorflow/core/platform/cloud/curl_http_request.cc:614] The transmission of request 0x7fb417f4b9a0 (URI: http://metadata/computeMetadata/v1/instance/service-accounts/default/token) has been stuck at 0 of 0 bytes for 61 seconds and will be aborted. CURL timing information: lookup time: 0.003921 (No error), connect time: 0 (No error), pre-transfer time: 0 (No error), start-transfer time: 0 (No error) ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59623/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59623/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59622
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59622/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59622/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59622/events
https://github.com/tensorflow/tensorflow/issues/59622
1,577,061,179
I_kwDOArmXAs5eAAs7
59,622
[tensorflow_datasets 3.1.0]: ValueError(_NAME_STR_ERR.format(name_str)) when loading huggingface dataset
{ "login": "YuliyaPylypiv", "id": 22336454, "node_id": "MDQ6VXNlcjIyMzM2NDU0", "avatar_url": "https://avatars.githubusercontent.com/u/22336454?v=4", "gravatar_id": "", "url": "https://api.github.com/users/YuliyaPylypiv", "html_url": "https://github.com/YuliyaPylypiv", "followers_url": "https://api.github.com/users/YuliyaPylypiv/followers", "following_url": "https://api.github.com/users/YuliyaPylypiv/following{/other_user}", "gists_url": "https://api.github.com/users/YuliyaPylypiv/gists{/gist_id}", "starred_url": "https://api.github.com/users/YuliyaPylypiv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/YuliyaPylypiv/subscriptions", "organizations_url": "https://api.github.com/users/YuliyaPylypiv/orgs", "repos_url": "https://api.github.com/users/YuliyaPylypiv/repos", "events_url": "https://api.github.com/users/YuliyaPylypiv/events{/privacy}", "received_events_url": "https://api.github.com/users/YuliyaPylypiv/received_events", "type": "User", "site_admin": false }
[ { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1114343535, "node_id": "MDU6TGFiZWwxMTE0MzQzNTM1", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:data", "name": "comp:data", "color": "0052cc", "default": false, "description": "tf.data related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false }
[ { "login": "synandi", "id": 98147397, "node_id": "U_kgDOBdmcRQ", "avatar_url": "https://avatars.githubusercontent.com/u/98147397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/synandi", "html_url": "https://github.com/synandi", "followers_url": "https://api.github.com/users/synandi/followers", "following_url": "https://api.github.com/users/synandi/following{/other_user}", "gists_url": "https://api.github.com/users/synandi/gists{/gist_id}", "starred_url": "https://api.github.com/users/synandi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/synandi/subscriptions", "organizations_url": "https://api.github.com/users/synandi/orgs", "repos_url": "https://api.github.com/users/synandi/repos", "events_url": "https://api.github.com/users/synandi/events{/privacy}", "received_events_url": "https://api.github.com/users/synandi/received_events", "type": "User", "site_admin": false } ]
null
[ "Closing, tensorflow_datasets 3.1.0 is too old", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59622\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59622\">No</a>\n" ]
2023-02-09T01:23:09
2023-02-10T05:35:22
2023-02-09T01:35:49
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? Yes ### Source binary ### Tensorflow Version 2.11.0 ### Custom Code No ### OS Platform and Distribution macOS ### Mobile device _No response_ ### Python version 3.8, 3.9, 3.10 ### Bazel version _No response_ ### GCC/Compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current Behaviour? ```shell ValueError(_NAME_STR_ERR.format(name_str)) when loading huggingface dataset via tensorflow_datasets.load() ``` ### Standalone code to reproduce the issue ```shell import tensorflow_datasets data = tensorflow_datasets.load('huggingface:glue/mrpc') ``` ### Relevant log output ```shell pip show tensorflow_datasets Name: tensorflow-datasets Version: 3.1.0 Summary: tensorflow/datasets is a library of datasets ready to use with TensorFlow. Home-page: https://github.com/tensorflow/datasets Author: Google Inc. Author-email: [email protected] License: Apache 2.0 Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/local/conda/envs/tf_base/lib/python3.8/site-packages/tensorflow_datasets/core/api_utils.py", line 69, in disallow_positional_args_dec return fn(*args, **kwargs) File "/Users/local/conda/envs/tf_base/lib/python3.8/site-packages/tensorflow_datasets/core/registered.py", line 356, in load name, name_builder_kwargs = _dataset_name_and_kwargs_from_name_str(name) File "/Users/local/conda/envs/tf_base/lib/python3.8/site-packages/tensorflow_datasets/core/registered.py", line 391, in _dataset_name_and_kwargs_from_name_str raise ValueError(_NAME_STR_ERR.format(name_str)) ValueError: Parsing builder name string huggingface:glue/mrpc failed. The builder name string must be of the following format: dataset_name[/config_name][:version][/kwargs] Where: * dataset_name and config_name are string following python variable naming. * version is of the form x.y.z where {x,y,z} can be any digit or *. * kwargs is a comma list separated of arguments and values to pass to builder. Examples: my_dataset my_dataset:1.2.* my_dataset/config1 my_dataset/config1:1.*.* my_dataset/config1/arg1=val1,arg2=val2 my_dataset/config1:1.2.3/right=True,foo=bar,rate=1.2 ``` </details>
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59622/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59622/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59621
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59621/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59621/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59621/events
https://github.com/tensorflow/tensorflow/pull/59621
1,577,031,073
PR_kwDOArmXAs5Jks-d
59,621
Revert "Disable broken test in TF 2.12.0 Release builds."
{ "login": "mihaimaruseac", "id": 323199, "node_id": "MDQ6VXNlcjMyMzE5OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/323199?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mihaimaruseac", "html_url": "https://github.com/mihaimaruseac", "followers_url": "https://api.github.com/users/mihaimaruseac/followers", "following_url": "https://api.github.com/users/mihaimaruseac/following{/other_user}", "gists_url": "https://api.github.com/users/mihaimaruseac/gists{/gist_id}", "starred_url": "https://api.github.com/users/mihaimaruseac/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mihaimaruseac/subscriptions", "organizations_url": "https://api.github.com/users/mihaimaruseac/orgs", "repos_url": "https://api.github.com/users/mihaimaruseac/repos", "events_url": "https://api.github.com/users/mihaimaruseac/events{/privacy}", "received_events_url": "https://api.github.com/users/mihaimaruseac/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-02-09T00:52:50
2023-02-09T23:56:21
2023-02-09T04:37:41
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59621", "html_url": "https://github.com/tensorflow/tensorflow/pull/59621", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59621.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59621.patch", "merged_at": "2023-02-09T04:37:41" }
Reverts tensorflow/tensorflow#59596
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59621/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59621/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59620
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59620/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59620/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59620/events
https://github.com/tensorflow/tensorflow/issues/59620
1,577,017,112
I_kwDOArmXAs5d_18Y
59,620
AttributeError: 'list' object has no attribute 'numpy'
{ "login": "AAnirudh07", "id": 86918353, "node_id": "MDQ6VXNlcjg2OTE4MzUz", "avatar_url": "https://avatars.githubusercontent.com/u/86918353?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AAnirudh07", "html_url": "https://github.com/AAnirudh07", "followers_url": "https://api.github.com/users/AAnirudh07/followers", "following_url": "https://api.github.com/users/AAnirudh07/following{/other_user}", "gists_url": "https://api.github.com/users/AAnirudh07/gists{/gist_id}", "starred_url": "https://api.github.com/users/AAnirudh07/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AAnirudh07/subscriptions", "organizations_url": "https://api.github.com/users/AAnirudh07/orgs", "repos_url": "https://api.github.com/users/AAnirudh07/repos", "events_url": "https://api.github.com/users/AAnirudh07/events{/privacy}", "received_events_url": "https://api.github.com/users/AAnirudh07/received_events", "type": "User", "site_admin": false }
[ { "id": 386191887, "node_id": "MDU6TGFiZWwzODYxOTE4ODc=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stat:awaiting%20response", "name": "stat:awaiting response", "color": "f4b400", "default": false, "description": "Status - Awaiting response from author" }, { "id": 473172988, "node_id": "MDU6TGFiZWw0NzMxNzI5ODg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/type:bug", "name": "type:bug", "color": "159b2e", "default": false, "description": "Bug" }, { "id": 1097546578, "node_id": "MDU6TGFiZWwxMDk3NTQ2NTc4", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:keras", "name": "comp:keras", "color": "0052cc", "default": false, "description": "Keras related issues" }, { "id": 4829271983, "node_id": "LA_kwDOArmXAs8AAAABH9jXrw", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/TF%202.11", "name": "TF 2.11", "color": "46B4D7", "default": false, "description": "Issues related to TF 2.11" } ]
closed
false
{ "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false }
[ { "login": "pjpratik", "id": 118897289, "node_id": "U_kgDOBxY6iQ", "avatar_url": "https://avatars.githubusercontent.com/u/118897289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pjpratik", "html_url": "https://github.com/pjpratik", "followers_url": "https://api.github.com/users/pjpratik/followers", "following_url": "https://api.github.com/users/pjpratik/following{/other_user}", "gists_url": "https://api.github.com/users/pjpratik/gists{/gist_id}", "starred_url": "https://api.github.com/users/pjpratik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pjpratik/subscriptions", "organizations_url": "https://api.github.com/users/pjpratik/orgs", "repos_url": "https://api.github.com/users/pjpratik/repos", "events_url": "https://api.github.com/users/pjpratik/events{/privacy}", "received_events_url": "https://api.github.com/users/pjpratik/received_events", "type": "User", "site_admin": false } ]
null
[ "@AAnirudh07 The `layer_weights` contains list of variable tensors. The list can be iterated and each tensor can be then converted with `.numpy()` method:\r\n```\r\nfor weightTensors in layer_weights:\r\n weights.append(weightTensors.numpy()) \r\n```\r\n\r\nPlease refer the working gist [here](https://colab.research.google.com/gist/pjpratik/858d9aaadd77e33fa53eb1da4d2fee30/59620.ipynb) and let us know if it helps. Thanks!\r\n\r\n", "Woah this is awesome! Thanks a lot @pjpratik!\r\n\r\nI have one final question - Is there any particular reason why list iteration works but list indexing doesn't? List indexing thows an `IndexError: list index out of range` error.\r\n\r\nThanks!", "@AAnirudh07 I can see your first layer returns empty list as it does not contain any weights, that's why you were getting `IndexError: list index out of range` error. \r\n\r\nI was able to index the second layer list with out any error.\r\n\r\nPlease refer the gist [here](https://colab.research.google.com/gist/pjpratik/b33618073ea0dbabe630cc268a68fee0/59620.ipynb) and let us know if it helps. Feel free to close the issue if it is resolved. Thanks!", "Ah right my bad.\r\n\r\nThanks for all the help!", "Are you satisfied with the resolution of your issue?\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=Yes&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59620\">Yes</a>\n<a href=\"https://docs.google.com/forms/d/e/1FAIpQLSfaP12TRhd9xSxjXZjcZFNXPGk4kc1-qMdv3gc6bEP90vY1ew/viewform?entry.85265664=No&entry.2137816233=https://github.com/tensorflow/tensorflow/issues/59620\">No</a>\n" ]
2023-02-09T00:38:20
2023-02-09T14:27:33
2023-02-09T14:27:29
NONE
null
null
null
<details><summary>Click to expand!</summary> ### Issue Type Bug ### Have you reproduced the bug with TF nightly? No ### Source source ### Tensorflow Version tf 2.11.0 ### Custom Code No ### OS Platform and Distribution Windows 11 ### Python version 3.10.9 ### Current Behaviour? Hello! I'm trying to write a script that gets the weights (just the weights) of each layer of a keras model. I am aware of the `get_weights()` method, but I don't want to use it since it returns specific terms such as bias with the weights, so I can't tell which is which. I used `model.get_layer(layer.name).weights` to extract the weights of a particular layer. The layer weights are returned as a TensorFlow variable. Here's an example: ```shell [<tf.Variable 'dense_2/kernel:0' shape=(256, 10) dtype=float32, numpy= array([[-0.08837277, -0.03666556, -0.00683133, ..., 0.09055033, 0.13219357, 0.0625298 ], [-0.00596744, -0.10817644, -0.08093027, ..., -0.03245946, -0.1296913 , 0.14863956], [-0.10632615, -0.14407103, -0.09643614, ..., 0.1368066 , 0.09166756, 0.12455937], ..., [ 0.1320965 , -0.14804208, -0.11622404, ..., 0.14576206, 0.02600923, 0.10927373], [ 0.05249688, -0.00176807, -0.06608753, ..., -0.09677176, 0.1066353 , -0.11133642], [-0.07169801, -0.05865452, 0.11303747, ..., 0.11609155, 0.03141506, 0.00285086]], dtype=float32)>] ``` Despite having a `list` type, the above output cannot be indexed: Assuming the above output is referred to as `var`; `var[0]` throws an `IndexError: list index out of range` error. Whenever I try to evaluate tf.Variable with the numpy() method, the error shown in the issue title appears. Any help would be much appreciated. Thank you! ### Standalone code to reproduce the issue ```shell import tensorflow as tf def get_model(): mnist_model = tf.keras.Sequential([ tf.keras.layers.Flatten(input_shape=(28, 28)), tf.keras.layers.Dense(256, activation='relu', use_bias=False), tf.keras.layers.Dropout(0.45), tf.keras.layers.Dense(256, activation='relu', use_bias=False), tf.keras.layers.Dropout(0.45), tf.keras.layers.Dense(10, use_bias=False)]) return mnist_model def get_model_weights(model): weights = [] for index, layer in enumerate(model.layers): layer_weights = model.get_layer(layer.name).weights layer_weights.numpy() weights.append(layer_weights) return weights get_model_weights(get_model()) ```
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59620/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59620/timeline
null
completed
false
https://api.github.com/repos/tensorflow/tensorflow/issues/59619
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59619/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59619/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59619/events
https://github.com/tensorflow/tensorflow/pull/59619
1,576,905,187
PR_kwDOArmXAs5JkRVq
59,619
[NVIDIA TF] Throw error only for non-empty function definitions.
{ "login": "pavanimajety", "id": 33809857, "node_id": "MDQ6VXNlcjMzODA5ODU3", "avatar_url": "https://avatars.githubusercontent.com/u/33809857?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pavanimajety", "html_url": "https://github.com/pavanimajety", "followers_url": "https://api.github.com/users/pavanimajety/followers", "following_url": "https://api.github.com/users/pavanimajety/following{/other_user}", "gists_url": "https://api.github.com/users/pavanimajety/gists{/gist_id}", "starred_url": "https://api.github.com/users/pavanimajety/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pavanimajety/subscriptions", "organizations_url": "https://api.github.com/users/pavanimajety/orgs", "repos_url": "https://api.github.com/users/pavanimajety/repos", "events_url": "https://api.github.com/users/pavanimajety/events{/privacy}", "received_events_url": "https://api.github.com/users/pavanimajety/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "@reedwm what do you think ?", "Thanks for the PR! Quick question, \r\n> there can be Node ops with type func with default values that have no associated name.\r\n\r\nWhen does this happen?", "@k-w-w we tried to register an OP that can define or not an optional `func`.", "I see, can you add this as a comment in the code? (`# Custom ops may contain a func attr with an empty fname`) " ]
2023-02-08T22:49:52
2023-02-23T19:38:04
2023-02-23T19:37:50
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59619", "html_url": "https://github.com/tensorflow/tensorflow/pull/59619", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59619.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59619.patch", "merged_at": null }
During Function Serialization and Deserialization with Saved Models there can be Node ops with type `func` with default values that have no associated name. In such cases, we shouldn't look for undefined empty strings in Function Library. This is a trivial change and helps with how Saved Models are loaded.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59619/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59619/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59618
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59618/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59618/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59618/events
https://github.com/tensorflow/tensorflow/pull/59618
1,576,752,334
PR_kwDOArmXAs5JjwxY
59,618
Update tensorboard 2.12.0 dependency
{ "login": "vinila21", "id": 106367904, "node_id": "U_kgDOBlcLoA", "avatar_url": "https://avatars.githubusercontent.com/u/106367904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinila21", "html_url": "https://github.com/vinila21", "followers_url": "https://api.github.com/users/vinila21/followers", "following_url": "https://api.github.com/users/vinila21/following{/other_user}", "gists_url": "https://api.github.com/users/vinila21/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinila21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinila21/subscriptions", "organizations_url": "https://api.github.com/users/vinila21/orgs", "repos_url": "https://api.github.com/users/vinila21/repos", "events_url": "https://api.github.com/users/vinila21/events{/privacy}", "received_events_url": "https://api.github.com/users/vinila21/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[]
2023-02-08T20:22:27
2023-02-10T00:25:20
2023-02-09T23:40:55
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59618", "html_url": "https://github.com/tensorflow/tensorflow/pull/59618", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59618.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59618.patch", "merged_at": "2023-02-09T23:40:55" }
Re : Updating Tensorboard's protobuf Updating the TB 2.12.0 dependency in r2.12 release branch from TF side.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59618/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59618/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59617
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59617/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59617/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59617/events
https://github.com/tensorflow/tensorflow/pull/59617
1,576,737,684
PR_kwDOArmXAs5JjtmI
59,617
Update setup.py
{ "login": "tiruk007", "id": 111861663, "node_id": "U_kgDOBqrfnw", "avatar_url": "https://avatars.githubusercontent.com/u/111861663?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tiruk007", "html_url": "https://github.com/tiruk007", "followers_url": "https://api.github.com/users/tiruk007/followers", "following_url": "https://api.github.com/users/tiruk007/following{/other_user}", "gists_url": "https://api.github.com/users/tiruk007/gists{/gist_id}", "starred_url": "https://api.github.com/users/tiruk007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tiruk007/subscriptions", "organizations_url": "https://api.github.com/users/tiruk007/orgs", "repos_url": "https://api.github.com/users/tiruk007/repos", "events_url": "https://api.github.com/users/tiruk007/events{/privacy}", "received_events_url": "https://api.github.com/users/tiruk007/received_events", "type": "User", "site_admin": false }
[ { "id": 474725938, "node_id": "MDU6TGFiZWw0NzQ3MjU5Mzg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/stale", "name": "stale", "color": "d4c5f9", "default": false, "description": "This label marks the issue/pr stale - to be closed automatically if no activity" }, { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "https://cbea.ms/git-commit/", "Need to be removed from CI too. This PR is not sufficient.", "Hi @tiruk007 Can you please check @mihaimaruseac's comments. Thank you!", "This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.", "This PR was closed because it has been inactive for 14 days since being marked as stale. Please reopen if you'd like to work on this further." ]
2023-02-08T20:09:41
2023-04-19T18:40:13
2023-04-19T01:55:55
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59617", "html_url": "https://github.com/tensorflow/tensorflow/pull/59617", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59617.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59617.patch", "merged_at": null }
Fixes #59575
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59617/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59617/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59616
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59616/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59616/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59616/events
https://github.com/tensorflow/tensorflow/pull/59616
1,576,730,947
PR_kwDOArmXAs5JjsIi
59,616
ReLU Epilogue Fusion for FP8 GEMMs in XLA
{ "login": "philipphack", "id": 80296164, "node_id": "MDQ6VXNlcjgwMjk2MTY0", "avatar_url": "https://avatars.githubusercontent.com/u/80296164?v=4", "gravatar_id": "", "url": "https://api.github.com/users/philipphack", "html_url": "https://github.com/philipphack", "followers_url": "https://api.github.com/users/philipphack/followers", "following_url": "https://api.github.com/users/philipphack/following{/other_user}", "gists_url": "https://api.github.com/users/philipphack/gists{/gist_id}", "starred_url": "https://api.github.com/users/philipphack/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/philipphack/subscriptions", "organizations_url": "https://api.github.com/users/philipphack/orgs", "repos_url": "https://api.github.com/users/philipphack/repos", "events_url": "https://api.github.com/users/philipphack/events{/privacy}", "received_events_url": "https://api.github.com/users/philipphack/received_events", "type": "User", "site_admin": false }
[ { "id": 1133285679, "node_id": "MDU6TGFiZWwxMTMzMjg1Njc5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/comp:xla", "name": "comp:xla", "color": "0052cc", "default": false, "description": "XLA" }, { "id": 1169365494, "node_id": "MDU6TGFiZWwxMTY5MzY1NDk0", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:M", "name": "size:M", "color": "adafea", "default": false, "description": "CL Change Size: Medium" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "CC @reedwm." ]
2023-02-08T20:04:08
2023-02-23T19:37:56
2023-02-23T19:37:49
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59616", "html_url": "https://github.com/tensorflow/tensorflow/pull/59616", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59616.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59616.patch", "merged_at": null }
Enables the epilogue fusion of ReLU activations for FP8 GEMMs.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59616/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59616/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59615
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59615/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59615/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59615/events
https://github.com/tensorflow/tensorflow/pull/59615
1,576,720,248
PR_kwDOArmXAs5Jjp1z
59,615
Update tensorboard 2.12.0 dependency
{ "login": "vinila21", "id": 106367904, "node_id": "U_kgDOBlcLoA", "avatar_url": "https://avatars.githubusercontent.com/u/106367904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vinila21", "html_url": "https://github.com/vinila21", "followers_url": "https://api.github.com/users/vinila21/followers", "following_url": "https://api.github.com/users/vinila21/following{/other_user}", "gists_url": "https://api.github.com/users/vinila21/gists{/gist_id}", "starred_url": "https://api.github.com/users/vinila21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vinila21/subscriptions", "organizations_url": "https://api.github.com/users/vinila21/orgs", "repos_url": "https://api.github.com/users/vinila21/repos", "events_url": "https://api.github.com/users/vinila21/events{/privacy}", "received_events_url": "https://api.github.com/users/vinila21/received_events", "type": "User", "site_admin": false }
[ { "id": 1169364259, "node_id": "MDU6TGFiZWwxMTY5MzY0MjU5", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:XS", "name": "size:XS", "color": "adafea", "default": false, "description": "CL Change Size: Extra Small" } ]
closed
false
{ "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }
[ { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false } ]
null
[ "This can't be merged until we actually have published a 2.12 release of TensorBoard. We're working on it right now and it should be ready later today, but please do not merge this until we let you know it's ready." ]
2023-02-08T19:54:49
2023-02-09T22:47:43
2023-02-09T22:47:36
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59615", "html_url": "https://github.com/tensorflow/tensorflow/pull/59615", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59615.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59615.patch", "merged_at": null }
Re : Updating Tensorboard's protobuf Updating the TB 2.12.0 dependency from TF side.
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59615/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59615/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59614
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59614/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59614/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59614/events
https://github.com/tensorflow/tensorflow/pull/59614
1,576,660,843
PR_kwDOArmXAs5JjcsL
59,614
[NVIDIA XLA] Support Conv-Bias-Relu6/LeakyRelu fusion in XLA using cuDNN runtime fusion
{ "login": "Young768", "id": 7083506, "node_id": "MDQ6VXNlcjcwODM1MDY=", "avatar_url": "https://avatars.githubusercontent.com/u/7083506?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Young768", "html_url": "https://github.com/Young768", "followers_url": "https://api.github.com/users/Young768/followers", "following_url": "https://api.github.com/users/Young768/following{/other_user}", "gists_url": "https://api.github.com/users/Young768/gists{/gist_id}", "starred_url": "https://api.github.com/users/Young768/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Young768/subscriptions", "organizations_url": "https://api.github.com/users/Young768/orgs", "repos_url": "https://api.github.com/users/Young768/repos", "events_url": "https://api.github.com/users/Young768/events{/privacy}", "received_events_url": "https://api.github.com/users/Young768/received_events", "type": "User", "site_admin": false }
[ { "id": 390482148, "node_id": "MDU6TGFiZWwzOTA0ODIxNDg=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/awaiting%20review", "name": "awaiting review", "color": "bc3869", "default": false, "description": "Pull request awaiting review" }, { "id": 987666414, "node_id": "MDU6TGFiZWw5ODc2NjY0MTQ=", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull", "name": "ready to pull", "color": "2cd643", "default": false, "description": "PR ready for merge process" }, { "id": 1169365682, "node_id": "MDU6TGFiZWwxMTY5MzY1Njgy", "url": "https://api.github.com/repos/tensorflow/tensorflow/labels/size:L", "name": "size:L", "color": "adafea", "default": false, "description": "CL Change Size: Large" } ]
closed
false
{ "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }
[ { "login": "cheshire", "id": 348959, "node_id": "MDQ6VXNlcjM0ODk1OQ==", "avatar_url": "https://avatars.githubusercontent.com/u/348959?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cheshire", "html_url": "https://github.com/cheshire", "followers_url": "https://api.github.com/users/cheshire/followers", "following_url": "https://api.github.com/users/cheshire/following{/other_user}", "gists_url": "https://api.github.com/users/cheshire/gists{/gist_id}", "starred_url": "https://api.github.com/users/cheshire/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cheshire/subscriptions", "organizations_url": "https://api.github.com/users/cheshire/orgs", "repos_url": "https://api.github.com/users/cheshire/repos", "events_url": "https://api.github.com/users/cheshire/events{/privacy}", "received_events_url": "https://api.github.com/users/cheshire/received_events", "type": "User", "site_admin": false }, { "login": "reedwm", "id": 6510203, "node_id": "MDQ6VXNlcjY1MTAyMDM=", "avatar_url": "https://avatars.githubusercontent.com/u/6510203?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reedwm", "html_url": "https://github.com/reedwm", "followers_url": "https://api.github.com/users/reedwm/followers", "following_url": "https://api.github.com/users/reedwm/following{/other_user}", "gists_url": "https://api.github.com/users/reedwm/gists{/gist_id}", "starred_url": "https://api.github.com/users/reedwm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reedwm/subscriptions", "organizations_url": "https://api.github.com/users/reedwm/orgs", "repos_url": "https://api.github.com/users/reedwm/repos", "events_url": "https://api.github.com/users/reedwm/events{/privacy}", "received_events_url": "https://api.github.com/users/reedwm/received_events", "type": "User", "site_admin": false }, { "login": "chsigg", "id": 7523982, "node_id": "MDQ6VXNlcjc1MjM5ODI=", "avatar_url": "https://avatars.githubusercontent.com/u/7523982?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chsigg", "html_url": "https://github.com/chsigg", "followers_url": "https://api.github.com/users/chsigg/followers", "following_url": "https://api.github.com/users/chsigg/following{/other_user}", "gists_url": "https://api.github.com/users/chsigg/gists{/gist_id}", "starred_url": "https://api.github.com/users/chsigg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chsigg/subscriptions", "organizations_url": "https://api.github.com/users/chsigg/orgs", "repos_url": "https://api.github.com/users/chsigg/repos", "events_url": "https://api.github.com/users/chsigg/events{/privacy}", "received_events_url": "https://api.github.com/users/chsigg/received_events", "type": "User", "site_admin": false }, { "login": "gbaned", "id": 48215717, "node_id": "MDQ6VXNlcjQ4MjE1NzE3", "avatar_url": "https://avatars.githubusercontent.com/u/48215717?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gbaned", "html_url": "https://github.com/gbaned", "followers_url": "https://api.github.com/users/gbaned/followers", "following_url": "https://api.github.com/users/gbaned/following{/other_user}", "gists_url": "https://api.github.com/users/gbaned/gists{/gist_id}", "starred_url": "https://api.github.com/users/gbaned/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gbaned/subscriptions", "organizations_url": "https://api.github.com/users/gbaned/orgs", "repos_url": "https://api.github.com/users/gbaned/repos", "events_url": "https://api.github.com/users/gbaned/events{/privacy}", "received_events_url": "https://api.github.com/users/gbaned/received_events", "type": "User", "site_admin": false }, { "login": "gcforster", "id": 108087815, "node_id": "U_kgDOBnFKBw", "avatar_url": "https://avatars.githubusercontent.com/u/108087815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gcforster", "html_url": "https://github.com/gcforster", "followers_url": "https://api.github.com/users/gcforster/followers", "following_url": "https://api.github.com/users/gcforster/following{/other_user}", "gists_url": "https://api.github.com/users/gcforster/gists{/gist_id}", "starred_url": "https://api.github.com/users/gcforster/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gcforster/subscriptions", "organizations_url": "https://api.github.com/users/gcforster/orgs", "repos_url": "https://api.github.com/users/gcforster/repos", "events_url": "https://api.github.com/users/gcforster/events{/privacy}", "received_events_url": "https://api.github.com/users/gcforster/received_events", "type": "User", "site_admin": false }, { "login": "xla-rotation", "id": 116104012, "node_id": "U_kgDOBuubTA", "avatar_url": "https://avatars.githubusercontent.com/u/116104012?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xla-rotation", "html_url": "https://github.com/xla-rotation", "followers_url": "https://api.github.com/users/xla-rotation/followers", "following_url": "https://api.github.com/users/xla-rotation/following{/other_user}", "gists_url": "https://api.github.com/users/xla-rotation/gists{/gist_id}", "starred_url": "https://api.github.com/users/xla-rotation/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xla-rotation/subscriptions", "organizations_url": "https://api.github.com/users/xla-rotation/orgs", "repos_url": "https://api.github.com/users/xla-rotation/repos", "events_url": "https://api.github.com/users/xla-rotation/events{/privacy}", "received_events_url": "https://api.github.com/users/xla-rotation/received_events", "type": "User", "site_admin": false } ]
null
[ "Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\nView this [failed invocation](https://github.com/tensorflow/tensorflow/pull/59614/checks?check_run_id=11205585012) of the CLA check for more information.\n\nFor the most up to date status, view the checks section at the bottom of the pull request.", "@kaixih and @philipphack could you both do a quick review please?\r\nWe'll remove the Draft state once you take a look.", "@philipphack could you take a quick look?", "@philipphack @kaixih could you please take a look and provide feebacks?", "Hi @Young768 , can you resolve the conflict first?", "@cheshire what else I need to do on this PR? I added the fix to [outline_cuda_graphs.mlir](https://github.com/tensorflow/tensorflow/pull/59614/files#diff-45654d97055eed7c7d12154ede62d2019af46e8719ef8c2ff886755ced12c387) to fix the cudagraph test since your last approval. Could you please help trigger the tests as well?", "@cheshire could you please share the log of that internal test feedback/copybara? So I can know what failed the test.", "@Young768 A test is failing internally in `xla_aot_compile_gpu_test.cc` on [this line](https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/compiler/xla/service/xla_aot_compile_gpu_test.cc;l=238;drc=c0759632b00da7d3709e6927171342450e6fce63). This test has the [`no_oss` tag](https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/compiler/xla/service/BUILD;l=7081;drc=67380fa97b52c0ab186efdff89c6353194c142f4) which is why the GitHub CI passed.", "To pass the XLA test, you need to add the leakyrelu_alpha field to this hlo https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/compiler/xla/service/xla_aot_compile_test_autotune_results.prototxt;l=26?q=xla_aot_compile_test_&ss=tensorflow%2Ftensorflow\r\n\r\nSo that the highlighted line becomes \r\n` hlo: \"(f32[1,1,2,3]{3,2,1,0}, u8[0]{0}) custom-call(f32[2,1,4,4]{3,2,1,0}, f32[2,1,3,2]{3,2,1,0}), window={size=2x3}, dim_labels=bf01_oi01->bf01, custom_call_target=\\\"__cudnn$convBackwardFilter\\\", backend_config=\\\"{\\\\\\\"activation_mode\\\\\\\":\\\\\\\"0\\\\\\\",\\\\\\\"conv_result_scale\\\\\\\":1,\\\\\\\"side_input_scale\\\\\\\":0,\\\\\\\"leakyrelu_alpha\\\\\\\":0}\\\"\"`", "@reedwm could you help trigger the CI tests?", "This was rolled back, unfortunately.\r\n\r\n@jlebar do you know the details of what broke and if it's possible to fix and resubmit this PR in a way that will not cause breakages again?", "> @jlebar do you know the details of what broke and if it's possible to fix and resubmit this PR in a way that will not cause breakages again?\r\n\r\nMy understanding is, this PR appears to require cudnn with libnvrtc support. We do not build with libnvrtc enabled today inside Google, so this will be broken for anyone who has relu6 and runs on Ampere at Google.\r\n\r\nUntil Google supports libnvrtc, Google will need to disable the generation of convs that use libnvrtc.\r\n\r\nI believe @Artem-B is working on enabling libnvrtc at Google because his understanding is it's required for cudnn 8.8.", "@reedwm @jlebar I think nvrtc is built inside cudnn since cudnn 8? Since another merged [PR](https://github.com/tensorflow/tensorflow/pull/57794) has already used the runtime engine.", "The change enabling libnvrtc should land next week.\r\n\r\nI may be completely off base here as I'm not very familiar with the specifics of interaction between XLA, cuDNN, cudnn_frontend and libnvrtc, but the \"appears to require cudnn with libnvrtc support\" part strikes me as odd.\r\n\r\nLibnvrtc availability appears to be an optional feature. TensorRT and cuDNN have been working fine for us without it, even if they may leave some performance on the table. I would assume that any functionality in XLA also should not have the hard dependency on libnvrtc availability either. If the change does depend on libnvrtc, is it possible to query if the required functionality is available and fall back on something less fancy if it is not? What am I missing?\r\n\r\n", "> I think nvrtc is built inside cudnn since cudnn 8?\r\n\r\nThat's certainly not the case for the static variant of cuDNN library. Versions up to 8.7 `dlopen()` libnvrtc at runtime. I believe v8.8 has started to link with libnvrtc statically which is what got me to finally get it working in our internal build.\r\n", "@Young768, libnvrtc is now supported in Google according to @jlebar, so we can take this change now.\r\n\r\nSince this PR was already merged (and then rolled back), can you create a new PR with this change?", "@reedwm I *think* we can take this change, but please double-check that this is correct! :)", "Good point, once @Young768 creates the PR, I'll manually import it and run the tests that were previously broken before submitting.\r\n\r\n@Young768 please CC me on the new PR :)" ]
2023-02-08T19:14:48
2023-04-19T18:29:42
2023-04-07T18:41:49
CONTRIBUTOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59614", "html_url": "https://github.com/tensorflow/tensorflow/pull/59614", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59614.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59614.patch", "merged_at": "2023-04-07T18:41:49" }
This PR enables the Conv-Bias-Relu6/LeakyRelu fusion in XLA, which can take advantage of the cuDNN runtime compiled fusion kernels. A quick benchmark measured that this can bring 6~7% performance improvement. @kaixih @pjannaty @nluehr
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59614/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59614/timeline
null
null
true
https://api.github.com/repos/tensorflow/tensorflow/issues/59613
https://api.github.com/repos/tensorflow/tensorflow
https://api.github.com/repos/tensorflow/tensorflow/issues/59613/labels{/name}
https://api.github.com/repos/tensorflow/tensorflow/issues/59613/comments
https://api.github.com/repos/tensorflow/tensorflow/issues/59613/events
https://github.com/tensorflow/tensorflow/pull/59613
1,576,628,642
PR_kwDOArmXAs5JjVu1
59,613
r2.12 cherry-pick: 46cdedf47c1 "Include TSL proto files in the pip package"
{ "login": "tensorflow-jenkins", "id": 16359713, "node_id": "MDQ6VXNlcjE2MzU5NzEz", "avatar_url": "https://avatars.githubusercontent.com/u/16359713?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tensorflow-jenkins", "html_url": "https://github.com/tensorflow-jenkins", "followers_url": "https://api.github.com/users/tensorflow-jenkins/followers", "following_url": "https://api.github.com/users/tensorflow-jenkins/following{/other_user}", "gists_url": "https://api.github.com/users/tensorflow-jenkins/gists{/gist_id}", "starred_url": "https://api.github.com/users/tensorflow-jenkins/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tensorflow-jenkins/subscriptions", "organizations_url": "https://api.github.com/users/tensorflow-jenkins/orgs", "repos_url": "https://api.github.com/users/tensorflow-jenkins/repos", "events_url": "https://api.github.com/users/tensorflow-jenkins/events{/privacy}", "received_events_url": "https://api.github.com/users/tensorflow-jenkins/received_events", "type": "User", "site_admin": false }
[]
closed
false
null
[]
null
[ "This cherry-pick resolves https://github.com/tensorflow/tensorflow/issues/59514: TF 2.12 is missing TF Core .proto files that were moved to TSL in between 2.11 and 2.12. Without these files, external plugins such as the DirectML plugin cannot be compiled, which is a pretty notable regression.\r\n\r\nThere are no side effects to this change except that missing static .proto files are once again included inside the TF Python wheel. They do not change any behavior as far as I know." ]
2023-02-08T18:50:05
2023-02-14T00:52:14
2023-02-14T00:49:27
COLLABORATOR
null
false
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/pulls/59613", "html_url": "https://github.com/tensorflow/tensorflow/pull/59613", "diff_url": "https://github.com/tensorflow/tensorflow/pull/59613.diff", "patch_url": "https://github.com/tensorflow/tensorflow/pull/59613.patch", "merged_at": "2023-02-14T00:49:27" }
Refer to the original commit: https://github.com/tensorflow/tensorflow/commit/46cdedf47c1f547d3c4ff9e3f63c12b7e7ec5a22
{ "url": "https://api.github.com/repos/tensorflow/tensorflow/issues/59613/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/tensorflow/tensorflow/issues/59613/timeline
null
null
true