PR #10892: Fix some clang-tidy reported issues in xla/service
PR #10892: Fix some clang-tidy reported issues in xla/service

Imported from GitHub PR https://github.com/openxla/xla/pull/10892

Fixes:
1. `~BufferAllocation() {}` - There is no needed to define empty dtor explicitly. Also, if dtor is explicitly defined we also need to define copy ctor and copy operator=. The right solution here is to not define dtor explicitly.
2. `std::move(target_config)` - `target_config` is const ref - it is not possible to move/modify const refs. std::move can be removed since it is not doing anything here.
3. `mutable_dot_config()->insert(MapPair)` - better to use `try_emplace(K&&, V&&)` directly because it accepts K&& and V&& params, where `insert` requires to create temp `MapPair` object. Internally `insert` uses `try_emplace`.
4. `const std::vector<bool> require_broadcast` - remove const from this param because `require_broadcast` will be moved in this function
5. add `std::move` to `set_auto_spmd_partitioning_mesh_shape` and `set_auto_spmd_partitioning_mesh_ids` to make them similar and consistent with other setter(std::vector) functions in `HloModuleConfig` class.
6. update callers of HloModuleConfig setter(std::vector) functions to use std::move or rvalue to avoid vector copy.
7. `chunk_(std::move(chunk))` - remove move because struct Chunk is trivially-copyable type. So, move have the same price as copy for such types.
8. `additional_sort_data_.insert(pair)` - replaced with `try_emplace(K&&, V&&)` to remove `std::make_pair`. Remove move from `std::move(sort_data)` -  sort_data type AdditionalSortData is trivially-copyable type.
9. `std::move(*buffer_assignment_proto_after_opt)` - remove move because `buffer_assignment_proto_after_opt` is `const BufferAssignmentProto*` - it can not be moved/modified. move does nothing here.
10. return std::move(executable)` - move is not needed in return. It breaks RVO/NRVO compiler optimization.
11. `run_options_(std::move(run_options))` - `std::move` is removed because run_options type ExecutableRunOptions is trivially-copyable type. move has no effect here.
Copybara import of the project:

--
0ad7bde68fea25b626ef1e2ac99ca007151f8b0b by Alexander Pivovarov <pivovaa@amazon.com>:

Fix some clang-tidy reported issues in xla/service

Merging this change closes #10892

FUTURE_COPYBARA_INTEGRATE_REVIEW=https://github.com/openxla/xla/pull/10892 from apivovarov:bugs_server_server 0ad7bde68fea25b626ef1e2ac99ca007151f8b0b
