text: On Fri, 2005-01-28 at 21:34 +0100, Lorenzo Hernández García-Hierro
  wrote:
  > Hi,
  >
  > Attached the new patch following Arjan's recommendations.
  > I'm sorry about not making it "inlined", but my mail agent messes up the
  > diffs if I do so.
  > Still waiting for the OSDL STP tests results, they will take a while to
  > finish.
  >
  > Cheers,
  lots better already! Some more comments (now that the patch got a lot
  easier to read :)
  static inline __u32 tcp_v4_init_sequence(struct sock *sk, struct
  sk_buff *skb)
  {
  - return secure_tcp_sequence_number(skb->nh.iph->daddr,
  - skb->nh.iph->saddr,
  - skb->h.th->dest,
  - skb->h.th->source);
  +
  + return ip_randomisn();
  }
  is there a reason for the weird indentation?
  + if (!tp->write_seq) {
  + tp->write_seq = ip_randomisn();
  + }
  spare { } pare that's not needed, also looks like one tab too many
  static inline u32 xprt_alloc_xid(struct rpc_xprt *xprt)
  {
  - return xprt->xid++;
  + /* Return randomized xprt->xid instead of prt->xid++ */
  + return (u32) obsd_get_random_long();
  +
  }
  that cast looks quite redundant...