text: Red Hat Bugzilla – Bug 869861
  Review Request: pam_openshift - Openshift PAM module
  Last modified: 2012-11-29 01:44:27 EST
  Spec URL:
  SRPM URL:
  Description: The Openshift PAM module configures proper SELinux context for
  processes in a session.
  Fedora Account System Username: tdawson
  Hi, sorry for being late, I was a little too sick for doing it right now.
  I have a few question :
  - some files are under a BSD license, shouldn't it be reflected somewhere ?
  - why pam-libra and pam-openshift provides/obsoletes ?
  ( I guess that's for internal reason of openshift, but once the transitition happened, this can be removed, I think )
  - man page title is incorrect ( still use pam_libra ), I would suggest to regenerate it from the .xml, instead of using the copy shipped by upstream ( and ask to upstream to drop it, or at least, to place the needed code in the Makefile )
  - I think there is some missing requires for shell scripts like attr and policycoreutils. They are likely installed by default, but as they are marked as optional, I would add them explicitly ( following the whole discussion on fedora minimal installation on -devel )
  License:
  It is actually dual licensed code (BSD and/or GPL). We are choosing to use GPL. But ya, I'll see about getting that more clear upstream.
  Obsoletes:
  The original rpm was called pam-libra, and was then switched to pam-openshift. There are currently instructions for "Build your own PAAS" for building those rpm's on Fedora. So we know there are some people that need this.
  But yes, upstream is planning on only having those there until they feel confident that nobody needs them anymore.
  Man Pages:
  Good catch, we'll fix that. Upstream is also in the process of adding the missing man page.
  Requires:
  Another good catch.
  Upstream will soon have another release (with the man page fixes). I'll work on getting the other changes you talked about in that version and we'll just use that version, instead of patching this version up.
  The rpm seemed otherwise good, so do we wait for next upstream release ?
  Spec URL:
  SRPM URL:
  Man page fixed, also man page added for oo-namespace-init
  Requires:
  I did a rpm -qp --requires pam_openshift and it listed both libattr.so.1 and libselinux.so.1. So it picks up attr, but libselinux doesn't pull in policycoreutils, so I have added that.
  License:
  The license is technically there and correct. Since it's a dual license it's a little more confusing than normal. I couldn't figure out a good way to make it more clear without possibly breaking the license.
  Man page and Requires are in the merge path with upstream. License requires more talking to upstream. But I think for now it is good enough.
  Spec URL:
  SRPM URL:
  Updated to latest stable version from upstream.
  This version has all the fixes in it.
  Package Review
  ==============
  Key:
  [x] = Pass
  [!] = Fail
  [-] = Not applicable
  [?] = Not evaluated
  [ ] = Manual review needed
  ===== Notes =====
  - Requires on attr may still be needed ( but again, this is a in progress discussion )
  - Licensing is a little bit unclear ( why GPLv2, not more, etc ), but I guess that's nitpicking ( especially since the code is already under a BSD license )
  - explicit %attr is likely not needed in %files, as this is the default permission ( IIRC ). Not blocking but would be cleaner IMHO.
  - not sure if that a groff issue or a man page issue
  pam_openshift.x86_64: W: manual-page-warning /usr/share/man/man8/pam_openshift.8.gz 169: warning: macro `HTML-TAG' not defined
  Man page display fine, so let's say this is not blocking.
  So the package is approved.
  ===== MUST items =====
  C/C++:
  [x]: Package does not contain any libtool archives (.la)
  [x]: Package does not contain kernel modules.
  [x]: Package contains no static executables.
  [x]: Rpath absent or only used for internal libs.
  /misc/checkout/git/FedoraReview/869861-pam_openshift is not relocatable.
  [x]: Requires correct, justified where necessary.
   30720 bytes in 5 files.
  .
  [!]: Uses parallel make.
  ]: Spec file according to URL is the same as in SRPM.
  [x]: Large data in /usr/share should live in a noarch subpackage if package is
  arched.
  Rpmlint
  -------
  Checking: pam_openshift-1.1.2-2.fc17.x86_64.rpm.
  Rpmlint (installed packages)
  ----------------------------
  # rpmlint pam_openshift.
  # echo 'rpmlint-done:'
  Requires
  --------
  pam_openshift (rpmlib, GLIBC filtered):
  /bin/sh
  config(pam_openshift)
  libattr.so.1()(64bit)
  libattr.so.1(ATTR_1.0)(64bit)
  libc.so.6()(64bit)
  libpam.so.0()(64bit)
  libpam.so.0(LIBPAM_1.0)(64bit)
  libpam.so.0(LIBPAM_EXTENSION_1.0)(64bit)
  libpam.so.0(LIBPAM_MODUTIL_1.0)(64bit)
  libselinux.so.1()(64bit)
  policycoreutils
  rtld(GNU_HASH)
  Provides
  --------
  pam_openshift:
  config(pam_openshift)
  pam-libra
  pam-openshift
  pam_openshift
  pam_openshift(x86-64)
  pam_openshift.so.1()(64bit)
  Unversioned so-files
  --------------------
  pam_openshift: /lib64/security/pam_libra.so
  pam_openshift: /lib64/security/pam_openshift.so
  MD5-sum check
  ------------- :
  CHECKSUM(SHA256) this package : a3fc4758128aaf2566017e964d3df3e5a9e005c7b50e09f7c1adf04d052e9def
  CHECKSUM(SHA256) upstream package : a3fc4758128aaf2566017e964d3df3e5a9e005c7b50e09f7c1adf04d052e9def
  Generated by fedora-review 0.2.0 (Unknown) last change: Unknown
  Buildroot used: fedora-17-x86_64
  Command line :./try-fedora-review -b 869861
  New Package SCM Request
  =======================
  Package Name: pam_openshift
  Short Description: Openshift PAM module
  Owners: tdawson maxamillion
  Branches: f18 f17
  InitialCC:
  Git done (by process-git-requests).
  pam_openshift-1.1.2-2.fc18 has been submitted as an update for Fedora 18.
  pam_openshift-1.1.2-2.fc18 has been pushed to the Fedora 18 testing repository.
  pam_openshift-1.1.2-2.fc18 has been pushed to the Fedora 18 stable repository.