text: Closed Bug 1288758 Opened 4 years ago Closed 4 years ago
  Assertion failure: !s
  User32Before Blocklist, at [snip]mozilla/mozglue/build/Windows Dll Blocklist .cpp:769 (Port bug 1285356 to TB, IM, SM)
  Categories
  (Thunderbird :: General, defect)
  Tracking
  (thunderbird48 unaffected, thunderbird49 fixed, thunderbird50 fixed, thunderbird_esr45 unaffected)
  Thunderbird 50.0
  People
  (Reporter: jorgk-bmo, Assigned: jorgk-bmo)
  Details
  Attachments
  (1 file)
  Local debug builds don't start due to an assertion in WindowsDllBlocklist.cpp. I can't see it in DXR, so it must be brand new (it is, see below): First seen 2016-07-22: This comes from here: Bug 1285356. Aaron: TB doesn't start any more in debug mode due to the MOZ_ASSERT you added here: Is that intentional ;-)
  Flags: needinfo?(aklotz)
  Closer looking at it looks like TB needs to port a bit of that, for example: + DELAYLOAD_DLLS += [ + 'winmm.dll', + 'user32.dll', + ] + or even the changes in main(). Aleth, would that be right?
  Flags: needinfo?(aleth)
  Yes, that's correct. The changes to browser/app/nsBrowserApp.cpp also need to be ported to the mail/app equivalent. Ditto for suite and im...
  Flags: needinfo?(aleth)
  Flags: needinfo?(aklotz)
  Summary: Assertion failure: !sUser32BeforeBlocklist, at [snip]mozilla/mozglue/build/WindowsDllBlocklist.cpp:769 → Assertion failure: !sUser32BeforeBlocklist, at [snip]mozilla/mozglue/build/WindowsDllBlocklist.cpp:769 (Port bug 1285356 to TB, IM, SM)
  As far as I can see, no changes are required in mail/app/nsMailApp.cpp suite/app/nsSuiteApp.cpp im/app/nsMain.cpp since #ifdef HAS_DLL_BLOCKLIST DllBlocklist_Initialize(); #ifdef DEBUG // In order to be effective against AppInit DLLs, the blocklist must be // initialized before user32.dll is loaded into the process (bug 932100). if (GetModuleHandleA("user32.dll")) { fprintf(stderr, "DLL blocklist was unable to intercept AppInit DLLs.\n"); } #endif #endif is already at the top of main(). But I could be wrong ;-)
  Comment on attachment 8774226 [details] [diff] [review] See whether this works. With this patch applied, my local build starts up again. Let's see on try:
  Attachment #8774226 - Flags: review?(aleth)
  Comment on attachment 8774226 [details] [diff] [review] See whether this works. Review of attachment 8774226 [details] [diff] [review]: ----------------------------------------------------------------- You are right, but that's a sign that we have missed some bug(s) touching that file which need porting ;)
  Attachment #8774226 - Flags: review?(aleth) → review+
  Landed: Sadly the try run results were orange. However, that seem to have been other failures, the Assertion failure: !sUser32BeforeBlocklist have all gone. I also checked that all 1141 Mozmill tests worked on Windows XP debug. (In reply to aleth [:aleth] from comment #5) > You are right, but that's a sign that we have missed some bug(s) touching > that file which need porting ;) Well, look at the difference here: We don't have the sandbox stuff. The block of code mentioned in comment #3 moved from after this block we don't have to before it. Since we don't have the block, we didn't need to move anything.
  Status: NEW → RESOLVED
  Closed: 4 years ago
  Resolution: --- → FIXED
  Target Milestone: --- → Thunderbird 50.0
  Assignee: nobody → mozilla
  Comment on attachment 8774226 [details] [diff] [review] See whether this works. This needs uplift since bug 1285356 got uplifted.
  Attachment #8774226 - Flags: approval-comm-aurora+
  Aurora (TB 49):
  status-thunderbird48: --- → unaffected
  status-thunderbird49: --- → fixed
  status-thunderbird50: --- → fixed