fix

services/model_handler.py

@@ -77,11 +77,16 @@ class LocalHuggingFaceModel(Model):
     def invoke(self, prompt: str, **kwargs) -> str:
         """Synchronous invoke method"""
         try:
-            logging.info(f"Invoking model with prompt: {prompt[:100]}...")
+            logging.info(f"Invoking model with prompt: {prompt[:100] if prompt else 'None'}...")
             
-            if not prompt or not prompt.strip():
+            # Check if prompt is None or empty
+            if prompt is None:
+                logging.warning("None prompt provided to invoke method")
+                return Response("No input provided. Please provide a valid prompt.")
+                
+            if not prompt.strip():
                 logging.warning("Empty prompt provided to invoke method")
-                return "No input provided."
+                return Response("No input provided. Please provide a non-empty prompt.")
                 
             inputs = self.tokenizer(prompt, return_tensors="pt", padding=True)
             
@@ -101,17 +106,17 @@ class LocalHuggingFaceModel(Model):
             # Check if output is empty
             if not decoded_output or not decoded_output.strip():
                 logging.warning("Model generated empty output")
-                return "The model did not generate any output. Please try with a different prompt."
+                return Response("The model did not generate any output. Please try with a different prompt.")
                 
             logging.info(f"Model generated output: {decoded_output[:100]}...")
-            return decoded_output
+            return Response(decoded_output)
         except Exception as e:
             logging.error(f"Error in local model generation: {str(e)}")
             if hasattr(e, 'args') and len(e.args) > 0:
                 error_message = e.args[0]
             else:
                 error_message = str(e)
-            return f"Error during generation: {error_message}"
+            return Response(f"Error during generation: {error_message}")
     
     def invoke_stream(self, prompt: str, **kwargs):
         """Synchronous streaming invoke method"""
@@ -268,7 +273,21 @@ class ModelHandler:
     
     def _format_prompt(self, role, instructions, query):
         """Format the prompt for the model"""
-        return f"""Task: {role}
+        # Validate inputs
+        if not role or not role.strip():
+            role = "Assistant"
+            logging.warning("Empty role provided to _format_prompt, using default: 'Assistant'")
+        
+        if not instructions or not instructions.strip():
+            instructions = "Please process the following input."
+            logging.warning("Empty instructions provided to _format_prompt, using default instructions")
+        
+        if not query or not query.strip():
+            query = "No input provided."
+            logging.warning("Empty query provided to _format_prompt, using placeholder text")
+        
+        # Format the prompt
+        formatted_prompt = f"""Task: {role}
 
 Instructions:
 {instructions}
@@ -276,7 +295,14 @@ Instructions:
 Input: {query}
 
 Output:"""
-
+        
+        # Ensure the prompt is not empty
+        if not formatted_prompt or not formatted_prompt.strip():
+            logging.error("Generated an empty prompt despite validation")
+            formatted_prompt = "Please provide a response."
+        
+        return formatted_prompt
+    
     @staticmethod
     @st.cache_resource
     def _load_model():
@@ -303,6 +329,12 @@ Output:"""
     def generate_answer(self, query: str) -> str:
         try:
             logging.info(f"Generating answer for query: {query}")
+            
+            # Validate input query
+            if not query or not query.strip():
+                logging.error("Empty query provided")
+                return "Error: Please provide a non-empty query"
+                
             # Format translation prompt
             translation_prompt = self._format_prompt(
                 role="Translate the following text to English",
@@ -311,6 +343,11 @@ Output:"""
             )
             logging.info(f"Translation prompt: {translation_prompt}")
             
+            # Validate translation prompt
+            if not translation_prompt or not translation_prompt.strip():
+                logging.error("Empty translation prompt generated")
+                return "Error: Unable to generate translation prompt"
+            
             # Get English translation
             translation = self.translator.run(prompt=translation_prompt, stream=False)
             logging.info(f"Translation result type: {type(translation)}")
@@ -327,6 +364,10 @@ Output:"""
                 translation_content = str(translation)
                 logging.info(f"Translation as string: {translation_content}")
 
+            # Validate translation content
+            if not translation_content or not translation_content.strip():
+                logging.error("Empty translation content")
+                return "Error: Empty translation result"
             
             # Format research prompt
             research_prompt = self._format_prompt(
@@ -336,6 +377,11 @@ Output:"""
             )
             logging.info(f"Research prompt: {research_prompt}")
             
+            # Validate research prompt
+            if not research_prompt or not research_prompt.strip():
+                logging.error("Empty research prompt generated")
+                return "Error: Unable to generate research prompt"
+            
             # Get research results
             research_results = self.researcher.run(prompt=research_prompt, stream=False)
             logging.info(f"Research results type: {type(research_results)}")
@@ -352,6 +398,11 @@ Output:"""
                 research_content = str(research_results)
                 logging.info(f"Research as string: {research_content}")
 
+            # Validate research content
+            if not research_content or not research_content.strip():
+                logging.error("Empty research content")
+                return "Error: Empty research result"
+                
             logging.info(f"Research results: {research_results}")
             
             # Format summary prompt
@@ -362,6 +413,11 @@ Output:"""
             )
             logging.info(f"Summary prompt: {summary_prompt}")
             
+            # Validate summary prompt
+            if not summary_prompt or not summary_prompt.strip():
+                logging.error("Empty summary prompt generated")
+                return "Error: Unable to generate summary prompt"
+            
             # Get summary
             summary = self.summarizer.run(prompt=summary_prompt, stream=False)
             logging.info(f"Summary type: {type(summary)}")
@@ -378,6 +434,11 @@ Output:"""
                 summary_content = str(summary)
                 logging.info(f"Summary as string: {summary_content}")
 
+            # Validate summary content
+            if not summary_content or not summary_content.strip():
+                logging.error("Empty summary content")
+                return "Error: Empty summary result"
+                
             logging.info(f"Summary: {summary}")
             
             # Format presentation prompt
@@ -388,6 +449,11 @@ Output:"""
             )
             logging.info(f"Presentation prompt: {presentation_prompt}")
             
+            # Validate presentation prompt
+            if not presentation_prompt or not presentation_prompt.strip():
+                logging.error("Empty presentation prompt generated")
+                return "Error: Unable to generate presentation prompt"
+            
             # Get presentation
             presentation = self.presenter.run(prompt=presentation_prompt, stream=False)
             logging.info(f"Presentation type: {type(presentation)}")