Update app.py

app.py

@@ -469,23 +469,23 @@ def process_uploaded_file(file, state_bookmarks):
 
     if file is None:
         logger.warning("No file uploaded")
-        return "Please upload a bookmarks HTML file.", '', state_bookmarks, display_bookmarks(), gr.update(choices=[])
+        return "Please upload a bookmarks HTML file.", '', state_bookmarks, gr.update(choices=[])
 
     try:
         file_content = file.decode('utf-8')
     except UnicodeDecodeError as e:
         logger.error(f"Error decoding the file: {e}", exc_info=True)
-        return "Error decoding the file. Please ensure it's a valid HTML file.", '', state_bookmarks, display_bookmarks(), gr.update(choices=[])
+        return "Error decoding the file. Please ensure it's a valid HTML file.", '', state_bookmarks, gr.update(choices=[])
 
     try:
         bookmarks = parse_bookmarks(file_content)
     except Exception as e:
         logger.error(f"Error parsing bookmarks: {e}", exc_info=True)
-        return "Error parsing the bookmarks HTML file.", '', state_bookmarks, display_bookmarks(), gr.update(choices=[])
+        return "Error parsing the bookmarks HTML file.", '', state_bookmarks, gr.update(choices=[])
 
     if not bookmarks:
         logger.warning("No bookmarks found in the uploaded file")
-        return "No bookmarks found in the uploaded file.", '', state_bookmarks, display_bookmarks(), gr.update(choices=[])
+        return "No bookmarks found in the uploaded file.", '', state_bookmarks, gr.update(choices=[])
 
     # Assign unique IDs to bookmarks
     for idx, bookmark in enumerate(bookmarks):
@@ -505,7 +505,7 @@ def process_uploaded_file(file, state_bookmarks):
         faiss_index = vectorize_and_index(bookmarks)
     except Exception as e:
         logger.error(f"Error building FAISS index: {e}", exc_info=True)
-        return "Error building search index.", '', state_bookmarks, display_bookmarks(), gr.update(choices=[])
+        return "Error building search index.", '', state_bookmarks, gr.update(choices=[])
 
     message = f"✅ Successfully processed {len(bookmarks)} bookmarks."
     logger.info(message)
@@ -518,7 +518,7 @@ def process_uploaded_file(file, state_bookmarks):
     # Update state
     state_bookmarks = bookmarks.copy()
 
-    return message, bookmark_html, state_bookmarks, bookmark_html, gr.update(choices=choices)
+    return message, bookmark_html, state_bookmarks, gr.update(choices=choices)
 
 def delete_selected_bookmarks(selected_indices, state_bookmarks):
     """
@@ -581,7 +581,7 @@ def edit_selected_bookmarks_category(selected_indices, new_category, state_bookm
     # Update state
     state_bookmarks = bookmarks.copy()
 
-    return message, gr.update(choices=choices), display_bookmarks(), state_bookmarks
+    return message, gr.update(choices=choices), display_bookmarks(), state_bookmarks()
 
 def export_bookmarks():
     """
@@ -722,6 +722,12 @@ def build_app():
             # Initialize state
             state_bookmarks = gr.State([])
 
+            # Define 'bookmark_selector' first
+            bookmark_selector = gr.CheckboxGroup(
+                label="✅ Select Bookmarks",
+                choices=[]
+            )
+
             # General Overview
             gr.Markdown("""
 # 📚 SmartMarks - AI Browser Bookmarks Manager
@@ -767,7 +773,7 @@ Navigate through the tabs to explore each feature in detail.
                 process_button.click(
                     process_uploaded_file,
                     inputs=[upload, state_bookmarks],
-                    outputs=[output_text, bookmark_display, state_bookmarks, bookmark_display, gr.JSON(label="Bookmark Choices")]
+                    outputs=[output_text, bookmark_display, state_bookmarks, bookmark_display, bookmark_selector]
                 )
 
             with gr.Tab("Chat with Bookmarks"):
@@ -837,11 +843,8 @@ Navigate through the tabs to explore each feature in detail.
                 bookmark_display_manage = gr.HTML(label="📄 Bookmarks")
 
                 with gr.Row():
-                    # Define 'bookmark_selector' inside the tab
-                    bookmark_selector = gr.CheckboxGroup(
-                        label="✅ Select Bookmarks",
-                        choices=[]
-                    )
+                    # Render 'bookmark_selector' inside the tab
+                    bookmark_selector.render()
 
                 with gr.Row():
                     delete_button = gr.Button("🗑️ Delete Selected")