fix (aggregators): Minor fix to median aggregator.

Signed-off-by: Kshitij Fadnis <[email protected]>

src/utilities/aggregators.ts

@@ -82,8 +82,8 @@ export const medianAggregator: Aggregator = {
     // Step 3: Calculate aggregate value & standard deviation
     const median =
       sortedNumericScores.length % 2 == 0
-        ? sortedNumericScores[sortedNumericScores.length / 2]
-        : sortedNumericScores[(sortedNumericScores.length + 1) / 2];
+        ? sortedNumericScores[sortedNumericScores.length / 2 - 1]
+        : sortedNumericScores[(sortedNumericScores.length + 1) / 2 - 1];
     const std = Math.sqrt(
       sortedNumericScores
         .map((score) => Math.pow(score - median, 2))

src/utilities/metrics.ts

@@ -230,7 +230,7 @@ function computeMedian(
   // Step 6: Calculate median
   const median =
     sortedNumericScores.length % 2 == 0
-      ? sortedNumericScores[sortedNumericScores.length / 2]
+      ? sortedNumericScores[sortedNumericScores.length / 2 - 1]
       : sortedNumericScores[(sortedNumericScores.length + 1) / 2 - 1];
 
   // Step 7: Common patterns

src/views/model-behavior/ModelBehavior.tsx

@@ -180,9 +180,8 @@ export default function ModelBehavior({
   const [selectedMetric, setSelectedMetric] = useState<Metric | undefined>(
     undefined,
   );
-  const [selectedAllowedValues, setSelectedAllowedValues] = useState<string[]>(
-    [],
-  );
+  const [selectedAllowedValues, setSelectedAllowedValues] =
+    useState<string[]>();
   const [selectedAnnotator, setSelectedAnnotator] = useState<
     string | undefined
   >(undefined);
@@ -313,7 +312,7 @@ export default function ModelBehavior({
       ).sort();
     }
 
-    return [];
+    return undefined;
   }, [
     evaluationsPerMetric,
     selectedModels,
@@ -519,8 +518,11 @@ export default function ModelBehavior({
         ) : null}
 
         {selectedMetric &&
-        selectedMetric.aggregator === 'majority' &&
-        availableAllowedValues ? (
+        selectedMetric.type === 'categorical' &&
+        (selectedMetric.aggregator === 'majority' ||
+          selectedMetric.aggregator === 'median') &&
+        availableAllowedValues &&
+        selectedAllowedValues ? (
           <div className={classes.allowedValueSelector}>
             <FilterableMultiSelect
               key={'allowed-value-selector' + selectedAllowedValues.join('::')}

src/workers/filter.ts

@@ -103,7 +103,6 @@ onmessage = function (event: MessageEvent<FilterationRequest>) {
             evaluation.modelId in models &&
             evaluation[metric.name].hasOwnProperty(annotator) &&
             (!allowedValues ||
-              isEmpty(allowedValues) ||
               allowedValues.includes(evaluation[metric.name][annotator].value))
           ) {
             // Step 3.b.i.*: Create and add record
@@ -126,7 +125,6 @@ onmessage = function (event: MessageEvent<FilterationRequest>) {
                 .map((level) => level.value)
                 .includes(evaluation[`${metric.name}_agg`].level)) &&
             (!allowedValues ||
-              isEmpty(allowedValues) ||
               allowedValues.includes(evaluation[`${metric.name}_agg`].value))
           ) {
             // Step 3.b.ii.*: Create and add record
@@ -161,7 +159,6 @@ onmessage = function (event: MessageEvent<FilterationRequest>) {
             evaluation.modelId in models &&
             evaluation[metric].hasOwnProperty(annotator) &&
             (!allowedValues ||
-              isEmpty(allowedValues) ||
               allowedValues.includes(evaluation[metric][annotator].value))
           ) {
             records.push({
@@ -179,7 +176,6 @@ onmessage = function (event: MessageEvent<FilterationRequest>) {
                 .map((level) => level.value)
                 .includes(evaluation[`${metric}_agg`].level)) &&
             (!allowedValues ||
-              isEmpty(allowedValues) ||
               allowedValues.includes(evaluation[`${metric}_agg`].value))
           ) {
             records.push({