fix HUUUGE memory leak

src/production/generateAudio.mts

@@ -21,36 +21,42 @@ export async function generateAudio(prompt: string, audioFileName: string) {
     protocolTimeout: 120000,
   })
 
-  const page = await browser.newPage()
+  try {
+    const page = await browser.newPage()
 
-  await page.goto(instance, {
-    waitUntil: "networkidle2",
-  })
+    await page.goto(instance, {
+      waitUntil: "networkidle2",
+    })
 
-  await new Promise(r => setTimeout(r, 3000))
+    await new Promise(r => setTimeout(r, 3000))
 
-  const firstTextboxInput = await page.$('input[data-testid="textbox"]')
+    const firstTextboxInput = await page.$('input[data-testid="textbox"]')
 
-  await firstTextboxInput.type(prompt)
+    await firstTextboxInput.type(prompt)
 
-  // console.log("looking for the button to submit")
-  const submitButton = await page.$("button.lg")
+    // console.log("looking for the button to submit")
+    const submitButton = await page.$("button.lg")
 
-  // console.log("clicking on the button")
-  await submitButton.click()
+    // console.log("clicking on the button")
+    await submitButton.click()
 
-  await page.waitForSelector("a[download]", {
-    timeout: 120000, // no need to wait for too long, generation is quick
-  })
+    await page.waitForSelector("a[download]", {
+      timeout: 120000, // no need to wait for too long, generation is quick
+    })
 
-  const audioRemoteUrl = await page.$$eval("a[download]", el => el.map(x => x.getAttribute("href"))[0])
+    const audioRemoteUrl = await page.$$eval("a[download]", el => el.map(x => x.getAttribute("href"))[0])
 
 
-  // it is always a good idea to download to a tmp dir before saving to the pending dir
-  // because there is always a risk that the download will fail
-  
-  const tmpFileName = `${uuidv4()}.mp4`
+    // it is always a good idea to download to a tmp dir before saving to the pending dir
+    // because there is always a risk that the download will fail
+    
+    const tmpFileName = `${uuidv4()}.mp4`
 
-  await downloadFileToTmp(audioRemoteUrl, tmpFileName)
-  await moveFileFromTmpToPending(tmpFileName, audioFileName)
+    await downloadFileToTmp(audioRemoteUrl, tmpFileName)
+    await moveFileFromTmpToPending(tmpFileName, audioFileName)
+  } catch (err) {
+    throw err
+  } finally {
+    await browser.close()
+  }
 }

src/production/generateVoice.mts

@@ -18,39 +18,45 @@ export async function generateVoice(prompt: string, voiceFileName: string) {
     protocolTimeout: 800000,
   })
 
-  const page = await browser.newPage()
+  try {
+    const page = await browser.newPage()
 
-  await page.goto(instance, {
-    waitUntil: "networkidle2",
-  })
+    await page.goto(instance, {
+      waitUntil: "networkidle2",
+    })
 
-  await new Promise(r => setTimeout(r, 3000))
+    await new Promise(r => setTimeout(r, 3000))
 
-  const firstTextarea = await page.$('textarea[data-testid="textbox"]')
+    const firstTextarea = await page.$('textarea[data-testid="textbox"]')
 
-  await firstTextarea.type(prompt)
+    await firstTextarea.type(prompt)
 
-  // console.log("looking for the button to submit")
-  const submitButton = await page.$("button.lg")
+    // console.log("looking for the button to submit")
+    const submitButton = await page.$("button.lg")
 
-  // console.log("clicking on the button")
-  await submitButton.click()
+    // console.log("clicking on the button")
+    await submitButton.click()
 
-  await page.waitForSelector("audio", {
-    timeout: 800000, // need to be large enough in case someone else attemps to use our space
-  })
+    await page.waitForSelector("audio", {
+      timeout: 800000, // need to be large enough in case someone else attemps to use our space
+    })
 
-  const voiceRemoteUrl = await page.$$eval("audio", el => el.map(x => x.getAttribute("src"))[0])
+    const voiceRemoteUrl = await page.$$eval("audio", el => el.map(x => x.getAttribute("src"))[0])
 
 
-  console.log({
-    voiceRemoteUrl,
-  })
+    console.log({
+      voiceRemoteUrl,
+    })
 
 
-  console.log(`- downloading ${voiceFileName} from ${voiceRemoteUrl}`)
+    console.log(`- downloading ${voiceFileName} from ${voiceRemoteUrl}`)
 
-  await downloadFileToTmp(voiceRemoteUrl, voiceFileName)
+    await downloadFileToTmp(voiceRemoteUrl, voiceFileName)
 
-  return voiceFileName
+    return voiceFileName
+  } catch (err) {
+    throw err
+  } finally {
+    await browser.close()
+  }
 }

src/production/interpolateVideo.mts

@@ -28,33 +28,39 @@ export async function interpolateVideo(fileName: string, steps: number, fps: num
     protocolTimeout: 400000,
   })
 
-  const page = await browser.newPage()
-  await page.goto(instance, { waitUntil: 'networkidle2' })
-  
-  await new Promise(r => setTimeout(r, 3000))
+  try {
+    const page = await browser.newPage()
+    await page.goto(instance, { waitUntil: 'networkidle2' })
+    
+    await new Promise(r => setTimeout(r, 3000))
 
-  const fileField = await page.$('input[type=file]')
+    const fileField = await page.$('input[type=file]')
 
-  // console.log(`uploading file..`)
-  await fileField.uploadFile(inputFilePath)
+    // console.log(`uploading file..`)
+    await fileField.uploadFile(inputFilePath)
 
-  // console.log('looking for the button to submit')
-  const submitButton = await page.$('button.lg')
+    // console.log('looking for the button to submit')
+    const submitButton = await page.$('button.lg')
 
-  // console.log('clicking on the button')
-  await submitButton.click()
+    // console.log('clicking on the button')
+    await submitButton.click()
 
-  await page.waitForSelector('a[download="interpolated_result.mp4"]', {
-    timeout: 400000, // need to be large enough in case someone else attemps to use our space
-  })
+    await page.waitForSelector('a[download="interpolated_result.mp4"]', {
+      timeout: 400000, // need to be large enough in case someone else attemps to use our space
+    })
 
-  const interpolatedFileUrl = await page.$$eval('a[download="interpolated_result.mp4"]', el => el.map(x => x.getAttribute("href"))[0])
+    const interpolatedFileUrl = await page.$$eval('a[download="interpolated_result.mp4"]', el => el.map(x => x.getAttribute("href"))[0])
 
-  // it is always a good idea to download to a tmp dir before saving to the pending dir
-  // because there is always a risk that the download will fail
+    // it is always a good idea to download to a tmp dir before saving to the pending dir
+    // because there is always a risk that the download will fail
 
-  const tmpFileName = `${uuidv4()}.mp4`
+    const tmpFileName = `${uuidv4()}.mp4`
 
-  await downloadFileToTmp(interpolatedFileUrl, tmpFileName)
-  await moveFileFromTmpToPending(tmpFileName, fileName)
+    await downloadFileToTmp(interpolatedFileUrl, tmpFileName)
+    await moveFileFromTmpToPending(tmpFileName, fileName)
+  } catch (err) {
+    throw err
+  } finally {
+    await browser.close()
+  }
 }

src/production/upscaleVideo.mts

@@ -22,51 +22,57 @@ export async function upscaleVideo(fileName: string, prompt: string) {
     protocolTimeout: 800000,
   })
 
-  const page = await browser.newPage()
+  try {
+    const page = await browser.newPage()
 
-  await page.goto(instance, {
-    waitUntil: 'networkidle2',
-  })
+    await page.goto(instance, {
+      waitUntil: 'networkidle2',
+    })
 
-  const promptField = await page.$('textarea')
-  await promptField.type(prompt)
+    const promptField = await page.$('textarea')
+    await promptField.type(prompt)
 
-  const inputFilePath = path.join(pendingFilesDirFilePath, fileName)
-  // console.log(`local file to upscale: ${inputFilePath}`)
-  
-  await new Promise(r => setTimeout(r, 3000))
+    const inputFilePath = path.join(pendingFilesDirFilePath, fileName)
+    // console.log(`local file to upscale: ${inputFilePath}`)
+    
+    await new Promise(r => setTimeout(r, 3000))
 
-  const fileField = await page.$('input[type=file]')
+    const fileField = await page.$('input[type=file]')
 
-  // console.log(`uploading file..`)
-  await fileField.uploadFile(inputFilePath)
+    // console.log(`uploading file..`)
+    await fileField.uploadFile(inputFilePath)
 
-  // console.log('looking for the button to submit')
-  const submitButton = await page.$('button.lg')
+    // console.log('looking for the button to submit')
+    const submitButton = await page.$('button.lg')
 
-  // console.log('clicking on the button')
-  await submitButton.click()
+    // console.log('clicking on the button')
+    await submitButton.click()
 
-  /*
-  const client = await page.target().createCDPSession()
+    /*
+    const client = await page.target().createCDPSession()
 
-  await client.send('Page.setDownloadBehavior', {
-    behavior: 'allow',
-    downloadPath: tmpDir,
-  })
-  */
+    await client.send('Page.setDownloadBehavior', {
+      behavior: 'allow',
+      downloadPath: tmpDir,
+    })
+    */
 
-  await page.waitForSelector('a[download="xl_result.mp4"]', {
-    timeout: 800000, // need to be large enough in case someone else attemps to use our space
-  })
+    await page.waitForSelector('a[download="xl_result.mp4"]', {
+      timeout: 800000, // need to be large enough in case someone else attemps to use our space
+    })
 
-  const upscaledFileUrl = await page.$$eval('a[download="xl_result.mp4"]', el => el.map(x => x.getAttribute("href"))[0])
+    const upscaledFileUrl = await page.$$eval('a[download="xl_result.mp4"]', el => el.map(x => x.getAttribute("href"))[0])
 
-  // it is always a good idea to download to a tmp dir before saving to the pending dir
-  // because there is always a risk that the download will fail
-  
-  const tmpFileName = `${uuidv4()}.mp4`
+    // it is always a good idea to download to a tmp dir before saving to the pending dir
+    // because there is always a risk that the download will fail
+    
+    const tmpFileName = `${uuidv4()}.mp4`
 
-  await downloadFileToTmp(upscaledFileUrl, tmpFileName)
-  await moveFileFromTmpToPending(tmpFileName, fileName)
+    await downloadFileToTmp(upscaledFileUrl, tmpFileName)
+    await moveFileFromTmpToPending(tmpFileName, fileName)
+  } catch (err) {
+    throw err
+  } finally {
+    await browser.close()
+  }
 }

src/utils/segmentImage.mts

@@ -36,54 +36,60 @@ export async function segmentImage(
     protocolTimeout: 40000,
   })
 
-  const page = await browser.newPage()
-  await page.goto(instance, { waitUntil: 'networkidle2' })
-  
-  await new Promise(r => setTimeout(r, 3000))
+  try {
+    const page = await browser.newPage()
+    await page.goto(instance, { waitUntil: 'networkidle2' })
+    
+    await new Promise(r => setTimeout(r, 3000))
 
-  const fileField = await page.$('input[type="file"]')
+    const fileField = await page.$('input[type="file"]')
 
-  // console.log(`uploading file..`)
-  await fileField.uploadFile(inputImageFilePath)
+    // console.log(`uploading file..`)
+    await fileField.uploadFile(inputImageFilePath)
 
-  const firstTextarea = await page.$('textarea[data-testid="textbox"]')
+    const firstTextarea = await page.$('textarea[data-testid="textbox"]')
 
-  const conceptsToDetect = actionnables.join(" . ")
-  await firstTextarea.type(conceptsToDetect)
+    const conceptsToDetect = actionnables.join(" . ")
+    await firstTextarea.type(conceptsToDetect)
 
-  // console.log('looking for the button to submit')
-  const submitButton = await page.$('button.lg')
+    // console.log('looking for the button to submit')
+    const submitButton = await page.$('button.lg')
 
-  await sleep(300)
+    await sleep(300)
 
-  // console.log('clicking on the button')
-  await submitButton.click()
+    // console.log('clicking on the button')
+    await submitButton.click()
 
-  await page.waitForSelector('img[data-testid="detailed-image"]', {
-    timeout: 40000, // we keep it tight, to fail early
-  })
+    await page.waitForSelector('img[data-testid="detailed-image"]', {
+      timeout: 40000, // we keep it tight, to fail early
+    })
 
-  const maskUrl = await page.$$eval('img[data-testid="detailed-image"]', el => el.map(x => x.getAttribute("src"))[0])
+    const maskUrl = await page.$$eval('img[data-testid="detailed-image"]', el => el.map(x => x.getAttribute("src"))[0])
 
-  let segments: ImageSegment[] = []
-  
-  try {
-    segments = JSON.parse(await page.$$eval('textarea', el => el.map(x => x.value)[1]))
-  } catch (err) {
-    console.log(`failed to parse JSON: ${err}`)
-    segments = []
-  }
+    let segments: ImageSegment[] = []
+    
+    try {
+      segments = JSON.parse(await page.$$eval('textarea', el => el.map(x => x.value)[1]))
+    } catch (err) {
+      console.log(`failed to parse JSON: ${err}`)
+      segments = []
+    }
 
-  // const tmpMaskFileName = `${uuidv4()}.png`
-  // await downloadFileToTmp(maskUrl, tmpMaskFileName)
+    // const tmpMaskFileName = `${uuidv4()}.png`
+    // await downloadFileToTmp(maskUrl, tmpMaskFileName)
 
-  const rawPngInBase64 = await downloadImageAsBase64(maskUrl)
+    const rawPngInBase64 = await downloadImageAsBase64(maskUrl)
 
-  const pngInBase64 = await resizeBase64Image(rawPngInBase64, width, height)
+    const pngInBase64 = await resizeBase64Image(rawPngInBase64, width, height)
 
-  return {
-    pngInBase64,
-    segments,
+    return {
+      pngInBase64,
+      segments,
+    }
+  } catch (err) {
+    throw err
+  } finally {
+    await browser.close()
   }
 }