now it should work

app.py

@@ -69,17 +69,19 @@ def use_streamlit():
 
             form_filename = f"{st.session_state['session_id']}_form.pdf"
             st.session_state["form_filename"] = form_filename
-            form_data = build_form_data_from_answers(st.session_state["answers"], categories,
+            form_data, filename = build_form_data_from_answers(st.session_state["answers"], categories,
                                                      st.session_state.get("signature"))
-            write_pdf_form(form_data, Path(form_filename))
+            st.session_state["pdf_form"] = write_pdf_form(form_data)
+            st.session_state["pdf_form_filename"] = filename
             st.session_state["step"] = "form_created"
     if st.session_state.get("step") == "form_created":
-        with open(Path(st.session_state["form_filename"]), "rb") as form:
-            st.download_button("download form", form.read(), mime="application/pdf")
+        st.download_button("download form", st.session_state["pdf_form"],
+                           file_name=st.session_state["pdf_form_filename"], mime="application/pdf")
         start_over_button = st.button("Start over")
         if start_over_button:
             del st.session_state["step"]
-            os.unlink(st.session_state["form_filename"])
+            del st.session_state["pdf_form"]
+            del st.session_state["pdf_form_filename"]
 
 
 use_streamlit()

form/form.py

@@ -1,12 +1,14 @@
+from io import BytesIO
 from pathlib import Path
-from typing import TypedDict
+from typing import TypedDict, Tuple
 from PyPDFForm import PdfWrapper
 
 from utils.date_utils import get_today_date_as_dd_mm_yyyy
 from utils.parsing_utils import find_and_parse_date, find_and_parse_phone_number
 
 
-def build_form_data_from_answers(answers: dict[int, str], categories: list[str], signature: str | None = None):
+def build_form_data_from_answers(answers: dict[int, str], categories: list[str], signature: str | None = None) -> (
+        Tuple)[dict[str, str], str]:
     form_data = {}
     for category in categories:
         form_data[form_fields_map[category]] = True
@@ -27,15 +29,17 @@ def build_form_data_from_answers(answers: dict[int, str], categories: list[str],
     form_data[form_fields_map["signature_date"]] = get_today_date_as_dd_mm_yyyy()
     if signature:
         form_data[form_fields_map["signature"]] = signature
-    return form_data
+    return form_data, (f"work_permit_request"
+                       f"_{'-'.join(categories)}_{answers[9]}_"
+                       f"{form_data[form_fields_map['start_date']].replace('/','-')}.pdf")
 
-def write_pdf_form(form_data: dict[str, str | bool | int], output_path:Path):
+
+def write_pdf_form(form_data: dict[str, str | bool | int]) -> bytes:
     base_form_path = Path(__file__).parent
     base_form_path = base_form_path.joinpath("form.pdf")
     with open(base_form_path, "rb") as blank_form:
         filled_form = PdfWrapper(blank_form).fill(form_data)
-    with open(output_path, "wb+") as filled_form_file:
-        filled_form_file.write(filled_form.read())
+    return filled_form.read()
 
 class FormFields(TypedDict, total=True):
     start_date: str