other release with pons

README.rst

@@ -38,14 +38,16 @@ in this tool starting with google translate
 Features
 --------
 
-* deep-translator uses google translate to translate a text. Therefore, all languages are supported
-* TODO: add support for the PONS translator (pons.com)
+* Support for google translate
+* Support for Pons translator (pons.com)
+* Translate directly from a text file
+* Translate different paragraphs in different languages
 
 
 Usage
 =====
 
-To use deep_translator in a project::
+.. code-block:: python
 
     from deep_translator import GoogleTranslator
 
@@ -57,10 +59,16 @@ To use deep_translator in a project::
 
     result_german = GoogleTranslator(source='auto', target='de').translate(payload=english_text)
 
-
     # Alternatively, you can pass languages by their name:
-
     result_german = GoogleTranslator(source='english', target='german').translate(payload=english_text)
 
-    # soon also support for the PONS translator. Take a look in the examples folder for more :)
+    ##################### or maybe you want to translate a text file ? #############################
+    translated_text = GoogleTranslator(source='auto', target='german').translate_file('path/to/file')
+
+    # or maybe you have many sentences in different languages and want to automate the translation process
+    translated = GoogleTranslator(source='auto', target='de').translate_sentences(your_list_of_sentences)
+
+    ###################### or use Pons as a translator  ###########################
+    word = 'good'
+    translated_word = PonsTranslator(source='english', target='french').translate(word)
 

deep_translator/__init__.py

@@ -5,7 +5,7 @@ from .pons import PonsTranslator
 
 __author__ = """Nidhal Baccouri"""
 __email__ = '[email protected]'
-__version__ = '0.1.2'
+__version__ = '0.1.3'
 
 __all__ = [GoogleTranslator,
            PonsTranslator]

deep_translator/google_trans.py

@@ -59,13 +59,7 @@ class GoogleTranslator(BaseTranslator, ABC):
         @return: str: translated text
         """
 
-        if not self.validate_payload(payload):
-            raise NotValidPayload(payload)
-
-        if not self._check_length(payload):
-            raise NotValidLength(payload)
-
-        try:
+        if self._validate_payload(payload):
             payload = payload.strip()
 
             if self.payload_key:
@@ -79,8 +73,37 @@ class GoogleTranslator(BaseTranslator, ABC):
 
             return element.get_text(strip=True)
 
+    def translate_file(self, path, **kwargs):
+        try:
+            with open(path) as f:
+                text = f.read()
+
+            return self.translate(payload=text)
+        except Exception as e:
+            raise e
+
+    def translate_sentences(self, sentences=None, **kwargs):
+        """
+        translate many sentences together. This makes sense if you have sentences with different languages
+        and you want to translate all to unified language. This is handy because it detects
+        automatically the language of each sentence and then translate it.
+
+        @param sentences: list of sentences to translate
+        @return: list of all translated sentences
+        """
+        if not sentences:
+            raise NotValidPayload(sentences)
+
+        translated_sentences = []
+        try:
+            for sentence in sentences:
+                translated = self.translate(payload=sentence)
+                translated_sentences.append(translated)
+
+            return translated_sentences
+
         except Exception as e:
-            raise Exception(str(e.args))
+            raise e
 
 
 if __name__ == '__main__':

deep_translator/parent.py

@@ -1,6 +1,6 @@
 """Main module."""
 
-from deep_translator.exceptions import NotValidPayload
+from deep_translator.exceptions import NotValidPayload, NotValidLength
 from abc import ABC, abstractmethod
 
 
@@ -29,52 +29,25 @@ class BaseTranslator(ABC):
         self.payload_key = payload_key
         super(BaseTranslator, self).__init__()
 
-    def validate_payload(self, payload):
+    @staticmethod
+    def _validate_payload(payload, min_chars=1, max_chars=5000):
         """
         validate the payload text to translate
         @param payload: text to translate
         @return: bool
         """
-        if not payload or not isinstance(payload, str):
-            return False
 
+        if not payload or not isinstance(payload, str):
+            raise NotValidPayload(payload)
+        if not BaseTranslator.__check_length(payload, min_chars, max_chars):
+            raise NotValidLength
         return True
 
-    def _check_length(self, payload, min_chars=0, max_chars=5000):
+    @staticmethod
+    def __check_length(payload, min_chars, max_chars):
         return True if min_chars < len(payload) < max_chars else False
 
     @abstractmethod
     def translate(self, payload, **kwargs):
         pass
 
-    def translate_file(self, path, **kwargs):
-        try:
-            with open(path) as f:
-                text = f.read()
-
-            return self.translate(payload=text)
-        except Exception as e:
-            raise e
-
-    def translate_sentences(self, sentences=None, **kwargs):
-        """
-        translate many sentences together. This makes sense if you have sentences with different languages
-        and you want to translate all to unified language. This is handy because it detects
-        automatically the language of each sentence and then translate it.
-
-        @param sentences: list of sentences to translate
-        @return: list of all translated sentences
-        """
-        if not sentences:
-            raise NotValidPayload
-
-        translated_sentences = []
-        try:
-            for sentence in sentences:
-                translated = self.translate(payload=sentence)
-                translated_sentences.append(translated)
-
-            return translated_sentences
-
-        except Exception as e:
-            raise e

deep_translator/pons.py

@@ -2,7 +2,7 @@
 from bs4 import BeautifulSoup
 import requests
 from deep_translator.constants import BASE_URLS, PONS_LANGUAGES_TO_CODES, PONS_CODES_TO_LANGUAGES
-from deep_translator.exceptions import LanguageNotSupportedException, ElementNotFoundInGetRequest
+from deep_translator.exceptions import LanguageNotSupportedException, ElementNotFoundInGetRequest, NotValidPayload
 from deep_translator.parent import BaseTranslator
 from requests.utils import quote
 
@@ -18,7 +18,7 @@ class PonsTranslator(BaseTranslator):
         """
         self.__base_url = BASE_URLS.get("PONS")
 
-        if self.is_language_supported(source, target, translator='pons'):
+        if self.is_language_supported(source, target):
             self._source, self._target = self._map_language_to_code(source, target)
 
         super().__init__(base_url=self.__base_url,
@@ -50,34 +50,49 @@ class PonsTranslator(BaseTranslator):
                     raise LanguageNotSupportedException(lang)
         return True
 
-    def translate(self, payload, **kwargs):
+    def translate(self, word, **kwargs):
 
-        url = "{}{}-{}/{}".format(self.__base_url, self._source, self._target, quote(payload))
-        response = requests.get(url)
-        soup = BeautifulSoup(response.text, 'html.parser')
-        elements = soup.findAll(self._element_tag, self._element_query)
-        if not elements:
-            raise ElementNotFoundInGetRequest(elements)
+        if self._validate_payload(word):
+            url = "{}{}-{}/{}".format(self.__base_url, self._source, self._target, quote(word))
+            response = requests.get(url)
+            soup = BeautifulSoup(response.text, 'html.parser')
+            elements = soup.findAll(self._element_tag, self._element_query)
+            if not elements:
+                raise ElementNotFoundInGetRequest(elements)
 
-        eof = []
-        for el in elements:
-            temp = ''
-            for e in el.findAll('a'):
-                if e.parent.name == 'div':
-                    if e and "/translate/{}-{}/".format(self._target, self._source) in e.get('href'):
-                        temp += e.get_text() + ' '
-            eof.append(temp)
+            eof = []
+            for el in elements:
+                temp = ''
+                for e in el.findAll('a'):
+                    if e.parent.name == 'div':
+                        if e and "/translate/{}-{}/".format(self._target, self._source) in e.get('href'):
+                            temp += e.get_text() + ' '
+                            if not kwargs.get('return_all'):
+                                return temp
+                eof.append(temp)
 
-        return [word for word in eof if word and len(word) > 1]
+            if 'return_all' in kwargs and kwargs.get('return_all'):
+                return [word for word in eof if word and len(word) > 1]
+
+    def translate_words(self, words, **kwargs):
+        if not words:
+            raise NotValidPayload(words)
+
+        translated_words = []
+        for word in words:
+            translated_words.append(self.translate(payload=word))
+        return translated_words
 
 
 if __name__ == '__main__':
-    # res = GoogleTranslator(source='auto', target='french').translate(payload="A paragraph is a series of related sentences developing a central idea, called the topic. Try to think about paragraphs in terms of thematic unity: a paragraph is a sentence or a group of sentences that supports one central, unified idea. Paragraphs add one idea at a time to your broader argument.")
+
     # res = GoogleTranslator(source='auto', target='french').translate_text(path='../examples/test.txt')
     # res = GoogleTranslator(source='auto', target='french').translate_sentences([
     #     "this is good",
     #     "das Wetter ist schön",
     #     "un verme verde in un bicchiere verde"
     # ])
-    res = PonsTranslator(source="english", target="arabic").translate(payload='good')
+    # res = PonsTranslator(source="en", target="ar").translate(payload='good')
+    res = PonsTranslator(source="en", target="ar").translate_words(words=('good', 'cute', 'angry'))
+
     print(res)

docs/usage.rst

@@ -2,9 +2,10 @@
 Usage
 =====
 
-To use deep_translator in a project::
 
-    from deep_translator import GoogleTranslator
+.. code-block:: python
+
+    from deep_translator import GoogleTranslator, PonsTranslator
 
     english_text = 'happy coding'
 
@@ -16,8 +17,9 @@ To use deep_translator in a project::
 
 
     # Alternatively, you can pass languages by their name:
-
     result_german = GoogleTranslator(source='english', target='german').translate(payload=english_text)
 
-    # soon also support for the PONS translator.
+    ###################### Use Pons as a translator  ###########################
+    word = 'good'
+    translated_word = PonsTranslator(source='english', target='french').translate(word)
 

setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.1.1
+current_version = 0.1.3
 commit = True
 tag = True
 

setup.py

@@ -51,6 +51,6 @@ setup(
     test_suite='tests',
     tests_require=test_requirements,
     url='https://github.com/nidhaloff/deep_translator',
-    version='0.1.2',
+    version='0.1.3',
     zip_safe=False,
 )