Sync from GitHub repo

.gitignore

@@ -49,4 +49,6 @@ Thumbs.db
 # Uploads
 static/temp_audio
 
-votes/
+votes/
+
+.claude

app.py

@@ -690,8 +690,8 @@ def generate_tts():
             "cache_hit": False,
         }
         
-        # Mark sentence as consumed for direct usage
-        mark_sentence_consumed(text, session_id=session_id, usage_type='direct')
+        # Don't mark as consumed yet - wait until vote is submitted to maintain security
+        # while allowing legitimate votes to count for ELO
 
         # Return audio file paths and session
         return jsonify(
@@ -827,13 +827,7 @@ def submit_vote():
     if error:
         return jsonify({"error": error}), 500
 
-    # Mark sentence as consumed AFTER successful vote recording (only for dataset sentences)
-    if vote and vote.sentence_origin == 'dataset' and vote.counts_for_public_leaderboard:
-        try:
-            mark_sentence_consumed(session_data["text"], session_id=session_id, usage_type='voted')
-            app.logger.info(f"Marked dataset sentence as consumed after vote: '{session_data['text'][:50]}...'")
-        except Exception as e:
-            app.logger.error(f"Error marking sentence as consumed after vote: {str(e)}")
+    # Sentence consumption is now handled within record_vote function
 
     # --- Save preference data ---
     try:
@@ -1134,14 +1128,7 @@ def submit_podcast_vote():
     if error:
         return jsonify({"error": error}), 500
 
-    # Mark sentence as consumed AFTER successful vote recording (only for dataset sentences)
-    # Note: Conversational votes typically use custom scripts, not dataset sentences
-    if vote and vote.sentence_origin == 'dataset' and vote.counts_for_public_leaderboard:
-        try:
-            mark_sentence_consumed(session_data["text"], session_id=session_id, usage_type='voted')
-            app.logger.info(f"Marked dataset sentence as consumed after conversational vote: '{session_data['text'][:50]}...'")
-        except Exception as e:
-            app.logger.error(f"Error marking sentence as consumed after conversational vote: {str(e)}")
+    # Sentence consumption is now handled within record_vote function
 
     # --- Save preference data ---\
     try:

models.py

@@ -243,8 +243,8 @@ def record_vote(user_id, text, chosen_model_id, rejected_model_id, model_type,
     
     if all_dataset_sentences and text in all_dataset_sentences:
         sentence_origin = 'dataset'
-        # Only count for public leaderboard if sentence was unconsumed when used
-        # Check if it was consumed BEFORE this vote (don't consume yet)
+        # For dataset sentences, check if already consumed to prevent fraud
+        # But now we'll mark as consumed AFTER successful vote recording
         counts_for_public = not is_sentence_consumed(text)
     else:
         sentence_origin = 'custom'
@@ -316,6 +316,15 @@ def record_vote(user_id, text, chosen_model_id, rejected_model_id, model_type,
     )
 
     db.session.add_all([chosen_history, rejected_history])
+    
+    # Mark sentence as consumed AFTER successful vote recording (only for dataset sentences that count)
+    if counts_for_public and sentence_origin == 'dataset':
+        try:
+            mark_sentence_consumed(text, usage_type='voted')
+        except Exception as e:
+            # If consumption marking fails, log but don't fail the vote
+            logging.error(f"Failed to mark sentence as consumed after vote: {str(e)}")
+    
     db.session.commit()
 
     return vote, None