fix: env variable defines whether fields autopopulated

- for the CI tests, the env variable is set too, so the tests pass
- next step requires tests updated to cope (visual tests can fill the
fields to simulate the user)

.github/workflows/python-pycov-onPR.yml

@@ -27,7 +27,7 @@ jobs:
       # note this will run all non-visual tests, including the slow end2end ones
       # - this action is only on PR; the slow ones are skipped on push.
       run: |
-        pytest -s -m "not visual" --ignore=tests/visual_selenium --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov=src tests/ | tee pytest-coverage.txt
+        DEBUG_AUTOPOPULATE_METADATA=True pytest -s -m "not visual" --ignore=tests/visual_selenium --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov=src tests/ | tee pytest-coverage.txt
         echo "working dir:" && pwd
         echo "files in cwd:" && ls -ltr
 

.github/workflows/python-pytest.yml

@@ -33,4 +33,7 @@ jobs:
     #    flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
     - name: Run quick tests with pytest
       run: |
-        pytest -m "not slow and not visual" --strict-markers --ignore=tests/visual_selenium
+        DEBUG_AUTOPOPULATE_METADATA=True pytest -m "not slow and not visual" --strict-markers --ignore=tests/visual_selenium
+      
+    # first pass: the visual tests that are looking for metadata to be populated already pass with this debug flag.
+    # todo: expand tests to enter the metadata, which will allow progress through the phases. 

.github/workflows/python-visualtests.yml

@@ -50,4 +50,6 @@ jobs:
       # we use --demo to make it slow enough (selenium doesn't wait long enough
       # otherwise, not one step it consistently fails at.)
       run: |
-            pytest -m "visual" --strict-markers tests/visual_selenium/ -s --demo
+            DEBUG_AUTOPOPULATE_METADATA=True pytest -m "visual" --strict-markers tests/visual_selenium/ -s --demo
+
+      # DEBUG_AUTOPOPULATE_METADATA=True streamlit run src/main.py

src/input/input_handling.py

@@ -2,6 +2,7 @@ from typing import List, Tuple
 import datetime
 import logging
 import hashlib
+import os
 
 import streamlit as st
 from streamlit.delta_generator import DeltaGenerator
@@ -23,15 +24,25 @@ both the UI elements (setup_input_UI) and the validation functions.
 '''
 allowed_image_types = ['jpg', 'jpeg', 'png', 'webp']
 
+def _is_str_true(v:str) -> bool:
+    ''' convert a string to boolean: if contains True or 1 (or yes), return True '''
+    # https://stackoverflow.com/questions/715417/converting-from-a-string-to-boolean-in-python
+    return v.lower() in ("yes", "true", "t", "1")
 # an arbitrary set of defaults so testing is less painful...
 # ideally we add in some randomization to the defaults
-spoof_metadata = {
-    "latitude": 0.5,
-    "longitude": 44,
-    "author_email": "[email protected]",
-    "date": None,
-    "time": None,
-}
+dbg_populate_metadata = _is_str_true( os.getenv("DEBUG_AUTOPOPULATE_METADATA", "False"))
+# the other main option would be argparse, where we can run `streamlit run src/main.py -- --debug` or similar
+# - I think env vars are simple and clean enough, it isn't really a CLI that we want to offer debug options, it is for dev.
+if dbg_populate_metadata:
+    spoof_metadata = {
+        "latitude": 0.5,
+        "longitude": 44,
+        "author_email": "[email protected]",
+        "date": None,
+        "time": None,
+    }
+else:
+    spoof_metadata = {}
 
 def check_inputs_are_set(empty_ok:bool=False, debug:bool=False) -> bool:
     """
@@ -190,10 +201,11 @@ def metadata_inputs_one_file(file:UploadedFile, image_hash:str, dbg_ix:int=0) ->
     msg = f"[D] {filename}: lat, lon from image metadata: {latitude0}, {longitude0}"
     m_logger.debug(msg)
     
-    if latitude0 is None: # get some default values if not found in exifdata
-        latitude0:float = spoof_metadata.get('latitude', 0) + dbg_ix
-    if longitude0 is None:
-        longitude0:float = spoof_metadata.get('longitude', 0) - dbg_ix
+    if spoof_metadata:
+        if latitude0 is None: # get some default values if not found in exifdata
+            latitude0:float = spoof_metadata.get('latitude', 0) + dbg_ix
+        if longitude0 is None:
+            longitude0:float = spoof_metadata.get('longitude', 0) - dbg_ix
         
     image = st.session_state.images.get(image_hash, None)
     # add the UI elements