Update app.py

app.py

@@ -72,6 +72,13 @@ GENRE_EXAMPLES = {
     ]
 }
 
+# 2. Add constants at the top for magic numbers
+MAX_HISTORY_LENGTH = 20
+MEMORY_WINDOW = 10
+MAX_TOKENS = 512
+TEMPERATURE = 0.7
+TOP_P = 0.95
+
 def get_examples_for_genre(genre):
     """Get example prompts specific to the selected genre"""
     return GENRE_EXAMPLES.get(genre, GENRE_EXAMPLES["fantasy"])
@@ -117,8 +124,20 @@ def format_history_for_gradio(history_tuples):
         messages.append({"role": "assistant", "content": bot_msg})
     return messages
 
-def respond(message, chat_history, genre=None, use_full_memory=True):
+# 1. Add type hints for better code maintainability
+# 4. Add input validation
+def respond(
+    message: str, 
+    chat_history: list[tuple[str, str]], 
+    genre: str | None = None,   # Make optional type more explicit
+    use_full_memory: bool = True
+) -> Generator[list[dict[str, str]], None, None]:   # More specific return type
     """Generate a response based on the current message and conversation history."""
+    if not message.strip():
+        return chat_history
+    if genre and genre not in GENRE_EXAMPLES:
+        genre = "fantasy"  # fallback to default
+
     system_message = get_enhanced_system_prompt(genre)
 
     # Convert your existing (user, bot) history into a format for the API request
@@ -131,17 +150,17 @@ def respond(message, chat_history, genre=None, use_full_memory=True):
     
     # Use full memory or partial memory
     if use_full_memory and formatted_history:
-        if len(formatted_history) > 20:
+        if len(formatted_history) > MAX_HISTORY_LENGTH:
             summary_instruction = create_story_summary(chat_history[:len(chat_history)-5])
             if summary_instruction:
                 api_messages.append(summary_instruction)
-            for msg in formatted_history[-10:]:
+            for msg in formatted_history[-MEMORY_WINDOW:]:
                 api_messages.append(msg)
         else:
             for msg in formatted_history:
                 api_messages.append(msg)
     else:
-        memory_length = 10
+        memory_length = MEMORY_WINDOW
         if formatted_history:
             for msg in formatted_history[-memory_length*2:]:
                 api_messages.append(msg)
@@ -160,10 +179,10 @@ def respond(message, chat_history, genre=None, use_full_memory=True):
     try:
         for response_chunk in client.chat_completion(
             api_messages,
-            max_tokens=512,
+            max_tokens=MAX_TOKENS,
             stream=True,
-            temperature=0.7,
-            top_p=0.95,
+            temperature=TEMPERATURE,
+            top_p=TOP_P,
         ):
             delta = response_chunk.choices[0].delta.content
             if delta: