Refactor submit_model function to handle task-specific logic and improve error messages

utils.py

@@ -46,9 +46,14 @@ def fetch_model_information(model_name):
 
 def submit_model(model_name, revision, precision, params, license, task):
     # Load existing evaluations
-    df_retrieval = load_retrieval_results()
+    if task == "Retriever":
+        df = load_retrieval_results()
+    elif task == "Reranker":
+        df = load_retrieval_results()
+    else:
+        return gr.Error(f"Error: Task '{task}' is not supported.")
     
-    existing_models_results = df_retrieval[['Model', 'Revision', 'Precision', "Task"]]
+    existing_models_results = df[['Model', 'Revision', 'Precision', 'Task']]
 
     # Handle 'Missing' precision
     if precision == 'Missing':
@@ -93,7 +98,7 @@ def submit_model(model_name, revision, precision, params, license, task):
         api.model_info(model_name)
     except Exception as e:
         print(f"Error fetching model info: {e}")
-        return gr.Error(f"**Error: Model '{model_name}' not found on HuggingFace Hub.**")
+        return gr.Error(f"Error: Model '{model_name}' not found on HuggingFace Hub.")
 
     # Proceed with submission
     status = "PENDING"
@@ -118,7 +123,7 @@ def submit_model(model_name, revision, precision, params, license, task):
         return "**Please enter the full model name including the organization or username, e.g., 'intfloat/multilingual-e5-large-instruct'**"
     org, model_id = org_model
     precision_str = precision if precision else 'Missing'
-    file_path_in_repo = f"pending/{org}/{model_id}_eval_request_{revision}_{precision_str}_{task}.json"
+    file_path_in_repo = f"pending/{org}/{model_id}_eval_request_{revision}_{precision_str}_{task.lower()}.json"
 
     # Upload the submission to the dataset repository
     try:
@@ -131,9 +136,10 @@ def submit_model(model_name, revision, precision, params, license, task):
             token=hf_api_token
         )
     except Exception as e:
-        return f"**Error: Could not submit the model. {str(e)}**"
+        print(f"Error uploading file: {e}")
+        return gr.Error(f"Error: Could not submit model '{model_name}' for evaluation.")
 
-    return f"**Model '{model_name}' has been submitted for evaluation.**"
+    return f"**Model '{model_name}' with revision '{revision}' and precision '{precision}' for task '{task}' has been submitted successfully.**"
 
 def load_requests(status_folder):
     api = HfApi()