Update app.py

app.py

@@ -135,9 +135,15 @@ def save_qa_history(history_entry):
     and configurable paths.
     """
     try:
-        # Save to local JSON file first
-        history_file = Path("qa_history.json")
+        # Get absolute paths
+        current_dir = Path.cwd()
+        history_file = current_dir / "qa_history.json"
+        repo_path = Path(os.getenv('GITHUB_REPO_PATH', ''))
         
+        if not repo_path.exists():
+            print(f"Repository path does not exist: {repo_path}")
+            return False
+            
         # Initialize or load existing history
         history_data = []
         if history_file.exists():
@@ -145,41 +151,46 @@ def save_qa_history(history_entry):
                 with open(history_file, "r", encoding="utf-8") as f:
                     history_data = json.load(f)
             except json.JSONDecodeError:
+                print("Error reading existing history file, starting fresh")
                 pass
         
-        # Append new entry if it's a list of entries
+        # Append new entries
         if isinstance(history_entry, list):
             history_data.extend(history_entry)
         else:
             history_data.append(history_entry)
         
-        # Save updated history locally
+        # Save locally first
         with open(history_file, "w", encoding="utf-8") as f:
             json.dump(history_data, f, ensure_ascii=False, indent=2)
         
-        # Try to push to GitHub if configured
+        # Copy file to repository if it's in a different location
+        repo_history_file = repo_path / "qa_history.json"
+        if history_file != repo_history_file:
+            import shutil
+            shutil.copy2(history_file, repo_history_file)
+        
+        # Git operations
         try:
-            repo_path = os.getenv('GITHUB_REPO_PATH') or st.secrets.get('GITHUB_REPO_PATH')
+            repo = Repo(repo_path)
+            repo.git.add(str(repo_history_file))
             
-            if repo_path and Path(repo_path).exists():
-                repo = Repo(repo_path)
-                repo.git.add(str(history_file.absolute()))
-                if repo.is_dirty():
-                    repo.index.commit("Update QA history")
-                    origin = repo.remote(name="origin")
-                    origin.push()
-                else:
-                    print("No changes to commit.")
+            if repo.is_dirty():
+                repo.index.commit("Update QA history")
+                origin = repo.remote('origin')
+                origin.push()
+                print("Successfully pushed to GitHub")
             else:
-                print("GitHub sync skipped - repository path not configured or doesn't exist")
+                print("No changes to commit")
+                
+            return True
                 
         except Exception as git_error:
-            print(f"GitHub sync failed (continuing without GitHub push): {str(git_error)}")
-            
-        return True
+            print(f"Git operation failed: {str(git_error)}")
+            return False
             
     except Exception as e:
-        print(f"Error saving QA history: {str(e)}")
+        print(f"Error in save_qa_history: {str(e)}")
         return False
 
 def add_to_qa_history(query: str, answer: str):
@@ -261,30 +272,49 @@ def initialize_github_sync():
     Returns True if GitHub sync is properly configured, False otherwise.
     """
     try:
-        repo_path = os.getenv('GITHUB_REPO_PATH') or st.secrets.get('GITHUB_REPO_PATH')
+        # Get repository path
+        repo_path = Path(os.getenv('GITHUB_REPO_PATH', ''))
         
-        if not repo_path:
-            print("GitHub repository path not configured")
-            return False
-            
-        repo_dir = Path(repo_path)
-        if not repo_dir.exists():
+        # Validate repository path
+        if not repo_path or not repo_path.exists():
             print(f"Repository directory does not exist: {repo_path}")
             return False
             
-        # Validate Git repository
         try:
-            repo = Repo(repo_dir)
-            # Check if remote 'origin' exists
-            if 'origin' not in [remote.name for remote in repo.remotes]:
-                print("Remote 'origin' not configured in repository")
+            # Initialize repository
+            repo = Repo(repo_path)
+            
+            # Ensure it's a valid git repository
+            if not repo.git_dir:
+                print("Invalid Git repository")
                 return False
-        except Exception as e:
-            print(f"Error validating Git repository: {str(e)}")
+                
+            # Check for origin remote
+            try:
+                origin = repo.remote('origin')
+                # Validate origin URL
+                if not origin.urls:
+                    print("Remote 'origin' has no URL configured")
+                    return False
+            except ValueError:
+                print("Remote 'origin' not found")
+                return False
+                
+            # Test Git operations
+            try:
+                # Test git status
+                repo.git.status()
+                # Test if we can get the current branch
+                repo.active_branch
+                return True
+            except Exception as git_error:
+                print(f"Git operations test failed: {str(git_error)}")
+                return False
+                
+        except Exception as repo_error:
+            print(f"Error validating Git repository: {str(repo_error)}")
             return False
             
-        return True
-        
     except Exception as e:
         print(f"Error initializing GitHub sync: {str(e)}")
         return False