Update app.py

app.py

@@ -44,6 +44,7 @@ def upload(files: Optional[List[str]], chatbot: CHAT_HISTORY) -> CHAT_HISTORY:
         image = Image.open(file).convert('RGB')
         image_preview = preprocess_image(image)
         if image_preview:
+            # Display a preview of the uploaded image
             gr.Image(image_preview).render()
         image_path = cache_pil_image(image)
         chatbot.append(((image_path,), None))
@@ -57,31 +58,29 @@ def user(text_prompt: str, chatbot: CHAT_HISTORY):
 def bot(
     files: Optional[List[str]],
     model_choice: str,
-    use_system_instruction: str,  # Controla si se usa la instrucción del sistema
-    system_instruction: str,     # Texto de la instrucción del sistema
+    system_instruction: Optional[str],  # Parámetro para la instrucción del sistema
     chatbot: CHAT_HISTORY
 ):
     if not GOOGLE_API_KEY:
         raise ValueError("GOOGLE_API_KEY is not set.")
 
+    # Configurar la API con la clave
     genai.configure(api_key=GOOGLE_API_KEY)
     generation_config = genai.types.GenerationConfig(
-        temperature=0.7,
-        max_output_tokens=8192,
-        top_k=10,
-        top_p=0.9
+        temperature=0.7,  # Valor predeterminado
+        max_output_tokens=8192,  # Fijar el límite de tokens a 8,192
+        top_k=10,  # Valor predeterminado
+        top_p=0.9   # Valor predeterminado
     )
 
     text_prompt = [chatbot[-1][0]] if chatbot and chatbot[-1][0] and isinstance(chatbot[-1][0], str) else []
     image_prompt = [preprocess_image(Image.open(file).convert('RGB')) for file in files] if files else []
-
-    # Considerar la instrucción del sistema solo si está activada
-    system_instruction_to_use = system_instruction if use_system_instruction == "Yes" else None
-
+    
+    # Crear el modelo con la instrucción del sistema si está definida
     model = genai.GenerativeModel(
         model_name=model_choice,
         generation_config=generation_config,
-        system_instruction=system_instruction_to_use  # Aplicar la instrucción si corresponde
+        system_instruction=system_instruction if system_instruction else None
     )
 
     response = model.generate_content(text_prompt + image_prompt, stream=True, generation_config=generation_config)
@@ -94,10 +93,30 @@ def bot(
             time.sleep(0.01)
             yield chatbot
 
+# Componente para ingresar la instrucción del sistema
+system_instruction_component = gr.Textbox(
+    placeholder="Enter system instruction...", 
+    show_label=True, 
+    scale=8,
+    visible=False  # Por defecto no visible
+)
+
+def toggle_system_instruction(system_instruction_active: bool):
+    return gr.update(visible=system_instruction_active)
+
 # Definir los componentes de entrada y salida
-chatbot_component = gr.Chatbot(label='Gemini', bubble_full_width=False, scale=2, height=300)
-text_prompt_component = gr.Textbox(placeholder="Message...", show_label=False, autofocus=True, scale=8)
-upload_button_component = gr.UploadButton(label="Upload Images", file_count="multiple", file_types=["image"], scale=1)
+chatbot_component = gr.Chatbot(
+    label='Gemini',
+    bubble_full_width=False,
+    scale=2,
+    height=250
+)
+text_prompt_component = gr.Textbox(
+    placeholder="Message...", show_label=False, autofocus=True, scale=8
+)
+upload_button_component = gr.UploadButton(
+    label="Upload Images", file_count="multiple", file_types=["image"], scale=1
+)
 run_button_component = gr.Button(value="Run", variant="primary", scale=1)
 model_choice_component = gr.Dropdown(
     choices=["gemini-1.5-flash", "gemini-2.0-flash-exp", "gemini-1.5-pro"],
@@ -105,29 +124,21 @@ model_choice_component = gr.Dropdown(
     label="Select Model",
     scale=2
 )
-use_system_instruction_component = gr.Dropdown(
-    choices=["Yes", "No"],
-    value="No",
-    label="Use System Instruction",
+system_instruction_toggle = gr.Checkbox(
+    label="Enable System Instruction",
+    value=False,
     scale=1
 )
-system_instruction_component = gr.Textbox(
-    placeholder="Enter system instruction...",
-    show_label=True,
-    scale=8,
-    visible=False  # Oculto inicialmente
-)
 
-# Función para actualizar la visibilidad del campo de instrucción
-def toggle_system_instruction(use_system_instruction: str):
-    return gr.update(visible=(use_system_instruction == "Yes"))
+user_inputs = [
+    text_prompt_component,
+    chatbot_component
+]
 
-user_inputs = [text_prompt_component, chatbot_component]
 bot_inputs = [
     upload_button_component,
-    model_choice_component,
-    use_system_instruction_component,
-    system_instruction_component,
+    model_choice_component,  # El campo de modelo está ahora arriba
+    system_instruction_component,  # Instrucción del sistema sigue siendo separada
     chatbot_component
 ]
 
@@ -136,30 +147,28 @@ with gr.Blocks() as demo:
     gr.HTML(TITLE)
     gr.HTML(SUBTITLE)
     with gr.Column():
+        # Campo de selección de modelo arriba
         model_choice_component.render()
         chatbot_component.render()
         with gr.Row():
             text_prompt_component.render()
             upload_button_component.render()
             run_button_component.render()
-        use_system_instruction_component.render()
+        system_instruction_toggle.render()
+        system_instruction_toggle.change(
+            fn=toggle_system_instruction,
+            inputs=[system_instruction_toggle],
+            outputs=[system_instruction_component]
+        )
         system_instruction_component.render()
 
-    use_system_instruction_component.change(
-        fn=toggle_system_instruction,
-        inputs=[use_system_instruction_component],
-        outputs=[system_instruction_component]
-    )
-
     run_button_component.click(
         fn=user,
         inputs=user_inputs,
         outputs=[text_prompt_component, chatbot_component],
         queue=False
     ).then(
-        fn=bot,
-        inputs=bot_inputs,
-        outputs=[chatbot_component],
+        fn=bot, inputs=bot_inputs, outputs=[chatbot_component],
     )
 
     text_prompt_component.submit(
@@ -168,9 +177,7 @@ with gr.Blocks() as demo:
         outputs=[text_prompt_component, chatbot_component],
         queue=False
     ).then(
-        fn=bot,
-        inputs=bot_inputs,
-        outputs=[chatbot_component],
+        fn=bot, inputs=bot_inputs, outputs=[chatbot_component],
     )
 
     upload_button_component.upload(