Title: Change the pop-up text for "favorite question" tooltip
Tags: feature-request;bookmarks;tooltips
Question: Please do not duplicate this for one of the similar bug report or discussion questions, which only ask "why" it is like this or state "it should not be" like this.
I am proposing an actual idea to change it (feature-request).  

(TL;DR; further below for those who know the issue)  



The current message when hovering the tooltip:  

```
  This is a favorite question (click again to undo)  
```

The message is one of the states regardless

Currently, whether the question is a favorite or not, it states exactly the same message (as above).
This could be fine if the message was different, but the current message is one of the actual states of the tooltip.  

So if it is a favorite then the message is fine as it states "this is a favorite", but if it's not a favorite then the message is telling me it is the opposite potential state to what it actually is.  

This really is confusing, and while it's not exactly an admin control area button, I just think it's illogical enough to warrant a change. 

Someone's telling porkies

It is not a favorite question, I do not have any favorite pgarcia@example.org.
This is even confirmed to me in my profile:  

```
  You have no favorite questions  
```

The is confusing, because my profile states that I have no favorites but when on a question I'm told by a tooltip pop-up message that I do have a favorite.  

In fact, if I were to believe the tooltip message, every single question on every Stack site would be a favorite...  

```
  "I'm not upset that you lied to me, I'm upset that from now on I can't
  believe you."
   - Friedrich Nietzsche
```

Undo that which has not been done

I cannot "(click again to undo)" because I never did it in the first place.  

```
  undo  
  
  To reverse the doing of; cause to be as if never done:
```

I cannot reverse the doing of something I have not done.
I cannot cause to be as if never done because it has already not has been never done (I didn't do it yet).  



TL;DR;

A Simple Change

So, I am proposing to simply change the static text to something more logical, such as .  

```
  Click to toggle favorite on or off  
```

It's still not perfect given the amazingly worded functionality the site otherwise offers, but at least it's generic and not one of the possible states.  

Also the visual state confirms it a bit, as when a question "is favorite" the star is gold, and when "not favorite" it's grey and offy looking (I know this is in play with the current message, but it still has an incorrect message).  

(Although.. the HTML anchor's CSS class does currently change based on state -"not favorite" is ```class="star-off"```, and "is favorite" is ```class="star-off star-on"```, so something in the scripts already knows the state change, how hard would it be to... no, no, simple request James..).  



Please implement this and I won't mention that "favourite" is also misspelled...  



Here is another answer: The question I asked about this gave me the answer that it is telling you:
```
The tooltip is telling you in what situation to click the star (&quot;This is a favorite question&quot;).
It is also telling you that this can be undone (&quot;(click again to undo)&quot;).
```
Now, that makes sense - but it is not consistent with other buttons on SE.
The 'accept answer' button says (emphasis mine):
```
Click to accept this answer because it solved your problem or was the most helpful in finding your solution (click again to undo) when unclicked
Click to undo acceptance of this answer; you accepted this answer [DATE]  when clicked
```
That's the simplest solution to this (and to make it more consistent with the site) is, add 'Click to' to the message and change the message again when it has been clicked. ie (in bold and italics is the change, the 'optionally' is optional ;):
```
Click to make Tthis is a favorite question (click again to undo)  when unclicked 
Click to remove this from your favorites (optionally); you added this as a favorite on [DATE] when clicked;
```
It should, as you said, be easy to implement this - because you already know when the state changes - so you can just change the message depending on what class the button has!

Another option is to follow the voting symbols which simply say:
```
This question shows research effort; it is useful and clear when unclicked
This question shows research effort; it is useful and clear (click again to undo)when clicked
```
So, just make it:
```
Make Tthis is a favorite question when unclicked 
Make Tthis is a favorite question (click again to undo) when unclicked 
```


{'source': 'StackExchangeDataset', 'subset': 'meta.stackexchange.com', 'metadata': {'AnswerCount': 1, 'CommentCount': 0, 'ContentLicense': 'CC BY-SA 3.0', 'CreationDate': '2015:00:04/13/15', 'FavoriteCount': None, 'PostTypeId': 1, 'Tags': '<feature-request><bookmarks><tooltips>', 'Title': 'Change the pop-up text for "favorite question" tooltip', 'ViewCount': 50, 'id': 253242, 'user_AboutMe': '', 'user_AccountId': 3110201.0, 'user_DisplayName': 'James', 'user_Reputation': 20468.0, 'user_Views': 1253.0, 'user_id': 230506.0}}