<NME> policy.py
<BEF> # Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.

from oslo_log import versionutils
from oslo_policy import policy

from keystone.common.policies import base

    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'get_policy',
        check_str=base.RULE_ADMIN_REQUIRED,
        description='Show policy details.',
        operations=[{'path': '/v3/policy/{policy_id}',
                     'method': 'GET'}]),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'list_policies',
        check_str=base.RULE_ADMIN_REQUIRED,
        description='List policies.',
        operations=[{'path': '/v3/policies',
                     'method': 'GET'}]),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'create_policy',
        check_str=base.RULE_ADMIN_REQUIRED,
        description='Create policy.',
        operations=[{'path': '/v3/policies',
                     'method': 'POST'}]),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'update_policy',
        check_str=base.RULE_ADMIN_REQUIRED,
        description='Update policy.',
        operations=[{'path': '/v3/policies/{policy_id}',
                     'method': 'PATCH'}]),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'delete_policy',
        check_str=base.RULE_ADMIN_REQUIRED,
        description='Delete policy.',
        operations=[{'path': '/v3/policies/{policy_id}',
                     'method': 'DELETE'}])
)


policy_policies = [
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'get_policy',
        check_str=base.SYSTEM_READER,
        # This API isn't really exposed to usable, it's actually deprecated.
        # More-or-less adding scope_types to be consistent with other policies.
        scope_types=['system'],
        description='Show policy details.',
        operations=[{'path': '/v3/policies/{policy_id}',
                     'method': 'GET'}],
        deprecated_rule=deprecated_get_policy),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'list_policies',
        check_str=base.SYSTEM_READER,
        scope_types=['system'],
        description='List policies.',
        operations=[{'path': '/v3/policies',
                     'method': 'GET'}],
        deprecated_rule=deprecated_list_policies),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'create_policy',
        check_str=base.SYSTEM_ADMIN,
        scope_types=['system'],
        description='Create policy.',
        operations=[{'path': '/v3/policies',
                     'method': 'POST'}],
        deprecated_rule=deprecated_create_policy),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'update_policy',
        check_str=base.SYSTEM_ADMIN,
        scope_types=['system'],
        description='Update policy.',
        operations=[{'path': '/v3/policies/{policy_id}',
                     'method': 'PATCH'}],
        deprecated_rule=deprecated_update_policy),
    policy.DocumentedRuleDefault(
        name=base.IDENTITY % 'delete_policy',
        check_str=base.SYSTEM_ADMIN,
        scope_types=['system'],
        description='Delete policy.',
        operations=[{'path': '/v3/policies/{policy_id}',
                     'method': 'DELETE'}],
        deprecated_rule=deprecated_delete_policy)
]


def list_rules():
    return policy_policies

<MSG> Add scope_types for policy policies

This commit adds `system` to the list of scope types for all policy
policies. Policies aren't really used and should be considered
system-level until authorization can be done without having to modify
service policy files.

From now on, a warning will be logged when a project-scoped token is
used for policy management. Operators can opt into requiring
system-scoped tokens for these policies by enabling oslo.policy's
`enforce_scope` configuration option.

Change-Id: I1542a78f66817ac9b36ec26c308aca08e3c23af7

<DFF> @@ -18,30 +18,37 @@ policy_policies = [
     policy.DocumentedRuleDefault(
         name=base.IDENTITY % 'get_policy',
         check_str=base.RULE_ADMIN_REQUIRED,
+        # This API isn't really exposed to usable, it's actually deprecated.
+        # More-or-less adding scope_types to be consistent with other policies.
+        scope_types=['system'],
         description='Show policy details.',
         operations=[{'path': '/v3/policy/{policy_id}',
                      'method': 'GET'}]),
     policy.DocumentedRuleDefault(
         name=base.IDENTITY % 'list_policies',
         check_str=base.RULE_ADMIN_REQUIRED,
+        scope_types=['system'],
         description='List policies.',
         operations=[{'path': '/v3/policies',
                      'method': 'GET'}]),
     policy.DocumentedRuleDefault(
         name=base.IDENTITY % 'create_policy',
         check_str=base.RULE_ADMIN_REQUIRED,
+        scope_types=['system'],
         description='Create policy.',
         operations=[{'path': '/v3/policies',
                      'method': 'POST'}]),
     policy.DocumentedRuleDefault(
         name=base.IDENTITY % 'update_policy',
         check_str=base.RULE_ADMIN_REQUIRED,
+        scope_types=['system'],
         description='Update policy.',
         operations=[{'path': '/v3/policies/{policy_id}',
                      'method': 'PATCH'}]),
     policy.DocumentedRuleDefault(
         name=base.IDENTITY % 'delete_policy',
         check_str=base.RULE_ADMIN_REQUIRED,
+        scope_types=['system'],
         description='Delete policy.',
         operations=[{'path': '/v3/policies/{policy_id}',
                      'method': 'DELETE'}])

{'addition_count': 7, 'commit_subject': 'Add scope_types for policy policies', 'deletion_count': 0, 'file_extension': '.py', 'lang': 'py', 'license': 'apache-2.0', 'repo_name': 'openstack/keystone'}