#juju-gui 2013-09-01 <hatch> ahoy <rick_h> party hatch <hatch> rick_h: hey u in the hotel? <rick_h> hatch: yep, just back from the grocery store <rick_h> needed some viddles, this whole 'travel through the night' thing confuses the schedule <hatch> cool, I gotta find me a SIM , everyone I found didn't have one for my phone :/ <rick_h> hatch: :( I got lucky and got one at the airport terminal. <3 <hatch> haha I've been awake for 27 hours so far <rick_h> hatch: hit up the guys down stairs. They make a big deal of the 'ask me anything' guys at the hotel <rick_h> hatch: let me know if you need company and maps. I've got the mifi loaded up for the week <hatch> cool will do, I dug the 'check yourself in' thing <rick_h> yea, cool <hatch> yeah we should meet up for supper <rick_h> hatch: definitely #juju-gui 2013-09-02 <rick_h> Makyo: http://paste.mitechie.com/show/1015/ <Makyo> http://www.youtube.com/watch?v=gxpfroru1To <rick_h> jujugui can I get a review/qa please? https://codereview.appspot.com/13469043 <Makyo> jujugui https://codereview.appspot.com/13335048 requesting two reviews please <Makyo> +IE10 QA <bac> jujugui: re-enabling updates on comingsoon <rick_h> bac: cool thanks #juju-gui 2013-09-03 <huwshimi> luca__: http://669-615-7011:2464/ <hatch> rick_h, done <rick_h> hatch: woot! <rick_h> .c <hatch> Makyo, qa'ing now <frankban> bcsaller: https://codereview.appspot.com/13309044 thanks! <huwshimi> rick_h: What's the nose package I need to install to be able to run single tests? <rick_h> huwshimi: https://pypi.python.org/pypi/nose-selecttests/0.4 <huwshimi> rick_h: Cheers <rick_h> huwshimi: so you can bin/pip install nose-selecttests and then you can run tests with -t XXXXX <rick_h> Makyo: https://codereview.appspot.com/13441046/ <Makyo> bcsaller, I landed your test fix as part of this branch, since my last one broke ci <bcsaller> ahh, ok, I merged trunk and didn't see it so I did finally propose <Makyo> Still lboxing :) <abentley> orangesquad, bac or benji: Could you please review https://code.launchpad.net/~abentley/charmworld/use-latest-charm/+merge/183661 ? * sinzui looks <benji> wow, fast on the trigger this morning <abentley> benji: <abentley> benji: Was basically done on Friday. <sinzui> abentley, r=me <rick_h> curses, no IE love https://developer.mozilla.org/en-US/docs/WebAPI/Using_Web_Notifications <jcsackett> orangesquad: i have returned from having my stitches taken out. sinzui, i'll be free for our normal 1x1 time. <sinzui> jcsackett, orangesquad: let's hangout in 9 minutes to do some orienteering <abentley> sinzui: +1 <sinzui> jcsackett, adeuring https://plus.google.com/hangouts/_/538341c5065bcf63afe4dfc783cbb34db8a826b1?hl=en <jcsackett> sinzui: thanks; fighting G+ <abentley> sinzui, abel: Test runs used to take 4 minutes. Now, they take 3 hours: https://jenkins.qa.ubuntu.com/job/charmworld-merger-trunk/buildTimeTrend <sinzui> abentley, adeuring Lp's test runs take 35 minutes. I think we need to save face and make runs fast again <adeuring> sinzui: agreed... <jcastro> hey guys <jcastro> any word on when we'll have more readable URLs land? <rick_h> jcastro: ummm...not at the moment. <jcastro> ugh, this sucks <jcastro> ok then, I'm going to use the github URLs! <frankban> hatch: https://ec2-54-226-194-198.compute-1.amazonaws.com/:flags:/serviceInspector/ <rick_h> jujugui review please? https://codereview.appspot.com/13443044 <bcsaller> hatch: when you have a minute can you look to see if you think I missed any topics in https://codereview.appspot.com/13415045 <abentley> sinzui: I think we could avoid Tarmac by using this: https://wiki.jenkins-ci.org/display/JENKINS/URLTrigger+Plugin <sinzui> Yummy <benji> call? <bac> benji: i'm here <benji> bac: what you talking about, Willis? <bac> jujugui: are sprinters going to participate in our daily call? <bac> benji: i mean, i'm here and willing to have a call <benji> oh <benji> I thought you were saying you were on the call already <bac> no sir <bcsaller> we are really busy trying to push back on having to do work ;) <rick_h> bac: benji gary says yes we'll do a hangout shortly and will update <rick_h> hangout url will be offered in the near future? <bcsaller> hatch: I did send you a link before <bac> rick_h: eta on "shortly"? this hour? <rick_h> bac: I *think* so <rick_h> bac: I interrupted his current conversation to bring this up and he said yes, he wants to chat and will send a url <rick_h> but no specific timeline given atm <bcsaller> rick_h: https://codereview.appspot.com/12323043/ has the instructions you wanted <bac> benji: i'm getting F and E in trunk tests. :( <benji> :( <bac> adeuring: benji and i notice 'make test' on charmworld is insanely slow. is that a result of your es test fixes perhaps? <adeuring> bac: I'm afraid so :( <benji> bac: I made wait_for_green_status a noop and my subset of the tests went from 186 seconds to 6 seconds. <adeuring> It's hard t <adeuring> pproblem for me right now is that the tests a _cirrently_ fast again <adeuring> without any apparent related change... <bac> benji: i did the same and ran 'make test' in trunk resulting in <bac> Ran 721 tests in 53.682s <bac> FAILED (errors=19, failures=6) <bac> adeuring: with trunk my tests ran for 10 minutes and didn't get past the first line of dots <adeuring> crazy... abentley suggested to s/green/yellw/ in ElasticSearchLient.wait_for_green_status(). That might help butmight reintroduce the previous psurious failures... <benji> bac: have time for a review? https://code.launchpad.net/~benji/charmworld/bundle-feature-ui/+merge/183709 <bac> benji: sure <benji> bac: I assume its just you and me on charmworld now, right? <benji> (after the orange guys finish up any branches they are working on) <bac> benji: yeah. glad we don't require two reviews <benji> heh <bac> abentley, sinzui: in the wait_for_green method, we're passing a timeout to client.health as an integer. the docs for es looks like it wants a string that includes units, e.g. '30s'. does the python client convert those? it doesn't look like it to me. <sinzui> bac: timeout â Number of seconds to wait for each request before raising Timeout <sinzui> http://pyelasticsearch.readthedocs.org/en/latest/api/#module-pyelasticsearch <sinzui> bac: abentley oh, but I see that some methods do want a string like '5m' <sinzui> I think you are correct bac. The health check wants a string with units <bac> sinzui: thanks for the link to docs! i hadn't found them before. <bac> sinzui: even if i wanted an integer, those docs say 'number of seconds'. it looks like our code thinks it is milliseconds. <bac> i.e. the default is 30,000 <sinzui> We have created a very patient test suite <bac> sinzui: but we have impatient developers <bac> oi, bin/es-update takes forever now too <bac> benji: how do i see your new page? <benji> bac: you have to go to a URL like /bundles/wiki-bundle/wiki/featured/edit <benji> as far as I can tell there is no way to click through to a charm featured edit page so I didn't make a way to do it for bundles either <bac> benji: so it has to be promulgated? <gary_poster> bac, benji, hey. I'm sorry I missed the call. Do you want to have a quick call now to catch up, or talk tomorrow? <bac> gary_poster: i'm free to talk now, if you have time. <benji> bac: yep; that is the same as for charms (only promulgated charms can be featured) <bac> benji: so do you have test data? i've just been loading the two bundles from LP and neither are promulgated <benji> bac: I did the same and it worked for me; maybe my understanding of how it works is flawed <benji> gary_poster: I had just started lunch. I don't think I have anything significant to discuss. <bac> benji: when i try to go to http://669-615-7011:2464/charms/precise/apache2-passenger/featured/edit i get 403 - Forbidden <bac> when i try to login i get 'resource not found.' <bac> benji: when you're back from lunch we should talk <gary_poster> bac, benji, I don't know if you replied: the network kicked my off almost immediately after saying hi to you :-P <gary_poster> sorry <bac> gary_poster: we said we'd be glad to talk to you tomorrow since it is so late over there and benji is eating lunch. <gary_poster> bac, cool, thanks. :-) talk you you tomorrow, then <bac> gary_poster: he and i are talking amongst ourselves frequently and don't have much to say <gary_poster> ok cool bac. I wanted to let you know what is going on here <gary_poster> so will talk tomorrow <bac> gary_poster: ok, have a good evening. <gary_poster> thanks, have a nice afternoon! <gary_poster> bye <abentley> sinzui: my critical bugfixes have landed. I would like to do a release. Is it safe to do that? <sinzui> abentley, it is <benji> bac: I'm back <abentley> jcastro m_3 marcoceppi: I believe the issues you reported Friday are all fixed. <abentley> Well, the ones I was working on. I don't know what other issues you might have reported :-) <jcastro> abentley: which issue? <jcastro> oh, the rack/rails one? <abentley> jcastro: Yes. <abentley> sinzui, benji, bac: I've deployed r377 to production. <benji> k <sinzui> thank you abentley <bac> benji: sorry i had to run an errand <benji> no worries <bac> benji: guichat? <benji> sure <abentley> sinzui: I am setting up a jenkins instance, and trying to run the test suite, but it is not installing pip. Any ideas? http://669-615-7011:8080/job/Test%20charmworld/ws/bin/ * sinzui thinks <bac> benji: when you resolve your conflicts be sure to import pymongo into helpers <sinzui> abentley, check the charm. I think there was a hack for pip...well maybe to install a specific pip lib * sinzui visits a meeting <abentley> sinzui: pip is installed on the host, and the only reference to pip in the charm is a one-liner in config-changed that uses pip. <sinzui> abentley, I have pip installed as /usr/bin/pip not /bin/pip <sinzui> oh, but this in our tree <abentley> sinzui: I have both. <bac> benji: try this: http://staging.jujucharms.com/login/openid <bac> abentley, sinzui: we have a problem: http://manage.jujucharms.com/login/openid gives a 404. any idea what might've caused this problem? <sinzui> bac: no, but I see staging is also affected <abentley> sinzui: I wonder if it's related to your routes work? <benji> bac: hmm, that's not good <bac> abentley, sinzui: i'm trying r372, before sinzui's branch <sinzui> bac, abentley, benji, surely this is caused by my URL changes to support juju-gui promulgated charms <bac> 372 works <bac> 373 breaks <abentley> bac: confirmed. <sinzui> bac Since login can happen against anything, we might need to specify series or "login" specifically <sinzui> bac: we don't have a route for login, only logout. So routing's promulgated charm rule will always win <sinzui> bac, we can bac my rev out, remove "# Unnamespaced promulgated charms" from routing, add routing for login add a factory/custom_predicate that knows charm series <bac> sinzui: how does login work in the absence of the promulgated charm routing rules? <bac> sinzui: is there a default that it hits? <sinzui> I was just going to read how it works <bac> sinzui: so there is an 'add_ubuntu_sso' after the routing is built. i guess that adds a default <sinzui> bac, I see, and it is always last :( <bac> sinzui: but it looks like that call can be made in routes.py before the promulgated <sinzui> bac, I agree. I don't know why it wasn't done like that. Maybe charmworld was intended to be separate <bac> http://paste.ubuntu.com/6060075/ <bac> sinzui: i think that may work but i don't have any promulgated charms in my test data to see if that routing still works <bac> sinzui: did you add test coverage for those routes? <bac> not that our tests work or anything <sinzui> bac, I certainly did! <bac> \o/ <sinzui> bac, login is from the first week we joined the project. * sinzui find children <abentley> I guess I just assumed that the last thing you add would have the highest priority. <sinzui> abentley, I think the order of registration is the order of matching. I had to move rules when adding the new urls to not collide with historic urls <sinzui> bac, did you tell charmers that they cannot qa/feature any charms at the moment? <bac> sinzui: i did not <bac> sinzui: i'm been caught up trying to get a fix <sinzui> I will tell them, Thy might no ever know since featuring and QA is a rare activity <bac> sinzui: you will send an email to juju or to ~charmers directly? <sinzui> bac charmers is a highlight word in #juju. <bac> benji: could you review and QA/test https://code.launchpad.net/~bac/charmworld/fix-login/+merge/183757 <benji> bac: sure <bac> sinzui: if you could glance at ^^^ that would be nice too. <sinzui> sure <benji> bac: <benji> The branch looks good and QA passed. <benji> Reply <benji> s/Reply// <bac> benji: cool. did you try http://669-615-7011:2464/precise/bonnie ? (it passes) <benji> nope, I did apache <benji> bonnie looks fine too <bac> benji: and all of the tests passed? <benji> bac: oh, I forgot the tests (I'm really not feeling well all of a sudden). Startin gth etests now. <bac> benji: when that lands and is merged i can QA your branch. <benji> bac: I didn't comment out the slow function, should I have? <bac> benji: don't know. nothing works on my vm <sinzui> bac, can't you change the tests to wait for yellow? <bac> sinzui: didn't help <benji> the tests are slowly passing, so I'll give them some time <bac> sinzui: my VM seems to be pathological wrt these timeouts <sinzui> egads! <bac> benji: in the good old days of say r370, how long did it take 'make test' to run on your machine? <bac> mine was always about 74 seconds <benji> I don't know exactly, but not much more than a minute. <bac> yeah, so clock time mine isn't that slow. i'm not sure why it causes the es stuff to go nuts <m_3> abentley: thanks!! <m_3> I'll test it this afternoon <bac> benji: i also have this review stagnating: https://code.launchpad.net/~bac/charmworld/bundle-icon/+merge/183730 <benji> bac: looking <bac> benji: did the tests ever finish? <benji> still running <bac> oi goi oi <benji> bac: sorry, I don't have the mental accuity to understand that branch right now; the only thing I can think right now is that I'm surprised that much code is needed bceause we are already storing all the bundle's file at ingest time <bac> benji: they werent' being put into gridfs <bac> benji: but it can wait until tomorrow. <benji> thanks <benji> there are about 100 dots thus far <benji> (no errors or failures) <benji> bac: tests still running; I bet it takes 20 more minutes; I'll tell you when it finishes <bac> sinzui: do you think it wise to try to push this branch to production tonight? i'm unsure about webop coverage. <sinzui> I can <bac> sinzui: i'd like to shepherd it if you think it is feasible. <bac> sinzui: gotta get it tested, landed, and on staging first <benji> 200 dots or so <bac> sinzui: after changing green to yellow i got <bac> Ran 724 tests in 105.753s <bac> FAILED (errors=7, failures=4) <bac> benji: fwiw, i stopped elasticsearch, removed the storage in /var/lib/elasticsearch, and restarted it. my test sped up a lot. <sinzui> yuck <sinzui> bac, I will have time to run your branch in about 10 minutes <benji> bac: do you want me to try that or let this run finish? <bac> benji: how many dots to go? <bac> benji: and there are no failures yet? <benji> bac: no failures, 220 dots; I don't know how many are left <bac> oi. well 724 tests. <benji> yow <benji> ok, I'm trying the speedup <benji> bac: I don't think this is any faster. I'm giving up. I vote you merge your branch as-is and you and I work on the test issue as critical in the morning. <bac> benji: ok. <bac> benji: have a good night <benji> thanks <bac> sinzui: how often does tarmac run? my branch was approved 31 minutes ago but has not merged <sinzui> bac. every 10/15 minutes, but as abentley noted in the channel, Jenkins takes 3h to run the test suite <bac> sinzui: oh, my <bac> sinzui: sorry i missed that comment <sinzui> I favour rolling back adeuring's changes. It takes too long to respond to a real problem...Lp's test suite takes 35 minutes...thank you former yellow squad <bac> sinzui: i'll do that tomorrow <bac> it is insane #juju-gui 2013-09-04 <rick_h> Makyo: http://jsbin.com/ENIbojO/1/ checking console logs <gary_poster> rick_h, http://www.tasrestaurants.co.uk/pide.html <antdillon> gary_poster, Do you by any chance have admin rights for juju.ubuntu.com? <gary_poster> no, sorry antdillon <antdillon> gary_poster, Thanks <gary_poster> ...for nothing ;-) <bac> adeuring: the wait_for_green effort is not workable. jenkins is taking over 3 hours to test and land branches. sinzui and i decided it is best for now to revert your branch. would you have time to prepare a rollback branch and propose it? <adeuring> bac: yes, though "yellow" will help only partially. I think I have meanwhile an idea what is wrong: the core setup. /etc/elasticsearch/elasticsearch.yml allows to set the parameters number_of_replicas and number_of_shards. The default is 5 and 1, respectively, and at least our dev environment has no replicas... <adeuring> Using the value 1 and zero helps. <adeuring> But I'd like to set this in create_index(), but xould not yet figure out the right parameters... <huwshimi> luca__: Icons required: eye, spanner, cog (plus hover states if applicable) and trash can. <adeuring> bac: can you have a look here https://code.launchpad.net/~adeuring/charmworld/set_n_replicas_and_shards/+merge/183846 (and please test the branch too ;) <hatch> http://askubuntu.com/questions/73589/higher-screen-resolution-for-virtualbox <huwshimi> jujugui: Can I have a review of my inspector changes? https://codereview.appspot.com/13521043/ <bac> adeuring: i ran your new branch and got: <bac> Ran 726 tests in 88.575s <bac> FAILED (errors=7, failures=4) <bac> so it is faster <adeuring> bac: great. Can you show me the errors? <bac> adeuring: many refer to es client not having 'multi_get'. http://paste.ubuntu.com/6062400/ <adeuring> bac: thanks. <adeuring> bac: WHich version of pyelasticsearch is installed on your machine? It's 0.6 on my machine and multgi_get is defined there. <bac> adeuring: it is installed by charmworld setup in the venv. requirements.txt:pyelasticsearch==0.6 <adeuring> weird... <bac> i do not have it installed in my system python <adeuring> bac: right; but it is strange that class ElasticSearch defines a method multi_get() and we get a failure like this AttributeError... I'm just trying to figure out how this can happen <bac> adeuring: i'll drop into pdb and see if i can figure it out <Makyo> rick_h, https://gist.github.com/makyo/6436215 <benji> back and adeuring: let me know if there is anything I can do <adeuring> benji: I am really puzlled by most of these errors: http://paste.ubuntu.com/6062400/ If you can reproduce them (using lp:~adeuring/charmworld/set_n_replicas_and_shards) and try to figure out what's causing them -- that would be great. <benji> adeuring: I'll see if I can repro <adeuring> thanks <adeuring> be, bac: The last error (in test_search_charm_sort_newest) looks familiar. I think it is caused by search() not using any yorting by defualt. <Makyo> hatch, huwshimi http://www.popvssoda.com/ <bac> adeuring: turns out my pyelasticsearch was still 0.4.1. i didn't do a 'make deps' after it got upgraded <adeuring> bac, benji: ah, that explains a few problems ;) <benji> ooh <benji> deps really should be a dependency of install <benji> adeuring: after a "make deps" I only get one failure: http://paste.ubuntu.com/6062493/ <adeuring> benji: cool. can you reproduce this eror more or less reliably? In that case, could you try to add index_client.wait_for-green_status() before the get_:mapping() call in this test? <benji> I'm doing a second run now to see. If so I'll add that call and see. <bac> adeuring, benji: running abel's branch i get only one failure http://paste.ubuntu.com/6062553/ <bac> different from benji's <benji> heh <benji> and my tests are still slow :( <bac> that test fails in isolation? <adeuring> bac: sounds great. I think we need a better test setup here. I can this error too occasionally... I believe that api_search() does not specify any sort order by default. <bac> benji: still slow? huh. mine are at 100s or so <benji> bac: I haven't checked that one <bac> adeuring, benji: also, i have a simple fix to the openid log pollution in the test output <benji> after a "make distclean"... wait! I was running in the wrong darn branch <adeuring> benji: did you try to restart the ES server? <benji> bac and adeuring: ooh, and I noticed that I have two failures, not one. And the one I missed is the same bac had * benji needs to go for a mind-clearing jog or something. <adeuring> benji: I'll look into this "sort issue" <benji> bac and adeuring: I get bac's failure when I run that test in isolation <bac> adeuring: would you have a look at lp:~bac/charmworld/timeout-values ? reviewing the documentation it seems for the health checks the timeout values should be strings * adeuring is looking <bac> jcsackett: do you know if sinzui is in today? <bac> jcsackett: do you have access to charmworld staging? <bac> jcsackett: management access via juju, i mean <adeuring> bac: Right, I think I've tried this before but then thought that I could specify integers (meaning milliseconds) too. But explicitly speicfying a unit sounds reasonable. <bac> adeuring: other calls indicate they want an integer specifying seconds not milliseconds <bac> adeuring: please merge that branch into yours for a single landing if you agree <bac> adeuring: do you have access to staging via juju? <adeuring> bac: sure, i'll merge it. But I am a bit puzzled that an integer would mean seconds, not millisecondes. And yes, I have meanwhile juju access to staging. <bac> adeuring: i'm seeing this when trying to access staging <bac> 2013-09-04 09:01:17,726 INFO Connecting to environment... <bac> 2013-09-04 09:01:19,284 ERROR juju environment not found: is the environment bootstrapped? <bac> when running /usr/bin/juju status -e staging <bac> adeuring: can you see if you can simply get status via juju? <adeuring> bac: I'm getting the same error. <bac> ugh <bac> yay! <bac> good morning sinzui! <sinzui> Good? I am not going to commit to such an accusation. I will simply state the obvious. Morning bac <bac> sinzui: it is good b/c you're here. hey, both adeuring and i are inable to access staging via juju. "juju status -e staging" reports the environment isn't up <bac> s/inable/unable <sinzui> ah * sinzui wonders if canonistack has toppled juju <benji> bac and adeuring: test run time for me is 115s and on the last run I only got bac's failure <adeuring> \o/ <bac> sinzui: the web app is running <bac> benji: let's not call this 'bac's failure' <benji> heh <benji> "the bacobian abnormality" <sinzui> bac, adeuring :( I was tempted to write kirkland to say canonistack has bad weeks and good months. We have completed a good month. This is out bad week <adeuring> yeah... though I found one setup issue we had with elasticsearch since we began to use it... <sinzui> bac, adeuring. I suspect the state server and possibly the agents are zombies. I have fixed this situation in the past by rebooting the the instances via nova * sinzui checks that he documented this <bac> adeuring, benji: i propose abel disable the failing test, land the branch, and then leisurely try to fix the test. the rest of us need the test speed-up now. <benji> +1 <adeuring> ok, let me just save the fixes i have in place. ES is real fun to work with :( <bac> benji: fwiw i'm now seeing the full suite run in ~90s <sinzui> bac: I think this issue is like the first 3 reported problems in https://docs.google.com/a/canonical.com/document/d/190xKLPpEPSrlVix4D9eX_aTciiKFo12h0u7MpzqI28I/edit# . Per the doc, I just sshed and rebooted the state server (instance 0) <benji> bac: sounds good (my machine is a tad slow, so I would expect mine to give slightly longer run times) <rick_h> abentley: ping, got a sec to chat search? <abentley> rick_h: sure. juju-gui? <rick_h> abentley: well figured I'd ask here. I noticed the docs note some extra fields to search on, summary, etc? <bac> sinzui: i didn't realize i could ssh natively, thought i had to use 'juju ssh'. <rick_h> abentley: but it comes back as not supported: http://staging.jujucharms.com/api/2/charms?summary=apache <rick_h> abentley: and http://staging.jujucharms.com/api/3/search?summary=apache <sinzui> bac, yeah. We always have the cloud's tools to use, but I too am not as versed in them as I am Juju <rick_h> abentley: is this intended to work? I was looking at the bugs around m_3 about wanting to search more data and I was trying to see how we might do that currently. <abentley> rick_h: What the docs mean is that if you do http://staging.jujucharms.com/api/3/search?text=apache, one of the the things searched is the summary field. <rick_h> abentley: ooooh, ok. <bac> sinzui: can you grant me edit to that doc? <adeuring> bac, benji, sinzui: so, here is the MP: https://code.launchpad.net/~adeuring/charmworld/set_n_replicas_and_shards/+merge/183846 <sinzui> bac: done <benji> adeuring: I'll review it <sinzui> The state servers logs still say they cannot talk to the zookeeper. Looks like the monkeys are loose. <sinzui> abentley, bac, benji, adeuring. If I don't have this sorted out soon, I propose we redeploy the stack since that is 20 minutes at most <benji> +1 <benji> adeuring: the branch looks good to me; I had a question that is bigger than the branch and shouldn't block its landing <abentley> sinzui: This is probably not the right time, but now that canonistack has a much larger floating IP range, we can start looking at using gojuju instead of pyjuju. <sinzui> abentley, I disagree. This might be the right time. <sinzui> I think we want to ask webops if they are prepared to redeploy charmworld on juju 1.x <adeuring> benji: thanks! * sinzui wants to remove pyjuju and zookeeper from his computers <bac> sinzui: can you update that doc with instructions for what you tried? i'm unsure. <abentley> sinzui: Yes, maybe it's time. <bac> adeuring: i thought you were going to include my timeout-values branch. do you not think it is needed? <bac> adeuring: but perhaps i should land it separately, so never mind <adeuring> bac: sorry, simply forgot it :( <bac> adeuring: i'll do it once yours lands <bac> better actually <bac> adeuring: and thanks a million for figuring out the underlying problem! <bac> benji, adeuring: please have a look https://code.launchpad.net/~bac/charmworld/timeout-values/+merge/183877 <adeuring> bac: on standup call right now; I'll look asap * benji looks <benji> bac: looks good <sinzui> bac benji: I am inclined to teardown the staging env and rebuild it with gojuju. bac you have an instance in it. Can I remove it too? <bac> sinzui: yes <benji> sinzui: sounds like a good idea; we need to be transitioning to gojuju <bac> sinzui: there will be some setup changes <bac> a missing cert, i believe, that gojuju wants <sinzui> hmm <sinzui> I need to learn about that. This is the script we used in the last few deploys of the stack: https://pastebin.canonical.com/91952/ <bac> benji: i'm back to looking at your bundle-feature-ui branch. it has a conflict. <benji> bac: oh, yeah; I had forgotten about that. I'll look at it now. <bac> benji: i've fixed it locally about three times... :) <bac> benji: your branch fails this test repeatedly: http://paste.ubuntu.com/6062793/ <benji> bac: yep, I'm seeing the same thing. <bac> sinzui: does the charm deploy charmworld trunk or a fixed revno? <sinzui> bac by default it deploys tip (-1). we call set to increment the revno <bac> sinzui: cool, tip is what we want <sinzui> I see staging is finally gone. I will update my config and try gojuju <rick_h> jujugui review time please https://codereview.appspot.com/13237052 <jcsackett> sinzui: i'm looking at the audit charms card. i'm assuming anywhere a queue is referred to here, we're talking about charmworld tools? <benji> bac: all tests are passing: https://code.launchpad.net/~benji/charmworld/bundle-feature-ui/+merge/183709 <bac> benji: great * bac reboots <frankban> hatch: https://code.launchpad.net/~frankban/juju-gui/ci-activate-inspector/+merge/183898 <Makyo> jujugui https://codereview.appspot.com/13527043/ fairly small <benji> Makyo: I'll take a look <Makyo> benji, Thanks <abentley> sinzui: Got a build running the tests: http://669-615-7011:8080/job/test-charmworld/1/console <frankban> Makyo: https://codereview.appspot.com/13313044 <bac> benji: at line 206 of your diff, does that assignment of form last until the end of the method or is the scope just the exception handler? * benji looks <benji> bac: end of the method (that code was moved during the refactor, I don't think I touched it) <sinzui> jcsackett, Yes, I believe queue == Tools. <bac> benji: that is overly clever and confusing, i think. <jcsackett> sinzui: ok; any idea what this "build 2nd queue or combined queue" means? <sinzui> abentley, \o/ <jcsackett> seems like maybe a redundant bullet point, given the first one is about building a new queue? or is it referring to something else? <benji> bac: I agree. Smuggling return values through exceptions isn't exactly something that should be done lightly. <benji> it's a pretty big refactor though (or at least a pretty big task to understand the form validation system) <benji> I would be inclined to have a bug/card along the lines of "revamp and potentially replace form validation logic with third party library". <sinzui> jcsackett, we want to re-review everything. charmers need a way to burn a list of charms down. The review criteria is more strict than the past. The goal is to record what needs to be done (bug reports?). charmers have a queue of MPs, but these are only the active development charms <abentley> sinzui: 1x1? <jcsackett> sinzui: ah, ok. <sinzui> jcsackett, We can choose to build a new queue or augment the current queue. The effort is one time so we can plan for a way to get a list of items to do. We can discuss this later in a 1x1 <jcsackett> sinzui: sounds good. <sinzui> abentley, yes our 1x1...but i need a few minutes to find caffeine <abentley> sinzui: :-) <sinzui> abentley, I am ready, shall I call? <abentley> sinzui: sure. <rick_h> abentley: so we want to put the owner on the charm token but I recall there was a reason that was bad? <rick_h> jcastro: ^^ as well <bac> benji: http://669-615-7011:2464/bundles/wiki/wiki/featured/edit this url should work but doesn't b/c that bundle is not promulgated, right? <abentley> rick_h: otp <rick_h> we're pondering "If this is not a reviewed charm, put the owner name on the charm token" <rick_h> abentley: rgr * benji looks <benji> bac: I can't get that bundle to show up after I've cleared my DB. Any hints? I ran bin/enqueue --prefix '~charmers/charms/precise' --limit=100; bin/ingest-queued <bac> benji: this is what i run: http://paste.ubuntu.com/6063136/ <bac> benji: but first i change charmworld.ini to limit to 10 instead of 110 charms <benji> k <benji> me thinks we need a script for setting up a dev DB; something like what you have there <bac> jujugui are we having a call? <bac> or am i having lunch? * bac roots for the latter <gary_poster> bac benji I am in guichat. I think. <bac> gary_poster: yay <hatch> ahoy Goodspud <Goodspud> Aloha <hatch> how are you? <Goodspud> All is good in my world. I hear there are some of the crew on London? <Goodspud> Er, *in <hatch> yup - it's expensive here :P <adeuring> bac, benji, abentley: could one of you have a look at this MP: https://code.launchpad.net/~adeuring/charmworld/fix-more-spurious-failures/+merge/183919 ? <hatch> jujugui could I get a review on https://codereview.appspot.com/13237053 plz <bac> sinzui: what't the status of staging? <sinzui> My deploy failed a few minutes ago. I see an error in my config <benji> bac: was the "needs fixing" because of the overly clever form validation bit? <Goodspud> Apologies hatch, I lost my connection on my phone * benji suspects bac is lunching, so he does the same. <sinzui> bac: sorry for the delay. I need to do a few hacks to deploy because the much promised public ips aren't here yet * benji is back after a short lunch <benji> back let me know when you're around <bac> benji: no, the needs fixing was due to the uncaught exception being raised. sorry i wasn't clear. <benji> bac: cool, in that case it is ready for you to look at again <bac> dang, i should've said 'both' <benji> bac: I don't follow. "both" what? <bac> benji: both issues. assigning form in the exception and not raising the 404. <bac> benji: but it looks good. r=me <benji> yay <benji> bac: I'm looking at your bundles icon branch; do you have a moment for a call about it? <bac> sure <jcsackett> jujugui: is there a simple way to determine what series the juju-GUI app is running on within the app code? <hazmat> jcsackett, it can look for itself within the env <hazmat> jcsackett, ie examine its own charm, doesn't work against the fake/mems <bac> how goes the battle sinzui? (sorry i got disconnected and distracted.) <sinzui> bac: ingestion just started. maybe 15 minutes? <sinzui> bac: abentley: I think the authorized keys option is bad, or just obtuse: https://wiki.canonical.com/InformationInfrastructure/IS/CanonicalOpenstack/CanonistackWithJujuCore <sinzui> ^ When I set it, such as with the staging key we use, I get locked out. <sinzui> The successful setup lets juju choose keys <abentley> sinzui: You're putting the contents of the public key there? <sinzui> abentley, I added the path to the staging public key <abentley> sinzui: The way I read it, it's not a path, it's the actual contents of the key. <abentley> sinzui: That's why I said it would make distributing environments.yaml more convenient in the future. <sinzui> abentley, a list of the keys? well I might tear this down in a few hours and try again <rick_h> jcsackett: did you get it figured out? <jcsackett> rick_h: not yet; made note of hazmat's suggestion, but that does nothing for sandbox mode. <jcsackett> rick_h: working on it alongside other things; hope to deal with it tomorrow morning. <rick_h> jcsackett: app.env.get('defaultSeries') <jcastro> rick_h: I just found a shitty bug <jcastro> rick_h: ok so in the jujucharms.com search box <jcsackett> rick_h: well then. <jcsackett> that's easier. :-P <rick_h> jcastro: hopefully something we can address or have addressed. Lots of bug finding lately <sinzui> bac: looks like mongodb has an agent-state error. charmworld is waiting to mongodb <jcastro> search for "rabbit" = nothing. search for "rabbitmq" returns rabbitmq-server <jcastro> how come rabbit doesn't return anything? <rick_h> jcastro: yea, it matches full names, partial matches in fields like summary/etc <bac> sinzui: ok <rick_h> jcastro: because rabbit is part of the word. We don't tokenize it. I think it's something we'll look at changing as trying ot get better search, but not set in stone atm <hazmat> jcsackett, another option its part of the config . and the charm can write it out, or default value from config for fake/mems <hazmat> rick_h, default doesn't nesc. correspond to the gui series though <jcsackett> hazmat: i think rick_h's approach fits my needs; we just want to grab the env series. i think my question garbled my intent. <rick_h> hazmat: true, but for what jcsackett is doing I think works. It's basically a helper to plus up the series you're working 'in'. <hazmat> ah cool <rick_h> for search results ranking a little bit #juju-gui 2013-09-05 <luca___> if I want to add 20 units to postgres do I type "juju add-unit postgres" <luca___> gary_poster: rick_h Makyo ^ <Makyo> juju add-unit -n 20 postgres I think <Makyo> luca___, juju add-unit postgres -n 20 <Makyo> luca___, Or either works. The docs are conflicting :P <luca___> Makyo: I see, thank you <luca___> someone needs to juju add-unit luca's brain -n 20 <Makyo> If I could scale up like that, I imagine this would all be a lot easier. <Makyo> hatch, http://www.youtube.com/watch?v=mC4Z8uIoVcQ <Makyo> For whenever. <huwshimi> rick_h: http://669-615-7011:2464/ <luca__> huwshimi: Scale up with these constraints? <huwshimi> Does anyone remember writing this comment in the inspector CSS? "The height of each list is 35px so setting this to help the auto max height script." <rick_h> huwshimi: I think that is from the auto adjusting height stuff right? <huwshimi> rick_h: If you get a chance could you come over and explain what's going on there? <rick_h> huwshimi: yea <huwshimi> rick_h: No hurry <rick_h> yea, trying to figure out if we're having an 'all' meeting or not <Makyo> frankban, categoryWrapperNode.filter(function(d) { return d3.select(this).classed('landscape-needs-reboot'); }) <sinzui> jcsackett, hangout? <benji> bac: I finished my Makefile branch: https://code.launchpad.net/~benji/charmworld/makefile-tweaks/+merge/184105 <benji> I would enjoy a review if you have time. <bac> benji: ok. i'm reviewing abel's branch atm <benji> thanks <bac> benji: my icon2 branch is ready too. i'm going to kill the initial MP <benji> bac: I'll review it <benji> (just let me know when and where) <huwshimi> If anyone wants to review my charmworld redesign branch it's here: https://code.launchpad.net/~huwshimi/charmworld/charmworld-styling/+merge/184078 <huwshimi> Don't worry, it's only a 11,237 line diff. <benji> huwshimi: I'll take a look. <benji> If I'm not back in three weeks tell my family that I love them. <Makyo> frankban, https://gist.github.com/makyo/6450487 <huwshimi> benji: Haha, thanks. My apologies. <benji> I wonder if I can get this diff up on Rietveld. It would be nice to do this as an in-line review. <bac> benji: makefile branch approved but with one question about use in production. <benji> cool, I'll look <hatch> gary_poster, review done <gary_poster> thank you I saw hatch :-) <bac> benji: looks like huwshimi's branch breaks the makefile wrt css <benji> bac: yeah, I was just noticing the same thing <bac> benji: quick, land yours and maybe that'll fix it <benji> heh, I doubt it <huwshimi> bac, benji: Oh did I not remove some bootstrap paths or something? <rick_h> hatch: can you QA my branch that gary reviewed please? https://codereview.appspot.com/13368049/ <bac> huwshimi: there is a rule that depends on theme.less but it has been removed <huwshimi> oops <bac> huwshimi: so is the css all static now? not less and not generated? <huwshimi> bac: Yeah, in fact we just load the CSS hosted on ubuntu.com <benji> eww, the charm is written in shell script <Makyo> hatch, https://codereview.appspot.com/13563043 <jcsackett> sinzui: so, juju is now throwing "found no instances" i assume because i'm no longer shuttled. however, nova lists nothing for me as well. do we have nothing live, or is my nova lying? <sinzui> jcsackett, you are being lied to. There nova list shows me 6 staging machines, 2 qa machines and a bac instance <jcsackett> sinzui: ok, so juju is probably configured right, but not canonistack itself. interesting. <sinzui> This morning I source orange stack, set JUJU_HOME to the dir to my env.yaml, ran sshuttle, did juju status <benji> huwshimi: If you can fix that make issue it would help me in the review (I'm trying to get the diff up on Rietveld so I can do in-line comments) <huwshimi> benji: Sure, will take a look now. <benji> cool <jcsackett> sinzui: right, i was going to shuttle, but i don't want to ping you every time i need to get the IPs to do so. so time to debug nova. <bac> huwshimi: thanks for the rework of the charm and bundle pages. sorry they were such a mess to start. <bac> adeuring: may i assign the ES test problem card to you on the kanban board? <adeuring> bac: well... not sure if this fits into the tasks I am supposed to works on in the next time. sinzui: ^^^ <bac> adeuring: i figured your current branch did the work. <bac> adeuring: i'm just trying to clean up the board and thought you should get credit for work already done. <adeuring> bac: no, douglassanchez@example.org. I suspect that we need to not only use the ES call health() but to also check the index status, as descriibed here http://www.elasticsearch.org/guide/reference/api/admin-indices-status/ <abentley> orangesquad: Here's a blog post that I believe describes how the launchpad jenkins plugin is used. http://qualityhour.wordpress.com/2012/06/14/continuous-integration-with-jenkins-and-launchpad/ <bac> benji: i think you can just remove the CSS rule from huwshimi's makefile. the css is all static now. <benji> bac: he's looking at it; I figured he would know what was up better than I <adeuring> bac: the challenge with this APU call is to figure out what information is relevant. And perhaps also, _if_ this URL provides relevant information... <huwshimi> bac: No problems at all! <huwshimi> benji: I've got caught up here a bit. I think you can probably remove any/all css rules there, but I was going to grab Rick to make sure I wasn't breaking anything, but he's caught up with something now. <benji> huwshimi: ok, I'll take a look <adeuring> bac: ah, i misunderstood your question. I thought you refered to email. Yes, the pending MP should fix some problems that occur even when the ES server is "stable". <jcastro> hey gary_poster <jcastro> I found an interesting thing <jcastro> https://chinstrap.canonical.com/~liam/cassandra-setup.jpeg <jcastro> I asked the guys in IS to make me a diagram on how we do cassandra for a blog post <jcastro> and this is what they came up with <jcastro> but like the GUI doesn't show units and relationships together, so the diagram looks rather lame in comparison <jcastro> I know we don't really target "make it look impressive when there's a ton of units" as a use case <jcastro> but I thought I'd point it out <Makyo> hatch, https://codereview.appspot.com/13515044 <Makyo> jujugui Review please for flagging a service as charm_changed https://codereview.appspot.com/13560043/ <gary_poster> jcastro, hey. Fair enough. :-) Yeah, I don't expect we'll get a unit view any time soon. <bac> sinzui: now that staging is up and happy, i'd like to get production on the same rev 381. anything i should know besides just following your google doc? <sinzui> bac: Nothing special today <bac> okey doke, off to file an rt <sinzui> bac: I ponder making staging again at EOD because I think we want to use a floating IP. I will also need to land a branch to make migration 18 safe for fresh deploys. <huwshimi> benji: Did you have any luck with the makefile? <benji> huwshimi: yep, tests running now <huwshimi> benji: Great! <benji> huwshimi: tests passed <benji> I'm going to try to get this up on Rietveld now. <huwshimi> benji: Have fun! <huwshimi> benji: I think 10,000 lines of that review are removing bootstrap, so it's not as bad as it seems. <bac> benji: are you going to be able to get to my bundle-icon branch or should i ask an orangish person? <benji> bac: oh, I didn't know it was ready. I asked for you to tell me where it was when it was ready. * benji looks at the backscroll to see if he missed something. <bac> benji: yeah, it's been ready. sorry i didn't give you an url...its in the normal spot <bac> benji: https://code.launchpad.net/%7Ejuju-jitsu/charmworld/trunk/+activereviews <benji> thanks <bac> benji: only 244 lines of that are code, the rest svg <benji> cool, looking now <Makyo> jujugui https://codereview.appspot.com/13566044 quick review please, I broke zooming :( <benji> bac: the branch looks good <bac> thanks <benji> bac: I added a card for the docstringageddon <bac> benji: great. we're much better at making cards than finishing them. :( * bac points finger at self <benji> heh <bac> benji: no call today, right? <benji> as far as I know <bac> nice. /me -> lunch <Makyo> jujugui quick fix for services appearing to jump on drag https://codereview.appspot.com/13547045 <benji> Makyo: I did a review (no QA) <bac> hi sinzui, fyi production has been updated https://pastebin.canonical.com/96998/ <bac> we should have a charm icon contest. i vote bip for most engaging. http://manage.jujucharms.com/charms/precise/bip <bac> hi benji, there is a problem with your makefile for the run target. es_update instead of es-update. i've fixed it in my branch. <benji> bac: ooh, thanks; I'll sneak a quick change into trunk <bac> benji: something is clearing out my local db between runs. could it be a change to the makefile? <bac> benji: could be an undesired behavior in production. <benji> bac: I don't see how. <benji> bac: between runs i.e., "make run"? <bac> benji: perhaps 'make test' / 'make run' cycles. <bac> benji: a mostly mechanical change: https://code.launchpad.net/~bac/charmworld/singularize-bundle/+merge/184181 <benji> bac: I'll take a look. Re. db clearage: I just did a "make run" and checked that the apache charm page worked, did a "make test" (the tests passed), and then another "make run" and the apache page was still working <bac> thanks for the review benji <benji> my pleasure <bac> benji: it is ES that is getting blown away. do a run / test / run and then do a search for 'precise' <bac> benji: i wonder if it is es-update. it sure takes a long time now * bac dogs walk <benji> bac: yep, I think I have the same thing happening, all searches return no results #juju-gui 2013-09-06 <Makyo> rick_h, https://codereview.appspot.com/13560043/ <rick_h> jujugui small tiny review and qa please https://codereview.appspot.com/13289049 <Makyo> rick_h, https://gist.github.com/makyo/6461440 <raywang> hi, does anyone know how to change juju gui's admin password? <rick_h> raywang: it's the environment admin password <rick_h> raywang: if you change that in your environments.yaml it'll change in the gui <raywang> rick_h, yeah, i know, but i need to change it :) <raywang> rick_h, but i already have a running env deployed by juju <rick_h> raywang: :( talking here souds like your out of luck <rick_h> raywang: if you change the admin password in the environment.yaml I'l told you have to re-deploy the environment <rick_h> I'l means I'm <raywang> rick_h, well, user sometimes need to change the password then. it's necessary to have this functionality :) <rick_h> raywang: yea, so there's work to be done to support multiple users down the road and that might do what you want <raywang> rick_h, agreed :) <rick_h> but right now, there's not a way we know of to change the admin password for the environment <rick_h> without the reploy your environment story. <raywang> rick_h, ok, thanks for the information :) <rick_h> sorry I don't have better news <raywang> np :) <Makyo> hatch, rewrite core in node pls <rick_h> jujugui another tiny review please, and QA as well https://codereview.appspot.com/13588043 with an easy QA of "get up a ghost to deploy a charm" <bcsaller> https://codereview.appspot.com/13418046/ has the proposed databinding reset support gary wants <benji> bcsaller: do you need a review? <bcsaller> benji: that would be great <benji> will do <bcsaller> benji: thanks for the review <benji> my pleasure <bac> morning <rick_h> morning <frankban> guihelp: https://codereview.appspot.com/13358045 <bac> frankban: i'll do it <Makyo> frankban, I'll get the other. <frankban> thanks bac and Makyo <bac> hi frankban, i'm attempting to do qa on your landscape link branch. how do i get a unit to show the link? <frankban> bac: using improv --landscape, but do that only if you are very interested, Matyhew already did QA. <bac> frankban: ok <frankban> bac: thanks <sinzui> orangesquad, bac, benji: Does anyone have a few minutes to review the migration 18 fix: https://code.launchpad.net/~sinzui/charmworld/migrate-new-index/+merge/184292 <benji> sinzui: sure <bac> rick_h: is the charmbrowser letter-spacing scrunchiness a known issue? <rick_h> bac: yes, we're douglassanchez@example.org. It seems to be due to r1015 and trying to verify that's true and if so figure out what it did <bac> okey doke <bac> rick_h: tip: look for "scrunchy: true" in the css and turn it back off. <rick_h> bac :) <rick_h> jcsackett: ping, don't land you brnach please <rick_h> I'm working on updating the charm token to make the result of that suck less <benji> sinzui: Looks good. <sinzui> thank you benji <sinzui> abentley, you can use https://code.launchpad.net/~sinzui/charmworld/migrate-new-index/+merge/184292 for testing jenkins integration <abentley> sinzui: It's not approved yet. My scripts are supposed to trigger when status is approved. <abentley> sinzui: Or were you inviting me to approve at my leisure? <Makyo> hatch, https://codereview.appspot.com/13527048/diff/7001/app/widgets/charm-token.js <rick_h> bac: problem identified, update coming <Makyo> bac, +1 <jcsackett> rick_h: ok, in standup, can you talk at 10? <rick_h> jcsackett: sure thing <Makyo> jamie___, http://comingsoon.jujucharms.com/:flags:/upgradeCharm/ <hatch> bac, I need frankban's branch so I'm going to go do that review <bac> hatch: don't. i did it just forgot to send <hatch> oh haha ok then :) thanks! <bac> done <rick_h> jcsackett: so I'll land that filter branch. Hit a token update blocker in that the related api doesn't provide the owner/series info in the call so I can't fill out those tokens <bac> hi huwshimi, will you be landing your charmworld restyling branch soonish? <huwshimi> bac: I would like to. I need to fix up the makefile and make a couple of simple changes and then I'll try and land it. I'll get to that in half an hour or so. <bac> huwshimi: ok. i think i'll start my work using your current version as a pre-requisite branch <bac> i need to add some stuff to bundle.pt and don't want to fuss with the old nasty one <huwshimi> bac: Great. Remember that the make won't work yet though. <bac> rt <bac> huwshimi: theme.css has gone away, right? if so, could you update .bzrignore and hacking.rst to remove mentions? <huwshimi> bac: OK will do. <bac> huwshimi: i'm adding some comments to your merge proposal. if you want to defer the one about the 'readme' section feel free. <huwshimi> bac: OK thanks I'll take a look <bac> rick_h: will gary be around later? <rick_h> bac: no idea tbh. I'd imagine, but they're in mgt stuff atm <rick_h> jujugui review time please https://codereview.appspot.com/13239049 <jcsackett> rick_h: looking. <jcsackett> rick_h: we don't need shouldShowIcon anymore? <benji> bac: I have a small branch up for review: https://code.launchpad.net/~benji/charmworld/fetch-bundle-head-via-api/+merge/184329 <bac> benji: ok. will look in a bit <benji> thanks <jcsackett> rick_h: nm, found where it was added back in. <bac> benji: what would you think about making bin/test (possibly moved) a static file so we could more easily make it smarter? i'd like something like 'bin/test -d' as shorthand for specifying all the pdb stuff. <benji> bac: sounds good to me; the main reason it isn't static now is that I preserved the use of $(INI), but that really looks like unnecessary indirection to me <benji> (unless the charm overrides it to set its own INI file, in which case we need a honkin' big comment at the top of the Makefile) <bac> benji: you are the slayer of unnecessary indirection <benji> next time I do fantasy LARPing that'll be my name <bac> benji: avatar? https://plus.google.com/photos?pid=5920530088824285986&oid=117034961047606128906 <benji> lol <rick_h> jcsackett: yea, ordered those because it was annoying me :) <rick_h> jcsackett: thanks for looking <benji> that's a cool photo of a cool statue <rick_h> jcsackett: ping, so did the text move under the icon in your note there? <benji> I like how you maintained context by including the graves
{'channel': 'juju-gui', 'month': 9}