#ubuntu-unity 2012-10-01 <didrocks> sil2100: good morning! How are you? <sil2100> didrocks: good morning - I'm a bit cold and tired, but fine - how about you? <didrocks> sil2100: still coughing a little, but way better, thanks! <didrocks> sil2100: will we have some tested compiz packages today? * didrocks wants to update today on ubuntu to have one less parameter for next unity release <sil2100> didrocks: yes ;) <didrocks> great! Any ETA? <didrocks> sil2100: sorry, got disconnected <didrocks> 09:10:05 didrocks | great! Any ETA? <sil2100> didrocks: I'll know everything soon, need to consult with popey <didrocks> sil2100: ok, keep me posted ASAP so that I can organize my work :) <davidcalle> mpt, ping? <davidcalle> mpt, oops, nevermind, found what I was looking for :) <mpt> davidcalle, ok. :-) FWIW, I never respond to pings. I do respond to questions. <didrocks> mpt: I should have the same policy :) <didrocks> mpt: tired of "ping", then you answer "pong" and finally no answer for an hour :p <mpt> exactly <thumper> haha <thumper> s'up mpt <thumper> mpt: I'm missing my marmite <didrocks> marmite? :) <mpt> hi thumper -- the factory's still closed? <thumper> mpt: factory broke in the earthquake way back, no more made <thumper> didrocks: yes... <thumper> didrocks: nz marmite, not uk marmite <thumper> mpt: unfortunately <mpt> thumper, is there a black market for it? <thumper> mpt: probably <thumper> mpt: a local radio station was using the 5g single serve things as prizes :) <mpt> Holy crap, NZ$61 for a 500g jar <mpt> http://www.trademe.co.nz/Browse/SearchResults.aspx?searchString=marmite <didrocks> thumper: a marmite is rather that in France: http://fr.wikipedia.org/wiki/Marmite_en_fonte :) <thumper> mpt: hmm, $61 is a bit rich for me <mpt> It would almost be worth me buying up the stock at the NZ Shop in Haymarket and putting it on TradeMe <mpt> even with postage back to NZ <mpt> (though I guess if that was really a good idea, someone would have done it already) <thumper> didrocks: different marmite :) <thumper> mpt: if there is some, I'll pay you for a jar at copenhagen <mpt> ok :-) <didrocks> thumper: I can see that :) <popey> morning didrocks <didrocks> hey popey! <popey> didrocks, had some issues which I debugged with omer on friday night, which were not regressions in compiz.. nvidia related issues <popey> and I have an issue with xrestop for finding windows resources <popey> seems xrestop crashes x (so don't run it) <didrocks> xrestop? <popey> https://bugzilla.redhat.com/show_bug.cgi?id=851885 <popey> known <ubot5> bugzilla.redhat.com bug 851885 in xorg-x11-server "xrestop crashes X" [Unspecified,New] <popey> yeah, one of the manual tests for compiz <popey> i guess to look for leaks <didrocks> ah ok, (upstream test I guess) <popey> yes <popey> but other than that, all looking funky <didrocks> ok, so no regression and tests done? <didrocks> sweet :) <popey> even had one report from loco member who said it all felt quicker :D <popey> which wasn't what I asked, but nice to hear anyway :D <popey> yes, no regressions I found, and tests done <popey> (just to be clear) :) <didrocks> exacellent! <didrocks> excellent! <didrocks> so sil2100, popey: packages? :) * popey points didrocks to sil2100 :) * didrocks stares at stil2100 <didrocks> popey: thanks for the testing! :) <didrocks> and results ;) <popey> np <didrocks> sil2100: ? :) <sil2100> uh oh sorry! <sil2100> Didn't watch IRC <sil2100> didrocks: you want the packaging branch ;) ? <didrocks> sil2100: well, if it's ready to be released, have all bugs on it and so on, yes :) <sil2100> didrocks: https://code.launchpad.net/~sil2100/compiz/ubuntu_+1-585-472-9035 <sil2100> It *should* be ready for release, since I prepared the changelog last week already <sil2100> And we tested packages built from it <seb128> hum, I should install that compiz ;-) <didrocks> seb128: I'll get you some debs ready soon if you want <sil2100> seb128: I have it on my PPA, but you need to reinstall unity as well <sil2100> https://docs.google.com/a/canonical.com/document/d/1B0HsvYRiKNs-EEzTFkFQ95_XWDN0iX73tW74NZSq8Lc/edit# <sil2100> Here's the PPA address too <seb128> didrocks, sil2100: I can test whatever should be tested, just point me to what to install when it's ready <didrocks> sil2100: just take sil2100 ppa then :) <didrocks> I'm rebuilding here compiz and unity <toabctl> can someone have a look at https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205 (and merge it if the code is ok), please? <ppd> hi. I'm having severe performance issues with unity spread/compiz scale in quantal on my nvidia gt 220. what is the preferred way of collecting meaningful data for the developers to look at? I have seen some bug reports in compiz/unity regarding nvidia performance problems, but a Gt220 should easily outrun my pre-sandy-bridge integrated intel chip in my laptop. Right now multi-monitor setups just make me cry... <mhr3> ppd, it's fixed in trunk <seb128> toabctl, hey, I've pinged your merge request to Cimi (the maintainer of overlay-scrollbars) <ppd> mhr3, really? thank god. Is it the drawing caching fix? <toabctl> seb128, is cimi also on irc? /whois cimi on freenode gives nothing. <toabctl> seb128, btw, thanks! <seb128> toabctl, yw! <seb128> toabctl, not sure why he's not on this IRC, I pinged him about it <toabctl> seb128, how do you ping him? on GIMPNet ? or any other server? <seb128> toabctl, through the Canonical server <toabctl> seb128, ah. ok <didrocks> davidcalle: on https://code.launchpad.net/~davidc3/ubuntu-mono/22width-indicator-messages/+merge/127203, you need to ask mpt, he did the icons :) <didrocks> so not sure if the size was on purpose <davidcalle> didrocks, looks like you just did it :) (I thought Matthieu did them) <didrocks> davidcalle: yeah, it was a double ping :p <mpt> davidcalle, +1 on that change <didrocks> davidcalle: it's really the same icons, just different size, isn't it? <davidcalle> didrocks, yep <didrocks> ok, I'm sponsoring it then <davidcalle> didrocks, mpt, thanks <didrocks> davidcalle: thanks to you! <davidcalle> didrocks, I had the change on my desktop for a week, and a screenshot this morning reminded me it wasn't in distro :p <didrocks> heh :) <tsdgeos> to fix a bug in unity shall i be using lp:~unity-team/unity/6.0 or lp:unity? <tsdgeos> how different are they nowadays? <sil2100> tsdgeos: the rule is: <sil2100> tsdgeos: first you submit a fix to lp:unity, then backport it to 6.0 <sil2100> tsdgeos: they're VERY similar right now <sil2100> But always first commit a fix to trunk, then to given version <tsdgeos> oki <tsdgeos> tx <tsdgeos> sil2100: are we finally getting a new unity-2d release for precise with my unreleased bugfixes? <sil2100> tsdgeos: yes, it's like ready since Friday :o <sil2100> tsdgeos: the problem is, right now we're again context switched by unity 3d release <tsdgeos> sure no hurries <sil2100> I think it will be dealt with tomorrow <tsdgeos> but good we are giving the users some extra polish for LTS :-) <sil2100> ;) <tsdgeos> hmmm, can't use quantal to depebelop for lp:unity? <tsdgeos> unityshell.cpp:1310:30: error: âclass nux33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abnimation33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abnimationControllerâ has no member named âHasRunningAnimationsâ <tsdgeos> oh man that depebelop had lots of typos :D <tsdgeos> develop i mean <sil2100> I think you need latest nux <sil2100> From lp:nux or at least lp:nux/3.0 <tsdgeos> ouch <hyperdad> simple way to add unity themes? #ubuntu-unity 2012-10-02 * tsdgeos shows https://code.launchpad.net/~aacid/unity/ignore_unmapped_on_minimize_unminimize/+merge/127460 to the channel and hopes it's not a laughable commit/fix <MCR1> tsdgeos: Great, that you are still helping here :) <davidcalle> didrocks, hey <didrocks> salut davidcalle! <didrocks> davidcalle: if you come for Super + C, I'm unsure, it needs to be a UIFe to warn the doc team :) <didrocks> otherwise, comment Ã§a va? :) <davidcalle> didrocks, Ã§a va ? Bien vu, je viens pour un Ã©ventuel distro patch pour Ã§a. <davidcalle> didrocks, bien, bien <didrocks> ahah :) <didrocks> gotcha! <didrocks> davidcalle: so yeah, UIFe will be needed, ask the doc team <didrocks> I didn't take it on purpose <davidcalle> didrocks, ok, I'm asking Jeremy first, I don't know if the shortcut is documented. <didrocks> yep :) <didrocks> if not, I'm happy to cherry-pick <bernie> has anyone ever observed a bug in ccsm that makes it impossible to specify hotkeys containing <Super> ? <bernie> i'm seeing this on 3 different precise installations <bernie> how to reproduce: 1) open ccsm; 2) go to any setting which lets you specify a hotkey; 3) bring up the hotkey editor, and press Super + any key 4) exit ccsm 5) open ccsm again and go back to the hotkey <bernie> on my machine, the hotkey is cleared. it only happens if it contains <Super> <bernie> it also gets cleared immediately if you bring up the text entry box and accept an existing <Super>+something hotkey, without editing it #ubuntu-unity 2012-10-03 <sil2100> tsdgeos: https://code.launchpad.net/~sil2100/unity/ignore_unmapped_on_minimize_unminimize_6.0/+merge/127652 <tsdgeos> oh cool <tsdgeos> i was planning to do it now <tsdgeos> have you done 5.0 too? <tsdgeos> back in a sec <sil2100> tsdgeos: 5.0 not yet, I did 6.0 since we need it in ;) <sil2100> tsdgeos: can you test and approve? :) <sil2100> (your own fix ;p) <tsdgeos> sure <sil2100> tsdgeos: once you're done, please approve - since I want it to go in ASAP <tsdgeos> compile just finished <tsdgeos> sil2100: give me 10 min more, something went wrong in my compile and things are crashing like crazy <sil2100> Ouuch <sil2100> Ok, no problem <tsdgeos> sil2100: done <tsdgeos> sorry for the delay <sil2100> Awesome, thanks! <tsdgeos> sil2100: going to test the 5.0 one and will create a MR for it too <sil2100> tsdgeos: thanks! <tsdgeos> sil2100: not yet merged? needs an unblock or is just the merger being busy? <tsdgeos> https://code.launchpad.net/~aacid/unity/ignore_unmapped_on_minimize_unminimize_5.0 ready too <sil2100> I think the merger is busy... <sil2100> The merger seems to be really slow recetnly, and has a BIG queue <davmor2> hey guys I noticed that the messaging indicator shows online with no app started but can't be set to anything else till an app is open it this the expected behaviour? <Mirv> davmor2: sounds like a bug, I can see that as well... <Mirv> btw anyone wanting to test the candidate for next 12.10 unity stack, it's at the moment at ppa:unity-team/ppa <Daekdroom> Mirv, is it still building? <Mirv> Daekdroom: only for ARM <Mirv> i386/amd64 should be all built and published <Daekdroom> Installed and running. <Daekdroom> No kittens have died so far. <davmor2> popey: quick check on skye... <popey> davmor2, leaping around like a lunatic <davmor2> popey: kittens are indeed safe then it appears <davmor2> Mirv: I'd love to join in unfortunately I'm juggling enough things as it is <anant> I compiled unity from src by following instructions at http://unity.ubuntu.com/getinvolved/development/unity/. On starting it though (unity --replace &), it crashed. <anant> I'm running Q Beta 2. Stack trace: http://paste.ubuntu.com/1251142/ <mhr3> bschaefer, morning :) <bschaefer> mhr3, good morning! <mhr3> want to improve your mood in the morning - lp:~mhr3/unity/ubus-rewrite ;) <bschaefer> \o/ * bschaefer grabs the branch and compiles it <mhr3> things seemed to be working mostly :) <mhr3> will need to merge re-trunk though i guess <bschaefer> mhr3, awesome, and without taking a look at the code, how is starvation being handled? <mhr3> i mean re-merge trunk :) <didrocks> mhr3: *NO* :-) <mhr3> didrocks, huush! it's your eod! <didrocks> mhr3: don't even try to sneak it in 6.0, I know you thought about it! :) <bschaefer> haha * mhr3 continues his masterplan while didrocks isn't looking <didrocks> mhr3: you will need to DDOS launchpad to not send any email :) <didrocks> or ack the canonical servers for it <didrocks> starts to be quite expensive to do :) <mhr3> didrocks, you're thinking too big, all it takes is pinging is to suspend your mail for a bit ;) <didrocks> heh :) <mhr3> bschaefer, as for starvation, i set the default prio to "default", ie all ubus msgs have same prio as redraws or any other event processing <bschaefer> mhr3, cool, I was just thinking if people keep shoving HIGH prio the ones before it could starve to death :( <mhr3> but the starvation isn't really fixable while unity runs in the same thread as compiz <mhr3> perhaps one day... :) <bschaefer> hmm the only way I could think of would be to bump of the prio at times for things... <bschaefer> meh <bschaefer> it is very unlikely to happen :) <mhr3> yea, it'd be nice we glib sources could specify deadlines by which even low-prio sources have to be processed <mhr3> that could completely fix possible starvation <bschaefer> hmm yeah, which would be nice but the added complexity vs worth it <bschaefer> starvation is not cool though <mhr3> but anyway... i gotta be on squash court in 30minutes, so gtg cyas :) <bschaefer> mhr3, have a good one! Thanks again! <mhr3> bschaefer, thx, as for the branch, it's just missing a few more tests, then i'll re-merge and propose ;) <bschaefer> cool, Ill test it out as well :) (ie. fixing a few bugs ;)) <mhr3> feel free to comment it @ https://code.launchpad.net/~mhr3/unity/ubus-rewrite/+merge/127821 <bschaefer> will do! <anant> what's the difference between the enum values NOT_HANDLED and HIDE_DASH (enum HandledType in UnityCore/Lens.h)? #ubuntu-unity 2012-10-04 <didrocks> btw, I think that people noticed the merger is stuck? <om26er> davidcalle, Hey! <om26er> you may want to take a look at bug 1056814 <ubot5> Launchpad bug 1056814 in unity-lens-video (Ubuntu) "unity-lens-video crashed with UnicodeEncodeError in progress_zg_events(): 'ascii' codec can't encode character u'\xe4' in position 35: ordinal not in range(128)" [Medium,Confirmed] https://launchpad.net/bugs/1056814 <davidcalle> om26er, hey! <davidcalle> om26er, looking at it and wishing we could have moved it to py3 this cycle... Thanks <om26er> davidcalle, thank you :) <davidcalle> om26er, hey again, I'm wondering about https://bugs.launchpad.net/unity-lens-photos/+bug/1049090, why have you removed [UIFe] from the title? <ubot5> Ubuntu bug 1049090 in OEM Priority Project quantal "The shortcut Super + P of photo lens is conflict to Video out hotkey" [High,Confirmed] <om26er> davidcalle, sorry about that, I thought it was too late for that and did we get a response from design on that? <om26er> its actually a oem-priority to get that fixed <davidcalle> om26er, yeah, everything is ready, design, doc and translators have acked. <om26er> davidcalle, added back the tag <davidcalle> didrocks, ^^^are we waiting on someone else or is it ok for you? <om26er> bug 1049090 <ubot5> Launchpad bug 1049090 in OEM Priority Project quantal "[UIFe] The shortcut Super + P of photo lens is conflict to Video out hotkey" [High,Confirmed] https://launchpad.net/bugs/1049090 <om26er> davidcalle, so whats the new key for photo lens? <davidcalle> om26er, thanks, it wasn't an issue for me, just wanted to know :) <davidcalle> om26er, Super+C <om26er> and what does C stand for :O <davidcalle> Camera :P <didrocks> davidcalle: I'll backport it <didrocks> davidcalle: it will be uploaded today <didrocks> davidcalle: what's the task on the shopping lens? <didrocks> ah changing the shortcut as well <davidcalle> didrocks, I've a branch to remove the keyboard shortcut, it doesn't need one <didrocks> ok, please do and propose it :) <didrocks> Mirv: ^ <davidcalle> didrocks, the MP is done I think, let me check <didrocks> davidcalle: can you send the link here <Mirv> davidcalle: this one? https://code.launchpad.net/~davidc3/unity-lens-shopping/remove-keyboard-shortcut/+merge/128008 <davidcalle> didrocks, https://code.launchpad.net/~davidc3/unity-lens-shopping/remove-keyboard-shortcut/+merge/128008 <davidcalle> Mirv, yes <didrocks> Mirv: not sure if the shopping lens has the merger in TBH <didrocks> Mirv: approved the branch :) <didrocks> davidcalle: thanks! <Mirv> thanks, both d:s <didrocks> davidcalle: can you add the downstream tasks for both on the bug report please? <davidcalle> didrocks, sure <didrocks> Mirv: I'm taking care of the photo lens <Mirv> sil2100 actually has the shopping packaging on his computer, but I poked him about this so that it'll be included in today's release <jono> didrocks, want to come on our marathon hangout for an interiveW? <jono> internview <jono> interview * jono can't type * jono can't type <didrocks> jono: can do! maybe rather tomorrow morning (when all you guys will be almost passing out :)) as today is desktop infrastructure and we are pushing unity 6.8? <jono> didrocks, no worries! <didrocks> mhall119: indeed, I will have a "full night of sleep" :) <didrocks> but thinking about you guys, no worry :) <mhall119> didrocks: :P <sil2100> Trevinho: hi! How's the crash fixes going? Merges submitted? * sil2100 in the bus right now <sil2100> didrocks: any problems with the releases so far? <didrocks> sil2100: some with dconf <didrocks> sil2100: and you not diffing configure.ac <sil2100> In what package? <sil2100> Bamf I'm sure I diffed... <didrocks> the shopping lens <didrocks> depped on the new libunity <sil2100> Ok, about that really sorry, since it was all in a hurry, grrr - yes, this change I didn't bzr merge -c from the previous ubuntu branch... <sil2100> Since I recreated it from 0 in a few minutes with the new tarball :/ <sil2100> We even prepped checklists for thimgs like that, not to forget anything, but it all was useless when doing in a hurry, I apologise about that <sil2100> *things <toabctl> Cimi, can you comment/merge https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 please? <sil2100> I blame the buses ;p But I also could have just made cp the whole debian directory instead <Cimi> toabctl: thx, I read and forgot to reply! <Cimi> toabctl: anyway, why you did modify the tests as well? <toabctl> Cimi, the test program looked very ugly. <toabctl> Cimi, it's just cosmetic <toabctl> Cimi, oh. I just realized that I proposed both commits. I can recreate the merge request with only the memory leak fix, if you want <didrocks> sil2100: no worry, but rigor rigor rigor please :/ <didrocks> sil2100: this should be automatic after 6 months of practice alreadyâ¦ <Cimi> toabctl: the if is redundant in the destroy notify <sil2100> I know I know! This time I assure you - if I only I didnt do it so hastily before going out, I would certainly notice the change, since now its no way not to when we do everything step by step <sil2100> So this will hopefully *not* happen again in normal working conditions <sil2100> I feel so ashamed because we worked so hard this week to get this formalized in our team and it all went to waste with the shopping packaging ;p <Cimi> toabctl: I am checking with our glib expert <toabctl> Cimi, you mean in destroy_private() ? g_slice_free() already checks for NULL? <Cimi> toabctl: destroy notify never get null <toabctl> Cimi, ah. ok. I can remove the if-statement <toabctl> Cimi, what do you want to check? and who's the glib expert? <Cimi> toabctl: ryan lortie <Cimi> desrt on freenode <toabctl> ok <toabctl> Cimi, just let me know what I should change on the branch <Cimi> sure <sil2100> popey I'm running as fast as I can :)! <toabctl> Cimi, thanks * sil2100 is taking a taxi now <sil2100> didrocks: just wait 5 more minutes! <didrocks> ok, thanks :) <sil2100> I have REALLY bad timing! <sil2100> Launching pc! <didrocks> launching? <didrocks> no unity tarball still? <toabctl> charles, is there something to do for https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 ? <toabctl> charles, would be cool to provide debug symbols in an extra debian package for the scrollbar. <davidcalle> mhr3, could you have a quick look at https://code.launchpad.net/~davidc3/unity-lens-videos/fix-1056814/+merge/128073 ? <davidcalle> didrocks, is it too late for video lens cherrypicking? utf-8 related crash. <didrocks> davidcalle: urgh, really? :/ <didrocks> is it new? <davidcalle> didrocks, no, but I'm discovering it, it's a regression from a few weeks ago apparently. <didrocks> davidcalle: I will really mandate automated testing when you get issues like this <mhr3> davidcalle, the first should be uri, that shouldn't need encoding <davidcalle> didrocks, I'm discovering this part of the code. I will update myself on automated testing next cycle :/ <didrocks> mhr3: can you review it then? <mhr3> although zg isn't really forcing uris to be properly encoded uris <davidcalle> mhr3, yeah, but the bug report is about the uri not being correctly encoded <didrocks> davidcalle: if you can do the needed change in ack from mhr3 in the coming 3 minutes, I'll upload it :) <mhr3> meh, ack :) <davidcalle> didrocks, mhr3, thanks, om26er pinged me about it this morning but I couldn't access my own computer until know. <davidcalle> now* <mhr3> lenses are getting messy, libunity should do more than it does <didrocks> well, the video lens is still messy, I type the exact string of files name and it can't find them <mhr3> cause it's searching in ~/Videos only <toabctl> didrocks, if I want to add a -dbg package for the overlay-scrollbar, is bzr branch lp:~ubuntu-desktop/ayatana-scrollbar/ubuntu the right place to start a branch? <didrocks> mhr3: no, I see it at first glance <didrocks> toabctl: right, but why do you want to do that? <davidcalle> didrocks, odd, it's using locate. <didrocks> mhr3: I see it in the first panel, with no search <mhr3> didrocks, yes, the no-search results are populated by zg query <didrocks> like sliders.blablabla <didrocks> ah <didrocks> that's weird <mhr3> i think we should sru it to do things properly <didrocks> or not consistent :) <didrocks> yeah <toabctl> didrocks, because of https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 . maybe there will be other problems in the future and then it's nice to have the symbols araound. <didrocks> toabctl: we do have symbols in ubuntu <didrocks> toabctl: we don't need -dbg packages <toabctl> didrocks, hm. how to get the ??? resolved, then? <didrocks> toabctl: https://wiki.ubuntu.com/DebuggingProgramCrash <didrocks> mhr3: davidcalle: uploaded <davidcalle> mhr3, to be consistent, Zeitgeist could index all your files *cough* <davidcalle> didrocks, thanks! <didrocks> davidcalle: yw :) <davidcalle> mhr3, kidding :) <didrocks> davidcalle: is there any reason why the search doesn't include Zeitgeist? * didrocks sees mhr3 becoming a green hulk :) <mhr3> davidcalle, yea... no :P <mhr3> it's a log, not an index <mhr3> indexer* <davidcalle> didrocks, the logic has changed this cycle, zg results were in a Recently viewed category in Precise. Now, it's merged, but the search hasn't been added. Would be great indeed. <toabctl> didrocks, cool. thanks! <didrocks> davidcalle: can be a SRU I guess, yep <didrocks> toabctl: yw :) <mhr3> hmm, that reminds me, design often wants something changed visually but forget to tell us how the behaviour should change to deal with that visual change <toabctl> didrocks, how does this work? do you build all packages without optimization and upload the packages to ddebs with the dbgsym suffix? <didrocks> toabctl: we build all package with debug symbols (but optimisations also, it's separate) <didrocks> packages* <didrocks> then, we strip the symbols in another files <didrocks> (pkgbinarymangler is doing that) <didrocks> and upload that in the separate archive (to not double the size of the index) <toabctl> didrocks, that's full automatic? without any -dbg stuff in debian/control files? <didrocks> toabctl: yeah, all packages in ubuntu go throught that <didrocks> toabctl: we just have another package installed in the chroot <didrocks> and hooking that <didrocks> toabctl: you can install it yourself: pkg-create-dbgsym <toabctl> Cimi, charles : I updated the bug report and the branch for the overlay-scrollbar. please review again: https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 <charles> toabctl: cool! <charles> toabctl: I was just looking at that too, we're doing a lot of unnecessary work in the hijacked-dispose callback <charles> which was what caused Priv to get called while the widet was being disposed <toabctl> charles, the DestroyNotify callback definitly fixes a mem leak. So imho that's a must. <charles> I was just about to offer that on top of your patch <charles> toabctl: agree <charles> toabctl: but allocating memory and setting it in a widget's qdata in that widget's dispose function... not good <charles> IMO we need two fixes here <charles> toabctl: also, thanks for the test program you submitted to demonstrate the leak. I wish all leak reports were this good <toabctl> charles, agree. allocating mem in a dispose function is bad. <toabctl> charles, I just wanted to port d-feet to Gtk3. Then I ended at the scrollbar while searching for mem leaks :-) <toabctl> charles, btw: there seems to be another leak (reported by valgrind for the same program). but I don't understand it: http://paste.ubuntu.com/1260522/ * charles looks <charles> toabctl: I think that's a false positive <charles> toabctl: or rather, it's something that's happening deep inside the dependencies that we can't control <charles> toabctl: http://sourceware.org/bugzilla/show_bug.cgi?id=2314 <ubot5> sourceware.org bug 2314 in libc "nss_parse_service_list leaks a tiny amount of memory" [Minor,Resolved: wontfix] <toabctl> charles, ah. thanks! <charles> Cimi, toabctl: https://code.launchpad.net/~charlesk/ayatana-scrollbar/lp-1058205/+merge/128087 <toabctl> charles, what about the CI comment for your branch? all links are just 404.... <charles> toabctl: CI is having a hard day :) <charles> toabctl: alesage is looking at it <alesage> toabctl, on it, a few min <toabctl> alesage, cool. <toabctl> charles, how to get the fix into 12.10? do you do a new release? or should the patch be provided in debian/patches? <charles> that's up to the packager. I didn't check when the last ayatana-scrollbar release was, they may patch or they may release <charles> toabctl: ^ <toabctl> charles, I'll ask didrocks. he did the last upload. <toabctl> charles, thanks for the help! <charles> toabctl: seb128's on it <toabctl> charles, ok #ubuntu-unity 2012-10-05 <ricotz> racarr, hi :) <ricotz> racarr, do you think you could make bamf's dependency on libunity-webapps optional? <jbicha> hey, we have an issue with yesterday's unity update <jbicha> because of the fix for bug 1055019, deja-dup, empathy, nautilus, & shotwell depend on libunity9 which depends on unity-common which depends on compiz-gnome <ubot5> Launchpad bug 1055019 in libunity (Ubuntu) "libunity9 should depend on unity-common" [Medium,Fix released] https://launchpad.net/bugs/1055019 <jbicha> but the Ubuntu GNOME Remix doesn't ship compiz... <Mirv> jbicha: uh oh :( so you had already libunity9 installed, but now the deps bring compiz as well? that's indeed not pretty <sil2100> This is hm, indeed problematic <sil2100> I think the dependency to compiz-gnome is due to unity-common including the setting migration files <sil2100> seb128: hi! <seb128> sil2100, hey, how are you? <sil2100> seb128: rather fine, thanks, how about you? <seb128> sil2100, I'm good thanks <jbicha> I filed bug 1062099 <ubot5> Launchpad bug 1062099 in libunity (Ubuntu) "libunity9 now depends on unity-common which depends on compiz" [Undecided,New] https://launchpad.net/bugs/1062099 <jbicha> Mirv: I mean we'd prefer not to include libunity9 either but that's not possible (at least not this release) <seb128> jbicha, Mirv: I guess the easiest way out for this cycle is to revert the Depends and make the code bail out nicely when the schemas is missing <jbicha> unity-mail should check if the schema exists before trying to call it <seb128> it doesn't call it, it just uses libunity which uses a key from the schemas <mhr3> it should be fixed in libunity, it's a foreign schema, it should deal with it not being there <didrocks> sil2100: so, you did ping upstream? I think we should fix that quickly * didrocks is concerned to not see things being act on here, apart from the great mhr3 always watching :) <didrocks> mhr3: I have a simple recipe to detect the schema, but I'm not confortable with the side effect of not setting a preference value <didrocks> mhr3: so I think you would be the best to do the change <didrocks> I think you know about the "list_schemas" hack? <mhr3> i'll have to fix tests as well anyway, they expect the schema is there too <didrocks> (I think we should really have an upstream glib call for it) <mhr3> +1 <didrocks> I'm having this hack in 6 places already :/ <mhr3> whose idea was it that crashing an app is better than using a GError? :P <mhr3> hmm desrt? <didrocks> yep :) <didrocks> and he's quite adamant for it <sil2100> didrocks: once mhr3 is ready with a fix, should we distro-patch it? <didrocks> yeah <didrocks> thanks mhr3 for noticing it yourself. I was excepting you would be warned by the integration team (and was waiting on that) <popey> didrocks, we were just discussing it before you arrived <didrocks> popey: since 10h10? :/ <didrocks> and where the discussion was going on? should be on this channel, isn't it? <popey> it wasn't here no <didrocks> it should though <didrocks> and 50 minutes to discuss about pinging upstream seems to be quite seriousâ¦ <popey> i was actually waiting for you to get off your hangout to ping you, but you saw it first <didrocks> popey: well, I saw it at 9:30 <popey> great. <didrocks> then, I told jbicha to ping you guys here <didrocks> then first answer 24 minutes after the concern was raised, and no upstream ping in 50 minutes, I'm concern about the effectivness TBH <mhr3> sil2100, didrocks, proposed the libunity branch <didrocks> sweet! we need someone testing it without having the schema installed (and so not compiled, removing the schema is not enough) <mhr3> fwiw i tried by just settings XDG_DATA_DIRS to something weird <didrocks> that should work, as long as the app using it doesn't have schema installed :) <mhr3> otoh didn't try to call any of the methods in that case <mhr3> but since all just lookups into empty hashtable they should just return false <didrocks> mhr3: maybe trying with empathy and other from the list above? ^ <didrocks> nautilus is a good one <didrocks> IMHO <mhr3> didrocks, i don't think nautilus is one of those apps that can survive without any schemas :) <didrocks> yeah, that's why rm schema + recompiling them <didrocks> mhr3: who is reviewing your branch? <mhr3> didrocks, ehm, you? :) <didrocks> as the integration team will probably prepare the distro-patch, I think they will test it at the same time, so they should? <mhr3> sil2100, ^ <didrocks> I must admit that it's more elegant that in C :) <didrocks> schema in Settings.list_schemas (); <didrocks> :) <mhr3> hmm... why didn't i do that? <mhr3> i guess i like extra variables :P <didrocks> seems so :) <didrocks> to show you know the "unowned" :p <mhr3> right, what if vala copied the array in that case? that would be horrible waste of cpu and memory :P <didrocks> heh <didrocks> mhr3: so vala copies everything by default? <mhr3> would surely waste at least 3nanoseconds <mhr3> not in that case :) <didrocks> yeah, but if it's not unowned? <jokerdino> hey, unity dash looks weirdish with no blur. is that a known bug? <mhr3> then yea, string[] arr = get_something_unowned(); will copy the array <sil2100> ugh, sorry, I was busy copy-pasting some bugs <didrocks> interesting <sil2100> Looking at the merge request <didrocks> mhr3: but string a = b; <mhr3> didrocks, that too <didrocks> and if I want to share the same ref? it needs to be unkowned on a? <mhr3> yep <didrocks> but then, you need b to go out of scope after a <mhr3> exactly <didrocks> there is no way to still have automatic freeing generation with b going out of scope before a? and they still share the same reference? <mhr3> so unowned needs to be used with care <mhr3> didrocks, well what would you do in that case? <didrocks> counting the number of reference :) <mhr3> the reference is invalid if b gets out of scope <didrocks> yeah, but there can be a "magic" keyword telling a = b target the same ref <mhr3> yea, of course for ref-counted objects Obj a = b; just increases the refcount <didrocks> ok, just not on basic types? <didrocks> as string a = b; triggers a copy <mhr3> string is always special :) int a = b also doesn't need references :) <didrocks> ok, it's only for the basic types :) <mhr3> and structs <didrocks> I was starting to think it was for everything <didrocks> hence my "getting scared" :) <mhr3> no worries, it's sane :) <didrocks> heh <sil2100> davidcalle: ping <davmor2> popey: can you confirm a bug for me please. from a fresh start on quantal flick through the dash lenses how many of the See more results arrows are pointing down instead of right? I'll go grab you the bug number <popey> sure <davmor2> popey: nevermind bug got duped so is already confirmed https://bugs.launchpad.net/unity/+bug/1053047 <ubot5> Ubuntu bug 1053047 in unity (Ubuntu) "Dash - Category expander arrow is in expanded mode no metter if category is actually expanded." [Medium,In progress] <popey> FINE! <popey> :) <davmor2> popey: I was looking at mine rather than the dupe and wondering why it wasn't confirmed <davmor2> popey: I blame my cold <jokerdino> popey: have you found any bug with dash and no blur setting? <davmor2> popey: although gdocs is still desparate to download the spreadsheet I want to interact with as a pdf :D <popey> jokerdino, can you be more specific? <Mirv> wasn't there this "jumping" of background with no blur? <Mirv> I think it was mentioned, but I'm not sure if a bug was filed <dandrader> the launcher in my desktop only comes up if I press the super key. It no longer shows up when I push the pointer against the left screen edge. I'm in Quantal. How can I fix it? <popey> dandrader, nvidia? <dandrader> yes <popey> bug 1057000 <ubot5> Launchpad bug 1057000 in xorg-server (Ubuntu) "[Ubuntu 12.04.1/12.10] nVidia drivers 304.51 prevent autohidden Unity launcher from revealing" [High,Triaged] https://launchpad.net/bugs/1057000 <popey> probably <dandrader> popey, hmm, ok. I'll have a montgomeryrobert@example.net. Thanks! <popey> jokerdino, bug 1058391 <ubot5> Launchpad bug 1058391 in unity (Ubuntu Quantal) "[no blur] Desktop rolls over unity panel vertically when i open the dash or hud" [High,Confirmed] https://launchpad.net/bugs/1058391 <popey> Mirv, that one? ^ <Mirv> popey: yes, that one <jokerdino> sorry and thanks popey. i think that's the bug i was looking for <popey> np <didrocks> sil2100: Mirv: is libunity backported and tested now? <sil2100> didrocks: tested - yes, backported - no... but I'll do that in a moment, just need 5 more minutes <didrocks> tested without the schema installed, right? <didrocks> backporting then is just a 2 min manipulationâ¦ <sil2100> didrocks: I know, I should have done it ASAP once the testing was done, just picked up something else to do in the meantime ;( <didrocks> sil2100: didn't I say this one would be urgent and ask for working on it since this morning? :/ <didrocks> TBH, I think there are some priotization issue on your team (one hour to start pinging upstreamâ¦ 30 minutes to tell "oh it's vala, we should get someone else to review it" and right now, more than one hour and 20 minutes since it's merged upstream and still not backported) <didrocks> so it will soon be too late to push it for the week-end <sil2100> https://code.launchpad.net/~sil2100/libunity/ubuntu_6.8.0-2 <sil2100> Packaging with the cherry-pick <sil2100> I removed the unity-common dep as well <Mirv> thanks sil2100, cherry-pick is the right way to go atm so that it's gotten in as soon as possible <didrocks> sil2100: thanks, looking <didrocks> sil2100: did you try your cherry-pick? <sil2100> didrocks: the cherry-pick I just posted was test-built, but its almost the same thing as what I tested basically <didrocks> sil2100: test-built but not tested, right? <sil2100> I can re-test it without the schemas now again <didrocks> well, you should <didrocks> because from what I can see it's wrong <didrocks> I'm sure mhr3 can find quickly what's wrong :) <didrocks> sil2100: still don't get it? I clearly showed the issue at the integration sprint with vala projectsâ¦ <sil2100> didrocks: still looking, give me a moment more <Daviey> wait, didrocks.. you know the cause of a problem, and there is wasted effort in trying to duplicate the discovery ? <didrocks> Daviey: well, popey's teaÃ¹m <didrocks> Daviey: want to progress <Daviey> didrocks: and you know the answer, and haven't shared it? <didrocks> Daviey: the issue already happened 3 times in the past and I did showed it <Daviey> SO you are proving a point now? <didrocks> Daviey: so it's some kind of training for them to find it until they ask <didrocks> Daviey: hence his "give me a moment more" <tsdgeos> any idea how to unit test https://code.launchpad.net/~aacid/unity/do_not_reuse_menus_on_order_change/+merge/128243 ? <Daviey> This is a total waste of time didrocks <tsdgeos> Trevinho: â <seb128> Daviey, some people seem to not learn when you don't let them think by themself about the issue for a while <Daviey> seb128: Have they requested this sort of support? <Trevinho> tsdgeos: for the change in Indicator33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abGetEntry there are unit tests <seb128> Daviey, what "support"? <Trevinho> tsdgeos: just integrate them with your api change <tsdgeos> Trevinho: i'm more concerned about the dbus one <Daviey> seb128: exactly. <Trevinho> tsdgeos: there are still no tests for that... <Trevinho> tsdgeos: I started doing it some time ago, but it was too long and I didn't continue due to other priorities <Trevinho> tsdgeos: however, you can use Autopilot, or.... (much better) would be adding a new test suite to test-gtest-dbus <Trevinho> tsdgeos: basically you need to add a fake unity-panel-service there <Trevinho> and use DbusIndicators to connect to that <Trevinho> tsdgeos: at that point you can test everything you want <tsdgeos> ok, that's going to be a hard exercise :D <Trevinho> tsdgeos: however, imho instead of changing Entry33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abPtr Indicator33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abGetEntry, imho it's better to add Indicato33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abntryIndex method <Trevinho> tsdgeos: yeah :) <Trevinho> tsdgeos: more boring than hard <tsdgeos> Trevinho: well, never done any of that dbus stuff, so i need to do some c&p and be lucky ;-) <tsdgeos> Trevinho: well, the think is that i want both the entry and the index <tsdgeos> feels a bit silly doing the loop twice <Trevinho> tsdgeos: yeah, I know.. but it should not really impact a lot <tsdgeos> or you mean that EntryIndex should return both the entry and the index as my modified GetEntry ? <mhr3> didrocks, can i? i see it properly cherrypicked <didrocks> mhr3: vala man, vala when shipping câ¦ <tsdgeos> Trevinho: ok, i'll add the new function <mhr3> didrocks, we changed the build system, no more .c files ;) <didrocks> mhr3: we still have them in the packaging dir <mhr3> didrocks, at least not in tarball <didrocks> mhr3: so until we remove themâ¦ <Trevinho> tsdgeos: or another clean way would be to set the index inside an entry since it looks like that you want an entry to only have a specific index <didrocks> (we should do that for R) <mhr3> didrocks, i actually think the build system should pick it up properly <didrocks> mhr3: was it tested? <didrocks> mhr3: I'm quite afraid by that <mhr3> but maybe i'm wrong, i don't see into the packaging build <tsdgeos> Trevinho: i can do what you prefer :-) <didrocks> sil2100: so, if the build system is covering this right now, I may be wrong, it just needs a double check <didrocks> sil2100: but remember what I told about .vala files trick -> when we have .c files, they are not always regenerated (because of vala ignoring timestamps) <mhr3> sil2100, if you have your pkg installed do `XDG_DATA_DIRS=/home python -c "from gi.repository import Unity; print Unity.LauncherFavorites.get_default();" <mhr3> sil2100, if it crashes it's bad :) <mhr3> if there are two warnings it's good <sil2100> mhr3: just get a warning <sil2100> mhr3: (process:28044): libunity-WARNING **: unity-launcher.vala:373: Schema "com.canonical.Unity.Launcher" is not installed! <didrocks> sil2100: ok, in that case, I'll take it <sil2100> mhr3: I just tried it on tests too, no crashes <didrocks> sil2100: I'll just downgrade it to Suggests, but that's a personal nitpick <sil2100> didrocks: ok, thanks <mhr3> didrocks, see how nice we made vala behave with debs now ;) <didrocks> mhr3: is that for every projects you did that? <mhr3> at least in libunity, still a problem everywhere else :P <didrocks> mhr3: so that I don't do sil2100 searching something for nothing :p <mhr3> sil2100, keep in mind ^ <sil2100> .o> <didrocks> mhr3: so lenses have this build system enhancement? <mhr3> <mhr3> at least in libunity, still a problem everywhere else :P <didrocks> ok, everywhere like everywhere :) <didrocks> sil2100: can you note that down? ^ something good to note for next cycle "converting vala lenses to not ship .c file" ^ <mhr3> but ultimately it's a matter of getting .c away from tarballs <mhr3> patches for that welcome :) <mhr3> took me like a week to tune the build system in libunity to do that (and distcheck pass) :P <didrocks> mhr3: if you have the commits rev handy, can be useful to have it :) <mhr3> didrocks, the most important part of it is 153.3.8 <didrocks> sil2100: ^ <mhr3> i have to note that i still like x.y.z revnos better than a hash of every commit :P <mpt> To whom it may concern: The most common unfixed crash in Q is currently http://launchpad.net/bugs/1062037 in unity-lens-video <ubot5> Error: ubuntu bug 1062037 not found <mpt> ubot5, try harder <didrocks> sil2100: working fine for me, pushing it to quantal! Thanks (just added the suggests). <didrocks> mpt: I guess this one was fixed yesterday evening <didrocks> I backported an additional commit for it <mpt> great <mhr3> i think crashes of binaries should have bigger weight on errors.ubuntu.com <mpt> mhr3, bigger weight than what? <didrocks> mhr3: errors.ubuntu.com is just about crashes :) <mhr3> it's just full of python exceptions <mpt> mhr3, only unhandled exceptions, though, right? <mhr3> yes, but that doesn't mean fatal ones <mhr3> or does it? * mpt doesn't know <mhr3> still i think a separate view with most common sigsegvs would be useful <mpt> We'd like to make it more personally useful in general <mpt> Show you just the kinds of errors you are good at fixing yourself <mpt> for example <mpt> It already does individual packages, a next step would be package sets e.g. "Ubuntu Desktop" or "Xorg" <mpt> and classifying by error type e.g. sigsegv would be interesting too <mhr3> the problem is that we don't get anything else than segfaults for non-interpreted apps <mhr3> freezes could be useful, but that's not that simple to detect <mhr3> possible though :) <didrocks> sil2100: around? <popey> didrocks, he's on a late lunch <didrocks> popey: ok, no hurry anyway, or maybe do you want us to discuss about what's needed for a SRU? <sil2100> didrocks: what's up? <didrocks> sil2100: so, I wanted to discuss with you about SRU/prioritization, do you have a minute? <didrocks> if you don't today, that can wait on Monday <popey> didrocks, how about a call with you me mirv and sil2100 first thing on monday morning? <popey> (your first thing, not mine) <didrocks> popey: sounds good to me <popey> ok I'll set it up <didrocks> thanks! <sil2100> didrocks, popey: ok, so let's do it on Monday then <didrocks> sil2100: it will be more an opened question on how to organize as I can only showed you what we did in the past and what worked (and rather what didn't really work) <didrocks> sil2100: so if you can think on some way to organize the SRU until then, please come with suggestions :) <popey> sil2100, you okay to start at 06:00 UTC? <popey> I think he fainted. <didrocks> :) <didrocks> you should maybe consider later for him then :) <didrocks> (especially on a Monday) <popey> heh <popey> done * didrocks likes how thunderbird is condering popey's mail as a spam and doesn't want me to click on "accept" the invitation <sil2100> didrocks: ACK <sil2100> popey: I'm okay with anything * popey moves it to 03:00 UTC <sil2100> HEY <sil2100> Maybe not *anything* <sil2100> ;) <didrocks> ahah <didrocks> sil2100: too late! <tsdgeos> Trevinho: uploadded the unittest to https://code.launchpad.net/~aacid/unity/do_not_reuse_menus_on_order_change/+merge/128243 <tsdgeos> hope that is what you suggested :D <tsdgeos> aaaaaaand weekend time <tsdgeos> enojy all #ubuntu-unity 2012-10-06 <Munchor> Hi there, does anybody know where I can find the source code for Ubuntu's keyboard indicator? #ubuntu-unity 2012-10-07 <tham> Is it possible to make the Unity Launcher display only the apps in the current workspace? <Nel> i have problems with sound in ubuntu 12.04 <Nel> distorted sound <meebey> any libmessaging-menu hackers around? I am porting Smuxi from libindicate to libmessage-menu and noticed an API issue that other clients (like xchat-indicate) seem to ignore <sbte> meebey, I ported emesene from libindicate to libmessagingmenu if that helps <meebey> sbte: do you have an URL with the patch? <sbte> meebey, https://github.com/emesene/emesene/commits/752fa1c75e8429cba14ef71476fbab64020ca25f <sbte> all the commits that contain messagingmenu up to the version 2.12.9 commit #ubuntu-unity 2012-10-08 <ricotz> racarr, hi, please consider this bamf change or similar http://paste.debian.net/plain/197585 <tsdgeos> Trevinho: what defines gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abTimeout ? <gord> tsdgeos, https://bazaar.launchpad.net/~unity-team/unity/trunk/view/head:/UnityCore/GLibSource.h#L133 <tsdgeos> gord: ahhh, i thought it was in glibmm or something and couldn't find it anywhere <tsdgeos> didn't think to look inside unity itself ^_ ^ <tsdgeos> tx <gord> yeah unity doesn't use glibmm, so anytime you see something like that, it'll be inside unitycore <gopu> Hi all <gopu> My unity is having some problem working in 3D <gopu> Compiz is taking 100 % Cpu in 3D <gopu> Any idea <gopu> Anyoone here <tsdgeos> gord: Trevinho suggested to change g_timeout_add to gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abTimeout, but the first takes a void* with data and the second not, what's the recommented way of using gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abTimeout? Do i inherit from it to stuff in my data? <tsdgeos> gord: ok, i see how to use it <didrocks> sil2100: Mirv: can you review/approve https://code.launchpad.net/~didrocks/unity/workspace-switch-translation/+merge/128440 please? <didrocks> I'm cherry-picking it in 6.0 meanwhile <sil2100> didrocks: ok, one moment <didrocks> thanks :) <Trevinho> tsdgeos: gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abTimeout can also be called with a lambda function, so you can pass to it anything you want <tsdgeos> yep yep, found that, tx <Trevinho> tsdgeos: I suggest you to check test_glib_source to see better ways to use it or just grep the unity code :) <tsdgeos> yes, did that 15 minutes ago ;-) <Trevinho> tsdgeos: ok, nice :) <tsdgeos> Trevinho: do i really have to move to gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abDBusProxy? calling g_dbus_connection_call_sync really helps and shouldn't hurt in a test <Trevinho> tsdgeos: i tought it was simpler to read/write, but if you want continue with that it's ok.. <Trevinho> tsdgeos: what's the problem with the gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99ab one? <tsdgeos> well, the thing is that i trigger the resync and then ask via dbus if it has sent already to know when to end the waiting loop, but to ask via dbus the function that returns a bool i'm using the sync method that is really convinient <tsdgeos> if i don't have the sync method i need a waiting loop inside the waiting loop <tsdgeos> which is a bit weirdish <Trevinho> tsdgeos: ah, ok <Trevinho> tsdgeos: or feel free to add a CallSync method to gli33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abDBusProxy too :) <tsdgeos> ok, i'll have a look at it <Trevinho> tsdgeos: otherwise another way is just to use the async way.. but after calling it you can just add a utils33ec:265c:71fe:e26d:2682:4ec2:aaa1:99abWaitForTimeoutMSec(msecs); without the need of adding a new loop <tsdgeos> yeah, just didn't want to add a random number in that wait <tsdgeos> i'll try to add the callsync method <tsdgeos> shouldn't be that hard <tsdgeos> last famous words <Trevinho> tsdgeos: hehe :), if it causes too troubles, using the way you're using it's fine as well.. Maybe just add an utility method in TestDBusIndicators, to call a method without repeating all the common parameters (i.e. you pass to it only a method name) <ricotz> mhr3, hi :) <mhr3> ricotz, hey <ricotz> mhr3, you have a moment for bamf? <mhr3> Trevinho, does ;) <mhr3> well.. might ;) <Trevinho> mhr3, ricotz yeah... I have :) <ricotz> mhr3, i already pinged racarr about it <ricotz> ;) <ricotz> i really want to have the webapps dependency optional <ricotz> Trevinho, so maybe you could consider that http://paste.debian.net/plain/197585 <Trevinho> ricotz: well, yes.. I tought the same few days ago... <Trevinho> ricotz: looking <ricotz> Trevinho, it is pretty easy and even doesnt touch the lib <Trevinho> ricotz: looks fair <Trevinho> ricotz: please do a MR for that <ricotz> Trevinho, the depcheck could be done more elegant of course by introducing a real --enable-* flag, but this automatic choice is working <Trevinho> ricotz: one thing, add another bamfdaemon_webapps_headers += ... and don't move the shared headers to bamfdaemon_sources <ricotz> Trevinho, https://code.launchpad.net/~ricotz/bamf/optional-webapps/+merge/128456 <ricotz> Trevinho, yeah <didrocks> sil2100: https://code.launchpad.net/~didrocks/unity/workspace-switch-translation/+merge/128457 <sil2100> didrocks: ugh, ok <didrocks> sil2100: it's better, we don't have anything to do with the manual upload :) <sil2100> didrocks: ok then ;) <tsdgeos> Trevinho: implemented all your suggestions <Trevinho> tsdgeos: cool <ricotz> Trevinho, updated the merge <Trevinho> ricotz: approved <ricotz> Trevinho, thanks :), feel free to merge it then <Trevinho> ricotz: automerger will do that in some minutes <Trevinho> (hopefully) :) <ricotz> Trevinho, alright <ricotz> Trevinho, another problem is for sure that if gtk2 is enabled webapps must be disabled <Trevinho> ricotz: mh probably... <ricotz> Trevinho, not sure if there are plans to drop gtk2 support which would solve this problem of course <Trevinho> ricotz: however I was wondering if we could drop bamf-gtk2... <ricotz> right <Trevinho> even if ginn still depends on it... <ricotz> Trevinho, ah, don't worry the daemon doesnt really have a gtk2 flavor so it isnt broken currently with enabled webapps <Trevinho> ricotz: yeah, i know <Trevinho> tsdgeos: looks good overall, comments added <tsdgeos> Trevinho: the lambdas are actaully different <Trevinho> tsdgeos: mhmh <tsdgeos> Trevinho: i don't get what you mean with "fix the parameters indentation." <Trevinho> tsdgeos: well.. the is-connected one should be called anyway for all tests <mhr3> aaaaaah <mhr3> CallSync in UnityCore <mhr3> nooooooooooooooooo <mhr3> kill it! <mhr3> kill it now! <tsdgeos> Trevinho: well, i mymiced the hud tests, that only do the is connected for the first one <tsdgeos> mhr3: well it was Trevinho that suggested it <tsdgeos> i did not have it originally i'm just doing what you guys ask <Trevinho> tsdgeos: in GLibDBusProxy.cpp there's a missing space.. <tsdgeos> Trevinho: which line? <Trevinho> tsdgeos: 108 in the diff <Trevinho> tsdgeos: about callsync btw why do you added also the g_main_loop thing? <tsdgeos> ah right in the declaration <tsdgeos> Trevinho: because that's how the function you asked me to replace <tsdgeos> works <tsdgeos> callsync is sync <tsdgeos> and thus will wait for the session to be stabilished <tsdgeos> not fail because you're still not connected <Trevinho> just call that... and eventually just make it protected so it won't be mis-used... or if mhr3 really doesn't want it, move back to the old one (but put it into a TestClass method) <mhr3> tsdgeos, Trevinho, it'd be much better to implement a sync-capable subclass somewhere in
{'channel': 'ubuntu-unity', 'month': 10}