#ubuntu-reviews 2010-08-02
<dholbach> good morning
<bdrung> dholbach: edit patch doesn't seem to fit into sponsor-patch
<dholbach> bdrung: I don't understand
<bdrung> dholbach: sponsor-patch is the name for the script that i am writing for the reviewers team
<dholbach> right
<dholbach> I'm sorry, I still don't understand
<dholbach> what does "fit into" mean in this context
<bdrung> sponsor-patch has to apply the downloaded patch, but edit-patch is designed for editing a patch
<dholbach> ah ok
<dholbach> maybe it needs some kind of option
<dholbach> like -n for "non-interactive" or something
<dholbach> mvo would know better than I do if this makes sense
<dholbach> maybe you can have a chat with him?
<bdrung> k
 * dholbach hugs bdrung
<dholbach> awesome
<bdrung> dholbach: sponsor-patch will be a eierlegende Wollmilchsau
<dholbach> bdrung: really? doesn't it just have one task?
<bdrung> dholbach: it can be used for sponsoring (SRUs, merge), too
<dholbach> ah ok
<bdrung> dholbach: at least sponsoring SRUs works already
<dholbach> nice
<bdrung> dholbach: sponsor-patch has already 400 loc
<dholbach> holy cow
<dholbach> thanks for your work on this
<aftabraja3> hi
#ubuntu-reviews 2010-08-03
<dholbach> good morning
#ubuntu-reviews 2010-08-04
<dholbach> good morning
<MWelchUK_work_> dholbach, morning
<dholbach> hi MWelchUK_work_
<MWelchUK_work_> dholbach, is there anything I can do to speed up an update to fix bug #524366 for 10.04?
<ubot4> Launchpad bug 524366 in gzip (Fedora) (and 1 other project) "Regression: CRC error an i386 (affects: 19) (dups: 1) (heat: 113)" [Unknown,Unknown] https://launchpad.net/bugs/524366
<dholbach> MWelchUK_work_: I'll ask in #ubuntu-devel for somebody to review the branch
<dholbach> that's all I can do
<MWelchUK_work_> This regression has been known about since nearly 2 months now.
<MWelchUK_work_> That would be great.
<dholbach> can you join #ubuntu-devel?
<MWelchUK_work_> yup.
#ubuntu-reviews 2010-08-05
<dholbach> good morning!
<dholbach> Packaging Training Session: Fixing Small Ubuntu Bugs in 18 minutes in #ubuntu-classroom
#ubuntu-reviews 2010-08-06
<dholbach> good morning!
#ubuntu-reviews 2010-08-09
<dholbach> good morning
#ubuntu-reviews 2010-08-10
<dholbach> good morning
#ubuntu-reviews 2010-08-11
<dholbach> good morning
<devildante> Hello
<devildante> When subscribing ubuntu-sponsors to a bug, should I unsuscribe the ubuntu-review team?
#ubuntu-reviews 2010-08-12
<dholbach> good morning
<dholbach> HAPPY HUG DAY!
<dholbach> salut jibel
<dholbach> comment Ã§a va?
<jibel> guten tag dholbach
<dholbach> :)
<jibel> ca va et toi ?
<dholbach> un peu fatiguÃ©e mais ca va :)
<dholbach> fatiguÃ©
<vish> dholbach: how many languages do you know? :)
<dholbach> jibel: ca va bien, c'est 'UG DAY aujourd'hui :)
<dholbach> vish: not enough :)
<yofel> morgen ^^
<dholbach> vish: I'm sure you speak more than I do :)
<jibel> without the 'e' is better for a man :)
<dholbach> Indians all speak more languages than anybody else
 * vish parle un peu de francais ;)
<dholbach> jibel: yeah, it took me a bit to realise :)
<yofel> dholbach: your merge on bug 586790 still being looked at?
<ubot4> Launchpad bug 586790 in software-properties (Ubuntu) "Typo in --help of apt-add-repository (affects: 2) (heat: 12)" [Low,Triaged] https://launchpad.net/bugs/586790
<dholbach> yofel: I'll pester mvo
<dholbach> once he's up
<yofel> ok
<dholbach> what a slacker!
<yofel> more like, shouldn't that be merged into lp:software-properties not lp:ubuntu/software-properties ?
<dholbach> yofel: software-properties is probably a special case
<dholbach> I was demo'ing the general approach of getting something into Ubuntu
<dholbach> getting the fix upstream is a different story
<dholbach> but yeah, I agree
<yofel> ah ok
 * dholbach starts doing a bit of sponsoring, will join you for some patch review in a bit
<dholbach> "LP will go down for maintenace in 30 seconds."
<dholbach> :-(
<vish> argh! great day for lp maintainance! we have feature freeze as well today :(
<dholbach> yep, good timing
<dholbach> hey seb128
<seb128> hey dholbach
<dholbach> seb128: thanks for getting the gdm fix in
<dholbach> awesome
<seb128> dholbach, yw
<dholbach> seb128: merci beaucoup mon vieux ami :-P
<seb128> de rien mon jeune ami !
<dholbach> haha
<dholbach> I'm older than you!
<seb128> you call me old so ... ;-)
<dholbach> OK! The HUG DAY is back! :)
<dholbach> yoohoo!
<dholbach> how's the reviews coming on?
<dholbach> Packaging Training Session: Patch Review and Operation Cleansweep in #ubuntu-classroom in 5 minutes
<pedro_> see dholbach
<dholbach> haha pedro_
<dholbach> pedro_: we just had a session in #ubuntu-classroom about the patch reviewers process
<dholbach> and will now work on a few examples together
<dholbach> I'm sure we'll have a bunch of questions for you in a bit :)
<pedro_> dholbach, cool! is the log available somewhere?
<pedro_> dholbach, so we can link it on the hug day page ;-)
<dholbach> pedro_: not yet, but I'll give you the link once the session is done and the log available
<pedro_> dholbach, ok, thanks!
<pedro_> reboot, brb
<norax> dholbach : are you choosing a bug? or are we finished?. "thanks for the questions" seems for me like we are finished, and I would like to see an example.
<dholbach> oh ok
<dholbach> I just did https://bugs.edge.launchpad.net/ubuntu/+source/sabayon/+bug/595608
<ubot4> Launchpad bug 595608 in sabayon (Ubuntu) "Sabayon-apply fails on mozilla_bookmarks (affects: 2) (heat: 12)" [Undecided,Fix released]
<dholbach> with a bit of investigation I found that it was fixed already
<dholbach> one I did before was https://bugs.edge.launchpad.net/debian/+source/python-mysqldb/+bug/588859
<ubot4> Launchpad bug 588859 in python-mysqldb (Debian) (and 2 other projects) "python-mysqldb silently drops exceptions on deadlocks (affects: 1) (heat: 8)" [Unknown,Unknown]
<dholbach> (the person had forwarded the patches to debian and upstream already
<dholbach> )
<dholbach> so I added the upstream/debian bugs to the bug's tasks and added the tags
<dholbach> also if you check out https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide#Examples there's a couple more examples
<dholbach> I thought we'd now all go and try to work on bugs/patches individually and bring up questions as soon as we have them
<dholbach> which patches/bugs are you currently looking at? anyone ran into problems already?
<devildante> I'd like to add that if you did an ubuntu-sponsors merge request, there is no need to subscribe them to the bug
<dholbach> devildante: hm?
<devildante> (talking by experience :p)
<dholbach> ah yes
<yofel> hm, we don't have an example for a merge request in the Examples. I did bug 601127 yesterday, but there I had to patch the patch
<ubot4> Launchpad bug 601127 in update-manager (Ubuntu) (and 1 other project) "don't hide treeview and notebook when some package is available but not installable (affects: 1) (heat: 12)" [Low,Fix released] https://launchpad.net/bugs/601127
<yofel> someone got a cleaner one?
<dholbach> pedro_: https://wiki.ubuntu.com/Packaging/Training/Logs/2010-08-12
<dholbach> yofel: if you find one, can you add it to https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide#Examples ?
<pedro_> dholbach, thanks! linking it right now
<yofel> sure
<dholbach> yeeeeeeehaw
<dholbach> awesome
<dholbach> I got a few of them off the list already
<dholbach> looking forward to see http://qa.ubuntu.com/reports/patches/ later on
<kamusin> glad to see you here devildante :)
<devildante> kamusin: hi :)
<kamusin> hey devildante how are things today with the hugday?
<devildante> kamusin: not very well, still busy with my addons branch
<dholbach> how are you guys getting on?
<devildante> kamusin: but I think my work of yesterday is enough to compensate :p
<kamusin> heh
<dholbach> how are we doing in terms of reviewing bugs/patches? :)
<dholbach> I should've made a note where we started today :)
<dholbach> pedro_: could it be that bugs.g.o is very slow?
<dholbach> pedro_: what is the bugzilla component for mobile-broadband-provider-info?
<dholbach> modem-manager found it
<dholbach> thanks
<dholbach> :)
<pedro_> dholbach, bugzilla is slow for you? it's working fine here
<dholbach> it's better now
<dholbach> pedro_: how can I add https://bugzilla.gnome.org/show_bug.cgi?id=626731 to https://bugs.edge.launchpad.net/mobile-broadband-provider-info/+bug/447380 ?
<ubot4> Gnome bug 626731 in ModemManager "Support for Croatian Academic and Research NETwork" [Normal,Unconfirmed]
<pedro_> looking
<pedro_> i see, since the project is already registered in launchpad as upstream lp doesn't allows you to add the upstream link
 * pedro_ kicks lp
<dholbach> oh ok
<pedro_> let me try something , one sec
<pedro_> dholbach, looks like the only solution is to reject that upstream tasks for mobile-broadband-provider-info, open one for NM and put the link there...
<pedro_> lp fault
<dholbach> yeah, whatever :)
<pedro_> would be great to have a link here to create those: https://bugs.launchpad.net/bugs/447380/+watch/79578
<ubot4> Launchpad bug 447380 in mobile-broadband-provider-info (Ubuntu) (and 1 other project) "Support for Croatian Academic and Research NETwork (affects: 1) (heat: 8)" [Undecided,New]
<pedro_> "There are currently no links to this bug watch" I'd love to have a "create one" button there...
<dholbach> yeah
<ara> dholbach, where did you upload the logs of the session you just gave?
<dholbach> ara: https://wiki.ubuntu.com/Packaging/Training/Logs/2010-08-12
<pedro_> ara,  https://wiki.ubuntu.com/Packaging/Training/Logs/2010-08-12
<dholbach> HA! QUICKER! :)
<pedro_> high five!
 * dholbach hugs pedro_
 * pedro_ hugs dholbach back
<dholbach> pedro_: Â¡COGE EL AVE!
<pedro_> lol!
<dholbach> it doesn't get old :)
<ara> :D
<dholbach> 1501!
<dholbach> 1499!
<dholbach> 1494!
<dholbach> 1492!
<dholbach> awesome
 * dholbach hugs you all
<devildante> guys, bug 600989 is for a bug that doesn't have an upstream bug tracker. should I seek Ubuntu sponsorship?
<ubot4> Launchpad bug 600989 in multimon (Ubuntu) "Wrong sox syntax in gen.c (output) (affects: 1) (heat: 90)" [Undecided,New] https://launchpad.net/bugs/600989
<devildante> for a package*
<simar__mohaar> devildante: what to do for todays hug day. I hope to involve too ..
<yofel> https://wiki.ubuntu.com/UbuntuBugDay/20100812
<devildante> follow this for each bug: https://wiki.ubuntu.com/ReviewersTeam/ReviewGuide#Workflow
<simar__mohaar> yofel: devildante thanks, I see myself as a potential contributer here. :))
<devildante> how can we know progress of operation cleansweep?
<elopio> devildante: there's a plot here https://wiki.ubuntu.com/UbuntuBugDay/20100812
<devildante> thank you, elopio :)
<norax> Hi. I have a patch that is included in a release in debian unstable but not in testing (and not in maverick). I have added the tag patch-accepted-debian, but do I have to do anything more? I mean, the bug is still New, do I have to change to fix commited or something like that?
<nigelb> norax: which app?
<norax> nigelb: its pmccabe. In unstable is in 2.6 but we have 2.5 in maverick.
<nigelb> norax: you can request an ffe.
<norax> nigelb: Whats an ffe?
<nigelb> !ffe
<ubot4> Feature Freeze Exception. See https://wiki.ubuntu.com/FreezeExceptionProcess for the freeze exception process.
<nigelb> sorry about the jargon
<norax> No problem. Thanks.
<nigelb> oh, ugh, that might require a merge and not a sync though
<nigelb> ok, just a sync would do!
<norax> It is a sync. But  I do not know if it worths. It is not a critical package and if it is not in testing I assume that it is not testing enough
<nigelb> norax: its not in testing because I think debian is frozen now.
<norax> nigelb: Thanks. I think I am going to request an FFE. Let's see what happens
<nigelb> norax: And I just confirmed from maco that debian is indeed in freeze :)
<norax> nigelb: then should I ask an FFE also for debian?
<nigelb> Don't think so.
<nigelb> It was their final freeze I think.
<norax> I have request an FFE: https://bugs.launchpad.net/ubuntu/+source/pmccabe/+bug/616977 but I do not know, maybe it is too much work (not just mine, but the ubuntu release team, and later the sponsor team) for something that will be automatically repaired in 11.04.
<ubot4> Launchpad bug 616977 in pmccabe (Ubuntu) "ask for an FFE syncing from debian unstable (affects: 1) (heat: 8)" [Undecided,New]
<rsajdok> Do I understand. Forward to debian-upstream is to run program: submittodebian ?
<norax> submittodebian sends an email from your account that creates a bug in their track system, so I think that you are right, debian-upstream is to run this program.
<rsajdok> norax: It would be good if someone confirm this
<norax> nigelb: It seems that as the update is bug fix only, no FFe is required.
<yofel> rsajdok: yes submittodebian would be the easiest way, esp. if you already packaged the patch to test it
<yofel> about bug 613407 - it's adding a check to not make dkms fail if a config file doesn't exist, but the config file is actually installed by the dkms package so should never be missing unless deleted, does that even make sense to fix?
<ubot4`> Launchpad bug 613407 in dkms (Ubuntu) "/etc/kernel/header_postinst.d/dkms exited with return code 2 (affects: 2) (dups: 1) (heat: 494)" [Undecided,New] https://launchpad.net/bugs/613407
#ubuntu-reviews 2010-08-13
<chilicuil> hi, I'd like to help to review some patches as part of the bugday, I'm watching bug 614907 and the diff doesn't apply to the latest net-tools source ($bzr branch lp:/ubuntu/net-tools), should I reject it?, it looks to me like the patch is useful, should I send it to debian/berlios instead?, I dont have the hardware to test it, should I avoid touching it?
<ubot4`> Launchpad bug 614907 in net-tools (Ubuntu) "Add suppport for IEEE 802.15.4 hardware in net-tools (affects: 1) (heat: 8)" [Undecided,New] https://launchpad.net/bugs/614907
<dholbach> good morning
<jibel> good morning dholbach
<dholbach> hey jibel
#ubuntu-reviews 2010-08-14
<chilicuil> hi, good afternoon, do u think I should add the patch-forwarded to bug #611401? since it's a valid patch
<ubot4`> Launchpad bug 611401 in ubuntuone-client (Ubuntu) (and 1 other project) "copyright file not formatted per Dep5 (draft) (affects: 1) (heat: 246)" [Undecided,New] https://launchpad.net/bugs/611401
<yofel> chilicui1: actually no, that patch should be refreshed against the current package and then get ubuntu-sponsors subscribed
<yofel> and we don't have a patch-forwarded tag, it's either patch-forwarded-upstream or patch-forwarded debian
<yofel> *patch-forwarded-debian
<chilicui1> yofel: ok, thx, I'm gonna refresh it
<yofel> you can put the 'patch-rejected-upstream' tag on the bug as they did reject it in comment #3
<chilicui1> yofel: ok, =), changing the tag
#ubuntu-reviews 2010-08-16
<dholbach> good morning
#ubuntu-reviews 2010-08-17
<dholbach> good morning
<bdrung> seb128: bug #607793
<ubot4`> Launchpad bug 607793 in nautilus (Debian) (and 2 other projects) "Audio preview of CD tracks fails if totem is not installed (affects: 1) (heat: 10)" [Unknown,Confirmed] https://launchpad.net/bugs/607793
<seb128> yes?
<bdrung> seb128: my understanding: ubuntu-sponsors is for sponsoring an upload for someone without upload rights. ubuntu-review is for getting a patch into ubuntu
<bdrung> seb128: sponsoring an upload means that someone has provided something that can be uploaded
<seb128> having 2 teams for the same things is confusing
<seb128> we had this discussion in the past on list
<seb128> there is no reason why we should require a perfect debdiff to sponsor something
<seb128> having correct patches from people not knowing packaging is valuable
<seb128> it's easy enough to add a changelog entry while sponsoring
<bdrung> yes, but most of these 'random' patches target upstream code and should be processed by ubuntu-review -> getting them fixed in upstream and then sponsored into ubuntu
<seb128> I've difficulties to understand wht ubuntu review is doing in fact now
<bdrung> seb128: ubuntu-review should process every patch that is attached to an bug. 1. make sure that the patch applies 2. forward to upstream 3. once accepted by upstream upload to ubuntu if it's severe enough to not wait for the next upstream release
<bdrung> ubuntu-review requires no knowledge of the patch writer
<bdrung> ubuntu-sponsor does
<vish> nigelb, dholbach ^^ maybe you could clarify...
<vish> afaic, ubuntu-review is for getting a patch to a right place, not necessarily into Ubuntu, its need was mostly since patches were unattended and for someone to just tend to them..
<bdrung> vish: getting a patch to a right place and into ubuntu in the long run (through package new upstream releases)
<vish> bdrung: getting it into Ubuntu is of-course as per reviewers interest of the patch/ bug
<vish> bdrung: yeah , it does eventually flow into Ubuntu..
<dholbach> vish, nigelb: what is the question exactly?
<vish> dholbach:  <seb128> I've difficulties to understand wht ubuntu review is doing in fact now
<nigelb> hrm?
<dholbach> slowly triage our 2000+ patches, feed them upstream and if important get into Ubuntu
<nigelb> dholbach: 1
<nigelb> +1
<bdrung> who runs the 'add patch tag' script? i have an enhancement request.
<nigelb> bdrung: brian does.
<nigelb> there are 2 scripts now
<nigelb> one will look at the ubuntu-bugs list and one will look at LP
<bdrung> nigelb: can i see the source?
<seb128> dholbach, why should the review team be subscribed to bug #607793
<ubot4`> Launchpad bug 607793 in nautilus (Debian) (and 2 other projects) "Audio preview of CD tracks fails if totem is not installed (affects: 1) (heat: 10)" [Unknown,Confirmed] https://launchpad.net/bugs/607793
<seb128> ?
<nigelb> seb128: bug in the script or sponsors was subscribed after the script tagged it.
<seb128> nigelb, ?
<vish> nigelb: read the bug ;)
<dholbach> 2010-07-20 14:29:54	Olivier Tilloy	attachment added		oem-preview-audio-cd-tracks-with-playbin.patch
 * nigelb has very slow internet today
<dholbach> seb128, 1^
<seb128> nigelb, I don't understand how that replies to my question
<dholbach> the patch was removed afterwards
<seb128> dholbach, that patchis being reviewed upstream
<vish> dholbach: seb128's question is due to the last 2 comments on the bug :)
<seb128> dholbach, I don't get why bdrung subscribed the review team again
<dholbach> I'll leave that to you guys :)
<seb128> I've tagged it "patch-forwarded-upstream"
<seb128> dholbach, ok, so I still don't understand what reviewer are for there...
<seb128> thanks for leaving me in confusion
<seb128> ;-)
 * seb128 hugs dholbach
<nigelb> seb128: ubuntu-reviews comes into play since its a simple patch, that's all
<dholbach> seb128, what the team is there for generally or why it is on that bug report?
<nigelb> if bdrung hadn't subscribed the team, we would have been subscribed by the script anyway.
<bdrung> seb128: ok, with patch-forwarded-upstream subscribing the team is not required
<seb128> I though the team was to review non reviewed patches
<nigelb> seb128: It was.
<nigelb> seb128: It *is*
<seb128> I don't get why reviewers need to be subscribed to that bug
<nigelb> We don't.
<seb128> ok thanks
<nigelb> You've tagged it right anyway.
 * nigelb hugs seb128 :)
<seb128> yes and bdrung came saying I did it wrong
<seb128> and subscribed reviewers back
<seb128> such my question there
<nigelb> Just FYI, the script subscribes us back anyway :(
 * seb128 hugs nigelb
<nigelb> bdrung: http://bazaar.launchpad.net/~ubuntu-reviewers/ubuntu-review-overview/trunk/files
<nigelb> the patch-overview file is what you want.
<nigelb> bdrung: Talk to brian murray before you do anything though.  He'll probaly give you the latest code that he's running.
<bdrung> seb128: ok, i should have only unsubscribed ubuntu-sponsor with the remark -> first get it accepted upstream and then resubscribe the team
<seb128> bdrung, ok, that matches what I was thinking, I did that now btw
<seb128> bdrung, note that Olivier subscribed the sponsors, not me
<seb128> bdrung, nigelb, dholbach: thanks
<bdrung> seb128: you wrote "subscribe the sponsors again once it's done"
<bdrung> seb128: that led to my comment :)
<bdrung> seb128: i agree with your latest comment "subscribe sponsors back when upstream is happy with the change"
<seb128> bdrung, right, I though it was just needing tweak in reply to upstream comment to be ready to be commited upstream and so uploaded to Ubuntu
<seb128> anyway it's all sorted now
<bdrung> thanks seb128
<seb128> thank to you ;-)
<bdrung> bdmurray: around?
<bdmurray> bdrung: I am now fwiw
<bdrung> bdmurray: i was thinking about your patch tagging script. could it subscribe ubuntu-review if the attached patch is a debdiff (= changes "debian/changelog")?
<bdrung> bdmurray: you can look at sponsor-patch in lp:ubuntu-dev-tools how i detected debdiffs
<bdmurray> bdrung: using the extension type or downloading the attachment?
<bdrung> bdmurray: downloading the attachment
<bdrung> bdmurray: and analyze it with diffstat
<bdmurray> bdrung: that sounds like a great idea - I'll see what I can do
<bdrung> i am curious how many debdiff are out there without having ubuntu-sponsors subscribed (i found at least some by searching for "sync" and "merge")
<bdrung> bdmurray: if the script subscribes ubuntu-sponsors, it should add a comment that it was done automatically
<bdmurray> bdrung: got it
<bdrung> bdmurray: does your script exclude fixed bugs?
<bdmurray> bdrung: yes
<bdrung> bdmurray: once you have something in place, can you do a dry run and give me the list of bugs?
<bdmurray> bdrung: sure it might be a bit before I get to it
<bdrung> bdmurray: i will be on vacation in three days. if i am not on irc, drop me a mail
<penguin42> so what happens to bugs where the patch in them is already in the latest package but the bug is still open?
<nigelb> penguin42: close the bug as Fix Released.
<nigelb> especially if that patch is in maverick
<penguin42> nigelb: Can you look at bug 428318
 * nigelb pokes maco.  Can you help?
 * nigelb is kinda unstablishly sleepy.
 * penguin42 hands nigelb coffee
<nigelb> 3 am.  I'd rather have a pillow.
<penguin42> oh that is a bit late, erm early
#ubuntu-reviews 2010-08-18
<bobbo> Good evening #-reviews!
<penguin42> hi
<bobbo> anyone able to link me to the QA graphs page for Cleansweep?
<yofel> bobbo: topic?
<bobbo> aha, thanks yofel, I need to improve my reading!
<yofel> np ;)
<penguin42> a lot of the patches are very old, and a fair few of them already seem to have got merged or fixed sometime
<penguin42> crimsun_: Knock knock
<dholbach> good morning
<nigelb> vish: um, we probably need to do that discussion here.
<nigelb> vish: the 400 something count which I'm talking about includes only patches with the bucket tags
<bilalakhtar> nigelb: I understand that
<bilalakhtar> nigelb: we should first get them there
<bilalakhtar> nigelb: and then wait
<nigelb> vish: if you want you can go to http://blog.qa.ubuntu.com/
<nigelb> bilalakhtar: yes, so upstream has ot make a call.  Where does regression in ubuntu come into the picture at all?
<bilalakhtar> nigelb: let me give you an example
<nigelb> bilalakhtar: what we're doing (or trying to do) is not have people write patches and they stale in launchpad.
<vish> nigelb: how many of the ones are we *really* forwarding? which have not gotten attention?
<nigelb> vish: we have forwarded 200 patches
<nigelb> atleast
<bilalakhtar> nigelb: some patches get accepted upstream and then they create regressions
<vish> nigelb: what i'm saying is tht we are claiming success from the work seb128 and similar teams have been doing for ages
<nigelb> bilalakhtar: how can that be our fault?  Upstream has to make a call.
<bilalakhtar> nigelb: GNOME bug #625675
<nigelb> Its their code.  They should know.
<bilalakhtar> no bot in here?
<vish> nigelb: of those 200 how much have we really improved due to clean sweep?
<nigelb> bilalakhtar: our duty is to foward them upstream
<nigelb> vish: Do you have of any method to track that?
<bilalakhtar> nigelb: fine, you win
<nigelb> I dont
<nigelb> bilalakhtar: Its not a win/fail thing.
<nigelb> bilalakhtar: I'm only trying to explain.
<bilalakhtar> nigelb: I meant you;re right
<bilalakhtar> but I cannot mention it, so wrote 'win' instead
<seb128> bilalakhtar, the issue is usually rather changes pushed to the distro without waiting for upstream review
<seb128> bilalakhtar, upstream tend to know their code better and fix issues they create
<bilalakhtar> seb128 is right, that's what is happening, and its my fault as well
<vish> nigelb: no i dont, but i think its wrong to claim others work as our success,  my best guess is that we would have had atleast 150 forwarded are the work that seb128 and others teams have been doing already
<nigelb> if upstream is introducing regressons, we can take blame for that too.  Besides all the ^**^% we get blamed for.
<bilalakhtar> ok, seb128 and nigelb , see this one https://bugzilla.gnome.org/show_bug.cgi?id=625675
<nigelb> vish: That is him helping us out in cleansweep! How can I not acknowledge that as contribution?
<bilalakhtar> seb128 and nigelb : its regression https://bugzilla.gnome.org/show_bug.cgi?id=626620
<vish> nigelb: how is that? he has been doing that for ages..! why is that our success?
<nigelb> vish: there isn't a condition that states its only number patches reviewed by volunteers or people other than desktop team that counts.
<nigelb> vish: Why NOT?
<nigelb> He's reviewing patches.  The goal of cleansweep is to review patches.  Where are you getting confused?
<seb128> it's rather how you message it than what you do
<seb128> because you claim those patches have been review in the cleansweep effort
<vish> nigelb: you are just increasing his workflow and claiming that he has helped you? why?
<seb128> but they have not, they have been reviewed by people doing their usual work they were doing before cleansweep
<vish> +1
<seb128> you should rather say than ubuntu forwarded nnn changes and that cleansweep contributed to that effort
<bilalakhtar> seb128 is right, most of the [people on OC are long-time patch reviewers
<vish> that is exactly what i'm saying , total reviewed patches != Operation Cleensweep success
<bilalakhtar> http://bit.ly/ddQFie is the list of bugs with patches, however many of them have debdiffs rather than patches
<nigelb> bilalakhtar: if you can give a list to bdmurray he can tweak the script.
<nigelb> We have a new script that is a bit "too" active.
<bilalakhtar> nigelb: yup, the new script is marking merges also with 'patch'
<nigelb> vish: but how do you know which is which?
<seb128> would be nice if the script stopped changing bugs already fixed for example
<seb128> it's tagging patches since which have been uploaded
<vish> nigelb: for one , the whole process is a shaddy
<nigelb> seb128: we were losing bugs through cracks when we did only LP
<bilalakhtar> seb128: yes, like https://bugs.edge.launchpad.net/ubuntu/+source/ddclient/+bug/619141 nigelb
<nigelb> vish: I'm not the one doing the tagging.
<nigelb> vish: brian is the one doing the tagging.
<nigelb> Talk to him.  Please.
<vish> nigelb: but you know about it right?
<nigelb> vish: yes, but I don't know how to fix it.
<vish> nigelb: you suggested the changes?
<nigelb> vish: No, you were on the mail.  Brain suggested the changes.
<bilalakhtar> bdmurray: ping
<nigelb> Wait, you suggested the changes.
<nigelb> We missed a few bugs and you alerted me.  Remember?
<vish> nigelb: it wasnt me.. i have at many times suggested several changes and you have just stuck to the currrent process
<nigelb> I wrote a mail to Brian copying you and we have a new script that uses the bugs list.
<nigelb> vish: which was discussed at uds, and noone raised issues.
<nigelb> It was also mailed to -devel.
<vish> nigelb: you should not have been adding more bugs and subscribing the team to new bugs was someone else's idea.. not mine
<nigelb> vish: subscribing team to new bugs was what was alexanderlisa@example.com.
<nigelb> It was not my decision.
<vish> nigelb: half the people who have tried to suggest changes have given up arguing with you, and just went with "meh!"
<nigelb> vish: Only you suggested changes.
<nigelb> ugh, I wish there was a mailing list.
<vish> nigelb: several have suggested and i dont want to name them
<nigelb> vish: Everyone wanted $foo, $foo1, $foo2.
<nigelb> I had to stick with a $foo and get going.
<nigelb> REmember, no one wanted to do alexanderlisa@example.com.
<vish> nigelb: they have tried to question several workflow and you have argued for statistics and they eventually just gave up
<nigelb> so I was more interested in getting the thing launched rather than dicussing.
<vish> nigelb: yes, you did a great job is bringing attention.. i dont deny it :)
<nigelb> if someone wants to make changes and feel it can be effective, I'm open to it.
<nigelb> vish: If there was ever any reason was because it was I need to kickstart it rather than keep discussing
<nigelb> we went for about a month talking.
<nigelb> Finally, I stopped talking started doing.
<vish> nigelb: doing?
 * bilalakhtar will now leave
<nigelb> vish: When the workflow was written, there were lot of oppositions.
<nigelb> Most of it was, this is hard.
<nigelb> I asked, do you have a better way
<nigelb> Then it would squard back to, "this is hard"
 * nigelb needs to get back to work.
<nigelb> If someone came up with a meaningful change, I haven't rejected it.
<nigelb> (maybe I've forgotten about it due to lack of time)
<vish> nigelb: several times people have tried to reason with you, but since you have great interest they have just left it to your judgement
<vish> since they didnt have much stake..
<nigelb> vish: The time that the entire process was discussed, there were back and forth mails for months.
<dholbach> can we try to calm down a bit?
<nigelb> *month.
<vish> nigelb: lets try this now.. :)  firstly, you should not have been adding more bugs and subscribing the team.. that is a way to get a more realistic number..
<nigelb> vish: why didn't you raise it at uds?
<nigelb> you were there
<nigelb> It there it was discussed.
<vish> nigelb: i wasnt in every session
<nigelb> It was /not/ my call.
<dholbach> seb128, vish, nigelb: we all put loads of hours into getting the number of patches down, we all worked very hard, what is the bottom line of what you want to change?
 * nigelb isn't very sure what just happened.
<seb128> dholbach, I don't want to change anything, I'm not in this discussion ;-)
<vish> dholbach: nigelb: even now.. i dint bring up the whole discussion.. :)
<dholbach> the end goal being: more patches getting reviewed, forwarded and integrated and bugs closed
<seb128> I don't even know what the discussion is about
<dholbach> ok, what are practical suggestions right now?
<vish> dholbach: nigelb: i just wanted to mention it as a we need to actually do work.. somehow this got twisted.. ;)
<seb128> I just made a comment saying that if anybody has a perception issue that cleansweep is claiming work it should do change the wording to say "ubuntu did and cleansweep helped"
<dholbach> parts of this discussion read like a heated argument and if there's no practical suggestions, we can as well all go back to doing some real work
<seb128> should->shouldn't
<seb128> dholbach, indeed
<dholbach> seb128, ok, I'm sure nobody tried to steal anybody's credit, but we can message that out more clearly - I'll try to do that when I blog about it next again
<nigelb> seb128: ack.  agreed.
<vish> dholbach: indeed.. :)  i just made a passing observation in -motu which lead to a lot of chatter :(
<nigelb> M turn next week.   I'll do it.
 * nigelb gets back to work.
<seb128> dholbach, I was not the one who complained, that's just what I got from the discussion
<seb128> yeah, let's back to work ;-)
<dholbach> seb128, gotcha, thanks for your comment
 * dholbach hugs you all
<seb128> not worth discussing
<seb128> for what is worth I'm fine cleansweep counting patches I forwarded as cleansweep effort
<seb128> as long as it motivates people to work on cleaning
<dholbach> numbers are always complicated
<dholbach> you never get them right, somebody will always be pissed off
<vish> dholbach: i actually dint get pissed off :s  i just wanted to say we need to do more reviews and that our numbers arent really very good right now :(
<vish> dholbach: pls read my para on -motu  ..
<dholbach> vish, totally agreed - we need to work harder :)
<nigelb> vish: you've got time for a logo design?
<nigelb> http://pollka.net if you're interested.
<vish> nigelb: we already have one, right?  needs any update or a new one?
<vish> oh!
<nigelb> Its from the UW competition that happened a few months back.
<nigelb> elky opensourced the app and called for contributors who would be mentored in PHP :)
<vish> nigelb: its a standalone app or only runs on sites?
<nigelb> vish: its a standalone app for quick polling
 * nigelb points to launchpad.net/pollka
<vish> cool!
<nigelb> Actually, alanbell wanted the code
<nigelb> and it ended up being on elky's junk folder
<nigelb> and then as a new project and mentoring platform
 * nigelb kicks google maps meanwhile.
<vish> hmm..
<vish> just for the record, i think nigelb is great ! :D
 * vish just got pm'd by someone thinking i hate nigelb :s
 * nigelb hugs vish
<nigelb> belatedly
<nigelb> Today is just a bad day.  At least my foosball luck is improving.
<nigelb> hm, won all ames today
 * penguin42 closes another bug-with-patch
<penguin42> a lot fo them are so old that someone somewhere has pushed the bug upstream already
<nigelb> yep, low hanging fruit.
<nigelb> Like I said, we need more manpower.
 * penguin42 has this week off so I'm happy to pick of the low hangers off and anything I understand
<vish> nigelb: heh , yeah , somehow they thought i was alexanderlisa@example.com.. [oh the joys of irc ;p ]  and wanted to use me as a mouth piece for their frustration!
<nigelb> vish: ftr, if anyone has any issues, I'll just wait for him/her to have the guts to mail/ping me.
<vish> nigelb: yay! mud fight? ;p
<nigelb> vish: hahaha
<nigelb> vish: what do you want me to do?
<nigelb> unassign the bug from me and say I won't be able to do it?
<vish> nigelb: hmm, i just entered... dont know what the context is..
<nigelb> haha
<nigelb> cheeeese!
<vish> nigelb: ah! yeah, just add a comment on the bug about what pitti told you , kermiac will pick it up from there..
<nigelb> vish: um, what pitti told me....
 * nigelb has no recollection.
<nigelb> The logs are on my laptop which is in the shop :(
 * nigelb notes the "..." in the comments :p
<vish> nigelb: yeah, that was an oopsie! i was about to write something .. then pinged you and not sure what i did there..
#ubuntu-reviews 2010-08-19
<dholbach> good morning
#ubuntu-reviews 2010-08-20
<dholbach> good morning
<vish> nigelb: lol! didrocks uploaded it a long time ago! :D
<vish> we were wondering why the delay!
<nigelb> vish: GAH!
<nigelb> vish: I rememebr some conversation about it from long back
<nigelb> but I thought it was lucid :?
<nigelb> :/
<nigelb> vish: close the metacity task while alexanderlisa@example.com.
<vish> nigelb: yeah , and it seems didrocks uploaded on that very same day! :)
<vish> nigelb: silly didrocks and his typos! ;p
<nigelb> vish: typos?
 * vish lucky didrocks in on vacation
<vish> nigelb: he missed a number in the changelog
<vish> Nicke_: it was 111*** he uploaded as 11*** , missed one '1' and all the confusion ;)
<nigelb> vish: GAH
#ubuntu-reviews 2010-08-22
<simar>  hi nigelb
<simar> nigelb: there?/
#ubuntu-reviews 2010-08-23
<dholbach> good morning
 * vish grumbles! was only recently told of dholbach's secret script stash!
<vish> ;p
<vish> dholbach: morning :)
<vish> a lot of the bugs, i would have subscribed the Main Sponsors and i noticed that you would silently switch it to new Sponsors team.. and i was always thinking i was increasing your workload :(
<vish> dholbach: only recently nigelb told me you were not looking at them personally ;p
<nigelb> vish: HAHAHAH
 * hyperair lols
#ubuntu-reviews 2010-08-24
<dholbach> good morning
<dholbach> nigelb, done
#ubuntu-reviews 2010-08-25
<dholbach> good morning
<rsajdok> https://bugs.launchpad.net/ubuntu/+source/pm-utils/+bug/606160 https://bugs.launchpad.net/ubuntu/+source/zsync/+bug/605428 Pytanie na irc: I found two bugs. Do I think good in this case sufficient to change tag to 'patch-forwarded*' ?
<ubot4> Launchpad bug 606160 in pm-utils (Ubuntu Maverick) (and 1 other project) "package pm-utils 1.3.0-2 failed to install/upgrade: trying to overwrite '/usr/lib/pm-utils/power.d/laptop-mode', which is also in package laptop-mode-tools 1.52-1ubuntu2 (affects: 6) (heat: 32)" [Undecided,Fix released]
<rsajdok> I found two bugs. Do I think good in this case sufficient to change tag to 'patch-forwarded*' ?
<nigelb> rsajdok: the first one is Fix Released.
<nigelb> So, no need to tag or do anything with it.
<nigelb> the second one isn't forwarded to the upstream bug tracker and as such doen't qualify to be tagged patch-forwarded-upstream.
<rsajdok> nigelb: Why is not? Otus wrote: "I sent it to upstream by email, but haven't heard back" https://bugs.launchpad.net/ubuntu/+source/zsync/+bug/605428/comments/1
<ubot4> Launchpad bug 605428 in zsync (Ubuntu) "When input file is complete, zsync should stop (affects: 1) (heat: 8)" [Undecided,New]
<nigelb> rsajdok: Ah, I should learn to read.
<nigelb> Yes, patch-forwarded-upstream then :)
<rsajdok> nigelb: ok :) thanks
<nigelb> rsajdok: np :)
<nigelb> simar: you were looking for me a few days back?
<simar> nigelb: ya
<simar> nigelb: hi
<nigelb> (whenever I come in, you're not around and when you're around I'm not, etc)
<simar> nigelb: my bad luckk :(
<nigelb> simar: hi, wassup?
<simar> nigelb: actually i want to work for operation cleansweep
<nigelb> simar: ah, welcome :)
<simar> nigelb: i had a simple bug to review .. but i had a doubt
<nigelb> ask away :)
<nigelb> Feel free to ask your doubt here.  I'm on here most of the time and if not somone else will always be willing to answer
<simar> nigelb: i can't find it now ..
<simar> nigelb: :-))
<nigelb> simar: anything, feel free to ask :)
<simar> nigelb: please tell if i'm wrong but i think, there aren't many simple patches left to review ..
<nigelb> simar: 1407 to go.
<simar> nigelb: bug 1407
<ubot4> simar: Error: Bug #1407 not found.
<simar> nigelb: ah!! error
<nigelb> simar: you can use the link in topic or http://is.gd/eD6Hz
<nigelb> the link which I just gave you is sorted from old ot new
<nigelb> *old to new
<simar> nigelb:  my internet connection broke
<nigelb> simar: heh, np
<simar> nigelb: i just needed that list .. if i had contacted you that day, i was going to ask the same .. :-))
<nigelb> simar: look on the topic :)
<simar> nigelb: but i think new ones will be more easy ..
<nigelb> simar: ah, let me get you the sorted one
<nigelb> simar: http://is.gd/eD6Hz (start from end, its sorted old to new)
<nigelb> lastlog vish
<nigelb> grr
<simar> nigelb: that is still the oldest first list..
<nigelb> simar: yes, I know.  start from the end of that list
<simar> nigelb: oh .. ya
<nigelb> :)
<simar> nigelb: well thanks nigelb for the list and help .. but currently i have some work regarding testing of patches .. in security team .
<simar> nigelb: i will try one easy one from the list .. some day
<nigelb> simar: oh, cool!
<nigelb> simar: thanks for helpign out
<simar> nigelb: not yet helped .. but ok :-|
<simar> nigelb:  cya .. bye :-))
<simar> nigelb: hopefully i will join this weekend ..
<nigelb> :)
<simar> nigelb: which downloader you are using in ubuntu ... just now i had to download the draper iso, i used firefox but only 16KBps but in IDM (in virtual) i'm getting 150KBps ... but i'm not able to find a downloader that can download by making multiple connections to server while there are plenty in windows ..
<nigelb> simar: I just use wget -c on the command line
<simar> wget -c . does it make multiple connections ?
<nigelb> nope, but it lets you continue
<simar> nigelb: isn't there exist on in ubuntu that like IDM in windows .. if not I think we should port one in ubuntu ..
<simar> nigelb: i have created one in visual basic in windows ... i don't think doing it in ubuntu will be a very difficult task ... or i hope may it exist in upstream or debian
<nigelb> simar: I think we just need to find it
<simar> nigelb: ya, leave it to me .. i will add it in my list ..
<simar> nigelb: but i think there is none in ubuntu repositories .. but i will find it elsewhere
<nigelb> :)
#ubuntu-reviews 2010-08-26
<dholbach> good morning
#ubuntu-reviews 2010-08-29
<thomas> nick iAmerikan
<micahg> k, so, what do I mark for a patch that was upstreamed that a different version was accepted?
<micahg> nigelb: ^^
#ubuntu-reviews 2010-08-30
<persia> micahg, A different version of the patch was accepted upstream for the same issue?  If they aren't too different, I'd go for patch-accepted-upstream.  If they are wildly different, I'd suggest patch-rejected-upstream with a pointer to the patch that was accepted.
<micahg> persia: idr, I'll have to look again, thanks'
<persia> No promises someone else won't give a more correct answer though :)
<tt33l3r> Where can I get some help with an Ubuntu problem I'm having?
<tt33l3r> Please
<nigelb> micahg: sorry, was offline from sat evening till now :)
<micahg> nigelb: k, I went through most of the patches
 * nigelb hugs micahg 
<nigelb> Thank you !
<micahg> nigelb: np, I'll try to do the rest next weekend
<nigelb> \o/
<nigelb> Gah, team report time and I'm not sure what to write.  Sigh.
<nigelb> Anyone wants to add anything to https://wiki.ubuntu.com/ReviewersTeam/TeamReports/10/August ?
 * nigelb pokes persia 
<nigelb> Can you take a glance?
<persia> Was there any intergration/coordination with GlobalJam?  Other than that, looks sane.
<nigelb> Ah, missed that one.
<dholbach> good morning
#ubuntu-reviews 2010-08-31
<dholbach> good morning

{'channel': 'ubuntu-reviews', 'month': 8}