From pdfbox-dev-returnmichaelbecker@example.org Mon Dec 01 09:49:38 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 49932 invoked from network); 1 Dec 2008 09:49:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Dec 2008 09:49:38 -0000 Received: (qmail 60502 invoked by uid 500); 1 Dec 2008 09:49:50 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 60493 invoked by uid 500); 1 Dec 2008 09:49:50 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 60441 invoked by uid 99); 1 Dec 2008 09:49:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2008 01:49:49 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2008 09:48:30 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 8234C234C29F for <michaelbecker@example.org>; Mon, 1 Dec 2008 01:48:47 -0800 (PST) Message-ID: <1113715188.1228124927532.JavaMail.jira@brutus> Date: Mon, 1 Dec 2008 01:48:47 -0800 (PST) From: "Mathias Bosch (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Updated: (PDFBOX-390) org.pdfbox.filter.ASCIIHexFilter does not skip Whitespace In-Reply-To: <1952833009.1227784604227.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Bosch updated PDFBOX-390: --------------------------------- Attachment: 000161.pdf hi andreas, i did attach a sample document containing multiple hex encoded inline images containing whitespaces and an EOD as the firstByte. It does not provide an example for the "special" case where the secondByte is the EOD, this is coded according to the spec. > org.pdfbox.filter.ASCIIHexFilter does not skip Whitespace > --------------------------------------------------------- > > Key: PDFBOX-390 > URL: https://issues.apache.org/jira/browse/PDFBOX-390 > Project: PDFBox > Issue Type: Bug > Components: Parsing > Affects Versions: 0.8.0-incubator > Reporter: Mathias Bosch > Fix For: 0.8.0-incubator > > Attachments: 000161.pdf, ASCIIHexFilter_390-Patch.diff > > > org.pdfbox.filter.ASCIIHexFilter does not skip Whitespace > According to the Specification (pdf_reference_1-7.pdf) all Whitespace > Characters between the ASCII-Hex values have to be skipped (see 3.3.1 > ASCIIHexDecode Filter). > The 0.8.0-incubator source decodes (or attempts to decode) those Whitespace > Characters and as a result the byte values are wrong (all characters that > are not [0-9a-f] result in -1, but processing does continue). > This causes an invalid byte Stream. > The ASCIIHexDecode Filter Section also defines the EOD end Character of the > Byte Steam as '>' which might ease the parsing of inline Images. > (The EI Operator should follow the EOD in case of an inline Image). > Example for ASCII-Hex encoded value, copied from the Spec: > FF CE A3 7C 5B 3F 28 16 0A 02 00 02 0A 16 28 3F 5B 7C A3 CE FF > > I did fix the problem to be able to continue with my work. > I paste the changed code here as a hint that might help to fix the bug. > public class ASCIIHexFilter > implements Filter > { > /** > * Whitespace > * 0 0x00 Null (NUL) > * 9 0x09 Tab (HT) > * 10 0x0A Line feed (LF) > * 12 0x0C Form feed (FF) > * 13 0x0D Carriage return (CR) > * 32 0x20 Space (SP) > */ > protected boolean isWhitespace(int c) { > return c == 0 || c == 9 || c == 10 || c == 12 || c == 13 || c == 32; > } > > protected boolean isEOD(int c) { > return (c == 62); // '>' - EOD > } > /** > * {@inheritDoc} > */ > public void decode(InputStream compressedData, OutputStream result, COSDictionary options, int filterIndex) throws IOException { > int value = 0; > int firstByte = 0; > int secondByte = 0; > while ((firstByte = compressedData.read()) != -1) { > > // always after first char > while(isWhitespace(firstByte)) > firstByte = compressedData.read(); > if(isEOD(firstByte)) > break; > > if(REVERSE_HEX[firstByte] == -1) > System.out.println("Invalid Hex Code; int: " + firstByte + " char: " + (char) firstByte); > value = REVERSE_HEX[firstByte] * 16; > secondByte = compressedData.read(); > > if(isEOD(secondByte)) { > // second value behaves like 0 in case of EOD > result.write(value); > break; > } > if(secondByte >= 0) { > if(REVERSE_HEX[secondByte] == -1) > System.out.println("Invalid Hex Code; int: " + secondByte + " char: " + (char) secondByte); > value += REVERSE_HEX[secondByte]; > } > result.write(value); > } > > result.flush(); > } > // ..................................................... > // other code remains unchanged -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Wed Dec 03 19:36:05 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 16458 invoked from network); 3 Dec 2008 19:36:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Dec 2008 19:36:04 -0000 Received: (qmail 76215 invoked by uid 500); 3 Dec 2008 19:36:16 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 76199 invoked by uid 500); 3 Dec 2008 19:36:16 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 76188 invoked by uid 99); 3 Dec 2008 19:36:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 11:36:16 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 19:34:56 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 54354234C2A9 for <michaelbecker@example.org>; Wed, 3 Dec 2008 11:35:44 -0800 (PST) Message-ID: <849-419-6902.1228332944343.JavaMail.jira@brutus> Date: Wed, 3 Dec 2008 11:35:44 -0800 (PST) From: "Brian Carrier (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Created: (PDFBOX-393) Maven files in jempbox do not work MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Maven files in jempbox do not work ---------------------------------- Key: PDFBOX-393 URL: https://issues.apache.org/jira/browse/PDFBOX-393 Project: PDFBox Issue Type: Bug Components: JempBox Affects Versions: 0.8.0-incubator Reporter: Brian Carrier When I tried to use the Maven files in JempBox, I got errors in the test code that it could not find the junit packages. Changing the pom file to better specify the test and source directories fixed it. --- jempbox/trunk/pom.xml (revision 723007) +++ jempbox/trunk/pom.xml (working copy) @@ -36,7 +36,8 @@ <description>JempBox is an open source Java library that implements Adobe's XMP(TM) specification.</description> <build> - <sourceDirectory>src</sourceDirectory> + <sourceDirectory>src/org</sourceDirectory> + <testSourceDirectory>src/test</testSourceDirectory> </build> <dependencies> -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Wed Dec 03 19:39:19 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 17884 invoked from network); 3 Dec 2008 19:39:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Dec 2008 19:39:19 -0000 Received: (qmail 86057 invoked by uid 500); 3 Dec 2008 19:39:30 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 86035 invoked by uid 500); 3 Dec 2008 19:39:30 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 86014 invoked by uid 99); 3 Dec 2008 19:39:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 11:39:30 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO spunkymail-a6.g.dreamhost.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 19:38:01 +0000 Received: from [83.161.120.155] (ip65-47-145-42.z145-47-65.customer.algx.net [83.161.120.155]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by spunkymail-a6.g.dreamhost.com (Postfix) with ESMTP id ED67F109F30 for <michaelbecker@example.org>; Wed, 3 Dec 2008 11:38:47 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) In-Reply-To: <1288363881.1227272446915.JavaMail.jira@brutus> References: <1288363881.1227272446915.JavaMail.jira@brutus> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <michaelbecker@example.org> Content-Transfer-Encoding: 7bit From: Brian Carrier <michaelbecker@example.org> Subject: Re: [jira] Commented: (PDFBOX-377) Incorrect direction of extracted Arabic Text Date: Wed, 3 Dec 2008 14:38:45 -0500 To: michaelbecker@example.org X-Mailer: Apple Mail (2.753.1) X-Virus-Checked: Checked by ClamAV on apache.org On Nov 21, 2008, at 8:00 AM, Jukka Zitting (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/PDFBOX-377? > page=com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=12649664#action_12649664 ] > > Jukka Zitting commented on PDFBOX-377: > -------------------------------------- > > Yeah, I guess using ICU4J is reasonable in this case. Could the > code be organized so that ICU4J is only loaded when such > normalization is needed? I changed the previous patch to make ICU4J an optional dependency. In the current design, the library is required to build PDFBox, but at runtime it is only used if ICU4J is given in the classpath. It seems that this will be easier to manage if Maven were being used instead of Ant. ICU4J could then be marked as an optional dependency. Is timethe only reason that PDFBox does not use Maven or are there other reasons? thanks, brian From pdfbox-dev-returnmichaelbecker@example.org Wed Dec 03 23:00:05 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 6098 invoked from network); 3 Dec 2008 23:00:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Dec 2008 23:00:05 -0000 Received: (qmail 77063 invoked by uid 500); 3 Dec 2008 23:00:17 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 77026 invoked by uid 500); 3 Dec 2008 23:00:17 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 76933 invoked by uid 99); 3 Dec 2008 23:00:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 15:00:17 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 22:58:56 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 56448234C2B1 for <michaelbecker@example.org>; Wed, 3 Dec 2008 14:59:44 -0800 (PST) Message-ID: <307736974.1228345184352.JavaMail.jira@brutus> Date: Wed, 3 Dec 2008 14:59:44 -0800 (PST) From: "Brian Carrier (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Created: (PDFBOX-394) TestFDF junit test failing in testFDFFreedomExpressions(). MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org TestFDF junit test failing in testFDFFreedomExpressions(). ---------------------------------------------------------- Key: PDFBOX-394 URL: https://issues.apache.org/jira/browse/PDFBOX-394 Project: PDFBox Issue Type: Test Components: Parsing Affects Versions: 0.8.0-incubator Reporter: Brian Carrier Currently, the TestFDF junit tests are failing because testFDFFreedomExpressions() tries to load an FDF file and PDFParser.parseHeader() returns an error because it can't find a PDF header. I fixed that code so that it also looks for an FDF header. That patch is attached. However, it still results in a test failure with this line: assertTrue( totalAmt.getDictionary().getDictionaryObject( "AP" ) == null ); I haven't looked at the test file enough to determine where the problem is. getDictionaryObject("AP") is returning a COSDictionary. PDFDebugger shows that eeSuppTotalAmt is in entry 58, but I don't see any obvious reference to an "AP". Also, TestFDF is being called twice in TestAll.java. That patch is also attached. Please apply these patches and keep this open so that the assertion failure can be fixed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Wed Dec 03 23:04:35 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 7596 invoked from network); 3 Dec 2008 23:04:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Dec 2008 23:04:35 -0000 Received: (qmail 83744 invoked by uid 500); 3 Dec 2008 23:04:47 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 83735 invoked by uid 500); 3 Dec 2008 23:04:47 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 83724 invoked by uid 99); 3 Dec 2008 23:04:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 15:04:47 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 23:03:26 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 7B241234C2A3 for <michaelbecker@example.org>; Wed, 3 Dec 2008 15:03:44 -0800 (PST) Message-ID: <1569286006.1228345424503.JavaMail.jira@brutus> Date: Wed, 3 Dec 2008 15:03:44 -0800 (PST) From: "Brian Carrier (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Updated: (PDFBOX-394) TestFDF junit test failing in testFDFFreedomExpressions(). In-Reply-To: <307736974.1228345184352.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Carrier updated PDFBOX-394: --------------------------------- Attachment: PDFParser.diff TestAll.diff Patches that fix some of the problems in the TestFDF junit test. > TestFDF junit test failing in testFDFFreedomExpressions(). > ---------------------------------------------------------- > > Key: PDFBOX-394 > URL: https://issues.apache.org/jira/browse/PDFBOX-394 > Project: PDFBox > Issue Type: Test > Components: Parsing > Affects Versions: 0.8.0-incubator > Reporter: Brian Carrier > Attachments: PDFParser.diff, TestAll.diff > > > Currently, the TestFDF junit tests are failing because testFDFFreedomExpressions() tries to load an FDF file and PDFParser.parseHeader() returns an error because it can't find a PDF header. I fixed that code so that it also looks for an FDF header. That patch is attached. > However, it still results in a test failure with this line: > assertTrue( totalAmt.getDictionary().getDictionaryObject( "AP" ) == null ); > I haven't looked at the test file enough to determine where the problem is. getDictionaryObject("AP") is returning a COSDictionary. PDFDebugger shows that eeSuppTotalAmt is in entry 58, but I don't see any obvious reference to an "AP". > Also, TestFDF is being called twice in TestAll.java. That patch is also attached. > Please apply these patches and keep this open so that the assertion failure can be fixed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Wed Dec 03 23:08:14 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 8329 invoked from network); 3 Dec 2008 23:08:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Dec 2008 23:08:14 -0000 Received: (qmail 85911 invoked by uid 500); 3 Dec 2008 23:08:25 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 85896 invoked by uid 500); 3 Dec 2008 23:08:25 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 85885 invoked by uid 99); 3 Dec 2008 23:08:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 15:08:25 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO spunkymail-a6.g.dreamhost.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 23:06:56 +0000 Received: from [83.161.120.155] (ip65-47-145-42.z145-47-65.customer.algx.net [83.161.120.155]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by spunkymail-a6.g.dreamhost.com (Postfix) with ESMTP id A59E0109F2B for <michaelbecker@example.org>; Wed, 3 Dec 2008 15:07:13 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) Content-Transfer-Encoding: 7bit Message-Id: <michaelbecker@example.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed To: michaelbecker@example.org From: Brian Carrier <michaelbecker@example.org> Subject: Regression Tests Date: Wed, 3 Dec 2008 18:07:10 -0500 X-Mailer: Apple Mail (2.753.1) X-Virus-Checked: Checked by ClamAV on apache.org Hello, While looking at the regression tests, I found that TestPDFParser and TextStripperPerformance are not called. Does anyone know the history of these tests and why they are not included in the default tests? Also, does anyone know if TestFDF used to work? I had previously only been using the "testextract" target. thanks, brian From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 01:36:35 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 70524 invoked from network); 4 Dec 2008 01:36:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 01:36:34 -0000 Received: (qmail 81998 invoked by uid 500); 4 Dec 2008 01:36:46 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 81989 invoked by uid 500); 4 Dec 2008 01:36:46 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 81978 invoked by uid 99); 4 Dec 2008 01:36:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 17:36:46 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 01:35:26 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 25E84234C2A1 for <michaelbecker@example.org>; Wed, 3 Dec 2008 17:35:44 -0800 (PST) Message-ID: <1518139447.1228354544141.JavaMail.jira@brutus> Date: Wed, 3 Dec 2008 17:35:44 -0800 (PST) From: "Jukka Zitting (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Commented: (PDFBOX-392) Remove or replace the ICC profiles In-Reply-To: <1997392601.1227830924176.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653111#action_12653111 ] Jukka Zitting commented on PDFBOX-392: -------------------------------------- I removed the troublesome ICC profiles in revision 723183. This change breaks the PDDeviceCMYK class. To make it work, a user needs to explicitly place the CMYK.pf file in the classpath or file system at Resources/colorspace-profiles/CMYK.pf. Unless someone has a better idea on how to fix this, I suggest that we simply resolve this issue as fixed for 0.8.0 and include a warning about the change in the release notes. > Remove or replace the ICC profiles > ---------------------------------- > > Key: PDFBOX-392 > URL: https://issues.apache.org/jira/browse/PDFBOX-392 > Project: PDFBox > Issue Type: Sub-task > Reporter: Jukka Zitting > Priority: Blocker > Fix For: 0.8.0-incubator > > > The ICC profiles in src/main/resources/Resources/colorspace-profiles are licensed under the Sun Binary Code License that doesn't satisfy the Open Source Definition and is thus can not be distributed by an Apache project. > The ICC profiles (more accurately just the CMYK profile) are used by the o.a.p.pdmodel.graphics.color.PDDeviceCMYK class. Would it be possible for us to get the CMYK color profile from somewhere with a different license? Alternatively, is there some other way we could avoid using the CMYK profile or perhaps automatically locate and (if available) use it only in the runtime environment? > In any case we need to drop the current ICC profiles from src/main/resources/Resources/colorspace-profiles. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 08:33:41 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 42818 invoked from network); 4 Dec 2008 08:33:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 08:33:41 -0000 Received: (qmail 41854 invoked by uid 500); 4 Dec 2008 08:33:49 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 41848 invoked by uid 500); 4 Dec 2008 08:33:49 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 41827 invoked by uid 99); 4 Dec 2008 08:33:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 00:33:49 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO mx4.rwe.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 08:32:20 +0000 From: <michaelbecker@example.org> To: <michaelbecker@example.org> Date: Thu, 4 Dec 2008 09:32:05 +0100 Subject: AW: Regression Tests Thread-Topic: Regression Tests Thread-Index: AclVnAc7Xb06wAScRQC88dZK87OyWAAS12Qg Message-ID: <michaelbecker@example.org> In-Reply-To: <michaelbecker@example.org> Accept-Language: de-DE Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org Hi, >While looking at the regression tests, I found that TestPDFParser and >TextStripperPerformance are not called. Does anyone know the history >of these tests and why they are not included in the default tests? The TextStripperPerformance tests the stripping-function but without comparing the result with the expected result. So compared to the TextStripper-test it does less and therefore I guess it's obsolet. BR, Andreas ---------------------------------------------------------------- - Geschaeftsfuehrung: Chittur Ramakrishnan (Vorsitzender), Stefan Niehusmann - - Sitz der Gesellschaft: Dortmund - - Eingetragen beim Amtsgericht Dortmund - - Handelsregister-Nr. HR B 21222 - - USt.-IdNr. DE 2588 96 719 - From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 13:56:35 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 90127 invoked from network); 4 Dec 2008 13:56:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 13:56:35 -0000 Received: (qmail 82422 invoked by uid 500); 4 Dec 2008 13:56:47 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 82387 invoked by uid 500); 4 Dec 2008 13:56:47 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 82376 invoked by uid 99); 4 Dec 2008 13:56:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 05:56:47 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 13:55:26 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 41C1C234C2D4 for <michaelbecker@example.org>; Thu, 4 Dec 2008 05:55:44 -0800 (PST) Message-ID: <849-419-6902.1228398944268.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 05:55:44 -0800 (PST) From: =?utf-8?Q?Andreas_Lehmk=C3=BChler_=28JIRA=29?= <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Commented: (PDFBOX-392) Remove or replace the ICC profiles In-Reply-To: <1997392601.1227830924176.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-392?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1265= 3301#action_12653301 ]=20 Andreas Lehmk=C3=BChler commented on PDFBOX-392: ------------------------------------------- I've found some code to replace the ICC-Profile dependency, so that this wo= n't be a problem anymore. It's licensed under the GPL. > Remove or replace the ICC profiles > ---------------------------------- > > Key: PDFBOX-392 > URL: https://issues.apache.org/jira/browse/PDFBOX-392 > Project: PDFBox > Issue Type: Sub-task > Reporter: Jukka Zitting > Priority: Blocker > Fix For: 0.8.0-incubator > > > The ICC profiles in src/main/resources/Resources/colorspace-profiles are = licensed under the Sun Binary Code License that doesn't satisfy the Open So= urce Definition and is thus can not be distributed by an Apache project. > The ICC profiles (more accurately just the CMYK profile) are used by the = o.a.p.pdmodel.graphics.color.PDDeviceCMYK class. Would it be possible for u= s to get the CMYK color profile from somewhere with a different license? Al= ternatively, is there some other way we could avoid using the CMYK profile = or perhaps automatically locate and (if available) use it only in the runt= ime environment? > In any case we need to drop the current ICC profiles from src/main/resour= ces/Resources/colorspace-profiles. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 14:00:05 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 92864 invoked from network); 4 Dec 2008 14:00:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 14:00:05 -0000 Received: (qmail 84139 invoked by uid 500); 4 Dec 2008 14:00:17 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 84124 invoked by uid 500); 4 Dec 2008 14:00:17 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 84113 invoked by uid 99); 4 Dec 2008 14:00:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 06:00:17 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 13:58:56 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 88946234C2D1 for <michaelbecker@example.org>; Thu, 4 Dec 2008 05:59:44 -0800 (PST) Message-ID: <673896270.1228399184435.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 05:59:44 -0800 (PST) From: "Jukka Zitting (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Commented: (PDFBOX-392) Remove or replace the ICC profiles In-Reply-To: <1997392601.1227830924176.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653303#action_12653303 ] Jukka Zitting commented on PDFBOX-392: -------------------------------------- GPL is also troublesome for Apache projects, see http://www.apache.org/legal/resolved.html. > Remove or replace the ICC profiles > ---------------------------------- > > Key: PDFBOX-392 > URL: https://issues.apache.org/jira/browse/PDFBOX-392 > Project: PDFBox > Issue Type: Sub-task > Reporter: Jukka Zitting > Priority: Blocker > Fix For: 0.8.0-incubator > > > The ICC profiles in src/main/resources/Resources/colorspace-profiles are licensed under the Sun Binary Code License that doesn't satisfy the Open Source Definition and is thus can not be distributed by an Apache project. > The ICC profiles (more accurately just the CMYK profile) are used by the o.a.p.pdmodel.graphics.color.PDDeviceCMYK class. Would it be possible for us to get the CMYK color profile from somewhere with a different license? Alternatively, is there some other way we could avoid using the CMYK profile or perhaps automatically locate and (if available) use it only in the runtime environment? > In any case we need to drop the current ICC profiles from src/main/resources/Resources/colorspace-profiles. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 14:08:04 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 220 invoked from network); 4 Dec 2008 14:08:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 14:08:04 -0000 Received: (qmail 97075 invoked by uid 500); 4 Dec 2008 14:08:16 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 97038 invoked by uid 500); 4 Dec 2008 14:08:16 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 97027 invoked by uid 99); 4 Dec 2008 14:08:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 06:08:16 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 14:06:56 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 41CB4234C2D4 for <michaelbecker@example.org>; Thu, 4 Dec 2008 06:07:44 -0800 (PST) Message-ID: <843295715.1228399664268.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 06:07:44 -0800 (PST) From: =?utf-8?Q?Andreas_Lehmk=C3=BChler_=28JIRA=29?= <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Commented: (PDFBOX-392) Remove or replace the ICC profiles In-Reply-To: <1997392601.1227830924176.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-392?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1265= 3306#action_12653306 ]=20 Andreas Lehmk=C3=BChler commented on PDFBOX-392: ------------------------------------------- :-( OK, I already remembered something like that. So finally I've to write = my own code. > Remove or replace the ICC profiles > ---------------------------------- > > Key: PDFBOX-392 > URL: https://issues.apache.org/jira/browse/PDFBOX-392 > Project: PDFBox > Issue Type: Sub-task > Reporter: Jukka Zitting > Priority: Blocker > Fix For: 0.8.0-incubator > > > The ICC profiles in src/main/resources/Resources/colorspace-profiles are = licensed under the Sun Binary Code License that doesn't satisfy the Open So= urce Definition and is thus can not be distributed by an Apache project. > The ICC profiles (more accurately just the CMYK profile) are used by the = o.a.p.pdmodel.graphics.color.PDDeviceCMYK class. Would it be possible for u= s to get the CMYK color profile from somewhere with a different license? Al= ternatively, is there some other way we could avoid using the CMYK profile = or perhaps automatically locate and (if available) use it only in the runt= ime environment? > In any case we need to drop the current ICC profiles from src/main/resour= ces/Resources/colorspace-profiles. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 17:32:53 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 56180 invoked from network); 4 Dec 2008 17:32:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 17:32:53 -0000 Received: (qmail 71284 invoked by uid 500); 4 Dec 2008 17:33:05 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 71274 invoked by uid 500); 4 Dec 2008 17:33:05 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 71263 invoked by uid 99); 4 Dec 2008 17:33:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 09:33:05 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO yorktown.networkredux.net) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 17:31:35 +0000 Received: from [83.161.120.155] (helo=localhost) by yorktown.networkredux.net with esmtpa (Exim 4.63) (envelope-from <michaelbecker@example.org>) id 1L8I3v-0005Jn-CU for michaelbecker@example.org; Thu, 04 Dec 2008 09:32:27 -0800 Received: from 83.161.120.155 ([83.161.120.155]) by localhost (Horde MIME library) with HTTP; Thu, 04 Dec 2008 12:32:27 -0500 Message-ID: <20081204123227.52vpyehkw0w4o4kc@localhost> Date: Thu, 04 Dec 2008 12:32:27 -0500 From: Ben Litchfield <michaelbecker@example.org> To: michaelbecker@example.org Subject: Re: AW: Regression Tests References: <michaelbecker@example.org> In-Reply-To: <michaelbecker@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.6) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - yorktown.networkredux.net X-AntiAbuse: Original Domain - incubator.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - benlitchfield.com X-Source: X-Source-Args: X-Source-Dir: X-Virus-Checked: Checked by ClamAV on apache.org They were not included in the default tests because of the time it =20 took to run them, I would usually run the default tests more =20 frequently and then the textstripper/performance one separate. Performance has been a concern since the beginning and sometimes even =20 small changes have had a dramatic effect on the performance so I think =20 performace tests should remain as part of the test suite, although I'm =20 sure the existing tests could be improved upon. The text-stripping specifically tests the quality of the output. Ben Quoting michaelbecker@example.org: > Hi, > >> While looking at the regression tests, I found that TestPDFParser and >> TextStripperPerformance are not called. Does anyone know the history >> of these tests and why they are not included in the default tests? > The TextStripperPerformance tests the stripping-function but without > comparing the result with the expected result. So compared to the > TextStripper-test it does less and therefore I guess it's obsolet. > > BR, > Andreas > > ---------------------------------------------------------------- > - Geschaeftsfuehrung: Chittur Ramakrishnan (Vorsitzender), > Stefan Niehusmann - > - Sitz der Gesellschaft: Dortmund - > - Eingetragen beim Amtsgericht Dortmund - > - Handelsregister-Nr. HR B 21222 - > - USt.-IdNr. DE 2588 96 719 - > From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 22:35:15 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 32365 invoked from network); 4 Dec 2008 22:35:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 22:35:15 -0000 Received: (qmail 12063 invoked by uid 500); 4 Dec 2008 22:35:27 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 12055 invoked by uid 500); 4 Dec 2008 22:35:27 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 12044 invoked by uid 99); 4 Dec 2008 22:35:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 14:35:27 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 22:33:56 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 83D11234C300 for <michaelbecker@example.org>; Thu, 4 Dec 2008 14:34:44 -0800 (PST) Message-ID: <332358701.1228430084538.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 14:34:44 -0800 (PST) From: "Jukka Zitting (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Commented: (PDFBOX-391) Remove or replace troublesome test files In-Reply-To: <1823267723.1227829364211.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653524#action_12653524 ] Jukka Zitting commented on PDFBOX-391: -------------------------------------- I quickly browsed through the test files, and only the following look like something that I'd feel comfortable redistributing within an Apache project: test/input/cweb.pdf test/input/data-000001.pdf test/input/Liste732004001452_001_0.pdf_0_.pdf test/input/openoffice-test-document test/input/sample_fonts_solidconvertor.pdf test/input/sampleForSpec.pdf test/input/simple-openoffice.pdf test/input/yaddatest.pdf test/pdfreader/debug.xml.pdf test/pdfreader/excel.pdf test/pdfreader/ollix_test_2005-03-11_bin.pdf test/pdfreader/pdfbox_webpage.pdf Note that there is a clear distinction between using and redistributing something. We could still come up with a way to use the test suite in our Hudson CI build and individually by each developer, but we probably can't keep the documents in svn and we definitely can't release them as a part of PDFBox. > Remove or replace troublesome test files > ---------------------------------------- > > Key: PDFBOX-391 > URL: https://issues.apache.org/jira/browse/PDFBOX-391 > Project: PDFBox > Issue Type: Sub-task > Reporter: Jukka Zitting > Priority: Blocker > Fix For: 0.8.0-incubator > > > One issue raised by the license review (PDFBOX-366) is the status of the various test PDF files included in the test directory. Many of these don't seem to come with a license that would permit redistribution within an Apache project, so our only option seems to be to remove or replace the files before we can make the first Apache release. > The full list of potentially (I haven't looked at all of these in detail so some might be OK for us to keep) troublesome test files is: > $ find test -name '*.pdf' > test/encryption/encrypted_doc_no_id.pdf > test/input/10101-AR.pdf > test/input/601501018.pdf > test/input/Exolab.pdf > test/input/FreedomExpressions.pdf > test/input/Garcia2003b__Correlative_exploration_of_EEG_Signals.pdf > test/input/Garcia2004_thesis.pdf > test/input/Hd301212.pdf > test/input/JavaMail-1.2.pdf > test/input/Liste732004001452_001_0.pdf_0_.pdf > test/input/Michel2001__Review_p2_structured.pdf > test/input/News-Oct-2001-RUS.pdf > test/input/OLS2000-rsync.pdf > test/input/OSP_framework.pdf > test/input/SphericalHomeomorphism.pdf > test/input/T05140.pdf > test/input/TEST_SetCharSpacing_Error.pdf > test/input/amyuni2_05d__pdf1_3_acro4x.pdf > test/input/authentication.pdf > test/input/c21-5916 .pdf > test/input/citi-tr-00-4.ps.gz.pdf > test/input/connection_pool.pdf > test/input/cweb.pdf > test/input/data-000001.pdf > test/input/defensive_driving_class_schedule.pdf > test/input/ekb_deutsch.pdf > test/input/emsv4a4.pdf > test/input/fdeb.pdf > test/input/frweb-f-332-18.pdf > test/input/hexnumberproblem.pdf > test/input/irs tax guide for small businesses.pdf > test/input/jose-lugo-test.pdf > test/input/jun2003.pdf > test/input/null_thread_bead.pdf > test/input/ocalc.pdf > test/input/openoffice-test-document.pdf > test/input/org.eclipse.platform.doc.isv.pdf > test/input/pdf_with_lots_of_fields.pdf > test/input/rc5.pdf > test/input/reservedparkingsalaryreductionauthorization.pdf > test/input/ruminations.pdf > test/input/sampleForSpec.pdf > test/input/sample_fonts_solidconvertor.pdf > test/input/sha256.pdf > test/input/simple-openoffice.pdf > test/input/surface_interpolation.pdf > test/input/tech_report.pdf > test/input/terms_and_conditions_book.pdf > test/input/test_rotate_270.pdf > test/input/warp.pdf > test/input/welcome.pdf > test/input/whats_new.pdf > test/input/yaddatest.pdf > test/pdfparser/genko_oc_shiryo1.pdf > test/pdfreader/debug.xml.pdf > test/pdfreader/excel.pdf > test/pdfreader/ollix_test_2005-03-11_bin.pdf > test/pdfreader/pdfbox_webpage.pdf > My suggestion is that (in line with PDFBOX-368) we create a new src/test/resources directory where we move all reviewed and accepted test cases. Once all these files have been reviewed, we just drop the remaining ones for which an acceptable license could not be found. It would be nice if replacements could be created for such test cases, but in some cases (special PDF constructs, etc.) that might be a bit troublesome so I guess we'll just need to live with some reduction in test coverage due to this. > For more background, see the discussions at http://markmail.org/message/z7meilylwifef7db and http://markmail.org/message/cuyylr6zqs4fwdiz. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 22:47:44 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 36341 invoked from network); 4 Dec 2008 22:47:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 22:47:44 -0000 Received: (qmail 26293 invoked by uid 500); 4 Dec 2008 22:47:56 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 26280 invoked by uid 500); 4 Dec 2008 22:47:56 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 26269 invoked by uid 99); 4 Dec 2008 22:47:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 14:47:56 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 22:46:26 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 409AA234C2FA for <michaelbecker@example.org>; Thu, 4 Dec 2008 14:46:44 -0800 (PST) Message-ID: <1121751636.1228430804263.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 14:46:44 -0800 (PST) From: "Brian Carrier (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Commented: (PDFBOX-377) Incorrect direction of extracted Arabic Text In-Reply-To: <477454789.1221854684521.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-377?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1265= 3529#action_12653529 ]=20 Brian Carrier commented on PDFBOX-377: -------------------------------------- I have redone this patch to make it optional at runtime and so that it take= s into account other code changes that have been made since the original pa= tch. ICU4J is needed to build PDFBOX, but it tests for the relevant classes= at runtime to determine if the ICU4J components should be used. Updated a= nt and maven files are included in the diff. While working on this patch, I realized that PDFTextStripper (and its subcl= asses) were not consistent with how they wrote to the output (some called o= utput directly and others used wrapper functions). I made it more consiste= nt and added some more wrappers (such as writeString). I then realized that= some of the functions were not consistently named. For example processLin= eSeparator() was not really processing a lineseparator in the PDF file (lik= e processPage() does). It prints a line separator, so I renamed it to write= LineSeparator() and deprecated the original. There were a few other functio= ns that I found to be inconsistently named and so I made them more consiste= nt (and made deprecated wrappers for backwards compatibility).=20 For example: - PDFStreamEngine.showCharacter() was renamed to processTextPosition() beca= use it doesn't always show a character and it is in the hierarchy of proces= sXXX() functions that include processPages(), processPage(), etc.=20 - Similarly, PDFStreamEngine.showString() was renamed to processEncodedText= () because a) it doesn't display anything and b) it takes encoded data as i= nput (not a normal string).=20 - PDFTextStripper.flushText() was renamed to writePage() because it is the = writing counterpart to processPage() and it operates at the page scale, ver= sus document scale.=20 I migrated these renames to the classes that use them to remove the depreca= ted warnings.=20 There are three failures on the regression tests. They are improvements.=20 - The 10101-AR.pdf now has more correct arabic text in it. It is better if= sorting is enabled, but the tests do not use sorting. - The cweb.pdf and Garcia2004_thesis.pdf failures are now both better becau= se the 'ff' ligature has been removed and replaced with "f" and "f". > Incorrect direction of extracted Arabic Text > -------------------------------------------- > > Key: PDFBOX-377 > URL: https://issues.apache.org/jira/browse/PDFBOX-377 > Project: PDFBox > Issue Type: Bug > Components: Text extraction > Affects Versions: 0.8.0-incubator > Reporter: Brian Carrier > Attachments: hello3.pdf, PDFTextStripper.diff > > > Arabic text (and other right to left languages) is stored in presentation= format in PDF files, which is the opposite of the logical order that Arabi= c text is typically stored. Arabic text is typically stored such that the f= irst byte is for the right-most character, but the output of PDFBox has the= first byte always being the left-most character.=20 > Further, PDF files typically store the presentation form of Arabic charac= ters instead the more general form. For example, U+FB50 instead of U+0671. = The presentation form is not supposed to be stored in the logical form, but= PDFBox does not normalize them out.=20 > The attached patch solves both of these problems using the ICU4J library = (http://www.icu-project.org/). It identifies the dominant text direction o= f each page and reverses the order of each line (only if any right to left = text exists). It then normalizes the text to remove the presentation forms= .=20 > An example file is attached. Without the patch, the following is (incorr= ectly) produced: > Hello =EF=BA=AA=EF=BB=A4=EF=BA=A4=EF=BB=A3 World.=20 > With the patch, the following is (correctly) produced: > Hello =D9=85=D8=AD=D9=85=D8=AF World.=20 --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Thu Dec 04 22:49:43 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 36935 invoked from network); 4 Dec 2008 22:49:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Dec 2008 22:49:43 -0000 Received: (qmail 30080 invoked by uid 500); 4 Dec 2008 22:49:55 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 30043 invoked by uid 500); 4 Dec 2008 22:49:55 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 30032 invoked by uid 99); 4 Dec 2008 22:49:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 14:49:55 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 22:48:26 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 4140E234C2FA for <michaelbecker@example.org>; Thu, 4 Dec 2008 14:48:44 -0800 (PST) Message-ID: <1210434089.1228430924266.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 14:48:44 -0800 (PST) From: "Brian Carrier (JIRA)" <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Updated: (PDFBOX-377) Incorrect direction of extracted Arabic Text In-Reply-To: <477454789.1221854684521.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-377?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Carrier updated PDFBOX-377: --------------------------------- Attachment: reorder-patch.zip Updated patch (with ICU jar file) > Incorrect direction of extracted Arabic Text > -------------------------------------------- > > Key: PDFBOX-377 > URL: https://issues.apache.org/jira/browse/PDFBOX-377 > Project: PDFBox > Issue Type: Bug > Components: Text extraction > Affects Versions: 0.8.0-incubator > Reporter: Brian Carrier > Attachments: hello3.pdf, PDFTextStripper.diff, reorder-patch.zip > > > Arabic text (and other right to left languages) is stored in presentation= format in PDF files, which is the opposite of the logical order that Arabi= c text is typically stored. Arabic text is typically stored such that the f= irst byte is for the right-most character, but the output of PDFBox has the= first byte always being the left-most character.=20 > Further, PDF files typically store the presentation form of Arabic charac= ters instead the more general form. For example, U+FB50 instead of U+0671. = The presentation form is not supposed to be stored in the logical form, but= PDFBox does not normalize them out.=20 > The attached patch solves both of these problems using the ICU4J library = (http://www.icu-project.org/). It identifies the dominant text direction o= f each page and reverses the order of each line (only if any right to left = text exists). It then normalizes the text to remove the presentation forms= .=20 > An example file is attached. Without the patch, the following is (incorr= ectly) produced: > Hello =EF=BA=AA=EF=BB=A4=EF=BA=A4=EF=BB=A3 World.=20 > With the patch, the following is (correctly) produced: > Hello =D9=85=D8=AD=D9=85=D8=AF World.=20 --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Fri Dec 05 07:11:35 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 60577 invoked from network); 5 Dec 2008 07:11:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Dec 2008 07:11:35 -0000 Received: (qmail 7520 invoked by uid 500); 5 Dec 2008 07:11:47 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 7509 invoked by uid 500); 5 Dec 2008 07:11:47 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 7498 invoked by uid 99); 5 Dec 2008 07:11:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Dec 2008 23:11:47 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2008 07:10:26 +0000 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 62249234C30C for <michaelbecker@example.org>; Thu, 4 Dec 2008 23:10:44 -0800 (PST) Message-ID: <849-419-6902.1228461044400.JavaMail.jira@brutus> Date: Thu, 4 Dec 2008 23:10:44 -0800 (PST) From: =?utf-8?Q?Andreas_Lehmk=C3=BChler_=28JIRA=29?= <michaelbecker@example.org> To: michaelbecker@example.org Subject: [jira] Updated: (PDFBOX-392) Remove or replace the ICC profiles In-Reply-To: <1997392601.1227830924176.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PDFBOX-392?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Lehmk=C3=BChler updated PDFBOX-392: -------------------------------------- Attachment: DeviceCMYK_392.txt I made a patch to avoid using the ICC-Profiles coming with JAI. The needed = colorspaces are used in PDFBox to convert colorvalues from a soucre colorsp= ace coming with the pdf-document to the default-colorspace sRGB or CIEXYZ f= or displaying and printing the pdf-document. To do so, I wrote a new class = for the needed conversions. It inherits from java.awt.color.ColorSpace and = doesn't use any ICC-Profile. Perhaps in future we will come back to this point. These profiles are inter= esting for dispalying documents on calibrated monitors or printing on calib= rated printers. This feature has to be configurable during the runtime or b= y a configuration-file divided in printing and displaying. But I think, the= re are many other issues to solve and features to implement which are more = important for the moment. > Remove or replace the ICC profiles > ---------------------------------- > > Key: PDFBOX-392 > URL: https://issues.apache.org/jira/browse/PDFBOX-392 > Project: PDFBox > Issue Type: Sub-task > Reporter: Jukka Zitting > Priority: Blocker > Fix For: 0.8.0-incubator > > Attachments: DeviceCMYK_392.txt > > > The ICC profiles in src/main/resources/Resources/colorspace-profiles are = licensed under the Sun Binary Code License that doesn't satisfy the Open So= urce Definition and is thus can not be distributed by an Apache project. > The ICC profiles (more accurately just the CMYK profile) are used by the = o.a.p.pdmodel.graphics.color.PDDeviceCMYK class. Would it be possible for u= s to get the CMYK color profile from somewhere with a different license? Al= ternatively, is there some other way we could avoid using the CMYK profile = or perhaps automatically locate and (if available) use it only in the runt= ime environment? > In any case we need to drop the current ICC profiles from src/main/resour= ces/Resources/colorspace-profiles. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From pdfbox-dev-returnmichaelbecker@example.org Mon Dec 08 00:24:42 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 6125 invoked from network); 8 Dec 2008 00:24:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 8 Dec 2008 00:24:42 -0000 Received: (qmail 47636 invoked by uid 500); 8 Dec 2008 00:24:54 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 47600 invoked by uid 500); 8 Dec 2008 00:24:54 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 47589 invoked by uid 99); 8 Dec 2008 00:24:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Dec 2008 16:24:54 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of michaelbecker@example.org designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO rv-out-0708.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 00:23:24 +0000 Received: by rv-out-0708.google.com with SMTP id k29so1065459rvb.0 for <michaelbecker@example.org>; Sun, 07 Dec 2008 16:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=bWAAR3NGy9x1KLkLFOb2UMlZAHadUsfEGjPOgVpSHGA=; b=lXc09JxLo6nT+BThoSM45FVTpYUIh+v3prv0KMlfW32joC6xQ/ItBg1/RdOOFNWoLw tw8kr4sNA1b+RYtxtLts6vmisftV/Aa3ttyvo6DlF1wU2X2p6o93jYOxPMxw5NrUbRQJ jSsFKjHLJYhp8vkrUl/BmB/1jeK2pHClOFsPw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=cjalkREKzOnrUTMJo3zvi5olejlrzZOsxoe8T0zoqvMBi44uk4ae43BApPvYSQPhbg UgIrvsmEyvqaipGIWG+/FLRqI/BC96F8KOEJPTiaueFCxZN9xfoft5i/NqNc7ZeWlBNq kzJq2KTDyfnTov5g/VcpxRda/bvlzbjFgm7vk= Received: by 83.161.120.155 with SMTP id o14mr1360561rvf.3.1228695843120; Sun, 07 Dec 2008 16:24:03 -0800 (PST) Received: by 83.161.120.155 with HTTP; Sun, 7 Dec 2008 16:24:03 -0800 (PST) Message-ID: <michaelbecker@example.org> Date: Mon, 8 Dec 2008 01:24:03 +0100 From: "Jukka Zitting" <michaelbecker@example.org> To: michaelbecker@example.org Subject: License review update MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org Hi, It looks like we are pretty close to a resolution on the CMap issue [1], and Andreas has written a patch to address the ICC profile issue [2]. This leaves us with only the troublesome test files [3]. It seems clear that we can't redistribute the test files in an Apache release, so the most straightforward solution is to simply drop the tests so that we can move forward with the 0.8.0-incubating release. To keep the tests we could repackage the test suite as an independent component and release it under the PDFBox SourceForge project with proper disclaimers about the copyright status of the included files. Then in our developer documentation at Apache we could have a pointer to that test suite and instructions on how to integrate it with a normal PDFBox checkout. [1] https://issues.apache.org/jira/browse/LEGAL-36 [2] https://issues.apache.org/jira/browse/PDFBOX-392 [3] https://issues.apache.org/jira/browse/PDFBOX-391 BR, Jukka Zitting From pdfbox-dev-returnmichaelbecker@example.org Mon Dec 08 14:54:27 2008 Return-Path: <pdfbox-dev-returnmichaelbecker@example.org> Delivered-To: michaelbecker@example.org Received: (qmail 28203 invoked from network); 8 Dec 2008 14:54:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 8 Dec 2008 14:54:27 -0000 Received: (qmail 74693 invoked by uid 500); 8 Dec 2008 14:54:27 -0000 Delivered-To: michaelbecker@example.org Received: (qmail 74660 invoked by uid 500); 8 Dec 2008 14:54:27 -0000 Mailing-List: contact michaelbecker@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:michaelbecker@example.org> List-Unsubscribe: <mailto:michaelbecker@example.org> List-Post: <mailto:michaelbecker@example.org> List-Id: <pdfbox-dev.incubator.apache.org> Reply-To: michaelbecker@example.org Delivered-To: mailing list michaelbecker@example.org Received: (qmail 74627 invoked by uid 99); 8 Dec 2008 14:54:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 06:54:27 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO spunkymail-a18.g.dreamhost.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Dec 2008 14:54:12 +0000 Received: from [83.161.120.155] (ip65-47-145-42.z145-47-65.customer.algx.net [83.161.120.155]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by spunkymail-a18.g.dreamhost.com (Postfix) with ESMTP id 807765B4F7 for <michaelbecker@example.org>; Mon, 8 Dec 2008 06:53:50 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) In-Reply-To: <michaelbecker@example.org> References: <michaelbecker@example.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <michaelbecker@example.org> Content-Transfer-Encoding: 7bit From: Brian Carrier <michaelbecker@example.org> Subject: Re: License review update Date: Mon, 8 Dec 2008 09:53:39 -0500 To: michaelbecker@example.org X-Mailer: Apple Mail (2.753.1) X-Virus-Checked: Checked by ClamAV on apache.org Hi Jukka, On Dec 7, 2008, at 7:24 PM, Jukka Zitting wrote: > To keep the tests we could repackage the test suite as an independent > component and release it under the PDFBox SourceForge project with > proper disclaimers about the copyright status of the included files. > Then in our developer documentation at Apache we could have a pointer > to that test suite and instructions on how to integrate it with a > normal PDFBox checkout. This sounds good. For the text extraction tests, and possibly the others, we could do it such that the SF files are placed in their own directory and the test suite will test for the existence of the directory (and not give an error if it does not exist). Before we move the test files though, I would like to think about how we can improve the text extraction regression tests. Currently, there is a single "input" directory with PDF files and a
{'source': 'Apache Software Foundation Public Mail Archives'}