From mendozajillian@example.org Wed Jan 18 06:18:46 2006
Return-Path: <mendozajillian@example.org>
Delivered-To: mendozajillian@example.org
Received: (qmail 86403 invoked from network); 18 Jan 2006 06:18:46 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 18 Jan 2006 06:18:46 -0000
Received: (qmail 22019 invoked by uid 500); 18 Jan 2006 06:18:46 -0000
Mailing-List: contact mendozajillian@example.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mendozajillian@example.org>
List-Unsubscribe: <mailto:mendozajillian@example.org>
List-Post: <mailto:mendozajillian@example.org>
List-Id: <test-dev.perl.apache.org>
Reply-To: mendozajillian@example.org
Delivered-To: mailing list mendozajillian@example.org
Delivered-To: moderator for mendozajillian@example.org
Received: (qmail 65949 invoked by uid 99); 16 Jan 2006 21:54:14 -0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of mendozajillian@example.org designates 83.161.120.155 as permitted sender)
Message-ID: <mendozajillian@example.org>
Date: Mon, 16 Jan 2006 13:53:44 -0800
From: "Philippe M. Chiasson" <mendozajillian@example.org>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To:  mendozajillian@example.org
Subject: test123
X-Enigmail-Version: 83.161.120.155
Content-Type: multipart/signed; micalg=pgp-ripemd160;
 protocol="application/pgp-signature";
 boundary="------------enig017D6DFA06199D241BB4B936"
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

--------------enig017D6DFA06199D241BB4B936
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

test
-- 
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

--------------enig017D6DFA06199D241BB4B936
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFDzBXoyzKhB4jDpaURA1brAKCrFFkGNmFE+44Yxu0kWxNJwVuwKACeJxd3
bqko5HVYPWgoQ+CZ6k7QrD4=
=wERX
-----END PGP SIGNATURE-----

--------------enig017D6DFA06199D241BB4B936--

From mendozajillian@example.org Fri Jan 27 02:57:51 2006
Return-Path: <mendozajillian@example.org>
Delivered-To: mendozajillian@example.org
Received: (qmail 63167 invoked from network); 27 Jan 2006 02:57:51 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 27 Jan 2006 02:57:51 -0000
Received: (qmail 41478 invoked by uid 500); 27 Jan 2006 02:57:51 -0000
Mailing-List: contact mendozajillian@example.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mendozajillian@example.org>
List-Unsubscribe: <mailto:mendozajillian@example.org>
List-Post: <mailto:mendozajillian@example.org>
List-Id: <test-dev.perl.apache.org>
Reply-To: mendozajillian@example.org
Delivered-To: mailing list mendozajillian@example.org
Received: (qmail 41467 invoked by uid 99); 27 Jan 2006 02:57:50 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2006 18:57:50 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [83.161.120.155] (HELO secure.exclamationlabs.net) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2006 18:57:50 -0800
Received: from [83.161.120.155] (pcp0010776620pcs.walngs01.pa.comcast.net [83.161.120.155])
	(authenticated (0 bits))
	by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id k0R2vZC08961;
	Thu, 26 Jan 2006 20:57:35 -0600
Message-ID: <mendozajillian@example.org>
Date: Thu, 26 Jan 2006 21:57:28 -0500
From: Geoffrey Young <mendozajillian@example.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040927
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: mendozajillian@example.org, mendozajillian@example.org
Subject: Re: svn commit: r372663 - /perl/Apache-Test/trunk/lib/Apache/Test.pm
References: <mendozajillian@example.org>
In-Reply-To: <mendozajillian@example.org>
X-Enigmail-Version: 83.161.120.155
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

hi colm :)

mendozajillian@example.org wrote:
> Author: colm
> Date: Thu Jan 26 15:44:59 2006
> New Revision: 372663
> 
> URL: http://svn.apache.org/viewcvs?rev=372663&view=rev
> Log:
> Revert most of r371931, as it currently breaks the test suite. need_php
> in particular is returning success when it shouldn't be.

hmph.  I'm sorry you had to go through all that, but next time just speak up
- I would have happily worked on fixing it rather than have you go through a
few different iterations trying to make it work then backing the whole thing
out.  sorry I don't follow new-httpd as much as I should...

anyway, the problem was mostly a variable stomping issue.  but with php in
particular it was a cut and paste error: need_php4 was checking for php4 or
php5 instead of php4 and sapi_apache.c.  and that was even carried over to
the current version as well ;)

so, should be all fixed now, so give it another whirl.

oh, I tweaked need_imagemap a bit for you and added a brief doc while I was
at it ;)

--Geoff

From mendozajillian@example.org Fri Jan 27 08:49:20 2006
Return-Path: <mendozajillian@example.org>
Delivered-To: mendozajillian@example.org
Received: (qmail 4394 invoked from network); 27 Jan 2006 08:49:20 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 27 Jan 2006 08:49:20 -0000
Received: (qmail 14376 invoked by uid 500); 27 Jan 2006 08:49:19 -0000
Mailing-List: contact mendozajillian@example.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mendozajillian@example.org>
List-Unsubscribe: <mailto:mendozajillian@example.org>
List-Post: <mailto:mendozajillian@example.org>
List-Id: <test-dev.perl.apache.org>
Reply-To: mendozajillian@example.org
Delivered-To: mailing list mendozajillian@example.org
Received: (qmail 14361 invoked by uid 99); 27 Jan 2006 08:49:19 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2006 00:49:19 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [83.161.120.155] (HELO dochas.stdlib.net) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2006 00:49:18 -0800
Received: from colmmacc by dochas.stdlib.net with local (Exim 4.50)
	id 1F2PJ2-0000Cz-6m; Fri, 27 Jan 2006 08:50:08 +0000
Date: Fri, 27 Jan 2006 08:50:08 +0000
From: Colm MacCarthaigh <mendozajillian@example.org>
To: mendozajillian@example.org
Cc: mendozajillian@example.org
Subject: Re: svn commit: r372663 - /perl/Apache-Test/trunk/lib/Apache/Test.pm
Message-ID: <mendozajillian@example.org>
Reply-To: mendozajillian@example.org
References: <mendozajillian@example.org> <mendozajillian@example.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <mendozajillian@example.org>
User-Agent: Mutt/1.5.9i
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

On Thu, Jan 26, 2006 at 09:57:28PM -0500, Geoffrey Young wrote:
> hmph.  I'm sorry you had to go through all that, but next time just speak up

I didn't know where to :) I was actually surprised I could commit to it,
and then I thought dev@httpd was the place for discussion and assumed it
was dead. It was only later that I found this list, so my bad.

> - I would have happily worked on fixing it rather than have you go through a
> few different iterations trying to make it work then backing the whole thing
> out.  sorry I don't follow new-httpd as much as I should...

I'll update our docs later to be more clear on where things are tracked,
here is a fine place, I don't think you should have to track  the httpd
list, it's pretty noisy!

> anyway, the problem was mostly a variable stomping issue.  but with php in
> particular it was a cut and paste error: need_php4 was checking for php4 or
> php5 instead of php4 and sapi_apache.c.  and that was even carried over to
> the current version as well ;)
> 
> so, should be all fixed now, so give it another whirl.

Yep, no more errors or dubious results.

> oh, I tweaked need_imagemap a bit for you and added a brief doc while I was
> at it ;)

Thank you very much!

-- 
Colm MacCárthaigh                        Public Key: mendozajillian@example.org

From mendozajillian@example.org Fri Jan 27 13:56:58 2006
Return-Path: <mendozajillian@example.org>
Delivered-To: mendozajillian@example.org
Received: (qmail 81655 invoked from network); 27 Jan 2006 13:56:58 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 27 Jan 2006 13:56:58 -0000
Received: (qmail 720 invoked by uid 500); 27 Jan 2006 13:56:57 -0000
Mailing-List: contact mendozajillian@example.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mendozajillian@example.org>
List-Unsubscribe: <mailto:mendozajillian@example.org>
List-Post: <mailto:mendozajillian@example.org>
List-Id: <test-dev.perl.apache.org>
Reply-To: mendozajillian@example.org
Delivered-To: mailing list mendozajillian@example.org
Received: (qmail 709 invoked by uid 99); 27 Jan 2006 13:56:57 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2006 05:56:57 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [83.161.120.155] (HELO secure.exclamationlabs.net) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2006 05:56:56 -0800
Received: from [83.161.120.155] (pcp0010776620pcs.walngs01.pa.comcast.net [83.161.120.155])
	(authenticated (0 bits))
	by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id k0RDuZf24208;
	Fri, 27 Jan 2006 07:56:35 -0600
Message-ID: <mendozajillian@example.org>
Date: Fri, 27 Jan 2006 08:56:34 -0500
From: Geoffrey Young <mendozajillian@example.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040927
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: mendozajillian@example.org
CC: mendozajillian@example.org
Subject: Re: svn commit: r372663 - /perl/Apache-Test/trunk/lib/Apache/Test.pm
References: <mendozajillian@example.org> <mendozajillian@example.org> <mendozajillian@example.org>
In-Reply-To: <mendozajillian@example.org>
X-Enigmail-Version: 83.161.120.155
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N



Colm MacCarthaigh wrote:
> On Thu, Jan 26, 2006 at 09:57:28PM -0500, Geoffrey Young wrote:
> 
>>hmph.  I'm sorry you had to go through all that, but next time just speak up
> 
> 
> I didn't know where to :) 

you're probably not alone - the lists have recently changed.

> I was actually surprised I could commit to it,

here's the history...

Apache-Test started as part of the mp2 project.  then the httpd-test project
was started (owned by httpd) and Apache-Test spun off as the engine for the
perl-framework under httpd-test.  then more things got added to httpd-test
and only mod_perl people were working on Apache-Test proper anyway, so last
year we took it back over under our project.  but all the original
committers to httpd-test (all of httpd) were allowed to keep their commit
privs to Apache-Test, kind of as a courtesy.

note that A-T is actually a separate project using svn externals on checkout
of httpd-test:

  http://svn.apache.org/repos/asf/perl/Apache-Test/

> and then I thought dev@httpd was the place for discussion and assumed it
> was dead. It was only later that I found this list, so my bad.

no, that's ok.  Apache-Test was given its own list (this one) when we took
it back over last year, making two lists - one for A-T and one for the rest
of httpd-test (the now dead test-dev@httpd).  then maybe last month justin
retired test-dev@httpd and moved discussion over to httpd.

so, the way things stand now, A-T probems/issues/discussion should happen
here, while the rest of httpd-test (including perl-framework/t) should
happen on httpd.  the idea was to get the real httpd tests discussed in the
right place, while still keeping the perl engine (A-T) visible and
maintained by the ASF people that know perl the best (and who happen to be
the nearly sole creators and maintaners of it, since we use it for the mp2
test suite and maintain a separate distribtion of just A-T).

> 
> 
>>- I would have happily worked on fixing it rather than have you go through a
>>few different iterations trying to make it work then backing the whole thing
>>out.  sorry I don't follow new-httpd as much as I should...
> 
> 
> I'll update our docs later to be more clear on where things are tracked,
> here is a fine place, I don't think you should have to track  the httpd
> list, it's pretty noisy!

:)

if you document that perl-framework/Apache-Test is really a separate project
in and of itself, under the direction of the perl pmc, and has its own
mailing list it should be a bit more clear.

really, I'd like to restrict commit access to just mod_perl folks (extended
to httpd people that have contributed and understand the project), or at
least ask that non-familiar-with-the-project folks follow RTC, since nobody
seems to enjoy coding perl quite as much as we do :)  but I don't want to
offend anyone either.

> 
> 
>>anyway, the problem was mostly a variable stomping issue.  but with php in
>>particular it was a cut and paste error: need_php4 was checking for php4 or
>>php5 instead of php4 and sapi_apache.c.  and that was even carried over to
>>the current version as well ;)
>>
>>so, should be all fixed now, so give it another whirl.
> 
> 
> Yep, no more errors or dubious results.

excellent.

> 
> 
>>oh, I tweaked need_imagemap a bit for you and added a brief doc while I was
>>at it ;)
> 
> 
> Thank you very much!

sure.  just for your own knowledge there exists two sets of testing methods
- need_* and have_* - such that things like need_imagemap() ought to have a
have_imagemap() counterpart.  the difference is that need_imagemap()
populates the skip message so can be used with plan(), while have_imagemap()
performs the exact same check without populating the skip message.  the net
result is that you can use have_imagemap() anywhere in your test code to
skip individual tests without affecting the overall skip message.

anyway, so every time you implement a need_* function you ought to do have_*
as well.  luckily the have_* counterparts are automagically created - all
you need to do is populate the @need array at the top of Test.pm with the
name of your new method.

just FYI if you're interested :)

--Geoff


{'source': 'Apache Software Foundation Public Mail Archives'}