From hdean@example.net Thu Feb 01 10:00:51 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 88402 invoked from network); 1 Feb 2007 10:00:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 10:00:51 -0000 Received: (qmail 53429 invoked by uid 500); 1 Feb 2007 10:00:58 -0000 Delivered-To: hdean@example.net Received: (qmail 53310 invoked by uid 500); 1 Feb 2007 10:00:57 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 53300 invoked by uid 99); 1 Feb 2007 10:00:57 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 02:00:57 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [83.161.120.155] (HELO byaroza.objectstyle.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 Feb 2007 02:00:48 -0800 Received: (qmail 25052 invoked from network); 1 Feb 2007 10:00:19 -0000 Received: from unknown (HELO ?JB?????IPv888a:dbb7:2d49:b3f6:8605:bf4e:caed:e5a4:1?) (83.161.120.155) by localhost with SMTP; 1 Feb 2007 10:00:19 -0000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <hdean@example.net> References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Andrus Adamchik <hdean@example.net> Subject: Re: DbEntity Comments Date: Thu, 1 Feb 2007 12:00:19 +0200 To: hdean@example.net X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org On Jan 31, 2007, at 11:57 PM, Mike Kienenberger wrote: > As for the overhead, maybe we can configure each user property as > something that should or should not be loaded. Perhaps specify which > load situations are appropriate: MODELER_ONLY, MODELER_PLUS_CGEN, or > ALWAYS. BTW, this is somewhat similar to Java annotation scope: SOURCE, CLASS, RUNTIME. > I've mostly been > holding off until the Eclipse/Maven/Ant/Java 1.5 build environment for > 3.0 settled down enough that I could do Cayenne work without having to > learn Maven. I am glad to say that we are finally past this point. Andrus From hdean@example.net Thu Feb 01 10:29:20 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 95651 invoked from network); 1 Feb 2007 10:29:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 10:29:20 -0000 Received: (qmail 84787 invoked by uid 500); 1 Feb 2007 10:29:26 -0000 Delivered-To: hdean@example.net Received: (qmail 84694 invoked by uid 500); 1 Feb 2007 10:29:26 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 84683 invoked by uid 99); 1 Feb 2007 10:29:26 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 02:29:26 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [83.161.120.155] (HELO byaroza.objectstyle.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 Feb 2007 02:29:17 -0800 Received: (qmail 25873 invoked from network); 1 Feb 2007 10:28:56 -0000 Received: from unknown (HELO ??2?????IPv888a:dbb7:2d49:b3f6:8605:bf4e:caed:e5a4:1?) (83.161.120.155) by localhost with SMTP; 1 Feb 2007 10:28:56 -0000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <hdean@example.net> References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Andrus Adamchik <hdean@example.net> Subject: Re: DbEntity Comments Date: Thu, 1 Feb 2007 12:28:54 +0200 To: hdean@example.net X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org On Jan 31, 2007, at 11:31 PM, Malcolm Edgar wrote: > My thinking on design would be to keep it a simple (80/20 rule > solution), in which I think a simple comment attribute to the mapping > XML elements. We can treat comments and properties as two separate features .... or not? They share these characteristics though - (a) the data is arbitrary and not linked to any Cayenne functions (except for reverse- engineering DB comments); (b) they may optionally be excluded from runtime; (c) users want both of them :-) > In an XML attribute we have to take care encoding the > value. Just sticking it in a CDATA section should take care of it. > With a simple optional attribute, I would think it would be a pretty > safe bet that there would not be any performance impact on the initial > startup time. I think we are also talking about a trivial amount of > memory. We are talking about BLOBS of text. Consider people using this for javadocs, with each attribute having a 100 char comment field. For the model of 50 entities with 20 attributes each, we have (50 + 50*20) * 100 = 102K. Not crucial, but still keeping this stuff around in runtime seems wrong. Those things add up over time, resulting in framework becoming heavier with every new release. I wouldn't mind storing the data in the main XML file, as the parser can skip it in runtime. So how about a simple solution - a single parameter passed to Configuration on load that includes or excludes optional metadata - no lazy loading hassle, still gives lots of flexibility (cgen will include it, runtime will exclude it by default). Andrus From hdean@example.net Thu Feb 01 11:32:13 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 10749 invoked from network); 1 Feb 2007 11:32:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 11:32:13 -0000 Received: (qmail 48257 invoked by uid 500); 1 Feb 2007 11:32:19 -0000 Delivered-To: hdean@example.net Received: (qmail 48238 invoked by uid 500); 1 Feb 2007 11:32:19 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 48229 invoked by uid 99); 1 Feb 2007 11:32:18 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 03:32:18 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO fish.ish.com.au) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 03:32:10 -0800 Received: from [83.161.120.155] (helo=[83.161.120.155]) by fish.ish.com.au with esmtpa (Exim 4.43) id 1HCaWi-00052g-0t for hdean@example.net; Thu, 01 Feb 2007 22:54:56 +1100 Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <hdean@example.net> References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-33-896257367" Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Aristedes Maniatis <hdean@example.net> Subject: Re: DbEntity Comments Date: Thu, 1 Feb 2007 22:31:41 +1100 To: hdean@example.net X-Pgp-Agent: GPGMail 1.1.2 (Tiger) X-Mailer: Apple Mail (2.752.2) X-Spam-Score: -1.4 (-) X-Spam-Report: -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-33-896257367 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed On 01/02/2007, at 9:28 PM, Andrus Adamchik wrote: > We are talking about BLOBS of text. Consider people using this for > javadocs, with each attribute having a 100 char comment field. For > the model of 50 entities with 20 attributes each, we have (50 + > 50*20) * 100 = 102K. Not crucial, but still keeping this stuff > around in runtime seems wrong. Those things add up over time, > resulting in framework becoming heavier with every new release. Not to mention it might contain private notes we may not want in a public release of a product. I don't want our entity documentation released to the world. How about a velocity(?) script which could strip some parts of the XML file for deployment? As long as they were easily identifiable, we could even put a little regex into our main ant build script for deploying the application. On the other hand, a separate config file for comments would make this easier... Ari --------------------------> ish http://www.ish.com.au Level 1, 30 Wilson Street Newtown 2042 Australia phone 3152033554 fax 3152033554 GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A --Apple-Mail-33-896257367 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (Darwin) iD8DBQFFwc+e72p9Lj5JECoRAlREAJ9RxwEVCWdlgn6D5ufDFcmYnRAbMwCeITlp cw2Whd9GfM1jMVk3CKXSF9I= =vkxC -----END PGP SIGNATURE----- --Apple-Mail-33-896257367-- From hdean@example.net Thu Feb 01 13:43:31 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 39267 invoked from network); 1 Feb 2007 13:43:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 13:43:30 -0000 Received: (qmail 82237 invoked by uid 500); 1 Feb 2007 13:43:36 -0000 Delivered-To: hdean@example.net Received: (qmail 82139 invoked by uid 500); 1 Feb 2007 13:43:36 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 82129 invoked by uid 99); 1 Feb 2007 13:43:36 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 05:43:36 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO nz-out-0506.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 05:43:27 -0800 Received: by nz-out-0506.google.com with SMTP id m22so423758nzf for <hdean@example.net>; Thu, 01 Feb 2007 05:43:06 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=iKOpjg0lnCpi913ql3vuhi5v1S5U1fnvHC0GX5GYSjqQyQ4If9cwyI9UwQbq3y6Jp3xzIUce457ymtkGAwlDLlFi1qyGMm3kcbljBpBqJyQsBg6YbV8pcO9MlGFv2e5FGZW6YR9linZyUR1Ci2OlDGIFdTaq3YGVBVr2orggc1A= Received: by 83.161.120.155 with SMTP id v16mr4184174pyk.1170337386673; Thu, 01 Feb 2007 05:43:06 -0800 (PST) Received: by 83.161.120.155 with HTTP; Thu, 1 Feb 2007 05:43:06 -0800 (PST) Message-ID: <hdean@example.net> Date: Thu, 1 Feb 2007 08:43:06 -0500 From: "Michael Gentry" <hdean@example.net> To: hdean@example.net Subject: FindBugs MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org What would the general consensus be here of using FindBugs (http://findbugs.sourceforge.net/)? I just used the 1.1.1 version to analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at least on my current source tree). I haven't used this tool much yet, but it seems like it could be useful. I also believe it has support to run in the background, like from an ant task. This could be useful for nightly builds. Or even like a weekly report of some kind. Thoughts? Thanks! /dev/mrg From hdean@example.net Thu Feb 01 13:59:39 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 42859 invoked from network); 1 Feb 2007 13:59:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 13:59:27 -0000 Received: (qmail 8337 invoked by uid 500); 1 Feb 2007 13:59:32 -0000 Delivered-To: hdean@example.net Received: (qmail 8325 invoked by uid 500); 1 Feb 2007 13:59:32 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 8305 invoked by uid 99); 1 Feb 2007 13:59:32 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 05:59:32 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [83.161.120.155] (HELO byaroza.objectstyle.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 01 Feb 2007 05:59:23 -0800 Received: (qmail 31665 invoked from network); 1 Feb 2007 13:59:01 -0000 Received: from unknown (HELO ?JB?????IPv888a:dbb7:2d49:b3f6:8605:bf4e:caed:e5a4:1?) (83.161.120.155) by localhost with SMTP; 1 Feb 2007 13:59:01 -0000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <hdean@example.net> References: <hdean@example.net> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Andrus Adamchik <hdean@example.net> Subject: Re: FindBugs Date: Thu, 1 Feb 2007 15:59:00 +0200 To: hdean@example.net X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org "FindBugs" names seems to imply too much for an automated tool :-) Can you post a report somewhere showing what kind of "bugs" it finds? Andrus On Feb 1, 2007, at 3:43 PM, Michael Gentry wrote: > What would the general consensus be here of using FindBugs > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 version to > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at > least on my current source tree). I haven't used this tool much yet, > but it seems like it could be useful. I also believe it has support > to run in the background, like from an ant task. This could be useful > for nightly builds. Or even like a weekly report of some kind. > > Thoughts? > > Thanks! > > /dev/mrg > From hdean@example.net Thu Feb 01 14:06:56 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 44868 invoked from network); 1 Feb 2007 14:06:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 14:06:56 -0000 Received: (qmail 17884 invoked by uid 500); 1 Feb 2007 14:07:02 -0000 Delivered-To: hdean@example.net Received: (qmail 17792 invoked by uid 500); 1 Feb 2007 14:07:02 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 17783 invoked by uid 99); 1 Feb 2007 14:07:02 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 06:07:02 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO nz-out-0506.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 06:06:53 -0800 Received: by nz-out-0506.google.com with SMTP id m22so428102nzf for <hdean@example.net>; Thu, 01 Feb 2007 06:06:32 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=UHqNqC3N2f2N6gvDi5a4a/amvK3gTiEP4c1e8UU9YrcVbuJ7SjS9Ux+8VG47OCMe12Pv+FHfZcCG3DjDbXIIMfwdraVfhlYbqbq7L6OeOBBRU0hcVUDnScI4JWLFYpIhmu4Uz49gmrB58CF1eJfeBWIyGTW5qXaBB77gqxHHULc= Received: by 83.161.120.155 with SMTP id f17mr1138472pyn.1170338792532; Thu, 01 Feb 2007 06:06:32 -0800 (PST) Received: by 83.161.120.155 with HTTP; Thu, 1 Feb 2007 06:06:32 -0800 (PST) Message-ID: <hdean@example.net> Date: Thu, 1 Feb 2007 09:06:32 -0500 From: "Michael Gentry" <hdean@example.net> To: hdean@example.net Subject: Re: FindBugs In-Reply-To: <hdean@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <hdean@example.net> <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org Well, it has GUI and command-line (which can be automated) support. I'm kind of in the mood to play with it today, so I'll try to put together something. I've been running it (GUI-mode) against some of the Java stuff around here and it is finding "interesting" things. :-) Thanks, /dev/mrg On 2/1/07, Andrus Adamchik <hdean@example.net> wrote: > "FindBugs" names seems to imply too much for an automated tool :-) > > Can you post a report somewhere showing what kind of "bugs" it finds? > > Andrus > > On Feb 1, 2007, at 3:43 PM, Michael Gentry wrote: > > > What would the general consensus be here of using FindBugs > > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 version to > > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at > > least on my current source tree). I haven't used this tool much yet, > > but it seems like it could be useful. I also believe it has support > > to run in the background, like from an ant task. This could be useful > > for nightly builds. Or even like a weekly report of some kind. > > > > Thoughts? > > > > Thanks! > > > > /dev/mrg > > > > From hdean@example.net Thu Feb 01 14:14:00 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 46949 invoked from network); 1 Feb 2007 14:13:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 14:13:59 -0000 Received: (qmail 31120 invoked by uid 500); 1 Feb 2007 14:14:05 -0000 Delivered-To: hdean@example.net Received: (qmail 31104 invoked by uid 500); 1 Feb 2007 14:14:05 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 31095 invoked by uid 99); 1 Feb 2007 14:14:05 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 06:14:05 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO fish.ish.com.au) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 06:13:57 -0800 Received: from [83.161.120.155] (helo=[83.161.120.155]) by fish.ish.com.au with esmtpa (Exim 4.43) id 1HCd3K-0007HV-CM for hdean@example.net; Fri, 02 Feb 2007 01:36:45 +1100 Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <hdean@example.net> References: <hdean@example.net> Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-35-905967381" Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Aristedes Maniatis <hdean@example.net> Subject: Re: FindBugs Date: Fri, 2 Feb 2007 01:13:31 +1100 To: hdean@example.net X-Pgp-Agent: GPGMail 1.1.2 (Tiger) X-Mailer: Apple Mail (2.752.2) X-Spam-Score: -1.4 (-) X-Spam-Report: -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-35-905967381 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed On 02/02/2007, at 12:43 AM, Michael Gentry wrote: > What would the general consensus be here of using FindBugs > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 version to > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at > least on my current source tree). I haven't used this tool much yet, > but it seems like it could be useful. I also believe it has support > to run in the background, like from an ant task. This could be useful > for nightly builds. Or even like a weekly report of some kind. From my experience of it, there are lots of 'bugs' it finds which you end up having to ignore. If that was the case, a weekly report may not be that helpful since anything useful would be buried in the noise. But if the FindBug count count be brought to zero, then a weekly script might be more useful. I seem to remember that there are lots of ways to configure the rules it runs to quite a fine degree. I seem to remember that the style and performance reports it created were less useful, but it found some interesting problems in our code base. Ari Maniatis --------------------------> ish http://www.ish.com.au Level 1, 30 Wilson Street Newtown 2042 Australia phone 3152033554 fax 3152033554 GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A --Apple-Mail-35-905967381 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (Darwin) iD8DBQFFwfWM72p9Lj5JECoRAl8CAJ4kBv76UsAutj62vSiV01/3BC9Q8wCfSOAM 27uJDC8WIICQz35iqLVZwpE= =VCNj -----END PGP SIGNATURE----- --Apple-Mail-35-905967381-- From hdean@example.net Thu Feb 01 14:57:00 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 65469 invoked from network); 1 Feb 2007 14:56:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 14:56:59 -0000 Received: (qmail 23662 invoked by uid 500); 1 Feb 2007 14:57:05 -0000 Delivered-To: hdean@example.net Received: (qmail 23636 invoked by uid 500); 1 Feb 2007 14:57:05 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 23626 invoked by uid 99); 1 Feb 2007 14:57:05 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 06:57:05 -0800 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO py-out-1112.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 06:56:54 -0800 Received: by py-out-1112.google.com with SMTP id h31so402387pyc for <hdean@example.net>; Thu, 01 Feb 2007 06:56:33 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=gFg1iAY6NGhoIwMHtYFMmP1o2WtMNR5cH+7ZsOFIn7GZij04YrNhJcWnshSn2bkHp2C8b/dUvyynZtbz8u8JiCwNZF62Q9CynG/Iah/oDcKjcRd1KCGNhnVf7mlgiojov/eDmdMJrF/lN7S5DqNrNPxLllCjlqDGnkWxCqWJsSM= Received: by 83.161.120.155 with SMTP id z17mr4335372pyl.1170341793563; Thu, 01 Feb 2007 06:56:33 -0800 (PST) Received: by 83.161.120.155 with HTTP; Thu, 1 Feb 2007 06:56:33 -0800 (PST) Message-ID: <hdean@example.net> Date: Thu, 1 Feb 2007 09:56:33 -0500 From: "Michael Gentry" <hdean@example.net> To: hdean@example.net Subject: Re: FindBugs In-Reply-To: <hdean@example.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3698_22975430.1170341793320" References: <hdean@example.net> <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_3698_22975430.1170341793320 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline There are ways to tell the tool to exclude bugs by a filter list. I haven't looked into the details of that yet, but that could be an option to eliminate things we decide are OK and don't want to appear again. I'm attaching an HTML report I produced with this command-line: ~/Projects/eclipse/workspace/Cayenne30/framework> ~/Desktop/findbugs-1.1.1/bin/findbugs -textui -effort:max -onlyAnalyze 'org.apache.cayenne.-' -low -html -outputFile modeler-report.html cayenne-modeler It also has a -xdocs option to produce output for Maven. Obviously, I have more work to do. :-) Thanks, /dev/mrg PS. If the mailing list strips the attachment and you want to see it (and don't want to run your own like I did above), shoot me an e-mail directly. On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: > > On 02/02/2007, at 12:43 AM, Michael Gentry wrote: > > > What would the general consensus be here of using FindBugs > > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 version to > > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at > > least on my current source tree). I haven't used this tool much yet, > > but it seems like it could be useful. I also believe it has support > > to run in the background, like from an ant task. This could be useful > > for nightly builds. Or even like a weekly report of some kind. > > > From my experience of it, there are lots of 'bugs' it finds which > you end up having to ignore. If that was the case, a weekly report > may not be that helpful since anything useful would be buried in the > noise. But if the FindBug count count be brought to zero, then a > weekly script might be more useful. I seem to remember that there are > lots of ways to configure the rules it runs to quite a fine degree. I > seem to remember that the style and performance reports it created > were less useful, but it found some interesting problems in our code > base. > > Ari Maniatis > > > --------------------------> > ish > http://www.ish.com.au > Level 1, 30 Wilson Street Newtown 2042 Australia > phone 3152033554 fax 3152033554 > GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A > > > > > ------=_Part_3698_22975430.1170341793320-- From hdean@example.net Thu Feb 01 17:06:24 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 21810 invoked from network); 1 Feb 2007 17:06:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 17:06:24 -0000 Received: (qmail 74226 invoked by uid 500); 1 Feb 2007 17:06:30 -0000 Delivered-To: hdean@example.net Received: (qmail 74207 invoked by uid 500); 1 Feb 2007 17:06:30 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Delivered-To: moderator for hdean@example.net Received: (qmail 60962 invoked by uid 99); 1 Feb 2007 16:58:35 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=PIiUf30W8jT3eOkB5E8PjSesmwkrGT5vaUt2x5k3ALJGou6nPNeZIw8oIUmi21VXVSs9yEdK/t0ez7bAoAjldSA91BGIihRR3sPse699oQ58KlrasGWJJkuq3lCCIX24NB9G23ft25TTyDv2Fft8lxFtoHMuA3DKX6IPY5edDiA= Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <hdean@example.net> References: <hdean@example.net> <hdean@example.net> <hdean@example.net> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Robert Zeigler <hdean@example.net> Subject: Re: FindBugs Date: Thu, 1 Feb 2007 10:57:39 -0600 To: hdean@example.net X-Mailer: Apple Mail (2.752.3) Sender: robert zeigler <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org Hi, I'd be interested in seeing the report. Robert On Feb 1, 2007, at 8:56 AM, Michael Gentry wrote: > There are ways to tell the tool to exclude bugs by a filter list. I > haven't looked into the details of that yet, but that could be an > option to eliminate things we decide are OK and don't want to appear > again. > > I'm attaching an HTML report I produced with this command-line: > > ~/Projects/eclipse/workspace/Cayenne30/framework> > ~/Desktop/findbugs-1.1.1/bin/findbugs -textui -effort:max -onlyAnalyze > 'org.apache.cayenne.-' -low -html -outputFile modeler-report.html > cayenne-modeler > > It also has a -xdocs option to produce output for Maven. Obviously, I > have more work to do. :-) > > Thanks, > > /dev/mrg > > PS. If the mailing list strips the attachment and you want to see it > (and don't want to run your own like I did above), shoot me an e-mail > directly. > > > On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: >> >> On 02/02/2007, at 12:43 AM, Michael Gentry wrote: >> >> > What would the general consensus be here of using FindBugs >> > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 >> version to >> > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at >> > least on my current source tree). I haven't used this tool much >> yet, >> > but it seems like it could be useful. I also believe it has >> support >> > to run in the background, like from an ant task. This could be >> useful >> > for nightly builds. Or even like a weekly report of some kind. >> >> >> From my experience of it, there are lots of 'bugs' it finds which >> you end up having to ignore. If that was the case, a weekly report >> may not be that helpful since anything useful would be buried in the >> noise. But if the FindBug count count be brought to zero, then a >> weekly script might be more useful. I seem to remember that there are >> lots of ways to configure the rules it runs to quite a fine degree. I >> seem to remember that the style and performance reports it created >> were less useful, but it found some interesting problems in our code >> base. >> >> Ari Maniatis >> >> >> --------------------------> >> ish >> http://www.ish.com.au >> Level 1, 30 Wilson Street Newtown 2042 Australia >> phone 3152033554 fax 3152033554 >> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A >> >> >> >> >> From hdean@example.net Thu Feb 01 17:08:00 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 22230 invoked from network); 1 Feb 2007 17:07:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 17:07:59 -0000 Received: (qmail 78240 invoked by uid 500); 1 Feb 2007 17:08:06 -0000 Delivered-To: hdean@example.net Received: (qmail 78218 invoked by uid 500); 1 Feb 2007 17:08:05 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 78209 invoked by uid 99); 1 Feb 2007 17:08:05 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 09:08:05 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO qb-out-0506.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 09:07:55 -0800 Received: by qb-out-0506.google.com with SMTP id f9so58307qba for <hdean@example.net>; Thu, 01 Feb 2007 09:07:34 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer:sender; b=LlMjHUFrTFFF1O9om5AMxxykEF5nc84N3Hl+FGjq0L4AwaZY0NCedXJRGFP1mOAK95n7b4Fk5zOushIkuQH19js7sp2d9rRyjR/iyKbuuykjgxTWwhG5OlQEl6V/EJQ7DxbYZoNhaD5nDAGE98fHlVa+rFHzxL2yyx038KyPRww= Received: by 83.161.120.155 with SMTP id v1mr4605473pyl.1170349654651; Thu, 01 Feb 2007 09:07:34 -0800 (PST) Received: from ?83.161.120.155? ( [83.161.120.155]) by mx.google.com with ESMTP id y64sm2932993pyg.283.161.120.155.07.33; Thu, 01 Feb 2007 09:07:33 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <hdean@example.net> References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Robert Zeigler <hdean@example.net> Subject: Re: FindBugs Date: Thu, 1 Feb 2007 11:07:13 -0600 To: hdean@example.net X-Mailer: Apple Mail (2.752.3) Sender: robert zeigler <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org Sorry! Missend! Robert On Feb 1, 2007, at 10:57 AM, Robert Zeigler wrote: > Hi, > > I'd be interested in seeing the report. > > Robert > On Feb 1, 2007, at 8:56 AM, Michael Gentry wrote: > >> There are ways to tell the tool to exclude bugs by a filter list. I >> haven't looked into the details of that yet, but that could be an >> option to eliminate things we decide are OK and don't want to appear >> again. >> >> I'm attaching an HTML report I produced with this command-line: >> >> ~/Projects/eclipse/workspace/Cayenne30/framework> >> ~/Desktop/findbugs-1.1.1/bin/findbugs -textui -effort:max - >> onlyAnalyze >> 'org.apache.cayenne.-' -low -html -outputFile modeler-report.html >> cayenne-modeler >> >> It also has a -xdocs option to produce output for Maven. >> Obviously, I >> have more work to do. :-) >> >> Thanks, >> >> /dev/mrg >> >> PS. If the mailing list strips the attachment and you want to see it >> (and don't want to run your own like I did above), shoot me an e-mail >> directly. >> >> >> On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: >>> >>> On 02/02/2007, at 12:43 AM, Michael Gentry wrote: >>> >>> > What would the general consensus be here of using FindBugs >>> > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 >>> version to >>> > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at >>> > least on my current source tree). I haven't used this tool >>> much yet, >>> > but it seems like it could be useful. I also believe it has >>> support >>> > to run in the background, like from an ant task. This could be >>> useful >>> > for nightly builds. Or even like a weekly report of some kind. >>> >>> >>> From my experience of it, there are lots of 'bugs' it finds which >>> you end up having to ignore. If that was the case, a weekly report >>> may not be that helpful since anything useful would be buried in the >>> noise. But if the FindBug count count be brought to zero, then a >>> weekly script might be more useful. I seem to remember that there >>> are >>> lots of ways to configure the rules it runs to quite a fine >>> degree. I >>> seem to remember that the style and performance reports it created >>> were less useful, but it found some interesting problems in our code >>> base. >>> >>> Ari Maniatis >>> >>> >>> --------------------------> >>> ish >>> http://www.ish.com.au >>> Level 1, 30 Wilson Street Newtown 2042 Australia >>> phone 3152033554 fax 3152033554 >>> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A >>> >>> >>> >>> >>> > From hdean@example.net Thu Feb 01 17:15:26 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 24914 invoked from network); 1 Feb 2007 17:15:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 17:15:22 -0000 Received: (qmail 87337 invoked by uid 500); 1 Feb 2007 17:15:23 -0000 Delivered-To: hdean@example.net Received: (qmail 87307 invoked by uid 500); 1 Feb 2007 17:15:22 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 87272 invoked by uid 99); 1 Feb 2007 17:15:22 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 09:15:22 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO an-out-0708.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 09:15:12 -0800 Received: by an-out-0708.google.com with SMTP id c5so328990anc for <hdean@example.net>; Thu, 01 Feb 2007 09:14:51 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ObDswOAl5ylwn+C/Cez5sgaqG++PVbUMvJ/id6UNCs7sJbwiYDofSpDEwsiAY8s5N5A2D2Hgj/8TxbCTeIX9t9jHLqxqtl2vuEpFZl1g6JGA6+7wBTNHePzZ7uecWIr+ykkNOPDTFFS/WGI8WUB23Nos2UCagwwe6tHuMNQymT4= Received: by 83.161.120.155 with SMTP id g1mr161988wad.1170350091345; Thu, 01 Feb 2007 09:14:51 -0800 (PST) Received: by 83.161.120.155 with HTTP; Thu, 1 Feb 2007 09:14:51 -0800 (PST) Message-ID: <hdean@example.net> Date: Thu, 1 Feb 2007 12:14:51 -0500 From: "Mike Kienenberger" <hdean@example.net> To: hdean@example.net Subject: Re: FindBugs In-Reply-To: <hdean@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <hdean@example.net> <hdean@example.net> <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org Michael, Maybe you could post it on your people.apache.org account and give us the link. -Mike On 2/1/07, Michael Gentry <hdean@example.net> wrote: > There are ways to tell the tool to exclude bugs by a filter list. I > haven't looked into the details of that yet, but that could be an > option to eliminate things we decide are OK and don't want to appear > again. > > I'm attaching an HTML report I produced with this command-line: > > ~/Projects/eclipse/workspace/Cayenne30/framework> > ~/Desktop/findbugs-1.1.1/bin/findbugs -textui -effort:max -onlyAnalyze > 'org.apache.cayenne.-' -low -html -outputFile modeler-report.html > cayenne-modeler > > It also has a -xdocs option to produce output for Maven. Obviously, I > have more work to do. :-) > > Thanks, > > /dev/mrg > > PS. If the mailing list strips the attachment and you want to see it > (and don't want to run your own like I did above), shoot me an e-mail > directly. > > > On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: > > > > On 02/02/2007, at 12:43 AM, Michael Gentry wrote: > > > > > What would the general consensus be here of using FindBugs > > > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 version to > > > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at > > > least on my current source tree). I haven't used this tool much yet, > > > but it seems like it could be useful. I also believe it has support > > > to run in the background, like from an ant task. This could be useful > > > for nightly builds. Or even like a weekly report of some kind. > > > > > > From my experience of it, there are lots of 'bugs' it finds which > > you end up having to ignore. If that was the case, a weekly report > > may not be that helpful since anything useful would be buried in the > > noise. But if the FindBug count count be brought to zero, then a > > weekly script might be more useful. I seem to remember that there are > > lots of ways to configure the rules it runs to quite a fine degree. I > > seem to remember that the style and performance reports it created > > were less useful, but it found some interesting problems in our code > > base. > > > > Ari Maniatis > > > > > > --------------------------> > > ish > > http://www.ish.com.au > > Level 1, 30 Wilson Street Newtown 2042 Australia > > phone 3152033554 fax 3152033554 > > GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A > > > > > > > > > > > From hdean@example.net Thu Feb 01 21:36:25 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 46619 invoked from network); 1 Feb 2007 21:36:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Feb 2007 21:36:24 -0000 Received: (qmail 14044 invoked by uid 500); 1 Feb 2007 21:36:30 -0000 Delivered-To: hdean@example.net Received: (qmail 14020 invoked by uid 500); 1 Feb 2007 21:36:30 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 14011 invoked by uid 99); 1 Feb 2007 21:36:30 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 13:36:30 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO nf-out-0910.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 13:36:21 -0800 Received: by nf-out-0910.google.com with SMTP id g2so912668nfe for <hdean@example.net>; Thu, 01 Feb 2007 13:35:59 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=b5uwucOt49PmMgYMSC/6O5wK8xAKJhF6foZjXLedWEaVU1U8gFL62tuMj/uy5uy3xe26v7OhS0/8hCdJps1kaV1ESM82FQorJm9N0VthB1tenxkrpl2BiDFm8OZuaUhrWaQSWSk7EtL0JZYfDy+EH5Ve2LOGMpM1vQWSKy2nNpQ= Received: by 83.161.120.155 with SMTP id m17mr885721bud.1170365759205; Thu, 01 Feb 2007 13:35:59 -0800 (PST) Received: by 83.161.120.155 with HTTP; Thu, 1 Feb 2007 13:35:59 -0800 (PST) Message-ID: <hdean@example.net> Date: Fri, 2 Feb 2007 08:35:59 +1100 From: "Malcolm Edgar" <hdean@example.net> To: hdean@example.net Subject: Re: DbEntity Comments In-Reply-To: <hdean@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org I think the requirements for user properties (CAY-400) and comments/description (CAY-659) are different. While CAY-400 could be used to support comments, and other things like meta-data, I think getting the comments/description done as a modeler enhancement is better done separately. Editing a simple description field will be easier to use than arbitrary lists of user defined properties. The danger with CAY-400 is the use-cases/requirements are pretty vague, making it hard to dermine what's needed. I think this is why this feature has stalled. Adding description fields to the Modeler is a much simpler requirement, which shouldn't be stalled as well. Regarding the design, loading the comments only when using the modeler sounds fine to me. I can't imagine people pasting a Word document into a 30 character length text field, however I could be wrong. regards Malcolm Edgar On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: > > On 01/02/2007, at 9:28 PM, Andrus Adamchik wrote: > > > We are talking about BLOBS of text. Consider people using this for > > javadocs, with each attribute having a 100 char comment field. For > > the model of 50 entities with 20 attributes each, we have (50 + > > 50*20) * 100 = 102K. Not crucial, but still keeping this stuff > > around in runtime seems wrong. Those things add up over time, > > resulting in framework becoming heavier with every new release. > > Not to mention it might contain private notes we may not want in a > public release of a product. I don't want our entity documentation > released to the world. > > How about a velocity(?) script which could strip some parts of the > XML file for deployment? As long as they were easily identifiable, we > could even put a little regex into our main ant build script for > deploying the application. > > On the other hand, a separate config file for comments would make > this easier... > > Ari > > > --------------------------> > ish > http://www.ish.com.au > Level 1, 30 Wilson Street Newtown 2042 Australia > phone 3152033554 fax 3152033554 > GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A > > > > From hdean@example.net Fri Feb 02 00:01:24 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 89949 invoked from network); 2 Feb 2007 00:01:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 2 Feb 2007 00:01:24 -0000 Received: (qmail 88197 invoked by uid 500); 2 Feb 2007 00:01:30 -0000 Delivered-To: hdean@example.net Received: (qmail 88185 invoked by uid 500); 2 Feb 2007 00:01:30 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 88176 invoked by uid 99); 2 Feb 2007 00:01:30 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 16:01:30 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO py-out-1112.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2007 16:01:20 -0800 Received: by py-out-1112.google.com with SMTP id h31so526178pyc for <hdean@example.net>; Thu, 01 Feb 2007 16:01:00 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=e34i4qRsI+x3iAbHge0931aCsp9a+CAgteSik540UcOrYxMKszQHfOcspWYkZSVjPlpZMJYliU7N429BPPJlYPTPSyXTSy70Lk48krcVeLoqtHFBSZtlm9lEAzPX22DspNHhxGCVI/GXbnmqtQc7tmtCyHVkXlDGwE4a0CqPMck= Received: by 83.161.120.155 with SMTP id f9mr5330703pyl.1170374460114; Thu, 01 Feb 2007 16:01:00 -0800 (PST) Received: by 83.161.120.155 with HTTP; Thu, 1 Feb 2007 16:01:00 -0800 (PST) Message-ID: <hdean@example.net> Date: Thu, 1 Feb 2007 19:01:00 -0500 From: "Michael Gentry" <hdean@example.net> To: hdean@example.net Subject: Re: FindBugs In-Reply-To: <hdean@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org OK, here it is: http://people.apache.org/~mgentry/modeler-report.html Thanks, /dev/mrg On 2/1/07, Michael Gentry <hdean@example.net> wrote: > Sadly, SSH is blocked. I can do it tonight when I get home ... > > /dev/mrg > > > On 2/1/07, Andrus Adamchik <hdean@example.net> wrote: > > Michael, > > > > BTW, you can use your apache web space to publish the report (if you > > can ssh from work that is). Just log in to people.apache.org and put > > HTML content under ~/public_html. The URL will be: > > > > http://people.apache.org/~mgentry/whatever > > > > Andrus > > > > > > On Feb 1, 2007, at 4:56 PM, Michael Gentry wrote: > > > > > There are ways to tell the tool to exclude bugs by a filter list. I > > > haven't looked into the details of that yet, but that could be an > > > option to eliminate things we decide are OK and don't want to appear > > > again. > > > > > > I'm attaching an HTML report I produced with this command-line: > > > > > > ~/Projects/eclipse/workspace/Cayenne30/framework> > > > ~/Desktop/findbugs-1.1.1/bin/findbugs -textui -effort:max -onlyAnalyze > > > 'org.apache.cayenne.-' -low -html -outputFile modeler-report.html > > > cayenne-modeler > > > > > > It also has a -xdocs option to produce output for Maven. Obviously, I > > > have more work to do. :-) > > > > > > Thanks, > > > > > > /dev/mrg > > > > > > PS. If the mailing list strips the attachment and you want to see it > > > (and don't want to run your own like I did above), shoot me an e-mail > > > directly. > > > > > > > > > On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: > > >> > > >> On 02/02/2007, at 12:43 AM, Michael Gentry wrote: > > >> > > >> > What would the general consensus be here of using FindBugs > > >> > (http://findbugs.sourceforge.net/)? I just used the 1.1.1 > > >> version to > > >> > analyze Cayenne 3.0 and it is reporting 1720 (potential) bugs (at > > >> > least on my current source tree). I haven't used this tool much > > >> yet, > > >> > but it seems like it could be useful. I also believe it has > > >> support > > >> > to run in the background, like from an ant task. This could be > > >> useful > > >> > for nightly builds. Or even like a weekly report of some kind. > > >> > > >> > > >> From my experience of it, there are lots of 'bugs' it finds which > > >> you end up having to ignore. If that was the case, a weekly report > > >> may not be that helpful since anything useful would be buried in the > > >> noise. But if the FindBug count count be brought to zero, then a > > >> weekly script might be more useful. I seem to remember that there are > > >> lots of ways to configure the rules it runs to quite a fine degree. I > > >> seem to remember that the style and performance reports it created > > >> were less useful, but it found some interesting problems in our code > > >> base. > > >> > > >> Ari Maniatis > > >> > > >> > > >> --------------------------> > > >> ish > > >> http://www.ish.com.au > > >> Level 1, 30 Wilson Street Newtown 2042 Australia > > >> phone 3152033554 fax 3152033554 > > >> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A > > >> > > >> > > >> > > >> > > >> > > > > > From hdean@example.net Fri Feb 02 10:35:41 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 67572 invoked from network); 2 Feb 2007 10:35:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 2 Feb 2007 10:35:41 -0000 Received: (qmail 31044 invoked by uid 500); 2 Feb 2007 10:35:47 -0000 Delivered-To: hdean@example.net Received: (qmail 30947 invoked by uid 500); 2 Feb 2007 10:35:47 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 30938 invoked by uid 99); 2 Feb 2007 10:35:47 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2007 02:35:47 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [83.161.120.155] (HELO byaroza.objectstyle.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 02 Feb 2007 02:35:38 -0800 Received: (qmail 3768 invoked from network); 2 Feb 2007 10:35:16 -0000 Received: from unknown (HELO ?JC?????IPv888a:dbb7:2d49:b3f6:8605:bf4e:caed:e5a4:1?) (83.161.120.155) by localhost with SMTP; 2 Feb 2007 10:35:16 -0000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <hdean@example.net> References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <hdean@example.net> Content-Transfer-Encoding: 7bit From: Andrus Adamchik <hdean@example.net> Subject: Re: DbEntity Comments Date: Fri, 2 Feb 2007 12:35:16 +0200 To: hdean@example.net X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org As I mentioned I don't see a problem with comments being done as a separate feature (CAY-659). I posted a list of similarities between comments and properties in my previous message, but there are differences as well. Anyways, I am +1 on Malcolm's proposal as long as MapLoader can be configured to skip or include hdean@example.net. Should we assign CAY-659 to Malcolm? > The danger with CAY-400 is the use-cases/requirements are pretty > vague, making it hard to dermine what's needed. I think this is why > this feature has stalled. I think this was more of a lack of personal motivation among current committers. I can speak for myself - I think this feature is cool, but I never needed it badly enough. Andrus On Feb 1, 2007, at 11:35 PM, Malcolm Edgar wrote: > I think the requirements for user properties (CAY-400) and > comments/description (CAY-659) are different. > > While CAY-400 could be used to support comments, and other things like > meta-data, I think getting the comments/description done as a modeler > enhancement is better done separately. Editing a simple description > field will be easier to use than arbitrary lists of user defined > properties. > > The danger with CAY-400 is the use-cases/requirements are pretty > vague, making it hard to dermine what's needed. I think this is why > this feature has stalled. > > Adding description fields to the Modeler is a much simpler > requirement, which shouldn't be stalled as well. > > Regarding the design, loading the comments only when using the modeler > sounds fine to me. I can't imagine people pasting a Word document into > a 30 character length text field, however I could be wrong. > > regards Malcolm Edgar > > On 2/1/07, Aristedes Maniatis <hdean@example.net> wrote: >> >> On 01/02/2007, at 9:28 PM, Andrus Adamchik wrote: >> >> > We are talking about BLOBS of text. Consider people using this for >> > javadocs, with each attribute having a 100 char comment field. For >> > the model of 50 entities with 20 attributes each, we have (50 + >> > 50*20) * 100 = 102K. Not crucial, but still keeping this stuff >> > around in runtime seems wrong. Those things add up over time, >> > resulting in framework becoming heavier with every new release. >> >> Not to mention it might contain private notes we may not want in a >> public release of a product. I don't want our entity documentation >> released to the world. >> >> How about a velocity(?) script which could strip some parts of the >> XML file for deployment? As long as they were easily identifiable, we >> could even put a little regex into our main ant build script for >> deploying the application. >> >> On the other hand, a separate config file for comments would make >> this easier... >> >> Ari >> >> >> --------------------------> >> ish >> http://www.ish.com.au >> Level 1, 30 Wilson Street Newtown 2042 Australia >> phone 3152033554 fax 3152033554 >> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A >> >> >> >> > From hdean@example.net Fri Feb 02 11:01:39 2007 Return-Path: <hdean@example.net> Delivered-To: hdean@example.net Received: (qmail 72943 invoked from network); 2 Feb 2007 11:01:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 2 Feb 2007 11:01:38 -0000 Received: (qmail 56992 invoked by uid 500); 2 Feb 2007 11:01:45 -0000 Delivered-To: hdean@example.net Received: (qmail 56894 invoked by uid 500); 2 Feb 2007 11:01:45 -0000 Mailing-List: contact hdean@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:hdean@example.net> List-Unsubscribe: <mailto:hdean@example.net> List-Post: <mailto:hdean@example.net> List-Id: <dev.cayenne.apache.org> Reply-To: hdean@example.net Delivered-To: mailing list hdean@example.net Received: (qmail 56881 invoked by uid 99); 2 Feb 2007 11:01:44 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2007 03:01:44 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of hdean@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO ug-out-1314.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2007 03:01:36 -0800 Received: by ug-out-1314.google.com with SMTP id 78so702720ugn for <hdean@example.net>; Fri, 02 Feb 2007 03:01:15 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DZPsR9CnFwWh5AlQz1CKTY2dgkZg0tv7ldH1xslCb6oDmhrOukGyabcMytaZL0IlkhAQK10DHaSkOAbDaXswJTd8l6Cu3fQXCwRQ6rTafs2wcc/0/lDgHBlByH+AXwzwd0e+kdHG1jbvvzoM+rCCBcethf3dkYu/mdW3+NbNMqM= Received: by 83.161.120.155 with SMTP id q2mr1119864buc.1170414074571; Fri, 02 Feb 2007 03:01:14 -0800 (PST) Received: by 83.161.120.155 with HTTP; Fri, 2 Feb 2007 03:01:14 -0800 (PST) Message-ID: <hdean@example.net> Date: Fri, 2 Feb 2007 22:01:14 +1100 From: "Malcolm Edgar" <hdean@example.net> To: hdean@example.net Subject: Re: DbEntity Comments In-Reply-To: <hdean@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> <hdean@example.net> X-Virus-Checked: Checked by ClamAV on apache.org I suppose I am actuall reitterating what you said earlier. Please assign CAY-659 to me. regards Malcolm Edgar On 2/2/07, Andrus Adamchik <hdean@example.net> wrote: > As I mentioned I don't see a problem with comments being done
{'source': 'Apache Software Foundation Public Mail Archives'}