From bridges-dev-roger49@example.com Mon Jan 01 18:20:50 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 94003 invoked from network); 1 Jan 2007 18:20:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Jan 2007 18:20:49 -0000 Received: (qmail 54884 invoked by uid 500); 1 Jan 2007 18:20:55 -0000 Delivered-To: roger49@example.com Received: (qmail 54858 invoked by uid 500); 1 Jan 2007 18:20:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 54847 invoked by uid 99); 1 Jan 2007 18:20:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jan 2007 10:20:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jan 2007 10:20:47 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id B244C7142D4 for <roger49@example.com>; Mon, 1 Jan 2007 10:20:27 -0800 (PST) Message-ID: <19078110.1167675627727.JavaMail.jira@brutus> Date: Mon, 1 Jan 2007 10:20:27 -0800 (PST) From: "James May (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Updated: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James May updated PB-49: ------------------------ Priority: Major (was: Minor) Issue Type: Bug (was: Improvement) I've updated the severity of this issue because I've received several messages from user's saying that is a critical issue for them. I've also changed the issue type to bug because it is incorrect to assume that only one instance of a portlet will exist at a time. It is perfectly reasonable to assume that a weather portlet, for example, may appear serveral times on a page with each instance displaying weather data for different areas of the globe. Changes to one portlet instance (form bean, render attributes, portlet mode, etc.) should not affect other instances. I have spent a considerable amount of time creating a fix for this: Here is what I've acheived so far: The struts bridge (my local) now - * correctly handles form beans for multiple portlet instances * correctly handles render attributes for multiple instances * remembers the portlet mode of each instance and correctly remembers the last page when switching modes (see PB-38) One outstanding issue that I'm facing is this: When changing from view mode to edit mode, the edit page displays correctly. However after a subsequent render request, the mode icon for that portlet instance changes back to the pencil icon, as if the portlet is in view mode. The edit page still displays and request.getPortletMode().toString() returns "edit". So why is the mode icon and link changing? This has me stumped. Any ideas on this would be appreciated. > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: http://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Tue Jan 02 19:15:51 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 9855 invoked from network); 2 Jan 2007 19:15:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 2 Jan 2007 19:15:50 -0000 Received: (qmail 92470 invoked by uid 500); 2 Jan 2007 19:15:56 -0000 Delivered-To: roger49@example.com Received: (qmail 92441 invoked by uid 500); 2 Jan 2007 19:15:56 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 92425 invoked by uid 99); 2 Jan 2007 19:15:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 11:15:56 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 11:15:49 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 89E757142DF for <roger49@example.com>; Tue, 2 Jan 2007 11:15:27 -0800 (PST) Message-ID: <23416523.1167765327561.JavaMail.jira@brutus> Date: Tue, 2 Jan 2007 11:15:27 -0800 (PST) From: "David Sean Taylor (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Work stopped: (PB-53) The method setDefaultView() sets the PortletSession attribute with a null value. In-Reply-To: <9675975.1166827461020.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/PB-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on PB-53 stopped by David Sean Taylor. > The method setDefaultView() sets the PortletSession attribute with a null value. > -------------------------------------------------------------------------------- > > Key: PB-53 > URL: http://issues.apache.org/jira/browse/PB-53 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > > The method: org.apache.portals.bridges.jsf.FacesPortlet.setDefaultView(FacesContext, String, String) contains an else branch that is entered when the viewRoot value is null (line 589). > This else branch creates a new viewRoot, a new view id, and sets both on the facesContext object. The code then creates a view root key and calls portal session set attribute with this key using the null viewRoot value, instead of the viewRoot object that was just created. The portlet session attribute map will contain a valid viewRoot key, but a null viewRoot value. This appears to be an error, because the viewRoot is always going to be null when this branch of code is entered. > I propose that the method call (on line 594 of FacesPortlet) should look like this: > portletRequest.getPortletSession().setAttribute(createViewRootKey(facesContext, view, viewId), facesContext.getViewRoot() ); > This will store the newly created viewRoot in the portlet session where it can be retrieved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Tue Jan 02 19:15:52 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 9889 invoked from network); 2 Jan 2007 19:15:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 2 Jan 2007 19:15:51 -0000 Received: (qmail 92556 invoked by uid 500); 2 Jan 2007 19:15:57 -0000 Delivered-To: roger49@example.com Received: (qmail 92522 invoked by uid 500); 2 Jan 2007 19:15:57 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 92511 invoked by uid 99); 2 Jan 2007 19:15:57 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 11:15:57 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 11:15:50 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id B0EE17142E4 for <roger49@example.com>; Tue, 2 Jan 2007 11:15:27 -0800 (PST) Message-ID: <10477605.1167765327718.JavaMail.jira@brutus> Date: Tue, 2 Jan 2007 11:15:27 -0800 (PST) From: "David Sean Taylor (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Closed: (PB-53) The method setDefaultView() sets the PortletSession attribute with a null value. In-Reply-To: <9675975.1166827461020.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/PB-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sean Taylor closed PB-53. ------------------------------- Resolution: Fixed fixed > The method setDefaultView() sets the PortletSession attribute with a null value. > -------------------------------------------------------------------------------- > > Key: PB-53 > URL: http://issues.apache.org/jira/browse/PB-53 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > > The method: org.apache.portals.bridges.jsf.FacesPortlet.setDefaultView(FacesContext, String, String) contains an else branch that is entered when the viewRoot value is null (line 589). > This else branch creates a new viewRoot, a new view id, and sets both on the facesContext object. The code then creates a view root key and calls portal session set attribute with this key using the null viewRoot value, instead of the viewRoot object that was just created. The portlet session attribute map will contain a valid viewRoot key, but a null viewRoot value. This appears to be an error, because the viewRoot is always going to be null when this branch of code is entered. > I propose that the method call (on line 594 of FacesPortlet) should look like this: > portletRequest.getPortletSession().setAttribute(createViewRootKey(facesContext, view, viewId), facesContext.getViewRoot() ); > This will store the newly created viewRoot in the portlet session where it can be retrieved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Tue Jan 02 20:56:50 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 54549 invoked from network); 2 Jan 2007 20:56:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 2 Jan 2007 20:56:49 -0000 Received: (qmail 56746 invoked by uid 500); 2 Jan 2007 20:56:56 -0000 Delivered-To: roger49@example.com Received: (qmail 56692 invoked by uid 500); 2 Jan 2007 20:56:56 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 56681 invoked by uid 99); 2 Jan 2007 20:56:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 12:56:56 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jan 2007 12:56:47 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id A35B07142E3 for <roger49@example.com>; Tue, 2 Jan 2007 12:56:27 -0800 (PST) Message-ID: <14110813.1167771387665.JavaMail.jira@brutus> Date: Tue, 2 Jan 2007 12:56:27 -0800 (PST) From: "David Sean Taylor (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-52) JSF portal bridge attempting to encode URL twice fails In-Reply-To: <31926435.1166545941201.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/PB-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461820 ] David Sean Taylor commented on PB-52: ------------------------------------- Just so its clear, could you explain what you mean by an absolute *URL*, and relative *URI* along with an example of each... > JSF portal bridge attempting to encode URL twice fails > ------------------------------------------------------ > > Key: PB-52 > URL: http://issues.apache.org/jira/browse/PB-52 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > > I evaluating the MyFaces portlet bridge with a sample JSF portal app and I ran into a problem. The portlet worked with the Sun portlet bridge, but does not even complete the render phase when I try to use the MyFaces portlet bridge. > The exception I am seeing is: > javax.servlet.ServletException: only absolute URLs or full path URIs are allowed > Caused by: java.lang.IllegalArgumentException: only absolute URLs or full path URIs are allowed > at com.ibm.ws.portletcontainer.core.impl.PortletResponseImpl.encodeURL(PortletResponseImpl.java:143) > at org.apache.portals.bridges.jsf.PortletExternalContextImpl.encodeActionURL(PortletExternalContextImpl.java) > I hooked up a remote debugger to see what was happening. The String URL that is passed into PortletExternalContextImpl is: pa.do?_pa=-1088437171&_rid=-507a2aba:10f977651ed:-7fee&.pa=true > As you can see the URL is already encoded and the encodeActionURL( String ) method attempts to call this.portletResponse.encodeURL(s). The PortletResponse tries to encode the string URL again, leading to the Exception. > I tracked down the difference in Sun's version of ExternalContextImpl. I found a Sun portlet bridge bug # 6243708 that addresses the same problem of double encoding the value from the portlet environment. The Sun portlet bridge fixed this bug in their com.sun.faces.portlet.ExternalContextImpl.encodeActionURL( String ) method to return the string url instead of attempting to encode it again. > I suggest that the PortletExternalContextImpl will always get portal encoded URL strings, and should return the string passed to it to avoid this Exceptional case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Wed Jan 03 21:34:50 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 55842 invoked from network); 3 Jan 2007 21:34:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2007 21:34:49 -0000 Received: (qmail 81622 invoked by uid 500); 3 Jan 2007 21:34:56 -0000 Delivered-To: roger49@example.com Received: (qmail 81593 invoked by uid 500); 3 Jan 2007 21:34:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 81577 invoked by uid 99); 3 Jan 2007 21:34:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 13:34:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 13:34:48 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id BE690714323 for <roger49@example.com>; Wed, 3 Jan 2007 13:34:27 -0800 (PST) Message-ID: <8755830.1167860067776.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 13:34:27 -0800 (PST) From: "Matthew Bruzek (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-52) JSF portal bridge attempting to encode URL twice fails In-Reply-To: <31926435.1166545941201.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462058 ] Matthew Bruzek commented on PB-52: ---------------------------------- Absolute URLs will start with "http://" or "https://" because they do not depend upon any context path. For example: "http://www.google.com" Relative URI is a string that starts with a slash ("/") character the implementation can then prepend the full path to the string. For example: "/intl/en_ALL/images/logo.gif" the context path could be prepended to create" http://www.google.com/intl/en_ALL/images/logo.gif" The reason I get this exception is because the string from my environment was an encoded URL and did not match either of these conditions. The implementation did not know how to handle the encoded string "pa.do?_pa=-1088437171&_rid=-507a2aba:10f977651ed:-7fee&.pa=true". The code in PortletExternalContextImpl.encodeResourceURL(String s) does some similar checking for "http" or the slash ("/") but it prepend the slash character to strings that fail this check (which I believe to be in error). These methods should NOT prepend any characters to the string unless it is specifically called out in the specifications. I would suggest changing encodeResourceURL() and encodeActionURL() to do the following for both methods: If the string parameter starts with "http://" or "https://" or "/" then call the implementation's encodeURL() method to properly encode the strings that the implementation can handle. Otherwise return the original string as it does not need encoding, and would generate an exception if encoding was attempted. I think this is a better solution than always returning the original string. This solution will prevent the exception from occuring in my environment and keep the methods working as designed for other possible situations. > JSF portal bridge attempting to encode URL twice fails > ------------------------------------------------------ > > Key: PB-52 > URL: https://issues.apache.org/jira/browse/PB-52 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > > I evaluating the MyFaces portlet bridge with a sample JSF portal app and I ran into a problem. The portlet worked with the Sun portlet bridge, but does not even complete the render phase when I try to use the MyFaces portlet bridge. > The exception I am seeing is: > javax.servlet.ServletException: only absolute URLs or full path URIs are allowed > Caused by: java.lang.IllegalArgumentException: only absolute URLs or full path URIs are allowed > at com.ibm.ws.portletcontainer.core.impl.PortletResponseImpl.encodeURL(PortletResponseImpl.java:143) > at org.apache.portals.bridges.jsf.PortletExternalContextImpl.encodeActionURL(PortletExternalContextImpl.java) > I hooked up a remote debugger to see what was happening. The String URL that is passed into PortletExternalContextImpl is: pa.do?_pa=-1088437171&_rid=-507a2aba:10f977651ed:-7fee&.pa=true > As you can see the URL is already encoded and the encodeActionURL( String ) method attempts to call this.portletResponse.encodeURL(s). The PortletResponse tries to encode the string URL again, leading to the Exception. > I tracked down the difference in Sun's version of ExternalContextImpl. I found a Sun portlet bridge bug # 6243708 that addresses the same problem of double encoding the value from the portlet environment. The Sun portlet bridge fixed this bug in their com.sun.faces.portlet.ExternalContextImpl.encodeActionURL( String ) method to return the string url instead of attempting to encode it again. > I suggest that the PortletExternalContextImpl will always get portal encoded URL strings, and should return the string passed to it to avoid this Exceptional case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Wed Jan 03 23:00:54 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 83055 invoked from network); 3 Jan 2007 23:00:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2007 23:00:52 -0000 Received: (qmail 10918 invoked by uid 500); 3 Jan 2007 23:00:57 -0000 Delivered-To: roger49@example.com Received: (qmail 10584 invoked by uid 500); 3 Jan 2007 23:00:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 10552 invoked by uid 99); 3 Jan 2007 23:00:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:00:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:00:48 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id E39FB714323 for <roger49@example.com>; Wed, 3 Jan 2007 15:00:27 -0800 (PST) Message-ID: <12278434.1167865227929.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 15:00:27 -0800 (PST) From: "Anonymous (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Updated: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attachment: patch.zip > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: https://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > Attachments: patch.zip > > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Wed Jan 03 23:03:50 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 83707 invoked from network); 3 Jan 2007 23:03:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2007 23:03:49 -0000 Received: (qmail 12873 invoked by uid 500); 3 Jan 2007 23:03:56 -0000 Delivered-To: roger49@example.com Received: (qmail 12811 invoked by uid 500); 3 Jan 2007 23:03:56 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 12800 invoked by uid 99); 3 Jan 2007 23:03:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:03:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:03:48 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 3F9C8714322 for <roger49@example.com>; Wed, 3 Jan 2007 15:03:28 -0800 (PST) Message-ID: <10431374.1167865408257.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 15:03:28 -0800 (PST) From: "Matthew Bruzek (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-54) PortletViewHandlerImpl.getResourceURL() always prepends the context path. In-Reply-To: <18889369.1167343341261.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462076 ] Matthew Bruzek commented on PB-54: ---------------------------------- For example of the problem one of the resource string is "/Graph/theme/graphStyle.css" and the result of getRequestContextPath() is "/Graph" so the resulting string that is returned is "/Graph/Graph/theme/graphStyle.css" and that resource is not found. The method getResourceURL() should not always prepend the context path in this case. > PortletViewHandlerImpl.getResourceURL() always prepends the context path. > ------------------------------------------------------------------------- > > Key: PB-54 > URL: https://issues.apache.org/jira/browse/PB-54 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > > When running an application on the MyFaces JSF portal bridge, I noticed the context path is always appended to the URI path in PortletViewHandlerImpl.getResourceURL() even if the path parameter already contains the context path. > My JSF portal application loads image resources and css files and when using the Sun portal bridge all the resources resolved. When attempt to use the MyFaces JSF portal bridge, the application failed to find the resources citing a java.io.FileNotFoundException for the resources. The resources that already contained the context path are prepened with another context path. The getResourceURL() method of PortletViewHandlerImpl ALWAYS prepends the context path to the path parameter without checking if it is already there. > I believe changing the getResourceURL() code to delegate this call to the handler.getResourceURL() method of (javax.faces.application.ViewHandler) would resolve the problem. I made this small change in my sandbox. The URLs with the context path did not get prepended and the application found all resources. > Is there a reason the PortletViewHandlerImpl does not delegate the getResourceURL() method that I am missing? If there is not a compelling reason not to delegate the call to the included ViewHandler, then perhaps we should delegate the call to javax.faces.application.ViewHandler. If there is a compelling reason perhaps we should add a check if the context path already exists in the path parameter. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Wed Jan 03 23:10:04 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 85536 invoked from network); 3 Jan 2007 23:10:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2007 23:10:04 -0000 Received: (qmail 20162 invoked by uid 500); 3 Jan 2007 23:10:10 -0000 Delivered-To: roger49@example.com Received: (qmail 20139 invoked by uid 500); 3 Jan 2007 23:10:10 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 20127 invoked by uid 99); 3 Jan 2007 23:10:10 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:10:10 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:09:29 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id A8CB8714323 for <roger49@example.com>; Wed, 3 Jan 2007 15:08:30 -0800 (PST) Message-ID: <5468350.1167865710688.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 15:08:30 -0800 (PST) From: "James May (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462078 ] James May commented on PB-49: ----------------------------- I've uploaded a patch to fix this issue as well as PB-38. The problem I was seeing with the edit mode icon seems to be related to a specific jetspeed build or installation. The same code works as expected in one portal installation but not in another. Someone please let me know if you encounter this problem when you get a chance to test this fix. You will notice that there is a new (optional) PortletActionMapping. I will post more about this soon. James > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: https://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > Attachments: patch.zip > > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Wed Jan 03 23:18:40 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 88068 invoked from network); 3 Jan 2007 23:18:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2007 23:18:39 -0000 Received: (qmail 33969 invoked by uid 500); 3 Jan 2007 23:18:46 -0000 Delivered-To: roger49@example.com Received: (qmail 33913 invoked by uid 500); 3 Jan 2007 23:18:46 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 33902 invoked by uid 99); 3 Jan 2007 23:18:46 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:18:46 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:17:50 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id BB99E71432B for <roger49@example.com>; Wed, 3 Jan 2007 15:17:27 -0800 (PST) Message-ID: <20412109.1167866247765.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 15:17:27 -0800 (PST) From: "Ate Douma (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Assigned: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ate Douma reassigned PB-49: --------------------------- Assignee: Ate Douma > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: https://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > Assigned To: Ate Douma > Attachments: patch.zip > > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Wed Jan 03 23:19:56 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 88249 invoked from network); 3 Jan 2007 23:19:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2007 23:19:55 -0000 Received: (qmail 35491 invoked by uid 500); 3 Jan 2007 23:20:02 -0000 Delivered-To: roger49@example.com Received: (qmail 35428 invoked by uid 500); 3 Jan 2007 23:20:02 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 35412 invoked by uid 99); 3 Jan 2007 23:20:02 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:20:02 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 15:19:47 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id C6DCB71432D for <roger49@example.com>; Wed, 3 Jan 2007 15:19:27 -0800 (PST) Message-ID: <16379421.1167866367811.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 15:19:27 -0800 (PST) From: "Ate Douma (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462083 ] Ate Douma commented on PB-49: ----------------------------- James, Thanks very much for the patch. I'll try to look into it this weekend. Ate > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: https://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > Assigned To: Ate Douma > Attachments: patch.zip > > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Thu Jan 04 22:46:51 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 81776 invoked from network); 4 Jan 2007 22:46:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Jan 2007 22:46:49 -0000 Received: (qmail 36838 invoked by uid 500); 4 Jan 2007 22:46:55 -0000 Delivered-To: roger49@example.com Received: (qmail 36795 invoked by uid 500); 4 Jan 2007 22:46:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 36749 invoked by uid 99); 4 Jan 2007 22:46:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2007 14:46:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2007 14:46:48 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id BE126714311 for <roger49@example.com>; Thu, 4 Jan 2007 14:46:27 -0800 (PST) Message-ID: <28225468.1167950787775.JavaMail.jira@brutus> Date: Thu, 4 Jan 2007 14:46:27 -0800 (PST) From: "James May (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Updated: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James May updated PB-49: ------------------------ Attachment: patch-2007-01-04.zip > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: https://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > Assigned To: Ate Douma > Attachments: patch-2007-01-04.zip, patch.zip > > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Thu Jan 04 22:48:51 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 82311 invoked from network); 4 Jan 2007 22:48:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Jan 2007 22:48:50 -0000 Received: (qmail 39881 invoked by uid 500); 4 Jan 2007 22:48:55 -0000 Delivered-To: roger49@example.com Received: (qmail 39843 invoked by uid 500); 4 Jan 2007 22:48:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 39795 invoked by uid 99); 4 Jan 2007 22:48:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2007 14:48:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2007 14:48:48 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id +1-623-717-1836 for <roger49@example.com>; Thu, 4 Jan 2007 14:48:28 -0800 (PST) Message-ID: <5658592.1167950908087.JavaMail.jira@brutus> Date: Thu, 4 Jan 2007 14:48:28 -0800 (PST) From: "James May (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-49) Multiple instances of a struts portlet should be able to coexist on a single page. In-Reply-To: <23040065.1159205151986.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462351 ] James May commented on PB-49: ----------------------------- Hi Ate. I've uploaded a 'cleaner' version of the patch (patch-2007-01-04.zip). Please use the new patch files when working on this. Also the new zip file contains a document describing the changes in the patch. Thanx James > Multiple instances of a struts portlet should be able to coexist on a single page. > ---------------------------------------------------------------------------------- > > Key: PB-49 > URL: https://issues.apache.org/jira/browse/PB-49 > Project: Portals Bridges > Issue Type: Bug > Components: struts > Affects Versions: 1.0 > Environment: Any. > Reporter: James May > Assigned To: Ate Douma > Attachments: patch-2007-01-04.zip, patch.zip > > > When including multiple instances of a struts portlet on a page, form data for the portlet instances gets clobbered because there is a single form bean that is shared by all instances. Each portlet instance should be able to maintain its state independently of other instances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Fri Jan 05 16:44:49 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 48282 invoked from network); 5 Jan 2007 16:44:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2007 16:44:49 -0000 Received: (qmail 89225 invoked by uid 500); 5 Jan 2007 16:44:55 -0000 Delivered-To: roger49@example.com Received: (qmail 89204 invoked by uid 500); 5 Jan 2007 16:44:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 89192 invoked by uid 99); 5 Jan 2007 16:44:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 08:44:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 08:44:48 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id B921A714315 for <roger49@example.com>; Fri, 5 Jan 2007 08:44:27 -0800 (PST) Message-ID: <4928853.1168015467754.JavaMail.jira@brutus> Date: Fri, 5 Jan 2007 08:44:27 -0800 (PST) From: "Matthew Bruzek (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-54) PortletViewHandlerImpl.getResourceURL() always prepends the context path. In-Reply-To: <18889369.1167343341261.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462526 ] Matthew Bruzek commented on PB-54: ---------------------------------- I have tried the code in the SVN trunk for this fix and it works for my environment. Thanks. > PortletViewHandlerImpl.getResourceURL() always prepends the context path. > ------------------------------------------------------------------------- > > Key: PB-54 > URL: https://issues.apache.org/jira/browse/PB-54 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > > When running an application on the MyFaces JSF portal bridge, I noticed the context path is always appended to the URI path in PortletViewHandlerImpl.getResourceURL() even if the path parameter already contains the context path. > My JSF portal application loads image resources and css files and when using the Sun portal bridge all the resources resolved. When attempt to use the MyFaces JSF portal bridge, the application failed to find the resources citing a java.io.FileNotFoundException for the resources. The resources that already contained the context path are prepened with another context path. The getResourceURL() method of PortletViewHandlerImpl ALWAYS prepends the context path to the path parameter without checking if it is already there. > I believe changing the getResourceURL() code to delegate this call to the handler.getResourceURL() method of (javax.faces.application.ViewHandler) would resolve the problem. I made this small change in my sandbox. The URLs with the context path did not get prepended and the application found all resources. > Is there a reason the PortletViewHandlerImpl does not delegate the getResourceURL() method that I am missing? If there is not a compelling reason not to delegate the call to the included ViewHandler, then perhaps we should delegate the call to javax.faces.application.ViewHandler. If there is a compelling reason perhaps we should add a check if the context path already exists in the path parameter. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Fri Jan 05 16:50:00 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 49870 invoked from network); 5 Jan 2007 16:49:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2007 16:49:52 -0000 Received: (qmail 98125 invoked by uid 500); 5 Jan 2007 16:49:55 -0000 Delivered-To: roger49@example.com Received: (qmail 98093 invoked by uid 500); 5 Jan 2007 16:49:55 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 98007 invoked by uid 99); 5 Jan 2007 16:49:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 08:49:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 08:49:47 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id CB654714315 for <roger49@example.com>; Fri, 5 Jan 2007 08:49:27 -0800 (PST) Message-ID: <11202608.1168015767829.JavaMail.jira@brutus> Date: Fri, 5 Jan 2007 08:49:27 -0800 (PST) From: "Matthew Bruzek (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Commented: (PB-52) JSF portal bridge attempting to encode URL twice fails In-Reply-To: <31926435.1166545941201.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462528 ] Matthew Bruzek commented on PB-52: ---------------------------------- I have tried the code changed for this bug and it works in my environment. Aside from the redundant startsWith( "http" ) I think that is how the code should work. Thanks. > JSF portal bridge attempting to encode URL twice fails > ------------------------------------------------------ > > Key: PB-52 > URL: https://issues.apache.org/jira/browse/PB-52 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > > I evaluating the MyFaces portlet bridge with a sample JSF portal app and I ran into a problem. The portlet worked with the Sun portlet bridge, but does not even complete the render phase when I try to use the MyFaces portlet bridge. > The exception I am seeing is: > javax.servlet.ServletException: only absolute URLs or full path URIs are allowed > Caused by: java.lang.IllegalArgumentException: only absolute URLs or full path URIs are allowed > at com.ibm.ws.portletcontainer.core.impl.PortletResponseImpl.encodeURL(PortletResponseImpl.java:143) > at org.apache.portals.bridges.jsf.PortletExternalContextImpl.encodeActionURL(PortletExternalContextImpl.java) > I hooked up a remote debugger to see what was happening. The String URL that is passed into PortletExternalContextImpl is: pa.do?_pa=-1088437171&_rid=-507a2aba:10f977651ed:-7fee&.pa=true > As you can see the URL is already encoded and the encodeActionURL( String ) method attempts to call this.portletResponse.encodeURL(s). The PortletResponse tries to encode the string URL again, leading to the Exception. > I tracked down the difference in Sun's version of ExternalContextImpl. I found a Sun portlet bridge bug # 6243708 that addresses the same problem of double encoding the value from the portlet environment. The Sun portlet bridge fixed this bug in their com.sun.faces.portlet.ExternalContextImpl.encodeActionURL( String ) method to return the string url instead of attempting to encode it again. > I suggest that the PortletExternalContextImpl will always get portal encoded URL strings, and should return the string passed to it to avoid this Exceptional case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Fri Jan 05 18:29:31 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 77621 invoked from network); 5 Jan 2007 18:29:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2007 18:29:31 -0000 Received: (qmail 80813 invoked by uid 500); 5 Jan 2007 18:29:36 -0000 Delivered-To: roger49@example.com Received: (qmail 80741 invoked by uid 500); 5 Jan 2007 18:29:35 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 80591 invoked by uid 99); 5 Jan 2007 18:29:25 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 10:29:24 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id E22EE714317 for <roger49@example.com>; Fri, 5 Jan 2007 10:28:27 -0800 (PST) Message-ID: <14960216.1168021707922.JavaMail.jira@brutus> Date: Fri, 5 Jan 2007 10:28:27 -0800 (PST) From: "David Sean Taylor (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Resolved: (PB-52) JSF portal bridge attempting to encode URL twice fails In-Reply-To: <31926435.1166545941201.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sean Taylor resolved PB-52. --------------------------------- Resolution: Fixed patch applied and teste by reported > JSF portal bridge attempting to encode URL twice fails > ------------------------------------------------------ > > Key: PB-52 > URL: https://issues.apache.org/jira/browse/PB-52 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > > I evaluating the MyFaces portlet bridge with a sample JSF portal app and I ran into a problem. The portlet worked with the Sun portlet bridge, but does not even complete the render phase when I try to use the MyFaces portlet bridge. > The exception I am seeing is: > javax.servlet.ServletException: only absolute URLs or full path URIs are allowed > Caused by: java.lang.IllegalArgumentException: only absolute URLs or full path URIs are allowed > at com.ibm.ws.portletcontainer.core.impl.PortletResponseImpl.encodeURL(PortletResponseImpl.java:143) > at org.apache.portals.bridges.jsf.PortletExternalContextImpl.encodeActionURL(PortletExternalContextImpl.java) > I hooked up a remote debugger to see what was happening. The String URL that is passed into PortletExternalContextImpl is: pa.do?_pa=-1088437171&_rid=-507a2aba:10f977651ed:-7fee&.pa=true > As you can see the URL is already encoded and the encodeActionURL( String ) method attempts to call this.portletResponse.encodeURL(s). The PortletResponse tries to encode the string URL again, leading to the Exception. > I tracked down the difference in Sun's version of ExternalContextImpl. I found a Sun portlet bridge bug # 6243708 that addresses the same problem of double encoding the value from the portlet environment. The Sun portlet bridge fixed this bug in their com.sun.faces.portlet.ExternalContextImpl.encodeActionURL( String ) method to return the string url instead of attempting to encode it again. > I suggest that the PortletExternalContextImpl will always get portal encoded URL strings, and should return the string passed to it to avoid this Exceptional case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Fri Jan 05 18:31:29 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 78679 invoked from network); 5 Jan 2007 18:31:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2007 18:31:27 -0000 Received: (qmail 87064 invoked by uid 500); 5 Jan 2007 18:31:34 -0000 Delivered-To: roger49@example.com Received: (qmail 87039 invoked by uid 500); 5 Jan 2007 18:31:34 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 87028 invoked by uid 99); 5 Jan 2007 18:31:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 10:31:34 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 10:30:56 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id C8B5D714311 for <roger49@example.com>; Fri, 5 Jan 2007 10:30:27 -0800 (PST) Message-ID: <4319082.1168021827818.JavaMail.jira@brutus> Date: Fri, 5 Jan 2007 10:30:27 -0800 (PST) From: "David Sean Taylor (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Assigned: (PB-54) PortletViewHandlerImpl.getResourceURL() always prepends the context path. In-Reply-To: <18889369.1167343341261.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PB-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sean Taylor reassigned PB-54: ----------------------------------- Assignee: David Sean Taylor > PortletViewHandlerImpl.getResourceURL() always prepends the context path. > ------------------------------------------------------------------------- > > Key: PB-54 > URL: https://issues.apache.org/jira/browse/PB-54 > Project: Portals Bridges > Issue Type: Bug > Components: jsf > Affects Versions: 1.0 > Environment: Sun JSF Reference Implementation version 1.2 (jsf-impl.jar) > Websphere portlet container version 6.1.0 > Apache MyFaces JSF portal bridge version 1.0 (portals-bridges-jsf-1.0.jar) > Reporter: Matthew Bruzek > Assigned To: David Sean Taylor > Fix For: 1.0.1 > > > When running an application on the MyFaces JSF portal bridge, I noticed the context path is always appended to the URI path in PortletViewHandlerImpl.getResourceURL() even if the path parameter already contains the context path. > My JSF portal application loads image resources and css files and when using the Sun portal bridge all the resources resolved. When attempt to use the MyFaces JSF portal bridge, the application failed to find the resources citing a java.io.FileNotFoundException for the resources. The resources that already contained the context path are prepened with another context path. The getResourceURL() method of PortletViewHandlerImpl ALWAYS prepends the context path to the path parameter without checking if it is already there. > I believe changing the getResourceURL() code to delegate this call to the handler.getResourceURL() method of (javax.faces.application.ViewHandler) would resolve the problem. I made this small change in my sandbox. The URLs with the context path did not get prepended and the application found all resources. > Is there a reason the PortletViewHandlerImpl does not delegate the getResourceURL() method that I am missing? If there is not a compelling reason not to delegate the call to the included ViewHandler, then perhaps we should delegate the call to javax.faces.application.ViewHandler. If there is a compelling reason perhaps we should add a check if the context path already exists in the path parameter. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: roger49@example.com For additional commands, e-mail: roger49@example.com From bridges-dev-roger49@example.com Fri Jan 05 18:31:30 2007 Return-Path: <bridges-dev-roger49@example.com> Delivered-To: roger49@example.com Received: (qmail 78708 invoked from network); 5 Jan 2007 18:31:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2007 18:31:28 -0000 Received: (qmail 87168 invoked by uid 500); 5 Jan 2007 18:31:34 -0000 Delivered-To: roger49@example.com Received: (qmail 87140 invoked by uid 500); 5 Jan 2007 18:31:34 -0000 Mailing-List: contact roger49@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:roger49@example.com> List-Unsubscribe: <mailto:roger49@example.com> List-Post: <mailto:roger49@example.com> List-Id: <bridges-dev.portals.apache.org> Reply-To: roger49@example.com Delivered-To: mailing list roger49@example.com Received: (qmail 87122 invoked by uid 99); 5 Jan 2007 18:31:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 10:31:34 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 10:30:56 -0800 Received: from brutus (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 011B3714317 for <roger49@example.com>; Fri, 5 Jan 2007 10:30:28 -0800 (PST) Message-ID: <13882963.1168021828000.JavaMail.jira@brutus> Date: Fri, 5 Jan 2007 10:30:27 -0800 (PST) From: "David Sean Taylor (JIRA)" <roger49@example.com> To: roger49@example.com Subject: [jira] Resolved: (PB-54) PortletViewHandlerImpl.getResourceURL() always prepends the context path. In-Reply-To: <18889369.1167343341261.JavaMail.jira@brutus> MIME-Version:
{'source': 'Apache Software Foundation Public Mail Archives'}