From bcel-devvshelton@example.com Wed Aug 03 07:08:28 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 7564 invoked from network); 3 Aug 2005 07:08:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Aug 2005 07:08:28 -0000 Received: (qmail 25792 invoked by uid 500); 3 Aug 2005 07:08:27 -0000 Delivered-To: vshelton@example.com Received: (qmail 25669 invoked by uid 500); 3 Aug 2005 07:08:26 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 25642 invoked by uid 99); 3 Aug 2005 07:08:26 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2005 00:08:18 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 2C884E0; Wed, 3 Aug 2005 09:08:14 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 35991] New: - Unable to generate method that returns an array of integers X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Wed, 3 Aug 2005 09:08:14 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35991>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35991 Summary: Unable to generate method that returns an array of integers Product: BCEL Version: 5.1 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Main AssignedTo: vshelton@example.com ReportedBy: vshelton@example.com I'm trying to generate the following code use BCEL: package bci; public class Test { public int[] getArray() { return new int[1]; } public static void main(String[] args) { } } I use BCELIfier to generate the code that creates Test. The snippet that creates getArray is private void createMethod_2() { InstructionList il = new InstructionList(); MethodGen method = new MethodGen(ACC_PUBLIC, new ArrayType(T_INT, 1), Type.NO_ARGS, new String[] { }, "getArray", "bci.Test", il, _cp); InstructionHandle ih_0 = il.append(new PUSH(_cp, 1)); il.append(_factory.createNewArray(new ArrayType(T_INT, 1), (short) 1)); InstructionHandle ih_3 = il.append(_factory.createReturn(Type.OBJECT)); method.setMaxStack(); method.setMaxLocals(); _cg.addMethod(method.getMethod()); il.dispose(); } I run TestCreator (generated by BCELIfier) and execute Test, which triggers the following error: Exception in thread "main" java.lang.VerifyError: (class: bci/Test, method: getArray signature: ()[I) Wrong return type in function If I return null rather than the array, everything is perfectly allright. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Wed Aug 03 07:35:40 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 20064 invoked from network); 3 Aug 2005 07:35:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Aug 2005 07:35:40 -0000 Received: (qmail 47435 invoked by uid 500); 3 Aug 2005 07:35:40 -0000 Delivered-To: vshelton@example.com Received: (qmail 47397 invoked by uid 500); 3 Aug 2005 07:35:39 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 47383 invoked by uid 99); 3 Aug 2005 07:35:38 -0000 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=NO_REAL_NAME,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2005 00:35:30 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 4EB58E0; Wed, 3 Aug 2005 09:35:27 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 35991] - Unable to generate method that returns an array of integers X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Wed, 3 Aug 2005 09:35:27 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35991>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35991 ------- Additional Comments From vshelton@example.com 2005-08-03 09:35 ------- I figured this is actually a bug in BCELIfier. Rather than il.append(_factory.createNewArray(new ArrayType(Type.INT, 1), (short) 1)); it should say il.append(_factory.createNewArray(Type.INT, (short) 1)); -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Wed Aug 03 10:31:01 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 77991 invoked from network); 3 Aug 2005 10:31:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Aug 2005 10:31:01 -0000 Received: (qmail 48368 invoked by uid 500); 3 Aug 2005 10:31:00 -0000 Delivered-To: vshelton@example.com Received: (qmail 48349 invoked by uid 500); 3 Aug 2005 10:30:59 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 48334 invoked by uid 99); 3 Aug 2005 10:30:59 -0000 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=NO_REAL_NAME,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2005 03:30:51 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 37DD5E0; Wed, 3 Aug 2005 12:30:48 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 35991] - Unable to generate method that returns an array of integers X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Wed, 3 Aug 2005 12:30:48 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35991>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35991 ------- Additional Comments From vshelton@example.com 2005-08-03 12:30 ------- agreed... working on it. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 04 03:57:54 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 7416 invoked from network); 4 Aug 2005 03:57:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Aug 2005 03:57:54 -0000 Received: (qmail 75899 invoked by uid 500); 4 Aug 2005 03:57:54 -0000 Delivered-To: vshelton@example.com Received: (qmail 75872 invoked by uid 500); 4 Aug 2005 03:57:53 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 75859 invoked by uid 500); 4 Aug 2005 03:57:53 -0000 Received: (qmail 75856 invoked by uid 99); 4 Aug 2005 03:57:53 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 Aug 2005 20:57:42 -0700 Received: (qmail 7351 invoked by uid 65534); 4 Aug 2005 03:57:39 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r227300 - /jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java Date: Thu, 04 Aug 2005 03:57:39 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Wed Aug 3 20:57:27 2005 New Revision: 227300 URL: http://svn.apache.org/viewcvs?rev=227300&view=rev Log: Bug 35991: When generating ANEWARRAY statements, pass the basic type to the createNewArray call, not the Array type itself. Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java?rev=227300&r1=227299&r2=227300&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java Wed Aug 3 20:57:27 2005 @@ -5,10 +5,12 @@ import java.util.HashMap; import java.util.Iterator; import java.util.Map; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.Utility; import org.apache.bcel.generic.AllocationInstruction; import org.apache.bcel.generic.ArrayInstruction; +import org.apache.bcel.generic.ArrayType; import org.apache.bcel.generic.BranchHandle; import org.apache.bcel.generic.BranchInstruction; import org.apache.bcel.generic.CHECKCAST; @@ -177,8 +179,10 @@ case Constants.ANEWARRAY: case Constants.NEWARRAY: + if (type instanceof ArrayType) + type = ((ArrayType)type).getBasicType(); _out.println("il.append(_factory.createNewArray(" + - BCELifier.printType(type) + ", (short) " + dim + "));"); + BCELifier.printType(type) + ", (short) " + dim + "));"); break; default: --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 04 03:57:58 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 7445 invoked from network); 4 Aug 2005 03:57:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Aug 2005 03:57:58 -0000 Received: (qmail 76034 invoked by uid 500); 4 Aug 2005 03:57:57 -0000 Delivered-To: vshelton@example.com Received: (qmail 76015 invoked by uid 500); 4 Aug 2005 03:57:57 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 76001 invoked by uid 99); 4 Aug 2005 03:57:57 -0000 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=NO_REAL_NAME,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2005 20:57:49 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 93E29E3; Thu, 4 Aug 2005 05:57:46 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 35991] - Unable to generate method that returns an array of integers X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Thu, 4 Aug 2005 05:57:46 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35991>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=35991 vshelton@example.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From vshelton@example.com 2005-08-04 05:57 ------- fix applied to svn, thanks for the report. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Tue Aug 09 03:31:24 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 32282 invoked from network); 9 Aug 2005 03:31:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 9 Aug 2005 03:31:23 -0000 Received: (qmail 88043 invoked by uid 500); 9 Aug 2005 03:31:23 -0000 Delivered-To: vshelton@example.com Received: (qmail 87997 invoked by uid 500); 9 Aug 2005 03:31:22 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 87984 invoked by uid 500); 9 Aug 2005 03:31:22 -0000 Received: (qmail 87980 invoked by uid 99); 9 Aug 2005 03:31:22 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Aug 2005 20:31:21 -0700 Received: (qmail 32260 invoked by uid 65534); 9 Aug 2005 03:31:21 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r230959 - in /jakarta/bcel/trunk/src/java/org/apache/bcel: classfile/ generic/ util/ verifier/statics/ Date: Tue, 09 Aug 2005 03:31:12 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Mon Aug 8 20:30:38 2005 New Revision: 230959 URL: http://svn.apache.org/viewcvs?rev=230959&view=rev Log: use interface references, where possible Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/Utility.java jakarta/bcel/trunk/src/java/org/apache/bcel/generic/ClassGen.java jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGen.java jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGenOrMethodGen.java jakarta/bcel/trunk/src/java/org/apache/bcel/generic/InstructionList.java jakarta/bcel/trunk/src/java/org/apache/bcel/generic/MethodGen.java jakarta/bcel/trunk/src/java/org/apache/bcel/generic/Type.java jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassVector.java jakarta/bcel/trunk/src/java/org/apache/bcel/util/InstructionFinder.java jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/statics/IntList.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/Utility.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/Utility.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/Utility.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/Utility.java Mon Aug 8 20:30:38 2005 @@ -29,8 +29,10 @@ import java.io.Reader; import java.io.Writer; import java.util.ArrayList; +import java.util.List; import java.util.zip.GZIPInputStream; import java.util.zip.GZIPOutputStream; + import org.apache.bcel.Constants; import org.apache.bcel.util.ByteSequence; @@ -559,9 +561,8 @@ boolean chopit) throws ClassFormatException { - ArrayList vec = new ArrayList(); + List vec = new ArrayList(); int index; - String[] types; try { // Read all declarations between for `(' and `)' if(signature.charAt(0) != '(') Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/ClassGen.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/ClassGen.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/ClassGen.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/ClassGen.java Mon Aug 8 20:30:38 2005 @@ -19,6 +19,8 @@ import java.util.ArrayList; import java.util.Iterator; +import java.util.List; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.AccessFlags; import org.apache.bcel.classfile.Attribute; @@ -47,10 +49,10 @@ private ConstantPoolGen cp; // Template for building up constant pool // ArrayLists instead of arrays to gather fields, methods, etc. - private ArrayList field_vec = new ArrayList(); - private ArrayList method_vec = new ArrayList(); - private ArrayList attribute_vec = new ArrayList(); - private ArrayList interface_vec = new ArrayList(); + private List field_vec = new ArrayList(); + private List method_vec = new ArrayList(); + private List attribute_vec = new ArrayList(); + private List interface_vec = new ArrayList(); private static BCELComparator _cmp = new BCELComparator() { public boolean equals(Object o1, Object o2) { Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGen.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGen.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGen.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGen.java Mon Aug 8 20:30:38 2005 @@ -19,6 +19,8 @@ import java.util.ArrayList; import java.util.Iterator; +import java.util.List; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.Attribute; import org.apache.bcel.classfile.Constant; @@ -226,7 +228,7 @@ public String getSignature() { return type.getSignature(); } - private ArrayList observers; + private List observers; /** Add observer for this object. */ Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGenOrMethodGen.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGenOrMethodGen.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGenOrMethodGen.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/FieldGenOrMethodGen.java Mon Aug 8 20:30:38 2005 @@ -1,5 +1,7 @@ package org.apache.bcel.generic; import java.util.ArrayList; +import java.util.List; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.AccessFlags; import org.apache.bcel.classfile.Attribute; @@ -17,7 +19,7 @@ protected String name; protected Type type; protected ConstantPoolGen cp; - private ArrayList attribute_vec = new ArrayList(); + private List attribute_vec = new ArrayList(); protected FieldGenOrMethodGen() {} Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/InstructionList.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/InstructionList.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/InstructionList.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/InstructionList.java Mon Aug 8 20:30:38 2005 @@ -24,7 +24,9 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; +import java.util.List; import java.util.Map; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.Constant; import org.apache.bcel.util.ByteSequence; @@ -702,7 +704,7 @@ first.prev = null; // Completely separated from rest of list last.next = null; - ArrayList target_vec = new ArrayList(); + List target_vec = new ArrayList(); for(InstructionHandle ih=first; ih != null; ih = ih.next) ih.getInstruction().dispose(); // e.g. BranchInstructions release their targets @@ -963,7 +965,7 @@ */ public Instruction[] getInstructions() { ByteSequence bytes = new ByteSequence(getByteCode()); - ArrayList instructions = new ArrayList(); + List instructions = new ArrayList(); try { while(bytes.available() > 0) { @@ -971,9 +973,7 @@ } } catch(IOException e) { throw new ClassGenException(e.toString()); } - Instruction[] result = new Instruction[instructions.size()]; - instructions.toArray(result); - return result; + return (Instruction[])instructions.toArray(new Instruction[instructions.size()]); } public String toString() { @@ -1227,7 +1227,7 @@ } } - private ArrayList observers; + private List observers; /** Add observer for this object. */ Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/MethodGen.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/MethodGen.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/MethodGen.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/MethodGen.java Mon Aug 8 20:30:38 2005 @@ -20,7 +20,9 @@ import java.util.ArrayList; import java.util.Hashtable; import java.util.Iterator; +import java.util.List; import java.util.Stack; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.Attribute; import org.apache.bcel.classfile.Code; @@ -59,11 +61,11 @@ private InstructionList il; private boolean strip_attributes; - private ArrayList variable_vec = new ArrayList(); - private ArrayList line_number_vec = new ArrayList(); - private ArrayList exception_vec = new ArrayList(); - private ArrayList throws_vec = new ArrayList(); - private ArrayList code_attrs_vec = new ArrayList(); + private List variable_vec = new ArrayList(); + private List line_number_vec = new ArrayList(); + private List exception_vec = new ArrayList(); + private List throws_vec = new ArrayList(); + private List code_attrs_vec = new ArrayList(); private static BCELComparator _cmp = new BCELComparator() { public boolean equals(Object o1, Object o2) { @@ -1014,7 +1016,7 @@ return maxStackDepth; } - private ArrayList observers; + private List observers; /** Add observer for this object. */ Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/Type.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/Type.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/Type.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/Type.java Mon Aug 8 20:30:38 2005 @@ -18,6 +18,8 @@ import java.util.ArrayList; +import java.util.List; + import org.apache.bcel.Constants; import org.apache.bcel.classfile.ClassFormatException; import org.apache.bcel.classfile.Utility; @@ -189,7 +191,7 @@ * @return array of argument types */ public static Type[] getArgumentTypes(String signature) { - ArrayList vec = new ArrayList(); + List vec = new ArrayList(); int index; Type[] types; Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/util/BCELFactory.java Mon Aug 8 20:30:38 2005 @@ -4,6 +4,7 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; +import java.util.List; import java.util.Map; import org.apache.bcel.Constants; @@ -235,7 +236,7 @@ } // Memorize BranchInstructions that need an update - private ArrayList branches = new ArrayList(); + private List branches = new ArrayList(); public void visitBranchInstruction(BranchInstruction bi) { BranchHandle bh = (BranchHandle)branch_map.get(bi); Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java Mon Aug 8 20:30:38 2005 @@ -26,6 +26,7 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.Iterator; +import java.util.List; import java.util.StringTokenizer; import java.util.zip.ZipEntry; import java.util.zip.ZipFile; @@ -49,7 +50,7 @@ public ClassPath(String class_path) { this.class_path = class_path; - ArrayList vec = new ArrayList(); + List vec = new ArrayList(); for(StringTokenizer tok=new StringTokenizer(class_path, System.getProperty("path.separator")); @@ -103,7 +104,7 @@ return false; } - private static final void getPathComponents(String path, ArrayList list) { + private static final void getPathComponents(String path, List list) { if(path != null) { StringTokenizer tok = new StringTokenizer(path, File.pathSeparator); @@ -127,12 +128,12 @@ String boot_path = System.getProperty("sun.boot.class.path"); String ext_path = System.getProperty("java.ext.dirs"); - ArrayList list = new ArrayList(); + List list = new ArrayList(); getPathComponents(class_path, list); getPathComponents(boot_path, list); - ArrayList dirs = new ArrayList(); + List dirs = new ArrayList(); getPathComponents(ext_path, dirs); for(Iterator e = dirs.iterator(); e.hasNext(); ) { Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassVector.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassVector.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassVector.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassVector.java Mon Aug 8 20:30:38 2005 @@ -17,6 +17,8 @@ package org.apache.bcel.util; import java.util.ArrayList; +import java.util.List; + import org.apache.bcel.classfile.JavaClass; /** @@ -29,7 +31,7 @@ * @deprecated as of 5.1.1 - 7/17/2005 */ public class ClassVector implements java.io.Serializable { - protected ArrayList vec = new ArrayList(); + protected List vec = new ArrayList(); public void addElement(JavaClass clazz) { vec.add(clazz); } public JavaClass elementAt(int index) { return (JavaClass)vec.get(index); } Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/InstructionFinder.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/util/InstructionFinder.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/util/InstructionFinder.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/util/InstructionFinder.java Mon Aug 8 20:30:38 2005 @@ -20,7 +20,9 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; +import java.util.List; import java.util.Map; + import org.apache.bcel.Constants; import org.apache.bcel.generic.ClassGenException; import org.apache.bcel.generic.Instruction; @@ -200,7 +202,7 @@ " not found in instruction list."); try { RE regex = new RE(search); - ArrayList matches = new ArrayList(); + List matches = new ArrayList(); while(start < il_string.length() && regex.match(il_string, start)) { int startExpr = regex.getParenStart(0); Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/statics/IntList.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/statics/IntList.java?rev=230959&r1=230958&r2=230959&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/statics/IntList.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/statics/IntList.java Mon Aug 8 20:30:38 2005 @@ -18,6 +18,7 @@ import java.util.ArrayList; +import java.util.List; /** * A small utility class representing a set of basic int values. @@ -27,7 +28,7 @@ */ public class IntList{ /** The int are stored as Integer objects here. */ - private ArrayList theList; + private List theList; /** This constructor creates an empty list. */ IntList(){ theList = new ArrayList(); --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Tue Aug 09 03:41:19 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 36907 invoked from network); 9 Aug 2005 03:41:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 9 Aug 2005 03:41:19 -0000 Received: (qmail 95851 invoked by uid 500); 9 Aug 2005 03:41:19 -0000 Delivered-To: vshelton@example.com Received: (qmail 95832 invoked by uid 500); 9 Aug 2005 03:41:19 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 95819 invoked by uid 500); 9 Aug 2005 03:41:19 -0000 Received: (qmail 95816 invoked by uid 99); 9 Aug 2005 03:41:19 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Aug 2005 20:41:18 -0700 Received: (qmail 36900 invoked by uid 65534); 9 Aug 2005 03:41:18 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r230960 - /jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/ConstantPool.java Date: Tue, 09 Aug 2005 03:41:18 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Mon Aug 8 20:41:11 2005 New Revision: 230960 URL: http://svn.apache.org/viewcvs?rev=230960&view=rev Log: 'guard' against npe's Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/ConstantPool.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/ConstantPool.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/ConstantPool.java?rev=230960&r1=230959&r2=230960&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/ConstantPool.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/ConstantPool.java Mon Aug 8 20:41:11 2005 @@ -323,14 +323,14 @@ try { c = (ConstantPool)clone(); - } catch(CloneNotSupportedException e) {} + c.constant_pool = new Constant[constant_pool_count]; - c.constant_pool = new Constant[constant_pool_count]; + for(int i=1; i < constant_pool_count; i++) { + if(constant_pool[i] != null) + c.constant_pool[i] = constant_pool[i].copy(); + } + } catch(CloneNotSupportedException e) {} - for(int i=1; i < constant_pool_count; i++) { - if(constant_pool[i] != null) - c.constant_pool[i] = constant_pool[i].copy(); - } return c; } --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Tue Aug 09 03:44:02 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 37259 invoked from network); 9 Aug 2005 03:44:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 9 Aug 2005 03:44:02 -0000 Received: (qmail 97742 invoked by uid 500); 9 Aug 2005 03:43:58 -0000 Delivered-To: vshelton@example.com Received: (qmail 97689 invoked by uid 500); 9 Aug 2005 03:43:58 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 97643 invoked by uid 500); 9 Aug 2005 03:43:58 -0000 Received: (qmail 97619 invoked by uid 99); 9 Aug 2005 03:43:58 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Aug 2005 20:43:56 -0700 Received: (qmail 37226 invoked by uid 65534); 9 Aug 2005 03:43:56 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r230961 - /jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java Date: Tue, 09 Aug 2005 03:43:55 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Mon Aug 8 20:43:46 2005 New Revision: 230961 URL: http://svn.apache.org/viewcvs?rev=230961&view=rev Log: 'guard' against npe's Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java?rev=230961&r1=230960&r2=230961&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java Mon Aug 8 20:43:46 2005 @@ -670,24 +670,24 @@ try { c = (JavaClass)clone(); - } catch (CloneNotSupportedException e) { - } - c.constant_pool = constant_pool.copy(); - c.interfaces = (int[])interfaces.clone(); - c.interface_names = (String[])interface_names.clone(); + c.constant_pool = constant_pool.copy(); + c.interfaces = (int[])interfaces.clone(); + c.interface_names = (String[])interface_names.clone(); - c.fields = new Field[fields.length]; - for (int i = 0; i < fields.length; i++) - c.fields[i] = fields[i].copy(c.constant_pool); + c.fields = new Field[fields.length]; + for (int i = 0; i < fields.length; i++) + c.fields[i] = fields[i].copy(c.constant_pool); - c.methods = new Method[methods.length]; - for (int i = 0; i < methods.length; i++) - c.methods[i] = methods[i].copy(c.constant_pool); + c.methods = new Method[methods.length]; + for (int i = 0; i < methods.length; i++) + c.methods[i] = methods[i].copy(c.constant_pool); - c.attributes = new Attribute[attributes.length]; - for (int i = 0; i < attributes.length; i++) - c.attributes[i] = attributes[i].copy(c.constant_pool); + c.attributes = new Attribute[attributes.length]; + for (int i = 0; i < attributes.length; i++) + c.attributes[i] = attributes[i].copy(c.constant_pool); + } catch (CloneNotSupportedException e) { + } return c; } --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Tue Aug 09 03:45:44 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 37548 invoked from network); 9 Aug 2005 03:45:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 9 Aug 2005 03:45:44 -0000 Received: (qmail 99035 invoked by uid 500); 9 Aug 2005 03:45:44 -0000 Delivered-To: vshelton@example.com Received: (qmail 98925 invoked by uid 500); 9 Aug 2005 03:45:43 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 98912 invoked by uid 500); 9 Aug 2005 03:45:43 -0000 Received: (qmail 98906 invoked by uid 99); 9 Aug 2005 03:45:43 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Aug 2005 20:45:43 -0700 Received: (qmail 37545 invoked by uid 65534); 9 Aug 2005 03:45:42 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r230962 - /jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifierAppFrame.java Date: Tue, 09 Aug 2005 03:45:42 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Mon Aug 8 20:45:35 2005 New Revision: 230962 URL: http://svn.apache.org/viewcvs?rev=230962&view=rev Log: 'guard' against npe's Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifierAppFrame.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifierAppFrame.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifierAppFrame.java?rev=230962&r1=230961&r2=230962&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifierAppFrame.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifierAppFrame.java Mon Aug 8 20:45:35 2005 @@ -331,11 +331,11 @@ JavaClass jc = null; try { jc = Repository.lookupClass(v.getClassName()); + all3amsg += "Method '"+jc.getMethods()[i]+"': "+vr.getMessage().replace('\n',' ')+"\n\n"; } catch (ClassNotFoundException ex) { // FIXME: handle the error ex.printStackTrace(); } - all3amsg += "Method '"+jc.getMethods()[i]+"': "+vr.getMessage().replace('\n',' ')+"\n\n"; } } pass3aTextPane.setText(all3amsg); @@ -363,11 +363,11 @@ JavaClass jc = null; try { jc = Repository.lookupClass(v.getClassName()); + all3bmsg += "Method '"+jc.getMethods()[i]+"': "+vr.getMessage().replace('\n',' ')+"\n\n"; } catch (ClassNotFoundException ex) { // FIXME: handle the error ex.printStackTrace(); } - all3bmsg += "Method '"+jc.getMethods()[i]+"': "+vr.getMessage().replace('\n',' ')+"\n\n"; } } pass3bTextPane.setText(all3bmsg); --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Tue Aug 09 03:47:00 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 37786 invoked from network); 9 Aug 2005 03:47:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 9 Aug 2005 03:47:00 -0000 Received: (qmail 99726 invoked by uid 500); 9 Aug 2005 03:47:00 -0000 Delivered-To: vshelton@example.com Received: (qmail 99601 invoked by uid 500); 9 Aug 2005 03:46:59 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 99588 invoked by uid 500); 9 Aug 2005 03:46:59 -0000 Received: (qmail 99584 invoked by uid 99); 9 Aug 2005 03:46:59 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Aug 2005 20:46:59 -0700 Received: (qmail 37769 invoked by uid 65534); 9 Aug 2005 03:46:59 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r230963 - /jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifyDialog.java Date: Tue, 09 Aug 2005 03:46:58 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Mon Aug 8 20:46:52 2005 New Revision: 230963 URL: http://svn.apache.org/viewcvs?rev=230963&view=rev Log: 'guard' against npe's Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifyDialog.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifyDialog.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifyDialog.java?rev=230963&r1=230962&r2=230963&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifyDialog.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/VerifyDialog.java Mon Aug 8 20:46:52 2005 @@ -504,17 +504,18 @@ JavaClass jc = null; try { jc = Repository.lookupClass(class_name); + + int nr = jc.getMethods().length; + for (int i=0; i<nr; i++) { + vr = v.doPass3b(i); + if (vr.getStatus() != VerificationResult.VERIFIED_OK){ + color = Color.red; + break; + } + } } catch (ClassNotFoundException ex) { // FIXME: report the error ex.printStackTrace(); - } - int nr = jc.getMethods().length; - for (int i=0; i<nr; i++) { - vr = v.doPass3b(i); - if (vr.getStatus() != VerificationResult.VERIFIED_OK){ - color = Color.red; - break; - } } } else{ --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Tue Aug 09 03:50:52 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 38306 invoked from network); 9 Aug 2005 03:50:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 9 Aug 2005 03:50:51 -0000 Received: (qmail 3370 invoked by uid 500); 9 Aug 2005 03:50:51 -0000 Delivered-To: vshelton@example.com Received: (qmail 3350 invoked by uid 500); 9 Aug 2005 03:50:51 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 3337 invoked by uid 500); 9 Aug 2005 03:50:51 -0000 Received: (qmail 3334 invoked by uid 99); 9 Aug 2005 03:50:51 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Aug 2005 20:50:51 -0700 Received: (qmail 38301 invoked by uid 65534); 9 Aug 2005 03:50:50 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r230964 - /jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java Date: Tue, 09 Aug 2005 03:50:50 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Mon Aug 8 20:50:43 2005 New Revision: 230964 URL: http://svn.apache.org/viewcvs?rev=230964&view=rev Log: make sure streams are closed, even on exception Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java?rev=230964&r1=230963&r2=230964&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/util/ClassPath.java Mon Aug 8 20:50:43 2005 @@ -220,17 +220,22 @@ * @return byte array for file on class path */ public byte[] getBytes(String name, String suffix) throws IOException { - InputStream is = getInputStream(name, suffix); + DataInputStream dis = null; + try { + InputStream is = getInputStream(name, suffix); - if(is == null) - throw new IOException("Couldn't find: " + name + suffix); + if(is == null) + throw new IOException("Couldn't find: " + name + suffix); - DataInputStream dis = new DataInputStream(is); - byte[] bytes = new byte[is.available()]; - dis.readFully(bytes); - dis.close(); is.close(); + dis = new DataInputStream(is); + byte[] bytes = new byte[is.available()]; + dis.readFully(bytes); - return bytes; + return bytes; + } finally { + if (dis != null) + dis.close(); + } } /** --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Wed Aug 10 05:17:23 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 78381 invoked from network); 10 Aug 2005 05:17:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 10 Aug 2005 05:17:23 -0000 Received: (qmail 43003 invoked by uid 500); 10 Aug 2005 05:17:23 -0000 Delivered-To: vshelton@example.com Received: (qmail 42894 invoked by uid 500); 10 Aug 2005 05:17:22 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 42881 invoked by uid 99); 10 Aug 2005 05:17:22 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Aug 2005 22:17:21 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 0520FE0; Wed, 10 Aug 2005 07:17:19 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 36110] New: - A bug in LocalVariableGen X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Wed, 10 Aug 2005 07:17:19 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36110>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36110 Summary: A bug in LocalVariableGen Product: BCEL Version: unspecified Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Main AssignedTo: vshelton@example.com ReportedBy: vshelton@example.com I'm one of the developers working on the Jakarta commons sandbox javaflow project. This problem is observed in the trunk (as of 2005/08/09), and it's causing some test failures in the gump build of the said javaflow project. Here's what I found while tracing through the code. When LocalVariableGen is created by using the following constructor: > public LocalVariableGen(int index, String name, Type type, > InstructionHandle start, InstructionHandle end) { > if((index < 0) || (index > Constants.MAX_SHORT)) > throw new ClassGenException("Invalid index index: " + index); > > this.name = name; > this.type = type; > this.index = index; > setStart(start); > setEnd(end); > } During the setStart method, it registers this newly created LocalVariableGen as a targeter to the InstructionHandle given by the 'start' parameter. InstructionHandle.targeters is a HashSet. So adding a LocalVariableGen as a targter means inserting a LocalVariableGen into a HashSet. This involves in computing the hashCode. So from within the setStart method, LocalVariableGen.hashCode() is invoked, since the end instruction isn't set yet, this returns a hashCode based on just index and start, ignoring the end field. Then immediately after the setStart method returns, the above constructor now sets the end instruction. As a result of this, hash code of the LocalVariableGen changes. This makes it impossible to update the start of LocalVariableGen correctly, because LocalVariableGen can no longer remove itself from the targeter set of the previous 'start' instruction. In other words, the problem is that the LocalVariableGen class computes its hash code based on mutable fields, yet at the same time it is used in a HashSet, where objects are not allowed to change its hash code. To the eyes of a new comer like me, this seems like a rather fundamental design flaw in the current BCEL library. SUGGESTED FIX ============= implement the hashCode method to return a constant value would fix the problem at the expense of the performance: public int hashCode() { return 42; } Alternatively, instead of using HashSet, use a custom implementation of a Set where the identity hash code is used instead of Object.hashCode. Although I haven't tested this approach, I believe this also fixes the problem. There may be other ways to fix the problem. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 03:36:41 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 95003 invoked from network); 11 Aug 2005 03:36:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 03:36:41 -0000 Received: (qmail 28428 invoked by uid 500); 11 Aug 2005 03:36:41 -0000 Delivered-To: vshelton@example.com Received: (qmail 28376 invoked by uid 500); 11 Aug 2005 03:36:40 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 28362 invoked by uid 500); 11 Aug 2005 03:36:40 -0000 Received: (qmail 28354 invoked by uid 99); 11 Aug 2005 03:36:40 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Aug 2005 20:36:40 -0700 Received: (qmail 94998 invoked by uid 65534); 11 Aug 2005 03:36:39 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r231385 - /jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java Date: Thu, 11 Aug 2005 03:36:39 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Wed Aug 10 20:36:32 2005 New Revision: 231385 URL: http://svn.apache.org/viewcvs?rev=231385&view=rev Log: fix for 36110 - LocalVariableGen calls setStart and setEnd which add 'this' to a hashset. The problem is that the hash is computed using start and end. since start wasn't computed until after it is added, the add hash and remove hash will be different. Changed ctor to stuff the start and end values before calling setStart and setEnd Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java?rev=231385&r1=231384&r2=231385&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java Wed Aug 10 20:36:32 2005 @@ -58,6 +58,12 @@ this.name = name; this.type = type; this.index = index; + // setStart and setEnd add 'this' to a HashSet, causing the hash to compute. + // The hash uses start and end, so set them before calling setStart/setEnd. + // Otherwise, the remove will fail because the hash is different than the add. + // Icky, but should be ok. See Bug: 36110 -- dbrosius + this.start = start; + this.end = end; setStart(start); setEnd(end); } --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 03:38:21 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 95196 invoked from network); 11 Aug 2005 03:38:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 03:38:21 -0000 Received: (qmail 30873 invoked by uid 500); 11 Aug 2005 03:38:21 -0000 Delivered-To: vshelton@example.com Received: (qmail 30854 invoked by uid 500); 11 Aug 2005 03:38:21 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 30841 invoked by uid 99); 11 Aug 2005 03:38:20 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2005 20:38:20 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id D212FE5; Thu, 11 Aug 2005 05:38:19 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 36110] - A bug in LocalVariableGen X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Thu, 11 Aug 2005 05:38:19 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36110>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36110 vshelton@example.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From vshelton@example.com 2005-08-11 05:38 ------- agreed.. nice detective work. I've added this, which i believe should be valid, and solve the problem, if icky. public LocalVariableGen(int index, String name, Type type, InstructionHandle start, InstructionHandle end) { if((index < 0) || (index > Constants.MAX_SHORT)) throw new ClassGenException("Invalid index index: " + index); this.name = name; this.type = type; this.index = index; // setStart and setEnd add 'this' to a HashSet, causing the hash to compute. // The hash uses start and end, so set them before calling setStart/setEnd. // Otherwise, the remove will fail because the hash is different than the add. // Icky, but should be ok. See Bug: 36110 -- dbrosius this.start = start; this.end = end; setStart(start); setEnd(end); } please let us know if there are still problems. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 05:07:04 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 24318 invoked from network); 11 Aug 2005 05:07:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 05:07:04 -0000 Received: (qmail 36742 invoked by uid 500); 11 Aug 2005 05:07:03 -0000 Delivered-To: vshelton@example.com Received: (qmail 36726 invoked by uid 500); 11 Aug 2005 05:07:03 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 36713 invoked by uid 99); 11 Aug 2005 05:07:03 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2005 22:07:03 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id 1E910E5; Thu, 11 Aug 2005 07:07:01 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 36110] - A bug in LocalVariableGen X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Thu, 11 Aug 2005 07:07:01 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36110>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36110 vshelton@example.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Additional Comments From vshelton@example.com 2005-08-11 07:06 ------- Sorry, that didn't fix the problem. Now it causes an NPE like this: 1. the LocalVariableGen constructor sets start and end to non-null 2. then it calls the setStart method. 3. the setStart method calls the notifyTarget method to remove itself from the old handle, and add itself to the new handle. 4. in this case, since the start field is already set, the old handle is non-null. 5. the notifyTarget method calls the removeTargeter method to remove the LocalVariableGen from the old InstructionHandle. 6. But since this 'old' InsturctionHandle doesn't actually have any targeter yet, the following method causes NPE. > public void removeTargeter(InstructionTargeter t) { > targeters.remove(t); > } Besides, I think we really need a proper fix to this problem. The suggested fix doesn't work if I attempt to move the start/end more than once. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 22:19:39 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 59952 invoked from network); 11 Aug 2005 22:19:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 22:19:39 -0000 Received: (qmail 64001 invoked by uid 500); 11 Aug 2005 22:19:39 -0000 Delivered-To: vshelton@example.com Received: (qmail 63894 invoked by uid 500); 11 Aug 2005 22:19:38 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 63881 invoked by uid 500); 11 Aug 2005 22:19:38 -0000 Received: (qmail 63878 invoked by uid 99); 11 Aug 2005 22:19:38 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO minotaur.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 11 Aug 2005 15:19:38 -0700 Received: (qmail 59932 invoked by uid 65534); 11 Aug 2005 22:19:37 -0000 Message-ID: <vshelton@example.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r231527 - /jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java Date: Thu, 11 Aug 2005 22:19:37 -0000 To: vshelton@example.com From: vshelton@example.com X-Mailer: svnmailer-1.0.3 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: dbrosius Date: Thu Aug 11 15:19:27 2005 New Revision: 231527 URL: http://svn.apache.org/viewcvs?rev=231527&view=rev Log: rollback Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java?rev=231527&r1=231526&r2=231527&view=diff ============================================================================== --- jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java (original) +++ jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java Thu Aug 11 15:19:27 2005 @@ -58,12 +58,6 @@ this.name = name; this.type = type; this.index = index; - // setStart and setEnd add 'this' to a HashSet, causing the hash to compute. - // The hash uses start and end, so set them before calling setStart/setEnd. - // Otherwise, the remove will fail because the hash is different than the add. - // Icky, but should be ok. See Bug: 36110 -- dbrosius - this.start = start; - this.end = end; setStart(start); setEnd(end); } --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 22:19:57 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 59996 invoked from network); 11 Aug 2005 22:19:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 22:19:57 -0000 Received: (qmail 64062 invoked by uid 500); 11 Aug 2005 22:19:56 -0000 Delivered-To: vshelton@example.com Received: (qmail 64046 invoked by uid 500); 11 Aug 2005 22:19:56 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 64033 invoked by uid 99); 11 Aug 2005 22:19:56 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Aug 2005 15:19:56 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [83.161.120.155] (HELO seanic31.net) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 11 Aug 2005 15:20:18 -0700 Received: (qmail 30572 invoked by uid 0); 11 Aug 2005 22:14:50 -0000 Message-ID: <vshelton@example.com> X-Mailer: Autoreply Sendmail v1.0 Date: Thu, 11 Aug 2005 22:14:50 GMT Content-Transfer-Encoding: 7bit Mime-Version: 1.0 To: "BCEL Developers List" <vshelton@example.com> From: vshelton@example.com X-Autoreply-To: vshelton@example.com Subject: AutoReply: svn commit: r231527 - /jakarta/bcel/trunk/src/java/org/apache/bcel/generic/LocalVariableGen.java X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N *****Please donot reply to this mail, Please send your reply to vshelton@example.com without changing the subject line***** Hello "BCEL Developers List" <vshelton@example.com>, Thank you for applying online through monsterindia.com. Please send your resume in word format to vshelton@example.com, so that we can assess your profile and match it against current requirements. If your profile matches with the requirement, we will contact you by telephone / email. We recommend that you update your profile and send us an updated CV whenever your contact details or your career path changes, so that your record is up-to-date with us. Please be assured that your CV will remain confidential with us and we will submit your profile to our clients only after due consultation with you. In case you require any further information please do contact us. with warm regards, Team @ A. S. Consultancy Services #1205, 2nd Main, 2nd Cross, Vijayanagar, Bangalore - 560040, India Tele - 91 80 2310 9012, Telefax - 91 80 2330 5364, Email: vshelton@example.com URL: www.asconsultancy.com Please Note 1. This email id (vshelton@example.com) is meant for receiving job application mails only. For other informartion, please contact us at the above mentioned contact details. 2. This message and any files transmitted with it contain confidential information and are intended only for the individual named. If you are not the named addressee you must not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. 3. E-mail transmission cannot be guaranteed to be fully or partly secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The recipient should check this email and any attachments for the presence of viruses. The sender neither accepts liability for any errors or omissions in the contents of this message nor accepts any liability for any damage caused by any virus, which arise as a result of e-mail transmission. Warning: Although the company has taken reasonable precautions to ensure no viruses are present in this email, the company cannot accept responsibility for any loss or damage arising from the use of this email or attachments. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 22:23:38 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 60979 invoked from network); 11 Aug 2005 22:23:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 22:23:37 -0000 Received: (qmail 65765 invoked by uid 500); 11 Aug 2005 22:23:37 -0000 Delivered-To: vshelton@example.com Received: (qmail 65740 invoked by uid 500); 11 Aug 2005 22:23:37 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 65727 invoked by uid 99); 11 Aug 2005 22:23:36 -0000 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=NO_REAL_NAME,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO ajax.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Aug 2005 15:23:36 -0700 Received: by ajax.apache.org (Postfix, from userid 99) id B8EF4EC; Fri, 12 Aug 2005 00:23:35 +0200 (CEST) From: vshelton@example.com To: vshelton@example.com Subject: DO NOT REPLY [Bug 36110] - A bug in LocalVariableGen X-Bugzilla-Reason: AssignedTo Message-Id: <vshelton@example.com> Date: Fri, 12 Aug 2005 00:23:35 +0200 (CEST) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=36110>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=36110 ------- Additional Comments From vshelton@example.com 2005-08-12 00:23 ------- rolled back -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: vshelton@example.com For additional commands, e-mail: vshelton@example.com From bcel-devvshelton@example.com Thu Aug 11 22:25:54 2005 Return-Path: <bcel-devvshelton@example.com> Delivered-To: vshelton@example.com Received: (qmail 61456 invoked from network); 11 Aug 2005 22:25:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 11 Aug 2005 22:25:54 -0000 Received: (qmail 66540 invoked by uid 500); 11 Aug 2005 22:25:53 -0000 Delivered-To: vshelton@example.com Received: (qmail 66520 invoked by uid 500); 11 Aug 2005 22:25:53 -0000 Mailing-List: contact vshelton@example.com; run by ezmlm Precedence: bulk List-Unsubscribe: <mailto:vshelton@example.com> List-Help: <mailto:vshelton@example.com> List-Post: <mailto:vshelton@example.com> List-Id: "BCEL Developers List" <bcel-dev.jakarta.apache.org> Reply-To: "BCEL Developers List" <vshelton@example.com> Delivered-To: mailing list vshelton@example.com Received: (qmail 66506 invoked by uid 99); 11 Aug 2005 22:25:53 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Aug 2005 15:25:53 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [83.161.120.155] (HELO seanic31.net) (83.161.120.155) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 11 Aug 2005 15:26:15 -0700 Received: (qmail 31617 invoked by uid 0); 11 Aug 2005 22:20:36 -0000 Message-ID: <vshelton@example.com> X-Mailer: Autoreply Sendmail v1.0 Date: Thu, 11 Aug 2005 22:20:36 GMT Content-Transfer-Encoding: 7bit Mime-Version: 1.0 To: "BCEL Developers List" <vshelton@example.com> From: vshelton@example.com X-Autoreply-To: vshelton@example.com Subject: AutoReply: DO NOT REPLY [Bug 36110] - A bug in LocalVariableGen X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N *****Please donot reply to this mail, Please send your reply to vshelton@example.com without changing the subject line***** Hello "BCEL Developers List" <vshelton@example.com>, Thank you for applying online through monsterindia.com. Please send your resume in word format to vshelton@example.com, so that we can assess your profile and match it against current requirements. If your profile matches with the requirement, we will contact you by telephone / email. We recommend that you update your profile and send us an updated CV whenever your contact details or your career path changes, so that your record is up-to-date with us. Please be assured that your CV will remain confidential with us and we will submit your profile to our clients only after due consultation with you. In case you require any further information please do contact us. with warm regards, Team @ A. S. Consultancy Services #1205, 2nd Main, 2nd Cross, Vijayanagar, Bangalore - 560040, India Tele - 91 80 2310 9012, Telefax - 91 80 2330 5364, Email: vshelton@example.com URL: www.asconsultancy.com Please Note 1. This email id (vshelton@example.com) is meant for receiving job application mails only. For other informartion, please contact us at the above mentioned contact details. 2. This message and any files transmitted with it contain confidential information and are intended only for the individual named. If you are not the named addressee you must not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. 3. E-mail transmission cannot be guaranteed to be fully or partly secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The recipient should check this email and any attachments for the presence of viruses. The sender neither accepts liability for any errors or omissions in the contents of this message nor accepts any liability for any damage caused by any virus, which arise as a result of e-mail transmission. Warning: Although the company has taken reasonable precautions to ensure no viruses are present in this email, the company cannot accept responsibility for any
{'source': 'Apache Software Foundation Public Mail Archives'}