From jonathansmith@example.com Mon Nov 01 00:05:19 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 8461 invoked from network); 1 Nov 2010 00:05:19 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 00:05:19 -0000 Received: (qmail 70126 invoked by uid 500); 1 Nov 2010 00:05:50 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 70105 invoked by uid 500); 1 Nov 2010 00:05:50 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 70097 invoked by uid 99); 1 Nov 2010 00:05:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 00:05:50 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 00:05:45 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 4CC8C8A208; Mon, 1 Nov 2010 00:05:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 00:05:24 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ ----------------------------------------------------------- (Updated 2010-10-31 17:05:24.252151) Review request for hbase and stack. Changes ------- Bit of cleanup on tests to make them compatible with the new changes. For = example, master cannot have PENDING_OPEN w/o existence of a zk node... and = we never have to handle a node in CLOSING during failover (on RS, we will a= lways do one of three: transition to closed, delete from closing, die). TestMasterFailover and TestRollingRestart (@ 50 regions) are both passing. Summary ------- Does cleanup of RIT timeouts according to document in progress. Still fini= shing document but I'd like to get this patch tested before finalizing it. Also found some strange stuff in server shutdown handling that could have e= asily led to some double assignment issues that stack was seeing. This addresses bug HBASE-3181. http://issues.apache.org/jira/browse/HBASE-3181 Diffs (updated) ----- trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java= 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHa= ndler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHan= dler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHa= ndler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdown= Handler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 10295= 07 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.jav= a 1029507 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.jav= a 1029507 = Diff: http://review.cloudera.org/r/1143/diff Testing ------- Working on tests now. This definitely changes some behavior that is tested= in the new TestMasterFailover so need to figure if the test should change = or whether we need to handle things like CLOSING. Maybe let it timeout a f= ew times? Thanks, Jonathan From jonathansmith@example.com Mon Nov 01 05:17:42 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 38803 invoked from network); 1 Nov 2010 05:17:42 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 05:17:42 -0000 Received: (qmail 92339 invoked by uid 500); 1 Nov 2010 05:18:13 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 92129 invoked by uid 500); 1 Nov 2010 05:18:12 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 92116 invoked by uid 99); 1 Nov 2010 05:18:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 05:18:11 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 05:18:06 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id BEACA8A208; Mon, 1 Nov 2010 05:17:45 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 05:17:45 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ ----------------------------------------------------------- (Updated 2010-10-31 22:17:45.677862) Review request for hbase and stack. Changes ------- Latest version. Summary ------- Does cleanup of RIT timeouts according to document in progress. Still fini= shing document but I'd like to get this patch tested before finalizing it. Also found some strange stuff in server shutdown handling that could have e= asily led to some double assignment issues that stack was seeing. This addresses bug HBASE-3181. http://issues.apache.org/jira/browse/HBASE-3181 Diffs (updated) ----- trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java= 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 102= 9507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHa= ndler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHan= dler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHa= ndler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdown= Handler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 10295= 07 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.jav= a 1029507 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.jav= a 1029507 = Diff: http://review.cloudera.org/r/1143/diff Testing ------- Working on tests now. This definitely changes some behavior that is tested= in the new TestMasterFailover so need to figure if the test should change = or whether we need to handle things like CLOSING. Maybe let it timeout a f= ew times? Thanks, Jonathan From jonathansmith@example.com Mon Nov 01 05:36:12 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 42926 invoked from network); 1 Nov 2010 05:36:12 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 05:36:12 -0000 Received: (qmail 639 invoked by uid 500); 1 Nov 2010 05:36:43 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 382 invoked by uid 500); 1 Nov 2010 05:36:42 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 367 invoked by uid 99); 1 Nov 2010 05:36:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 05:36:41 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 05:36:36 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id A86468A208; Mon, 1 Nov 2010 05:36:15 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 05:36:15 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/#review1735 ----------------------------------------------------------- Just ran TestRollingRestart with 4200 regions and it passed. Looking good.= Needs stack cluster testing. - Jonathan On 2010-10-31 22:17:45, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1143/ > ----------------------------------------------------------- > = > (Updated 2010-10-31 22:17:45) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > Does cleanup of RIT timeouts according to document in progress. Still fi= nishing document but I'd like to get this patch tested before finalizing it. > = > Also found some strange stuff in server shutdown handling that could have= easily led to some double assignment issues that stack was seeing. > = > = > This addresses bug HBASE-3181. > http://issues.apache.org/jira/browse/HBASE-3181 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1= 029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegion= Handler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegion= Handler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdo= wnHandler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 102= 9507 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1029507 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.j= ava 1029507 = > = > Diff: http://review.cloudera.org/r/1143/diff > = > = > Testing > ------- > = > Working on tests now. This definitely changes some behavior that is test= ed in the new TestMasterFailover so need to figure if the test should chang= e or whether we need to handle things like CLOSING. Maybe let it timeout a= few times? > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 06:06:52 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 60493 invoked from network); 1 Nov 2010 06:06:52 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 06:06:52 -0000 Received: (qmail 9894 invoked by uid 500); 1 Nov 2010 06:07:23 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 9649 invoked by uid 500); 1 Nov 2010 06:07:23 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 9637 invoked by uid 99); 1 Nov 2010 06:07:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 06:07:22 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 06:07:16 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id A09E08A208; Mon, 1 Nov 2010 06:06:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 06:06:55 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ ----------------------------------------------------------- (Updated 2010-10-31 23:06:55.505816) Review request for hbase and stack. Changes ------- Latest patch. Works with 5000 regions on TRR. TRR: Success! Found expected number of 5002 regions ---------------------------------------------------------------------------= ---- Test set: org.apache.hadoop.hbase.master.TestRollingRestart ---------------------------------------------------------------------------= ---- Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,227.177 s= ec Summary ------- Does cleanup of RIT timeouts according to document in progress. Still fini= shing document but I'd like to get this patch tested before finalizing it. Also found some strange stuff in server shutdown handling that could have e= asily led to some double assignment issues that stack was seeing. This addresses bug HBASE-3181. http://issues.apache.org/jira/browse/HBASE-3181 Diffs (updated) ----- trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java= 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 102= 9507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHa= ndler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHan= dler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHa= ndler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdown= Handler.java 1029507 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 10295= 07 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.jav= a 1029507 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.jav= a 1029507 = Diff: http://review.cloudera.org/r/1143/diff Testing ------- Working on tests now. This definitely changes some behavior that is tested= in the new TestMasterFailover so need to figure if the test should change = or whether we need to handle things like CLOSING. Maybe let it timeout a f= ew times? Thanks, Jonathan From jonathansmith@example.com Mon Nov 01 06:14:13 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 61070 invoked from network); 1 Nov 2010 06:14:13 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 06:14:13 -0000 Received: (qmail 11130 invoked by uid 500); 1 Nov 2010 06:14:44 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 10882 invoked by uid 500); 1 Nov 2010 06:14:44 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 10856 invoked by uid 99); 1 Nov 2010 06:14:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 06:14:43 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 06:14:38 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id B63298A208; Mon, 1 Nov 2010 06:14:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 06:14:17 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/#review1736 ----------------------------------------------------------- trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5666> adding this setOfflineInZK boolean as a mandatory argument to assignmen= t is a critical part of forcing us to get this stuff right. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5665> should be "are in transition" not "are not" - Jonathan On 2010-10-31 23:06:55, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1143/ > ----------------------------------------------------------- > = > (Updated 2010-10-31 23:06:55) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > Does cleanup of RIT timeouts according to document in progress. Still fi= nishing document but I'd like to get this patch tested before finalizing it. > = > Also found some strange stuff in server shutdown handling that could have= easily led to some double assignment issues that stack was seeing. > = > = > This addresses bug HBASE-3181. > http://issues.apache.org/jira/browse/HBASE-3181 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1= 029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegion= Handler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegion= Handler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdo= wnHandler.java 1029507 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 102= 9507 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1029507 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.j= ava 1029507 = > = > Diff: http://review.cloudera.org/r/1143/diff > = > = > Testing > ------- > = > Working on tests now. This definitely changes some behavior that is test= ed in the new TestMasterFailover so need to figure if the test should chang= e or whether we need to handle things like CLOSING. Maybe let it timeout a= few times? > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 17:15:53 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 71225 invoked from network); 1 Nov 2010 17:15:53 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 17:15:53 -0000 Received: (qmail 49976 invoked by uid 500); 1 Nov 2010 17:16:24 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 49903 invoked by uid 500); 1 Nov 2010 17:16:23 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Delivered-To: moderator for jonathansmith@example.com Received: (qmail 31553 invoked by uid 99); 1 Nov 2010 17:04:36 -0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Refactor "Corrupt Data" Tests in TestHLogSplit From: "Alex Newman" <jonathansmith@example.com> To: "Nicolas" <jonathansmith@example.com> Date: Mon, 01 Nov 2010 17:04:09 -0000 Message-ID: <jonathansmith@example.com> Cc: "Alex Newman" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> X-Virus-Checked: Checked by ClamAV on apache.org > On 2010-10-31 21:18:46, Nicolas wrote: > > I'm okay with the general concept/direction. I think you should get ri= d of resetLogReaderClass(), but other than that, it looks pretty clean :) = I think there's more edge cases with IOE/ParseExceptions that we could theo= retically handle, but this is a positive step and mitigates the regression. Right on, what are some edge cases? What's the best way to nuke that state?= Eventually, with distributed log splitting, this will eventually need to w= ork in a distributed way. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1115/#review1734 ----------------------------------------------------------- On 2010-10-29 15:03:31, Alex Newman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1115/ > ----------------------------------------------------------- > = > (Updated 2010-10-29 15:03:31) > = > = > Review request for hbase and Nicolas. > = > = > Summary > ------- > = > So I took the approach taken with the instrumented sequence file rider. N= ot sure if exposing those methods in the WALReader is cool so I am down wit= h other suggestions. > = > - Add a FaultySequenceFileLogReader > - Un-commented the 2935 tests > = > = > This addresses bug hbase-2935. > http://issues.apache.org/jira/browse/hbase-2935 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java c8a10a= f = > src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogR= eader.java 0b7dc78 = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/FaultySequenceFi= leLogReader.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.ja= va 473c359 = > = > Diff: http://review.cloudera.org/r/1115/diff > = > = > Testing > ------- > = > Running on our internal hudson as I type this. Also I ran the TestHLogSpl= it test locally. I'll update the review if hudson is green. > = > = > Thanks, > = > Alex > = > From jonathansmith@example.com Mon Nov 01 17:27:05 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 76190 invoked from network); 1 Nov 2010 17:27:05 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 17:27:05 -0000 Received: (qmail 64450 invoked by uid 500); 1 Nov 2010 17:27:36 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 64421 invoked by uid 500); 1 Nov 2010 17:27:36 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 64413 invoked by uid 99); 1 Nov 2010 17:27:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 17:27:36 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 83.161.120.155 is neither permitted nor denied by domain of jonathansmith@example.com) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 17:27:31 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 956698A208; Mon, 1 Nov 2010 17:27:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-3154: HBase RPC should support timeout (Hairong's patch) From: jonathansmith@example.com To: "Kannan Muthukkaruppan" <jonathansmith@example.com>, jonathansmith@example.com Date: Mon, 01 Nov 2010 17:27:10 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1142/#review1745 ----------------------------------------------------------- This looks right. Does it work? There is no test. I put it up on my litt= le cluster and stuff still works so its not breaking anything. - stack On 2010-10-31 12:45:13, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1142/ > ----------------------------------------------------------- > = > (Updated 2010-10-31 12:45:13) > = > = > Review request for hbase, stack and Kannan Muthukkaruppan. > = > = > Summary > ------- > = > This patch is from Hairong. Just helping out by putting it up on RB. > = > This adds a global, configurable timeout for all HBase RPCs. Uses new co= nfig parameter 'hbase.rpc.timeout' rather than overloading the lease period. > = > = > This addresses bug HBASE-3154. > http://issues.apache.org/jira/browse/HBASE-3154 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1029423 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.j= ava 1029423 = > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 102942= 3 = > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1029423 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 1029423 = > = > Diff: http://review.cloudera.org/r/1142/diff > = > = > Testing > ------- > = > Not actually sure. I know that we've committed this internally at FB and= I think Hairong did testing on it. > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 17:55:36 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 87454 invoked from network); 1 Nov 2010 17:55:35 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 17:55:35 -0000 Received: (qmail 14755 invoked by uid 500); 1 Nov 2010 17:56:06 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 14732 invoked by uid 500); 1 Nov 2010 17:56:06 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 14723 invoked by uid 99); 1 Nov 2010 17:56:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 17:56:06 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 83.161.120.155 is neither permitted nor denied by domain of jonathansmith@example.com) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 17:56:01 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id E331E8A208; Mon, 1 Nov 2010 17:55:40 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-3154: HBase RPC should support timeout (Hairong's patch) From: jonathansmith@example.com To: "Kannan Muthukkaruppan" <jonathansmith@example.com>, jonathansmith@example.com Date: Mon, 01 Nov 2010 17:55:40 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1142/#review1752 ----------------------------------------------------------- Ship it! +1 on commit because of Hairong remarks up in issue. - stack On 2010-10-31 12:45:13, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1142/ > ----------------------------------------------------------- > = > (Updated 2010-10-31 12:45:13) > = > = > Review request for hbase, stack and Kannan Muthukkaruppan. > = > = > Summary > ------- > = > This patch is from Hairong. Just helping out by putting it up on RB. > = > This adds a global, configurable timeout for all HBase RPCs. Uses new co= nfig parameter 'hbase.rpc.timeout' rather than overloading the lease period. > = > = > This addresses bug HBASE-3154. > http://issues.apache.org/jira/browse/HBASE-3154 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1029423 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.j= ava 1029423 = > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 102942= 3 = > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1029423 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 1029423 = > = > Diff: http://review.cloudera.org/r/1142/diff > = > = > Testing > ------- > = > Not actually sure. I know that we've committed this internally at FB and= I think Hairong did testing on it. > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 18:47:32 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 20560 invoked from network); 1 Nov 2010 18:47:32 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 18:47:32 -0000 Received: (qmail 88605 invoked by uid 500); 1 Nov 2010 18:48:03 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 88578 invoked by uid 500); 1 Nov 2010 18:48:03 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 88570 invoked by uid 99); 1 Nov 2010 18:48:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 18:48:02 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 18:47:56 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 973F68A208; Mon, 1 Nov 2010 18:47:35 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 18:47:35 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ ----------------------------------------------------------- (Updated 2010-11-01 11:47:35.522039) Review request for hbase and stack. Changes ------- This fixes new found bug. When we processed server shutdown, we read META for regions on the dead ser= ver. But we were only comparing HServerAddress not HServerInfo. When roll= ing restart is acting up (or any time an RS comes back up w/ different star= tcode) this would cause double assignment. Checks against HSI now. Summary ------- Does cleanup of RIT timeouts according to document in progress. Still fini= shing document but I'd like to get this patch tested before finalizing it. Also found some strange stuff in server shutdown handling that could have e= asily led to some double assignment issues that stack was seeing. This addresses bug HBASE-3181. http://issues.apache.org/jira/browse/HBASE-3181 Diffs (updated) ----- trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 10297= 89 = trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java= 1029789 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029789 = trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 102= 9789 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHa= ndler.java 1029789 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHan= dler.java 1029789 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHa= ndler.java 1029789 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdown= Handler.java 1029789 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 10297= 89 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.jav= a 1029789 = trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.jav= a 1029789 = Diff: http://review.cloudera.org/r/1143/diff Testing ------- Working on tests now. This definitely changes some behavior that is tested= in the new TestMasterFailover so need to figure if the test should change = or whether we need to handle things like CLOSING. Maybe let it timeout a f= ew times? Thanks, Jonathan From jonathansmith@example.com Mon Nov 01 19:04:38 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 24032 invoked from network); 1 Nov 2010 19:04:38 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 19:04:38 -0000 Received: (qmail 6073 invoked by uid 500); 1 Nov 2010 19:05:09 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 6048 invoked by uid 500); 1 Nov 2010 19:05:09 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 6040 invoked by uid 99); 1 Nov 2010 19:05:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 19:05:09 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 83.161.120.155 is neither permitted nor denied by domain of jonathansmith@example.com) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 19:05:02 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id EFF558A208; Mon, 1 Nov 2010 19:04:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: jonathansmith@example.com To: jonathansmith@example.com Date: Mon, 01 Nov 2010 19:04:41 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/#review1753 ----------------------------------------------------------- Patch looks good. I'm testing it on cluster. trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHa= ndler.java <http://review.cloudera.org/r/1143/#comment5676> Want to document the return? - stack On 2010-11-01 11:47:35, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1143/ > ----------------------------------------------------------- > = > (Updated 2010-11-01 11:47:35) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > Does cleanup of RIT timeouts according to document in progress. Still fi= nishing document but I'd like to get this patch tested before finalizing it. > = > Also found some strange stuff in server shutdown handling that could have= easily led to some double assignment issues that stack was seeing. > = > = > This addresses bug HBASE-3181. > http://issues.apache.org/jira/browse/HBASE-3181 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 102= 9789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1= 029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegion= Handler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegion= Handler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdo= wnHandler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 102= 9789 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1029789 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.j= ava 1029789 = > = > Diff: http://review.cloudera.org/r/1143/diff > = > = > Testing > ------- > = > Working on tests now. This definitely changes some behavior that is test= ed in the new TestMasterFailover so need to figure if the test should chang= e or whether we need to handle things like CLOSING. Maybe let it timeout a= few times? > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 19:08:09 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 37240 invoked from network); 1 Nov 2010 19:08:08 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 19:08:08 -0000 Received: (qmail 10292 invoked by uid 500); 1 Nov 2010 19:08:40 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 10196 invoked by uid 500); 1 Nov 2010 19:08:39 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 10188 invoked by uid 99); 1 Nov 2010 19:08:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 19:08:39 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 19:08:34 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 05B768A208; Mon, 1 Nov 2010 19:08:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" <jonathansmith@example.com> To: jonathansmith@example.com Date: Mon, 01 Nov 2010 19:08:13 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> > On 2010-11-01 12:04:42, stack wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdo= wnHandler.java, line 167 > > <http://review.cloudera.org/r/1143/diff/4/?file=3D16342#file16342line16= 7> > > > > Want to document the return? It's in the javadoc: * Returns true if specified region should be assig= ned, false if not. Just didn't put it in the @return... can fix that up on commit - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/#review1753 ----------------------------------------------------------- On 2010-11-01 11:47:35, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1143/ > ----------------------------------------------------------- > = > (Updated 2010-11-01 11:47:35) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > Does cleanup of RIT timeouts according to document in progress. Still fi= nishing document but I'd like to get this patch tested before finalizing it. > = > Also found some strange stuff in server shutdown handling that could have= easily led to some double assignment issues that stack was seeing. > = > = > This addresses bug HBASE-3181. > http://issues.apache.org/jira/browse/HBASE-3181 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 102= 9789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1= 029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegion= Handler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegion= Handler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdo= wnHandler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 102= 9789 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1029789 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.j= ava 1029789 = > = > Diff: http://review.cloudera.org/r/1143/diff > = > = > Testing > ------- > = > Working on tests now. This definitely changes some behavior that is test= ed in the new TestMasterFailover so need to figure if the test should chang= e or whether we need to handle things like CLOSING. Maybe let it timeout a= few times? > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 21:34:02 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 56986 invoked from network); 1 Nov 2010 21:34:02 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 21:34:02 -0000 Received: (qmail 81612 invoked by uid 500); 1 Nov 2010 21:34:33 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 81585 invoked by uid 500); 1 Nov 2010 21:34:33 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 81576 invoked by uid 99); 1 Nov 2010 21:34:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 21:34:33 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jonathansmith@example.com designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-ww0-f41.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 21:34:26 +0000 Received: by wwb39 with SMTP id 39so337882wwb.2 for <jonathansmith@example.com>; Mon, 01 Nov 2010 14:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=M5UnY9daF0apOMf7EaD0i0OcIIS9owzJbXmP2xaB6eE=; b=PrkwrfwrxJJJ4zgF0umKMT7NflFhuK/4mld6JL/jdLOlKpLVXgvs6S0yLV686Un+20 WsqvIw8VmPYxOs37Uu3qDq2fPxbVuEcVo7axwsS4L5cjymgBOD+cJxEfXIXcx2bl/hg6 BCxgoN1EX5M5zOhcsTbbBD5LG6TzL9o3GvGns= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=BZqq48WTP+sh1MNta7n+VHZlCiQm3FqTj2xsHWO7WgE2fR0v4OlEHl+Ugo+KolritY jHzcIDsFHTYfOJA2ek8sBdfx1kv+77UwcsqhyV4epd3yuUCGMJcZSJanNyb+dHx9VIax RO4F7C/1OSBgrhq/279zwm+l2By0Y+FIceZ1E= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id 60mr223687wey.42.1288647245244; Mon, 01 Nov 2010 14:34:05 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Mon, 1 Nov 2010 14:34:05 -0700 (PDT) Date: Mon, 1 Nov 2010 17:34:05 -0400 Message-ID: <jonathansmith@example.com> Subject: HBase Citation From: Jeffrey Spies <jonathansmith@example.com> To: jonathansmith@example.com Content-Type: text/plain; charset=ISO-8859-1 Hi, Developers, Do you have a preferred way to cite HBase? I'm currently using: @webpage{HBase, Author = {{The Apache Software Foundation}}, Lastchecked = {2010-10-31}, Title = {Welcome to HBase!}, Url = {http://hbase.apache.org}, Year = {2010}} or, when formatted: The Apache Software Foundation (2010). "Welcome to HBase!", URL http://hbase.apache.org. If not, I am fond of citing documentation if organized into what can be considered a manual (then it can have a more prominent position on, say, a CV): HBase Development Team (2010). HBase: A Distributed Database for Large Datasets. The Apache Software Foundation, Los Angeles, CA. URL http://hbase.apache.org. Thanks, Jeff. From jonathansmith@example.com Mon Nov 01 21:48:49 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 69040 invoked from network); 1 Nov 2010 21:48:48 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 21:48:48 -0000 Received: (qmail 7834 invoked by uid 500); 1 Nov 2010 21:49:19 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 7808 invoked by uid 500); 1 Nov 2010 21:49:19 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 7795 invoked by uid 99); 1 Nov 2010 21:49:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 21:49:19 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 83.161.120.155 is neither permitted nor denied by domain of jonathansmith@example.com) Received: from [83.161.120.155] (HELO ip-10-202-7-187.ec2.internal) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 21:49:12 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [83.161.120.155]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id CC52B8A208; Mon, 1 Nov 2010 21:48:51 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Cleanup of RIT timeouts and server shutdown handling From: jonathansmith@example.com To: jonathansmith@example.com Date: Mon, 01 Nov 2010 21:48:51 -0000 Message-ID: <jonathansmith@example.com> Cc: "Jonathan Gray" <jonathansmith@example.com>, jonathansmith@example.com, jonathansmith@example.com In-Reply-To: <jonathansmith@example.com> References: <jonathansmith@example.com> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/#review1755 ----------------------------------------------------------- Ship it! Commit after reviewing the below. This patch makes a HUGE difference. My = trashing rolling restart of a 10 node cluster of 3k regions now works (most= ly). Seems like an errant region the odd time I test but thats for hbck to= figure now.... Great work JGray. trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java <http://review.cloudera.org/r/1143/#comment5678> How did this ever work? Why didn't typing catch this? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5679> We doing this or not? Seems like we are. Should we change this back t= o plain HashMap... else when concurrent map it gives impression that its ok= to meddle in regionPlan w/o first synchronizing? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5680> want to doc this new param? (Not important -- its self-describing) trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5681> We don't have to do the remove anymore? Passing force new plan does th= is for us? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5682> Should this test go into a method of its own? Is it repeated elsewhere? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5683> What happens if state.isClosing now? (You dropped it from else if here) trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5684> Are all this.regions synchronized? Same for this.regionPlans? You mig= ht want to give it all a review before commit? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5685> I think spell it out rather than NSRE in the message. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5686> Is this ok? Calling assign inside a synchronize on RIT? Is that done = everywhere? Or, this is the assign that takes a RegionState.. and expects = the synchronize to be in place? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5687> This is good... moving this stuff inside assign. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5688> Nothing to do here? Job for hbck? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5689> What happens here? I suppose we used shutdown server? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1143/#comment5690> Ok trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java <http://review.cloudera.org/r/1143/#comment5691> Thats an awkward sentence for a debug message... trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHand= ler.java <http://review.cloudera.org/r/1143/#comment5692> We were not using this? Probably for the best. Probably stale by time= we went to act on it? - stack On 2010-11-01 11:47:35, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1143/ > ----------------------------------------------------------- > = > (Updated 2010-11-01 11:47:35) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > Does cleanup of RIT timeouts according to document in progress. Still fi= nishing document but I'd like to get this patch tested before finalizing it. > = > Also found some strange stuff in server shutdown handling that could have= easily led to some double assignment issues that stack was seeing. > = > = > This addresses bug HBASE-3181. > http://issues.apache.org/jira/browse/HBASE-3181 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 102= 9789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1= 029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegion= Handler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegion= Handler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdo= wnHandler.java 1029789 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 102= 9789 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1029789 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.j= ava 1029789 = > = > Diff: http://review.cloudera.org/r/1143/diff > = > = > Testing > ------- > = > Working on tests now. This definitely changes some behavior that is test= ed in the new TestMasterFailover so need to figure if the test should chang= e or whether we need to handle things like CLOSING. Maybe let it timeout a= few times? > = > = > Thanks, > = > Jonathan > = > From jonathansmith@example.com Mon Nov 01 22:04:50 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 74676 invoked from network); 1 Nov 2010 22:04:50 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 22:04:50 -0000 Received: (qmail 29712 invoked by uid 500); 1 Nov 2010 22:05:21 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 29680 invoked by uid 500); 1 Nov 2010 22:05:21 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Delivered-To: moderator for jonathansmith@example.com Received: (qmail 95960 invoked by uid 99); 1 Nov 2010 21:43:20 -0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Date: Mon, 1 Nov 2010 21:42:58 +0000 (UTC) From: Apache Hudson Server <jonathansmith@example.com> To: jonathansmith@example.com Message-ID: <976284677.61288647778163.JavaMail.hudson@aegis> Subject: Build failed in Hudson: HBase-TRUNK #1605 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit See <https://hudson.apache.org/hudson/job/HBase-TRUNK/1605/changes> Changes: [jgray] HBASE-3184 Xmx setting in pom to use for tests/surefire does not appear to work [jgray] HBASE-3154 HBase RPC should support timeout (Hairong via jgray) ------------------------------------------ [...truncated 995 lines...] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec Running org.apache.hadoop.hbase.io.hfile.TestSeekTo Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.236 sec Running org.apache.hadoop.hbase.filter.TestColumnPaginationFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running org.apache.hadoop.hbase.rest.TestStatusResource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.108 sec Running org.apache.hadoop.hbase.executor.TestExecutorService Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.049 sec Running org.apache.hadoop.hbase.client.TestFromClientSide Tests run: 40, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 322.503 sec Running org.apache.hadoop.hbase.replication.TestReplication Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 195.45 sec Running org.apache.hadoop.hbase.regionserver.TestCompaction Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.005 sec Running org.apache.hadoop.hbase.filter.TestSingleColumnValueFilter Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.037 sec Running org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.466 sec Running org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServerArg Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.036 sec Running org.apache.hadoop.hbase.mapreduce.TestSimpleTotalOrderPartitioner Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.123 sec Running org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 158.423 sec Running org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.596 sec Running org.apache.hadoop.hbase.client.replication.TestReplicationAdmin Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.533 sec Running org.apache.hadoop.hbase.regionserver.TestScanDeleteTracker Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.201 sec Running org.apache.hadoop.hbase.client.TestMetaScanner Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.682 sec Running org.apache.hadoop.hbase.metrics.TestMetricsMBeanBase Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec Running org.apache.hadoop.hbase.TestRegionRebalancing Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 83.048 sec Running org.apache.hadoop.hbase.filter.TestSingleColumnValueExcludeFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running org.apache.hadoop.hbase.filter.TestInclusiveStopFilter Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running org.apache.hadoop.hbase.rest.TestTableResource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 56.678 sec Running org.apache.hadoop.hbase.TestHBaseTestingUtility Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 83.908 sec Running org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.073 sec Running org.apache.hadoop.hbase.rest.TestSchemaResource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.093 sec Running org.apache.hadoop.hbase.regionserver.wal.TestWALReplay Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.46 sec Running org.apache.hadoop.hbase.regionserver.TestKeyValueScanFixture Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec Running org.apache.hadoop.hbase.rest.model.TestTableListModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.135 sec Running org.apache.hadoop.hbase.rest.model.TestColumnSchemaModel Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec Running org.apache.hadoop.hbase.regionserver.TestStoreFile Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.746 sec Running org.apache.hadoop.hbase.zookeeper.TestZooKeeperNodeTracker Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.472 sec Running org.apache.hadoop.hbase.rest.model.TestScannerModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.135 sec Running org.apache.hadoop.hbase.regionserver.wal.TestHLogMethods Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.238 sec Running org.apache.hadoop.hbase.rest.TestVersionResource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.758 sec Running org.apache.hadoop.hbase.filter.TestFilter Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.956 sec Running org.apache.hadoop.hbase.regionserver.TestWideScanner Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.929 sec Running org.apache.hadoop.hbase.regionserver.TestSplitTransaction Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.052 sec Running org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.199 sec Running org.apache.hadoop.hbase.util.TestMergeTable Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 64.924 sec Running org.apache.hadoop.hbase.regionserver.TestReadWriteConsistencyControl Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.031 sec Running org.apache.hadoop.hbase.regionserver.TestGetClosestAtOrBefore Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.737 sec Running org.apache.hadoop.hbase.rest.model.TestVersionModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 sec Running org.apache.hadoop.hbase.rest.model.TestCellSetModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.141 sec Running org.apache.hadoop.hbase.rest.client.TestRemoteTable Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 128.816 sec Running org.apache.hadoop.hbase.rest.model.TestStorageClusterStatusModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.151 sec Running org.apache.hadoop.hbase.avro.TestAvroServer Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.091 sec Running org.apache.hadoop.hbase.TestFullLogReconstruction Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 92.866 sec Running org.apache.hadoop.hbase.TestSerialization Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec Running org.apache.hadoop.hbase.regionserver.TestKeyValueHeap Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.178 sec Running org.apache.hadoop.hbase.regionserver.TestStoreScanner Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 sec Running org.apache.hadoop.hbase.TestHMsg Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec Running org.apache.hadoop.hbase.io.hfile.TestReseekTo Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.256 sec Running org.apache.hadoop.hbase.util.TestIncrementingEnvironmentEdge Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running org.apache.hadoop.hbase.util.TestKeying Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running org.apache.hadoop.hbase.regionserver.TestScanner Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 67.676 sec Running org.apache.hadoop.hbase.regionserver.TestHRegionInfo Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running org.apache.hadoop.hbase.master.TestRestartCluster Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.589 sec Running org.apache.hadoop.hbase.client.TestShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 343.509 sec Running org.apache.hadoop.hbase.rest.model.TestTableInfoModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.14 sec Running org.apache.hadoop.hbase.regionserver.TestMinorCompactingStoreScanner Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec Running org.apache.hadoop.hbase.TestInfoServers Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.061 sec Running org.apache.hadoop.hbase.master.TestLogsCleaner Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.166 sec Running org.apache.hadoop.hbase.regionserver.TestMasterAddressManager Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.351 sec Running org.apache.hadoop.hbase.regionserver.TestQueryMatcher Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.184 sec Running org.apache.hadoop.hbase.client.TestAdmin Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 450.318 sec Running org.apache.hadoop.hbase.regionserver.TestPriorityCompactionQueue Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.114 sec Running org.apache.hadoop.hbase.util.TestMergeTool Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.431 sec Running org.apache.hadoop.hbase.TestAcidGuarantees Tests run: 3, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.024 sec Running org.apache.hadoop.hbase.util.TestBase64 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 sec Running org.apache.hadoop.hbase.regionserver.TestMemStore Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.479 sec Running org.apache.hadoop.hbase.rest.TestScannerResource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.061 sec Running org.apache.hadoop.hbase.io.hfile.TestLruBlockCache Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.053 sec Running org.apache.hadoop.hbase.master.TestDeadServer Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec Running org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.944 sec Running org.apache.hadoop.hbase.TestKeyValue Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 sec Running org.apache.hadoop.hbase.client.TestMultiParallel Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 73.436 sec Running org.apache.hadoop.hbase.master.TestMaster Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 86.459 sec Running org.apache.hadoop.hbase.master.TestRollingRestart Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 33.631 sec <<< FAILURE! Running org.apache.hadoop.hbase.client.TestResult Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.041 sec Running org.apache.hadoop.hbase.client.TestHTablePool Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.814 sec Running org.apache.hadoop.hbase.rest.model.TestTableSchemaModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.146 sec Running org.apache.hadoop.hbase.util.TestByteBloomFilter Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.734 sec Running org.apache.hadoop.hbase.filter.TestFilterList Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.092 sec Running org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 348.324 sec Running org.apache.hadoop.hbase.regionserver.TestHRegion Tests run: 51, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.068 sec Running org.apache.hadoop.hbase.master.TestMasterFailover Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 102.601 sec Running org.apache.hadoop.hbase.rest.model.TestTableRegionModel Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 sec Running org.apache.hadoop.hbase.client.TestTimestampsFilter Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.073 sec Running org.apache.hadoop.hbase.master.TestLoadBalancer Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.575 sec Running org.apache.hadoop.hbase.util.TestRootPath Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec Running org.apache.hadoop.hbase.client.TestScannerTimeout Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 56.463 sec Running org.apache.hadoop.hbase.mapred.TestTableMapReduce Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.405 sec Running org.apache.hadoop.hbase.regionserver.wal.TestWALObserver Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.556 sec Running org.apache.hadoop.hbase.master.TestActiveMasterManager Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.61 sec Running org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManager Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.078 sec Running org.apache.hadoop.hbase.util.TestBytes Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec Running org.apache.hadoop.hbase.util.TestCompressionTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec Running org.apache.hadoop.hbase.client.TestGetRowVersions Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 48.505 sec Running org.apache.hadoop.hbase.filter.TestDependentColumnFilter Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.447 sec Running org.apache.hadoop.hbase.rest.model.TestCellModel Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.133 sec Running org.apache.hadoop.hbase.master.TestCatalogJanitor Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.706 sec Running org.apache.hadoop.hbase.catalog.TestCatalogTracker Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.213 sec Running org.apache.hadoop.hbase.replication.TestReplicationSource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.055 sec Running org.apache.hadoop.hbase.rest.TestRowResource Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.862 sec Running org.apache.hadoop.hbase.io.hfile.TestHFile Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.459 sec Running org.apache.hadoop.hbase.catalog.TestMetaReaderEditor Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.505 sec Running org.apache.hadoop.hbase.mapreduce.TestImportTsv Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec Running org.apache.hadoop.hbase.rest.client.TestRemoteAdmin Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.693 sec Running org.apache.hadoop.hbase.regionserver.wal.TestHLog Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.498 sec Running org.apache.hadoop.hbase.client.TestTimestamp Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 25.87 sec Running org.apache.hadoop.hbase.TestScanMultipleVersions Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.466 sec Running org.apache.hadoop.hbase.rest.model.TestStorageClusterVersionModel Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec Running org.apache.hadoop.hbase.client.TestHCM Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.628 sec Results : Failed tests: Tests run: 546, Failures: 1, Errors: 0, Skipped: 10 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. Please refer to <https://hudson.apache.org/hudson/job/HBase-TRUNK/ws/trunk/target/surefire-reports> for the individual test results. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 81 minutes 17 seconds [INFO] Finished at: Mon Nov 01 21:42:36 UTC 2010 [INFO] Final Memory: 53M/521M [INFO] ------------------------------------------------------------------------ [locks-and-latches] Releasing all the locks [locks-and-latches] All the locks released Archiving artifacts Recording test results From jonathansmith@example.com Mon Nov 01 22:24:11 2010 Return-Path: <jonathansmith@example.com> Delivered-To: jonathansmith@example.com Received: (qmail 90866 invoked from network); 1 Nov 2010 22:24:11 -0000 Received: from unknown (HELO mail.apache.org) (83.161.120.155) by 83.161.120.155 with SMTP; 1 Nov 2010 22:24:11 -0000 Received: (qmail 53784 invoked by uid 500); 1 Nov 2010 22:24:42 -0000 Delivered-To: jonathansmith@example.com Received: (qmail 53762 invoked by uid 500); 1 Nov 2010 22:24:42 -0000 Mailing-List: contact jonathansmith@example.com; run by ezmlm Precedence: bulk List-Help: <mailto:jonathansmith@example.com> List-Unsubscribe: <mailto:jonathansmith@example.com> List-Post: <mailto:jonathansmith@example.com> List-Id: <dev.hbase.apache.org> Reply-To: jonathansmith@example.com Delivered-To: mailing list jonathansmith@example.com Received: (qmail 53749 invoked by uid 99); 1 Nov 2010 22:24:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Nov 2010 22:24:42 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155]
{'source': 'Apache Software Foundation Public Mail Archives'}