From notificationsclarson@example.org Tue Sep 01 03:04:30 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 90811 invoked from network); 1 Sep 2009 03:04:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 03:04:29 -0000 Received: (qmail 14733 invoked by uid 500); 1 Sep 2009 03:04:29 -0000 Delivered-To: clarson@example.org Received: (qmail 14661 invoked by uid 500); 1 Sep 2009 03:04:29 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 14649 invoked by uid 99); 1 Sep 2009 03:04:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 03:04:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 03:04:26 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 330EE23888CD; Tue, 1 Sep 2009 03:04:05 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809805 - in /ant/sandbox/antlibs/compress/trunk/src: main/org/apache/ant/compress/taskdefs/ tests/antunit/ Date: Tue, 01 Sep 2009 03:04:04 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 03:04:04 2009 New Revision: 809805 URL: http://svn.apache.org/viewvc?rev=809805&view=rev Log: <gzip> and <bzip2> can now wrap an archiving task Modified: ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/BZip2.java ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/GZip.java ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java ant/sandbox/antlibs/compress/trunk/src/tests/antunit/bzip2-test.xml ant/sandbox/antlibs/compress/trunk/src/tests/antunit/gzip-test.xml Modified: ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/BZip2.java URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/BZip2.java?rev=809805&r1=809804&r2=809805&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/BZip2.java (original) +++ ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/BZip2.java Tue Sep 1 03:04:04 2009 @@ -18,7 +18,10 @@ package org.apache.ant.compress.taskdefs; +import org.apache.ant.compress.resources.BZip2Resource; +import org.apache.ant.compress.resources.CommonsCompressCompressorResource; import org.apache.ant.compress.util.BZip2StreamFactory; +import org.apache.tools.ant.types.Resource; /** * Compresses using gzip. @@ -26,7 +29,12 @@ public final class BZip2 extends PackBase { public BZip2() { - super(new BZip2StreamFactory()); + super(new BZip2StreamFactory(), + new PackBase.ResourceWrapper() { + public CommonsCompressCompressorResource wrap(Resource dest) { + return new BZip2Resource(dest); + } + }); } } \ No newline at end of file Modified: ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/GZip.java URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/GZip.java?rev=809805&r1=809804&r2=809805&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/GZip.java (original) +++ ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/GZip.java Tue Sep 1 03:04:04 2009 @@ -18,7 +18,10 @@ package org.apache.ant.compress.taskdefs; +import org.apache.ant.compress.resources.CommonsCompressCompressorResource; +import org.apache.ant.compress.resources.GZipResource; import org.apache.ant.compress.util.GZipStreamFactory; +import org.apache.tools.ant.types.Resource; /** * Compresses using gzip. @@ -26,7 +29,12 @@ public final class GZip extends PackBase { public GZip() { - super(new GZipStreamFactory()); + super(new GZipStreamFactory(), + new PackBase.ResourceWrapper() { + public CommonsCompressCompressorResource wrap(Resource dest) { + return new GZipResource(dest); + } + }); } } \ No newline at end of file Modified: ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java?rev=809805&r1=809804&r2=809805&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java (original) +++ ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java Tue Sep 1 03:04:04 2009 @@ -25,6 +25,7 @@ import java.io.OutputStream; import java.util.Iterator; +import org.apache.ant.compress.resources.CommonsCompressCompressorResource; import org.apache.ant.compress.util.CompressorStreamFactory; import org.apache.commons.compress.utils.IOUtils; import org.apache.tools.ant.BuildException; @@ -43,12 +44,16 @@ private static final int BUFFER_SIZE = 8 * 1024; private final CompressorStreamFactory factory; + private final ResourceWrapper wrapper; private Resource src; + private ArchiveBase srcTask; private Resource dest; - protected PackBase(CompressorStreamFactory factory) { + protected PackBase(CompressorStreamFactory factory, + ResourceWrapper wrapper) { this.factory = factory; + this.wrapper = wrapper; } /** @@ -91,8 +96,8 @@ * @param src resource to expand */ public void setSrc(Resource src) { - if (this.src != null) { - throw new BuildException("Can only have one source resource."); + if (this.src != null || srcTask != null) { + throw new BuildException("Can only have one source."); } if (src.isDirectory()) { throw new BuildException("the source can't be a directory"); @@ -110,16 +115,24 @@ } } + public void add(ArchiveBase task) { + if (src != null || srcTask != null) { + throw new BuildException("Can only have one source."); + } + srcTask = task; + } + /** * validation routine * @throws BuildException if anything is invalid */ private void validate() throws BuildException { - if (src == null) { - throw new BuildException("source resource is required.", + if (src == null && srcTask == null) { + throw new BuildException("source is required.", getLocation()); } + if (src != null) { if (src.isDirectory()) { throw new BuildException("source resource must not " + "represent a directory!", getLocation()); @@ -128,6 +141,7 @@ if (!src.isExists()) { throw new BuildException("source resource must exist."); } + } if (dest == null) { throw new BuildException("dest resource is required.", @@ -148,6 +162,11 @@ public void execute() throws BuildException { validate(); + if (srcTask != null) { + srcTask.setDest(wrapper.wrap(dest)); + srcTask.setTaskName(getTaskName()); + srcTask.execute(); + } else if (dest.isExists() && dest.getLastModified() > src.getLastModified()) { log("Nothing to do: " + dest.getName() + " is up to date."); } else { @@ -176,4 +195,8 @@ FileUtils.close(out); } } + + public static interface ResourceWrapper { + CommonsCompressCompressorResource wrap(Resource dest); + } } Modified: ant/sandbox/antlibs/compress/trunk/src/tests/antunit/bzip2-test.xml URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/tests/antunit/bzip2-test.xml?rev=809805&r1=809804&r2=809805&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/src/tests/antunit/bzip2-test.xml (original) +++ ant/sandbox/antlibs/compress/trunk/src/tests/antunit/bzip2-test.xml Tue Sep 1 03:04:04 2009 @@ -17,6 +17,7 @@ --> <project default="antunit" xmlns:au="antlib:org.apache.ant.antunit" + xmlns:cond="antlib:org.apache.tools.ant.types.conditions" xmlns:cmp="antlib:org.apache.ant.compress"> <import file="antunit-base.xml" /> @@ -29,7 +30,7 @@ </target> <target name="testFailNone" depends="setUp"> - <au:expectfailure expectedmessage="source resource is required."> + <au:expectfailure expectedmessage="source is required."> <cmp:bzip2 destfile="${output}/file.bz2"> <fileset dir="${output}/empty" /> </cmp:bzip2> @@ -37,7 +38,7 @@ </target> <target name="testFailTwo" depends="setUp"> - <au:expectfailure expectedmessage="Can only have one source resource."> + <au:expectfailure expectedmessage="Can only have one source."> <cmp:bzip2 destfile="${output}/file.bz2"> <fileset dir="${output}" /> </cmp:bzip2> @@ -95,4 +96,24 @@ <au:assertFileExists file="${output}/asf-logo-huge.tar.bz2"/> </target> + <target name="testNestedTask" depends="setUp"> + <cmp:bzip2 destfile="${output}/asf-logo.tar.bz2"> + <cmp:tar> + <cmp:cpiofileset src="../resources/asf-logo.gif.cpio" + includes="asf-logo.gif"/> + </cmp:tar> + </cmp:bzip2> + <au:assertFileExists file="${output}/asf-logo.tar.bz2"/> + <au:assertTrue> + <cond:islastmodified datetime="2009-07-31-20:11:13 +0200" + pattern="yyyy-MM-dd-HH:mm:ss Z"> + <cmp:tarentry name="asf-logo.gif"> + <bzip2resource> + <file file="${output}/asf-logo.tar.bz2"/> + </bzip2resource> + </cmp:tarentry> + </cond:islastmodified> + </au:assertTrue> + </target> + </project> Modified: ant/sandbox/antlibs/compress/trunk/src/tests/antunit/gzip-test.xml URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/tests/antunit/gzip-test.xml?rev=809805&r1=809804&r2=809805&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/src/tests/antunit/gzip-test.xml (original) +++ ant/sandbox/antlibs/compress/trunk/src/tests/antunit/gzip-test.xml Tue Sep 1 03:04:04 2009 @@ -17,6 +17,7 @@ --> <project default="antunit" xmlns:au="antlib:org.apache.ant.antunit" + xmlns:cond="antlib:org.apache.tools.ant.types.conditions" xmlns:cmp="antlib:org.apache.ant.compress"> <import file="antunit-base.xml" /> @@ -29,7 +30,7 @@ </target> <target name="testFailNone" depends="setUp"> - <au:expectfailure expectedmessage="source resource is required."> + <au:expectfailure expectedmessage="source is required."> <cmp:gzip destfile="${output}/file.gz"> <fileset dir="${output}/empty" /> </cmp:gzip> @@ -37,7 +38,7 @@ </target> <target name="testFailTwo" depends="setUp"> - <au:expectfailure expectedmessage="Can only have one source resource."> + <au:expectfailure expectedmessage="Can only have one source."> <cmp:gzip destfile="${output}/file.gz"> <fileset dir="${output}" /> </cmp:gzip> @@ -85,4 +86,24 @@ destfile="${output}/asf-logo.gif.gz" /> <au:assertLogContains text="Nothing to do: asf-logo.gif.gz is up to date."/> </target> + + <target name="testNestedTask" depends="setUp"> + <cmp:gzip destfile="${output}/asf-logo.tar.gz"> + <cmp:tar> + <cmp:cpiofileset src="../resources/asf-logo.gif.cpio" + includes="asf-logo.gif"/> + </cmp:tar> + </cmp:gzip> + <au:assertFileExists file="${output}/asf-logo.tar.gz"/> + <au:assertTrue> + <cond:islastmodified datetime="2009-07-31-20:11:13 +0200" + pattern="yyyy-MM-dd-HH:mm:ss Z"> + <cmp:tarentry name="asf-logo.gif"> + <gzipresource> + <file file="${output}/asf-logo.tar.gz"/> + </gzipresource> + </cmp:tarentry> + </cond:islastmodified> + </au:assertTrue> + </target> </project> From notificationsclarson@example.org Tue Sep 01 03:06:51 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 91228 invoked from network); 1 Sep 2009 03:06:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 03:06:51 -0000 Received: (qmail 15492 invoked by uid 500); 1 Sep 2009 03:06:51 -0000 Delivered-To: clarson@example.org Received: (qmail 15430 invoked by uid 500); 1 Sep 2009 03:06:51 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 15421 invoked by uid 99); 1 Sep 2009 03:06:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 03:06:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 03:06:48 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6A50423888CD; Tue, 1 Sep 2009 03:06:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809806 - /ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java Date: Tue, 01 Sep 2009 03:06:27 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 03:06:26 2009 New Revision: 809806 URL: http://svn.apache.org/viewvc?rev=809806&view=rev Log: whitespace Modified: ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java Modified: ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java?rev=809806&r1=809805&r2=809806&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java (original) +++ ant/sandbox/antlibs/compress/trunk/src/main/org/apache/ant/compress/taskdefs/PackBase.java Tue Sep 1 03:06:26 2009 @@ -133,14 +133,15 @@ } if (src != null) { - if (src.isDirectory()) { - throw new BuildException("source resource must not " - + "represent a directory!", getLocation()); - } - - if (!src.isExists()) { - throw new BuildException("source resource must exist."); - } + if (src.isDirectory()) { + throw new BuildException("source resource must not " + + "represent a directory!", + getLocation()); + } + + if (!src.isExists()) { + throw new BuildException("source resource must exist."); + } } if (dest == null) { @@ -166,8 +167,8 @@ srcTask.setDest(wrapper.wrap(dest)); srcTask.setTaskName(getTaskName()); srcTask.execute(); - } else - if (dest.isExists() && dest.getLastModified() > src.getLastModified()) { + } else if (dest.isExists() + && dest.getLastModified() > src.getLastModified()) { log("Nothing to do: " + dest.getName() + " is up to date."); } else { log("Building: " + dest.getName()); From notificationsclarson@example.org Tue Sep 01 03:48:56 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 98596 invoked from network); 1 Sep 2009 03:48:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 03:48:56 -0000 Received: (qmail 26781 invoked by uid 500); 1 Sep 2009 03:48:56 -0000 Delivered-To: clarson@example.org Received: (qmail 26707 invoked by uid 500); 1 Sep 2009 03:48:55 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 26698 invoked by uid 99); 1 Sep 2009 03:48:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 03:48:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 03:48:52 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id A8F4423888CD; Tue, 1 Sep 2009 03:48:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: svn commit: r809810 - /ant/sandbox/antlibs/compress/trunk/contributors.xml Date: Tue, 01 Sep 2009 03:48:30 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 03:48:29 2009 New Revision: 809810 URL: http://svn.apache.org/viewvc?rev=809810&view=rev Log: track down people who contributed to the core classes that built the base for this antlib Modified: ant/sandbox/antlibs/compress/trunk/contributors.xml Modified: ant/sandbox/antlibs/compress/trunk/contributors.xml URL: http://svn.apache.org/viewvc/ant/sandbox/antlibs/compress/trunk/contributors.xml?rev=809810&r1=809809&r2=809810&view=diff ============================================================================== --- ant/sandbox/antlibs/compress/trunk/contributors.xml (original) +++ ant/sandbox/antlibs/compress/trunk/contributors.xml Tue Sep 1 03:48:29 2009 @@ -31,7 +31,189 @@ These are some of the many people who have helped with this Ant Library. </introduction> <name> + <first>Alex</first> + <last>Rosen</last> + </name> + <name> + <first>Antoine</first> + <last>Levy-Lambert</last> + </name> + <name> + <first>Arnout</first> + <middle>J.</middle> + <last>Kuiper</last> + </name> + <name> + <first>Bart</first> + <last>Vanhaute</last> + </name> + <name> + <first>Brian</first> + <last>Deitte</last> + </name> + <name> + <first>Conor</first> + <last>MacNeill</last> + </name> + <name> + <first>Curt</first> + <last>Arnold</last> + </name> + <name> + <first>Dale</first> + <last>Sherwood</last> + </name> + <name> + <first>David</first> + <last>Rees</last> + </name> + <name> + <first>Don</first> + <last>Ferguson</last> + </name> + <name> + <first>Erik</first> + <last>Hatcher</last> + </name> + <name> + <first>Glenn</first> + <last>McAllister</last> + </name> + <name> + <first>Holger</first> + <last>Joest</last> + </name> + <name> + <first>James</first> + <middle>Duncan</middle> + <last>Davidson</last> + </name> + <name> + <first>Jan</first> + <last>Matèrne</last> + </name> + <name> + <first>Jason</first> + <last>Salter</last> + </name> + <name> + <first>Jeff</first> + <last>Martin</last> + </name> + <name> + <first>Jesse</first> + <last>Glick</last> + </name> + <name> + <first>Jon</first> + <last>Skeet</last> + </name> + <name> + <first>Jörg</first> + <last>Wassmer</last> + </name> + <name> + <first>Keiron</first> + <last>Liddle</last> + </name> + <name> + <first>Kevin</first> + <last>Jackson</last> + </name> + <name> + <first>Larry</first> + <last>Shatzer</last> + </name> + <name> + <first>Magesh</first> + <last>Umasankar</last> + </name> + <name> + <first>Martijn</first> + <last>Kruithof</last> + </name> + <name> + <first>Matt</first> + <last>Benson</last> + </name> + <name> + <first>Nico</first> + <last>Seessle</last> + </name> + <name> + <first>Pavan</first> + <last>Bayyapu</last> + </name> + <name> + <first>Peter</first> + <last>Donald</last> + </name> + <name> + <first>Peter</first> + <last>Janes</last> + </name> + <name> + <first>Peter</first> + <last>Reilly</last> + </name> + <name> + <first>Phil</first> + <last>Hanna</last> + </name> + <name> + <first>Remie</first> + <last>Bolte</last> + </name> + <name> + <first>Richard</first> + <last>Evans</last> + </name> + <name> + <first>Robert</first> + <last>Stupp</last> + </name> + <name> + <first>Sam</first> + <last>Ruby</last> + </name> + <name> + <first>Simone</first> + <last>Bordet</last> + </name> + <name> <first>Stefan</first> <last>Bodewig</last> </name> + <name> + <first>Stefan</first> + <last>Heimann</last> + </name> + <name> + <first>Stefano</first> + <last>Mazzocchi</last> + </name> + <name> + <first>Stephane</first> + <last>Bailliez</last> + </name> + <name> + <first>Steve</first> + <last>Langley</last> + </name> + <name> + <first>Steve</first> + <last>Loughran</last> + </name> + <name> + <first>Takashi</first> + <last>Okamoto</last> + </name> + <name> + <first>Thomas</first> + <last>Aglassinger</last> + </name> + <name> + <first>William</first> + <last>Webber</last> + </name> </contributors> From notificationsclarson@example.org Tue Sep 01 07:28:52 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 75469 invoked from network); 1 Sep 2009 07:28:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 07:28:52 -0000 Received: (qmail 72962 invoked by uid 500); 1 Sep 2009 07:28:52 -0000 Delivered-To: clarson@example.org Received: (qmail 72911 invoked by uid 500); 1 Sep 2009 07:28:52 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 72902 invoked by uid 99); 1 Sep 2009 07:28:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 07:28:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 07:28:49 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 522142388907; Tue, 1 Sep 2009 07:28:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809863 - in /ant/core/trunk: CONTRIBUTORS contributors.xml Date: Tue, 01 Sep 2009 07:28:28 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 07:28:27 2009 New Revision: 809863 URL: http://svn.apache.org/viewvc?rev=809863&view=rev Log: A few people I found while researching the compress code origins Modified: ant/core/trunk/CONTRIBUTORS ant/core/trunk/contributors.xml Modified: ant/core/trunk/CONTRIBUTORS URL: http://svn.apache.org/viewvc/ant/core/trunk/CONTRIBUTORS?rev=809863&r1=809862&r2=809863&view=diff ============================================================================== Binary files - no diff available. Modified: ant/core/trunk/contributors.xml URL: http://svn.apache.org/viewvc/ant/core/trunk/contributors.xml?rev=809863&r1=809862&r2=809863&view=diff ============================================================================== --- ant/core/trunk/contributors.xml (original) +++ ant/core/trunk/contributors.xml Tue Sep 1 07:28:27 2009 @@ -47,6 +47,10 @@ <last>Ishutin</last> </name> <name> + <first>Alex</first> + <last>Rosen</last> + </name> + <name> <first>Alexei</first> <last>Yudichev</last> </name> @@ -133,6 +137,10 @@ <last>Fejes 2</last> </name> <name> + <first>Bart</first> + <last>Vanhaute</last> + </name> + <name> <first>Benjamin</first> <last>Burgess</last> </name> @@ -244,6 +252,10 @@ <last>Sandvik</last> </name> <name> + <first>Curt</first> + <last>Arnold</last> + </name> + <name> <first>Curtis</first> <last>White</last> </name> @@ -260,6 +272,10 @@ <last>Anson</last> </name> <name> + <first>Dale</first> + <last>Sherwood</last> + </name> + <name> <first>Dan</first> <last>Armbrust</last> </name> @@ -511,6 +527,10 @@ <last>Engels</last> </name> <name> + <first>Holger</first> + <last>Joest</last> + </name> + <name> <first>Ignacio</first> <last>Coloma</last> </name> @@ -659,6 +679,10 @@ </name> <name> <first>Jon</first> + <last>Skeet</last> + </name> + <name> + <first>Jon</first> <middle>S.</middle> <last>Stevens</last> </name> @@ -978,6 +1002,10 @@ <last>Gaspar</last> </name> <name> + <first>Pavan</first> + <last>Bayyapu</last> + </name> + <name> <first>Pavel</first> <last>Jisl</last> </name> @@ -1004,9 +1032,17 @@ </name> <name> <first>Peter</first> + <last>Janes</last> + </name> + <name> + <first>Peter</first> <last>Reilly</last> </name> <name> + <first>Phil</first> + <last>Hanna</last> + </name> + <name> <first>Philip</first> <last>Hourihane</last> </name> @@ -1169,10 +1205,18 @@ <last>Law</last> </name> <name> + <first>Simone</first> + <last>Bordet</last> + </name> + <name> <first>Stefan</first> <last>Bodewig</last> </name> <name> + <first>Stefan</first> + <last>Heimann</last> + </name> + <name> <first>Stefano</first> <last>Mazzocchi</last> </name> @@ -1201,6 +1245,10 @@ </name> <name> <first>Steve</first> + <last>Langley</last> + </name> + <name> + <first>Steve</first> <last>Loughran</last> </name> <name> @@ -1322,6 +1370,10 @@ <last>Ferguson</last> </name> <name> + <first>William</first> + <last>Webber</last> + </name> + <name> <first>Wolf</first> <last>Siberski</last> </name> From notificationsclarson@example.org Tue Sep 01 07:30:05 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 75890 invoked from network); 1 Sep 2009 07:30:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 07:30:05 -0000 Received: (qmail 74944 invoked by uid 500); 1 Sep 2009 07:30:05 -0000 Delivered-To: clarson@example.org Received: (qmail 74924 invoked by uid 500); 1 Sep 2009 07:30:05 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 74915 invoked by uid 99); 1 Sep 2009 07:30:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 07:30:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO vmgump.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 07:30:03 +0000 Received: from [83.161.120.155] (localhost [83.161.120.155]) by vmgump.apache.org (Postfix) with ESMTP id B0B29AB42F8 for <clarson@example.org>; Tue, 1 Sep 2009 00:29:42 -0700 (PDT) Date: Tue, 01 Sep 2009 00:29:42 PDT From: Gump Integration Build <clarson@example.org> To: clarson@example.org Subject: [GUMP@vmgump]: Project test-ant-no-xerces (in module ant) failed Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at clarson@example.org. Project test-ant-no-xerces has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - test-ant-no-xerces : Java based build tool Full details are available at: http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/gump_work/build_ant_test-ant-no-xerces.html Work Name: build_ant_test-ant-no-xerces (Type: Build) Work ended in a state of : Failed Elapsed: 17 mins 2 secs Command Line: /usr/lib/jvm/java-6-sun/bin/java -Djava.awt.headless=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dtest.haltonfailure=false -Dant.home=/srv/gump/public/workspace/ant/dist run-tests [Working Directory: /srv/gump/public/workspace/ant] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/ant/build/testcases:/srv/gump/public/workspace/ant/src/tests/junit:/srv/gump/public/workspace/ant/src/etc/testcases:/srv/gump/public/workspace/ant/src/etc/testcases/taskdefs/optional/out:/srv/gump/public/workspace/ant/build/lib/ant-stylebook.jar:/srv/gump/public/workspace/ant/build/lib/ant-swing.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/build/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-regexp.jar:/srv/gump/public/workspace/ant/build/lib/ant-commons-net.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-log4j.jar:/srv/gump/public/workspace/ant/build/lib/ant-commons-logging.jar:/srv/gump/public/workspace/ant/build/lib/ant-jai.jar:/srv/gump/public/workspace/ant/build/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/build/lib/ant-launcher.jar:/srv/gump/publ ic/workspace/ant/build/lib/ant-jdepend.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-bsf.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-oro.jar:/srv/gump/public/workspace/ant/build/lib/ant-apache-bcel.jar:/srv/gump/public/workspace/ant/build/lib/ant-trax.jar:/srv/gump/public/workspace/ant/build/lib/ant-antlr.jar:/srv/gump/public/workspace/ant/build/lib/ant-junit.jar:/srv/gump/public/workspace/ant/build/lib/ant-jsch.jar:/srv/gump/public/workspace/ant/build/lib/ant-javamail.jar:/srv/gump/public/workspace/ant/build/lib/ant.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-31082009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-31082009.jar:/srv/gump/public/workspace/apache-commons/net/dist/commons-net-31082009.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/jakarta-bcel/target/bcel-5.3-SNAPSHOT.jar:/srv/gump/public/workspace/jakarta -bsf/build/lib/bsf.jar:/srv/gump/public/workspace/logging-log4j-12/dist/lib/log4j-31082009.jar:/srv/gump/public/workspace/jakarta-oro/jakarta-oro-31082009.jar:/srv/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-31082009.jar:/srv/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jdepend-2.6/lib/jdepend.jar:/srv/gump/packages/jsch/jsch-0.1.38.jar:/srv/gump/public/workspace/xml-stylebook/bin/stylebook-1.0-b3_xalan-2.jar:/srv/gump/public/workspace/ant-antlibs/antunit/build/ant-antunit-31082009.jar:/srv/gump/public/workspace/junit/dist/junit-31082009.jar:/srv/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-compiler.jar:/srv/gump/public/workspace/jakarta-tomcat-4.0/dist/common/lib/jasper-runtime.jar:/srv/gump/public/workspace/xml-commons/java/build/which.jar:/srv/gump/public/workspace/rhino/build/rhino_31082009/js.jar:/srv/gump/packages/bs h-2.0b4/bsh-commands-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-classpath-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-core-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-bsf-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-reflect-2.0b4.jar:/srv/gump/packages/bsh-2.0b4/bsh-util-2.0b4.jar:/srv/gump/public/workspace/apache-commons/codec/dist/commons-codec-31082009.jar --------------------------------------------- [au:antunit] Target: testpath took 0.026 sec [au:antunit] Target: testfilelist took 0.011 sec [au:antunit] Target: testpropertyset took 0.018 sec [au:antunit] Target: testintersect took 0.054 sec [au:antunit] Target: testzipfileset took 0.047 sec [au:antunit] Target: testfileurl took 0.021 sec [au:antunit] Target: testdifference took 0.045 sec [au:antunit] Target: testfile took 0.015 sec [au:antunit] Target: testjarurl took 0.049 sec [au:antunit] Build File: /srv/gump/public/workspace/ant/src/tests/antunit/types/resources/tokens-test.xml [au:antunit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.058 sec [au:antunit] Target: testSort took 0.002 sec [au:antunit] Target: testEncoding took 0.005 sec [au:antunit] Target: testFileTokenizer took 0.005 sec [au:antunit] Target: testLines took 0.003 sec [au:antunit] Target: testStringTokenizer took 0.001 sec [au:antunit] Target: testExplicitLines took 0.001 sec [au:antunit] Build File: /srv/gump/public/workspace/ant/src/tests/antunit/types/selectors/filename-test.xml [au:antunit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.078 sec [au:antunit] Target: testRegex took 0.003 sec [au:antunit] Target: testPattern took 0.002 sec [au:antunit] Build File: /srv/gump/public/workspace/ant/src/tests/antunit/types/selectors/modified-test.xml [au:antunit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.033 sec [au:antunit] Target: testUpdate took 0.027 sec [au:antunit] Build File: /srv/gump/public/workspace/ant/src/tests/antunit/types/selectors/readwrite-test.xml [au:antunit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 1.04 sec [au:antunit] Target: testWritable took 0.003 sec [au:antunit] Target: testAsConditions took 0.477 sec [au:antunit] Target: testReadable took 0.003 sec [au:antunit] Target: testUnwritable took 0.379 sec [au:antunit] Build File: /srv/gump/public/workspace/ant/src/tests/antunit/types/tarfileset-test.xml [au:antunit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.092 sec [au:antunit] Target: testMissingArchive took 0.004 sec [au:antunit] Target: testMissingArchiveDoesntMatter took 0.001 sec [au:antunit] Build File: /srv/gump/public/workspace/ant/src/tests/antunit/types/zipfileset-test.xml [au:antunit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.274 sec [au:antunit] Target: testMissingArchive took 0.002 sec [au:antunit] Target: test-refid-check-encoding took 0.004 sec [au:antunit] Target: test-refid-modify took 0.049 sec [au:antunit] Target: test-refid-check-prefix took 0.001 sec [au:antunit] Target: testMissingArchiveDoesntMatter took 0.001 sec check-failed: run-tests: BUILD FAILED /srv/gump/public/workspace/ant/build.xml:1547: Unit tests failed Total time: 17 minutes 1 second --------------------------------------------- To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/rss.xml - Atom: http://vmgump.apache.org/gump/public/ant/test-ant-no-xerces/atom.xml ============================== Gump Tracking Only === Produced by Gump version 2.3. Gump Run 14001631082009, vmgump:vmgump-public:14001631082009 Gump E-mail Identifier (unique within run) #30. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] From notificationsclarson@example.org Tue Sep 01 09:04:06 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 95341 invoked from network); 1 Sep 2009 09:04:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 09:04:06 -0000 Received: (qmail 89440 invoked by uid 500); 1 Sep 2009 09:04:06 -0000 Delivered-To: clarson@example.org Received: (qmail 89377 invoked by uid 500); 1 Sep 2009 09:04:06 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 89367 invoked by uid 99); 1 Sep 2009 09:04:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 09:04:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 09:04:02 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 9A250234C046; Tue, 1 Sep 2009 02:03:42 -0700 (PDT) From: clarson@example.org To: clarson@example.org Subject: DO NOT REPLY [Bug 47666] XMLJUnitResultFormatter can output illegal XML characters X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Optional Tasks X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: clarson@example.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: clarson@example.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution In-Reply-To: <clarson@example.org/bugzilla/> References: <clarson@example.org/bugzilla/> X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <clarson@example.org> Date: Tue, 1 Sep 2009 02:03:42 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=47666 Stefan Bodewig <clarson@example.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED Resolution| |WORKSFORME -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From notificationsclarson@example.org Tue Sep 01 09:04:23 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 95426 invoked from network); 1 Sep 2009 09:04:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 09:04:23 -0000 Received: (qmail 89999 invoked by uid 500); 1 Sep 2009 09:04:23 -0000 Delivered-To: clarson@example.org Received: (qmail 89929 invoked by uid 500); 1 Sep 2009 09:04:23 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 89920 invoked by uid 99); 1 Sep 2009 09:04:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 09:04:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 09:04:21 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 41A5C234C055; Tue, 1 Sep 2009 02:04:01 -0700 (PDT) From: clarson@example.org To: clarson@example.org Subject: DO NOT REPLY [Bug 47764] Path class missing references to 'id' attribute. X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Core X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: clarson@example.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: clarson@example.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution In-Reply-To: <clarson@example.org/bugzilla/> References: <clarson@example.org/bugzilla/> X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <clarson@example.org> Date: Tue, 1 Sep 2009 02:04:01 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=47764 Stefan Bodewig <clarson@example.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From notificationsclarson@example.org Tue Sep 01 09:09:52 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 96957 invoked from network); 1 Sep 2009 09:09:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 09:09:51 -0000 Received: (qmail 2666 invoked by uid 500); 1 Sep 2009 09:09:51 -0000 Delivered-To: clarson@example.org Received: (qmail 2597 invoked by uid 500); 1 Sep 2009 09:09:51 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 2588 invoked by uid 99); 1 Sep 2009 09:09:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 09:09:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 09:09:48 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id A9535234C046; Tue, 1 Sep 2009 02:09:27 -0700 (PDT) From: clarson@example.org To: clarson@example.org Subject: DO NOT REPLY [Bug 16726] External FilterReaders don't get chain()ed X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Core X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: clarson@example.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: clarson@example.org X-Bugzilla-Target-Milestone: 1.7.0 X-Bugzilla-Changed-Fields: Status Resolution Target Milestone In-Reply-To: <clarson@example.org/bugzilla/> References: <clarson@example.org/bugzilla/> X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <clarson@example.org> Date: Tue, 1 Sep 2009 02:09:27 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=16726 Stefan Bodewig <clarson@example.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX Target Milestone|--- |1.7.0 --- Comment #5 from Stefan Bodewig <clarson@example.org> 2009-09-01 02:09:24 PDT --- I think this is solved in the meantime by using componentdef to create named filterreaders and having them work the same way as the built-in ones. I'm closing this as WONTFIX as it is extremely unlikely anybody is going to touch it after more than six years - and the problem can be solved in 1.7.x in a more elegant way. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From notificationsclarson@example.org Tue Sep 01 10:19:37 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 19348 invoked from network); 1 Sep 2009 10:19:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 10:19:37 -0000 Received: (qmail 93988 invoked by uid 500); 1 Sep 2009 10:19:37 -0000 Delivered-To: clarson@example.org Received: (qmail 93947 invoked by uid 500); 1 Sep 2009 10:19:37 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 93938 invoked by uid 99); 1 Sep 2009 10:19:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 10:19:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 10:19:35 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id B300C2388904; Tue, 1 Sep 2009 10:19:15 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809955 - /ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java Date: Tue, 01 Sep 2009 10:19:15 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 10:19:15 2009 New Revision: 809955 URL: http://svn.apache.org/viewvc?rev=809955&view=rev Log: wrong classname Modified: ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java?rev=809955&r1=809954&r2=809955&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/PropertyHelper.java Tue Sep 1 10:19:15 2009 @@ -161,7 +161,7 @@ // CheckStyle:LineLengthCheck OFF see too long /** * {@inheritDoc} - * @see org.apache.tools.ant.PropertyHelper.PropertyExpander#parsePropertyName(java.lang.String, java.text.ParsePosition, org.apache.tools.ant.PropertyHelper) + * @see org.apache.tools.ant.property.PropertyExpander#parsePropertyName(java.lang.String, java.text.ParsePosition, org.apache.tools.ant.PropertyHelper) */ // CheckStyle:LineLengthCheck ON public String parsePropertyName( From notificationsclarson@example.org Tue Sep 01 10:20:07 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 19449 invoked from network); 1 Sep 2009 10:20:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 10:20:07 -0000 Received: (qmail 94382 invoked by uid 500); 1 Sep 2009 10:20:07 -0000 Delivered-To: clarson@example.org Received: (qmail 94322 invoked by uid 500); 1 Sep 2009 10:20:07 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 94313 invoked by uid 99); 1 Sep 2009 10:20:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 10:20:07 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 10:20:04 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6DB3023888DC; Tue, 1 Sep 2009 10:19:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809956 - /ant/core/trunk/src/tests/antunit/propertyhelpers.xml Date: Tue, 01 Sep 2009 10:19:43 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 10:19:43 2009 New Revision: 809956 URL: http://svn.apache.org/viewvc?rev=809956&view=rev Log: simplify propertyhelper usage Modified: ant/core/trunk/src/tests/antunit/propertyhelpers.xml Modified: ant/core/trunk/src/tests/antunit/propertyhelpers.xml URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/propertyhelpers.xml?rev=809956&r1=809955&r2=809956&view=diff ============================================================================== --- ant/core/trunk/src/tests/antunit/propertyhelpers.xml (original) +++ ant/core/trunk/src/tests/antunit/propertyhelpers.xml Tue Sep 1 10:19:43 2009 @@ -73,19 +73,17 @@ </target> <target name="defineHelpers" depends="compileHelpers"> - <typedef name="urlhelper" + <componentdef name="urlhelper" classname="org.apache.ant.propertyhelper.URLHelper"> <classpath location="${propout}"/> - </typedef> - <urlhelper id="url"/> - <typedef name="javahelper" + </componentdef> + <componentdef name="javahelper" classname="org.apache.ant.propertyhelper.JavaHelper"> <classpath location="${propout}"/> - </typedef> - <javahelper id="java"/> + </componentdef> <propertyhelper> - <delegate refid="url"/> - <delegate refid="java"/> + <urlhelper/> + <javahelper/> </propertyhelper> </target> From notificationsclarson@example.org Tue Sep 01 11:28:48 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 34707 invoked from network); 1 Sep 2009 11:28:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 11:28:48 -0000 Received: (qmail 66047 invoked by uid 500); 1 Sep 2009 11:28:48 -0000 Delivered-To: clarson@example.org Received: (qmail 65991 invoked by uid 500); 1 Sep 2009 11:28:48 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 65982 invoked by uid 99); 1 Sep 2009 11:28:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 11:28:48 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 11:28:45 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 129C92388904; Tue, 1 Sep 2009 11:28:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809976 - in /ant/core/trunk/src: etc/testcases/core/unknownelement.xml tests/junit/org/apache/tools/ant/UnknownElementTest.java Date: Tue, 01 Sep 2009 11:28:23 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 11:28:23 2009 New Revision: 809976 URL: http://svn.apache.org/viewvc?rev=809976&view=rev Log: failing test for PR 26917, not sure whether this is a bug Modified: ant/core/trunk/src/etc/testcases/core/unknownelement.xml ant/core/trunk/src/tests/junit/org/apache/tools/ant/UnknownElementTest.java Modified: ant/core/trunk/src/etc/testcases/core/unknownelement.xml URL: http://svn.apache.org/viewvc/ant/core/trunk/src/etc/testcases/core/unknownelement.xml?rev=809976&r1=809975&r2=809976&view=diff ============================================================================== --- ant/core/trunk/src/etc/testcases/core/unknownelement.xml (original) +++ ant/core/trunk/src/etc/testcases/core/unknownelement.xml Tue Sep 1 11:28:23 2009 @@ -33,4 +33,7 @@ <child/> </parent> </target> + <target name="echo"> + <echo message="Hello, world!"/> + </target> </project> Modified: ant/core/trunk/src/tests/junit/org/apache/tools/ant/UnknownElementTest.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/junit/org/apache/tools/ant/UnknownElementTest.java?rev=809976&r1=809975&r2=809976&view=diff ============================================================================== --- ant/core/trunk/src/tests/junit/org/apache/tools/ant/UnknownElementTest.java (original) +++ ant/core/trunk/src/tests/junit/org/apache/tools/ant/UnknownElementTest.java Tue Sep 1 11:28:23 2009 @@ -22,7 +22,6 @@ import java.util.Iterator; import java.util.List; - public class UnknownElementTest extends BuildFileTest { public void setUp() { configureProject("src/etc/testcases/core/unknownelement.xml"); @@ -32,6 +31,36 @@ executeTarget("testMaybeConfigure"); } + /** + * Not really a UnknownElement test but rather one of "what + * information is available in taskFinished". + * @see https://issues.apache.org/bugzilla/show_bug.cgi?id=26197 + */ + public void XtestTaskFinishedEvent() { + getProject().addBuildListener(new BuildListener() { + public void buildStarted(BuildEvent event) {} + public void buildFinished(BuildEvent event) {} + public void targetStarted(BuildEvent event) {} + public void targetFinished(BuildEvent event) {} + public void taskStarted(BuildEvent event) { + assertTaskProperties(event.getTask()); + } + public void taskFinished(BuildEvent event) { + assertTaskProperties(event.getTask()); + } + public void messageLogged(BuildEvent event) {} + private void assertTaskProperties(Task ue) { + assertNotNull(ue); + assertTrue(ue instanceof UnknownElement); + Task t = ((UnknownElement) ue).getTask(); + assertNotNull(t); + assertEquals("org.apache.tools.ant.taskdefs.Echo", + t.getClass().getName()); + } + }); + executeTarget("echo"); + } + public static class Child extends Task { Parent parent; public void injectParent(Parent parent) { @@ -51,7 +80,7 @@ public void fromChild() { log("fromchild"); } - + public void execute() { for (Iterator i = children.iterator(); i.hasNext();) { UnknownElement el = (UnknownElement) i.next(); From notificationsclarson@example.org Tue Sep 01 11:55:32 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 43814 invoked from network); 1 Sep 2009 11:55:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 11:55:32 -0000 Received: (qmail 97527 invoked by uid 500); 1 Sep 2009 11:55:32 -0000 Delivered-To: clarson@example.org Received: (qmail 97471 invoked by uid 500); 1 Sep 2009 11:55:31 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 97424 invoked by uid 99); 1 Sep 2009 11:55:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 11:55:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 11:55:30 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 28E0623888E6; Tue, 1 Sep 2009 11:55:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r809987 - /ant/core/trunk/lib/libraries.properties Date: Tue, 01 Sep 2009 11:55:10 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 11:55:09 2009 New Revision: 809987 URL: http://svn.apache.org/viewvc?rev=809987&view=rev Log: upgrade jsch dependency Modified: ant/core/trunk/lib/libraries.properties Modified: ant/core/trunk/lib/libraries.properties URL: http://svn.apache.org/viewvc/ant/core/trunk/lib/libraries.properties?rev=809987&r1=809986&r2=809987&view=diff ============================================================================== --- ant/core/trunk/lib/libraries.properties (original) +++ ant/core/trunk/lib/libraries.properties Tue Sep 1 11:55:09 2009 @@ -42,7 +42,7 @@ jdepend.version=2.9.1 jruby.version=0.9.8 junit.version=3.8.2 -jsch.version=0.1.29 +jsch.version=0.1.42 jython.version=2.1 #log4j 1.2.15 requires JMS and a few other Sun jars that are not in the m2 repo log4j.version=1.2.14 From notificationsclarson@example.org Tue Sep 01 12:05:10 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 47217 invoked from network); 1 Sep 2009 12:05:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 12:05:09 -0000 Received: (qmail 7522 invoked by uid 500); 1 Sep 2009 12:05:09 -0000 Delivered-To: clarson@example.org Received: (qmail 7453 invoked by uid 500); 1 Sep 2009 12:05:09 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 7444 invoked by uid 99); 1 Sep 2009 12:05:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 12:05:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 12:05:06 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id C9AA3234C046; Tue, 1 Sep 2009 05:04:45 -0700 (PDT) From: clarson@example.org To: clarson@example.org Subject: DO NOT REPLY [Bug 40184] [PATCH] Move property expansion from Property and MacroInstance to the PropertyHelper class X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Core X-Bugzilla-Keywords: PatchAvailable X-Bugzilla-Severity: enhancement X-Bugzilla-Who: clarson@example.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: clarson@example.org X-Bugzilla-Target-Milestone: 1.8.0 X-Bugzilla-Changed-Fields: Status Resolution Target Milestone In-Reply-To: <{{EMAIL+PHONE}}/bugzilla/> References: <{{EMAIL+PHONE}}/bugzilla/> X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <clarson@example.org> Date: Tue, 1 Sep 2009 05:04:45 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=40184 Stefan Bodewig <clarson@example.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED Target Milestone|--- |1.8.0 --- Comment #4 from Stefan Bodewig <clarson@example.org> 2009-09-01 05:04:40 PDT --- Property#resolveAllProperties uses PropertyHelper by now (svn revision 578769 ) while the PropertyHelper logic has been modified strong enough to keep the MacroInstance code separate (we most likely do not want to use the same logic for macro attribute expansions as for property expansions). Using FIXED; but WONTFIX or "INVALID by now" would be as good as resolution types. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From notificationsclarson@example.org Tue Sep 01 12:28:45 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 58860 invoked from network); 1 Sep 2009 12:28:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 12:28:45 -0000 Received: (qmail 38107 invoked by uid 500); 1 Sep 2009 12:28:45 -0000 Delivered-To: clarson@example.org Received: (qmail 38076 invoked by uid 500); 1 Sep 2009 12:28:45 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 38067 invoked by uid 99); 1 Sep 2009 12:28:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 12:28:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 12:28:44 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id D05F1234C055; Tue, 1 Sep 2009 05:28:23 -0700 (PDT) From: clarson@example.org To: clarson@example.org Subject: DO NOT REPLY [Bug 41356] Output all checksums to single file X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Core tasks X-Bugzilla-Keywords: PatchAvailable X-Bugzilla-Severity: enhancement X-Bugzilla-Who: clarson@example.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: clarson@example.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: In-Reply-To: <{{EMAIL+PHONE}}/bugzilla/> References: <{{EMAIL+PHONE}}/bugzilla/> X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <clarson@example.org> Date: Tue, 1 Sep 2009 05:28:23 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=41356 --- Comment #2 from Stefan Bodewig <clarson@example.org> 2009-09-01 05:28:22 PDT --- well, using checksum as a condition and things like totalproperty/verifyproperty make things quite a bit more complex. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From notificationsclarson@example.org Tue Sep 01 13:26:55 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 77518 invoked from network); 1 Sep 2009 13:26:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 13:26:55 -0000 Received: (qmail 28266 invoked by uid 500); 1 Sep 2009 13:26:55 -0000 Delivered-To: clarson@example.org Received: (qmail 28236 invoked by uid 500); 1 Sep 2009 13:26:55 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 28226 invoked by uid 99); 1 Sep 2009 13:26:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 13:26:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 13:26:52 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 35C7323888E6; Tue, 1 Sep 2009 13:26:31 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r810025 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Date: Tue, 01 Sep 2009 13:26:31 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 13:26:30 2009 New Revision: 810025 URL: http://svn.apache.org/viewvc?rev=810025&view=rev Log: Make javaresource and friends honor build.sysclasspath Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java?rev=810025&r1=810024&r2=810025&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Tue Sep 1 13:26:30 2009 @@ -164,7 +164,8 @@ } if (cl == null) { if (getClasspath() != null) { - cl = getProject().createClassLoader(classpath); + Path p = getClasspath().concatSystemClasspath(); + cl = getProject().createClassLoader(p); } else { cl = JavaResource.class.getClassLoader(); } From notificationsclarson@example.org Tue Sep 01 14:00:40 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 86446 invoked from network); 1 Sep 2009 14:00:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 14:00:40 -0000 Received: (qmail 80539 invoked by uid 500); 1 Sep 2009 14:00:40 -0000 Delivered-To: clarson@example.org Received: (qmail 80474 invoked by uid 500); 1 Sep 2009 14:00:39 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 80465 invoked by uid 99); 1 Sep 2009 14:00:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:00:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:00:38 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id DC30C2388909; Tue, 1 Sep 2009 14:00:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r810060 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTypes/resources.html src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java src/tests/antunit/types/resources/javaresource-test.xml Date: Tue, 01 Sep 2009 14:00:17 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 14:00:17 2009 New Revision: 810060 URL: http://svn.apache.org/viewvc?rev=810060&view=rev Log: add a parentFirst attribute to javaresource so you can load resources from the specified classpath instead of the system classpath. PR 41369 Added: ant/core/trunk/src/tests/antunit/types/resources/javaresource-test.xml (with props) Modified: ant/core/trunk/WHATSNEW ant/core/trunk/docs/manual/CoreTypes/resources.html ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Modified: ant/core/trunk/WHATSNEW URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=810060&r1=810059&r2=810060&view=diff ============================================================================== --- ant/core/trunk/WHATSNEW (original) +++ ant/core/trunk/WHATSNEW Tue Sep 1 14:00:17 2009 @@ -939,6 +939,11 @@ * <property> can now specify values as nested text. Bugzilla Report 32917. + * a new parentFirst attribute on <javaresource> allows resources to + be loaded from the specified classpath rather than the system + classloader. + Bugzilla Report 41369. + Changes from Ant 1.7.0 TO Ant 1.7.1 ============================================= Modified: ant/core/trunk/docs/manual/CoreTypes/resources.html URL: http://svn.apache.org/viewvc/ant/core/trunk/docs/manual/CoreTypes/resources.html?rev=810060&r1=810059&r2=810060&view=diff ============================================================================== --- ant/core/trunk/docs/manual/CoreTypes/resources.html (original) +++ ant/core/trunk/docs/manual/CoreTypes/resources.html Tue Sep 1 14:00:17 2009 @@ -149,6 +149,15 @@ used to load the resource, constructed from the specified classpath.</td> <td align="center" valign="top">No</td> </tr> + <tr> + <td valign="top">parentFirst</td> + <td valign="top">Whether to consult the parent classloader first - + the parent classloader most likely is the system classloader - + when using a nested classpath. Defaults + to <code>true</code>.<br/> + <em>Since Ant 1.8.0</em></td> + <td align="center" valign="top">No</td> + </tr> </table> <p>The classpath can also be specified as nested classpath element, Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java?rev=810060&r1=810059&r2=810060&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Tue Sep 1 14:00:17 2009 @@ -17,6 +17,7 @@ */ package org.apache.tools.ant.types.resources; +import org.apache.tools.ant.AntClassLoader; import org.apache.tools.ant.Project; import org.apache.tools.ant.types.Resource; import org.apache.tools.ant.types.Path; @@ -31,13 +32,14 @@ * * A Resource representation of anything that is accessed via a Java classloader. * The core methods to set/resolve the classpath are provided. - * @since Ant 1.8 + * @since Ant 1.8.0 * */ public abstract class AbstractClasspathResource extends Resource { private Path classpath; private Reference loader; + private boolean parentFirst = true; /** * Set the classpath to use when looking up a resource. @@ -117,6 +119,17 @@ } /** + * Whether to consult the parent classloader first. + * + * <p>Only relevant if a classpath has been specified.</p> + * + * @since Ant 1.8.0 + */ + public void setParentFirst(boolean b) { + parentFirst = b; + } + + /** * Overrides the super version. * @param r the Reference to set. */ @@ -165,7 +178,14 @@ if (cl == null) { if (getClasspath() != null) { Path p = getClasspath().concatSystemClasspath(); - cl = getProject().createClassLoader(p); + if (parentFirst) { + cl = getProject().createClassLoader(p); + } else { + cl = AntClassLoader.newAntClassLoader(getProject() + .getCoreLoader(), + getProject(), + p, false); + } } else { cl = JavaResource.class.getClassLoader(); } Added: ant/core/trunk/src/tests/antunit/types/resources/javaresource-test.xml URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/types/resources/javaresource-test.xml?rev=810060&view=auto ============================================================================== --- ant/core/trunk/src/tests/antunit/types/resources/javaresource-test.xml (added) +++ ant/core/trunk/src/tests/antunit/types/resources/javaresource-test.xml Tue Sep 1 14:00:17 2009 @@ -0,0 +1,62 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project default="antunit" xmlns:au="antlib:org.apache.ant.antunit"> + + <import file="../../antunit-base.xml"/> + + <target name="setUp"> + <mkdir dir="${output}"/> + </target> + + <target name="testUsesSystemClasspath" depends="setUp"> + <copy todir="${output}"> + <javaresource name="org/apache/tools/ant/antlib.xml"/> + </copy> + <au:assertFileExists file="${output}/org/apache/tools/ant/antlib.xml"/> + </target> + + <target name="-setUpAntlibXmlInInput" depends="setUp"> + <mkdir dir="${input}/org/apache/tools/ant"/> + <echo file="${input}/org/apache/tools/ant/antlib.xml">Hello, world!</echo> + </target> + + <target name="testParentFirstIsDefault" depends="-setUpAntlibXmlInInput"> + <copy todir="${output}"> + <javaresource name="org/apache/tools/ant/antlib.xml"> + <classpath location="${input}"/> + </javaresource> + </copy> + <au:assertFileExists file="${output}/org/apache/tools/ant/antlib.xml"/> + <au:assertFilesDiffer + expected="${input}/org/apache/tools/ant/antlib.xml" + actual="${output}/org/apache/tools/ant/antlib.xml"/> + </target> + + <target name="testParentFirstFalse" depends="-setUpAntlibXmlInInput"> + <copy todir="${output}"> + <javaresource name="org/apache/tools/ant/antlib.xml" + parentFirst="false"> + <classpath location="${input}"/> + </javaresource> + </copy> + <au:assertFileExists file="${output}/org/apache/tools/ant/antlib.xml"/> + <au:assertFilesMatch + expected="${input}/org/apache/tools/ant/antlib.xml" + actual="${output}/org/apache/tools/ant/antlib.xml"/> + </target> +</project> Propchange: ant/core/trunk/src/tests/antunit/types/resources/javaresource-test.xml ------------------------------------------------------------------------------ svn:eol-style = native From notificationsclarson@example.org Tue Sep 01 14:01:43 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 86993 invoked from network); 1 Sep 2009 14:01:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 14:01:43 -0000 Received: (qmail 84323 invoked by uid 500); 1 Sep 2009 14:01:43 -0000 Delivered-To: clarson@example.org Received: (qmail 84300 invoked by uid 500); 1 Sep 2009 14:01:43 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 84291 invoked by uid 99); 1 Sep 2009 14:01:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:01:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:01:41 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id B38CE23888DB; Tue, 1 Sep 2009 14:01:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r810061 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Date: Tue, 01 Sep 2009 14:01:21 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 14:01:21 2009 New Revision: 810061 URL: http://svn.apache.org/viewvc?rev=810061&view=rev Log: backwards compatibility Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java?rev=810061&r1=810060&r2=810061&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Tue Sep 1 14:01:21 2009 @@ -177,7 +177,7 @@ } if (cl == null) { if (getClasspath() != null) { - Path p = getClasspath().concatSystemClasspath(); + Path p = getClasspath().concatSystemClasspath("ignore"); if (parentFirst) { cl = getProject().createClassLoader(p); } else { From notificationsclarson@example.org Tue Sep 01 14:02:37 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 87232 invoked from network); 1 Sep 2009 14:02:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 14:02:37 -0000 Received: (qmail 85328 invoked by uid 500); 1 Sep 2009 14:02:36 -0000 Delivered-To: clarson@example.org Received: (qmail 85270 invoked by uid 500); 1 Sep 2009 14:02:36 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 85261 invoked by uid 99); 1 Sep 2009 14:02:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:02:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:02:34 +0000 Received: by brutus.apache.org (Postfix, from userid 33) id 0954D234C045; Tue, 1 Sep 2009 07:02:12 -0700 (PDT) From: clarson@example.org To: clarson@example.org Subject: DO NOT REPLY [Bug 41369] Copy with javaresource handles classpath incorrectly X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ant X-Bugzilla-Component: Core X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: clarson@example.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: clarson@example.org X-Bugzilla-Target-Milestone: 1.8.0 X-Bugzilla-Changed-Fields: Status Resolution Target Milestone In-Reply-To: <{{EMAIL+PHONE}}/bugzilla/> References: <{{EMAIL+PHONE}}/bugzilla/> X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Message-Id: <clarson@example.org> Date: Tue, 1 Sep 2009 07:02:12 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=41369 Stefan Bodewig <clarson@example.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED Target Milestone|--- |1.8.0 --- Comment #2 from Stefan Bodewig <clarson@example.org> 2009-09-01 07:02:07 PDT --- You are correct, but backwards compatibility is going to byte us. svn revision 810060 introduces a new parentfirst attribute, set this to false and your tests pass. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From notificationsclarson@example.org Tue Sep 01 14:10:36 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 89500 invoked from network); 1 Sep 2009 14:10:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 14:10:36 -0000 Received: (qmail 91301 invoked by uid 500); 1 Sep 2009 14:10:36 -0000 Delivered-To: clarson@example.org Received: (qmail 91228 invoked by uid 500); 1 Sep 2009 14:10:36 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 91218 invoked by uid 99); 1 Sep 2009 14:10:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:10:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:10:33 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id AE2FD23888DB; Tue, 1 Sep 2009 14:10:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r810063 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Date: Tue, 01 Sep 2009 14:10:12 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 14:10:12 2009 New Revision: 810063 URL: http://svn.apache.org/viewvc?rev=810063&view=rev Log: ensure classloaders get cleaned up when no longer needed Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java?rev=810063&r1=810062&r2=810063&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Tue Sep 1 14:10:12 2009 @@ -24,6 +24,7 @@ import org.apache.tools.ant.types.Reference; import org.apache.tools.ant.util.FileUtils; +import java.io.FilterInputStream; import java.io.InputStream; import java.io.IOException; import java.util.Stack; @@ -172,6 +173,7 @@ } dieOnCircularReference(); ClassLoader cl = null; + boolean clNeedsCleanup = false; if (loader != null) { cl = (ClassLoader) loader.getReferencedObject(); } @@ -186,6 +188,7 @@ getProject(), p, false); } + clNeedsCleanup = loader != null; } else { cl = JavaResource.class.getClassLoader(); } @@ -194,7 +197,22 @@ } } - return openInputStream(cl); + final ClassLoader classLoader = cl; + return !clNeedsCleanup + ? openInputStream(cl) + : new FilterInputStream(openInputStream(cl)) { + public void close() throws IOException { + FileUtils.close(in); + ((AntClassLoader) classLoader).cleanup(); + } + protected void finalize() throws Throwable { + try { + close(); + } finally { + super.finalize(); + } + } + }; } /** From notificationsclarson@example.org Tue Sep 01 14:13:47 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 90507 invoked from network); 1 Sep 2009 14:13:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 14:13:47 -0000 Received: (qmail 95981 invoked by uid 500); 1 Sep 2009 14:13:47 -0000 Delivered-To: clarson@example.org Received: (qmail 95957 invoked by uid 500); 1 Sep 2009 14:13:47 -0000 Mailing-List: contact clarson@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:clarson@example.org> List-Unsubscribe: <mailto:clarson@example.org> List-Post: <mailto:clarson@example.org> List-Id: <notifications.ant.apache.org> Reply-To: clarson@example.org Delivered-To: mailing list clarson@example.org Received: (qmail 95937 invoked by uid 99); 1 Sep 2009 14:13:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:13:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2009 14:13:44 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6FF9E23888DB; Tue, 1 Sep 2009 14:13:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r810065 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Date: Tue, 01 Sep 2009 14:13:23 -0000 To: clarson@example.org From: clarson@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <clarson@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: bodewig Date: Tue Sep 1 14:13:23 2009 New Revision: 810065 URL: http://svn.apache.org/viewvc?rev=810065&view=rev Log: Oops, logic was backwards. Clean up classloader unless it is added as a reference later. Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java?rev=810065&r1=810064&r2=810065&view=diff ============================================================================== --- ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java (original) +++ ant/core/trunk/src/main/org/apache/tools/ant/types/resources/AbstractClasspathResource.java Tue Sep 1 14:13:23 2009 @@ -188,7 +188,7 @@ getProject(), p, false); } - clNeedsCleanup = loader != null; + clNeedsCleanup = loader == null; } else { cl = JavaResource.class.getClassLoader(); } From notificationsclarson@example.org Tue Sep 01 14:54:04 2009 Return-Path: <notificationsclarson@example.org> Delivered-To: clarson@example.org Received: (qmail 3428 invoked from network); 1 Sep 2009 14:54:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Sep 2009 14:54:04 -0000 Received: (qmail 61825 invoked by uid 500); 1 Sep 2009 14:54:04 -0000 Delivered-To: clarson@example.org Received: (qmail 61752 invoked by uid 500); 1 Sep 2009 14:54:04 -0000 Mailing-List: contact clarson@example.org; run by ezmlm
{'source': 'Apache Software Foundation Public Mail Archives'}