From dev-thomasbishop@example.net Wed Jun 1 00:50:22 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 1DB344033 for <thomasbishop@example.net>; Wed, 1 Jun 2011 00:50:22 +0000 (UTC) Received: (qmail 89789 invoked by uid 500); 1 Jun 2011 00:50:21 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 89724 invoked by uid 500); 1 Jun 2011 00:50:21 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 89716 invoked by uid 99); 1 Jun 2011 00:50:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 00:50:21 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO out3.smtp.messagingengine.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 00:50:13 +0000 Received: from compute4.internal (compute4.nyi.mail.srv.osa [83.161.120.155]) by gateway1.messagingengine.com (Postfix) with ESMTP id 7DE4B207ED; Tue, 31 May 2011 20:49:52 -0400 (EDT) Received: from frontend1.messagingengine.com ([83.161.120.155]) by compute4.internal (MEProxy); Tue, 31 May 2011 20:49:52 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to; s=smtpout; bh=cVyHIbk6tr3v5P4aDG0bFm6s/p8=; b=YvUjSLcqs6v9+mqYp+ZzKABxyyoXym4l9FISGQEw4nH2sHQFFDgVdn8DlRL/qUkH2qX+0jQDfI5D+6GIKAghpL0ogtQeoUs8zk0ii+8U0M1eogc6HF/FAW2KmwFc/yWQBKIY6TtpIKtNbZSm9hzmWelk7VfdNixy3lRUe2WYc38= X-Sasl-enc: /fzbt1mPCFBWj3fC+ERkJUfu/6QvCua7D3mtYkVS5rCwe0PLtR77GKsrp9ML5w 1306889391 Received: from daniel3.local (bzq-109-65-248-107.red.bezeqint.net [83.161.120.155]) by mail.messagingengine.com (Postfix) with ESMTPSA id 9663B409B75; Tue, 31 May 2011 20:49:51 -0400 (EDT) Date: Wed, 1 Jun 2011 03:49:39 +0300 From: Daniel Shahaf <thomasbishop@example.net> To: thomasbishop@example.net Cc: Johan Corveleyn <thomasbishop@example.net> Subject: Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c Message-ID: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <thomasbishop@example.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-Virus-Checked: Checked by ClamAV on apache.org Stefan Sperling wrote on Wed, Jun 01, 2011 at 01:22:40 +0200: > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: > > [[[ > > The usual namespace rules apply: only names that begin with "SVN_" > > and don't contain double underscores are considered part of the public > > API. Everything else is not officially supported. > > ]]] > > I just edited this paragraph to remove the first of the two claims it makes. > > Thinking: "I don't think this should be part of the public API", so I > > can just dispense with the "SVN_" prefix. > > In this case I would advocate for SVN__DISABLE_PREFIX_SUFFIX_SCANNING :) > You're right that it doesn't need to be part of the public API. From dev-thomasbishop@example.net Wed Jun 1 08:05:04 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id A35516297 for <thomasbishop@example.net>; Wed, 1 Jun 2011 08:05:04 +0000 (UTC) Received: (qmail 79520 invoked by uid 500); 1 Jun 2011 08:05:04 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 79453 invoked by uid 500); 1 Jun 2011 08:05:03 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 79445 invoked by uid 99); 1 Jun 2011 08:05:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 08:05:02 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO mtaout03-winn.ispmail.ntl.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 08:04:54 +0000 Received: from aamtaout01-winn.ispmail.ntl.com ([83.161.120.155]) by mtaout03-winn.ispmail.ntl.com (InterMail vM.83.161.120.155 201-2186-134-20080326) with ESMTP id <thomasbishop@example.net>; Wed, 1 Jun 2011 09:04:30 +0100 Received: from cpc2-farn6-0-0-cust204.6-2.cable.virginmedia.com ([83.161.120.155]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.83.161.120.155 201-2196-133-20080908) with ESMTP id <thomasbishop@example.net>; Wed, 1 Jun 2011 09:04:29 +0100 Received: by cpc2-farn6-0-0-cust204.6-2.cable.virginmedia.com (Postfix, from userid 1000) id 3BE80361C1; Wed, 1 Jun 2011 09:04:27 +0100 (BST) From: Philip Martin <thomasbishop@example.net> To: Stefan Fuhrmann <thomasbishop@example.net> Cc: thomasbishop@example.net Subject: Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx References: <thomasbishop@example.net> <thomasbishop@example.net> <1306501985.1991.1918.camel@edith> <thomasbishop@example.net> <thomasbishop@example.net> Date: Wed, 01 Jun 2011 09:04:27 +0100 In-Reply-To: <thomasbishop@example.net> (Stefan Fuhrmann's message of "Sun, 29 May 2011 13:27:32 +0200") Message-ID: <thomasbishop@example.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Cloudmark-Analysis: v=1.1 cv=R50lirqlHffDPPkwUlkuVa99MrvKdVWo//yz83qex8g= c=1 sm=0 a=dmETdrZ3I3YA:10 a=AhfYtD1IieQA:10 a=sOaj6hhuNKAA:10 a=kj9zAlcOel0A:10 a=5mFqyISTkN3DPW03_B4A:9 a=J-gUDbITcHJAw_dEExkA:7 a=CjuIK1q_8ugA:10 a=5KVauyKsRKMA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Stefan Fuhrmann <thomasbishop@example.net> writes: >> Updated log message: >> [[[ >> Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. >> >> * subversion/libsvn_diff/lcs.c >> (svn_diff__snake): Removed idx parameter (always 0) >> (svn_diff__lcs): Removed idx variable (always 0) , let d have either >> sign, and moved the origo of fp by d. New version no longer chooses >> the shorter file as the "original", and can thus give different LCS's >> depending on the order of the input files even when the files have >> different lengths. Speed is ~15% faster for core lcs algorithm. >> ]]] > Committed as r1128857. I took the liberty to > weaken the speed-up claim. This commit fixed the spurious conflict on update in issue 3449, I suppose the chosen LCS is "better" in this particular case. Are there likely to be cases where the chosen LCS is "worse" so that previously clean merges are now conflicts? See r1130036 for a 3449 regression test. -- Philip From dev-thomasbishop@example.net Wed Jun 1 08:29:02 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 2FC7C6F13 for <thomasbishop@example.net>; Wed, 1 Jun 2011 08:29:02 +0000 (UTC) Received: (qmail 9280 invoked by uid 500); 1 Jun 2011 08:29:01 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 9250 invoked by uid 500); 1 Jun 2011 08:29:01 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 9242 invoked by uid 99); 1 Jun 2011 08:29:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 08:29:01 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-iy0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 08:28:56 +0000 Received: by iyi20 with SMTP id 20so6575869iyi.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 01:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=yl+ZSQckVJOAyhVVoUmMeHH/VFqN8BBL416m7yTAKss=; b=IGEx227kjlzzH5jxkX5TSm46++4yfR5bXTBeCGcU7KHYS96wDT33Wqaqgg1Bk6Eo2y DvtwZV3e8NpM6CSs/6fqTIttOf0dwe+yirnZPI0zyZXk7JGIe7mP9P7Whg+LakyRh94O LQv4TfuQ7Q7s9cmMaUbFoxJEiYDKe0Uo1x/rQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=s9O9uYqAaAOheSV7Qt/jmUA1LJ13pGeN5O33uHdQQyGiV0gTDT/DV5lqnPkBmDuK0H ruZbS4jS3AZW22CIt94xqA4t2zJXYmtnQJv9798mxZIm7krRRT5SS7o++BTEiWlyaRzQ dFPIr9hdXhSGBFsJCV3fWVFMUP8VxzWafq4/k= Received: by 83.161.120.155 with SMTP id a4mr12666527icw.199.1306916915908; Wed, 01 Jun 2011 01:28:35 -0700 (PDT) MIME-Version: 1.0 Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 01:28:15 -0700 (PDT) In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <1306501985.1991.1918.camel@edith> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> From: Johan Corveleyn <thomasbishop@example.net> Date: Wed, 1 Jun 2011 10:28:15 +0200 Message-ID: <thomasbishop@example.net> Subject: Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx To: Philip Martin <thomasbishop@example.net> Cc: Stefan Fuhrmann <thomasbishop@example.net>, thomasbishop@example.net, thomasbishop@example.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Jun 1, 2011 at 10:04 AM, Philip Martin <thomasbishop@example.net> wrote: > Stefan Fuhrmann <thomasbishop@example.net> writes: > >>> Updated log message: >>> [[[ >>> Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. >>> >>> * subversion/libsvn_diff/lcs.c >>> =A0 (svn_diff__snake): Removed idx parameter (always 0) >>> =A0 (svn_diff__lcs): Removed idx variable (always 0) , let d have eithe= r >>> =A0 =A0sign, and moved the origo of fp by d. New version no longer choo= ses >>> =A0 =A0the shorter file as the "original", and can thus give different = LCS's >>> =A0 =A0depending on the order of the input files even when the files ha= ve >>> =A0 =A0different lengths. Speed is ~15% faster for core lcs algorithm. >>> ]]] >> Committed as r1128857. I took the liberty to >> weaken the speed-up claim. > > This commit fixed the spurious conflict on update in issue 3449, I > suppose the chosen LCS is "better" in this particular case. =A0Are there > likely to be cases where the chosen LCS is "worse" so that previously > clean merges are now conflicts? > > See r1130036 for a 3449 regression test. I was wondering about the exact same thing yesterday :). I suspected that the sudden resolution to issue 3449 was related to this. The chosen LCS is indeed better now, because it follows the same direction for both comparisons involved in the update/merge (i.e. (Base, Mine) and (Base, Theirs), whereas previously the LCS could be reversed based on which side was shorter). See Morten's explanation (and my reply) about this a couple of mails ago in this thread. But I'm also unsure about your second question: are the cases where there was previously a clean merge, and now a "spurious" conflict. I suppose one could come up with an example, but I guess it would be more up to interpretation whether or not there should be (or should have been) a conflict. I have to think some more about this. Maybe Morten has an idea? Cheers, --=20 Johan From dev-thomasbishop@example.net Wed Jun 1 09:28:07 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 4BEFC64E1 for <thomasbishop@example.net>; Wed, 1 Jun 2011 09:28:07 +0000 (UTC) Received: (qmail 85702 invoked by uid 500); 1 Jun 2011 09:28:07 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 85668 invoked by uid 500); 1 Jun 2011 09:28:07 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 85660 invoked by uid 99); 1 Jun 2011 09:28:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 09:28:07 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO sp-exchfea.sp.corp.collab.net) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 09:28:01 +0000 Received: from noorul.collab.net ([83.161.120.155]) by sp-exchfea.sp.corp.collab.net with Microsoft SMTPSVC(276)277-0925); Wed, 1 Jun 2011 02:27:40 -0700 From: Noorul Islam K M <thomasbishop@example.net> To: Subversion <thomasbishop@example.net> Subject: [PATCH] Re: Bug in exporting externals? References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> Date: Wed, 01 Jun 2011 14:56:04 +0530 In-Reply-To: <thomasbishop@example.net> (Noorul Islam K. M.'s message of "Tue, 31 May 2011 15:02:01 +0530") Message-ID: <thomasbishop@example.net> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OriginalArrivalTime: 01 Jun 2011 09:27:40.0350 (UTC) FILETIME=[2721F5E0:01CC203E] --=-=-= Content-Type: text/plain Noorul Islam K M <thomasbishop@example.net> writes: > Noorul Islam K M <thomasbishop@example.net> writes: > >> Noorul Islam K M <thomasbishop@example.net> writes: >> >>> While working on issue 3799, in one of the review comments julianf said >>> the following about number 10 test in external_tests.py. >>> >>> <quote> >>> A/B/gamma is only an external: it does not appear in the WC until >>> Subversion processes the external definitions. >>> >>> It looks to me like that failure was showing us a bug. If I run the >>> test, without your patch, in verbose mode, I see: >>> >>> CMD: svn export svn-test-work/working_copies/externals_tests-10 >>> svn-test-work/working_copies/externals_tests-10.export [...] >>> A svn-test-work/working_copies/externals_tests-10.export/A >>> A svn-test-work/working_copies/externals_tests-10.export/A/B >>> A svn-test-work/working_copies/externals_tests-10.export/A/B/lambda >>> A svn-test-work/working_copies/externals_tests-10.export/A/B/gamma >>> [...] >>> A svn-test-work/working_copies/externals_tests-10.export/A/B/gamma >>> [...] >>> CMD: svn export --ignore-externals >>> svn-test-work/working_copies/externals_tests-10 >>> svn-test-work/working_copies/externals_tests-10.export [...] >>> A svn-test-work/working_copies/externals_tests-10.export/A >>> A svn-test-work/working_copies/externals_tests-10.export/A/B >>> A svn-test-work/working_copies/externals_tests-10.export/A/B/lambda >>> A svn-test-work/working_copies/externals_tests-10.export/A/B/gamma >>> [...] >>> >>> There is a comment in the test about --ignore-externals not ignoring >>> A/B/gamma. That's a bug. And the first export (without >>> --ignore-externals) is also buggy. It shouldn't export A/B/gamma twice. >>> >>> We shouldn't just quietly tweak the test to hide the bug. We should >>> write a new test specifically to check for that bug, or fix the bug, or >>> file an issue, or write to the dev@ list about it. Something. >>> >>> - Julian >>> </quote> >>> >>> I tried to re-create this out of test environment and I came up with a >>> reproduction script which is attached. >>> >>> Here I have a repository with the following files >>> >>> A/B/lambda >>> A/D/gamma >>> >>> Along with this I have an external set on A/B as >>> >>> "^/A/D/gamma gamma" >>> >>> Now while exporting the working copy. A/B/gamma is exported twice which >>> looks like a bug and while exporting the WC with --ignore-externals >>> A/B/gamma is exported once which also seems to be a bug since A/B/gamma >>> is an external. >>> >>> I can go ahead and create an issue for this if people can confirm this. >>> >> >> Somehow I missed the attachment. Here is it. >> >> Thanks and Regards >> Noorul >> > > Really sorry about the previous mail in which I attached the script > inline and also script had some issues. Please find attached the correct > one. > Attached is the patch which fixes this issue. Log [[[ Fix a bug in 'svn export' because of which externals are exported twice when exporting a working copy having externals. * subversion/libsvn_client/export.c (copy_versioned_files): Do not copy an external file here. This is done down the line in the function. * subversion/tests/cmdline/externals_tests.py (export_wc_with_externals): Remove XFail marker. Patch by: Noorul Islam K M <noorul{_AT_}collab.net> ]]] Thanks and Regards Noorul --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=fix_export_external_issue.txt Index: subversion/tests/cmdline/externals_tests.py =================================================================== --- subversion/tests/cmdline/externals_tests.py (revision 1130008) +++ subversion/tests/cmdline/externals_tests.py (working copy) @@ -737,7 +737,6 @@ # Test for issue #2429 @Issue(2429) -@XFail() def export_wc_with_externals(sbox): "test exports from working copies with externals" Index: subversion/libsvn_client/export.c =================================================================== --- subversion/libsvn_client/export.c (revision 1130008) +++ subversion/libsvn_client/export.c (working copy) @@ -505,10 +505,20 @@ else if (child_kind == svn_node_file && depth >= svn_depth_files) { - SVN_ERR(copy_one_versioned_file(child_abspath, target_abspath, - ctx, revision, - native_eol, ignore_keywords, - iterpool)); + svn_node_kind_t external_kind; + + SVN_ERR(svn_wc__read_external_info(&external_kind, + NULL, NULL, NULL, + NULL, ctx->wc_ctx, + child_abspath, + child_abspath, TRUE, + pool, pool)); + + if (external_kind != svn_node_file) + SVN_ERR(copy_one_versioned_file(child_abspath, target_abspath, + ctx, revision, + native_eol, ignore_keywords, + iterpool)); } } --=-=-=-- From dev-thomasbishop@example.net Wed Jun 1 13:44:03 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 2DBE56B8E for <thomasbishop@example.net>; Wed, 1 Jun 2011 13:44:03 +0000 (UTC) Received: (qmail 73665 invoked by uid 500); 1 Jun 2011 13:44:02 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 73626 invoked by uid 500); 1 Jun 2011 13:44:02 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 73618 invoked by uid 99); 1 Jun 2011 13:44:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 13:44:02 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-vx0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 13:43:56 +0000 Received: by vxc40 with SMTP id 40so6526386vxc.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 06:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=vp8aQ2jorSMQlTWVjPRHbpf3jfwMfkK3eouP/vp0iR0=; b=H+EK5ZUUqlJZiMKdU/va/oGaLx4oe0DZzwmO0EitX6IqpN/7ZhQ3A9xZfParoUSC9q HoqCdkK/fwas4DKc5lF1o0wkvBI1yNeTfHwvz8Fk7zXFpOp9pShxN9dxV377t4YDueRf lkHf30I8Gxnrg1C/JZnztqLlqGMUKdtROUM/c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=ty6YglypVO/PpK5XbVMAbZ/6WXpSyCElyWodMQ5DqdOnToOhovi2Yf3ZNq69QUnZEg 6aKzK6kpn6RfHaZifP4YU0XXPsvd5bXzWJThUn0ZZrU3MJg+QvhqIQ8/Pv+B+/Rd6EbS nN35uIKFbXZsMXnpDP7ueEV7yLvutxrqGF8dM= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id a7mr1145213vdt.61.1306935815513; Wed, 01 Jun 2011 06:43:35 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 06:43:35 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 06:43:35 -0700 (PDT) Date: Wed, 1 Jun 2011 09:43:35 -0400 Message-ID: <thomasbishop@example.net> Subject: Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c From: Greg Stein <thomasbishop@example.net> To: thomasbishop@example.net Content-Type: multipart/alternative; boundary=20cf307f38e407265c04a4a6b538 --20cf307f38e407265c04a4a6b538 Content-Type: text/plain; charset=ISO-8859-1 On Jun 1, 2011 8:02 AM, <thomasbishop@example.net> wrote: > > Author: julianfoad > Date: Wed Jun 1 12:02:32 2011 > New Revision: 1130118 > > URL: http://svn.apache.org/viewvc?rev=1130118&view=rev > Log: > Rename svn_stream_buffered() and related symbols to ...is_buffered... for > clarity. It seems this API is only around to support stream_readline(). Is it really worthwhile to expose this for a single callpoint? Cheers, -g --20cf307f38e407265c04a4a6b538-- From dev-thomasbishop@example.net Wed Jun 1 13:57:54 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 1C4D9679D for <thomasbishop@example.net>; Wed, 1 Jun 2011 13:57:54 +0000 (UTC) Received: (qmail 97090 invoked by uid 500); 1 Jun 2011 13:57:53 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 97038 invoked by uid 500); 1 Jun 2011 13:57:53 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 97030 invoked by uid 99); 1 Jun 2011 13:57:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 13:57:53 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-vw0-f43.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 13:57:45 +0000 Received: by vws10 with SMTP id 10so6552400vws.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 06:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=x6jgw/NAHCCK+mTqjIG7reMDf85rF91AvTgy/4UzzH4=; b=IlP8cC5K89E+7H7ZQl0j9HRqOKSFEo4YrWZh8ZtBs0VGN2nuN+/EZaokI9wvplI+6E rXm8NryUwXzQrdgUe6F8kEBYpXtZzTfPhfyO0Gg6XNMT+NXABHFBhaTBdYvv5G6mpcSB CsMnIK2ByKCFLQM6QH7cIobliiIlvpWbng4AE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=Z4wYM8w4Tzn+zDiehijtpEfXbqdd1paiX3J/4VhOMTkK292weQSkscqx2Nw15+nWve lB7Jl24pDD7w+h4VyvNHKgzZRU2+m674Ckrsp1MRbsHg2070awx1jpQfl22zA0ge/h2e bTUMpT0beUsbxPqSxbQcTyR1gbLrpSqW7ZWC4= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id en6mr1259759vdb.301.1306936644881; Wed, 01 Jun 2011 06:57:24 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 06:57:24 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 06:57:24 -0700 (PDT) In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> Date: Wed, 1 Jun 2011 09:57:24 -0400 Message-ID: <thomasbishop@example.net> Subject: Re: svn commit: r1129980 - /subversion/trunk/notes/knobs From: Greg Stein <thomasbishop@example.net> To: thomasbishop@example.net Content-Type: multipart/alternative; boundary=20cf307f3b08764d3304a4a6e6f5 X-Virus-Checked: Checked by ClamAV on apache.org --20cf307f3b08764d3304a4a6e6f5 Content-Type: text/plain; charset=ISO-8859-1 On May 31, 2011 8:49 PM, <thomasbishop@example.net> wrote: >... > +++ subversion/trunk/notes/knobs Wed Jun 1 00:48:56 2011 > @@ -17,9 +17,9 @@ The SVN source code boasts a number of e > processor enabled tweaks that are mainly aimed at developer support. > If you introduce new ones, please document them here. > > -The usual namespace rules apply: only names that begin with "SVN_" > -and don't contain double underscores are considered part of the public > -API. Everything else is not officially supported. > +The usual namespace rules apply: names that don't begin with "SVN_" or > +contain double underscores are not part of the public API and may change > +arbitrarily at any time (including between patch releases). I had a define in workqueue.c that somebody recently prefixed with SVN_. I never intended it to be part of *any* API. just a little helper for us devs. Yet now it shows up in knobs, and is an "official API"?!? Seems we may want to reconsider how stuff magically becomes a "knob". Cheers, -g --20cf307f3b08764d3304a4a6e6f5-- From dev-thomasbishop@example.net Wed Jun 1 14:01:59 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 2229767AD for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:01:59 +0000 (UTC) Received: (qmail 8244 invoked by uid 500); 1 Jun 2011 14:01:58 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 8213 invoked by uid 500); 1 Jun 2011 14:01:58 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 8205 invoked by uid 99); 1 Jun 2011 14:01:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:01:58 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO einhorn.in-berlin.de) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:01:50 +0000 X-Envelope-From: thomasbishop@example.net Received: from ted.stsp.name (ted.stsp.name [83.161.120.155]) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id p51E1Qel017916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 1 Jun 2011 16:01:26 +0200 Received: from ted.stsp.name (stsp@localhost [83.161.120.155]) by ted.stsp.name (8.14.3/8.14.3) with ESMTP id p51E1QW6009990; Wed, 1 Jun 2011 16:01:26 +0200 (CEST) Received: (from stsp@localhost) by ted.stsp.name (8.14.3/8.14.3/Submit) id p51E1PLT012923; Wed, 1 Jun 2011 16:01:25 +0200 (CEST) Date: Wed, 1 Jun 2011 16:01:24 +0200 From: Stefan Sperling <thomasbishop@example.net> To: Greg Stein <thomasbishop@example.net> Cc: thomasbishop@example.net Subject: Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c Message-ID: <thomasbishop@example.net> Mail-Followup-To: Greg Stein <thomasbishop@example.net>, thomasbishop@example.net References: <thomasbishop@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <thomasbishop@example.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 83.161.120.155 On Wed, Jun 01, 2011 at 09:43:35AM -0400, Greg Stein wrote: > On Jun 1, 2011 8:02 AM, <thomasbishop@example.net> wrote: > > > > Author: julianfoad > > Date: Wed Jun 1 12:02:32 2011 > > New Revision: 1130118 > > > > URL: http://svn.apache.org/viewvc?rev=1130118&view=rev > > Log: > > Rename svn_stream_buffered() and related symbols to ...is_buffered... for > > clarity. > > It seems this API is only around to support stream_readline(). Is it really > worthwhile to expose this for a single callpoint? I'd say we should move this into private/svn_io_private.h. From dev-thomasbishop@example.net Wed Jun 1 14:08:36 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id DFDA76CFF for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:08:36 +0000 (UTC) Received: (qmail 26800 invoked by uid 500); 1 Jun 2011 14:08:36 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 26762 invoked by uid 500); 1 Jun 2011 14:08:36 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 26754 invoked by uid 99); 1 Jun 2011 14:08:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:08:36 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-wy0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:08:28 +0000 Received: by wyb32 with SMTP id 32so5981964wyb.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:08:07 -0700 (PDT) Received: by 83.161.120.155 with SMTP id q14mr4953933wep.49.1306937287108; Wed, 01 Jun 2011 07:08:07 -0700 (PDT) Received: from [83.161.120.155] (cpc3-newt6-0-0-cust796.newt.cable.virginmedia.com [83.161.120.155]) by mx.google.com with ESMTPS id y3sm655879wec.10.283.161.120.155.08.04 (version=SSLv3 cipher=OTHER); Wed, 01 Jun 2011 07:08:05 -0700 (PDT) Subject: Re: svn commit: r1072519 - Add svn_stream_skip(), svn_stream_buffered(), svn_stream_supports_mark() From: Julian Foad <thomasbishop@example.net> To: thomasbishop@example.net, thomasbishop@example.net In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Jun 2011 15:08:02 +0100 Message-ID: <1306937282.20888.651.camel@edith> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit On Sun, 2011-02-20, thomasbishop@example.net wrote: > Merge all changes (r1068695 - r1072516) from the > integrate-stream-api-extensions. > > These patches add svn_stream_skip(), svn_stream_buffered() > and svn_stream_supports_mark(). A belated review. > Modified: > subversion/trunk/ (props changed) > subversion/trunk/subversion/include/svn_io.h > subversion/trunk/subversion/libsvn_subr/stream.c > subversion/trunk/subversion/libsvn_subr/subst.c > subversion/trunk/subversion/tests/libsvn_subr/stream-test.c [...] > Modified: subversion/trunk/subversion/include/svn_io.h > +/** Skip data handler function for a generic stream. @see svn_stream_t. > + * @since New in 1.7. > + */ > +typedef svn_error_t *(*svn_skip_fn_t)(void *baton, > + apr_size_t *count); > +/** Buffer test handler function for a generic stream. @see svn_stream_t > + * and svn_stream_buffered(). > + * > + * @since New in 1.7. > + */ > +typedef svn_boolean_t (*svn_io_buffered_fn_t)(void *baton); > +/** Set @a stream's skip function to @a skip_fn > + * > + * @since New in 1.7 > + */ > +void > +svn_stream_set_skip(svn_stream_t *stream, > + svn_skip_fn_t skip_fn); > +/** Set @a stream's buffer test function to @a buffered_fn > + * > + * @since New in 1.7. > + */ > +void > +svn_stream_set_buffered(svn_stream_t *stream, > + svn_io_buffered_fn_t buffered_fn); > +/** > + * Skip COUNT bytes from a generic STREAM. If the stream is exhausted > + * before COUNT bytes have been read, an error will be returned and > + * COUNT will be changed to the actual number of bytes skipped. > + * > + * NOTE. No assumption can be made on the semantics of this function > + * other than that the stream read pointer will be advanced by *count > + * bytes. Depending on the capabilities of the underlying stream > + * implementation, this may for instance be translated into a sequence > + * of reads or a simple seek operation. > + */ > +svn_error_t * > +svn_stream_skip(svn_stream_t *stream, > + apr_size_t *count); > +/** Returns @c TRUE if the generic @a stream supports svn_stream_mark(). > + * > + * @see svn_stream_mark() > + * @since New in 1.7. > + */ > +svn_boolean_t > +svn_stream_supports_mark(svn_stream_t *stream); Would a better name be svn_stream_supports_mark_seek()? I do wonder whether we need this. I guess the idea is it's supposed to be faster than calling svn_stream_mark() and checking for the error SVN_ERR_STREAM_SEEK_NOT_SUPPORTED. > +/** Return whether this generic @a stream uses internal buffering. > + * This may be used to work around subtle differences between buffered > + * an non-buffered APR files. > + * > + * @since New in 1.7. > + */ > +svn_boolean_t > +svn_stream_buffered(svn_stream_t *stream); I renamed the symbols from ...buffered... to ...is_buffered... in r1130118, for clarity. Does "is buffered" mean "this layer of the stream implements its own buffering layer"? Does it mean "this stream knows that there is a RAM buffer at some layer of the stream implementation, so some reads from this stream can be served without I/O latency"? Should a layered stream, for example a checksumming stream, delegate to what its underlying stream says? The semantics seem insufficiently clear for a general-purpose stream. The "is buffered" API has one caller, stream_readline(), which says if (stream supports mark && is buffered && ...) then { /* We can efficiently read chunks speculatively and reposition the stream pointer to the end of the line once we found that. */ readline_chunky(); } else { readline_bytewise(); } But I don't understand that. I understand why we'd need to use a byte-by-byte implementation if the stream doesn't support mark and seek, of course, but why would we need to do so if the stream claims not to be buffered? The relevant question right now is: is there a clear benefit for this being public in 1.7? I think not, so I propose to make the "is buffered" API private by renaming the relevant symbols to "svn_stream__*". Or move them into private/svn_io_private.h, as Stefan just suggested. Questions of semantics can then wait. - Julian From dev-thomasbishop@example.net Wed Jun 1 14:09:43 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id BCFBB6D55 for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:09:43 +0000 (UTC) Received: (qmail 28543 invoked by uid 500); 1 Jun 2011 14:09:43 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 28520 invoked by uid 500); 1 Jun 2011 14:09:43 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 28512 invoked by uid 99); 1 Jun 2011 14:09:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:09:43 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO einhorn.in-berlin.de) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:09:34 +0000 X-Envelope-From: thomasbishop@example.net Received: from ted.stsp.name (ted.stsp.name [83.161.120.155]) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id p51E9Amm018450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 1 Jun 2011 16:09:10 +0200 Received: from ted.stsp.name (stsp@localhost [83.161.120.155]) by ted.stsp.name (8.14.3/8.14.3) with ESMTP id p51E9Avg023106; Wed, 1 Jun 2011 16:09:10 +0200 (CEST) Received: (from stsp@localhost) by ted.stsp.name (8.14.3/8.14.3/Submit) id p51E9ASW012734; Wed, 1 Jun 2011 16:09:10 +0200 (CEST) Date: Wed, 1 Jun 2011 16:09:10 +0200 From: Stefan Sperling <thomasbishop@example.net> To: Greg Stein <thomasbishop@example.net> Cc: thomasbishop@example.net Subject: Re: svn commit: r1129980 - /subversion/trunk/notes/knobs Message-ID: <thomasbishop@example.net> Mail-Followup-To: Greg Stein <thomasbishop@example.net>, thomasbishop@example.net References: <thomasbishop@example.net> <thomasbishop@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <thomasbishop@example.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 83.161.120.155 On Wed, Jun 01, 2011 at 09:57:24AM -0400, Greg Stein wrote: > I had a define in workqueue.c that somebody recently prefixed with SVN_. That was me. > I never intended it to be part of *any* API. just a little helper for us devs. > Yet now it shows up in knobs, and is an "official API"?!? > > Seems we may want to reconsider how stuff magically becomes a "knob". I don't really see the point of documenting this define in notes/knobs either. Should I move this back to a file-private define that isn't documented in knobs? From dev-thomasbishop@example.net Wed Jun 1 14:11:25 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 213EB6053 for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:11:25 +0000 (UTC) Received: (qmail 36492 invoked by uid 500); 1 Jun 2011 14:11:24 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 36464 invoked by uid 500); 1 Jun 2011 14:11:24 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 36456 invoked by uid 99); 1 Jun 2011 14:11:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:11:24 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-wy0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:11:17 +0000 Received: by wyb32 with SMTP id 32so5985482wyb.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:10:56 -0700 (PDT) Received: by 83.161.120.155 with SMTP id y47mr5018053wes.55.1306937456549; Wed, 01 Jun 2011 07:10:56 -0700 (PDT) Received: from [83.161.120.155] (cpc3-newt6-0-0-cust796.newt.cable.virginmedia.com [83.161.120.155]) by mx.google.com with ESMTPS id z22sm653905weq.26.283.161.120.155.10.54 (version=SSLv3 cipher=OTHER); Wed, 01 Jun 2011 07:10:55 -0700 (PDT) Subject: Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c From: Julian Foad <thomasbishop@example.net> To: Johan Corveleyn <thomasbishop@example.net> Cc: thomasbishop@example.net In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Jun 2011 15:10:53 +0100 Message-ID: <1306937453.20888.655.camel@edith> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On Wed, 2011-06-01 at 01:39 +0200, Johan Corveleyn wrote: > On Wed, Jun 1, 2011 at 1:22 AM, Stefan Sperling <thomasbishop@example.net> wrote: > > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: > >> [[[ > >> The usual namespace rules apply: only names that begin with "SVN_" > >> and don't contain double underscores are considered part of the public > >> API. Everything else is not officially supported. > >> ]]] > >> > >> Thinking: "I don't think this should be part of the public API", so I > >> can just dispense with the "SVN_" prefix. > > > > In this case I would advocate for SVN__DISABLE_PREFIX_SUFFIX_SCANNING :) > > You're right that it doesn't need to be part of the public API. > > I went for SVN_DISABLE_PREFIX_SUFFIX_SCANNING in the end (r1129965). > Who knows, maybe it can prove useful someday, if some special build > needs to disable this f.i. because it has problems with the seeking > around of the prefix/suffix scanning (jumping to the end of the file, > then jumping to the start again) or something ... I think the implication that these #defines are considered part of the public API is not true. This one's purpose is definitely private (debugging/testing/optimising); there's no point in speculating that it might turn out to be useful. - Julian From dev-thomasbishop@example.net Wed Jun 1 14:15:19 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 5B8C1659D for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:15:19 +0000 (UTC) Received: (qmail 47611 invoked by uid 500); 1 Jun 2011 14:15:19 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 47584 invoked by uid 500); 1 Jun 2011 14:15:19 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 47576 invoked by uid 99); 1 Jun 2011 14:15:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:15:19 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-iy0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:15:13 +0000 Received: by iyi20 with SMTP id 20so6916114iyi.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=Klw59Av69AWsCUZx76Rg4eZhcboa0KOUsNHuLnwbRIc=; b=q4ttzgvybqvwAbvAySOzxLyudj2D0h35kRRliNahinsXog5V/vtyubRyofgt5mVUCB ub1bqTkyStX3DS4Rq5yOCg9AMk7zBHY0ri8GDNgPAQpgCpaK59o7nWFo1AECt3re8GmW IJoy2qiLZgwwry/6c5dOr4Eb/LwDW8RebQRtg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=nSsM96xXqT3uif/BHdJIomLyqHSW1nQlJZAzcZVaJlsEqfR0wNrFBncYvWBGGcuZiz 0gjI3p12kncsg4IREc5BnASx57iFQK8ebHoIE74Dl6YwW3GLlTBX35a/kPwteZzgVV1E gD+ScW3EpN5WuIWoHoHg+Dlm10vg5KEBWB5WQ= Received: by 83.161.120.155 with SMTP id 12mr11790364icg.357.1306937692084; Wed, 01 Jun 2011 07:14:52 -0700 (PDT) MIME-Version: 1.0 Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 07:14:32 -0700 (PDT) In-Reply-To: <1306937453.20888.655.camel@edith> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <1306937453.20888.655.camel@edith> From: Johan Corveleyn <thomasbishop@example.net> Date: Wed, 1 Jun 2011 16:14:32 +0200 Message-ID: <thomasbishop@example.net> Subject: Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c To: Julian Foad <thomasbishop@example.net> Cc: thomasbishop@example.net Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On Wed, Jun 1, 2011 at 4:10 PM, Julian Foad <thomasbishop@example.net> wrote: > On Wed, 2011-06-01 at 01:39 +0200, Johan Corveleyn wrote: >> On Wed, Jun 1, 2011 at 1:22 AM, Stefan Sperling <thomasbishop@example.net> wrote: >> > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: >> >> [[[ >> >> The usual namespace rules apply: only names that begin with "SVN_" >> >> and don't contain double underscores are considered part of the public >> >> API. Everything else is not officially supported. >> >> ]]] >> >> >> >> Thinking: "I don't think this should be part of the public API", so I >> >> can just dispense with the "SVN_" prefix. >> > >> > In this case I would advocate for SVN__DISABLE_PREFIX_SUFFIX_SCANNING :) >> > You're right that it doesn't need to be part of the public API. >> >> I went for SVN_DISABLE_PREFIX_SUFFIX_SCANNING in the end (r1129965). >> Who knows, maybe it can prove useful someday, if some special build >> needs to disable this f.i. because it has problems with the seeking >> around of the prefix/suffix scanning (jumping to the end of the file, >> then jumping to the start again) or something ... > > I think the implication that these #defines are considered part of the > public API is not true. > > This one's purpose is definitely private (debugging/testing/optimising); > there's no point in speculating that it might turn out to be useful. Ok, I guess you're right. But then I'll still leave it with "SVN_" prefix, because that doesn't imply anything (as you say), and it's consistent with most other #defines in knobs. -- Johan From dev-thomasbishop@example.net Wed Jun 1 14:23:19 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id C2BE261D8 for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:23:19 +0000 (UTC) Received: (qmail 71798 invoked by uid 500); 1 Jun 2011 14:23:19 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 71771 invoked by uid 500); 1 Jun 2011 14:23:19 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 71763 invoked by uid 99); 1 Jun 2011 14:23:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:23:19 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-vx0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:23:12 +0000 Received: by vxc40 with SMTP id 40so6581038vxc.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=fNBUaHRS8uJRWhVS7Bonq23HRu5MRkXZ2+OZG2mNZgE=; b=UTCMC9clrq/Ox2ivrnIxcHKJPKLVhhtOgXt/G/Wg2/8AAAOp+NIsd9P60KzFk5ONTY K68RWK9PXMtISRreKHiuBcuXPbe7YjnSjVjITnCr/BL/8CNsodX+IIchT3Y8SWCY6tUp 0MXZayVBy2EDdH9FZbCs8jQD1zBW1lZa8uQ5g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=cxrOeKFApztysUPqvwPhvXBXhAXMQBomLmiH6slCcAnIbq6uOBCrV18hrYzq1rz0+G Xmsx8ZcuMvUGypwcOHT3rKwhmI63QMgrghwel3tO+mwqPGXrpGiRRBVuRHvEBnvD0Uky fllv2UeJKEoKvpigmuBbNElYFEG6i32XkpCco= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id bt16mr1126758vdb.141.1306938171650; Wed, 01 Jun 2011 07:22:51 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 07:22:51 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 07:22:51 -0700 (PDT) In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> Date: Wed, 1 Jun 2011 10:22:51 -0400 Message-ID: <thomasbishop@example.net> Subject: Re: svn commit: r1129980 - /subversion/trunk/notes/knobs From: Greg Stein <thomasbishop@example.net> To: thomasbishop@example.net Content-Type: multipart/alternative; boundary=bcaec50160cb76f2d604a4a7414c X-Virus-Checked: Checked by ClamAV on apache.org --bcaec50160cb76f2d604a4a7414c Content-Type: text/plain; charset=ISO-8859-1 On Jun 1, 2011 10:09 AM, "Stefan Sperling" <thomasbishop@example.net> wrote: > > On Wed, Jun 01, 2011 at 09:57:24AM -0400, Greg Stein wrote: > > I had a define in workqueue.c that somebody recently prefixed with SVN_. > > That was me. > > > I never intended it to be part of *any* API. just a little helper for us devs. > > Yet now it shows up in knobs, and is an "official API"?!? > > > > Seems we may want to reconsider how stuff magically becomes a "knob". > > I don't really see the point of documenting this define in notes/knobs > either. Should I move this back to a file-private define that isn't > documented in knobs? No need to rename it (either name would be valid in that file), but yanking it from knobs makes sense to me. Cheers, -g --bcaec50160cb76f2d604a4a7414c-- From dev-thomasbishop@example.net Wed Jun 1 14:24:25 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 9EA5261EA for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:24:25 +0000 (UTC) Received: (qmail 73333 invoked by uid 500); 1 Jun 2011 14:24:25 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 73306 invoked by uid 500); 1 Jun 2011 14:24:25 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 73298 invoked by uid 99); 1 Jun 2011 14:24:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:24:25 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of thomasbishop@example.net designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-vx0-f171.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:24:18 +0000 Received: by vxc40 with SMTP id 40so6582991vxc.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=CXrROUyQurOtCdnCfqAQWkfLbEG9MFWPdiWjFJirxJc=; b=xbrNR0YbupxG2DVUzsqJsZ0SaEFVTtA8g5N/Ept7pcGMelS/dAO1kUufQ7n2MRuPVU WjFSzS7nSVh28fqygndY1VO/OfTfLcSXZB5SGNiAN1fLIk2byZq6PrkUmt8WAlDD4RWl vQGVru1UfODk7Bm/BvCyFd9CmkBSScO1Yx5UU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=O8YTcuVjIlvWoajBOoitztFl7BnpUcb5czWWP9a2hvjw0eT+kBedFPPGdRtAOB4RBf gNezERUjoFcZsVLk2Pg6R6Jmst6hOnJm/sQ0LZAa5Gn1Jw+XzMWrgMueCnsURoQL50xc C6KBzT6u1IOIVXaF319BuvYohFwxk6JlzWeDc= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id z5mr1617898vdv.261.1306938237678; Wed, 01 Jun 2011 07:23:57 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 07:23:57 -0700 (PDT) Received: by 83.161.120.155 with HTTP; Wed, 1 Jun 2011 07:23:57 -0700 (PDT) In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> Date: Wed, 1 Jun 2011 10:23:57 -0400 Message-ID: <thomasbishop@example.net> Subject: Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c From: Greg Stein <thomasbishop@example.net> To: thomasbishop@example.net Content-Type: multipart/alternative; boundary=bcaec5015dd366739b04a4a74557 X-Virus-Checked: Checked by ClamAV on apache.org --bcaec5015dd366739b04a4a74557 Content-Type: text/plain; charset=ISO-8859-1 On Jun 1, 2011 10:01 AM, "Stefan Sperling" <thomasbishop@example.net> wrote: > > On Wed, Jun 01, 2011 at 09:43:35AM -0400, Greg Stein wrote: > > On Jun 1, 2011 8:02 AM, <thomasbishop@example.net> wrote: > > > > > > Author: julianfoad > > > Date: Wed Jun 1 12:02:32 2011 > > > New Revision: 1130118 > > > > > > URL: http://svn.apache.org/viewvc?rev=1130118&view=rev > > > Log: > > > Rename svn_stream_buffered() and related symbols to ...is_buffered... for > > > clarity. > > > > It seems this API is only around to support stream_readline(). Is it really > > worthwhile to expose this for a single callpoint? > > I'd say we should move this into private/svn_io_private.h. Sounds good to me. Maybe with those other few that Julian just mentioned. Cheers, -g --bcaec5015dd366739b04a4a74557-- From dev-thomasbishop@example.net Wed Jun 1 14:29:39 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 92F0F63DB for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:29:39 +0000 (UTC) Received: (qmail 81576 invoked by uid 500); 1 Jun 2011 14:29:39 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 81548 invoked by uid 500); 1 Jun 2011 14:29:39 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 81539 invoked by uid 99); 1 Jun 2011 14:29:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:29:39 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO out3.smtp.messagingengine.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:29:33 +0000 Received: from compute6.internal (compute6.nyi.mail.srv.osa [83.161.120.155]) by gateway1.messagingengine.com (Postfix) with ESMTP id 9E62720874; Wed, 1 Jun 2011 10:29:12 -0400 (EDT) Received: from frontend1.messagingengine.com ([83.161.120.155]) by compute6.internal (MEProxy); Wed, 01 Jun 2011 10:29:12 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to; s=smtpout; bh=m8fQXfDwRO3ScPmoeLIG5Jfvkio=; b=a8n6jcOP9tTNAsyO72/F2N2iHI8iPY7s/OGr7eIRyIaWCDO9ZhHpsBMBLE72saxvmi0w6MgylQUQtrW1aNOzTwiaG2CmfQLZ3UyRuxfwXz4hA9ymTl91IGmGFqzmR2hspCL7r5+bDSu/E5XtnH0AikJxnWF5v2yGtOrCXap9LI0= X-Sasl-enc: bLySmivEcT+kdQcBRQk1S4+fRKTzIbIZhB+YbxrIdI5dycsrJih1ZHzJyUQtTw 1306938551 Received: from daniel3.local (bzq-109-65-248-107.red.bezeqint.net [83.161.120.155]) by mail.messagingengine.com (Postfix) with ESMTPSA id CAD02409D0E; Wed, 1 Jun 2011 10:29:10 -0400 (EDT) Date: Wed, 1 Jun 2011 17:28:59 +0300 From: Daniel Shahaf <thomasbishop@example.net> To: Greg Stein <thomasbishop@example.net> Cc: thomasbishop@example.net Subject: Re: svn commit: r1129980 - /subversion/trunk/notes/knobs Message-ID: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <thomasbishop@example.net> User-Agent: Mutt/1.5.20 (2009-06-14) Greg Stein wrote on Wed, Jun 01, 2011 at 10:22:51 -0400: > On Jun 1, 2011 10:09 AM, "Stefan Sperling" <thomasbishop@example.net> wrote: > > > > On Wed, Jun 01, 2011 at 09:57:24AM -0400, Greg Stein wrote: > > > I had a define in workqueue.c that somebody recently prefixed with SVN_. > > > > That was me. > > > > > I never intended it to be part of *any* API. just a little helper for us > devs. > > > Yet now it shows up in knobs, and is an "official API"?!? > > > > > > Seems we may want to reconsider how stuff magically becomes a "knob". > > > > I don't really see the point of documenting this define in notes/knobs > > either. Should I move this back to a file-private define that isn't > > documented in knobs? > > No need to rename it (either name would be valid in that file), but yanking > it from knobs makes sense to me. > knobs can list both public and developer-only macros... if we want it to list just public macros let's rm the file and add a section to the doxygen docs. > Cheers, > -g From dev-thomasbishop@example.net Wed Jun 1 14:32:21 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 598F16F2F for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:32:21 +0000 (UTC) Received: (qmail 89415 invoked by uid 500); 1 Jun 2011 14:32:21 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 89359 invoked by uid 500); 1 Jun 2011 14:32:21 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 89351 invoked by uid 99); 1 Jun 2011 14:32:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:32:21 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO out3.smtp.messagingengine.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:32:15 +0000 Received: from compute5.internal (compute5.nyi.mail.srv.osa [83.161.120.155]) by gateway1.messagingengine.com (Postfix) with ESMTP id 0D40620248; Wed, 1 Jun 2011 10:31:49 -0400 (EDT) Received: from frontend1.messagingengine.com ([83.161.120.155]) by compute5.internal (MEProxy); Wed, 01 Jun 2011 10:31:49 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=date:from:to:cc:subject:message-id:references:mime-version:content-type:in-reply-to; s=smtpout; bh=685vNazLxy+a0cyif95YYL1gVts=; b=RtAy419AS8Wcg5gUEJQ9lVQ/IEJvRXQGGzl5WBbQ1GoE/Ku1BfmGOD2SaroIQL7ZB4rRCH2Licd4seff5m18zAUW1SRk1GxdT3Nb/goLABUQ9zpRt8YX+0wxDGCXMbMMrB1yjwmiLPpaUXwlfJ9pnzgLEPu4EIpVe9Qcnp5H+oI= X-Sasl-enc: 9f6O5AXZXo6lLUPE+TwNSOmRl1omJ1rP3yHExOFgWRap2Kag8MfOVPbKuNHY7g 1306938708 Received: from daniel3.local (bzq-109-65-248-107.red.bezeqint.net [83.161.120.155]) by mail.messagingengine.com (Postfix) with ESMTPSA id 53518409D41; Wed, 1 Jun 2011 10:31:47 -0400 (EDT) Date: Wed, 1 Jun 2011 17:31:37 +0300 From: Daniel Shahaf <thomasbishop@example.net> To: Johan Corveleyn <thomasbishop@example.net> Cc: Julian Foad <thomasbishop@example.net>, thomasbishop@example.net Subject: Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c Message-ID: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> <1306937453.20888.655.camel@edith> <thomasbishop@example.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <thomasbishop@example.net> User-Agent: Mutt/1.5.20 (2009-06-14) Johan Corveleyn wrote on Wed, Jun 01, 2011 at 16:14:32 +0200: > On Wed, Jun 1, 2011 at 4:10 PM, Julian Foad <thomasbishop@example.net> wrote: > > On Wed, 2011-06-01 at 01:39 +0200, Johan Corveleyn wrote: > >> On Wed, Jun 1, 2011 at 1:22 AM, Stefan Sperling <thomasbishop@example.net> wrote: > >> > On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: > >> >> [[[ > >> >> The usual namespace rules apply: only names that begin with "SVN_" > >> >> and don't contain double underscores are considered part of the public > >> >> API. Everything else is not officially supported. > >> >> ]]] > >> >> > >> >> Thinking: "I don't think this should be part of the public API", so I > >> >> can just dispense with the "SVN_" prefix. > >> > > >> > In this case I would advocate for SVN__DISABLE_PREFIX_SUFFIX_SCANNING :) > >> > You're right that it doesn't need to be part of the public API. > >> > >> I went for SVN_DISABLE_PREFIX_SUFFIX_SCANNING in the end (r1129965). > >> Who knows, maybe it can prove useful someday, if some special build > >> needs to disable this f.i. because it has problems with the seeking > >> around of the prefix/suffix scanning (jumping to the end of the file, > >> then jumping to the start again) or something ... > > > > I think the implication that these #defines are considered part of the > > public API is not true. > > > > This one's purpose is definitely private (debugging/testing/optimising); > > there's no point in speculating that it might turn out to be useful. > > Ok, I guess you're right. But then I'll still leave it with "SVN_" > prefix, because that doesn't imply anything (as you say), and it's > consistent with most other #defines in knobs. If it's not public, then IMO it should get the double-underscore treatment. The goal is the same as for API functions: to make it easier to see from the name of a symbol whether it's a public API or not. From dev-thomasbishop@example.net Wed Jun 1 14:40:47 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id 4D5D06E96 for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:40:47 +0000 (UTC) Received: (qmail 5904 invoked by uid 500); 1 Jun 2011 14:40:46 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 5850 invoked by uid 500); 1 Jun 2011 14:40:46 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 5832 invoked by uid 99); 1 Jun 2011 14:40:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:40:46 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-ww0-f47.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:40:37 +0000 Received: by wwk4 with SMTP id 4so4894809wwk.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:40:17 -0700 (PDT) Received: by 83.161.120.155 with SMTP id er18mr7495207wbb.63.1306939217571; Wed, 01 Jun 2011 07:40:17 -0700 (PDT) Received: from [83.161.120.155] (cpc3-newt6-0-0-cust796.newt.cable.virginmedia.com [83.161.120.155]) by mx.google.com with ESMTPS id et5sm794197wbb.16.283.161.120.155.40.15 (version=SSLv3 cipher=OTHER); Wed, 01 Jun 2011 07:40:16 -0700 (PDT) Subject: Re: svn commit: r1072519 - Add svn_stream_skip(), svn_stream_buffered(), svn_stream_supports_mark() From: Julian Foad <thomasbishop@example.net> To: thomasbishop@example.net Cc: thomasbishop@example.net In-Reply-To: <1306937282.20888.651.camel@edith> References: <thomasbishop@example.net> <1306937282.20888.651.camel@edith> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Jun 2011 15:40:14 +0100 Message-ID: <1306939214.20888.686.camel@edith> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org I (Julian Foad) wrote: > On Sun, 2011-02-20, thomasbishop@example.net wrote: > > Merge all changes (r1068695 - r1072516) from the > > integrate-stream-api-extensions. > > > > These patches add svn_stream_skip(), svn_stream_buffered() > > and svn_stream_supports_mark(). > > A belated review. And some more. > static svn_error_t * > skip_handler_apr(void *baton, apr_size_t *count) > { > struct baton_apr *btn = baton; > apr_off_t offset = *count; > apr_off_t new_pos = *count; > apr_off_t current = 0; > svn_error_t *err; > > /* so far, we have not moved anything */ > *count = 0; > > SVN_ERR(svn_io_file_seek(btn->file, APR_CUR, &current, btn->pool)); > err = svn_io_file_seek(btn->file, APR_CUR, &new_pos, btn->pool); > > /* Irrespective of errors, return the number of bytes we actually moved. > * If no new position has been returned from seek(), assume that no move > * happend and keep the *count==0 set earlier. > */ > if ((offset != new_pos) || (current == 0)) It doesn't make sense to compare 'offset' with 'new_pos', because the former is a relative position and the latter an absolute position. And comparing 'current' with 0 doesn't seem relevant: if the first seek failed, we'd not still be in this function because an error would have been raised. If the second seek returns an error you can't trust the value of 'new_pos', unless we're relying on undocumented behaviour. So I think what you want here is simply: if (! err) and remove the doc-string promise that you'll return the current position in the event of an error. And then the 'count' parameter can be just an input parameter rather than in/out. > *count = (apr_size_t)(new_pos - current); > > return err; > } - Julian From dev-thomasbishop@example.net Wed Jun 1 14:45:49 2011 Return-Path: <dev-thomasbishop@example.net> X-Original-To: thomasbishop@example.net Delivered-To: thomasbishop@example.net Received: from mail.apache.org (hermes.apache.org [83.161.120.155]) by minotaur.apache.org (Postfix) with SMTP id C9EDF64E5 for <thomasbishop@example.net>; Wed, 1 Jun 2011 14:45:49 +0000 (UTC) Received: (qmail 22901 invoked by uid 500); 1 Jun 2011 14:45:49 -0000 Delivered-To: thomasbishop@example.net Received: (qmail 22875 invoked by uid 500); 1 Jun 2011 14:45:49 -0000 Mailing-List: contact thomasbishop@example.net; run by ezmlm Precedence: bulk List-Help: <mailto:thomasbishop@example.net> List-Unsubscribe: <mailto:thomasbishop@example.net> List-Post: <mailto:thomasbishop@example.net> List-Id: <dev.subversion.apache.org> Delivered-To: mailing list thomasbishop@example.net Received: (qmail 22867 invoked by uid 99); 1 Jun 2011 14:45:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:45:49 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-ww0-f47.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 14:45:42 +0000 Received: by wwk4 with SMTP id 4so4898840wwk.16 for <thomasbishop@example.net>; Wed, 01 Jun 2011 07:45:21 -0700 (PDT) Received: by 83.161.120.155 with SMTP id p45mr7031816wej.61.1306939521717; Wed, 01 Jun 2011 07:45:21 -0700 (PDT) Received: from [83.161.120.155] (cpc3-newt6-0-0-cust796.newt.cable.virginmedia.com [83.161.120.155]) by mx.google.com with ESMTPS id 77sm675273wet.9.283.161.120.155.45.20 (version=SSLv3 cipher=OTHER); Wed, 01 Jun 2011 07:45:20 -0700 (PDT) Subject: Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c From: Julian Foad <thomasbishop@example.net> To: Greg Stein <thomasbishop@example.net> Cc: thomasbishop@example.net In-Reply-To: <thomasbishop@example.net> References: <thomasbishop@example.net> <thomasbishop@example.net> <thomasbishop@example.net> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Jun 2011 15:45:19 +0100 Message-ID: <1306939519.20888.690.camel@edith> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On Wed, 2011-06-01 at 10:23 -0400, Greg Stein wrote: > On Jun 1, 2011 10:01 AM, "Stefan Sperling" <thomasbishop@example.net> wrote: > > >
{'source': 'Apache Software Foundation Public Mail Archives'}