From commonscassandrawright@example.org Fri Jan 01 07:09:18 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 80225 invoked from network); 1 Jan 2010 07:09:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Jan 2010 07:09:18 -0000 Received: (qmail 96230 invoked by uid 500); 1 Jan 2010 07:09:18 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 96140 invoked by uid 500); 1 Jan 2010 07:09:17 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 96130 invoked by uid 99); 1 Jan 2010 07:09:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jan 2010 07:09:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jan 2010 07:09:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id D6FD4234C045 for <cassandrawright@example.org>; Thu, 31 Dec 2009 23:08:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Fri, 1 Jan 2010 07:08:54 +0000 (UTC) From: "Dunith Dhanushka (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Updated: (WSCOMMONS-514) Stomp transport for WS-Commons project In-Reply-To: <{{EMAIL+PHONE}}> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dunith Dhanushka updated WSCOMMONS-514: --------------------------------------- Attachment: UserGuide.pdf I think this user guide may help you to build, configure and run Stomp transport with Apache Axis2. > Stomp transport for WS-Commons project > -------------------------------------- > > Key: WSCOMMONS-514 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-514 > Project: WS-Commons > Issue Type: New Feature > Components: Transport > Affects Versions: Transports 1.1 > Environment: Developed this transport on Ubuntu 9.10 (Karmic) and JDK 1.6 > Reporter: Dunith Dhanushka > Attachments: axis2-transport-stomp.patch, UserGuide.pdf > > > This is a new Stomp transport for the WS-Commons transport project. This will enable any Stomp client to invoke a web service hosted in Apache axis2 through a Stomp supported message broker. Here I used Apache ActiveMQ as the Stomp broker. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Fri Jan 01 10:16:22 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 8198 invoked from network); 1 Jan 2010 10:16:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 1 Jan 2010 10:16:22 -0000 Received: (qmail 25772 invoked by uid 500); 1 Jan 2010 10:16:22 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 25690 invoked by uid 500); 1 Jan 2010 10:16:22 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 25680 invoked by uid 99); 1 Jan 2010 10:16:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jan 2010 10:16:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jan 2010 10:16:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 8778C234C495 for <cassandrawright@example.org>; Fri, 1 Jan 2010 02:15:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Fri, 1 Jan 2010 10:15:54 +0000 (UTC) From: "Andreas Veithen (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Commented: (WSCOMMONS-489) StAXUtils incorrectly assumes that XMLInputFactory and XMLOutputFactory instances are thread safe In-Reply-To: <842257981.1247262074996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795743#action_12795743 ] Andreas Veithen commented on WSCOMMONS-489: ------------------------------------------- Ben, There have been too many changes between 1.2.7 and HEAD in the part of the code affected by this fix (for example, the entire StAX dialect mechanism is new in 1.2.9), so that backporting the change using individual patches is not feasible. What is actually preventing you from using 1.2.9-SNAPSHOT? Andreas > StAXUtils incorrectly assumes that XMLInputFactory and XMLOutputFactory instances are thread safe > ------------------------------------------------------------------------------------------------- > > Key: WSCOMMONS-489 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-489 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Affects Versions: Axiom 1.2.8 > Reporter: Andreas Veithen > Assignee: Andreas Veithen > Fix For: Axiom 1.2.9 > > > StAXUtil uses a single XMLInputFactory or XMLOutputFactory instance (per classloader). This means that it makes the assumption that these instances are thread safe. However, there is nothing in the StAX specs that guarantees that, and Sun's implementation in JDK 6 is not thread safe, at least with the default properties [1] [2]. > [1] http://www.java2s.com/Open-Source/Java-Document/6.0-JDK-Modules-com.sun/xml/com/sun/xml/internal/stream/XMLInputFactoryImpl.java.htm > [2] http://www.java2s.com/Open-Source/Java-Document/6.0-JDK-Modules-com.sun/xml/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java.htm -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Sun Jan 03 12:30:18 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 54859 invoked from network); 3 Jan 2010 12:30:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2010 12:30:18 -0000 Received: (qmail 5449 invoked by uid 500); 3 Jan 2010 12:30:18 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 5358 invoked by uid 500); 3 Jan 2010 12:30:17 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 5348 invoked by uid 99); 3 Jan 2010 12:30:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 12:30:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 12:30:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id AE533234C48C for <cassandrawright@example.org>; Sun, 3 Jan 2010 04:29:54 -0800 (PST) Message-ID: <{{EMAIL+PHONE}}> Date: Sun, 3 Jan 2010 12:29:54 +0000 (UTC) From: "Andreas Veithen (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Commented: (WSCOMMONS-513) Behavior of insertSiblingAfter and insertSiblingBefore is not well defined for orphan nodes In-Reply-To: <cassandrawright@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795966#action_12795966 ] Andreas Veithen commented on WSCOMMONS-513: ------------------------------------------- The right behavior should be to throw an exception, i.e. DOOM should be modified to behave in the same way as LLOM. Rationale: Assume that a node would be allowed to have a sibling without having a parent. The siblings can only be serialized (together) if they are added to a document. Since adding a node to document necessarily removes the existing sibling relationship, it doesn't make sense to allow the creation of the sibling relationship in the first place. > Behavior of insertSiblingAfter and insertSiblingBefore is not well defined for orphan nodes > ------------------------------------------------------------------------------------------- > > Key: WSCOMMONS-513 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-513 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Affects Versions: Axiom 1.2.8 > Reporter: Andreas Veithen > Assignee: Andreas Veithen > Priority: Minor > Fix For: Axiom 1.2.9 > > > The behavior of OMNode#insertSiblingAfter and OMNode#insertSiblingBefore is not well defined if the node has no parent: > - LLOM: throws OMException ("Parent can not be null"). > - DOOM in Axiom < 1.2.8: silently accepts the call. > - DOOM in Axiom 1.2.8: throws NPE (see AXIS2-4514). > The behavior needs to be clearly specified and made consistent between LLOM and DOOM. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Sun Jan 03 13:30:18 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 74089 invoked from network); 3 Jan 2010 13:30:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2010 13:30:18 -0000 Received: (qmail 35982 invoked by uid 500); 3 Jan 2010 13:30:17 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 35899 invoked by uid 500); 3 Jan 2010 13:30:17 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 35889 invoked by uid 99); 3 Jan 2010 13:30:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 13:30:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 13:30:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 80ABE234C045 for <cassandrawright@example.org>; Sun, 3 Jan 2010 05:29:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Sun, 3 Jan 2010 13:29:54 +0000 (UTC) From: "Andreas Veithen (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Work started: (WSCOMMONS-513) Behavior of insertSiblingAfter and insertSiblingBefore is not well defined for orphan nodes In-Reply-To: <cassandrawright@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on WSCOMMONS-513 started by Andreas Veithen. > Behavior of insertSiblingAfter and insertSiblingBefore is not well defined for orphan nodes > ------------------------------------------------------------------------------------------- > > Key: WSCOMMONS-513 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-513 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Affects Versions: Axiom 1.2.8 > Reporter: Andreas Veithen > Assignee: Andreas Veithen > Priority: Minor > Fix For: Axiom 1.2.9 > > > The behavior of OMNode#insertSiblingAfter and OMNode#insertSiblingBefore is not well defined if the node has no parent: > - LLOM: throws OMException ("Parent can not be null"). > - DOOM in Axiom < 1.2.8: silently accepts the call. > - DOOM in Axiom 1.2.8: throws NPE (see AXIS2-4514). > The behavior needs to be clearly specified and made consistent between LLOM and DOOM. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Sun Jan 03 13:59:24 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 87026 invoked from network); 3 Jan 2010 13:59:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2010 13:59:24 -0000 Received: (qmail 45292 invoked by uid 500); 3 Jan 2010 13:59:23 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 45223 invoked by uid 500); 3 Jan 2010 13:59:23 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 45213 invoked by uid 99); 3 Jan 2010 13:59:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 13:59:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 13:59:13 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 33B2D2388901; Sun, 3 Jan 2010 13:58:52 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r895391 - in /webservices/commons/trunk/modules/axiom/modules: axiom-api/src/test/java/org/apache/axiom/om/ axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/ axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/ Date: Sun, 03 Jan 2010 13:58:51 -0000 To: cassandrawright@example.org From: cassandrawright@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <cassandrawright@example.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: veithen Date: Sun Jan 3 13:58:50 2010 New Revision: 895391 URL: http://svn.apache.org/viewvc?rev=895391&view=rev Log: Split OMElementTestBase and move the unit tests for methods defined by OMNode to a different class. Added: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java (with props) webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/NodeImplTest.java (with props) webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/OMNodeImplTest.java (with props) Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java?rev=895391&r1=895390&r2=895391&view=diff ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java (original) +++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMElementTestBase.java Sun Jan 3 13:58:50 2010 @@ -230,55 +230,6 @@ assertEquals("In correct number of children", 1, count); } - // Regression test for WSCOMMONS-337 - public void testInsertSiblingAfterLastChild() throws Exception { - OMFactory fac = omMetaFactory.getOMFactory(); - OMNamespace ns = fac.createOMNamespace("http://www.testuri.com","ns"); - OMElement parent = fac.createOMElement("parent", ns); - - // Create three OMElements - OMElement c1 = fac.createOMElement("c1", ns); - OMElement c2 = fac.createOMElement("c2", ns); - OMElement c3 = fac.createOMElement("c3", ns); - - // Add c1 to parent using parent.addChild() - parent.addChild(c1); - // Add c2 to c1 as a sibling after - c1.insertSiblingAfter(c2); - // Now add c3 to parent using parent.addChild() - parent.addChild(c3); - assertXMLEqual("<ns:parent xmlns:ns=\"http://www.testuri.com\">" + - "<ns:c1 /><ns:c2 /><ns:c3 /></ns:parent>", parent.toString()); - } - - private void testDetach(boolean build) throws Exception { - OMElement root = AXIOMUtil.stringToOM(omMetaFactory.getOMFactory(), "<root><a/><b/><c/></root>"); - if (build) { - root.build(); - } else { - assertFalse(root.isComplete()); - } - OMElement a = (OMElement)root.getFirstOMChild(); - assertEquals("a", a.getLocalName()); - OMElement b = (OMElement)a.getNextOMSibling(); - assertEquals("b", b.getLocalName()); - b.detach(); - assertNull(b.getParent()); - OMElement c = (OMElement)a.getNextOMSibling(); - assertEquals("c", c.getLocalName()); - assertSame(c, a.getNextOMSibling()); - assertSame(a, c.getPreviousOMSibling()); - root.close(false); - } - - public void testDetachWithBuild() throws Exception { - testDetach(true); - } - - public void testDetachWithoutBuild() throws Exception { - testDetach(false); - } - public void testFindNamespaceByPrefix() throws Exception { OMElement root = AXIOMUtil.stringToOM(omMetaFactory.getOMFactory(), "<a:root xmlns:a='urn:a'><child/></a:root>"); Added: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java?rev=895391&view=auto ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java (added) +++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java Sun Jan 3 13:58:50 2010 @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.axiom.om; + +import org.apache.axiom.om.util.AXIOMUtil; + +public class OMNodeTestBase extends AbstractTestCase { + protected final OMMetaFactory omMetaFactory; + + public OMNodeTestBase(OMMetaFactory omMetaFactory) { + this.omMetaFactory = omMetaFactory; + } + + // Regression test for WSCOMMONS-337 + public void testInsertSiblingAfterLastChild() throws Exception { + OMFactory fac = omMetaFactory.getOMFactory(); + OMNamespace ns = fac.createOMNamespace("http://www.testuri.com","ns"); + OMElement parent = fac.createOMElement("parent", ns); + + // Create three OMElements + OMElement c1 = fac.createOMElement("c1", ns); + OMElement c2 = fac.createOMElement("c2", ns); + OMElement c3 = fac.createOMElement("c3", ns); + + // Add c1 to parent using parent.addChild() + parent.addChild(c1); + // Add c2 to c1 as a sibling after + c1.insertSiblingAfter(c2); + // Now add c3 to parent using parent.addChild() + parent.addChild(c3); + assertXMLEqual("<ns:parent xmlns:ns=\"http://www.testuri.com\">" + + "<ns:c1 /><ns:c2 /><ns:c3 /></ns:parent>", parent.toString()); + } + + private void testDetach(boolean build) throws Exception { + OMElement root = AXIOMUtil.stringToOM(omMetaFactory.getOMFactory(), "<root><a/><b/><c/></root>"); + if (build) { + root.build(); + } else { + assertFalse(root.isComplete()); + } + OMElement a = (OMElement)root.getFirstOMChild(); + assertEquals("a", a.getLocalName()); + OMElement b = (OMElement)a.getNextOMSibling(); + assertEquals("b", b.getLocalName()); + b.detach(); + assertNull(b.getParent()); + OMElement c = (OMElement)a.getNextOMSibling(); + assertEquals("c", c.getLocalName()); + assertSame(c, a.getNextOMSibling()); + assertSame(a, c.getPreviousOMSibling()); + root.close(false); + } + + public void testDetachWithBuild() throws Exception { + testDetach(true); + } + + public void testDetachWithoutBuild() throws Exception { + testDetach(false); + } + + +} Propchange: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java ------------------------------------------------------------------------------ svn:eol-style = native Added: webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/NodeImplTest.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/NodeImplTest.java?rev=895391&view=auto ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/NodeImplTest.java (added) +++ webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/NodeImplTest.java Sun Jan 3 13:58:50 2010 @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.axiom.om.impl.dom; + +import org.apache.axiom.om.OMNodeTestBase; +import org.apache.axiom.om.impl.dom.factory.OMDOMMetaFactory; + +public class NodeImplTest extends OMNodeTestBase { + public NodeImplTest() { + super(new OMDOMMetaFactory()); + } +} Propchange: webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/NodeImplTest.java ------------------------------------------------------------------------------ svn:eol-style = native Added: webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/OMNodeImplTest.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/OMNodeImplTest.java?rev=895391&view=auto ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/OMNodeImplTest.java (added) +++ webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/OMNodeImplTest.java Sun Jan 3 13:58:50 2010 @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.axiom.om.impl.llom; + +import org.apache.axiom.om.OMNodeTestBase; +import org.apache.axiom.om.impl.llom.factory.OMLinkedListMetaFactory; + +public class OMNodeImplTest extends OMNodeTestBase { + public OMNodeImplTest() { + super(new OMLinkedListMetaFactory()); + } +} Propchange: webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/test/java/org/apache/axiom/om/impl/llom/OMNodeImplTest.java ------------------------------------------------------------------------------ svn:eol-style = native From commonscassandrawright@example.org Sun Jan 03 14:22:02 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 98196 invoked from network); 3 Jan 2010 14:22:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2010 14:22:02 -0000 Received: (qmail 58929 invoked by uid 500); 3 Jan 2010 14:22:02 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 58856 invoked by uid 500); 3 Jan 2010 14:22:02 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 58846 invoked by uid 99); 3 Jan 2010 14:22:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 14:22:02 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 14:22:01 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 218BF23889B6; Sun, 3 Jan 2010 14:21:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r895397 - in /webservices/commons/trunk/modules/axiom/modules: axiom-api/src/main/java/org/apache/axiom/om/ axiom-api/src/test/java/org/apache/axiom/om/ axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ Date: Sun, 03 Jan 2010 14:21:40 -0000 To: cassandrawright@example.org From: cassandrawright@example.org X-Mailer: svnmailer-1.0.8 Message-Id: <cassandrawright@example.org> Author: veithen Date: Sun Jan 3 14:21:40 2010 New Revision: 895397 URL: http://svn.apache.org/viewvc?rev=895397&view=rev Log: WSCOMMONS-513: Clarified the expected behavior of OMNode#insertSibling(Before|After), changed the behavior of these methods in DOOM (to match the behavior of LLOM) and added a couple of unit tests to enforce the behavior. Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java?rev=895397&r1=895396&r2=895397&view=diff ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java (original) +++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMNode.java Sun Jan 3 14:21:40 2010 @@ -140,18 +140,26 @@ void discard() throws OMException; /** - * Inserts a new sibling after the current node. - * - * @param sibling The node that will be added after the current node. + * Inserts a new sibling after the current node. The current node must have a parent for this + * operation to succeed. If the node to be inserted has a parent, then it will first be + * detached. + * + * @param sibling + * The node that will be added after the current node. * @throws OMException + * if the current node has no parent */ void insertSiblingAfter(OMNode sibling) throws OMException; /** - * Inserts a sibling just before the current node. - * - * @param sibling The node that will be added before the current node. + * Inserts a sibling just before the current node. The current node must have a parent for this + * operation to succeed. If the node to be inserted has a parent, then it will first be + * detached. + * + * @param sibling + * The node that will be added before the current node. * @throws OMException + * if the current node has no parent */ void insertSiblingBefore(OMNode sibling) throws OMException; Modified: webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java?rev=895397&r1=895396&r2=895397&view=diff ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java (original) +++ webservices/commons/trunk/modules/axiom/modules/axiom-api/src/test/java/org/apache/axiom/om/OMNodeTestBase.java Sun Jan 3 14:21:40 2010 @@ -28,6 +28,27 @@ this.omMetaFactory = omMetaFactory; } + public void testInsertSiblingAfter() { + OMFactory fac = omMetaFactory.getOMFactory(); + OMElement parent = fac.createOMElement("test", null); + OMText text1 = fac.createOMText("text1"); + OMText text2 = fac.createOMText("text2"); + parent.addChild(text1); + text1.insertSiblingAfter(text2); + assertSame(parent, text2.getParent()); + } + + public void testInsertSiblingBefore() { + OMFactory fac = omMetaFactory.getOMFactory(); + OMElement parent = fac.createOMElement("test", null); + OMText text1 = fac.createOMText("text1"); + OMText text2 = fac.createOMText("text2"); + parent.addChild(text1); + text1.insertSiblingBefore(text2); + assertSame(parent, text2.getParent()); + assertSame(text2, parent.getFirstOMChild()); + } + // Regression test for WSCOMMONS-337 public void testInsertSiblingAfterLastChild() throws Exception { OMFactory fac = omMetaFactory.getOMFactory(); @@ -49,6 +70,30 @@ "<ns:c1 /><ns:c2 /><ns:c3 /></ns:parent>", parent.toString()); } + public void testInsertSiblingAfterOnOrphan() { + OMFactory fac = omMetaFactory.getOMFactory(); + OMText text1 = fac.createOMText("text1"); + OMText text2 = fac.createOMText("text2"); + try { + text1.insertSiblingAfter(text2); + fail("Expected OMException because node has no parent"); + } catch (OMException ex) { + // Expected + } + } + + public void testInsertSiblingBeforeOnOrphan() { + OMFactory fac = omMetaFactory.getOMFactory(); + OMText text1 = fac.createOMText("text1"); + OMText text2 = fac.createOMText("text2"); + try { + text1.insertSiblingBefore(text2); + fail("Expected OMException because node has no parent"); + } catch (OMException ex) { + // Expected + } + } + private void testDetach(boolean build) throws Exception { OMElement root = AXIOMUtil.stringToOM(omMetaFactory.getOMFactory(), "<root><a/><b/><c/></root>"); if (build) { Modified: webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java?rev=895397&r1=895396&r2=895397&view=diff ============================================================================== --- webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java (original) +++ webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ChildNode.java Sun Jan 3 14:21:40 2010 @@ -149,13 +149,12 @@ /** Inserts the given sibling next to this item. */ public void insertSiblingAfter(OMNode sibling) throws OMException { - - if (this.parentNode != null) { - ((OMNodeEx) sibling).setParent(this.parentNode); + if (this.parentNode == null) { + throw new OMException("Parent can not be null"); } else if (this == sibling) { throw new OMException("Inserting self as the sibling is not allowed"); } - + ((OMNodeEx) sibling).setParent(this.parentNode); if (sibling instanceof ChildNode) { ChildNode domSibling = (ChildNode) sibling; domSibling.previousSibling = this; @@ -176,7 +175,9 @@ /** Inserts the given sibling before this item. */ public void insertSiblingBefore(OMNode sibling) throws OMException { // ((OMNodeEx)sibling).setParent(this.parentNode); - if (this == sibling) { + if (this.parentNode == null) { + throw new OMException("Parent can not be null"); + } else if (this == sibling) { throw new OMException("Inserting self as the sibling is not allowed"); } if (sibling instanceof ChildNode) { From commonscassandrawright@example.org Sun Jan 03 14:24:17 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 98786 invoked from network); 3 Jan 2010 14:24:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 3 Jan 2010 14:24:17 -0000 Received: (qmail 61292 invoked by uid 500); 3 Jan 2010 14:24:17 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 61216 invoked by uid 500); 3 Jan 2010 14:24:17 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 61206 invoked by uid 99); 3 Jan 2010 14:24:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 14:24:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jan 2010 14:24:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 688D1234C045 for <cassandrawright@example.org>; Sun, 3 Jan 2010 06:23:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Sun, 3 Jan 2010 14:23:54 +0000 (UTC) From: "Andreas Veithen (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Resolved: (WSCOMMONS-513) Behavior of insertSiblingAfter and insertSiblingBefore is not well defined for orphan nodes In-Reply-To: <cassandrawright@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Veithen resolved WSCOMMONS-513. --------------------------------------- Resolution: Fixed > Behavior of insertSiblingAfter and insertSiblingBefore is not well defined for orphan nodes > ------------------------------------------------------------------------------------------- > > Key: WSCOMMONS-513 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-513 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Affects Versions: Axiom 1.2.8 > Reporter: Andreas Veithen > Assignee: Andreas Veithen > Priority: Minor > Fix For: Axiom 1.2.9 > > > The behavior of OMNode#insertSiblingAfter and OMNode#insertSiblingBefore is not well defined if the node has no parent: > - LLOM: throws OMException ("Parent can not be null"). > - DOOM in Axiom < 1.2.8: silently accepts the call. > - DOOM in Axiom 1.2.8: throws NPE (see AXIS2-4514). > The behavior needs to be clearly specified and made consistent between LLOM and DOOM. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Mon Jan 04 11:28:23 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 64348 invoked from network); 4 Jan 2010 11:28:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Jan 2010 11:28:19 -0000 Received: (qmail 77199 invoked by uid 500); 4 Jan 2010 11:28:18 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 77135 invoked by uid 500); 4 Jan 2010 11:28:18 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 76886 invoked by uid 99); 4 Jan 2010 11:28:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 11:28:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 11:28:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id E8343234C48D for <cassandrawright@example.org>; Mon, 4 Jan 2010 03:27:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Mon, 4 Jan 2010 11:27:54 +0000 (UTC) From: "Rajika Kumarasiri (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Created: (WSCOMMONS-515) Bug in isSessionTransacted() method in JMSConnectionFactory.java:255 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org Bug in isSessionTransacted() method in JMSConnectionFactory.java:255 -------------------------------------------------------------------- Key: WSCOMMONS-515 URL: https://issues.apache.org/jira/browse/WSCOMMONS-515 Project: WS-Commons Issue Type: Bug Components: Transport Reporter: Rajika Kumarasiri I think conditional check should changes as follows return parameters.get(JMSConstants.PARAM_SESSION_TRANSACTED) != null && in JMSConnectionFactory.java:255 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Mon Jan 04 11:30:55 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 64873 invoked from network); 4 Jan 2010 11:30:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Jan 2010 11:30:54 -0000 Received: (qmail 82653 invoked by uid 500); 4 Jan 2010 11:30:53 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 82566 invoked by uid 500); 4 Jan 2010 11:30:53 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 82556 invoked by uid 99); 4 Jan 2010 11:30:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 11:30:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 11:30:51 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 91D6929A0011 for <cassandrawright@example.org>; Mon, 4 Jan 2010 03:29:55 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Mon, 4 Jan 2010 11:29:55 +0000 (UTC) From: "Rajika Kumarasiri (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Updated: (WSCOMMONS-515) Bug in isSessionTransacted() method in JMSConnectionFactory.java:255 In-Reply-To: <cassandrawright@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajika Kumarasiri updated WSCOMMONS-515: ---------------------------------------- Attachment: WSCOMMONS-515.patch A patch which fix the problem. Please review it. Rajika > Bug in isSessionTransacted() method in JMSConnectionFactory.java:255 > -------------------------------------------------------------------- > > Key: WSCOMMONS-515 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-515 > Project: WS-Commons > Issue Type: Bug > Components: Transport > Reporter: Rajika Kumarasiri > Attachments: WSCOMMONS-515.patch > > > I think conditional check should changes as follows > return parameters.get(JMSConstants.PARAM_SESSION_TRANSACTED) != null && in JMSConnectionFactory.java:255 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Mon Jan 04 14:46:23 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 38574 invoked from network); 4 Jan 2010 14:46:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Jan 2010 14:46:23 -0000 Received: (qmail 18777 invoked by uid 500); 4 Jan 2010 14:46:22 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 18700 invoked by uid 500); 4 Jan 2010 14:46:22 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 18690 invoked by uid 99); 4 Jan 2010 14:46:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 14:46:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 14:46:15 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id A89BF29A0013 for <cassandrawright@example.org>; Mon, 4 Jan 2010 06:45:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Mon, 4 Jan 2010 14:45:54 +0000 (UTC) From: "Ben Reif (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Commented: (WSCOMMONS-489) StAXUtils incorrectly assumes that XMLInputFactory and XMLOutputFactory instances are thread safe In-Reply-To: <842257981.1247262074996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WSCOMMONS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796198#action_12796198 ] Ben Reif commented on WSCOMMONS-489: ------------------------------------ Andreas, Thanks for the quick reply. I guess technically nothing is preventing us from using the 1.2.9-SNAPSHOT. We are using Axis2 1.4 (which came with Axiom 1.2.7) and it's really more of a question of risk and how stable the Axiom1.2.9-SNAPSHOT is and also if it is compatible with Axis2 1.4. Would you be able to provide any feedback on this? Thanks, Ben > StAXUtils incorrectly assumes that XMLInputFactory and XMLOutputFactory instances are thread safe > ------------------------------------------------------------------------------------------------- > > Key: WSCOMMONS-489 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-489 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Affects Versions: Axiom 1.2.8 > Reporter: Andreas Veithen > Assignee: Andreas Veithen > Fix For: Axiom 1.2.9 > > > StAXUtil uses a single XMLInputFactory or XMLOutputFactory instance (per classloader). This means that it makes the assumption that these instances are thread safe. However, there is nothing in the StAX specs that guarantees that, and Sun's implementation in JDK 6 is not thread safe, at least with the default properties [1] [2]. > [1] http://www.java2s.com/Open-Source/Java-Document/6.0-JDK-Modules-com.sun/xml/com/sun/xml/internal/stream/XMLInputFactoryImpl.java.htm > [2] http://www.java2s.com/Open-Source/Java-Document/6.0-JDK-Modules-com.sun/xml/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java.htm -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Mon Jan 04 23:39:16 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 35770 invoked from network); 4 Jan 2010 23:39:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 4 Jan 2010 23:39:16 -0000 Received: (qmail 97846 invoked by uid 500); 4 Jan 2010 23:39:15 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 97765 invoked by uid 500); 4 Jan 2010 23:39:15 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 97755 invoked by uid 99); 4 Jan 2010 23:39:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 23:39:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jan 2010 23:39:14 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 9C94529A0012 for <cassandrawright@example.org>; Mon, 4 Jan 2010 15:38:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Mon, 4 Jan 2010 23:38:54 +0000 (UTC) From: "Scott Parkerson (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Created: (WSCOMMONS-516) Axiom Bundles are "named" the same, appear to be running twice in ServiceMix/Karaf MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Axiom Bundles are "named" the same, appear to be running twice in ServiceMix/Karaf ---------------------------------------------------------------------------------- Key: WSCOMMONS-516 URL: https://issues.apache.org/jira/browse/WSCOMMONS-516 Project: WS-Commons Issue Type: Bug Components: AXIOM Reporter: Scott Parkerson Priority: Trivial Clearly these are two different bundles, but their names don't have any differentiation when seen in the OSGi bundle list in Karaf: karaf@root> list . . . [ 108] [Active ] [ ] [ ] [ 60] Axiom API (1.2.7) [ 109] [Active ] [ ] [ ] [ 60] Axiom API (1.2.7) . . . karaf@root> headers 108 Axiom API (108) --------------- Manifest-Version = 1.0 Archiver-Version = Plexus Archiver Created-By = Apache Maven Built-By = dims Build-Jdk = 1.5.0_15 Bundle-License = http://www.apache.org/licenses/LICENSE-2.0.txt Import-Package = javax.activation,javax.xml.namespace,javax.xml.stream,org.apache.axiom.attachments.utils,org.apache.axiom.om,org.apache.axiom.om.impl,org.apache.axiom.om.impl.builder,org.apache.axiom.om.impl.exception,org.apache.axiom.om.impl.serialize,org.apache.axiom.om.impl.traverse,org.apache.axiom.om.impl.util,org.apache.axiom.om.util,org.apache.axiom.soap,org.apache.axiom.soap.impl.builder,org.apache.commons.logging Export-Package = org.apache.axiom.om.impl.llom.factory,org.apache.axiom.om.impl.llom.util,org.apache.axiom.om.impl.llom,org.apache.axiom.soap.impl.llom.soap11,org.apache.axiom.soap.impl.llom.soap12,org.apache.axiom.soap.impl.llom Bundle-Version = 1.2.7 Bundle-Name = Axiom API Bundle-DocURL = http://www.apache.org/ Bundle-ManifestVersion = 2 Bundle-Vendor = Apache Software Foundation Bundle-SymbolicName = org.apache.ws.commons.axiom.axiom-impl karaf@root> headers 109 Axiom API (109) --------------- Manifest-Version = 1.0 Archiver-Version = Plexus Archiver Created-By = Apache Maven Built-By = dims Build-Jdk = 1.5.0_15 Bundle-License = http://www.apache.org/licenses/LICENSE-2.0.txt Import-Package = javax.activation,javax.mail,javax.mail.internet,javax.xml.namespace,javax.xml.stream,org.apache.commons.logging,org.jaxen;resolution:=optional,org.jaxen.saxpath;resolution:=optional,org.jaxen.util;resolution:=optional,org.apache.axiom.om.impl.dom.factory;resolution:=optional,org.apache.axiom.soap.impl.dom.factory;resolution:=optional,org.apache.axiom.om.impl.llom.factory;resolution:=optional,org.w3c.dom,org.xml.sax,org.xml.sax.helpers Export-Package = org.apache.axiom.attachments.impl,org.apache.axiom.attachments.lifecycle.impl,org.apache.axiom.attachments.lifecycle,org.apache.axiom.attachments.utils,org.apache.axiom.attachments,org.apache.axiom.om.ds.custombuilder,org.apache.axiom.om.ds,org.apache.axiom.om.impl.builder,org.apache.axiom.om.impl.exception,org.apache.axiom.om.impl.serialize,org.apache.axiom.om.impl.traverse,org.apache.axiom.om.impl.util,org.apache.axiom.om.impl,org.apache.axiom.om.util,org.apache.axiom.om.xpath,org.apache.axiom.om,org.apache.axiom.soap.impl.builder,org.apache.axiom.soap Bundle-Version = 1.2.7 Bundle-Name = Axiom API Bundle-DocURL = http://www.apache.org/ Bundle-ManifestVersion = 2 Bundle-Vendor = Apache Software Foundation Bundle-SymbolicName = org.apache.ws.commons.axiom.axiom-api karaf@root> -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Tue Jan 05 00:25:16 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 49756 invoked from network); 5 Jan 2010 00:25:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 00:25:16 -0000 Received: (qmail 33463 invoked by uid 500); 5 Jan 2010 00:25:15 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 33396 invoked by uid 500); 5 Jan 2010 00:25:15 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 33386 invoked by uid 99); 5 Jan 2010 00:25:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 00:25:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 00:25:14 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 9D418234C48C for <cassandrawright@example.org>; Mon, 4 Jan 2010 16:24:54 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Tue, 5 Jan 2010 00:24:54 +0000 (UTC) From: "Andreas Veithen (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Resolved: (WSCOMMONS-516) Axiom Bundles are "named" the same, appear to be running twice in ServiceMix/Karaf In-Reply-To: <cassandrawright@example.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WSCOMMONS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Veithen resolved WSCOMMONS-516. --------------------------------------- Resolution: Fixed Fix Version/s: Axiom 1.2.9 OSGi support was completely rewritten shortly after the 1.2.8 release, and the Bundle-Names are correct in 1.2.9. > Axiom Bundles are "named" the same, appear to be running twice in ServiceMix/Karaf > ---------------------------------------------------------------------------------- > > Key: WSCOMMONS-516 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-516 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Reporter: Scott Parkerson > Priority: Trivial > Fix For: Axiom 1.2.9 > > > Clearly these are two different bundles, but their names don't have any differentiation when seen in the OSGi bundle list in Karaf: > karaf@root> list > . > . > . > [ 108] [Active ] [ ] [ ] [ 60] Axiom API (1.2.7) > [ 109] [Active ] [ ] [ ] [ 60] Axiom API (1.2.7) > . > . > . > karaf@root> headers 108 > Axiom API (108) > --------------- > Manifest-Version = 1.0 > Archiver-Version = Plexus Archiver > Created-By = Apache Maven > Built-By = dims > Build-Jdk = 1.5.0_15 > Bundle-License = http://www.apache.org/licenses/LICENSE-2.0.txt > Import-Package = javax.activation,javax.xml.namespace,javax.xml.stream,org.apache.axiom.attachments.utils,org.apache.axiom.om,org.apache.axiom.om.impl,org.apache.axiom.om.impl.builder,org.apache.axiom.om.impl.exception,org.apache.axiom.om.impl.serialize,org.apache.axiom.om.impl.traverse,org.apache.axiom.om.impl.util,org.apache.axiom.om.util,org.apache.axiom.soap,org.apache.axiom.soap.impl.builder,org.apache.commons.logging > Export-Package = org.apache.axiom.om.impl.llom.factory,org.apache.axiom.om.impl.llom.util,org.apache.axiom.om.impl.llom,org.apache.axiom.soap.impl.llom.soap11,org.apache.axiom.soap.impl.llom.soap12,org.apache.axiom.soap.impl.llom > Bundle-Version = 1.2.7 > Bundle-Name = Axiom API > Bundle-DocURL = http://www.apache.org/ > Bundle-ManifestVersion = 2 > Bundle-Vendor = Apache Software Foundation > Bundle-SymbolicName = org.apache.ws.commons.axiom.axiom-impl > karaf@root> headers 109 > Axiom API (109) > --------------- > Manifest-Version = 1.0 > Archiver-Version = Plexus Archiver > Created-By = Apache Maven > Built-By = dims > Build-Jdk = 1.5.0_15 > Bundle-License = http://www.apache.org/licenses/LICENSE-2.0.txt > Import-Package = javax.activation,javax.mail,javax.mail.internet,javax.xml.namespace,javax.xml.stream,org.apache.commons.logging,org.jaxen;resolution:=optional,org.jaxen.saxpath;resolution:=optional,org.jaxen.util;resolution:=optional,org.apache.axiom.om.impl.dom.factory;resolution:=optional,org.apache.axiom.soap.impl.dom.factory;resolution:=optional,org.apache.axiom.om.impl.llom.factory;resolution:=optional,org.w3c.dom,org.xml.sax,org.xml.sax.helpers > Export-Package = org.apache.axiom.attachments.impl,org.apache.axiom.attachments.lifecycle.impl,org.apache.axiom.attachments.lifecycle,org.apache.axiom.attachments.utils,org.apache.axiom.attachments,org.apache.axiom.om.ds.custombuilder,org.apache.axiom.om.ds,org.apache.axiom.om.impl.builder,org.apache.axiom.om.impl.exception,org.apache.axiom.om.impl.serialize,org.apache.axiom.om.impl.traverse,org.apache.axiom.om.impl.util,org.apache.axiom.om.impl,org.apache.axiom.om.util,org.apache.axiom.om.xpath,org.apache.axiom.om,org.apache.axiom.soap.impl.builder,org.apache.axiom.soap > Bundle-Version = 1.2.7 > Bundle-Name = Axiom API > Bundle-DocURL = http://www.apache.org/ > Bundle-ManifestVersion = 2 > Bundle-Vendor = Apache Software Foundation > Bundle-SymbolicName = org.apache.ws.commons.axiom.axiom-api > karaf@root> -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Tue Jan 05 05:50:53 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 52885 invoked from network); 5 Jan 2010 05:50:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 05:50:53 -0000 Received: (qmail 96050 invoked by uid 500); 5 Jan 2010 05:50:53 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 95963 invoked by uid 500); 5 Jan 2010 05:50:52 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 95953 invoked by uid 99); 5 Jan 2010 05:50:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 05:50:52 +0000 X-ASF-Spam-Status: No, hits=3.4 required=10.0 tests=HTML_MESSAGE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-pw0-f49.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 05:50:45 +0000 Received: by pwj12 with SMTP id 12so11434912pwj.8 for <cassandrawright@example.org>; Mon, 04 Jan 2010 21:50:25 -0800 (PST) MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id r4mr12655750wfc.65.1262670625267; Mon, 04 Jan 2010 21:50:25 -0800 (PST) Date: Tue, 5 Jan 2010 11:20:25 +0530 Message-ID: <cassandrawright@example.org> Subject: Question on distributed JMS transaction in JMS sender From: Rajika Kumarasiri <cassandrawright@example.org> To: cassandrawright@example.org Content-Type: multipart/alternative; boundary=001636e0b95d166073047c646ab2 --001636e0b95d166073047c646ab2 Content-Type: text/plain; charset=ISO-8859-1 hi, I just went through the implementation of the distributed JMS transaction implementation of JMS transport sender and came across the following observations. First JMS transport sender check for JTA JMS transaction using the message context property "UserTransaction" ( JMSMessageSender.java:177) and this property is set at the JMSMessageReceiver (JMSMessageReceiver.java:192), which actually pass from the run method in ServiceTaskManager. According to my understanding we are using the same transaction in JMSSender (pass as a msg_ctx property) created in JMS listener. I think there is a problem in this approach, because if we do not initialize the userTransaction in the listener but if we plan to use a userTransaction in the sender side we may not acquire a userTransaction. I think what sender should do is to use an already available userTransaction or create a one and participate in the distribute transaction if not. Is my understanding is correct? WDYT ? Rajika --001636e0b95d166073047c646ab2-- From commonscassandrawright@example.org Tue Jan 05 09:51:46 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 31494 invoked from network); 5 Jan 2010 09:51:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 09:51:46 -0000 Received: (qmail 88838 invoked by uid 500); 5 Jan 2010 09:51:45 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 88751 invoked by uid 500); 5 Jan 2010 09:51:45 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 88741 invoked by uid 99); 5 Jan 2010 09:51:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 09:51:45 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of cassandrawright@example.org designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-fx0-f213.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 09:51:38 +0000 Received: by fxm5 with SMTP id 5so15181239fxm.8 for <cassandrawright@example.org>; Tue, 05 Jan 2010 01:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type; bh=AJ5u15yhGZfnWUtAmbeO5VtzpzHHWR3ZBpNVmstBgzY=; b=Mt6+Fze+JHdH0GPfQI/zH3/B7sjZLYlFH+4KaQamZ46niPZ3LB4SZ1Tx3clZ1e2mek Fh/0ocNl1R/2Quolsoo1wF5H064sJSJcsdPF2eHGLYq4v2MN04fqzFyJbqNAHBE/IKSF ra/5idRDauhvqMKsSy0DGN/TZYzraZa0rJa/I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=Z4m9LQqGI0bVHZik7LQ+m6z3y0oaPxHViA80S46fB5anu1Py8CJlEWwLy/TFCwwv10 EY39jruiFZPb9gL3cRDFviWGWy72hrJgQD2FePSUDtd6GoCuCFGWTMEviPpE132ZbzBB 1ko++mRl9z24fn0+mDzxKAL5Ett35IpsrOkt4= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id 4mr721232hbw.99.1262685077398; Tue, 05 Jan 2010 01:51:17 -0800 (PST) In-Reply-To: <cassandrawright@example.org> References: <cassandrawright@example.org> From: Andreas Veithen <cassandrawright@example.org> Date: Tue, 5 Jan 2010 10:50:57 +0100 Message-ID: <cassandrawright@example.org> Subject: Re: Question on distributed JMS transaction in JMS sender To: cassandrawright@example.org Content-Type: text/plain; charset=ISO-8859-1 Rajika, Why would the JMS sender ever want to create a new transaction? Andreas On Tue, Jan 5, 2010 at 06:50, Rajika Kumarasiri <cassandrawright@example.org> wrote: > hi, > I just went through the implementation of the distributed JMS transaction > implementation of JMS transport sender and came across the following > observations. > First JMS transport sender check for JTA JMS transaction using the message > context property "UserTransaction" ( JMSMessageSender.java:177) and this > property is set at the JMSMessageReceiver (JMSMessageReceiver.java:192), > which actually pass from the run method in ServiceTaskManager. > According to my understanding we are using the same transaction in JMSSender > (pass as a msg_ctx property) created in JMS listener. I think there is a > problem in this approach, because if we do not initialize the > userTransaction in the listener but if we plan to use a userTransaction in > the sender side we may not acquire a userTransaction. I think what sender > should do is to use an already available userTransaction or create a one and > participate in the distribute transaction if not. > Is my understanding is correct? WDYT ? > > Rajika > From commonscassandrawright@example.org Tue Jan 05 10:32:22 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 46528 invoked from network); 5 Jan 2010 10:32:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 10:32:22 -0000 Received: (qmail 31089 invoked by uid 500); 5 Jan 2010 10:32:22 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 31018 invoked by uid 500); 5 Jan 2010 10:32:22 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 31008 invoked by uid 99); 5 Jan 2010 10:32:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:32:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:32:16 +0000 Received: from brutus.apache.org (localhost [83.161.120.155]) by brutus.apache.org (Postfix) with ESMTP id 428A4234C4A7 for <cassandrawright@example.org>; Tue, 5 Jan 2010 02:31:56 -0800 (PST) Message-ID: <cassandrawright@example.org> Date: Tue, 5 Jan 2010 10:31:56 +0000 (UTC) From: "Andreas Veithen (JIRA)" <cassandrawright@example.org> To: cassandrawright@example.org Subject: [jira] Commented: (WSCOMMONS-489) StAXUtils incorrectly assumes that XMLInputFactory and XMLOutputFactory instances are thread safe In-Reply-To: <842257981.1247262074996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WSCOMMONS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796613#action_12796613 ] Andreas Veithen commented on WSCOMMONS-489: ------------------------------------------- Ben, If you want to minimize risk and have a stable environment, then you should use Woodstox instead of SJSXP, as this eliminates the root cause of the issue. > StAXUtils incorrectly assumes that XMLInputFactory and XMLOutputFactory instances are thread safe > ------------------------------------------------------------------------------------------------- > > Key: WSCOMMONS-489 > URL: https://issues.apache.org/jira/browse/WSCOMMONS-489 > Project: WS-Commons > Issue Type: Bug > Components: AXIOM > Affects Versions: Axiom 1.2.8 > Reporter: Andreas Veithen > Assignee: Andreas Veithen > Fix For: Axiom 1.2.9 > > > StAXUtil uses a single XMLInputFactory or XMLOutputFactory instance (per classloader). This means that it makes the assumption that these instances are thread safe. However, there is nothing in the StAX specs that guarantees that, and Sun's implementation in JDK 6 is not thread safe, at least with the default properties [1] [2]. > [1] http://www.java2s.com/Open-Source/Java-Document/6.0-JDK-Modules-com.sun/xml/com/sun/xml/internal/stream/XMLInputFactoryImpl.java.htm > [2] http://www.java2s.com/Open-Source/Java-Document/6.0-JDK-Modules-com.sun/xml/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java.htm -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. From commonscassandrawright@example.org Tue Jan 05 10:34:00 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 47085 invoked from network); 5 Jan 2010 10:34:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 10:34:00 -0000 Received: (qmail 31964 invoked by uid 500); 5 Jan 2010 10:33:59 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 31897 invoked by uid 500); 5 Jan 2010 10:33:59 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 31887 invoked by uid 99); 5 Jan 2010 10:33:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:33:59 +0000 X-ASF-Spam-Status: No, hits=3.4 required=10.0 tests=HTML_MESSAGE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-pw0-f49.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:33:51 +0000 Received: by pwj12 with SMTP id 12so11613745pwj.8 for <cassandrawright@example.org>; Tue, 05 Jan 2010 02:33:30 -0800 (PST) MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id d20mr3709106wfa.37.1262687610086; Tue, 05 Jan 2010 02:33:30 -0800 (PST) In-Reply-To: <cassandrawright@example.org> References: <cassandrawright@example.org> <cassandrawright@example.org> Date: Tue, 5 Jan 2010 16:03:30 +0530 Message-ID: <cassandrawright@example.org> Subject: Re: Question on distributed JMS transaction in JMS sender From: Rajika Kumarasiri <cassandrawright@example.org> To: cassandrawright@example.org Content-Type: multipart/alternative; boundary=0050450296257625bc047c685e50 X-Virus-Checked: Checked by ClamAV on apache.org --0050450296257625bc047c685e50 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Jan 5, 2010 at 3:20 PM, Andreas Veithen <cassandrawright@example.org>wrote: > Rajika, > > Why would the JMS sender ever want to create a new transaction? > In case of only the JMS TransportSender needs to participate in a distributed transaction. Rajika > > Andreas > > --0050450296257625bc047c685e50-- From commonscassandrawright@example.org Tue Jan 05 10:41:09 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 50558 invoked from network); 5 Jan 2010 10:41:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 10:41:09 -0000 Received: (qmail 42363 invoked by uid 500); 5 Jan 2010 10:41:08 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 42269 invoked by uid 500); 5 Jan 2010 10:41:08 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 42259 invoked by uid 99); 5 Jan 2010 10:41:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:41:08 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of cassandrawright@example.org designates 83.161.120.155 as permitted sender) Received: from [83.161.120.155] (HELO mail-fx0-f213.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:41:01 +0000 Received: by fxm5 with SMTP id 5so15227956fxm.8 for <cassandrawright@example.org>; Tue, 05 Jan 2010 02:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type; bh=iafcdohIxO9WOjAw38fhOhGCVw9Ow+dKjEWhJzKqBpo=; b=rPKcXAtVRNto/2fY08dG3YNXFaYIg1IhefoV6pRn6aboXkc8//IG4vSNE9ePVoXMow T3NI/Irg3CxlUJCBxZ01KqGM23pr+oqYA/q6H/9EKB34Y53w1hTdXtU5CM3i/WnZoXHS fOW/edtVLYeMQQGhd+DTrdpSi6Es6NE3Xch98= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=dm0U4biVb+n57YvnACpilgN5/3aS9bH/vs6xstEC+605i2RYA3zh5yCF6ulHI8IkWM Zh0n3DYTSm1P3HJJ51iVY+SvXYNAf4mqdcdZ0ttNB2I93Ty+jFgg/nTsOwvyvzZ+4/Xq iYc9yoh8KSBc6bPYOw5BS3nooJu7zc6qJTDqU= MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id u6mr1121483hbc.167.1262688040163; Tue, 05 Jan 2010 02:40:40 -0800 (PST) In-Reply-To: <cassandrawright@example.org> References: <cassandrawright@example.org> <cassandrawright@example.org> <cassandrawright@example.org> From: Andreas Veithen <cassandrawright@example.org> Date: Tue, 5 Jan 2010 11:40:20 +0100 Message-ID: <cassandrawright@example.org> Subject: Re: Question on distributed JMS transaction in JMS sender To: cassandrawright@example.org Content-Type: text/plain; charset=ISO-8859-1 Rajika, In that case, why do you need a distributed transaction, considering that the JMS sender uses a single resource (the JMS connection factory) and executes a single operation (sending the JMS message)? It seems to me that in that case, you don't need a transaction, and even less a distributed transaction. Andreas On Tue, Jan 5, 2010 at 11:33, Rajika Kumarasiri <cassandrawright@example.org> wrote: > On Tue, Jan 5, 2010 at 3:20 PM, Andreas Veithen > <cassandrawright@example.org>wrote: > >> Rajika, >> >> Why would the JMS sender ever want to create a new transaction? >> > > In case of only the JMS TransportSender needs to participate in a > distributed transaction. > > Rajika > > >> >> Andreas >> >> > From commonscassandrawright@example.org Tue Jan 05 10:56:31 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 58509 invoked from network); 5 Jan 2010 10:56:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155) by minotaur.apache.org with SMTP; 5 Jan 2010 10:56:31 -0000 Received: (qmail 59107 invoked by uid 500); 5 Jan 2010 10:56:31 -0000 Delivered-To: cassandrawright@example.org Received: (qmail 59029 invoked by uid 500); 5 Jan 2010 10:56:31 -0000 Mailing-List: contact cassandrawright@example.org; run by ezmlm Precedence: bulk List-Help: <mailto:cassandrawright@example.org> List-Unsubscribe: <mailto:cassandrawright@example.org> List-Post: <mailto:cassandrawright@example.org> List-Id: <commons-dev.ws.apache.org> Reply-To: cassandrawright@example.org Delivered-To: mailing list cassandrawright@example.org Received: (qmail 59018 invoked by uid 99); 5 Jan 2010 10:56:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:56:31 +0000 X-ASF-Spam-Status: No, hits=3.4 required=10.0 tests=HTML_MESSAGE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [83.161.120.155] (HELO mail-pw0-f49.google.com) (83.161.120.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 10:56:23 +0000 Received: by pwj12 with SMTP id 12so11627480pwj.8 for <cassandrawright@example.org>; Tue, 05 Jan 2010 02:56:02 -0800 (PST) MIME-Version: 1.0 Received: by 83.161.120.155 with SMTP id r4mr12765002wfc.65.1262688961888; Tue, 05 Jan 2010 02:56:01 -0800 (PST) In-Reply-To: <cassandrawright@example.org> References: <cassandrawright@example.org> <cassandrawright@example.org> <cassandrawright@example.org> <cassandrawright@example.org> Date: Tue, 5 Jan 2010 16:26:01 +0530 Message-ID: <cassandrawright@example.org> Subject: Re: Question on distributed JMS transaction in JMS sender From: Rajika Kumarasiri <cassandrawright@example.org> To: cassandrawright@example.org Content-Type: multipart/alternative; boundary=001636e0b95d090320047c68af4f X-Virus-Checked: Checked by ClamAV on apache.org --001636e0b95d090320047c68af4f Content-Type: text/plain; charset=ISO-8859-1 Andreas, I think I was not clear with my requirement. Consider a scenario like this. Assume we use synapse and say we pick a message from a database and send it to a JMS queue, using the JMS transport. Now I want this happen to be happened in a distributed transaction, i.e. if something went wrong (database crash or JMS queue crash) I want to rollback the transaction so that I don't loose any messages. Rajika On Tue, Jan 5, 2010 at 4:10 PM, Andreas Veithen <cassandrawright@example.org>wrote: > Rajika, > > In that case, why do you need a distributed transaction, considering > that the JMS sender uses a single resource (the JMS connection > factory) and executes a single operation (sending the JMS message)? It > seems to me that in that case, you don't need a transaction, and even > less a distributed transaction. > > Andreas > > On Tue, Jan 5, 2010 at 11:33, Rajika Kumarasiri <cassandrawright@example.org> wrote: > > On Tue, Jan 5, 2010 at 3:20 PM, Andreas Veithen > > <cassandrawright@example.org>wrote: > > > >> Rajika, > >> > >> Why would the JMS sender ever want to create a new transaction? > >> > > > > In case of only the JMS TransportSender needs to participate in a > > distributed transaction. > > > > Rajika > > > > > >> > >> Andreas > >> > >> > > > --001636e0b95d090320047c68af4f-- From commonscassandrawright@example.org Tue Jan 05 11:05:43 2010 Return-Path: <commonscassandrawright@example.org> Delivered-To: cassandrawright@example.org Received: (qmail 63645
{'source': 'Apache Software Foundation Public Mail Archives'}