From heraldry-commits-return-263alyssa14@example.net Thu Mar 01 19:55:11 2007
Return-Path: <heraldry-commits-return-263alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 59305 invoked from network); 1 Mar 2007 19:55:11 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 1 Mar 2007 19:55:11 -0000
Received: (qmail 67609 invoked by uid 500); 1 Mar 2007 19:55:20 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 67591 invoked by uid 500); 1 Mar 2007 19:55:20 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 67582 invoked by uid 99); 1 Mar 2007 19:55:20 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2007 11:55:20 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2007 11:55:10 -0800
Received: from brutus (localhost [83.161.120.155])
	by brutus.apache.org (Postfix) with ESMTP id AE2BB7141F8
	for <alyssa14@example.net>; Thu,  1 Mar 2007 11:54:50 -0800 (PST)
Message-ID: <8872691.1172778890710.JavaMail.jira@brutus>
Date: Thu, 1 Mar 2007 11:54:50 -0800 (PST)
From: "Ward Vandewege (JIRA)" <alyssa14@example.net>
To: alyssa14@example.net
Subject: [jira] Created: (HERALDRY-5) [PATCH] 403 unauthorized when clicking
 on 'resend confirmation e-mail'
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

[PATCH] 403 unauthorized when clicking on 'resend confirmation e-mail'
----------------------------------------------------------------------

                 Key: HERALDRY-5
                 URL: https://issues.apache.org/jira/browse/HERALDRY-5
             Project: Heraldry
          Issue Type: Bug
          Components: PIP
            Reporter: Ward Vandewege


When clicking on the 'resend confirmation e-mail' from 'My Profile', one gets a 403 error because the click is transformed into a POST, without passing in the session_id_validation parameter.

The following patch fixes this problem. Please apply it!

Thanks,
Ward.

Index: _email_verification.rhtml
===================================================================
--- _email_verification.rhtml   (revision 509879)
+++ _email_verification.rhtml   (working copy)
@@ -25,7 +25,7 @@
         <h2><%= current_user.email %></h2><br />
       <p>A confirmation e-mail has been sent to your e-mail address. Your account will not be verified until you respond to that message.</p>
       <br />
-      <%= link_to "Resend confirmation e-mail", account_url(:action => 'resend_confirmation'), :post => true, :class => 'white' %>
+      <%= link_to "Resend confirmation e-mail", { :controller => 'account', :action => 'resend_confirmation', :session_id_validation => security_token } , :post => true, :class => 'white' %>
     </div>
     <div class='rbbot3'>
       <div></div>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From heraldry-commits-return-264alyssa14@example.net Fri Mar 02 19:18:10 2007
Return-Path: <heraldry-commits-return-264alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 19767 invoked from network); 2 Mar 2007 19:18:08 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 2 Mar 2007 19:18:08 -0000
Received: (qmail 65947 invoked by uid 500); 2 Mar 2007 19:18:09 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 65911 invoked by uid 500); 2 Mar 2007 19:18:08 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 65877 invoked by uid 99); 2 Mar 2007 19:18:08 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:18:08 -0800
X-ASF-Spam-Status: No, hits=-99.5 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:17:59 -0800
Received: by eris.apache.org (Postfix, from userid 65534)
	id 2EEBF1A981A; Fri,  2 Mar 2007 11:17:39 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r513896 -
 /incubator/heraldry/idp/pip/trunk/app/views/account/login.rhtml
Date: Fri, 02 Mar 2007 19:17:39 -0000
To: alyssa14@example.net
From: alyssa14@example.net
X-Mailer: svnmailer-1.1.0
Message-Id: <alyssa14@example.net>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: recordond
Date: Fri Mar  2 11:17:38 2007
New Revision: 513896

URL: http://svn.apache.org/viewvc?view=rev&rev=513896
Log:
Add an explicit link to forgotten password page from login page

Modified:
    incubator/heraldry/idp/pip/trunk/app/views/account/login.rhtml

Modified: incubator/heraldry/idp/pip/trunk/app/views/account/login.rhtml
URL: http://svn.apache.org/viewvc/incubator/heraldry/idp/pip/trunk/app/views/account/login.rhtml?view=diff&rev=513896&r1=513895&r2=513896
==============================================================================
--- incubator/heraldry/idp/pip/trunk/app/views/account/login.rhtml (original)
+++ incubator/heraldry/idp/pip/trunk/app/views/account/login.rhtml Fri Mar  2 11:17:38 2007
@@ -34,5 +34,7 @@
     <%= hidden_field_tag 'return_to', session[:return_to] || @return_to %>
     <%= hidden_field_tag 'previous_protocol', session[:previous_protocol] || @previous_protocol %>
     <p><%= image_submit_tag 'buttons/login.gif', :alt => 'Login', :name => 'commit' %></p>
+	<br />
+	<p><%= link_to  'Forgot your password?', 'forgot_password' %></p>
   </div>
 <%= end_form_tag %>



From heraldry-commits-return-265alyssa14@example.net Fri Mar 02 19:30:48 2007
Return-Path: <heraldry-commits-return-265alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 22986 invoked from network); 2 Mar 2007 19:30:48 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 2 Mar 2007 19:30:48 -0000
Received: (qmail 87961 invoked by uid 500); 2 Mar 2007 19:30:56 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 87942 invoked by uid 500); 2 Mar 2007 19:30:56 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 87933 invoked by uid 99); 2 Mar 2007 19:30:56 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:30:56 -0800
X-ASF-Spam-Status: No, hits=-99.5 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:30:47 -0800
Received: by eris.apache.org (Postfix, from userid 65534)
	id 1F4A21A981A; Fri,  2 Mar 2007 11:30:27 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r513902 -
 /incubator/heraldry/idp/pip/trunk/app/views/account/_email_verification.rhtml
Date: Fri, 02 Mar 2007 19:30:26 -0000
To: alyssa14@example.net
From: alyssa14@example.net
X-Mailer: svnmailer-1.1.0
Message-Id: <alyssa14@example.net>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: recordond
Date: Fri Mar  2 11:30:25 2007
New Revision: 513902

URL: http://svn.apache.org/viewvc?view=rev&rev=513902
Log:
Patch by Ward Vandewege which fixes the issue where email verification link is
submitted via POST, but does not include the needed security token.

https://issues.apache.org/jira/browse/HERALDRY-5

Thanks for the patch!

Modified:
    incubator/heraldry/idp/pip/trunk/app/views/account/_email_verification.rhtml

Modified: incubator/heraldry/idp/pip/trunk/app/views/account/_email_verification.rhtml
URL: http://svn.apache.org/viewvc/incubator/heraldry/idp/pip/trunk/app/views/account/_email_verification.rhtml?view=diff&rev=513902&r1=513901&r2=513902
==============================================================================
--- incubator/heraldry/idp/pip/trunk/app/views/account/_email_verification.rhtml (original)
+++ incubator/heraldry/idp/pip/trunk/app/views/account/_email_verification.rhtml Fri Mar  2 11:30:25 2007
@@ -25,7 +25,7 @@
         <h2><%= current_user.email %></h2><br />
       <p>A confirmation e-mail has been sent to your e-mail address. Your account will not be verified until you respond to that message.</p>
       <br />
-      <%= link_to "Resend confirmation e-mail", account_url(:action => 'resend_confirmation'), :post => true, :class => 'white' %>
+      <%= link_to "Resend confirmation e-mail", { :controller => 'account', :action => 'resend_confirmation', :session_id_validation => security_token } , :post => true, :class => 'white' %> 
     </div>
     <div class='rbbot3'>
       <div></div>



From heraldry-commits-return-266alyssa14@example.net Fri Mar 02 19:31:34 2007
Return-Path: <heraldry-commits-return-266alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 23402 invoked from network); 2 Mar 2007 19:31:11 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 2 Mar 2007 19:31:11 -0000
Received: (qmail 89221 invoked by uid 500); 2 Mar 2007 19:31:20 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 89211 invoked by uid 500); 2 Mar 2007 19:31:20 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 89193 invoked by uid 99); 2 Mar 2007 19:31:20 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:31:20 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:31:10 -0800
Received: from brutus (localhost [83.161.120.155])
	by brutus.apache.org (Postfix) with ESMTP id B5C6C7142EE
	for <alyssa14@example.net>; Fri,  2 Mar 2007 11:30:50 -0800 (PST)
Message-ID: <23674136.1172863850715.JavaMail.jira@brutus>
Date: Fri, 2 Mar 2007 11:30:50 -0800 (PST)
From: "David Recordon (JIRA)" <alyssa14@example.net>
To: alyssa14@example.net
Subject: [jira] Resolved: (HERALDRY-5) [PATCH] 403 unauthorized when
 clicking on 'resend confirmation e-mail'
In-Reply-To: <8872691.1172778890710.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/HERALDRY-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Recordon resolved HERALDRY-5.
-----------------------------------

    Resolution: Fixed
      Assignee: David Recordon

154:~/Desktop/pip/trunk/app/views/account drecordon$ svn ci _email_verification.rhtml 
Sending        _email_verification.rhtml
Transmitting file data .
Committed revision 513902.

> [PATCH] 403 unauthorized when clicking on 'resend confirmation e-mail'
> ----------------------------------------------------------------------
>
>                 Key: HERALDRY-5
>                 URL: https://issues.apache.org/jira/browse/HERALDRY-5
>             Project: Heraldry
>          Issue Type: Bug
>          Components: PIP
>            Reporter: Ward Vandewege
>         Assigned To: David Recordon
>
> When clicking on the 'resend confirmation e-mail' from 'My Profile', one gets a 403 error because the click is transformed into a POST, without passing in the session_id_validation parameter.
> The following patch fixes this problem. Please apply it!
> Thanks,
> Ward.
> Index: _email_verification.rhtml
> ===================================================================
> --- _email_verification.rhtml   (revision 509879)
> +++ _email_verification.rhtml   (working copy)
> @@ -25,7 +25,7 @@
>          <h2><%= current_user.email %></h2><br />
>        <p>A confirmation e-mail has been sent to your e-mail address. Your account will not be verified until you respond to that message.</p>
>        <br />
> -      <%= link_to "Resend confirmation e-mail", account_url(:action => 'resend_confirmation'), :post => true, :class => 'white' %>
> +      <%= link_to "Resend confirmation e-mail", { :controller => 'account', :action => 'resend_confirmation', :session_id_validation => security_token } , :post => true, :class => 'white' %>
>      </div>
>      <div class='rbbot3'>
>        <div></div>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From heraldry-commits-return-267alyssa14@example.net Fri Mar 02 19:45:33 2007
Return-Path: <heraldry-commits-return-267alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 27874 invoked from network); 2 Mar 2007 19:45:31 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 2 Mar 2007 19:45:31 -0000
Received: (qmail 12835 invoked by uid 500); 2 Mar 2007 19:45:40 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 12816 invoked by uid 500); 2 Mar 2007 19:45:39 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 12807 invoked by uid 99); 2 Mar 2007 19:45:39 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:45:39 -0800
X-ASF-Spam-Status: No, hits=-99.5 required=10.0
	tests=ALL_TRUSTED,NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO eris.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:45:30 -0800
Received: by eris.apache.org (Postfix, from userid 65534)
	id 927D71A981A; Fri,  2 Mar 2007 11:45:10 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r513914 - in /incubator/heraldry/idp/pip/trunk/db/migrate:
 005_rename_title_columns.rb 012_add_attachment_fields.rb
Date: Fri, 02 Mar 2007 19:45:10 -0000
To: alyssa14@example.net
From: alyssa14@example.net
X-Mailer: svnmailer-1.1.0
Message-Id: <alyssa14@example.net>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: recordond
Date: Fri Mar  2 11:45:09 2007
New Revision: 513914

URL: http://svn.apache.org/viewvc?view=rev&rev=513914
Log:
Patch by Ward Vandewege fixing migrations for the downgrade path.
https://issues.apache.org/jira/browse/HERALDRY-3

Thanks for the patch!

Modified:
    incubator/heraldry/idp/pip/trunk/db/migrate/005_rename_title_columns.rb
    incubator/heraldry/idp/pip/trunk/db/migrate/012_add_attachment_fields.rb

Modified: incubator/heraldry/idp/pip/trunk/db/migrate/005_rename_title_columns.rb
URL: http://svn.apache.org/viewvc/incubator/heraldry/idp/pip/trunk/db/migrate/005_rename_title_columns.rb?view=diff&rev=513914&r1=513913&r2=513914
==============================================================================
--- incubator/heraldry/idp/pip/trunk/db/migrate/005_rename_title_columns.rb (original)
+++ incubator/heraldry/idp/pip/trunk/db/migrate/005_rename_title_columns.rb Fri Mar  2 11:45:09 2007
@@ -27,6 +27,6 @@
     add_column :trusts, :persona_id, :integer
     remove_column :trusts, :profile_id
     
-    rename_column :profiles, :name, :title
+    rename_column :profiles, :title, :name
   end
 end

Modified: incubator/heraldry/idp/pip/trunk/db/migrate/012_add_attachment_fields.rb
URL: http://svn.apache.org/viewvc/incubator/heraldry/idp/pip/trunk/db/migrate/012_add_attachment_fields.rb?view=diff&rev=513914&r1=513913&r2=513914
==============================================================================
--- incubator/heraldry/idp/pip/trunk/db/migrate/012_add_attachment_fields.rb (original)
+++ incubator/heraldry/idp/pip/trunk/db/migrate/012_add_attachment_fields.rb Fri Mar  2 11:45:09 2007
@@ -26,7 +26,7 @@
 
   def self.down
     remove_column "users", "filename"
-    remove_column "content_type", "content_type"
+    remove_column "users", "content_type"
     remove_column "users", "size"
     remove_column "users", "width"
     remove_column "users", "height"



From heraldry-commits-return-268alyssa14@example.net Fri Mar 02 19:47:12 2007
Return-Path: <heraldry-commits-return-268alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 28291 invoked from network); 2 Mar 2007 19:47:11 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 2 Mar 2007 19:47:11 -0000
Received: (qmail 13632 invoked by uid 500); 2 Mar 2007 19:47:20 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 13618 invoked by uid 500); 2 Mar 2007 19:47:20 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 13604 invoked by uid 99); 2 Mar 2007 19:47:20 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:47:20 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:47:11 -0800
Received: from brutus (localhost [83.161.120.155])
	by brutus.apache.org (Postfix) with ESMTP id BAF2A7142EE
	for <alyssa14@example.net>; Fri,  2 Mar 2007 11:46:50 -0800 (PST)
Message-ID: <22117211.1172864810748.JavaMail.jira@brutus>
Date: Fri, 2 Mar 2007 11:46:50 -0800 (PST)
From: "David Recordon (JIRA)" <alyssa14@example.net>
To: alyssa14@example.net
Subject: [jira] Resolved: (HERALDRY-3) small bugs in the db migrations of
 the Ruby Heraldry OpenID server
In-Reply-To: <30335435.1171600805498.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/HERALDRY-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Recordon resolved HERALDRY-3.
-----------------------------------

    Resolution: Fixed
      Assignee: David Recordon

154:~/Desktop/pip/trunk/db/migrate drecordon$ svn ci 005_rename_title_columns.rb 012_add_attachment_fields.rb 
Sending        005_rename_title_columns.rb
Sending        012_add_attachment_fields.rb
Transmitting file data ..
Committed revision 513914.

> small bugs in the db migrations of the Ruby Heraldry OpenID server
> ------------------------------------------------------------------
>
>                 Key: HERALDRY-3
>                 URL: https://issues.apache.org/jira/browse/HERALDRY-3
>             Project: Heraldry
>          Issue Type: Bug
>          Components: PIP
>            Reporter: Ward Vandewege
>         Assigned To: David Recordon
>
> The db migrations contain a couple of small bugs in the downgrade path. Here are two patches to fix them:
> --- db/migrate/005_rename_title_columns.rb      (revision 508264)
> +++ db/migrate/005_rename_title_columns.rb      (working copy)
> @@ -27,6 +27,6 @@
>      add_column :trusts, :persona_id, :integer
>      remove_column :trusts, :profile_id
>      
> -    rename_column :profiles, :name, :title
> +    rename_column :profiles, :title, :name
>    end
>  end
> --- db/migrate/012_add_attachment_fields.rb     (revision 508264)
> +++ db/migrate/012_add_attachment_fields.rb     (working copy)
> @@ -26,7 +26,7 @@
>  
>    def self.down
>      remove_column "users", "filename"
> -    remove_column "content_type", "content_type"
> +    remove_column "users", "content_type"
>      remove_column "users", "size"
>      remove_column "users", "width"
>      remove_column "users", "height"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


From heraldry-commits-return-269alyssa14@example.net Fri Mar 02 19:54:12 2007
Return-Path: <heraldry-commits-return-269alyssa14@example.net>
Delivered-To: alyssa14@example.net
Received: (qmail 30167 invoked from network); 2 Mar 2007 19:54:11 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (83.161.120.155)
  by minotaur.apache.org with SMTP; 2 Mar 2007 19:54:11 -0000
Received: (qmail 20970 invoked by uid 500); 2 Mar 2007 19:54:20 -0000
Delivered-To: alyssa14@example.net
Received: (qmail 20941 invoked by uid 500); 2 Mar 2007 19:54:20 -0000
Mailing-List: contact alyssa14@example.net; run by ezmlm
Precedence: bulk
List-Help: <mailto:alyssa14@example.net>
List-Unsubscribe: <mailto:alyssa14@example.net>
List-Post: <mailto:alyssa14@example.net>
List-Id: <heraldry-commits.incubator.apache.org>
Reply-To: alyssa14@example.net
Delivered-To: mailing list alyssa14@example.net
Received: (qmail 20929 invoked by uid 99); 2 Mar 2007 19:54:20 -0000
Received: from herse.apache.org (HELO herse.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:54:20 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [83.161.120.155] (HELO brutus.apache.org) (83.161.120.155)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2007 11:54:10 -0800
Received: from brutus (localhost [83.161.120.155])
	by brutus.apache.org (Postfix) with ESMTP id AE95A7142EE
	for <alyssa14@example.net>; Fri,  2 Mar 2007 11:53:50 -0800 (PST)
Message-ID: <18504668.1172865230706.JavaMail.jira@brutus>
Date: Fri, 2 Mar 2007 11:53:50 -0800 (PST)
From: "David Recordon (JIRA)" <alyssa14@example.net>
To: alyssa14@example.net
Subject: [jira] Commented: (HERALDRY-4) the Ruby Heraldry OpenID server does
 not support a PostgreSQL backend out of the box
In-Reply-To: <61882.1171601165876.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HERALDRY-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477422 ] 

David Recordon commented on HERALDRY-4:
---------------------------------------

So I'm not familiar enough with Postgres anymore...

Looks like the first two patches add quotes around the number 1.  I'm assuming this is due to Postgres treating the number as a string and thus requiring quotes.?.

I'm also a bit at a loss as to the last patch.  What does the SELECT setval do for Postgres?

Thanks!

> the Ruby Heraldry OpenID server does not support a PostgreSQL backend out of the box
> ------------------------------------------------------------------------------------
>
>                 Key: HERALDRY-4
>                 URL: https://issues.apache.org/jira/browse/HERALDRY-4
>             Project: Heraldry
>          Issue Type: Improvement
>            Reporter: Ward Vandewege
>
> The Ruby Heraldry OpenID server does not support a PostgreSQL backend out of the box. These two patches are simple fixes that will not affect MySQL:
> --- app/models/property_type.rb (revision 508264)
> +++ app/models/property_type.rb (working copy)
> @@ -52,7 +52,7 @@
>      # ====Parameters
>      # user888a:dbb7:2d49:b3f6:8605:bf4e:caed:e5a4 The User for whom we're finding PropertyTypes.
>      def roots_global_or_owned_by(user)
> -      find(:all, :conditions => ['property_types.parent_id = 1 AND (property_types.is_global = 1 OR property_types.user_id = ?)', user.id], :order => 'property_types.created_at ASC')
> +      find(:all, :conditions => ['property_types.parent_id = 1 AND (property_types.is_global = \'1\' OR property_types.user_id = ?)', user.id], :order => 'property_types.created_at ASC')
>      end
>    end
> --- db/migrate/026_reorder_personal_property_types.rb   (revision 508264)
> +++ db/migrate/026_reorder_personal_property_types.rb   (working copy)
> @@ -43,7 +43,7 @@
>        end
>  
>        def roots_global_or_owned_by(user)
> -        find(:all, :conditions => ['property_types.parent_id = 1 AND (property_types.is_global = 1 OR property_types.user_id = ?)', user.id], :order => 'property_types.created_at ASC')
> +        find(:all, :conditions => ['property_types.parent_id = 1 AND (property_types.is_global = \'1\' OR property_types.user_id = ?)', user.id], :order => 'property_types.created_at ASC')
>        end
>      end
>  
> Finally, this patch is also necessary, but it needs a bit of work:
> --- db/migrate/022_globalize_migration.rb       (revision 508264)
> +++ db/migrate/022_globalize_migration.rb       (working copy)
> @@ -65,6 +65,13 @@
>        t.column :scope, :string, :limit => 1
>      end
>  
> +    # Added for PostgresSQL
> +    tables = ['globalize_countries', 'globalize_translations', 'globalize_languages']
> +      tables.each do |table|
> +      sql = "SELECT setval('#{table}_id_seq', 1)" 
> +      ActiveRecor888a:dbb7:2d49:b3f6:8605:bf4e:caed:e5a4Base.connection.execute(sql)
> +    end
> +
>      add_index :globalize_languages, :iso_639_1
>      add_index :globalize_languages, :iso_639_2  
>      add_index :globalize_languages, :iso_639_3  
> The problem is that the rake db:migrate command fails because PostgreSQL does not allow using currval on a sequence that has not been used in the current session. This patch fixes this, but it will break MySQL support. A detection of the database backend needs to be added to it before it goes into the svn tree.
> Any questions, please feel free to contact me.
> Thanks,
> Ward.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



{'source': 'Apache Software Foundation Public Mail Archives'}