#juju-gui 2012-11-01 <bcsaller> gary_poster: https://github.com/mooz/js2-mode/wiki/Changes-from-the-original-mode might be better, some of this looks ok #juju-gui 2012-11-05 <bac> morning <sepi> Hi all. Quick q. <sepi> According to the readme I neet to access https://localhost:8081/ws <sepi> But I have nothing running on that port <sepi> afer doing a "make server" <bac> hi sepi <sepi> hi I think I know my problem <sepi> I needed to use the rapi-delta branch? <bac> sepi: yes, either it or rapi-rollup <bac> sepi: also, the url you pasted is only for the web socket to use. to actually access the juju gui you would use http://localhost:8888 <bac> sepi: reading the README i see we don't mention that explicitly. i'll fix that now. <sepi> bac: thanks :) <bac> np. have fun, file bugs! <gary_poster> hiya (was upgrading quantal on the desktop) <bac> morning <gary_poster> mattuk1972, hi. I got your question about the service detail page. The box has the two-radius rounded corners, right? I'm pretty sure I see that. Because of that, I want to confer with Makyo and see if we want to do this with svg. I'll do that and get back to you * bac tries to remember which days we had dinner paid. <gary_poster> heh <gary_poster> good question <gary_poster> many of them <gary_poster> esp. second week <mattuk1972> gary_poster: ok ty <gary_poster> bcsaller, hi. are you in nyc area, or just awake *really* early on west coast? :-) <mattuk1972> gary_poster: also kapil mentioned that theres a requirement to simplify the svg's overall? <bcsaller> gary_poster: in NYC <bcsaller> :) <bcsaller> as of last night <gary_poster> bcsaller, cool :-) hope everything is ok for you there <frankban> bac: these are my notes, maybe they can help: http://pastebin.ubuntu.com/1334735/ <bcsaller> Seems mostly back together here but there is still alot to be done in other spots <gary_poster> mattuk1972, yes. Chrome and IE10 support the service box svgs on the environment mage well. iPad 3 is pretty good. FF is very bad. Apparently the FF problem is largely because of the service assets <gary_poster> s/mage/page <gary_poster> mattuk1972, Makyo investigated and reported that FF team is not being very responsive about SVG rendering issues <mattuk1972> gary_poster: weird i did a lot of testing in all the browsers to make sure they rendered well and firefox was one of the best... <gary_poster> So we need to do something to make that better. I believe I heard hazmat (who is out this week) talked to Ivo about it so he may know details. <gary_poster> mattuk1972, it's not a matter of rendering accuracy. The problem is that once you draw the boxes, when you try to drag them around it is extremely slow <mattuk1972> ahh <bcsaller> gary_poster: I can still try to reach out to some of the people I know at Mozilla and see if they can make it more of a priority <gary_poster> mattuk1972, easy comparison: try http://uistage.jujucharms.com:8080/ in chrome and in ff to see diff <gary_poster> at least in Ubuntu <mattuk1972> but simplifying the svgs will fix it? removing any transparency? <gary_poster> haven't tried in os x <gary_poster> bcsaller, that's worth a try <gary_poster> thank you <mattuk1972> hmm seems to be ok in osx <bcsaller> mattuk1972: removing the filters and layers will help alot, yes <mattuk1972> i don't know how much of that i can do before it just becomes a plain grey box <gary_poster> mattuk1972, that's my understanding. It's probably worth some experimentation coordinating with us to both verify (I think that's already been done, and bcsaller is confirming) and to see how far we can go <bac> frankban: your records matched my recollection. thanks. <benji> we can replace all the fancy shading with a png that just says "Firefox is slow." <gary_poster> ack mattuk1972. Maybe there's a simple experiment we can run to see if it this avenue is even workable? <mattuk1972> to take it right down with a really basic shape just to see if it helps? <bac> my DSL connection is flaky today, dropping and reconnecting every now and then. <mattuk1972> lol benji <gary_poster> I.e., you quickly simplify it to a point that you think might be representative "the least detail that would work visually/professionally" <gary_poster> :-) <gary_poster> mattuk1972, I think we have already established that a basic shape helps, right bcsaller? The question is, is FF good enough that we can still have something professional looking, or not <gary_poster> I think <gary_poster> Since FF is the default browser in Ubuntu, it's kind of important <bcsaller> gary_poster, mattuk1972: Yeah, simplfying the service boxes helps, but it comes at visual cost. We have options to help make FF faster, make the svgs simpler, add a drag mode that on FF turns them into outlines, or switch FF to use larger static image assests that don't scale as well and try shrinking those down as needed. <bcsaller> I think an outline on drag could fix our issue at low cost <bcsaller> like an old school WM <gary_poster> heh <gary_poster> yeah, not a bad idea <gary_poster> interesting that it is ok on os x <gary_poster> in ff <mattuk1972> yea it really smooth - can't see any dif between it and chrome <bcsaller> FF uses different platform specific paths for accel <bcsaller> I *think* its cairo on linux for this, but not sure <bcsaller> pretty sure it was at one point, but don't know now <bcsaller> so windows and osx can do very different things <gary_poster> k <gary_poster> right <bcsaller> this is just a border cases that impacts very few sites on a smaller cross section of their browsers <bcsaller> chrome wrote their own svg accel layer and use it everywhere iirc <tveronezi> bcsaller: can we have a g+? I need to check with you the solution I have for the aggregation task I am working on. <bcsaller> tveronezi: yeah, I need a few minutes though <tveronezi> ok... ping me when you are ready. tkx! <gary_poster> If anybody said anything to me in the past 15 min or so I probably missed it. Had to switch computers for a few minutes <gary_poster> So if I haven't replied to something or other, please try again :-) <bac> gary_poster: standup is still at 12 EST i assume <gary_poster> bac, yeah, for now that was what I was thinking, though I was going to clarify with everyone. AFAIK we have all now gone through DST transition. We might be able to move the call one hour earlier with Ben on the East Coast, but that's arguably a separate discussion. Lemme ping everyone... <bcsaller> tveronezi: ok, I can chat now, joining the hangout <tveronezi> ok <gary_poster> bac bcsaller benji frankban (hazmat not here) Makyo mattuk1972 teknico tveronezi I think we have all moved from DST now except bac, who will not. bcsaller is now on East Coast USA. What do you say to moving the daily call an hour earlier, adjusted for DST changes, to 1600 UTC (11AM EST, 9AM MST, 12PM AST, 1700 CET)? <gary_poster> (If I left anyone <benji> sounds good to me <bcsaller> gary_poster: I'm cool with that <gary_poster> 's timezone out I apologize :-) I tried) <frankban> gary_poster: ok <gary_poster> mm, I left benji's out because I still think he is Eastern sorry :-P * benji is livin' la vida UTC <gary_poster> :-) <bac> gary_poster: sounds good. no change for me <gary_poster> ok thx <bcsaller> I am the man without a timezone. Europe to SF for 1 day to NYC, my body is sure I hate it. <gary_poster> heh <Makyo> gary_poster, Sounds fine. <Makyo> gary_poster, Starting today? <teknico> gary_poster, ok for me <gary_poster> Makyo, that's the idea, but doesn't have to be <Makyo> gary_poster, Just making sure :) <gary_poster> cool :-) <bcsaller> Makyo: got a sec to catch up on g+? <gary_poster> frankban, mattuk1972, tveronezi let me/us know asap if the new mtg time I proposed above is OK for you. I'm hoping it is ok for jovan too, when he is back <tveronezi> gary_poster: sounds good to me too. <mattuk1972> jovan is in the office <mattuk1972> is that 4 my time? <frankban> gary_poster: sounds good <gary_poster> mattuk1972, yes <gary_poster> frankban, tveronezi cool thx <mattuk1972> ok sounds good <gary_poster> cool thanks * gary_poster is changing calendar <mattuk1972> jovan says 4 is good too <Makyo> bcsaller, Sure, was just replying to email, whenever's good. <bcsaller> Makyo: I'll hop in the g+ <bcsaller> g+ is being strange <bcsaller> hmm, going to restart the router here, it might be acting up <Makyo> Alright. <gary_poster> mattuk1972, fwiw and to be clear I invited you to all the meetings, but don't expect you to actually want to attend all of them. You are invited to attend as makes sense for you. :-) <mattuk1972> gary_poster: cool will do - ty <gary_poster> cool <gary_poster> bac, hey. I just found the css spec for the two-radius border syntax. It looks like it is supported. Did you ad Huw try it and reject it, or is it broken for some reason that is not clear on this page? http://muddledramblings.com/table-of-css3-border-radius-compliance/ <bac> gary_poster: we did not try it <gary_poster> bac ok. maybe worth playing with. we have more of those two-radii curves coming. <bac> gary_poster: we didn't know about it. <bac> gary_poster: i'll try it now <gary_poster> cool <gary_poster> thx <bac> hi gary_poster, mattuk1972 says that cimi tried that two radii method and rejected it since the curve is a more complex bezier curve and cannot be replicated using that CSS approach. <mattuk1972> i mean it might be worth just seeing what it looks like? but i think cimi spet a long time trying to emulate it before <gary_poster> bac, but we can get a lot closer with it, yeah? for buttons and smaller shapes in particular <bac> gary_poster: we can try but if they have investigated and rejected it then i'm not hopeful we'll be able to get them to accept a non-image approach <bac> mattuk1972: does that sound accurate? <gary_poster> bac, I thought we were hoping to get the buttons in all css, even with the simple rounded curves, and this would be a lot closer. Did I misunderstand? <mattuk1972> from what i can understand. would it be useful to talk to cimi? <bac> gary_poster: yes, that was the goal <bac> gary_poster: but if the designers won't allow any deviation it seems like the experiment is not a good use of time <mattuk1972> if you use tat method then it won't be following the visual style of siri <bac> i.e., i don't know if there is anything "close enough" <mattuk1972> suru even lol <gary_poster> :-) <bac> siri, make me a button <mattuk1972> hehe <mattuk1972> if someone can show me how close we can get then it might be ok? <gary_poster> bac, ^^ <gary_poster> bac, I can try or you <mattuk1972> just warning that it may get some noise from this end if we don't have the curve right enough <gary_poster> ack <bac> gary_poster: if that is what you want i'm willing to try <gary_poster> bac, I don't see how the attempt should take more than 15 minutes or so, yeah? <mattuk1972> from what i can work out a nice multi radius to try would be 12 and 8 <gary_poster> cool <gary_poster> thx <mattuk1972> as thats where the curve start on the horizontal and then the virt <gary_poster> Makyo, thanks for reply. I can imagine pretty easily what we'd want for the image slice css border approach. If we did the svg approach, what resources/assets would we want? We couldn't use an svg of the whole box; we'd want svgs of the four corners, I guess? or what would you recommend? <gary_poster> bac bcsaller benji frankban jovan2 Makyo mattuk1972 (if you want) teknico tveronezi call in 2 <gary_poster> in https://plus.google.com/hangouts/_/409819056ea1551523432ac63f4df4a6feaa5922?hl=en-US * gary_poster has to install google talk plugin and didn't realize... <bac> reminder this is the last day to the the company survey <tveronezi> lunch time... brb <Makyo> Noticeable improvement in speed in FF with the new asset. Still not great, but definitely better. <teknico> gary_poster, so, I had a look at the pdf for #1074298, any pre-imp hints? <_mup_> Bug #1074298: charm panel search results page should match visual design <juju-ui:Triaged> < https://launchpad.net/bugs/1074298 > <gary_poster> teknico, first, leave out the drop-down, if that wasn't clear <teknico> gary_poster, well, that part indeed was clear, yep ;-) <gary_poster> cool :-) <gary_poster> teknico, otherwise, for the buttons, instead of the image, I'd prefer it if you could use the button function that bac made and is tweaking now <gary_poster> teknico, also the search part should already be done, if that's not clear--the searchbox_icon.png and so on <gary_poster> I *think* this should just be CSS teknico <gary_poster> teknico, is all of that clear or would you like to discuss? <teknico> gary_poster, yeah, I thought it would be CSS <teknico> gary_poster, a few specific pointers in code and CSS would speed things up <gary_poster> teknico, cool. Gimme a sec and then we can have hangout? Maybe set up a hangout and then I'll join? <teknico> gary_poster, great, thanks. I'm sure frankban won't be offended if we employ the usual https://tinyurl.com/see-emily-code :-) <gary_poster> :-) k <frankban> :-) <Makyo> Very, very simple branch up for review, lp:~makyo/juju-gui/replace-service-module Just replacing assets. <Makyo> Rietveld: https://codereview.appspot.com/6826057 <gary_poster> Reviewing... <gary_poster> you've got one approval, Makyo <Makyo> gary_poster, Fanks :) Easy, but hopefully helpful. <gary_poster> cool <bac> hi gary_poster -- i've messed with the border-radius and something like "border-radius 4px / 10px" seems close. take a look? <gary_poster> bac, love to. <gary_poster> what should I do? <gary_poster> just change css probably :-) <bac> gary, just mess with it in your browser <gary_poster> ack, on it <bac> gary_poster: i discovered in LESS it has to be written: border-radius: ~"4 px / 10px" <bac> or else it tries to do division. :( <gary_poster> huh <gary_poster> heh <bac> ~"..." tells it to not interpret <gary_poster> that's a good weekly hint bac; or at least an email <gary_poster> bac, cool. my eye likes 4px/7px best but go withe what your eye tells you and show Matt. You could offer to change it live over a hangout tomorrow even <gary_poster> mm, I could be convinced bt 4px/10px bac <gary_poster> by <gary_poster> thanks for exploring bac <bac> mm? <gary_poster> bac maybe just land it? <gary_poster> the "mm" was a sound of thought as I compared the two, side by side <bac> gary_poster: ok, i'll land it. <gary_poster> cool <Makyo> Out to the vet. <benji> Makyo: what is the difference between the buildingRelation and the clickAddRelation flags? <bac> lbox hates me <gary_poster> bac, gave you an approval despite lbox's displeasure with you <bac> gary_poster: cool. just on the MP i presume <gary_poster> bac, y <bac> it blows up trying to access google <gary_poster> boom! <bac> so 'lbox submit' ignores the reviewers from LP. i should've guessed that. no rv = no reviewers in the submit * bac -> dog walk <Makyo> benji, buildingRelation is true if you did the click to add or the long click, clickAddRelation only in the former case. <tveronezi> brb... <bac> tveronezi: there is a conflict in your filter-buttons branch. no big deal but please push a new branch when you get a chance <tveronezi> bac: ok... tkx. <bac> tveronezi: i'll have a full look at it tomorrow before you start. * Makyo dogwalks. #juju-gui 2012-11-06 <tveronezi> bcsaller: good morning. When you have time, please ping me. I need to check with you about the aggregation card. It is already implemented, but I need to check about how it would we enable the debugging mode of this thing. Tkx. <bac> morning <teknico> bac, hi, did you already start work on #1074298? <_mup_> Bug #1074298: charm panel search results page should match visual design <juju-ui:Triaged> < https://launchpad.net/bugs/1074298 > <bac> teknico: no, last night there were no open spots <teknico> bac, would you like to pair on it? <bac> teknico: sure, but i warn you my internet has been really bad. but we can try. <bac> i'm doing a trivial branch to fix a problem in the Makefile but will be ready to start in a little bit, teknico <teknico> bac, ok, great, I'll get something for lunch in the meantime <tveronezi> bac: tkx for taking some time to review my branch. :) <bac> tveronezi: np. very nice work. <gary_poster> Bring me your tired, your poor, your huddled masses yearning for reviews * benji stumbles in from the other room. <gary_poster> lol <gary_poster> bac, for your Makefile branch, trying to figure out how to dupe what you did. I guess you manually cleaned out app/assets/sprite without running make clean? Or is there another way to trigger the situation? <gary_poster> dupe the initial problem I mean <bac> make clean <bac> make <bac> touch some png <bac> make <bac> boom <gary_poster> wfm. will try again <gary_poster> oh, touch some png. <bac> did you do the touch? <gary_poster> no will try that <bac> yes, that triggers the target <gary_poster> yeah makes sense <bac> it seemed trivial enough to self review <gary_poster> boom! <gary_poster> agree bac <gary_poster> I thought you didn't so I was looking at it <gary_poster> if you were already merging it then I'll move on <bac> oh, sorry. <bac> it is merged <gary_poster> oh cool <gary_poster> moving on then :-) <gary_poster> thanks <bac> too bad we have this problem with claiming reviews <gary_poster> y <gary_poster> make <gary_poster> oops <gary_poster> anyway, irc is the best we have afaik <frankban> gary_poster: do you have a min? <gary_poster> frankban, yes <bac> hi jovan2, mattuk1972: i landed a branch yesterday with the two radius button styling for 'deploy' and 'cancel' in the charm panel. take a look please. <frankban> gary_poster: I'm in juju-ui hangout <gary_poster> ok <jovan2> hi bac, will do. <mattuk1972> bac: they don't really bear enough relation to the suru style imo -they almost look like a straight line edge <bac> jovan2, mattuk1972: if you think it needs tweaking perhaps you can play with the values using the interactive CSS editor in chromium <gary_poster> mattuk1972, bac, can also do that with you <gary_poster> frankban, hangouts is unhappy... <bac> gary_poster: i don't understand what you mean <gary_poster> bac, do it in hangout. share screen <frankban> gary_poster: :-/ <bac> mattuk1972: i'm free to do a screen sharing hangout if you have a moment <gary_poster> frankban, going to try restarting. after that will try reinstalling <mattuk1972> bac: I'm in the hangout <mattuk1972> hopefully in the right one <bac> mattuk1972: ok, i'll join now <bac> mattuk1972: you still there? if so can you paste the url you're using <mattuk1972> https://plus.google.com/hangouts/_/409819056ea1551523432ac63f4df4a6feaa5922?hl=en-US <gary_poster> tveronezi, you have plenty of reviewers for the filter-buttons branch, right? IOW, I can't help there? <tveronezi> gary_poster: its done already. Mayko and bac did it. Thanks. <gary_poster> awesome <tveronezi> gary_poster: I will move the card to the ui review lane. <gary_poster> great * gary_poster thinks that the html5 placeholder behavior is annoying * gary_poster thinks it is less confusing if the text disappears on focus * gary_poster came to this conclusion when using another site last night * gary_poster returns to regularly scheduled programming <gary_poster> branches that need reviews: <gary_poster> I need two reviews of this one: https://codereview.appspot.com/6814089/ <gary_poster> Makyo needs two of https://codereview.appspot.com/6782063/ . I will do one. <gary_poster> World ^^^ * benji looks at https://codereview.appspot.com/6814089/ <gary_poster> ty :-) <frankban> gary_poster: looking at Makyo branch <gary_poster> thanks frankban . When I merge trunk tests fail, fwiw. Trying to remember which charms are subordinate also :-) <gary_poster> http://jujucharms.com/charms?sub=1 <gary_poster> frankban, I think the branch has bitrotted enough (over a week in review queue) that we need Makyo to polish it up, thngs are noty quite working for me <gary_poster> I'm going to halt my review for now with that note <frankban> gary_poster: makes sense, so, I won't proceed, and back to my branch after a launchpad review! <gary_poster> frankban, sounds good. <gary_poster> bac, can I move "Makefile broken" card to done done? <bac> yes <gary_poster> thx <gary_poster> jovan2, mattuk1972 we have a goal of cards staying in one lane for no more than 24 hours. I recommend that for the design cards, but I <gary_poster> 'm thinking more of the UX review cards <gary_poster> it would be great to have those resolved one way or the other by the time of our call in 1.5 hours <gary_poster> We have five cards waiting for you, which actually fills up the WIP limit--which is arbitrary, but indicative of a blockage <jovan2> hi gary_poster, will take a look at them in 2 ticks <gary_poster> thanks much jovan2 <jovan2> gary_poster can you confirm that this is what is what I should be looking at: http://636-721-3251:8080/ if there is no other link in the kanban card? <gary_poster> jovan2, correct (the more human friendly spelling for the same thing is http://uistage.jujucharms.com:8080/ ) <gary_poster> slightly more human-friendly, anyway :-) <tveronezi> bcsaller: do you have a minute to g+? <bcsaller> tveronezi: yeah, sorry I didn't get back right away <bcsaller> I'll hop on g+ now <tveronezi> ok... tkx. <benji> gary_poster: I'm done with reviewing your branch. <jovan2> gary_poster: Not sure what I should be looking at for the card Charm Panel Full Screen - it doesn't look any different to how it was before. I must be missing somethingâ¦ <mattuk1972> bac: i had a play with the css and ill mail you <bac> mattuk1972: great <bac> thanks mattuk1972 <gary_poster> thanks benji <benji> my pleasure <gary_poster> jovan2, the charm panel used to be a popup <gary_poster> before my branch <gary_poster> now it fills the right hand side <gary_poster> if you don't have any issues with it, I guess we can mark it as a victory :-) <gary_poster> unless you object, I'll do so <jovan2> gary_poster, yes, sure, that's a victory! For nowâ¦. I thought by Full Screen you might have meant the full charm store! Which would have been a really great advance since yesterday! <gary_poster> lol <gary_poster> especially without UX and visual design :-) <gary_poster> thanks <jovan2> gary_poster: I know you like to keep one step ahead if possible :) <gary_poster> lol true <gary_poster> benji, bac, lp2kanban needs to be taught about our two-review policy <gary_poster> it is trying to drag cards from reviewing to UX review after a single review <gary_poster> I guess I'll make a slack card <benji> mmm <mattuk1972> gary_poster: the card about indicator - can u shed some light? is that the "growl" type notification? <gary_poster> looking <gary_poster> mattuk1972, I think so. bcsaller made that card (I looked at its "history"). bcsaller, could you elaborate on those two cards you made so that jovan2 and mattuk1972 have a better idea of what we are requesting? <mattuk1972> I think it relates to the notification wireframes here -https://docs.google.com/a/canonical.com/file/d/0BwQq-CeM0YioZGV5TS1sU3hvaFU <bcsaller> gary_poster, mattuk1972: Sure I can make some notes, the jist is the view all notification page isn't designed and I don't think we had final design for the menu now as it relates to the new charm panel, so both need to be discussed. <mattuk1972> gary_poster: in regards to the charm panel -im not sure the fade out to close works that well? <gary_poster> mattuk1972, maybe I don't have privileges but I get "Sorry, the page (or document) you have requested does not exist." from that link <mattuk1972> bcsaller: cool - will get onto that next <gary_poster> mattuk1972, cool, that's why we ask for your feedback. :-) slide up? slide right? <gary_poster> (the fade out is easiest to code so it's a good starting point in case it is OK visually :-) ) <mattuk1972> gary_poster: seems some things in the visual design are no longer in the charm store? like the view sorter? show me all/recent/favourites? <mattuk1972> things like the scroll bar design and font size/weight/colour and line spacing are all very different? <mattuk1972> also the divider between cells and the cell colour? <mattuk1972> and the position of the button and where the text should wrap <mattuk1972> is there something you want me to do for review of these? <gary_poster> mattuk1972, depends on what it is. Remember we do things bit by bit also. Right now the only thing that is in that branch is converting it into a full right side panel instead of a popup. So in the case of the view sorter, I think you are talking about the drop-down. We didn't do that initially both because of time and because of lack of confidence in direction. I made a bug for the second part and talked to Jo <gary_poster> van about it yesterday. Bug is 1074296. <gary_poster> mattuk1972, since it is fresh on your mind, let's have a quick call <mattuk1972> sure <gary_poster> I think we have everything coming along, but if we missed something, I should make another bug <gary_poster> mattuk1972, https://plus.google.com/hangouts/_/409819056ea1551523432ac63f4df4a6feaa5922?hl=en-US <gary_poster> bac bcsaller benji frankban jovan2 Makyo teknico tveronezi call in 1 <tveronezi> jovan2: do you have a minute to talk about the filter buttons? https://plus.google.com/hangouts/_/47a7aab138b3ca13a291c18caa947ae158f3d995?authuser=0&hl=en-GB <Makyo> Oops, restart for updates, back in a bit. <tveronezi> lunch... brb. <teknico> gary_poster, oh, there was actually one more thing: <gary_poster> ok <teknico> gary_poster, can you please move that card from backlog into prototyping for me? <teknico> gary_poster, it's kind of hard finding it among the vast backlog sea :-) <gary_poster> :-) teknico I moved it to "ready to code" <gary_poster> I think we might be full even though it doesn't look like it <teknico> gary_poster, uhm, I cannot see it, which one is it? <gary_poster> teknico, bug 1074424 <_mup_> Bug #1074424: Make GUI charm able to configure user & password for the rapi-rollup branch <deploy-story> <juju-ui:Triaged> < https://launchpad.net/bugs/1074424 > <frankban> gary_poster: my card was automatically moved to UX review... but I think the correct path is 'active reviewing' and then UX review, right? <teknico> gary_poster, that one? user and password? something escapes me... <gary_poster> frankban, right. I'm hoping I might have just fixed it by renaming the columns <gary_poster> moving those back <gary_poster> teknico right sorry, was too quick, one sec <frankban> gary_poster: for UX reviews, hangout + screen share with mattuk1972? <gary_poster> teknico, bug 1074410 <_mup_> Bug #1074410: Need juju GUI charm that connects to improv <deploy-story> <juju-ui:Triaged> < https://launchpad.net/bugs/1074410 > <gary_poster> where I said it would be, now <gary_poster> :-) <teknico> gary_poster, thanks (you may have it some kanban bug, it said you moved this one earlier too, but then moved the other one) <teknico> s/have it/have hit/ <gary_poster> frankban, we are still shaking that out. Jovan also does reviews then. Why don't you try what you said and report back if it seemed to work well. The alternate approach is to just move the card to the UX lane and ask them to look at it without you <gary_poster> but then you need to make sure you clarify what they need to do <teknico> gary_poster, oh, and then I'll need the other card in misc for learning the tools, shall I make it? <gary_poster> teknico, put it in slack please, and +1 <teknico> gary_poster, will do <gary_poster> thank you <frankban> gary_poster: doesn't the second option require the branch to be already merged? <gary_poster> frankban, it usually is <gary_poster> that's why it is after "landing" <frankban> gary_poster: aha! ;-) <gary_poster> but I would prefer to have it earlier <gary_poster> as you expected <gary_poster> then our review period would require four reviews before landing though. oof <frankban> gary_poster: so, right now, if a fix is requested by UX we should 1) create another card, another branch, 2) hack 3) new review/UX review? <gary_poster> frankban, yes. if they specifically requested the branch, getting the review earlier probably makes sense. <benji> new branch up for review: https://codereview.appspot.com/6821088 <benji> anyone remember which days we did not have dinner provided in Copenhagen? <gary_poster> benji, frankban and bac both have notes on this <gary_poster> benji, coudl you please make a bug for your branch under review? <gary_poster> Makyo, I made bug for your firefox work and linked it to card <gary_poster> benji, you can ask me to make your bug too if you want :-P <benji> gary_poster: I thought I asked lbox to make one. I will now ask you to make one. <gary_poster> :-) ok * benji will soon be delegating all work to software or gary_poster <gary_poster> :-) <gary_poster> maybe it is in MP but not card... <gary_poster> nope <frankban> benji: here are my notes: http://pastebin.ubuntu.com/1334735/ <benji> frankban: thanks <gary_poster> benji, heh, your MP comments don't really help the reviewer figure out what the heck to do :-P um...I'm copying over the text from Matt's original MP... <benji> gary_poster: yeah, I felt bad writting that, but I didn't really know what else to say; I should have worked harder <gary_poster> updated in MP; transferring to bug... <benji> frankban: do you remember how much the 2 zoner to/from the airport was? <benji> I seem to recall 45 DKK <gary_poster> benji, you'll need a receipt for that I think <gary_poster> (I was burned on that in Montreal, for a lot more $$) <benji> gary_poster: I might have one; are they worried that we walked and pocketed the money instead? <gary_poster> benji, or perhaps it is a business/legal requirement, since these reimbursements are not taxed? Not sure <gary_poster> but that was my guess <frankban> benji: 2 zones -> 24, 3 zones -> 36 ... and unfortunately I pay taxes on these reimbursements :-( <benji> frankban: they you should expense the taxes, and then expense the taxes on the tax expenses, and then expense those taxes * benji should start an international tax consultancy <frankban> benji: :-) <gary_poster> taxed on reimbursements: :-( I got concerned about that a while ago because of the high amount of money I was shelling out for ec2. In America we are not being (double) taxed for that money, according to the tax consultant we used. <benji> gary_poster: If I were expensing as much on EC2 as you were, I wouldn't be concerned with the taxes as much as the DEA thinking that I was laundering an entire south-american country's economy through EC2 <gary_poster> lol <frankban> gary_poster: I need to change my consultant... and maybe my country :-) <gary_poster> :-) <benji> gary_poster: expenses filed <gary_poster> cool benji, thanks. I will review all of those today <tveronezi> bcsaller: https://codereview.appspot.com/6821090 please take a look when you have some time. <bcsaller> tveronezi: yeah <teknico> frankban, I vote New Zealand (but you know that already) <frankban> heh * benji downloads the Quantal ISO <bac> benji: didn't you have one in your goody bag? <benji> bac: ooh! I do. Thanks. * bac is looking at his on the desk <Makyo> Did my upgrade through the updates center. Took a while, and totally taxed the machine. Ah well. <bac> Makyo: i did too. even found a bug, which i reported directly to mvo when i ran into him in the airport <bac> turns out it doesn't like you plopping directories into /etc/apt/sources.d. tries to open them as files. <Makyo> Ah :/ * benji starts to upgrade with fear and trepidation. <tveronezi> brb... * benji restarts into Quantal. <benji> as always, some of my settings have been reverted to the default, but things appear to be working <bac> benji: is your machine ready and able to do a quick hangout? i've got a layout problem i'd like some help on for just a bit. <benji> bac: I think so * benji tries to figure out how to launch firefox. <bac> gary_poster: hey, you have a moment? <benji> gary_poster: your presense is requested at https://plus.google.com/hangouts/_/b2ccac118e89d6e06b6e85a0dca260988e8a8d98?pqs=1&hl=en&authuser=0# <gary_poster> bac, y <bac> gary_poster: could you join ^^ <benji> grr, why does alt-tab not work <gary_poster> wfm <Makyo> gary_poster, #1074336 has a card already, in Subdivide 7 <_mup_> Bug #1074336: Environment view service menu has non-functional "unit" option <juju-ui:Triaged> < https://launchpad.net/bugs/1074336 > <Makyo> Want me to link? <gary_poster> Makyo, mind if I just delete it in backlog? I kind of regard the backlog as a big trash pit. :-) I think hazmat wants to garden it later though <Makyo> gary_poster, Sure, whatever works :) <gary_poster> (I actually don't care which one we delete, but it is ready to code) <gary_poster> cool thanks <gary_poster> benji, looking at your branch. So...where are you on the goals of the yui doc work? You and I are both diligently commenting on the option-type functions, like line 23 of https://codereview.appspot.com/6821088/diff/1/app/views/environment.js?column_width=80 <gary_poster> We are using a yuidoc "trigger" of /** <gary_poster> but yuidoc will never pick up on these <gary_poster> we're doing them because the linter complains otherwise <gary_poster> AIUI <benji> gary_poster: I thought the yuidoc branch was merged <gary_poster> it is, benji <gary_poster> I must be talking past you <gary_poster> alongside you <gary_poster> in cross directions <benji> gary_poster: hangout <gary_poster> benji, I'm talking about the philosophy of commenting these things <benji> ? <gary_poster> k <gary_poster> juju-ui if it is available <gary_poster> it is <gary_poster> hanging out <benji> gary_poster: I hear treadmill but I don't see you * bac done. <benji> gary_poster: I lost you. <tveronezi> bcsaller: do you have a minute for another pre-implementation chat? <bcsaller> tveronezi: yes, I'll hop on g+ <bcsaller> tveronezi: oops, occupied it looks like, we can open another <tveronezi> ok... on it... <Makyo> gary_poster, What was the bad behavior you were seeing from subordinate services? (That broken test took a while, sorry, will make a card) <gary_poster> Makyo, on call <Makyo> gary_poster, np <gary_poster> Makyo, hey. So, I added a subordinate, and it went to 0, 0 and never moved out. Then when I tried to make relationships they were tied to 0, 0 <gary_poster> (relationships from the subordinate) <gary_poster> if you can't dupe trivvially I'm happy to try and write up a recipe <gary_poster> though I am at my EoD <Makyo> gary_poster, Sorry, stepped away. I can reproduce, but I get that in trunk. Was just curious. Will play around with it. Have a good evening :) <gary_poster> Makyo, oh ok <gary_poster> wondered about that but did not check <gary_poster> mm... <gary_poster> so I guess you can reload the page after adding a subordinate to TEST YOUR <gary_poster> oops, fun with caps lock etc <gary_poster> ...to test your branch <gary_poster> I'll look at it tomorry <gary_poster> have a good evening <Makyo> Yeah, it seems to be a event-not-binding thing, but only for subordinates. I'll keep poking. Ciao #juju-gui 2012-11-07 <mattuk1972> hey frankban: <mattuk1972> Ive got a fair bit of feedback -all small little details - would you like me to talk you through it or make a document? <frankban> mattuk1972: some notes would be great <mattuk1972> okily <frankban> mattuk1972: thanks <bac> frankban: regarding colors, I used a color picker to look at the colors on the assets referenced on the visual design <bac> they are similar but a bit different, which is why i mentioned it <frankban> bac: ah! i have to re-check then... however, I am also waiting for the UX review, so I will fix things up all together. thanks Brad. <bac> frankban: we've got too many specs to reference! <frankban> bac: heh... and the borders in charm-store_detailview_preview.png are shadowed, that can explain the color picking mismatches. <hazmat> frankban, pushed test fixes for rapi fwiw <frankban> hazmat: cool <mattuk1972> Frankban: bac: was just going to work though the screen grab and mark out the difference in colour,font weight size and colour and cell size - theres quite a lot of difference <bac> hazmat: welcome back. you here for real? <frankban> mattuk1972: thanks <hazmat> bac, not yet, just dropping by, and going through emails <hazmat> bac, back for real next week <gary_poster> There is WIP room <gary_poster> looking to give reviews... <frankban> mattuk1972: awesome review, thanks! <gary_poster> frankban, approved your branch with chatty comments <frankban> cool gary_poster, thanks. <gary_poster> np <gary_poster> Makyo, hey. Should I mark https://code.launchpad.net/~makyo/juju-gui/replace-service-module/+merge/132938 as rejected so we get it out of the review list? <gary_poster> Also, I think you said you had tests fixed for https://codereview.appspot.com/6782063/ . If you push those then I can review. I'm OK with separating out the subordinate creation problems into a separate card <gary_poster> bac, I dunno why LP didn't recognize https://code.launchpad.net/~bac/juju-gui/trunk/+merge/133060 as merged, but it is, so I am marking it as such <BradCrittenden> thanks gary <gary_poster> benji, tveronezi I will be reviewing your branches. Could you also do some work to rustle up a second reviewer for your branches so we can move things along? <gary_poster> I am working on benji's now then will move to tveronezi's two <gary_poster> if anyone beats me to it that's fine by me ;-) <benji> tveronezi: I'll review yours if you review mine <gary_poster> :-) <benji> (Is this some sort of iterated prisoner's dilemma?) <gary_poster> heh <tveronezi> hahah. <tveronezi> :) ok. <tveronezi> benji ^ <benji> :) <Makyo> gary_poster, Sorry I left myself online last night! Sounds good for rejecting that mp. Let me make sure I'm good to push, I agree about the separate card for subordinate issues. <gary_poster> cool thanks Makyo (and np, I do that all the time for better or worse) <gary_poster> benji, approved your branch with comments & small requests <benji> gary_poster: thanks <gary_poster> welcome, thank you <benji> after my upgrade to 12.10, when I visit some sites in Firefox asks me if I want to install NAME-OF-SITE. I have said yes to some but I can't find anything in addons or anywhere else. <bac> benji: i've seen that and said no. wonder what it does <bac> hi mattuk1972, can i ask you about charm search results styling? <bac> namely the intent of list_one_div and list_two_div <benji> on a positive note, I figured out how to kill the persistent tooltips of death <frankban> mattuk1972: so, the border between elements in the charm panel is no longer one line dark gray and one line white. But it's one line dark gray and one line gray, right? With the exception of the first one after the "<- back" section <gary_poster> I think the browser thing has different integration depending on the site. The browser menu may get special options (which can be accessed with the HUD) in some cases; in other cases the site may install controls within the top-right sound menu, for instance, or other existing action menus <benji> interesting; it would be nice if I could figure out what each site's special features are <gary_poster> dunno, but yeah agreed <Makyo> gary_poster, tveronezi: Events are bound in attachSceneEvents, line 338 of environment.js. Since each event is bound in the same way with the same signature, we have to call them in the same way if we're to call them from other closures. I don't know if this is something that might change with refactoring, though. <Makyo> Not sure if that helps explain the pattern or not, bcsaller would probably be better at explaining :) <gary_poster> Makyo, but foo.bar() is identical to bar.call(foo) <gary_poster> so that at least can be simplified, right? <gary_poster> (from the latter to the former) <bcsaller> .call() supports chaining, foo.bar() doesn't by default <gary_poster> bcsaller, that's good to remember, but irrelevant unless we are chaining, yeah? <bcsaller> its useful in the sense that we say "if () {one line expression} because you'll often need it later and the cost is low <bcsaller> the braces I mean * gary_poster not sold on this as a pattern we should therefore follow :-) (YAGNI in the small comes to mind) but maybe we ought to talk about it Friday <Makyo> I have no stake in either. If it changes, it changes :) <gary_poster> :-) <mattuk1972> frankban: the default divider is one grey one white - except on the ones I've marked - where there is suppose to be in inset shadow effect for example <tveronezi> Makyo, gary_poster, bcsaller: It just seems strange to see "this.myFunction.call(this)" but does not break the application. I am good having it if you agree. But don't make it as standard. It should be used only if really need it. <bcsaller> its not Method.call or Method.apply, its d3Selection.call() -> selection <bcsaller> I don't feel strongly either, but the d3 style is chaining <bcsaller> and remembering that something *doesn't* chain is more complex to me <gary_poster> bac bcsaller benji frankban jovan2 Makyo teknico tveronezi call in 2 <frankban> mattuk1972: ok, so, e.g. between description and interfaces, and between interfaces and changelog, it's gray-white. and for all: can you suggest a nice ruler to use with chromium? <bac> frankban: matt has left the building <bac> just as i was about to ask something <frankban> bac: yes... the ruler question is still valid <gary_poster> bcsaller, ack. maybe I don't know enough about context. Good friday conversation maybe <bac> frankban: yes, that would be handy * frankban stops counting pixels and joins the hangout <gary_poster> jovan2, starting <jovan2> gary_poster on my way <hazmat> bac, jovan2 thanks, email sent * bac -> lunch <benji> Makyo: to kill the tooltips you: launch the CompizConfig Settings Manager, enable the Opacity, Brightness, and Saturation plugin, open that plugin, under "Windows specific settings" click the "New" button and enter "type=tooltip" (no quotes) and a value of 0. <Makyo> benji, does that kill all tooltips? <benji> Makyo: yep <benji> you can make the selector more specific to only kill some <Makyo> benji, Cool, thanks. Will try for a while, see if I miss anything <benji> or you can make the opacity very low instead of zero so they will still be there, but be less bothersome * gary_poster lunches <tveronezi> lunch... <bac> gary_poster: the cursor in the charm search box is inially red. mind if i make that gray? <gary_poster> bac +1 thanks <bac> s/inially/initially <gary_poster> it's the valid thing <gary_poster> you probably know that already <bac> gary_poster: it changes as soon as you type <gary_poster> bac, right it is a bootstrap valid thing <gary_poster> I <bac> righto <gary_poster> cool <bac> jovan2: can i ask you about charm search results styling? namely the intent of list_one_div and list_two_div <jovan2> bac: I'll take a look... <jovan2> bac: are you referring to visual design files? <bac> jovan2: yes <Makyo> gary_poster, do you have time for a quick call in a bit? I have a question re: this test. <jovan2> bac: which zip or pdf file should I be looking at? <bac> jovan2: trying to find it on g+ <gary_poster> Makyo, happy to do it. IRC/email might be better in the short term, over next hour or two; after that call would be fine <Makyo> IRC's fine. <gary_poster> cool <bac> jovan2: https://docs.google.com/a/canonical.com/file/d/0B6l8lFdCRvtqNEZ4bElfVjF0Tjg/edit <bac> and the png files in charm_store_assets_1.zip <jovan2> bac: it looks like a difference in background colour - white or grey <bac> jovan2: right, so there are three backgrounds then. one for selected and these other two <bac> is list_one_div really to be applied to the first in the list and the other non-hovered ones to be different colors? that is odd to me. <bcsaller> Has anyone else seen a problem with `make lint` running on recent branches (or maybe since the upgrade to Q)? <jovan2> bac: yes it looks a bit odd to me too. Matt has left already, so will ask him to clarify tomorrow if that's ok? <bac> jovan2: sure. for now i'm going to proceed ignoring list_two_div <jovan2> bac: ok <bac> frankban: is your charm panel description branch going to land today? i need your orange scrollbar <frankban> bac: yes, going to land asap <bac> yay <bac> hey gary, got a second for some pixel counting on stagin? <bac> g <frankban> bac: branch landed <bac> cool, thanks <tveronezi> benji: merge-files.js is entirely ours. :) <benji> tveronezi: ok, thanks; I'll finish the review here in a bit, then <bac> gary_poster, has anyone noted the extra width on the content div, making it hang off 1 px to the right. most visible when the charm panel is extended <gary_poster> I have but I think it is intermittent :-/ <bac> i see it with my branch but noted it is also on trunk. could not easily figure it out. <gary_poster> bac if you resize http://uistage.jujucharms.com:8080/ oevr and over again sometimes it will be just right and sometimes not. I was the last one to touch this code, and I made it a lot more reliable (IMO) but there's still this issue <bac> ok <bac> i'll make a card <gary_poster> ok thx <gary_poster> tveronezi, your Makefile has the same kind of problem that I talked with you about before, with the sprite generation: it runs the compression every time. This is one way to address it: http://pastebin.ubuntu.com/1340722/ <tveronezi> gary_poster: sweet... tkx. <gary_poster> welcome <tveronezi> gary_poster: we dont want to use $(NODE_TARGETS) instead of the node_modules/yui and node_modules/d3/d3.v2.min.js modules. Sure we will download unnecessary stuff, but it would be just once. <gary_poster> tveronezi, that's a question? <gary_poster> or a statement? :-) <tveronezi> gary_poster: yeap... question. :) <gary_poster> heh ok <gary_poster> I originally used $(NODE_TARGETS). I then wanted to be more specific about what this depends on. The most proper approach IMO would be to add app/assets/javascripts/d3.v2.min.js and *all* of app/assets/javascripts/yui/* (recursive) to $(NODE_TARGETS) (which is true--we're making those too) and then depending on the d3 and the yui in app/assets/javascripts <gary_poster> Listing yui was annoying <gary_poster> So but it would be good because that's what the script *actually* depends on <gary_poster> the combinejs script I mean <gary_poster> So then I compromised and said I only depended on nodejs and d23 <gary_poster> d3 <gary_poster> it will still build *all* of the node_modeules <gary_poster> there's no target for "only build these parts of node_modules" <gary_poster> so it is really just documentation <gary_poster> Specifying $(NODE_TARGETS) is *practically* exactly equivalent <gary_poster> tveronezi, ^^ <tveronezi> ok. <gary_poster> In sum, what I did was a documentation compromise. What you propose would be acceptable, and practically equivalent, but not in my picture of how things are really supposed to work with a Makefile. Since I'm only compromising, do whichever you prefer,. <gary_poster> If I were *really* doing it right, I'd feel stronger about it :-) <tveronezi> gary_poster: for some reason, using the $(NODE_TARGETS) does not work. The combinejs always runs three times if I use it. :/ I think I will stick with your first solution. <gary_poster> tveronezi, that suggests to me that the files listed in NODE_TARGETS are not quite right <gary_poster> so you could also try to to tackle it from that perspective <gary_poster> but do what you wish <tveronezi> gary_poster: thanks for your solution for the make files. I was struggling to get it working when I started the branch. I forgot to ask your help before submitting the branch. It works like a charm. <gary_poster> cool tveronezi <tveronezi> gary_poster: do you mind if I create another card for the $(NODE_TARGETS) issue? I mean, another card to pinpoint what is not supposed to be there? <gary_poster> tveronezi, if you wish. to be perfectly honest, I'd plan on forgetting about it until it bit me later :-P Certainly you don't need to address it in this branch IMO <tveronezi> gary_poster: ok... tkx. * bac being summoned to the fort. bbiab. <gary_poster> tveronezi, I submitted a preliminary review for the file aggregation branch; I'll have more later <tveronezi> gary_poster: ok... tkx. <gary_poster> bac, if you are available to review https://codereview.appspot.com/6819104/ then maybe tveronezi and I can review https://codereview.appspot.com/6817101/ <Makyo> Woo, have FF almost as fast as Chrome now. <gary_poster> Wow, Makyo cool <bac> gary_poster: ok. <bac> tveronezi: 2nd review done. thanks. <tveronezi> bac: tkx. <bac> thanks for the review gary <gary_poster> welcome <bac> i set the spacing to 10px as stated. perhaps something else is making it more. <bac> as to the different backgrounds, I asked jovan about it and he was going to check with matt. it didn't occur to either of us that it was alternating a la green-line <bac> if that is their intent, i think they didn't get it quite right on the vis design. makes sense, though. <gary_poster> bac 10px: oh ok. I didn't see the 10px directive, but agreed that this is what you have <gary_poster> so nm <bac> i wish the inspector gave a better way to measure <gary_poster> Makyo, I gave your branch a +1. You still need another look though <Makyo> gary_poster, Why thank ya <gary_poster> :-) <gary_poster> jbye #juju-gui 2012-11-08 <teknico> buongiorno <bac> thanks for the review frankban <frankban> bac: my pleasure <bac> mattuk1972: i've landed your CSS button suggestions for deploy and cancel. thanks for helping to get the colors right and spotting that text shadow. have a look at http://uistage.jujucharms.com:8080/ <mattuk1972> bac: nice one -will take a look when i get a mo <bac> mattuk1972: also, i talked to jovan yesterday about some question about the charm search results panel. he was going to follow up with you. let's chat about it when you have some time. <mattuk1972> sure -ill have some lunch and ping you <bac> i'll be here <bac> just noticed the codereview bot has been sending me G+ chat messages. has that been happening a long time? * benji fires up the coffee maker. <tveronezi> bcsaller.... I am reviewing you code. <gary_poster> tveronezi, bcsaller hi. I was happy to see that tveronezi had a pre-imp on the code minification/aggregation branch. It turns out benji and I had a shared observation/request that went against the pre-imp call discussion. benji and I felt that the build tool belonged in the top-level bin directory, while tveronezi said that Ben asked to move the file into app/assets. That seems like an odd choice to me, because <gary_poster> the app is what we are supposed to serve, and this file is a build tool. I thought it might be a good idea
{'channel': 'juju-gui', 'month': 11}