#juju-gui 2013-02-01 <teknico> NOTICE: about to make a release <benji> yow, it's a little cooler this morning than I expected, -7C <teknico> will someone else check that the release candidate tarball on staging is fit for final release? thanks https://staging.launchpad.net/juju-gui/stable/0.2.0/+download/juju-gui-0.2.0.tgz <benji> teknico: I'll be glad to look, although I'm not entirely sure what all should be checked <teknico> benji, thanks, there are some suggestions in the release checklist, in docs/process.rst <benji> cool, I'll look at those <teknico> frankban, how do I "juju deploy" from staging? <benji> teknico: the release looks good. The tests pass and I started the app and poked around in it for a while and everything worked as expected and no JS errors were generated <teknico> benji, great, thanks <benji> my pleasure <frankban> teknico: you can't. You may want to make and upload a trunk release and then test it before uploading the stable one, e.g.: "juju-gui-source: trunk" in the config file. you can also run the charm tests against trunk setting the env var JUJU_GUI_SOURCE: JUJU_GUI_SOURCE=trunk jutsu test... <benji> frankban: speaking of the charm, I haven't been able to use the juju-gui-source setting to get the charm to run against a different release; is it supposed to work and how am I supposed to use it? (I have been doing a "juju set" just after deploying the service.) <frankban> benji: it should work <benji> ok, I'll try again and see if I can track down what is going wrong; I assume the "juju set" bit is the right way to do it, correct? <frankban> benji: something like "juju set juju-gui juju-gui-source=0.1.4 <benji> frankban: oh, I thought you could give it a branch URL <frankban> benji: otherwise you can pass a customized config.yaml to deploy --config <frankban> benji: yes, that too, e.g. juju-gui-source=lp:juju-gui <benji> cool; I'll try harder then ;) <frankban> benji: it is considered a branch if it starts with "lp:" or "http://" <benji> oh, so no "bzr:"? That is probably where I was going wrong. <frankban> benji: precisely, we should add the "bzr:" scheme too, it's quite easy, feel free to create a card if you want to <benji> frankban: will do <frankban> benji: cool thanks <teknico> benji, while you're at it, maybe add to the card the possibility to deploy from staging :-) <benji> teknico: sure :) <benji> frankban: https://bugs.launchpad.net/juju-gui/+bug/1112529 <_mup_> Bug #1112529: Support "bzr:" scheme in juju-gui-source charm setting. <juju-gui:New> < https://launchpad.net/bugs/1112529 > <benji> teknico: https://bugs.launchpad.net/juju-gui/+bug/1112530 <_mup_> Bug #1112530: Support deploying the GUI charm from LP staging <juju-gui:New> < https://launchpad.net/bugs/1112530 > <frankban> thank you! <teknico> benji, thanks <benji> np <frankban> guihelp: I wonder how, now that the charm is in the store, we are supposed to re-propose new changes <frankban> teknico: done? <teknico> frankban, what? <frankban> teknico: the release <teknico> frankban, nope, still upoading <teknico> or something :-) <hazmat> frankban, merge proposal .. with approval by charmers <teknico> frankban, but I think there's no need to wait landing branches now <hazmat> frankban, so ideally if there's a round of dev on it, we'd do it with our normal process against the team branch, and then propose to the official charmers version <frankban> hazmat: so, we might want to collect some changes before re-proposing <hazmat> frankban, yes <frankban> hazmat: cool, thanks <hazmat> frankban, technically the distinction isn't in the store but the owner in the store. <hazmat> np <teknico> frankban, finished, https://launchpad.net/juju-gui/+milestone/0.2.0 <frankban> teknico: great! <hazmat> frankban, its about 2-5 days for a charmers review.. this their queue http://jujucharms.com/review-queue <frankban> hazmat: ack. so, I'd suggest, e.g. when testing the GUI (deployments, new releases, etc.), to always use the latest version of our charm, i.e. most of the times, the one owned by juju-gui. what do you think? <hazmat> frankban, sounds sensible, but socially we want to continue distill/promote to charmers (aka the official charm) <frankban> hazmat: of course. agreed <frankban> teknico: the release tarball seems broken :-( . http://pastebin.ubuntu.com/1597149/ <teknico> what?!? <frankban> teknico: I am downloading the tarball, I will try to uncompress it manually. <teknico> frankban, me too, the local copy is correct <teknico> the size is wrong, and the content is junk :-( <frankban> teknico: I confirm the uploaded tarball is broken. please remove the release <teknico> frankban, done, I'll upload again <teknico> guihelp: the release tarball on staging is correct. Is there a way to upload that copy to production, rather than the one I have locally? <frankban> teknico: I don't know and I guess no. however, why do you want to do that? I suggest to try the release process again, it could be nice to find what's wrong. Is there a final tarball (downloaded from launchpad) qa step? if not, we should add it. <hazmat> teknico, define production? <teknico> hazmat, I meant stable <teknico> frankban, I'd like to do that because it would be easier and faster. The release process has went well up to generating the tarball: as I said, the local one is correct. I am uploading it again. <hazmat> teknico, i don't know, effectively your asking can we can copy tarballs in launchpad to replace a broken one? <teknico> frankban, you can find the release checklist in docs/process.rst. There are a number of qa steps, I'll add one more. <hazmat> teknico, that seems best.. if the tarball is entirely broken.. replacing/updating seems okay.. <teknico> hazmat, I deleted the broken one already <teknico> hazmat, I'm asking if we can do a lp-to-lp copy in place of a standard upload, as a matter of convenience <frankban> teknico: thanks, I believe that checking that everything is ok with the tarball at the end of the process is without doubt a good idea ;-) <teknico> frankban, I guess we hadn't yet had problems with the final uploading step <teknico> I'm still mistified how this could happen <hazmat> teknico, not that i know <teknico> how do you end up with 34MB of garbage after having uploaded a 25MB tarball? <frankban> teknico: try to restart your router ;-) <teknico> frankban, I'll see if they can restart the internet <benji> https://www.youtube.com/watch?v=iDbyYGrswtg <teknico> broken again :-( <teknico> this is even weirder though: <teknico> the gpg signature on lp is correct, while the file is not <benji> the Elders of the Internet want us to have a standup in 3 minutes <teknico> I guess the upload_release.py script uploads the .asc signature file too <goodspud> Hey all. Are we having our daily stand up today? * frankban connecting to the Internet for the daily call <teknico> deleted again :-/ <hazmat> is ther a standup? <hazmat> looks like <bac> teknico: at least len(juju) < len(ensemble) <teknico> bac, that's true :-) <hazmat> :-) <hazmat> bcsaller, we're really short on pyjuju reviewers.. if you have a moment would you mind having a look at https://codereview.appspot.com/7241062/ <bcsaller> hazmat: yeah, just proposed my branch so I can look at that one now <hazmat> bcsaller, thanks, its thankfully pretty small <hazmat> a one liner and a drive by <benji> teknico: a small branch you might review: https://codereview.appspot.com/7231077 <teknico> benji, looking <teknico> benji, there's a conflict in the lp diff, and Rietveld says "error: old chunk mismatch" on docs/process.rst <benji> darn; let me look <benji> teknico: fixed: https://codereview.appspot.com/7231077 <teknico> benji, looking <teknico> benji, I uploaded the release tarball to U1 (and downloaded it to check, successfully) <teknico> benji, I shared a folder with you, you should have an email <teknico> benji, in the folder you'll find the tarball and the .asc signature file <benji> teknico: cool. I suppose that I should pick up the release instructions just after the bit about making sure the release works, right? <teknico> benji, yes, you should put both of them in a releases/ directory in a juju-gui branch <benji> k <teknico> benji, well, the release checklist says to run "FINAL=1 PROD=1 make dist" <teknico> benji, that also tries to build the tarball <teknico> benji, you only need to run the last step: "python2 upload_release.py juju-gui stable 0.2.0 releases/juju-gui-0.2.0.tgz" <benji> sounds good <teknico> benji, however, I don't know where the upload_release.py script comes from :-) <teknico> it appears in the branch dir during the release process <teknico> like, it's magic ;-) <benji> I can work that magic. <teknico> that's good :-) <teknico> benji, do you have time for a quick hangout? <benji> teknico: sure; is juju-ui free? <teknico> let's see <benji> it is <Makyo> James is home sick, I'm going to duck out to a coffeeshop. Hopefully less awful coughing there. <benji> teknico: https://codereview.appspot.com/7231077 <teknico> benji, looking <benji> k <frankban> so, you think you love JavaScript? http://dmitry.baranovskiy.com/post/91403200 <teknico> guihelp: I cannot find the standard review markers we decided upon ("Land as is", "Land with changes" and so on), where are they? <Makyo> teknico, I don't know if we wrote those down anywhere. It's those two and "request re-review", as far as I know. Any suggestions on where we should put them? Docs, maybe? <hazmat> process.rst would do the trick <teknico> that's where they are! <teknico> silly me, I was reviewing exactly that file :-D <Makyo> Oh! Well, there you go :) <teknico> it must be friday afternoon ;-) <teknico> benji, I'm sorry, one more iteration needed :-) <benji> heh, no worries <benji> comments in the review? <teknico> benji, yep <benji> cool <bcsaller> Makyo: can I ask what you found to be at the core of the dragging issue? <benji> teknico: once more, with feeling! https://codereview.appspot.com/7231077 <teknico> benji, allegretto con brio! <Makyo> bcsaller, When things were updated, the datum associated with each service didn't equal the datum passed in as 'd' to drag. When setting the translateStr in selection.attr('transform', function(d) { return d.translateStr(); }), we were also overloading the 'd' variable. Changing it to function(datum) and still using 'd' fixed that. <benji> :) <bcsaller> ahh <Makyo> bcsaller, Additionally, the service in the relations was being matched on modelId, but the relations objects were stale, so relation lines weren't updating properly either. <Makyo> ...relations which used to be 'relPairs', to clarify. <teknico> benji, done <teknico> I guess we need to come up with some joke like: "What do you call two perfectionists one-upping each other? ..." <teknico> missing the closing part though :-) <benji> teknico: I have a good punchline but if I tell you, you will come up with a better one. <teknico> benji, true, but someone's got to give in sooner or later :-) <teknico> benji, btw, any luck with the release upload? <benji> teknico: I got the file, but other than that I have been distracted by the QA bits. I'm looking at it now. <teknico> benji, out of curiosity, what upload bandwidth do you have available? <benji> teknico: 5 megabit <teknico> upload?!? oh wow. oh wow. <benji> my link is hilariously asymmetrical: 100 down, 5 up <teknico> well, around here it can be 20 (nominal) down, .3 up, so... <teknico> more than .5 up is almost unheard of <teknico> that is 0.3 and 0.5 resp., to be clear <benji> yeah, that's common here too; one of the big reasons to buy this particular house was that a good connection was available <bac> https://files.one.ubuntu.com/sEhlVl2GRu28wl3nHw2rhw <bac> bcsaller: can you see that link? <bcsaller> bac: after SSO it gives me an error <bac> doh * Makyo discovers lack of charger in laptop back. Back home <benji> Makyo: when you walk into the house start yelling "Unclean. Unclean!" at the top of your lungs <bac> bcsaller: was trying to show you the screenshot for bug 1112717 * bac needs to figure out ubuntu one share settings <bcsaller> bac: its on the bug itself, right? <bcsaller> I can see it there <bac> bcsaller: yep <bac> just another amusing/hair pulling bug <bcsaller> thats great :-/ <bac> bcsaller: if you can think of things you think may be broken let me know and i'll try them <bac> so far it is fish in a barrel <bcsaller> bac: I find that surprising as is, at this point I'd assume it mostly doesn't work. Anything with a transform attr on it is suspect it sounds like <bac> bcsaller: do you think the exercise is pointless atm? <bac> i.e., is there a class of problem that may be solved in one way so there's no need to identify them all? <bcsaller> bac: no, generating a list of things that don't work is fine, but I don't think you need to find them all, just calsses of errors <bcsaller> classes <bcsaller> sounds like the same thinking <bac> calluses of errors #juju-gui 2013-02-04 <bac> morning <frankban> gary_poster: hi, do you have a minute? <gary_poster> hey frankban. Maybe 15 minutes from now ok? can do sooner if needed <frankban> gary_poster: 15 minutes are ok, thanks <gary_poster> cool, will ping <gary_poster> frankban, took longer than expected, sorry. ready now in juju-ui <frankban> gary_poster: joining <bac> benji: second review done <benji> thanks bac <teknico> bac, what does this sentence of yours mean? "the wrapper should be goldenrod with maybe an accent wall" <bac> teknico: :) <bac> just a light-hearted reference to bike shedding <teknico> oh, I see <teknico> ok, what does it mean in literal tems then? :-) <bac> goldenrod is an awful color from the 70s used in suburbia. i think it is actually resurgent now <bac> used in conjunction with an avacado colored dishwasher <teknico> and an accent wall is one wall in a room which is of a different color than the other ones <teknico> which is not something that I'm accustomed to :-) <bac> yes, inexplicably. i came home one day and found one wall in the living room was orange. it eventually grew on me. <gary_poster> bac bcsaller benji frankban goodspud hazmat Makyo teknico call in 2 <alejandraobregon> gary_poster: arosales: hazmat: hey guys... <alejandraobregon> goodspud is working on a scoping diagram for 13.04... I believe he's shared it <alejandraobregon> goodspud and i were thinking it would be good to use our meeting to discuss it <alejandraobregon> and clear up any areas that are hazy right now <arosales> alejandraobregon: ok, I'll check mail. Should we follow up on this on the upcoming call in ~14 minutes? <alejandraobregon> gary_poster: arosales: hazmat: What do you think <alejandraobregon> arosales: that was my thinking.... i have to attend a tablet meeting... and thought would be useful to use that hour to further define the scope for 13.04 based on goodspud diagram... <alejandraobregon> arosales: can be here for the first bit... <alejandraobregon> arosales: gary_poster is there anything else we should cover at our meeting <gary_poster> alejandraobregon, sorry on call. that sounds good. goodspud and I have a good handle on the immediate deliverables afaik, so if you want to touch base on that to know where we are that is fine, but I don't have concerns there. All's good <alejandraobregon> gary_poster: excellent! okay so i'll leave you in goodspud 's capable hands... he could use the hour to get clarity on a few things <bcsaller> teknico: do you want to have that talk now or wait till matts up and about? <teknico> bcsaller, let's do it now, thanks <bcsaller> teknico: back in gui hangout <goodspud> arosales, gary_poster, can't join the hangout "You are not allowed to join this hangout" <gary_poster> goodspud, try using Canonical account? <arosales> need canonical account <bac> Makyo: i'm trying to replicate the drag problem on uistage and can't see the failure. should it still fail there? <gary_poster> yes bac <gary_poster> lemme see if I can see it <bac> i've never seen it so perhaps i'm doing it wrong <gary_poster> bac I do not see it on uistage anymore either <bac> gary_poster: ok. i'll try locally <gary_poster> bac ok <Makyo> Not seeing it either. Maybe bcsaller's refactor fixed it. Trying two browsers <Makyo> Can't reproduce with two browsers locally. Oh well! That's good, then. <gary_poster> Hey goodspud do you have five minutes? Literally, because I have to run :-) <goodspud> gary_poster, certainly do <goodspud> hangout? <gary_poster> thanks goodspud , yeah <gary_poster> juju-ui <teknico> Makyo, time for a quick hangout? <Makyo> teknico, sure. <teknico> uhm, I'm trying to add you to a hangout, but it tries to call you, I don't know why :-) <teknico> Makyo, ^^ <teknico> Makyo, https://plus.google.com/hangouts/_/02bb45411739e441fe107c9f66e2a8cc36ba4ba7 <Makyo> teknico, I'm there, but I don't see you. <benji> teknico: revised branch up at https://codereview.appspot.com/7248050 <teknico> benji, looking <teknico> benji, for some reason when looking at the patch set 2 of your branch, I cannot see inline comments anymore <teknico> I wonder why, it makes things cumbersome <benji> that's a good question; I think I have had that problem before. I have no idea what causes it. <bac> Makyo: second review done <Makyo> bac, thanks. Will play around with the branch some more and see if it's needed anymore. If nothing else, I can turn it into a get-rid-of-magic-numbers branch. <teknico> benji, approved, all comments in the reply, not inline <teknico> benji, I'll try to tone down the bikeshedding :-) <bac> Makyo: ugh, look at this render in FF on os x. seems to be a newish regression. https://docs.google.com/a/canonical.com/file/d/0B4pGCY-5QO19d0VtT0l4NHNxMk0/edit?usp=sharing <Makyo> bac, lunch, will be back in a few to get to it. <bac> no rush <benji> thanks, teknico; looking now <gary_poster> bac, interestingly and somewhat unhappily, FF on Quantal does not have that problem :-/ <bac> gary_poster: yeah <bac> gary_poster: this is ff 18.0.1, fwis <bac> fwiw <gary_poster> bac also 18.0.1 <gary_poster> (on ubuntu I mean) <bac> gotcha * bac -> dentist <gary_poster> benji, thank you for the CI progress. two questions. first is to please send the group an email about what needs to happen next. Are we simply waiting on Diogo to set up something in Jenkins, or do we need more work on our side before that can happen? I'm happy to have a call and be the scribe if that would be a help. Second is from the review. bac asked you in review why you used the python-shelltoolbox branch <gary_poster> rather than using the packaged version (which presumably means specifying in the HACKING document that the deb package should be installed). You replied that this was a mistake you planned to change ("Because I was supposed to change that before proposing the branch. Fixed.") but the Makefile in trunk still looks the same. Actually...he also asks whether selenium should be a dependency of test-misc, and you say y <gary_poster> es, but everything looks the same there too. Do you know what is going on with those? If so, I'm curious, and if not...I'm curious. :-) <gary_poster> "I'm happy to have a call and be the scribe if that would be a help." I mean you and I could have a call, and I could write down what you tell me is next, and send the email. <benji> gary_poster: re. python-shelltoolbox; I misread his statement to be about selenium (i.e., not installing from a tar in archives/; which is what I changed) <gary_poster> benji, ah! <benji> it is better in my estimation to require a bzr branch vs. a deb install but I can do otherwise if wanted <gary_poster> why benji? that is shared across the system, which has limitations, but this package changes little, and we have quite a bit of precedent <benji> automation <benji> maybe putting package installs in the Make would be good middle path <benji> s/Make/Makefile/ <gary_poster> we have charm automation for this, and shell toolbox might provide, but not sure <benji> perhaps a card to make "make" make all that needs to be made (removing some of the prose in HACKING) <benji> oh! another reason: the tests need a nice, new version of the selenium package which I don't think is available <gary_poster> benji, remember we are talking about python-shelltoolbox not selenium :-) <gary_poster> benji, for now would suggest putting python-shelltoolbox in HACKING and removing virtualenv for that. we use virtualenv where we have to but generally prefer packages in this project atm. I guess we could have the Makefile do sudo <gary_poster> Then we could make the card as you describe <gary_poster> I'm ok with doing this myself benji <benji> right, but the code that is run needs selenium... hmm, but I guess that is technically a non-sequiter (sp?) because although the "driver" is a Python script and the tests are too, we can run one with the system python and the other with our virtualenv <gary_poster> but want to check you are ok with plan. Prefer better than "it doesn't kill kittens" but might take it :-P I think we have a precedent for preferring packages here. <gary_poster> right <gary_poster> ah and bin/test-charm depends on selenium now <gary_poster> ...mm, trying to follow that through... <benji> I really think all this would be better done with buildout; we are fast approaching a time where we will be doing a lot of work that buildout makes easy (making test runners, building scripts, managing package installation) <gary_poster> Maybe. Not very sure of that yet, but you've thought of it more than I. benji, I would like to get a handle on what needs to be done next. Do you want to do that verbally, with me as scribe, and then I can let you get back to what you were doing; or do you want to write it up? <benji> gary_poster: I suspect the results will be more comprehensive if we talk it out. <gary_poster> cool benji <benji> gary_poster: I have stormed the gates of juju-ui <hazmat> benji, i think the door was open ;-) <benji> heh #juju-gui 2013-02-05 <benji> gary_poster: did you see the message from StevenK (indirectly) about bug 1112799? <gary_poster> thanks for helping StevenK benji <_mup_> Bug #1112799: Uploading a release to stable is broken <juju-gui:Incomplete> < https://launchpad.net/bugs/1112799 > <gary_poster> :-) <gary_poster> yes <benji> heh <benji> the change that caused the problem is here: http://paste.ubuntu.com/1612461/ <gary_poster> I wonder why my upload yesterday to the trunk series worked <benji> I /think/ the problem they were trying to solve is that some browsers send UTF-8 encoded text without specifying so in the request headers. <gary_poster> oof yeah. that's not a good change for us <gary_poster> right <gary_poster> and who cares about binary blobs :-) <benji> they reverted the change, thats why it started working again <gary_poster> gotcha <benji> heh <benji> the log says "moo", no wait, the log says that they were trying to fix https://bugs.launchpad.net/launchpad/+bug/897053 <_mup_> Bug #897053: apport generated urls can trigger UnicodeDecodeError <oops> <qa-ok> <Launchpad itself:Fix Released by stevenk> < https://launchpad.net/bugs/897053 > <gary_poster> ah ok <gary_poster> Martin Pool's presentation is really good. read 2/3 of it earlier this morning <gary_poster> https://docs.google.com/presentation/d/1awg1CHM1w128iOBp_JOxE2DgHfywBeyjDe2bkx1vfVQ/edit#slide=id.p <gary_poster> Some of it touches on topics we've discussed lately (tested fakes) <benji> it seems to me that the right place to introduce this sort of guessing (if we really must) would be the text widget * benji gets some coffee. <gary_poster> yeah <therve> gary_poster, as it turns out, wsgi doesn't support %2F. But we can encode things on our end I think <gary_poster> therve, wow! I'll try to file that away. Thanks for investigating further. Glad you encode further. Double encoding? :-P %252F (saw somebody do that when I did my quick search) <therve> gary_poster, yeah something like that. <gary_poster> k cool <therve> I'm not sure there is anything to file. I've seen people complaining, but there is just not an obvious solution apparently <teknico_> frickin' telecom "technicians", instead of fixing my line they broke the neighbor's one, leaving me stranded :-P <gary_poster> bcsaller, Makyo, hi. how is landing your reviewed branches going? Over WIP limit: important to get those through the queue. <bcsaller> gary_poster: mine was merged yesterday <gary_poster> ah cool bcsaller thanks. <Makyo> gary_poster, no answer from others on whether or not my branch is needed anymore. If not, should I just trash the card? <gary_poster> Makyo, it isn't a nice improvement anyway? * gary_poster goes to look at it <Makyo> gary_poster, No, not really, unless we change history and call it 'name magic numbers', in which case, it's a four line change. <gary_poster> Makyo, ack. updateLinkEndpoints docstring in relation.js is fixed in your branch too. I will disconnect the bug from your card, and then you can quickly land just the trivial but still valuable bits and move on? <Makyo> gary_poster, sure, sounds good. Will make a new branch. <gary_poster> thank you <gary_poster> card changed to reflect new focus, bug marked as fixed, Makyo <Makyo> gary_poster, thanks <gary_poster> bac bcsaller benji frankban goodspud hazmat Makyo teknico call in 2 *in new Canonical-account-only jujugui room* <goodspud> gary_poster, could you email me the link please <Makyo> bcsaller, Can I get a quick +/- on https://codereview.appspot.com/7311046 since you have to deal with this code most? <bcsaller> gary_poster: having trouble joining, logged into g+ with canonical account but its still rejecting me on the link <gary_poster> benji bcsaller hazmat starting. bcsaller try starting from calendar daily standup link? * benji wonders how to get the new hangout to use the right account <hazmat> bcsaller, i opened incogonito and logged back in <hazmat> the multi account auth doesn't seem to like these hangouts <hazmat> benji, http://tinyurl.com/jujugui <benji> "You are not allowed to join this hangout." <gary_poster> My evil plan is now complete :-P <gary_poster> Try link from calendar benji <gary_poster> or incognito like Kapil said <benji> link from calendar doesn't work <gary_poster> benji incognito worked for you? <benji> gary_poster: yep; I guess I'll have to do that and log in every time <benji> not a big deal, just slightly annoying <gary_poster> I find that if Canonical is your first logged-in Google identity it works for me * bac must resist the urge to eat lunch immediately after the call since it is an hour early <benji> and if Canonical is my first logged-in Google identity then the rest of the Google world breaks for me :) <gary_poster> benji, ack. If this doesn't let us break the 10-participant barrier (we will be 10 people by default once Jeff joins, so that would mean other people like Ale, Jovan, Antonio and so on would have trouble joining) I'm happy to switch back <benji> yeah, if it has no advantages we should go back, but breaking the 10-participant barrier is a biggie <frankban> could anyone make the second review for https://codereview.appspot.com/7306045? thanks! <gary_poster> guihelp ^^^ * gary_poster goes to agile meeting lunch. back in 1.5 hours <teknico> frankban, I'll do it <frankban> teknico: thanks <teknico> frankban, review done, nice running tests remotely :-) <Makyo> benji, ping re: #1091273 <_mup_> Bug #1091273: Style can be applied with different orderings resulting in slight visual differences <juju-gui:Triaged> < https://launchpad.net/bugs/1091273 > <benji> Makyo: pong <gary_poster> benji qa lab machines cannot access outside world other than local deb repos and LP, so we will need to change the test script build machines in the way that we discussed <gary_poster> I will write up <benji> gary_poster: interesting; sounds good <Makyo> benji, it looks like we switched to a 'build-shared' target for prod, debug, and devel at some point, and there's now no difference between build-prod/index.html and app/index.html or the files they include. Suspecting it's no longer an issue, but want to make sure. <benji> Makyo: ah; yeah it may be a non-issue now. An easy way to verify would be to take a screenshot of each and compare (flip-book style). <Makyo> benji, Alright, will do. <Makyo> benji, verified no difference. gary_poster, what to do with the card? <benji> cool <gary_poster> Makyo, move to done Done, close card as fix released <gary_poster> I mean close bug <Makyo> gary_poster, cool, thanks :) <gary_poster> :-) * benji fights with the linter. * benji is kicked by the linter and falls out a window. * benji falls on his horse which gallops away. * benji lives to fight another day. <benji> review of source maps branch at https://codereview.appspot.com/7305047 <Makyo> benji, taking a look, but also have a question. * benji waits in rapt anticipation. <Makyo> HAd to grab the bug ID, sorry. Would this maybe help with #1116320? It seems like the problem is using the un-minified version of YUI, which loads the event stuff from the yahooapis site. <_mup_> Bug #1116320: External resources still loaded by test-debug <juju-gui:Triaged> < https://launchpad.net/bugs/1116320 > <Makyo> benji, ^^^ <benji> hmm, looking <benji> Makyo: nope, I don't think it will help that. The using of un-minified versions is only done in the context of minifying it ourselves in the prod flavor. The debug flavor is the same as it ever was. <Makyo> benji, Alright, thanks. Figured I'd check :) <benji> :) <benji> gary_poster: that presentation from Martin was good. The bit about Mocks living beside the thing they mock got me thinking and lead to this paper: http://jmock.org/oopsla2004.pdf -- which I have not entirely digested but seems important <gary_poster> benji, the abstract was too abstract. :-P I will look at it later. thanks for link <benji> heh <benji> Makyo: thanks for the review, you should tag the card <Makyo> benji, Good catch, thank you. <benji> if anyone else would enjoy a review, it is there for the taking #juju-gui 2013-02-06 <frankban> hi benji: could you please review https://codereview.appspot.com/7299057 ? quick one <benji> frankban: sure <frankban> benji: thanks * frankban lunches <benji> frankban: looks good <gary_poster> benji, once you get 1110823 landed please get me the jenkins username I emailed everyone about yesterday <gary_poster> bcsaller same for you <gary_poster> and hi btw :-D <benji> gary_poster: sure <gary_poster> thanks <benji> yow, I decrypeded the GPG message and I got a MIME document with a base64 encoded tgz; this is like some sort of geek obsticle course :) <gary_poster> heh <gary_poster> thunderbird handled that part transparently fwiw <gary_poster> thunderbird + enigmail that is <benji> "VERIFY ERROR: depth=1, error=self signed certificate in certificate chain" <bac> funny mine wasn't double tarred like gary's <gary_poster> good <gary_poster> So far I've waited 15 minutes for juju status to return after a canonistack bootstrap :-/ <benji> gary_poster: user name: "benji" <gary_poster> thank you benji <benji> heh, I like the weather metaphore <benji> np <gary_poster> hey hazmat, I'm trying to get canonistack working with juju, both for general good practice and to be able to dupe what the CI is going to do. I followed the wiki instructions for juju+canonistack AFAIK, and I can bootstrap, but juju status still doesn't return , 25+ minutes ago. output from juju --verbose status isas follows: http://pastebin.ubuntu.com/1616631/ . Does that suggest any problem/remediation to you? <gary_poster> that ssh to 6585208393 seems to not be working out so well... <hazmat> gary_poster, can you log into the machine with ssh <hazmat> gary_poster, which region and which provider? <hazmat> one of the regions requires 'openstack' and one 'openstack_s3' <hazmat> gary_poster, i think 02 is swift, and 01 is s3 <gary_poster> hazmat, openstack provider, per https://wiki.canonical.com/InformationInfrastructure/IS/CanonicalOpenstack/QuickStart . Using default region, which I think is 01 <hazmat> hmmm.. maybe that's a red herring <gary_poster> ssh timed out <gary_poster> ah-ha, matsubara improved my .ssh/config. looks like it might work now... <gary_poster> yes, all's good. Will include follow-up in email <hazmat> gary_poster, cool <hazmat> i just updated the quick start doc to remove some extraneous config bits <gary_poster> hazmat, should I add the snippet I gave in the email for step 4 to that quick start? Maybe recent ssh instructions elsewhere include that, but iwbni the quick start were self-sufficient, I think <gary_poster> Specifically, I also needed this: <gary_poster> Host 10.55.58.* 10.55.60.* 10.55.62.* 10.55.63.* *.canonistack *.canonistack2 <gary_poster> ProxyCommand ssh chinstrap.canonical.com nc -q0 %h %p <gary_poster> I only had that for 10.55.60.* before <hazmat> gary_poster, sounds good to me <gary_poster> k will do hazmat <bcsaller> gary_poster: do you have some time for a call soon? <gary_poster> sure bcsaller. 9:55 or 10:00 ok? <bcsaller> gary_poster: yeah, ping me when ready <gary_poster> will do <gary_poster> bcsaller, jujugui is open <gary_poster> bac benji frankban goodspud hazmat Makyo teknico call in 1 <gary_poster> hatch hi :-)\ <hatch> Ahoy! <benji> guihelp: has anyone seen this error when running "make test-prod"? Error: extend failed, verify dependencies (http://localhost:8084/juju-ui/assets/all-yui.js:1 <benji> the tests pass when run in the browser <Makyo> teknico, Anything I can do to help? <teknico> Makyo, yes, thanks, call? <Makyo> teknico, Sure. The old juju-ui hangout is free. <Makyo> https://plus.google.com/hangouts/_/409819056ea1551523432ac63f4df4a6feaa5922?hl=en-US <benji> darn, my test failures are due to some change made during review; traking it down now <dweaver> Question: How do you use juju-gui with local charms repository. I can see in assets/config.js: charm_store_url: 'https://jujucharms.com/', Can this be set to a local file location like the juju option --repository or is there another way to support local charm repos? <dweaver> Any help will be appreciated :) <Makyo> guihelp, ^^^ <Makyo> dweaver, I don't believe there's current support for a local repository, but I've not tried the method you've suggested. <hazmat> dweaver, at the moment its not supported <hazmat> dweaver, the gui will work with local charms once their deployed <bcsaller> (via the cli) <hazmat> but we don't have a local program that you can run that will give the endpoint interface that the gui needs at the moment <hazmat> its an interesting discussion point.. at the moment if the gui is deployed over ssl most browsers will ignore sub resources.. <hazmat> that aren't ssl.. the exception seems to be websockets.. <hazmat> but its unclear if thats just a transient quirk.. if its not we can do local charms over websocket.. else.. i'm not sure what options there are <hazmat> since/because the local program can't present a valid cert for itself running on localhost.. <dweaver> OK, thanks, that answers my query, it is a query coming from HP, so it is likely to be a future requirement, so probably worth thinking about how we're going to achieve it. <dweaver> eventually, anyway :) <dweaver> hazmat++ <dweaver> thanks <hazmat> np... so nutshell local charm search no.. manipulation/introspection of services deployed with local charms are fully supported <gary_poster> hazmat, for one story, charm might be hook point for something we could do. You tell the charm about your local server, and it proxies it for you. We could have it served from /local/* . Similar proxying could be done in other stories. <hazmat> gary_poster, local host differs between the proxy and the client.. <hazmat> and nat/firewall prevent remote_ip usage <gary_poster> hazmat, yes, for this to work, charm would have to be able reach your machine <gary_poster> so limited value, but perhaps some <hazmat> too many cases where it won't work to be a solution. <gary_poster> fair enough <hazmat> i think just pushing forward with the websocket gives us a possible universal answer. <hazmat> but it would be good to verify/research why this browser behavior exists. <hazmat> ie oversight or reasoned <hazmat> sounds like recent firefox may not allow it.. from some quick googling.. <hazmat> gary_poster, alternatively we have the user separately accept the websocket cert from localhost <hazmat> in their browser as a crappy but nesc requirement <gary_poster> yeah <hazmat> and documented <hazmat> and then we can avoid the websocket and just make it a parallel impl <hazmat> of the existing search rest backend <gary_poster> hazmat, ack, may be best we can do. Although, for big companies as mentioned above, it may not even be a big deal to put it behind a real cert. <gary_poster> sounds a bit like other plans too though <hazmat> bcsaller, would you be up for sanity checking a mind twisted txzk branch ? <hazmat> dweaver, gary_poster, for them (big) i have other plans. <bcsaller> hazmat: sure <gary_poster> hazmat, understood <dweaver> hazmat, sounds exciting! <hazmat> hatch, welcome on board! <hatch> thanks :) <hatch> Hi everyone <hatch> My name is Jeff and I hate long walks on the beach <hatch> :D <hazmat> :-) <gary_poster> jujugui, ^^^ :-) <Makyo> hatch, o/ <bac> hi hatch <bcsaller> hazmat: send me a link to what you want reviewed when you're ready <benji> hi hatch <hatch> Hey, looking forward to getting started <hazmat> bcsaller, its got some debug junk in it.. which i'm cleaning up.. but ignoring those the rest is ready https://codereview.appspot.com/7307051/ <hazmat> hmm.. that diff is wierd.. <hazmat> bcsaller, not sure why reitveld is getting the diff wrong <bcsaller> hazmat: too much? <hazmat> bcsaller, yeah.. way too much <bcsaller> hazmat: good, it was looking like quite the branch <hazmat> odd. even lp gets it wrong.. <hazmat> trunk shows the managed.py but both are treating it as a new file <hazmat> in the diffs (reitveld and lp) <bcsaller> hazmat: if you don't get it working in the next few minutes I can try to generate it locally at the cost of some of the inline review comments <hazmat> bcsaller, i'm just going to go back and work on yanking the debug bits for now.. maybe just hold till tomorrow till i can get this clean <bcsaller> hazmat: thanks <hazmat> i was hoping to get it in for some of the drill work that people are doing.. but they seem to have other concerns atm <benji> gary_poster: do we want to put some kind of user or branch details in the sauce labs jobs? Like say user name and branch nick? <gary_poster> benji sounds nice <benji> k, it'll be easy to do <bac> gary_poster: the approach i thought looked promising didn't actually work. i'm talking with curtis now to see if he has any brilliant thoughts <gary_poster> good idea bac <benji> darn, grabbing the branch nick doesn't make any sense because the tests don't know that they are actually running against that branch <benji> gary_poster (and all other reviewers): https://codereview.appspot.com/7300054 <gary_poster> on call <gary_poster> benji land with changes <benji> thanks <benji> "converting browser tests into runes" -- lol <gary_poster> :-) <gary_poster> bcsaller, am I right that there's no juju facility to somehow automatically associate elastic IPs, a la https://wiki.canonical.com/InformationInfrastructure/IS/CanonicalOpenstack#Obtaining_a_Public_IP_Address? If not will simply suggest we script with the euca-* commands <gary_poster> (this is for automating CI using Juju, Jenkins, and Canonistack) <hazmat> gary_poster, can i grab you for some gui charm debugging? <bcsaller> gary_poster: I don't think the providers do anything special for elastic IPs. You get the public one provided but things like Amazon's elastic ips are provider specific and I don't think we had a general facility for that. I think associating an elastic IP changes the public address though <gary_poster> hazmat, sure. <gary_poster> bcsaller, cool, thank you <hazmat> gary_poster, for openstack there is a facility for using an elastic ip <hazmat> use-floating-ips <hazmat> but it enables it everywhere <hazmat> and there are not that many <hazmat> on an account <gary_poster> hazmat enabled even for the bootstrap? <Makyo> I remember running into this when I was setting up canonistack. Was keeping the websocket address from being set properly, correct? <hazmat> gary_poster, yes <gary_poster> hazmat, ok thanks. I'm in jujugui if you want to meet there, or can move to juju-ui <hazmat> gary_poster, i'm trying to setup something remote with the drill team.. i'll ping again when its happening <gary_poster> Makyo, ah, I bet you are right, but I was simply trying to make it so that sauce labs can even see the charm at all <gary_poster> in an automated way <Makyo> gary_poster, ah, yeah, definitely. I found that even with a public IP, though, the 'public address' as reported to juju was still the canonistack address. <gary_poster> hazmat ok <gary_poster> Makyo, :-( . Did you use use-floating-ips or the euca approach? <Makyo> gary_poster, euca. <gary_poster> ok <Makyo> gary_poster, so maybe floating IPs might help there. <gary_poster> Maybe the other approach will work better. Will try both. Yeah, thanks for warning <hazmat> we could slim down charm deb installs considerably <hazmat> by considering what the active config options are <hazmat> ie. if stable don't most of the pkgs, if not staging don't need zk, etc <hazmat> we should also move the download off launchpad and onto a cdn <hazmat> its quite slow to download from lp #juju-gui 2013-02-07 <hazmat> bcsaller, final branch is up for review, still haven't been able to get the review diff right.. it looks fine by hand <hazmat> bcsaller, revno 52 has the complete diff, all the other revs are on trunk.. <bcsaller> hazmat: did a review on lp for you <hazmat> bcsaller, thanks for the review.. commented back. surprised your coverage report didn't pickup the test, was it only being run against a particular test module instead of the full suite? <bcsaller> hazmat: it was 'make coverage' <hazmat> odd <hazmat> there's a test that explicitly checks for the backoff content in the logs in test_session <hazmat> ie. test_managed_client_backoff <bcsaller> your version of coverage shows it being trigged in manage then? for me managed only shows 83% but most of that is missing calls to error logging <hazmat> coverage locally reports its covered <hazmat> for the package i have 94% for the managed module 89% (mostly exception handling) <bcsaller> hmm, maybe I have an old coverage package <hazmat> well for the test to pass it has to hit those lines, which is what's od <hazmat> odd <bcsaller> hazmat: I'll look into it, I'm guess its something with my environment <gary_poster> teknico, feeling any better about the bug today? If not, why don't you ask to pair with Ben or Matt this morning? <teknico> gary_poster, having lunch now, but maybe a quick call? <gary_poster> sure teknico. I'm free for 53 minutes, then we have our regular call in another hour. Can do it whenever you like within my available time <teknico> gary_poster, I'm in jujugui <benji> gary_poster: when you get a second I would like to discuss the UX of the browser compatability warning <gary_poster> ack benji <bac> guihelp - anyone free to review my css branch? <hatch> good morning <benji> morning, hatch <gary_poster> morning <gary_poster> bac, on it <bac> gary_poster: cool. won't take long <gary_poster> cool <bac> thanks gary_poster <gary_poster> welcome <bac> gary_poster: here is a bit of a rambling explanation: http://dalelane.co.uk/blog/?p=2222 <bac> the reason i suggest we add this is it keeps IE from behaving differently when it sees the server is on the same LAN. seems like a recipe for disaster to have it work one way in development and then another when deployed. <gary_poster> bac +1. Just add a link to the blog post maybe? Not sure <gary_poster> thank you <bac> +1 * bac looks for something more authoritative <Makyo> bcsaller_, benji frankban gary_poster call now? <gary_poster> baf <gary_poster> sorry <gary_poster> thanks <gary_poster> benji frankban hazmat like Makyo said :-) <gary_poster> goodspud too :-) <frankban> guihelp: is the "failfast" behavior of the GUI test suite a bug or something we precisely decided? <gary_poster> frankban, bug I think <frankban> gary_poster: ok thanks <bcsaller_> frankban: I think there is a 'bail' flag in mocha that is being set <bcsaller_> bcsaller_: I suspect we can pass bail: false to the mocha init <bcsaller_> talking to myself now, great <teknico> bcsaller_, that's ok, as long as you listen to yourself <bcsaller_> all about good manners <frankban> :-) bcsaller_ : it works <frankban> gary_poster, bcsaller_: do we want failfast? otherwise I'll add "bail: false" in my branch. <gary_poster> :-) I vote for not failfast, but don't feel strongly about it frankban <bcsaller_> frankban: I don't mind fail fast on the cli tests as we are mostly doing a sanity check at that point, I do the actual debugging in the browser <bcsaller_> but I don't feel strongly either, usually with the cli tests though a single failure would prevent a lbox submit <gary_poster> mm, lbox is a good point <hazmat> guihelp re cs:precise/juju-gui anyone know why it would result in 2013-02-07 11:10:16,812: hook.output@INFO: E: Unable to locate package python-charmhelpers <gary_poster> hazmat, that used to happen if person was not using juju from ppa. supposed to be fixed now, because we add ppa at start anyway <hatch> is `guihelp` a string that I should set to ding in my chat? <hazmat> yup <hazmat> its a group broadcast <gary_poster> hatch, yes, guihelp (among ourselves) and jujugui (on #juju channel for user help) <hatch> that's a very smart idea :D <hazmat> gary_poster, is that fixed in the ~charmers version only the ~juju-gui version? <hazmat> s/only/or only <gary_poster> hazmat, ~charmers, pretty sure. verifying. <teknico> hatch, hi, you might also want to configure your IRC client so that it shows your first name and last name too <gary_poster> hazmat, ~charmers. bootstrap_utils.install_extra_repositories('ppa:juju/pkgs') in install hook <hatch> teknico: in my whois information? <teknico> hatch, yep <hatch> oh cmon I need some kind of anonymity ;) <gary_poster> frankban, you happen to have any experience with what hazmat mentioned above in charm? I don't see why/how it would happen <teknico> hatch, do you? :-) <frankban> gary_poster: hum... no, looking at the ~charmers revision <gary_poster> frankban, http://bazaar.launchpad.net/~charmers/charms/precise/juju-gui/trunk/view/head:/hooks/install fwiw <gary_poster> hazmat, are they running on precise? <gary_poster> hazmat, or more pertinently, are they trying to run on raring. We only test on precise. the juju ppa does not have charm-tools for raring <gary_poster> python-charmhelpers are in the charm-tools version supplied by both precise and quantal <hazmat> gary_poster, its all precise <hazmat> gary_poster, the problem is actually ppa add because its a proxy environment <hazmat> the add apt repo ends up adding junk the apt repo <gary_poster> ah :-( <frankban> :-/ <hazmat> after that it fails because adding nodejs and we don't have a key for it.. <hazmat> nodejs ppa <hazmat> imo the charm shouldn't be downloading things it doesn't need for it current configuration <hazmat> ie. i'm using a release i don't need nodejs/imagemagick/etc.. i'm not using staging mode.. i don't need java/zookeeper <gary_poster> hazmat, added bug for that yesterday on your comment then. triaged as low given that it was nice to have, but put it on kanban as slack task. if this is blocker for important things then we can reprioritize. <hazmat> its a blocker for important things.. but the timeline is tight.. <hazmat> i might just hack do a hack for it <hazmat> sadly lacking access to fix directly <gary_poster> hazmat, right. is this a drop everything? The change would be risky IMO <gary_poster> you could hack and put it in your own branch? <hazmat> gary_poster, yeah.. or just pass them to the hook <gary_poster> risky only in the sense that it would need to be tested. we would have to move downloading prerequisites into config-changed <hazmat> gary_poster, understood, i'm testing a hack fix now (just commenting out all the unesc pkgs) <gary_poster> cool, sounds good <frankban> Makyo: quick hangout? <Makyo> frankban, sure. <frankban> Makyo: http://tinyurl.com/see-emily-code <Makyo> frankban, There. <hazmat> odd the gui deploys and gets to started (no hook errors) without the extra packages but it doesn't actual run.. the nginx config gets odd * benji tweaks the unsupported browser wording. It now reads "Your browser is bad and you should feel bad." <frankban> hazmat: what oddities are you seeing? <teknico> benji, is "now" before or after the tweaks? :-) <benji> heh <benji> we should replace all of our UI elements with memes <hazmat> frankban, nginx is running but not serving traffic.. all the pieces look like there in place but i can hit the front end webserver (its exposed) <hazmat> ie. api server running, files on disk <frankban> hazmat: any error in /var/log/upstart/juju*? <hazmat> frankban, no.. afaics the only issue is the nginx config <hazmat> the hooks all run to completion without error <hazmat> nginx config : http://paste.ubuntu.com/1621578/ charm log: http://paste.ubuntu.com/1621582/ <frankban> hazmat: is "gui" the name of the charm you deployed? <hazmat> frankban, its the name of the service charm <hazmat> hmm.. i deployed ~juju-gui's charm version <hazmat> with this diff http://paste.ubuntu.com/1621609/ <hazmat> i meant to deploy the ~charmers version.. i'll retry with that to verify <frankban> hazmat: aha! ppa:juju-gui/ppa is required so that the ssl-enabled haproxy is installed, not the precise one <hazmat> frankban, gotcha.. that's not in the ~charmers version yet right? <frankban> hazmat: right <hazmat> jovan2, the new gui vision looks much improved <jovan2> hazmat glad you like it <Makyo> >:/ <gary_poster> Makyo, ? <Makyo> gary_poster, Firefox and Flash problems. <gary_poster> gotcha <gary_poster> bac you available to review Matt's branch? When that lands I can move some more of the CI Jenkins stuff forward <bac> gary_poster: i can. trying to get that hatch patch to work <hatch> bac - I've never actually tested that code so I would be interested to hear your results :) <bac> hatch: not good so far <bac> i expect the ie10 class to be added to <html> but it isn't <hatch> hmm is the js executing? <bac> not sure. <bac> not too adept at using the ie tools <hatch> inside the script tags console.log('it works!'); <gary_poster> thank you bac <hatch> I need to close some chrome tabs (I'm out of ram haha) and then I can boot up a Win8 VM if you like <bac> hatch: cool. i'm doing a review now but will be back at it in a bit <bac> Makyo: done <Makyo> bac, thanks <bac> hatch: got it to work. <hatch> oh excellent - what was the issue? <bac> hatch: there was a typo in the code i copied from you. missing a closing > before script. no biggie. <hatch> oh woops I should fix that in the gist <hatch> thanks <hatch> bac: I may be doing this review this wrong but I think you forgot the console.log() in the html ;) <bac> ergh, probably <bac> thanks for the catch <hatch> np and I updated the gist with the missing > :) <bac> having trouble submitting my changes due to lbox.check <bac> and then it worked #juju-gui 2013-02-08 <gary_poster> frankban, land as is. Really nice. <frankban> gary_poster: cool thanks! <gary_poster> :-) <gary_poster> hazmat, zero rush, but you might be interested in double-checking and commenting on bug 1119412 at some point. <_mup_> Bug #1119412: charm has difficulties when run behind
{'channel': 'juju-gui', 'month': 2}