#launchpad-yellow 2011-05-02 <bac> good morning yellow team, er, benji <benji> heh <benji> I don't see much need for a call; I'm OCR today and will be trying to work on my curren card and the bugs Gary pointed out in his email yesterday. <bac> ok <bac> benji: actually do you mind chatting just so we can figure out exactly what's going on today? <benji> sure, skype? <bac> yes <bac> my skype is slow to launch, though. i'll call you when it pops open <benji> k <bac> francis <benji> heh <bac> let's not skype then <benji> I don't know about Francis. <bac> i was just asking if francis was around, since gary indicated decision makers were scarce <bac> doesn't really matter <bac> ok, thanks for the info. i'll try to get the deploy done <benji> Johnathan won't be back until tomorrow <benji> sounds good <bac> benji: have you requested a nodowntime deploy before? <bac> do the losas just pick it up from the wiki or do you have to hunt them down? <benji> nope, I had a link to how to do it somewhere, let me see <bac> benji: i've filled it the wiki page <benji> I think you put it on the page and then ping them. <benji> this is all I have: https://wiki.canonical.com/InformationInfrastructure/OSA/LaunchpadProductionStatus <bac> hi benji, can you review gary and grahams' branch for bug 720147 at https://code.launchpad.net/~bac/launchpad/bug-720147/+merge/59677 ? <benji> bac: sure <bac> benji: i'm getting lunch now but will bbiab <benji> k <bac> hi benji, the deploy is finally done <benji> yay! <bac> i'll play with it now and then change the feature flags <benji> if it looks good and you add all of LP to malone alpha, you'll probably want to send the list an email so people know it's happening <benji> may even want to wait until the morning to turn it on in case things crash and burn we'll be around <benji> oh, you won't be here tomorrow, in that case I'd go ahead and turn it on; I'll be able to look at it if things go south <bac> our people picker is awful <bac> benji: how about i change the feature flag tonight <bac> and in the morning add ~launchpad-dev <benji> sounds good <bac> that is if i can get our people picker to let me! #launchpad-yellow 2011-05-03 <bac> hi gmb, please see the comment and attachment i just added to bug 720147. i don't have time to figure out those test failures so i'm bouncing it back to you. <bac> gmb, benji: call? <gmb> Oh, good point. <bac> could someone else initiate the call as i'm on my phone <gmb> Sure <gmb> Hmm. <gmb> bac: All I get from you is rejection. <bac> try again? <bac> i just accepted your contact request <gmb> bac: Yeah, you drop out whenever I dial <bac> i call you <bac> you declined <bac> :( <gmb> bac: Yeah. Too many things happening at once <gmb> bac: Try again. <bac> ok <bac> it thinks we're connected and won't let me dial <bac> hang on * gmb hangs <gmb> benji: Since you reviewed the original, could you take a look at my fix for the test failures? https://code.launchpad.net/~gmb/launchpad/filter-on-bug-creation-bug-720147/+merge/59772 <benji> gmb: sure <gmb> Thanks <bac> gmb do you ever travel with your 70-200? i really like it but my back does not. <gmb> bac: Sometimes. I'm more inclined to do it now that I've got rid of all my messenger bags. <bac> i guess i'll see how full my carry on gets <benji> gmb: approved <gmb> benji: Thanks. <gmb> bac: I think the 70-200 is one of those where I have to be sure I'll need it before I pack it. Otherwise I make do with my primes and a wide-angle zoom. <benji> I wish those diffs would update a little faster, then maybe I wouldn't get distracted waiting for them. <gmb> benji: You and me both. <benji> :) #launchpad-yellow 2011-05-04 <danilos> bac, hi <danilos> bac, lifeless has denied a request to add ~launchpad to ~malone-alpha, and it seems it's possible to have another feature flag for ~launchpad team; I am not strictly sure that's better, but he did complain about "a flag would be better" <danilos> bac, so, I am thinking of requesting the following flags be added: http://pastebin.ubuntu.com/603230/ <danilos> bac, what do you think? <danilos> oh right, bac might be travelling already <danilos> gmb, benji: what do you guys think? :) ^ * gmb looks <gmb> danilos: Yep, that looks good to me. <benji> agreed; I had told him that I would do get the LOSAs to put the rule in place at my morning (now-ish), but you can feel free to as well <danilos> benji, right, I've already started so let me get it done; I'll say we've got gary's approval ha :) * danilos also ponders using r=gary these days a lot :) <gmb> :) <danilos> btw, call in 5? <gmb> Yep. Assuming there's anyhting to actually say besides "Yeah, hi, what's on the Kanban board, hurrah." <gmb> danilos, benji: Call time? <gmb> Or should we just get on with bugs? * gmb -> out for a walk #launchpad-yellow 2011-05-05 * gmb -> out to vote and run errands; back later <benji> gmb and danilos: I'm taking 777766 unless someone else is already working on it. <benji> I'm also taking something for this headache. <danilos> benji, not me, go for it <danilos> benji, with gmb out, I assume there's not much to discuss in the call <benji> not that I can think of <danilos> benji, gmb (when you come back): I would like us to make a firm decision if we should pursue opening the feature to the wider launchpad-beta-testers team tomorrow (early, most likely) <danilos> (I don't want it to be late because if it goes horribly wrong, it'll do so for a bunch of people over the weekend) <benji> ideally it would be early tomorrow or Monday (tomorrow being a Friday) <benji> right <danilos> benji, right :) * danilos -> off #launchpad-yellow 2011-05-06 * gmb -> lunch <danilos> gmb, benji: hi guys, if you can see it, please comment on the announcement for the beta team opening (http://blog.launchpad.net/?p=2324) <danilos> gmb, benji: you might need to log into the blog, and if you still can't see it, I can paste it for you <gmb> Logging in now. <gmb> danilos: By "comment on" do you mean "write a comment on the post?" <danilos> gmb, no, I mean comment if you think anything needs fixing <benji> I appear to have logged in, but can't see the post. Any hints? <gmb> danilos: Ah. In that case, I think it reads fine. <danilos> benji, it's unpublished, so you are probably not an admin yet; for that you'd have to talk to mrevell most likely, but for now, you can look at the text at ... <danilos> https://pastebin.canonical.com/47209/ <benji> thanks <danilos> (some formatting is lost in the process, but I am sure you can interpolate it back in with little effort :) <benji> looks good; I suggest adding a bit about filtering, i.e., you can subscribe to bugs with particular tags, bugs that are only "Critical", etc. <danilos> benji, I'll pass that on to mrevell, we are still waiting for losas to change the feature flags to launchpad-beta-testers <benji> k <danilos> benji, gmb: ok, launchpad-beta-testers is exposed to the feature stuff, mrevell will announce it <benji> cool <gmb> Cool <danilos> the coincidental change of the launchpad product configuration (which breaks mail filtering for many launchpadders) is very badly timed with our beta opening :/ * danilos -> off, might drop in later to check in on things <danilos> if anyone notices something going horribly wrong, we know what to do (blame it on someone else :)) <danilos> cheers <benji> if, like me, anyone is getting irritated wading throught all the tagged bugs looking for something to work on, here's a query that shows Critical, or High bugs that aren't being worked on: http://bit.ly/m7FZ79 #launchpad-yellow 2011-05-09 * gmb -> lunch <gary_poster> benji danilos gmb, hi! skype in 2? <danilos> gary_poster, hi there, ack <gmb> Yep <gary_poster> cool <gary_poster> benji, you online? <benji> gary_poster: yep <gary_poster> benji, approved <gary_poster> bye y'all <benji> thanks and bye <bac> hi gmb, benji <gmb> Hi bac <benji> hey! how's it going? <bac> gmb: i'm giving my talk tomorrow. is there anything substantial that has changed in the last week wrt subscription work? <gmb> bac: Not AFAIK. <bac> benji: pretty good. lots of nerds here! <gmb> It's been all fixin. <bac> gmb: cool <bac> gmb: so does 'unsubscribe in anger' actually work? i've never used it before <gmb> bac: Er. Neither have I :). I believe there are some little weirdnesses (like you get told that you "don't have permission" to change team subscriptions when you're not a team admin). <gmb> Other than that, though it works, AIUI. I think danilos might know better than I since ISTR he did the lion's share of the work on it. <gmb> I just mocked it up. <bac> gmb: hmm, ok. but it is on production? guess i should make a structural subscription and see what the email looks like <bac> gmb: ok, i'll ask him tomorrow <gmb> bac: It is: c.f. http://bugs.launchpad.net/launchpad/+subscriptions <gmb> Ah <gmb> ISWYM. <gmb> The email bit I don't know about. <gmb> Gmail hides a lot of things from me. Let me see... <bac> gmb so the UIA part is really just +subscriptions? <bac> i thought there was a different page <gmb> bac: I'm getting confused with https://bugs.launchpad.net/launchpad/+bug/779538/+subscriptions <_mup_> Bug #779538: Link from superseded blueprint to its successor disappears when you click it <Launchpad itself:New> < https://launchpad.net/bugs/779538 > <gmb> (For example) <gmb> Which is a different page altogether and *does* fit the UIA story. <gmb> But I see no link thereto in any of today's bugmail. <gmb> So it seems like it's only partially live, which is odd. * bac looks <bac> hmm <danilos> bac, the link is not added to the email <danilos> bac, I am pretty sure gary wanted to add it only when it's available to everybody <gmb> Ah, of course. <danilos> bac, (iow, when we are out of the beta) <gmb> Because trying to feature-flag that would be a nightmare, I suspect. <bac> ok, thanks danilos <danilos> bac, gmb: "Edit bug mail" is a link to get to that page basically <bac> right <gmb> yep <danilos> np <bac> gmb: did you get email from me about the UDS session? i sent it to yellow but don't see it in the archvies * gmb checks <bac> it may have been from the wrong email address and got silently dropped... <gmb> bac: I got it. <gmb> Tomorrow at 14:15 UTC, right? <bac> gmb: yes <gmb> bac: I'll try to participate, providing my OCR duties don't conflict. <bac> gmb: there is audio but only one way. otherwise you can join #ubuntu-uds-petofi (the physical room name) <gmb> Ok #launchpad-yellow 2011-05-10 <bac> good morning danilos <danilos> bac, oh, good morning <danilos> bac, how's UDS going so far? <bac> not used to people chatting here at this hour? :) <bac> uds is good. in a firefox translations session atm <bac> you can join at #ubuntu-uds-dery if you're interested <bac> danilos: ^^ <danilos> bac, heh, right :) <danilos> bac, thanks, I'll join in, not sure I can participate heavily with all the other stuff I've got to do today <bac> danilos: np. just thought i'd mention it. certainly not required <danilos> bac, I can't hear anything, is something supposed to be happening atm? <bac> you should be able to hear <bac> others have said the audio was working <danilos> right, it might be my side then <bac> any audio now danilos ? <danilos> bac, nope <bac> i summoned elmo but he hasn't shown up yet <bac> now? <danilos> bac, I haven't used totem/vlc for playing these streams yet, so I can't be sure if it's not on my side (since I don't know if it ever worked) <danilos> bac, thus, I am not complaining loudly <bac> it isn't you <bac> sorry for the bad session, danilos. did the audio ever work? i had to leave early. <danilos> bac, yeah, 2 minutes before the end of it :) <danilos> gmb, hi, I see your fix for 772609 has landed, but even if I merge devel, I don't see the "mute link" show up when there is a direct team subscription on a bug <danilos> gmb, was that supposed to be fixed as well? <gmb> danilos: Hrm. Yes. Thanks for the heads-up. <danilos> gmb, np, I was hoping to wrap up bug 771204 fix, and noticed that mute link should show up even for team subscriptions; I'll take care of the JS side at least :) <_mup_> Bug #771204: mute link does not appear when a new direct subscription is made on a bug <story-better-bug-notification> <Launchpad itself:In Progress by danilo> < https://launchpad.net/bugs/771204 > <gmb> danilos: Ah, it got rolled back because it had the side effect of exposingd stuff for private bugs. <gmb> (Which caused OOPSes. William has filed a bug about it.) <danilos> gmb, oh... can we do something about it? <gmb> danilos: I think so. I need to check what the expected behaviour on private bugs actually is (William's bug suggests that getIndirectSubscribers() should always be empty in that case). Slightly odd that we don't have a test for that, but not wholly unsurprising :/ <gmb> I'll have a proper dig around in a minute, just grabbing a drink first. <danilos> gmb, sure thing <danilos> gmb, also, I am a bit confused about the use of feature_flag_2 (advanced-STRUCTURAL-subscriptions flag) in test "test_mute_subscription_link_not_shown_for_non_subscribers" (regardless of your branch, because I am changing the link to always be in the DOM [but hidden] so JS can easily show it when needed) <gmb> Ok <gmb> danilos: Just pulling up that code now... <danilos> gmb, ack <gmb> danilos: Uhm. I'm not sure why that's there, actually. It's a change that bac made but I can't remember why it was done. It doesn't seem to serve any purposes, as far as I can tell. <gmb> danilos: I suspect that if you pull that with FeatureFixture line out the test will still pass. <danilos> gmb, yeah, it seems to be a bit silly test: asserts that link doesn't show up when feature_flag_1 is not on, which is a nice negative test, but a bit misnamed then <danilos> gmb, right <gmb> danilos: Yeah, it should set the flag to 'on', not None. <danilos> gmb, I'll clean up that test <gmb> Otherwise it's always going to pass. <danilos> gmb, it's the wrong flag as well, that's what made me wonder the most <gmb> Ah, yes, it is. <gmb> That tool. <gmb> Too* <gmb> (Not trying to say bac is a tool in any way, shape or form) <danilos> hahaha <danilos> ok then, I'll clean that test up to be only for "nothing shows up when the (right) flag is off" <danilos> and add a new one which tests all it needs to (along with the 'hidden' class which I am adding) <gmb> Right, cool. <gmb> Thanks :) <danilos> no, thank you for helping out :) <danilos> benji, gmb: shall we have a call? <benji> I'm fine either way. <gmb> I've nothing much to add to yesterday's to be honest. <gmb> OCR + rolled back branch is keeping me busy. <benji> pretty much the same here, finishing up one bug fix, about to do another <gary_poster> hi all <gary_poster> I'm just here for a sec <gary_poster> gmb, mockup ok? you need my input for anything? <gary_poster> danilos, benji, everything ok with you all? <benji> gary_poster: things are peachy <gary_poster> yay :-) <gmb> gary_poster: I've only touched on them briefly this morning (so far so good); my branch from the weekend got rolled back as it caused some issues with private bugs, so I'm fixing that first. <gary_poster> gmb, ah, ok, makes sense <danilos> gary_poster, yeah, just fine, thanks :) <gary_poster> ok cool :-) <danilos> gary_poster, I am a bit late with the email, but it'll go out soon <gary_poster> cool <gary_poster> np <gary_poster> I'll run away then :-) <gary_poster> bye and have a great day! <danilos> cheers, tty tomorrow <bac> just saw the bug subscription notification window for the first time. nice! <bac> the UDS session begins in five minutes. follow along at #ubuntu-uds-krudy if you want. <gmb> benji, danilos: Can one of you review https://code.launchpad.net/~gmb/launchpad/bug-772609-again/+merge/60513 for me? It's my fix for the issue that caused wgrant to roll back last night's change; I've pasted the salient bits of the diff in a comment. <benji> gmb: sure <gmb> benji: Although I've pasted garbage, let me just update that... <benji> :) <gmb> Must've hit pageup before copying <gmb> benji: New comment has sensible diff. <benji> k <benji> gmb: done <gmb> benji: Ta * danilos -> out #launchpad-yellow 2011-05-11 <danilos> gmb, hi, do you think it makes sense to have a bug activity record for muting/unmuting a bug? (I assume that's what bug.addChange did in subscribe/unsubscribe) <gmb> danilos: I'm torn between "I don't know when anyone would make use of that" and "If it's easy, we might as well" to be honest. <gmb> If it'll take you more than half an hour to do I'd be tempted to not bother. <danilos> gmb, I'd have to check what does bug.addChange exactly do, and I kinda feel lazy if it doesn't seem very useful :) <danilos> gmb, there's more important things I'd do first <gmb> danilos: Yeah. I wouldn't be too concerned about adding it unless you need something to fill up the last hour or so of your day. <danilos> gmb, right, I'll see about that later <danilos> now I just need a reviewer because OCR told me he doesn't want to have anything to do with my branches <gmb> Haha. <gmb> danilos: Ignore him, he's well known for being awkward. <gmb> I'll take a look at it for you. <danilos> gmb, I know! <danilos> gmb, cool, https://code.launchpad.net/~danilo/launchpad/proper-bug-muting/+merge/60615 :) <gmb> I'll take a look shortly. <gary_poster> Does Microsoft's acquisition of Skype mean that we should no longer use it? :-) <danilos> gary_poster, it means we should at least switch to windows :) <danilos> I'll probably have to check my hard disk drive for defects and reinstall the system if I want mumble back, though :/ <gary_poster> ack danilos :-/ <gmb> gary_poster: I've pushed basic mockups for the "also notified people" up here: lp:~yellow/launchpad/also-notified-people-mockups. That's based loosely on what we said on the call the other day, but I suspect it's too simplistic a solution. <gary_poster> gmb, awesome, I'll take a look. Are you still working on bug 778847 too? <_mup_> Bug #778847: Muting a bug subscription for a team with a contact address crashes getRecipientFilterData <oops> <regression> <story-better-bug-notification> <Launchpad itself:In Progress by yellow> < https://launchpad.net/bugs/778847 > <gmb> gary_poster: Yes. I'm hanging fire until danilos's BugMute branch lands, though, to avoid collisions. <danilos> gmb, mine is against db-devel, so you should probably land it anyway <gmb> danilos: Ah, fair point. <gary_poster> ok cool, I won't ask that it be marked as blocked then :-) <gmb> In that case I'll get that reviewed and into EC2 today and keep an eye on conflicts when devel gets merged to db-devel. <gary_poster> benji danilos gmb, kanban nowish, mumble in 3 <gary_poster> s/mumble/skype/ :-P <danilos> thank you :) <gary_poster> np, just oversight <danilos> I had to click through the EULA before it'd load :) <gary_poster> hh <gary_poster> heh <gary_poster> not ready for call yet; will hopefully be ready in 10 <danilos> sure thing <gary_poster> danilos, uh :-) . So, everything is handled with house visitor (== refrigerator repairman :-P ) but I have to take kids to school in 9 minutes. I imagine we want to have a relaxed call, not a "gary will leave any second" call? :-) If so, maybe roughly 30 minutes from now? <gary_poster> uh-oh smiley face overload <gary_poster> My defence is too little sleep <gary_poster> defense <danilos> gary_poster, sure, go for it, and we'll talk later <gary_poster> ok thanks <danilos> gmb, I can take that branch for review if you want as well :) <gmb> danilos: I'd let you, too, if I could get this damn test to pass :) <danilos> gmb, that's just nitpicking :) <gmb> Heh <gmb> Oh hey, turns out things land quicker if you actually put your password in when prompted for it. <benji> I have the same problem. <benji> gary_poster: I sent Huw an email about whether or not he approved of my approach for bug 771335 a week ago. I haven't heard anything back so I'm just going to land it today. <_mup_> Bug #771335: Title of add subscription widget can wrap if long. <story-better-bug-notification> <Launchpad itself:In Progress by benji> < https://launchpad.net/bugs/771335 > <gary_poster> benji, cool. I saw the ellipsis thing, and I liked the idea. That's the kind of thing I had in mind. <gary_poster> does your approach fix all instances of that overlay, or just ours? <gary_poster> benji, isd has a branch replacing their use of lazr.restful with piston, so we may be back to being the only client, which is too bad, but easier <benji> gary_poster: the ellipsis thing was just for that dialog; I hadn't considered generalizing it, but that's a good idea. I'll see if it can be done without too much work. <gary_poster> Now is the month of maying, when we have to look at our year review and bonus/raising, fa la la la la la la... (with apologies to Thomas Morley) <benji> gary_poster: re. ISD; unfortunate, but certainly an interesting datapoint; voting with their feet and all that <gary_poster> so I'll be contacting al of you to set up these calls soon <benji> heh <gary_poster> benji, generalizing ellipisis: cool. ISD datapoint: yeah <gary_poster> ok, back in a few min, and then will ping d a n i l o s (don't tell him--it will be a big surprise!!!!) <benji> gary_poster: I've verified that all my cards that were in no-downtime-deploy are indeed deployed and moved them to done-done <gary_poster> great thanks benji <gary_poster> ok danilos, my time estimates are particularly bad this morning, but...I'M READY!!! whenever you are <danilos> gary_poster, calling then :) <gary_poster> k :-) <gary_poster> danilos I lost you <gary_poster> says you are offline <gary_poster> gmb, on of the things we discussed on Monday for the mockups was to investigate how well we could estimate the "other subscriber". Right now we load the portlet conditionally ; I expect we'll want to change this to draw the portlet immediatey and get the data for the "view other subscribers" box as needed <gary_poster> did you have any thoughts on that? <gmb> gary_poster: Some, but nothing well fleshed-out (got sidetracked with yesterday's rollback). I'll have a think about it this afternoon and get back to you. <gary_poster> Also, your other subscribers does not distinguish between... ok call with danilos <gmb> Haha * gmb -> heading out to run errands <gary_poster> hey benji, do you think you will be looking for a new task later today, or are you booked? <benji> gary_poster: yep, I'll need something either this afternoon or first thing in the morning, depending on if I give up on the click-to-close message function and generalizing the ellipsis thing <gary_poster> benji, danilos has a collaboration opportunity, so if you could work on something significantly today, it would be worth connecting with him. However, it requires a bit of predicting the future, because he has EoD Real Soon Now. If, best guess, you only think you'll have a couple of hours today at most, then I suggest not worrying about it. If there's a good chance you would have a full half day, go ahead and ta <benji> gary_poster: it depends mostly on how much we value those two things; is it worth keeping the click-to-close message box link and generalizing the ellipsis bit (which I haven't looked at yet) <benji> if so, it'll probably take most of if not all of today to do both <benji> I really like the click-to-close bits, but it's not a world-changer by any means <gary_poster> benji, generalizing: low priority for me. click-to-close message box link: removing it would not be ideal, but we could do that and claim victory; we can't ignore the mute stuff. Therefore, if you've started the proper fix for click-to-close, and I think you have, then continue; if you have not, I suggest postponing it till the two big scary jobs are done. <gary_poster> benji, generalizing: if you don't generalize, a bug pointing out the general problem and suggesting our local solution would be a good alternative <benji> re. click-to-close: yeah, I've started (twice, unfortunately, my first one didn't turn out so well), so I'll try to finish that up. After that I'll look at the generalizing and see how likely that is to succeed and then either do it or file a bug <gary_poster> ok. So, benji, danilos, it looks like we will recheck tomorrow to see if there is a Collaboration Opportunity (TM) <danilos> gary_poster, ack <benji> k * danilos -> afk <gary_poster> gmb, when you are back, I'd like a call <gary_poster> if it is not past your EoD, of course <gmb> gary_poster: I'm back, finally. Aparrently bus timetables are things that Stagecoach Lancaster is aware of but doesn't pay much attention to. <gmb> So, call? <gary_poster> gmb, heh. how much more time do you have? I'm finishing up a mockup revision, and we could talk from there <gary_poster> but if you quit soon I'm pretty close <gmb> gary_poster: I'll be around for at least a couple of hours; I need to make up the time I lost twiddling my thumbs at the bus station. <gary_poster> heh <gary_poster> gmb, ok, I'll try to call in 5; if today's other time estimates are any indication, it will be 10 or 15 minutes <gmb> Okay. Just time for me to make a cup of tea, then :) <gary_poster> cool :-) <gary_poster> gmb, I committed a new mockup to the same branch and pushed it to the same ~yellow <gary_poster> lemme know when you have it and then we can talk <gmb> Cool, I'll grab it now. <gary_poster> thanks <gary_poster> oh, I forgot something <gmb> Hmm. Something wrong with codehosting? <gmb> I can't seem to pull the branch... <gmb> Ah well, working this time. <gary_poster> gmb, good, cause I just pushed another version :-P <gmb> gary_poster: Okay, all set. <gary_poster> cool #launchpad-yellow 2011-05-12 * gary_poster needs to get back in the habit of joining IRC first thing... * gary_poster enjoyed getting out of the habit :-P * gmb -> grabbing a bite to eat; back for the call <gary_poster> cool <gary_poster> benji, gmb, finishing an email, but Skype in just a sec. Please make sure kanban is OK now. <benji> gary_poster: https://bugs.launchpad.net/launchpad/+bugs?field.searchtext=&orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.importance%3Alist=CRITICAL&field.importance%3Alist=HIGH&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&fiel <gmb> gary_poster: Are we still having a call? <benji> gary_poster: the official name for those things seems to be "embroidery hoop" <gary_poster> benji, cool, thanks :-) <gary_poster> gmb, call in 1? <gmb> gary_poster: Yep. <gary_poster> cool <gary_poster> gmb, we do handle things properly for sending emails, pretty sure... <gary_poster> (in lp.bugs.model.structuralsubscription, get_structural_subscription_targets ramirezanna@example.org.parent_subscription_target, which for a product will be a project) <gmb> Ok. <gmb> I'll double-check, but I'm 95% certain that we have tests to cover sending structural subscription emails for project groups. <gary_poster> yeah, I would have expected it <gmb> The UI and the email stuff are worlds apart, really. <gary_poster> I was just concerned because I hadn't thought of it <gmb> I know that feeling all too well. <gary_poster> :-) <gary_poster> gmb, lp.bugs.model.structuralsubscription has the problem in two methods: get_structural_subscriptions_for_target and get_structural_subscriptions_for_bug . Fixing the latter will also affect a bug's also_notified_subscribers, fwiw. * gary_poster leaving you alone now :-) <gmb> gary_poster: Thanks for the guidance :) <gary_poster> np :-) * gary_poster should have said two *functions* <gmb> Hah. Indeed. <gary_poster> benji, crazy idea: if the team's contact address is a mailing list controlled by Launchpad, and we can tell this (I expect we can), and we can tell that the person is or is not a member of the mailing list, then we could offer a link to unsubscribe from the mailing list as a remediation action. <gary_poster> rephrase: if the team's contact address is a mailing list controlled by Launchpad, and the person is subscribed to the mailing list, then we could offer a link. <gary_poster> An interesting question then is what to do if the person is not subscribed to the mailing list <benji> gary_poster: good idea; and I assume that if they aren't a member of the mailing list we would act as if the team didn't have a contact address at all (?) <gary_poster> in that case, it would seem that the subscription might not be pertinent then... <gary_poster> we could not render it, or render it with some "grayed out" visualization or something <gary_poster> I think we should still render it somehow <gary_poster> so people can see that it exists and why it does not affect them...*especially* after they have made a change <gary_poster> (e.g., unsubscribed from mailing list) <benji> hmm, that could work; would strike-through be too much? it only really works for short bits of text <gary_poster> yeah, this is a whole box <gary_poster> I don't think strike-through would be good <gary_poster> being grayed out sounds decent, the more I think about it <gary_poster> we wouldn't offer an in-page change for this <gary_poster> so we wouldn't have to worry about too many controls on a "diabled" box <gary_poster> disabled <gary_poster> benji, if we gray this out, we have to gray the "opt out from this subscription" too, I just realized. <benji> k <gary_poster> so I suppose another option is just having extra text like we do for the opt-out thing. <gary_poster> benji, I'm cool with you making a call. If I'm around, I'd love to see what you decided on for the chance to make tweaks, but don't block on me. <benji> sounds good <benji> gary_poster: I just filed https://bugs.launchpad.net/launchpad/+bug/781729, hopefully it captures the problem in a reasonable way. <_mup_> Bug #781729: Direct subscription controls are (mostly) ineffectual if subscribed via a team with a contact address <story-better-bug-notification> <Launchpad itself:Triaged by yellow> < https://launchpad.net/bugs/781729 > <gary_poster> Cool, thanks benji. Looks good. I'll add a comment <benji> k <gary_poster> benji, are you ok with having our performance review report tomorrow @4 (the same time as our Thursday call)? <gary_poster> performance review report *call* that is <benji> gary_poster: sure <gary_poster> cool <gary_poster> benji, I just carefully composed an email to you, and then sent it from our family email address. :-P . Maybe even twice for good measure, though I'm not sure how I managed that. I'll resend from Canonical; apologies for the dupes. <benji> heh <benji> I've come close to doing the same thing. <gary_poster> benji, ok resent <gary_poster> gmb, also sent you one. <gmb> gary_poster: Just got it, thanks. I'll take a look shortly. <gary_poster> cool <gmb> gary_poster: Separately, amusing one-line fix for part of bug 777783: http://pastebin.ubuntu.com/606538 <_mup_> Bug #777783: Project +subscriptions doesn't show subscriptions to the project group <story-better-bug-notification> <Launchpad itself:In Progress by gmb> < https://launchpad.net/bugs/777783 > <benji> gary_poster: got them; tell Karyn that I appreciate her input on my review <gmb> Quick version, having the __helper cached for products means that when get_structural_subscription_targets() is called, and it looks up the parent_subscription_target, it gets None back, because the __helper was initialised before the Product knew about its Project. <gmb> I do not know why this happens in the real world, however. <gary_poster> gmb, fix: heh and argh <gary_poster> benji, I'll pass that along :-) <gary_poster> gmb, that means somebody is asking for that value and getting the wrong answer though :-( <gary_poster> I think that cachedproperty doesn't cache unless somebody asks for the value <gmb> gary_poster: You're right, it doesn't. <gmb> So yes, something is asking for it somewhere. <gmb> I'm going to carry on fixing this, but I'm also going to push this into ec2 and see what breaks. * benji lunches. <gary_poster> So I think that the test is right, but it should stay a cachedproperty <gmb> (And if nothing breaks, I will be slightly concerned). <gmb> gary_poster: Yes, I agree. Some pdb fun might have to happen here, I thikn. <gary_poster> and we should fix why it is not being initially set properly <gary_poster> yeah <gmb> That's what makes the least sense to me. <gary_poster> if you need another pair of eyes, ask <gmb> I mean, in the case of the test, I understand it. <gmb> Because i create the product and then set the project. <gmb> But even if I do something like: <gmb> ... ah, no. The factory does the same thing. <gmb> I wonder what happens if I re-fetch the project from the store... * gmb goes to try that <gary_poster> ack <gary_poster> I'm going to go for a walk, and have lunch and such. biab <gmb> gary_poster: Do you know how to invalidate the storm cache for an object? <gary_poster> try committing transaction and just getting it again? <gary_poster> IOW, no :-P <gmb> Heh. <gmb> Okay, I'll try the big hammer first. <gary_poster> k :-) <benji> gary_poster: you may be on the phone, but it just occurred to me that we're going to have the same changing-your-direct-subscriptions-might-not-reduce-your-mail-level problem with the mute link on the bug page <gary_poster> benji, yes. I think that's already handled in the mockups for bug 772754 though <_mup_> Bug #772754: After better-bug-notification changes, list of bug subscribers is confusing <story-better-bug-notification> <Launchpad itself:Triaged by yellow> < https://launchpad.net/bugs/772754 > <benji> ah, cool <gary_poster> benji, ready whenever you are #launchpad-yellow 2011-05-13 <gary_poster> danilos, if you are around, I'd like to chat about whether we can move ahead on the mute work without you. <gary_poster> benji, gmb, skype in a sec <gmb> Righto <gary_poster> gmb, almost ready. <gmb> gary_poster: Okay. I'm ready when you are. <gmb> gary_poster: Ah, I was wrong about the linter. It does pick up the PDB call; I just didn't spot it because there was a lot of other things wrong with the file I added it to :). <gary_poster> gmb, lol, ok cool <gmb> Maybe it should flash it in red letters. <gary_poster> heh <benji> gary_poster: you said that there was code that already does some sort of "you can contact this team by mailing their contact address" behavior; can you give me any more pointers to that? I can't find it. <gary_poster> benji, I don't know. :-) Let me look; I know what I meant, but maybe I was mistaken... <benji> thanks <gary_poster> benji, search for "CONTACT_TEAMS" in lib/lp/bugs/javascript/subscription.js <benji> ah! thanks <benji> gary_poster: I finally have everything coming together for my bug. I like this version that doesn't use explanitory text but I'm afrade it will be too subtle: http://i.imgur.com/3XFjR.png <benji> (me realized Gary may be on a call) * gary_poster looks <gary_poster> no <benji> cool <benji> the rain fritzes out my telepathy <gary_poster> :-) <benji> also note that the text in the two boxes just below "Other subscriptions" could use more margin between the prose and the action. If you agree, I'll fix that too. <gary_poster> most definitely, though I was wondering if there might be better solutions to that problem. Considering... <gary_poster> yeah, ok I agree that more margin is sufficient for that problem. Still considering other bits... <gary_poster> After consideration, I'm ok with not having explanatory text in the abstract, but there's a problem I would like to be solved. One solution would be to add some explanatory text, but I can imagine another, and I expect there are yet more reasonable options. <gary_poster> The problem is that the user should know what to ask the administrators to change. <gary_poster> In this case, there are two options <benji> mm, good point <gary_poster> The administrator could change the subscription <gary_poster> or the administrator could remove the contact address <gary_poster> The other solution I can think of in the abstract is to pre-populate the email text to the administrators with the pertinent details. <gary_poster> That would be a nice feature generally <gary_poster> But that would either mean a new page <gary_poster> or it would mean passing arbitrary things in a query string <gary_poster> and having the mail page accept them to insert them as default <gary_poster> which inherently is not so bad IMO <gary_poster> but is sometimes frowned upon <gary_poster> as I said, maybe there are other options <benji> actually, that already works: https://launchpad.net/~benji/+contactuser?field.message=foo <gary_poster> heh <gary_poster> can you submit the form too? <gary_poster> not that I want you to, mind you :-) <gary_poster> more from a "potentially security hole that I should probably not be amused about" perspective <benji> nope, I get a UnsafeFormGetSubmissionError <benji> but we can include a subject too: https://launchpad.net/~benji/+contactuser?field.message=foo&field.subject=hi <benji> so assuming acceptable text for subject and message, that option sounds good <gary_poster> ok, cool <gary_poster> I'm +1 on that, myself <gary_poster> it seems like a reasonable compromise <benji> I changed "Request administrators change" to "Request team administrators change" to be clear about which administrators we're talking about. <benji> cool <gary_poster> Yeah I keep staring at that text <gary_poster> Request change from team administrators? <gary_poster> feels kind of hard to parse atm <benji> hmm, yeah "Request team administrators change" could mean that you want to provoke a regime change :) <benji> "Request team administrators change subscription"? Getting long now, but it's the only thing on the line. <gary_poster> Honestly it is still hard for me to parse quickly <gary_poster> Request that team adminstrators change the subscription <gary_poster> Request team adminstrators change the subscription <gary_poster> Request subscription changethat team adminstrators change the subscription <gary_poster> Sorry that was supposed to be <gary_poster> Request subscription change <gary_poster> Request change to the subscription <gary_poster> I like that last one myself <gary_poster> We don't have to mention the administrators here, I think <gary_poster> especially with the prepopulated email <benji> yep me too; and if they don't know who they're talking to they'll be able to look on the next page <gary_poster> (that will presumably mention the administrators <benji> yep <gary_poster> right <gary_poster> cool <benji> "Request change to the subscription" it is. <gary_poster> great. looks good, thank you <benji> Today's productivity brought to you by http://www.youtube.com/watch?v=uKJeLG8-M5I <benji> gary_poster: what did we want to do differently if the team contact is a mailing list and the user is subscribed to the mailing list? Point them at the page where they can manage their subscription? <gary_poster> music is cool <benji> songs like that make me want to try building sampled tracks again; it feels like one of those "life's work" kind of things that we only have so much time for though <gary_poster> yeah that's fine. My initial idea was that we could offer to unsubscribe them directly. I have no idea how reasonable that is. If we send them off to a page, we should make it clear what they need to do there (that is, which mailing list they need to unsubscribe from) <gary_poster> heh <benji> sounds good <benji> here's a first draft of the message: http://typewith.me/RfELh2ztbw I'm not real happy with it. <benji> oops, gary^ <gary_poster> benji, was getting kids from school. will read, then call you <benji> sounds good #launchpad-yellow 2011-05-16 <danilos> gmb, hi, I remember you said you'd review my branch last week, but I see no review :) should I go for the OCR? <gmb> danilos: Oops. I think I did review it, I just didn't post the review. Let me take a look now... <danilos> gmb, sure <gmb> danilos: Ah, yes. My only comment was that those XXXs about addChange()... is it worth filing a bug to remind us to do that, or should we just drop them? <danilos> gmb, uhm, right, I don't know, what do you think? I'll perhaps add a task card on the kanban board and then discuss it with gary <gmb> danilos: Ok. Might as well drop the XXXs for the sake of landing this. We can always look back to check where they should go if we decide to file a bug about it later. <gmb> Anyway, belatedly, r=me. <danilos> gmb, ok, agreed, thanks for the review <gmb> np <danilos> gmb, (no worries, since I wasn't really in shape to land it anyway) <gmb> :) <gmb> danilos: Glad to see you're better. Or at least well enough to have an IRC conversation. <danilos> gmb, heh, I am very much better, thanks <gary_poster> (bac is here today but not around for meeting) <gary_poster> benji danilos gmb, hi. I'll be looking at kanban board in a sec, and call will be in 4 <gary_poster> A friend writes on Skype: "Microsoft Skype 2.2 Professional Edition Plus" <gary_poster> hee hee <gmb> Heh. <danilos> gary_poster, ack <gary_poster> benji, I may have forgotten a schedule wrinkle for you, but call now <benji> gary_poster: nope, I forgot the wrinkle that you have to run skype for it to work, maybe microsoft will fix that <danilos> gary_poster, to register, https://forms.canonical.com/sprint/ <gary_poster> danilos, heh, thank you, I was wondering...and procrastinating! :-) <benji> gmb: I noticed that https://code.launchpad.net/~gmb/launchpad/bug-772609-again/+merge/60513 hasn't been merged yet and wanted to let you know in case it had slipped through the cracks <gmb> benji: That's the one that bounced because devel was broken. I'm running it through ec2 again now. Thanks for spotting it, though. <benji> cool <gary_poster> hey danilos. I proposed a PDR meeting time in an email I sent earlier today. Could you review and lemme know if that works for you? <danilos> gary_poster, sure, will do <danilos> gary_poster, replied to the email, yes, tomorrow at 14:30 UTC works fine <gary_poster> :-) thanks <gmb> Hmm. When ~name16 and ~landscaped-developers are subscribed to *everything* there may be a chance - just a chance - that one has done something amusing when one wanted to do something useful. <gary_poster> heh, why, or in what way? <gmb> gary_poster: Still trying to work that out. Hurrah for pdb. <gary_poster> heh <gary_poster> ok * gmb -> stepping out for an appointment; back in a bit * danilos -> out <bac> hi gary_poster <gary_poster> hey bac <bac> gary_poster: have time this afternoon for a quick skype call? <gary_poster> sure, bac. if it is < 20 min, I can do now; otherwise...maybe start around 2:30 or 3:00? I need to be out 3:35-3:55 to get kids from school but then could continue if needed. <bac> gary_poster: now would be good. let me find my phone <gary_poster> cool <gary_poster> Assuming we're using Skype, I'm logged in andhave my headphones on; gimme a call when you are ready. <gary_poster> http://www.w3.org/TR/wai-aria/ <benji> gary_poster: did you see Brian Murray's message to launchpad-users about https://bugs.launchpad.net/people/+me/+structural-subscriptions? I seem to recall that the page in question isn't ready for prime time and in fact should be removed. If that's true I'll reply to him. <gary_poster> bac, old page, but orca in 2008 seemed to be doing pretty well with aria. I suspect if we support aria we'll do ok <gary_poster> old page was in reference to link I did not give <bac> cool <gary_poster> bac, any thoughts on what benji just said? <gary_poster> do you know why he would have done that? <gary_poster> because yes, benji, we do not link to that page and it is not ready for primetime and not under development <gary_poster> (and no, I didn't see the email) <bac> i have not read the email <bac> in my session he brought that up and i told him that page was deprecated. i guess i didn't make myself clear. <benji> gary_poster: https://lists.launchpad.net/launchpad-users/msg06288.html * bac looks for email <benji> bac: https://lists.launchpad.net/launchpad-users/msg06288.html <gary_poster> benji, bac,gotcha. benji, yeah please reply. that page introduces the idea of filters, which is something we discarded <gary_poster> (from the UI) <bac> i think brian really wants a single page to list all of his subscriptions and was hoping that page would be it <gary_poster> It would be nice <gary_poster> it was on our nice-to-have plans <gary_poster> but not our must-have plans <benji> ok, I'll reply <benji> we should probably kill that page <gary_poster> thank you #launchpad-yellow 2011-05-17 * gmb lunches <gary_poster> danilos, hey. Can I take "UI: unmute does not show dialog, just unmutes"--that is, is the kanban board accurate? If so, what branch should I use as a base--is "Provide BugMute table and use it for muting bug subscriptions" in db-devel or is the kanban accurate again, and I need to get a branch? <gary_poster> Ah-ha <gary_poster> looks like I need to branch https://code.launchpad.net/~danilo/launchpad/proper-bug-muting <danilos> gary_poster, you could, but it'd be even better to branch off my nothing branch <gary_poster> ...uh...wha? <danilos> gary_poster, I've got one test to take care of there and it's going up for review <gary_poster> oh, your nothing branch! <gary_poster> heh, got it now <gary_poster> lp:~danilo/launchpad/bug-772763-remove-nothing <danilos> gary_poster, heh, yeah :) <gary_poster> cool thanks <danilos> gary_poster, I hit a bunch of test failures in the proper-bug-muting branch, fwiw, some of them related to person merging <gary_poster> ah, yeah, that's a pain <gary_poster> but resolved now, it looks like <danilos> gary_poster, yeah, up in ec2 again (just in case) <gary_poster> :-) cool <gary_poster> bac benji danilos gmb, kanban now-ish, skype in 4 <gmb> https://bugs.launchpad.net/launchpad/+bug/783948 <_mup_> Bug #783948: Entering a comment returns an error <Launchpad itself:Triaged> < https://launchpad.net/bugs/783948 > <gmb> https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/752193 <_mup_> Bug #752193: Installation of the acroread package causes completion to treat directories like files with some commands <amd64> <apport-bug> <natty> <acroread (Ubuntu):Confirmed for brian-thomason> <bash-completion (Ubuntu):Won't Fix> <bash-completion (Debian):Won't Fix> < https://launchpad.net/bugs/752193 > <gmb> gary_poster, benji: Am I right in thinking that a LocationError from TAL basically means "You're trying to access an attribute that doesn't exist"? <benji> gmb: not normally; it's more often a problem finding out where an object is in the url space; e.g., it doesn't have a __parent__ <gary_poster> yeah <gmb> Hmm. <gmb> Here's the salient bit of the OOPS: <gmb> LocationError: (<zope.browserpage.metaconfigure.SimpleViewClass from /srv/launchpad.net/production/launchpad-rev-13053/lib/lp/bugs/browser/../templates/bug-portlet-subscribers.pt object at 0xfe1d610>, 'current_user_mute_class') <gmb> I'm trying to figure out what that actually means in this case. <gary_poster> is there a traceback as well, or is that eaten somehow? <gmb> gary_poster: It's all here: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1963BC361 <gary_poster> gmb, your initial description was correct <gmb> Ah. <gmb> Now that's very odd. <gary_poster> as I expect you saw, <gary_poster> attr = getattr(subject, name, _marker) <gary_poster> if attr is not _marker: <gary_poster> return attr <gary_poster> if hasattr(subject, '__getitem__'): <gary_poster> try: <gary_poster> return subject[name] <gary_poster> except (KeyError, TypeError): <gary_poster> pass <gary_poster> raise LocationError(subject, name) <gmb> Saw, but didn't pay enough attention to :) <gary_poster> :-) <gmb> Hmm. <gary_poster> this may be one of those transitive attribute errors...sometimes they explain surprises like this <gary_poster> if current_user_mute_class is an @property * gary_poster looks forward to having Python use mwh's wrapped exceptions, from whatever version of Python that is in <gmb> gary_poster: That wouldn't explain why the page still OOPSes for Gavin and I but not wgrant, though. <gary_poster> gmb, ForbiddenAttribute and Unauthorized both subsclass AttributeError, IIRC. Maybe pertinent? <gmb> Ah, true. <gmb> Hmm. * gmb pokes <gary_poster> They would be eaten by the code above <gmb> Yes. <gary_poster> and converted into LocationError <gmb> Quite so. <gmb> So, let's see if I can break it. <gmb> Muhahaha, etc. <gary_poster> heh <gary_poster> danilos, I'm ready anytime for our call. This is 11 minutes early, so no rush. ;-) Give me a Skype call when you are ready. <danilos> gary_poster, sure thing, I am ready myself <gary_poster> cool <gmb> gary_poster: I haven't been able to break anything and I've now been sucked into an OCR / helping out a contributor conversation. I think it might be a good time to roll back my last revision since that seems (to me) like a likely culprit. <gary_poster> gmb, ok, please do <gmb> On it now. <gmb> gary_poster: I can confirm that the rollback fixed the problem. <gmb> Now, that doesn't mean that it was actually my revision that caused the problem (we rolled back from 13050 to 13045 for logistical reasons) but it seems likely. <gary_poster> gmb, just saw this, but mostly good. :-) <gmb> Yeah. <gmb> Trouble is reproducing it. <danilos> gmb, thanks for the review * danilos -> off <gmb> np <bac> hi gary_poster, benji: on this page https://bugs.launchpad.net/ubuntu/+subscriptions there is a help icon next to the "Stop my emails" link. but we go to great pains to make it appear and disappear on hover. why? <bac> i think that link only appears for team subscriptions and perhaps ones for teams you don't administer <benji> bac, I don't remember specifically why I did it that way; I think it was to reduce confusion because of the number of other icons visible <gary_poster> bac: why: the number of icons were becoming problematic. The hover was a problematic solution that benji prototyped up and that we felt was an improvement. [Link should appear for team subscriptions, unless team has a contact address (that last part is in progress).] <bac> ok. fwiw it seemed like a browser bug when i first encountered it. <gary_poster> heh <gary_poster> making it appear gradually would reduce that impression, but not remove the underlying discoverability problem. <bac> gary_poster: bug 778323 <_mup_> Bug #778323: On the subscription page, the help popup button opens up a 404 page. <story-better-bug-notification> <Launchpad itself:Triaged by bac> < https://launchpad.net/bugs/778323 > <bac> gary_poster: so the problem is the help file only exists for bugs.lp.net <gary_poster> bac, good one. Sorry, I forget to do
{'channel': 'launchpad-yellow', 'month': 5}