Update app.py

app.py

@@ -19,35 +19,19 @@ class QuizApp:
         prompt = f"""Create exactly {num_questions} multiple choice questions based on this text:
         {text}
         
-        Format your response EXACTLY like this example:
+        Return ONLY a JSON array with this EXACT format - no other text:
         [
             {{
-                "question": "What is the main topic discussed?",
+                "question": "Question text here?",
                 "options": [
-                    "Correct answer",
-                    "Wrong answer 1",
-                    "Wrong answer 2",
-                    "Wrong answer 3"
-                ],
-                "correct_answer": 0
-            }},
-            {{
-                "question": "Another question here?",
-                "options": [
-                    "Correct answer",
-                    "Wrong answer 1",
-                    "Wrong answer 2",
-                    "Wrong answer 3"
+                    "Option 1",
+                    "Option 2",
+                    "Option 3",
+                    "Option 4"
                 ],
                 "correct_answer": 0
             }}
         ]
-    
-        Important:
-        - Return ONLY the JSON array
-        - Each question must have exactly 4 options
-        - correct_answer must be the index (0-3) of the correct option
-        - Do not add any explanation or additional text
         """
         
         try:
@@ -55,7 +39,7 @@ class QuizApp:
                 messages=[
                     {
                         "role": "system",
-                        "content": "You are a quiz generator that creates clear, single-choice questions. Always respond with valid JSON array only."
+                        "content": "You are a quiz generator. Respond only with a properly formatted JSON array."
                     },
                     {
                         "role": "user",
@@ -63,63 +47,81 @@ class QuizApp:
                     }
                 ],
                 model="llama-3.2-3b-preview",
-                temperature=0.5,
-                max_tokens=2048
+                temperature=0.3,  # Reduced temperature for more consistent formatting
+                max_tokens=2048,
+                stop=["\n\n", "```"]  # Stop generation at these tokens
             )
             
             # Clean up the response
             response_text = response.choices[0].message.content.strip()
-            # Remove any markdown formatting or additional text
-            response_text = response_text.replace("```json", "").replace("```", "").strip()
             
-            # Ensure response starts with [ and ends with ]
-            response_text = response_text[response_text.find("["):response_text.rfind("]")+1]
+            # Remove any markdown formatting
+            response_text = response_text.replace("```json", "").replace("```", "").strip()
             
-            print("Generated response:", response_text)  # Debug print
+            # Find the JSON array
+            start_idx = response_text.find("[")
+            end_idx = response_text.rfind("]")
             
-            # Parse and validate questions
-            questions = json.loads(response_text)
-            if not isinstance(questions, list):
-                raise ValueError("Response is not a list")
+            if start_idx == -1 or end_idx == -1:
+                raise ValueError("No valid JSON array found in response")
                 
-            # Validate each question
+            response_text = response_text[start_idx:end_idx + 1]
+            
+            # Try to parse the JSON
+            try:
+                questions = json.loads(response_text)
+            except json.JSONDecodeError:
+                # If parsing fails, try to fix common JSON formatting issues
+                response_text = response_text.replace("'", '"')  # Replace single quotes with double quotes
+                response_text = response_text.replace("},]", "}]")  # Fix trailing comma
+                response_text = response_text.replace(",]", "]")  # Fix trailing comma
+                questions = json.loads(response_text)
+            
+            # Validate questions
             validated_questions = []
             for q in questions:
                 if not isinstance(q, dict):
                     continue
+                    
+                # Ensure all required fields are present
                 if not all(key in q for key in ["question", "options", "correct_answer"]):
                     continue
+                    
+                # Ensure options is a list with exactly 4 items
                 if not isinstance(q["options"], list) or len(q["options"]) != 4:
-                    continue
-                if not isinstance(q["correct_answer"], int) or q["correct_answer"] not in range(4):
-                    continue
+                    # Try to fix by padding with additional options if needed
+                    if isinstance(q["options"], list) and len(q["options"]) < 4:
+                        q["options"].extend([f"Additional option {i+1}" for i in range(4 - len(q["options"]))])
+                    else:
+                        continue
+                        
+                # Ensure correct_answer is valid
+                if not isinstance(q["correct_answer"], (int)) or q["correct_answer"] not in range(4):
+                    q["correct_answer"] = 0  # Default to first option if invalid
+                    
                 validated_questions.append(q)
             
             if not validated_questions:
-                raise ValueError("No valid questions generated")
+                return False, []
                 
-            self.current_questions = validated_questions
-            return True, validated_questions
+            self.current_questions = validated_questions[:num_questions]  # Limit to requested number
+            return True, self.current_questions
             
-        except json.JSONDecodeError as e:
-            print(f"JSON parsing error: {e}")
-            # Return a default question for testing/debugging
+        except Exception as e:
+            print(f"Error in question generation: {str(e)}")
+            # Create a single default question for testing
             default_questions = [{
-                "question": "Sample question (Error occurred in generation)",
+                "question": "Default question (Error in generation - please try again)",
                 "options": [
-                    "Option 1",
-                    "Option 2",
-                    "Option 3",
-                    "Option 4"
+                    "Option A",
+                    "Option B",
+                    "Option C",
+                    "Option D"
                 ],
                 "correct_answer": 0
             }]
             self.current_questions = default_questions
             return True, default_questions
-            
-        except Exception as e:
-            print(f"Error generating questions: {e}")
-            return False, []
 
     def calculate_score(self, answers):
         if not answers or not self.current_questions:
@@ -196,27 +198,29 @@ def create_quiz_interface():
                 )
                 certificate_display = gr.Image(label="Your Certificate")
 
-
         def update_questions(text, num_questions):
             if not text.strip():
                 return (
-                    gr.update(value="Please enter some text content to generate questions."),
+                    gr.update(value="⚠️ Please enter some text content to generate questions."),
                     *[gr.update(visible=False, choices=[]) for _ in range(5)],
                     [],
                     0
                 )
-                
+            
             success, questions = quiz_app.generate_questions(text, num_questions)
+            
             if not success or not questions:
                 return (
-                    gr.update(value="Failed to generate questions. Please try again with different content."),
+                    gr.update(value="❌ Failed to generate questions. Please try again with different content."),
                     *[gr.update(visible=False, choices=[]) for _ in range(5)],
                     [],
                     0
                 )
             
             # Update question display
-            questions_html = "### Answer all questions below:\n\n"
+            questions_html = "# 📝 Assessment Questions\n\n"
+            questions_html += "> Please select one answer for each question below.\n\n"
+            
             for i, q in enumerate(questions, 1):
                 questions_html += f"### Question {i}\n{q['question']}\n\n"
             
@@ -228,13 +232,12 @@ def create_quiz_interface():
                         visible=True,
                         choices=questions[i]["options"],
                         value=None,
-                        label=f"Question {i+1}"
+                        label=f"Select answer for Question {i+1}"
                     ))
                 else:
                     updates.append(gr.update(visible=False, choices=[]))
             
-            return (gr.update(value=questions_html), *updates, questions, 1)
-        
+            return (gr.update(value=questions_html), *updates, questions, 1)        
         
         def submit_quiz(q1, q2, q3, q4, q5, questions):
             answers = [q1, q2, q3, q4, q5][:len(questions)]