Horsley was the son of the painter John Callcott Horsley.
A RIBA associate in 1890, he left the institute in 1892 in protest against plans for compulsory registration of architects; he rejoined as a fellow in 1906.