Johnstone was born in 1897 in Denholm in the Scottish Borders and grew up to a farming family.
During World War II Johnstone became culturally despondent, turning away from practising art to become a teacher, a role which occupied much of his professional life.