Croft was the third son of Conservative MP Sir Herbert George Denman Croft, 9th Baronet and his wife, Georgiana Eliza Lucy Marsh.
In 1912, Croft married Esmé Sutton, daughter of Sir Arthur Edwin Sutton, 7th Baronet.