He passed advocate at the Scottish bar on 3 July 1790, and became the close friend and literary confidant of Scott.
Scott dedicated to Erskine the third canto of Marmion, which was published in February 1808.