McDonald was born in Sydney, the son of mining engineer George McDonald and his wife Margaret McNamara.
McDonald was called to the Bar in 1927 and admitted as a solicitor in 1937, establishing his own firm.