He was first elected in the 1979 general election as the member for Perth and East Perthshire.
He was elected Deputy Chairman of the Scottish Conservatives in June 2000, and again in 2006, serving until 2008.