prompt: You will be provided with a partial code base and an issue statement explaining a problem to resolve.
  <issue>
  Warning Check on Unused Parameter hides Error Check about Missing Parameter Type
  *cfn-lint version: cfn-lint 0.25.3*
  
  Parameters defined in a template, but not directly used, are not validated for missing attributes like `Type`.
  
  For various reasons, we want to include parameters in our templates that are not used by resources in the templates and therefore disable `W2001` When this happens, the following template will not fail cfn-lint. If I uncomment the `Metadata` section, I will finally see the `E1012` failure. I should not have to resolve a Warning in order to unmask an Error.
  
  ```yaml
  Parameters:
    Foo:
      Description: "Foo?"
  Conditions:
    AlwaysFalse: !Equals [ true, false ]
  Resources:
    # Metadata:
    #   Foo: !Ref Foo
    NullResource:
      Type: Custom::NullResource
      Condition: AlwaysFalse
  ```
  
  
  </issue>
  <code>
  [start of src/cfnlint/rules/parameters/Configuration.py]
  1 """
  2 Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
  3 SPDX-License-Identifier: MIT-0
  4 """
  5 from cfnlint.rules import CloudFormationLintRule
  6 from cfnlint.rules import RuleMatch
  7 
  8 
  9 class Configuration(CloudFormationLintRule):
  10     """Check if Parameters are configured correctly"""
  11     id = 'E2001'
  12     shortdesc = 'Parameters have appropriate properties'
  13     description = 'Making sure the parameters are properly configured'
  14     source_url = 'https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/parameters-section-structure.html'
  15     tags = ['parameters']
  16 
  17     valid_keys = [
  18         'AllowedPattern',
  19         'AllowedValues',
  20         'ConstraintDescription',
  21         'Default',
  22         'Description',
  23         'MaxLength',
  24         'MaxValue',
  25         'MinLength',
  26         'MinValue',
  27         'NoEcho',
  28         'Type',
  29     ]
  30 
  31     def match(self, cfn):
  32         """Check CloudFormation Parameters"""
  33 
  34         matches = []
  35 
  36         for paramname, paramvalue in cfn.get_parameters().items():
  37             for propname, _ in paramvalue.items():
  38                 if propname not in self.valid_keys:
  39                     message = 'Parameter {0} has invalid property {1}'
  40                     matches.append(RuleMatch(
  41                         ['Parameters', paramname, propname],
  42                         message.format(paramname, propname)
  43                     ))
  44 
  45         return matches
  46
  [end of src/cfnlint/rules/parameters/Configuration.py]
  </code>
  
  I need you to solve this issue by generating a single patch file that I can apply directly to this repository using git apply. Please respond with a single patch file in the following format.
  <patch>
  diff --git a/file.py b/file.py
  --- a/file.py
  +++ b/file.py
  @@ -1,27 +1,35 @@
   def euclidean(a, b):
  -    while b:
  -        a, b = b, a % b
  -    return a
  +    if b == 0:
  +        return a
  +    return euclidean(b, a % b)
   
   
   def bresenham(x0, y0, x1, y1):
       points = []
       dx = abs(x1 - x0)
       dy = abs(y1 - y0)
  -    sx = 1 if x0 < x1 else -1
  -    sy = 1 if y0 < y1 else -1
  -    err = dx - dy
  +    x, y = x0, y0
  +    sx = -1 if x0 > x1 else 1
  +    sy = -1 if y0 > y1 else 1
   
  -    while True:
  -        points.append((x0, y0))
  -        if x0 == x1 and y0 == y1:
  -            break
  -        e2 = 2 * err
  -        if e2 > -dy:
  -            err -= dy
  -            x0 += sx
  -        if e2 < dx:
  -            err += dx
  -            y0 += sy
  +    if dx > dy:
  +        err = dx / 2.0
  +        while x != x1:
  +            points.append((x, y))
  +            err -= dy
  +            if err < 0:
  +                y += sy
  +                err += dx
  +            x += sx
  +    else:
  +        err = dy / 2.0
  +        while y != y1:
  +            points.append((x, y))
  +            err -= dx
  +            if err < 0:
  +                x += sx
  +                err += dy
  +            y += sy
  +
  +    points.append((x, y))
       return points
  
  </patch>
golden_diff: diff --git a/src/cfnlint/rules/parameters/Configuration.py b/src/cfnlint/rules/parameters/Configuration.py
  --- a/src/cfnlint/rules/parameters/Configuration.py
  +++ b/src/cfnlint/rules/parameters/Configuration.py
  @@ -28,6 +28,10 @@
           'Type',
       ]
   
  +    required_keys = [
  +        'Type'
  +    ]
  +
       def match(self, cfn):
           """Check CloudFormation Parameters"""
   
  @@ -41,5 +45,12 @@
                           ['Parameters', paramname, propname],
                           message.format(paramname, propname)
                       ))
  +            for reqname in self.required_keys:
  +                if reqname not in paramvalue.keys():
  +                    message = 'Parameter {0} is missing required property {1}'
  +                    matches.append(RuleMatch(
  +                        ['Parameters', paramname],
  +                        message.format(paramname, reqname)
  +                    ))
   
           return matches
  
verification_info: {"golden_diff": "diff --git a/src/cfnlint/rules/parameters/Configuration.py b/src/cfnlint/rules/parameters/Configuration.py\n--- a/src/cfnlint/rules/parameters/Configuration.py\n+++ b/src/cfnlint/rules/parameters/Configuration.py\n@@ -28,6 +28,10 @@\n         'Type',\n     ]\n \n+    required_keys = [\n+        'Type'\n+    ]\n+\n     def match(self, cfn):\n         \"\"\"Check CloudFormation Parameters\"\"\"\n \n@@ -41,5 +45,12 @@\n                         ['Parameters', paramname, propname],\n                         message.format(paramname, propname)\n                     ))\n+            for reqname in self.required_keys:\n+                if reqname not in paramvalue.keys():\n+                    message = 'Parameter {0} is missing required property {1}'\n+                    matches.append(RuleMatch(\n+                        ['Parameters', paramname],\n+                        message.format(paramname, reqname)\n+                    ))\n \n         return matches\n", "issue": "Warning Check on Unused Parameter hides Error Check about Missing Parameter Type\n*cfn-lint version: cfn-lint 0.25.3*\r\n\r\nParameters defined in a template, but not directly used, are not validated for missing attributes like `Type`.\r\n\r\nFor various reasons, we want to include parameters in our templates that are not used by resources in the templates and therefore disable `W2001` When this happens, the following template will not fail cfn-lint. If I uncomment the `Metadata` section, I will finally see the `E1012` failure. I should not have to resolve a Warning in order to unmask an Error.\r\n\r\n```yaml\r\nParameters:\r\n  Foo:\r\n    Description: \"Foo?\"\r\nConditions:\r\n  AlwaysFalse: !Equals [ true, false ]\r\nResources:\r\n  # Metadata:\r\n  #   Foo: !Ref Foo\r\n  NullResource:\r\n    Type: Custom::NullResource\r\n    Condition: AlwaysFalse\r\n```\r\n\n", "before_files": [{"content": "\"\"\"\nCopyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.\nSPDX-License-Identifier: MIT-0\n\"\"\"\nfrom cfnlint.rules import CloudFormationLintRule\nfrom cfnlint.rules import RuleMatch\n\n\nclass Configuration(CloudFormationLintRule):\n    \"\"\"Check if Parameters are configured correctly\"\"\"\n    id = 'E2001'\n    shortdesc = 'Parameters have appropriate properties'\n    description = 'Making sure the parameters are properly configured'\n    source_url = 'https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/parameters-section-structure.html'\n    tags = ['parameters']\n\n    valid_keys = [\n        'AllowedPattern',\n        'AllowedValues',\n        'ConstraintDescription',\n        'Default',\n        'Description',\n        'MaxLength',\n        'MaxValue',\n        'MinLength',\n        'MinValue',\n        'NoEcho',\n        'Type',\n    ]\n\n    def match(self, cfn):\n        \"\"\"Check CloudFormation Parameters\"\"\"\n\n        matches = []\n\n        for paramname, paramvalue in cfn.get_parameters().items():\n            for propname, _ in paramvalue.items():\n                if propname not in self.valid_keys:\n                    message = 'Parameter {0} has invalid property {1}'\n                    matches.append(RuleMatch(\n                        ['Parameters', paramname, propname],\n                        message.format(paramname, propname)\n                    ))\n\n        return matches\n", "path": "src/cfnlint/rules/parameters/Configuration.py"}]}