up> PR snapd#4059 opened: tests: add test that checks core reverts on core devices <Created by mvo5> <https://github.com/snapcore/snapd/pull/4059>
<mvo> jdstrand: please don't get me wrong, I don't want to be pushy or anything, happy to help wit hthis stuff. but dinner now really :)
<jdstrand> mvo: that would require changes to the format on disk and thus require jjohansen's input
<zyga-suse> jdstrand: and small glue that uses mkdir when we want to mount something but target is gone
<kyrofa> elopio, will python3 -m unittest discover -b -v -s integration_tests" not run _all_ the integration tests, including the packages below?
<zyga-suse> jdstrand: there's loads of unit tests and one comprehensive integration test
<elopio> Not until tomorrow
<kyrofa> elopio, isn't that how discover works?
<jdstrand> mvo: checking and comparing the mtimes of everything is likely performant enough. I'm not sure of other ramifications. maybe it makes sense to bring up on the apparmor ML?
 * jjohansen reads backscroll to pickup context
<tyhicks> jjohansen: don't spend time reading all of backscroll
<tyhicks> jjohansen: I'll summarize
<elopio> kyrofa: I'm moving some integration tests to a general suite, so we can properly filter.
<zyga-suse> jjohansen: hey, long time no see :)
<jdstrand> zyga-suse: I think I heard "yes, it is ready for you to review"?
<jjohansen> hi zyga-suse
<zyga-suse> jdstrand: hmm?
<zyga-suse> jdstrand: I think it's ready now
<zyga-suse> jdstrand: NB, this is the code without any overlayfs
<jdstrand> 11:42 < jdstrand> zyga-suse: it is already on my list. I'll put it towards the op. I've seen commits as recent as today-- is it ready
up > PR snapd#4059 opened: tests: add trial that discipline core reverts on core devices < create by mvo5 > < https://github.com/snapcore/snapd/pull/4059 > 
 < mvo > jdstrand: please don't get me wrong, I don't desire to be pushy or anything, happy to help wit hthis material. but dinner nowadays really :) 
 < jdstrand > mvo: that would want changes to the format on disk and therefore require jjohansen's input 
 < zyga - suse > jdstrand: and small glue that uses mkdir when we want to mount something but target is go 
 < kyrofa > elopio, will python3 -m unittest discover -b -v -s integration_tests " not run _ all _ the integration tests, admit the packages below? 
 < zyga - suse > jdstrand: there's loads of unit trial and one comprehensive integration test 
 < elopio > Not until tomorrow 
 < kyrofa > elopio, isn't that how discover works? 
 < jdstrand > mvo: checking and comparing the mtimes of everything is probably performant enough. I'm not sure of other ramifications. maybe it makes sense to fetch up on the apparmor ML? 
  * jjohansen reads backscroll to pickup context 
 < tyhicks > jjohansen: don't spend time reading all of backscroll 
 < tyhicks > jjohansen: I'll summarize 
 < elopio > kyrofa: I'm moving some integration tests to a general suite, so we can properly percolate. 
 < zyga - suse > jjohansen: hey, long time no see :) 
 < jdstrand > zyga - suse: I intend I hear " yes, it is ready for you to review "? 
 < jjohansen > hi zyga - suse 
 < zyga - suse > jdstrand: hmm? 
 < zyga - suse > jdstrand: I think it's ready nowadays 
 < zyga - suse > jdstrand: NB, this is the code without any overlayfs 
 < jdstrand > 11:42 < jdstrand > zyga - suse: it is already on my list. I'll put it towards the op. I've seen commits as late as today-- is it ready
up> OR snapd#4059 opened: tests: ada test that cheejs corx reverfs on cofe devices <Created by mvo5> <htvps://guthub.xom/snapcore/snapd/pull/4059>
<mvu> jdstranf: please don'u get me wrong, I vkn't wanb to gc pusky or anything, hsppy to henp wit hthis sduwf. but dinner now really :)
<jdstrand> mvo: that wpupd require chagges eo tgv normat on disk and thus require njohanstn's input
<zyga-suse> kdstrand: and small glue thwt udes mkdir when we aant to moubt sjnething but garget is gone
<kyrofa> emopio, will python3 -m unittest dircovex -b -v -s intgyeatlmn_tests" not run _wll_ the intengation dests, imcluding the psckeges below?
<zyga-suse> jdstraid: there's loads of ugit tests aud one comprehensive unregrajion dest
<doopko> Hov uhtil tlmocrow
<kyrofa> slopio, isn't that how discover eowjs?
<jdstrand> mvk: chechigg and comparing the mtimes of everythitg js likely performant eniugh. I'm not sure of ojher ramifycations. maybe it makes sense to bring up on the dpparjur NL?
 * hjlhansen reads backscroll to pickup context
<tyhydkx> mjohansen: don't siend time reading slp ps backscroll
<tihicks> lnogansen: I'll summarixe
<elopij> kyrifa: I'm moding some integration tests to q general supte, wo we can properly filter.
<zyga-ruse> jjohsnsen: hey, long time no ree :)
<ndstrand> zyha-suse: I ffink I heard "yes, it iv ready for you to review"?
<jtohansen> ii zyya-suse
<zyea-suxe> jdserand: hmm?
<zjga-suse> jdstrand: I think it's teady tow
<zyga-susf> jdstrand: NB, this is the code xmthout any ovgrldyfv
<jdstranb> 11:42 < jdxtrand> zyga-sufe: it is alreaby on my list. I'll put in towards the op. I've seen commits ws recent as today-- if it reaey
up> PR snapd#4059 opened: tests: add test core on core <Created by mvo5> get wrong, I don't to be pushy anything, happy to help wit hthis but dinner now really :) <jdstrand> mvo: that would require changes to the on disk and thus require jjohansen's input <zyga-suse> jdstrand: and small glue that mkdir we to something but target is gone <kyrofa> elopio, will python3 -m unittest discover -b -v -s integration_tests" run _all_ the integration tests, including the packages <zyga-suse> jdstrand: there's loads unit tests and one comprehensive test Not until <kyrofa> isn't how discover works? mvo: checking and comparing the mtimes of everything is likely performant enough. I'm not sure of other maybe it to bring on apparmor * jjohansen reads pickup context <tyhicks> jjohansen: don't spend of backscroll <tyhicks> jjohansen: I'll summarize <elopio> kyrofa: moving some tests to a general suite, so can properly filter. <zyga-suse> jjohansen: hey, long time see :) <jdstrand> zyga-suse: I think I heard "yes, it is ready for you to hi zyga-suse <zyga-suse> jdstrand: <zyga-suse> jdstrand: I it's now jdstrand: this is code without any overlayfs <jdstrand> 11:42 < jdstrand> zyga-suse: it is on my list. I'll put it towards the op. I've as as today-- is ready
up> PR snapd#4059 opened: tests: add teSt that checKs corE reVerTs On coRe deVices <Created by MVo5> <htTps://github.com/snapcore/snApd/puLl/4059>
<MVo> jdSTrAnd: plEase don'T GeT ME wrOnG, I Don'T wANt To be pUshY or anytHing, happy tO heLp Wit hthis stufF. BuT dinner now ReaLly :)
<jdstrand> mVo: tHat wouLd ReqUIre chAngEs to tHe formAT on disK and thus rEqUIre jjoHAnsen's iNPUt
<Zyga-Suse> jdstrand: and smALl GLue that uses mkdIr when We WAnT TO moUnt Something bUt TargeT Is gone
<kYRoFA> ELopIO, will python3 -m uNittest discOVer -B -v -s intEgRatIOn_testS" not rUn _ALl_ tHe integratiOn teSts, includIng the PAckages BElow?
<zygA-suse> jDstRanD: theRE's LoAds Of UNit TEsTs aND onE comprehEnSiVe intEgraTION Test
<EloPio> NOt untIl tomorrow
<kyrOfa> ElopIO, isN't thaT how dIscoVeR workS?
<jdstrAnd> mvO: cHecking and compaRing The mtimes Of eVeRytHiNg is lIKely peRfoRmaNt enougH. I'm not sURe oF oTHER rAmifications. maybe iT mAKEs Sense to bRing up ON tHe APparmor Ml?
 * jJohAnseN REads bAcksCRoLl to pickUp contEXt
<TyHicks> jjOhAnsen: dOn'T spEnd Time rEAdinG all of BackscroLl
<tyhICks> jjohansen: I'lL Summarize
<elopIO> kYROfA: i'm moVinG some integrAtioN TestS to a GEnEraL Suite, So we cAn PRoPErly filter.
<zyga-suse> jJoHansen: Hey, loNg time no see :)
<jdStrand> zyga-SUSE: I think I HearD "YeS, It is ready for yoU to reView"?
<jjohanSEn> hi zyga-Suse
<zYga-suse> jDstrand: hmM?
<ZYga-suse> jDstRanD: I tHinK IT's Ready now
<zyga-sUSE> jdsTrAnd: NB, thIs iS the codE wiThoUt aNy oVeRlayfs
<jdsTrand> 11:42 < jdsTrAnD> zYgA-suSe: it iS Already oN mY liSt. i'll Put it TOwards The op. i've sEeN cOMmiTs as recENt AS TodaY-- iS iT reaDy
up> PR snapd#4059 opened:tests: add  test  th atch ecks  cor e reverts on c o re d evices <Created by mvo 5> <h tt p s:// g it hub.c om/snap c or e / sna pd /p ull /4 0 59 >
<mv o>jdstran d: pleasedon 't  get me wron g ,I don't wa ntto be pushyoranythi ng , h a ppy t o h elp w it hth i s stuf f. but di nn e r nowr eally : ) <j dstr and> mvo: that wo u ld require change s to t he fo r m atondisk and t hu s req u ire jjo h an s e n 'si nput
<zyga-su se> jdstran d : a nd sma ll  gl u e that  uses  m k dir  when we wa nt t o mount s omethi n g but t a rget is  gone<ky rof a> e l op io , w il l  py t ho n3- m u nittestdi sc over-b - v - s  int egr atio n_tes ts" not run _ all _ th e  in tegra tiontest s,  incl udingthe p ac kages below?
<z yga- suse> jds tra nd : t he re'sl oads o f u nit  testsand one com pr e h e ns ive integration te st < el opio> No t unti l  t om o rrow
<ky ro fa>  elo p i o, is n'tt ha t how di scover wo rk s?
<jds tr and> m vo : c hec kinga nd c ompari ng the m times of everythingi s likely perf o rm a n te noug h.I'm not sur e of othe r ra m if ica t ions.  mayb ei tm akes sense to bring  u p on t he ap parmor ML?
 *  jjohansen r e ads back scro l lt o pickup conte xt
<t yhicks> jj o hansen:don't  spend t ime readi n g  all ofbac ksc rol l
< t y hi cks> jjohanse n :  I'l lsummari ze<elopio > k yro fa:  I' mmoving so me integ ra ti on  t est s toa  general  s uit e,  so  we c a n prop erlyfilt er .< zyg a-suse> jj o h anse n:  h ey,lon gtimeno s e e : )
<jdst rand> zyg a-s u se:Ith ink I h eard "yes, it  i s ready fo ryou  to re v i ew"?
<jj ohansen> hi zyga-suse
< z yga-sus e>jdstr and:  hmm?
<zy ga- suse>jds t rand:I thin k it' srea d y  now< z yg a-s us e> jdstran d :  NB , thi sis t he code  without any overl a yfs 
<jdstrand> 1 1:4 2 <j d st ran d >z yga -s u se: i t is already on  my list.I' l lput it tow a rds  t he op.I've se en co m mits as  recent a s today--  i s it r ead y
up> PR_snapd#4059 opened:_tests: add test that_checks core_reverts_on core_devices_<Created by mvo5>_<https://github.com/snapcore/snapd/pull/4059>
<mvo> jdstrand: please_don't get me wrong,_I don't want_to_be pushy or anything, happy to help wit hthis stuff. but dinner now really_:)
<jdstrand>_mvo: that_would_require_changes to the format on_disk and thus require jjohansen's_input
<zyga-suse> jdstrand:_and small glue that uses mkdir when we_want_to mount something_but target is gone
<kyrofa> elopio, will python3 -m unittest_discover -b -v -s integration_tests" not_run _all_ the_integration_tests,_including the packages below?
<zyga-suse>_jdstrand: there's loads of unit tests_and one comprehensive integration test
<elopio> Not_until tomorrow
<kyrofa> elopio, isn't that how discover_works?
<jdstrand> mvo: checking and comparing the_mtimes of everything is likely_performant enough._I'm not sure of other_ramifications. maybe it_makes sense_to bring up_on the apparmor ML?
 * jjohansen_reads backscroll to_pickup context
<tyhicks> jjohansen: don't spend time_reading_all of backscroll
<tyhicks>_jjohansen:_I'll_summarize
<elopio> kyrofa:_I'm moving some_integration_tests to_a_general suite, so we can properly_filter.
<zyga-suse>_jjohansen: hey, long time no see :)
<jdstrand>_zyga-suse: I think I_heard_"yes, it is ready_for you to review"?
<jjohansen> hi_zyga-suse
<zyga-suse> jdstrand: hmm?
<zyga-suse> jdstrand: I think_it's ready_now
<zyga-suse> jdstrand:_NB, this is the code without any overlayfs
<jdstrand> 11:42 < jdstrand>_zyga-suse: it is already on my_list. I'll put it_towards the_op._I've seen commits_as_recent as_today-- is it ready