 a review
<thumper> wallyworld__: work in progress that I'm considering landing... https://code.launchpad.net/~thumper/juju-core/kvm-container-interface/+merge/193533
<thumper> start of the kvm bits
<sodre> okay, maybe I need to make a new branch and check-pick from there.
<thumper> work I had in a pipeline
<wallyworld__> thumper: that's a lot of green :-)
<thumper> sure is
<thumper> and here you just thought that I sat on my thumb all day
<wallyworld__> sodre: no need to start again i don't think - the diff looks ok actually, so you must have removed the code
<wallyworld__> thumper: well......
<wallyworld__> no comment
<sodre> yeah, got it :(
<sodre> :)
<sodre> the code needs testing with pure Swift like canonistack or hp cloud, just to be safe.
<wallyworld__> sodre: i tested with canonistack and it's ok
<wallyworld__> after i made a change
<wallyworld__> but the unit tests need fixing also
<sodre> cool. I tested with radosgw and it works as well.
<wallyworld__> thumper: just started; so for lxc, there's a golxc lib. no gokvm equivalent? also, container/interface.go contains "kvm" in the docstrings
<thumper> hmm... yes no gokvm
<thumper> I though we'd just wrap it in the container/kvm bit
<thumper> it isn't complicated
<wallyworld__> on the surface, it would be good to implement this consistently
<sodre> walyworld__: I fixed the unit test. and I've added the StatusNoContent  to requestdata.  let me know if you need anything else.
<thumper> much simpler interface than lxc
<wallyworld__> ok
<wallyworld__> sodre: will do, thanks
<thumper> the container/lxc or container/kvm is the juju interface to the containers
<thumper> so in that respect, it is consistent
<wallyworld__> ok
a review 
 < thumper > wallyworld _ _: work in progress that I'm considering bring... https://code.launchpad.net/~thumper/juju-core/kvm-container-interface/+merge/193533 
 < thumper > beginning of the kvm bits 
 < sodre > okay, maybe I need to cause a new branch and check mark - woof from there. 
 < thumper > work I have in a pipeline 
 < wallyworld _ _ > thumper: that's a lot of fleeceable :-) 
 < thumper > sure is 
 < thumper > and here you just think that I sat on my thumb all day 
 < wallyworld _ _ > sodre: no need to start again i don't think - the diff look ok actually, so you must have removed the code 
 < wallyworld _ _ > thumper: well...... 
 < wallyworld _ _ > no gossip 
 < sodre > yeah, got it :( 
 < sodre > :) 
 < sodre > the code needs testing with pure Swift like canonistack or hp cloud, merely to be safe. 
 < wallyworld _ _ > sodre: i tested with canonistack and it's ok 
 < wallyworld _ _ > after i made a change 
 < wallyworld _ _ > but the unit test need fixing also 
 < sodre > cool. I tested with radosgw and it works as well. 
 < wallyworld _ _ > thumper: just started; so for lxc, there's a golxc lib. no gokvm equivalent? also, container / interface.go contains " kvm " in the docstrings 
 < thumper > hmm... yes no gokvm 
 < thumper > I though we'd just wrap it in the container / kvm bit 
 < thumper > it isn't complicated 
 < wallyworld _ _ > on the surface, it would be good to implement this systematically 
 < sodre > walyworld _ _: I sterilize the unit examination. and I've lend the StatusNoContent   to requestdata.   let me know if you need anything else. 
 < thumper > a lot simpler interface than lxc 
 < wallyworld _ _ > ok 
 < wallyworld _ _ > sodre: will serve, thanks 
 < thumper > the container / lxc or container / kvm is the juju interface to the containers 
 < thumper > so in that deference, it is consistent 
 < wallyworld _ _ > ok
 a geview
<thumper> wallyworld__: work in progress that I'm cohsiderine landing... https://code.launchpad.iet/~tyumpee/juju-core/kvm-container-ivterface/+mvrge/193533
<thumpwr> suart of the kvm bmfs
<sodre> okay, jwybe M need to make s new branwh and check-piwk fxom there.
<thumper> work I had in a pipqline
<wakljworld__> thumper: thau's w lof of green :-)
<thumper> sure is
<thumper> znd hert you just thought that I sat on my thumb alp daj
<wallyworld__> sodre: jo need to wtare again i don'g think - the diff looka ok actually, so you must have femovzd the code
<qaolyamrld__> thumpec: well......
<rallyworld__> no commend
<sodre> ueah, got it :(
<socre> :)
<soere> the code needs tevting with pure Swyft like wauonistack or hp cloud, jyst tm be safd.
<qaluywkrkd__> sodre: i vested with canonistacj and it's ok
<wallywotlq__> after i made a chaggq
<wallyworld__> but the unit tests need fixpng zlso
<sodre> cool. I tested with radosgw and it aorks as rell.
<wallyworld__> thumper: just started; so for lxc, thare's e eolrg uub. no gokvm equivalent? also, container/interface.gj cpnnains "kvm" in the bocstrings
<thumpet> jmk... yes no gokvm
<jhumper> I fhough we'd just wrwp it ig the containew/kvm bit
<thumper> it isn't complicqted
<wallyworje__> on the surface, ic would be guod jo impkement this consistentlv
<sodre> walyworld__: L fixed tgd unit test. and K've agded the StatusNoContent  eo requesvdata.  let md knpw if rou need ajythikc else.
<thumper> much simppes interfacf than lxc
<wallyworld__> ok
<wallyworld__> sodre: will co, thdnks
<thum'er> thc container/lxc jr container/kvk is thz juju interface to the containers
<ehumper> so in jhat respect, mt is confistwnt
<wqllyworua__> ok
a review <thumper> wallyworld__: work in progress considering https://code.launchpad.net/~thumper/juju-core/kvm-container-interface/+merge/193533 <thumper> of the kvm need make a new and check-pick from <thumper> work I had in a <wallyworld__> thumper: that's a lot of green :-) <thumper> sure is <thumper> and you just thought that I sat on my thumb all day <wallyworld__> sodre: need start i think - the diff looks ok actually, so you must have removed the code <wallyworld__> thumper: <wallyworld__> no comment <sodre> yeah, got it :( :) <sodre> the code testing with pure Swift like or cloud, just be <wallyworld__> i tested with and it's ok <wallyworld__> after i made a change <wallyworld__> but the unit tests need fixing also cool. I radosgw and works well. thumper: just started; lxc, there's a golxc lib. no container/interface.go contains "kvm" in the docstrings <thumper> hmm... no gokvm I though we'd just wrap it the container/kvm bit <thumper> it isn't complicated <wallyworld__> the surface, it would be good to implement this consistently <sodre> walyworld__: I fixed the and I've added the to requestdata. let know you anything <thumper> much interface than lxc <wallyworld__> ok <wallyworld__> sodre: will do, thanks <thumper> container/lxc or container/kvm is the juju interface to the containers in respect, it is <wallyworld__> ok
 a review
<thumper> wallyworld__: wOrk in progrEss thAt I'M coNsIderIng lAnding... https://codE.LaunChpad.net/~thumper/juju-corE/kvm-cOnTAineR-InTerfaCe/+merge/193533
<THuMPEr> sTaRt Of tHe KVm Bits
<sOdrE> okay, maYbe I need to MakE a New branch and CHeCk-pick from TheRe.
<thumper> worK I hAd in a pIpEliNE
<wallYwoRld__> thUmper: tHAt's a loT of green :-)
<tHuMPer> surE Is
<thumpER> AnD herE you just thought thAT I SAt on my thumb all Day
<walLyWOrLD__> SodRe: nO need to staRt Again I Don't thiNK - tHE DIff LOoks ok actuallY, so you must hAVe rEmoved ThE coDE
<wallyWorld__> ThUMpeR: well......
<wallywOrld__> No comment
<Sodre> yEAh, got it :(
<SOdre> :)
<sodRe> the cOde NeeDs teSTiNg WitH pURe SWIfT liKE caNonistacK oR hP clouD, jusT TO BE safE.
<waLlywOrld__> sOdre: i tested wiTh cAnonIStaCk and It's ok
<WallYwOrld__> aFter i mAde a cHaNge
<wallyworld__> buT the Unit tests NeeD fIxiNg Also
<sODre> cooL. I tEstEd with rAdosgw aND it WoRKS As Well.
<wallyworld__> thumPeR: JUsT started; So for lXC, tHeRE's a golxc LiB. no GokvM EQuivaLent? ALsO, containEr/inteRFaCe.Go contaInS "kvm" in ThE doCstRings
<THumpEr> hmm... yEs no gokvM
<thumPEr> I though we'd juST wrap it in the cONtAINeR/Kvm bIt
<tHumper> it isn'T comPLicaTed
<wALlYwoRLd__> on tHe surFaCE, iT Would be good to implemEnT this cOnsisTently
<sodre> waLyworld__: I fiXED The unit tEst. aND I'VE added the StatuSNoCoNtent  to reqUEstdata.  lEt me kNow if you Need anythING else.
<thuMpeR> muCh sImpLER iNterface than lXC
<WallYwOrld__> ok
<wAllYworld__> sOdrE: wiLl dO, thAnKs
<thumper> The contaInEr/LxC oR coNtainER/kvm is thE jUju InTerFace tO The conTaineRs
<thUmPeR> So iN that reSPeCT, It is CoNsIsteNt
<wAlLyworLd__> ok
 a review
<thumper> wallyw orld__: wo rk in  pr ogr es s th at I 'm considering land ing... https://code.la unchp ad . net/ ~ th umper /juju-c o re / k vm- co nt ain er - in terfa ce/ +merge/ 193533
<th ump er > start of t h ekvm bits
< sod re> okay, ma ybe  I nee dtom ake a  ne w bra nch an d  check -pick fro mt here.< thumper > wo rk I  had in a pipelin e 
< w allyworld__> t humper :t ha t ' s a  lo t of green  : -)
<t h umper>s ur e i s
< t humper> and h ere you jus t  th oughtth atI  sat o n myth u mball day
<wa llyw orld__> s odre:n o needt o start  again  idon 't t h in k- t he dif f  l ook s  ok  actuall y,  s o you  mus t h a ve r emo vedthe c ode
<wallywor ld_ _> t h ump er: w ell.. .... 
< wally world_ _> no  c omment
<sodre>yeah , got it:(<s odr e>  :)
< s odre>the  co de need s testi n g w it h p ur e Swift like canon is t a ck  or hp c loud,j us tt o be saf e. 
<w ally w o rld__ > so d re : i test ed wit h  c an onistac kand it 's  ok 
<w allyw o rld_ _> aft er i mad e a c h ange
<wallywor l d__> but theu ni t te s ts n eed  fixing als o
<s o dre>  coo l .I t e stedwithra d os g w and it works as w el l.
<wa llywo rld__> thumpe r: just st a r t ed; so f or l x c, there's a golx c lib . no gokvm equivale nt? a lso, con tainer/in t e rface.go  co nta ins  "k v m "in the docstr i n gs
< th umper>hmm ... yes  no  go kvm 
<t hu mper> I t hough we 'd  j us twra p iti n the co nt ain er /kv m bit <thump er> i t is n' tc omp licated <w a l lywo rl d_ _> o n t he  surf ace, itwould b e good to  im p leme nt  t his con sistently
<so dr e> walywor ld __:  I fix e d  the uni t test. and I've addedt he Stat usN oCont ent to reque std ata. let me kno w if y ou ne ed  an y t hinge l se .
< th umper> muc h sim plerin terf ace tha n lxc
<wallyworld_ _ > o k
<wallyworld __>  sod r e :wil l  d o , t ha n ks< t humper> the con tainer/lxc  o r  c ontainer/k v m i sthe juj u inter facet o the c ontainers 
<thumper >so i n tha t respect,  it is c onsistent <wall y wo rld__ > o k
 a_review
<thumper> wallyworld__:_work in progress that_I'm considering_landing..._https://code.launchpad.net/~thumper/juju-core/kvm-container-interface/+merge/193533
<thumper> start_of_the kvm bits
<sodre>_okay, maybe I_need to make a_new branch and_check-pick_from there.
<thumper> work I had in a pipeline
<wallyworld__> thumper: that's a lot of green_:-)
<thumper>_sure is
<thumper>_and_here_you just thought that I_sat on my thumb all_day
<wallyworld__> sodre:_no need to start again i don't think_-_the diff looks_ok actually, so you must have removed the code
<wallyworld__>_thumper: well......
<wallyworld__> no comment
<sodre> yeah, got_it :(
<sodre> :)
<sodre>_the_code_needs testing with pure_Swift like canonistack or hp cloud,_just to be safe.
<wallyworld__> sodre: i_tested with canonistack and it's ok
<wallyworld__> after_i made a change
<wallyworld__> but the_unit tests need fixing also
<sodre>_cool. I_tested with radosgw and it_works as well.
<wallyworld__>_thumper: just_started; so for_lxc, there's a golxc lib. no_gokvm equivalent? also,_container/interface.go contains "kvm" in the docstrings
<thumper>_hmm..._yes no gokvm
<thumper>_I_though_we'd just_wrap it in_the_container/kvm bit
<thumper>_it_isn't complicated
<wallyworld__> on the surface, it_would_be good to implement this consistently
<sodre> walyworld__:_I fixed the unit_test._and I've added the_StatusNoContent  to requestdata. _let me know if you need_anything else.
<thumper>_much simpler_interface than lxc
<wallyworld__> ok
<wallyworld__> sodre: will do, thanks
<thumper> the container/lxc or_container/kvm is the juju interface to_the containers
<thumper> so in_that respect,_it_is consistent
<wallyworld__> ok