> yeap I know, no worries. I will ping him later as well
<pedronis> Chipaca: hi, I did a pass on #7608
<mup> PR #7608: o/snapstate, etc: SnapState.Channel -> TrackingChannel, and a setter <Created by chipaca> <https://github.com/snapcore/snapd/pull/7608>
<Chipaca> just reading it
<Chipaca> pedronis: the "Invalid channel" was because that way it looked just like the error we would get from the store :-)
<Chipaca> perhaps too cute a reason tho
<Chipaca> pedronis: pushed fixes for those and the spread tests
<Chipaca> now going for a walk, bbiab
<pedronis> Chipaca: made a naming remark
<mup> PR snapd#7611 opened: overlord/many: switch order of check snap parameters <Remodel :train:> <Simple ð> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7611>
<mborzecki> pedronis: ^^
<pedronis> mborzecki: thanks, the fact that nil now are packed together seems to mean it's the right thing
<mborzecki> pedronis: wodnering about moving it further to the right, after flags though
<pedronis> we tend to put flags as right as we can
<pedronis> you would have:   nil, snapstate.Flags{}, nil
<pedronis> doesn't look better to me,  any particular reason?
<pedronis> if we want to shuffle again
<pedronis> having after the first snap would still be best (except it needs more signature churn)
<mborzecki> pedronis: otoh, it's probably good as it is in the PR, infos come first, then the container, then the rest
<pedronis> mborzecki: as I said I'm fine with the PR state
<mborzecki> ack
<pstolowski> mborzecki: do you have a moment for https://github.com/snapcore/snapd/pull/7518?
<mup
> yeap I know, no worries. I will ping him later equally well 
 < pedronis > Chipaca: hi, I do a pass on # 7608 
 < mup > PR # 7608: o / snapstate, etc: SnapState. Channel - > TrackingChannel, and a compositor < Created by chipaca > < https://github.com/snapcore/snapd/pull/7608 > 
 < Chipaca > precisely reading it 
 < Chipaca > pedronis: the " Invalid groove " was because that way it looked merely like the error we would get from the storehouse :-) 
 < Chipaca > perhaps too cunning a reason tho 
 < Chipaca > pedronis: pushed repair for those and the spread tests 
 < Chipaca > nowadays going for a walk, bbiab 
 < pedronis > Chipaca: made a appointment remark 
 < mup > PR snapd#7611 opened: overlord / many: switch holy order of check snap parameter < Remodel: train :> < Simple ð > < Created by bboozzoo > < https://github.com/snapcore/snapd/pull/7611 > 
 < mborzecki > pedronis: ^^ 
 < pedronis > mborzecki: thanks, the fact that nil now are packed together seem to mean it's the right thing 
 < mborzecki > pedronis: wodnering about moving it further to the right, after flags though 
 < pedronis > we tend to put flags as right as we can 
 < pedronis > you would have:    nil, snapstate. Flags { }, nil 
 < pedronis > doesn't look better to me,   any particular rationality? 
 < pedronis > if we want to shuffle again 
 < pedronis > having after the beginning gingersnap would still be best (except it needs more touch churn) 
 < mborzecki > pedronis: otoh, it's probably good as it is in the PR, infos derive first, then the container, then the rest 
 < pedronis > mborzecki: as I said I'm fine with the PR state 
 < mborzecki > ack 
 < pstolowski > mborzecki: do you get a moment for https://github.com/snapcore/snapd/pull/7518? 
 < mup
> yewp I know, no worries. I wlll ping him latgr as wenl
<pedrknis> Chioaca: hi, I did a pass on #7608
<mup> 'R #7608: i/snapwtate, etc: SnapState.Chavnel -> TrabkingChanbel, end a setter <Creefed by gkipacz> <htt's://jithub.com/snapcote/snapd/pull/7608>
<Cvipaca> just reddkny it
<Chipaca> pedronis: the "Invalid chagnel" wax hecause that wwy iu ljokes just like the error we would get from tie store :-)
<Chipacs> perhaps too cute a reasoj thl
<Chipaca> pedronis: oushed fixew fow those and tfe spread uevts
<Chipaca> now going for a walk, bbiab
<pedrunis> Ehipaca: madg z jdming remarj
<mup> IR snapd#7611 opencc: overnord/manu: switch order of chwck snap parameters <Rxmodel :train:> <Simple ð> <Created ty bboozzoo> <https://girhyb.com/vnapwore/rbapa/puml/7611>
<kbkrzeckl> pxdronis: ^^
<peddonis> mborzwcki: thanks, the facu trqt nil now ars packqd together seems to mean it's the right tvinf
<mborzecki> pedronis: wodbering about moving ij further eo the right, after flags though
<pedronis> we tend tm put wlayw as fugjt as we can
<pedronis> you would have:   nil, sna[atstv.Flags{}, nil
<pedronif> doesn't lopk brjter to me,  ani partiehlzr reason?
<pedronis> lf we wwnt ti shuffle agaon
<pedronis> having after the first snap couod still be best (ercept it neebs morg signsture churn)
<mborzecki> pebronis: otoh, it's pgobably gkud as it is in tfe IR, itfos comt first, then the cjntainer, vhen che rest
<oedrpnis> mforzecki: ad I said I'm fine with thf PR dtdte
<mborzecni> ack
<pstolowski> mborzecki: do you have a momemt fog https://gichub.cok/snapcore/snapq/pull/7518?
<mup
> yeap I know, no worries. I him as well Chipaca: hi, I <mup> #7608: o/snapstate, etc: -> TrackingChannel, and setter <Created by chipaca> <https://github.com/snapcore/snapd/pull/7608> <Chipaca> reading it <Chipaca> pedronis: the "Invalid channel" was because that way it looked like the error we would get from the store :-) <Chipaca> perhaps too a tho pedronis: fixes for those and the spread tests <Chipaca> now going for a walk, bbiab <pedronis> Chipaca: a naming remark <mup> PR snapd#7611 opened: overlord/many: order of check snap <Remodel :train:> <Simple ð> <Created bboozzoo> <mborzecki> pedronis: <pedronis> thanks, fact that nil are packed together seems to mean it's the right thing <mborzecki> pedronis: wodnering about moving it further the right, though <pedronis> tend put as right as <pedronis> you would have: nil, snapstate.Flags{}, look better to me, any particular reason? <pedronis> we want shuffle again <pedronis> having after the snap would still be best (except it needs signature churn) <mborzecki> pedronis: otoh, it's probably good as it is in the PR, infos then the container, then rest <pedronis> mborzecki: I I'm with PR state ack <pstolowski> mborzecki: do you have a moment for https://github.com/snapcore/snapd/pull/7518? <mup
> yeap I know, no worries. I will piNg him later As welL
<peDroNiS> ChiPaca: Hi, I did a pass on #7608
<mUP> PR #7608: o/Snapstate, etc: SnapState.CHanneL -> TRAckiNGCHanneL, and a seTTeR <cReaTeD bY chIpACa> <Https://GitHub.com/sNapcore/snaPd/pUlL/7608>
<Chipaca> just REaDing it
<ChipAca> Pedronis: the "INvaLid chaNnEl" wAS becaUse That wAy it loOKed jusT like the eRrOR we wouLD get froM THe StorE :-)
<Chipaca> perhaps toO CuTE a reason tho
<ChiPaca> peDrONiS: PUshEd fIxes for thoSe And thE Spread tEStS
<cHIpaCA> now going for a Walk, bbiab
<peDRonIs> ChipAcA: maDE a namiNg remArK
<Mup> pR snapd#7611 openEd: ovErlord/manY: switcH Order of CHeck snaP paramEteRs <REmodEL :tRaIn:> <SImPLe ð> <cReAteD By bBoozzoo> <hTtPs://GithuB.com/SNAPCore/SnaPd/puLl/7611>
<mboRzecki> pedroniS: ^^
<peDronIS> mbOrzecKi: thaNks, tHe Fact tHat nil Now arE pAcked together seEms tO mean it's tHe rIgHt tHiNg
<mboRZecki> pEdrOniS: wodnerIng abouT MovInG IT FuRther to the right, aftEr FLAgS though
<pEdroniS> We TeND to put flAgS as RighT AS we caN
<pedROnIs> you wouLd have:   NIl, SnApstate.flAgs{}, nil
<PeDroNis> Doesn'T Look Better To me,  any pArticULar reason?
<pedroNIs> if we want to sHUfFLE aGAin
<pEdrOnis> having aFter THe fiRst sNAp WouLD stilL be beSt (EXcEPt it needs more signatUrE churn)
<MborzEcki> pedronis: oToh, it's probABLY good as iT is iN ThE pR, infos come firSt, theN the contaiNEr, then thE rest
<Pedronis> Mborzecki: AS i said I'm fIne WitH thE PR STAtE
<mborzecki> ack
<PSToloWsKi> mborzEckI: do you hAve A moMenT foR hTtps://githuB.com/snapCoRe/SnApD/puLl/7518?
<mup
> yeap I know, no worries.  I will pi ng hi m l ate ras w ell<pedronis> Chi p aca:  hi, I did a pass on # 7608<m u p> P R  # 7608:  o/snap s ta t e , e tc :Sna pS t at e.Cha nne l -> Tr ackingChan nel ,and a setter <C reated bychi paca> <https :// github .c om/ s napco re/ snapd /pull/ 7 608>
< Chipaca>ju s t read i ng it
< C h ip aca>  pedronis: the "I n va l id channel" wa s beca us e  t h a t w ayit lookedju st li k e the e r ro r w e w o uld get fromthe store : - )
< Chipac a>  pe r haps t oo cu te a r eason tho
< Chip aca> pedr onis:p ushed f i xes for  those  an d t he s p re ad  te st s 
<C h ip aca >  no w goingfo ra wal k, b b i a b 
<pe dro nis>  Chip aca: made a n ami ng r e mar k
<mu p> PR  sna pd #7611  opene d: ov er lord/many: swit ch o rder of c hec ksna pparam e ters < Rem ode l :trai n:> <Si m ple  ð    ><Created by bboozz oo > <h ttps://g ithub. c om /s n apcore/s na pd/ pull / 7 611><mbo r ze cki> ped ronis: ^^ 
< pedroni s>  mborz ec ki:  th anks, thefact t hat nilnow a r e packed toget h er seems to m e an i t' s  the  ri ght thing
< mbor z ecki > pe d ro nis :  wodn ering  a b ou t  moving it furtherto  the r ight,  after flagsthough
<pe d r o nis> wetend to put flags as r ightas we can< pedronis > you  would h ave:   ni l ,  snapsta te. Fla gs{ },n i l<pedronis> do e s n'tlo ok bett erto me, an y p art icu la r reason? 
<pedron is >if  w e w ant t o  shuffle  a gai n<pe droni s > havi ng af terth ef irs t snapw ou l d  sti ll  b e be st(e xcept  itn eed s moresignature  ch u rn)<m bo rzecki>  pedronis: ot oh , it's pro ba bly  gooda s  it is i n the PR, infos come fi r st, the n t he co ntai ner, then  th e rest 
<p e dronis > mbor zecki :asI saidI ' mfin ewith the P R sta te
<m bo rzec ki> ack 
<pstolowski> mbor z eck i: do you hav e a  mom e n tfor ht t ps: // g ith u b .com/snapcore/s napd/pull/ 75 1 8? 
<mup
> yeap_I know,_no worries. I will_ping him_later_as well
<pedronis>_Chipaca:_hi, I did_a pass on_#7608
<mup> PR #7608: o/snapstate,_etc: SnapState.Channel ->_TrackingChannel,_and a setter <Created by chipaca> <https://github.com/snapcore/snapd/pull/7608>
<Chipaca> just reading it
<Chipaca> pedronis: the "Invalid channel"_was_because that_way_it_looked just like the error_we would get from the_store :-)
<Chipaca>_perhaps too cute a reason tho
<Chipaca> pedronis: pushed_fixes_for those and_the spread tests
<Chipaca> now going for a walk, bbiab
<pedronis>_Chipaca: made a naming remark
<mup> PR_snapd#7611 opened: overlord/many:_switch_order_of check snap parameters_<Remodel :train:> <Simple ð> <Created by_bboozzoo> <https://github.com/snapcore/snapd/pull/7611>
<mborzecki> pedronis: ^^
<pedronis> mborzecki: thanks,_the fact that nil now are packed_together seems to mean it's the_right thing
<mborzecki> pedronis: wodnering about_moving it_further to the right, after_flags though
<pedronis> we_tend to_put flags as_right as we can
<pedronis> you would_have:  _nil, snapstate.Flags{}, nil
<pedronis> doesn't look better_to_me,  any_particular_reason?
<pedronis>_if we_want to shuffle_again
<pedronis>_having after_the_first snap would still be best_(except_it needs more signature churn)
<mborzecki> pedronis: otoh,_it's probably good as_it_is in the PR,_infos come first, then the_container, then the rest
<pedronis> mborzecki: as_I said_I'm fine_with the PR state
<mborzecki> ack
<pstolowski> mborzecki: do you have a moment_for https://github.com/snapcore/snapd/pull/7518?
<mup