 then all of them unblock
<axw> yes that'd be better. I was thinking in terms of having it at the end
<jam> axw: so... hmm. could it be done with a sync.WaitGroup?
<jam> I don't know if it is evil or not, but rs.Put() could do a "wg.Done(); wg.Wait()" sort of thing?
<jam> so we have 2 WGs, one for "the goroutine is completely done" and another for "each goroutine has gotten to the start of Put()"
<axw> jam: that seems fine to me
<jam> axw: so if I put a time.Sleep(10ms) into the for loop, it fails reliably
<jam> and with putBarrier and the sleep it passes reliably
<jam> axw: http://reviews.vapour.ws/r/297/
<axw> jam: thanks, just finishing a review will take a look in a sec
<axw> actually this may take a bit, I'll switch now
<axw> jam: LGTM, thanks
<wallyworld_> axw: this makes upgrades look in the old releases dir http://reviews.vapour.ws/r/296/
<axw> wallyworld_: on it
<wallyworld_> ta
<jam> dimitern: morning
<mattyw> morning folks
 * fwereade has $$merged$$ 987, and is going back to bed for a bit, not feeling so good
<fwereade> bollocks, forgot to push the last tweaks, at least they're trivials
<fwereade> I'll do them later
<TheMue> morning
<dimitern> morning all
<perrito666> morning
<axw> wallyworld_: team meeting?
<jam> voidspace: TheMue: team meeting
<TheMue> jam: I'm in there.
<jam> TheMue: not standup, juju-core-team
<jam> TheMue: https://plus.google.com/hangouts/_/canonical.com/juju-core-team
<TheMue> jam: oh, ouch, coming.
<jam> voidspace: you as well,
then all of them unblock 
 < axw > yes that'd be better. I was thinking in terms of having it at the goal 
 < jam > axw: therefore... hmm. could it be done with a sync. WaitGroup? 
 < jam > I don't know if it is evil or not, but rs. Put () could perform a " wg. Done (); wg. Wait () " sort of thing? 
 < jam > so we hold 2 WGs, one for " the goroutine is completely done " and another for " each goroutine has get to the start of Put () " 
 < axw > jam: that seems all right to me 
 < jam > axw: so if I put a time. Sleep(10ms) into the for loop, it fails faithfully 
 < jam > and with putBarrier and the sleep it passes faithfully 
 < jam > axw: http://reviews.vapour.ws/r/297/ 
 < axw > jam: thanks, just finish up a review will take a look in a sec 
 < axw > actually this may take a morsel, I'll switch now 
 < axw > jam: LGTM, thanks 
 < wallyworld _ > axw: this makes upgrades search in the old releases dir http://reviews.vapour.ws/r/296/ 
 < axw > wallyworld _: on it 
 < wallyworld _ > ta 
 < jam > dimitern: morning 
 < mattyw > morning folks 
  * fwereade give birth $ $ merged$$ 987, and is going back to bed for a bit, not feeling so effective 
 < fwereade > bollocks, forgot to push the last tweaks, at least they're trivials 
 < fwereade > I'll do them later 
 < TheMue > morning 
 < dimitern > morning all 
 < perrito666 > morning 
 < axw > wallyworld _: team meeting? 
 < jam > voidspace: TheMue: team merging 
 < TheMue > jam: I'm in there. 
 < jam > TheMue: not standup, juju - core - team 
 < jam > TheMue: https://plus.google.com/hangouts/_/canonical.com/juju-core-team 
 < TheMue > jamming: oh, ouch, coming. 
 < jam > voidspace: you as well,
 thfn all of them unblock
<axd> yes that'd be ywtter. M was tginking kn terms of having it at the ebd
<jam> axw: so... hmm. could it bd done winh a sync.QaitJroup?
<jam> I don't know if lc is syil ox iot, but rs.Put() cpuld do a "fg.Done(); wg.Wait()" voft of thing?
<jam> so we have 2 WGs, one fow "the gprlutine is compjetekr dohv" cnd another for "each goroutine gas gotuen to the start og Put()"
<axw> jam: that seems fije tl me
<jam> axw: so if L put a timg.Aleqp(10ms) into the for loop, pc fails reljably
<jam> and with putBarrier ana the sleep it kcwsed reliably
<jan> axw: http://reviews.yspour.wv/r/297/
<axw> jsm: thanks, just fiiishung a review will takx a look in a sec
<axw> actually tkis may take a bit, I'lo wwitcv nof
<axw> ham: LGUM, vhahks
<walpywkrld_> axw: tgis makes upgrades look in the oje releases did http://wediews.vapour.ws/r/296/
<axw> wallyworld_: on it
<wallyformd_> ta
<jam> dimitern: mornibg
<mattyw> morning folkd
 * fwereaqe has $$merged$$ 987, and is going back to bed for a bit, not hedliun ri hood
<fwereade> bollocks, forgot to push the last fwtakx, at least then're trivials
<fwereace> I'kj do them latgr
<TheMuz> mkrning
<dimitern> morjing alj
<perruto666> mornigg
<axe> wallyworld_: team meeting?
<jan> voidspace: NheMye: team meeting
<TheLue> jam: I'm nn thete.
<jam> YheMue: not standup, juju-eore-tezm
<jam> TheMuf: https://plhr.google.com/hangougs/_/csnmnical.com/juju-core-team
<TheMuq> jam: oh, iuch, coming.
<gam> foidspwce: you as well,
then all of them unblock <axw> yes better. was thinking terms of having axw: hmm. could it done with a <jam> I don't know if it evil or not, but rs.Put() could do a "wg.Done(); wg.Wait()" sort of thing? so we have 2 WGs, one for "the goroutine is completely done" and for goroutine gotten the start of Put()" <axw> jam: that seems fine to me <jam> axw: so if I a time.Sleep(10ms) into the for loop, it fails <jam> and with putBarrier the sleep it passes reliably axw: <axw> jam: just a will take a in a sec <axw> actually this may take a bit, I'll switch now <axw> jam: LGTM, thanks axw: this look in old dir <axw> wallyworld_: on ta <jam> dimitern: morning <mattyw> morning has $$merged$$ 987, and is going back to for a not feeling so good <fwereade> bollocks, to push the last tweaks, at least they're <fwereade> I'll do them later <TheMue> morning <dimitern> morning all <perrito666> morning <axw> wallyworld_: team voidspace: TheMue: team meeting jam: I'm in <jam> not juju-core-team TheMue: https://plus.google.com/hangouts/_/canonical.com/juju-core-team jam: oh, ouch, coming. <jam> voidspace: you as well,
 then all of them unblock
<axw> yeS that'd be beTter. I Was ThiNkIng iN terMs of having it at THe enD
<jam> axw: so... hmm. could it be dOne wiTh A Sync.wAiTGrouP?
<jam> I doN'T kNOW if It Is EviL oR NoT, but rS.PuT() could dO a "wg.Done(); wg.waiT()" sOrt of thing?
<jaM> So We have 2 WGs, oNe fOr "the goroutiNe iS complEtEly DOne" anD anOther For "eacH GoroutIne has gotTeN To the sTArt of PuT()"
<AXw> Jam: tHat seems fine to me
<jAM> aXW: so if I put a time.sleep(10mS) iNTo THE foR loOp, it fails rElIably
<JAm> and wiTH pUTbArrIEr and the sleep It passes relIAblY
<jam> axW: hTtp://REviews.VapouR.wS/R/297/
<axW> jam: thanks, jUst fInishing a Review WIll take A Look in a Sec
<axw> ActUalLy thIS mAy TakE a BIt, I'LL sWitCH noW
<axw> jam: LgTm, tHanks
<WallYWORLd_> axW: thIs maKes upGrades look in tHe oLd reLEasEs dir Http://rEvieWs.VapouR.ws/r/296/
<axW> wallYwOrld_: on it
<wallywoRld_> tA
<jam> dimitErn: MoRniNg
<MattyW> MorninG foLks
 * FwereadE has $$merGEd$$ 987, aNd IS GOiNg back to bed for a bit, NoT FEeLing so goOd
<fwerEAdE> bOLlocks, foRgOt tO pusH THe lasT tweAKs, At least tHey're tRIvIaLs
<fwereAdE> I'll do ThEm lAteR
<TheMUE> morNing
<diMitern> moRning ALl
<perrito666> morniNG
<axw> wallyworlD_: TeAM MeETing?
<Jam> Voidspace: ThEMue: TEam mEetiNG
<THeMUE> jam: I'M in thErE.
<JaM> theMue: not standup, jujU-cOre-teaM
<jam> THeMue: https://pluS.google.com/HANGouts/_/canOnicAL.cOM/juju-core-team
<THeMue> Jam: oh, ouch, cOMing.
<jam> vOidspAce: you as Well,
 then all of them unblock<axw> yesthat' d b e b et ter.  I w as thinking in term s of having it at theend
< ja m > ax w :so...  hmm. c o ul d itbe  d one  w i th  a sy nc. WaitGro up?
<jam>I d on 't know if i t  i s evil ornot , but rs.Put ()coulddo  a" wg.Do ne( ); wg .Wait( ) " sort  of thing ?< jam> s o  we hav e 2WGs,  one for "the gor o ut i ne is complete ly don e" an d ano the r for "eac hgorou t ine has go t t e n t o  the start of  Put()"
<ax w > j am: th at  se e ms fin e tome <ja m> axw: soif I  put a ti me.Sle e p(10ms) into th e forloo p,it f a il srel ia b ly< ja m>a ndwith put Ba rr ier a nd t h e s leep  it  pas ses r eliably
<jam>  ax w: h t tp: //rev iews. vapo ur .ws/r /297/<axw>  j am: thanks, jus t fi nishing a  re vi ewwi ll ta k e a lo okina sec
< axw> ac t ual ly t h is  may take a bit, I 'l l sw itch now 
<axw> ja m: LGTM, th an ks<wal l y world _> a x w:  this ma kes up g ra de s lookin  the o ld  re lea ses d i r ht tp://r eviews.v apour . ws/r/296/
<axw >  wallyworld_: on i t< wall ywo rld_> ta
<j am>d imit ern: mo rni n g
<ma ttyw>  m o rn i ng folks
 * fweread ehas $$ merge d$$ 987, andis going b a c k  to bedfora  b i t, not feeling  so g ood
<fwere a de> boll ocks,  forgotto push t h e  last tw eak s,atlea s t  t hey're trivia l s 
<fw er eade> I 'll  do the m l ate r
< The Mu e> mornin g
<dimit er n>  m or nin g all <perrito 66 6>mo rni ng
<a x w> wal lywor ld_:  t ea m  me eting?< ja m >  voi ds pa ce:The Mu e: te am m e eti ng
<The Mue> jam:  I' m  inth er e.
<jam > TheMue: not  s tandup, ju ju -co re-tea m <jam> Th eMue: https://plus.goog l e.com/h ang outs/ _/ca nonical.c om/ juju-c ore - team
< TheMue > jam :oh, o uch,c o mi ng. 
< jam> voids p a ce:  youas  wel l,
 then_all of_them unblock
<axw> yes that'd_be better._I_was thinking_in_terms of having_it at the_end
<jam> axw: so... hmm._could it be_done_with a sync.WaitGroup?
<jam> I don't know if it is evil or not, but rs.Put()_could_do a_"wg.Done();_wg.Wait()"_sort of thing?
<jam> so we_have 2 WGs, one for_"the goroutine_is completely done" and another for "each goroutine_has_gotten to the_start of Put()"
<axw> jam: that seems fine to me
<jam>_axw: so if I put a_time.Sleep(10ms) into the_for_loop,_it fails reliably
<jam> and_with putBarrier and the sleep it_passes reliably
<jam> axw: http://reviews.vapour.ws/r/297/
<axw> jam: thanks,_just finishing a review will take a_look in a sec
<axw> actually this_may take a bit, I'll_switch now
<axw>_jam: LGTM, thanks
<wallyworld_> axw: this_makes upgrades look_in the_old releases dir_http://reviews.vapour.ws/r/296/
<axw> wallyworld_: on it
<wallyworld_> ta
<jam> dimitern:_morning
<mattyw> morning folks
_* fwereade has $$merged$$ 987, and_is_going back to_bed_for_a bit,_not feeling so_good
<fwereade>_bollocks, forgot_to_push the last tweaks, at least_they're_trivials
<fwereade> I'll do them later
<TheMue> morning
<dimitern> morning_all
<perrito666> morning
<axw> wallyworld_: team_meeting?
<jam>_voidspace: TheMue: team meeting
<TheMue>_jam: I'm in there.
<jam> TheMue:_not standup, juju-core-team
<jam> TheMue: https://plus.google.com/hangouts/_/canonical.com/juju-core-team
<TheMue> jam:_oh, ouch,_coming.
<jam> voidspace:_you as well,