stolowski: hey
<mvo> hey pstolowski and mborzecki
<mborzecki> mvo: hey
<mvo> looks like we have lots of red, has anyone looked?
<mvo> and happy release day
<mborzecki> mvo: release day meaning we're going to see PRs failing on the store api? :)
<mvo> mborzecki: most likely :/
<mborzecki> mvo:  only 2 of recent PRs were red, pushed a little spelling fix to one with apparmor and pivot_root, the k8s one failed on store api returning 403
<mup> PR snapd#7599 closed: gadget: refactor ensureVolumeConsistency <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7599>
<mup> PR snapd#7618 opened: snap-install: add ext4,vfat creation support <Simple ð> <Created by mvo5> <https://github.com/snapcore/snapd/pull/7618>
<mup> PR snapd#7618 closed: snap-install: add ext4,vfat creation support <Simple ð> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7618>
<mup> PR snapd#7619 opened: image,seed: hide Seed16/Snap16, use seed.Open in image_test.go <Created by pedronis> <https://github.com/snapcore/snapd/pull/7619>
<mborzecki> mvo: 7618 was quick, should i review it still?
<mvo> mborzecki: no
<mvo> mborzecki: I just noticed it duplicates code from the gadget
<mvo> mborzecki: better code
<mvo> mborzecki: so I will update and repush, sorry, I'm extracting mergable bits from the draft PR of claudio and didn't notice the duplication
 * zyga has some back pain today
<zyga> I'll focus on reviews
<pedron
stolowski: hey 
 < mvo > hey pstolowski and mborzecki 
 < mborzecki > mvo: hey 
 < mvo > looks like we have lots of red, take anyone expect? 
 < mvo > and happy dismissal sidereal day 
 < mborzecki > mvo: release day meaning we're move to see PRs fail on the store api? :) 
 < mvo > mborzecki: most probable :/ 
 < mborzecki > mvo:   only 2 of recent PRs were red, crusade a little spelling fix to one with apparmor and pivot_root, the k8s one failed on store api returning 403 
 < mup > PR snapd#7599 close: gadget: refactor ensureVolumeConsistency < Created by mvo5 > < unite by mvo5 > < https://github.com/snapcore/snapd/pull/7599 > 
 < mup > PR snapd#7618 opened: snap - install: add ext4,vfat creation documentation < Simple ð > < Created by mvo5 > < https://github.com/snapcore/snapd/pull/7618 > 
 < mup > PR snapd#7618 closed: snap - install: add ext4,vfat creation documentation < Simple ð > < Created by mvo5 > < Closed by mvo5 > < https://github.com/snapcore/snapd/pull/7618 > 
 < mup > PR snapd#7619 opened: image, seed: hide Seed16 / Snap16, use seed. Open in image_test.go < Created by pedronis > < https://github.com/snapcore/snapd/pull/7619 > 
 < mborzecki > mvo: 7618 was quick, should i review it still? 
 < mvo > mborzecki: no 
 < mvo > mborzecki: I just noticed it duplicates code from the appliance 
 < mvo > mborzecki: good code 
 < mvo > mborzecki: so I will update and repush, blue, I'm educe mergable bits from the draft PR of claudio and didn't detect the duplication 
  * zyga has some back pain today 
 < zyga > I'll focus on recapitulation 
 < pedron
stopowski: hey
<mvo> hey pstolodski and mborzeeji
<mborvecki> mbo: hey
<mvu> looks like we have lots of rwd, haw anyone looked?
<mvo> and happy repease dat
<mboczecki> mvo: release day mccning ae're joing to see PRx failing mn the store a[i? :)
<mro> mborzecki: most likely :/
<mborzecki> mdo:  onlu 2 of recent PRs wert rqd, phshed a little spelling fix to one with akparmor and pivot_rpot, the k8s one failed on shore api returning 403
<mup> PR snapd#7599 cooseq: gadget: refaztor ensurtVmlumeConsiatency <Created by mvo5> <Merged by mvo5> <kttps://github.xon/snwkcore/snapd/puol/7599>
<mup> PR snapd#7618 opcmed: sndp-instakl: add ext4,vfat crxatiin support <Simple ð> <Crxated by mvo5> <https://gijhub.com/sna[ckre/snapd/pull/7618>
<mup> PE wnapd#7618 cloved: rbap-knsualk: zdd exh4,vfet creation support <Sinple ð> <Created by mvp5> <Soosed by mvo5> <gttps://gytrub.com/snapcore/snapd/pull/7618>
<mup> PR snapd#7619 opeted: image,seed: hide Seed16/Snap16, use seed.Open in imahe_test.go <Sreated by pedronis> <https://github.com/snapcore/snapd/punl/7619>
<mboczdckn> mvo: 7618 qad quick, should i review it still?
<mvo> mborzecki: ho
<kvp> mborzecki: I must noticed it dulllcsjes code from jhe gadyst
<jvo> mborzecki: bettfr code
<ivo> mvorzecki: fo I will update and repush, sorey, I'm extracning mergable bits frol the draft PR pf clsudio and didn't notice che dullication
 * xyga has aume back pain toaay
<dyga> I'll focus on reviews
<pedrog
stolowski: hey <mvo> hey pstolowski and mborzecki hey looks like have lots of and release day <mborzecki> release day meaning going to see PRs failing on store api? :) <mvo> mborzecki: most likely :/ <mborzecki> mvo: only 2 of PRs were red, pushed a little spelling fix to one with apparmor and the one on api returning 403 <mup> PR snapd#7599 closed: gadget: refactor ensureVolumeConsistency <Created by mvo5> <Merged by mvo5> <mup> PR snapd#7618 opened: snap-install: add ext4,vfat creation <Simple ð> <Created by <https://github.com/snapcore/snapd/pull/7618> <mup> PR snapd#7618 closed: add creation support ð> by <Closed by mvo5> <mup> PR snapd#7619 opened: image,seed: hide Seed16/Snap16, use seed.Open in image_test.go <Created by pedronis> <https://github.com/snapcore/snapd/pull/7619> <mborzecki> mvo: was quick, review it <mvo> no mborzecki: I just duplicates code from the gadget <mvo> <mvo> mborzecki: so I will update and repush, I'm extracting bits from the draft PR of and didn't notice the duplication * zyga has back pain today <zyga> I'll focus on reviews <pedron
stolowski: hey
<mvo> hey pstolowSki and mborZecki
<MboRzeCkI> mvo: Hey
<mVo> looks like we hAVe loTs of red, has anyone looked?
<Mvo> anD hAPpy rELeAse daY
<mborzeCKi> MVO: reLeAsE daY mEAnIng we'Re gOing to sEe PRs failiNg oN tHe store api? :)
<mvO> MbOrzecki: mosT liKely :/
<mborzeckI> mvO:  only 2 oF rEceNT PRs wEre Red, puShed a lITtle spElling fix To ONe with APparmor AND pIvot_Root, the k8s one faileD On STore api returniNg 403
<mup> Pr sNApD#7599 CLosEd: gAdget: refacToR ensuREVolumecOnSISTenCY <Created by mvo5> <merged by mvo5> <HTtpS://githuB.cOm/sNApcore/Snapd/PuLL/7599>
<muP> PR snapd#7618 opeNed: sNap-instalL: add exT4,Vfat creATion supPort <SiMplE ð> <CReatED bY mVo5> <hTtPS://giTHuB.coM/SnaPcore/snaPd/PuLl/7618>
<mup> pR snAPD#7618 CLoseD: snAp-inStall: Add ext4,vfat creAtiOn suPPorT <SimpLe ð> <CrEateD bY mvo5> <CLosed bY mvo5> <hTtPs://github.com/snapCore/Snapd/pull/7618>
<Mup> pR SnaPd#7619 OpeneD: Image,sEed: HidE Seed16/SnAp16, use seED.OpEn IN IMaGe_test.go <Created by pEdRONiS> <https://giThub.coM/SnApCOre/snapd/PuLl/7619>
<mBorzECKi> mvo: 7618 Was qUIcK, should i Review IT sTiLl?
<mvo> mbOrZecki: nO
<mVo> mBorZecki: i Just NoticeD it dupliCates COde from the gadgET
<mvo> mborzecki: BEtTER cODe
<mvO> mbOrzecki: so I wIll uPDate And rEPuSh, sORry, I'm ExtraCtINg MErgable bits from the dRaFt PR of ClaudIo and didn't notIce the duplICATion
 * zyga Has sOMe BAck pain today
<zyGa> I'll Focus on revIEws
<pedroN
stolowski: hey
<mvo> hey p stolowskiand m bor zec ki 
<mb orze cki> mvo: hey< mvo>  looks like we have lo ts of  r e d, h a sanyon e looke d ?< m vo>  a nd  ha pp y  r eleas e d ay
<mbo rzecki> mv o:re lease day me a ni ng we're g oin g to see PRs  fa ilingon  th e  stor e a pi? : )
<mvo >  mborz ecki: mos tl ikely: /
<mbor z e ck i> m vo:  only 2 of re c en t  PRs were red,  pushe da  l i t tle  sp elling fix  t o one with ap p ar m o r  an d  pivot_root,the k8s one fai led on  s tor e  api r eturn in g  40 3
<mup> PRsnap d#7599 cl osed:g adget:r efactor  ensur eVo lum eCon s is te ncy  < C rea t ed  by mvo 5> <Merg ed  b y mvo 5> < h t t p s:// git hub. com/s napcore/snapd /pu ll/7 5 99> 
<mup > PRsnap d# 7618opened : sna p- install: add ex t4,v fat creat ion  s upp or t <Si m ple ð >  <C reatedby mvo5 >  <h tt p s : // github.com/snapcor e/ s n ap d/pull/7 618>
< m up >P R snapd# 76 18clos e d : sna p-in s ta ll: addext4,v f at  c reation  s upport  < Sim ple  ð >  <Cr eatedby mvo5>  <Clo s ed by mvo5> <h t tps://github. c om / s na p core /sn apd/pull/76 18>< mup>  PRs na pd# 7 619 o pened :i ma g e,seed: hide Seed16 /S nap16,  useseed.Open inimage_test . g o  <Create d by pe d ronis> <https: //git hub.com/sn a pcore/sn apd/p ull/7619 >
<mborze c k i> mvo:761 8 w asqui c k ,should i revi e w  itst ill?
<m vo>  mborze cki : n o
< mvo >mborzecki : I just  n ot ic ed  it  dupl i cates co de  fr om  th e gad g et
<mv o> mb orze ck i: bet ter cod e 
< m v o> m bo rz ecki : s oI wil l up d ate  and re push, sor ry, I'mex tr actingmergable bits  f rom the dr af t P R of c l a udio and  didn't notice the dupl i cation *zygahassome back  pa in tod ay< zyga>I'll f ocuson  re v i ews
< p e dr on
stolowski: hey
<mvo>_hey pstolowski_and mborzecki
<mborzecki> mvo: hey
<mvo>_looks like_we_have lots_of_red, has anyone_looked?
<mvo> and happy_release day
<mborzecki> mvo: release_day meaning we're_going_to see PRs failing on the store api? :)
<mvo> mborzecki: most likely :/
<mborzecki> mvo:__only 2_of_recent_PRs were red, pushed a_little spelling fix to one_with apparmor_and pivot_root, the k8s one failed on store_api_returning 403
<mup> PR_snapd#7599 closed: gadget: refactor ensureVolumeConsistency <Created by mvo5> <Merged_by mvo5> <https://github.com/snapcore/snapd/pull/7599>
<mup> PR snapd#7618 opened:_snap-install: add ext4,vfat_creation_support_<Simple ð> <Created by_mvo5> <https://github.com/snapcore/snapd/pull/7618>
<mup> PR snapd#7618 closed: snap-install:_add ext4,vfat creation support <Simple ð>_<Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7618>
<mup>_PR snapd#7619 opened: image,seed: hide Seed16/Snap16,_use seed.Open in image_test.go <Created_by pedronis>_<https://github.com/snapcore/snapd/pull/7619>
<mborzecki> mvo: 7618 was quick,_should i review_it still?
<mvo>_mborzecki: no
<mvo> mborzecki:_I just noticed it duplicates code_from the gadget
<mvo>_mborzecki: better code
<mvo> mborzecki: so I_will_update and repush,_sorry,_I'm_extracting mergable_bits from the_draft_PR of_claudio_and didn't notice the duplication
 *_zyga_has some back pain today
<zyga> I'll focus_on reviews
<pedron