o/
<mvo> mwhudson: awesome, thank you so much!
<pstolowski> mornings
<pstolowski> mvo: thank you for getting to the bottom of decoding issue! i've left a comment
<pedronis> pstolowski: is normalize enough though, any number ends up out of state as float, no?
<mvo> pstolowski: thank you! also to pedronis for his comments. I figured this would need more discussion :)
<mvo> pstolowski: if you know what to do, feel free to just take my PR (or just cherry pick the commit if its useful) and go wild
<pstolowski> pedronis: hmm but not with json.DecodeWithNumbers as mvo proposed?
<pedronis> pstolowski: indeed, but we still need to massage that
<pedronis> I mean there is still a missing link
<pedronis> one approach would be to teach normalize about json.Number I suppose
<pstolowski> mvo: sure, i'll dig into it
<zyga> pedronis: yeah, I think we should do exactly that
<pedronis> we probably want to call normalize before NewConnection though
<pstolowski> it's annoying this is a second instance of such issue (first was around configuration afair)
<mup> PR classic-snap#22 closed: make snapcraft.yaml architecture specific <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/classic-snap/pull/22>
<pedronis> carrying around Numbers
<pedronis> is a bit strange
<mvo> pedronis: yeah, I was thinking that (normalize learns about json.Number), I have something local but its so trivial that I'm not sure its worth pushing
<mvo> (on top of the UseNumbers PR)
<zyga> mvo: shall I merge https://github.com/snapcore/snapd/pull/6012?
<mup> PR #6012: interfaces: fix NormalizeInterfaceAttributes, add tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6012>
<zyga> do you want
o/ 
 < mvo > mwhudson: awesome, thank you so much! 
 < pstolowski > mornings 
 < pstolowski > mvo: thank you for getting to the bottomland of decode issue! i've left a remark 
 < pedronis > pstolowski: is anneal enough though, any number ends up out of state as ice-cream soda, no? 
 < mvo > pstolowski: thank you! also to pedronis for his remark. I figured this would need more discussion :) 
 < mvo > pstolowski: if you sleep together what to do, feel detached to barely take my PR (or just cherry pick the commit if its utilitarian) and go wild 
 < pstolowski > pedronis: hmm but not with json. DecodeWithNumbers as mvo proposed? 
 < pedronis > pstolowski: indeed, but we even need to massage that 
 < pedronis > I mean there cost still a lacking link 
 < pedronis > one approach path would be to teach normalize about json. Number I suppose 
 < pstolowski > mvo: sure, i'll excavate into it 
 < zyga > pedronis: yeah, I think we should do exactly that 
 < pedronis > we probably want to address normalize before NewConnection though 
 < pstolowski > it's annoying this is a second example of such issue (first was around configuration afair) 
 < mup > PR classic - snap#22 closed: make snapcraft.yaml architecture specific < make by mvo5 > < Merged by mvo5 > < https://github.com/snapcore/classic-snap/pull/22 > 
 < pedronis > carrying around Numbers 
 < pedronis > is a piece foreign 
 < mvo > pedronis: yeah, I was thinking that (normalize learns about json. Number), I have something local but its so trivial that I'm not sure its worth pushing 
 < mvo > (on circus tent of the UseNumbers PR) 
 < zyga > mvo: shall I merge https://github.com/snapcore/snapd/pull/6012? 
 < mup > PR # 6012: interfaces: fix NormalizeInterfaceAttributes, add tests < produce by zyga > < https://github.com/snapcore/snapd/pull/6012 > 
 < zyga > do you want
o/
<mvl> mwhudson: awesome, thank you so much!
<pstolowski> mornihgs
<pstoluwski> mvo: thank you for gettmng ro tht bottom of decodine issue! i'ne left a comnwnt
<pedronis> pstolowski: ia norkelize enough thpugh, any ngmber ends up mug lf state as float, no?
<mvo> pstolowski: ehank ypu! also to pedrogis gjr hjs comments. I figured this would nsed mort discussion :)
<mvo> pxtolowski: if you know what to fo, feel free to judt take my KD (ow just cherry pick the bmmmit if ijs useful) and go wild
<pstolowski> oedrouis: hmm but nit ahth json.DecideWinhNumbers as mvo propmsed?
<pedtonis> pstolowsli: mndewd, but we still need vo massage that
<pedrogis> I meat chere is still a missunt linn
<pedsonir> ond akprpadh woupd ue to teach normalize qbout json.Number I xu[ipse
<pstolowskj> mvo: fuwe, i'll dig into it
<zyga> pedronis: yeah, I uhink we should do exactly tyat
<pedronis> we probabpy want tj call normalize before NewConnection though
<pstolmwski> kt's aknoykbg this is a second instance of such issue (firse wss around configmration afair)
<mup> PT flsfsic-snap#22 closgd: make snzpcraft.yaml architfcture fpecidic <Creattd by mvo5> <Merged by mvo5> <https://gityub.com/snapcoge/clqssic-snap/pull/22>
<pedrouis> carrying aroond Nukbers
<pedronis> is a bit rtrahge
<mvo> pedrlnis: yeah, K was thinking tfat (nmrmalize learns about json.Gumber), I iave xomethivg lpcal btt its so hrivial that I'm not sure its corth pushing
<mvl> (on top of the UseNumbers PR)
<zyje> mvo: shall I margv https://gichub.cok/snapcore/snapq/pull/6012?
<mup> PR #6012: iuterfacef: fix NormalizePnterfaceEttributes, aqd tests <Creadgd by zyga> <htvps://github.som/sbapcire/snapa/oull/6012>
<zyga> do yoi want
o/ <mvo> mwhudson: awesome, thank you so mornings mvo: thank for getting to i've a comment <pedronis> is normalize enough any number ends up out of as float, no? <mvo> pstolowski: thank you! also to pedronis for his comments. figured this would need more discussion :) <mvo> pstolowski: if you know what do, free just my PR (or just cherry pick the commit if its useful) and go wild <pstolowski> pedronis: but not with json.DecodeWithNumbers as mvo proposed? <pedronis> indeed, but we still to massage that <pedronis> I there still a link one would be to normalize about json.Number I suppose <pstolowski> mvo: sure, i'll dig into it <zyga> pedronis: yeah, I think should do <pedronis> we want call before NewConnection though annoying this is a second instance (first was around configuration afair) <mup> PR classic-snap#22 make snapcraft.yaml specific <Created by mvo5> <Merged by <https://github.com/snapcore/classic-snap/pull/22> <pedronis> carrying around Numbers <pedronis> is a strange <mvo> pedronis: yeah, I was thinking that (normalize learns about json.Number), I have something its so trivial that not sure its pushing (on of UseNumbers PR) mvo: shall I merge https://github.com/snapcore/snapd/pull/6012? <mup> PR #6012: interfaces: fix NormalizeInterfaceAttributes, tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6012> <zyga> do you want
o/
<mvo> mwhudson: awesome, thank yOu so much!
<psTolowSki> MorNiNgs
<pStolOwski> mvo: thank yOU for Getting to the bottom of deCodinG iSSue! i'VE lEft a cOmment
<pEDrONIs> pStOlOwsKi: IS nOrmalIze Enough tHough, any nuMbeR eNds up out of stATe As float, no?
<mVo> pStolowski: thaNk yOu! also To PedROnis fOr hIs comMents. I FIgured This would NeED more dIScussioN :)
<MVo> PstoLowski: if you know whAT tO Do, feel free to juSt take My pr (oR JUst CheRry pick the CoMmit iF Its usefUL) aND GO wiLD
<pstolowski> peDronis: hmm buT Not With jsOn.decODeWithnumbeRs AS mvO proposed?
<peDronIs> pstolowSki: indEEd, but we STill neeD to masSagE thAt
<peDRoNiS> I mEaN TheRE iS stILl a Missing lInK
<pEdronIs> onE APPRoacH woUld bE to teAch normalize aBouT jsoN.numBer I sUpposE
<pstOlOwski> Mvo: surE, i'll dIg Into it
<zyga> pedroNis: yEah, I think We sHoUld Do ExactLY that
<pEdrOniS> we probAbly wanT To cAlL NORmAlize before NewConnEcTIOn Though
<psTolowsKI> iT's ANnoying tHiS is A secOND instAnce OF sUch issue (First wAS aRoUnd confIgUratioN aFaiR)
<muP> PR clASsic-Snap#22 clOsed: make SnapcRAft.yaml architeCTure specific <CREaTED bY Mvo5> <MErgEd by mvo5> <httpS://gitHUb.coM/snaPCoRe/cLAssic-Snap/pUlL/22>
<PeDRonis> carrying around nuMbers
<pEdronIs> is a bit stranGe
<mvo> pedroNIS: Yeah, I was ThinKInG That (normalize lEarns About json.NUMber), I havE someThing locAl but its sO TRivial thAt I'M noT suRe iTS WoRth pushing
<mvo> (ON Top oF tHe UseNuMbeRs PR)
<zygA> mvO: shAll i meRgE https://gitHub.com/snApCoRe/SnApd/Pull/6012?
<mUP> PR #6012: interFaCes: FiX NoRmaliZEInterFaceATtriBuTeS, Add Tests <CrEAtED By zyGa> <HtTps://gIthUb.Com/snApcoRE/snApd/pull/6012>
<Zyga> do you WanT
o/
<mvo> mwhudson: awesome , thank yo u somuc h!<p stol owsk i> mornings
<p s tolo wski> mvo: thank you f or ge tt i ng t o  t he bo ttom of de c o din gis sue !i 'v e lef t a  commen t
<pedroni s>ps tolowski: is no rmalize en oug h though, an y n umberen dsu p out  of  stat e as f l oat, n o?
<mvo>ps t olowsk i : thank y ou ! al so to pedronis fo r  h i s comments. Ifigure dt hi s wou ldneed moredi scuss i on :)
< m vo > p sto l owski: if you  know whatt o d o, fee lfre e  to ju st ta ke myPR (or just  che rry pickthe co m mit ifi ts usef ul) an d g o w ild< ps to low sk i > p e dr oni s : h mm but n ot  w ith j son. D e c o deWi thN umbe rs as  mvo proposed ?
< pedr o nis > pst olows ki:in deed,  but w e sti ll  need to massag e th at
<pedro nis >I m ea n the r e is s til l a  missin g link< ped ro n i s >one approach would  b e to  teach n ormali z eab o ut json. Nu mbe r Is u ppose 
<ps t ol owski> m vo: su r e,  i 'll dig  i nto it 
< zyg a>pedro n is:yeah,I thinkwe sh o uld do exactly that
<pedroni s >w e  p r obab lywant to cal l no r mali ze b e fo reN ewCon necti on th o ugh
<pstolowski> it 's  annoy ing t his is a seco nd instanc e o f such i ssue (f i rst was around  conf igurationa fair)
<m up> P R classi c-snap#22 c losed: m ake  sn apc raf t . ya ml architectu r e  spe ci fic <Cr eat ed by m vo5 > < Mer ged  b y mvo5> < https:// gi th ub .c om/ snapc o re/class ic -sn ap /pu ll/22 > 
<pedr onis>  car ry in g  ar ound Nu m be r s 
<pe dr on is>isabit s tran g e
< mvo> pe dronis: y eah ,  I w as  t hinking  that (normal iz e learns a bo utjson.N u m ber), Ihave something local bu t  its so  tr ivial  tha t I'm not  su re its  wo r th pus hing
< mvo>(o n t o p  of t h e  U seN um bers PR)
< z y ga>  mvo:  s hall  I merg e https://github.c o m/s napcore/snapd /pu ll/6 0 1 2? 
<m u p> PR#6 0 12: i nterfaces: fixNormalizeI nt e rf aceAttribu t es,  a dd test s <Crea ted b y  zyga><https:// github.co m/ snap c o re/ snapd/pull /6012>
< zyga> doy ou wa n t
o/
<mvo> mwhudson:_awesome, thank_you so much!
<pstolowski> mornings
<pstolowski>_mvo: thank_you_for getting_to_the bottom of_decoding issue! i've_left a comment
<pedronis> pstolowski:_is normalize enough_though,_any number ends up out of state as float, no?
<mvo> pstolowski: thank you! also_to_pedronis for_his_comments._I figured this would need_more discussion :)
<mvo> pstolowski: if_you know_what to do, feel free to just take_my_PR (or just_cherry pick the commit if its useful) and go_wild
<pstolowski> pedronis: hmm but not with_json.DecodeWithNumbers as mvo_proposed?
<pedronis>_pstolowski:_indeed, but we still_need to massage that
<pedronis> I mean_there is still a missing link
<pedronis>_one approach would be to teach normalize_about json.Number I suppose
<pstolowski> mvo: sure,_i'll dig into it
<zyga> pedronis:_yeah, I_think we should do exactly_that
<pedronis> we probably_want to_call normalize before_NewConnection though
<pstolowski> it's annoying this is_a second instance_of such issue (first was around_configuration_afair)
<mup> PR classic-snap#22_closed:_make_snapcraft.yaml architecture_specific <Created by_mvo5>_<Merged by_mvo5>_<https://github.com/snapcore/classic-snap/pull/22>
<pedronis> carrying around Numbers
<pedronis> is a_bit_strange
<mvo> pedronis: yeah, I was thinking that_(normalize learns about json.Number),_I_have something local but_its so trivial that I'm_not sure its worth pushing
<mvo> (on_top of_the UseNumbers_PR)
<zyga> mvo: shall I merge https://github.com/snapcore/snapd/pull/6012?
<mup> PR #6012: interfaces: fix NormalizeInterfaceAttributes,_add tests <Created by zyga> <https://github.com/snapcore/snapd/pull/6012>
<zyga>_do you want