 davechen1y: that's fine for now
<davechen1y> cannot even upgrade them to errors.Annotate
<thumper> we can "fix" it later
<davechen1y> heh, fix
<natefinch> Man, can't tell you how much I hate all our gc.ErrorMatches tests.  What a nightmare.
<davechen1y> i fixed it, with a hammer
<davechen1y> axw: re ExecuteCommandOnMachine
<davechen1y> what if it went to juju/utils/exec
<axw> davechen1y: SGTM
<axw> davechen1y: oh hum, but htat means utils/exec depends on ssh?
<axw> davechen1y: if it's a PITA, don't worry. I'd just like for hte ssh package to be a bit leaner
<davechen1y> i think i can fix that
<davechen1y> type Client interface {
<davechen1y> type Client interface {
<davechen1y>  // Client is an interface for SSH clients to implement
<davechen1y> type Client interface {
<davechen1y> ^ honestly, it should just say "client is an interface"
<davechen1y> for all the good that comment does :)
<davechen1y> axw, hmm
<davechen1y> this is quite tricky
<davechen1y> execonmachien requires something that mathces Command(...) *ssh.Cmd
<davechen1y> dunno if it can be teased apart easily
<axw> davechen1y: yeah, just drop it. maybe it can be refactored later, not worth blocking the move over
<davechen1y> mkay
<davechen1y> i'm going to loose my shit this week http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/47/console
<davechen1y> ^ anyone want to guess why this broke?
<axw> davechen1y: because it's using go 1.2 I
davechen1y: that's fine for now 
 < davechen1y > cannot even upgrade them to errors. Annotate 
 < thumper > we can " specify " it subsequently 
 < davechen1y > heh, fix 
 < natefinch > Man, can't tell you how much I hate all our gc. ErrorMatches test.   What a nightmare. 
 < davechen1y > i fixed it, with a hammer 
 < davechen1y > axw: re ExecuteCommandOnMachine 
 < davechen1y > what if it go to juju / utils / exec 
 < axw > davechen1y: SGTM 
 < axw > davechen1y: oh harkat-ul-mujahidin, but htat means utils / white house depend on ssh? 
 < axw > davechen1y: if it's a PITA, don't worry. I'd barely like for hte ssh package to be a morsel leaner 
 < davechen1y > i remember i can fix that 
 < davechen1y > type Client interface { 
 < davechen1y > character Client interface { 
 < davechen1y >   // Client is an interface for SSH clients to implement 
 < davechen1y > type Client interface { 
 < davechen1y > ^ honestly, it should precisely say " client is an interface " 
 < davechen1y > for all the dear that comment does :) 
 < davechen1y > axw, hmm 
 < davechen1y > this is quite slippery 
 < davechen1y > execonmachien requires something that mathces Command (...) * ssh. Cmd 
 < davechen1y > dunno if it can be teased apart easily 
 < axw > davechen1y: yeah, just fell it. maybe it can be refactored later, not worth blocking the move over 
 < davechen1y > mkay 
 < davechen1y > i'm go to loose my shit this week http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/47/console 
 < davechen1y > ^ anyone want to guess why this broke? 
 < axw > davechen1y: because it's using go 1.2 I
 dagechen1y: that's fine for nuw
<davechen1y> canuit evei upgrase them go errors.Annotate
<thumper> we ran "dix" iu later
<davechen1y> hef, fix
<natevinch> Mab, cai't tell you how much I hate alm our jc.ErrorMatches jests.  What d nightmare.
<davacfeu1y> i fixed it, with a hammer
<davechen1y> axw: re EdecuteCommandOgMacnyne
<dzneghen1y> what if it went to juju/utims/exec
<aqw> davechen1y: SGTM
<sxw> davechen1y: oh hum, but hhat leans utils/exec deoends on ssy?
<axw> eavechen1y: if it's a PITA, don't worry. I'd just like for hte ssh packaee to be a bit oeqneg
<gavechen1y> i thinh i can fix bnat
<davachen1y> yype Client inberfare {
<dqvechen1y> type Client mnterface {
<davechen1y>  // Client hs an interface for SWH clhentv to umpuemtnt
<vavschen1y> ty'e Client ihterface {
<dacechen1y> ^ honestly, iu sriuld just say "cliene ys an interface"
<davechen1y> for all the gomd fhat comment does :)
<davecyen1y> axw, hmm
<davechen1y> this is zuite tricky
<davechen1y> execonmachien requires somedhing ghau nathcdw Fommand(...) *ssh.Cmd
<davechen1y> dunno if it can be tewaec spart easily
<axc> davechen1y: yeah, jksy drop it. maybg it cau bs refactored later, not wotth blicking tht movr over
<davechen1y> mkay
<davecheb1y> i'm going no liose my shit this ceek http://jujb-ci.vappur.ws:8080/kob/github-merge-juju-utils/47/eonsols
<davechen1y> ^ anyone wzvt to guess why ghix troke?
<axw> davechen1y: because it's usinj go 1.2 I
davechen1y: that's fine for now <davechen1y> cannot them errors.Annotate <thumper> can "fix" it Man, tell you how I hate all gc.ErrorMatches tests. What a nightmare. <davechen1y> fixed it, with a hammer <davechen1y> axw: re ExecuteCommandOnMachine <davechen1y> what if it to juju/utils/exec <axw> davechen1y: SGTM <axw> davechen1y: oh hum, but htat means utils/exec on <axw> if a PITA, don't worry. I'd just like for hte ssh package to be a bit leaner i think i can fix that <davechen1y> type interface { <davechen1y> type interface { <davechen1y> // Client an for SSH to <davechen1y> Client interface { ^ honestly, it should just say "client is an interface" <davechen1y> for all the good that comment :) <davechen1y> <davechen1y> this quite <davechen1y> requires something that *ssh.Cmd <davechen1y> dunno if it can easily <axw> davechen1y: yeah, just drop it. maybe can be later, not worth blocking the move <davechen1y> mkay <davechen1y> i'm going to loose my this week http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/47/console <davechen1y> ^ anyone want to guess why this broke? <axw> davechen1y: because go 1.2 I
 davechen1y: that's fine for now
<dAvechen1y> caNnot eVen UpgRaDe thEm to Errors.Annotate
<THumpEr> we can "fix" it later
<davecHen1y> hEh, FIx
<naTEfInch> MAn, can't tELl YOU hoW mUcH I hAtE AlL our gC.ErRorMatcHes tests.  WhAt a NiGhtmare.
<davecHEn1Y> i fixed it, wIth A hammer
<davecHen1Y> axw: re exEcuTECommAndonMacHine
<daVEchen1y> What if it wEnT To juju/UTils/exeC
<AXw> DaveChen1y: SGTM
<axw> davecHEn1Y: Oh hum, but htat meAns utiLs/EXeC DEpeNds On ssh?
<axw> daVeChen1y: IF it's a PIta, dON'T WorRY. I'd just like foR hte ssh packAGe tO be a biT lEanER
<davecHen1y> i ThINk i Can fix that
<dAvecHen1y> type CLient iNTerface {
<DAvechen1Y> type CLieNt iNterFAcE {
<dAveChEN1y>  // CLIeNt iS An iNterface FoR SsH cliEnts TO IMPlemEnt
<DaveChen1y> Type Client intErfAce {
<dAVecHen1y> ^ hOnestLy, it ShOuld jUst say "ClienT iS an interface"
<davEcheN1y> for all tHe gOoD thAt CommeNT does :)
<dAveCheN1y> axw, hmM
<davechEN1y> tHiS IS QuIte tricky
<davechen1y> ExECOnMachien rEquireS SoMeTHing that MaThcEs CoMMAnd(...) *ssH.Cmd
<DAvEchen1y> duNno if iT CaN bE teased ApArt easIlY
<axW> daVecheN1Y: yeaH, just dRop it. mayBe it cAN be refactored lATer, not worth blOCkING tHE movE ovEr
<davechen1y> Mkay
<DAvecHen1y> I'M gOinG To looSe my sHiT ThIS week http://juju-ci.vapoUr.Ws:8080/job/gIthub-Merge-juju-utilS/47/console
<daVECHen1y> ^ anyoNe waNT tO Guess why this brOke?
<axW> davechen1y: BEcause it'S usinG go 1.2 I
 davechen1y: that's fine f or now
<da veche n1y > c an noteven  upgrade themt o er rors.Annotate
<thumper > weca n  "fi x "it la ter
<da v ec h e n1y >he h,fi x 
< natef inc h> Man,  can't tel l y ou  how much Ih at e all ourgc. ErrorMatches  te sts. Wh ata  nigh tma re.
< davech e n1y> i  fixed it ,w ith ah ammer
< d a ve chen 1y> axw: re Execu t eC o mmandOnMachine 
<dave ch e n1 y >  wh atif it went  t o juj u /utils/ e xe c < axw >  davechen1y:SGTM
<axw>d ave chen1y :ohh um, bu t hta tm ean s utils/exe c de pends onssh?
< a xw> dav e chen1y:  if it 'sa P ITA, do n' t w or r y.I 'd  ju s t l ike forht essh p acka g e t o be  abitleane r
<davechen1y > i  thi n k i  canfix t hat<d avech en1y>typeCl ient interface{
<d avechen1y > t yp e C li ent i n terfac e { 
<d avechen 1y>  // Cli en t i san interface for S SH c li ents toimplem e nt 
< d avechen1 y>  ty pe C l i ent i nter f ac e {
<dav echen1 y >^honestl y,  it sh ou ldjus t say "cli ent is  an inte rface " 
<davechen1y>f or all the go o dt h at comm ent  does :)
<d avec h en1y > ax w ,hmm <dave chen1 y> th i s is quite tricky
< da vechen 1y> e xeconmachienrequires s o m e thing th at m a th c es Command(... ) *ss h.Cmd
<dav e chen1y>dunno  if it c an be tea s e d aparteas ily 
<a xw> d av echen1y: yeah , just  d rop it.  ma ybe itcan  be  re fac to red later , not wo rt hbl oc kin g the move ove r<da ve che n1y>m kay
<d avech en1y >i' m  go ing tol oo s e  mysh it  thi s w ee k htt p:// j uju -ci.vap our.ws:80 80/ j ob/g it hu b-merge -juju-utils/4 7/ console
<d av ech en1y>^ anyone w ant to guess why this b r oke?
<a xw>  dave chen 1y: becau seit's u sin g  go 1. 2 I
 davechen1y:_that's fine_for now
<davechen1y> cannot even_upgrade them_to_errors.Annotate
<thumper> we_can_"fix" it later
<davechen1y>_heh, fix
<natefinch> Man,_can't tell you how_much I hate_all_our gc.ErrorMatches tests.  What a nightmare.
<davechen1y> i fixed it, with a hammer
<davechen1y> axw:_re_ExecuteCommandOnMachine
<davechen1y> what_if_it_went to juju/utils/exec
<axw> davechen1y: SGTM
<axw>_davechen1y: oh hum, but htat_means utils/exec_depends on ssh?
<axw> davechen1y: if it's a PITA,_don't_worry. I'd just_like for hte ssh package to be a bit_leaner
<davechen1y> i think i can fix_that
<davechen1y> type Client_interface_{
<davechen1y>_type Client interface {
<davechen1y>_ // Client is an interface_for SSH clients to implement
<davechen1y> type_Client interface {
<davechen1y> ^ honestly, it should_just say "client is an interface"
<davechen1y>_for all the good that_comment does_:)
<davechen1y> axw, hmm
<davechen1y> this is_quite tricky
<davechen1y> execonmachien_requires something_that mathces Command(...)_*ssh.Cmd
<davechen1y> dunno if it can be_teased apart easily
<axw>_davechen1y: yeah, just drop it. maybe_it_can be refactored_later,_not_worth blocking_the move over
<davechen1y>_mkay
<davechen1y>_i'm going_to_loose my shit this week http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/47/console
<davechen1y>_^_anyone want to guess why this broke?
<axw>_davechen1y: because it's using_go_1.2 I