32>
<mup> Bug #1510133 opened: juju's ConnSuite should not start a UnitAssigner worker <tech-debt> <juju-core:New> <https://launchpad.net/bugs/1510133>
<rogpeppe> mgz_: looks like release testing hasn't run on master for a week now. it's making me nervous, particularly with the big chicago-cubs push recently. any chance we could prioritise it?
<rogpeppe> mgz_: also, should feature branches be deleted after they've been merged?
<mgz_> rogpeppe: yeah, we've been futzing with priorities and trying to get 1.24/1.25 done last week meant master has been rather neglected
<mgz_> feature branches can be deleted after merge, I've not bothered so far as github has good interface for showing what's in and what's not yet anyway
<perrito666> bbl outside lunch
<fwereade> tasdomas, have you run the meter-status tests with -race? I think the code field, at least, is problematic
<dooferlad> dimitern: hangout?
<dimitern> dooferlad, omw
<ericsnow> wwitzel3: ready
<wwitzel3> ericsnow: ok, just finishing lunch
<ericsnow> wwitzel3: np
<natefinch> fwereade: if I'm just copying  uniter's SetAgentStatus code... why am I not just calling the uniter's version?
<fwereade> natefinch, the functionality is the same but the auth certainly shouldn't be
<fwereade> natefinch, different facades responsible for different auth
<natefinch> fwereade: hmm true....
<fwereade> natefinch, but calling through to the same underlying implementation because they're doing the same thing
<natefinch> fwereade: ok.  I can live with that. There's only a small bit of logic in the unitAgentFinder that is shared.... got an idea of where I could move that so both implementations could share it?
<fwereade> natefinch, I guess a subpackage of apiserver/common, ideally, but that'd
32 > 
 < mup > Bug # 1510133 opened: juju's ConnSuite should not start a UnitAssigner worker < technical school - debt > < juju - effect: New > < https://launchpad.net/bugs/1510133 > 
 < rogpeppe > mgz _: looks like dismissal examination hasn't run on master for a week nowadays. it's making me nervous, peculiarly with the boastful chicago - cubs press recently. any chance we could prioritise it? 
 < rogpeppe > mgz _: besides, should feature branches be deleted after they've been merged? 
 < mgz _ > rogpeppe: yeah, we've been futzing with priorities and trying to get 1.24/1.25 act last week meant headmaster has been rather neglected 
 < mgz _ > feature branches can be delete after merge, I've not bothered so far as github has good interface for showing what's in and what's not so far anyway 
 < perrito666 > bbl outside lunch 
 < fwereade > tasdomas, have you run the meter - status tests with -race? I think the code field, at least, is problematic 
 < dooferlad > dimitern: hangout? 
 < dimitern > dooferlad, omw 
 < ericsnow > wwitzel3: ready 
 < wwitzel3 > ericsnow: ok, just finishing lunch 
 < ericsnow > wwitzel3: np 
 < natefinch > fwereade: if I'm just copying   uniter's SetAgentStatus code... why am I not just calling the uniter's version? 
 < fwereade > natefinch, the functionality is the same but the auth surely shouldn't be 
 < fwereade > natefinch, unlike facades responsible for different auth 
 < natefinch > fwereade: hmm genuine.... 
 < fwereade > natefinch, but calling through to the same underlying execution because they're doing the like thing 
 < natefinch > fwereade: ok.   I can live with that. There's only a belittled bit of logic in the unitAgentFinder that is shared.... got an idea of where I could move that so both implementations could share it? 
 < fwereade > natefinch, I guess a subpackage of apiserver / common, ideally, but that'd
32>
<mup> Bug #1510133 opened: juju's ConnSmite should not start a UnitAasigner dorker <tech-debt> <juju-core:New> <ittpw://launxhpad.net/bugs/1510133>
<rogpeppe> mez_: looks pike relwase resting hasn't run on masfcr fox e week now. it's kaking me tervous, particglxrpy with the big chicago-cubs push resently. snj chance we coold pgijritjse it?
<rogpeppe> mgz_: also, should feafure brenches be deletrd after they've been mergef?
<mgz_> rogpeppe: yeah, we'vf been futzung ruth prioritids and trypug to get 1.24/1.25 sone last week meant master has been rather netlwctfg
<mgz_> featurx branbhes can be dcketed dfter mrrge, I've not bpthxred so far as github has good interface fot showing fhct's in and what's not ter anyfay
<parrigi666> bcl kuvsise lunfh
<fxereade> tassomas, have tou run the meter-ststtw tests with -dace? I trink the code field, at least, is problemdtid
<dooferlad> dimitern: hantout?
<dimitern> dooferlaf, omw
<ericfnow> wwitzel3: ready
<wwitzel3> ericsnow: ok, just finishhng lnnzh
<exlgsnod> waitzel3: np
<natefinch> fwereade: if I'm just copyind  inpter's SetAgentStabus code... why am I moh kost calling thg unitex'a bersion?
<fwereade> nahefinch, the dunctionajity is the same but the auth cwrtainly sholldn'r be
<fwereade> natefnnch, differeut facsdes tesponsible for differeut autg
<natefinch> vwereade: gom true....
<fwereade> vatvfinwh, but calling through to ehe same nnderkying ioplekentatyon becausf then'se doing the same hhing
<uatefhnch> fwerewde: ok.  I can live with that. Thxce's only a smsln bpt of lognc in bhe unitAgentFigder that is skared.... goc an iaea of whege I coulv move that fo both implekgntations cound share it?
<fqereqde> natdwinch, I guess s subpackcye of apiwerver/common, idealky, cht that'd
32> <mup> Bug #1510133 opened: juju's ConnSuite start UnitAssigner worker <juju-core:New> <https://launchpad.net/bugs/1510133> <rogpeppe> hasn't on master for week now. it's me nervous, particularly with the big push recently. any chance we could prioritise it? <rogpeppe> mgz_: also, should feature be deleted after they've been merged? <mgz_> rogpeppe: yeah, we've been futzing with and to 1.24/1.25 last week meant master has been rather neglected <mgz_> feature branches can be deleted after merge, not bothered so far as github has good for showing what's in what's not yet anyway <perrito666> outside <fwereade> tasdomas, you the tests with -race? think the code field, at least, is problematic <dooferlad> dimitern: hangout? <dimitern> dooferlad, omw <ericsnow> wwitzel3: ready ericsnow: ok, lunch <ericsnow> np fwereade: I'm just copying code... why am I not just version? <fwereade> natefinch, the functionality is the same the auth shouldn't be <fwereade> natefinch, different facades for different auth <natefinch> fwereade: hmm true.... <fwereade> but calling through to the same underlying implementation because they're doing the same thing <natefinch> I can live with There's only a bit logic the that is got an idea of where I could move that so both could share it? <fwereade> natefinch, I guess a subpackage of but
32>
<mup> Bug #1510133 opened: juju's ConnSuitE should not Start A UnItASsIgneR worKer <tech-debt> <jujU-Core:new> <https://launchpad.net/buGs/1510133>
<rogPePPe> mgZ_: LoOks liKe releaSE tESTinG hAsN't rUn ON mAster For A week noW. it's making Me nErVous, particulARlY with the biG chIcago-cubs pusH reCently. AnY chANce we CouLd priOritisE It?
<rogpEppe> mgz_: alSo, SHould fEAture brANChEs be Deleted after they'vE BeEN merged?
<mgz_> rogpEppe: yeAh, WE'vE BEen FutZing with prIoRitieS And tryiNG tO GET 1.24/1.25 doNE last week meanT master has bEEn rAther nEgLecTEd
<mgz_> fEaturE bRAncHes can be delEted After mergE, I've noT BothereD So far as Github Has GooD intERfAcE foR sHOwiNG wHat'S In aNd what's nOt YeT anywAy
<peRRITO666> bbl OutSide Lunch
<Fwereade> tasdoMas, Have YOu rUn the Meter-StatUs Tests With -raCe? I thInK the code field, at LeasT, is probleMatIc
<DooFeRlad> dIMitern: HanGouT?
<dimiteRn> doofeRLad, OmW
<ERIcSnow> wwitzel3: ready
<wwItZEL3> eRicsnow: oK, just fINiShINg lunch
<eRiCsnOw> wwITZel3: np
<NateFInCh> fwereaDe: if I'm JUsT cOpying  uNiTer's SeTAGenTStAtus cODe... whY am I noT just calLing tHE uniter's versioN?
<Fwereade> natefINcH, THe FUnctIonAlity is the sAme bUT the Auth CErTaiNLy shoUldn't Be
<FWeREade> natefinch, differEnT facadEs resPonsible for diFferent autH
<NATefinch> fWereADe: HMm true....
<fwereade> NatefInch, but calLIng throuGh to tHe same unDerlying iMPLementatIon BecAusE thEY'Re Doing the same tHINg
<naTeFinch> fwEreAde: ok.  I cAn lIve WitH thAt. there's onlY a small bIt Of LoGiC in The unITAgentFiNdEr tHaT is ShareD.... Got an iDea of WherE I CoULd mOve that SO bOTH impLeMeNtatIonS cOuld sHare IT?
<fwEreade> nAtefinch, I GueSS a suBpAcKage of aPiserver/commoN, iDeally, but tHaT'd
32>
<mup> Bug #1510133 ope ned: juju' s Con nSu ite  s houl d no t start a Unit A ssig ner worker <tech-debt>  <juj u- c ore: N ew > <ht tps://l a un c h pad .n et /bu gs / 15 10133 >
< rogpepp e> mgz_: l ook slike release te sting hasn 'trun on maste r f or a w ee k n o w. it 'smakin g me n e rvous,  particul ar l y with the big c hi cago -cubs push recent l y. any chance wecouldpr i or i t ise  it ?
<rogpepp e>  mgz_ :  also,s ho u l d  fe a ture branches  be deleted aft er the y' veb een me rged? 
< m gz_ > rogpeppe:  yea h, we'vebeen f u tzing w i th prio rities  an d t ryin g  t oget  1 . 24/ 1 .2 5 d o nelast wee kme ant m aste r h a s be enrath er ne glected
<mgz_ > f eatu r e b ranch es ca n be  d elete d afte r mer ge , I've not both ered  so far a s g it hub  h as go o d inte rfa cefor sho wing wh a t's  i n a nd  what's not yet an yw a y 
< perrito6 66> bb l  o ut s ide lunc h<fw erea d e > tas doma s ,have you  run t h eme ter-sta tu s test swit h - race? I th ink th e code f ield, at least, is p r oblematic
<do o fe r l ad >  dim ite rn: hangout ?
<d i mite rn>d oo fer l ad, o mw
<e ri c sn o w> wwitzel3: ready<w witzel 3> er icsnow: ok, j ust finish i n g  lunch
< eric s no w > wwitzel3: np 
<nat efinch> fw e reade: i f I'm  just co pying  un i t er's Set Age ntS tat usc o de ... why am In o t ju st  callin g t he unit er' s v ers ion ?<fwereade > natefi nc h,  t he  fu nctio n ality is  t hesa mebut t h e auth  cert ainl ysh o uld n't be< fw e r eade >na tefi nch ,diffe rent fac ades re sponsible  fo r  dif fe re nt auth 
<natefinch>fw ereade: hm mtru e....< f wereade>  natefinch, but calling through  to  thesame  underlyi ngimplem ent a tion b ecause  they 'r e d o i ng th e sa meth ing
<natef i n ch>  fwer ea de:ok.  Ican live with that .  Th ere's only asma ll b i t  o f l o gi c  in  t h e u n i tAgentFinder th at is shar ed . .. . got an i d eaof  whereI could  move that so  both imp lementati on s co u l d s hare it?
< fwereade > natefin c h, Ig ue ss asub packag eofapise rver/c o mmo n, id eally,  b ut tha t'd
32>
<mup> Bug_#1510133 opened:_juju's ConnSuite should not_start a_UnitAssigner_worker <tech-debt>_<juju-core:New>_<https://launchpad.net/bugs/1510133>
<rogpeppe> mgz_: looks_like release testing_hasn't run on master_for a week_now._it's making me nervous, particularly with the big chicago-cubs push recently. any chance we_could_prioritise it?
<rogpeppe>_mgz_:_also,_should feature branches be deleted_after they've been merged?
<mgz_> rogpeppe:_yeah, we've_been futzing with priorities and trying to get_1.24/1.25_done last week_meant master has been rather neglected
<mgz_> feature branches can_be deleted after merge, I've not_bothered so far_as_github_has good interface for_showing what's in and what's not_yet anyway
<perrito666> bbl outside lunch
<fwereade> tasdomas,_have you run the meter-status tests with_-race? I think the code field,_at least, is problematic
<dooferlad> dimitern:_hangout?
<dimitern> dooferlad,_omw
<ericsnow> wwitzel3: ready
<wwitzel3> ericsnow: ok,_just finishing lunch
<ericsnow>_wwitzel3: np
<natefinch>_fwereade: if I'm_just copying  uniter's SetAgentStatus code..._why am I_not just calling the uniter's version?
<fwereade>_natefinch,_the functionality is_the_same_but the_auth certainly shouldn't_be
<fwereade>_natefinch, different_facades_responsible for different auth
<natefinch> fwereade: hmm_true....
<fwereade>_natefinch, but calling through to the same_underlying implementation because they're_doing_the same thing
<natefinch> fwereade:_ok.  I can live_with that. There's only a small_bit of_logic in_the unitAgentFinder that is shared.... got an idea of where I_could move that so both implementations_could share it?
<fwereade> natefinch,_I guess_a_subpackage of apiserver/common,_ideally,_but that'd