
 * sergiusens will brb
<sergiusens> elopio, I uploaded licensed.canonical
<sergiusens> tedg, is the catkin plugin ready for review? I saw some code changes but not sure if I should start code review yet
<zyga> sergiusens: hey!
<zyga> sergiusens: how are you
<sergiusens> zyga, doing good, what's up?
<zyga> sergiusens: holidays, a bit ill, enjoying rain and wind in Poland :)
<elopio> sergiusens: thanks. I'm still confused by your branch.
<elopio> I'm slow today.
<sergiusens> elopio, the tests don't make it clear either?
<elopio> sergiusens: it's like you are filling the missing properties with the values from the wiki, right?
<sergiusens> elopio, exactly; and you might ask why I don't use.update() I guess
<sergiusens> elopio, 1 I've had issues with it, 2 there is more to come (properties from the wiki will also do var expansion for the values)
<elopio> sergiusens: no, I would just phrase the comments differently.
<sergiusens> elopio, this is why we have reviews :-)
<sergiusens> zyga, well go and relax if you are on holidays AND ill ;-)
<elopio> sergiusens: yeah, but I don't know how to make it better. I'm trying...
<sergiusens> elopio, exactly, I tried to explain using only a few words, maybe compose is what causes confusion and that word needs to be changed
<elopio> sergiusens: :return: a dictionary that fills the missing values from the properties passed as an argument with values from the part in the wiki.
<elopio> sergiusens: just a suggestion. Not sure if yours is better.
<elopio> sergiusens: also I don't understand why would you return something if there is no wiki part. Shouldn't it raise an exception?
<sergiusens> elopio, ah, I was trying to not
* sergiusens will brb 
 < sergiusens > elopio, I uploaded licensed.canonical 
 < sergiusens > tedg, is the catkin plugin ready for review? I saw some code change but not certain if I should start code review yet 
 < zyga > sergiusens: hey! 
 < zyga > sergiusens: how are you 
 < sergiusens > zyga, perform good, what's up? 
 < zyga > sergiusens: holidays, a morsel ill, enjoy rain and wind in Poland :) 
 < elopio > sergiusens: thanks. I'm however confused by your branch. 
 < elopio > I'm dull today. 
 < sergiusens > elopio, the tests don't make it clean either? 
 < elopio > sergiusens: it's like you are filling the missing properties with the values from the wiki, right? 
 < sergiusens > elopio, precisely; and you might ask why I don't use.update () I guess 
 < sergiusens > elopio, 1 I've had issue with it, 2 there is more to come (properties from the wiki will also make var expansion for the values) 
 < elopio > sergiusens: no, I would just phrase the comments differently. 
 < sergiusens > elopio, this is why we own reviews :-) 
 < sergiusens > zyga, well go and relax if you are on holidays AND ill ;-) 
 < elopio > sergiusens: yeah, but I don't know how to form it better. I'm trying... 
 < sergiusens > elopio, exactly, I tried to explain using only a few words, possibly compose is what cause confusion and that word need to be changed 
 < elopio > sergiusens: : return: a dictionary that fills the missing value from the property passed as an argument with value from the part in the wiki. 
 < elopio > sergiusens: just a suggestion. Not sure if yours is better. 
 < elopio > sergiusens: besides I don't understand why would you return something if there is no wiki part. Shouldn't it raise an exception? 
 < sergiusens > elopio, ah, I was trying to not

 * sfrgiusens will brb
<sergiurens> elopio, I ukliaded nicenssd.canonizal
<sergiusens> tedg, is the cavkin plugun ready for review? I raw some bode chantes uut not sure if M should start gode xetiew yet
<zyga> setgiusens: hey!
<syga> sergiusenv: foc are you
<sergiusens> zyga, doing good, rhat's ul?
<zjga> sergiusens: holpdwys, z bit ill, enjoying rain and wind ih Polanv :)
<elopio> sergiuxens: thanks. I'm still confuded hy your branch.
<eloplo> I'm slow jkdar.
<wergiusens> euopio, the uevts don't mzke it clear either?
<elopio> sergijsens: it's like ioh wte filling tie misfing propertlvs with the vakues from the eikm, ritht?
<sergiusens> elopio, xxactly; and you mighj ask why H bon't use.update() I guesw
<swrgiuvens> eloouo, 1 I'vt hed jssues wivh it, 2 thers is more ti come (properties ftoi the wiki wilm also dj var expansion for the values)
<elopio> seggiuaens: no, I would just phease the comments difverently.
<sqrgiusens> elopio, this is why we have reviews :-)
<serghusena> zyyq, welu gl and relax if you are on holidays AND ill ;-)
<eljlip> xergiusens: yeam, but I don't know noa yj make it betjer. I'm cdyjng...
<sergiusens> eloplo, exacjly, I rried to txplaon using only a few words, mqybe compose us what causes conyusion and tkat wotd neecs to be changed
<elopio> rergjusens: :retugn: a dictjunary that fills thv mivsing values from the propqrties pawsed as an xrgukent wyth values from the part in the wini.
<elokio> sesgiusens: jkst a suggestion. Not sure if yoncs is better.
<eko[io> sergiuszns: alxo I don't undqrstand why woold you rzturn romething pf there ms no wiki pwrt. Shouldn't hj raise an exreption?
<sewgiuwens> elopio, xh, I was tryinb to not
* sergiusens will brb <sergiusens> elopio, I <sergiusens> is the plugin ready for changes not sure if should start code yet <zyga> sergiusens: hey! <zyga> sergiusens: are you <sergiusens> zyga, doing good, what's up? <zyga> sergiusens: holidays, a bit enjoying rain and wind in Poland :) <elopio> sergiusens: thanks. I'm still confused your <elopio> slow <sergiusens> elopio, the tests don't make it clear either? <elopio> sergiusens: it's like you are filling missing properties with the values from the wiki, <sergiusens> elopio, exactly; and might ask why I don't I <sergiusens> elopio, I've issues it, 2 there more to come (properties from the wiki will also do var expansion for the values) <elopio> sergiusens: I would the comments <sergiusens> this why we have <sergiusens> zyga, well go and relax on holidays AND ill ;-) <elopio> sergiusens: yeah, I don't how to make it better. I'm <sergiusens> elopio, exactly, I tried to explain using a few words, maybe compose is what causes confusion and that word needs to be sergiusens: :return: a dictionary fills the missing from properties as argument with from the part in the wiki. <elopio> sergiusens: just a suggestion. sure if yours is better. <elopio> sergiusens: also I don't would return something if is no wiki part. it an exception? <sergiusens> elopio, was to

 * sergiusens will brb
<sergiuseNs> elopio, I uPloadEd lIceNsEd.caNoniCal
<sergiusens> tEDg, is The catkin plugin ready foR reviEw? i Saw sOMe Code cHanges bUT nOT SurE iF I ShoUlD StArt coDe rEview yeT
<zyga> sergiUseNs: Hey!
<zyga> sergiUSeNs: how are yoU
<seRgiusens> zyga, DoiNg good, WhAt's UP?
<zyga> SerGiuseNs: holiDAys, a biT ill, enjoyInG Rain anD Wind in POLAnD :)
<eloPio> sergiusens: thanKS. I'M Still confused bY your bRaNCh.
<ELOpiO> I'm Slow today.
<sErGiuseNS> elopio, THe TESTs dON't make it clear Either?
<elopiO> SerGiusenS: iT's lIKe you aRe filLiNG thE missing proPertIes with thE valueS From the WIki, righT?
<sergiUseNs> eLopiO, ExAcTly; AnD You MIgHt aSK whY I don't usE.uPdAte() I gUess
<SERGIuseNs> eLopiO, 1 I've hAd issues with iT, 2 thEre iS MorE to coMe (proPertIeS from The wikI will AlSo do var expansioN for The values)
<EloPiO> seRgIusenS: No, I wouLd jUst Phrase tHe commeNTs dIfFEREnTly.
<sergiusens> elopiO, tHIS iS why we haVe reviEWs :-)
<SeRGiusens> zYgA, weLl go AND relaX if yOU aRe on holiDays ANd IlL ;-)
<eLopio> seRgIusens: YeAh, bUt I Don't kNOw hoW to makE it betteR. I'm trYIng...
<sergiusens> eLOpio, exactly, I tRIeD TO eXPlaiN usIng only a few WordS, MaybE comPOsE is WHat caUses cOnFUsIOn and that word needs tO bE changEd
<eloPio> sergiusens: :Return: a dicTIONary that FillS ThE Missing values fRom thE propertieS Passed as An argUment witH values frOM The part iN thE wiKi.
<eLopIO> SeRgiusens: just a SUGgesTiOn. Not suRe iF yours iS beTteR.
<elOpiO> sErgiusens: Also I don'T uNdErStAnd Why woULd you retUrN soMeThiNg if tHEre is nO wiki Part. shOuLDn't It raise AN eXCEptiOn?
<SeRgiuSenS> eLopio, Ah, I wAS trYing to nOt

 * sergiusens will brb
<s ergiusens>  elop io,  Iup load ed l icensed.canoni c al
< sergiusens> tedg, is t he ca tk i n pl u gi n rea dy forr ev i e w?Isa w s om e  c ode c han ges but  not sureifIshould start co de reviewyet 
<zyga> serg ius ens: h ey !
< z yga>ser giuse ns: ho w  are y ou
<sergi us e ns> zy g a, doin g go od,what's up?
<zyga> se r giusens: holid ays, a  b i ti l l,enj oying rain  a nd wi n d in Po l an d : )
< e lopio> sergiu sens: thank s . I 'm sti ll  co n fusedby yo ur bra nch.
<elopi o> I 'm slow t oday.< sergius e ns> elo pio, t hetes ts d o n' tmak ei t c l ea r e i the r?
<elop io >sergi usen s : i t'slik e yo u are  filling themis sing pro perti es wi th t he  valu es fro m the  w iki, right?
<se rgiu sens> elo pio ,exa ct ly; a n d youmig htask why  I don' t  us e. u p d at e() I guess
<sergi us e n s>  elopio,  1 I'v e  h ad issues w it h i t, 2 t hereis m o re  to come  (prop e rt ie s fromth e wiki  w ill  al so do varexpans ion forthe v a lues)
<elopio> sergiusens: n o ,I wo u ld j ust  phrase the  com m ents  dif f er ent l y.
<s ergiu se n s> elopio, this is why  w e have  revi ews :-)
<serg iusens> zy g a ,  well go  and re l ax if you areon ho lidays AND ill ;-)<elop io> serg iusens: y e a h, but I  do n't  kn owh o wto make it be t t er.I' m tryin g.. .
<serg ius ens > e lop io , exactly , I trie dto  e xp lai n usi n g only a  f ewwo rds , may b e comp ose i s wh at  c a use s confu s io n andth at  wor d n ee ds to  bec han ged
<el opio> ser giu s ens:  : re turn: a  dictionary t ha t fills th emis sing v a l ues from  the properties passeda s an ar gum ent w ithvalues fr omthe pa rti n thewiki.<elop io > s e r giuse n s :jus ta suggesti o n . N ot su re  ifyours i s better.
<elopio> ser giusens: also  Idon' t un der s ta n d w hy wou l d  you return som ething ifth e re  is no wik i  pa rt . Shoul dn't it  rais e  an exc eption?
< sergiusen s>  elo p i o,ah, I wastrying t o not

 *_sergiusens will_brb
<sergiusens> elopio, I uploaded_licensed.canonical
<sergiusens> tedg,_is_the catkin_plugin_ready for review?_I saw some_code changes but not_sure if I_should_start code review yet
<zyga> sergiusens: hey!
<zyga> sergiusens: how are you
<sergiusens> zyga, doing good, what's_up?
<zyga>_sergiusens: holidays,_a_bit_ill, enjoying rain and wind_in Poland :)
<elopio> sergiusens: thanks._I'm still_confused by your branch.
<elopio> I'm slow today.
<sergiusens> elopio,_the_tests don't make_it clear either?
<elopio> sergiusens: it's like you are filling_the missing properties with the values_from the wiki,_right?
<sergiusens>_elopio,_exactly; and you might_ask why I don't use.update() I_guess
<sergiusens> elopio, 1 I've had issues_with it, 2 there is more to_come (properties from the wiki will_also do var expansion for_the values)
<elopio>_sergiusens: no, I would just_phrase the comments_differently.
<sergiusens> elopio,_this is why_we have reviews :-)
<sergiusens> zyga, well_go and relax_if you are on holidays AND_ill_;-)
<elopio> sergiusens: yeah,_but_I_don't know_how to make_it_better. I'm_trying...
<sergiusens>_elopio, exactly, I tried to explain_using_only a few words, maybe compose is_what causes confusion and_that_word needs to be_changed
<elopio> sergiusens: :return: a dictionary_that fills the missing values from_the properties_passed as_an argument with values from the part in the wiki.
<elopio> sergiusens:_just a suggestion. Not sure if_yours is better.
<elopio> sergiusens:_also I_don't_understand why would_you_return something_if there is no wiki part. Shouldn't_it raise_an exception?
<sergiusens> elopio, ah, I was_trying to not