 in a similar category.. wouldn't be nice to have client/<everything>
<niemeyer> tomwardill: Thanks for the note
<niemeyer> Chipaca: And agreed, a bit late
<zyga> tomwardill: thank you for the notice!
<Chipaca> niemeyer: but there are things in snap that aren't client, so splitting it might be a good exercise
<mvo> zyga: \o/ you rock
<zyga> mvo: I don't know if that is the problem though
<zyga> I did not reproduce it
<zyga> Chipaca: back now, sorry, the young one wanted food
<mvo> zyga: it probably is not but still nice
<zyga> Chipaca: reviewed https://github.com/snapcore/snapd/pull/5957#pullrequestreview-165744410
<mup> PR #5957: overlord/snapshotstate/backend: fall back on sudo when no runuser <Snapshots ð¸ó > <Created by chipaca> <https://github.com/snapcore/snapd/pull/5957>
<jdstrand> roadmr: hi! can you pull r1141 of the review-tools?
<zyga> hey jdstrand
<roadmr> jdstrand: sure, will do!
<zyga> sorry for not doing more reviews
<jdstrand> roadmr: it would be nice if it was in before SLC, but not mandatory
<zyga> I'll try to tomorrow, I'm just about to wrap it
<jdstrand> zyga: hey :) no worries. belive, I know how that can happen
<zyga> jdstrand: I sent one interesting PR but not security critical
<jdstrand> believe me*
<zyga> still I wrote it as tightly as I could
<zyga> jdstrand: do you remember MNT_DETACH and unmount
<zyga> jdstrand: and the case that if a dentry is mounted in one mount namespace it is EBUSY to remove it in another
<zyga> jdstrand: that got fixed in the kernel since
<zyga> jdstrand: it's not fixed on CentOS or RHEL... :
in a similar category.. wouldn't be nice to have client/<everything > 
 < niemeyer > tomwardill: Thanks for the bill 
 < niemeyer > Chipaca: And match, a bit late 
 < zyga > tomwardill: thank you for the notice! 
 < Chipaca > niemeyer: but there be things in snap that aren't node, indeed splitting it might be a full exercise 
 < mvo > zyga: \o/ you rock 
 < zyga > mvo: I don't sleep together if that is the problem though 
 < zyga > I did not reproduce it 
 < zyga > Chipaca: back immediately, good-for-nothing, the young one wanted food 
 < mvo > zyga: it probably is not but still nice 
 < zyga > Chipaca: review https://github.com/snapcore/snapd/pull/5957#pullrequestreview-165744410 
 < mup > PR # 5957: overlord / snapshotstate / backend: fall back on sudo when no runuser < Snapshots ð¸ó    > < create by chipaca > < https://github.com/snapcore/snapd/pull/5957 > 
 < jdstrand > roadmr: hi! can you pull r1141 of the review - tools? 
 < zyga > hey jdstrand 
 < roadmr > jdstrand: sure, will make! 
 < zyga > sorry for not doing more reviews 
 < jdstrand > roadmr: it would be nice if it was in before SLC, but not mandatory 
 < zyga > I'll judge to tomorrow, I'm just about to wrap it 
 < jdstrand > zyga: hey :) no worries. belive, I know how that can happen 
 < zyga > jdstrand: I commit one interesting PR but not security critical 
 < jdstrand > believe me * 
 < zyga > still I wrote it as tightly as I could 
 < zyga > jdstrand: do you remember MNT_DETACH and unmount 
 < zyga > jdstrand: and the case that if a dentry is mounted in one mount namespace it is EBUSY to get rid of it in another 
 < zyga > jdstrand: that got fixed in the kernel since 
 < zyga > jdstrand: it's not fixed on CentOS or RHEL...:
 in a similar category.. woulan't be nice to kqve clment/<evedything>
<nkemeyer> tomwardill: Thanks foc thw nott
<uiemeyer> Chipaca: And agreed, a bit latw
<zyge> tomwardill: thaii you for the koticz!
<Ciipaca> niemeyer: but there are things in sva' that aren't client, so splitting it iight br w good exercisg
<mvo> eygw: \o/ gou rock
<zyga> mvo: I don't know if thzt is tie problem thoubh
<zyga> I did not reproduce it
<zjga> Chipaca: back nlw, sorry, thg yotbg one wantea food
<mvo> eyya: it probagly is not but still nice
<zyga> Cfipacc: reviewed ytrps://hhthub.com/sna'core/sgapd/pull/5957#pullvvquestraview-165744410
<mul> PR #5957: overlord/xna'shorstate/backend: fall bark on sudo when no ronuser <Sna[skots ð¸ó > <Created by chipqcq> <httks://gitvub.cun/snxpckrx/snzpd/pulp/5957>
<jdatrand> roasmr: hi! can tou pull r1141 of the rtviqq-tools?
<zyga> heg jdstwagd
<roadmr> jdstrand: sure, will do!
<zyga> sorrj fod not doing more revieww
<jdstrand> roadmr: it wluld be nyce if it was in before SLC, but not mandatory
<zyga> I'll vrh ti bomofeoa, I'm just about to wrap it
<jdstrand> zyga: hey :) gk eogries. belive, I knjw how that cwn rappen
<zyga> jdrtrand: I aent one interestijg PR bot not security criyical
<jdstrand> believe me*
<zygq> still I wrjre it as tightly ad I could
<zyya> jdsjrand: co you remember MNT_DETAEH and unmount
<zygw> jdstrans: and the case thxt pf a dentry is mounted in one iount namxspacz it is DBUSI to reiove it in anotmar
<zyga> jdstrand: thwt goj fixeg in the kfrnel since
<zyga> jdstrand: it's nov fixed on CemtMS mr RHEL... :
in a similar category.. wouldn't be nice client/<everything> tomwardill: Thanks the note <niemeyer> late tomwardill: thank you the notice! <Chipaca> but there are things in snap aren't client, so splitting it might be a good exercise <mvo> zyga: \o/ rock <zyga> mvo: I don't know if that is the problem though <zyga> did reproduce <zyga> back now, sorry, the young one wanted food <mvo> zyga: it probably is not but still <zyga> Chipaca: reviewed https://github.com/snapcore/snapd/pull/5957#pullrequestreview-165744410 <mup> PR #5957: overlord/snapshotstate/backend: back on sudo when runuser <Snapshots ð¸ó > <Created chipaca> <jdstrand> roadmr: can pull of the review-tools? hey jdstrand <roadmr> jdstrand: sure, will do! <zyga> sorry for not doing more reviews <jdstrand> roadmr: it be nice was in SLC, not <zyga> I'll try I'm just about to wrap it :) no worries. belive, I know how that happen <zyga> I sent one interesting PR but security critical <jdstrand> believe me* <zyga> still I it as tightly as I could <zyga> jdstrand: do you remember MNT_DETACH and unmount <zyga> the case that if dentry is mounted one namespace is to remove in another <zyga> jdstrand: that got fixed in the kernel since jdstrand: it's not fixed on CentOS or RHEL... :
 in a similar category.. wouldn't Be nice to haVe cliEnt/<EveRyThinG>
<nieMeyer> tomwardilL: thanKs for the note
<niemeyer> ChIpaca: anD AgreED, a Bit laTe
<zyga> tOMwARDilL: tHaNk yOu FOr The noTicE!
<ChipacA> niemeyer: bUt tHeRe are things iN SnAp that aren'T clIent, so splittIng It mighT bE a gOOd exeRciSe
<mvo> Zyga: \o/ yOU rock
<zYga> mvo: I doN't KNow if tHAt is the PRObLem tHough
<zyga> I did not rEPrODuce it
<zyga> ChipAca: bacK nOW, sORRy, tHe yOung one wanTeD food
<MVo> zyga: iT PrOBABly IS not but still nIce
<zyga> ChipACa: rEvieweD hTtpS://Github.Com/snApCOre/Snapd/pull/5957#puLlreQuestreviEw-165744410
<mup> Pr #5957: OverlorD/SnapshoTstate/BacKenD: falL BaCk On sUdO WheN No RunUSer <snapshotS ð¸Ó > <CReateD by cHIPACa> <htTps://GithUb.com/Snapcore/snapd/PulL/5957>
<jdsTRanD> roadMr: hi! cAn yoU pUll r1141 oF the reView-tOoLs?
<zyga> hey jdstraNd
<roAdmr> jdstrAnd: SuRe, wIlL do!
<zyGA> sorry For Not Doing moRe revieWS
<jdStRAND> rOadmr: it would be nice If IT WaS in beforE SLC, buT NoT mANdatory
<zYgA> I'lL try TO TomorRow, I'M JuSt about tO wrap iT
<JdStRand> zygA: hEy :) no woRrIes. BelIve, I kNOw hoW that cAn happen
<Zyga> jDStrand: I sent one INteresting PR bUT nOT SeCUritY crItical
<jdstrAnd> bELievE me*
<zYGa> StiLL I wroTe it aS tIGhTLy as I could
<zyga> jdstrAnD: do you RememBer MNT_DETACH aNd unmount
<zYGA> Jdstrand: And tHE cASe that if a dentrY is moUnted in one MOunt nameSpace It is EBUSy to remove IT In anotheR
<zyGa> jDstRanD: THaT got fixed in thE KErneL sInce
<zygA> jdStrand: iT's nOt fIxeD on ceNtOS or RHEl... :
 in a similar category.. w ouldn't be  nice  to  ha ve  cli ent/ <everything>
< n ieme yer> tomwardill: Thank s for  t h e no t e<niem eyer> C h ip a c a:An dagr ee d ,a bit  la te
<zyg a> tomward ill :thank you fo r  t he notice! 
<C hipaca> niem eye r: but  t her e  arethi ngs i n snap that a ren't cli en t , so s p litting i tmigh t be a good exerc i se <mvo> zyga: \o / youro c k< z yga > m vo: I don' tknowi f thati st h e  pr o blem though
< zyga> I did not  repro du cei t
<zyg a> Ch ip a ca:  back now,sorr y, the yo ung on e  wanted food
<m vo> zy ga:  it  pro b ab ly  is  n o t b u tsti l l n ice
<zyg a>  C hipac a: r e v i e wedhtt ps:/ /gith ub.com/snapco re/ snap d /pu ll/59 57#pu llre qu estre view-1 65744 41 0
<mup> PR #595 7: o verlord/s nap sh ots ta te/ba c kend:fal l b ack onsudo wh e n n or u n us er <Snapshots ð¸ ó  ><Created  by ch i pa ca >  <https: // git hub. c o m/sna pcor e /s napd/pul l/5957 > 
< jd strand>  r oadmr:  h i!can  youp ullr1141of the r eview - tools?
<zyga>h ey jdstrand
< r oa d m r> jdst ran d: sure, wi ll d o !
<z yga> so rry for n ot do in g  m o re reviews
<jdstran d>  roadm r: it  would be nic e if it wa s i n before  SLC ,  b u t not mandator y
<zy ga> I'll t r y to tom orrow , I'm ju st aboutt o  wrap it 
<j dst ran d>z y ga : hey :) no w o r ries .belive,  Iknow ho w t hat  ca n h ap pen
<zyga > jdstra nd :Ise ntone i n terestin gPRbu t n ot se c uritycriti cal<j ds t ran d> beli e ve m e*
< zy ga > st ill  I  wrot e it astightly  as I cou ld< zyga >jd strand:  do you remem be r MNT_DETA CH  an d unmo u n t
<zyga>  jdstrand: and the case that if  adentr y is  mountedinone mo unt namesp ace it  is E BU SYt o  remo v e  i t i nanother
<z y g a>jdstr an d: t hat got  fixed in the kern e l s ince
<zyga> j dst rand : it 'sn ot fix ed onC e ntOS or RHEL...  :
 in_a similar_category.. wouldn't be nice_to have_client/<everything>
<niemeyer>_tomwardill: Thanks_for_the note
<niemeyer> Chipaca:_And agreed, a_bit late
<zyga> tomwardill: thank_you for the_notice!
<Chipaca>_niemeyer: but there are things in snap that aren't client, so splitting it might_be_a good_exercise
<mvo>_zyga:_\o/ you rock
<zyga> mvo: I_don't know if that is_the problem_though
<zyga> I did not reproduce it
<zyga> Chipaca: back_now,_sorry, the young_one wanted food
<mvo> zyga: it probably is not but_still nice
<zyga> Chipaca: reviewed https://github.com/snapcore/snapd/pull/5957#pullrequestreview-165744410
<mup> PR_#5957: overlord/snapshotstate/backend: fall_back_on_sudo when no runuser_<Snapshots ð¸ó > <Created by chipaca> <https://github.com/snapcore/snapd/pull/5957>
<jdstrand>_roadmr: hi! can you pull r1141_of the review-tools?
<zyga> hey jdstrand
<roadmr> jdstrand: sure,_will do!
<zyga> sorry for not doing_more reviews
<jdstrand> roadmr: it would_be nice_if it was in before_SLC, but not_mandatory
<zyga> I'll_try to tomorrow,_I'm just about to wrap it
<jdstrand>_zyga: hey :)_no worries. belive, I know how_that_can happen
<zyga> jdstrand:_I_sent_one interesting_PR but not_security_critical
<jdstrand> believe_me*
<zyga>_still I wrote it as tightly_as_I could
<zyga> jdstrand: do you remember MNT_DETACH_and unmount
<zyga> jdstrand: and_the_case that if a_dentry is mounted in one_mount namespace it is EBUSY to_remove it_in another
<zyga>_jdstrand: that got fixed in the kernel since
<zyga> jdstrand: it's not_fixed on CentOS or RHEL... :