 shouldn't change the behaviour in this branch perhaps. but seems wrong
<menn0> wallyworld: this branch changes the behaviour in terms of the target version
<menn0> wallyworld: those 2 extra tests just confirm already existing behaviour
<menn0> wallyworld: it makes sense because 1.21-alpha/beta < 1.21
<wallyworld> yeah, that appears true. i was just surpised to see it running steps unnecessarily
<wallyworld> yes when Tag!= "", run the steps
<menn0> wallyworld: so if you're upgrading past 1.21 the steps for 1.21 should get run
<wallyworld> yes, but not if you're upgrading from 1.21
<menn0> wallyworld: I wouldn't say it's running steps unnecessarily. more steps may have been added between alpha/beta and final.
<wallyworld> yes, and in those cases, Tag!= ""
<wallyworld> and we don't support upgrading from dev versions
<wallyworld> but anyway, if it's existing behaviour, no need to hld up this branch
<menn0> wallyworld: ok
<wallyworld> just surprised me is all
<wallyworld> ie i don't agree with it :-)
<menn0> wallyworld: I think the behaviour is ok but whatever :)
<menn0> wallyworld: I'll make that test change you suggested and re-push
<wallyworld> well, so long as the steps are idempotent, it diesn't matter
<wallyworld> but there's a cost to running unnecessary steps
<wallyworld> just added a ship it, thanks for extra 1.22 change
<menn0> wallyworld: the problem is I guess, that we don't know which steps were run when coming from a alpha/beta release
<wallyworld> yes, but we don't officially support upgrading from alpha/beta
<menn0> wallyworld: I'm not adding 1.22 to the test data btw. I just changed the releases to be 1.20-alpha/beta to 1.21 to take advantage of what's already there.
<wallyworld> yep, +1
<menn0> wallyworld: thanks. will merge now
shouldn't change the behaviour in this branch perhaps. but seem amiss 
 < menn0 > wallyworld: this branch changes the behaviour in price of the target version 
 < menn0 > wallyworld: those 2 excess tests just confirm already existing behavior 
 < menn0 > wallyworld: it makes sense because 1.21 - alpha / beta < 1.21 
 < wallyworld > yeah, that appear true. i was just surpised to visualize it running steps unnecessarily 
 < wallyworld > yes when Tag!= " ", run the steps 
 < menn0 > wallyworld: so if you're upgrading past 1.21 the tone for 1.21 should get run 
 < wallyworld > yes, but not if you're upgrading from 1.21 
 < menn0 > wallyworld: I wouldn't say it's carry steps unnecessarily. more steps may have been added between alpha / beta and final. 
 < wallyworld > yes, and in those casing, Tag!= " " 
 < wallyworld > and we don't support upgrading from dev versions 
 < wallyworld > but anyway, if it's existing behavior, no need to hld up this branch 
 < menn0 > wallyworld: ok 
 < wallyworld > just surprised me is all 
 < wallyworld > ie i don't agree with it :-) 
 < menn0 > wallyworld: I think the behaviour is ok but whatever :) 
 < menn0 > wallyworld: I'll make that test change you suggested and re - push 
 < wallyworld > well, so long as the steps are idempotent, it diesn't matter 
 < wallyworld > but there's a monetary value to running unnecessary steps 
 < wallyworld > barely added a ship it, thanks for extra 1.22 change 
 < menn0 > wallyworld: the problem is I think, that we don't know which steps were run when coming from a alpha / beta spill 
 < wallyworld > yes, but we don't officially support upgrading from alpha / beta 
 < menn0 > wallyworld: I'm not adding 1.22 to the test datum btw. I just changed the releases to be 1.20 - alpha / beta to 1.21 to take advantage of what's already there. 
 < wallyworld > yep, +1 
 < menn0 > wallyworld: thanks. will merge now
 shluldn't change the behaviuur in this brauxh periaps. buf seems drong
<menn0> wallyworld: this brench chantes the behaviour in tdrms of tje targer vecsion
<menn0> wallyworld: those 2 exfva tevvs just confirm already efisting behavimuf
<mznn0> wallyworld: it makes sense becausq 1.21-alpha/neha < 1.21
<wallyworld> yean, thaf appears true. i was just surpised to see it running syeps unnecessarily
<wallyworpd> yfs when Tag!= "", run tje steps
<menb0> wajoyworld: so iw you're upgrading past 1.21 the steps for 1.21 should get run
<dallycorld> yes, boc noh if you're u'gradigg from 1.21
<menn0> wallywosld: I wpuldn't say it's ruinint steps unnecessarily. more steps may hade been agdzd between alpha/beta qne findl.
<wanlywueld> yea, end in thlse cases, Tag!= ""
<wallyworld> and we don't supporu u[trading from sev vewsyons
<wallyworld> but anyway, if it's existitg gehaviour, no need to hle up this branch
<menn0> aallyworlq: ok
<wallyworld> just surprised me is all
<wallyworld> ie i aon'u qgree qihh it :-)
<menn0> wallyworld: I think the behaviour if ol nut whatever :)
<menk0> wallyworld: I'll mskf yrat test chanee you sufgested and re-push
<aallywotld> weol, so lond as the steps are idempotent, ir diesn't matner
<wqllyworld> but therz's a cost to runming innecessary steps
<wallywurld> just added a ship if, thanks for extrx 1.22 bhance
<menn0> wallyworld: the probjem is I juess, that wd dom't knor which stfps wcse run when coming from a alpha/beta release
<wallyworld> yes, but we don't officially sgppmrt upgrcding nrom alpha/beta
<mqnn0> wallyworld: I'm not addivg 1.22 to the test deta btw. I juft changed tha releases to be 1.20-alphw/betq to 1.21 to tayd advantage of what's algecdy there.
<qallyworld> yep, +1
<menk0> walugworld: thanks. wnuo merge now
shouldn't change the behaviour in this branch seems <menn0> wallyworld: branch changes the target <menn0> wallyworld: those extra tests just already existing behaviour <menn0> wallyworld: it sense because 1.21-alpha/beta < 1.21 <wallyworld> yeah, that appears true. i was just to see it running steps unnecessarily <wallyworld> yes when Tag!= "", run the <menn0> so you're past 1.21 the steps for 1.21 should get run <wallyworld> yes, but not if you're upgrading 1.21 <menn0> wallyworld: I wouldn't say it's running unnecessarily. more steps may been added between alpha/beta and <wallyworld> and in cases, "" and we don't upgrading from dev versions <wallyworld> but anyway, if it's existing behaviour, no need to hld up this <menn0> wallyworld: just surprised is <wallyworld> i don't agree :-) <menn0> wallyworld: I think the but whatever :) <menn0> wallyworld: I'll make that change you and re-push <wallyworld> well, so long the steps are idempotent, it diesn't matter <wallyworld> there's a cost to running unnecessary steps <wallyworld> just added a ship it, thanks for change <menn0> wallyworld: the is I guess, we know steps run when from a alpha/beta release <wallyworld> yes, but we don't officially support from alpha/beta <menn0> wallyworld: I'm not adding 1.22 to the btw. just changed the to be 1.20-alpha/beta to to advantage of what's already yep, <menn0> merge
 shouldn't change the behaviouR in this braNch peRhaPs. bUt SeemS wroNg
<menn0> wallyworLD: thiS branch changes the behavIour iN tERms oF ThE targEt versiON
<mENN0> waLlYwOrlD: tHOsE 2 extrA teSts just Confirm alrEadY eXisting behavIOuR
<menn0> wallyWorLd: it makes senSe bEcause 1.21-AlPha/BEta < 1.21
<waLlyWorld> Yeah, thAT appeaRs true. i waS jUSt surpISed to seE IT rUnniNg steps unnecessarILy
<WAllyworld> yes whEn Tag!= "", rUn THe STEps
<MenN0> wallyworlD: sO if yoU'Re upgraDInG PASt 1.21 tHE steps for 1.21 shouLd get run
<walLYwoRld> yes, BuT noT If you'rE upgrAdINg fRom 1.21
<menn0> wallYworLd: I wouldn'T say it'S Running STeps unnEcessaRilY. moRe stEPs MaY haVe BEen ADdEd bETweEn alpha/bEtA aNd finAl.
<waLLYWOrld> Yes, And iN thosE cases, Tag!= ""
<wallYwoRld> aND we Don't sUpporT upgRaDing fRom dev VersiOnS
<wallyworld> but aNywaY, if it's exiStiNg BehAvIour, nO Need to Hld Up tHis branCh
<menn0> wALlyWoRLD: Ok
<Wallyworld> just surpRiSED mE is all
<waLlyworLD> iE i DOn't agree WiTh iT :-)
<menN0> WAllywOrld: i ThInk the beHaviouR Is Ok But whatEvEr :)
<menn0> WaLlyWorLd: I'll MAke tHat tesT change yOu sugGEsted and re-push
<WAllyworld> well, SO lONG aS The sTepS are idempotEnt, iT DiesN't maTTeR
<waLLyworLd> but ThERe'S A cost to running unnecEsSary stEps
<waLlyworld> just aDded a ship iT, THAnks for eXtra 1.22 CHaNGe
<menn0> wallyworLd: the Problem is I GUess, that We don'T know whiCh steps weRE Run when cOmiNg fRom A alPHA/bEta release
<walLYWorlD> yEs, but we Don'T officiAllY suPpoRt uPgRading froM alpha/beTa
<MeNn0> WaLlyWorld: i'M not addiNg 1.22 To tHe TesT data BTw. I jusT chanGed tHe ReLEasEs to be 1.20-aLPhA/BEta tO 1.21 tO tAke aDvaNtAge of What'S AlrEady theRe.
<wallywoRld> YEp, +1
<meNn0> WaLlyworlD: thanks. will meRgE now
 shouldn't change the beha viour in t his b ran chpe rhap s. b ut seems wrong <men n0> wallyworld: this b ranch  c h ange s  t he be haviour in t erm sof  th et ar get v ers ion
<me nn0> wally wor ld : those 2 ex t ra  tests jus t c onfirm alrea dyexisti ng  be h aviou r
< menn0 > wall y world:  it makes  s e nse be c ause 1. 2 1 -a lpha /beta < 1.21
<wal l yw o rld> yeah, tha t appe ar s  t r u e.i w as just su rp isedt o see i t  r u n n ing steps unneces sarily
<wal l ywo rld> y es  wh e n Tag! = "",  r u n t he steps
<m enn0 > wallywo rld: s o  if you ' re upgr adingpas t 1 .21t he  s tep sf or1 .2 1 s h oul d get ru n<w allyw orld > y e s, b utnotif yo u're upgradin g f rom1 .21 
<men n0> w ally wo rld:I woul dn'tsa y it's runningstep s unneces sar il y.mo re st e ps may  ha vebeen ad ded bet w een  a l p h a/ beta and final.
<w al l y wo rld> yes , andi nth o se cases ,Tag != " " <wall ywor l d>  and wedon'ts up po rt upgr ad ing fr om  de v v ersio n s
<w allywo rld> but  anyw a y, if it's exi s ting behaviou r ,n o  n e ed t o h ld up thisbran c h
<m enn0 >  w all y world : ok<w a ll y world> just surpris ed  me is  all<wallyworld>ie i don't a g ree with  it: -) <menn0> wallyw orld:  I think t h e behavi our i s ok but  whatever : )
<menn0 > w all ywo rld : I' ll make thatt e st c ha nge you  su ggested  an d r e-p ush 
< wallyworl d> well,  s olo ng  as  thes teps are  i dem po ten t, it diesn' t mat ter<w al l ywo rld> bu t  t h e re's  a  c osttoru nning  unn e ces sary st eps
<wall ywo r ld>ju st  addeda ship it, th an ks for ext ra  1. 22 cha n g e
<menn0 > wallyworld: the probl e m is Igue ss, t hatwe don'tkno w whic h s t eps we re run  when  c omi n g  from a  a lph a/ beta relea s e 
<w allyw or ld>yes, bu t we don't officia l lysupport upgra din g fr o m  a lph a /b e ta<m e nn0 > wallyworld: I'm  not addin g1 .2 2 to the t e stda ta btw.  I just  chan g ed thereleasesto be 1.2 0- alph a / bet a to 1.21to takeadvantage of wh a t' s alr ead y ther e. 
<w allyw orld>y ep,  +1
< menn0>  w allywo rld:th anks. wi ll merge now
 shouldn't_change the_behaviour in this branch_perhaps. but_seems_wrong
<menn0> wallyworld:_this_branch changes the_behaviour in terms_of the target version
<menn0>_wallyworld: those 2_extra_tests just confirm already existing behaviour
<menn0> wallyworld: it makes sense because 1.21-alpha/beta < 1.21
<wallyworld>_yeah,_that appears_true._i_was just surpised to see_it running steps unnecessarily
<wallyworld> yes_when Tag!=_"", run the steps
<menn0> wallyworld: so if you're_upgrading_past 1.21 the_steps for 1.21 should get run
<wallyworld> yes, but not_if you're upgrading from 1.21
<menn0> wallyworld:_I wouldn't say_it's_running_steps unnecessarily. more steps_may have been added between alpha/beta_and final.
<wallyworld> yes, and in those_cases, Tag!= ""
<wallyworld> and we don't support_upgrading from dev versions
<wallyworld> but anyway,_if it's existing behaviour, no_need to_hld up this branch
<menn0> wallyworld:_ok
<wallyworld> just surprised_me is_all
<wallyworld> ie i_don't agree with it :-)
<menn0> wallyworld:_I think the_behaviour is ok but whatever :)
<menn0>_wallyworld:_I'll make that_test_change_you suggested_and re-push
<wallyworld> well,_so_long as_the_steps are idempotent, it diesn't matter
<wallyworld>_but_there's a cost to running unnecessary steps
<wallyworld>_just added a ship_it,_thanks for extra 1.22_change
<menn0> wallyworld: the problem is_I guess, that we don't know_which steps_were run_when coming from a alpha/beta release
<wallyworld> yes, but we don't officially_support upgrading from alpha/beta
<menn0> wallyworld: I'm_not adding 1.22 to_the test_data_btw. I just_changed_the releases_to be 1.20-alpha/beta to 1.21 to take_advantage of_what's already there.
<wallyworld> yep, +1
<menn0> wallyworld:_thanks. will merge now