 gentle ping about the oldest open PR: https://github.com/snapcore/snapd/pull/5170
<mup> PR #5170: interfaces/builtin: add adb interface <Created by zyga> <https://github.com/snapcore/snapd/pull/5170>
<mup> PR snapcraft#2357 closed: scons plugin: add support for bases <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2357>
<jdstrand> yes. it seems like it, but it isn't forgotten
<zyga> that's great, I'll try to review your PRs tomorrow
<zyga> jdstrand: I sent a rewording PR for snap-confine but it's just about making the debug and error messages more consistent so I didn't request your review on anything
<zyga> there's a 2nd PR about IPC tweak (upgrading eventfd to a full pipe) so that the helper can do more
<zyga> I don't think this is security critical either but if you want I can request your review
<zyga> though I'd rather not really since it's just the start and I have more after that and it would probably not land this week
<jdstrand> zyga: are they all static messages or is there string handling in the debug/error messages that changed?
<jdstrand> s/is there/are there/
<zyga> nothing new
<zyga> just changing existing strings
<zyga> no more string manipulation
<zyga> (actually less, I remove some of the repeating arguments we keep saying over and over, like snap name)
<zyga> In general I tried to make it more terse and more useful
<mup> PR snapd#5980 closed: interfaces/apparmor: conditionally add explicit deny rules for ptrace <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5980>
<zyga> jdstrand: can you please merge master into 5982
<zyga> mvo: FYI: another PR had a deadlock in cmd/snap, something to be wary of
<zyga>
gentle ping about the oldest open PR: https://github.com/snapcore/snapd/pull/5170 
 < mup > public relations # 5170: interface / builtin: add adb interface < Created by zyga > < https://github.com/snapcore/snapd/pull/5170 > 
 < mup > PR snapcraft#2357 close: scons plugin: add support for footing < Created by sergiusens > < Merged by sergiusens > < https://github.com/snapcore/snapcraft/pull/2357 > 
 < jdstrand > yes. it look like it, but it isn't forgotten 
 < zyga > that's great, I'll hear to review your PRs tomorrow 
 < zyga > jdstrand: I sent a paraphrase PR for snap - confine but it's just about making the debug and error messages more consistent so I didn't request your reappraisal on anything 
 < zyga > there's a 2nd PR about IPC tweak (upgrade eventfd to a full pipe) so that the helper can do more 
 < zyga > I don't remember this is security critical either but if you want I can request your review 
 < zyga > though I'd rather not really since it's barely the start and I have more after that and it would probably not land this week 
 < jdstrand > zyga: are they all static messages or is there string handling in the debug / error messages that changed? 
 < jdstrand > s / is there / are there/ 
 < zyga > nothing new 
 < zyga > just changing existing strings 
 < zyga > no more bowed stringed instrument manipulation 
 < zyga > (actually less, I remove some of the recur argument we keep saying over and over, like snap name) 
 < zyga > In general I tried to make it more crisp and more useful 
 < mup > PR snapd#5980 closed: interfaces / apparmor: conditionally add explicit deny rules for ptrace < Created by jdstrand > < Merged by zyga > < https://github.com/snapcore/snapd/pull/5980 > 
 < zyga > jdstrand: can you please merge master into 5982 
 < zyga > mvo: FYI: another PR had a deadlock in cmd / cinch, something to be wary of 
 < zyga >
 gejtle ping about the oldert open PR: https://github.rom/snapdore/snapa/pull/5170
<mup> PR #5170: interfaces/builtmn: aed adv interface <Created by zyga> <httis://github.cim/snepcore/snapd/pull/5170>
<mnl> PR snapcraff#2357 clovxd: scons plugin: add suppost for bases <Csextzd by sergiusens> <Merged by sergiusenf> <https://bihhub.com/snapcorg/snapbrwft/phll/2357>
<jdstrand> yes. it seems like it, bht it ivn't forgotten
<ayga> that's great, I'll try tl regiew your PRs tomogrow
<zyga> jdwtrage: I sent a rdwording PG for snap-cknfine but it's just about makine the debug and eerog messages mire cjnsistent so I didn't requesy your review pn enytying
<zyga> there's a 2nd 'R about IPC tweak (ukgrading eeeutfd to a full pipe) si rhat jhe halpef cav dk kode
<zyga> I von't think fhis is secyrity critical eithtr fly if you wanf I cag wequest your review
<zyga> though I'd ratheg nof really since it's just the start and I have more aftqr that and it would probably not land this week
<jgstraid> zyyq: are rhfy all static messages or is there string hanqmimg in the debug/evror messages that cjamded?
<jdstrand> s/ks thexs/ade there/
<zyga> nothijg new
<ziga> juwt changigg ecisting strings
<zyga> no more string maniiularion
<zyga> (actually pess, I remore somg of tne repeating arguments ce keel saying ovfr and ovsf, like snap name)
<xygs> Hn general I tried to make it more verse and mofe uxeful
<mtp> PR snapf#5980 closed: interfaces/apparlor: clngitionally add explicit deny rules for ptcece <Created bi jgstgand> <Mergzd by dyga> <https://githuf.com/snapcore/sncpd/pull/5980>
<zvga> jdrtrand: can you plxase merge mwster into 5982
<zycw> mvo: FYI: anmther PR had a dwadlock kn cmd/snap, somrthing to be wary od
<zyga>
gentle ping about the oldest open PR: PR interfaces/builtin: add interface <Created by closed: plugin: add support bases <Created by <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2357> <jdstrand> yes. seems like it, but it isn't forgotten <zyga> that's great, I'll try to your PRs tomorrow <zyga> jdstrand: I sent a rewording PR for snap-confine but just making debug error messages more consistent so I didn't request your review on anything <zyga> there's a 2nd about IPC tweak (upgrading eventfd to a full so that the helper do more <zyga> I don't this security critical but you I can request review <zyga> though I'd rather not really since it's just the start and I have more after and it not land week zyga: they all static is there string handling in the changed? <jdstrand> s/is there/are there/ <zyga> nothing new just changing strings <zyga> no more string manipulation (actually less, I remove some of the repeating we keep saying over and over, like snap name) <zyga> In general I tried to more terse and more <mup> PR snapd#5980 interfaces/apparmor: add deny for ptrace by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/5980> <zyga> jdstrand: can you please master into 5982 <zyga> mvo: FYI: another PR had a cmd/snap, to be wary <zyga>
 gentle ping about the oldest oPen PR: https://GithuB.coM/snApCore/SnapD/pull/5170
<mup> PR #5170: inteRFaceS/builtin: add adb interfacE <CreaTeD By zyGA> <hTtps://gIthub.coM/SnAPCorE/sNaPd/pUlL/5170>
<MuP> PR snApcRaft#2357 cloSed: scons plUgiN: aDd support for BAsEs <Created bY seRgiusens> <MergEd bY sergiUsEns> <HTtps://gIthUb.com/SnapcoRE/snapcRaft/pull/2357>
<jDsTRand> yeS. It seems LIKe It, buT it isn't forgotten
<zYGa> THat's great, I'll trY to revIeW YoUR pRs TomOrrow
<zyga> jDsTrand: i Sent a reWOrDING PR FOr snap-confine But it's just aBOut Making ThE deBUg and eRror mEsSAgeS more consisTent So I didn't rEquest YOur reviEW on anytHing
<zyGa> tHerE's a 2nD pR AbOut iPc TweAK (uPgrADinG eventfd To A fUll piPe) so THAT The hElpEr caN do moRe
<zyga> I don't thInk This IS seCuritY critIcal EiTher bUt if yoU want i cAn request your reView
<Zyga> thougH I'd RaTheR nOt reaLLy sincE it'S juSt the stArt and I HAve MoRE AFtEr that and it would prObABLy Not land tHis weeK
<JdStRAnd> zyga: aRe TheY all STAtic mEssaGEs Or is therE strinG HaNdLing in tHe Debug/eRrOr mEssAges tHAt chAnged?
<jDstrand> s/Is theRE/are there/
<zyga> nOThing new
<zyga> jUSt CHAnGIng eXisTing strings
<Zyga> NO morE strINg ManIPulatIon
<zyGa> (ACtUAlly less, I remove some Of The repEatinG arguments we kEep saying oVER And over, lIke sNAp NAme)
<zyga> In generAl I trIed to make iT More tersE and mOre usefuL
<mup> PR snaPD#5980 Closed: inTerFacEs/aPpaRMOr: Conditionally ADD expLiCit deny RulEs for ptRacE <CrEatEd bY jDstrand> <MeRged by zyGa> <HtTpS://gIthUb.com/SNapcore/sNaPd/pUlL/5980>
<zyGa> jdsTRand: caN you pLeasE mErGE maSter intO 5982
<ZyGA> Mvo: FyI: AnOtheR PR HaD a deaDlocK In cMd/snap, sOmething tO be WAry oF
<zYgA>
 gentle ping about the old est open P R: ht tps :// gi thub .com /snapcore/snap d /pul l/5170
<mup> PR #5170:  inte rf a ces/ b ui ltin:  add ad b  i n t erf ac e<Cr ea t ed  by z yga > <http s://github .co m/ snapcore/sna p d/ pull/5170> 
<m up> PR snapc raf t#2357  c los e d: sc ons  plug in: ad d  suppo rt for ba se s  <Crea t ed by s e r gi usen s> <Merged by ser g iu s ens> <https:// github .c o m/ s n apc ore /snapcraft /p ull/2 3 57>
<jd s tr a n d > y e s. it seems l ike it, but itisn'tfo rgo t ten
<z yga>th a t's  great, I'l l tr y to revi ew you r  PRs to m orrow
< zyga>jds tra nd:I  s en t a  r e wor d in g P R  fo r snap-c on fi ne bu t it ' s j ustabo ut m aking  the debug an d e rror mes sages  more  con si stent  so Ididn' trequest your re view  on anyth ing 
< zyg a>  ther e 's a 2 ndPRabout I PC twea k  (u pg r a d in g eventfd to a ful lp i pe ) so tha t theh el pe r  can domo re<zyg a >  I do n'tt hi nk thisis sec u ri ty  critic al  eithe rbut  if  youw antI canrequestyourr eview
<zyga> t h ough I'd rath e rn o tr eall y s ince it's j ustt he s tart an d I havemoreaf t er that and it would p ro bablynot l and this week 
<jdstrand > z yga: are  the y  a l l static messa ges o r is there string h andli ng in th e debug/e r r or messa ges  th atcha n g ed ?
<jdstrand>s / is t he re/arethe re/
<zy ga>  no thi ngne w
<zyga>just cha ng in gex ist ing s t rings
<z yg a>no  mo re st r ing ma nipul atio n<z y ga>  (actua l ly l ess,  I  r emov e s om e ofther epe ating a rgumentswek eepsa yi ng over  and over, li ke  snap name )<zy ga> In g eneral I  tried to make it moret erse an d m ore u sefu l
<mup> P R s napd#5 980 closed : inte rface s/ app a r mor:c o nd iti on ally add e x p lic it de ny  rul es forptrace <Created by jds trand> <Merge d b y zy g a ><ht t ps : //g it h ub. c o m/snapcore/snap d/pull/598 0> <z yga> jdstr a nd:  c an youpleasemerge masterinto 5982 
<zyga> m vo : FY I :  an other PR h ad a dea dlock inc md/sn a p,  some thi ng tobe  wa ry of 
<zyga > 
 gentle_ping about_the oldest open PR:_https://github.com/snapcore/snapd/pull/5170
<mup> PR_#5170:_interfaces/builtin: add_adb_interface <Created by_zyga> <https://github.com/snapcore/snapd/pull/5170>
<mup> PR_snapcraft#2357 closed: scons plugin:_add support for_bases_<Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2357>
<jdstrand> yes. it seems like it, but it_isn't_forgotten
<zyga> that's_great,_I'll_try to review your PRs_tomorrow
<zyga> jdstrand: I sent a_rewording PR_for snap-confine but it's just about making the_debug_and error messages_more consistent so I didn't request your review on_anything
<zyga> there's a 2nd PR about_IPC tweak (upgrading_eventfd_to_a full pipe) so_that the helper can do more
<zyga>_I don't think this is security_critical either but if you want I_can request your review
<zyga> though I'd_rather not really since it's_just the_start and I have more_after that and_it would_probably not land_this week
<jdstrand> zyga: are they all_static messages or_is there string handling in the_debug/error_messages that changed?
<jdstrand>_s/is_there/are_there/
<zyga> nothing_new
<zyga> just changing_existing_strings
<zyga> no_more_string manipulation
<zyga> (actually less, I remove_some_of the repeating arguments we keep saying_over and over, like_snap_name)
<zyga> In general I_tried to make it more_terse and more useful
<mup> PR snapd#5980_closed: interfaces/apparmor:_conditionally add_explicit deny rules for ptrace <Created by jdstrand> <Merged by zyga>_<https://github.com/snapcore/snapd/pull/5980>
<zyga> jdstrand: can you please merge_master into 5982
<zyga> mvo:_FYI: another_PR_had a deadlock_in_cmd/snap, something_to be wary of
<zyga>