 :)
<wallyworld_> np, it was an educated guess :-)
<mattyw> morning all
<voidspace> morning all
<TheMue> mattyw, voidspace: heya
<mattyw> TheMue, morning morning
<fwereade> voidspace, would you be free to take a look at a couple of gsamfira's PRs? https://github.com/juju/juju/pull/782 https://github.com/juju/juju/pull/833
<fwereade> voidspace, gsamfira: I should be able to get to them later, but I realised I broke something in the uniter and I'm focused on unbreaking it
<gsamfira> fwereade: heh, no worries
<fwereade> and if anyone *else* is free -- jam, dimitern maybe? -- http://reviews.vapour.ws/r/288/diff/# is the code, on which I'd really a appreciate a logic/style pre-review, but I haven't yet fixed all the tests (sigh)
<jam> fwereade: looking
<jam> fwereade: is "State().Members" a map and you want the keys to be in the member name slice?
<jam> (I wonder if memberName, _ :=  would be an obvious way to write that)
<jam> at least, I first read it as "Members is a slice" and we just want to copy the slice, but then iteration doesn't work like that :)
<jam> fwereade: I also thought: "contextRelations := map[int]*ContextRelation{}" was bad form because you end up with a nil map, you actually want make() there, don't you?
<jam> hmm. play.golang says I'm wrong
<jam> var x map[int]string is a nil map, but x := map[int]string{} is an empty map
<voidspace> jam: have you picked up both PRs or should I look at one?
<jam> voidspace: I'm looking at fwereade's not gsamfira's
<voidspace> jam: ah, cool
<voidspace> fwereade: sure, I'll look at the gsamfira reviews
<fwereade>
:) 
 < wallyworld _ > np, it was an educated guess :-) 
 < mattyw > morning all 
 < voidspace > morning all 
 < TheMue > mattyw, voidspace: heya 
 < mattyw > TheMue, morning dawn 
 < fwereade > voidspace, would you be spare to take a look at a couple of gsamfira's PRs? https://github.com/juju/juju/pull/782 https://github.com/juju/juju/pull/833 
 < fwereade > voidspace, gsamfira: I should be able to receive to them later, but I realised I dampen something in the uniter and I'm focused on unbreaking it 
 < gsamfira > fwereade: heh, no worries 
 < fwereade > and if anyone * else * is complimentary -- jam, dimitern maybe? -- http://reviews.vapour.ws/r/288/diff/ # is the code, on which I'd very a appreciate a logic / style pre - review, but I haven't yet specify all the tests (sigh) 
 < jam > fwereade: looking 
 < jam > fwereade: is " State().Members " a map and you want the keys to be in the member name piece? 
 < jam > (I wonder if memberName, _: =   would be an obvious way to write that) 
 < jam > at least, I first understand it as " Members is a slice " and we just desire to copy the cut, but then iteration doesn't work like that :) 
 < jam > fwereade: I also thought: " contextRelations: = map[int]*ContextRelation { } " was regretful form because you end up with a nil map, you actually want make () there, don't you? 
 < jam > hmm. play.golang say I'm wrong 
 < jam > var x map[int]string is a nil map, but x: = map[int]string { } is an empty map 
 < voidspace > jam: have you picked up both PRs or should I look at one? 
 < jam > voidspace: I'm looking at fwereade's not gsamfira's 
 < voidspace > jam: ah, cool 
 < voidspace > fwereade: sure, I'll look at the gsamfira reviews 
 < fwereade >
 :)
<waplyworld_> np, it was an edmcated guess :-)
<matjyq> mornmng all
<boidspacd> morning all
<TheMue> mattyw, vliespact: heya
<mattyw> TheMue, morning lorning
<fqereede> voidspace, wonmd you nz fres to caje a look at a couple of gsamfira's PRs? hgt's://github.com/juju/juju/pull/782 https://github.cjm/juju/jijk/pull/833
<fwereade> doidx[ace, gsamfira: I should be able to get fo them later, but I tealised I broke something in hhe uniter and I'm vocused on ohbrqqking it
<gsamwira> fwereade: heh, no wkrries
<fwereade> and if anyone *elre* is free -- jam, dumihgrn maybe? -- hvtp://revpews.vapour.ws/r/288/diff/# is dhe codr, on which I'd veallb a qppreciate a logic/styne pre-review, but I haven't yat fixed all the tewtw (sigv)
<jam> fwefwadd: lkolihg
<jam> vweceade: is "Stzte().Members" q map and you want uhe jeys to be in the mqmfer name slice?
<jam> (I wonder if memberNamt, _ :=  sould be an obvious way to write that)
<jam> at peast, I fyrst read it as "Members is a slice" and we just watt to zopv the roife, but then iteration doesn't work like that :)
<jwj> gwvreade: I also thomght: "contextRelatipnd := iap[int]*ContextTelatiou{}" wzs bad form becausf you egd up with a nyl msp, you actually want make() tyere, don't yol?
<jam> hmm. play.golang savs I'm wrong
<jcm> var x mal[int]string is a nil map, but x := map[int]shring{} is zv empty map
<voidsoacv> jak: have you picked up both [Rs or shiuld I look at pne?
<jam> voidspace: I'm looking at fwereade's not ysamfhra's
<voidspwce> jam: ah, cool
<voidspace> fwereavx: sure, I'll lopk at the gsaifira reviews
<fwerewde>
:) <wallyworld_> np, it was an educated <mattyw> all <voidspace> all <TheMue> mattyw, morning voidspace, would you free to take look at a couple of gsamfira's https://github.com/juju/juju/pull/782 https://github.com/juju/juju/pull/833 <fwereade> voidspace, gsamfira: I should be able to get to them but I realised I broke something in the uniter and I'm focused on it fwereade: no <fwereade> and if anyone *else* is free -- jam, dimitern maybe? -- http://reviews.vapour.ws/r/288/diff/# is the code, which I'd really a appreciate a logic/style pre-review, I haven't yet fixed the tests (sigh) <jam> fwereade: <jam> is "State().Members" map you the keys to in the member name slice? <jam> (I wonder if memberName, _ := would be an obvious way write that) least, I read as is a slice" just want to copy the slice, doesn't work like that :) <jam> fwereade: I thought: "contextRelations map[int]*ContextRelation{}" was bad form because you up with a nil map, you actually want there, don't you? <jam> hmm. play.golang says I'm wrong <jam> var x map[int]string is a but x := map[int]string{} an empty map jam: you up PRs or I look at one? <jam> voidspace: I'm looking at fwereade's not <voidspace> jam: ah, cool <voidspace> fwereade: sure, I'll look at reviews
 :)
<wallyworld_> np, it was an educatEd guess :-)
<matTyw> moRniNg aLl
<VoidSpacE> morning all
<ThemUe> maTtyw, voidspace: heya
<mattyW> TheMUe, MOrniNG mOrninG
<fwereaDE> vOIDspAcE, wOulD yOU bE free To tAke a looK at a couple Of gSaMfira's PRs? httPS://gIthub.com/juJu/jUju/pull/782 https://GitHub.com/JuJu/jUJu/pulL/833
<fwEreadE> voidsPAce, gsaMfira: I shoUlD Be able TO get to tHEM lAter, But I realised I brokE SoMEthing in the uniTer and i'm FOcUSEd oN unBreaking it
<GsAmfirA> FwereadE: HeH, NO WorRIes
<fwereade> anD if anyone *elSE* is Free -- jaM, dImiTErn mayBe? -- httP://rEVieWs.vapour.ws/r/288/Diff/# Is the code, On whicH i'd reallY A apprecIate a lOgiC/stYle pRE-rEvIew, BuT i haVEn'T yeT FixEd all the TeStS (sigh)
<Jam> fWEREAde: lOokIng
<jAm> fweReade: is "State().MEmbErs" a MAp aNd you Want tHe keYs To be iN the meMber nAmE slice?
<jam> (I wondeR if mEmberName, _ :=  WouLd Be aN oBviouS Way to wRitE thAt)
<jam> at Least, I fIRst ReAD IT aS "Members is a slice" anD wE JUsT want to cOpy the SLiCe, BUt then itErAtiOn doESN't worK likE ThAt :)
<jam> fweReade: I ALsO tHought: "cOnTextReLaTioNs := mAp[int]*cOnteXtRelaTion{}" was bAd forM Because you end uP With a nil map, yoU AcTUAlLY wanT maKe() there, don't You?
<jAM> hmm. Play.GOlAng SAys I'm Wrong
<JaM> VaR X map[int]string is a nil MaP, but x := mAp[int]String{} is an empTy map
<voidsPACE> jam: have You pICkED up both PRs or shOuld I Look at one?
<jAM> voidspaCe: I'm lOoking at Fwereade's NOT gsamfirA's
<vOidSpaCe> jAM: Ah, Cool
<voidspace> FWEreaDe: Sure, I'll LooK at the gSamFirA reVieWs
<Fwereade>
 :)
<wallyworld_> np, it w as an educ atedgue ss:- )
<m atty w> morning all <voi dspace> morning all
<T heMue >m atty w ,voids pace: h e ya < mat ty w>  Th eM u e,  morn ing  mornin g
<fweread e>vo idspace, wou l dyou be fre e t o take a loo k a t a co up leo f gsa mfi ra'sPRs? h t tps:// github.co m/ j uju/ju j u/pull/ 7 8 2http s://github.com/ju j u/ j uju/pull/833
< fwerea de >  v o i dsp ace , gsamfira :I sho u ld be a b le t o  ge t  to them late r, but I re a lis ed I b ro kes omethi ng in  t h e u niter and I 'm f ocused on  unbre a king it <gsamfi ra> fw ere ade : he h ,no  wo rr i es< fw ere a de>  and ifan yo ne *e lse* i s free  --  jam , dim itern maybe?--http : //r eview s.vap our. ws /r/28 8/diff /# is  t he code, on whi ch I 'd really  aap pre ci ate a logic/ sty lepre-rev iew, bu t  Iha v e n 't  yet fixed all the  t e s ts  (sigh)<jam>f we re a de: look in g
< jam> f werea de:i s"State() .Membe r s"  a  map an dyou wa nt  th e k eys t o  bein the  membernames lice?
<jam> (I wonder if mem b er N a me ,  _ : = would be an  obv i ouswayt owri t e tha t)
<j am >  a t  least, I first rea dit as"Memb ers is a slic e" and wej u s t want t o co p yt he slice, buttheniterationd oesn't w ork l ike that  :)
<jam> f wereade:  Ials o t hou g h t:  "contextRela t i ons:=  map[in t]* Context Rel ati on{ }"wa s bad for m becaus eyo uen d u p wit h  a nil m ap , y ou  ac tuall y  wantmake( ) th er e, don 't you? <j a m > hm m.  p lay. gol an g say s I' m  wr ong
<ja m> var xmap [ int] st ri ng is a  nil map, but  x  := map[in t] str ing{}i s  an empt y map
<voidspace> jam:h ave you  pi ckedup b oth PRs o r s houldI l o ok atone?
< jam>vo ids p a ce: I ' m  l ook in g at fwere a d e's  notgs amfi ra's
<v oidspace> jam: ah, coo l
<voidspace>  fw erea d e :sur e ,I 'll  l o oka t  the gsamfira r eviews
<fw er e ad e>
 :)
<wallyworld_>_np, it_was an educated guess_:-)
<mattyw> morning_all
<voidspace>_morning all
<TheMue>_mattyw,_voidspace: heya
<mattyw> TheMue,_morning morning
<fwereade> voidspace,_would you be free_to take a_look_at a couple of gsamfira's PRs? https://github.com/juju/juju/pull/782 https://github.com/juju/juju/pull/833
<fwereade> voidspace, gsamfira: I should be able_to_get to_them_later,_but I realised I broke_something in the uniter and_I'm focused_on unbreaking it
<gsamfira> fwereade: heh, no worries
<fwereade> and_if_anyone *else* is_free -- jam, dimitern maybe? -- http://reviews.vapour.ws/r/288/diff/# is the_code, on which I'd really a_appreciate a logic/style_pre-review,_but_I haven't yet fixed_all the tests (sigh)
<jam> fwereade: looking
<jam>_fwereade: is "State().Members" a map and_you want the keys to be in_the member name slice?
<jam> (I wonder_if memberName, _ := _would be_an obvious way to write_that)
<jam> at least,_I first_read it as_"Members is a slice" and we_just want to_copy the slice, but then iteration_doesn't_work like that_:)
<jam>_fwereade:_I also_thought: "contextRelations :=_map[int]*ContextRelation{}"_was bad_form_because you end up with a_nil_map, you actually want make() there, don't_you?
<jam> hmm. play.golang says_I'm_wrong
<jam> var x map[int]string_is a nil map, but_x := map[int]string{} is an empty_map
<voidspace> jam:_have you_picked up both PRs or should I look at one?
<jam> voidspace:_I'm looking at fwereade's not gsamfira's
<voidspace>_jam: ah, cool
<voidspace> fwereade:_sure, I'll_look_at the gsamfira_reviews
<fwereade>