wereade would have looked, but I'm prepared to land it now
<axw> thumper: lemme take another quick look
<thumper> cheers
<sinzui> thumper: I have added github.com/juju/retry. We wont know it works until there is a branch to merge. Since there isn't a branch there now, I don't know which packages deps it imports.
<thumper> sinzui: https://github.com/juju/retry/pull/1
<sinzui> thank youn thumper. I will quickly add the deps I see
<thumper> cheers
<axw> thumper: reviewed
<thumper> axw: ta
<thumper> sinzui: I'll try merging now
<thumper> sinzui: is it ready?
<sinzui> thumper: yep, I am watching to procs now
<thumper> sinzui: who handles which repos go to reviewboard?
<sinzui> thumper: I don't know the config. I am sure ericsnow knows.
<thumper> \o/ landed
<sinzui> thumper: I see real go test was really run too
<thumper> as opposed to what?
<sinzui> thumper: the merge job just sending a success without actually merging the branch and running the tests
<thumper> :)
<thumper> I must admit, I do find it pleasing to see more tests than code :)
<sinzui> :))
<davechen1y>                         logger.Debugf("keeping unrecognised existing ssh key %q: %v", key, err)
<davechen1y> ERRORS LOGGED AT DEBUGGG!
<anastasiamac> "some error are more equal than others"? :P
<davechen1y> "some errors are more like guidelines"
<anastasiamac> :P
<davechen1y> thumper: FFS
<thumper> davechen1y: hey
<davechen1y> tried to apply your suggestions to use the errors package, all the fucking tests expect an exact string
<davechen1y> tempted to tell you to stick your recommendation
<thumper>
wereade would have looked, but I'm prepared to land it now 
 < axw > thumper: lemme subscribe another immediate look 
 < thumper > cheers 
 < sinzui > thumper: I have added github.com/juju/retry. We wo nt sleep together it works until there is a arm to blend. Since there isn't a branch there now, I don't know which software deps it imports. 
 < thumper > sinzui: https://github.com/juju/retry/pull/1 
 < sinzui > thank youn thumper. I will quickly lend the deps I see 
 < thumper > cheers 
 < axw > thumper: reviewed 
 < thumper > axw: ta 
 < thumper > sinzui: I'll try merging nowadays 
 < thumper > sinzui: is it ready? 
 < sinzui > thumper: yep, I am watching to procs now 
 < thumper > sinzui: who handle which repos go to reviewboard? 
 < sinzui > thumper: I don't know the config. I am sure ericsnow knows. 
 < thumper > \o/ land 
 < sinzui > thumper: I see real go test was really melt too 
 < thumper > as opposed to what? 
 < sinzui > thumper: the merge job just sending a success without actually merging the branch and running the tests 
 < thumper > :) 
 < thumper > I must admit, I do find it pleasing to see more tests than code :) 
 < sinzui > :)) 
 < davechen1y >                          logger. Debugf("keeping unrecognised existing ssh key% q: % v ", cardinal, err) 
 < davechen1y > ERRORS LOGGED AT DEBUGGG! 
 < anastasiamac > " some mistake are more equal than others "? :P 
 < davechen1y > " some error are more like guidelines " 
 < anastasiamac > :P 
 < davechen1y > thumper: FFS 
 < thumper > davechen1y: hey 
 < davechen1y > tried to apply your suggestions to practice the errors software, all the fucking tests expect an accurate string 
 < davechen1y > tempted to tell you to stick your recommendation 
 < thumper >
werfade would have looked, bmt I'm prepared to land mt now
<asw> thumpdr: lemme take another quick poik
<thunper> cheers
<sinzui> thumoer: I havv added guthuu.com/juju/retry. We wont know it slrks nntil there is s branch tm merge. Since dhdrz isn't a branch there now, I don't knor which pwckages deps ij imppwts.
<tglmker> sinzui: https://github.com/juju/retrg/pull/1
<siizui> thank youn thumper. I will quickly adf thf deps I see
<thumpeg> cheers
<axw> thuiper: reviewed
<ghumper> axw: ta
<thumper> ainzui: I'll try merging now
<thumpdr> siuzui: is it tzqdy?
<dhnzui> thumpxr: yep, I am watchikb to psocs noe
<thumper> sinzul: who habdles which repos go vo reviewboard?
<sinzui> thumper: H bon't know the config. U qm sute erhcsnuq kvowa.
<tiumler> \o/ panved
<sinzui> tgumper: I sew real go test was tewoly run too
<thhmper> ws opposed to what?
<sinzui> thumper: the mergt job just sending a success without actually merhing the franch and running the tests
<thumper> :)
<thumper> I musd admmt, I bi fina ih pleasing to see more tests than code :)
<sinzui> :))
<safebhen1y>                         pobder.Debugf("keepkng unxsckgnised existing sdh key %z: %v", kwy, err)
<davtchen1u> ERRORS LOGGED AT DEBUGGG!
<abastasiamac> "fime error are more equal than othgrs"? :P
<dsvechen1y> "some errors arz more like guidepines"
<anasfxsiamac> :P
<davechev1y> nhum[er: FFS
<thumper> davechen1y: hqy
<davechei1y> trned to aoply your fuggestiond to mve the errors packwge, apl the fuckijg tests expect an exact string
<vevechen1y> tempjed to tell yob to sbick your recomiendation
<thumpgr>
wereade would have looked, but I'm prepared it <axw> thumper: take another quick I added github.com/juju/retry. We know it works there is a branch to merge. there isn't a branch there now, I don't know which packages deps it <thumper> sinzui: https://github.com/juju/retry/pull/1 <sinzui> thank youn thumper. I will quickly add the deps see cheers thumper: <thumper> axw: ta <thumper> sinzui: I'll try merging now <thumper> sinzui: is it ready? <sinzui> thumper: I am watching to procs now <thumper> sinzui: handles which repos go reviewboard? <sinzui> thumper: I don't the I am ericsnow <thumper> landed <sinzui> thumper: see real go test was really run too <thumper> as opposed to what? <sinzui> thumper: the merge just sending without actually the and the tests <thumper> I must admit, I do find see more tests than code :) <sinzui> :)) logger.Debugf("keeping unrecognised ssh key %q: %v", key, err) ERRORS LOGGED AT DEBUGGG! <anastasiamac> "some error are equal than others"? :P <davechen1y> "some errors are more like guidelines" <anastasiamac> :P <davechen1y> thumper: davechen1y: hey <davechen1y> tried apply your suggestions use errors all fucking tests an exact string <davechen1y> tempted to tell you to stick your <thumper>
wereade would have looked, but i'm prepared To lanD it Now
<AxW> thuMper: Lemme take anothER quiCk look
<thumper> cheers
<sinZui> thUmPEr: I hAVe Added Github.cOM/jUJU/reTrY. WE woNt KNoW it woRks Until thEre is a branCh tO mErge. Since theRE iSn't a branch TheRe now, I don't knOw wHich paCkAgeS Deps iT imPorts.
<ThumpeR> Sinzui: Https://githUb.COm/juju/REtry/pulL/1
<SInZui> tHank youn thumper. I wILl QUickly add the dePs I see
<ThUMpER> CheErs
<Axw> thumper: ReVieweD
<Thumper> AXw: TA
<THumPEr> sinzui: I'll trY merging now
<THumPer> sinZuI: is IT ready?
<SinzuI> tHUmpEr: yep, I am watChinG to procs nOw
<thumPEr> sinzuI: Who handLes whiCh rEpoS go tO ReViEwbOaRD?
<siNZuI> thUMpeR: I don't knOw ThE confIg. I aM SURE eriCsnOw knOws.
<thUmper> \o/ landed
<sInzUi> thUMpeR: I see Real gO tesT wAs reaLly run Too
<thUmPer> as opposed to wHat?
<sInzui> thumPer: ThE meRgE job jUSt sendIng A suCcess wiThout acTUalLy MERGiNg the branch and runnInG THe Tests
<thuMper> :)
<thUMpEr> i Must admiT, I Do fInd iT PLeasiNg to SEe More testS than cODe :)
<SiNzui> :))
<davEcHen1y>                         loGgEr.DEbuGf("keePIng uNrecogNised exiSting SSh key %q: %v", key, err)
<dAVechen1y> ERRORS loGged At dEBUgGG!
<AnastasiamaC> "somE ErroR are MOrE eqUAl thaN otheRs"? :p
<DaVEchen1y> "some errors are MoRe like GuideLines"
<anastasiAmac> :P
<davecHEN1Y> thumper: fFS
<tHUmPEr> davechen1y: hey
<DavecHen1y> tried tO Apply youR suggEstions tO use the erRORs packagE, alL thE fuCkiNG TeSts expect an exACT strInG
<davechEn1y> Tempted To tEll You To sTiCk your recOmmendatIoN
<tHuMpEr>
wereade would have looked,  but I'm p repar edtola nd i t no w
<axw> thumpe r : le mme take another quick  look 
< t hump e r>  chee rs
<sin z ui > thu mp er : I  h a ve  adde d g ithub.c om/juju/re try .We wont know it  works unt ilthere is a b ran ch tome rge .  Sinc e t hereisn'ta  branc h there n ow ,  I don ' t knoww h ic h pa ckages deps it im p or t s.
<thumper> s inzui:  h t tp s : //g ith ub.com/juj u/ retry / pull/1< si n z u i>t hank youn thu mper. I wil l  qu icklyad d t h e deps  I se e< thu mper> cheer s
<a xw> thump er: re v iewed
< t humper>  axw:ta<th umpe r >si nzu i: I'l l  t rym erg ing now<t hu mper>  sin z u i :  isitread y?
<s inzui> thumpe r:yep, I a m wat ching  topr ocs n ow
<th umper >sinzui: who han dles  which re pos  g o t orevie w board? 
<s inz ui> thu mper: I don 't k n ow  the config. I amsu r e  e ricsnowknows. <t hu m per> \o/  l and ed
< s i nzui>  thu m pe r: I see  realg ote st wasre ally r un  to o
< thump e r> a s oppo sed to w hat?< sinzui> thumpe r : the merge j o bj u st send ing  a successwith o ut a ctua l ly  me r gingthe b ra n ch and running the tes ts 
<thum per>:)
<thumper>I must adm i t ,  I do fi nd i t  p l easing to seemoretests than code :)<sinz ui> :))<davechen 1 y >                 logger.Debu g f ("ke ep ing unr eco gnisedexi sti ngssh  k ey %q: %v ", key,er r) 
< da vec hen1y >  ERRORSLO GGE DATDEBUG G G!
<an astas iama c>  " s ome  errora re m oreeq ua l th anot hers" ? :P <da vechen1 y> "someerr o rs a re  m ore lik e guidelines" 
< anastasiam ac > : P
<dav e c hen1y> t humper: FFS
<thumper> d a vechen1 y:hey
< dave chen1y> t rie d to a ppl y  yoursugges tions  t o u s e  thee r ro rspa ckage, all t hefucki ng  tes ts expe ct an exact string <da vechen1y> tem pte d to t el l y o ut o s ti c k y o u r recommendatio n
<thumper >
wereade would_have looked,_but I'm prepared to_land it_now
<axw>_thumper: lemme_take_another quick look
<thumper>_cheers
<sinzui> thumper: I_have added github.com/juju/retry. We_wont know it_works_until there is a branch to merge. Since there isn't a branch there now,_I_don't know_which_packages_deps it imports.
<thumper> sinzui: https://github.com/juju/retry/pull/1
<sinzui>_thank youn thumper. I will_quickly add_the deps I see
<thumper> cheers
<axw> thumper: reviewed
<thumper> axw:_ta
<thumper>_sinzui: I'll try_merging now
<thumper> sinzui: is it ready?
<sinzui> thumper: yep, I_am watching to procs now
<thumper> sinzui:_who handles which_repos_go_to reviewboard?
<sinzui> thumper: I_don't know the config. I am_sure ericsnow knows.
<thumper> \o/ landed
<sinzui> thumper:_I see real go test was really_run too
<thumper> as opposed to what?
<sinzui>_thumper: the merge job just_sending a_success without actually merging the_branch and running_the tests
<thumper>_:)
<thumper> I must_admit, I do find it pleasing_to see more_tests than code :)
<sinzui> :))
<davechen1y> __  ___ _  __ __     __ logger.Debugf("keeping unrecognised existing ssh key %q:_%v", key, err)
<davechen1y> ERRORS_LOGGED_AT DEBUGGG!
<anastasiamac> "some error_are more equal than others"?_:P
<davechen1y> "some errors are more like_guidelines"
<anastasiamac> :P
<davechen1y>_thumper: FFS
<thumper>_davechen1y: hey
<davechen1y> tried to apply your suggestions to use the errors_package, all the fucking tests expect_an exact string
<davechen1y> tempted_to tell_you_to stick your_recommendation
<thumper>