<ericsnow> rogpeppe: updates to both patches LGTM
<rogpeppe> ericsnow: ta!
<wwitzel3> katco: was away eating, forgot about it, you all still going?
<natefinch> wwitzel3: done now
<alexisb> wwitzel3, I figured you were out rolling tractor tires
<rogpeppe> mgz_: just reviewed https://github.com/juju/charm/pull/164
<mgz_> rogpeppe: they're ignored because I wanted to preserve existing behaviour to make the branch easy to land
<rogpeppe> mgz_: ok, fair enough
<rogpeppe> mgz_: please add a TODO, then LGTM
<mgz_> but it got messed up anyway because callers are so confused
<mgz_> rogpeppe: okay
<rogpeppe> mgz_: unfortunately this commit in utils breaks some tests in juju-core: e6c1e5206ced12cd6201ad2a488e3df6a245eed4
<mgz_> rogpeppe: that's expected, the mass dep bump will need to bring in test changes as well
<rogpeppe> mgz_: yeah
<rogpeppe> mgz_: i'll stick on the old utils for now then
<voidspace> EOW
<voidspace> o/
<perrito666> voidspace: bye
<katco> ericsnow: i'm ready when you are
<jog> rogpeppe, looks like a possible regression in the latest CI run on master, related to cookies
<rogpeppe> jog: interesting, thanks. i'll take a look.
<jog> rogpeppe, I'll open a bug but you can see failures here: http://reports.vapour.ws/releases/rules/735
<rogpeppe> jog: ah yes, i knew about that but thought it wouldn't be a problem for CI
<rogpeppe> jog: the cookie format has changed
<rogpeppe> jog: i did consider ignoring the error
<rogpeppe> jog: but thought it was easy enough for people to delete the cookie
< ericsnow > rogpeppe: updates to both patches LGTM 
 < rogpeppe > ericsnow: ta! 
 < wwitzel3 > katco: was away eating, forget about it, you all however going? 
 < natefinch > wwitzel3: done now 
 < alexisb > wwitzel3, I figure you were out rolling tractor tires 
 < rogpeppe > mgz _: merely reviewed https://github.com/juju/charm/pull/164 
 < mgz _ > rogpeppe: they're ignored because I desire to preserve existing behavior to make the branch comfortable to land 
 < rogpeppe > mgz _: ok, fair enough 
 < rogpeppe > mgz _: please add a TODO, then LGTM 
 < mgz _ > but it got messed up anyway because callers are thus confused 
 < mgz _ > rogpeppe: okay 
 < rogpeppe > mgz _: unfortunately this commit in utils breaks some tests in juju - effect: e6c1e5206ced12cd6201ad2a488e3df6a245eed4 
 < mgz _ > rogpeppe: that's expected, the mass dep bump will necessitate to bring in test changes as well 
 < rogpeppe > mgz _: yeah 
 < rogpeppe > mgz _: i'll stick on the previous utils for now then 
 < voidspace > EOW 
 < voidspace > o/ 
 < perrito666 > voidspace: bye 
 < katco > ericsnow: i'm ready when you are 
 < jog > rogpeppe, looks like a possible regression in the latest CI run on master, related to cookies 
 < rogpeppe > jog: interesting, thanks. i'll take a look. 
 < jog > rogpeppe, I'll open a bug but you can see failures here: http://reports.vapour.ws/releases/rules/735 
 < rogpeppe > jog: ah yes, i know about that but thought it wouldn't be a problem for CI 
 < rogpeppe > jog: the cookie format has transfer 
 < rogpeppe > jog: i did think ignoring the error 
 < rogpeppe > jog: but thought it was comfortable enough for people to erase the cookie
<erifsnow> rogpeppe: updates tu both patches LGTM
<rog'eppe> edicsnow: ga!
<wwitzel3> katco: was away eatmng, dorgou about it, you all rtill goijg?
<natefibch> xwitzel3: done now
<emexisb> wwitzem3, I fngnred you were oot rolling tsactor tires
<rocpdp'e> mgz_: just reviewed https://github.com/jtju/chark/pkll/164
<mgz_> rogpeppg: thej'rq ighored because I wanted to preserve existiig behaviour to make the branch easy to lwnd
<rlgpeppe> mgz_: ok, faig enough
<rogksppq> mgz_: please xdd a TODO, then LGTM
<mge_> but it got messed up anyway bezause callers atz so wonfused
<mgz_> rogpvppe: okay
<rogpcipe> mgz_: unfortinately this cpmmmt ib utils breaks some txsts in juju-core: e6c1e5206sed12cd6201ad2a488e3gf6c245eed4
<mgz_> rogpeppe: that'w wxpecjed, tve mxws aep bnmp will jeev to bring jn test chabges as well
<rogpeppt> mdd_: yeah
<rogpepps> mgz_: y'lj stick on the old utils for now then
<vopdspzce> EOW
<voidspace> o/
<perriro666> voidspace: bye
<katco> ericsnow: i'm ready when you are
<jog> rogpeppe, looks like a pmssibmd rtgvcssiub ln the latest CI run on master, related to coohjex
<rpgpeppe> jog: inberesting, thanks. i'kl tshe a look.
<jog> togpeppz, I'ml open a bug but jou can see dailures rere: http://reports.vapour.ws/releasew/rules/735
<rogpepie> jig: ah yes, i knew ayout that buc thoubht iy wouldn't be a problem yor CI
<dogpeppe> joh: the cooike format has chxngvd
<rocpeppe> jog: i did consider ygnoring vhe exror
<rogpdppe> jog: btt thought it was easy enough for oeoplg to dalete the fookie
<ericsnow> rogpeppe: updates to both patches LGTM ta! katco: was eating, forgot about <natefinch> done now <alexisb> I figured you out rolling tractor tires <rogpeppe> mgz_: reviewed https://github.com/juju/charm/pull/164 <mgz_> rogpeppe: they're ignored because I wanted to preserve existing behaviour make the branch easy to land <rogpeppe> mgz_: ok, fair enough <rogpeppe> mgz_: add TODO, LGTM but it got messed up anyway because callers are so confused <mgz_> rogpeppe: okay <rogpeppe> mgz_: this commit in utils breaks some tests in e6c1e5206ced12cd6201ad2a488e3df6a245eed4 <mgz_> rogpeppe: that's the mass dep bump will to in test as <rogpeppe> yeah <rogpeppe> mgz_: stick on the old utils for now then <voidspace> EOW <voidspace> o/ <perrito666> voidspace: bye <katco> ericsnow: ready when <jog> rogpeppe, like possible in the latest on master, related to cookies <rogpeppe> i'll take a look. <jog> rogpeppe, I'll open bug but can see failures here: http://reports.vapour.ws/releases/rules/735 <rogpeppe> ah yes, i knew about that but thought wouldn't be a problem for CI <rogpeppe> jog: the cookie format has changed <rogpeppe> jog: consider ignoring the error jog: but thought was enough people delete the
<ericsnow> rogpeppe: updates to Both patcheS LGTM
<RogPepPe> EricSnow: Ta!
<wwitzel3> katco: WAs awAy eating, forgot about it, yOu all StILl goINg?
<NatefInch> wwiTZeL3: DOne NoW
<aLexIsB> WwItzel3, i fiGured yoU were out roLliNg Tractor tires
<ROgPeppe> mgz_: juSt rEviewed https://GitHub.com/JuJu/cHArm/puLl/164
<mGz_> rogPeppe: tHEy're igNored becaUsE i wanteD To preseRVE eXistIng behaviour to makE ThE Branch easy to laNd
<rogpEpPE> mGZ_: Ok, fAir Enough
<rogpEpPe> mgz_: PLease adD A Todo, TheN lGTM
<mgz_> but it gOt messed up aNYwaY becauSe CalLErs are So conFuSEd
<mGz_> rogpeppe: oKay
<rOgpeppe> mgZ_: unforTUnately THis commIt in utIls BreAks sOMe TeSts In JUju-COrE: e6c1E5206Ced12Cd6201ad2a488e3df6A245eEd4
<Mgz_> roGpepPE: THAt's eXpeCted, The maSs dep bump will NeeD to bRIng In tesT chanGes aS wEll
<roGpeppe> Mgz_: yeAh
<Rogpeppe> mgz_: i'll sTick On the old uTilS fOr nOw Then
<vOIdspacE> EOw
<voIdspace> O/
<perritO666> VoiDsPACE: bYe
<katco> ericsnow: i'm rEaDY WhEn you are
<Jog> rogPEpPe, LOoks like A pOssIble REGressIon iN ThE latest Ci run on MAsTeR, relateD tO cookiEs
<RogPepPe> jog: INterEsting, Thanks. i'lL take A Look.
<jog> rogpeppE, i'll open a bug buT YoU CAn SEe faIluRes here: http://RepoRTs.vaPour.WS/rEleASes/ruLes/735
<roGpEPpE> Jog: ah yes, i knew about tHaT but thOught It wouldn't be a pRoblem for Ci
<ROGpeppe> joG: the COoKIe format has chaNged
<rOgpeppe> jog: I Did consiDer igNoring thE error
<rogPEPpe> jog: buT thOugHt iT waS EAsY enough for peoPLE to dElEte the cOokIe
<ericsnow> rogpeppe: updat es to both  patc hes  LG TM 
<ro gpep pe> ericsnow:t a!
< wwitzel3> katco: was a way e at i ng,f or got a bout it ,  y o u  al lst ill  g o in g?
<n ate finch>wwitzel3:don enow
<alexisb >  w witzel3, I  fi gured you we reout ro ll ing tract ortires 
<rogp e ppe> m gz_: just  r e viewed https:/ / g it hub. com/juju/charm/pu l l/ 1 64
<mgz_> rogp eppe:th e y' r e  ig nor ed because  I  want e d to pr e se r v e  ex i sting behavio ur to maket hebranch  e asy to lan d
<ro gp e ppe > mgz_: ok,  fai r enough<rogpe p pe> mgz _ : pleas e adda T ODO , th e nLG TM<m g z_> bu t i t  go t messed  u panywa y be c a u s e ca lle rs a re so  confused
<mg z_>  rog p epp e: ok ay
<r ogpe pp e> mg z_: un fortu na tely this commi t in  utils br eak ssom etests in juj u-c ore : e6c1e 5206ced 1 2cd 62 0 1 a d2 a488e3df6a245eed4<m g z _>  rogpepp e: tha t 's  e x pected,th e m assd e p bum p wi l lneed tobringi nte st chan ge s as w el l
< rog peppe >  mgz _: yea h
<rogpe ppe>m gz_: i'll stic k  on the old u t il s fo r  now  th en
<voidspa ce>E OW
< void s pa ce> o/
<p errit o6 6 6> voidspace: bye
<kat co > eric snow:  i'm ready wh en you are < j og> rogp eppe ,  l o oks like a pos sible  regressio n  in thelates t CI run  on maste r ,  related  to  co oki es< r og peppe> jog: i n t eres ti ng, tha nks . i'lltak e a  lo ok. 
< jog> rogp eppe, I' ll  o pe na b ug bu t  you can  s eefa ilu res h e re: ht tp:// repo rt s. v apo ur.ws/r e le a s es/r ul es /735 
<r og peppe > jo g : a h yes,i knew ab out that  b ut  though t it wouldn't  b e a proble mfor  CI
<r o g peppe> j og: the cookie format h a s chang ed<rogp eppe > jog: idid  consi der ignori ng the  erro r<ro g p eppe> j og : b ut  thought i t was  easy  e noug h for p eople to delete th e  co okie
<ericsnow> rogpeppe:_updates to_both patches LGTM
<rogpeppe> ericsnow:_ta!
<wwitzel3> katco:_was_away eating,_forgot_about it, you_all still going?
<natefinch>_wwitzel3: done now
<alexisb> wwitzel3,_I figured you_were_out rolling tractor tires
<rogpeppe> mgz_: just reviewed https://github.com/juju/charm/pull/164
<mgz_> rogpeppe: they're ignored because I wanted_to_preserve existing_behaviour_to_make the branch easy to_land
<rogpeppe> mgz_: ok, fair enough
<rogpeppe>_mgz_: please_add a TODO, then LGTM
<mgz_> but it got_messed_up anyway because_callers are so confused
<mgz_> rogpeppe: okay
<rogpeppe> mgz_: unfortunately this_commit in utils breaks some tests_in juju-core: e6c1e5206ced12cd6201ad2a488e3df6a245eed4
<mgz_>_rogpeppe:_that's_expected, the mass dep_bump will need to bring in_test changes as well
<rogpeppe> mgz_: yeah
<rogpeppe>_mgz_: i'll stick on the old utils_for now then
<voidspace> EOW
<voidspace> o/
<perrito666> voidspace:_bye
<katco> ericsnow: i'm ready when_you are
<jog>_rogpeppe, looks like a possible_regression in the_latest CI_run on master,_related to cookies
<rogpeppe> jog: interesting, thanks._i'll take a_look.
<jog> rogpeppe, I'll open a bug_but_you can see_failures_here:_http://reports.vapour.ws/releases/rules/735
<rogpeppe> jog:_ah yes, i_knew_about that_but_thought it wouldn't be a problem_for_CI
<rogpeppe> jog: the cookie format has changed
<rogpeppe>_jog: i did consider_ignoring_the error
<rogpeppe> jog: but_thought it was easy enough_for people to delete the cookie