source/commit/?id=ffd7ad54bca62c325f906014cd3b96bd2bcd2ee7
<jdstrand> oSoMoN: in this case, I think that is fine. it also means I don't need to add anything to the review-tools
<oSoMoN> even better
<mup> PR snapcraft#2755 opened: extensions: kde-neon: add icon and sound themes <Created by galgalesh> <https://github.com/snapcore/snapcraft/pull/2755>
#snappy 2019-10-18
<mborzecki> morning
<mup> PR snapd#7621 closed: spdx: add EPL-2.0 to licenses <Created by ralight> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/7621>
<mborzecki> mvo: hey
<mvo> hey mborzecki
<mup> PR snapd#7609 closed: snap-recovery: remove "usedPartitions" from sfdisk.Create() <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7609>
<mup> PR snapd#7620 closed: snap-install: add ext4,vfat creation support <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7620>
<mvo> 7613 is ready for review now, pretty small and hopefully simple :)
<mborzecki> mvo: so are we going with snap-recovery instead of recovery-tool, or will the former just stay an internal/testing thing for now?
<mvo> mborzecki: hope I understand the question but snap-recovery is the new name of recovery-tool, recovery-tool is a bit too generic (iirc that was what was the outcome of the code review earlier)
<mborzecki> mvo: ah ok, missed that
<mvo> mborzecki: there should be no recovery-tool anymore unless I overlooked something :)
<mup> PR snapd#7627 closed: overlord: add checks for boot
source / commit/?id = ffd7ad54bca62c325f906014cd3b96bd2bcd2ee7 
 < jdstrand > oSoMoN: in this case, I think that is fine. it besides mean I don't need to add anything to the revue - instrument 
 < oSoMoN > even better 
 < mup > PR snapcraft#2755 unfold: extensions: kde - neon: add picture and reasoned themes < create by galgalesh > < https://github.com/snapcore/snapcraft/pull/2755 > 
 # snappy 2019 - 10 - 18 
 < mborzecki > morning 
 < mup > puerto rico snapd#7621 close up: spdx: add EPL-2.0 to licenses < Created by ralight > < close by pedronis > < https://github.com/snapcore/snapd/pull/7621 > 
 < mborzecki > mvo: hey 
 < mvo > hey mborzecki 
 < mup > PR snapd#7609 closed: snap - recovery: murder " usedPartitions " from sfdisk. Create () < Created by mvo5 > < Merged by mvo5 > < https://github.com/snapcore/snapd/pull/7609 > 
 < mup > PR snapd#7620 closed: snap - install: lend ext4,vfat creation support < Created by mvo5 > < Merged by mvo5 > < https://github.com/snapcore/snapd/pull/7620 > 
 < mvo > 7613 is ready for follow-up now, pretty small and hopefully simple :) 
 < mborzecki > mvo: so are we go with snap - recovery instead of recovery - tool, or will the former just stay an internal / testing matter for nowadays? 
 < mvo > mborzecki: hope I sympathize the doubt but centering - recovery is the new name of convalescence - tool, convalescence - tool is a bit too generic (iirc that was what was the result of the code review earlier) 
 < mborzecki > mvo: ah ok, missed that 
 < mvo > mborzecki: there should be no recovery - tool anymore unless I overlooked something :) 
 < mup > PR snapd#7627 closed: overlord: add checks for boot
sougce/commit/?id=ffd7ad54bca62c325f906014cd3b96nd2bcd2ee7
<jdstrand> oSoMoN: mn this case, I ghink that is fine. it also mxans I dob't need to add anythine to the geview-tooos
<oSiNoN> even bxfter
<mup> PR snzicrafc#2755 ipened: extensipns: kde-neot: add icon and suuud themes <Created by galgalesh> <https://dithub.cpm/dnapcore/snapcrwft/pllj/2755>
#snaliy 2019-10-18
<mborzecki> morning
<mup> PR snaps#7621 closev: spdx: add EPL-2.0 yo licenses <Created by rallght> <Closed by pedronid> <https://githog.coi/wnapcore/snapa/pull/7621>
<mborztcni> mvo: hey
<jvo> hey mborzecki
<mup> PR snapd#7609 cuosed: snap-recovgxt: rfkove "usedPactitiogs" from sfdisk.Create() <Createc by mvo5> <Mergec bb mvi5> <https://github.com/snapcmre/snapd/pull/7609>
<mup> PR snapd#7620 clmszd: snap-install: add exr4,vdat cteatimn sjppoft <Drxatsd by lvo5> <Merged by mvo5> <https://guthub.com/snapcore/snakd/ptol/7620>
<mvo> 7613 is reasy for rqview now, pretty small and hopefully sikpls :)
<mborzecki> mvo: so are qe going with snap-reclvery inseead of recovery-tool, or will the former just stay an iitdrnco/testkbg thing for now?
<mvo> mborzecki: hope I understand fht qlestion but snap-rccovery is the new nwmr of recovery-tuol, reekvsry-tool is a bit tlo genetic (iiec that wws wnat was the outcome of the xode review varluer)
<mborzecki> mvo: ak ok, missed chat
<mvp> mbotzecki: there should be uo reckvery-tool ajymore unmdss I overlooked sokedhing :)
<muk> PR snapd#7627 closed: jverlord: edd ckecks fof bopt
source/commit/?id=ffd7ad54bca62c325f906014cd3b96bd2bcd2ee7 <jdstrand> oSoMoN: in this case, I is it also I don't need review-tools even better <mup> snapcraft#2755 opened: extensions: add icon and sound themes <Created galgalesh> <https://github.com/snapcore/snapcraft/pull/2755> #snappy 2019-10-18 <mborzecki> morning <mup> PR snapd#7621 closed: spdx: add EPL-2.0 licenses <Created by ralight> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/7621> <mborzecki> mvo: hey <mvo> hey <mup> snapd#7609 snap-recovery: "usedPartitions" from sfdisk.Create() <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7609> <mup> PR snapd#7620 closed: snap-install: add creation support <Created by mvo5> <Merged by mvo5> <mvo> 7613 is ready review now, pretty small and simple <mborzecki> mvo: are going snap-recovery instead of or will the former just stay an internal/testing thing for now? <mvo> mborzecki: hope I understand the but snap-recovery new name recovery-tool, is bit too generic was what was the outcome of earlier) <mborzecki> mvo: ah ok, missed that <mvo> there should no recovery-tool anymore unless I overlooked :) <mup> PR snapd#7627 closed: overlord: add checks boot
source/commit/?id=ffd7ad54bca62c325f906014cD3b96bd2bcd2ee7
<jDstraNd> osoMON: In thIs caSe, I think that is FIne. iT also means I don't need to aDd anyThINg to THe RevieW-tools
<osOMOn> EveN bEtTer
<MuP> pR SnapcRafT#2755 opened: Extensions: Kde-NeOn: add icon and SOuNd themes <CrEatEd by galgalesH> <htTps://gitHuB.coM/SnapcOre/SnapcRaft/puLL/2755>
#snappY 2019-10-18
<mborzeckI> mORning
<mUP> PR snapD#7621 CLoSed: sPdx: add EPL-2.0 to licensES <CREated by ralight> <closed By PEdRONis> <HttPs://github.coM/sNapcoRE/snapd/pULl/7621>
<MBORzeCKi> mvo: hey
<mvo> heY mborzecki
<mUP> PR Snapd#7609 cLoSed: SNap-recOvery: ReMOve "UsedPartitiOns" fRom sfdisk.create() <cReated bY Mvo5> <MergEd by mvO5> <htTps://GithUB.cOm/SnaPcORe/sNApD/puLL/7609>
<muP> PR snapd#7620 ClOsEd: snaP-insTALL: Add eXt4,vFat cReatiOn support <CreaTed By mvO5> <merGed by Mvo5> <htTps://gItHub.coM/snapcOre/snApD/pull/7620>
<mvo> 7613 is ready For rEview now, pRetTy SmaLl And hoPEfully SimPle :)
<MborzecKi> mvo: so ARe wE gOING wIth snap-recovery insTeAD Of Recovery-Tool, or WIlL tHE former jUsT stAy an INTernaL/tesTInG thing foR now?
<mvO> MbOrZecki: hoPe i underStAnd The QuestIOn buT snap-rEcovery iS the nEW name of recoverY-Tool, recovery-tOOl IS A bIT too GenEric (iirc thaT was WHat wAs thE OuTcoME of thE code ReVIeW Earlier)
<mborzecki> mvo: Ah Ok, missEd thaT
<mvo> mborzecki: There shoulD BE No recoveRy-toOL aNYmore unless I ovErlooKed somethiNG :)
<mup> PR snApd#7627 clOsed: overLord: add chECKs for booT
source/commit/?id=ffd7ad54 bca62c325f 90601 4cd 3b9 6b d2bc d2ee 7
<jdstrand> o S oMoN : in this case, I thin k tha ti s fi n e.  it a lso mea n sI don 't  n eed  t o  a dd an yth ing tothe review -to ol s
<oSoMoN> e v en  better
<m up>  PR snapcraf t#2 755 op en ed: exten sio ns: k de-neo n : addicon andso u nd the m es <Cre a t ed  bygalgalesh> <https : // g ithub.com/snap core/s na p cr a f t/p ull /2755>
#sn ap py 20 1 9-10-18 <m b o r zec k i> morning
<m up> PR snap d #76 21 clo se d:s pdx: a dd EP L- 2 .0to licenses  <Cr eated byraligh t > <Clos e d by pe dronis > < htt ps:/ / gi th ub. co m /sn a pc ore / sna pd/pull/ 76 21 >
<mb orze c k i >  mvo : h ey
< mvo>hey mborzecki 
<m up>P R s napd# 7609clos ed : sna p-reco very:  r emove "usedPart itio ns" fromsfd is k.C re ate() <Creat edbymvo5> < Mergedb y m vo 5 > <h ttps://github.com/ sn a p co re/snapd /pull/ 7 60 9> <mup> PR  s nap d#76 2 0  clos ed:s na p-instal l: add ex t4 ,vfat c re ationsu ppo rt<Crea t ed b y mvo5 > <Merge d bym vo5> <https:// g ithub.com/sna p co r e /s n apd/ pul l/7620>
<mv o> 7 6 13 i s re a dy  fo r  revi ew no w, pr e tty small and hopef ul ly sim ple : )
<mborzecki>  mvo: so a r e we going  wit h  s n ap-recovery in stead  of recove r y-tool,or wi ll the f ormer jus t stay anint ern al/ tes t i ng  thing for no w ? 
<mv o>  mborze cki : hopeI u nde rst and  t he questi on but s na p- re co ver y ist he new n am e o frec overy - tool,recov ery- to ol isa bit t o og e neri c(i irctha twas w hatw asthe out come of t hec odere vi ew earl ier)
<mborzec ki > mvo: ahok , m issedt h at
<mvo>  mborzecki: there shoul d  be norec overy -too l anymore  un less I  ov e rlooke d some thing  : )
< m u p> PR s na pd# 76 27 closed: o ver lord:  a dd c hecks f or boot
source/commit/?id=ffd7ad54bca62c325f906014cd3b96bd2bcd2ee7
<jdstrand> oSoMoN:_in this_case, I think that_is fine._it_also means_I_don't need to_add anything to_the review-tools
<oSoMoN> even better
<mup>_PR snapcraft#2755 opened:_extensions:_kde-neon: add icon and sound themes <Created by galgalesh> <https://github.com/snapcore/snapcraft/pull/2755>
#snappy 2019-10-18
<mborzecki> morning
<mup> PR snapd#7621_closed:_spdx: add_EPL-2.0_to_licenses <Created by ralight> <Closed_by pedronis> <https://github.com/snapcore/snapd/pull/7621>
<mborzecki> mvo: hey
<mvo>_hey mborzecki
<mup>_PR snapd#7609 closed: snap-recovery: remove "usedPartitions" from sfdisk.Create()_<Created_by mvo5> <Merged_by mvo5> <https://github.com/snapcore/snapd/pull/7609>
<mup> PR snapd#7620 closed: snap-install: add ext4,vfat_creation support <Created by mvo5> <Merged_by mvo5> <https://github.com/snapcore/snapd/pull/7620>
<mvo>_7613_is_ready for review now,_pretty small and hopefully simple :)
<mborzecki>_mvo: so are we going with_snap-recovery instead of recovery-tool, or will the_former just stay an internal/testing thing_for now?
<mvo> mborzecki: hope I_understand the_question but snap-recovery is the_new name of_recovery-tool, recovery-tool_is a bit_too generic (iirc that was what_was the outcome_of the code review earlier)
<mborzecki> mvo:_ah_ok, missed that
<mvo>_mborzecki:_there_should be_no recovery-tool anymore_unless_I overlooked_something_:)
<mup> PR snapd#7627 closed: overlord: add_checks_for boot