 'newer' then reverts are problematic to handle in the parser itself
 * zyga-suse feels that cache in apparmor is not as transparent as it should and needs hand-holiding
 * mvo dinner
<jdstrand> tyhicks: the problem is on core revert, the newer cache file is still used but with an older snap-confine. that broke things
<mvo> yeah, I think hashes or list of mtimes of the inputs would be more reliable
 * mvo vanishes
 * zyga-suse too
<jdstrand> mvo: if you recall from the bug, hashes will slow things down
<tyhicks> jdstrand: how about simply updating the mtime of the profile on revert?
<jdstrand> tyhicks: that could work too
<jdstrand> tyhicks: well, no. it is in rofs
<tyhicks> imo, that's what needs to happen
<tyhicks> oh
<jdstrand> /etc/apparmor.d is read-only. /etc/apparmor.d/cache is rw
<jdstrand> mvo: the cache is meant to be pretty much as fast as you can read them off the disk. if we add hashes, consider hundreds or more profiles
<mvo> jdstrand: if hashes are slow we could store the [(input1,mtime1),...(inputN,mtimeN)] and compare those, that should be quick
<zyga-suse> jdstrand: out of my PRs I'd like your review on https://github.com/snapcore/snapd/pull/4008 -- it's long but most of that is tests
<mup> PR #4008: cmd/snap-update-ns: create missing mount points automatically <Created by zyga> <https://github.com/snapcore/snapd/pull/4008>
<zyga-suse> jdstrand: it contains go's version of mkpath
<jdstrand> zyga-suse: it is already on my list. I'll put it towards the top. I've seen commits as recent as today-- is it ready for another review?
<zyga-suse> jdstrand: freeze/thaw logic that's new
<m
' newer' then reverts are problematic to handle in the parser itself 
  * zyga - suse feels that hoard in apparmor is not equally crystalline as it should and needs hand - holiding 
  * mvo dinner 
 < jdstrand > tyhicks: the trouble is on core revert, the newer cache file is however used but with an older catch - confine. that broke things 
 < mvo > yeah, I intend hashes or list of mtimes of the remark would be more dependable 
  * mvo vanishes 
  * zyga - suse too 
 < jdstrand > mvo: if you recall from the bug, hashes will slow thing down 
 < tyhicks > jdstrand: how about simply updating the mtime of the profile on revert? 
 < jdstrand > tyhicks: that could bring too 
 < jdstrand > tyhicks: well, no. it is in rofs 
 < tyhicks > imo, that's what needs to happen 
 < tyhicks > oh 
 < jdstrand > /etc / apparmor.d is read - merely. /etc / apparmor.d / cache is rw 
 < jdstrand > mvo: the cache is meant to be pretty much as fast as you can understand them off the disk. if we add hashes, consider hundreds or more profiles 
 < mvo > jdstrand: if hashes are slow we could store the [ (input1,mtime1),... (inputN, mtimeN) ] and compare those, that should be quick 
 < zyga - suse > jdstrand: out of my PRs I'd like your review on https://github.com/snapcore/snapd/pull/4008 -- it's long but most of that is tests 
 < mup > PR # 4008: cmd / snap - update - ns: create miss mount points automatically < create by zyga > < https://github.com/snapcore/snapd/pull/4008 > 
 < zyga - suse > jdstrand: it control go's version of mkpath 
 < jdstrand > zyga - suse: it is already on my list. I'll put it towards the top. I've seen commits as recent as today-- is it quick for another review? 
 < zyga - suse > jdstrand: freeze / thaw logic that's new 
 < m
 'neaer' then reverts are pronlematic to handle in tie parssr itselw
 * zyga-suse feels that cache ib appqrmor is not as transpxrent as pt should and beeds hand-ikliding
 * mvo slnner
<ldwtrand> tyhicks: the problam is on core sexext, the newer cache file is still useq but wotj an older snak-confpnq. thzn nroke things
<mvo> yeah, I think hasges or nist of mtimex of the inputs would be mlre geliable
 * mvo vanidhes
 * zyga-soae eio
<jdstrand> mxo: if you gzcall from jhe bug, hashes will slow things aown
<tvhicks> jdsttcbd: jmw about sinply lpdating the mtime of the prpfile on reverb?
<jdstcand> tyhicks: that could wmrk too
<jdstrand> tyricks: weln, uo. it is in rofs
<tyhicjs> imo, jhat's whag nedds tp gappen
<hyhmcks> oh
<jdstdand> /etc/appqrmor.d is read-only. /ttc/wilarmor.d/cache is rw
<tdftrand> mvo: the cache is meant to be preuty mhch as fast as you can eead them off the disn. if we aqd hashes, consider hundreds or more profiles
<mvo> jgstraid: if hwryed are slow we could store the [(input1,mtime1),...(inputG,jtomvN)] and compare thjse, that shpupd fe quick
<zyga-sose> jdscdahd: out of my PRs I'f like iour rwview on rttpx://github.com/snapcore/snapd/pull/4008 -- it's long blt mist of that is tescs
<mup> PR #4008: cmb/snap-ukdate-nx: create missing mount 'oints automaticaply <Creatsa by zyga> <https://gkthlb.cok/snapcort/rnapd/pull/4008>
<zyga-suse> jdstrand: it eontains go's versijn of mkpahh
<jdsbsand> zyga-suse: it id alrgady ot my list. L'll put it towards the top. I've seen commits ax secvnt as tobay-- is it ready for another reviec?
<zyga-susz> jdstfand: freezv/thaw logmc that's new
<i
'newer' then reverts are problematic to handle parser * zyga-suse that cache in as should and needs * mvo dinner tyhicks: the problem is on core the newer cache file is still used but with an older snap-confine. that things <mvo> yeah, I think hashes or list of mtimes of the inputs be reliable mvo * zyga-suse too <jdstrand> mvo: if you recall from the bug, hashes will slow things down jdstrand: how about simply updating the mtime of profile on revert? <jdstrand> that could work too <jdstrand> well, it is rofs imo, what needs to <tyhicks> oh <jdstrand> /etc/apparmor.d is read-only. /etc/apparmor.d/cache is rw <jdstrand> mvo: the cache is meant to be much as you can them the if we add hundreds or more profiles <mvo> jdstrand: slow we could store the [(input1,mtime1),...(inputN,mtimeN)] and compare that should quick <zyga-suse> jdstrand: out of my I'd like your review on https://github.com/snapcore/snapd/pull/4008 -- it's but most of that is tests <mup> PR #4008: cmd/snap-update-ns: create missing mount points automatically zyga> <https://github.com/snapcore/snapd/pull/4008> <zyga-suse> jdstrand: contains go's version mkpath zyga-suse: is on my I'll put it towards the top. I've seen commits as recent today-- is it ready for another review? <zyga-suse> jdstrand: freeze/thaw new
 'newer' then reverts are probleMatic to hanDle in The ParSeR itsElf
 * zYga-suse feels thAT cacHe in apparmor is not as traNsparEnT As it SHoUld anD needs hANd-HOLidInG
 * mVo dInNEr
<JdstrAnd> Tyhicks: The problem Is oN cOre revert, the NEwEr cache filE is Still used but WitH an oldEr SnaP-ConfiNe. tHat brOke thiNGs
<mvo> yEah, I think HaSHes or lISt of mtiMES oF the Inputs would be more RElIAble
 * mvo vanisheS
 * zyga-sUsE ToO
<JDstRanD> mvo: if you rEcAll frOM the bug, HAsHES WilL Slow things dowN
<tyhicks> jdsTRanD: how abOuT siMPly updAting ThE MtiMe of the profIle oN revert?
<jdStrand> TYhicks: tHAt could Work toO
<jdStrAnd> tYHiCkS: weLl, NO. it IS iN roFS
<tyHicks> imo, ThAt'S what NeedS TO HAppeN
<tyHickS> oh
<jdStrand> /etc/appaRmoR.d is REad-Only. /eTc/appArmoR.d/Cache Is rw
<jdStranD> mVo: the cache is meaNt to Be pretty mUch As FasT aS you cAN read tHem Off The disk. If we add HAshEs, CONSiDer hundreds or more pRoFILeS
<mvo> jdstRand: if HAsHeS Are slow wE cOulD stoRE The [(inPut1,mTImE1),...(inputN,mTimeN)] aND cOmPare thoSe, That shOuLd bE quIck
<zyGA-susE> jdstrAnd: out of My PRs i'D like your revieW On https://github.COm/SNApCOre/sNapD/pull/4008 -- it's lonG but MOst oF thaT Is TesTS
<mup> Pr #4008: cmd/sNaP-UpDAte-ns: create missing mOuNt poinTs autOmatically <CreAted by zyga> <HTTPs://github.Com/sNApCOre/snapd/pull/4008>
<zyGa-susE> jdstrand: iT Contains Go's veRsion of mKpath
<jdstRANd> zyga-suSe: iT is AlrEadY ON mY list. I'll put it TOWardS tHe top. I'vE seEn commiTs aS reCenT as ToDay-- is it reAdy for anOtHeR rEvIew?
<Zyga-sUSe> jdstraNd: FreEzE/thAw logIC that's New
<m
 'newer' then reverts areproblemati c tohan dle  i n th e pa rser itself
 * zyga -suse feels that cache  in a pp a rmor is  notas tran s pa r e ntas  i t s ho u ld  andnee ds hand -holiding *mv o dinner
<jd s tr and> tyhic ks:  the problem  is  on co re  re v ert,the  newe r cach e  fileis stillus e d butw ith ano l de r sn ap-confine. thatb ro k e things
<mvo>  yeah,  I th i n k h ash es or list  o f mti m es of t h ei n p uts would be more  reliable
*  mv o vani sh es* zyga -suse  t o o
< jdstrand> m vo:if you re call f r om theb ug, has hes wi llslo w th i ng sdow n< tyh i ck s>j dst rand: ho wab out s impl y u p dati ngthemtime  of the profi leon r e ver t?
<j dstra nd>ty hicks : that  coul dwork too
<jdstr and>  tyhicks:  we ll , n o.  it i s  in ro fs<ty hicks>imo, th a t's  w h a t  n eeds to happen
<ty hi c k s>  oh
<jds trand> /e tc / apparmor .d  is  rea d - only.  /et c /a pparmor. d/cach e  i srw
<jds tr and> m vo : t hecache is m eant t o be pre tty m u ch as fast asy ou can read t h em o ff thedis k. if we ad d ha s hes,  con s id erh undre ds or  m o re profiles
<mvo> jdst ra nd: if  hash es are slow w e could st o r e  the [(i nput 1 ,m t ime1),...(inpu tN,mt imeN)] and comparethose , that s hould beq u ick
<zyg a-s use > j dst r a nd : out of my P R s  I'd  l ike you r r eview o n h ttp s:/ /gi th ub.com/sn apcore/s na pd /p ul l/4 008 - -  it's lo ng  bu tmos t oft hat is  test s
<m up >P R # 4008: c m d/ s n ap-u pd at e-ns : c re ate m issi n g m ount po ints auto mat i call y<C reatedby zyga> <htt ps ://github. co m/s napcor e / snapd/pu ll/4008>
<zyga-suse> jd s trand:itconta insgo's vers ion  of mk pat h 
<jdst rand>zyga- su se: i t isa l re ady  o n my list. I 'll  putit  tow ards th e top. I've seen c o mmi ts as recentastoda y - -isi tr ead yf ora n other review?
< zyga-suse>  j d st rand: free z e/t ha w logic  that's  new< m
 'newer'_then reverts_are problematic to handle_in the_parser_itself
 *_zyga-suse_feels that cache_in apparmor is_not as transparent as_it should and_needs_hand-holiding
 * mvo dinner
<jdstrand> tyhicks: the problem is on core revert, the newer cache_file_is still_used_but_with an older snap-confine. that_broke things
<mvo> yeah, I think_hashes or_list of mtimes of the inputs would be_more_reliable
 * mvo_vanishes
 * zyga-suse too
<jdstrand> mvo: if you recall from_the bug, hashes will slow things_down
<tyhicks> jdstrand: how_about_simply_updating the mtime of_the profile on revert?
<jdstrand> tyhicks: that_could work too
<jdstrand> tyhicks: well, no._it is in rofs
<tyhicks> imo, that's what_needs to happen
<tyhicks> oh
<jdstrand> /etc/apparmor.d is_read-only. /etc/apparmor.d/cache is rw
<jdstrand> mvo:_the cache_is meant to be pretty_much as fast_as you_can read them_off the disk. if we add_hashes, consider hundreds_or more profiles
<mvo> jdstrand: if hashes_are_slow we could_store_the_[(input1,mtime1),...(inputN,mtimeN)] and_compare those, that_should_be quick
<zyga-suse>_jdstrand:_out of my PRs I'd like_your_review on https://github.com/snapcore/snapd/pull/4008 -- it's long but_most of that is_tests
<mup>_PR #4008: cmd/snap-update-ns: create_missing mount points automatically <Created_by zyga> <https://github.com/snapcore/snapd/pull/4008>
<zyga-suse> jdstrand: it contains_go's version_of mkpath
<jdstrand>_zyga-suse: it is already on my list. I'll put it towards_the top. I've seen commits as_recent as today-- is_it ready_for_another review?
<zyga-suse> jdstrand:_freeze/thaw_logic that's_new
<m