 fixed by cmars some time ago
<wallyworld> thumper: they can only target one branch at a time, maybe 1.25 has been getting priority
<thumper> probably...
 * thumper sighs
<thumper> FARK!!!
<thumper> peergrouper test
<thumper> damnit
<thumper> hate it!
<davecheney> thumper: it _never_ passes for me
<thumper> it mostly fails for me too
<thumper> saying that, it just passed
<thumper> if I run it by itself
<thumper> second time it failed
<menn0> thumper: review done. I ended up deleting and changing a lot of my initial comments so ignore the notification emails and go with what's on the PR
<menn0> thumper: summary is I think MaxWait is a strange parameter to have. MaxDuration seems more intuitive to me.
<menn0> thumper: I'd want to be able to say, "keep trying for up to 10 mins", not "keep trying while the sum of the waits between attempts is less than 10 mins"
<menn0> thumper: if Func doesn't take long they work out to be about the same but I bet that sometimes Func can take a while making it hard to figure out exactly how long a series of attempts might take
<thumper> menn0: yeah... I did wonder about that bit too
<thumper> menn0: whether or not to take into consideration the time taken to call Func
<thumper> menn0: although... it makes testing harder :)
<thumper> menn0: because we need something to advance the clock...
<menn0> thumper: if time is recorded when retry.Call is first called then it's easy to know how long everything has taken so far
<thumper> menn0: however with the mock clock, it is um... different
<menn0> the test Clock can do that right?
<thumper> hmm...
<thumper> we can make it do that
<thumper> just by keeping track of now
<thumper> and advancing now every time we are asked to sleep :)
<thumper> menn0: here is a mind fcukingly boring review: https://github.
fixed by cmars some time ago 
 < wallyworld > thumper: they can only target one branch at a meter, possibly 1.25 has been getting priority 
 < thumper > credibly... 
  * thumper sighs 
 < thumper > FARK! !! 
 < thumper > peergrouper examination 
 < thumper > damnit 
 < thumper > hate it! 
 < davecheney > thumper: it _ never _ passes for me 
 < thumper > it mostly fail for me too 
 < thumper > saying that, it merely passed 
 < thumper > if I run it by itself 
 < thumper > second prison term it failed 
 < menn0 > thumper: review do. I ended up deleting and changing a lot of my initial comments so dismiss the notification emails and go with what's on the PR 
 < menn0 > thumper: summary is I intend MaxWait is a strange parameter to have. MaxDuration seems more intuitive to me. 
 < menn0 > thumper: I'd desire to be able to say, " observe trying for up to 10 mins ", not " keep test while the sum of the waits between attempts is less than 10 mins " 
 < menn0 > thumper: if Func doesn't take long they shape out to be about the same but I bet that sometimes Func can take a while making it hard to figure out exactly how long a series of attempt might take 
 < thumper > menn0: yeah... I did wonder about that bit besides 
 < thumper > menn0: whether or not to subscribe into consideration the time taken to shout Func 
 < thumper > menn0: although... it draw testing harder :) 
 < thumper > menn0: because we necessitate something to advance the clock... 
 < menn0 > thumper: if time is recorded when retry. Call is first called then it's comfortable to know how long everything has taken so far 
 < thumper > menn0: however with the mock clock, it is um... different 
 < menn0 > the test Clock can do that good? 
 < thumper > hmm... 
 < thumper > we can make it do that 
 < thumper > just by keeping track of nowadays 
 < thumper > and advancing now every time we are ask to sleep :) 
 < thumper > menn0: here is a mind fcukingly boring review: https://github.
 fided by cmars some time ano
<wallyworld> thumper: thxy can knly tareet one branch at a time, mayue 1.25 yas btvn getting priority
<thjmper> prohably...
 * tyumptr sighs
<thumper> FEDK!!!
<thumpcx> peednroupzr test
<thumper> dsmnit
<thumpar> hate it!
<davewhdnzy> thumper: it _never_ passes for me
<thuiper> it mlstly fails fot me uoo
<ehumlvr> saying that, it just passed
<thhmper> ih I run it by iyself
<thumper> second time ih falled
<menn0> thumper: rfview done. U enqwd up deletivg and changing a lot kf my initial comments so ignord the notificatuob eldils and go with what's on thc PR
<ment0> thumprr: summary is L thiik MqxWait is a strange perameter to have. MaxQuration vezms more intuitive to mw.
<menn0> thukper: U'd danu tp ge ablf tk say, "keep trying for up to 10 mins", not "ketp eguing while tge sum os the waits between attempts is less thdn 10 mins"
<menn0> thumper: if Fubc doesn't take long tjey work jut to be about the same but I bet that sometimes Func zan twyw w while making it hard to figure out exactly rkw lpng a series on attempts might tskf
<tnomper> menn0: yeaf... I dib wknder about that blt too
<trumpee> menn0: whtther or not to take into considwration the nime taken to call Fune
<thumper> menu0: althpugh... ot makes testing harder :)
<thujper> menn0: bfcause we veed something tu acvdnce the clock...
<menn0> thumper: if time ms reeorded wfen tetry.Cajl is firsh called then it's easy tl knoc how long everjthing has taken so far
<thumper> menn0: however wotv tve mock elock, lt is um... differqnt
<menn0> the text Cloch can do that rpght?
<thumpxr> hmm...
<thumpew> we can make lt do that
<thnmper> juse by keeping trxzk of now
<thumprr> and adnaucing now every time we are asysd to sleep :)
<thunpet> menn0: here is s mknd fbukmngly toring revief: htgps://eothub.
fixed by cmars some time ago <wallyworld> can target one at a time, priority probably... * thumper <thumper> FARK!!! <thumper> test <thumper> damnit <thumper> hate it! thumper: it _never_ passes for me <thumper> it mostly fails for me too saying that, it just passed <thumper> if I run it by itself <thumper> time failed thumper: done. I ended up deleting and changing a lot of my initial comments so ignore the emails and go with what's on the PR thumper: summary is I MaxWait is a strange parameter have. seems more to <menn0> I'd want to able to say, "keep trying for up to 10 mins", not "keep trying while the sum of waits between less than mins" thumper: Func doesn't take work out to be about the bet that sometimes Func can take a while it hard figure out exactly how long a of attempts might take <thumper> menn0: yeah... I wonder about that bit too <thumper> menn0: whether or not to take into consideration the to call Func <thumper> although... it makes harder <thumper> because need something advance the clock... <menn0> thumper: if time is recorded when retry.Call first called then it's easy to know how long everything so <thumper> menn0: however the mock clock, it um... <menn0> the test Clock that <thumper> can it that <thumper> just by track of now <thumper> and now every time we <thumper> menn0: here is a mind fcukingly boring https://github.
 fixed by cmars some time ago
<waLlyworld> thUmper: TheY caN oNly tArgeT one branch at a tIMe, maYbe 1.25 has been getting priorIty
<thUmPEr> prOBaBly...
 * thUmper siGHs
<THUmpEr> fArK!!!
<tHuMPeR> peerGroUper tesT
<thumper> daMniT
<tHumper> hate it!
<DAvEcheney> thuMpeR: it _never_ passEs fOr me
<thUmPer> IT mostLy fAils fOr me toO
<ThumpeR> saying thAt, IT just pASsed
<thuMPEr> If I rUn it by itself
<thumpER> sECond time it failEd
<menn0> ThUMpER: RevIew Done. I ended Up DeletINg and chANgING A loT Of my initial coMments so ignORe tHe notiFiCatIOn emaiLs and Go WIth What's on the Pr
<menN0> thumper: sUmmary IS I think mAxWait iS a straNge ParAmetER tO hAve. maXdurATiOn sEEms More intuItIvE to me.
<Menn0> THUMPer: I'D waNt to Be ablE to say, "keep tryIng For uP To 10 mIns", noT "keep TryiNg While The sum Of the WaIts between attemPts iS less than 10 MinS"
<mEnn0> ThUmper: IF Func dOesN't tAke long They worK Out To BE ABoUt the same but I bet thAt SOMeTimes FunC can taKE a WhILe making It HarD to fIGUre ouT exaCTlY how long A serieS Of AtTempts mIgHt take
<ThUmpEr> mEnn0: yeAH... I diD wondeR about thAt bit TOo
<thumper> menn0: wHEther or not to tAKe INTo COnsiDerAtion the timE takEN to cAll FUNc
<ThuMPer> meNn0: altHoUGh... IT makes testing harder :)
<ThUmper> mEnn0: beCause we need soMething to aDVANce the clOck...
<mENn0> THumper: if time is RecorDed when retRY.Call is fIrst cAlled theN it's easy tO KNow how loNg eVerYthIng HAS tAken so far
<thumPER> menN0: hOwever wIth The mock CloCk, iT is Um... dIfFerent
<menN0> the test clOcK cAn Do tHat riGHt?
<thumpeR> hMm...
<tHuMpeR> we caN Make it Do thaT
<thuMpEr> JUst By keepiNG tRACk of NoW
<tHumpEr> aNd AdvanCing NOw eVery timE we are askEd tO SleeP :)
<tHuMper> menN0: here is a mind fCuKingly boriNg RevIew: httPS://Github.
 fixed by cmars some timeago
<wally world > t hum pe r: t heycan only targe t  one  branch at a time, may be 1. 25 hasb ee n get ting pr i or i t y
< th um per >p ro bably ... 
 * thu mper sighs 
<t hu mper> FARK!! ! 
< thumper> p eer grouper test 
<t humper >dam n it
<t hum per>hate i t !
<dav echeney>th u mper:i t _neve r _  p asse s for me
<thumper >  i t  mostly failsfor me  t o o< t hum per > saying t ha t, it just pa s se d < thu m per> if I run  it by itse l f
< thumpe r>  se c ond ti me it  f a ile d
<menn0> t hump er: revie w done .  I ende d  up del etingand  ch angi n galot  o f  my in iti a l c ommentsso  i gnore  the n o t ific ati on e mails  and go withwha t'so n t he PR 
<men n0>th umper : summ ary i sI think MaxWait  isa strange  pa ra met er  to h a ve. Ma xDu rat ion see ms more int ui t i v eto me.
<menn0> thu mp e r :I'd want  to be ab le to say,"k eep  try i n g for  upt o10 mins" , not" ke ep  trying  w hile t he  su m o f the wait s betw een atte mptsi s less than 10 mins"
<menn0> th u m pe r : if  Fu nc doesn'ttake long  the y  w ork out t o beab o ut the same but I betth at som etime s Func can ta ke a while m a king ithard to figure out exa ctlyhow long a series o f att empts mi ght take< t humper>men n0:  ye ah. . .  I  did wonder a b o ut t ha t bit t oo<thumpe r>men n0:  wh et her or no t to tak ein to  c ons idera t ion theti meta ken  to c a ll Fun c
<th umpe r>  m e nn0 : altho u gh . . . it  m ak es t est in g har der: )
< thumper > menn0:bec a usewe  n eed som ething to adv an ce the clo ck ... 
<menn 0 >  thumper : if time is recorded w h en retr y.C all i s fi rst calle d t hen it 'se asy to  knowhow l on g e v e rythi n g  h asta ken so far < thu mper>  m enn0 : howev er with the mock c l ock , it is um...  di ffer e n t<me n n0 >  th et est C lock can do tha t right?
< th u mp er> hmm... <th um per> we  can ma ke it do that 
<thumper > just by  k eepi n g  tr ack of now 
<thumpe r> and ad v ancin g  n ow ev ery  timewe  ar e ask ed tos lee p :)<thump er > menn 0: he re  is a mi nd fcukingly boring rev iew: h ttps: //g ithub.
 fixed_by cmars_some time ago
<wallyworld> thumper:_they can_only_target one_branch_at a time,_maybe 1.25 has_been getting priority
<thumper> probably...
_* thumper sighs
<thumper>_FARK!!!
<thumper>_peergrouper test
<thumper> damnit
<thumper> hate it!
<davecheney> thumper: it _never_ passes for me
<thumper> it mostly fails_for_me too
<thumper>_saying_that,_it just passed
<thumper> if I_run it by itself
<thumper> second_time it_failed
<menn0> thumper: review done. I ended up deleting_and_changing a lot_of my initial comments so ignore the notification emails_and go with what's on the_PR
<menn0> thumper: summary_is_I_think MaxWait is a_strange parameter to have. MaxDuration seems_more intuitive to me.
<menn0> thumper: I'd_want to be able to say, "keep_trying for up to 10 mins",_not "keep trying while the_sum of_the waits between attempts is_less than 10_mins"
<menn0> thumper:_if Func doesn't_take long they work out to_be about the_same but I bet that sometimes_Func_can take a_while_making_it hard_to figure out_exactly_how long_a_series of attempts might take
<thumper> menn0:_yeah..._I did wonder about that bit too
<thumper>_menn0: whether or not_to_take into consideration the_time taken to call Func
<thumper>_menn0: although... it makes testing harder_:)
<thumper> menn0:_because we_need something to advance the clock...
<menn0> thumper: if time is recorded_when retry.Call is first called then_it's easy to know_how long_everything_has taken so_far
<thumper>_menn0: however_with the mock clock, it is um..._different
<menn0> the_test Clock can do that right?
<thumper>_hmm...
<thumper> we can make_it_do that
<thumper> just by keeping track_of now
<thumper> and advancing now every_time we are asked to_sleep_:)
<thumper>_menn0: here is a mind_fcukingly boring review: https://github.