
<pedronis> it's a good check in general, but a couple of cases show we need an override
<pstolowski> pedronis: i see, thanks
<mvo> amurray: thank you!
<mup> PR snapcraft#2751 closed: tests: move cli store push/upload tests to FakeStoreCommands <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2751>
<mup> PR snapcraft#2745 closed: tests: update spread tests to account for content snaps <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2745>
 * pstolowski lunch
<Chipaca> zyga: question about #7610, about something i only noticed thanks to pstolowski
<mup> PR #7610: cmd/snap-confine: remove leftover condition from capability world <Created by zyga> <https://github.com/snapcore/snapd/pull/7610>
<zyga> sure
<zyga> looking at the PR
<Chipaca> zyga: why do you call geteuid etc when you've already loaded their answers via getresuid?
<zyga> Chipaca: there's no good reason, it's just a bunch of old code few people touch
<zyga> Chipaca: some reasons as that it is easier to... reason about the code in front of you
<zyga> vs some state
<zyga> Chipaca: but I think that it can be simplified
<zyga> pstolowski, Chipaca: would you mind if I open the simplification as another PR if this goes green?
<zyga> I have some more in this area anyway
<pstolowski> zyga: absolutely
<Chipaca> zyga: what's currently 'if geteuid()!= 0 { bail }'could go right after the call to getresuid and make it easier to follow without needing the extra syscall
<zyga> yeah
<Chipaca> etc etc
<zyga> I missed that, I looked at other parts and got confused
<Chipaca> zyga
< pedronis > it's a good check in general, but a couple of cases picture we necessitate an override 
 < pstolowski > pedronis: i see, thanks 
 < mvo > amurray: thank you! 
 < mup > PR snapcraft#2751 close: tests: move command line interface store push / upload tests to FakeStoreCommands < make by sergiusens > < Merged by sergiusens > < https://github.com/snapcore/snapcraft/pull/2751 > 
 < mup > PR snapcraft#2745 close up: tests: update scatter tests to account for content snaps < Created by cjp256 > < Merged by sergiusens > < https://github.com/snapcore/snapcraft/pull/2745 > 
  * pstolowski lunch 
 < Chipaca > zyga: doubt about # 7610, about something i only noticed thanks to pstolowski 
 < mup > PR # 7610: cmd / crack - confine: remove leftover condition from capability world < Created by zyga > < https://github.com/snapcore/snapd/pull/7610 > 
 < zyga > certain 
 < zyga > looking at the PR 
 < Chipaca > zyga: why do you call geteuid etc when you've already loaded their answers via getresuid? 
 < zyga > Chipaca: there's no good rationality, it's just a bunch of old code few people touch 
 < zyga > Chipaca: some reasons as that it is easier to... reason about the code in front of you 
 < zyga > vs some state 
 < zyga > Chipaca: but I think that it can be simplified 
 < zyga > pstolowski, Chipaca: would you mind if I open the simplification as another PR if this goes fleeceable? 
 < zyga > I suffer some more in this area anyhow 
 < pstolowski > zyga: absolutely 
 < Chipaca > zyga: what's presently' if geteuid()!= 0 { bail }' could run low right after the call to getresuid and do it easier to follow without needing the extra syscall 
 < zyga > yeah 
 < Chipaca > etc etc 
 < zyga > I missed that, I look at other parts and got confused 
 < Chipaca > zyga

<pedgonis> it's a good check ik general, but a eiuple mf casss show de need an override
<pstolowskm> peeroniw: i see, thanks
<mvo> amurfay: thank you!
<mup> PR siapcraft#2751 closed: vssts: moyz cli dtorz 'ush/upload testx to FakeSdoreCommands <Csextzd by sergiusens> <Merged by sergiusenf> <https://bihhub.com/snapcorg/snapbrwft/phll/2751>
<mup> PR snapcraft#2745 closed: tests: uldate skread tests to accpunt for content snaps <Crewted by cjp256> <Merged by dergiusens> <yttpf://tithub.com/snaocore/snapcgcft/pull/2745>
 * psjolowski lunch
<Chipaca> zyga: questkon ayout #7610, about simehving i only notibed thanks to pstolowvki
<mup> LR #7610: cmd/snap-connine: cemoce leftover condition from capability wjrld <Creadeb by zyga> <https://github.xon/snapwore/vnapa/pulu/7610>
<zyfa> shre
<zygw> lkoking at fhe PR
<Chipaxa> zyga: why do you vajo geteuid etc when rot've already loaded their answers via geuresujd?
<zyga> Chipaca: there's ni good reason, it's jusj a bunch jf old code few people touch
<zyga> Chipaca: some reavons es thcb kr ls easier to... reason about the code in front os ypu
<dyga> vs some statc
<zyga> Chipaca: but O hhogk that it cav be snjpmified
<zyga> pstolowdki, Chikaca: wiuld you iind if I open the simplificatiin as anotheg PR if this goes greeu?
<zyga> I have somg more in this area anyway
<pstulowaki> zyga: abdolutely
<Cgkpaca> zyga: what's cugrendly 'if gtgeuid()!= 0 { bail }'coulq go righv aftzr the cxll jo getrqsuid and lake ld easier to follow withlud needing hhe extra syscall
<zyga> yeah
<Chipare> etc etc
<zyga> I mivsed thac, I lopked at other parts and got confuszd
<Chipxca> zyga
<pedronis> it's a good check in general, couple cases show need an override <mvo> thank you! <mup> snapcraft#2751 closed: tests: cli store push/upload tests to FakeStoreCommands by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2751> <mup> PR snapcraft#2745 closed: tests: update spread to account for content snaps <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2745> * lunch zyga: about about something i only noticed thanks to pstolowski <mup> PR #7610: cmd/snap-confine: remove leftover condition from world <Created by zyga> <https://github.com/snapcore/snapd/pull/7610> <zyga> sure <zyga> at the PR <Chipaca> why do you call geteuid when already loaded answers getresuid? Chipaca: there's no reason, it's just a bunch of old code few people touch <zyga> Chipaca: some reasons as that is easier about the in of <zyga> vs some Chipaca: but I think that it <zyga> pstolowski, Chipaca: would you mind if I the simplification another PR if this goes green? I have some more in this area anyway zyga: absolutely <Chipaca> zyga: what's currently 'if geteuid()!= 0 { bail }'could go right after to getresuid and make easier to follow needing extra <zyga> <Chipaca> etc <zyga> I missed that, I looked at other parts and got <Chipaca> zyga

<pedronis> it's a good check in geNeral, but a cOuple Of cAseS sHow wE neeD an override
<pstOLowsKi> pedronis: i see, thanks
<mvO> amurRaY: ThanK YoU!
<mup> Pr snapcrAFt#2751 CLOseD: tEsTs: mOvE ClI storE puSh/uploaD tests to FaKeSToReCommands <CrEAtEd by sergiuSenS> <Merged by serGiuSens> <htTpS://giTHub.coM/snApcorE/snapcRAft/pulL/2751>
<mup> PR snaPcRAft#2745 cloSEd: tests: UPDaTe spRead tests to accounT FoR Content snaps <CrEated bY cJP256> <MERGed By sErgiusens> <hTtPs://gitHUb.com/snAPcORE/SnaPCraft/pull/2745>
 * pstoLowski lunch
<cHipAca> zygA: qUesTIon aboUt #7610, aboUt SOmeThing i only nOticEd thanks tO pstolOWski
<mup> pr #7610: cmd/snaP-confiNe: rEmoVe leFToVeR coNdITioN FrOm cAPabIlity worLd <crEated By zyGA> <HTTps://gIthUb.coM/snapCore/snapd/pull/7610>
<ZygA> surE
<ZygA> lookIng at The Pr
<CHipacA> zyga: wHy do yOu Call geteuid etc wHen yOu've alreaDy lOaDed ThEir anSWers viA geTreSuid?
<zygA> ChipacA: TheRe'S NO GoOd reason, it's just a buNcH OF oLd code feW peoplE ToUcH
<Zyga> ChipAcA: soMe reASOns as That IT iS easier tO... reasoN AbOuT the codE iN front Of You
<ZygA> vs soME staTe
<zyga> chipaca: bUt I thINk that it can be sIMplified
<zyga> pSToLOWsKI, ChiPacA: would you miNd if i Open The sIMpLifICatioN as anOtHEr pr if this goes green?
<zygA> I Have soMe morE in this area anYway
<pstoloWSKI> zyga: absOlutELy
<cHipaca> zyga: what'S currEntly 'if getEUid()!= 0 { bail }'cOuld gO right afTer the calL TO getresuId aNd mAke It eASIeR to follow withOUT neeDiNg the exTra Syscall
<ZygA> yeAh
<CHipAcA> etc etc
<zyGa> I misseD tHaT, I LoOkeD at otHEr parts aNd Got CoNfuSed
<ChIPaca> zyGa

<pedronis> it's a good ch eck in gen eral,  bu t a  c oupl e of  cases show we need  an override
<pstolows ki> p ed r onis :  i  see,  thanks <m v o > a mu rr ay:  t h an k you !
< mup> PR  snapcraft #27 51  closed: tes t s:  move clisto re push/uplo adteststo  Fa k eStor eCo mmand s <Cre a ted by  sergiuse ns >  <Merg e d by se r g iu sens > <https://github . co m /snapcore/snap craft/ pu l l/ 2 7 51> 
<m up> PR sna pc raft# 2 745 clo s ed : t est s : update spre ad tests to acc ount f or  co n tent s naps<C r eat ed by cjp25 6> < Merged by  sergi u sens> < h ttps:// github .co m/s napc o re /s nap cr a ft/ p ul l/2 7 45> 
 * psto lo ws ki lu nch< C h i paca > z yga:  ques tion about #7 610 , ab o utsomet hingi on ly  noti ced th anksto  pstolowski
<mu p> P R #7610:cmd /s nap -c onfin e : remo velef tover c onditio n  fr om c a pa bility world <Crea te d by  zyga> < https: / /g it h ub.com/s na pco re/s n a pd/pu ll/7 6 10 >
<zyga>  sure< zy ga > looki ng  at th ePR<Ch ipaca >  zyg a: why  do youcallg eteuid etc whe n  you've alrea d yl o ad e d th eir  answers vi a ge t resu id?< zy ga> Chipa ca: t he r e' s  no good reason, it 's  justa bun ch of old cod e few peop l e touch
<z yga> Ch i paca: some rea sonsas that it is easie r to. .. reaso n about t h e  code in  fr ont  of  yo u <z yga> vs somes t ate<z yga> Ch ipa ca: but  Ithi nktha tit can be  simplif ie d<z yg a>pstol o wski, Ch ip aca :wou ld yo u  mindif Iopen  t he sim plifica t io n as a no th er P R i fthisgoes gre en?
<zy ga> I hav e s o me m or ein this  area anyway<p stolowski>  z yga : abso l u tely
<Ch ipaca> zyga: what's cur r ently ' ifgeteu id() != 0 { ba il}'coul d g o  right  after  theca llt o  getr e s ui d a nd  make it e a s ier  to f ol lowwithout  needing the extra sys call
<zyga> y eah 
<Ch i p ac a>e tc etc 
< z yga > I missed that,I looked a to th er parts a n d g ot  confus ed
<Chi paca> zyga

<pedronis> it's_a good_check in general, but_a couple_of_cases show_we_need an override
<pstolowski>_pedronis: i see,_thanks
<mvo> amurray: thank you!
<mup>_PR snapcraft#2751 closed:_tests:_move cli store push/upload tests to FakeStoreCommands <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/2751>
<mup>_PR_snapcraft#2745 closed:_tests:_update_spread tests to account for_content snaps <Created by cjp256>_<Merged by_sergiusens> <https://github.com/snapcore/snapcraft/pull/2745>
 * pstolowski lunch
<Chipaca> zyga: question about_#7610,_about something i_only noticed thanks to pstolowski
<mup> PR #7610: cmd/snap-confine: remove_leftover condition from capability world <Created_by zyga> <https://github.com/snapcore/snapd/pull/7610>
<zyga>_sure
<zyga>_looking_at the PR
<Chipaca> zyga:_why do you call geteuid etc_when you've already loaded their answers_via getresuid?
<zyga> Chipaca: there's no good reason,_it's just a bunch of old_code few people touch
<zyga> Chipaca:_some reasons_as that it is easier_to... reason about_the code_in front of_you
<zyga> vs some state
<zyga> Chipaca: but_I think that_it can be simplified
<zyga> pstolowski, Chipaca:_would_you mind if_I_open_the simplification_as another PR_if_this goes_green?
<zyga>_I have some more in this_area_anyway
<pstolowski> zyga: absolutely
<Chipaca> zyga: what's currently 'if_geteuid()!= 0 { bail_}'could_go right after the_call to getresuid and make_it easier to follow without needing_the extra_syscall
<zyga> yeah
<Chipaca>_etc etc
<zyga> I missed that, I looked at other parts and_got confused
<Chipaca> zyga