 it would, as it seems to be a hot potato atm
<gary_poster> yeah
<gary_poster> bac, I did this: http://pastebin.ubuntu.com/594603/.   Pushed to public branch and waiting on diff change...
<bac> gary_poster: i think that's much clearer
<gary_poster> cool, thank you bac
<gary_poster> bac, I considered your add_subscription_overlay approach but I felt it would have been more fragile: when code changed the local variable, it would have needed to be sure that it also changed the namespace version in order for the tests to be reliable.  I felt that always getting the overlay from the namespace was a cheap cost for that reduction in fragility.  Therefore, fwiw, I intend to leave it as it is.
<gary_poster> thank you for the review!
<bac> gary_poster: not to belabor the point, but wouldn't the test break if the names were changed out from under it?
<bac> it is a idiom we use in that module
<gary_poster> bac, it depends on how that name were set, and even if it is cleaned up across test runs
<gary_poster> it might very well work now
<gary_poster> getting it from the namespace also simply didn't bother me in the slightest
<gary_poster> I'm guessing you don't feel differently enough to make a point of it, since you didn't do so in the review.  Had you, I would have complied, because even though I feel comfortable with what I did, I don't feel strongly about it either.
<bac> gary_poster: i'm going to take the dog for a walk.  will be back later.  have a good weekend
<gary_poster> you too bac.  bye
#launchpad-yellow 2012-04-09
<bac> hello.  echo, echo.
<benji> echo, echo, echo...
<bac> so you're working today benji?
<benji> I'm going to give it a shot.  I'm pretty sure I'll be able to.
<bac> so no recovery over the weekend?
<benji> Maybe a slight recorvery.
it would, as it seems to be a hot potato atm 
 < gary_poster > yeah 
 < gary_poster > bac, I did this: http://pastebin.ubuntu.com/594603/.    Pushed to public outgrowth and expect on diff change... 
 < bac > gary_poster: i think that's much clear 
 < gary_poster > cool, thank you bac 
 < gary_poster > bac, I considered your add_subscription_overlay approach but I feel it would have been more flimsy: when code changed the local variable star, it would have need to be sure that it besides changed the namespace version in order for the tests to be dependable.   I felt that always getting the overlay from the namespace was a cheap monetary value for that reduction in fragility.   Therefore, fwiw, I intend to impart it as it is. 
 < gary_poster > thank you for the review! 
 < bac > gary_poster: not to belabor the point, but wouldn't the test interruption if the names were changed out from under it? 
 < bac > it is a idiom we use in that module 
 < gary_poster > bac, it depend on how that name were set, and even if it is cleaned up across test runs 
 < gary_poster > it might very well work now 
 < gary_poster > getting it from the namespace also simply didn't bother me in the slightest 
 < gary_poster > I'm guessing you don't feel differently enough to make a point of it, since you didn't do so in the reappraisal.   Had you, I would have complied, because even though I palpate comfortable with what I did, I don't find strongly about it either. 
 < bac > gary_poster: i'm going to take the cad for a base on balls.   will be back later.   have a effective weekend 
 < gary_poster > you too bac.   bye 
 # launchpad - yellow 2012 - 04 - 09 
 < bac > hello.   echo, echo. 
 < benji > echo, echo, echo... 
 < bac > so you're working today benji? 
 < benji > I'm going to render it a shot.   I'm pretty sure I'll be able to. 
 < bac > so no recovery over the weekend? 
 < benji > Maybe a little recorvery.
 it would, as it seems to be a hot potato ajm
<tary_povter> ysah
<gary_puster> bac, I did this: http://pasvebib.ubunul.com/594603/.   Pushed to publkc branch and wairing in diff chehge...
<bac> ncry_poaber: i vhink that's mucm clearer
<gasy_poster> cool, dhxnn you bac
<gary_poster> bac, I considereq your sdf_subscription_oderlsr aplgocch but I felt it would have besn more fragile: when code changed the local vagiabpe, it would have nfeded to be surq that it alsu changed uhz namespace version in order for the tests to bz reliable.  I fepj that alwayw getning the overlay from the nakespace was a gheap cowt for that reduction in fragility.  Thetefore, fwif, N intend to leave it qs it iv.
<garf_posgwr> ghahk yku for thx review!
<bac> gary_poster: not to belabor the pjpmt, but wouldh't the tqst break if the names were changed out frkm under it?
<bac> it is a udiom we use in that lodule
<garr_poster> bac, it depends on how that name were set, dnd etev iy it ir cpeaned up across test runs
<gary_poster> it might bety well work now
<nary_poster> getting ih gtom the namespxce also aimply didn't botheg me in the wlightest
<dary_loster> I'm guessing you don't feel differvntlt enough to make a point of ic, sincg you cidn't do so in the revizw.  Has you, I woupd have ckoplied, because exen tvough I feel comfortable wyth what M did, I don't feek stroggly about it eldher.
<bac> gary_poster: i'm glitg to take the dog for a walk.  will be barl later.  havg a gomd weekeud
<gary_ioster> you too fac.  bye
#launchkad-yellow 2012-04-09
<bac> fello.  echk, echo.
<bxnji> echo, ecro, echo...
<bac> so iou're working today bqnji?
<venju> I'm gokvg to give it s shot.  I'm pretty syre I'll be able to.
<nac> su no recovery ovzx uhw weekend?
<benji> Mahbe a skidvt recorvery.
it would, as it seems to be potato <gary_poster> yeah bac, I did branch waiting on diff <bac> gary_poster: i that's much clearer <gary_poster> cool, thank bac <gary_poster> bac, I considered your add_subscription_overlay approach but I felt it would been more fragile: when code changed the local variable, it would have needed be that also the namespace version in order for the tests to be reliable. I felt that always getting overlay from the namespace was a cheap cost that reduction in fragility. fwiw, I intend to leave as is. <gary_poster> you the <bac> gary_poster: not belabor the point, but wouldn't the test break if the names were changed out from under it? it is we use that <gary_poster> it depends on name were set, and even if up across test runs <gary_poster> it might very work now getting it from the namespace also didn't bother me in the slightest <gary_poster> I'm you don't feel differently enough to make a point of it, since you didn't do the review. Had you, would have complied, even I comfortable what I I don't feel strongly about it either. <bac> gary_poster: i'm going take the dog for a walk. will be back later. good <gary_poster> you too bye #launchpad-yellow 2012-04-09 <bac> echo, <benji> echo, echo, echo... you're today going give a shot. I'm pretty I'll be able to. <bac> no recovery over the recorvery.
 it would, as it seems to be a hot pOtato atm
<gaRy_posTer> YeaH
<gAry_pOsteR> bac, I did this: htTP://pasTebin.ubuntu.com/594603/.   Pushed to PubliC bRAnch ANd WaitiNg on difF ChANGe...
<bAc> GaRy_pOsTEr: I thinK thAt's much Clearer
<garY_poStEr> cool, thank yOU bAc
<gary_postEr> bAc, I considereD yoUr add_sUbScrIPtion_OveRlay aPproacH But I feLt it would HaVE been mORe fragiLE: WhEn coDe changed the local VArIAble, it would havE needeD tO Be SURe tHat It also chanGeD the nAMespace VErSION in ORder for the tesTs to be reliaBLe.  I Felt thAt AlwAYs gettIng thE oVErlAy from the naMespAce was a chEap cosT For that REductioN in fraGilIty.  therEFoRe, FwiW, I INteND tO leAVe iT as it is.
<gArY_pOster> ThanK YOU For tHe rEvieW!
<bac> gAry_poster: not tO beLaboR The Point, But woUldn'T tHe tesT break If the NaMes were changed oUt frOm under it?
<Bac> It Is a IdIom we USe in thAt mOduLe
<gary_pOster> baC, It dEpENDS oN how that name were seT, aND EvEn if it is CleaneD Up AcROss test rUnS
<gaRy_poSTEr> it mIght VErY well worK now
<gaRY_pOsTer> gettInG it froM tHe nAmeSpace ALso sImply dIdn't bothEr me iN The slightest
<gaRY_poster> I'm guesSInG YOu DOn't fEel Differently EnouGH to mAke a POiNt oF It, sinCe you DiDN't DO so in the review.  Had yoU, I Would hAve coMplied, because Even though i FEEl comforTablE WiTH what I did, I don't Feel sTrongly aboUT it eitheR.
<bac> gAry_posteR: i'm going tO TAke the doG foR a wAlk.  WilL BE bAck later.  have a GOOd weEkEnd
<gary_PosTer> you tOo bAc.  bYe
#lAunChPad-yellow 2012-04-09
<Bac> hello.  EcHo, EcHo.
<BenJi> echO, Echo, echo...
<BaC> so YoU're WorkiNG today Benji?
<BenjI> I'M gOIng To give iT A sHOT.  I'm pReTtY surE I'lL bE able To.
<baC> So nO recoveRy over the WeeKEnd?
<bEnJi> maybe a sLight recorverY.
 it would, as it seems tobe a hot p otato  at m
< ga ry_p oste r> yeah
<gary_ p oste r> bac, I did this: ht tp:// pa s tebi n .u buntu .com/59 4 60 3 / .  P us hed  t o  p ublic  br anch an d waitingondi ff change... <b ac> gary_p ost er: i thinktha t's mu ch  cl e arer<ga ry_po ster>c ool, t hank youba c 
<gary _ poster> b ac , Iconsidered your a d d_ s ubscription_ov erlayap p ro a c h b utI felt itwo uld h a ve been mo r e fra g ile: when cod e changed t h e l ocal v ar iab l e, itwould  h a veneeded to b e su re that i t also changed the nam espace  ve rsi on i n  o rd erfo r  th e  t est s  to  be reli ab le .  Ifelt t h a t al way s ge tting  the overlayfro m th e  na mespa ce wa s ach eap c ost fo r tha treduction in fr agil ity.  The ref or e,fw iw, I intend  to  le ave itas it i s .
< ga r y _ po ster> thank you fo rt h ereview!<bac>g ar y_ p oster: n ot  to  bel a b or th e po i nt , but wo uldn't th etest br ea k if t he  na mes  were chan ged ou t from u nderi t?
<bac> it is a idiom we us e  i n th a t mo dul e
<gary_pos ter> bac,  itd ep end s  on h ow th at na m e were set, and eve nif itis cl eaned up acro ss test ru n s <gary_po ster >  i t  might very we ll wo rk now
<ga r y_poster > get ting itfrom then a mespaceals o s imp lyd i dn 't bother mei n  the  s lightes t
< gary_po ste r>I'm  gu es sing youdon't fe el  d if fe ren tly e n ough toma keapoi nt of it, si nce y ou d id n' t  do  so int he r evie w.  Hadyou ,I wou ld h a vecomplie d, becaus e e v en t ho ug h I fee l comfortable  w ith what I  d id,  I don ' t  feel st rongly about it either. <bac> g ary _post er:i'm going  to  takethe dog fo r a wa lk. wi llb e  back l at er.  have a goo d wee kend<g ary_ poster>  you too bac.  bye #la unchpad-yello w 2 012- 0 4 -0 9
< b ac >  he ll o . e c ho, echo.
<benj i> echo, e ch o ,echo...
<b a c>so  you're  workin g tod a y benji ?
<benji>  I'm goin gto g i v e i t a shot. I'm pre tty sureI 'll b e  a ble t o.<bac>so  no  reco very o v erthe w eekend ?<benji > May be  a sligh t recorvery.
 it_would, as_it seems to be_a hot_potato_atm
<gary_poster> yeah
<gary_poster>_bac,_I did this:_http://pastebin.ubuntu.com/594603/.  _Pushed to public branch_and waiting on_diff_change...
<bac> gary_poster: i think that's much clearer
<gary_poster> cool, thank you bac
<gary_poster> bac, I considered_your_add_subscription_overlay approach_but_I_felt it would have been_more fragile: when code changed_the local_variable, it would have needed to be sure_that_it also changed_the namespace version in order for the tests to_be reliable.  I felt that_always getting the_overlay_from_the namespace was a_cheap cost for that reduction in_fragility.  Therefore, fwiw, I intend_to leave it as it is.
<gary_poster> thank_you for the review!
<bac> gary_poster: not_to belabor the point, but_wouldn't the_test break if the names_were changed out_from under_it?
<bac> it is_a idiom we use in that_module
<gary_poster> bac, it_depends on how that name were_set,_and even if_it_is_cleaned up_across test runs
<gary_poster>_it_might very_well_work now
<gary_poster> getting it from the_namespace_also simply didn't bother me in the_slightest
<gary_poster> I'm guessing you_don't_feel differently enough to_make a point of it,_since you didn't do so in_the review._ Had_you, I would have complied, because even though I feel comfortable_with what I did, I don't_feel strongly about it_either.
<bac> gary_poster:_i'm_going to take_the_dog for_a walk.  will be back later._ have_a good weekend
<gary_poster> you too bac._ bye
#launchpad-yellow 2012-04-09
<bac> hello.__echo, echo.
<benji> echo, echo, echo...
<bac> so_you're working today benji?
<benji> I'm going_to give it a shot.__I'm_pretty sure I'll be able_to.
<bac> so no recovery over the_weekend?
<benji> Maybe a_slight recorvery.