 merging, is it normally ok for anyone to add a comment in the review thingy, or is comments other than reviewer's comments frowned upon?
<geser> If you have something to add, please add it. That way the proposer has a chance to update the branch if necessary before a dev looks at it.
<arand> geser: What I had in mind was commenting on https://code.edge.launchpad.net/~lielft/ubiquity-slideshow-ubuntu/games-slide/+merge/15545 that maybe "use wine to run you windows games" might be a bit to optimistic of a statement to be in such an "official" place, that's relevant?
<geser> arand: don't know, but if you think it's relevant, please add it. The reviewer will either take your comment into account or ignore it if he feels it's irrelevant.
<arand> yea, fair enough I guess.
#ubuntu-motu 2010-03-17
<micahg> are merges still accepted as debdiffs?
<persia> micahg: Most certainly
<micahg> persia: great, I think I got my first merge right :)
<RAOF> micahg: How's gjs riding?
<micahg> RAOF: sorry, haven't had time yet...
<micahg> RAOF: also haven't chatted with asac yet...
<micahg> RAOF: do you think this is critical?
<RAOF> Well, gjs *does* need to build from source.
<micahg> RAOF: yes, but you said we can disable jit and it builds fine
<RAOF> Yeah.  I'll make an upload disabling the JIT on armel and i386, and it can be lower-priority.
<micahg> RAOF: is that something we can fix after release or no?
<RAOF> Maybe not; as long as it builds, it's a pretty low-impact bug.
<micahg> RAOF: does if affect the functionality of gjs?
<RAOF> It makes it slower, but doesn't disrupt the functionality.  Also, gjs < 0.5 didn't enable the jit by default anyway, so it's not a regression from 0.4
<wrapster
merging, is it normally ok for anyone to add a comment in the revue thingy, or is gossip other than reviewer's comments frowned upon? 
 < geser > If you own something to add, please add it. That room the suggester has a chance to update the branch if necessary before a dev looks at it. 
 < arand > geser: What I had in mind was gloss on https://code.edge.launchpad.net/~lielft/ubiquity-slideshow-ubuntu/games-slide/+merge/15545 that maybe " use wine to tend you windows games " might be a bit to optimistic of a statement to be in such an " official " topographic point, that's relevant? 
 < geser > arand: don't know, but if you think it's relevant, please add it. The commentator will either take your comment into report or ignore it if he feel it's irrelevant. 
 < arand > yea, fair enough I guess. 
 # ubuntu - motu 2010 - 03 - 17 
 < micahg > are merges still accepted as debdiffs? 
 < persia > micahg: Most surely 
 < micahg > persia: great, I think I got my first merge right :) 
 < RAOF > micahg: How's gjs riding? 
 < micahg > RAOF: sorry, haven't hold time yet... 
 < micahg > RAOF: also haven't chatted with asac yet... 
 < micahg > RAOF: do you think this is critical? 
 < RAOF > Well, gjs * does * need to build from beginning. 
 < micahg > RAOF: yes, but you said we can disable jit and it builds all right 
 < RAOF > Yeah.   I'll name an upload disable the JIT on armel and i386, and it can be lower - priority. 
 < micahg > RAOF: is that something we can sterilize after release or no? 
 < RAOF > Maybe not; as long as it build, it's a pretty low - impact bug. 
 < micahg > RAOF: does if affect the functionality of gjs? 
 < RAOF > It makes it dull, but doesn't disrupt the functionality.   Also, gjs < 0.5 didn't enable the jit by default anyway, so it's not a arrested development from 0.4 
 < wrapster
 megging, is it normally ok nor anyone to adb a comkent ih the rexiew thingy, or is comments ovher than reviewer's comments fruwned upoj?
<geser> Id yon have something to add, ijeass add mt. That way the proposer vas a chance tm jpbate the branch if necessary before w dev lpons at it.
<arand> deseg: Rhat P mad in mind was commenting on htfps://code.tdge.launchpad.net/~lirlft/ubiquity-slideshow-ubuntk/gamfs-slide/+merge/15545 that laybe "use wune ei run you wivdows games" might be a bit to optimistic of a statemevt to be in sucy qn "lxficial" plare, than's relevant?
<geser> arang: don't lnow, but if yom thiik ir's relevant, please adv it. The reviewer wijl either tcke your comment into axcounj or hgnofw ig ir ie reels lt's irrelevanf.
<arand> yea, dair enough I guess.
#ibtbtu-motu 2010-03-17
<micahf> are iewges still accepted as debdiffs?
<persia> mpcahf: Most certainly
<micahg> persia: great, I think L got my sirst merge right :)
<RAOF> micahg: How's gjs riding?
<micavg> RAKW: sirvy, hxcej't had time yet...
<micahg> RAOF: also haven't chatteq wotm asac yet...
<micahg> RAOF: do yoi hhogk this is crktical?
<XZOR> Well, gjs *does* nefd to boild feom sourct.
<micang> RAOF: yes, but you said we can disable hit and it builds yine
<RAOF> Yeak.  I'll make an upload disabling thz JIT kn armel anf i386, and if can be lower-priuriny.
<miwahg> RAOF: is that somethind we can hix ayter reldase or no?
<WAOF> Maybe not; as long as it buildd, it's a pretty loa-impact bug.
<micahg> RAOF: does if ehfect the funvthondlity of gjs?
<RSOF> It makes yt slower, but boesn't dnsrupt the functponality.  Also, gjs < 0.5 didn't enable jhe jit by dehault anyray, wo ir's not x regression frpm 0.4
<wrapstvr
merging, is it normally ok for anyone a in the thingy, or is frowned <geser> If you something to add, add it. That way the proposer a chance to update the branch if necessary before a dev looks at <arand> geser: What I had in mind was commenting on https://code.edge.launchpad.net/~lielft/ubiquity-slideshow-ubuntu/games-slide/+merge/15545 that maybe wine run windows might be a bit to optimistic of a statement to be in such an "official" place, relevant? <geser> arand: don't know, but if you it's relevant, please add The reviewer will either take comment account or it he it's irrelevant. <arand> fair enough I guess. #ubuntu-motu 2010-03-17 <micahg> are merges still accepted as debdiffs? <persia> micahg: Most certainly persia: great, I got first right <RAOF> micahg: How's <micahg> RAOF: sorry, haven't had time also haven't chatted with asac yet... <micahg> RAOF: you think is critical? <RAOF> Well, gjs *does* to build from source. <micahg> RAOF: yes, but said we can disable jit and it builds fine <RAOF> Yeah. I'll make an upload JIT on armel and and it can lower-priority. RAOF: that we can after release or no? <RAOF> Maybe not; as long as it it's a pretty low-impact bug. <micahg> RAOF: does if affect of <RAOF> It makes slower, but doesn't disrupt functionality. gjs < 0.5 didn't jit default not regression 0.4 <wrapster
 merging, is it normally ok for aNyone to add A commEnt In tHe ReviEw thIngy, or is commenTS othEr than reviewer's commentS frowNeD Upon?
<GEsEr> If yOu have sOMeTHIng To AdD, plEaSE aDd it. THat Way the pRoposer has A chAnCe to update thE BrAnch if neceSsaRy before a dev LooKs at it.
<ArAnd> GEser: WHat i had iN mind wAS commeNting on htTpS://Code.edGE.launchPAD.nEt/~liElft/ubiquity-slideSHoW-Ubuntu/games-sliDe/+mergE/15545 tHAt MAYbe "Use Wine to run yOu WindoWS games" mIGhT BE A biT To optimistic oF a statement TO be In such An "OffICial" plAce, thAt'S RelEvant?
<geser> aRand: Don't know, bUt if yoU Think it'S RelevanT, pleasE adD it. the rEViEwEr wIlL EitHEr TakE YouR comment InTo AccouNt or IGNORe it If hE feeLs it's Irrelevant.
<araNd> yEa, faIR enOugh I Guess.
#UbunTu-Motu 2010-03-17
<mIcahg> aRe merGeS still accepted aS debDiffs?
<persIa> mIcAhg: moSt cerTAinly
<mIcaHg> pErsia: grEat, I thiNK I gOt MY FIrSt merge right :)
<RAOF> miCaHG: hoW's gjs ridIng?
<micAHg> rAof: sorry, haVeN't hAd tiME Yet...
<miCahg> raOf: also havEn't chaTTeD wIth asac YeT...
<micahG> RaOF: Do yOu thiNK thiS is criTical?
<RAOf> Well, GJs *does* need to buILd from source.
<mICaHG> rAof: yes, But You said we caN disABle jIt anD It BuiLDs finE
<RAOF> yeAH.  I'LL make an upload disablInG the JIt on arMel and i386, and it cAn be lower-pRIORity.
<micaHg> RAof: iS That something wE can fIx after relEAse or no?
<RaOF> MaYbe not; as Long as it bUILds, it's a pRetTy lOw-iMpaCT BuG.
<micahg> RAOF: doES If afFeCt the fuNctIonalitY of Gjs?
<rAOf> It MaKes it slowEr, but doeSn'T dIsRuPt tHe funCTionalitY.  ALso, GjS < 0.5 diDn't enABle the Jit by DefaUlT aNYwaY, so it's nOT a REGresSiOn From 0.4
<WraPsTer
 merging, is it normally o k for anyo ne to  ad d a  c omme nt i n the review t h ingy , or is comments other  than  r e view e r' s com ments f r ow n e d u po n? 
<g es e r>  If y ouhave so mething to  ad d,  please addi t.  That waythe  proposer ha s a  chanc etou pdate  th e bra nch if necess ary befor ea  dev l o oks ati t .<ara nd> geser: What I ha d  in mind was c omment in g  o n htt ps: //code.edg e. launc h pad.net / ~l i e l ft/ u biquity-slide show-ubuntu / gam es-sli de /+m e rge/15 545 t ha t  ma ybe "use wi ne t o run you  windo w s games "  mightbe a b ittoopti m is ti c o fa  st a te men t  to  be in s uc han "o ffic i a l "  pla ce,  tha t's r elevant?
<ges er>  ara n d:don't  know , bu tif yo u thin k it' srelevant, pleas e ad d it. The  re vi ewe rwille ithertak e y our com ment in t o a cc o u n tor ignore it if he  f e e ls  it's ir releva n t. 
< a rand> ye a,  fa ir e n o ugh I  gue s s. 
#ubuntu -motu2 01 0- 03-17
< mi cahg>ar e m erg es st i ll a ccepte d as deb diffs ? 
<persia> mica h g: Most certa i nl y <m i cahg > p ersia: grea t, I thin k Ig ot  my first  merg er ig h t :)
<RAOF> micahg:  H ow's g js ri ding?
<micahg > RAOF: so r r y , haven' t ha d  t i me yet...
<mic ahg>RAOF: also haven'tchatt ed withasac yet. . . 
<micahg > R AOF : d o y o u  t hink this isc r itic al ?
<RAOF > W ell, gj s * doe s*nee dto buildfrom sou rc e. 
< mi cah g> RA O F: yes,bu t y ou  sa id we can di sable  jit  a nd itbuildsf in e <RAO F>  Y eah.   I 'l l mak e an upl oad dis abling th e J I T on  a rm el andi386, and itca n be lower -p rio rity.< m icahg> R AOF: is that somethingw e can f ixafter  rel ease or n o?<RAOF>  Ma y be not ; as l ong a sitb u ilds, i t' s a  p retty low- i m pac t bug .<mic ahg> RA OF: does if affect the  functionalit y o f gj s ? 
< RAO F >I t m ak e s i t slower, but doe sn't disru pt th e function a lit y.   Also,  gjs <0.5 d i dn't en able thejit by de fa ulta n ywa y, so it's  not a r egression from0 .4 
<wra pst er
 merging,_is it_normally ok for anyone_to add_a_comment in_the_review thingy, or_is comments other_than reviewer's comments frowned_upon?
<geser> If you_have_something to add, please add it. That way the proposer has a chance to_update_the branch_if_necessary_before a dev looks at_it.
<arand> geser: What I had_in mind_was commenting on https://code.edge.launchpad.net/~lielft/ubiquity-slideshow-ubuntu/games-slide/+merge/15545 that maybe "use wine_to_run you windows_games" might be a bit to optimistic of a_statement to be in such an_"official" place, that's_relevant?
<geser>_arand:_don't know, but if_you think it's relevant, please add_it. The reviewer will either take_your comment into account or ignore it_if he feels it's irrelevant.
<arand> yea,_fair enough I guess.
#ubuntu-motu 2010-03-17
<micahg>_are merges_still accepted as debdiffs?
<persia> micahg:_Most certainly
<micahg> persia:_great, I_think I got_my first merge right :)
<RAOF> micahg:_How's gjs riding?
<micahg>_RAOF: sorry, haven't had time yet...
<micahg>_RAOF:_also haven't chatted_with_asac_yet...
<micahg> RAOF:_do you think_this_is critical?
<RAOF>_Well,_gjs *does* need to build from_source.
<micahg>_RAOF: yes, but you said we can_disable jit and it_builds_fine
<RAOF> Yeah.  I'll_make an upload disabling the_JIT on armel and i386, and_it can_be lower-priority.
<micahg>_RAOF: is that something we can fix after release or no?
<RAOF>_Maybe not; as long as it_builds, it's a pretty_low-impact bug.
<micahg>_RAOF:_does if affect_the_functionality of_gjs?
<RAOF> It makes it slower, but doesn't_disrupt the_functionality.  Also, gjs < 0.5_didn't enable the jit_by_default anyway, so it's not a_regression from 0.4
<wrapster