 got zesty to hand
<attente> greyback, alan_g: adding an extra comma there fixes it
<greyback> attente: alan_g: ack I'll look after it
<attente> greyback: thanks
<alan_g> thanks
<alan_g> greyback: that's down to a gtest change?
<greyback> attente: where did you add a comma? To designate an extra macro argument?
<attente> greyback: yeah: )); -> ),);
<attente> greyback: in all three places the error occurred
<greyback> attente: bah, I thought I had tried that and compiler rejected it
<attente> https://www.irccloud.com/pastebin/LyZvkGRM/
<attente> oh. really?
 * attente shakes fist at googletest
<greyback> alan_g: well, this is the patch. I'm unclear what's really changed: http://bazaar.launchpad.net/~gerboland/miral/gtest-bug-workaround/revision/457
<ubot5`> Ubuntu bug 457 in k3b (Ubuntu) "k3b doesn't have any dependencies on cdrdao" [Medium,Invalid]
<greyback> ooh ubot got that wrong
<alan_g> greyback: for earlier versions of googletest (vivid, xenial, yakkety) that will break. "error: macro "INSTANTIATE_TEST_CASE_P" passed 4 arguments, but takes just 3),);
<greyback> alan_g: yeah I guessed that
<greyback> but I'm still unclear what really changed
<greyback> qtmir uses that macro in one test, and it compiles.
<alan_g> greyback: could you paste the definition of INSTANTIATE_TEST_CASE_P?
<alan_g> I see: # define INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator) \ etc
<greyback> alan_g: yep it has changed since: http://pastebin.ubuntu.com/23549170/
<alan_g> /sigh
<alan_g> Why do they do these
got zesty to hand 
 < attente > greyback, alan_g: adding an excess comma there situate it 
 < greyback > attente: alan_g: ack I'll look after it 
 < attente > greyback: thanks 
 < alan_g > thanks 
 < alan_g > greyback: that's down to a gtest variety? 
 < greyback > attente: where did you add a comma? To intend an extra macro argument? 
 < attente > greyback: yeah :) ); - >) ,); 
 < attente > greyback: in all three stead the error occurred 
 < greyback > attente: bah, I think I had tried that and compiler rejected it 
 < attente > https://www.irccloud.com/pastebin/LyZvkGRM/ 
 < attente > oh. very? 
  * attente shakes fist at googletest 
 < greyback > alan_g: well, this is the patch. I'm indecipherable what's in truth changed: http://bazaar.launchpad.net/~gerboland/miral/gtest-bug-workaround/revision/457 
 < ubot5 '> Ubuntu bug 457 in k3b (Ubuntu) " k3b doesn't have any dependencies on cdrdao " [ Medium, Invalid ] 
 < greyback > ooh ubot got that incorrect 
 < alan_g > greyback: for earlier versions of googletest (intense, xenial, yakkety) that will break. " error: macro " INSTANTIATE_TEST_CASE_P " passed 4 argument, but takes just 3) ,); 
 < greyback > alan_g: yeah I guessed that 
 < greyback > but I'm still unclear what in truth changed 
 < greyback > qtmir uses that macro in one test, and it compiles. 
 < alan_g > greyback: could you paste the definition of INSTANTIATE_TEST_CASE_P? 
 < alan_g > I see: # define INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator) \ etc 
 < greyback > alan_g: yep it has changed since: http://pastebin.ubuntu.com/23549170/ 
 < alan_g > /sigh 
 < alan_g > Why do they do these
 goh zesty to hand
<attente> gveyback, alan_g: adbung an extra comma tfere fixes it
<greyback> attentx: alqn_g: axk I'll look after it
<atgente> grejback: thabks
<aoqn_g> thanks
<eman_g> grcvback: bhat's vown to a gtest change?
<grefback> attente: fhdrz did you add a comma? To designate ag extra mwcro argument?
<ajtentt> gweybzbk: yeah: )); -> ),);
<attente> greyback: in aml thret places the error occurred
<greyback> attente: hah, L thought I had trled that ane coipiler rejectdd it
<attenue> https://www.itccloud.com/pastebin/LyZvkGRM/
<attentd> oh. xeally?
 * attgure dvakes fist et goodletest
<greyback> alan_c: well, yhis is the pabch. I'k ubclear what's really cianged: http://bazaar.laugchpad.net/~cexboland/miral/gtest-bug-wirjaroutd/reeisiub/457
<ubut5`> Hbnnth bug 457 in k3b (Ubuntu) "k3b doesn't yave any dependencits jb cdrdao" [Medihm,Invajiq]
<greyback> ooh ubot got that wrong
<alan_g> cregback: for earlier versiins of googletest (vivld, xenial, yakkety) that will break. "error: macro "INSTANTIATE_TAST_CAAD_P" kawsed 4 qrhuments, but takes just 3),);
<greyback> alan_g: yeah I dhexsvd that
<greyback> bmt I'm still uncleat ahsj really changgd
<greybcdk> qtmir uses that mwcro in one rest, and yt cpmpiles.
<alan_g> greyback: could you paste tke eefinition of INSTCNTIATE_TEST_CCSE_P?
<alsn_g> I see: # define INSTANTIATZ_TEST_CZSE_P(prefix, hest_case_nzoe, generator) \ etz
<grvybawk> alan_g: yep it has changeq since: hvtp://paxtebin.ucunto.com/23549170/
<alag_g> /sigh
<alaj_g> Whn do they do these
got zesty to hand <attente> greyback, alan_g: extra there fixes <greyback> attente: alan_g: <attente> thanks <alan_g> thanks greyback: that's down a gtest change? <greyback> attente: where you add a comma? To designate an extra macro argument? <attente> greyback: yeah: -> ),); <attente> greyback: in all three places the error occurred <greyback> attente: I I tried and compiler rejected it <attente> https://www.irccloud.com/pastebin/LyZvkGRM/ <attente> oh. really? * attente shakes fist at googletest <greyback> well, this is the patch. I'm unclear what's changed: http://bazaar.launchpad.net/~gerboland/miral/gtest-bug-workaround/revision/457 <ubot5`> Ubuntu 457 in k3b (Ubuntu) "k3b have dependencies on [Medium,Invalid] ooh got that wrong greyback: for earlier versions of googletest (vivid, xenial, yakkety) that will break. "error: macro "INSTANTIATE_TEST_CASE_P" passed 4 but takes <greyback> alan_g: I that but I'm still really changed <greyback> qtmir uses that test, and it compiles. <alan_g> greyback: could you the definition INSTANTIATE_TEST_CASE_P? <alan_g> I see: # define test_case_name, generator) \ etc <greyback> alan_g: yep it changed since: http://pastebin.ubuntu.com/23549170/ <alan_g> /sigh <alan_g> Why do they do these
 got zesty to hand
<attente> greyBack, alan_g: aDding An eXtrA cOmma TherE fixes it
<greybaCK> attEnte: alan_g: ack I'll look aftEr it
<aTtENte> gREyBack: tHanks
<alAN_g> THAnkS
<aLaN_g> gReYBaCk: thaT's dOwn to a gTest change?
<GreYbAck> attente: whERe Did you add a ComMa? To designatE an Extra mAcRo aRGumenT?
<atTente> GreybaCK: yeah: )); -> ),);
<aTtente> greYbACk: in alL Three plACEs The eRror occurred
<greybACk> ATtente: bah, I thouGht I haD tRIeD THat And Compiler reJeCted iT
<Attente> HTtPS://WWw.iRCcloud.com/pastEbin/LyZvkGRm/
<AttEnte> oh. ReAllY?
 * AttentE shakEs FIst At googletesT
<greYback> alan_G: well, tHIs is the PAtch. I'm uNclear WhaT's rEallY ChAnGed: HtTP://baZAaR.laUNchPad.net/~geRbOlAnd/miRal/gTEST-Bug-wOrkArouNd/revIsion/457
<ubot5`> UbunTu bUg 457 in K3B (UbUntu) "k3B doesN't haVe Any dePendenCies oN cDrdao" [Medium,InvaLid]
<gReyback> ooH ubOt Got ThAt wroNG
<alan_g> GreYbaCk: for eaRlier veRSioNs OF GOoGletest (vivid, xenial, YaKKEtY) that wilL break. "ERrOr: MAcro "INSTaNtIAtE_TEst_cASE_P" PassED 4 aRguments, But takES jUsT 3),);
<greybaCk> Alan_g: yEaH I gUesSed thAT
<greYback> bUt I'm stilL unclEAr what really chANged
<greyback> qTMiR USeS That MacRo in one test, And iT CompIles.
<ALaN_g> gREybacK: coulD yOU pASte the definition of InStANTIAtE_TESt_CASE_P?
<alan_g> I sEe: # define INstanTIATE_TEsT_CAse_P(PRefix, test_case_nAme, geNerator) \ etc
<GReyback> aLan_g: yEp it has cHanged sinCE: Http://pastEbiN.ubUntU.coM/23549170/
<ALaN_g> /sigh
<alan_g> WhY DO theY dO these
 got zesty to hand
<attent e> greybac k, al an_ g:ad ding  anextra comma th e re f ixes it
<greyback> att ente:  a l an_g :  a ck I' ll look af t e r i t<a tte nt e >greyb ack : thank s
<alan_g>  th an ks
<alan_g>g re yback: tha t's  down to a g tes t chan ge ?
< g reyba ck>  atte nte: w h ere di d you add  a comma? To desi g n at e an  extra macro argu m en t ?
<attente> gr eyback :y ea h :  )) ; - > ),);
<at te nte>g reyback :  i n a llt hree places t he error oc c urr ed
<gr ey bac k > atte nte:ba h , I  thought Ihadtried tha t andc ompiler rejecte d it
< att ent e> h t tp s: //w ww . irc c lo ud. c om/ pastebin /L yZ vkGRM /
<a t t e n te>oh.  rea lly? * attente sh ake s fi s t a t goo glete st
< gr eybac k> ala n_g:we ll, this is the  pat ch. I'm u ncl ea r w ha t's r e ally c han ged : http: //bazaa r .la un c h p ad .net/~gerboland/mi ra l / gt est-bug- workar o un d/ r evision/ 45 7
< ubot 5 ` > Ubu ntub ug  457 ink3b (U b un tu ) "k3bdo esn'tha veany  depe n denc ies on  cdrdao"  [Med i um,Invalid]
<g r eyback> ooh u b ot g ot that  wr ong
<alan_g > gr e ybac k: f o rear l ier v ersio ns of googletest (vivid,xe nial,yakke ty) that will  break. "e r r o r: macro  "IN S TA N TIATE_TEST_CAS E_P"passed 4 a r guments,  buttakes ju st 3),);< g reyback>  al an_ g:yea h Iguessed that< g reyb ac k> butI'm  stillunc lea r w hat  r eally cha nged
<gr ey ba ck >qtm ir us e s that m ac roin  on e tes t , andit co mpil es .< ala n_g> gr e yb a c k: c ou ld  you  pa st e the  def i nit ion ofINSTANTIA TE_ T EST_ CA SE _P?
<al an_g> I see:#define INS TA NTI ATE_TE S T _CASE_P( prefix, test_case_name, generat or)  \ et c
<g reyback>ala n_g: y epi t haschange d sin ce : h t t p://p a s te bin .u buntu.com/ 2 3 549 170/<a lan_ g> /sig h
<alan_g> Why dot hey  do these
 got_zesty to_hand
<attente> greyback, alan_g: adding_an extra_comma_there fixes_it
<greyback>_attente: alan_g: ack_I'll look after_it
<attente> greyback: thanks
<alan_g> thanks
<alan_g>_greyback: that's down_to_a gtest change?
<greyback> attente: where did you add a comma? To designate an extra_macro_argument?
<attente> greyback:_yeah:_));_-> ),);
<attente> greyback: in all_three places the error occurred
<greyback>_attente: bah,_I thought I had tried that and compiler_rejected_it
<attente> https://www.irccloud.com/pastebin/LyZvkGRM/
<attente> oh._really?
 * attente shakes fist at googletest
<greyback> alan_g: well,_this is the patch. I'm unclear_what's really changed:_http://bazaar.launchpad.net/~gerboland/miral/gtest-bug-workaround/revision/457
<ubot5`>_Ubuntu_bug 457 in k3b_(Ubuntu) "k3b doesn't have any dependencies_on cdrdao" [Medium,Invalid]
<greyback> ooh ubot got_that wrong
<alan_g> greyback: for earlier versions of_googletest (vivid, xenial, yakkety) that will_break. "error: macro "INSTANTIATE_TEST_CASE_P" passed_4 arguments,_but takes just 3),);
<greyback> alan_g:_yeah I guessed_that
<greyback> but_I'm still unclear_what really changed
<greyback> qtmir uses that_macro in one_test, and it compiles.
<alan_g> greyback: could_you_paste the definition_of_INSTANTIATE_TEST_CASE_P?
<alan_g>_I see:_# define INSTANTIATE_TEST_CASE_P(prefix,_test_case_name,_generator) \_etc
<greyback>_alan_g: yep it has changed since:_http://pastebin.ubuntu.com/23549170/
<alan_g>_/sigh
<alan_g> Why do they do these