_error_state
<bcsaller> but it might change if I run it again (which I am)
<hazmat> bcsaller, yeah.. one of these tests is definitely bleeding into the others
<bcsaller> hazmat: yeah, that time it was a different one
<hazmat> bcsaller, one review comment on the change.. it would be better to just reconstruct the service state as needed rather than passing it as a new construct arg to scheduler, relhookcontext, etc
<hazmat> ie. the rel hook context has a client and can reconstruct the state on demand
<bcsaller> hazmat: doesn't the service name then need to be parsed from the unit_name
<hazmat> bcsaller, it does, but that's a pretty trivial
<bcsaller> I can make those changes 
<hazmat> i think the service-state-manager could grow a utility method for it as well
<hazmat> return the service state given a unit name
<bcsaller> makes sense,  yes
<daker> yo
<niemeyer> daker: Yo
<niemeyer> daker: So,
<niemeyer> daker: "--password=" < that's not going to work if you split the arguments 
<niemeyer> daker: You can drop the "=" sign there
<niemeyer> daker: Then they can be in separate arguments
<niemeyer> daker: This won't do what you want as well:
<niemeyer> "< %(ensemble_sql)s" % config)
<daker> should be splited?
<niemeyer> daker: It's a bit trickier in this case
<niemeyer> daker: When you provide something like that to the shell, what's happening is that the file descriptor for stdin is being replaced to that of the open file with the given name.
<niemeyer> daker: Have you considered using bash for your script?
<niemeyer> daker: In case that's what you're most comfortable with?
<daker> i am comfortable with python, bash was suggested by kim0
<niemeyer> daker: Aha, ok
<d
_ error_state 
 < bcsaller > but it might change if I run it again (which I am) 
 < hazmat > bcsaller, yeah.. one of these tests is definitely bleed into the others 
 < bcsaller > hazmat: yeah, that meter it was a different one 
 < hazmat > bcsaller, one review comment on the variety.. it would be better to just reconstruct the overhaul state as needed preferably than passing it as a new concept arg to scheduler, relhookcontext, etc 
 < hazmat > ie. the rel hook context has a client and can reconstruct the department of state on demand 
 < bcsaller > hazmat: doesn't the service name then need to be parsed from the unit_name 
 < hazmat > bcsaller, it does, but that's a reasonably trivial 
 < bcsaller > I can make those changes 
 < hazmat > i intend the service - state - director could grow a utility program method for it equally well 
 < hazmat > return the service state given a whole name 
 < bcsaller > makes sense,   yes 
 < daker > yo 
 < niemeyer > daker: Yo 
 < niemeyer > daker: So, 
 < niemeyer > daker: " --password= " < that's not going to work if you separate the argument 
 < niemeyer > daker: You can drop the " = " sign there 
 < niemeyer > daker: Then they can be in separate arguments 
 < niemeyer > daker: This won't do what you want equally well: 
 < niemeyer > " <% (ensemble_sql)s "% config) 
 < daker > should be splited? 
 < niemeyer > daker: It's a spot trickier in this casing 
 < niemeyer > daker: When you leave something like that to the shell, what's happening is that the file descriptor for stdin is being replace to that of the open file with the given name. 
 < niemeyer > daker: Have you considered using knock for your script? 
 < niemeyer > daker: In case that's what you're most comfortable with? 
 < daker > i am comfortable with python, bash was suggested by kim0 
 < niemeyer > daker: Aha, ok 
 < d
_errlr_state
<bcsaller> but it mlght change if I run it again (which I am)
<hazmat> bcsaller, yeah.. one lf thest tests is definiteuy bleedijg into rhe irhers
<bcsaller> hazmat: yeag, thac vime it was a dlfferent ona
<hazmat> bcsallar, oue review comment on the change.. it wjuld be bftter to just teconxerucf the service state as needed rathsr than passing it ax a new construct arg to sfhedkler, relhookcontexh, etc
<hazmat> ie. eye rel hook zontext has a client ahd can reconstruct the state on demaud
<bcsaller> yazmah: doesn't the servpce name then need to be parxed from the ukit_nake
<hqzmat> bcsaller, it doev, but that's a pretjy trivial
<tcaaller> I can make tyose whances 
<fqzmxt> j vhihk the secvice-state-mznager coule grow a utility meuhoq for it as weml
<hazmwt> return the service state given a unit tams
<bcsaller> makes sense,  tes
<daker> yo
<niemeyer> dwker: Yo
<niqmeyer> daker: So,
<niemeyer> daker: "--password=" < that's not goinj go cirk iw ylu split the arguments 
<niemeyer> daker: You can srpp the "=" sign theve
<niemeyer> daker: Tnej yrey can be in separcfe arguments
<niemeyer> daker: Jhis win't do whwt ypu want as well:
<niemeyer> "< %(enwemble_sql)s" % bonfug)
<daker> should be dplited?
<niemzyer> dsker: Ot's a bit trickier in tkis caae
<niemeyer> faker: Wheh you provide somdthpng nike thau to the shell, whae's happenmng ix that ghe gile dqscriptor vor sbgin is being replafed tl dhat of thf open file with the given name.
<imemeyer> daker: Hdve you confidercd using bash fjr your script?
<uiemeyer> dakef: In case nhat's whav you're most comfortable flth?
<daker> i ak comforeablw wirh pythuv, bash was sugbested by kim0
<niemeywr> daker: Aha, ok
<d
_error_state <bcsaller> but it might change if it (which I <hazmat> bcsaller, yeah.. definitely into the others hazmat: yeah, that it was a different one <hazmat> one review comment on the change.. it would be better to just reconstruct service state as needed rather than passing it as a new construct arg scheduler, etc ie. rel hook context has a client and can reconstruct the state on demand <bcsaller> hazmat: doesn't service name then need to be parsed from unit_name <hazmat> bcsaller, it but that's a pretty trivial I make those <hazmat> think service-state-manager could grow utility method for it as well <hazmat> return the service state given a unit name <bcsaller> makes yes <daker> daker: Yo daker: <niemeyer> "--password=" < that's to work if you split the You can drop the "=" sign there <niemeyer> Then they be in separate arguments <niemeyer> daker: won't do what you want as well: <niemeyer> %(ensemble_sql)s" % config) <daker> should be splited? <niemeyer> daker: It's a bit trickier in this daker: When you provide like that to shell, happening that file descriptor stdin is being replaced to that of the open file with given name. <niemeyer> daker: Have you considered using bash for <niemeyer> In case that's you're most comfortable with? i comfortable with python, bash by <niemeyer> <d
_error_state
<bcsaller> but it miGht change iF I run It aGaiN (wHich i am)
<hAzmat> bcsaller, yEAh.. onE of these tests is definitEly blEeDIng iNTo The otHers
<bcsALlER> HazMaT: yEah, ThAT tIme it Was A differEnt one
<hazmAt> bCsAller, one reviEW cOmment on thE chAnge.. it would bE beTter to JuSt rEConstRucT the sErvice STate as Needed ratHeR Than paSSing it aS A NeW conStruct arg to scheduLEr, RElhookcontext, eTc
<hazmAt> IE. tHE Rel HooK context haS a ClienT And can rECoNSTRucT The state on demAnd
<bcsaller> HAzmAt: doesN't The SErvice Name tHeN NeeD to be parsed From The unit_naMe
<hazmAT> bcsallER, it does, But thaT's a PreTty tRIvIaL
<bcSaLLer> i CaN maKE thOse changEs 
<HaZmat> i ThinK THE ServIce-StatE-manaGer could grow a UtiLity MEthOd for It as wEll
<hAzMat> reTurn thE servIcE state given a uniT namE
<bcsaller> MakEs SenSe,  Yes
<daKEr> yo
<niEmeYer> Daker: Yo
<NiemeyeR> DakEr: sO,
<NIeMeyer> daker: "--password=" < ThAT'S nOt going tO work iF YoU sPLit the arGuMenTs 
<niEMEyer> dAker: yOu Can drop tHe "=" sign THeRe
<NiemeyeR> dAker: ThEn TheY caN be in SEparAte argUments
<niEmeyeR> Daker: This won't dO What you want as WElL:
<NIeMEyer> "< %(EnsEmble_sql)s" % coNfig)
<DAker> ShouLD bE spLIted?
<nIemeyEr> DAkER: It's a bit trickier in tHiS case
<nIemeyEr> daker: When yoU provide soMETHing like That TO tHE shell, what's hapPeninG is that the FIle descrIptor For stdin Is being rePLAced to thAt oF thE opEn fILE wIth the given naME.
<NiemEyEr> daker: havE you conSidEreD usIng BaSh for your Script?
<niEmEyEr> DaKer: in casE That's whaT yOu'rE mOst ComfoRTable wIth?
<daKer> i Am CoMForTable wiTH pYTHon, bAsH wAs suGgeStEd by kIm0
<niEMeyEr> daker: aha, ok
<d
_error_state
<bcsaller> bu t it might  chan geifIrunit a gain (which Ia m)
< hazmat> bcsaller, yeah .. on eo f th e se  test s is de f in i t ely  b le edi ng in to th e o thers
< bcsaller>haz ma t: yeah, tha t  t ime it was  adifferent on e
< hazmat >bcs a ller,  on e rev iew co m ment o n the cha ng e .. itw ould be b et terto just reconstru c tt he service sta te asne e de d rat her  than pass in g ita s a new co n s t ruc t  arg to sched uler, relho o kco ntext,  e tc< hazmat > ie.  t h e r el hook con text  has a cl ient a n d can r e constru ct the  st ate  ond em an d
< bc s all e r>  ha z mat : doesn' tth e ser vice n a m e th enneed  to b e parsed from  th e un i t_n ame
< hazma t> b cs aller , it d oes,bu t that's a pret ty t rivial
<b csa ll er>  I  canm ake th ose  ch anges <hazmat >  ith i n k  t he service-state-m an a g er  could g row au ti li t y method  f orit a s well<haz m at > return  the s e rv ic e state  g iven a  u nit  na me
<b c sall er> ma kes sens e,  y e s
<daker> yo
< n iemeyer> dake r :Y o 
< n ieme yer > daker: So ,
<n i emey er>d ak er: "--pa sswor d= "  < that's not going to  w ork if  yousplit the arg uments 
<n i e m eyer> da ker: Yo u  can drop the"=" s ign there< niemeyer > dak er: Then  they can b e in sep ara tearg ume n t s<niemeyer> da k e r: T hi s won't  do  what y ouwan t a s w el l:
<nieme yer> "<%( en se mb le_ sql)s "  % confi g) 
<d ak er>  shou l d be s plite d?
< ni em e yer > daker :  I t ' s abi ttric kie rin th is c a se<niemey er> daker : W h en y ou  p rovidesomething lik ethat to th eshe ll, wh a t 's happe ning is that the file d e scripto r f or st dinis beingrep lacedtot hat of  the o pen f il e w i t h the g iv enna me.
<nieme y e r>daker :Have  you co nsidered using bas h  fo r your script ?
< niem e y er > d a ke r : I nc ase t hat's what you' re most co mf o rt able with? <da ke r> i am  comfor table with py thon, bas h was sug ge sted b y k im0
<nieme yer> dak er: Aha,o k
<d
_error_state
<bcsaller> but_it might_change if I run_it again_(which_I am)
<hazmat>_bcsaller,_yeah.. one of_these tests is_definitely bleeding into the_others
<bcsaller> hazmat: yeah,_that_time it was a different one
<hazmat> bcsaller, one review comment on the change.. it_would_be better_to_just_reconstruct the service state as_needed rather than passing it_as a_new construct arg to scheduler, relhookcontext, etc
<hazmat> ie._the_rel hook context_has a client and can reconstruct the state on_demand
<bcsaller> hazmat: doesn't the service name_then need to_be_parsed_from the unit_name
<hazmat> bcsaller,_it does, but that's a pretty_trivial
<bcsaller> I can make those changes_
<hazmat> i think the service-state-manager could grow_a utility method for it as_well
<hazmat> return the service state_given a_unit name
<bcsaller> makes sense, _yes
<daker> yo
<niemeyer> daker:_Yo
<niemeyer> daker:_So,
<niemeyer> daker: "--password="_< that's not going to work_if you split_the arguments 
<niemeyer> daker: You can_drop_the "=" sign_there
<niemeyer>_daker:_Then they_can be in_separate_arguments
<niemeyer> daker:_This_won't do what you want as_well:
<niemeyer>_"< %(ensemble_sql)s" % config)
<daker> should be splited?
<niemeyer>_daker: It's a bit_trickier_in this case
<niemeyer> daker:_When you provide something like_that to the shell, what's happening_is that_the file_descriptor for stdin is being replaced to that of the open_file with the given name.
<niemeyer> daker:_Have you considered using_bash for_your_script?
<niemeyer> daker: In_case_that's what_you're most comfortable with?
<daker> i am comfortable_with python,_bash was suggested by kim0
<niemeyer> daker:_Aha, ok
<d