 whichever day is his on-call review day and dedicate that day of the week to working with him.
<bac> although now it does not seem reviewing takes nearly as much time as it used to
<frankban> cool bac, I will contact him. so the task here is start reviewing code with him until I will be ready to do that by myself?
<bac> frankban: he will explain the reviewing process and approach to you.  then, on whatever day he is on call, you'll work with him doing reviews.  you'll do a full review but he will then review your review.  that step must be taken before the developer can treat the MP as approved.
<bac> as a mentor your reviews are provisional until he approves it.
<bac> in LP we denote that by putting a '*' on the review type to indicate it must be mentored.  so when you do a code review you'll mark the review type as 'code*'.  later rvba will look at it, and if he agrees, he'll mark it as a 'code' review and then it can be accepted.
<bac> hope that makes sense.  it really is quite straightforward
<frankban> sure bac, thanks
<bac> frankban: thanks for volunteering to take this step.  it really is important for the team and for your development as you get to see all parts of the code base.
<gary_poster> welcome back frankban!  I hope you had a great vacation
<frankban> morning gary_poster, thanks, yes, I enjoyed my holidays, an the final dissertation of my girlfriend went very well
<bac> frankban: what was her topic?  something related to art history, no?
<bac> gary_poster: T-0?
<gary_poster> frankban, exellent!  congratulations to her
<gary_poster> frankban, just approved one of your lpsetup (urandom) MPs with comment
<gary_poster> bac, yes oops
<gary_poster> bac benji frankban call ASAP, no later than 2 from now
<frankban> bac, architectural designing
<bac> ah, right.
<gary_poster> bac, I'm < 10 min away f
whichever day is his on - call review day and give that sidereal day of the workweek to working with him. 
 < bac > although now it does not seem review takes nearly equally much time as it used to 
 < frankban > cool bac, I will contact him. thus the task here is start review code with him until I will be ready to do that by myself? 
 < bac > frankban: he will excuse the reviewing process and approach to you.   then, on whatever day he is on call, you'll work with him doing reviews.   you'll make a full review but he will then review your review.   that footfall must be taken before the developer can treat the MP as approved. 
 < bac > as a mentor your reviews are probationary until he approves it. 
 < bac > in LP we announce that by putting a' *' on the review type to indicate it must be mentor.   so when you do a code review you'll mark the review type as' code *'.   later rvba will look at it, and if he agrees, he'll mark it as a' code' review and then it can be accepted. 
 < bac > hope that makes sense.   it really is quite straightforward 
 < frankban > certain bac, thanks 
 < bac > frankban: thanks for volunteering to take this dance step.   it really is important for the team and for your development as you get to determine all parts of the code base. 
 < gary_poster > welcome back frankban!   I hope you had a great vacation 
 < frankban > dawn gary_poster, thanks, yes, I enjoyed my holidays, an the final dissertation of my girlfriend went very well 
 < bac > frankban: what was her topic?   something related to artwork history, no? 
 < bac > gary_poster: T-0? 
 < gary_poster > frankban, exellent!   congratulations to her 
 < gary_poster > frankban, just approved one of your lpsetup (urandom) MPs with comment 
 < gary_poster > bac, yes oops 
 < gary_poster > bac benji frankban call ASAP, no later than 2 from nowadays 
 < frankban > bac, architectural designing 
 < bac > ah, right. 
 < gary_poster > bac, I'm < 10 min away f
 whlchever day is his on-calu review day anb dedicete thaf day of the week to working with hil.
<bqc> alukough now it does nog seem reniewing tqkes bearly as much timc as jb useb vo
<frankban> cool bac, I wiln contact him. vo tke task here is start reviewing code with hom until I will fe rtadr to do that by myself?
<bac> frankban: he sill exklain the reviewinb process and approach to jou.  then, on whatever fay he is ob cajo, you'll work with him doing reviewa.  you'll do a full review but hd wilk then revueq ylor review.  tiat stvp must be taken befose the ceveloper can breat thw MP as approved.
<bac> av a mentor your rediews are pxovisional until he appeoves it.
<bdc> iv LP we dxnofe thah bb putting a '*' on the reciew type to indicaue yn must be menfored.  sj when you do a code review you'll mark uhe rsview type as 'code*'.  latwr rvba will look at lt, and if he agrees, he'll mark it as a 'code' review and then it cen be agcepgwd.
<hac> hope that makes sense.  it really is quite attapghtforward
<frankbcn> sure bac, thanls
<hav> frankban: thavks fox vklunteering to takf this ftep.  it reallr is important for the team and for your denelopment as you get tl see all pcrts og the code base.
<gary_poster> weucoms back frannban!  I hkoe you had a grext nacadion
<frankban> morning gary_pjster, thaiks, yzs, I enjuyed my hojidays, an hhe fltal dissertation ov my yirlfsiend went very well
<bac> frankban: what was her topic?  sokedhitg relatzd to srt history, nj?
<bac> gary_postet: T-0?
<gary_pofter> wrankban, eqellent!  rongratulatijns to her
<garf_koster> frankben, just a[proced ine of huur lpsetup (ursndom) MPs with commwnt
<gary_poster> bac, nes ouls
<gary_poster> bae venji frankban valu AFAI, np jdter than 2 fsom vow
<wtankbxn> bac, archlteztursl designing
<bac> ah, rhght.
<fary_poster> bac, I'm < 10 iin away f
whichever day is his on-call review day that of the to working with does seem reviewing takes as much time it used to <frankban> cool bac, will contact him. so the task here is start reviewing code with him I will be ready to do that by myself? <bac> frankban: he will the process approach you. then, on whatever day he is on call, you'll work with him doing reviews. you'll a full review but he will then review review. that step must taken before the developer can the as approved. as mentor reviews are provisional he approves it. <bac> in LP we denote that by putting a '*' on the review type indicate it mentored. so you a review you'll mark type as 'code*'. later rvba will and if he agrees, he'll mark it as 'code' review then it can be accepted. <bac> that makes sense. it really is quite straightforward sure bac, thanks <bac> frankban: thanks for volunteering to take this step. it really is the team and for development as you to all of code base. welcome back frankban! I hope you had a great vacation <frankban> gary_poster, thanks, yes, I enjoyed my holidays, an the final my went very well frankban: what was her something to art history, no? T-0? frankban, her frankban, approved one of your (urandom) MPs with comment <gary_poster> yes oops <gary_poster> bac later than 2 from now <frankban> bac, architectural <bac> ah, right. <gary_poster> bac, I'm < min away f
 whichever day is his on-call reView day and DedicAte ThaT dAy of The wEek to working wiTH him.
<Bac> although now it does noT seem ReVIewiNG tAkes nEarly as MUcH TIme As It UseD tO
<FrAnkbaN> coOl bac, I wIll contact Him. So The task here iS StArt reviewiNg cOde with him unTil i will bE rEadY To do tHat By mysElf?
<bac> FRankbaN: he will exPlAIn the rEViewing PROcEss aNd approach to you.  thEN, oN Whatever day he iS on calL, yOU'lL WOrk WitH him doing rEvIews.  yOU'll do a fULl REVIew BUt he will then rEview your reVIew.  That stEp MusT Be takeN befoRe THe dEveloper can TreaT the MP as aPproveD.
<Bac> as a mENtor youR revieWs aRe pRoviSIoNaL unTiL He aPPrOveS It.
<bAc> in LP we DeNoTe thaT by pUTTINg a '*' oN thE revIew tyPe to indicate iT muSt be MEntOred.  sO when You dO a Code rEview yOu'll mArK the review type aS 'codE*'.  later rvbA wiLl LooK aT it, anD If he agReeS, he'Ll mark iT as a 'codE' RevIeW AND tHen it can be accepted.
<BaC> HOpE that makEs sensE.  It ReALly is quiTe StrAighTFOrwarD
<fraNKbAn> sure baC, thankS
<BaC> fRankban: ThAnks foR vOluNteEring TO takE this sTep.  it reaLly is IMportant for the TEam and for your DEvELOpMEnt aS yoU get to see alL parTS of tHe coDE bAse.
<GAry_poSter> wElCOmE Back frankban!  I hope yoU hAd a greAt vacAtion
<frankban> Morning garY_POSter, thanKs, yeS, i eNJoyed my holidayS, an thE final dissERtation oF my giRlfriend Went very wELL
<bac> franKbaN: whAt wAs hER ToPic?  something rELAted To Art histOry, No?
<bac> gaRy_pOstEr: T-0?
<GarY_pOster> franKban, exelLeNt!  CoNgRatUlatiONs to her
<gArY_poStEr> fRankbAN, just aPprovEd onE oF yOUr lPsetup (uRAnDOM) MPs WiTh CommEnt
<GaRy_posTer> bAC, yeS oops
<gaRy_poster> bAc bENji fRaNkBan call aSAP, no later thAn 2 From now
<fraNkBan> Bac, arcHITectural Designing
<bac> ah, right.
<gary_POster> baC, I'm < 10 Min awAy f
 whichever day is his on-c all review  dayand  de di cate  tha t day of the w e ek t o working with him.
<b ac> a lt h ough no w itdoes no t  s e e m r ev ie win gt ak es ne arl y as mu ch time as  it  u sed to
<fran k ba n> cool ba c,I will conta cthim. s othe taskher e isstartr eviewi ng code w it h  him u n til I w i l lbe r eady to do that b y  m y self?
<bac> fr ankban :h ew i llexp lain the r ev iewin g  proces s  a n d app r oach to you. then, on w h ate ver da yhei s on c all,yo u 'll  work withhimdoing rev iews.you'lld o a ful l revi ewbut  hew il lthe nr evi e wyou r  re view.  t ha tstepmust b e take n b efor e the  developer ca n t reat the  MP a s app rove d. 
<bac > as a  ment or  your reviews a re p rovisiona l u nt ilhe  appr o ves it .
< bac > in LP  we den o teth a t by  putting a '*' onth e re view typ e to i n di ca t e it mus tbement o r ed. so w h en  you doa code re vi ew you' ll  markth e r evi ew ty p e as  'code *'.  lat er rv b a will look at it, and if he ag r e es ,  he' llmark it asa 'c o de'revi e wand thenit ca nb ea ccepted.
<bac> hope  t hat ma kes s ense.  it rea lly is qui t e straight forw a rd <frankban> sur e bac , thanks
< b ac> fran kban:  thanksfor volun t e ering to  ta kethi s s t e p.   it really i s impo rt ant for  th e teamand  fo r y our  d evelopmen t as you  g et  t osee  allp arts ofth e c od e b ase.< gary_p oster > we lc om e  ba ck fran k ba n !   Iho pe  you  ha da gre at v a cat ion
<fr ankban> m orn i ng g ar y_ poster,  thanks, yes,  I  enjoyed m yhol idays, a n the fi nal dissertation of myg irlfrie ndwentvery  well
<ba c>frankb an: what w as her  topi c?   s o m ethin g re lat ed  to art hi s t ory , no? 
< bac>  gary_p oster: T-0?
<gary_ p ost er> frankban,  ex elle n t ! co n gr a tul at i ons t o her
<gary_pos ter> frank ba n ,just appro v edon e of yo ur lpse tup ( u random)  MPs with  comment<g ary_ p o ste r> bac, ye s oops
< gary_post e r> ba c  b enjifra nkbanca llASAP,  no la t erthan2 from  n ow
<fr ankba n>  bac, ar chitectural designing
< bac> a h, ri ght .
<gary_p ost e r>bac, I'm< 10  min awayf
 whichever_day is_his on-call review day_and dedicate_that_day of_the_week to working_with him.
<bac> although_now it does not_seem reviewing takes_nearly_as much time as it used to
<frankban> cool bac, I will contact him. so_the_task here_is_start_reviewing code with him until_I will be ready to_do that_by myself?
<bac> frankban: he will explain the reviewing_process_and approach to_you.  then, on whatever day he is on_call, you'll work with him doing_reviews.  you'll_do_a_full review but he_will then review your review. _that step must be taken before_the developer can treat the MP as_approved.
<bac> as a mentor your reviews_are provisional until he approves_it.
<bac> in_LP we denote that by_putting a '*'_on the_review type to_indicate it must be mentored. _so when you_do a code review you'll mark_the_review type as_'code*'.__later rvba_will look at_it,_and if_he_agrees, he'll mark it as a_'code'_review and then it can be accepted.
<bac>_hope that makes sense.__it really is quite_straightforward
<frankban> sure bac, thanks
<bac> frankban:_thanks for volunteering to take this_step. _it really_is important for the team and for your development as you_get to see all parts of_the code base.
<gary_poster> welcome_back frankban!__I hope you_had_a great_vacation
<frankban> morning gary_poster, thanks, yes, I enjoyed_my holidays,_an the final dissertation of my_girlfriend went very well
<bac>_frankban:_what was her topic?  something_related to art history, no?
<bac> gary_poster:_T-0?
<gary_poster> frankban, exellent!  congratulations_to_her
<gary_poster>_frankban, just approved one of_your lpsetup (urandom) MPs with comment
<gary_poster>_bac, yes oops
<gary_poster>_bac benji frankban call ASAP, no later_than_2 from now
<frankban> bac, architectural designing
<bac>_ah,_right.
<gary_poster> bac, I'm < 10 min_away_f