 now
<tvoss_> Saviq, okay, those work for me
 * Saviq adds
<tvoss_> Saviq, will give that package a spin, too
<Saviq> tvoss_, pushed
<Saviq> tvoss_, drop the.override for good measure
<tvoss_> Saviq, ack
<Saviq> /food
<alf_> Saviq: alan_g: the DisplayChanger class holds the logic for properly reconfiguring the display (pausing/resuming), so that's what we should expose (or a similar interface), i.e., I don't think display->configure() should pause resume internally
<alf_> Saviq: alan_g: about whether we should pause/resume or schedule_compositing() instead, it depends on how well our display classes deal with posting buffers if the display is off (right now not very well it seems)
<alf_> Saviq: alan_g: and whether it actually makes sense to disable communications and input
<alan_g> alf_: I also wonder if we should be processing input when the display is off
<alf_> alan_g: don't we need to handle some kind of input event to wake up (e.g. power button press)?
<alan_g> Hmm. but touch events going to apps?
<alf_> alan_g: Turning off communications would solve that.
<alan_g> alf_: maybe not - there was a time input bypassed the thread pool. I don't remember that changing.
<alf_> alan_g: yes, so turning off communications _properly_ would solve that :)
<alf_> alan_g: and then there is also the issue of showing previous state when we wake up (because the buffer contents are obsolete)...
<alan_g> Anyway, it does look like code around patch is a cut down version of MediatingDisplayChanger
<alan_g> Which, like you say is what we should expose
<dandrader> any reason why all shell::Surface methods are virtual whereas surfaces:Surface are not. Both are concrete classes.
<alan_g> dandrader: insanity
<dandrader> lol
<alan_g> dandrader: you're also looking at an old version
<dandrader> alan_
now 
 < tvoss _ > Saviq, okay, those work for me 
  * Saviq adds 
 < tvoss _ > Saviq, will give that software a tailspin, besides 
 < Saviq > tvoss _, pushed 
 < Saviq > tvoss _, cliff the.override for estimable measure 
 < tvoss _ > Saviq, ack 
 < Saviq > /food 
 < alf _ > Saviq: alan_g: the DisplayChanger class oblige the logic for properly reconfiguring the display (pausing / resuming), so that's what we should expose (or a alike interface), i.e., I don't think display->configure () should pause resume internally 
 < alf _ > Saviq: alan_g: about whether we should hesitate / resume or schedule_compositing () instead, it depends on how well our display classes share with posting buffers if the display is off (right now not very well it look) 
 < alf _ > Saviq: alan_g: and whether it actually makes sense to disable communications and stimulation 
 < alan_g > alf _: I also wonder if we should be processing input when the display is off 
 < alf _ > alan_g: don't we necessitate to handle some kind of input event to wake up (e.g. office button press)? 
 < alan_g > Hmm. but touch events going to apps? 
 < alf _ > alan_g: turn off communications would solve that. 
 < alan_g > alf _: maybe not - there was a time input bypassed the thread pool. I don't remember that deepen. 
 < alf _ > alan_g: yes, so turning off communication _ properly _ would solve that :) 
 < alf _ > alan_g: and then there is also the return of indicate previous state when we awaken up (because the buffer contents are obsolete)... 
 < alan_g > Anyway, it does look like code around patch is a deletion down version of MediatingDisplayChanger 
 < alan_g > Which, like you say is what we should expose 
 < dandrader > any reason why all shell::Surface method are virtual whereas surfaces: open are not. Both are concrete classes. 
 < alan_g > dandrader: insanity 
 < dandrader > lol 
 < alan_g > dandrader: you're also looking at an old version 
 < dandrader > alan _
 noa
<tvoss_> Saviq, okay, those dork for me
 * Saruq addv
<tvoss_> Saviq, wkll give that package a spin, tio
<Savuq> tvoss_, pushed
<Saviq> txoss_, drop the.overeide dor good mxzsure
<tvoss_> Sablq, acn
<Waviq> /food
<alf_> Xaviq: alan_c: the DisplayCvavgzr class holds the logic for properlr recongihuring the disklay (kaufing/dvsmming), so that's what we should exlose (or a similar inyerface), i.e., I don't think didplaj->configure() should oause resumg inewrnally
<alf_> Sxviq: alan_g: about whethgr we should pause/resume or scheaule_cpmpositing() ibstfdd, it depenvs on row well our display classex deal with poxtiig byffers if the display is off (right now got very feml it seems)
<alf_> Saciw: alat_g: atd wfwthdr jt adtuallj mekes sense fo disable xommunications and on[ly
<alan_g> alf_: I also rogder if we should be processing input wven the display is off
<alf_> qlan_g: don't we need to handle sjme kind of input event to wake up (e.g. power buttot prear)?
<alck_n> Hmo. bkt touch events going to apps?
<alf_> alan_g: Turnind ogf communicationf would solfe tnwt.
<alan_g> alf_: mxybe not - there was a time lnput bipassee the thrtad ppol. I don't remember that chqnging.
<alf_> alcn_g: yes, so turning ofy communicatnons _ptoperlu_ would solve that :)
<alf_> clan_g: znd then thfre is alau the issue of sfowpng [revious state when we wakq up (becanse tke buffef comtents are obsolfte)...
<alan_g> Anyway, it does pook pine code arlund patch is a cut down versioi of MediatinbDhspnayChangzr
<alan_n> Which, like yot say is what ce shoulb expore
<dandradeg> any reavon why all shell::Surface lethods are tirtual wrereqs syrfaces:Rjrface are not. Both are concrete xlasses.
<alan_g> dandreder: jnsanity
<dandradzx> ool
<alan_g> dandracer: yot'rv aksj looking at dn oud xrrsiov
<dandrader> clxn_
now <tvoss_> Saviq, okay, those work for Saviq <tvoss_> Saviq, give that package pushed tvoss_, drop the.override good measure <tvoss_> ack <Saviq> /food <alf_> Saviq: alan_g: DisplayChanger class holds the logic for properly reconfiguring the display (pausing/resuming), so that's we should expose (or a similar interface), i.e., I don't think display->configure() should resume <alf_> alan_g: whether we should pause/resume or schedule_compositing() instead, it depends on how well our display classes deal posting buffers if the display is off (right not very well it <alf_> Saviq: alan_g: and whether actually sense to communications input alf_: I also if we should be processing input when the display is off <alf_> alan_g: don't we need to some kind event to up power press)? <alan_g> Hmm. events going to apps? <alf_> alan_g: would solve that. <alan_g> alf_: maybe not - was a input bypassed the thread pool. I remember that changing. <alf_> alan_g: yes, so turning communications _properly_ would solve that :) <alf_> alan_g: and then there is also the issue previous state when we up (because the contents obsolete)... Anyway, does look code around patch is a cut down version of MediatingDisplayChanger <alan_g> like you say is what we should expose <dandrader> any all methods are virtual surfaces:Surface are not. Both concrete <alan_g> dandrader: insanity <dandrader> dandrader: also old <dandrader>
 now
<tvoss_> Saviq, okay, those worK for me
 * SaviQ adds
<TvoSs_> SAvIq, wiLl giVe that package a SPin, tOo
<Saviq> tvoss_, pushed
<SaviQ> tvosS_, dROp thE.OvErridE for gooD MeASUre
<TvOsS_> SaViQ, AcK
<SaviQ> /foOd
<alf_> SaViq: alan_g: thE DiSpLayChanger clASs Holds the loGic For properly rEcoNfigurInG thE DisplAy (pAusinG/resumINg), so thAt's what we ShOUld expOSe (or a siMILaR intErface), i.e., I don't thinK DiSPlay->configure() sHould pAuSE rESUme IntErnally
<alf_> saViq: alAN_g: about WHeTHER we SHould pause/resUme or scheduLE_coMpositInG() inSTead, it DepenDs ON hoW well our disPlay Classes deAl with POsting bUFfers if The disPlaY is Off (rIGhT nOw nOt VEry WElL it SEemS)
<alf_> SaviQ: aLaN_g: and WhetHER IT actUalLy maKes seNse to disable cOmmUnicATioNs and Input
<Alan_G> aLf_: I alSo wondEr if wE sHould be processiNg inPut when thE diSpLay Is Off
<alF_> Alan_g: dOn't We nEed to haNdle somE KinD oF INPuT event to wake up (e.g. poWeR BUtTon press)?
<Alan_g> HMM. bUt TOuch evenTs GoiNg to APPs?
<alf_> Alan_G: tuRning off CommunICaTiOns woulD sOlve thAt.
<AlaN_g> aLf_: mayBE not - There wAs a time iNput bYPassed the threaD Pool. I don't remeMBeR THaT ChanGinG.
<alf_> alan_g: yeS, so tURninG off COmMunICatioNs _proPeRLy_ WOuld solve that :)
<alf_> alaN_g: And theN therE is also the issUe of showinG PREvious stAte wHEn WE wake up (because The buFfer contenTS are obsoLete)...
<aLan_g> AnywAy, it does lOOK like codE arOunD paTch IS A cUt down version OF mediAtIngDispLaychanger
<AlaN_g> WHicH, liKe You say is wHat we shoUlD eXpOsE
<daNdradER> any reasOn Why AlL shEll::SuRFace meThods Are vIrTuAL whEreas suRFaCES:SurFaCe Are nOt. BOtH are cOncrETe cLasses.
<aLan_g> dandrAdeR: InsaNiTy
<DandradEr> lol
<alan_g> danDrAder: you're aLsO loOking aT AN old versIon
<dandrader> alan_
 now
<tvoss_> Saviq, okay,  those wor k for  me 
 *  S aviq  add s
<tvoss_> Sav i q, w ill give that packagea spi n, too< Sa viq>tvoss_, pu s h ed<S av iq>  t v os s_, d rop  the.ov erride for  go od  measure
<tv o ss _> Saviq,ack 
<Saviq> /fo od<alf_>  S avi q : ala n_g : the  Displ a yChang er classho l ds the logic f o r  p rope rly reconfiguring th e  display (paus ing/re su m in g ) , s o t hat's what  w e sho u ld expo s e( o r  as imilar interf ace), i.e., I d on't t hi nkd isplay ->con fi g ure () should p ause  resume i nterna l ly
<alf _ > Saviq : alan _g:  ab outw he th erwe sho u ld  pa u se/ resume o rsc hedul e_co m p o s itin g()  ins tead,  it depends o n h ow w e llour d ispla y cl as ses d eal wi th po st ing buffers ifthedisplay i s o ff  (r ig ht no w  not v ery  we ll it s eems)
< a lf_ >S a v iq : alan_g: and whet he r it  actuall y make s  s en s e to dis ab lecomm u n icati onsa nd  input
< alan_g >  a lf _: I al so  wonde rifweshoul d  beproces sing inp ut wh e n the displayi s off
<alf_>a la n _ g: don' t w e need to h andl e  som e ki n dofi nputevent  t o  w a ke up (e.g. power b ut ton pr ess)? 
<alan_g> Hmm . but touc h e vents go ingt oa pps?
<alf_> al an_g:  Turning o f f commun icati ons woul d solve t h a t.
<alan _g>  al f_:  ma y b enot - there w a s  a t im e input  by passedthe  th rea d p oo l. I don' t rememb er  t ha tcha nging . 
<alf_>al an_ g:  ye s, so turnin g off  com mu ni c ati ons _pr o pe r l y_ w ou ld  sol veth at :) 
<al f _>alan_g:  and then  th e re i sal so theissue of show in g previous  s tat e when w e wake u p (because the buffer c o ntentsare  obso lete )...
<ala n_g > Anyw ay, it doe s look  like  c ode a round p at chis  a cut dow n ver sionof  Med iatingD isplayChanger
<ala n _g>  Which, likeyou  say i swha t  w e  sh ou l d e x p ose
<dandrader>  any reaso nw hy  all shell : :Su rf ace met hods ar e vir t ual whe reas surf aces:Surf ac e ar e not . Both are  concret e classes . 
<ala n _g > dan dra der: i ns ani ty
<d andrad e r>lol
< alan_g >dandra der:yo u're als o looking at an old ver sion
< dandr ade r> alan_
 now
<tvoss_>_Saviq, okay,_those work for me
_* Saviq_adds
<tvoss_>_Saviq, will_give_that package a_spin, too
<Saviq> tvoss_,_pushed
<Saviq> tvoss_, drop the.override_for good measure
<tvoss_>_Saviq,_ack
<Saviq> /food
<alf_> Saviq: alan_g: the DisplayChanger class holds the logic for properly reconfiguring the_display_(pausing/resuming), so_that's_what_we should expose (or a_similar interface), i.e., I don't_think display->configure()_should pause resume internally
<alf_> Saviq: alan_g: about whether_we_should pause/resume or_schedule_compositing() instead, it depends on how well our display_classes deal with posting buffers if_the display is_off_(right_now not very well_it seems)
<alf_> Saviq: alan_g: and whether_it actually makes sense to disable_communications and input
<alan_g> alf_: I also wonder_if we should be processing input_when the display is off
<alf_>_alan_g: don't_we need to handle some_kind of input_event to_wake up (e.g._power button press)?
<alan_g> Hmm. but touch_events going to_apps?
<alf_> alan_g: Turning off communications would_solve_that.
<alan_g> alf_: maybe_not_-_there was_a time input_bypassed_the thread_pool._I don't remember that changing.
<alf_> alan_g:_yes,_so turning off communications _properly_ would solve_that :)
<alf_> alan_g: and_then_there is also the_issue of showing previous state_when we wake up (because the_buffer contents_are obsolete)...
<alan_g>_Anyway, it does look like code around patch is a cut_down version of MediatingDisplayChanger
<alan_g> Which, like_you say is what_we should_expose
<dandrader>_any reason why_all_shell::Surface methods_are virtual whereas surfaces:Surface are not. Both_are concrete_classes.
<alan_g> dandrader: insanity
<dandrader> lol
<alan_g> dandrader: you're_also looking at an_old_version
<dandrader> alan_