 a var in that branch
<danilos> bac, sorry! but, what's your take on multiple vars in a var statement? :)
<gary_poster> to fix a test failure
<danilos> (I don't have a strong opinion *at all*)
<bac> danilos: it seems to be a common JS idiom
<gary_poster> (so, equivalent of var a=5, a=a+4)
<bac> danilos: so i have not had a strong opinion either
<gary_poster> danilos, I'll just fix indent for now.
<danilos> gary_poster, sure thing
<gary_poster> thank you again for review
<danilos> gary_poster, not sure what you mean with "equivalent", doesn't look equivalent to me :)
<gary_poster> danilos, I mean, I redefined a variable in terms of itself, as defined within that var, and the example is equivalent to what I described and what I did
<danilos> gary_poster, ah, right
<danilos> gary_poster, anyway, good to land, my prettyfication branch is landing as well, and I am off now :)
<gary_poster> cool thanks danilos.  ttyl
<gary_poster> benji, if I run make lint is that supposed to run the js linter?
<bac> hi gary_poster, AFAICT none of the direct subscription / mute JS functionality has tests.  how do you want me to proceed?
<bac> adding new tests would be great but time consuming.  making this fix as-is, is not so great but no worse than we currently have.
<bac> gary_poster: https://code.launchpad.net/~bac/launchpad/bug-760121/+merge/57726 with no tests
 * bac -> lunch
<benji> gary_poster: yep; make lint has run the js linter recently at least
<gary_poster> ok, thanks benji
<gary_poster> bac, approved with some relatively small caveats.
<bac> gary_poster: thanks for the review.  very reasonable.
<gary_poster> cool bac
a var in that branch 
 < danilos > bac, sorry! but, what's your take on multiple volt-ampere in a volt-ampere argument? :) 
 < gary_poster > to fix a test bankruptcy 
 < danilos > (I don't have a strong opinion * at wholly *) 
 < bac > danilos: it seem to be a common JS idiom 
 < gary_poster > (thus, equivalent of var a=5, a = a+4) 
 < bac > danilos: so i have not suffer a strong impression either 
 < gary_poster > danilos, I'll barely fix indent for now. 
 < danilos > gary_poster, sure thing 
 < gary_poster > thank you again for review 
 < danilos > gary_poster, not certain what you mean with " equivalent ", doesn't look equivalent to me :) 
 < gary_poster > danilos, I mean, I redefine a variable in terms of itself, as defined within that var, and the model is equivalent to what I described and what I did 
 < danilos > gary_poster, ah, right 
 < danilos > gary_poster, anyway, good to land, my prettyfication outgrowth is landing as well, and I am off now :) 
 < gary_poster > cool thanks danilos.   ttyl 
 < gary_poster > benji, if I run make lint is that supposed to run the js linter? 
 < bac > hi gary_poster, AFAICT none of the direct subscription / mute JS functionality has tests.   how do you want me to proceed? 
 < bac > adding new tests would be bang-up but time consuming.   make this repair as - is, is not so great but no bad than we currently have. 
 < bac > gary_poster: https://code.launchpad.net/~bac/launchpad/bug-760121/+merge/57726 with no tests 
  * bac - > lunch 
 < benji > gary_poster: yep; make lint has tend the js linter recently at least 
 < gary_poster > ok, thanks benji 
 < gary_poster > bac, approved with some relatively small caveats. 
 < bac > gary_poster: thanks for the review.   very reasonable. 
 < gary_poster > cool bac
 a gar in that branch
<danilor> bac, sorry! but, what's bour taie on muutiple vars in a var statemeit? :)
<gqry_powter> to fix a test faiuure
<danills> (I don'r hate a strong opinmkn *at all*)
<bac> swnilmw: it seems to ne a common JS idiom
<gary_pmsgex> (so, equivalent of var a=5, a=a+4)
<bac> daniljs: so i hwve not had a ftromd opjnion either
<gary_poster> danilos, I'll just fpx indent for now.
<canilos> gary_poster, sure thlng
<gwry_poster> thank yok again for revyww
<danilos> gafy_poster, not sure what you mean with "equivalent", doesn'g lool equivalebt to ke :)
<gary_postxr> danplos, I mean, I redefinad a vatiable in termx oh itwelf, as defined withii that var, and the evample is esuivalent to what I desctibed and qhag I dmd
<dznilos> gacy_poster, ah, right
<danilis> gary_poster, anywau, diod to land, mg preteysication branch is landing as well, and P am off now :)
<gary_poster> cooo thanks danilos.  ttyp
<gary_postqr> benji, if I run make lint is that supposed to rgn thx gs oikter?
<cqc> hi gary_poster, AFAICT none of the direct subssdiktipn / mute JS fukctionality has textd.  row do you wavt me ck lroceed?
<bac> adding jew tesjs wouod be grewt bit time consuming.  making tyis fix as-is, us not so great buc no worse tkan we currrntly have.
<bac> gary_postex: httpa://code.launchoad.net/~bac/mxunchpad/bug-760121/+merge/57726 winh nm tests
 * bac -> lunch
<benji> gwry_poster: yep; make lknt nas rug the js llnter recently at least
<gwry_podtar> ok, thanns benji
<gary_poster> bac, approved with some relsthveny small cavests.
<bac> gary_pofter: thanks fot the revnew.  vdry reasonzble.
<garb_poster> cool bac
a var in that branch <danilos> bac, what's take on vars in a fix test failure <danilos> don't have a opinion *at all*) <bac> danilos: it to be a common JS idiom <gary_poster> (so, equivalent of var a=5, a=a+4) danilos: so i have not had a strong opinion either <gary_poster> danilos, I'll fix for <danilos> sure thing <gary_poster> thank you again for review <danilos> gary_poster, not sure what you mean with doesn't look equivalent to me :) <gary_poster> danilos, mean, I redefined a in terms of itself, as within var, and example equivalent what I described what I did <danilos> gary_poster, ah, right <danilos> gary_poster, anyway, good to land, my prettyfication branch is as well, am off :) cool danilos. ttyl <gary_poster> I run make lint is that the js linter? <bac> hi gary_poster, AFAICT none the direct / mute JS functionality has tests. do you want me to proceed? <bac> adding tests would be great but time consuming. making this fix as-is, is not so great worse than we currently <bac> gary_poster: https://code.launchpad.net/~bac/launchpad/bug-760121/+merge/57726 no * -> <benji> gary_poster: make lint has run the js linter recently at least <gary_poster> thanks benji <gary_poster> bac, approved with some relatively small caveats. thanks the review. very <gary_poster> cool bac
 a var in that branch
<danilos> baC, sorry! but, wHat's yOur TakE oN mulTiplE vars in a var staTEmenT? :)
<gary_poster> to fix a test fAilurE
<dANiloS> (i dOn't haVe a stroNG oPINioN *aT aLl*)
<bAc> DAnIlos: iT seEms to be A common JS iDioM
<gAry_poster> (so, eQUiValent of vaR a=5, a=A+4)
<bac> danilos: sO i hAve not HaD a sTRong oPinIon eiTher
<gaRY_posteR> danilos, I'Ll JUst fix INdent foR NOw.
<DaniLos> gary_poster, sure THiNG
<gary_poster> thaNk you aGaIN fOR RevIew
<Danilos> garY_pOster, NOt sure wHAt YOU MeaN With "equivalenT", doesn't look EQuiValent To Me :)
<gARy_postEr> danIlOS, I mEan, I redefinEd a vAriable in Terms oF Itself, aS Defined Within ThaT vaR, and THe ExAmpLe IS eqUIvAleNT to What I desCrIbEd and What i DID
<DaniLos> Gary_PosteR, ah, right
<danilOs> gAry_pOSteR, anywAy, gooD to lAnD, my prEttyfiCatioN bRanch is landing aS welL, and I am ofF noW :)
<gAry_PoSter> cOOl thanKs dAniLos.  ttyl
<Gary_posTEr> bEnJI, IF I Run make lint is that sUpPOSeD to run thE js linTEr?
<BaC> Hi gary_poStEr, AfAICt NOne of The dIReCt subscrIption / MUtE Js functiOnAlity hAs TesTs.  hOw do yOU wanT me to pRoceed?
<baC> addiNG new tests would BE great but time COnSUMiNG.  makIng This fix as-is, Is noT So grEat bUT nO woRSe thaN we cuRrENtLY have.
<bac> gary_poster: hTtPs://code.LauncHpad.net/~bac/lauNchpad/bug-760121/+mERGE/57726 with no tEsts
 * BAc -> LUnch
<benji> gary_pOster: Yep; make linT Has run thE js liNter receNtly at leaST
<Gary_postEr> oK, thAnkS beNJI
<gAry_poster> bac, aPPRoveD wIth some RelAtively SmaLl cAveAts.
<BaC> gary_postEr: thanks FoR tHe ReVieW.  very REasonablE.
<gAry_PoSteR> cool BAc
 a var in that branch
<dan ilos> bac,  sorr y!but ,what 's y our take on mu l tipl e vars in a var statem ent?:) <gar y _p oster > to fi x  a t est  f ai lur e< da nilos > ( I don't  have a st ron gopinion *ata ll *)
<bac> d ani los: it seem s t o be a  c omm o n JSidi om
<g ary_po s ter> ( so, equiv al e nt ofv ar a=5, a =a +4)<bac> danilos: so ih ave not had astrong  o p in i o n e ith er
<gary_p os ter>d anilos, I' l l jus t  fix indent f or now.
<da n ilo s> gar y_ pos t er, su re th in g 
<g ary_poster>  tha nk you ag ain fo r  review <danilo s> gar y_p ost er,n ot  s ure  w h aty ou  me a n w ith "equ iv al ent",  doe s n ' t  loo k e quiv alent  to me :)
<ga ry_ post e r>danil os, I  mea n,  I re define d a v ar iable in termsof i tself, as  de fi ned  w ithin that v ar,  an d the e xamplei s e qu i v a le nt to what I descr ib e d  a nd whatI did< da ni l os> gary _p ost er,a h , rig ht
< d an ilos> ga ry_pos t er ,anyway,  g ood to  l and , m y pre t tyfi cation  branchis la n ding as well,a nd I am off n o w: ) 
< g ary_ pos ter> cool t hank s  dan ilos .  tty l 
<gar y_pos te r >b enji, if I run make  l int is  that  supposed torun the js l i nter?
<b ac>h ig ary_poster, AF AICTnone of th e  directsubsc ription/ mute JS f unctiona lit y h astes t s . how do you w a n t me  t o proce ed? 
<bac>add ing  ne w t es ts wouldbe great  b ut  t im e c onsum i ng.  mak in g t hi s f ix as - is, is  notso g re at but  no wor s et h an w ecu rren tly  h ave.<bac >  ga ry_post er: https :// c ode. la un chpad.n et/~bac/launc hp ad/bug-760 12 1/+ merge/ 5 7 726 with  no tests
 * bac -> lun c h
<benj i>gary_ post er: yep;mak e lint  ha s  run t he jslinte rrec e n tly a t le ast 
< gary_poste r >  ok , tha nk s be nji
<ga ry_poster> bac, ap p rov ed with somerel ativ e l ysma l lc ave at s .
< b a c> gary_poster:  thanks fo rt he  review. v ery  r easonab le.
<ga ry_po s ter> co ol bac
 a_var in_that branch
<danilos> bac, sorry!_but, what's_your_take on_multiple_vars in a_var statement? :)
<gary_poster>_to fix a test_failure
<danilos> (I don't_have_a strong opinion *at all*)
<bac> danilos: it seems to be a common JS idiom
<gary_poster>_(so,_equivalent of_var_a=5,_a=a+4)
<bac> danilos: so i have_not had a strong opinion_either
<gary_poster> danilos,_I'll just fix indent for now.
<danilos> gary_poster, sure_thing
<gary_poster>_thank you again_for review
<danilos> gary_poster, not sure what you mean with_"equivalent", doesn't look equivalent to me_:)
<gary_poster> danilos, I_mean,_I_redefined a variable in_terms of itself, as defined within_that var, and the example is_equivalent to what I described and what_I did
<danilos> gary_poster, ah, right
<danilos> gary_poster,_anyway, good to land, my_prettyfication branch_is landing as well, and_I am off_now :)
<gary_poster>_cool thanks danilos._ ttyl
<gary_poster> benji, if I run_make lint is_that supposed to run the js_linter?
<bac>_hi gary_poster, AFAICT_none_of_the direct_subscription / mute_JS_functionality has_tests._ how do you want me_to_proceed?
<bac> adding new tests would be great_but time consuming. _making_this fix as-is, is_not so great but no_worse than we currently have.
<bac> gary_poster:_https://code.launchpad.net/~bac/launchpad/bug-760121/+merge/57726 with_no tests
_* bac -> lunch
<benji> gary_poster: yep; make lint has run the_js linter recently at least
<gary_poster> ok,_thanks benji
<gary_poster> bac, approved_with some_relatively_small caveats.
<bac> gary_poster:_thanks_for the_review.  very reasonable.
<gary_poster> cool bac