title: New to jQuery, simple popup window script, any problems?
body: <p>Still a little "gunshy" about jQuery. Does this simple popup window script look okay? Is my jQuery logic right?</p>
  
  <p>I have a few questions in the code comments that I'm curious about.</p>
  
  <pre><code>$( document ).ready( function()
  {
      $( "a[target='popup']" ).click( function( event )
      {
          var $href = $( this ).attr( 'href' ); // should I use "this.href"?
          var $name = $( this ).attr( 'target' ); // does the window name matter?
          var $config = 'width=590, height=590, top=20, left=60, scrollbars=1';
          var $popup = window.open( $href, $name, $config );
  
          if ( window.focus ) // is this even necessary?
                              // any other conditions I should check instead?
          {
              $popup.focus();
          }
          event.preventDefault(); // should this be above $popup.focus()?
      });
  });
  </code></pre>
  
  <p>It seems to work, but since this script will be important for acquiring RSS subscribers on my site, I thought I'd make sure.</p>